Fri, 07 Feb 2014 21:43:33 +0100
8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
Summary: When the overrides deprecated method warning is being reported, need to do that in the lint context of the method.
Reviewed-by: vromero
duke@1 | 1 | /* |
jfranck@2250 | 2 | * Copyright (c) 1999, 2014, Oracle and/or its affiliates. All rights reserved. |
duke@1 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@1 | 4 | * |
duke@1 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@1 | 6 | * under the terms of the GNU General Public License version 2 only, as |
ohair@554 | 7 | * published by the Free Software Foundation. Oracle designates this |
duke@1 | 8 | * particular file as subject to the "Classpath" exception as provided |
ohair@554 | 9 | * by Oracle in the LICENSE file that accompanied this code. |
duke@1 | 10 | * |
duke@1 | 11 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@1 | 12 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@1 | 13 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@1 | 14 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@1 | 15 | * accompanied this code). |
duke@1 | 16 | * |
duke@1 | 17 | * You should have received a copy of the GNU General Public License version |
duke@1 | 18 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@1 | 19 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@1 | 20 | * |
ohair@554 | 21 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
ohair@554 | 22 | * or visit www.oracle.com if you need additional information or have any |
ohair@554 | 23 | * questions. |
duke@1 | 24 | */ |
duke@1 | 25 | |
duke@1 | 26 | package com.sun.tools.javac.comp; |
duke@1 | 27 | |
duke@1 | 28 | import java.util.*; |
jjg@1521 | 29 | |
ohrstrom@1384 | 30 | import javax.tools.JavaFileManager; |
duke@1 | 31 | |
duke@1 | 32 | import com.sun.tools.javac.code.*; |
jlahoda@2111 | 33 | import com.sun.tools.javac.code.Attribute.Compound; |
duke@1 | 34 | import com.sun.tools.javac.jvm.*; |
duke@1 | 35 | import com.sun.tools.javac.tree.*; |
duke@1 | 36 | import com.sun.tools.javac.util.*; |
duke@1 | 37 | import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition; |
duke@1 | 38 | import com.sun.tools.javac.util.List; |
duke@1 | 39 | |
duke@1 | 40 | import com.sun.tools.javac.code.Lint; |
duke@1 | 41 | import com.sun.tools.javac.code.Lint.LintCategory; |
duke@1 | 42 | import com.sun.tools.javac.code.Type.*; |
duke@1 | 43 | import com.sun.tools.javac.code.Symbol.*; |
mcimadamore@1347 | 44 | import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext; |
mcimadamore@1337 | 45 | import com.sun.tools.javac.comp.Infer.InferenceContext; |
mcimadamore@1550 | 46 | import com.sun.tools.javac.comp.Infer.FreeTypeListener; |
mcimadamore@1510 | 47 | import com.sun.tools.javac.tree.JCTree.*; |
mcimadamore@1510 | 48 | import com.sun.tools.javac.tree.JCTree.JCPolyExpression.*; |
duke@1 | 49 | |
duke@1 | 50 | import static com.sun.tools.javac.code.Flags.*; |
jjg@1127 | 51 | import static com.sun.tools.javac.code.Flags.ANNOTATION; |
jjg@1127 | 52 | import static com.sun.tools.javac.code.Flags.SYNCHRONIZED; |
duke@1 | 53 | import static com.sun.tools.javac.code.Kinds.*; |
jjg@1374 | 54 | import static com.sun.tools.javac.code.TypeTag.*; |
jjg@1374 | 55 | import static com.sun.tools.javac.code.TypeTag.WILDCARD; |
duke@1 | 56 | |
jjg@1127 | 57 | import static com.sun.tools.javac.tree.JCTree.Tag.*; |
jjg@700 | 58 | |
duke@1 | 59 | /** Type checking helper class for the attribution phase. |
duke@1 | 60 | * |
jjg@581 | 61 | * <p><b>This is NOT part of any supported API. |
jjg@581 | 62 | * If you write code that depends on this, you do so at your own risk. |
duke@1 | 63 | * This code and its internal interfaces are subject to change or |
duke@1 | 64 | * deletion without notice.</b> |
duke@1 | 65 | */ |
duke@1 | 66 | public class Check { |
duke@1 | 67 | protected static final Context.Key<Check> checkKey = |
duke@1 | 68 | new Context.Key<Check>(); |
duke@1 | 69 | |
jjg@113 | 70 | private final Names names; |
duke@1 | 71 | private final Log log; |
mcimadamore@1219 | 72 | private final Resolve rs; |
duke@1 | 73 | private final Symtab syms; |
mcimadamore@690 | 74 | private final Enter enter; |
mcimadamore@1347 | 75 | private final DeferredAttr deferredAttr; |
duke@1 | 76 | private final Infer infer; |
duke@1 | 77 | private final Types types; |
mcimadamore@89 | 78 | private final JCDiagnostic.Factory diags; |
mcimadamore@359 | 79 | private boolean warnOnSyntheticConflicts; |
jjg@576 | 80 | private boolean suppressAbortOnBadClassFile; |
mcimadamore@852 | 81 | private boolean enableSunApiLintControl; |
duke@1 | 82 | private final TreeInfo treeinfo; |
ohrstrom@1384 | 83 | private final JavaFileManager fileManager; |
jjg@1569 | 84 | private final Profile profile; |
vromero@2390 | 85 | private final boolean warnOnAccessToSensitiveMembers; |
duke@1 | 86 | |
duke@1 | 87 | // The set of lint options currently in effect. It is initialized |
duke@1 | 88 | // from the context, and then is set/reset as needed by Attr as it |
duke@1 | 89 | // visits all the various parts of the trees during attribution. |
duke@1 | 90 | private Lint lint; |
duke@1 | 91 | |
mcimadamore@795 | 92 | // The method being analyzed in Attr - it is set/reset as needed by |
mcimadamore@795 | 93 | // Attr as it visits new method declarations. |
mcimadamore@795 | 94 | private MethodSymbol method; |
mcimadamore@795 | 95 | |
duke@1 | 96 | public static Check instance(Context context) { |
duke@1 | 97 | Check instance = context.get(checkKey); |
duke@1 | 98 | if (instance == null) |
duke@1 | 99 | instance = new Check(context); |
duke@1 | 100 | return instance; |
duke@1 | 101 | } |
duke@1 | 102 | |
duke@1 | 103 | protected Check(Context context) { |
duke@1 | 104 | context.put(checkKey, this); |
duke@1 | 105 | |
jjg@113 | 106 | names = Names.instance(context); |
jjg@1521 | 107 | dfltTargetMeta = new Name[] { names.PACKAGE, names.TYPE, |
jjg@1521 | 108 | names.FIELD, names.METHOD, names.CONSTRUCTOR, |
jjg@1521 | 109 | names.ANNOTATION_TYPE, names.LOCAL_VARIABLE, names.PARAMETER}; |
duke@1 | 110 | log = Log.instance(context); |
mcimadamore@1219 | 111 | rs = Resolve.instance(context); |
duke@1 | 112 | syms = Symtab.instance(context); |
mcimadamore@690 | 113 | enter = Enter.instance(context); |
mcimadamore@1347 | 114 | deferredAttr = DeferredAttr.instance(context); |
duke@1 | 115 | infer = Infer.instance(context); |
jjg@1569 | 116 | types = Types.instance(context); |
mcimadamore@89 | 117 | diags = JCDiagnostic.Factory.instance(context); |
duke@1 | 118 | Options options = Options.instance(context); |
duke@1 | 119 | lint = Lint.instance(context); |
duke@1 | 120 | treeinfo = TreeInfo.instance(context); |
ohrstrom@1384 | 121 | fileManager = context.get(JavaFileManager.class); |
duke@1 | 122 | |
duke@1 | 123 | Source source = Source.instance(context); |
duke@1 | 124 | allowGenerics = source.allowGenerics(); |
mcimadamore@1219 | 125 | allowVarargs = source.allowVarargs(); |
duke@1 | 126 | allowAnnotations = source.allowAnnotations(); |
jjg@398 | 127 | allowCovariantReturns = source.allowCovariantReturns(); |
mcimadamore@795 | 128 | allowSimplifiedVarargs = source.allowSimplifiedVarargs(); |
mcimadamore@1393 | 129 | allowDefaultMethods = source.allowDefaultMethods(); |
mcimadamore@1415 | 130 | allowStrictMethodClashCheck = source.allowStrictMethodClashCheck(); |
jjg@1157 | 131 | complexInference = options.isSet("complexinference"); |
jjg@700 | 132 | warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts"); |
jjg@700 | 133 | suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile"); |
mcimadamore@852 | 134 | enableSunApiLintControl = options.isSet("enableSunApiLintControl"); |
vromero@2390 | 135 | warnOnAccessToSensitiveMembers = options.isSet("warnOnAccessToSensitiveMembers"); |
duke@1 | 136 | |
jjg@398 | 137 | Target target = Target.instance(context); |
jjg@398 | 138 | syntheticNameChar = target.syntheticNameChar(); |
jjg@398 | 139 | |
jjg@1569 | 140 | profile = Profile.instance(context); |
jjg@1569 | 141 | |
duke@1 | 142 | boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION); |
duke@1 | 143 | boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED); |
jjg@377 | 144 | boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI); |
jjg@60 | 145 | boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings(); |
duke@1 | 146 | |
jjg@60 | 147 | deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated, |
jjg@612 | 148 | enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION); |
jjg@60 | 149 | uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked, |
jjg@612 | 150 | enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED); |
jjg@377 | 151 | sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi, |
jjg@612 | 152 | enforceMandatoryWarnings, "sunapi", null); |
mcimadamore@852 | 153 | |
jlahoda@2028 | 154 | deferredLintHandler = DeferredLintHandler.instance(context); |
duke@1 | 155 | } |
duke@1 | 156 | |
duke@1 | 157 | /** Switch: generics enabled? |
duke@1 | 158 | */ |
duke@1 | 159 | boolean allowGenerics; |
duke@1 | 160 | |
mcimadamore@1219 | 161 | /** Switch: varargs enabled? |
mcimadamore@1219 | 162 | */ |
mcimadamore@1219 | 163 | boolean allowVarargs; |
mcimadamore@1219 | 164 | |
duke@1 | 165 | /** Switch: annotations enabled? |
duke@1 | 166 | */ |
duke@1 | 167 | boolean allowAnnotations; |
duke@1 | 168 | |
jjg@398 | 169 | /** Switch: covariant returns enabled? |
jjg@398 | 170 | */ |
jjg@398 | 171 | boolean allowCovariantReturns; |
jjg@398 | 172 | |
mcimadamore@795 | 173 | /** Switch: simplified varargs enabled? |
mcimadamore@795 | 174 | */ |
mcimadamore@795 | 175 | boolean allowSimplifiedVarargs; |
mcimadamore@795 | 176 | |
mcimadamore@1393 | 177 | /** Switch: default methods enabled? |
mcimadamore@1393 | 178 | */ |
mcimadamore@1393 | 179 | boolean allowDefaultMethods; |
mcimadamore@1393 | 180 | |
mcimadamore@1393 | 181 | /** Switch: should unrelated return types trigger a method clash? |
mcimadamore@1393 | 182 | */ |
mcimadamore@1393 | 183 | boolean allowStrictMethodClashCheck; |
mcimadamore@1393 | 184 | |
duke@1 | 185 | /** Switch: -complexinference option set? |
duke@1 | 186 | */ |
duke@1 | 187 | boolean complexInference; |
duke@1 | 188 | |
jjg@398 | 189 | /** Character for synthetic names |
jjg@398 | 190 | */ |
jjg@398 | 191 | char syntheticNameChar; |
jjg@398 | 192 | |
duke@1 | 193 | /** A table mapping flat names of all compiled classes in this run to their |
duke@1 | 194 | * symbols; maintained from outside. |
duke@1 | 195 | */ |
duke@1 | 196 | public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>(); |
duke@1 | 197 | |
duke@1 | 198 | /** A handler for messages about deprecated usage. |
duke@1 | 199 | */ |
duke@1 | 200 | private MandatoryWarningHandler deprecationHandler; |
duke@1 | 201 | |
duke@1 | 202 | /** A handler for messages about unchecked or unsafe usage. |
duke@1 | 203 | */ |
duke@1 | 204 | private MandatoryWarningHandler uncheckedHandler; |
duke@1 | 205 | |
jjg@582 | 206 | /** A handler for messages about using proprietary API. |
jjg@377 | 207 | */ |
jjg@377 | 208 | private MandatoryWarningHandler sunApiHandler; |
duke@1 | 209 | |
mcimadamore@852 | 210 | /** A handler for deferred lint warnings. |
mcimadamore@852 | 211 | */ |
mcimadamore@852 | 212 | private DeferredLintHandler deferredLintHandler; |
mcimadamore@852 | 213 | |
duke@1 | 214 | /* ************************************************************************* |
duke@1 | 215 | * Errors and Warnings |
duke@1 | 216 | **************************************************************************/ |
duke@1 | 217 | |
duke@1 | 218 | Lint setLint(Lint newLint) { |
duke@1 | 219 | Lint prev = lint; |
duke@1 | 220 | lint = newLint; |
duke@1 | 221 | return prev; |
duke@1 | 222 | } |
duke@1 | 223 | |
mcimadamore@795 | 224 | MethodSymbol setMethod(MethodSymbol newMethod) { |
mcimadamore@795 | 225 | MethodSymbol prev = method; |
mcimadamore@795 | 226 | method = newMethod; |
mcimadamore@795 | 227 | return prev; |
mcimadamore@795 | 228 | } |
mcimadamore@795 | 229 | |
duke@1 | 230 | /** Warn about deprecated symbol. |
duke@1 | 231 | * @param pos Position to be used for error reporting. |
duke@1 | 232 | * @param sym The deprecated symbol. |
duke@1 | 233 | */ |
duke@1 | 234 | void warnDeprecated(DiagnosticPosition pos, Symbol sym) { |
duke@1 | 235 | if (!lint.isSuppressed(LintCategory.DEPRECATION)) |
duke@1 | 236 | deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location()); |
duke@1 | 237 | } |
duke@1 | 238 | |
duke@1 | 239 | /** Warn about unchecked operation. |
duke@1 | 240 | * @param pos Position to be used for error reporting. |
duke@1 | 241 | * @param msg A string describing the problem. |
duke@1 | 242 | */ |
duke@1 | 243 | public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) { |
duke@1 | 244 | if (!lint.isSuppressed(LintCategory.UNCHECKED)) |
duke@1 | 245 | uncheckedHandler.report(pos, msg, args); |
duke@1 | 246 | } |
duke@1 | 247 | |
mcimadamore@580 | 248 | /** Warn about unsafe vararg method decl. |
mcimadamore@580 | 249 | * @param pos Position to be used for error reporting. |
mcimadamore@580 | 250 | */ |
mcimadamore@795 | 251 | void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) { |
mcimadamore@795 | 252 | if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs) |
mcimadamore@795 | 253 | log.warning(LintCategory.VARARGS, pos, key, args); |
mcimadamore@580 | 254 | } |
mcimadamore@580 | 255 | |
jjg@582 | 256 | /** Warn about using proprietary API. |
jjg@377 | 257 | * @param pos Position to be used for error reporting. |
jjg@377 | 258 | * @param msg A string describing the problem. |
jjg@377 | 259 | */ |
jjg@377 | 260 | public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) { |
jjg@377 | 261 | if (!lint.isSuppressed(LintCategory.SUNAPI)) |
jjg@377 | 262 | sunApiHandler.report(pos, msg, args); |
jjg@377 | 263 | } |
jjg@377 | 264 | |
jjg@505 | 265 | public void warnStatic(DiagnosticPosition pos, String msg, Object... args) { |
jjg@505 | 266 | if (lint.isEnabled(LintCategory.STATIC)) |
jjg@612 | 267 | log.warning(LintCategory.STATIC, pos, msg, args); |
jjg@505 | 268 | } |
jjg@505 | 269 | |
duke@1 | 270 | /** |
duke@1 | 271 | * Report any deferred diagnostics. |
duke@1 | 272 | */ |
duke@1 | 273 | public void reportDeferredDiagnostics() { |
duke@1 | 274 | deprecationHandler.reportDeferredDiagnostic(); |
duke@1 | 275 | uncheckedHandler.reportDeferredDiagnostic(); |
jjg@377 | 276 | sunApiHandler.reportDeferredDiagnostic(); |
duke@1 | 277 | } |
duke@1 | 278 | |
duke@1 | 279 | |
duke@1 | 280 | /** Report a failure to complete a class. |
duke@1 | 281 | * @param pos Position to be used for error reporting. |
duke@1 | 282 | * @param ex The failure to report. |
duke@1 | 283 | */ |
duke@1 | 284 | public Type completionError(DiagnosticPosition pos, CompletionFailure ex) { |
mcimadamore@1613 | 285 | log.error(JCDiagnostic.DiagnosticFlag.NON_DEFERRABLE, pos, "cant.access", ex.sym, ex.getDetailValue()); |
jjg@576 | 286 | if (ex instanceof ClassReader.BadClassFile |
jjg@576 | 287 | && !suppressAbortOnBadClassFile) throw new Abort(); |
duke@1 | 288 | else return syms.errType; |
duke@1 | 289 | } |
duke@1 | 290 | |
duke@1 | 291 | /** Report an error that wrong type tag was found. |
duke@1 | 292 | * @param pos Position to be used for error reporting. |
duke@1 | 293 | * @param required An internationalized string describing the type tag |
duke@1 | 294 | * required. |
duke@1 | 295 | * @param found The type that was found. |
duke@1 | 296 | */ |
duke@1 | 297 | Type typeTagError(DiagnosticPosition pos, Object required, Object found) { |
jrose@267 | 298 | // this error used to be raised by the parser, |
jrose@267 | 299 | // but has been delayed to this point: |
jjg@1374 | 300 | if (found instanceof Type && ((Type)found).hasTag(VOID)) { |
jrose@267 | 301 | log.error(pos, "illegal.start.of.type"); |
jrose@267 | 302 | return syms.errType; |
jrose@267 | 303 | } |
duke@1 | 304 | log.error(pos, "type.found.req", found, required); |
jjg@110 | 305 | return types.createErrorType(found instanceof Type ? (Type)found : syms.errType); |
duke@1 | 306 | } |
duke@1 | 307 | |
duke@1 | 308 | /** Report an error that symbol cannot be referenced before super |
duke@1 | 309 | * has been called. |
duke@1 | 310 | * @param pos Position to be used for error reporting. |
duke@1 | 311 | * @param sym The referenced symbol. |
duke@1 | 312 | */ |
duke@1 | 313 | void earlyRefError(DiagnosticPosition pos, Symbol sym) { |
duke@1 | 314 | log.error(pos, "cant.ref.before.ctor.called", sym); |
duke@1 | 315 | } |
duke@1 | 316 | |
duke@1 | 317 | /** Report duplicate declaration error. |
duke@1 | 318 | */ |
duke@1 | 319 | void duplicateError(DiagnosticPosition pos, Symbol sym) { |
duke@1 | 320 | if (!sym.type.isErroneous()) { |
mcimadamore@1085 | 321 | Symbol location = sym.location(); |
mcimadamore@1085 | 322 | if (location.kind == MTH && |
mcimadamore@1085 | 323 | ((MethodSymbol)location).isStaticOrInstanceInit()) { |
mcimadamore@1085 | 324 | log.error(pos, "already.defined.in.clinit", kindName(sym), sym, |
mcimadamore@1085 | 325 | kindName(sym.location()), kindName(sym.location().enclClass()), |
mcimadamore@1085 | 326 | sym.location().enclClass()); |
mcimadamore@1085 | 327 | } else { |
mcimadamore@1085 | 328 | log.error(pos, "already.defined", kindName(sym), sym, |
mcimadamore@1085 | 329 | kindName(sym.location()), sym.location()); |
mcimadamore@1085 | 330 | } |
duke@1 | 331 | } |
duke@1 | 332 | } |
duke@1 | 333 | |
duke@1 | 334 | /** Report array/varargs duplicate declaration |
duke@1 | 335 | */ |
duke@1 | 336 | void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) { |
duke@1 | 337 | if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) { |
duke@1 | 338 | log.error(pos, "array.and.varargs", sym1, sym2, sym2.location()); |
duke@1 | 339 | } |
duke@1 | 340 | } |
duke@1 | 341 | |
duke@1 | 342 | /* ************************************************************************ |
duke@1 | 343 | * duplicate declaration checking |
duke@1 | 344 | *************************************************************************/ |
duke@1 | 345 | |
duke@1 | 346 | /** Check that variable does not hide variable with same name in |
duke@1 | 347 | * immediately enclosing local scope. |
duke@1 | 348 | * @param pos Position for error reporting. |
duke@1 | 349 | * @param v The symbol. |
duke@1 | 350 | * @param s The scope. |
duke@1 | 351 | */ |
duke@1 | 352 | void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) { |
duke@1 | 353 | if (s.next != null) { |
duke@1 | 354 | for (Scope.Entry e = s.next.lookup(v.name); |
duke@1 | 355 | e.scope != null && e.sym.owner == v.owner; |
duke@1 | 356 | e = e.next()) { |
duke@1 | 357 | if (e.sym.kind == VAR && |
duke@1 | 358 | (e.sym.owner.kind & (VAR | MTH)) != 0 && |
duke@1 | 359 | v.name != names.error) { |
duke@1 | 360 | duplicateError(pos, e.sym); |
duke@1 | 361 | return; |
duke@1 | 362 | } |
duke@1 | 363 | } |
duke@1 | 364 | } |
duke@1 | 365 | } |
duke@1 | 366 | |
duke@1 | 367 | /** Check that a class or interface does not hide a class or |
duke@1 | 368 | * interface with same name in immediately enclosing local scope. |
duke@1 | 369 | * @param pos Position for error reporting. |
duke@1 | 370 | * @param c The symbol. |
duke@1 | 371 | * @param s The scope. |
duke@1 | 372 | */ |
duke@1 | 373 | void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) { |
duke@1 | 374 | if (s.next != null) { |
duke@1 | 375 | for (Scope.Entry e = s.next.lookup(c.name); |
duke@1 | 376 | e.scope != null && e.sym.owner == c.owner; |
duke@1 | 377 | e = e.next()) { |
jjg@1374 | 378 | if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) && |
duke@1 | 379 | (e.sym.owner.kind & (VAR | MTH)) != 0 && |
duke@1 | 380 | c.name != names.error) { |
duke@1 | 381 | duplicateError(pos, e.sym); |
duke@1 | 382 | return; |
duke@1 | 383 | } |
duke@1 | 384 | } |
duke@1 | 385 | } |
duke@1 | 386 | } |
duke@1 | 387 | |
duke@1 | 388 | /** Check that class does not have the same name as one of |
duke@1 | 389 | * its enclosing classes, or as a class defined in its enclosing scope. |
duke@1 | 390 | * return true if class is unique in its enclosing scope. |
duke@1 | 391 | * @param pos Position for error reporting. |
duke@1 | 392 | * @param name The class name. |
duke@1 | 393 | * @param s The enclosing scope. |
duke@1 | 394 | */ |
duke@1 | 395 | boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) { |
duke@1 | 396 | for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) { |
duke@1 | 397 | if (e.sym.kind == TYP && e.sym.name != names.error) { |
duke@1 | 398 | duplicateError(pos, e.sym); |
duke@1 | 399 | return false; |
duke@1 | 400 | } |
duke@1 | 401 | } |
duke@1 | 402 | for (Symbol sym = s.owner; sym != null; sym = sym.owner) { |
duke@1 | 403 | if (sym.kind == TYP && sym.name == name && sym.name != names.error) { |
duke@1 | 404 | duplicateError(pos, sym); |
duke@1 | 405 | return true; |
duke@1 | 406 | } |
duke@1 | 407 | } |
duke@1 | 408 | return true; |
duke@1 | 409 | } |
duke@1 | 410 | |
duke@1 | 411 | /* ************************************************************************* |
duke@1 | 412 | * Class name generation |
duke@1 | 413 | **************************************************************************/ |
duke@1 | 414 | |
duke@1 | 415 | /** Return name of local class. |
jjg@1358 | 416 | * This is of the form {@code <enclClass> $ n <classname> } |
duke@1 | 417 | * where |
duke@1 | 418 | * enclClass is the flat name of the enclosing class, |
duke@1 | 419 | * classname is the simple name of the local class |
duke@1 | 420 | */ |
duke@1 | 421 | Name localClassName(ClassSymbol c) { |
duke@1 | 422 | for (int i=1; ; i++) { |
duke@1 | 423 | Name flatname = names. |
duke@1 | 424 | fromString("" + c.owner.enclClass().flatname + |
jjg@398 | 425 | syntheticNameChar + i + |
duke@1 | 426 | c.name); |
duke@1 | 427 | if (compiled.get(flatname) == null) return flatname; |
duke@1 | 428 | } |
duke@1 | 429 | } |
duke@1 | 430 | |
duke@1 | 431 | /* ************************************************************************* |
duke@1 | 432 | * Type Checking |
duke@1 | 433 | **************************************************************************/ |
duke@1 | 434 | |
mcimadamore@1238 | 435 | /** |
mcimadamore@1238 | 436 | * A check context is an object that can be used to perform compatibility |
mcimadamore@1238 | 437 | * checks - depending on the check context, meaning of 'compatibility' might |
mcimadamore@1238 | 438 | * vary significantly. |
mcimadamore@1238 | 439 | */ |
mcimadamore@1348 | 440 | public interface CheckContext { |
mcimadamore@1238 | 441 | /** |
mcimadamore@1238 | 442 | * Is type 'found' compatible with type 'req' in given context |
mcimadamore@1238 | 443 | */ |
mcimadamore@1238 | 444 | boolean compatible(Type found, Type req, Warner warn); |
mcimadamore@1238 | 445 | /** |
mcimadamore@1238 | 446 | * Report a check error |
mcimadamore@1238 | 447 | */ |
mcimadamore@1296 | 448 | void report(DiagnosticPosition pos, JCDiagnostic details); |
mcimadamore@1238 | 449 | /** |
mcimadamore@1238 | 450 | * Obtain a warner for this check context |
mcimadamore@1238 | 451 | */ |
mcimadamore@1238 | 452 | public Warner checkWarner(DiagnosticPosition pos, Type found, Type req); |
mcimadamore@1337 | 453 | |
mcimadamore@1337 | 454 | public Infer.InferenceContext inferenceContext(); |
mcimadamore@1347 | 455 | |
mcimadamore@1347 | 456 | public DeferredAttr.DeferredAttrContext deferredAttrContext(); |
mcimadamore@1238 | 457 | } |
mcimadamore@1238 | 458 | |
mcimadamore@1238 | 459 | /** |
mcimadamore@1238 | 460 | * This class represent a check context that is nested within another check |
mcimadamore@1238 | 461 | * context - useful to check sub-expressions. The default behavior simply |
mcimadamore@1238 | 462 | * redirects all method calls to the enclosing check context leveraging |
mcimadamore@1238 | 463 | * the forwarding pattern. |
mcimadamore@1238 | 464 | */ |
mcimadamore@1238 | 465 | static class NestedCheckContext implements CheckContext { |
mcimadamore@1238 | 466 | CheckContext enclosingContext; |
mcimadamore@1238 | 467 | |
mcimadamore@1238 | 468 | NestedCheckContext(CheckContext enclosingContext) { |
mcimadamore@1238 | 469 | this.enclosingContext = enclosingContext; |
mcimadamore@1238 | 470 | } |
mcimadamore@1238 | 471 | |
mcimadamore@1238 | 472 | public boolean compatible(Type found, Type req, Warner warn) { |
mcimadamore@1238 | 473 | return enclosingContext.compatible(found, req, warn); |
mcimadamore@1238 | 474 | } |
mcimadamore@1238 | 475 | |
mcimadamore@1296 | 476 | public void report(DiagnosticPosition pos, JCDiagnostic details) { |
mcimadamore@1296 | 477 | enclosingContext.report(pos, details); |
mcimadamore@1238 | 478 | } |
mcimadamore@1238 | 479 | |
mcimadamore@1238 | 480 | public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) { |
mcimadamore@1238 | 481 | return enclosingContext.checkWarner(pos, found, req); |
mcimadamore@1238 | 482 | } |
mcimadamore@1337 | 483 | |
mcimadamore@1337 | 484 | public Infer.InferenceContext inferenceContext() { |
mcimadamore@1337 | 485 | return enclosingContext.inferenceContext(); |
mcimadamore@1337 | 486 | } |
mcimadamore@1347 | 487 | |
mcimadamore@1347 | 488 | public DeferredAttrContext deferredAttrContext() { |
mcimadamore@1347 | 489 | return enclosingContext.deferredAttrContext(); |
mcimadamore@1347 | 490 | } |
mcimadamore@1238 | 491 | } |
mcimadamore@1238 | 492 | |
mcimadamore@1238 | 493 | /** |
mcimadamore@1238 | 494 | * Check context to be used when evaluating assignment/return statements |
mcimadamore@1238 | 495 | */ |
mcimadamore@1238 | 496 | CheckContext basicHandler = new CheckContext() { |
mcimadamore@1296 | 497 | public void report(DiagnosticPosition pos, JCDiagnostic details) { |
mcimadamore@1296 | 498 | log.error(pos, "prob.found.req", details); |
mcimadamore@1238 | 499 | } |
mcimadamore@1238 | 500 | public boolean compatible(Type found, Type req, Warner warn) { |
mcimadamore@1238 | 501 | return types.isAssignable(found, req, warn); |
mcimadamore@1238 | 502 | } |
mcimadamore@1238 | 503 | |
mcimadamore@1238 | 504 | public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) { |
mcimadamore@1238 | 505 | return convertWarner(pos, found, req); |
mcimadamore@1238 | 506 | } |
mcimadamore@1337 | 507 | |
mcimadamore@1337 | 508 | public InferenceContext inferenceContext() { |
mcimadamore@1337 | 509 | return infer.emptyContext; |
mcimadamore@1337 | 510 | } |
mcimadamore@1347 | 511 | |
mcimadamore@1347 | 512 | public DeferredAttrContext deferredAttrContext() { |
mcimadamore@1347 | 513 | return deferredAttr.emptyDeferredAttrContext; |
mcimadamore@1347 | 514 | } |
vromero@2382 | 515 | |
vromero@2382 | 516 | @Override |
vromero@2382 | 517 | public String toString() { |
vromero@2382 | 518 | return "CheckContext: basicHandler"; |
vromero@2382 | 519 | } |
mcimadamore@1238 | 520 | }; |
mcimadamore@1238 | 521 | |
duke@1 | 522 | /** Check that a given type is assignable to a given proto-type. |
duke@1 | 523 | * If it is, return the type, otherwise return errType. |
duke@1 | 524 | * @param pos Position to be used for error reporting. |
duke@1 | 525 | * @param found The type that was found. |
duke@1 | 526 | * @param req The type that was required. |
duke@1 | 527 | */ |
duke@1 | 528 | Type checkType(DiagnosticPosition pos, Type found, Type req) { |
mcimadamore@1238 | 529 | return checkType(pos, found, req, basicHandler); |
darcy@609 | 530 | } |
darcy@609 | 531 | |
mcimadamore@1337 | 532 | Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) { |
mcimadamore@1337 | 533 | final Infer.InferenceContext inferenceContext = checkContext.inferenceContext(); |
vromero@2543 | 534 | if (inferenceContext.free(req) || inferenceContext.free(found)) { |
vromero@2543 | 535 | inferenceContext.addFreeTypeListener(List.of(req, found), new FreeTypeListener() { |
mcimadamore@1337 | 536 | @Override |
mcimadamore@1337 | 537 | public void typesInferred(InferenceContext inferenceContext) { |
vromero@2157 | 538 | checkType(pos, inferenceContext.asInstType(found), inferenceContext.asInstType(req), checkContext); |
mcimadamore@1337 | 539 | } |
mcimadamore@1337 | 540 | }); |
mcimadamore@1337 | 541 | } |
jjg@1374 | 542 | if (req.hasTag(ERROR)) |
duke@1 | 543 | return req; |
jjg@1374 | 544 | if (req.hasTag(NONE)) |
duke@1 | 545 | return found; |
mcimadamore@1238 | 546 | if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) { |
duke@1 | 547 | return found; |
mcimadamore@1238 | 548 | } else { |
vromero@1826 | 549 | if (found.isNumeric() && req.isNumeric()) { |
mcimadamore@1296 | 550 | checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req)); |
mcimadamore@1238 | 551 | return types.createErrorType(found); |
mcimadamore@1238 | 552 | } |
mcimadamore@1296 | 553 | checkContext.report(pos, diags.fragment("inconvertible.types", found, req)); |
jjg@110 | 554 | return types.createErrorType(found); |
duke@1 | 555 | } |
duke@1 | 556 | } |
duke@1 | 557 | |
duke@1 | 558 | /** Check that a given type can be cast to a given target type. |
duke@1 | 559 | * Return the result of the cast. |
duke@1 | 560 | * @param pos Position to be used for error reporting. |
duke@1 | 561 | * @param found The type that is being cast. |
duke@1 | 562 | * @param req The target type of the cast. |
duke@1 | 563 | */ |
duke@1 | 564 | Type checkCastable(DiagnosticPosition pos, Type found, Type req) { |
mcimadamore@1238 | 565 | return checkCastable(pos, found, req, basicHandler); |
mcimadamore@1238 | 566 | } |
mcimadamore@1238 | 567 | Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) { |
mcimadamore@1268 | 568 | if (types.isCastable(found, req, castWarner(pos, found, req))) { |
duke@1 | 569 | return req; |
duke@1 | 570 | } else { |
mcimadamore@1296 | 571 | checkContext.report(pos, diags.fragment("inconvertible.types", found, req)); |
mcimadamore@1238 | 572 | return types.createErrorType(found); |
duke@1 | 573 | } |
duke@1 | 574 | } |
mcimadamore@1237 | 575 | |
mcimadamore@1237 | 576 | /** Check for redundant casts (i.e. where source type is a subtype of target type) |
mcimadamore@1237 | 577 | * The problem should only be reported for non-292 cast |
mcimadamore@1237 | 578 | */ |
jlahoda@2028 | 579 | public void checkRedundantCast(Env<AttrContext> env, final JCTypeCast tree) { |
jlahoda@2028 | 580 | if (!tree.type.isErroneous() |
mcimadamore@1348 | 581 | && types.isSameType(tree.expr.type, tree.clazz.type) |
jjg@1521 | 582 | && !(ignoreAnnotatedCasts && TreeInfo.containsTypeAnnotation(tree.clazz)) |
mcimadamore@1348 | 583 | && !is292targetTypeCast(tree)) { |
jlahoda@2028 | 584 | deferredLintHandler.report(new DeferredLintHandler.LintLogger() { |
jlahoda@2028 | 585 | @Override |
jlahoda@2028 | 586 | public void report() { |
jlahoda@2028 | 587 | if (lint.isEnabled(Lint.LintCategory.CAST)) |
jlahoda@2028 | 588 | log.warning(Lint.LintCategory.CAST, |
jlahoda@2028 | 589 | tree.pos(), "redundant.cast", tree.expr.type); |
jlahoda@2028 | 590 | } |
jlahoda@2028 | 591 | }); |
mcimadamore@1237 | 592 | } |
mcimadamore@1237 | 593 | } |
mcimadamore@1237 | 594 | //where |
jjg@1521 | 595 | private boolean is292targetTypeCast(JCTypeCast tree) { |
jjg@1521 | 596 | boolean is292targetTypeCast = false; |
jjg@1521 | 597 | JCExpression expr = TreeInfo.skipParens(tree.expr); |
jjg@1521 | 598 | if (expr.hasTag(APPLY)) { |
jjg@1521 | 599 | JCMethodInvocation apply = (JCMethodInvocation)expr; |
jjg@1521 | 600 | Symbol sym = TreeInfo.symbol(apply.meth); |
jjg@1521 | 601 | is292targetTypeCast = sym != null && |
jjg@1521 | 602 | sym.kind == MTH && |
jjg@1521 | 603 | (sym.flags() & HYPOTHETICAL) != 0; |
mcimadamore@1237 | 604 | } |
jjg@1521 | 605 | return is292targetTypeCast; |
jjg@1521 | 606 | } |
mcimadamore@1237 | 607 | |
jjg@1521 | 608 | private static final boolean ignoreAnnotatedCasts = true; |
duke@1 | 609 | |
duke@1 | 610 | /** Check that a type is within some bounds. |
duke@1 | 611 | * |
jjg@1358 | 612 | * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid |
duke@1 | 613 | * type argument. |
duke@1 | 614 | * @param a The type that should be bounded by bs. |
jjg@1358 | 615 | * @param bound The bound. |
duke@1 | 616 | */ |
mcimadamore@1216 | 617 | private boolean checkExtends(Type a, Type bound) { |
mcimadamore@154 | 618 | if (a.isUnbound()) { |
mcimadamore@821 | 619 | return true; |
jjg@1374 | 620 | } else if (!a.hasTag(WILDCARD)) { |
dlsmith@2400 | 621 | a = types.cvarUpperBound(a); |
mcimadamore@1216 | 622 | return types.isSubtype(a, bound); |
mcimadamore@154 | 623 | } else if (a.isExtendsBound()) { |
dlsmith@2400 | 624 | return types.isCastable(bound, types.wildUpperBound(a), types.noWarnings); |
mcimadamore@154 | 625 | } else if (a.isSuperBound()) { |
dlsmith@2384 | 626 | return !types.notSoftSubtype(types.wildLowerBound(a), bound); |
mcimadamore@154 | 627 | } |
mcimadamore@821 | 628 | return true; |
mcimadamore@154 | 629 | } |
duke@1 | 630 | |
duke@1 | 631 | /** Check that type is different from 'void'. |
duke@1 | 632 | * @param pos Position to be used for error reporting. |
duke@1 | 633 | * @param t The type to be checked. |
duke@1 | 634 | */ |
duke@1 | 635 | Type checkNonVoid(DiagnosticPosition pos, Type t) { |
jjg@1374 | 636 | if (t.hasTag(VOID)) { |
duke@1 | 637 | log.error(pos, "void.not.allowed.here"); |
jjg@110 | 638 | return types.createErrorType(t); |
duke@1 | 639 | } else { |
duke@1 | 640 | return t; |
duke@1 | 641 | } |
duke@1 | 642 | } |
duke@1 | 643 | |
mcimadamore@1496 | 644 | Type checkClassOrArrayType(DiagnosticPosition pos, Type t) { |
mcimadamore@1496 | 645 | if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) { |
mcimadamore@1496 | 646 | return typeTagError(pos, |
mcimadamore@1496 | 647 | diags.fragment("type.req.class.array"), |
mcimadamore@1496 | 648 | asTypeParam(t)); |
mcimadamore@1496 | 649 | } else { |
mcimadamore@1496 | 650 | return t; |
mcimadamore@1496 | 651 | } |
mcimadamore@1496 | 652 | } |
mcimadamore@1496 | 653 | |
duke@1 | 654 | /** Check that type is a class or interface type. |
duke@1 | 655 | * @param pos Position to be used for error reporting. |
duke@1 | 656 | * @param t The type to be checked. |
duke@1 | 657 | */ |
duke@1 | 658 | Type checkClassType(DiagnosticPosition pos, Type t) { |
mcimadamore@1496 | 659 | if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) { |
duke@1 | 660 | return typeTagError(pos, |
mcimadamore@89 | 661 | diags.fragment("type.req.class"), |
mcimadamore@1496 | 662 | asTypeParam(t)); |
mcimadamore@1496 | 663 | } else { |
duke@1 | 664 | return t; |
mcimadamore@1496 | 665 | } |
duke@1 | 666 | } |
mcimadamore@1496 | 667 | //where |
mcimadamore@1496 | 668 | private Object asTypeParam(Type t) { |
mcimadamore@1496 | 669 | return (t.hasTag(TYPEVAR)) |
mcimadamore@1496 | 670 | ? diags.fragment("type.parameter", t) |
mcimadamore@1496 | 671 | : t; |
mcimadamore@1496 | 672 | } |
duke@1 | 673 | |
mcimadamore@1352 | 674 | /** Check that type is a valid qualifier for a constructor reference expression |
mcimadamore@1352 | 675 | */ |
mcimadamore@1352 | 676 | Type checkConstructorRefType(DiagnosticPosition pos, Type t) { |
mcimadamore@1496 | 677 | t = checkClassOrArrayType(pos, t); |
jjg@1374 | 678 | if (t.hasTag(CLASS)) { |
mcimadamore@1352 | 679 | if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) { |
mcimadamore@1627 | 680 | log.error(pos, "abstract.cant.be.instantiated", t.tsym); |
mcimadamore@1352 | 681 | t = types.createErrorType(t); |
mcimadamore@1352 | 682 | } else if ((t.tsym.flags() & ENUM) != 0) { |
mcimadamore@1352 | 683 | log.error(pos, "enum.cant.be.instantiated"); |
mcimadamore@1352 | 684 | t = types.createErrorType(t); |
mcimadamore@1627 | 685 | } else { |
mcimadamore@1627 | 686 | t = checkClassType(pos, t, true); |
mcimadamore@1627 | 687 | } |
mcimadamore@1627 | 688 | } else if (t.hasTag(ARRAY)) { |
mcimadamore@1627 | 689 | if (!types.isReifiable(((ArrayType)t).elemtype)) { |
mcimadamore@1627 | 690 | log.error(pos, "generic.array.creation"); |
mcimadamore@1627 | 691 | t = types.createErrorType(t); |
mcimadamore@1352 | 692 | } |
mcimadamore@1352 | 693 | } |
mcimadamore@1352 | 694 | return t; |
mcimadamore@1352 | 695 | } |
mcimadamore@1352 | 696 | |
duke@1 | 697 | /** Check that type is a class or interface type. |
duke@1 | 698 | * @param pos Position to be used for error reporting. |
duke@1 | 699 | * @param t The type to be checked. |
duke@1 | 700 | * @param noBounds True if type bounds are illegal here. |
duke@1 | 701 | */ |
duke@1 | 702 | Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) { |
duke@1 | 703 | t = checkClassType(pos, t); |
duke@1 | 704 | if (noBounds && t.isParameterized()) { |
duke@1 | 705 | List<Type> args = t.getTypeArguments(); |
duke@1 | 706 | while (args.nonEmpty()) { |
jjg@1374 | 707 | if (args.head.hasTag(WILDCARD)) |
duke@1 | 708 | return typeTagError(pos, |
jjg@598 | 709 | diags.fragment("type.req.exact"), |
duke@1 | 710 | args.head); |
duke@1 | 711 | args = args.tail; |
duke@1 | 712 | } |
duke@1 | 713 | } |
duke@1 | 714 | return t; |
duke@1 | 715 | } |
duke@1 | 716 | |
duke@1 | 717 | /** Check that type is a reference type, i.e. a class, interface or array type |
duke@1 | 718 | * or a type variable. |
duke@1 | 719 | * @param pos Position to be used for error reporting. |
duke@1 | 720 | * @param t The type to be checked. |
duke@1 | 721 | */ |
duke@1 | 722 | Type checkRefType(DiagnosticPosition pos, Type t) { |
jjg@1374 | 723 | if (t.isReference()) |
duke@1 | 724 | return t; |
jjg@1374 | 725 | else |
duke@1 | 726 | return typeTagError(pos, |
mcimadamore@89 | 727 | diags.fragment("type.req.ref"), |
duke@1 | 728 | t); |
duke@1 | 729 | } |
duke@1 | 730 | |
jrose@267 | 731 | /** Check that each type is a reference type, i.e. a class, interface or array type |
jrose@267 | 732 | * or a type variable. |
jrose@267 | 733 | * @param trees Original trees, used for error reporting. |
jrose@267 | 734 | * @param types The types to be checked. |
jrose@267 | 735 | */ |
jrose@267 | 736 | List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) { |
jrose@267 | 737 | List<JCExpression> tl = trees; |
jrose@267 | 738 | for (List<Type> l = types; l.nonEmpty(); l = l.tail) { |
jrose@267 | 739 | l.head = checkRefType(tl.head.pos(), l.head); |
jrose@267 | 740 | tl = tl.tail; |
jrose@267 | 741 | } |
jrose@267 | 742 | return types; |
jrose@267 | 743 | } |
jrose@267 | 744 | |
duke@1 | 745 | /** Check that type is a null or reference type. |
duke@1 | 746 | * @param pos Position to be used for error reporting. |
duke@1 | 747 | * @param t The type to be checked. |
duke@1 | 748 | */ |
duke@1 | 749 | Type checkNullOrRefType(DiagnosticPosition pos, Type t) { |
vromero@1826 | 750 | if (t.isReference() || t.hasTag(BOT)) |
duke@1 | 751 | return t; |
jjg@1374 | 752 | else |
duke@1 | 753 | return typeTagError(pos, |
mcimadamore@89 | 754 | diags.fragment("type.req.ref"), |
duke@1 | 755 | t); |
duke@1 | 756 | } |
duke@1 | 757 | |
duke@1 | 758 | /** Check that flag set does not contain elements of two conflicting sets. s |
duke@1 | 759 | * Return true if it doesn't. |
duke@1 | 760 | * @param pos Position to be used for error reporting. |
duke@1 | 761 | * @param flags The set of flags to be checked. |
duke@1 | 762 | * @param set1 Conflicting flags set #1. |
duke@1 | 763 | * @param set2 Conflicting flags set #2. |
duke@1 | 764 | */ |
duke@1 | 765 | boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) { |
duke@1 | 766 | if ((flags & set1) != 0 && (flags & set2) != 0) { |
duke@1 | 767 | log.error(pos, |
duke@1 | 768 | "illegal.combination.of.modifiers", |
mcimadamore@80 | 769 | asFlagSet(TreeInfo.firstFlag(flags & set1)), |
mcimadamore@80 | 770 | asFlagSet(TreeInfo.firstFlag(flags & set2))); |
duke@1 | 771 | return false; |
duke@1 | 772 | } else |
duke@1 | 773 | return true; |
duke@1 | 774 | } |
duke@1 | 775 | |
mcimadamore@914 | 776 | /** Check that usage of diamond operator is correct (i.e. diamond should not |
mcimadamore@914 | 777 | * be used with non-generic classes or in anonymous class creation expressions) |
mcimadamore@537 | 778 | */ |
mcimadamore@914 | 779 | Type checkDiamond(JCNewClass tree, Type t) { |
mcimadamore@914 | 780 | if (!TreeInfo.isDiamond(tree) || |
mcimadamore@914 | 781 | t.isErroneous()) { |
mcimadamore@914 | 782 | return checkClassType(tree.clazz.pos(), t, true); |
mcimadamore@914 | 783 | } else if (tree.def != null) { |
mcimadamore@914 | 784 | log.error(tree.clazz.pos(), |
mcimadamore@914 | 785 | "cant.apply.diamond.1", |
mcimadamore@914 | 786 | t, diags.fragment("diamond.and.anon.class", t)); |
mcimadamore@914 | 787 | return types.createErrorType(t); |
mcimadamore@948 | 788 | } else if (t.tsym.type.getTypeArguments().isEmpty()) { |
mcimadamore@914 | 789 | log.error(tree.clazz.pos(), |
mcimadamore@914 | 790 | "cant.apply.diamond.1", |
mcimadamore@914 | 791 | t, diags.fragment("diamond.non.generic", t)); |
mcimadamore@914 | 792 | return types.createErrorType(t); |
mcimadamore@993 | 793 | } else if (tree.typeargs != null && |
mcimadamore@993 | 794 | tree.typeargs.nonEmpty()) { |
mcimadamore@993 | 795 | log.error(tree.clazz.pos(), |
mcimadamore@993 | 796 | "cant.apply.diamond.1", |
mcimadamore@993 | 797 | t, diags.fragment("diamond.and.explicit.params", t)); |
mcimadamore@993 | 798 | return types.createErrorType(t); |
mcimadamore@914 | 799 | } else { |
mcimadamore@914 | 800 | return t; |
mcimadamore@537 | 801 | } |
mcimadamore@537 | 802 | } |
mcimadamore@537 | 803 | |
mcimadamore@795 | 804 | void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) { |
mcimadamore@580 | 805 | MethodSymbol m = tree.sym; |
mcimadamore@795 | 806 | if (!allowSimplifiedVarargs) return; |
mcimadamore@795 | 807 | boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null; |
mcimadamore@795 | 808 | Type varargElemType = null; |
mcimadamore@580 | 809 | if (m.isVarArgs()) { |
mcimadamore@795 | 810 | varargElemType = types.elemtype(tree.params.last().type); |
mcimadamore@795 | 811 | } |
mcimadamore@795 | 812 | if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) { |
mcimadamore@795 | 813 | if (varargElemType != null) { |
mcimadamore@795 | 814 | log.error(tree, |
mcimadamore@795 | 815 | "varargs.invalid.trustme.anno", |
mcimadamore@795 | 816 | syms.trustMeType.tsym, |
mcimadamore@795 | 817 | diags.fragment("varargs.trustme.on.virtual.varargs", m)); |
mcimadamore@795 | 818 | } else { |
mcimadamore@795 | 819 | log.error(tree, |
mcimadamore@795 | 820 | "varargs.invalid.trustme.anno", |
mcimadamore@795 | 821 | syms.trustMeType.tsym, |
mcimadamore@795 | 822 | diags.fragment("varargs.trustme.on.non.varargs.meth", m)); |
mcimadamore@580 | 823 | } |
mcimadamore@795 | 824 | } else if (hasTrustMeAnno && varargElemType != null && |
mcimadamore@795 | 825 | types.isReifiable(varargElemType)) { |
mcimadamore@795 | 826 | warnUnsafeVararg(tree, |
mcimadamore@795 | 827 | "varargs.redundant.trustme.anno", |
mcimadamore@795 | 828 | syms.trustMeType.tsym, |
mcimadamore@795 | 829 | diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType)); |
mcimadamore@795 | 830 | } |
mcimadamore@795 | 831 | else if (!hasTrustMeAnno && varargElemType != null && |
mcimadamore@795 | 832 | !types.isReifiable(varargElemType)) { |
mcimadamore@795 | 833 | warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType); |
mcimadamore@580 | 834 | } |
mcimadamore@580 | 835 | } |
mcimadamore@795 | 836 | //where |
mcimadamore@795 | 837 | private boolean isTrustMeAllowedOnMethod(Symbol s) { |
mcimadamore@795 | 838 | return (s.flags() & VARARGS) != 0 && |
mcimadamore@795 | 839 | (s.isConstructor() || |
mcimadamore@795 | 840 | (s.flags() & (STATIC | FINAL)) != 0); |
mcimadamore@795 | 841 | } |
mcimadamore@580 | 842 | |
mcimadamore@1812 | 843 | Type checkMethod(final Type mtype, |
mcimadamore@1812 | 844 | final Symbol sym, |
mcimadamore@1812 | 845 | final Env<AttrContext> env, |
mcimadamore@1812 | 846 | final List<JCExpression> argtrees, |
mcimadamore@1812 | 847 | final List<Type> argtypes, |
mcimadamore@1812 | 848 | final boolean useVarargs, |
mcimadamore@1812 | 849 | InferenceContext inferenceContext) { |
mcimadamore@1219 | 850 | // System.out.println("call : " + env.tree); |
mcimadamore@1219 | 851 | // System.out.println("method : " + owntype); |
mcimadamore@1219 | 852 | // System.out.println("actuals: " + argtypes); |
mcimadamore@1812 | 853 | if (inferenceContext.free(mtype)) { |
mcimadamore@1812 | 854 | inferenceContext.addFreeTypeListener(List.of(mtype), new FreeTypeListener() { |
mcimadamore@1812 | 855 | public void typesInferred(InferenceContext inferenceContext) { |
mcimadamore@1812 | 856 | checkMethod(inferenceContext.asInstType(mtype), sym, env, argtrees, argtypes, useVarargs, inferenceContext); |
mcimadamore@1812 | 857 | } |
mcimadamore@1812 | 858 | }); |
mcimadamore@1812 | 859 | return mtype; |
mcimadamore@1812 | 860 | } |
mcimadamore@1812 | 861 | Type owntype = mtype; |
mcimadamore@1219 | 862 | List<Type> formals = owntype.getParameterTypes(); |
kizune@1959 | 863 | List<Type> nonInferred = sym.type.getParameterTypes(); |
kizune@1959 | 864 | if (nonInferred.length() != formals.length()) nonInferred = formals; |
mcimadamore@1219 | 865 | Type last = useVarargs ? formals.last() : null; |
kizune@1959 | 866 | if (sym.name == names.init && sym.owner == syms.enumSym) { |
kizune@1959 | 867 | formals = formals.tail.tail; |
kizune@1959 | 868 | nonInferred = nonInferred.tail.tail; |
kizune@1959 | 869 | } |
mcimadamore@1219 | 870 | List<JCExpression> args = argtrees; |
mcimadamore@1352 | 871 | if (args != null) { |
mcimadamore@1352 | 872 | //this is null when type-checking a method reference |
mcimadamore@1352 | 873 | while (formals.head != last) { |
mcimadamore@1219 | 874 | JCTree arg = args.head; |
kizune@1959 | 875 | Warner warn = convertWarner(arg.pos(), arg.type, nonInferred.head); |
mcimadamore@1352 | 876 | assertConvertible(arg, arg.type, formals.head, warn); |
mcimadamore@1219 | 877 | args = args.tail; |
mcimadamore@1352 | 878 | formals = formals.tail; |
kizune@1959 | 879 | nonInferred = nonInferred.tail; |
mcimadamore@1219 | 880 | } |
mcimadamore@1352 | 881 | if (useVarargs) { |
mcimadamore@1352 | 882 | Type varArg = types.elemtype(last); |
mcimadamore@1352 | 883 | while (args.tail != null) { |
mcimadamore@1352 | 884 | JCTree arg = args.head; |
mcimadamore@1352 | 885 | Warner warn = convertWarner(arg.pos(), arg.type, varArg); |
mcimadamore@1352 | 886 | assertConvertible(arg, arg.type, varArg, warn); |
mcimadamore@1352 | 887 | args = args.tail; |
mcimadamore@1352 | 888 | } |
mcimadamore@1904 | 889 | } else if ((sym.flags() & (VARARGS | SIGNATURE_POLYMORPHIC)) == VARARGS && |
mcimadamore@1904 | 890 | allowVarargs) { |
mcimadamore@1352 | 891 | // non-varargs call to varargs method |
mcimadamore@1352 | 892 | Type varParam = owntype.getParameterTypes().last(); |
mcimadamore@1812 | 893 | Type lastArg = argtypes.last(); |
mcimadamore@1352 | 894 | if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) && |
kizune@1959 | 895 | !types.isSameType(types.erasure(varParam), types.erasure(lastArg))) |
mcimadamore@1352 | 896 | log.warning(argtrees.last().pos(), "inexact.non-varargs.call", |
kizune@1959 | 897 | types.elemtype(varParam), varParam); |
mcimadamore@1352 | 898 | } |
mcimadamore@1219 | 899 | } |
mcimadamore@1219 | 900 | if (useVarargs) { |
mcimadamore@1219 | 901 | Type argtype = owntype.getParameterTypes().last(); |
mcimadamore@1219 | 902 | if (!types.isReifiable(argtype) && |
kizune@1959 | 903 | (!allowSimplifiedVarargs || |
kizune@1959 | 904 | sym.attribute(syms.trustMeType.tsym) == null || |
kizune@1959 | 905 | !isTrustMeAllowedOnMethod(sym))) { |
mcimadamore@1219 | 906 | warnUnchecked(env.tree.pos(), |
mcimadamore@1219 | 907 | "unchecked.generic.array.creation", |
mcimadamore@1219 | 908 | argtype); |
mcimadamore@1219 | 909 | } |
vromero@1820 | 910 | if ((sym.baseSymbol().flags() & SIGNATURE_POLYMORPHIC) == 0) { |
mcimadamore@1812 | 911 | TreeInfo.setVarargsElement(env.tree, types.elemtype(argtype)); |
mcimadamore@1219 | 912 | } |
mcimadamore@1219 | 913 | } |
mcimadamore@1510 | 914 | PolyKind pkind = (sym.type.hasTag(FORALL) && |
mcimadamore@1510 | 915 | sym.type.getReturnType().containsAny(((ForAll)sym.type).tvars)) ? |
mcimadamore@1510 | 916 | PolyKind.POLY : PolyKind.STANDALONE; |
mcimadamore@1510 | 917 | TreeInfo.setPolyKind(env.tree, pkind); |
mcimadamore@1219 | 918 | return owntype; |
mcimadamore@547 | 919 | } |
mcimadamore@1219 | 920 | //where |
kizune@1959 | 921 | private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) { |
kizune@1959 | 922 | if (types.isConvertible(actual, formal, warn)) |
kizune@1959 | 923 | return; |
kizune@1959 | 924 | |
kizune@1959 | 925 | if (formal.isCompound() |
kizune@1959 | 926 | && types.isSubtype(actual, types.supertype(formal)) |
kizune@1959 | 927 | && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn)) |
kizune@1959 | 928 | return; |
kizune@1959 | 929 | } |
mcimadamore@547 | 930 | |
mcimadamore@821 | 931 | /** |
mcimadamore@821 | 932 | * Check that type 't' is a valid instantiation of a generic class |
mcimadamore@821 | 933 | * (see JLS 4.5) |
mcimadamore@821 | 934 | * |
mcimadamore@821 | 935 | * @param t class type to be checked |
mcimadamore@821 | 936 | * @return true if 't' is well-formed |
mcimadamore@821 | 937 | */ |
mcimadamore@821 | 938 | public boolean checkValidGenericType(Type t) { |
mcimadamore@821 | 939 | return firstIncompatibleTypeArg(t) == null; |
mcimadamore@821 | 940 | } |
mcimadamore@821 | 941 | //WHERE |
mcimadamore@821 | 942 | private Type firstIncompatibleTypeArg(Type type) { |
mcimadamore@821 | 943 | List<Type> formals = type.tsym.type.allparams(); |
mcimadamore@821 | 944 | List<Type> actuals = type.allparams(); |
mcimadamore@821 | 945 | List<Type> args = type.getTypeArguments(); |
mcimadamore@821 | 946 | List<Type> forms = type.tsym.type.getTypeArguments(); |
mcimadamore@1216 | 947 | ListBuffer<Type> bounds_buf = new ListBuffer<Type>(); |
mcimadamore@821 | 948 | |
mcimadamore@821 | 949 | // For matching pairs of actual argument types `a' and |
mcimadamore@821 | 950 | // formal type parameters with declared bound `b' ... |
mcimadamore@821 | 951 | while (args.nonEmpty() && forms.nonEmpty()) { |
mcimadamore@821 | 952 | // exact type arguments needs to know their |
mcimadamore@821 | 953 | // bounds (for upper and lower bound |
mcimadamore@1216 | 954 | // calculations). So we create new bounds where |
mcimadamore@1216 | 955 | // type-parameters are replaced with actuals argument types. |
mcimadamore@1216 | 956 | bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals)); |
mcimadamore@821 | 957 | args = args.tail; |
mcimadamore@821 | 958 | forms = forms.tail; |
mcimadamore@821 | 959 | } |
mcimadamore@821 | 960 | |
mcimadamore@821 | 961 | args = type.getTypeArguments(); |
mcimadamore@821 | 962 | List<Type> tvars_cap = types.substBounds(formals, |
mcimadamore@821 | 963 | formals, |
mcimadamore@821 | 964 | types.capture(type).allparams()); |
mcimadamore@821 | 965 | while (args.nonEmpty() && tvars_cap.nonEmpty()) { |
mcimadamore@821 | 966 | // Let the actual arguments know their bound |
mcimadamore@821 | 967 | args.head.withTypeVar((TypeVar)tvars_cap.head); |
mcimadamore@821 | 968 | args = args.tail; |
mcimadamore@821 | 969 | tvars_cap = tvars_cap.tail; |
mcimadamore@821 | 970 | } |
mcimadamore@821 | 971 | |
mcimadamore@821 | 972 | args = type.getTypeArguments(); |
mcimadamore@1216 | 973 | List<Type> bounds = bounds_buf.toList(); |
mcimadamore@821 | 974 | |
mcimadamore@1216 | 975 | while (args.nonEmpty() && bounds.nonEmpty()) { |
mcimadamore@1216 | 976 | Type actual = args.head; |
mcimadamore@854 | 977 | if (!isTypeArgErroneous(actual) && |
mcimadamore@1216 | 978 | !bounds.head.isErroneous() && |
mcimadamore@1216 | 979 | !checkExtends(actual, bounds.head)) { |
mcimadamore@821 | 980 | return args.head; |
mcimadamore@821 | 981 | } |
mcimadamore@821 | 982 | args = args.tail; |
mcimadamore@1216 | 983 | bounds = bounds.tail; |
mcimadamore@821 | 984 | } |
mcimadamore@821 | 985 | |
mcimadamore@821 | 986 | args = type.getTypeArguments(); |
mcimadamore@1216 | 987 | bounds = bounds_buf.toList(); |
mcimadamore@821 | 988 | |
mcimadamore@821 | 989 | for (Type arg : types.capture(type).getTypeArguments()) { |
jjg@1374 | 990 | if (arg.hasTag(TYPEVAR) && |
mcimadamore@828 | 991 | arg.getUpperBound().isErroneous() && |
mcimadamore@1216 | 992 | !bounds.head.isErroneous() && |
mcimadamore@854 | 993 | !isTypeArgErroneous(args.head)) { |
mcimadamore@821 | 994 | return args.head; |
mcimadamore@821 | 995 | } |
mcimadamore@1216 | 996 | bounds = bounds.tail; |
mcimadamore@854 | 997 | args = args.tail; |
mcimadamore@821 | 998 | } |
mcimadamore@821 | 999 | |
mcimadamore@821 | 1000 | return null; |
mcimadamore@821 | 1001 | } |
mcimadamore@854 | 1002 | //where |
mcimadamore@854 | 1003 | boolean isTypeArgErroneous(Type t) { |
mcimadamore@854 | 1004 | return isTypeArgErroneous.visit(t); |
mcimadamore@854 | 1005 | } |
mcimadamore@854 | 1006 | |
mcimadamore@854 | 1007 | Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() { |
mcimadamore@854 | 1008 | public Boolean visitType(Type t, Void s) { |
mcimadamore@854 | 1009 | return t.isErroneous(); |
mcimadamore@854 | 1010 | } |
mcimadamore@854 | 1011 | @Override |
mcimadamore@854 | 1012 | public Boolean visitTypeVar(TypeVar t, Void s) { |
mcimadamore@854 | 1013 | return visit(t.getUpperBound()); |
mcimadamore@854 | 1014 | } |
mcimadamore@854 | 1015 | @Override |
mcimadamore@854 | 1016 | public Boolean visitCapturedType(CapturedType t, Void s) { |
mcimadamore@854 | 1017 | return visit(t.getUpperBound()) || |
mcimadamore@854 | 1018 | visit(t.getLowerBound()); |
mcimadamore@854 | 1019 | } |
mcimadamore@854 | 1020 | @Override |
mcimadamore@854 | 1021 | public Boolean visitWildcardType(WildcardType t, Void s) { |
mcimadamore@854 | 1022 | return visit(t.type); |
mcimadamore@854 | 1023 | } |
mcimadamore@854 | 1024 | }; |
mcimadamore@821 | 1025 | |
duke@1 | 1026 | /** Check that given modifiers are legal for given symbol and |
vromero@1555 | 1027 | * return modifiers together with any implicit modifiers for that symbol. |
duke@1 | 1028 | * Warning: we can't use flags() here since this method |
duke@1 | 1029 | * is called during class enter, when flags() would cause a premature |
duke@1 | 1030 | * completion. |
duke@1 | 1031 | * @param pos Position to be used for error reporting. |
duke@1 | 1032 | * @param flags The set of modifiers given in a definition. |
duke@1 | 1033 | * @param sym The defined symbol. |
duke@1 | 1034 | */ |
duke@1 | 1035 | long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) { |
duke@1 | 1036 | long mask; |
duke@1 | 1037 | long implicit = 0; |
emc@2016 | 1038 | |
duke@1 | 1039 | switch (sym.kind) { |
duke@1 | 1040 | case VAR: |
pgovereau@2424 | 1041 | if (TreeInfo.isReceiverParam(tree)) |
pgovereau@2424 | 1042 | mask = ReceiverParamFlags; |
pgovereau@2424 | 1043 | else if (sym.owner.kind != TYP) |
duke@1 | 1044 | mask = LocalVarFlags; |
duke@1 | 1045 | else if ((sym.owner.flags_field & INTERFACE) != 0) |
duke@1 | 1046 | mask = implicit = InterfaceVarFlags; |
duke@1 | 1047 | else |
duke@1 | 1048 | mask = VarFlags; |
duke@1 | 1049 | break; |
duke@1 | 1050 | case MTH: |
duke@1 | 1051 | if (sym.name == names.init) { |
duke@1 | 1052 | if ((sym.owner.flags_field & ENUM) != 0) { |
duke@1 | 1053 | // enum constructors cannot be declared public or |
duke@1 | 1054 | // protected and must be implicitly or explicitly |
duke@1 | 1055 | // private |
duke@1 | 1056 | implicit = PRIVATE; |
duke@1 | 1057 | mask = PRIVATE; |
duke@1 | 1058 | } else |
duke@1 | 1059 | mask = ConstructorFlags; |
mcimadamore@1366 | 1060 | } else if ((sym.owner.flags_field & INTERFACE) != 0) { |
emc@2016 | 1061 | if ((sym.owner.flags_field & ANNOTATION) != 0) { |
emc@2016 | 1062 | mask = AnnotationTypeElementMask; |
emc@2016 | 1063 | implicit = PUBLIC | ABSTRACT; |
emc@2016 | 1064 | } else if ((flags & (DEFAULT | STATIC)) != 0) { |
mcimadamore@1513 | 1065 | mask = InterfaceMethodMask; |
mcimadamore@1513 | 1066 | implicit = PUBLIC; |
mcimadamore@1513 | 1067 | if ((flags & DEFAULT) != 0) { |
mcimadamore@1513 | 1068 | implicit |= ABSTRACT; |
mcimadamore@1513 | 1069 | } |
mcimadamore@1366 | 1070 | } else { |
mcimadamore@1366 | 1071 | mask = implicit = InterfaceMethodFlags; |
mcimadamore@1366 | 1072 | } |
emc@2016 | 1073 | } else { |
duke@1 | 1074 | mask = MethodFlags; |
duke@1 | 1075 | } |
duke@1 | 1076 | // Imply STRICTFP if owner has STRICTFP set. |
vromero@1712 | 1077 | if (((flags|implicit) & Flags.ABSTRACT) == 0 || |
vromero@1712 | 1078 | ((flags) & Flags.DEFAULT) != 0) |
vromero@1555 | 1079 | implicit |= sym.owner.flags_field & STRICTFP; |
duke@1 | 1080 | break; |
duke@1 | 1081 | case TYP: |
duke@1 | 1082 | if (sym.isLocal()) { |
duke@1 | 1083 | mask = LocalClassFlags; |
jjg@113 | 1084 | if (sym.name.isEmpty()) { // Anonymous class |
duke@1 | 1085 | // Anonymous classes in static methods are themselves static; |
duke@1 | 1086 | // that's why we admit STATIC here. |
duke@1 | 1087 | mask |= STATIC; |
duke@1 | 1088 | // JLS: Anonymous classes are final. |
duke@1 | 1089 | implicit |= FINAL; |
duke@1 | 1090 | } |
duke@1 | 1091 | if ((sym.owner.flags_field & STATIC) == 0 && |
duke@1 | 1092 | (flags & ENUM) != 0) |
duke@1 | 1093 | log.error(pos, "enums.must.be.static"); |
duke@1 | 1094 | } else if (sym.owner.kind == TYP) { |
duke@1 | 1095 | mask = MemberClassFlags; |
duke@1 | 1096 | if (sym.owner.owner.kind == PCK || |
duke@1 | 1097 | (sym.owner.flags_field & STATIC) != 0) |
duke@1 | 1098 | mask |= STATIC; |
duke@1 | 1099 | else if ((flags & ENUM) != 0) |
duke@1 | 1100 | log.error(pos, "enums.must.be.static"); |
duke@1 | 1101 | // Nested interfaces and enums are always STATIC (Spec ???) |
duke@1 | 1102 | if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC; |
duke@1 | 1103 | } else { |
duke@1 | 1104 | mask = ClassFlags; |
duke@1 | 1105 | } |
duke@1 | 1106 | // Interfaces are always ABSTRACT |
duke@1 | 1107 | if ((flags & INTERFACE) != 0) implicit |= ABSTRACT; |
duke@1 | 1108 | |
duke@1 | 1109 | if ((flags & ENUM) != 0) { |
duke@1 | 1110 | // enums can't be declared abstract or final |
duke@1 | 1111 | mask &= ~(ABSTRACT | FINAL); |
duke@1 | 1112 | implicit |= implicitEnumFinalFlag(tree); |
duke@1 | 1113 | } |
duke@1 | 1114 | // Imply STRICTFP if owner has STRICTFP set. |
duke@1 | 1115 | implicit |= sym.owner.flags_field & STRICTFP; |
duke@1 | 1116 | break; |
duke@1 | 1117 | default: |
duke@1 | 1118 | throw new AssertionError(); |
duke@1 | 1119 | } |
mcimadamore@1366 | 1120 | long illegal = flags & ExtendedStandardFlags & ~mask; |
duke@1 | 1121 | if (illegal != 0) { |
duke@1 | 1122 | if ((illegal & INTERFACE) != 0) { |
duke@1 | 1123 | log.error(pos, "intf.not.allowed.here"); |
duke@1 | 1124 | mask |= INTERFACE; |
duke@1 | 1125 | } |
duke@1 | 1126 | else { |
duke@1 | 1127 | log.error(pos, |
mcimadamore@80 | 1128 | "mod.not.allowed.here", asFlagSet(illegal)); |
duke@1 | 1129 | } |
duke@1 | 1130 | } |
duke@1 | 1131 | else if ((sym.kind == TYP || |
duke@1 | 1132 | // ISSUE: Disallowing abstract&private is no longer appropriate |
duke@1 | 1133 | // in the presence of inner classes. Should it be deleted here? |
duke@1 | 1134 | checkDisjoint(pos, flags, |
duke@1 | 1135 | ABSTRACT, |
mcimadamore@1366 | 1136 | PRIVATE | STATIC | DEFAULT)) |
duke@1 | 1137 | && |
duke@1 | 1138 | checkDisjoint(pos, flags, |
mcimadamore@1513 | 1139 | STATIC, |
mcimadamore@1513 | 1140 | DEFAULT) |
mcimadamore@1513 | 1141 | && |
mcimadamore@1513 | 1142 | checkDisjoint(pos, flags, |
duke@1 | 1143 | ABSTRACT | INTERFACE, |
duke@1 | 1144 | FINAL | NATIVE | SYNCHRONIZED) |
duke@1 | 1145 | && |
duke@1 | 1146 | checkDisjoint(pos, flags, |
duke@1 | 1147 | PUBLIC, |
duke@1 | 1148 | PRIVATE | PROTECTED) |
duke@1 | 1149 | && |
duke@1 | 1150 | checkDisjoint(pos, flags, |
duke@1 | 1151 | PRIVATE, |
duke@1 | 1152 | PUBLIC | PROTECTED) |
duke@1 | 1153 | && |
duke@1 | 1154 | checkDisjoint(pos, flags, |
duke@1 | 1155 | FINAL, |
duke@1 | 1156 | VOLATILE) |
duke@1 | 1157 | && |
duke@1 | 1158 | (sym.kind == TYP || |
duke@1 | 1159 | checkDisjoint(pos, flags, |
duke@1 | 1160 | ABSTRACT | NATIVE, |
duke@1 | 1161 | STRICTFP))) { |
duke@1 | 1162 | // skip |
duke@1 | 1163 | } |
mcimadamore@1366 | 1164 | return flags & (mask | ~ExtendedStandardFlags) | implicit; |
duke@1 | 1165 | } |
duke@1 | 1166 | |
duke@1 | 1167 | |
duke@1 | 1168 | /** Determine if this enum should be implicitly final. |
duke@1 | 1169 | * |
duke@1 | 1170 | * If the enum has no specialized enum contants, it is final. |
duke@1 | 1171 | * |
duke@1 | 1172 | * If the enum does have specialized enum contants, it is |
duke@1 | 1173 | * <i>not</i> final. |
duke@1 | 1174 | */ |
duke@1 | 1175 | private long implicitEnumFinalFlag(JCTree tree) { |
jjg@1127 | 1176 | if (!tree.hasTag(CLASSDEF)) return 0; |
duke@1 | 1177 | class SpecialTreeVisitor extends JCTree.Visitor { |
duke@1 | 1178 | boolean specialized; |
duke@1 | 1179 | SpecialTreeVisitor() { |
duke@1 | 1180 | this.specialized = false; |
duke@1 | 1181 | }; |
duke@1 | 1182 | |
jjg@398 | 1183 | @Override |
duke@1 | 1184 | public void visitTree(JCTree tree) { /* no-op */ } |
duke@1 | 1185 | |
jjg@398 | 1186 | @Override |
duke@1 | 1187 | public void visitVarDef(JCVariableDecl tree) { |
duke@1 | 1188 | if ((tree.mods.flags & ENUM) != 0) { |
duke@1 | 1189 | if (tree.init instanceof JCNewClass && |
duke@1 | 1190 | ((JCNewClass) tree.init).def != null) { |
duke@1 | 1191 | specialized = true; |
duke@1 | 1192 | } |
duke@1 | 1193 | } |
duke@1 | 1194 | } |
duke@1 | 1195 | } |
duke@1 | 1196 | |
duke@1 | 1197 | SpecialTreeVisitor sts = new SpecialTreeVisitor(); |
duke@1 | 1198 | JCClassDecl cdef = (JCClassDecl) tree; |
duke@1 | 1199 | for (JCTree defs: cdef.defs) { |
duke@1 | 1200 | defs.accept(sts); |
duke@1 | 1201 | if (sts.specialized) return 0; |
duke@1 | 1202 | } |
duke@1 | 1203 | return FINAL; |
duke@1 | 1204 | } |
duke@1 | 1205 | |
duke@1 | 1206 | /* ************************************************************************* |
duke@1 | 1207 | * Type Validation |
duke@1 | 1208 | **************************************************************************/ |
duke@1 | 1209 | |
duke@1 | 1210 | /** Validate a type expression. That is, |
duke@1 | 1211 | * check that all type arguments of a parametric type are within |
jjg@1755 | 1212 | * their bounds. This must be done in a second phase after type attribution |
duke@1 | 1213 | * since a class might have a subclass as type parameter bound. E.g: |
duke@1 | 1214 | * |
jjg@1358 | 1215 | * <pre>{@code |
duke@1 | 1216 | * class B<A extends C> { ... } |
duke@1 | 1217 | * class C extends B<C> { ... } |
jjg@1358 | 1218 | * }</pre> |
duke@1 | 1219 | * |
duke@1 | 1220 | * and we can't make sure that the bound is already attributed because |
duke@1 | 1221 | * of possible cycles. |
mcimadamore@638 | 1222 | * |
mcimadamore@638 | 1223 | * Visitor method: Validate a type expression, if it is not null, catching |
duke@1 | 1224 | * and reporting any completion failures. |
duke@1 | 1225 | */ |
mcimadamore@122 | 1226 | void validate(JCTree tree, Env<AttrContext> env) { |
mcimadamore@638 | 1227 | validate(tree, env, true); |
duke@1 | 1228 | } |
mcimadamore@638 | 1229 | void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) { |
mcimadamore@638 | 1230 | new Validator(env).validateTree(tree, checkRaw, true); |
mcimadamore@122 | 1231 | } |
duke@1 | 1232 | |
duke@1 | 1233 | /** Visitor method: Validate a list of type expressions. |
duke@1 | 1234 | */ |
mcimadamore@122 | 1235 | void validate(List<? extends JCTree> trees, Env<AttrContext> env) { |
duke@1 | 1236 | for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail) |
mcimadamore@122 | 1237 | validate(l.head, env); |
duke@1 | 1238 | } |
duke@1 | 1239 | |
duke@1 | 1240 | /** A visitor class for type validation. |
duke@1 | 1241 | */ |
duke@1 | 1242 | class Validator extends JCTree.Visitor { |
duke@1 | 1243 | |
jlahoda@2038 | 1244 | boolean checkRaw; |
mcimadamore@638 | 1245 | boolean isOuter; |
mcimadamore@638 | 1246 | Env<AttrContext> env; |
mcimadamore@638 | 1247 | |
mcimadamore@638 | 1248 | Validator(Env<AttrContext> env) { |
mcimadamore@638 | 1249 | this.env = env; |
mcimadamore@638 | 1250 | } |
mcimadamore@638 | 1251 | |
jjg@398 | 1252 | @Override |
duke@1 | 1253 | public void visitTypeArray(JCArrayTypeTree tree) { |
jlahoda@2038 | 1254 | validateTree(tree.elemtype, checkRaw, isOuter); |
duke@1 | 1255 | } |
duke@1 | 1256 | |
jjg@398 | 1257 | @Override |
duke@1 | 1258 | public void visitTypeApply(JCTypeApply tree) { |
jjg@1374 | 1259 | if (tree.type.hasTag(CLASS)) { |
duke@1 | 1260 | List<JCExpression> args = tree.arguments; |
mcimadamore@158 | 1261 | List<Type> forms = tree.type.tsym.type.getTypeArguments(); |
mcimadamore@821 | 1262 | |
mcimadamore@821 | 1263 | Type incompatibleArg = firstIncompatibleTypeArg(tree.type); |
mcimadamore@821 | 1264 | if (incompatibleArg != null) { |
mcimadamore@821 | 1265 | for (JCTree arg : tree.arguments) { |
mcimadamore@821 | 1266 | if (arg.type == incompatibleArg) { |
mcimadamore@829 | 1267 | log.error(arg, "not.within.bounds", incompatibleArg, forms.head); |
mcimadamore@821 | 1268 | } |
mcimadamore@829 | 1269 | forms = forms.tail; |
mcimadamore@829 | 1270 | } |
mcimadamore@829 | 1271 | } |
mcimadamore@829 | 1272 | |
mcimadamore@829 | 1273 | forms = tree.type.tsym.type.getTypeArguments(); |
duke@1 | 1274 | |
mcimadamore@638 | 1275 | boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class; |
mcimadamore@638 | 1276 | |
duke@1 | 1277 | // For matching pairs of actual argument types `a' and |
duke@1 | 1278 | // formal type parameters with declared bound `b' ... |
duke@1 | 1279 | while (args.nonEmpty() && forms.nonEmpty()) { |
mcimadamore@638 | 1280 | validateTree(args.head, |
mcimadamore@638 | 1281 | !(isOuter && is_java_lang_Class), |
mcimadamore@638 | 1282 | false); |
duke@1 | 1283 | args = args.tail; |
duke@1 | 1284 | forms = forms.tail; |
duke@1 | 1285 | } |
duke@1 | 1286 | |
duke@1 | 1287 | // Check that this type is either fully parameterized, or |
duke@1 | 1288 | // not parameterized at all. |
duke@1 | 1289 | if (tree.type.getEnclosingType().isRaw()) |
duke@1 | 1290 | log.error(tree.pos(), "improperly.formed.type.inner.raw.param"); |
jjg@1127 | 1291 | if (tree.clazz.hasTag(SELECT)) |
duke@1 | 1292 | visitSelectInternal((JCFieldAccess)tree.clazz); |
duke@1 | 1293 | } |
duke@1 | 1294 | } |
duke@1 | 1295 | |
jjg@398 | 1296 | @Override |
duke@1 | 1297 | public void visitTypeParameter(JCTypeParameter tree) { |
mcimadamore@638 | 1298 | validateTrees(tree.bounds, true, isOuter); |
duke@1 | 1299 | checkClassBounds(tree.pos(), tree.type); |
duke@1 | 1300 | } |
duke@1 | 1301 | |
duke@1 | 1302 | @Override |
duke@1 | 1303 | public void visitWildcard(JCWildcard tree) { |
duke@1 | 1304 | if (tree.inner != null) |
mcimadamore@638 | 1305 | validateTree(tree.inner, true, isOuter); |
duke@1 | 1306 | } |
duke@1 | 1307 | |
jjg@398 | 1308 | @Override |
duke@1 | 1309 | public void visitSelect(JCFieldAccess tree) { |
jjg@1374 | 1310 | if (tree.type.hasTag(CLASS)) { |
duke@1 | 1311 | visitSelectInternal(tree); |
duke@1 | 1312 | |
duke@1 | 1313 | // Check that this type is either fully parameterized, or |
duke@1 | 1314 | // not parameterized at all. |
duke@1 | 1315 | if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty()) |
duke@1 | 1316 | log.error(tree.pos(), "improperly.formed.type.param.missing"); |
duke@1 | 1317 | } |
duke@1 | 1318 | } |
mcimadamore@852 | 1319 | |
duke@1 | 1320 | public void visitSelectInternal(JCFieldAccess tree) { |
mcimadamore@122 | 1321 | if (tree.type.tsym.isStatic() && |
duke@1 | 1322 | tree.selected.type.isParameterized()) { |
duke@1 | 1323 | // The enclosing type is not a class, so we are |
duke@1 | 1324 | // looking at a static member type. However, the |
duke@1 | 1325 | // qualifying expression is parameterized. |
duke@1 | 1326 | log.error(tree.pos(), "cant.select.static.class.from.param.type"); |
duke@1 | 1327 | } else { |
duke@1 | 1328 | // otherwise validate the rest of the expression |
mcimadamore@122 | 1329 | tree.selected.accept(this); |
duke@1 | 1330 | } |
duke@1 | 1331 | } |
duke@1 | 1332 | |
jjg@1521 | 1333 | @Override |
jjg@1521 | 1334 | public void visitAnnotatedType(JCAnnotatedType tree) { |
jjg@1521 | 1335 | tree.underlyingType.accept(this); |
jjg@1521 | 1336 | } |
jjg@1521 | 1337 | |
jlahoda@2206 | 1338 | @Override |
jlahoda@2206 | 1339 | public void visitTypeIdent(JCPrimitiveTypeTree that) { |
jlahoda@2206 | 1340 | if (that.type.hasTag(TypeTag.VOID)) { |
jlahoda@2206 | 1341 | log.error(that.pos(), "void.not.allowed.here"); |
jlahoda@2206 | 1342 | } |
jlahoda@2206 | 1343 | super.visitTypeIdent(that); |
jlahoda@2206 | 1344 | } |
jlahoda@2206 | 1345 | |
duke@1 | 1346 | /** Default visitor method: do nothing. |
duke@1 | 1347 | */ |
jjg@398 | 1348 | @Override |
duke@1 | 1349 | public void visitTree(JCTree tree) { |
duke@1 | 1350 | } |
mcimadamore@122 | 1351 | |
mcimadamore@638 | 1352 | public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) { |
jlahoda@2038 | 1353 | if (tree != null) { |
jlahoda@2038 | 1354 | boolean prevCheckRaw = this.checkRaw; |
jlahoda@2038 | 1355 | this.checkRaw = checkRaw; |
jlahoda@2038 | 1356 | this.isOuter = isOuter; |
jlahoda@2038 | 1357 | |
jlahoda@2038 | 1358 | try { |
mcimadamore@638 | 1359 | tree.accept(this); |
mcimadamore@638 | 1360 | if (checkRaw) |
mcimadamore@638 | 1361 | checkRaw(tree, env); |
jlahoda@2038 | 1362 | } catch (CompletionFailure ex) { |
jlahoda@2038 | 1363 | completionError(tree.pos(), ex); |
jlahoda@2038 | 1364 | } finally { |
jlahoda@2038 | 1365 | this.checkRaw = prevCheckRaw; |
mcimadamore@638 | 1366 | } |
mcimadamore@638 | 1367 | } |
mcimadamore@638 | 1368 | } |
mcimadamore@638 | 1369 | |
mcimadamore@638 | 1370 | public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) { |
mcimadamore@638 | 1371 | for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail) |
mcimadamore@638 | 1372 | validateTree(l.head, checkRaw, isOuter); |
mcimadamore@638 | 1373 | } |
mcimadamore@1760 | 1374 | } |
mcimadamore@1760 | 1375 | |
mcimadamore@1760 | 1376 | void checkRaw(JCTree tree, Env<AttrContext> env) { |
mcimadamore@1760 | 1377 | if (lint.isEnabled(LintCategory.RAW) && |
mcimadamore@1760 | 1378 | tree.type.hasTag(CLASS) && |
mcimadamore@1760 | 1379 | !TreeInfo.isDiamond(tree) && |
mcimadamore@1760 | 1380 | !withinAnonConstr(env) && |
mcimadamore@1760 | 1381 | tree.type.isRaw()) { |
mcimadamore@1760 | 1382 | log.warning(LintCategory.RAW, |
mcimadamore@1760 | 1383 | tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type); |
mcimadamore@638 | 1384 | } |
mcimadamore@1760 | 1385 | } |
mcimadamore@1760 | 1386 | //where |
mcimadamore@1760 | 1387 | private boolean withinAnonConstr(Env<AttrContext> env) { |
mcimadamore@1103 | 1388 | return env.enclClass.name.isEmpty() && |
mcimadamore@1103 | 1389 | env.enclMethod != null && env.enclMethod.name == names.init; |
mcimadamore@1103 | 1390 | } |
duke@1 | 1391 | |
duke@1 | 1392 | /* ************************************************************************* |
duke@1 | 1393 | * Exception checking |
duke@1 | 1394 | **************************************************************************/ |
duke@1 | 1395 | |
duke@1 | 1396 | /* The following methods treat classes as sets that contain |
duke@1 | 1397 | * the class itself and all their subclasses |
duke@1 | 1398 | */ |
duke@1 | 1399 | |
duke@1 | 1400 | /** Is given type a subtype of some of the types in given list? |
duke@1 | 1401 | */ |
duke@1 | 1402 | boolean subset(Type t, List<Type> ts) { |
duke@1 | 1403 | for (List<Type> l = ts; l.nonEmpty(); l = l.tail) |
duke@1 | 1404 | if (types.isSubtype(t, l.head)) return true; |
duke@1 | 1405 | return false; |
duke@1 | 1406 | } |
duke@1 | 1407 | |
duke@1 | 1408 | /** Is given type a subtype or supertype of |
duke@1 | 1409 | * some of the types in given list? |
duke@1 | 1410 | */ |
duke@1 | 1411 | boolean intersects(Type t, List<Type> ts) { |
duke@1 | 1412 | for (List<Type> l = ts; l.nonEmpty(); l = l.tail) |
duke@1 | 1413 | if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true; |
duke@1 | 1414 | return false; |
duke@1 | 1415 | } |
duke@1 | 1416 | |
duke@1 | 1417 | /** Add type set to given type list, unless it is a subclass of some class |
duke@1 | 1418 | * in the list. |
duke@1 | 1419 | */ |
duke@1 | 1420 | List<Type> incl(Type t, List<Type> ts) { |
duke@1 | 1421 | return subset(t, ts) ? ts : excl(t, ts).prepend(t); |
duke@1 | 1422 | } |
duke@1 | 1423 | |
duke@1 | 1424 | /** Remove type set from type set list. |
duke@1 | 1425 | */ |
duke@1 | 1426 | List<Type> excl(Type t, List<Type> ts) { |
duke@1 | 1427 | if (ts.isEmpty()) { |
duke@1 | 1428 | return ts; |
duke@1 | 1429 | } else { |
duke@1 | 1430 | List<Type> ts1 = excl(t, ts.tail); |
duke@1 | 1431 | if (types.isSubtype(ts.head, t)) return ts1; |
duke@1 | 1432 | else if (ts1 == ts.tail) return ts; |
duke@1 | 1433 | else return ts1.prepend(ts.head); |
duke@1 | 1434 | } |
duke@1 | 1435 | } |
duke@1 | 1436 | |
duke@1 | 1437 | /** Form the union of two type set lists. |
duke@1 | 1438 | */ |
duke@1 | 1439 | List<Type> union(List<Type> ts1, List<Type> ts2) { |
duke@1 | 1440 | List<Type> ts = ts1; |
duke@1 | 1441 | for (List<Type> l = ts2; l.nonEmpty(); l = l.tail) |
duke@1 | 1442 | ts = incl(l.head, ts); |
duke@1 | 1443 | return ts; |
duke@1 | 1444 | } |
duke@1 | 1445 | |
duke@1 | 1446 | /** Form the difference of two type lists. |
duke@1 | 1447 | */ |
duke@1 | 1448 | List<Type> diff(List<Type> ts1, List<Type> ts2) { |
duke@1 | 1449 | List<Type> ts = ts1; |
duke@1 | 1450 | for (List<Type> l = ts2; l.nonEmpty(); l = l.tail) |
duke@1 | 1451 | ts = excl(l.head, ts); |
duke@1 | 1452 | return ts; |
duke@1 | 1453 | } |
duke@1 | 1454 | |
duke@1 | 1455 | /** Form the intersection of two type lists. |
duke@1 | 1456 | */ |
duke@1 | 1457 | public List<Type> intersect(List<Type> ts1, List<Type> ts2) { |
duke@1 | 1458 | List<Type> ts = List.nil(); |
duke@1 | 1459 | for (List<Type> l = ts1; l.nonEmpty(); l = l.tail) |
duke@1 | 1460 | if (subset(l.head, ts2)) ts = incl(l.head, ts); |
duke@1 | 1461 | for (List<Type> l = ts2; l.nonEmpty(); l = l.tail) |
duke@1 | 1462 | if (subset(l.head, ts1)) ts = incl(l.head, ts); |
duke@1 | 1463 | return ts; |
duke@1 | 1464 | } |
duke@1 | 1465 | |
duke@1 | 1466 | /** Is exc an exception symbol that need not be declared? |
duke@1 | 1467 | */ |
duke@1 | 1468 | boolean isUnchecked(ClassSymbol exc) { |
duke@1 | 1469 | return |
duke@1 | 1470 | exc.kind == ERR || |
duke@1 | 1471 | exc.isSubClass(syms.errorType.tsym, types) || |
duke@1 | 1472 | exc.isSubClass(syms.runtimeExceptionType.tsym, types); |
duke@1 | 1473 | } |
duke@1 | 1474 | |
duke@1 | 1475 | /** Is exc an exception type that need not be declared? |
duke@1 | 1476 | */ |
duke@1 | 1477 | boolean isUnchecked(Type exc) { |
duke@1 | 1478 | return |
jjg@1374 | 1479 | (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) : |
jjg@1374 | 1480 | (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) : |
jjg@1374 | 1481 | exc.hasTag(BOT); |
duke@1 | 1482 | } |
duke@1 | 1483 | |
duke@1 | 1484 | /** Same, but handling completion failures. |
duke@1 | 1485 | */ |
duke@1 | 1486 | boolean isUnchecked(DiagnosticPosition pos, Type exc) { |
duke@1 | 1487 | try { |
duke@1 | 1488 | return isUnchecked(exc); |
duke@1 | 1489 | } catch (CompletionFailure ex) { |
duke@1 | 1490 | completionError(pos, ex); |
duke@1 | 1491 | return true; |
duke@1 | 1492 | } |
duke@1 | 1493 | } |
duke@1 | 1494 | |
duke@1 | 1495 | /** Is exc handled by given exception list? |
duke@1 | 1496 | */ |
duke@1 | 1497 | boolean isHandled(Type exc, List<Type> handled) { |
duke@1 | 1498 | return isUnchecked(exc) || subset(exc, handled); |
duke@1 | 1499 | } |
duke@1 | 1500 | |
duke@1 | 1501 | /** Return all exceptions in thrown list that are not in handled list. |
duke@1 | 1502 | * @param thrown The list of thrown exceptions. |
duke@1 | 1503 | * @param handled The list of handled exceptions. |
duke@1 | 1504 | */ |
mcimadamore@362 | 1505 | List<Type> unhandled(List<Type> thrown, List<Type> handled) { |
duke@1 | 1506 | List<Type> unhandled = List.nil(); |
duke@1 | 1507 | for (List<Type> l = thrown; l.nonEmpty(); l = l.tail) |
duke@1 | 1508 | if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head); |
duke@1 | 1509 | return unhandled; |
duke@1 | 1510 | } |
duke@1 | 1511 | |
duke@1 | 1512 | /* ************************************************************************* |
duke@1 | 1513 | * Overriding/Implementation checking |
duke@1 | 1514 | **************************************************************************/ |
duke@1 | 1515 | |
duke@1 | 1516 | /** The level of access protection given by a flag set, |
duke@1 | 1517 | * where PRIVATE is highest and PUBLIC is lowest. |
duke@1 | 1518 | */ |
duke@1 | 1519 | static int protection(long flags) { |
duke@1 | 1520 | switch ((short)(flags & AccessFlags)) { |
duke@1 | 1521 | case PRIVATE: return 3; |
duke@1 | 1522 | case PROTECTED: return 1; |
duke@1 | 1523 | default: |
duke@1 | 1524 | case PUBLIC: return 0; |
duke@1 | 1525 | case 0: return 2; |
duke@1 | 1526 | } |
duke@1 | 1527 | } |
duke@1 | 1528 | |
duke@1 | 1529 | /** A customized "cannot override" error message. |
duke@1 | 1530 | * @param m The overriding method. |
duke@1 | 1531 | * @param other The overridden method. |
duke@1 | 1532 | * @return An internationalized string. |
duke@1 | 1533 | */ |
mcimadamore@89 | 1534 | Object cannotOverride(MethodSymbol m, MethodSymbol other) { |
duke@1 | 1535 | String key; |
duke@1 | 1536 | if ((other.owner.flags() & INTERFACE) == 0) |
duke@1 | 1537 | key = "cant.override"; |
duke@1 | 1538 | else if ((m.owner.flags() & INTERFACE) == 0) |
duke@1 | 1539 | key = "cant.implement"; |
duke@1 | 1540 | else |
duke@1 | 1541 | key = "clashes.with"; |
mcimadamore@89 | 1542 | return diags.fragment(key, m, m.location(), other, other.location()); |
duke@1 | 1543 | } |
duke@1 | 1544 | |
duke@1 | 1545 | /** A customized "override" warning message. |
duke@1 | 1546 | * @param m The overriding method. |
duke@1 | 1547 | * @param other The overridden method. |
duke@1 | 1548 | * @return An internationalized string. |
duke@1 | 1549 | */ |
mcimadamore@89 | 1550 | Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) { |
duke@1 | 1551 | String key; |
duke@1 | 1552 | if ((other.owner.flags() & INTERFACE) == 0) |
duke@1 | 1553 | key = "unchecked.override"; |
duke@1 | 1554 | else if ((m.owner.flags() & INTERFACE) == 0) |
duke@1 | 1555 | key = "unchecked.implement"; |
duke@1 | 1556 | else |
duke@1 | 1557 | key = "unchecked.clash.with"; |
mcimadamore@89 | 1558 | return diags.fragment(key, m, m.location(), other, other.location()); |
duke@1 | 1559 | } |
duke@1 | 1560 | |
duke@1 | 1561 | /** A customized "override" warning message. |
duke@1 | 1562 | * @param m The overriding method. |
duke@1 | 1563 | * @param other The overridden method. |
duke@1 | 1564 | * @return An internationalized string. |
duke@1 | 1565 | */ |
mcimadamore@89 | 1566 | Object varargsOverrides(MethodSymbol m, MethodSymbol other) { |
duke@1 | 1567 | String key; |
duke@1 | 1568 | if ((other.owner.flags() & INTERFACE) == 0) |
duke@1 | 1569 | key = "varargs.override"; |
duke@1 | 1570 | else if ((m.owner.flags() & INTERFACE) == 0) |
duke@1 | 1571 | key = "varargs.implement"; |
duke@1 | 1572 | else |
duke@1 | 1573 | key = "varargs.clash.with"; |
mcimadamore@89 | 1574 | return diags.fragment(key, m, m.location(), other, other.location()); |
duke@1 | 1575 | } |
duke@1 | 1576 | |
duke@1 | 1577 | /** Check that this method conforms with overridden method 'other'. |
duke@1 | 1578 | * where `origin' is the class where checking started. |
duke@1 | 1579 | * Complications: |
duke@1 | 1580 | * (1) Do not check overriding of synthetic methods |
duke@1 | 1581 | * (reason: they might be final). |
duke@1 | 1582 | * todo: check whether this is still necessary. |
duke@1 | 1583 | * (2) Admit the case where an interface proxy throws fewer exceptions |
duke@1 | 1584 | * than the method it implements. Augment the proxy methods with the |
duke@1 | 1585 | * undeclared exceptions in this case. |
duke@1 | 1586 | * (3) When generics are enabled, admit the case where an interface proxy |
duke@1 | 1587 | * has a result type |
duke@1 | 1588 | * extended by the result type of the method it implements. |
duke@1 | 1589 | * Change the proxies result type to the smaller type in this case. |
duke@1 | 1590 | * |
duke@1 | 1591 | * @param tree The tree from which positions |
duke@1 | 1592 | * are extracted for errors. |
duke@1 | 1593 | * @param m The overriding method. |
duke@1 | 1594 | * @param other The overridden method. |
duke@1 | 1595 | * @param origin The class of which the overriding method |
duke@1 | 1596 | * is a member. |
duke@1 | 1597 | */ |
duke@1 | 1598 | void checkOverride(JCTree tree, |
duke@1 | 1599 | MethodSymbol m, |
duke@1 | 1600 | MethodSymbol other, |
duke@1 | 1601 | ClassSymbol origin) { |
duke@1 | 1602 | // Don't check overriding of synthetic methods or by bridge methods. |
duke@1 | 1603 | if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) { |
duke@1 | 1604 | return; |
duke@1 | 1605 | } |
duke@1 | 1606 | |
duke@1 | 1607 | // Error if static method overrides instance method (JLS 8.4.6.2). |
duke@1 | 1608 | if ((m.flags() & STATIC) != 0 && |
duke@1 | 1609 | (other.flags() & STATIC) == 0) { |
duke@1 | 1610 | log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static", |
duke@1 | 1611 | cannotOverride(m, other)); |
vromero@1588 | 1612 | m.flags_field |= BAD_OVERRIDE; |
duke@1 | 1613 | return; |
duke@1 | 1614 | } |
duke@1 | 1615 | |
duke@1 | 1616 | // Error if instance method overrides static or final |
duke@1 | 1617 | // method (JLS 8.4.6.1). |
duke@1 | 1618 | if ((other.flags() & FINAL) != 0 || |
duke@1 | 1619 | (m.flags() & STATIC) == 0 && |
duke@1 | 1620 | (other.flags() & STATIC) != 0) { |
duke@1 | 1621 | log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth", |
duke@1 | 1622 | cannotOverride(m, other), |
mcimadamore@80 | 1623 | asFlagSet(other.flags() & (FINAL | STATIC))); |
vromero@1588 | 1624 | m.flags_field |= BAD_OVERRIDE; |
duke@1 | 1625 | return; |
duke@1 | 1626 | } |
duke@1 | 1627 | |
duke@1 | 1628 | if ((m.owner.flags() & ANNOTATION) != 0) { |
duke@1 | 1629 | // handled in validateAnnotationMethod |
duke@1 | 1630 | return; |
duke@1 | 1631 | } |
duke@1 | 1632 | |
duke@1 | 1633 | // Error if overriding method has weaker access (JLS 8.4.6.3). |
duke@1 | 1634 | if ((origin.flags() & INTERFACE) == 0 && |
duke@1 | 1635 | protection(m.flags()) > protection(other.flags())) { |
duke@1 | 1636 | log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access", |
duke@1 | 1637 | cannotOverride(m, other), |
mcimadamore@80 | 1638 | other.flags() == 0 ? |
vromero@1842 | 1639 | "package" : |
mcimadamore@80 | 1640 | asFlagSet(other.flags() & AccessFlags)); |
vromero@1588 | 1641 | m.flags_field |= BAD_OVERRIDE; |
duke@1 | 1642 | return; |
duke@1 | 1643 | } |
duke@1 | 1644 | |
duke@1 | 1645 | Type mt = types.memberType(origin.type, m); |
duke@1 | 1646 | Type ot = types.memberType(origin.type, other); |
duke@1 | 1647 | // Error if overriding result type is different |
duke@1 | 1648 | // (or, in the case of generics mode, not a subtype) of |
duke@1 | 1649 | // overridden result type. We have to rename any type parameters |
duke@1 | 1650 | // before comparing types. |
duke@1 | 1651 | List<Type> mtvars = mt.getTypeArguments(); |
duke@1 | 1652 | List<Type> otvars = ot.getTypeArguments(); |
duke@1 | 1653 | Type mtres = mt.getReturnType(); |
duke@1 | 1654 | Type otres = types.subst(ot.getReturnType(), otvars, mtvars); |
duke@1 | 1655 | |
mcimadamore@795 | 1656 | overrideWarner.clear(); |
duke@1 | 1657 | boolean resultTypesOK = |
tbell@202 | 1658 | types.returnTypeSubstitutable(mt, ot, otres, overrideWarner); |
duke@1 | 1659 | if (!resultTypesOK) { |
jjg@398 | 1660 | if (!allowCovariantReturns && |
duke@1 | 1661 | m.owner != origin && |
duke@1 | 1662 | m.owner.isSubClass(other.owner, types)) { |
duke@1 | 1663 | // allow limited interoperability with covariant returns |
duke@1 | 1664 | } else { |
mcimadamore@362 | 1665 | log.error(TreeInfo.diagnosticPositionFor(m, tree), |
mcimadamore@362 | 1666 | "override.incompatible.ret", |
mcimadamore@362 | 1667 | cannotOverride(m, other), |
duke@1 | 1668 | mtres, otres); |
vromero@1588 | 1669 | m.flags_field |= BAD_OVERRIDE; |
duke@1 | 1670 | return; |
duke@1 | 1671 | } |
mcimadamore@795 | 1672 | } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) { |
duke@1 | 1673 | warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree), |
mcimadamore@362 | 1674 | "override.unchecked.ret", |
mcimadamore@362 | 1675 | uncheckedOverrides(m, other), |
mcimadamore@362 | 1676 | mtres, otres); |
duke@1 | 1677 | } |
duke@1 | 1678 | |
duke@1 | 1679 | // Error if overriding method throws an exception not reported |
duke@1 | 1680 | // by overridden method. |
duke@1 | 1681 | List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars); |
mcimadamore@362 | 1682 | List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown)); |
mcimadamore@362 | 1683 | List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown); |
mcimadamore@362 | 1684 | if (unhandledErased.nonEmpty()) { |
duke@1 | 1685 | log.error(TreeInfo.diagnosticPositionFor(m, tree), |
duke@1 | 1686 | "override.meth.doesnt.throw", |
duke@1 | 1687 | cannotOverride(m, other), |
mcimadamore@362 | 1688 | unhandledUnerased.head); |
vromero@1588 | 1689 | m.flags_field |= BAD_OVERRIDE; |
mcimadamore@362 | 1690 | return; |
mcimadamore@362 | 1691 | } |
mcimadamore@362 | 1692 | else if (unhandledUnerased.nonEmpty()) { |
mcimadamore@362 | 1693 | warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree), |
mcimadamore@362 | 1694 | "override.unchecked.thrown", |
mcimadamore@362 | 1695 | cannotOverride(m, other), |
mcimadamore@362 | 1696 | unhandledUnerased.head); |
duke@1 | 1697 | return; |
duke@1 | 1698 | } |
duke@1 | 1699 | |
duke@1 | 1700 | // Optional warning if varargs don't agree |
duke@1 | 1701 | if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0) |
mcimadamore@795 | 1702 | && lint.isEnabled(LintCategory.OVERRIDES)) { |
duke@1 | 1703 | log.warning(TreeInfo.diagnosticPositionFor(m, tree), |
duke@1 | 1704 | ((m.flags() & Flags.VARARGS) != 0) |
duke@1 | 1705 | ? "override.varargs.missing" |
duke@1 | 1706 | : "override.varargs.extra", |
duke@1 | 1707 | varargsOverrides(m, other)); |
duke@1 | 1708 | } |
duke@1 | 1709 | |
duke@1 | 1710 | // Warn if instance method overrides bridge method (compiler spec ??) |
duke@1 | 1711 | if ((other.flags() & BRIDGE) != 0) { |
duke@1 | 1712 | log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge", |
duke@1 | 1713 | uncheckedOverrides(m, other)); |
duke@1 | 1714 | } |
duke@1 | 1715 | |
duke@1 | 1716 | // Warn if a deprecated method overridden by a non-deprecated one. |
mcimadamore@852 | 1717 | if (!isDeprecatedOverrideIgnorable(other, origin)) { |
jlahoda@2553 | 1718 | Lint prevLint = setLint(lint.augment(m)); |
jlahoda@2553 | 1719 | try { |
jlahoda@2553 | 1720 | checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other); |
jlahoda@2553 | 1721 | } finally { |
jlahoda@2553 | 1722 | setLint(prevLint); |
jlahoda@2553 | 1723 | } |
duke@1 | 1724 | } |
duke@1 | 1725 | } |
duke@1 | 1726 | // where |
duke@1 | 1727 | private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) { |
duke@1 | 1728 | // If the method, m, is defined in an interface, then ignore the issue if the method |
duke@1 | 1729 | // is only inherited via a supertype and also implemented in the supertype, |
duke@1 | 1730 | // because in that case, we will rediscover the issue when examining the method |
duke@1 | 1731 | // in the supertype. |
duke@1 | 1732 | // If the method, m, is not defined in an interface, then the only time we need to |
duke@1 | 1733 | // address the issue is when the method is the supertype implemementation: any other |
duke@1 | 1734 | // case, we will have dealt with when examining the supertype classes |
duke@1 | 1735 | ClassSymbol mc = m.enclClass(); |
duke@1 | 1736 | Type st = types.supertype(origin.type); |
jjg@1374 | 1737 | if (!st.hasTag(CLASS)) |
duke@1 | 1738 | return true; |
duke@1 | 1739 | MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false); |
duke@1 | 1740 | |
duke@1 | 1741 | if (mc != null && ((mc.flags() & INTERFACE) != 0)) { |
duke@1 | 1742 | List<Type> intfs = types.interfaces(origin.type); |
duke@1 | 1743 | return (intfs.contains(mc.type) ? false : (stimpl != null)); |
duke@1 | 1744 | } |
duke@1 | 1745 | else |
duke@1 | 1746 | return (stimpl != m); |
duke@1 | 1747 | } |
duke@1 | 1748 | |
duke@1 | 1749 | |
duke@1 | 1750 | // used to check if there were any unchecked conversions |
duke@1 | 1751 | Warner overrideWarner = new Warner(); |
duke@1 | 1752 | |
duke@1 | 1753 | /** Check that a class does not inherit two concrete methods |
duke@1 | 1754 | * with the same signature. |
duke@1 | 1755 | * @param pos Position to be used for error reporting. |
duke@1 | 1756 | * @param site The class type to be checked. |
duke@1 | 1757 | */ |
duke@1 | 1758 | public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) { |
duke@1 | 1759 | Type sup = types.supertype(site); |
jjg@1374 | 1760 | if (!sup.hasTag(CLASS)) return; |
duke@1 | 1761 | |
duke@1 | 1762 | for (Type t1 = sup; |
jlahoda@1956 | 1763 | t1.hasTag(CLASS) && t1.tsym.type.isParameterized(); |
duke@1 | 1764 | t1 = types.supertype(t1)) { |
duke@1 | 1765 | for (Scope.Entry e1 = t1.tsym.members().elems; |
duke@1 | 1766 | e1 != null; |
duke@1 | 1767 | e1 = e1.sibling) { |
duke@1 | 1768 | Symbol s1 = e1.sym; |
duke@1 | 1769 | if (s1.kind != MTH || |
duke@1 | 1770 | (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 || |
duke@1 | 1771 | !s1.isInheritedIn(site.tsym, types) || |
duke@1 | 1772 | ((MethodSymbol)s1).implementation(site.tsym, |
duke@1 | 1773 | types, |
duke@1 | 1774 | true) != s1) |
duke@1 | 1775 | continue; |
duke@1 | 1776 | Type st1 = types.memberType(t1, s1); |
duke@1 | 1777 | int s1ArgsLength = st1.getParameterTypes().length(); |
duke@1 | 1778 | if (st1 == s1.type) continue; |
duke@1 | 1779 | |
duke@1 | 1780 | for (Type t2 = sup; |
jjg@1374 | 1781 | t2.hasTag(CLASS); |
duke@1 | 1782 | t2 = types.supertype(t2)) { |
mcimadamore@24 | 1783 | for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); |
duke@1 | 1784 | e2.scope != null; |
duke@1 | 1785 | e2 = e2.next()) { |
duke@1 | 1786 | Symbol s2 = e2.sym; |
duke@1 | 1787 | if (s2 == s1 || |
duke@1 | 1788 | s2.kind != MTH || |
duke@1 | 1789 | (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 || |
duke@1 | 1790 | s2.type.getParameterTypes().length() != s1ArgsLength || |
duke@1 | 1791 | !s2.isInheritedIn(site.tsym, types) || |
duke@1 | 1792 | ((MethodSymbol)s2).implementation(site.tsym, |
duke@1 | 1793 | types, |
duke@1 | 1794 | true) != s2) |
duke@1 | 1795 | continue; |
duke@1 | 1796 | Type st2 = types.memberType(t2, s2); |
duke@1 | 1797 | if (types.overrideEquivalent(st1, st2)) |
duke@1 | 1798 | log.error(pos, "concrete.inheritance.conflict", |
duke@1 | 1799 | s1, t1, s2, t2, sup); |
duke@1 | 1800 | } |
duke@1 | 1801 | } |
duke@1 | 1802 | } |
duke@1 | 1803 | } |
duke@1 | 1804 | } |
duke@1 | 1805 | |
duke@1 | 1806 | /** Check that classes (or interfaces) do not each define an abstract |
duke@1 | 1807 | * method with same name and arguments but incompatible return types. |
duke@1 | 1808 | * @param pos Position to be used for error reporting. |
duke@1 | 1809 | * @param t1 The first argument type. |
duke@1 | 1810 | * @param t2 The second argument type. |
duke@1 | 1811 | */ |
duke@1 | 1812 | public boolean checkCompatibleAbstracts(DiagnosticPosition pos, |
duke@1 | 1813 | Type t1, |
duke@1 | 1814 | Type t2) { |
duke@1 | 1815 | return checkCompatibleAbstracts(pos, t1, t2, |
duke@1 | 1816 | types.makeCompoundType(t1, t2)); |
duke@1 | 1817 | } |
duke@1 | 1818 | |
duke@1 | 1819 | public boolean checkCompatibleAbstracts(DiagnosticPosition pos, |
duke@1 | 1820 | Type t1, |
duke@1 | 1821 | Type t2, |
duke@1 | 1822 | Type site) { |
dlsmith@2419 | 1823 | if ((site.tsym.flags() & COMPOUND) != 0) { |
dlsmith@2419 | 1824 | // special case for intersections: need to eliminate wildcards in supertypes |
dlsmith@2419 | 1825 | t1 = types.capture(t1); |
dlsmith@2419 | 1826 | t2 = types.capture(t2); |
dlsmith@2419 | 1827 | } |
mcimadamore@746 | 1828 | return firstIncompatibility(pos, t1, t2, site) == null; |
duke@1 | 1829 | } |
duke@1 | 1830 | |
duke@1 | 1831 | /** Return the first method which is defined with same args |
duke@1 | 1832 | * but different return types in two given interfaces, or null if none |
duke@1 | 1833 | * exists. |
duke@1 | 1834 | * @param t1 The first type. |
duke@1 | 1835 | * @param t2 The second type. |
duke@1 | 1836 | * @param site The most derived type. |
duke@1 | 1837 | * @returns symbol from t2 that conflicts with one in t1. |
duke@1 | 1838 | */ |
mcimadamore@746 | 1839 | private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) { |
duke@1 | 1840 | Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>(); |
duke@1 | 1841 | closure(t1, interfaces1); |
duke@1 | 1842 | Map<TypeSymbol,Type> interfaces2; |
duke@1 | 1843 | if (t1 == t2) |
duke@1 | 1844 | interfaces2 = interfaces1; |
duke@1 | 1845 | else |
duke@1 | 1846 | closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>()); |
duke@1 | 1847 | |
duke@1 | 1848 | for (Type t3 : interfaces1.values()) { |
duke@1 | 1849 | for (Type t4 : interfaces2.values()) { |
mcimadamore@746 | 1850 | Symbol s = firstDirectIncompatibility(pos, t3, t4, site); |
duke@1 | 1851 | if (s != null) return s; |
duke@1 | 1852 | } |
duke@1 | 1853 | } |
duke@1 | 1854 | return null; |
duke@1 | 1855 | } |
duke@1 | 1856 | |
duke@1 | 1857 | /** Compute all the supertypes of t, indexed by type symbol. */ |
duke@1 | 1858 | private void closure(Type t, Map<TypeSymbol,Type> typeMap) { |
jjg@1374 | 1859 | if (!t.hasTag(CLASS)) return; |
duke@1 | 1860 | if (typeMap.put(t.tsym, t) == null) { |
duke@1 | 1861 | closure(types.supertype(t), typeMap); |
duke@1 | 1862 | for (Type i : types.interfaces(t)) |
duke@1 | 1863 | closure(i, typeMap); |
duke@1 | 1864 | } |
duke@1 | 1865 | } |
duke@1 | 1866 | |
duke@1 | 1867 | /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */ |
duke@1 | 1868 | private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) { |
jjg@1374 | 1869 | if (!t.hasTag(CLASS)) return; |
duke@1 | 1870 | if (typesSkip.get(t.tsym) != null) return; |
duke@1 | 1871 | if (typeMap.put(t.tsym, t) == null) { |
duke@1 | 1872 | closure(types.supertype(t), typesSkip, typeMap); |
duke@1 | 1873 | for (Type i : types.interfaces(t)) |
duke@1 | 1874 | closure(i, typesSkip, typeMap); |
duke@1 | 1875 | } |
duke@1 | 1876 | } |
duke@1 | 1877 | |
duke@1 | 1878 | /** Return the first method in t2 that conflicts with a method from t1. */ |
mcimadamore@746 | 1879 | private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) { |
duke@1 | 1880 | for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) { |
duke@1 | 1881 | Symbol s1 = e1.sym; |
duke@1 | 1882 | Type st1 = null; |
mcimadamore@1441 | 1883 | if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) || |
mcimadamore@1441 | 1884 | (s1.flags() & SYNTHETIC) != 0) continue; |
duke@1 | 1885 | Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false); |
duke@1 | 1886 | if (impl != null && (impl.flags() & ABSTRACT) == 0) continue; |
duke@1 | 1887 | for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) { |
duke@1 | 1888 | Symbol s2 = e2.sym; |
duke@1 | 1889 | if (s1 == s2) continue; |
mcimadamore@1441 | 1890 | if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) || |
mcimadamore@1441 | 1891 | (s2.flags() & SYNTHETIC) != 0) continue; |
duke@1 | 1892 | if (st1 == null) st1 = types.memberType(t1, s1); |
duke@1 | 1893 | Type st2 = types.memberType(t2, s2); |
duke@1 | 1894 | if (types.overrideEquivalent(st1, st2)) { |
duke@1 | 1895 | List<Type> tvars1 = st1.getTypeArguments(); |
duke@1 | 1896 | List<Type> tvars2 = st2.getTypeArguments(); |
duke@1 | 1897 | Type rt1 = st1.getReturnType(); |
duke@1 | 1898 | Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1); |
duke@1 | 1899 | boolean compat = |
duke@1 | 1900 | types.isSameType(rt1, rt2) || |
jjg@1374 | 1901 | !rt1.isPrimitiveOrVoid() && |
jjg@1374 | 1902 | !rt2.isPrimitiveOrVoid() && |
mcimadamore@1415 | 1903 | (types.covariantReturnType(rt1, rt2, types.noWarnings) || |
mcimadamore@1415 | 1904 | types.covariantReturnType(rt2, rt1, types.noWarnings)) || |
mcimadamore@59 | 1905 | checkCommonOverriderIn(s1,s2,site); |
mcimadamore@746 | 1906 | if (!compat) { |
mcimadamore@746 | 1907 | log.error(pos, "types.incompatible.diff.ret", |
mcimadamore@746 | 1908 | t1, t2, s2.name + |
mcimadamore@746 | 1909 | "(" + types.memberType(t2, s2).getParameterTypes() + ")"); |
mcimadamore@746 | 1910 | return s2; |
mcimadamore@746 | 1911 | } |
mcimadamore@889 | 1912 | } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) && |
mcimadamore@889 | 1913 | !checkCommonOverriderIn(s1, s2, site)) { |
mcimadamore@746 | 1914 | log.error(pos, |
mcimadamore@746 | 1915 | "name.clash.same.erasure.no.override", |
mcimadamore@746 | 1916 | s1, s1.location(), |
mcimadamore@746 | 1917 | s2, s2.location()); |
mcimadamore@746 | 1918 | return s2; |
duke@1 | 1919 | } |
duke@1 | 1920 | } |
duke@1 | 1921 | } |
duke@1 | 1922 | return null; |
duke@1 | 1923 | } |
mcimadamore@59 | 1924 | //WHERE |
mcimadamore@59 | 1925 | boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) { |
mcimadamore@59 | 1926 | Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>(); |
mcimadamore@59 | 1927 | Type st1 = types.memberType(site, s1); |
mcimadamore@59 | 1928 | Type st2 = types.memberType(site, s2); |
mcimadamore@59 | 1929 | closure(site, supertypes); |
mcimadamore@59 | 1930 | for (Type t : supertypes.values()) { |
mcimadamore@59 | 1931 | for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) { |
mcimadamore@59 | 1932 | Symbol s3 = e.sym; |
mcimadamore@59 | 1933 | if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue; |
mcimadamore@59 | 1934 | Type st3 = types.memberType(site,s3); |
mcimadamore@1811 | 1935 | if (types.overrideEquivalent(st3, st1) && |
mcimadamore@1811 | 1936 | types.overrideEquivalent(st3, st2) && |
mcimadamore@1811 | 1937 | types.returnTypeSubstitutable(st3, st1) && |
mcimadamore@1811 | 1938 | types.returnTypeSubstitutable(st3, st2)) { |
mcimadamore@1811 | 1939 | return true; |
mcimadamore@59 | 1940 | } |
mcimadamore@59 | 1941 | } |
mcimadamore@59 | 1942 | } |
mcimadamore@59 | 1943 | return false; |
mcimadamore@59 | 1944 | } |
duke@1 | 1945 | |
duke@1 | 1946 | /** Check that a given method conforms with any method it overrides. |
duke@1 | 1947 | * @param tree The tree from which positions are extracted |
duke@1 | 1948 | * for errors. |
duke@1 | 1949 | * @param m The overriding method. |
duke@1 | 1950 | */ |
jlahoda@2111 | 1951 | void checkOverride(JCMethodDecl tree, MethodSymbol m) { |
duke@1 | 1952 | ClassSymbol origin = (ClassSymbol)m.owner; |
duke@1 | 1953 | if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name)) |
duke@1 | 1954 | if (m.overrides(syms.enumFinalFinalize, origin, types, false)) { |
duke@1 | 1955 | log.error(tree.pos(), "enum.no.finalize"); |
duke@1 | 1956 | return; |
duke@1 | 1957 | } |
jjg@1374 | 1958 | for (Type t = origin.type; t.hasTag(CLASS); |
duke@1 | 1959 | t = types.supertype(t)) { |
mcimadamore@746 | 1960 | if (t != origin.type) { |
mcimadamore@746 | 1961 | checkOverride(tree, t, origin, m); |
mcimadamore@746 | 1962 | } |
mcimadamore@746 | 1963 | for (Type t2 : types.interfaces(t)) { |
mcimadamore@746 | 1964 | checkOverride(tree, t2, origin, m); |
duke@1 | 1965 | } |
duke@1 | 1966 | } |
jlahoda@2111 | 1967 | |
jlahoda@2111 | 1968 | if (m.attribute(syms.overrideType.tsym) != null && !isOverrider(m)) { |
jlahoda@2111 | 1969 | DiagnosticPosition pos = tree.pos(); |
jlahoda@2111 | 1970 | for (JCAnnotation a : tree.getModifiers().annotations) { |
jlahoda@2111 | 1971 | if (a.annotationType.type.tsym == syms.overrideType.tsym) { |
jlahoda@2111 | 1972 | pos = a.pos(); |
jlahoda@2111 | 1973 | break; |
jlahoda@2111 | 1974 | } |
jlahoda@2111 | 1975 | } |
jlahoda@2111 | 1976 | log.error(pos, "method.does.not.override.superclass"); |
jlahoda@2111 | 1977 | } |
duke@1 | 1978 | } |
duke@1 | 1979 | |
mcimadamore@746 | 1980 | void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) { |
mcimadamore@746 | 1981 | TypeSymbol c = site.tsym; |
mcimadamore@746 | 1982 | Scope.Entry e = c.members().lookup(m.name); |
mcimadamore@746 | 1983 | while (e.scope != null) { |
mcimadamore@746 | 1984 | if (m.overrides(e.sym, origin, types, false)) { |
mcimadamore@746 | 1985 | if ((e.sym.flags() & ABSTRACT) == 0) { |
mcimadamore@746 | 1986 | checkOverride(tree, m, (MethodSymbol)e.sym, origin); |
mcimadamore@746 | 1987 | } |
mcimadamore@746 | 1988 | } |
mcimadamore@746 | 1989 | e = e.next(); |
mcimadamore@746 | 1990 | } |
mcimadamore@746 | 1991 | } |
mcimadamore@746 | 1992 | |
vromero@1607 | 1993 | private Filter<Symbol> equalsHasCodeFilter = new Filter<Symbol>() { |
vromero@1607 | 1994 | public boolean accepts(Symbol s) { |
vromero@1607 | 1995 | return MethodSymbol.implementation_filter.accepts(s) && |
vromero@1607 | 1996 | (s.flags() & BAD_OVERRIDE) == 0; |
vromero@1607 | 1997 | |
vromero@1607 | 1998 | } |
vromero@1607 | 1999 | }; |
vromero@1607 | 2000 | |
vromero@1620 | 2001 | public void checkClassOverrideEqualsAndHashIfNeeded(DiagnosticPosition pos, |
vromero@1620 | 2002 | ClassSymbol someClass) { |
vromero@1620 | 2003 | /* At present, annotations cannot possibly have a method that is override |
vromero@1620 | 2004 | * equivalent with Object.equals(Object) but in any case the condition is |
vromero@1620 | 2005 | * fine for completeness. |
vromero@1620 | 2006 | */ |
vromero@1620 | 2007 | if (someClass == (ClassSymbol)syms.objectType.tsym || |
vromero@1620 | 2008 | someClass.isInterface() || someClass.isEnum() || |
vromero@1620 | 2009 | (someClass.flags() & ANNOTATION) != 0 || |
vromero@1620 | 2010 | (someClass.flags() & ABSTRACT) != 0) return; |
vromero@1620 | 2011 | //anonymous inner classes implementing interfaces need especial treatment |
vromero@1620 | 2012 | if (someClass.isAnonymous()) { |
vromero@1620 | 2013 | List<Type> interfaces = types.interfaces(someClass.type); |
vromero@1620 | 2014 | if (interfaces != null && !interfaces.isEmpty() && |
vromero@1620 | 2015 | interfaces.head.tsym == syms.comparatorType.tsym) return; |
vromero@1620 | 2016 | } |
vromero@1620 | 2017 | checkClassOverrideEqualsAndHash(pos, someClass); |
vromero@1620 | 2018 | } |
vromero@1620 | 2019 | |
vromero@1620 | 2020 | private void checkClassOverrideEqualsAndHash(DiagnosticPosition pos, |
vromero@1607 | 2021 | ClassSymbol someClass) { |
vromero@1588 | 2022 | if (lint.isEnabled(LintCategory.OVERRIDES)) { |
vromero@1607 | 2023 | MethodSymbol equalsAtObject = (MethodSymbol)syms.objectType |
vromero@1607 | 2024 | .tsym.members().lookup(names.equals).sym; |
vromero@1607 | 2025 | MethodSymbol hashCodeAtObject = (MethodSymbol)syms.objectType |
vromero@1607 | 2026 | .tsym.members().lookup(names.hashCode).sym; |
vromero@1607 | 2027 | boolean overridesEquals = types.implementation(equalsAtObject, |
vromero@1607 | 2028 | someClass, false, equalsHasCodeFilter).owner == someClass; |
vromero@1607 | 2029 | boolean overridesHashCode = types.implementation(hashCodeAtObject, |
vromero@1607 | 2030 | someClass, false, equalsHasCodeFilter) != hashCodeAtObject; |
vromero@1607 | 2031 | |
vromero@1607 | 2032 | if (overridesEquals && !overridesHashCode) { |
vromero@1607 | 2033 | log.warning(LintCategory.OVERRIDES, pos, |
vromero@1620 | 2034 | "override.equals.but.not.hashcode", someClass); |
vromero@1588 | 2035 | } |
vromero@1588 | 2036 | } |
vromero@1588 | 2037 | } |
vromero@1588 | 2038 | |
mcimadamore@746 | 2039 | private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) { |
mcimadamore@858 | 2040 | ClashFilter cf = new ClashFilter(origin.type); |
mcimadamore@858 | 2041 | return (cf.accepts(s1) && |
mcimadamore@858 | 2042 | cf.accepts(s2) && |
mcimadamore@858 | 2043 | types.hasSameArgs(s1.erasure(types), s2.erasure(types))); |
mcimadamore@746 | 2044 | } |
mcimadamore@746 | 2045 | |
mcimadamore@746 | 2046 | |
duke@1 | 2047 | /** Check that all abstract members of given class have definitions. |
duke@1 | 2048 | * @param pos Position to be used for error reporting. |
duke@1 | 2049 | * @param c The class. |
duke@1 | 2050 | */ |
duke@1 | 2051 | void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) { |
duke@1 | 2052 | try { |
duke@1 | 2053 | MethodSymbol undef = firstUndef(c, c); |
duke@1 | 2054 | if (undef != null) { |
duke@1 | 2055 | if ((c.flags() & ENUM) != 0 && |
duke@1 | 2056 | types.supertype(c.type).tsym == syms.enumSym && |
duke@1 | 2057 | (c.flags() & FINAL) == 0) { |
duke@1 | 2058 | // add the ABSTRACT flag to an enum |
duke@1 | 2059 | c.flags_field |= ABSTRACT; |
duke@1 | 2060 | } else { |
duke@1 | 2061 | MethodSymbol undef1 = |
duke@1 | 2062 | new MethodSymbol(undef.flags(), undef.name, |
duke@1 | 2063 | types.memberType(c.type, undef), undef.owner); |
duke@1 | 2064 | log.error(pos, "does.not.override.abstract", |
duke@1 | 2065 | c, undef1, undef1.location()); |
duke@1 | 2066 | } |
duke@1 | 2067 | } |
duke@1 | 2068 | } catch (CompletionFailure ex) { |
duke@1 | 2069 | completionError(pos, ex); |
duke@1 | 2070 | } |
duke@1 | 2071 | } |
duke@1 | 2072 | //where |
duke@1 | 2073 | /** Return first abstract member of class `c' that is not defined |
duke@1 | 2074 | * in `impl', null if there is none. |
duke@1 | 2075 | */ |
duke@1 | 2076 | private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) { |
duke@1 | 2077 | MethodSymbol undef = null; |
duke@1 | 2078 | // Do not bother to search in classes that are not abstract, |
duke@1 | 2079 | // since they cannot have abstract members. |
duke@1 | 2080 | if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) { |
duke@1 | 2081 | Scope s = c.members(); |
duke@1 | 2082 | for (Scope.Entry e = s.elems; |
duke@1 | 2083 | undef == null && e != null; |
duke@1 | 2084 | e = e.sibling) { |
duke@1 | 2085 | if (e.sym.kind == MTH && |
mcimadamore@1393 | 2086 | (e.sym.flags() & (ABSTRACT|IPROXY|DEFAULT)) == ABSTRACT) { |
duke@1 | 2087 | MethodSymbol absmeth = (MethodSymbol)e.sym; |
duke@1 | 2088 | MethodSymbol implmeth = absmeth.implementation(impl, types, true); |
mcimadamore@1393 | 2089 | if (implmeth == null || implmeth == absmeth) { |
mcimadamore@1393 | 2090 | //look for default implementations |
mcimadamore@1393 | 2091 | if (allowDefaultMethods) { |
mcimadamore@1393 | 2092 | MethodSymbol prov = types.interfaceCandidates(impl.type, absmeth).head; |
mcimadamore@1393 | 2093 | if (prov != null && prov.overrides(absmeth, impl, types, true)) { |
mcimadamore@1393 | 2094 | implmeth = prov; |
mcimadamore@1393 | 2095 | } |
mcimadamore@1393 | 2096 | } |
mcimadamore@1393 | 2097 | } |
mcimadamore@1393 | 2098 | if (implmeth == null || implmeth == absmeth) { |
duke@1 | 2099 | undef = absmeth; |
mcimadamore@1393 | 2100 | } |
duke@1 | 2101 | } |
duke@1 | 2102 | } |
duke@1 | 2103 | if (undef == null) { |
duke@1 | 2104 | Type st = types.supertype(c.type); |
jjg@1374 | 2105 | if (st.hasTag(CLASS)) |
duke@1 | 2106 | undef = firstUndef(impl, (ClassSymbol)st.tsym); |
duke@1 | 2107 | } |
duke@1 | 2108 | for (List<Type> l = types.interfaces(c.type); |
duke@1 | 2109 | undef == null && l.nonEmpty(); |
duke@1 | 2110 | l = l.tail) { |
duke@1 | 2111 | undef = firstUndef(impl, (ClassSymbol)l.head.tsym); |
duke@1 | 2112 | } |
duke@1 | 2113 | } |
duke@1 | 2114 | return undef; |
duke@1 | 2115 | } |
duke@1 | 2116 | |
mcimadamore@690 | 2117 | void checkNonCyclicDecl(JCClassDecl tree) { |
mcimadamore@690 | 2118 | CycleChecker cc = new CycleChecker(); |
mcimadamore@690 | 2119 | cc.scan(tree); |
mcimadamore@690 | 2120 | if (!cc.errorFound && !cc.partialCheck) { |
mcimadamore@690 | 2121 | tree.sym.flags_field |= ACYCLIC; |
mcimadamore@690 | 2122 | } |
mcimadamore@690 | 2123 | } |
mcimadamore@690 | 2124 | |
mcimadamore@690 | 2125 | class CycleChecker extends TreeScanner { |
mcimadamore@690 | 2126 | |
mcimadamore@690 | 2127 | List<Symbol> seenClasses = List.nil(); |
mcimadamore@690 | 2128 | boolean errorFound = false; |
mcimadamore@690 | 2129 | boolean partialCheck = false; |
mcimadamore@690 | 2130 | |
mcimadamore@690 | 2131 | private void checkSymbol(DiagnosticPosition pos, Symbol sym) { |
mcimadamore@690 | 2132 | if (sym != null && sym.kind == TYP) { |
mcimadamore@690 | 2133 | Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym); |
mcimadamore@690 | 2134 | if (classEnv != null) { |
mcimadamore@690 | 2135 | DiagnosticSource prevSource = log.currentSource(); |
mcimadamore@690 | 2136 | try { |
mcimadamore@690 | 2137 | log.useSource(classEnv.toplevel.sourcefile); |
mcimadamore@690 | 2138 | scan(classEnv.tree); |
mcimadamore@690 | 2139 | } |
mcimadamore@690 | 2140 | finally { |
mcimadamore@690 | 2141 | log.useSource(prevSource.getFile()); |
mcimadamore@690 | 2142 | } |
mcimadamore@690 | 2143 | } else if (sym.kind == TYP) { |
mcimadamore@690 | 2144 | checkClass(pos, sym, List.<JCTree>nil()); |
mcimadamore@690 | 2145 | } |
mcimadamore@690 | 2146 | } else { |
mcimadamore@690 | 2147 | //not completed yet |
mcimadamore@690 | 2148 | partialCheck = true; |
mcimadamore@690 | 2149 | } |
mcimadamore@690 | 2150 | } |
mcimadamore@690 | 2151 | |
mcimadamore@690 | 2152 | @Override |
mcimadamore@690 | 2153 | public void visitSelect(JCFieldAccess tree) { |
mcimadamore@690 | 2154 | super.visitSelect(tree); |
mcimadamore@690 | 2155 | checkSymbol(tree.pos(), tree.sym); |
mcimadamore@690 | 2156 | } |
mcimadamore@690 | 2157 | |
mcimadamore@690 | 2158 | @Override |
mcimadamore@690 | 2159 | public void visitIdent(JCIdent tree) { |
mcimadamore@690 | 2160 | checkSymbol(tree.pos(), tree.sym); |
mcimadamore@690 | 2161 | } |
mcimadamore@690 | 2162 | |
mcimadamore@690 | 2163 | @Override |
mcimadamore@690 | 2164 | public void visitTypeApply(JCTypeApply tree) { |
mcimadamore@690 | 2165 | scan(tree.clazz); |
mcimadamore@690 | 2166 | } |
mcimadamore@690 | 2167 | |
mcimadamore@690 | 2168 | @Override |
mcimadamore@690 | 2169 | public void visitTypeArray(JCArrayTypeTree tree) { |
mcimadamore@690 | 2170 | scan(tree.elemtype); |
mcimadamore@690 | 2171 | } |
mcimadamore@690 | 2172 | |
mcimadamore@690 | 2173 | @Override |
mcimadamore@690 | 2174 | public void visitClassDef(JCClassDecl tree) { |
mcimadamore@690 | 2175 | List<JCTree> supertypes = List.nil(); |
mcimadamore@690 | 2176 | if (tree.getExtendsClause() != null) { |
mcimadamore@690 | 2177 | supertypes = supertypes.prepend(tree.getExtendsClause()); |
mcimadamore@690 | 2178 | } |
mcimadamore@690 | 2179 | if (tree.getImplementsClause() != null) { |
mcimadamore@690 | 2180 | for (JCTree intf : tree.getImplementsClause()) { |
mcimadamore@690 | 2181 | supertypes = supertypes.prepend(intf); |
mcimadamore@690 | 2182 | } |
mcimadamore@690 | 2183 | } |
mcimadamore@690 | 2184 | checkClass(tree.pos(), tree.sym, supertypes); |
mcimadamore@690 | 2185 | } |
mcimadamore@690 | 2186 | |
mcimadamore@690 | 2187 | void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) { |
mcimadamore@690 | 2188 | if ((c.flags_field & ACYCLIC) != 0) |
mcimadamore@690 | 2189 | return; |
mcimadamore@690 | 2190 | if (seenClasses.contains(c)) { |
mcimadamore@690 | 2191 | errorFound = true; |
mcimadamore@690 | 2192 | noteCyclic(pos, (ClassSymbol)c); |
mcimadamore@690 | 2193 | } else if (!c.type.isErroneous()) { |
mcimadamore@690 | 2194 | try { |
mcimadamore@690 | 2195 | seenClasses = seenClasses.prepend(c); |
jjg@1374 | 2196 | if (c.type.hasTag(CLASS)) { |
mcimadamore@690 | 2197 | if (supertypes.nonEmpty()) { |
mcimadamore@690 | 2198 | scan(supertypes); |
mcimadamore@690 | 2199 | } |
mcimadamore@690 | 2200 | else { |
mcimadamore@690 | 2201 | ClassType ct = (ClassType)c.type; |
mcimadamore@690 | 2202 | if (ct.supertype_field == null || |
mcimadamore@690 | 2203 | ct.interfaces_field == null) { |
mcimadamore@690 | 2204 | //not completed yet |
mcimadamore@690 | 2205 | partialCheck = true; |
mcimadamore@690 | 2206 | return; |
mcimadamore@690 | 2207 | } |
mcimadamore@690 | 2208 | checkSymbol(pos, ct.supertype_field.tsym); |
mcimadamore@690 | 2209 | for (Type intf : ct.interfaces_field) { |
mcimadamore@690 | 2210 | checkSymbol(pos, intf.tsym); |
mcimadamore@690 | 2211 | } |
mcimadamore@690 | 2212 | } |
mcimadamore@690 | 2213 | if (c.owner.kind == TYP) { |
mcimadamore@690 | 2214 | checkSymbol(pos, c.owner); |
mcimadamore@690 | 2215 | } |
mcimadamore@690 | 2216 | } |
mcimadamore@690 | 2217 | } finally { |
mcimadamore@690 | 2218 | seenClasses = seenClasses.tail; |
mcimadamore@690 | 2219 | } |
mcimadamore@690 | 2220 | } |
mcimadamore@690 | 2221 | } |
mcimadamore@690 | 2222 | } |
mcimadamore@690 | 2223 | |
duke@1 | 2224 | /** Check for cyclic references. Issue an error if the |
duke@1 | 2225 | * symbol of the type referred to has a LOCKED flag set. |
duke@1 | 2226 | * |
duke@1 | 2227 | * @param pos Position to be used for error reporting. |
duke@1 | 2228 | * @param t The type referred to. |
duke@1 | 2229 | */ |
duke@1 | 2230 | void checkNonCyclic(DiagnosticPosition pos, Type t) { |
duke@1 | 2231 | checkNonCyclicInternal(pos, t); |
duke@1 | 2232 | } |
duke@1 | 2233 | |
duke@1 | 2234 | |
duke@1 | 2235 | void checkNonCyclic(DiagnosticPosition pos, TypeVar t) { |
mcimadamore@236 | 2236 | checkNonCyclic1(pos, t, List.<TypeVar>nil()); |
duke@1 | 2237 | } |
duke@1 | 2238 | |
mcimadamore@236 | 2239 | private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) { |
duke@1 | 2240 | final TypeVar tv; |
jjg@1374 | 2241 | if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0) |
mcimadamore@42 | 2242 | return; |
duke@1 | 2243 | if (seen.contains(t)) { |
jjg@1978 | 2244 | tv = (TypeVar)t.unannotatedType(); |
jjg@110 | 2245 | tv.bound = types.createErrorType(t); |
duke@1 | 2246 | log.error(pos, "cyclic.inheritance", t); |
jjg@1374 | 2247 | } else if (t.hasTag(TYPEVAR)) { |
jjg@1978 | 2248 | tv = (TypeVar)t.unannotatedType(); |
mcimadamore@236 | 2249 | seen = seen.prepend(tv); |
duke@1 | 2250 | for (Type b : types.getBounds(tv)) |
duke@1 | 2251 | checkNonCyclic1(pos, b, seen); |
duke@1 | 2252 | } |
duke@1 | 2253 | } |
duke@1 | 2254 | |
duke@1 | 2255 | /** Check for cyclic references. Issue an error if the |
duke@1 | 2256 | * symbol of the type referred to has a LOCKED flag set. |
duke@1 | 2257 | * |
duke@1 | 2258 | * @param pos Position to be used for error reporting. |
duke@1 | 2259 | * @param t The type referred to. |
duke@1 | 2260 | * @returns True if the check completed on all attributed classes |
duke@1 | 2261 | */ |
duke@1 | 2262 | private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) { |
duke@1 | 2263 | boolean complete = true; // was the check complete? |
duke@1 | 2264 | //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG |
duke@1 | 2265 | Symbol c = t.tsym; |
duke@1 | 2266 | if ((c.flags_field & ACYCLIC) != 0) return true; |
duke@1 | 2267 | |
duke@1 | 2268 | if ((c.flags_field & LOCKED) != 0) { |
duke@1 | 2269 | noteCyclic(pos, (ClassSymbol)c); |
duke@1 | 2270 | } else if (!c.type.isErroneous()) { |
duke@1 | 2271 | try { |
duke@1 | 2272 | c.flags_field |= LOCKED; |
jjg@1374 | 2273 | if (c.type.hasTag(CLASS)) { |
duke@1 | 2274 | ClassType clazz = (ClassType)c.type; |
duke@1 | 2275 | if (clazz.interfaces_field != null) |
duke@1 | 2276 | for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail) |
duke@1 | 2277 | complete &= checkNonCyclicInternal(pos, l.head); |
duke@1 | 2278 | if (clazz.supertype_field != null) { |
duke@1 | 2279 | Type st = clazz.supertype_field; |
jjg@1374 | 2280 | if (st != null && st.hasTag(CLASS)) |
duke@1 | 2281 | complete &= checkNonCyclicInternal(pos, st); |
duke@1 | 2282 | } |
duke@1 | 2283 | if (c.owner.kind == TYP) |
duke@1 | 2284 | complete &= checkNonCyclicInternal(pos, c.owner.type); |
duke@1 | 2285 | } |
duke@1 | 2286 | } finally { |
duke@1 | 2287 | c.flags_field &= ~LOCKED; |
duke@1 | 2288 | } |
duke@1 | 2289 | } |
duke@1 | 2290 | if (complete) |
duke@1 | 2291 | complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null; |
duke@1 | 2292 | if (complete) c.flags_field |= ACYCLIC; |
duke@1 | 2293 | return complete; |
duke@1 | 2294 | } |
duke@1 | 2295 | |
duke@1 | 2296 | /** Note that we found an inheritance cycle. */ |
duke@1 | 2297 | private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) { |
duke@1 | 2298 | log.error(pos, "cyclic.inheritance", c); |
duke@1 | 2299 | for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail) |
jjg@110 | 2300 | l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType); |
duke@1 | 2301 | Type st = types.supertype(c.type); |
jjg@1374 | 2302 | if (st.hasTag(CLASS)) |
jjg@110 | 2303 | ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType); |
jjg@110 | 2304 | c.type = types.createErrorType(c, c.type); |
duke@1 | 2305 | c.flags_field |= ACYCLIC; |
duke@1 | 2306 | } |
duke@1 | 2307 | |
duke@1 | 2308 | /** Check that all methods which implement some |
duke@1 | 2309 | * method conform to the method they implement. |
duke@1 | 2310 | * @param tree The class definition whose members are checked. |
duke@1 | 2311 | */ |
duke@1 | 2312 | void checkImplementations(JCClassDecl tree) { |
mcimadamore@1415 | 2313 | checkImplementations(tree, tree.sym, tree.sym); |
duke@1 | 2314 | } |
jjg@1521 | 2315 | //where |
duke@1 | 2316 | /** Check that all methods which implement some |
duke@1 | 2317 | * method in `ic' conform to the method they implement. |
duke@1 | 2318 | */ |
mcimadamore@1415 | 2319 | void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) { |
duke@1 | 2320 | for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) { |
duke@1 | 2321 | ClassSymbol lc = (ClassSymbol)l.head.tsym; |
duke@1 | 2322 | if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) { |
duke@1 | 2323 | for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) { |
duke@1 | 2324 | if (e.sym.kind == MTH && |
duke@1 | 2325 | (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) { |
duke@1 | 2326 | MethodSymbol absmeth = (MethodSymbol)e.sym; |
duke@1 | 2327 | MethodSymbol implmeth = absmeth.implementation(origin, types, false); |
duke@1 | 2328 | if (implmeth != null && implmeth != absmeth && |
duke@1 | 2329 | (implmeth.owner.flags() & INTERFACE) == |
duke@1 | 2330 | (origin.flags() & INTERFACE)) { |
duke@1 | 2331 | // don't check if implmeth is in a class, yet |
duke@1 | 2332 | // origin is an interface. This case arises only |
duke@1 | 2333 | // if implmeth is declared in Object. The reason is |
duke@1 | 2334 | // that interfaces really don't inherit from |
duke@1 | 2335 | // Object it's just that the compiler represents |
duke@1 | 2336 | // things that way. |
duke@1 | 2337 | checkOverride(tree, implmeth, absmeth, origin); |
duke@1 | 2338 | } |
duke@1 | 2339 | } |
duke@1 | 2340 | } |
duke@1 | 2341 | } |
duke@1 | 2342 | } |
duke@1 | 2343 | } |
duke@1 | 2344 | |
duke@1 | 2345 | /** Check that all abstract methods implemented by a class are |
duke@1 | 2346 | * mutually compatible. |
duke@1 | 2347 | * @param pos Position to be used for error reporting. |
duke@1 | 2348 | * @param c The class whose interfaces are checked. |
duke@1 | 2349 | */ |
duke@1 | 2350 | void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) { |
duke@1 | 2351 | List<Type> supertypes = types.interfaces(c); |
duke@1 | 2352 | Type supertype = types.supertype(c); |
jjg@1374 | 2353 | if (supertype.hasTag(CLASS) && |
duke@1 | 2354 | (supertype.tsym.flags() & ABSTRACT) != 0) |
duke@1 | 2355 | supertypes = supertypes.prepend(supertype); |
duke@1 | 2356 | for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) { |
duke@1 | 2357 | if (allowGenerics && !l.head.getTypeArguments().isEmpty() && |
duke@1 | 2358 | !checkCompatibleAbstracts(pos, l.head, l.head, c)) |
duke@1 | 2359 | return; |
duke@1 | 2360 | for (List<Type> m = supertypes; m != l; m = m.tail) |
duke@1 | 2361 | if (!checkCompatibleAbstracts(pos, l.head, m.head, c)) |
duke@1 | 2362 | return; |
duke@1 | 2363 | } |
duke@1 | 2364 | checkCompatibleConcretes(pos, c); |
duke@1 | 2365 | } |
duke@1 | 2366 | |
mcimadamore@359 | 2367 | void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) { |
mcimadamore@359 | 2368 | for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) { |
mcimadamore@359 | 2369 | for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) { |
mcimadamore@359 | 2370 | // VM allows methods and variables with differing types |
mcimadamore@359 | 2371 | if (sym.kind == e.sym.kind && |
mcimadamore@359 | 2372 | types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) && |
mcimadamore@359 | 2373 | sym != e.sym && |
mcimadamore@359 | 2374 | (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) && |
mcimadamore@608 | 2375 | (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 && |
mcimadamore@359 | 2376 | (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) { |
mcimadamore@359 | 2377 | syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym); |
mcimadamore@359 | 2378 | return; |
mcimadamore@359 | 2379 | } |
mcimadamore@359 | 2380 | } |
mcimadamore@359 | 2381 | } |
mcimadamore@359 | 2382 | } |
mcimadamore@359 | 2383 | |
mcimadamore@780 | 2384 | /** Check that all non-override equivalent methods accessible from 'site' |
mcimadamore@780 | 2385 | * are mutually compatible (JLS 8.4.8/9.4.1). |
mcimadamore@780 | 2386 | * |
mcimadamore@780 | 2387 | * @param pos Position to be used for error reporting. |
mcimadamore@780 | 2388 | * @param site The class whose methods are checked. |
mcimadamore@780 | 2389 | * @param sym The method symbol to be checked. |
mcimadamore@780 | 2390 | */ |
mcimadamore@858 | 2391 | void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) { |
mcimadamore@858 | 2392 | ClashFilter cf = new ClashFilter(site); |
mcimadamore@1198 | 2393 | //for each method m1 that is overridden (directly or indirectly) |
mcimadamore@1198 | 2394 | //by method 'sym' in 'site'... |
vromero@2118 | 2395 | |
vromero@2118 | 2396 | List<MethodSymbol> potentiallyAmbiguousList = List.nil(); |
vromero@2118 | 2397 | boolean overridesAny = false; |
mcimadamore@1198 | 2398 | for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) { |
vromero@2118 | 2399 | if (!sym.overrides(m1, site.tsym, types, false)) { |
vromero@2118 | 2400 | if (m1 == sym) { |
vromero@2118 | 2401 | continue; |
vromero@2118 | 2402 | } |
vromero@2118 | 2403 | |
vromero@2118 | 2404 | if (!overridesAny) { |
vromero@2118 | 2405 | potentiallyAmbiguousList = potentiallyAmbiguousList.prepend((MethodSymbol)m1); |
vromero@2118 | 2406 | } |
vromero@2118 | 2407 | continue; |
vromero@2118 | 2408 | } |
vromero@2118 | 2409 | |
vromero@2118 | 2410 | if (m1 != sym) { |
vromero@2118 | 2411 | overridesAny = true; |
vromero@2118 | 2412 | potentiallyAmbiguousList = List.nil(); |
vromero@2118 | 2413 | } |
vromero@2118 | 2414 | |
vromero@2118 | 2415 | //...check each method m2 that is a member of 'site' |
vromero@2118 | 2416 | for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) { |
mcimadamore@1198 | 2417 | if (m2 == m1) continue; |
mcimadamore@858 | 2418 | //if (i) the signature of 'sym' is not a subsignature of m1 (seen as |
mcimadamore@858 | 2419 | //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error |
mcimadamore@1393 | 2420 | if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) && |
mcimadamore@1198 | 2421 | types.hasSameArgs(m2.erasure(types), m1.erasure(types))) { |
mcimadamore@858 | 2422 | sym.flags_field |= CLASH; |
mcimadamore@1198 | 2423 | String key = m1 == sym ? |
mcimadamore@858 | 2424 | "name.clash.same.erasure.no.override" : |
mcimadamore@858 | 2425 | "name.clash.same.erasure.no.override.1"; |
mcimadamore@858 | 2426 | log.error(pos, |
mcimadamore@858 | 2427 | key, |
mcimadamore@858 | 2428 | sym, sym.location(), |
mcimadamore@1198 | 2429 | m2, m2.location(), |
mcimadamore@1198 | 2430 | m1, m1.location()); |
mcimadamore@858 | 2431 | return; |
mcimadamore@858 | 2432 | } |
mcimadamore@780 | 2433 | } |
mcimadamore@780 | 2434 | } |
vromero@2118 | 2435 | |
vromero@2118 | 2436 | if (!overridesAny) { |
vromero@2118 | 2437 | for (MethodSymbol m: potentiallyAmbiguousList) { |
vromero@2118 | 2438 | checkPotentiallyAmbiguousOverloads(pos, site, sym, m); |
vromero@2118 | 2439 | } |
vromero@2118 | 2440 | } |
mcimadamore@780 | 2441 | } |
mcimadamore@780 | 2442 | |
mcimadamore@858 | 2443 | /** Check that all static methods accessible from 'site' are |
mcimadamore@858 | 2444 | * mutually compatible (JLS 8.4.8). |
mcimadamore@858 | 2445 | * |
mcimadamore@858 | 2446 | * @param pos Position to be used for error reporting. |
mcimadamore@858 | 2447 | * @param site The class whose methods are checked. |
mcimadamore@858 | 2448 | * @param sym The method symbol to be checked. |
mcimadamore@780 | 2449 | */ |
mcimadamore@858 | 2450 | void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) { |
mcimadamore@780 | 2451 | ClashFilter cf = new ClashFilter(site); |
mcimadamore@858 | 2452 | //for each method m1 that is a member of 'site'... |
mcimadamore@1015 | 2453 | for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) { |
mcimadamore@858 | 2454 | //if (i) the signature of 'sym' is not a subsignature of m1 (seen as |
mcimadamore@858 | 2455 | //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error |
vromero@2000 | 2456 | if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck)) { |
vromero@2000 | 2457 | if (types.hasSameArgs(s.erasure(types), sym.erasure(types))) { |
vromero@2000 | 2458 | log.error(pos, |
vromero@2000 | 2459 | "name.clash.same.erasure.no.hide", |
vromero@2000 | 2460 | sym, sym.location(), |
vromero@2000 | 2461 | s, s.location()); |
vromero@2000 | 2462 | return; |
vromero@2000 | 2463 | } else { |
vromero@2000 | 2464 | checkPotentiallyAmbiguousOverloads(pos, site, sym, (MethodSymbol)s); |
vromero@2000 | 2465 | } |
vromero@2000 | 2466 | } |
mcimadamore@858 | 2467 | } |
mcimadamore@858 | 2468 | } |
mcimadamore@780 | 2469 | |
mcimadamore@858 | 2470 | //where |
mcimadamore@858 | 2471 | private class ClashFilter implements Filter<Symbol> { |
mcimadamore@780 | 2472 | |
mcimadamore@858 | 2473 | Type site; |
mcimadamore@780 | 2474 | |
mcimadamore@858 | 2475 | ClashFilter(Type site) { |
mcimadamore@858 | 2476 | this.site = site; |
mcimadamore@858 | 2477 | } |
mcimadamore@858 | 2478 | |
mcimadamore@858 | 2479 | boolean shouldSkip(Symbol s) { |
mcimadamore@858 | 2480 | return (s.flags() & CLASH) != 0 && |
mcimadamore@858 | 2481 | s.owner == site.tsym; |
mcimadamore@858 | 2482 | } |
mcimadamore@858 | 2483 | |
mcimadamore@858 | 2484 | public boolean accepts(Symbol s) { |
mcimadamore@858 | 2485 | return s.kind == MTH && |
mcimadamore@858 | 2486 | (s.flags() & SYNTHETIC) == 0 && |
mcimadamore@858 | 2487 | !shouldSkip(s) && |
mcimadamore@858 | 2488 | s.isInheritedIn(site.tsym, types) && |
mcimadamore@858 | 2489 | !s.isConstructor(); |
mcimadamore@858 | 2490 | } |
mcimadamore@858 | 2491 | } |
mcimadamore@780 | 2492 | |
mcimadamore@1393 | 2493 | void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) { |
mcimadamore@1393 | 2494 | DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site); |
mcimadamore@1393 | 2495 | for (Symbol m : types.membersClosure(site, false).getElements(dcf)) { |
mcimadamore@1393 | 2496 | Assert.check(m.kind == MTH); |
mcimadamore@1393 | 2497 | List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m); |
mcimadamore@1393 | 2498 | if (prov.size() > 1) { |
alundblad@2047 | 2499 | ListBuffer<Symbol> abstracts = new ListBuffer<>(); |
alundblad@2047 | 2500 | ListBuffer<Symbol> defaults = new ListBuffer<>(); |
mcimadamore@1393 | 2501 | for (MethodSymbol provSym : prov) { |
mcimadamore@1393 | 2502 | if ((provSym.flags() & DEFAULT) != 0) { |
mcimadamore@1393 | 2503 | defaults = defaults.append(provSym); |
mcimadamore@1393 | 2504 | } else if ((provSym.flags() & ABSTRACT) != 0) { |
mcimadamore@1393 | 2505 | abstracts = abstracts.append(provSym); |
mcimadamore@1393 | 2506 | } |
mcimadamore@1393 | 2507 | if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) { |
mcimadamore@1393 | 2508 | //strong semantics - issue an error if two sibling interfaces |
mcimadamore@1393 | 2509 | //have two override-equivalent defaults - or if one is abstract |
mcimadamore@1393 | 2510 | //and the other is default |
mcimadamore@1393 | 2511 | String errKey; |
mcimadamore@1393 | 2512 | Symbol s1 = defaults.first(); |
mcimadamore@1393 | 2513 | Symbol s2; |
mcimadamore@1393 | 2514 | if (defaults.size() > 1) { |
mcimadamore@1393 | 2515 | errKey = "types.incompatible.unrelated.defaults"; |
mcimadamore@1393 | 2516 | s2 = defaults.toList().tail.head; |
mcimadamore@1393 | 2517 | } else { |
mcimadamore@1393 | 2518 | errKey = "types.incompatible.abstract.default"; |
mcimadamore@1393 | 2519 | s2 = abstracts.first(); |
mcimadamore@1393 | 2520 | } |
mcimadamore@1393 | 2521 | log.error(pos, errKey, |
mcimadamore@1393 | 2522 | Kinds.kindName(site.tsym), site, |
mcimadamore@1393 | 2523 | m.name, types.memberType(site, m).getParameterTypes(), |
mcimadamore@1393 | 2524 | s1.location(), s2.location()); |
mcimadamore@1393 | 2525 | break; |
mcimadamore@1393 | 2526 | } |
mcimadamore@1393 | 2527 | } |
mcimadamore@1393 | 2528 | } |
mcimadamore@1393 | 2529 | } |
mcimadamore@1393 | 2530 | } |
mcimadamore@1393 | 2531 | |
mcimadamore@1393 | 2532 | //where |
mcimadamore@1393 | 2533 | private class DefaultMethodClashFilter implements Filter<Symbol> { |
mcimadamore@1393 | 2534 | |
mcimadamore@1393 | 2535 | Type site; |
mcimadamore@1393 | 2536 | |
mcimadamore@1393 | 2537 | DefaultMethodClashFilter(Type site) { |
mcimadamore@1393 | 2538 | this.site = site; |
mcimadamore@1393 | 2539 | } |
mcimadamore@1393 | 2540 | |
mcimadamore@1393 | 2541 | public boolean accepts(Symbol s) { |
mcimadamore@1393 | 2542 | return s.kind == MTH && |
mcimadamore@1393 | 2543 | (s.flags() & DEFAULT) != 0 && |
mcimadamore@1393 | 2544 | s.isInheritedIn(site.tsym, types) && |
mcimadamore@1393 | 2545 | !s.isConstructor(); |
mcimadamore@1393 | 2546 | } |
mcimadamore@1393 | 2547 | } |
mcimadamore@1393 | 2548 | |
vromero@2000 | 2549 | /** |
vromero@2000 | 2550 | * Report warnings for potentially ambiguous method declarations. Two declarations |
vromero@2000 | 2551 | * are potentially ambiguous if they feature two unrelated functional interface |
vromero@2000 | 2552 | * in same argument position (in which case, a call site passing an implicit |
vromero@2000 | 2553 | * lambda would be ambiguous). |
vromero@2000 | 2554 | */ |
vromero@2000 | 2555 | void checkPotentiallyAmbiguousOverloads(DiagnosticPosition pos, Type site, |
vromero@2000 | 2556 | MethodSymbol msym1, MethodSymbol msym2) { |
vromero@2000 | 2557 | if (msym1 != msym2 && |
vromero@2000 | 2558 | allowDefaultMethods && |
vromero@2000 | 2559 | lint.isEnabled(LintCategory.OVERLOADS) && |
vromero@2000 | 2560 | (msym1.flags() & POTENTIALLY_AMBIGUOUS) == 0 && |
vromero@2000 | 2561 | (msym2.flags() & POTENTIALLY_AMBIGUOUS) == 0) { |
vromero@2000 | 2562 | Type mt1 = types.memberType(site, msym1); |
vromero@2000 | 2563 | Type mt2 = types.memberType(site, msym2); |
vromero@2000 | 2564 | //if both generic methods, adjust type variables |
vromero@2000 | 2565 | if (mt1.hasTag(FORALL) && mt2.hasTag(FORALL) && |
vromero@2000 | 2566 | types.hasSameBounds((ForAll)mt1, (ForAll)mt2)) { |
vromero@2000 | 2567 | mt2 = types.subst(mt2, ((ForAll)mt2).tvars, ((ForAll)mt1).tvars); |
vromero@2000 | 2568 | } |
vromero@2000 | 2569 | //expand varargs methods if needed |
vromero@2000 | 2570 | int maxLength = Math.max(mt1.getParameterTypes().length(), mt2.getParameterTypes().length()); |
vromero@2000 | 2571 | List<Type> args1 = rs.adjustArgs(mt1.getParameterTypes(), msym1, maxLength, true); |
vromero@2000 | 2572 | List<Type> args2 = rs.adjustArgs(mt2.getParameterTypes(), msym2, maxLength, true); |
vromero@2000 | 2573 | //if arities don't match, exit |
vromero@2000 | 2574 | if (args1.length() != args2.length()) return; |
vromero@2000 | 2575 | boolean potentiallyAmbiguous = false; |
vromero@2000 | 2576 | while (args1.nonEmpty() && args2.nonEmpty()) { |
vromero@2000 | 2577 | Type s = args1.head; |
vromero@2000 | 2578 | Type t = args2.head; |
vromero@2000 | 2579 | if (!types.isSubtype(t, s) && !types.isSubtype(s, t)) { |
vromero@2000 | 2580 | if (types.isFunctionalInterface(s) && types.isFunctionalInterface(t) && |
vromero@2000 | 2581 | types.findDescriptorType(s).getParameterTypes().length() > 0 && |
vromero@2000 | 2582 | types.findDescriptorType(s).getParameterTypes().length() == |
vromero@2000 | 2583 | types.findDescriptorType(t).getParameterTypes().length()) { |
vromero@2000 | 2584 | potentiallyAmbiguous = true; |
vromero@2000 | 2585 | } else { |
vromero@2000 | 2586 | break; |
vromero@2000 | 2587 | } |
vromero@2000 | 2588 | } |
vromero@2000 | 2589 | args1 = args1.tail; |
vromero@2000 | 2590 | args2 = args2.tail; |
vromero@2000 | 2591 | } |
vromero@2000 | 2592 | if (potentiallyAmbiguous) { |
vromero@2000 | 2593 | //we found two incompatible functional interfaces with same arity |
vromero@2000 | 2594 | //this means a call site passing an implicit lambda would be ambigiuous |
vromero@2000 | 2595 | msym1.flags_field |= POTENTIALLY_AMBIGUOUS; |
vromero@2000 | 2596 | msym2.flags_field |= POTENTIALLY_AMBIGUOUS; |
vromero@2000 | 2597 | log.warning(LintCategory.OVERLOADS, pos, "potentially.ambiguous.overload", |
vromero@2000 | 2598 | msym1, msym1.location(), |
vromero@2000 | 2599 | msym2, msym2.location()); |
vromero@2000 | 2600 | return; |
vromero@2000 | 2601 | } |
vromero@2000 | 2602 | } |
vromero@2000 | 2603 | } |
vromero@2000 | 2604 | |
vromero@2390 | 2605 | void checkElemAccessFromSerializableLambda(final JCTree tree) { |
vromero@2390 | 2606 | if (warnOnAccessToSensitiveMembers) { |
vromero@2390 | 2607 | Symbol sym = TreeInfo.symbol(tree); |
vromero@2390 | 2608 | if ((sym.kind & (VAR | MTH)) == 0) { |
vromero@2390 | 2609 | return; |
vromero@2390 | 2610 | } |
vromero@2390 | 2611 | |
vromero@2390 | 2612 | if (sym.kind == VAR) { |
vromero@2390 | 2613 | if ((sym.flags() & PARAMETER) != 0 || |
vromero@2390 | 2614 | sym.isLocal() || |
vromero@2390 | 2615 | sym.name == names._this || |
vromero@2390 | 2616 | sym.name == names._super) { |
vromero@2390 | 2617 | return; |
vromero@2390 | 2618 | } |
vromero@2390 | 2619 | } |
vromero@2390 | 2620 | |
vromero@2390 | 2621 | if (!types.isSubtype(sym.owner.type, syms.serializableType) && |
vromero@2390 | 2622 | isEffectivelyNonPublic(sym)) { |
vromero@2390 | 2623 | log.warning(tree.pos(), |
vromero@2390 | 2624 | "access.to.sensitive.member.from.serializable.element", sym); |
vromero@2390 | 2625 | } |
vromero@2390 | 2626 | } |
vromero@2390 | 2627 | } |
vromero@2390 | 2628 | |
vromero@2390 | 2629 | private boolean isEffectivelyNonPublic(Symbol sym) { |
vromero@2390 | 2630 | if (sym.packge() == syms.rootPackage) { |
vromero@2390 | 2631 | return false; |
vromero@2390 | 2632 | } |
vromero@2390 | 2633 | |
vromero@2390 | 2634 | while (sym.kind != Kinds.PCK) { |
vromero@2390 | 2635 | if ((sym.flags() & PUBLIC) == 0) { |
vromero@2390 | 2636 | return true; |
vromero@2390 | 2637 | } |
vromero@2390 | 2638 | sym = sym.owner; |
vromero@2390 | 2639 | } |
vromero@2390 | 2640 | return false; |
vromero@2390 | 2641 | } |
vromero@2390 | 2642 | |
mcimadamore@359 | 2643 | /** Report a conflict between a user symbol and a synthetic symbol. |
mcimadamore@359 | 2644 | */ |
mcimadamore@359 | 2645 | private void syntheticError(DiagnosticPosition pos, Symbol sym) { |
mcimadamore@359 | 2646 | if (!sym.type.isErroneous()) { |
mcimadamore@359 | 2647 | if (warnOnSyntheticConflicts) { |
mcimadamore@359 | 2648 | log.warning(pos, "synthetic.name.conflict", sym, sym.location()); |
mcimadamore@359 | 2649 | } |
mcimadamore@359 | 2650 | else { |
mcimadamore@359 | 2651 | log.error(pos, "synthetic.name.conflict", sym, sym.location()); |
mcimadamore@359 | 2652 | } |
mcimadamore@359 | 2653 | } |
mcimadamore@359 | 2654 | } |
mcimadamore@359 | 2655 | |
duke@1 | 2656 | /** Check that class c does not implement directly or indirectly |
duke@1 | 2657 | * the same parameterized interface with two different argument lists. |
duke@1 | 2658 | * @param pos Position to be used for error reporting. |
duke@1 | 2659 | * @param type The type whose interfaces are checked. |
duke@1 | 2660 | */ |
duke@1 | 2661 | void checkClassBounds(DiagnosticPosition pos, Type type) { |
duke@1 | 2662 | checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type); |
duke@1 | 2663 | } |
duke@1 | 2664 | //where |
duke@1 | 2665 | /** Enter all interfaces of type `type' into the hash table `seensofar' |
duke@1 | 2666 | * with their class symbol as key and their type as value. Make |
duke@1 | 2667 | * sure no class is entered with two different types. |
duke@1 | 2668 | */ |
duke@1 | 2669 | void checkClassBounds(DiagnosticPosition pos, |
duke@1 | 2670 | Map<TypeSymbol,Type> seensofar, |
duke@1 | 2671 | Type type) { |
duke@1 | 2672 | if (type.isErroneous()) return; |
duke@1 | 2673 | for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) { |
duke@1 | 2674 | Type it = l.head; |
duke@1 | 2675 | Type oldit = seensofar.put(it.tsym, it); |
duke@1 | 2676 | if (oldit != null) { |
duke@1 | 2677 | List<Type> oldparams = oldit.allparams(); |
duke@1 | 2678 | List<Type> newparams = it.allparams(); |
duke@1 | 2679 | if (!types.containsTypeEquivalent(oldparams, newparams)) |
duke@1 | 2680 | log.error(pos, "cant.inherit.diff.arg", |
duke@1 | 2681 | it.tsym, Type.toString(oldparams), |
duke@1 | 2682 | Type.toString(newparams)); |
duke@1 | 2683 | } |
duke@1 | 2684 | checkClassBounds(pos, seensofar, it); |
duke@1 | 2685 | } |
duke@1 | 2686 | Type st = types.supertype(type); |
dlsmith@2431 | 2687 | if (st != Type.noType) checkClassBounds(pos, seensofar, st); |
duke@1 | 2688 | } |
duke@1 | 2689 | |
duke@1 | 2690 | /** Enter interface into into set. |
duke@1 | 2691 | * If it existed already, issue a "repeated interface" error. |
duke@1 | 2692 | */ |
duke@1 | 2693 | void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) { |
duke@1 | 2694 | if (its.contains(it)) |
duke@1 | 2695 | log.error(pos, "repeated.interface"); |
duke@1 | 2696 | else { |
duke@1 | 2697 | its.add(it); |
duke@1 | 2698 | } |
duke@1 | 2699 | } |
duke@1 | 2700 | |
duke@1 | 2701 | /* ************************************************************************* |
duke@1 | 2702 | * Check annotations |
duke@1 | 2703 | **************************************************************************/ |
duke@1 | 2704 | |
mcimadamore@629 | 2705 | /** |
mcimadamore@634 | 2706 | * Recursively validate annotations values |
mcimadamore@629 | 2707 | */ |
mcimadamore@634 | 2708 | void validateAnnotationTree(JCTree tree) { |
mcimadamore@634 | 2709 | class AnnotationValidator extends TreeScanner { |
mcimadamore@629 | 2710 | @Override |
mcimadamore@629 | 2711 | public void visitAnnotation(JCAnnotation tree) { |
jjg@1017 | 2712 | if (!tree.type.isErroneous()) { |
jjg@1017 | 2713 | super.visitAnnotation(tree); |
jjg@1017 | 2714 | validateAnnotation(tree); |
jjg@1017 | 2715 | } |
mcimadamore@629 | 2716 | } |
mcimadamore@629 | 2717 | } |
mcimadamore@634 | 2718 | tree.accept(new AnnotationValidator()); |
mcimadamore@629 | 2719 | } |
mcimadamore@629 | 2720 | |
jjg@1326 | 2721 | /** |
jjg@1326 | 2722 | * {@literal |
jjg@1326 | 2723 | * Annotation types are restricted to primitives, String, an |
duke@1 | 2724 | * enum, an annotation, Class, Class<?>, Class<? extends |
duke@1 | 2725 | * Anything>, arrays of the preceding. |
jjg@1326 | 2726 | * } |
duke@1 | 2727 | */ |
duke@1 | 2728 | void validateAnnotationType(JCTree restype) { |
duke@1 | 2729 | // restype may be null if an error occurred, so don't bother validating it |
duke@1 | 2730 | if (restype != null) { |
duke@1 | 2731 | validateAnnotationType(restype.pos(), restype.type); |
duke@1 | 2732 | } |
duke@1 | 2733 | } |
duke@1 | 2734 | |
duke@1 | 2735 | void validateAnnotationType(DiagnosticPosition pos, Type type) { |
duke@1 | 2736 | if (type.isPrimitive()) return; |
duke@1 | 2737 | if (types.isSameType(type, syms.stringType)) return; |
duke@1 | 2738 | if ((type.tsym.flags() & Flags.ENUM) != 0) return; |
duke@1 | 2739 | if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return; |
dlsmith@2384 | 2740 | if (types.cvarLowerBound(type).tsym == syms.classType.tsym) return; |
duke@1 | 2741 | if (types.isArray(type) && !types.isArray(types.elemtype(type))) { |
duke@1 | 2742 | validateAnnotationType(pos, types.elemtype(type)); |
duke@1 | 2743 | return; |
duke@1 | 2744 | } |
duke@1 | 2745 | log.error(pos, "invalid.annotation.member.type"); |
duke@1 | 2746 | } |
duke@1 | 2747 | |
duke@1 | 2748 | /** |
duke@1 | 2749 | * "It is also a compile-time error if any method declared in an |
duke@1 | 2750 | * annotation type has a signature that is override-equivalent to |
duke@1 | 2751 | * that of any public or protected method declared in class Object |
duke@1 | 2752 | * or in the interface annotation.Annotation." |
duke@1 | 2753 | * |
jjh@972 | 2754 | * @jls 9.6 Annotation Types |
duke@1 | 2755 | */ |
duke@1 | 2756 | void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) { |
jjg@1374 | 2757 | for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) { |
duke@1 | 2758 | Scope s = sup.tsym.members(); |
duke@1 | 2759 | for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) { |
duke@1 | 2760 | if (e.sym.kind == MTH && |
duke@1 | 2761 | (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 && |
duke@1 | 2762 | types.overrideEquivalent(m.type, e.sym.type)) |
duke@1 | 2763 | log.error(pos, "intf.annotation.member.clash", e.sym, sup); |
duke@1 | 2764 | } |
duke@1 | 2765 | } |
duke@1 | 2766 | } |
duke@1 | 2767 | |
duke@1 | 2768 | /** Check the annotations of a symbol. |
duke@1 | 2769 | */ |
duke@1 | 2770 | public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) { |
duke@1 | 2771 | for (JCAnnotation a : annotations) |
duke@1 | 2772 | validateAnnotation(a, s); |
duke@1 | 2773 | } |
duke@1 | 2774 | |
jjg@1521 | 2775 | /** Check the type annotations. |
jjg@1521 | 2776 | */ |
jjg@1521 | 2777 | public void validateTypeAnnotations(List<JCAnnotation> annotations, boolean isTypeParameter) { |
jjg@1521 | 2778 | for (JCAnnotation a : annotations) |
jjg@1521 | 2779 | validateTypeAnnotation(a, isTypeParameter); |
jjg@1521 | 2780 | } |
jjg@1521 | 2781 | |
duke@1 | 2782 | /** Check an annotation of a symbol. |
duke@1 | 2783 | */ |
jfranck@1313 | 2784 | private void validateAnnotation(JCAnnotation a, Symbol s) { |
mcimadamore@634 | 2785 | validateAnnotationTree(a); |
duke@1 | 2786 | |
duke@1 | 2787 | if (!annotationApplicable(a, s)) |
duke@1 | 2788 | log.error(a.pos(), "annotation.type.not.applicable"); |
duke@1 | 2789 | |
mcimadamore@1497 | 2790 | if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) { |
mcimadamore@1497 | 2791 | if (s.kind != TYP) { |
mcimadamore@1497 | 2792 | log.error(a.pos(), "bad.functional.intf.anno"); |
jlahoda@2111 | 2793 | } else if (!s.isInterface() || (s.flags() & ANNOTATION) != 0) { |
jlahoda@2111 | 2794 | log.error(a.pos(), "bad.functional.intf.anno.1", diags.fragment("not.a.functional.intf", s)); |
mcimadamore@1497 | 2795 | } |
mcimadamore@1497 | 2796 | } |
duke@1 | 2797 | } |
duke@1 | 2798 | |
jjg@1521 | 2799 | public void validateTypeAnnotation(JCAnnotation a, boolean isTypeParameter) { |
jjg@1521 | 2800 | Assert.checkNonNull(a.type, "annotation tree hasn't been attributed yet: " + a); |
jjg@1521 | 2801 | validateAnnotationTree(a); |
jjg@1521 | 2802 | |
jjg@2134 | 2803 | if (a.hasTag(TYPE_ANNOTATION) && |
jjg@2134 | 2804 | !a.annotationType.type.isErroneous() && |
jjg@2134 | 2805 | !isTypeAnnotation(a, isTypeParameter)) { |
jjg@1521 | 2806 | log.error(a.pos(), "annotation.type.not.applicable"); |
jjg@2134 | 2807 | } |
jjg@1521 | 2808 | } |
jjg@1521 | 2809 | |
jfranck@1313 | 2810 | /** |
jjg@1492 | 2811 | * Validate the proposed container 'repeatable' on the |
jfranck@1313 | 2812 | * annotation type symbol 's'. Report errors at position |
jfranck@1313 | 2813 | * 'pos'. |
jfranck@1313 | 2814 | * |
jjg@1492 | 2815 | * @param s The (annotation)type declaration annotated with a @Repeatable |
jjg@1492 | 2816 | * @param repeatable the @Repeatable on 's' |
jfranck@1313 | 2817 | * @param pos where to report errors |
jfranck@1313 | 2818 | */ |
jjg@1492 | 2819 | public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) { |
jjg@1492 | 2820 | Assert.check(types.isSameType(repeatable.type, syms.repeatableType)); |
jfranck@1313 | 2821 | |
jfranck@1313 | 2822 | Type t = null; |
jjg@1492 | 2823 | List<Pair<MethodSymbol,Attribute>> l = repeatable.values; |
jfranck@1313 | 2824 | if (!l.isEmpty()) { |
jfranck@1313 | 2825 | Assert.check(l.head.fst.name == names.value); |
jfranck@1313 | 2826 | t = ((Attribute.Class)l.head.snd).getValue(); |
jfranck@1313 | 2827 | } |
jfranck@1313 | 2828 | |
jfranck@1313 | 2829 | if (t == null) { |
jjg@1492 | 2830 | // errors should already have been reported during Annotate |
jfranck@1313 | 2831 | return; |
jfranck@1313 | 2832 | } |
jfranck@1313 | 2833 | |
jjg@1492 | 2834 | validateValue(t.tsym, s, pos); |
jfranck@1313 | 2835 | validateRetention(t.tsym, s, pos); |
jfranck@1313 | 2836 | validateDocumented(t.tsym, s, pos); |
jfranck@1313 | 2837 | validateInherited(t.tsym, s, pos); |
jfranck@1313 | 2838 | validateTarget(t.tsym, s, pos); |
jfranck@2250 | 2839 | validateDefault(t.tsym, pos); |
jfranck@1313 | 2840 | } |
jfranck@1313 | 2841 | |
jjg@1492 | 2842 | private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) { |
jjg@1492 | 2843 | Scope.Entry e = container.members().lookup(names.value); |
jjg@1492 | 2844 | if (e.scope != null && e.sym.kind == MTH) { |
jjg@1492 | 2845 | MethodSymbol m = (MethodSymbol) e.sym; |
jjg@1492 | 2846 | Type ret = m.getReturnType(); |
jjg@1492 | 2847 | if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) { |
jjg@1492 | 2848 | log.error(pos, "invalid.repeatable.annotation.value.return", |
jjg@1492 | 2849 | container, ret, types.makeArrayType(contained.type)); |
jjg@1492 | 2850 | } |
jjg@1492 | 2851 | } else { |
jjg@1492 | 2852 | log.error(pos, "invalid.repeatable.annotation.no.value", container); |
jfranck@1313 | 2853 | } |
jfranck@1313 | 2854 | } |
jfranck@1313 | 2855 | |
jfranck@1313 | 2856 | private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) { |
jfranck@1313 | 2857 | Attribute.RetentionPolicy containerRetention = types.getRetention(container); |
jfranck@1313 | 2858 | Attribute.RetentionPolicy containedRetention = types.getRetention(contained); |
jfranck@1313 | 2859 | |
jfranck@1313 | 2860 | boolean error = false; |
jfranck@1313 | 2861 | switch (containedRetention) { |
jfranck@1313 | 2862 | case RUNTIME: |
jfranck@1313 | 2863 | if (containerRetention != Attribute.RetentionPolicy.RUNTIME) { |
jfranck@1313 | 2864 | error = true; |
jfranck@1313 | 2865 | } |
jfranck@1313 | 2866 | break; |
jfranck@1313 | 2867 | case CLASS: |
jfranck@1313 | 2868 | if (containerRetention == Attribute.RetentionPolicy.SOURCE) { |
jfranck@1313 | 2869 | error = true; |
jfranck@1313 | 2870 | } |
jfranck@1313 | 2871 | } |
jfranck@1313 | 2872 | if (error ) { |
jjg@1492 | 2873 | log.error(pos, "invalid.repeatable.annotation.retention", |
jfranck@1313 | 2874 | container, containerRetention, |
jfranck@1313 | 2875 | contained, containedRetention); |
jfranck@1313 | 2876 | } |
jfranck@1313 | 2877 | } |
jfranck@1313 | 2878 | |
jfranck@1313 | 2879 | private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) { |
jfranck@1313 | 2880 | if (contained.attribute(syms.documentedType.tsym) != null) { |
jfranck@1313 | 2881 | if (container.attribute(syms.documentedType.tsym) == null) { |
jjg@1492 | 2882 | log.error(pos, "invalid.repeatable.annotation.not.documented", container, contained); |
jfranck@1313 | 2883 | } |
jfranck@1313 | 2884 | } |
jfranck@1313 | 2885 | } |
jfranck@1313 | 2886 | |
jfranck@1313 | 2887 | private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) { |
jfranck@1313 | 2888 | if (contained.attribute(syms.inheritedType.tsym) != null) { |
jfranck@1313 | 2889 | if (container.attribute(syms.inheritedType.tsym) == null) { |
jjg@1492 | 2890 | log.error(pos, "invalid.repeatable.annotation.not.inherited", container, contained); |
jfranck@1313 | 2891 | } |
jfranck@1313 | 2892 | } |
jfranck@1313 | 2893 | } |
jfranck@1313 | 2894 | |
jfranck@1313 | 2895 | private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) { |
jfranck@1634 | 2896 | // The set of targets the container is applicable to must be a subset |
jfranck@1634 | 2897 | // (with respect to annotation target semantics) of the set of targets |
jfranck@1634 | 2898 | // the contained is applicable to. The target sets may be implicit or |
jfranck@1634 | 2899 | // explicit. |
jfranck@1634 | 2900 | |
jfranck@1634 | 2901 | Set<Name> containerTargets; |
jfranck@1313 | 2902 | Attribute.Array containerTarget = getAttributeTargetAttribute(container); |
jfranck@1313 | 2903 | if (containerTarget == null) { |
jfranck@1634 | 2904 | containerTargets = getDefaultTargetSet(); |
jfranck@1634 | 2905 | } else { |
jfranck@1634 | 2906 | containerTargets = new HashSet<Name>(); |
jfranck@1313 | 2907 | for (Attribute app : containerTarget.values) { |
jfranck@1313 | 2908 | if (!(app instanceof Attribute.Enum)) { |
jfranck@1313 | 2909 | continue; // recovery |
jfranck@1313 | 2910 | } |
jfranck@1313 | 2911 | Attribute.Enum e = (Attribute.Enum)app; |
jfranck@1313 | 2912 | containerTargets.add(e.value.name); |
jfranck@1313 | 2913 | } |
jfranck@1634 | 2914 | } |
jfranck@1634 | 2915 | |
jfranck@1634 | 2916 | Set<Name> containedTargets; |
jfranck@1634 | 2917 | Attribute.Array containedTarget = getAttributeTargetAttribute(contained); |
jfranck@1634 | 2918 | if (containedTarget == null) { |
jfranck@1634 | 2919 | containedTargets = getDefaultTargetSet(); |
jfranck@1634 | 2920 | } else { |
jfranck@1634 | 2921 | containedTargets = new HashSet<Name>(); |
jfranck@1313 | 2922 | for (Attribute app : containedTarget.values) { |
jfranck@1313 | 2923 | if (!(app instanceof Attribute.Enum)) { |
jfranck@1313 | 2924 | continue; // recovery |
jfranck@1313 | 2925 | } |
jfranck@1313 | 2926 | Attribute.Enum e = (Attribute.Enum)app; |
jfranck@1313 | 2927 | containedTargets.add(e.value.name); |
jfranck@1313 | 2928 | } |
jfranck@1634 | 2929 | } |
jfranck@1634 | 2930 | |
jfranck@1634 | 2931 | if (!isTargetSubsetOf(containerTargets, containedTargets)) { |
jjg@1492 | 2932 | log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained); |
jfranck@1313 | 2933 | } |
jfranck@1313 | 2934 | } |
jfranck@1313 | 2935 | |
jfranck@1634 | 2936 | /* get a set of names for the default target */ |
jfranck@1634 | 2937 | private Set<Name> getDefaultTargetSet() { |
jfranck@1634 | 2938 | if (defaultTargets == null) { |
jfranck@1634 | 2939 | Set<Name> targets = new HashSet<Name>(); |
jfranck@1634 | 2940 | targets.add(names.ANNOTATION_TYPE); |
jfranck@1634 | 2941 | targets.add(names.CONSTRUCTOR); |
jfranck@1634 | 2942 | targets.add(names.FIELD); |
jfranck@1634 | 2943 | targets.add(names.LOCAL_VARIABLE); |
jfranck@1634 | 2944 | targets.add(names.METHOD); |
jfranck@1634 | 2945 | targets.add(names.PACKAGE); |
jfranck@1634 | 2946 | targets.add(names.PARAMETER); |
jfranck@1634 | 2947 | targets.add(names.TYPE); |
jfranck@1634 | 2948 | |
jfranck@1634 | 2949 | defaultTargets = java.util.Collections.unmodifiableSet(targets); |
jfranck@1634 | 2950 | } |
jfranck@1634 | 2951 | |
jfranck@1634 | 2952 | return defaultTargets; |
jfranck@1634 | 2953 | } |
jfranck@1634 | 2954 | private Set<Name> defaultTargets; |
jfranck@1634 | 2955 | |
jfranck@1634 | 2956 | |
jfranck@1634 | 2957 | /** Checks that s is a subset of t, with respect to ElementType |
jfranck@2250 | 2958 | * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE}, |
jfranck@2250 | 2959 | * and {TYPE_USE} covers the set {ANNOTATION_TYPE, TYPE, TYPE_USE, |
jfranck@2250 | 2960 | * TYPE_PARAMETER}. |
jfranck@1313 | 2961 | */ |
jfranck@1634 | 2962 | private boolean isTargetSubsetOf(Set<Name> s, Set<Name> t) { |
jfranck@1634 | 2963 | // Check that all elements in s are present in t |
jfranck@1634 | 2964 | for (Name n2 : s) { |
jfranck@1313 | 2965 | boolean currentElementOk = false; |
jfranck@1634 | 2966 | for (Name n1 : t) { |
jfranck@1313 | 2967 | if (n1 == n2) { |
jfranck@1313 | 2968 | currentElementOk = true; |
jfranck@1313 | 2969 | break; |
jfranck@1313 | 2970 | } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) { |
jfranck@1313 | 2971 | currentElementOk = true; |
jfranck@1313 | 2972 | break; |
jfranck@2250 | 2973 | } else if (n1 == names.TYPE_USE && |
jfranck@2250 | 2974 | (n2 == names.TYPE || |
jfranck@2250 | 2975 | n2 == names.ANNOTATION_TYPE || |
jfranck@2250 | 2976 | n2 == names.TYPE_PARAMETER)) { |
jfranck@2250 | 2977 | currentElementOk = true; |
jfranck@2250 | 2978 | break; |
jfranck@1313 | 2979 | } |
jfranck@1313 | 2980 | } |
jfranck@1313 | 2981 | if (!currentElementOk) |
jfranck@1313 | 2982 | return false; |
jfranck@1313 | 2983 | } |
jfranck@1313 | 2984 | return true; |
jfranck@1313 | 2985 | } |
jfranck@1313 | 2986 | |
jfranck@2250 | 2987 | private void validateDefault(Symbol container, DiagnosticPosition pos) { |
jfranck@1344 | 2988 | // validate that all other elements of containing type has defaults |
jfranck@1344 | 2989 | Scope scope = container.members(); |
jfranck@1344 | 2990 | for(Symbol elm : scope.getElements()) { |
jfranck@1344 | 2991 | if (elm.name != names.value && |
jfranck@1344 | 2992 | elm.kind == Kinds.MTH && |
jfranck@1344 | 2993 | ((MethodSymbol)elm).defaultValue == null) { |
jfranck@1344 | 2994 | log.error(pos, |
jjg@1492 | 2995 | "invalid.repeatable.annotation.elem.nondefault", |
jfranck@1344 | 2996 | container, |
jfranck@1344 | 2997 | elm); |
jfranck@1344 | 2998 | } |
jfranck@1344 | 2999 | } |
jfranck@1344 | 3000 | } |
jfranck@1344 | 3001 | |
duke@1 | 3002 | /** Is s a method symbol that overrides a method in a superclass? */ |
duke@1 | 3003 | boolean isOverrider(Symbol s) { |
duke@1 | 3004 | if (s.kind != MTH || s.isStatic()) |
duke@1 | 3005 | return false; |
duke@1 | 3006 | MethodSymbol m = (MethodSymbol)s; |
duke@1 | 3007 | TypeSymbol owner = (TypeSymbol)m.owner; |
duke@1 | 3008 | for (Type sup : types.closure(owner.type)) { |
duke@1 | 3009 | if (sup == owner.type) |
duke@1 | 3010 | continue; // skip "this" |
duke@1 | 3011 | Scope scope = sup.tsym.members(); |
duke@1 | 3012 | for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) { |
duke@1 | 3013 | if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true)) |
duke@1 | 3014 | return true; |
duke@1 | 3015 | } |
duke@1 | 3016 | } |
duke@1 | 3017 | return false; |
duke@1 | 3018 | } |
duke@1 | 3019 | |
jlahoda@2111 | 3020 | /** Is the annotation applicable to types? */ |
jjg@1521 | 3021 | protected boolean isTypeAnnotation(JCAnnotation a, boolean isTypeParameter) { |
jjg@1521 | 3022 | Attribute.Compound atTarget = |
jjg@1521 | 3023 | a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym); |
jjg@1521 | 3024 | if (atTarget == null) { |
jjg@1521 | 3025 | // An annotation without @Target is not a type annotation. |
jjg@1521 | 3026 | return false; |
jjg@1521 | 3027 | } |
jjg@1521 | 3028 | |
jjg@1521 | 3029 | Attribute atValue = atTarget.member(names.value); |
jjg@1521 | 3030 | if (!(atValue instanceof Attribute.Array)) { |
jjg@1521 | 3031 | return false; // error recovery |
jjg@1521 | 3032 | } |
jjg@1521 | 3033 | |
jjg@1521 | 3034 | Attribute.Array arr = (Attribute.Array) atValue; |
jjg@1521 | 3035 | for (Attribute app : arr.values) { |
jjg@1521 | 3036 | if (!(app instanceof Attribute.Enum)) { |
jjg@1521 | 3037 | return false; // recovery |
jjg@1521 | 3038 | } |
jjg@1521 | 3039 | Attribute.Enum e = (Attribute.Enum) app; |
jjg@1521 | 3040 | |
jjg@1521 | 3041 | if (e.value.name == names.TYPE_USE) |
jjg@1521 | 3042 | return true; |
jjg@1521 | 3043 | else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER) |
jjg@1521 | 3044 | return true; |
jjg@1521 | 3045 | } |
jjg@1521 | 3046 | return false; |
jjg@1521 | 3047 | } |
jjg@1521 | 3048 | |
duke@1 | 3049 | /** Is the annotation applicable to the symbol? */ |
duke@1 | 3050 | boolean annotationApplicable(JCAnnotation a, Symbol s) { |
jfranck@1313 | 3051 | Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym); |
jjg@1521 | 3052 | Name[] targets; |
jlahoda@2210 | 3053 | |
jfranck@1313 | 3054 | if (arr == null) { |
jjg@1521 | 3055 | targets = defaultTargetMetaInfo(a, s); |
jjg@1521 | 3056 | } else { |
jjg@1521 | 3057 | // TODO: can we optimize this? |
jjg@1521 | 3058 | targets = new Name[arr.values.length]; |
jjg@1521 | 3059 | for (int i=0; i<arr.values.length; ++i) { |
jjg@1521 | 3060 | Attribute app = arr.values[i]; |
jjg@1521 | 3061 | if (!(app instanceof Attribute.Enum)) { |
jjg@1521 | 3062 | return true; // recovery |
jjg@1521 | 3063 | } |
jjg@1521 | 3064 | Attribute.Enum e = (Attribute.Enum) app; |
jjg@1521 | 3065 | targets[i] = e.value.name; |
jjg@1521 | 3066 | } |
jfranck@1313 | 3067 | } |
jjg@1521 | 3068 | for (Name target : targets) { |
jjg@1521 | 3069 | if (target == names.TYPE) |
jlahoda@2210 | 3070 | { if (s.kind == TYP) return true; } |
jjg@1521 | 3071 | else if (target == names.FIELD) |
duke@1 | 3072 | { if (s.kind == VAR && s.owner.kind != MTH) return true; } |
jjg@1521 | 3073 | else if (target == names.METHOD) |
duke@1 | 3074 | { if (s.kind == MTH && !s.isConstructor()) return true; } |
jjg@1521 | 3075 | else if (target == names.PARAMETER) |
duke@1 | 3076 | { if (s.kind == VAR && |
duke@1 | 3077 | s.owner.kind == MTH && |
duke@1 | 3078 | (s.flags() & PARAMETER) != 0) |
duke@1 | 3079 | return true; |
duke@1 | 3080 | } |
jjg@1521 | 3081 | else if (target == names.CONSTRUCTOR) |
duke@1 | 3082 | { if (s.kind == MTH && s.isConstructor()) return true; } |
jjg@1521 | 3083 | else if (target == names.LOCAL_VARIABLE) |
duke@1 | 3084 | { if (s.kind == VAR && s.owner.kind == MTH && |
duke@1 | 3085 | (s.flags() & PARAMETER) == 0) |
duke@1 | 3086 | return true; |
duke@1 | 3087 | } |
jjg@1521 | 3088 | else if (target == names.ANNOTATION_TYPE) |
duke@1 | 3089 | { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0) |
duke@1 | 3090 | return true; |
duke@1 | 3091 | } |
jjg@1521 | 3092 | else if (target == names.PACKAGE) |
duke@1 | 3093 | { if (s.kind == PCK) return true; } |
jjg@1521 | 3094 | else if (target == names.TYPE_USE) |
jjg@308 | 3095 | { if (s.kind == TYP || |
jjg@308 | 3096 | s.kind == VAR || |
jjg@308 | 3097 | (s.kind == MTH && !s.isConstructor() && |
jjg@1521 | 3098 | !s.type.getReturnType().hasTag(VOID)) || |
jjg@1521 | 3099 | (s.kind == MTH && s.isConstructor())) |
jjg@1521 | 3100 | return true; |
jjg@1521 | 3101 | } |
jjg@1521 | 3102 | else if (target == names.TYPE_PARAMETER) |
jjg@1521 | 3103 | { if (s.kind == TYP && s.type.hasTag(TYPEVAR)) |
jjg@308 | 3104 | return true; |
jjg@308 | 3105 | } |
duke@1 | 3106 | else |
duke@1 | 3107 | return true; // recovery |
duke@1 | 3108 | } |
duke@1 | 3109 | return false; |
duke@1 | 3110 | } |
duke@1 | 3111 | |
jfranck@1313 | 3112 | |
jfranck@1313 | 3113 | Attribute.Array getAttributeTargetAttribute(Symbol s) { |
jfranck@1313 | 3114 | Attribute.Compound atTarget = |
jfranck@1313 | 3115 | s.attribute(syms.annotationTargetType.tsym); |
jfranck@1313 | 3116 | if (atTarget == null) return null; // ok, is applicable |
jfranck@1313 | 3117 | Attribute atValue = atTarget.member(names.value); |
jfranck@1313 | 3118 | if (!(atValue instanceof Attribute.Array)) return null; // error recovery |
jfranck@1313 | 3119 | return (Attribute.Array) atValue; |
jfranck@1313 | 3120 | } |
jfranck@1313 | 3121 | |
jjg@1521 | 3122 | private final Name[] dfltTargetMeta; |
jjg@1521 | 3123 | private Name[] defaultTargetMetaInfo(JCAnnotation a, Symbol s) { |
jjg@1521 | 3124 | return dfltTargetMeta; |
jjg@1521 | 3125 | } |
jjg@1521 | 3126 | |
duke@1 | 3127 | /** Check an annotation value. |
jfranck@1445 | 3128 | * |
jfranck@1445 | 3129 | * @param a The annotation tree to check |
jfranck@1445 | 3130 | * @return true if this annotation tree is valid, otherwise false |
duke@1 | 3131 | */ |
jfranck@1445 | 3132 | public boolean validateAnnotationDeferErrors(JCAnnotation a) { |
jfranck@1445 | 3133 | boolean res = false; |
jfranck@1445 | 3134 | final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log); |
jfranck@1445 | 3135 | try { |
jfranck@1445 | 3136 | res = validateAnnotation(a); |
jfranck@1445 | 3137 | } finally { |
jfranck@1445 | 3138 | log.popDiagnosticHandler(diagHandler); |
jfranck@1445 | 3139 | } |
jfranck@1445 | 3140 | return res; |
jfranck@1445 | 3141 | } |
jfranck@1445 | 3142 | |
jfranck@1445 | 3143 | private boolean validateAnnotation(JCAnnotation a) { |
jfranck@1445 | 3144 | boolean isValid = true; |
jfranck@1445 | 3145 | // collect an inventory of the annotation elements |
jfranck@1445 | 3146 | Set<MethodSymbol> members = new LinkedHashSet<MethodSymbol>(); |
duke@1 | 3147 | for (Scope.Entry e = a.annotationType.type.tsym.members().elems; |
jfranck@1729 | 3148 | e != null; |
jfranck@1729 | 3149 | e = e.sibling) |
mcimadamore@1920 | 3150 | if (e.sym.kind == MTH && e.sym.name != names.clinit && |
mcimadamore@1920 | 3151 | (e.sym.flags() & SYNTHETIC) == 0) |
duke@1 | 3152 | members.add((MethodSymbol) e.sym); |
duke@1 | 3153 | |
jfranck@1445 | 3154 | // remove the ones that are assigned values |
duke@1 | 3155 | for (JCTree arg : a.args) { |
jjg@1127 | 3156 | if (!arg.hasTag(ASSIGN)) continue; // recovery |
duke@1 | 3157 | JCAssign assign = (JCAssign) arg; |
duke@1 | 3158 | Symbol m = TreeInfo.symbol(assign.lhs); |
duke@1 | 3159 | if (m == null || m.type.isErroneous()) continue; |
jfranck@1445 | 3160 | if (!members.remove(m)) { |
jfranck@1445 | 3161 | isValid = false; |
jjg@479 | 3162 | log.error(assign.lhs.pos(), "duplicate.annotation.member.value", |
duke@1 | 3163 | m.name, a.type); |
jfranck@1445 | 3164 | } |
duke@1 | 3165 | } |
duke@1 | 3166 | |
duke@1 | 3167 | // all the remaining ones better have default values |
jfranck@1445 | 3168 | List<Name> missingDefaults = List.nil(); |
mcimadamore@632 | 3169 | for (MethodSymbol m : members) { |
mcimadamore@632 | 3170 | if (m.defaultValue == null && !m.type.isErroneous()) { |
jfranck@1445 | 3171 | missingDefaults = missingDefaults.append(m.name); |
mcimadamore@632 | 3172 | } |
mcimadamore@632 | 3173 | } |
jfranck@1445 | 3174 | missingDefaults = missingDefaults.reverse(); |
mcimadamore@632 | 3175 | if (missingDefaults.nonEmpty()) { |
jfranck@1445 | 3176 | isValid = false; |
mcimadamore@632 | 3177 | String key = (missingDefaults.size() > 1) |
mcimadamore@632 | 3178 | ? "annotation.missing.default.value.1" |
mcimadamore@632 | 3179 | : "annotation.missing.default.value"; |
mcimadamore@632 | 3180 | log.error(a.pos(), key, a.type, missingDefaults); |
mcimadamore@632 | 3181 | } |
duke@1 | 3182 | |
duke@1 | 3183 | // special case: java.lang.annotation.Target must not have |
duke@1 | 3184 | // repeated values in its value member |
duke@1 | 3185 | if (a.annotationType.type.tsym != syms.annotationTargetType.tsym || |
duke@1 | 3186 | a.args.tail == null) |
jfranck@1445 | 3187 | return isValid; |
duke@1 | 3188 | |
jfranck@1445 | 3189 | if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery |
duke@1 | 3190 | JCAssign assign = (JCAssign) a.args.head; |
duke@1 | 3191 | Symbol m = TreeInfo.symbol(assign.lhs); |
jfranck@1445 | 3192 | if (m.name != names.value) return false; |
duke@1 | 3193 | JCTree rhs = assign.rhs; |
jfranck@1445 | 3194 | if (!rhs.hasTag(NEWARRAY)) return false; |
duke@1 | 3195 | JCNewArray na = (JCNewArray) rhs; |
duke@1 | 3196 | Set<Symbol> targets = new HashSet<Symbol>(); |
duke@1 | 3197 | for (JCTree elem : na.elems) { |
duke@1 | 3198 | if (!targets.add(TreeInfo.symbol(elem))) { |
jfranck@1445 | 3199 | isValid = false; |
duke@1 | 3200 | log.error(elem.pos(), "repeated.annotation.target"); |
duke@1 | 3201 | } |
duke@1 | 3202 | } |
jfranck@1445 | 3203 | return isValid; |
duke@1 | 3204 | } |
duke@1 | 3205 | |
duke@1 | 3206 | void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) { |
duke@1 | 3207 | if (allowAnnotations && |
mcimadamore@795 | 3208 | lint.isEnabled(LintCategory.DEP_ANN) && |
duke@1 | 3209 | (s.flags() & DEPRECATED) != 0 && |
duke@1 | 3210 | !syms.deprecatedType.isErroneous() && |
duke@1 | 3211 | s.attribute(syms.deprecatedType.tsym) == null) { |
mcimadamore@795 | 3212 | log.warning(LintCategory.DEP_ANN, |
jjg@612 | 3213 | pos, "missing.deprecated.annotation"); |
duke@1 | 3214 | } |
duke@1 | 3215 | } |
duke@1 | 3216 | |
mcimadamore@852 | 3217 | void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) { |
mcimadamore@852 | 3218 | if ((s.flags() & DEPRECATED) != 0 && |
mcimadamore@852 | 3219 | (other.flags() & DEPRECATED) == 0 && |
mcimadamore@852 | 3220 | s.outermostClass() != other.outermostClass()) { |
mcimadamore@852 | 3221 | deferredLintHandler.report(new DeferredLintHandler.LintLogger() { |
mcimadamore@852 | 3222 | @Override |
mcimadamore@852 | 3223 | public void report() { |
mcimadamore@852 | 3224 | warnDeprecated(pos, s); |
mcimadamore@852 | 3225 | } |
mcimadamore@852 | 3226 | }); |
jjg@1157 | 3227 | } |
mcimadamore@852 | 3228 | } |
mcimadamore@852 | 3229 | |
mcimadamore@852 | 3230 | void checkSunAPI(final DiagnosticPosition pos, final Symbol s) { |
mcimadamore@852 | 3231 | if ((s.flags() & PROPRIETARY) != 0) { |
mcimadamore@852 | 3232 | deferredLintHandler.report(new DeferredLintHandler.LintLogger() { |
mcimadamore@852 | 3233 | public void report() { |
mcimadamore@852 | 3234 | if (enableSunApiLintControl) |
mcimadamore@852 | 3235 | warnSunApi(pos, "sun.proprietary", s); |
mcimadamore@852 | 3236 | else |
mcimadamore@1218 | 3237 | log.mandatoryWarning(pos, "sun.proprietary", s); |
mcimadamore@852 | 3238 | } |
mcimadamore@852 | 3239 | }); |
mcimadamore@852 | 3240 | } |
mcimadamore@852 | 3241 | } |
mcimadamore@852 | 3242 | |
jjg@1569 | 3243 | void checkProfile(final DiagnosticPosition pos, final Symbol s) { |
jjg@1569 | 3244 | if (profile != Profile.DEFAULT && (s.flags() & NOT_IN_PROFILE) != 0) { |
jjg@1569 | 3245 | log.error(pos, "not.in.profile", s, profile); |
jjg@1569 | 3246 | } |
jjg@1569 | 3247 | } |
jjg@1569 | 3248 | |
duke@1 | 3249 | /* ************************************************************************* |
duke@1 | 3250 | * Check for recursive annotation elements. |
duke@1 | 3251 | **************************************************************************/ |
duke@1 | 3252 | |
duke@1 | 3253 | /** Check for cycles in the graph of annotation elements. |
duke@1 | 3254 | */ |
duke@1 | 3255 | void checkNonCyclicElements(JCClassDecl tree) { |
duke@1 | 3256 | if ((tree.sym.flags_field & ANNOTATION) == 0) return; |
jjg@816 | 3257 | Assert.check((tree.sym.flags_field & LOCKED) == 0); |
duke@1 | 3258 | try { |
duke@1 | 3259 | tree.sym.flags_field |= LOCKED; |
duke@1 | 3260 | for (JCTree def : tree.defs) { |
jjg@1127 | 3261 | if (!def.hasTag(METHODDEF)) continue; |
duke@1 | 3262 | JCMethodDecl meth = (JCMethodDecl)def; |
duke@1 | 3263 | checkAnnotationResType(meth.pos(), meth.restype.type); |
duke@1 | 3264 | } |
duke@1 | 3265 | } finally { |
duke@1 | 3266 | tree.sym.flags_field &= ~LOCKED; |
duke@1 | 3267 | tree.sym.flags_field |= ACYCLIC_ANN; |
duke@1 | 3268 | } |
duke@1 | 3269 | } |
duke@1 | 3270 | |
duke@1 | 3271 | void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) { |
duke@1 | 3272 | if ((tsym.flags_field & ACYCLIC_ANN) != 0) |
duke@1 | 3273 | return; |
duke@1 | 3274 | if ((tsym.flags_field & LOCKED) != 0) { |
duke@1 | 3275 | log.error(pos, "cyclic.annotation.element"); |
duke@1 | 3276 | return; |
duke@1 | 3277 | } |
duke@1 | 3278 | try { |
duke@1 | 3279 | tsym.flags_field |= LOCKED; |
duke@1 | 3280 | for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) { |
duke@1 | 3281 | Symbol s = e.sym; |
duke@1 | 3282 | if (s.kind != Kinds.MTH) |
duke@1 | 3283 | continue; |
duke@1 | 3284 | checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType()); |
duke@1 | 3285 | } |
duke@1 | 3286 | } finally { |
duke@1 | 3287 | tsym.flags_field &= ~LOCKED; |
duke@1 | 3288 | tsym.flags_field |= ACYCLIC_ANN; |
duke@1 | 3289 | } |
duke@1 | 3290 | } |
duke@1 | 3291 | |
duke@1 | 3292 | void checkAnnotationResType(DiagnosticPosition pos, Type type) { |
jjg@1374 | 3293 | switch (type.getTag()) { |
jjg@1374 | 3294 | case CLASS: |
duke@1 | 3295 | if ((type.tsym.flags() & ANNOTATION) != 0) |
duke@1 | 3296 | checkNonCyclicElementsInternal(pos, type.tsym); |
duke@1 | 3297 | break; |
jjg@1374 | 3298 | case ARRAY: |
duke@1 | 3299 | checkAnnotationResType(pos, types.elemtype(type)); |
duke@1 | 3300 | break; |
duke@1 | 3301 | default: |
duke@1 | 3302 | break; // int etc |
duke@1 | 3303 | } |
duke@1 | 3304 | } |
duke@1 | 3305 | |
duke@1 | 3306 | /* ************************************************************************* |
duke@1 | 3307 | * Check for cycles in the constructor call graph. |
duke@1 | 3308 | **************************************************************************/ |
duke@1 | 3309 | |
duke@1 | 3310 | /** Check for cycles in the graph of constructors calling other |
duke@1 | 3311 | * constructors. |
duke@1 | 3312 | */ |
duke@1 | 3313 | void checkCyclicConstructors(JCClassDecl tree) { |
duke@1 | 3314 | Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>(); |
duke@1 | 3315 | |
duke@1 | 3316 | // enter each constructor this-call into the map |
duke@1 | 3317 | for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) { |
duke@1 | 3318 | JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head); |
duke@1 | 3319 | if (app == null) continue; |
duke@1 | 3320 | JCMethodDecl meth = (JCMethodDecl) l.head; |
duke@1 | 3321 | if (TreeInfo.name(app.meth) == names._this) { |
duke@1 | 3322 | callMap.put(meth.sym, TreeInfo.symbol(app.meth)); |
duke@1 | 3323 | } else { |
duke@1 | 3324 | meth.sym.flags_field |= ACYCLIC; |
duke@1 | 3325 | } |
duke@1 | 3326 | } |
duke@1 | 3327 | |
duke@1 | 3328 | // Check for cycles in the map |
duke@1 | 3329 | Symbol[] ctors = new Symbol[0]; |
duke@1 | 3330 | ctors = callMap.keySet().toArray(ctors); |
duke@1 | 3331 | for (Symbol caller : ctors) { |
duke@1 | 3332 | checkCyclicConstructor(tree, caller, callMap); |
duke@1 | 3333 | } |
duke@1 | 3334 | } |
duke@1 | 3335 | |
duke@1 | 3336 | /** Look in the map to see if the given constructor is part of a |
duke@1 | 3337 | * call cycle. |
duke@1 | 3338 | */ |
duke@1 | 3339 | private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor, |
duke@1 | 3340 | Map<Symbol,Symbol> callMap) { |
duke@1 | 3341 | if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) { |
duke@1 | 3342 | if ((ctor.flags_field & LOCKED) != 0) { |
duke@1 | 3343 | log.error(TreeInfo.diagnosticPositionFor(ctor, tree), |
duke@1 | 3344 | "recursive.ctor.invocation"); |
duke@1 | 3345 | } else { |
duke@1 | 3346 | ctor.flags_field |= LOCKED; |
duke@1 | 3347 | checkCyclicConstructor(tree, callMap.remove(ctor), callMap); |
duke@1 | 3348 | ctor.flags_field &= ~LOCKED; |
duke@1 | 3349 | } |
duke@1 | 3350 | ctor.flags_field |= ACYCLIC; |
duke@1 | 3351 | } |
duke@1 | 3352 | } |
duke@1 | 3353 | |
duke@1 | 3354 | /* ************************************************************************* |
duke@1 | 3355 | * Miscellaneous |
duke@1 | 3356 | **************************************************************************/ |
duke@1 | 3357 | |
duke@1 | 3358 | /** |
duke@1 | 3359 | * Return the opcode of the operator but emit an error if it is an |
duke@1 | 3360 | * error. |
duke@1 | 3361 | * @param pos position for error reporting. |
duke@1 | 3362 | * @param operator an operator |
duke@1 | 3363 | * @param tag a tree tag |
duke@1 | 3364 | * @param left type of left hand side |
duke@1 | 3365 | * @param right type of right hand side |
duke@1 | 3366 | */ |
duke@1 | 3367 | int checkOperator(DiagnosticPosition pos, |
duke@1 | 3368 | OperatorSymbol operator, |
jjg@1127 | 3369 | JCTree.Tag tag, |
duke@1 | 3370 | Type left, |
duke@1 | 3371 | Type right) { |
duke@1 | 3372 | if (operator.opcode == ByteCodes.error) { |
duke@1 | 3373 | log.error(pos, |
mcimadamore@853 | 3374 | "operator.cant.be.applied.1", |
duke@1 | 3375 | treeinfo.operatorName(tag), |
mcimadamore@853 | 3376 | left, right); |
duke@1 | 3377 | } |
duke@1 | 3378 | return operator.opcode; |
duke@1 | 3379 | } |
duke@1 | 3380 | |
duke@1 | 3381 | |
duke@1 | 3382 | /** |
duke@1 | 3383 | * Check for division by integer constant zero |
duke@1 | 3384 | * @param pos Position for error reporting. |
duke@1 | 3385 | * @param operator The operator for the expression |
duke@1 | 3386 | * @param operand The right hand operand for the expression |
duke@1 | 3387 | */ |
duke@1 | 3388 | void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) { |
duke@1 | 3389 | if (operand.constValue() != null |
mcimadamore@795 | 3390 | && lint.isEnabled(LintCategory.DIVZERO) |
vromero@1826 | 3391 | && operand.getTag().isSubRangeOf(LONG) |
duke@1 | 3392 | && ((Number) (operand.constValue())).longValue() == 0) { |
duke@1 | 3393 | int opc = ((OperatorSymbol)operator).opcode; |
duke@1 | 3394 | if (opc == ByteCodes.idiv || opc == ByteCodes.imod |
duke@1 | 3395 | || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) { |
mcimadamore@795 | 3396 | log.warning(LintCategory.DIVZERO, pos, "div.zero"); |
duke@1 | 3397 | } |
duke@1 | 3398 | } |
duke@1 | 3399 | } |
duke@1 | 3400 | |
duke@1 | 3401 | /** |
duke@1 | 3402 | * Check for empty statements after if |
duke@1 | 3403 | */ |
duke@1 | 3404 | void checkEmptyIf(JCIf tree) { |
jjg@1127 | 3405 | if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null && |
jjg@1127 | 3406 | lint.isEnabled(LintCategory.EMPTY)) |
mcimadamore@795 | 3407 | log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if"); |
duke@1 | 3408 | } |
duke@1 | 3409 | |
duke@1 | 3410 | /** Check that symbol is unique in given scope. |
duke@1 | 3411 | * @param pos Position for error reporting. |
duke@1 | 3412 | * @param sym The symbol. |
duke@1 | 3413 | * @param s The scope. |
duke@1 | 3414 | */ |
duke@1 | 3415 | boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) { |
duke@1 | 3416 | if (sym.type.isErroneous()) |
duke@1 | 3417 | return true; |
duke@1 | 3418 | if (sym.owner.name == names.any) return false; |
duke@1 | 3419 | for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) { |
duke@1 | 3420 | if (sym != e.sym && |
mcimadamore@858 | 3421 | (e.sym.flags() & CLASH) == 0 && |
mcimadamore@858 | 3422 | sym.kind == e.sym.kind && |
mcimadamore@858 | 3423 | sym.name != names.error && |
emc@2024 | 3424 | (sym.kind != MTH || |
emc@2024 | 3425 | types.hasSameArgs(sym.type, e.sym.type) || |
emc@2024 | 3426 | types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) { |
mcimadamore@844 | 3427 | if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) { |
duke@1 | 3428 | varargsDuplicateError(pos, sym, e.sym); |
mcimadamore@844 | 3429 | return true; |
mcimadamore@907 | 3430 | } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) { |
mcimadamore@252 | 3431 | duplicateErasureError(pos, sym, e.sym); |
mcimadamore@844 | 3432 | sym.flags_field |= CLASH; |
mcimadamore@844 | 3433 | return true; |
mcimadamore@844 | 3434 | } else { |
duke@1 | 3435 | duplicateError(pos, e.sym); |
mcimadamore@844 | 3436 | return false; |
mcimadamore@844 | 3437 | } |
duke@1 | 3438 | } |
duke@1 | 3439 | } |
duke@1 | 3440 | return true; |
duke@1 | 3441 | } |
mcimadamore@844 | 3442 | |
mcimadamore@858 | 3443 | /** Report duplicate declaration error. |
mcimadamore@858 | 3444 | */ |
mcimadamore@858 | 3445 | void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) { |
mcimadamore@858 | 3446 | if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) { |
mcimadamore@858 | 3447 | log.error(pos, "name.clash.same.erasure", sym1, sym2); |
mcimadamore@844 | 3448 | } |
mcimadamore@858 | 3449 | } |
duke@1 | 3450 | |
duke@1 | 3451 | /** Check that single-type import is not already imported or top-level defined, |
duke@1 | 3452 | * but make an exception for two single-type imports which denote the same type. |
duke@1 | 3453 | * @param pos Position for error reporting. |
duke@1 | 3454 | * @param sym The symbol. |
duke@1 | 3455 | * @param s The scope |
duke@1 | 3456 | */ |
duke@1 | 3457 | boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) { |
duke@1 | 3458 | return checkUniqueImport(pos, sym, s, false); |
duke@1 | 3459 | } |
duke@1 | 3460 | |
duke@1 | 3461 | /** Check that static single-type import is not already imported or top-level defined, |
duke@1 | 3462 | * but make an exception for two single-type imports which denote the same type. |
duke@1 | 3463 | * @param pos Position for error reporting. |
duke@1 | 3464 | * @param sym The symbol. |
duke@1 | 3465 | * @param s The scope |
duke@1 | 3466 | */ |
duke@1 | 3467 | boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) { |
duke@1 | 3468 | return checkUniqueImport(pos, sym, s, true); |
duke@1 | 3469 | } |
duke@1 | 3470 | |
duke@1 | 3471 | /** Check that single-type import is not already imported or top-level defined, |
duke@1 | 3472 | * but make an exception for two single-type imports which denote the same type. |
duke@1 | 3473 | * @param pos Position for error reporting. |
duke@1 | 3474 | * @param sym The symbol. |
duke@1 | 3475 | * @param s The scope. |
duke@1 | 3476 | * @param staticImport Whether or not this was a static import |
duke@1 | 3477 | */ |
duke@1 | 3478 | private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) { |
duke@1 | 3479 | for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) { |
duke@1 | 3480 | // is encountered class entered via a class declaration? |
duke@1 | 3481 | boolean isClassDecl = e.scope == s; |
duke@1 | 3482 | if ((isClassDecl || sym != e.sym) && |
duke@1 | 3483 | sym.kind == e.sym.kind && |
mcimadamore@1945 | 3484 | sym.name != names.error && |
mcimadamore@1945 | 3485 | (!staticImport || !e.isStaticallyImported())) { |
duke@1 | 3486 | if (!e.sym.type.isErroneous()) { |
duke@1 | 3487 | if (!isClassDecl) { |
duke@1 | 3488 | if (staticImport) |
emc@2102 | 3489 | log.error(pos, "already.defined.static.single.import", e.sym); |
duke@1 | 3490 | else |
emc@2102 | 3491 | log.error(pos, "already.defined.single.import", e.sym); |
duke@1 | 3492 | } |
duke@1 | 3493 | else if (sym != e.sym) |
emc@2102 | 3494 | log.error(pos, "already.defined.this.unit", e.sym); |
duke@1 | 3495 | } |
duke@1 | 3496 | return false; |
duke@1 | 3497 | } |
duke@1 | 3498 | } |
duke@1 | 3499 | return true; |
duke@1 | 3500 | } |
duke@1 | 3501 | |
duke@1 | 3502 | /** Check that a qualified name is in canonical form (for import decls). |
duke@1 | 3503 | */ |
duke@1 | 3504 | public void checkCanonical(JCTree tree) { |
duke@1 | 3505 | if (!isCanonical(tree)) |
duke@1 | 3506 | log.error(tree.pos(), "import.requires.canonical", |
duke@1 | 3507 | TreeInfo.symbol(tree)); |
duke@1 | 3508 | } |
duke@1 | 3509 | // where |
duke@1 | 3510 | private boolean isCanonical(JCTree tree) { |
jjg@1127 | 3511 | while (tree.hasTag(SELECT)) { |
duke@1 | 3512 | JCFieldAccess s = (JCFieldAccess) tree; |
duke@1 | 3513 | if (s.sym.owner != TreeInfo.symbol(s.selected)) |
duke@1 | 3514 | return false; |
duke@1 | 3515 | tree = s.selected; |
duke@1 | 3516 | } |
duke@1 | 3517 | return true; |
duke@1 | 3518 | } |
duke@1 | 3519 | |
ohrstrom@1384 | 3520 | /** Check that an auxiliary class is not accessed from any other file than its own. |
ohrstrom@1384 | 3521 | */ |
ohrstrom@1384 | 3522 | void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) { |
ohrstrom@1384 | 3523 | if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) && |
ohrstrom@1384 | 3524 | (c.flags() & AUXILIARY) != 0 && |
ohrstrom@1384 | 3525 | rs.isAccessible(env, c) && |
ohrstrom@1384 | 3526 | !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile)) |
ohrstrom@1384 | 3527 | { |
ohrstrom@1384 | 3528 | log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file", |
ohrstrom@1384 | 3529 | c, c.sourcefile); |
ohrstrom@1384 | 3530 | } |
ohrstrom@1384 | 3531 | } |
ohrstrom@1384 | 3532 | |
duke@1 | 3533 | private class ConversionWarner extends Warner { |
mcimadamore@795 | 3534 | final String uncheckedKey; |
duke@1 | 3535 | final Type found; |
duke@1 | 3536 | final Type expected; |
mcimadamore@795 | 3537 | public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) { |
duke@1 | 3538 | super(pos); |
mcimadamore@795 | 3539 | this.uncheckedKey = uncheckedKey; |
duke@1 | 3540 | this.found = found; |
duke@1 | 3541 | this.expected = expected; |
duke@1 | 3542 | } |
duke@1 | 3543 | |
jjg@398 | 3544 | @Override |
mcimadamore@795 | 3545 | public void warn(LintCategory lint) { |
duke@1 | 3546 | boolean warned = this.warned; |
mcimadamore@795 | 3547 | super.warn(lint); |
duke@1 | 3548 | if (warned) return; // suppress redundant diagnostics |
mcimadamore@795 | 3549 | switch (lint) { |
mcimadamore@795 | 3550 | case UNCHECKED: |
mcimadamore@795 | 3551 | Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected); |
mcimadamore@795 | 3552 | break; |
mcimadamore@795 | 3553 | case VARARGS: |
mcimadamore@795 | 3554 | if (method != null && |
mcimadamore@795 | 3555 | method.attribute(syms.trustMeType.tsym) != null && |
mcimadamore@795 | 3556 | isTrustMeAllowedOnMethod(method) && |
mcimadamore@795 | 3557 | !types.isReifiable(method.type.getParameterTypes().last())) { |
mcimadamore@795 | 3558 | Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last()); |
mcimadamore@795 | 3559 | } |
mcimadamore@795 | 3560 | break; |
mcimadamore@795 | 3561 | default: |
mcimadamore@795 | 3562 | throw new AssertionError("Unexpected lint: " + lint); |
mcimadamore@795 | 3563 | } |
duke@1 | 3564 | } |
duke@1 | 3565 | } |
duke@1 | 3566 | |
duke@1 | 3567 | public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) { |
duke@1 | 3568 | return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected); |
duke@1 | 3569 | } |
duke@1 | 3570 | |
duke@1 | 3571 | public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) { |
duke@1 | 3572 | return new ConversionWarner(pos, "unchecked.assign", found, expected); |
duke@1 | 3573 | } |
jlahoda@2111 | 3574 | |
jlahoda@2111 | 3575 | public void checkFunctionalInterface(JCClassDecl tree, ClassSymbol cs) { |
jlahoda@2111 | 3576 | Compound functionalType = cs.attribute(syms.functionalInterfaceType.tsym); |
jlahoda@2111 | 3577 | |
jlahoda@2111 | 3578 | if (functionalType != null) { |
jlahoda@2111 | 3579 | try { |
jlahoda@2111 | 3580 | types.findDescriptorSymbol((TypeSymbol)cs); |
jlahoda@2111 | 3581 | } catch (Types.FunctionDescriptorLookupError ex) { |
jlahoda@2111 | 3582 | DiagnosticPosition pos = tree.pos(); |
jlahoda@2111 | 3583 | for (JCAnnotation a : tree.getModifiers().annotations) { |
jlahoda@2111 | 3584 | if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) { |
jlahoda@2111 | 3585 | pos = a.pos(); |
jlahoda@2111 | 3586 | break; |
jlahoda@2111 | 3587 | } |
jlahoda@2111 | 3588 | } |
jlahoda@2111 | 3589 | log.error(pos, "bad.functional.intf.anno.1", ex.getDiagnostic()); |
jlahoda@2111 | 3590 | } |
jlahoda@2111 | 3591 | } |
jlahoda@2111 | 3592 | } |
duke@1 | 3593 | } |