src/share/classes/com/sun/tools/javac/comp/Check.java

Thu, 03 Mar 2011 17:34:58 +0000

author
mcimadamore
date
Thu, 03 Mar 2011 17:34:58 +0000
changeset 907
32565546784b
parent 889
015dc9a63efc
child 914
ca32f2986301
permissions
-rw-r--r--

7022054: Invalid compiler error on covariant overriding methods with the same erasure
Summary: Rules for method clash use notion of subsignature, which is sometimes too strict and incompatible with JDK 6
Reviewed-by: jjg

duke@1 1 /*
jjg@815 2 * Copyright (c) 1999, 2011, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
duke@1 30
duke@1 31 import com.sun.tools.javac.code.*;
duke@1 32 import com.sun.tools.javac.jvm.*;
duke@1 33 import com.sun.tools.javac.tree.*;
duke@1 34 import com.sun.tools.javac.util.*;
duke@1 35 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 36 import com.sun.tools.javac.util.List;
duke@1 37
duke@1 38 import com.sun.tools.javac.tree.JCTree.*;
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
duke@1 43
duke@1 44 import static com.sun.tools.javac.code.Flags.*;
duke@1 45 import static com.sun.tools.javac.code.Kinds.*;
duke@1 46 import static com.sun.tools.javac.code.TypeTags.*;
duke@1 47
jjg@700 48 import static com.sun.tools.javac.main.OptionName.*;
jjg@700 49
duke@1 50 /** Type checking helper class for the attribution phase.
duke@1 51 *
jjg@581 52 * <p><b>This is NOT part of any supported API.
jjg@581 53 * If you write code that depends on this, you do so at your own risk.
duke@1 54 * This code and its internal interfaces are subject to change or
duke@1 55 * deletion without notice.</b>
duke@1 56 */
duke@1 57 public class Check {
duke@1 58 protected static final Context.Key<Check> checkKey =
duke@1 59 new Context.Key<Check>();
duke@1 60
jjg@113 61 private final Names names;
duke@1 62 private final Log log;
duke@1 63 private final Symtab syms;
mcimadamore@690 64 private final Enter enter;
duke@1 65 private final Infer infer;
duke@1 66 private final Types types;
mcimadamore@89 67 private final JCDiagnostic.Factory diags;
duke@1 68 private final boolean skipAnnotations;
mcimadamore@359 69 private boolean warnOnSyntheticConflicts;
jjg@576 70 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 71 private boolean enableSunApiLintControl;
duke@1 72 private final TreeInfo treeinfo;
duke@1 73
duke@1 74 // The set of lint options currently in effect. It is initialized
duke@1 75 // from the context, and then is set/reset as needed by Attr as it
duke@1 76 // visits all the various parts of the trees during attribution.
duke@1 77 private Lint lint;
duke@1 78
mcimadamore@795 79 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 80 // Attr as it visits new method declarations.
mcimadamore@795 81 private MethodSymbol method;
mcimadamore@795 82
duke@1 83 public static Check instance(Context context) {
duke@1 84 Check instance = context.get(checkKey);
duke@1 85 if (instance == null)
duke@1 86 instance = new Check(context);
duke@1 87 return instance;
duke@1 88 }
duke@1 89
duke@1 90 protected Check(Context context) {
duke@1 91 context.put(checkKey, this);
duke@1 92
jjg@113 93 names = Names.instance(context);
duke@1 94 log = Log.instance(context);
duke@1 95 syms = Symtab.instance(context);
mcimadamore@690 96 enter = Enter.instance(context);
duke@1 97 infer = Infer.instance(context);
duke@1 98 this.types = Types.instance(context);
mcimadamore@89 99 diags = JCDiagnostic.Factory.instance(context);
duke@1 100 Options options = Options.instance(context);
duke@1 101 lint = Lint.instance(context);
duke@1 102 treeinfo = TreeInfo.instance(context);
duke@1 103
duke@1 104 Source source = Source.instance(context);
duke@1 105 allowGenerics = source.allowGenerics();
duke@1 106 allowAnnotations = source.allowAnnotations();
jjg@398 107 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 108 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
jjg@700 109 complexInference = options.isSet(COMPLEXINFERENCE);
jjg@700 110 skipAnnotations = options.isSet("skipAnnotations");
jjg@700 111 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 112 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 113 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 114
jjg@398 115 Target target = Target.instance(context);
jjg@398 116 syntheticNameChar = target.syntheticNameChar();
jjg@398 117
duke@1 118 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 119 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 120 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 121 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 122
jjg@60 123 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 124 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 125 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 126 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 127 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 128 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 129
mcimadamore@852 130 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 131 }
duke@1 132
duke@1 133 /** Switch: generics enabled?
duke@1 134 */
duke@1 135 boolean allowGenerics;
duke@1 136
duke@1 137 /** Switch: annotations enabled?
duke@1 138 */
duke@1 139 boolean allowAnnotations;
duke@1 140
jjg@398 141 /** Switch: covariant returns enabled?
jjg@398 142 */
jjg@398 143 boolean allowCovariantReturns;
jjg@398 144
mcimadamore@795 145 /** Switch: simplified varargs enabled?
mcimadamore@795 146 */
mcimadamore@795 147 boolean allowSimplifiedVarargs;
mcimadamore@795 148
duke@1 149 /** Switch: -complexinference option set?
duke@1 150 */
duke@1 151 boolean complexInference;
duke@1 152
jjg@398 153 /** Character for synthetic names
jjg@398 154 */
jjg@398 155 char syntheticNameChar;
jjg@398 156
duke@1 157 /** A table mapping flat names of all compiled classes in this run to their
duke@1 158 * symbols; maintained from outside.
duke@1 159 */
duke@1 160 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 161
duke@1 162 /** A handler for messages about deprecated usage.
duke@1 163 */
duke@1 164 private MandatoryWarningHandler deprecationHandler;
duke@1 165
duke@1 166 /** A handler for messages about unchecked or unsafe usage.
duke@1 167 */
duke@1 168 private MandatoryWarningHandler uncheckedHandler;
duke@1 169
jjg@582 170 /** A handler for messages about using proprietary API.
jjg@377 171 */
jjg@377 172 private MandatoryWarningHandler sunApiHandler;
duke@1 173
mcimadamore@852 174 /** A handler for deferred lint warnings.
mcimadamore@852 175 */
mcimadamore@852 176 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 177
duke@1 178 /* *************************************************************************
duke@1 179 * Errors and Warnings
duke@1 180 **************************************************************************/
duke@1 181
duke@1 182 Lint setLint(Lint newLint) {
duke@1 183 Lint prev = lint;
duke@1 184 lint = newLint;
duke@1 185 return prev;
duke@1 186 }
duke@1 187
mcimadamore@852 188 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 189 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 190 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 191 return prev;
mcimadamore@852 192 }
mcimadamore@852 193
mcimadamore@795 194 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 195 MethodSymbol prev = method;
mcimadamore@795 196 method = newMethod;
mcimadamore@795 197 return prev;
mcimadamore@795 198 }
mcimadamore@795 199
duke@1 200 /** Warn about deprecated symbol.
duke@1 201 * @param pos Position to be used for error reporting.
duke@1 202 * @param sym The deprecated symbol.
duke@1 203 */
duke@1 204 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 205 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 206 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 207 }
duke@1 208
duke@1 209 /** Warn about unchecked operation.
duke@1 210 * @param pos Position to be used for error reporting.
duke@1 211 * @param msg A string describing the problem.
duke@1 212 */
duke@1 213 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 214 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 215 uncheckedHandler.report(pos, msg, args);
duke@1 216 }
duke@1 217
mcimadamore@580 218 /** Warn about unsafe vararg method decl.
mcimadamore@580 219 * @param pos Position to be used for error reporting.
mcimadamore@580 220 * @param sym The deprecated symbol.
mcimadamore@580 221 */
mcimadamore@795 222 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 223 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 224 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 225 }
mcimadamore@580 226
jjg@582 227 /** Warn about using proprietary API.
jjg@377 228 * @param pos Position to be used for error reporting.
jjg@377 229 * @param msg A string describing the problem.
jjg@377 230 */
jjg@377 231 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 232 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 233 sunApiHandler.report(pos, msg, args);
jjg@377 234 }
jjg@377 235
jjg@505 236 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 237 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 238 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 239 }
jjg@505 240
duke@1 241 /**
duke@1 242 * Report any deferred diagnostics.
duke@1 243 */
duke@1 244 public void reportDeferredDiagnostics() {
duke@1 245 deprecationHandler.reportDeferredDiagnostic();
duke@1 246 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 247 sunApiHandler.reportDeferredDiagnostic();
duke@1 248 }
duke@1 249
duke@1 250
duke@1 251 /** Report a failure to complete a class.
duke@1 252 * @param pos Position to be used for error reporting.
duke@1 253 * @param ex The failure to report.
duke@1 254 */
duke@1 255 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 256 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 257 if (ex instanceof ClassReader.BadClassFile
jjg@576 258 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 259 else return syms.errType;
duke@1 260 }
duke@1 261
duke@1 262 /** Report a type error.
duke@1 263 * @param pos Position to be used for error reporting.
duke@1 264 * @param problem A string describing the error.
duke@1 265 * @param found The type that was found.
duke@1 266 * @param req The type that was required.
duke@1 267 */
duke@1 268 Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
duke@1 269 log.error(pos, "prob.found.req",
duke@1 270 problem, found, req);
jjg@110 271 return types.createErrorType(found);
duke@1 272 }
duke@1 273
duke@1 274 Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
duke@1 275 log.error(pos, "prob.found.req.1", problem, found, req, explanation);
jjg@110 276 return types.createErrorType(found);
duke@1 277 }
duke@1 278
duke@1 279 /** Report an error that wrong type tag was found.
duke@1 280 * @param pos Position to be used for error reporting.
duke@1 281 * @param required An internationalized string describing the type tag
duke@1 282 * required.
duke@1 283 * @param found The type that was found.
duke@1 284 */
duke@1 285 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 286 // this error used to be raised by the parser,
jrose@267 287 // but has been delayed to this point:
jrose@267 288 if (found instanceof Type && ((Type)found).tag == VOID) {
jrose@267 289 log.error(pos, "illegal.start.of.type");
jrose@267 290 return syms.errType;
jrose@267 291 }
duke@1 292 log.error(pos, "type.found.req", found, required);
jjg@110 293 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 294 }
duke@1 295
duke@1 296 /** Report an error that symbol cannot be referenced before super
duke@1 297 * has been called.
duke@1 298 * @param pos Position to be used for error reporting.
duke@1 299 * @param sym The referenced symbol.
duke@1 300 */
duke@1 301 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 302 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 303 }
duke@1 304
duke@1 305 /** Report duplicate declaration error.
duke@1 306 */
duke@1 307 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 308 if (!sym.type.isErroneous()) {
duke@1 309 log.error(pos, "already.defined", sym, sym.location());
duke@1 310 }
duke@1 311 }
duke@1 312
duke@1 313 /** Report array/varargs duplicate declaration
duke@1 314 */
duke@1 315 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 316 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 317 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 318 }
duke@1 319 }
duke@1 320
duke@1 321 /* ************************************************************************
duke@1 322 * duplicate declaration checking
duke@1 323 *************************************************************************/
duke@1 324
duke@1 325 /** Check that variable does not hide variable with same name in
duke@1 326 * immediately enclosing local scope.
duke@1 327 * @param pos Position for error reporting.
duke@1 328 * @param v The symbol.
duke@1 329 * @param s The scope.
duke@1 330 */
duke@1 331 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 332 if (s.next != null) {
duke@1 333 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 334 e.scope != null && e.sym.owner == v.owner;
duke@1 335 e = e.next()) {
duke@1 336 if (e.sym.kind == VAR &&
duke@1 337 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 338 v.name != names.error) {
duke@1 339 duplicateError(pos, e.sym);
duke@1 340 return;
duke@1 341 }
duke@1 342 }
duke@1 343 }
duke@1 344 }
duke@1 345
duke@1 346 /** Check that a class or interface does not hide a class or
duke@1 347 * interface with same name in immediately enclosing local scope.
duke@1 348 * @param pos Position for error reporting.
duke@1 349 * @param c The symbol.
duke@1 350 * @param s The scope.
duke@1 351 */
duke@1 352 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 353 if (s.next != null) {
duke@1 354 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 355 e.scope != null && e.sym.owner == c.owner;
duke@1 356 e = e.next()) {
mcimadamore@639 357 if (e.sym.kind == TYP && e.sym.type.tag != TYPEVAR &&
duke@1 358 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 359 c.name != names.error) {
duke@1 360 duplicateError(pos, e.sym);
duke@1 361 return;
duke@1 362 }
duke@1 363 }
duke@1 364 }
duke@1 365 }
duke@1 366
duke@1 367 /** Check that class does not have the same name as one of
duke@1 368 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 369 * return true if class is unique in its enclosing scope.
duke@1 370 * @param pos Position for error reporting.
duke@1 371 * @param name The class name.
duke@1 372 * @param s The enclosing scope.
duke@1 373 */
duke@1 374 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 375 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 376 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 377 duplicateError(pos, e.sym);
duke@1 378 return false;
duke@1 379 }
duke@1 380 }
duke@1 381 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 382 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 383 duplicateError(pos, sym);
duke@1 384 return true;
duke@1 385 }
duke@1 386 }
duke@1 387 return true;
duke@1 388 }
duke@1 389
duke@1 390 /* *************************************************************************
duke@1 391 * Class name generation
duke@1 392 **************************************************************************/
duke@1 393
duke@1 394 /** Return name of local class.
duke@1 395 * This is of the form <enclClass> $ n <classname>
duke@1 396 * where
duke@1 397 * enclClass is the flat name of the enclosing class,
duke@1 398 * classname is the simple name of the local class
duke@1 399 */
duke@1 400 Name localClassName(ClassSymbol c) {
duke@1 401 for (int i=1; ; i++) {
duke@1 402 Name flatname = names.
duke@1 403 fromString("" + c.owner.enclClass().flatname +
jjg@398 404 syntheticNameChar + i +
duke@1 405 c.name);
duke@1 406 if (compiled.get(flatname) == null) return flatname;
duke@1 407 }
duke@1 408 }
duke@1 409
duke@1 410 /* *************************************************************************
duke@1 411 * Type Checking
duke@1 412 **************************************************************************/
duke@1 413
duke@1 414 /** Check that a given type is assignable to a given proto-type.
duke@1 415 * If it is, return the type, otherwise return errType.
duke@1 416 * @param pos Position to be used for error reporting.
duke@1 417 * @param found The type that was found.
duke@1 418 * @param req The type that was required.
duke@1 419 */
duke@1 420 Type checkType(DiagnosticPosition pos, Type found, Type req) {
darcy@609 421 return checkType(pos, found, req, "incompatible.types");
darcy@609 422 }
darcy@609 423
darcy@609 424 Type checkType(DiagnosticPosition pos, Type found, Type req, String errKey) {
duke@1 425 if (req.tag == ERROR)
duke@1 426 return req;
mcimadamore@536 427 if (found.tag == FORALL)
mcimadamore@536 428 return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req));
duke@1 429 if (req.tag == NONE)
duke@1 430 return found;
duke@1 431 if (types.isAssignable(found, req, convertWarner(pos, found, req)))
duke@1 432 return found;
duke@1 433 if (found.tag <= DOUBLE && req.tag <= DOUBLE)
mcimadamore@89 434 return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req);
duke@1 435 if (found.isSuperBound()) {
duke@1 436 log.error(pos, "assignment.from.super-bound", found);
jjg@110 437 return types.createErrorType(found);
duke@1 438 }
duke@1 439 if (req.isExtendsBound()) {
duke@1 440 log.error(pos, "assignment.to.extends-bound", req);
jjg@110 441 return types.createErrorType(found);
duke@1 442 }
darcy@609 443 return typeError(pos, diags.fragment(errKey), found, req);
duke@1 444 }
duke@1 445
duke@1 446 /** Instantiate polymorphic type to some prototype, unless
duke@1 447 * prototype is `anyPoly' in which case polymorphic type
duke@1 448 * is returned unchanged.
duke@1 449 */
mcimadamore@383 450 Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException {
duke@1 451 if (pt == Infer.anyPoly && complexInference) {
duke@1 452 return t;
duke@1 453 } else if (pt == Infer.anyPoly || pt.tag == NONE) {
duke@1 454 Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
duke@1 455 return instantiatePoly(pos, t, newpt, warn);
duke@1 456 } else if (pt.tag == ERROR) {
duke@1 457 return pt;
duke@1 458 } else {
mcimadamore@536 459 try {
mcimadamore@536 460 return infer.instantiateExpr(t, pt, warn);
mcimadamore@536 461 } catch (Infer.NoInstanceException ex) {
mcimadamore@536 462 if (ex.isAmbiguous) {
mcimadamore@536 463 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 464 log.error(pos,
mcimadamore@536 465 "undetermined.type" + (d!=null ? ".1" : ""),
mcimadamore@536 466 t, d);
mcimadamore@536 467 return types.createErrorType(pt);
mcimadamore@536 468 } else {
mcimadamore@536 469 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 470 return typeError(pos,
mcimadamore@536 471 diags.fragment("incompatible.types" + (d!=null ? ".1" : ""), d),
mcimadamore@536 472 t, pt);
mcimadamore@536 473 }
mcimadamore@536 474 } catch (Infer.InvalidInstanceException ex) {
mcimadamore@536 475 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 476 log.error(pos, "invalid.inferred.types", t.tvars, d);
mcimadamore@536 477 return types.createErrorType(pt);
mcimadamore@536 478 }
duke@1 479 }
mcimadamore@536 480 }
duke@1 481
duke@1 482 /** Check that a given type can be cast to a given target type.
duke@1 483 * Return the result of the cast.
duke@1 484 * @param pos Position to be used for error reporting.
duke@1 485 * @param found The type that is being cast.
duke@1 486 * @param req The target type of the cast.
duke@1 487 */
duke@1 488 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
duke@1 489 if (found.tag == FORALL) {
duke@1 490 instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
duke@1 491 return req;
duke@1 492 } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 493 return req;
duke@1 494 } else {
duke@1 495 return typeError(pos,
mcimadamore@89 496 diags.fragment("inconvertible.types"),
duke@1 497 found, req);
duke@1 498 }
duke@1 499 }
duke@1 500 //where
duke@1 501 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 502 * type variables?
duke@1 503 */
duke@1 504 boolean isTypeVar(Type t) {
duke@1 505 return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
duke@1 506 }
duke@1 507
duke@1 508 /** Check that a type is within some bounds.
duke@1 509 *
duke@1 510 * Used in TypeApply to verify that, e.g., X in V<X> is a valid
duke@1 511 * type argument.
duke@1 512 * @param pos Position to be used for error reporting.
duke@1 513 * @param a The type that should be bounded by bs.
duke@1 514 * @param bs The bound.
duke@1 515 */
mcimadamore@821 516 private boolean checkExtends(Type a, TypeVar bs) {
mcimadamore@154 517 if (a.isUnbound()) {
mcimadamore@821 518 return true;
mcimadamore@154 519 } else if (a.tag != WILDCARD) {
mcimadamore@154 520 a = types.upperBound(a);
mcimadamore@821 521 return types.isSubtype(a, bs.bound);
mcimadamore@154 522 } else if (a.isExtendsBound()) {
mcimadamore@821 523 return types.isCastable(bs.getUpperBound(), types.upperBound(a), Warner.noWarnings);
mcimadamore@154 524 } else if (a.isSuperBound()) {
mcimadamore@821 525 return !types.notSoftSubtype(types.lowerBound(a), bs.getUpperBound());
mcimadamore@154 526 }
mcimadamore@821 527 return true;
mcimadamore@154 528 }
duke@1 529
duke@1 530 /** Check that type is different from 'void'.
duke@1 531 * @param pos Position to be used for error reporting.
duke@1 532 * @param t The type to be checked.
duke@1 533 */
duke@1 534 Type checkNonVoid(DiagnosticPosition pos, Type t) {
duke@1 535 if (t.tag == VOID) {
duke@1 536 log.error(pos, "void.not.allowed.here");
jjg@110 537 return types.createErrorType(t);
duke@1 538 } else {
duke@1 539 return t;
duke@1 540 }
duke@1 541 }
duke@1 542
duke@1 543 /** Check that type is a class or interface type.
duke@1 544 * @param pos Position to be used for error reporting.
duke@1 545 * @param t The type to be checked.
duke@1 546 */
duke@1 547 Type checkClassType(DiagnosticPosition pos, Type t) {
duke@1 548 if (t.tag != CLASS && t.tag != ERROR)
duke@1 549 return typeTagError(pos,
mcimadamore@89 550 diags.fragment("type.req.class"),
duke@1 551 (t.tag == TYPEVAR)
mcimadamore@89 552 ? diags.fragment("type.parameter", t)
duke@1 553 : t);
duke@1 554 else
duke@1 555 return t;
duke@1 556 }
duke@1 557
duke@1 558 /** Check that type is a class or interface type.
duke@1 559 * @param pos Position to be used for error reporting.
duke@1 560 * @param t The type to be checked.
duke@1 561 * @param noBounds True if type bounds are illegal here.
duke@1 562 */
duke@1 563 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 564 t = checkClassType(pos, t);
duke@1 565 if (noBounds && t.isParameterized()) {
duke@1 566 List<Type> args = t.getTypeArguments();
duke@1 567 while (args.nonEmpty()) {
duke@1 568 if (args.head.tag == WILDCARD)
duke@1 569 return typeTagError(pos,
jjg@598 570 diags.fragment("type.req.exact"),
duke@1 571 args.head);
duke@1 572 args = args.tail;
duke@1 573 }
duke@1 574 }
duke@1 575 return t;
duke@1 576 }
duke@1 577
duke@1 578 /** Check that type is a reifiable class, interface or array type.
duke@1 579 * @param pos Position to be used for error reporting.
duke@1 580 * @param t The type to be checked.
duke@1 581 */
duke@1 582 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
duke@1 583 if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
duke@1 584 return typeTagError(pos,
mcimadamore@89 585 diags.fragment("type.req.class.array"),
duke@1 586 t);
duke@1 587 } else if (!types.isReifiable(t)) {
duke@1 588 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 589 return types.createErrorType(t);
duke@1 590 } else {
duke@1 591 return t;
duke@1 592 }
duke@1 593 }
duke@1 594
duke@1 595 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 596 * or a type variable.
duke@1 597 * @param pos Position to be used for error reporting.
duke@1 598 * @param t The type to be checked.
duke@1 599 */
duke@1 600 Type checkRefType(DiagnosticPosition pos, Type t) {
duke@1 601 switch (t.tag) {
duke@1 602 case CLASS:
duke@1 603 case ARRAY:
duke@1 604 case TYPEVAR:
duke@1 605 case WILDCARD:
duke@1 606 case ERROR:
duke@1 607 return t;
duke@1 608 default:
duke@1 609 return typeTagError(pos,
mcimadamore@89 610 diags.fragment("type.req.ref"),
duke@1 611 t);
duke@1 612 }
duke@1 613 }
duke@1 614
jrose@267 615 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 616 * or a type variable.
jrose@267 617 * @param trees Original trees, used for error reporting.
jrose@267 618 * @param types The types to be checked.
jrose@267 619 */
jrose@267 620 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 621 List<JCExpression> tl = trees;
jrose@267 622 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 623 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 624 tl = tl.tail;
jrose@267 625 }
jrose@267 626 return types;
jrose@267 627 }
jrose@267 628
duke@1 629 /** Check that type is a null or reference type.
duke@1 630 * @param pos Position to be used for error reporting.
duke@1 631 * @param t The type to be checked.
duke@1 632 */
duke@1 633 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
duke@1 634 switch (t.tag) {
duke@1 635 case CLASS:
duke@1 636 case ARRAY:
duke@1 637 case TYPEVAR:
duke@1 638 case WILDCARD:
duke@1 639 case BOT:
duke@1 640 case ERROR:
duke@1 641 return t;
duke@1 642 default:
duke@1 643 return typeTagError(pos,
mcimadamore@89 644 diags.fragment("type.req.ref"),
duke@1 645 t);
duke@1 646 }
duke@1 647 }
duke@1 648
duke@1 649 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 650 * Return true if it doesn't.
duke@1 651 * @param pos Position to be used for error reporting.
duke@1 652 * @param flags The set of flags to be checked.
duke@1 653 * @param set1 Conflicting flags set #1.
duke@1 654 * @param set2 Conflicting flags set #2.
duke@1 655 */
duke@1 656 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 657 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 658 log.error(pos,
duke@1 659 "illegal.combination.of.modifiers",
mcimadamore@80 660 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 661 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 662 return false;
duke@1 663 } else
duke@1 664 return true;
duke@1 665 }
duke@1 666
mcimadamore@537 667 /** Check that the type inferred using the diamond operator does not contain
mcimadamore@537 668 * non-denotable types such as captured types or intersection types.
mcimadamore@537 669 * @param t the type inferred using the diamond operator
mcimadamore@537 670 */
mcimadamore@537 671 List<Type> checkDiamond(ClassType t) {
mcimadamore@537 672 DiamondTypeChecker dtc = new DiamondTypeChecker();
mcimadamore@537 673 ListBuffer<Type> buf = ListBuffer.lb();
mcimadamore@537 674 for (Type arg : t.getTypeArguments()) {
mcimadamore@537 675 if (!dtc.visit(arg, null)) {
mcimadamore@537 676 buf.append(arg);
mcimadamore@537 677 }
mcimadamore@537 678 }
mcimadamore@537 679 return buf.toList();
mcimadamore@537 680 }
mcimadamore@537 681
mcimadamore@537 682 static class DiamondTypeChecker extends Types.SimpleVisitor<Boolean, Void> {
mcimadamore@537 683 public Boolean visitType(Type t, Void s) {
mcimadamore@537 684 return true;
mcimadamore@537 685 }
mcimadamore@537 686 @Override
mcimadamore@537 687 public Boolean visitClassType(ClassType t, Void s) {
mcimadamore@537 688 if (t.isCompound()) {
mcimadamore@537 689 return false;
mcimadamore@537 690 }
mcimadamore@537 691 for (Type targ : t.getTypeArguments()) {
mcimadamore@537 692 if (!visit(targ, s)) {
mcimadamore@537 693 return false;
mcimadamore@537 694 }
mcimadamore@537 695 }
mcimadamore@537 696 return true;
mcimadamore@537 697 }
mcimadamore@537 698 @Override
mcimadamore@537 699 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@537 700 return false;
mcimadamore@537 701 }
mcimadamore@537 702 }
mcimadamore@537 703
mcimadamore@795 704 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 705 MethodSymbol m = tree.sym;
mcimadamore@795 706 if (!allowSimplifiedVarargs) return;
mcimadamore@795 707 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 708 Type varargElemType = null;
mcimadamore@580 709 if (m.isVarArgs()) {
mcimadamore@795 710 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 711 }
mcimadamore@795 712 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 713 if (varargElemType != null) {
mcimadamore@795 714 log.error(tree,
mcimadamore@795 715 "varargs.invalid.trustme.anno",
mcimadamore@795 716 syms.trustMeType.tsym,
mcimadamore@795 717 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 718 } else {
mcimadamore@795 719 log.error(tree,
mcimadamore@795 720 "varargs.invalid.trustme.anno",
mcimadamore@795 721 syms.trustMeType.tsym,
mcimadamore@795 722 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 723 }
mcimadamore@795 724 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 725 types.isReifiable(varargElemType)) {
mcimadamore@795 726 warnUnsafeVararg(tree,
mcimadamore@795 727 "varargs.redundant.trustme.anno",
mcimadamore@795 728 syms.trustMeType.tsym,
mcimadamore@795 729 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 730 }
mcimadamore@795 731 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 732 !types.isReifiable(varargElemType)) {
mcimadamore@795 733 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 734 }
mcimadamore@580 735 }
mcimadamore@795 736 //where
mcimadamore@795 737 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 738 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 739 (s.isConstructor() ||
mcimadamore@795 740 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 741 }
mcimadamore@580 742
mcimadamore@547 743 /**
mcimadamore@547 744 * Check that vararg method call is sound
mcimadamore@547 745 * @param pos Position to be used for error reporting.
mcimadamore@547 746 * @param argtypes Actual arguments supplied to vararg method.
mcimadamore@547 747 */
mcimadamore@795 748 void checkVararg(DiagnosticPosition pos, List<Type> argtypes, Symbol msym) {
mcimadamore@547 749 Type argtype = argtypes.last();
mcimadamore@795 750 if (!types.isReifiable(argtype) &&
mcimadamore@795 751 (!allowSimplifiedVarargs ||
mcimadamore@795 752 msym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@795 753 !isTrustMeAllowedOnMethod(msym))) {
mcimadamore@547 754 warnUnchecked(pos,
mcimadamore@547 755 "unchecked.generic.array.creation",
mcimadamore@547 756 argtype);
mcimadamore@580 757 }
mcimadamore@547 758 }
mcimadamore@547 759
mcimadamore@821 760 /**
mcimadamore@821 761 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 762 * (see JLS 4.5)
mcimadamore@821 763 *
mcimadamore@821 764 * @param t class type to be checked
mcimadamore@821 765 * @return true if 't' is well-formed
mcimadamore@821 766 */
mcimadamore@821 767 public boolean checkValidGenericType(Type t) {
mcimadamore@821 768 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 769 }
mcimadamore@821 770 //WHERE
mcimadamore@821 771 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 772 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 773 List<Type> actuals = type.allparams();
mcimadamore@821 774 List<Type> args = type.getTypeArguments();
mcimadamore@821 775 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@821 776 ListBuffer<Type> tvars_buf = new ListBuffer<Type>();
mcimadamore@821 777
mcimadamore@821 778 // For matching pairs of actual argument types `a' and
mcimadamore@821 779 // formal type parameters with declared bound `b' ...
mcimadamore@821 780 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 781 // exact type arguments needs to know their
mcimadamore@821 782 // bounds (for upper and lower bound
mcimadamore@821 783 // calculations). So we create new TypeVars with
mcimadamore@821 784 // bounds substed with actuals.
mcimadamore@821 785 tvars_buf.append(types.substBound(((TypeVar)forms.head),
mcimadamore@821 786 formals,
mcimadamore@821 787 actuals));
mcimadamore@821 788 args = args.tail;
mcimadamore@821 789 forms = forms.tail;
mcimadamore@821 790 }
mcimadamore@821 791
mcimadamore@821 792 args = type.getTypeArguments();
mcimadamore@821 793 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 794 formals,
mcimadamore@821 795 types.capture(type).allparams());
mcimadamore@821 796 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 797 // Let the actual arguments know their bound
mcimadamore@821 798 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 799 args = args.tail;
mcimadamore@821 800 tvars_cap = tvars_cap.tail;
mcimadamore@821 801 }
mcimadamore@821 802
mcimadamore@821 803 args = type.getTypeArguments();
mcimadamore@821 804 List<Type> tvars = tvars_buf.toList();
mcimadamore@821 805
mcimadamore@821 806 while (args.nonEmpty() && tvars.nonEmpty()) {
mcimadamore@821 807 Type actual = types.subst(args.head,
mcimadamore@821 808 type.tsym.type.getTypeArguments(),
mcimadamore@821 809 tvars_buf.toList());
mcimadamore@854 810 if (!isTypeArgErroneous(actual) &&
mcimadamore@854 811 !tvars.head.getUpperBound().isErroneous() &&
mcimadamore@854 812 !checkExtends(actual, (TypeVar)tvars.head)) {
mcimadamore@821 813 return args.head;
mcimadamore@821 814 }
mcimadamore@821 815 args = args.tail;
mcimadamore@821 816 tvars = tvars.tail;
mcimadamore@821 817 }
mcimadamore@821 818
mcimadamore@821 819 args = type.getTypeArguments();
mcimadamore@828 820 tvars = tvars_buf.toList();
mcimadamore@821 821
mcimadamore@821 822 for (Type arg : types.capture(type).getTypeArguments()) {
mcimadamore@828 823 if (arg.tag == TYPEVAR &&
mcimadamore@828 824 arg.getUpperBound().isErroneous() &&
mcimadamore@854 825 !tvars.head.getUpperBound().isErroneous() &&
mcimadamore@854 826 !isTypeArgErroneous(args.head)) {
mcimadamore@821 827 return args.head;
mcimadamore@821 828 }
mcimadamore@828 829 tvars = tvars.tail;
mcimadamore@854 830 args = args.tail;
mcimadamore@821 831 }
mcimadamore@821 832
mcimadamore@821 833 return null;
mcimadamore@821 834 }
mcimadamore@854 835 //where
mcimadamore@854 836 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 837 return isTypeArgErroneous.visit(t);
mcimadamore@854 838 }
mcimadamore@854 839
mcimadamore@854 840 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 841 public Boolean visitType(Type t, Void s) {
mcimadamore@854 842 return t.isErroneous();
mcimadamore@854 843 }
mcimadamore@854 844 @Override
mcimadamore@854 845 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 846 return visit(t.getUpperBound());
mcimadamore@854 847 }
mcimadamore@854 848 @Override
mcimadamore@854 849 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 850 return visit(t.getUpperBound()) ||
mcimadamore@854 851 visit(t.getLowerBound());
mcimadamore@854 852 }
mcimadamore@854 853 @Override
mcimadamore@854 854 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 855 return visit(t.type);
mcimadamore@854 856 }
mcimadamore@854 857 };
mcimadamore@821 858
duke@1 859 /** Check that given modifiers are legal for given symbol and
duke@1 860 * return modifiers together with any implicit modififiers for that symbol.
duke@1 861 * Warning: we can't use flags() here since this method
duke@1 862 * is called during class enter, when flags() would cause a premature
duke@1 863 * completion.
duke@1 864 * @param pos Position to be used for error reporting.
duke@1 865 * @param flags The set of modifiers given in a definition.
duke@1 866 * @param sym The defined symbol.
duke@1 867 */
duke@1 868 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 869 long mask;
duke@1 870 long implicit = 0;
duke@1 871 switch (sym.kind) {
duke@1 872 case VAR:
duke@1 873 if (sym.owner.kind != TYP)
duke@1 874 mask = LocalVarFlags;
duke@1 875 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 876 mask = implicit = InterfaceVarFlags;
duke@1 877 else
duke@1 878 mask = VarFlags;
duke@1 879 break;
duke@1 880 case MTH:
duke@1 881 if (sym.name == names.init) {
duke@1 882 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 883 // enum constructors cannot be declared public or
duke@1 884 // protected and must be implicitly or explicitly
duke@1 885 // private
duke@1 886 implicit = PRIVATE;
duke@1 887 mask = PRIVATE;
duke@1 888 } else
duke@1 889 mask = ConstructorFlags;
duke@1 890 } else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 891 mask = implicit = InterfaceMethodFlags;
duke@1 892 else {
duke@1 893 mask = MethodFlags;
duke@1 894 }
duke@1 895 // Imply STRICTFP if owner has STRICTFP set.
duke@1 896 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 897 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 898 break;
duke@1 899 case TYP:
duke@1 900 if (sym.isLocal()) {
duke@1 901 mask = LocalClassFlags;
jjg@113 902 if (sym.name.isEmpty()) { // Anonymous class
duke@1 903 // Anonymous classes in static methods are themselves static;
duke@1 904 // that's why we admit STATIC here.
duke@1 905 mask |= STATIC;
duke@1 906 // JLS: Anonymous classes are final.
duke@1 907 implicit |= FINAL;
duke@1 908 }
duke@1 909 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 910 (flags & ENUM) != 0)
duke@1 911 log.error(pos, "enums.must.be.static");
duke@1 912 } else if (sym.owner.kind == TYP) {
duke@1 913 mask = MemberClassFlags;
duke@1 914 if (sym.owner.owner.kind == PCK ||
duke@1 915 (sym.owner.flags_field & STATIC) != 0)
duke@1 916 mask |= STATIC;
duke@1 917 else if ((flags & ENUM) != 0)
duke@1 918 log.error(pos, "enums.must.be.static");
duke@1 919 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 920 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 921 } else {
duke@1 922 mask = ClassFlags;
duke@1 923 }
duke@1 924 // Interfaces are always ABSTRACT
duke@1 925 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 926
duke@1 927 if ((flags & ENUM) != 0) {
duke@1 928 // enums can't be declared abstract or final
duke@1 929 mask &= ~(ABSTRACT | FINAL);
duke@1 930 implicit |= implicitEnumFinalFlag(tree);
duke@1 931 }
duke@1 932 // Imply STRICTFP if owner has STRICTFP set.
duke@1 933 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 934 break;
duke@1 935 default:
duke@1 936 throw new AssertionError();
duke@1 937 }
duke@1 938 long illegal = flags & StandardFlags & ~mask;
duke@1 939 if (illegal != 0) {
duke@1 940 if ((illegal & INTERFACE) != 0) {
duke@1 941 log.error(pos, "intf.not.allowed.here");
duke@1 942 mask |= INTERFACE;
duke@1 943 }
duke@1 944 else {
duke@1 945 log.error(pos,
mcimadamore@80 946 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 947 }
duke@1 948 }
duke@1 949 else if ((sym.kind == TYP ||
duke@1 950 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 951 // in the presence of inner classes. Should it be deleted here?
duke@1 952 checkDisjoint(pos, flags,
duke@1 953 ABSTRACT,
duke@1 954 PRIVATE | STATIC))
duke@1 955 &&
duke@1 956 checkDisjoint(pos, flags,
duke@1 957 ABSTRACT | INTERFACE,
duke@1 958 FINAL | NATIVE | SYNCHRONIZED)
duke@1 959 &&
duke@1 960 checkDisjoint(pos, flags,
duke@1 961 PUBLIC,
duke@1 962 PRIVATE | PROTECTED)
duke@1 963 &&
duke@1 964 checkDisjoint(pos, flags,
duke@1 965 PRIVATE,
duke@1 966 PUBLIC | PROTECTED)
duke@1 967 &&
duke@1 968 checkDisjoint(pos, flags,
duke@1 969 FINAL,
duke@1 970 VOLATILE)
duke@1 971 &&
duke@1 972 (sym.kind == TYP ||
duke@1 973 checkDisjoint(pos, flags,
duke@1 974 ABSTRACT | NATIVE,
duke@1 975 STRICTFP))) {
duke@1 976 // skip
duke@1 977 }
duke@1 978 return flags & (mask | ~StandardFlags) | implicit;
duke@1 979 }
duke@1 980
duke@1 981
duke@1 982 /** Determine if this enum should be implicitly final.
duke@1 983 *
duke@1 984 * If the enum has no specialized enum contants, it is final.
duke@1 985 *
duke@1 986 * If the enum does have specialized enum contants, it is
duke@1 987 * <i>not</i> final.
duke@1 988 */
duke@1 989 private long implicitEnumFinalFlag(JCTree tree) {
duke@1 990 if (tree.getTag() != JCTree.CLASSDEF) return 0;
duke@1 991 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 992 boolean specialized;
duke@1 993 SpecialTreeVisitor() {
duke@1 994 this.specialized = false;
duke@1 995 };
duke@1 996
jjg@398 997 @Override
duke@1 998 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 999
jjg@398 1000 @Override
duke@1 1001 public void visitVarDef(JCVariableDecl tree) {
duke@1 1002 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1003 if (tree.init instanceof JCNewClass &&
duke@1 1004 ((JCNewClass) tree.init).def != null) {
duke@1 1005 specialized = true;
duke@1 1006 }
duke@1 1007 }
duke@1 1008 }
duke@1 1009 }
duke@1 1010
duke@1 1011 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1012 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1013 for (JCTree defs: cdef.defs) {
duke@1 1014 defs.accept(sts);
duke@1 1015 if (sts.specialized) return 0;
duke@1 1016 }
duke@1 1017 return FINAL;
duke@1 1018 }
duke@1 1019
duke@1 1020 /* *************************************************************************
duke@1 1021 * Type Validation
duke@1 1022 **************************************************************************/
duke@1 1023
duke@1 1024 /** Validate a type expression. That is,
duke@1 1025 * check that all type arguments of a parametric type are within
duke@1 1026 * their bounds. This must be done in a second phase after type attributon
duke@1 1027 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1028 *
duke@1 1029 * class B<A extends C> { ... }
duke@1 1030 * class C extends B<C> { ... }
duke@1 1031 *
duke@1 1032 * and we can't make sure that the bound is already attributed because
duke@1 1033 * of possible cycles.
mcimadamore@638 1034 *
mcimadamore@638 1035 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1036 * and reporting any completion failures.
duke@1 1037 */
mcimadamore@122 1038 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1039 validate(tree, env, true);
duke@1 1040 }
mcimadamore@638 1041 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1042 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1043 }
duke@1 1044
duke@1 1045 /** Visitor method: Validate a list of type expressions.
duke@1 1046 */
mcimadamore@122 1047 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1048 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1049 validate(l.head, env);
duke@1 1050 }
duke@1 1051
duke@1 1052 /** A visitor class for type validation.
duke@1 1053 */
duke@1 1054 class Validator extends JCTree.Visitor {
duke@1 1055
mcimadamore@638 1056 boolean isOuter;
mcimadamore@638 1057 Env<AttrContext> env;
mcimadamore@638 1058
mcimadamore@638 1059 Validator(Env<AttrContext> env) {
mcimadamore@638 1060 this.env = env;
mcimadamore@638 1061 }
mcimadamore@638 1062
jjg@398 1063 @Override
duke@1 1064 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1065 tree.elemtype.accept(this);
duke@1 1066 }
duke@1 1067
jjg@398 1068 @Override
duke@1 1069 public void visitTypeApply(JCTypeApply tree) {
duke@1 1070 if (tree.type.tag == CLASS) {
duke@1 1071 List<JCExpression> args = tree.arguments;
mcimadamore@158 1072 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1073
mcimadamore@821 1074 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1075 if (incompatibleArg != null) {
mcimadamore@821 1076 for (JCTree arg : tree.arguments) {
mcimadamore@821 1077 if (arg.type == incompatibleArg) {
mcimadamore@829 1078 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1079 }
mcimadamore@829 1080 forms = forms.tail;
mcimadamore@829 1081 }
mcimadamore@829 1082 }
mcimadamore@829 1083
mcimadamore@829 1084 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1085
mcimadamore@638 1086 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1087
duke@1 1088 // For matching pairs of actual argument types `a' and
duke@1 1089 // formal type parameters with declared bound `b' ...
duke@1 1090 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1091 validateTree(args.head,
mcimadamore@638 1092 !(isOuter && is_java_lang_Class),
mcimadamore@638 1093 false);
duke@1 1094 args = args.tail;
duke@1 1095 forms = forms.tail;
duke@1 1096 }
duke@1 1097
duke@1 1098 // Check that this type is either fully parameterized, or
duke@1 1099 // not parameterized at all.
duke@1 1100 if (tree.type.getEnclosingType().isRaw())
duke@1 1101 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
duke@1 1102 if (tree.clazz.getTag() == JCTree.SELECT)
duke@1 1103 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1104 }
duke@1 1105 }
duke@1 1106
jjg@398 1107 @Override
duke@1 1108 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1109 validateTrees(tree.bounds, true, isOuter);
duke@1 1110 checkClassBounds(tree.pos(), tree.type);
duke@1 1111 }
duke@1 1112
duke@1 1113 @Override
duke@1 1114 public void visitWildcard(JCWildcard tree) {
duke@1 1115 if (tree.inner != null)
mcimadamore@638 1116 validateTree(tree.inner, true, isOuter);
duke@1 1117 }
duke@1 1118
jjg@398 1119 @Override
duke@1 1120 public void visitSelect(JCFieldAccess tree) {
duke@1 1121 if (tree.type.tag == CLASS) {
duke@1 1122 visitSelectInternal(tree);
duke@1 1123
duke@1 1124 // Check that this type is either fully parameterized, or
duke@1 1125 // not parameterized at all.
duke@1 1126 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1127 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1128 }
duke@1 1129 }
mcimadamore@852 1130
duke@1 1131 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1132 if (tree.type.tsym.isStatic() &&
duke@1 1133 tree.selected.type.isParameterized()) {
duke@1 1134 // The enclosing type is not a class, so we are
duke@1 1135 // looking at a static member type. However, the
duke@1 1136 // qualifying expression is parameterized.
duke@1 1137 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1138 } else {
duke@1 1139 // otherwise validate the rest of the expression
mcimadamore@122 1140 tree.selected.accept(this);
duke@1 1141 }
duke@1 1142 }
duke@1 1143
duke@1 1144 /** Default visitor method: do nothing.
duke@1 1145 */
jjg@398 1146 @Override
duke@1 1147 public void visitTree(JCTree tree) {
duke@1 1148 }
mcimadamore@122 1149
mcimadamore@638 1150 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1151 try {
mcimadamore@638 1152 if (tree != null) {
mcimadamore@638 1153 this.isOuter = isOuter;
mcimadamore@638 1154 tree.accept(this);
mcimadamore@638 1155 if (checkRaw)
mcimadamore@638 1156 checkRaw(tree, env);
mcimadamore@638 1157 }
mcimadamore@638 1158 } catch (CompletionFailure ex) {
mcimadamore@638 1159 completionError(tree.pos(), ex);
mcimadamore@638 1160 }
mcimadamore@638 1161 }
mcimadamore@638 1162
mcimadamore@638 1163 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1164 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1165 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1166 }
mcimadamore@638 1167
mcimadamore@638 1168 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1169 if (lint.isEnabled(LintCategory.RAW) &&
mcimadamore@638 1170 tree.type.tag == CLASS &&
mcimadamore@638 1171 !TreeInfo.isDiamond(tree) &&
mcimadamore@638 1172 !env.enclClass.name.isEmpty() && //anonymous or intersection
mcimadamore@638 1173 tree.type.isRaw()) {
mcimadamore@795 1174 log.warning(LintCategory.RAW,
mcimadamore@638 1175 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1176 }
mcimadamore@638 1177 }
duke@1 1178 }
duke@1 1179
duke@1 1180 /* *************************************************************************
duke@1 1181 * Exception checking
duke@1 1182 **************************************************************************/
duke@1 1183
duke@1 1184 /* The following methods treat classes as sets that contain
duke@1 1185 * the class itself and all their subclasses
duke@1 1186 */
duke@1 1187
duke@1 1188 /** Is given type a subtype of some of the types in given list?
duke@1 1189 */
duke@1 1190 boolean subset(Type t, List<Type> ts) {
duke@1 1191 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1192 if (types.isSubtype(t, l.head)) return true;
duke@1 1193 return false;
duke@1 1194 }
duke@1 1195
duke@1 1196 /** Is given type a subtype or supertype of
duke@1 1197 * some of the types in given list?
duke@1 1198 */
duke@1 1199 boolean intersects(Type t, List<Type> ts) {
duke@1 1200 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1201 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1202 return false;
duke@1 1203 }
duke@1 1204
duke@1 1205 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1206 * in the list.
duke@1 1207 */
duke@1 1208 List<Type> incl(Type t, List<Type> ts) {
duke@1 1209 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1210 }
duke@1 1211
duke@1 1212 /** Remove type set from type set list.
duke@1 1213 */
duke@1 1214 List<Type> excl(Type t, List<Type> ts) {
duke@1 1215 if (ts.isEmpty()) {
duke@1 1216 return ts;
duke@1 1217 } else {
duke@1 1218 List<Type> ts1 = excl(t, ts.tail);
duke@1 1219 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1220 else if (ts1 == ts.tail) return ts;
duke@1 1221 else return ts1.prepend(ts.head);
duke@1 1222 }
duke@1 1223 }
duke@1 1224
duke@1 1225 /** Form the union of two type set lists.
duke@1 1226 */
duke@1 1227 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1228 List<Type> ts = ts1;
duke@1 1229 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1230 ts = incl(l.head, ts);
duke@1 1231 return ts;
duke@1 1232 }
duke@1 1233
duke@1 1234 /** Form the difference of two type lists.
duke@1 1235 */
duke@1 1236 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1237 List<Type> ts = ts1;
duke@1 1238 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1239 ts = excl(l.head, ts);
duke@1 1240 return ts;
duke@1 1241 }
duke@1 1242
duke@1 1243 /** Form the intersection of two type lists.
duke@1 1244 */
duke@1 1245 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1246 List<Type> ts = List.nil();
duke@1 1247 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1248 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1249 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1250 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1251 return ts;
duke@1 1252 }
duke@1 1253
duke@1 1254 /** Is exc an exception symbol that need not be declared?
duke@1 1255 */
duke@1 1256 boolean isUnchecked(ClassSymbol exc) {
duke@1 1257 return
duke@1 1258 exc.kind == ERR ||
duke@1 1259 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1260 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1261 }
duke@1 1262
duke@1 1263 /** Is exc an exception type that need not be declared?
duke@1 1264 */
duke@1 1265 boolean isUnchecked(Type exc) {
duke@1 1266 return
duke@1 1267 (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
duke@1 1268 (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
duke@1 1269 exc.tag == BOT;
duke@1 1270 }
duke@1 1271
duke@1 1272 /** Same, but handling completion failures.
duke@1 1273 */
duke@1 1274 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1275 try {
duke@1 1276 return isUnchecked(exc);
duke@1 1277 } catch (CompletionFailure ex) {
duke@1 1278 completionError(pos, ex);
duke@1 1279 return true;
duke@1 1280 }
duke@1 1281 }
duke@1 1282
duke@1 1283 /** Is exc handled by given exception list?
duke@1 1284 */
duke@1 1285 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1286 return isUnchecked(exc) || subset(exc, handled);
duke@1 1287 }
duke@1 1288
duke@1 1289 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1290 * @param thrown The list of thrown exceptions.
duke@1 1291 * @param handled The list of handled exceptions.
duke@1 1292 */
mcimadamore@362 1293 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1294 List<Type> unhandled = List.nil();
duke@1 1295 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1296 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1297 return unhandled;
duke@1 1298 }
duke@1 1299
duke@1 1300 /* *************************************************************************
duke@1 1301 * Overriding/Implementation checking
duke@1 1302 **************************************************************************/
duke@1 1303
duke@1 1304 /** The level of access protection given by a flag set,
duke@1 1305 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1306 */
duke@1 1307 static int protection(long flags) {
duke@1 1308 switch ((short)(flags & AccessFlags)) {
duke@1 1309 case PRIVATE: return 3;
duke@1 1310 case PROTECTED: return 1;
duke@1 1311 default:
duke@1 1312 case PUBLIC: return 0;
duke@1 1313 case 0: return 2;
duke@1 1314 }
duke@1 1315 }
duke@1 1316
duke@1 1317 /** A customized "cannot override" error message.
duke@1 1318 * @param m The overriding method.
duke@1 1319 * @param other The overridden method.
duke@1 1320 * @return An internationalized string.
duke@1 1321 */
mcimadamore@89 1322 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1323 String key;
duke@1 1324 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1325 key = "cant.override";
duke@1 1326 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1327 key = "cant.implement";
duke@1 1328 else
duke@1 1329 key = "clashes.with";
mcimadamore@89 1330 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1331 }
duke@1 1332
duke@1 1333 /** A customized "override" warning message.
duke@1 1334 * @param m The overriding method.
duke@1 1335 * @param other The overridden method.
duke@1 1336 * @return An internationalized string.
duke@1 1337 */
mcimadamore@89 1338 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1339 String key;
duke@1 1340 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1341 key = "unchecked.override";
duke@1 1342 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1343 key = "unchecked.implement";
duke@1 1344 else
duke@1 1345 key = "unchecked.clash.with";
mcimadamore@89 1346 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1347 }
duke@1 1348
duke@1 1349 /** A customized "override" warning message.
duke@1 1350 * @param m The overriding method.
duke@1 1351 * @param other The overridden method.
duke@1 1352 * @return An internationalized string.
duke@1 1353 */
mcimadamore@89 1354 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1355 String key;
duke@1 1356 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1357 key = "varargs.override";
duke@1 1358 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1359 key = "varargs.implement";
duke@1 1360 else
duke@1 1361 key = "varargs.clash.with";
mcimadamore@89 1362 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1363 }
duke@1 1364
duke@1 1365 /** Check that this method conforms with overridden method 'other'.
duke@1 1366 * where `origin' is the class where checking started.
duke@1 1367 * Complications:
duke@1 1368 * (1) Do not check overriding of synthetic methods
duke@1 1369 * (reason: they might be final).
duke@1 1370 * todo: check whether this is still necessary.
duke@1 1371 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1372 * than the method it implements. Augment the proxy methods with the
duke@1 1373 * undeclared exceptions in this case.
duke@1 1374 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1375 * has a result type
duke@1 1376 * extended by the result type of the method it implements.
duke@1 1377 * Change the proxies result type to the smaller type in this case.
duke@1 1378 *
duke@1 1379 * @param tree The tree from which positions
duke@1 1380 * are extracted for errors.
duke@1 1381 * @param m The overriding method.
duke@1 1382 * @param other The overridden method.
duke@1 1383 * @param origin The class of which the overriding method
duke@1 1384 * is a member.
duke@1 1385 */
duke@1 1386 void checkOverride(JCTree tree,
duke@1 1387 MethodSymbol m,
duke@1 1388 MethodSymbol other,
duke@1 1389 ClassSymbol origin) {
duke@1 1390 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1391 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1392 return;
duke@1 1393 }
duke@1 1394
duke@1 1395 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1396 if ((m.flags() & STATIC) != 0 &&
duke@1 1397 (other.flags() & STATIC) == 0) {
duke@1 1398 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1399 cannotOverride(m, other));
duke@1 1400 return;
duke@1 1401 }
duke@1 1402
duke@1 1403 // Error if instance method overrides static or final
duke@1 1404 // method (JLS 8.4.6.1).
duke@1 1405 if ((other.flags() & FINAL) != 0 ||
duke@1 1406 (m.flags() & STATIC) == 0 &&
duke@1 1407 (other.flags() & STATIC) != 0) {
duke@1 1408 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1409 cannotOverride(m, other),
mcimadamore@80 1410 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1411 return;
duke@1 1412 }
duke@1 1413
duke@1 1414 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1415 // handled in validateAnnotationMethod
duke@1 1416 return;
duke@1 1417 }
duke@1 1418
duke@1 1419 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1420 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1421 protection(m.flags()) > protection(other.flags())) {
duke@1 1422 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1423 cannotOverride(m, other),
mcimadamore@80 1424 other.flags() == 0 ?
mcimadamore@80 1425 Flag.PACKAGE :
mcimadamore@80 1426 asFlagSet(other.flags() & AccessFlags));
duke@1 1427 return;
duke@1 1428 }
duke@1 1429
duke@1 1430 Type mt = types.memberType(origin.type, m);
duke@1 1431 Type ot = types.memberType(origin.type, other);
duke@1 1432 // Error if overriding result type is different
duke@1 1433 // (or, in the case of generics mode, not a subtype) of
duke@1 1434 // overridden result type. We have to rename any type parameters
duke@1 1435 // before comparing types.
duke@1 1436 List<Type> mtvars = mt.getTypeArguments();
duke@1 1437 List<Type> otvars = ot.getTypeArguments();
duke@1 1438 Type mtres = mt.getReturnType();
duke@1 1439 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1440
mcimadamore@795 1441 overrideWarner.clear();
duke@1 1442 boolean resultTypesOK =
tbell@202 1443 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1444 if (!resultTypesOK) {
jjg@398 1445 if (!allowCovariantReturns &&
duke@1 1446 m.owner != origin &&
duke@1 1447 m.owner.isSubClass(other.owner, types)) {
duke@1 1448 // allow limited interoperability with covariant returns
duke@1 1449 } else {
mcimadamore@362 1450 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1451 "override.incompatible.ret",
mcimadamore@362 1452 cannotOverride(m, other),
duke@1 1453 mtres, otres);
duke@1 1454 return;
duke@1 1455 }
mcimadamore@795 1456 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1457 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1458 "override.unchecked.ret",
mcimadamore@362 1459 uncheckedOverrides(m, other),
mcimadamore@362 1460 mtres, otres);
duke@1 1461 }
duke@1 1462
duke@1 1463 // Error if overriding method throws an exception not reported
duke@1 1464 // by overridden method.
duke@1 1465 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1466 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1467 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1468 if (unhandledErased.nonEmpty()) {
duke@1 1469 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1470 "override.meth.doesnt.throw",
duke@1 1471 cannotOverride(m, other),
mcimadamore@362 1472 unhandledUnerased.head);
mcimadamore@362 1473 return;
mcimadamore@362 1474 }
mcimadamore@362 1475 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1476 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1477 "override.unchecked.thrown",
mcimadamore@362 1478 cannotOverride(m, other),
mcimadamore@362 1479 unhandledUnerased.head);
duke@1 1480 return;
duke@1 1481 }
duke@1 1482
duke@1 1483 // Optional warning if varargs don't agree
duke@1 1484 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1485 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1486 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1487 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1488 ? "override.varargs.missing"
duke@1 1489 : "override.varargs.extra",
duke@1 1490 varargsOverrides(m, other));
duke@1 1491 }
duke@1 1492
duke@1 1493 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1494 if ((other.flags() & BRIDGE) != 0) {
duke@1 1495 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1496 uncheckedOverrides(m, other));
duke@1 1497 }
duke@1 1498
duke@1 1499 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1500 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1501 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1502 }
duke@1 1503 }
duke@1 1504 // where
duke@1 1505 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1506 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1507 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1508 // because in that case, we will rediscover the issue when examining the method
duke@1 1509 // in the supertype.
duke@1 1510 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1511 // address the issue is when the method is the supertype implemementation: any other
duke@1 1512 // case, we will have dealt with when examining the supertype classes
duke@1 1513 ClassSymbol mc = m.enclClass();
duke@1 1514 Type st = types.supertype(origin.type);
duke@1 1515 if (st.tag != CLASS)
duke@1 1516 return true;
duke@1 1517 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1518
duke@1 1519 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1520 List<Type> intfs = types.interfaces(origin.type);
duke@1 1521 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1522 }
duke@1 1523 else
duke@1 1524 return (stimpl != m);
duke@1 1525 }
duke@1 1526
duke@1 1527
duke@1 1528 // used to check if there were any unchecked conversions
duke@1 1529 Warner overrideWarner = new Warner();
duke@1 1530
duke@1 1531 /** Check that a class does not inherit two concrete methods
duke@1 1532 * with the same signature.
duke@1 1533 * @param pos Position to be used for error reporting.
duke@1 1534 * @param site The class type to be checked.
duke@1 1535 */
duke@1 1536 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1537 Type sup = types.supertype(site);
duke@1 1538 if (sup.tag != CLASS) return;
duke@1 1539
duke@1 1540 for (Type t1 = sup;
duke@1 1541 t1.tsym.type.isParameterized();
duke@1 1542 t1 = types.supertype(t1)) {
duke@1 1543 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1544 e1 != null;
duke@1 1545 e1 = e1.sibling) {
duke@1 1546 Symbol s1 = e1.sym;
duke@1 1547 if (s1.kind != MTH ||
duke@1 1548 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1549 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1550 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1551 types,
duke@1 1552 true) != s1)
duke@1 1553 continue;
duke@1 1554 Type st1 = types.memberType(t1, s1);
duke@1 1555 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1556 if (st1 == s1.type) continue;
duke@1 1557
duke@1 1558 for (Type t2 = sup;
duke@1 1559 t2.tag == CLASS;
duke@1 1560 t2 = types.supertype(t2)) {
mcimadamore@24 1561 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1562 e2.scope != null;
duke@1 1563 e2 = e2.next()) {
duke@1 1564 Symbol s2 = e2.sym;
duke@1 1565 if (s2 == s1 ||
duke@1 1566 s2.kind != MTH ||
duke@1 1567 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1568 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1569 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1570 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1571 types,
duke@1 1572 true) != s2)
duke@1 1573 continue;
duke@1 1574 Type st2 = types.memberType(t2, s2);
duke@1 1575 if (types.overrideEquivalent(st1, st2))
duke@1 1576 log.error(pos, "concrete.inheritance.conflict",
duke@1 1577 s1, t1, s2, t2, sup);
duke@1 1578 }
duke@1 1579 }
duke@1 1580 }
duke@1 1581 }
duke@1 1582 }
duke@1 1583
duke@1 1584 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1585 * method with same name and arguments but incompatible return types.
duke@1 1586 * @param pos Position to be used for error reporting.
duke@1 1587 * @param t1 The first argument type.
duke@1 1588 * @param t2 The second argument type.
duke@1 1589 */
duke@1 1590 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1591 Type t1,
duke@1 1592 Type t2) {
duke@1 1593 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1594 types.makeCompoundType(t1, t2));
duke@1 1595 }
duke@1 1596
duke@1 1597 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1598 Type t1,
duke@1 1599 Type t2,
duke@1 1600 Type site) {
mcimadamore@746 1601 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1602 }
duke@1 1603
duke@1 1604 /** Return the first method which is defined with same args
duke@1 1605 * but different return types in two given interfaces, or null if none
duke@1 1606 * exists.
duke@1 1607 * @param t1 The first type.
duke@1 1608 * @param t2 The second type.
duke@1 1609 * @param site The most derived type.
duke@1 1610 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1611 */
mcimadamore@746 1612 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1613 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1614 closure(t1, interfaces1);
duke@1 1615 Map<TypeSymbol,Type> interfaces2;
duke@1 1616 if (t1 == t2)
duke@1 1617 interfaces2 = interfaces1;
duke@1 1618 else
duke@1 1619 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1620
duke@1 1621 for (Type t3 : interfaces1.values()) {
duke@1 1622 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1623 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1624 if (s != null) return s;
duke@1 1625 }
duke@1 1626 }
duke@1 1627 return null;
duke@1 1628 }
duke@1 1629
duke@1 1630 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1631 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
duke@1 1632 if (t.tag != CLASS) return;
duke@1 1633 if (typeMap.put(t.tsym, t) == null) {
duke@1 1634 closure(types.supertype(t), typeMap);
duke@1 1635 for (Type i : types.interfaces(t))
duke@1 1636 closure(i, typeMap);
duke@1 1637 }
duke@1 1638 }
duke@1 1639
duke@1 1640 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1641 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
duke@1 1642 if (t.tag != CLASS) return;
duke@1 1643 if (typesSkip.get(t.tsym) != null) return;
duke@1 1644 if (typeMap.put(t.tsym, t) == null) {
duke@1 1645 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1646 for (Type i : types.interfaces(t))
duke@1 1647 closure(i, typesSkip, typeMap);
duke@1 1648 }
duke@1 1649 }
duke@1 1650
duke@1 1651 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1652 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1653 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1654 Symbol s1 = e1.sym;
duke@1 1655 Type st1 = null;
duke@1 1656 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
duke@1 1657 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1658 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1659 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1660 Symbol s2 = e2.sym;
duke@1 1661 if (s1 == s2) continue;
duke@1 1662 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
duke@1 1663 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1664 Type st2 = types.memberType(t2, s2);
duke@1 1665 if (types.overrideEquivalent(st1, st2)) {
duke@1 1666 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1667 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1668 Type rt1 = st1.getReturnType();
duke@1 1669 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1670 boolean compat =
duke@1 1671 types.isSameType(rt1, rt2) ||
duke@1 1672 rt1.tag >= CLASS && rt2.tag >= CLASS &&
duke@1 1673 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
mcimadamore@59 1674 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
mcimadamore@59 1675 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1676 if (!compat) {
mcimadamore@746 1677 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1678 t1, t2, s2.name +
mcimadamore@746 1679 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1680 return s2;
mcimadamore@746 1681 }
mcimadamore@889 1682 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1683 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1684 log.error(pos,
mcimadamore@746 1685 "name.clash.same.erasure.no.override",
mcimadamore@746 1686 s1, s1.location(),
mcimadamore@746 1687 s2, s2.location());
mcimadamore@746 1688 return s2;
duke@1 1689 }
duke@1 1690 }
duke@1 1691 }
duke@1 1692 return null;
duke@1 1693 }
mcimadamore@59 1694 //WHERE
mcimadamore@59 1695 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1696 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1697 Type st1 = types.memberType(site, s1);
mcimadamore@59 1698 Type st2 = types.memberType(site, s2);
mcimadamore@59 1699 closure(site, supertypes);
mcimadamore@59 1700 for (Type t : supertypes.values()) {
mcimadamore@59 1701 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1702 Symbol s3 = e.sym;
mcimadamore@59 1703 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1704 Type st3 = types.memberType(site,s3);
mcimadamore@59 1705 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1706 if (s3.owner == site.tsym) {
mcimadamore@59 1707 return true;
mcimadamore@59 1708 }
mcimadamore@59 1709 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1710 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1711 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1712 Type rt1 = st1.getReturnType();
mcimadamore@59 1713 Type rt2 = st2.getReturnType();
mcimadamore@59 1714 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1715 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1716 boolean compat =
mcimadamore@59 1717 rt13.tag >= CLASS && rt23.tag >= CLASS &&
mcimadamore@59 1718 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
mcimadamore@59 1719 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
mcimadamore@59 1720 if (compat)
mcimadamore@59 1721 return true;
mcimadamore@59 1722 }
mcimadamore@59 1723 }
mcimadamore@59 1724 }
mcimadamore@59 1725 return false;
mcimadamore@59 1726 }
duke@1 1727
duke@1 1728 /** Check that a given method conforms with any method it overrides.
duke@1 1729 * @param tree The tree from which positions are extracted
duke@1 1730 * for errors.
duke@1 1731 * @param m The overriding method.
duke@1 1732 */
duke@1 1733 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1734 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1735 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1736 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1737 log.error(tree.pos(), "enum.no.finalize");
duke@1 1738 return;
duke@1 1739 }
mcimadamore@746 1740 for (Type t = origin.type; t.tag == CLASS;
duke@1 1741 t = types.supertype(t)) {
mcimadamore@746 1742 if (t != origin.type) {
mcimadamore@746 1743 checkOverride(tree, t, origin, m);
mcimadamore@746 1744 }
mcimadamore@746 1745 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1746 checkOverride(tree, t2, origin, m);
duke@1 1747 }
duke@1 1748 }
duke@1 1749 }
duke@1 1750
mcimadamore@746 1751 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1752 TypeSymbol c = site.tsym;
mcimadamore@746 1753 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1754 while (e.scope != null) {
mcimadamore@746 1755 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1756 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1757 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1758 }
mcimadamore@746 1759 }
mcimadamore@746 1760 e = e.next();
mcimadamore@746 1761 }
mcimadamore@746 1762 }
mcimadamore@746 1763
mcimadamore@746 1764 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 1765 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 1766 return (cf.accepts(s1) &&
mcimadamore@858 1767 cf.accepts(s2) &&
mcimadamore@858 1768 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 1769 }
mcimadamore@746 1770
mcimadamore@746 1771
duke@1 1772 /** Check that all abstract members of given class have definitions.
duke@1 1773 * @param pos Position to be used for error reporting.
duke@1 1774 * @param c The class.
duke@1 1775 */
duke@1 1776 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1777 try {
duke@1 1778 MethodSymbol undef = firstUndef(c, c);
duke@1 1779 if (undef != null) {
duke@1 1780 if ((c.flags() & ENUM) != 0 &&
duke@1 1781 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 1782 (c.flags() & FINAL) == 0) {
duke@1 1783 // add the ABSTRACT flag to an enum
duke@1 1784 c.flags_field |= ABSTRACT;
duke@1 1785 } else {
duke@1 1786 MethodSymbol undef1 =
duke@1 1787 new MethodSymbol(undef.flags(), undef.name,
duke@1 1788 types.memberType(c.type, undef), undef.owner);
duke@1 1789 log.error(pos, "does.not.override.abstract",
duke@1 1790 c, undef1, undef1.location());
duke@1 1791 }
duke@1 1792 }
duke@1 1793 } catch (CompletionFailure ex) {
duke@1 1794 completionError(pos, ex);
duke@1 1795 }
duke@1 1796 }
duke@1 1797 //where
duke@1 1798 /** Return first abstract member of class `c' that is not defined
duke@1 1799 * in `impl', null if there is none.
duke@1 1800 */
duke@1 1801 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 1802 MethodSymbol undef = null;
duke@1 1803 // Do not bother to search in classes that are not abstract,
duke@1 1804 // since they cannot have abstract members.
duke@1 1805 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 1806 Scope s = c.members();
duke@1 1807 for (Scope.Entry e = s.elems;
duke@1 1808 undef == null && e != null;
duke@1 1809 e = e.sibling) {
duke@1 1810 if (e.sym.kind == MTH &&
duke@1 1811 (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
duke@1 1812 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 1813 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
duke@1 1814 if (implmeth == null || implmeth == absmeth)
duke@1 1815 undef = absmeth;
duke@1 1816 }
duke@1 1817 }
duke@1 1818 if (undef == null) {
duke@1 1819 Type st = types.supertype(c.type);
duke@1 1820 if (st.tag == CLASS)
duke@1 1821 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 1822 }
duke@1 1823 for (List<Type> l = types.interfaces(c.type);
duke@1 1824 undef == null && l.nonEmpty();
duke@1 1825 l = l.tail) {
duke@1 1826 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 1827 }
duke@1 1828 }
duke@1 1829 return undef;
duke@1 1830 }
duke@1 1831
mcimadamore@690 1832 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 1833 CycleChecker cc = new CycleChecker();
mcimadamore@690 1834 cc.scan(tree);
mcimadamore@690 1835 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 1836 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 1837 }
mcimadamore@690 1838 }
mcimadamore@690 1839
mcimadamore@690 1840 class CycleChecker extends TreeScanner {
mcimadamore@690 1841
mcimadamore@690 1842 List<Symbol> seenClasses = List.nil();
mcimadamore@690 1843 boolean errorFound = false;
mcimadamore@690 1844 boolean partialCheck = false;
mcimadamore@690 1845
mcimadamore@690 1846 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 1847 if (sym != null && sym.kind == TYP) {
mcimadamore@690 1848 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 1849 if (classEnv != null) {
mcimadamore@690 1850 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 1851 try {
mcimadamore@690 1852 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 1853 scan(classEnv.tree);
mcimadamore@690 1854 }
mcimadamore@690 1855 finally {
mcimadamore@690 1856 log.useSource(prevSource.getFile());
mcimadamore@690 1857 }
mcimadamore@690 1858 } else if (sym.kind == TYP) {
mcimadamore@690 1859 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 1860 }
mcimadamore@690 1861 } else {
mcimadamore@690 1862 //not completed yet
mcimadamore@690 1863 partialCheck = true;
mcimadamore@690 1864 }
mcimadamore@690 1865 }
mcimadamore@690 1866
mcimadamore@690 1867 @Override
mcimadamore@690 1868 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 1869 super.visitSelect(tree);
mcimadamore@690 1870 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 1871 }
mcimadamore@690 1872
mcimadamore@690 1873 @Override
mcimadamore@690 1874 public void visitIdent(JCIdent tree) {
mcimadamore@690 1875 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 1876 }
mcimadamore@690 1877
mcimadamore@690 1878 @Override
mcimadamore@690 1879 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 1880 scan(tree.clazz);
mcimadamore@690 1881 }
mcimadamore@690 1882
mcimadamore@690 1883 @Override
mcimadamore@690 1884 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 1885 scan(tree.elemtype);
mcimadamore@690 1886 }
mcimadamore@690 1887
mcimadamore@690 1888 @Override
mcimadamore@690 1889 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 1890 List<JCTree> supertypes = List.nil();
mcimadamore@690 1891 if (tree.getExtendsClause() != null) {
mcimadamore@690 1892 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 1893 }
mcimadamore@690 1894 if (tree.getImplementsClause() != null) {
mcimadamore@690 1895 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 1896 supertypes = supertypes.prepend(intf);
mcimadamore@690 1897 }
mcimadamore@690 1898 }
mcimadamore@690 1899 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 1900 }
mcimadamore@690 1901
mcimadamore@690 1902 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 1903 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 1904 return;
mcimadamore@690 1905 if (seenClasses.contains(c)) {
mcimadamore@690 1906 errorFound = true;
mcimadamore@690 1907 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 1908 } else if (!c.type.isErroneous()) {
mcimadamore@690 1909 try {
mcimadamore@690 1910 seenClasses = seenClasses.prepend(c);
mcimadamore@690 1911 if (c.type.tag == CLASS) {
mcimadamore@690 1912 if (supertypes.nonEmpty()) {
mcimadamore@690 1913 scan(supertypes);
mcimadamore@690 1914 }
mcimadamore@690 1915 else {
mcimadamore@690 1916 ClassType ct = (ClassType)c.type;
mcimadamore@690 1917 if (ct.supertype_field == null ||
mcimadamore@690 1918 ct.interfaces_field == null) {
mcimadamore@690 1919 //not completed yet
mcimadamore@690 1920 partialCheck = true;
mcimadamore@690 1921 return;
mcimadamore@690 1922 }
mcimadamore@690 1923 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 1924 for (Type intf : ct.interfaces_field) {
mcimadamore@690 1925 checkSymbol(pos, intf.tsym);
mcimadamore@690 1926 }
mcimadamore@690 1927 }
mcimadamore@690 1928 if (c.owner.kind == TYP) {
mcimadamore@690 1929 checkSymbol(pos, c.owner);
mcimadamore@690 1930 }
mcimadamore@690 1931 }
mcimadamore@690 1932 } finally {
mcimadamore@690 1933 seenClasses = seenClasses.tail;
mcimadamore@690 1934 }
mcimadamore@690 1935 }
mcimadamore@690 1936 }
mcimadamore@690 1937 }
mcimadamore@690 1938
duke@1 1939 /** Check for cyclic references. Issue an error if the
duke@1 1940 * symbol of the type referred to has a LOCKED flag set.
duke@1 1941 *
duke@1 1942 * @param pos Position to be used for error reporting.
duke@1 1943 * @param t The type referred to.
duke@1 1944 */
duke@1 1945 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 1946 checkNonCyclicInternal(pos, t);
duke@1 1947 }
duke@1 1948
duke@1 1949
duke@1 1950 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 1951 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 1952 }
duke@1 1953
mcimadamore@236 1954 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 1955 final TypeVar tv;
mcimadamore@42 1956 if (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 1957 return;
duke@1 1958 if (seen.contains(t)) {
duke@1 1959 tv = (TypeVar)t;
jjg@110 1960 tv.bound = types.createErrorType(t);
duke@1 1961 log.error(pos, "cyclic.inheritance", t);
duke@1 1962 } else if (t.tag == TYPEVAR) {
duke@1 1963 tv = (TypeVar)t;
mcimadamore@236 1964 seen = seen.prepend(tv);
duke@1 1965 for (Type b : types.getBounds(tv))
duke@1 1966 checkNonCyclic1(pos, b, seen);
duke@1 1967 }
duke@1 1968 }
duke@1 1969
duke@1 1970 /** Check for cyclic references. Issue an error if the
duke@1 1971 * symbol of the type referred to has a LOCKED flag set.
duke@1 1972 *
duke@1 1973 * @param pos Position to be used for error reporting.
duke@1 1974 * @param t The type referred to.
duke@1 1975 * @returns True if the check completed on all attributed classes
duke@1 1976 */
duke@1 1977 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 1978 boolean complete = true; // was the check complete?
duke@1 1979 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 1980 Symbol c = t.tsym;
duke@1 1981 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 1982
duke@1 1983 if ((c.flags_field & LOCKED) != 0) {
duke@1 1984 noteCyclic(pos, (ClassSymbol)c);
duke@1 1985 } else if (!c.type.isErroneous()) {
duke@1 1986 try {
duke@1 1987 c.flags_field |= LOCKED;
duke@1 1988 if (c.type.tag == CLASS) {
duke@1 1989 ClassType clazz = (ClassType)c.type;
duke@1 1990 if (clazz.interfaces_field != null)
duke@1 1991 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 1992 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 1993 if (clazz.supertype_field != null) {
duke@1 1994 Type st = clazz.supertype_field;
duke@1 1995 if (st != null && st.tag == CLASS)
duke@1 1996 complete &= checkNonCyclicInternal(pos, st);
duke@1 1997 }
duke@1 1998 if (c.owner.kind == TYP)
duke@1 1999 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2000 }
duke@1 2001 } finally {
duke@1 2002 c.flags_field &= ~LOCKED;
duke@1 2003 }
duke@1 2004 }
duke@1 2005 if (complete)
duke@1 2006 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2007 if (complete) c.flags_field |= ACYCLIC;
duke@1 2008 return complete;
duke@1 2009 }
duke@1 2010
duke@1 2011 /** Note that we found an inheritance cycle. */
duke@1 2012 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2013 log.error(pos, "cyclic.inheritance", c);
duke@1 2014 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2015 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2016 Type st = types.supertype(c.type);
duke@1 2017 if (st.tag == CLASS)
jjg@110 2018 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2019 c.type = types.createErrorType(c, c.type);
duke@1 2020 c.flags_field |= ACYCLIC;
duke@1 2021 }
duke@1 2022
duke@1 2023 /** Check that all methods which implement some
duke@1 2024 * method conform to the method they implement.
duke@1 2025 * @param tree The class definition whose members are checked.
duke@1 2026 */
duke@1 2027 void checkImplementations(JCClassDecl tree) {
duke@1 2028 checkImplementations(tree, tree.sym);
duke@1 2029 }
duke@1 2030 //where
duke@1 2031 /** Check that all methods which implement some
duke@1 2032 * method in `ic' conform to the method they implement.
duke@1 2033 */
duke@1 2034 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
duke@1 2035 ClassSymbol origin = tree.sym;
duke@1 2036 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2037 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2038 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2039 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2040 if (e.sym.kind == MTH &&
duke@1 2041 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2042 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2043 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2044 if (implmeth != null && implmeth != absmeth &&
duke@1 2045 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2046 (origin.flags() & INTERFACE)) {
duke@1 2047 // don't check if implmeth is in a class, yet
duke@1 2048 // origin is an interface. This case arises only
duke@1 2049 // if implmeth is declared in Object. The reason is
duke@1 2050 // that interfaces really don't inherit from
duke@1 2051 // Object it's just that the compiler represents
duke@1 2052 // things that way.
duke@1 2053 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2054 }
duke@1 2055 }
duke@1 2056 }
duke@1 2057 }
duke@1 2058 }
duke@1 2059 }
duke@1 2060
duke@1 2061 /** Check that all abstract methods implemented by a class are
duke@1 2062 * mutually compatible.
duke@1 2063 * @param pos Position to be used for error reporting.
duke@1 2064 * @param c The class whose interfaces are checked.
duke@1 2065 */
duke@1 2066 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2067 List<Type> supertypes = types.interfaces(c);
duke@1 2068 Type supertype = types.supertype(c);
duke@1 2069 if (supertype.tag == CLASS &&
duke@1 2070 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2071 supertypes = supertypes.prepend(supertype);
duke@1 2072 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2073 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2074 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2075 return;
duke@1 2076 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2077 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2078 return;
duke@1 2079 }
duke@1 2080 checkCompatibleConcretes(pos, c);
duke@1 2081 }
duke@1 2082
mcimadamore@359 2083 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2084 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2085 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2086 // VM allows methods and variables with differing types
mcimadamore@359 2087 if (sym.kind == e.sym.kind &&
mcimadamore@359 2088 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2089 sym != e.sym &&
mcimadamore@359 2090 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2091 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2092 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2093 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2094 return;
mcimadamore@359 2095 }
mcimadamore@359 2096 }
mcimadamore@359 2097 }
mcimadamore@359 2098 }
mcimadamore@359 2099
mcimadamore@780 2100 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2101 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2102 *
mcimadamore@780 2103 * @param pos Position to be used for error reporting.
mcimadamore@780 2104 * @param site The class whose methods are checked.
mcimadamore@780 2105 * @param sym The method symbol to be checked.
mcimadamore@780 2106 */
mcimadamore@858 2107 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2108 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2109 //for each method m1 that is a member of 'site'...
mcimadamore@877 2110 for (Symbol s1 : types.membersClosure(site).getElementsByName(sym.name, cf)) {
mcimadamore@858 2111 //...find another method m2 that is overridden (directly or indirectly)
mcimadamore@858 2112 //by method 'sym' in 'site'
mcimadamore@877 2113 for (Symbol s2 : types.membersClosure(site).getElementsByName(sym.name, cf)) {
mcimadamore@877 2114 if (s1 == s2 || !sym.overrides(s2, site.tsym, types, false)) continue;
mcimadamore@858 2115 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2116 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@907 2117 if (!types.isSubSignature(sym.type, types.memberType(site, s1), false) &&
mcimadamore@877 2118 types.hasSameArgs(s1.erasure(types), s2.erasure(types))) {
mcimadamore@858 2119 sym.flags_field |= CLASH;
mcimadamore@877 2120 String key = s2 == sym ?
mcimadamore@858 2121 "name.clash.same.erasure.no.override" :
mcimadamore@858 2122 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2123 log.error(pos,
mcimadamore@858 2124 key,
mcimadamore@858 2125 sym, sym.location(),
mcimadamore@877 2126 s1, s1.location(),
mcimadamore@877 2127 s2, s2.location());
mcimadamore@858 2128 return;
mcimadamore@858 2129 }
mcimadamore@780 2130 }
mcimadamore@780 2131 }
mcimadamore@780 2132 }
mcimadamore@780 2133
mcimadamore@877 2134
mcimadamore@877 2135
mcimadamore@858 2136 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2137 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2138 *
mcimadamore@858 2139 * @param pos Position to be used for error reporting.
mcimadamore@858 2140 * @param site The class whose methods are checked.
mcimadamore@858 2141 * @param sym The method symbol to be checked.
mcimadamore@780 2142 */
mcimadamore@858 2143 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2144 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2145 //for each method m1 that is a member of 'site'...
mcimadamore@877 2146 for (Symbol s : types.membersClosure(site).getElementsByName(sym.name, cf)) {
mcimadamore@858 2147 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2148 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@907 2149 if (!types.isSubSignature(sym.type, types.memberType(site, s), false) &&
mcimadamore@877 2150 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2151 log.error(pos,
mcimadamore@858 2152 "name.clash.same.erasure.no.hide",
mcimadamore@858 2153 sym, sym.location(),
mcimadamore@877 2154 s, s.location());
mcimadamore@858 2155 return;
mcimadamore@858 2156 }
mcimadamore@858 2157 }
mcimadamore@858 2158 }
mcimadamore@780 2159
mcimadamore@858 2160 //where
mcimadamore@858 2161 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2162
mcimadamore@858 2163 Type site;
mcimadamore@780 2164
mcimadamore@858 2165 ClashFilter(Type site) {
mcimadamore@858 2166 this.site = site;
mcimadamore@858 2167 }
mcimadamore@858 2168
mcimadamore@858 2169 boolean shouldSkip(Symbol s) {
mcimadamore@858 2170 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2171 s.owner == site.tsym;
mcimadamore@858 2172 }
mcimadamore@858 2173
mcimadamore@858 2174 public boolean accepts(Symbol s) {
mcimadamore@858 2175 return s.kind == MTH &&
mcimadamore@858 2176 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2177 !shouldSkip(s) &&
mcimadamore@858 2178 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2179 !s.isConstructor();
mcimadamore@858 2180 }
mcimadamore@858 2181 }
mcimadamore@780 2182
mcimadamore@359 2183 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2184 */
mcimadamore@359 2185 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2186 if (!sym.type.isErroneous()) {
mcimadamore@359 2187 if (warnOnSyntheticConflicts) {
mcimadamore@359 2188 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2189 }
mcimadamore@359 2190 else {
mcimadamore@359 2191 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2192 }
mcimadamore@359 2193 }
mcimadamore@359 2194 }
mcimadamore@359 2195
duke@1 2196 /** Check that class c does not implement directly or indirectly
duke@1 2197 * the same parameterized interface with two different argument lists.
duke@1 2198 * @param pos Position to be used for error reporting.
duke@1 2199 * @param type The type whose interfaces are checked.
duke@1 2200 */
duke@1 2201 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2202 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2203 }
duke@1 2204 //where
duke@1 2205 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2206 * with their class symbol as key and their type as value. Make
duke@1 2207 * sure no class is entered with two different types.
duke@1 2208 */
duke@1 2209 void checkClassBounds(DiagnosticPosition pos,
duke@1 2210 Map<TypeSymbol,Type> seensofar,
duke@1 2211 Type type) {
duke@1 2212 if (type.isErroneous()) return;
duke@1 2213 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2214 Type it = l.head;
duke@1 2215 Type oldit = seensofar.put(it.tsym, it);
duke@1 2216 if (oldit != null) {
duke@1 2217 List<Type> oldparams = oldit.allparams();
duke@1 2218 List<Type> newparams = it.allparams();
duke@1 2219 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2220 log.error(pos, "cant.inherit.diff.arg",
duke@1 2221 it.tsym, Type.toString(oldparams),
duke@1 2222 Type.toString(newparams));
duke@1 2223 }
duke@1 2224 checkClassBounds(pos, seensofar, it);
duke@1 2225 }
duke@1 2226 Type st = types.supertype(type);
duke@1 2227 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2228 }
duke@1 2229
duke@1 2230 /** Enter interface into into set.
duke@1 2231 * If it existed already, issue a "repeated interface" error.
duke@1 2232 */
duke@1 2233 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2234 if (its.contains(it))
duke@1 2235 log.error(pos, "repeated.interface");
duke@1 2236 else {
duke@1 2237 its.add(it);
duke@1 2238 }
duke@1 2239 }
duke@1 2240
duke@1 2241 /* *************************************************************************
duke@1 2242 * Check annotations
duke@1 2243 **************************************************************************/
duke@1 2244
mcimadamore@629 2245 /**
mcimadamore@634 2246 * Recursively validate annotations values
mcimadamore@629 2247 */
mcimadamore@634 2248 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2249 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2250 @Override
mcimadamore@629 2251 public void visitAnnotation(JCAnnotation tree) {
mcimadamore@629 2252 super.visitAnnotation(tree);
mcimadamore@629 2253 validateAnnotation(tree);
mcimadamore@629 2254 }
mcimadamore@629 2255 }
mcimadamore@634 2256 tree.accept(new AnnotationValidator());
mcimadamore@629 2257 }
mcimadamore@629 2258
duke@1 2259 /** Annotation types are restricted to primitives, String, an
duke@1 2260 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2261 * Anything>, arrays of the preceding.
duke@1 2262 */
duke@1 2263 void validateAnnotationType(JCTree restype) {
duke@1 2264 // restype may be null if an error occurred, so don't bother validating it
duke@1 2265 if (restype != null) {
duke@1 2266 validateAnnotationType(restype.pos(), restype.type);
duke@1 2267 }
duke@1 2268 }
duke@1 2269
duke@1 2270 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2271 if (type.isPrimitive()) return;
duke@1 2272 if (types.isSameType(type, syms.stringType)) return;
duke@1 2273 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2274 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2275 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2276 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2277 validateAnnotationType(pos, types.elemtype(type));
duke@1 2278 return;
duke@1 2279 }
duke@1 2280 log.error(pos, "invalid.annotation.member.type");
duke@1 2281 }
duke@1 2282
duke@1 2283 /**
duke@1 2284 * "It is also a compile-time error if any method declared in an
duke@1 2285 * annotation type has a signature that is override-equivalent to
duke@1 2286 * that of any public or protected method declared in class Object
duke@1 2287 * or in the interface annotation.Annotation."
duke@1 2288 *
duke@1 2289 * @jls3 9.6 Annotation Types
duke@1 2290 */
duke@1 2291 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
duke@1 2292 for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
duke@1 2293 Scope s = sup.tsym.members();
duke@1 2294 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2295 if (e.sym.kind == MTH &&
duke@1 2296 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2297 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2298 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2299 }
duke@1 2300 }
duke@1 2301 }
duke@1 2302
duke@1 2303 /** Check the annotations of a symbol.
duke@1 2304 */
duke@1 2305 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2306 if (skipAnnotations) return;
duke@1 2307 for (JCAnnotation a : annotations)
duke@1 2308 validateAnnotation(a, s);
duke@1 2309 }
duke@1 2310
duke@1 2311 /** Check an annotation of a symbol.
duke@1 2312 */
duke@1 2313 public void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2314 validateAnnotationTree(a);
duke@1 2315
duke@1 2316 if (!annotationApplicable(a, s))
duke@1 2317 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2318
duke@1 2319 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2320 if (!isOverrider(s))
duke@1 2321 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2322 }
duke@1 2323 }
duke@1 2324
duke@1 2325 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2326 boolean isOverrider(Symbol s) {
duke@1 2327 if (s.kind != MTH || s.isStatic())
duke@1 2328 return false;
duke@1 2329 MethodSymbol m = (MethodSymbol)s;
duke@1 2330 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2331 for (Type sup : types.closure(owner.type)) {
duke@1 2332 if (sup == owner.type)
duke@1 2333 continue; // skip "this"
duke@1 2334 Scope scope = sup.tsym.members();
duke@1 2335 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2336 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2337 return true;
duke@1 2338 }
duke@1 2339 }
duke@1 2340 return false;
duke@1 2341 }
duke@1 2342
duke@1 2343 /** Is the annotation applicable to the symbol? */
duke@1 2344 boolean annotationApplicable(JCAnnotation a, Symbol s) {
duke@1 2345 Attribute.Compound atTarget =
duke@1 2346 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
duke@1 2347 if (atTarget == null) return true;
duke@1 2348 Attribute atValue = atTarget.member(names.value);
duke@1 2349 if (!(atValue instanceof Attribute.Array)) return true; // error recovery
duke@1 2350 Attribute.Array arr = (Attribute.Array) atValue;
duke@1 2351 for (Attribute app : arr.values) {
duke@1 2352 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2353 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2354 if (e.value.name == names.TYPE)
duke@1 2355 { if (s.kind == TYP) return true; }
duke@1 2356 else if (e.value.name == names.FIELD)
duke@1 2357 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2358 else if (e.value.name == names.METHOD)
duke@1 2359 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2360 else if (e.value.name == names.PARAMETER)
duke@1 2361 { if (s.kind == VAR &&
duke@1 2362 s.owner.kind == MTH &&
duke@1 2363 (s.flags() & PARAMETER) != 0)
duke@1 2364 return true;
duke@1 2365 }
duke@1 2366 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2367 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2368 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2369 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2370 (s.flags() & PARAMETER) == 0)
duke@1 2371 return true;
duke@1 2372 }
duke@1 2373 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2374 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2375 return true;
duke@1 2376 }
duke@1 2377 else if (e.value.name == names.PACKAGE)
duke@1 2378 { if (s.kind == PCK) return true; }
jjg@308 2379 else if (e.value.name == names.TYPE_USE)
jjg@308 2380 { if (s.kind == TYP ||
jjg@308 2381 s.kind == VAR ||
jjg@308 2382 (s.kind == MTH && !s.isConstructor() &&
jjg@308 2383 s.type.getReturnType().tag != VOID))
jjg@308 2384 return true;
jjg@308 2385 }
duke@1 2386 else
duke@1 2387 return true; // recovery
duke@1 2388 }
duke@1 2389 return false;
duke@1 2390 }
duke@1 2391
duke@1 2392 /** Check an annotation value.
duke@1 2393 */
duke@1 2394 public void validateAnnotation(JCAnnotation a) {
duke@1 2395 if (a.type.isErroneous()) return;
duke@1 2396
mcimadamore@632 2397 // collect an inventory of the members (sorted alphabetically)
mcimadamore@632 2398 Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
mcimadamore@632 2399 public int compare(Symbol t, Symbol t1) {
mcimadamore@632 2400 return t.name.compareTo(t1.name);
mcimadamore@632 2401 }
mcimadamore@632 2402 });
duke@1 2403 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2404 e != null;
duke@1 2405 e = e.sibling)
duke@1 2406 if (e.sym.kind == MTH)
duke@1 2407 members.add((MethodSymbol) e.sym);
duke@1 2408
duke@1 2409 // count them off as they're annotated
duke@1 2410 for (JCTree arg : a.args) {
duke@1 2411 if (arg.getTag() != JCTree.ASSIGN) continue; // recovery
duke@1 2412 JCAssign assign = (JCAssign) arg;
duke@1 2413 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2414 if (m == null || m.type.isErroneous()) continue;
duke@1 2415 if (!members.remove(m))
jjg@479 2416 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2417 m.name, a.type);
duke@1 2418 }
duke@1 2419
duke@1 2420 // all the remaining ones better have default values
mcimadamore@632 2421 ListBuffer<Name> missingDefaults = ListBuffer.lb();
mcimadamore@632 2422 for (MethodSymbol m : members) {
mcimadamore@632 2423 if (m.defaultValue == null && !m.type.isErroneous()) {
mcimadamore@632 2424 missingDefaults.append(m.name);
mcimadamore@632 2425 }
mcimadamore@632 2426 }
mcimadamore@632 2427 if (missingDefaults.nonEmpty()) {
mcimadamore@632 2428 String key = (missingDefaults.size() > 1)
mcimadamore@632 2429 ? "annotation.missing.default.value.1"
mcimadamore@632 2430 : "annotation.missing.default.value";
mcimadamore@632 2431 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 2432 }
duke@1 2433
duke@1 2434 // special case: java.lang.annotation.Target must not have
duke@1 2435 // repeated values in its value member
duke@1 2436 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2437 a.args.tail == null)
duke@1 2438 return;
duke@1 2439
duke@1 2440 if (a.args.head.getTag() != JCTree.ASSIGN) return; // error recovery
duke@1 2441 JCAssign assign = (JCAssign) a.args.head;
duke@1 2442 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2443 if (m.name != names.value) return;
duke@1 2444 JCTree rhs = assign.rhs;
duke@1 2445 if (rhs.getTag() != JCTree.NEWARRAY) return;
duke@1 2446 JCNewArray na = (JCNewArray) rhs;
duke@1 2447 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2448 for (JCTree elem : na.elems) {
duke@1 2449 if (!targets.add(TreeInfo.symbol(elem))) {
duke@1 2450 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2451 }
duke@1 2452 }
duke@1 2453 }
duke@1 2454
duke@1 2455 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 2456 if (allowAnnotations &&
mcimadamore@795 2457 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 2458 (s.flags() & DEPRECATED) != 0 &&
duke@1 2459 !syms.deprecatedType.isErroneous() &&
duke@1 2460 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 2461 log.warning(LintCategory.DEP_ANN,
jjg@612 2462 pos, "missing.deprecated.annotation");
duke@1 2463 }
duke@1 2464 }
duke@1 2465
mcimadamore@852 2466 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 2467 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 2468 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 2469 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 2470 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2471 @Override
mcimadamore@852 2472 public void report() {
mcimadamore@852 2473 warnDeprecated(pos, s);
mcimadamore@852 2474 }
mcimadamore@852 2475 });
mcimadamore@852 2476 };
mcimadamore@852 2477 }
mcimadamore@852 2478
mcimadamore@852 2479 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 2480 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 2481 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2482 public void report() {
mcimadamore@852 2483 if (enableSunApiLintControl)
mcimadamore@852 2484 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 2485 else
mcimadamore@852 2486 log.strictWarning(pos, "sun.proprietary", s);
mcimadamore@852 2487 }
mcimadamore@852 2488 });
mcimadamore@852 2489 }
mcimadamore@852 2490 }
mcimadamore@852 2491
duke@1 2492 /* *************************************************************************
duke@1 2493 * Check for recursive annotation elements.
duke@1 2494 **************************************************************************/
duke@1 2495
duke@1 2496 /** Check for cycles in the graph of annotation elements.
duke@1 2497 */
duke@1 2498 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 2499 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 2500 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 2501 try {
duke@1 2502 tree.sym.flags_field |= LOCKED;
duke@1 2503 for (JCTree def : tree.defs) {
duke@1 2504 if (def.getTag() != JCTree.METHODDEF) continue;
duke@1 2505 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 2506 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 2507 }
duke@1 2508 } finally {
duke@1 2509 tree.sym.flags_field &= ~LOCKED;
duke@1 2510 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 2511 }
duke@1 2512 }
duke@1 2513
duke@1 2514 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 2515 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 2516 return;
duke@1 2517 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 2518 log.error(pos, "cyclic.annotation.element");
duke@1 2519 return;
duke@1 2520 }
duke@1 2521 try {
duke@1 2522 tsym.flags_field |= LOCKED;
duke@1 2523 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 2524 Symbol s = e.sym;
duke@1 2525 if (s.kind != Kinds.MTH)
duke@1 2526 continue;
duke@1 2527 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 2528 }
duke@1 2529 } finally {
duke@1 2530 tsym.flags_field &= ~LOCKED;
duke@1 2531 tsym.flags_field |= ACYCLIC_ANN;
duke@1 2532 }
duke@1 2533 }
duke@1 2534
duke@1 2535 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
duke@1 2536 switch (type.tag) {
duke@1 2537 case TypeTags.CLASS:
duke@1 2538 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 2539 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 2540 break;
duke@1 2541 case TypeTags.ARRAY:
duke@1 2542 checkAnnotationResType(pos, types.elemtype(type));
duke@1 2543 break;
duke@1 2544 default:
duke@1 2545 break; // int etc
duke@1 2546 }
duke@1 2547 }
duke@1 2548
duke@1 2549 /* *************************************************************************
duke@1 2550 * Check for cycles in the constructor call graph.
duke@1 2551 **************************************************************************/
duke@1 2552
duke@1 2553 /** Check for cycles in the graph of constructors calling other
duke@1 2554 * constructors.
duke@1 2555 */
duke@1 2556 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 2557 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 2558
duke@1 2559 // enter each constructor this-call into the map
duke@1 2560 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 2561 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 2562 if (app == null) continue;
duke@1 2563 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 2564 if (TreeInfo.name(app.meth) == names._this) {
duke@1 2565 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 2566 } else {
duke@1 2567 meth.sym.flags_field |= ACYCLIC;
duke@1 2568 }
duke@1 2569 }
duke@1 2570
duke@1 2571 // Check for cycles in the map
duke@1 2572 Symbol[] ctors = new Symbol[0];
duke@1 2573 ctors = callMap.keySet().toArray(ctors);
duke@1 2574 for (Symbol caller : ctors) {
duke@1 2575 checkCyclicConstructor(tree, caller, callMap);
duke@1 2576 }
duke@1 2577 }
duke@1 2578
duke@1 2579 /** Look in the map to see if the given constructor is part of a
duke@1 2580 * call cycle.
duke@1 2581 */
duke@1 2582 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 2583 Map<Symbol,Symbol> callMap) {
duke@1 2584 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 2585 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 2586 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 2587 "recursive.ctor.invocation");
duke@1 2588 } else {
duke@1 2589 ctor.flags_field |= LOCKED;
duke@1 2590 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 2591 ctor.flags_field &= ~LOCKED;
duke@1 2592 }
duke@1 2593 ctor.flags_field |= ACYCLIC;
duke@1 2594 }
duke@1 2595 }
duke@1 2596
duke@1 2597 /* *************************************************************************
duke@1 2598 * Miscellaneous
duke@1 2599 **************************************************************************/
duke@1 2600
duke@1 2601 /**
duke@1 2602 * Return the opcode of the operator but emit an error if it is an
duke@1 2603 * error.
duke@1 2604 * @param pos position for error reporting.
duke@1 2605 * @param operator an operator
duke@1 2606 * @param tag a tree tag
duke@1 2607 * @param left type of left hand side
duke@1 2608 * @param right type of right hand side
duke@1 2609 */
duke@1 2610 int checkOperator(DiagnosticPosition pos,
duke@1 2611 OperatorSymbol operator,
duke@1 2612 int tag,
duke@1 2613 Type left,
duke@1 2614 Type right) {
duke@1 2615 if (operator.opcode == ByteCodes.error) {
duke@1 2616 log.error(pos,
mcimadamore@853 2617 "operator.cant.be.applied.1",
duke@1 2618 treeinfo.operatorName(tag),
mcimadamore@853 2619 left, right);
duke@1 2620 }
duke@1 2621 return operator.opcode;
duke@1 2622 }
duke@1 2623
duke@1 2624
duke@1 2625 /**
duke@1 2626 * Check for division by integer constant zero
duke@1 2627 * @param pos Position for error reporting.
duke@1 2628 * @param operator The operator for the expression
duke@1 2629 * @param operand The right hand operand for the expression
duke@1 2630 */
duke@1 2631 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 2632 if (operand.constValue() != null
mcimadamore@795 2633 && lint.isEnabled(LintCategory.DIVZERO)
duke@1 2634 && operand.tag <= LONG
duke@1 2635 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 2636 int opc = ((OperatorSymbol)operator).opcode;
duke@1 2637 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 2638 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 2639 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 2640 }
duke@1 2641 }
duke@1 2642 }
duke@1 2643
duke@1 2644 /**
duke@1 2645 * Check for empty statements after if
duke@1 2646 */
duke@1 2647 void checkEmptyIf(JCIf tree) {
mcimadamore@795 2648 if (tree.thenpart.getTag() == JCTree.SKIP && tree.elsepart == null && lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 2649 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 2650 }
duke@1 2651
duke@1 2652 /** Check that symbol is unique in given scope.
duke@1 2653 * @param pos Position for error reporting.
duke@1 2654 * @param sym The symbol.
duke@1 2655 * @param s The scope.
duke@1 2656 */
duke@1 2657 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2658 if (sym.type.isErroneous())
duke@1 2659 return true;
duke@1 2660 if (sym.owner.name == names.any) return false;
duke@1 2661 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 2662 if (sym != e.sym &&
mcimadamore@858 2663 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 2664 sym.kind == e.sym.kind &&
mcimadamore@858 2665 sym.name != names.error &&
mcimadamore@858 2666 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 2667 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 2668 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 2669 return true;
mcimadamore@907 2670 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 2671 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 2672 sym.flags_field |= CLASH;
mcimadamore@844 2673 return true;
mcimadamore@844 2674 } else {
duke@1 2675 duplicateError(pos, e.sym);
mcimadamore@844 2676 return false;
mcimadamore@844 2677 }
duke@1 2678 }
duke@1 2679 }
duke@1 2680 return true;
duke@1 2681 }
mcimadamore@844 2682
mcimadamore@858 2683 /** Report duplicate declaration error.
mcimadamore@858 2684 */
mcimadamore@858 2685 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 2686 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 2687 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 2688 }
mcimadamore@858 2689 }
duke@1 2690
duke@1 2691 /** Check that single-type import is not already imported or top-level defined,
duke@1 2692 * but make an exception for two single-type imports which denote the same type.
duke@1 2693 * @param pos Position for error reporting.
duke@1 2694 * @param sym The symbol.
duke@1 2695 * @param s The scope
duke@1 2696 */
duke@1 2697 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2698 return checkUniqueImport(pos, sym, s, false);
duke@1 2699 }
duke@1 2700
duke@1 2701 /** Check that static single-type import is not already imported or top-level defined,
duke@1 2702 * but make an exception for two single-type imports which denote the same type.
duke@1 2703 * @param pos Position for error reporting.
duke@1 2704 * @param sym The symbol.
duke@1 2705 * @param s The scope
duke@1 2706 * @param staticImport Whether or not this was a static import
duke@1 2707 */
duke@1 2708 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2709 return checkUniqueImport(pos, sym, s, true);
duke@1 2710 }
duke@1 2711
duke@1 2712 /** Check that single-type import is not already imported or top-level defined,
duke@1 2713 * but make an exception for two single-type imports which denote the same type.
duke@1 2714 * @param pos Position for error reporting.
duke@1 2715 * @param sym The symbol.
duke@1 2716 * @param s The scope.
duke@1 2717 * @param staticImport Whether or not this was a static import
duke@1 2718 */
duke@1 2719 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 2720 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 2721 // is encountered class entered via a class declaration?
duke@1 2722 boolean isClassDecl = e.scope == s;
duke@1 2723 if ((isClassDecl || sym != e.sym) &&
duke@1 2724 sym.kind == e.sym.kind &&
duke@1 2725 sym.name != names.error) {
duke@1 2726 if (!e.sym.type.isErroneous()) {
duke@1 2727 String what = e.sym.toString();
duke@1 2728 if (!isClassDecl) {
duke@1 2729 if (staticImport)
duke@1 2730 log.error(pos, "already.defined.static.single.import", what);
duke@1 2731 else
duke@1 2732 log.error(pos, "already.defined.single.import", what);
duke@1 2733 }
duke@1 2734 else if (sym != e.sym)
duke@1 2735 log.error(pos, "already.defined.this.unit", what);
duke@1 2736 }
duke@1 2737 return false;
duke@1 2738 }
duke@1 2739 }
duke@1 2740 return true;
duke@1 2741 }
duke@1 2742
duke@1 2743 /** Check that a qualified name is in canonical form (for import decls).
duke@1 2744 */
duke@1 2745 public void checkCanonical(JCTree tree) {
duke@1 2746 if (!isCanonical(tree))
duke@1 2747 log.error(tree.pos(), "import.requires.canonical",
duke@1 2748 TreeInfo.symbol(tree));
duke@1 2749 }
duke@1 2750 // where
duke@1 2751 private boolean isCanonical(JCTree tree) {
duke@1 2752 while (tree.getTag() == JCTree.SELECT) {
duke@1 2753 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 2754 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 2755 return false;
duke@1 2756 tree = s.selected;
duke@1 2757 }
duke@1 2758 return true;
duke@1 2759 }
duke@1 2760
duke@1 2761 private class ConversionWarner extends Warner {
mcimadamore@795 2762 final String uncheckedKey;
duke@1 2763 final Type found;
duke@1 2764 final Type expected;
mcimadamore@795 2765 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 2766 super(pos);
mcimadamore@795 2767 this.uncheckedKey = uncheckedKey;
duke@1 2768 this.found = found;
duke@1 2769 this.expected = expected;
duke@1 2770 }
duke@1 2771
jjg@398 2772 @Override
mcimadamore@795 2773 public void warn(LintCategory lint) {
duke@1 2774 boolean warned = this.warned;
mcimadamore@795 2775 super.warn(lint);
duke@1 2776 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 2777 switch (lint) {
mcimadamore@795 2778 case UNCHECKED:
mcimadamore@795 2779 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 2780 break;
mcimadamore@795 2781 case VARARGS:
mcimadamore@795 2782 if (method != null &&
mcimadamore@795 2783 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 2784 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 2785 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 2786 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 2787 }
mcimadamore@795 2788 break;
mcimadamore@795 2789 default:
mcimadamore@795 2790 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 2791 }
duke@1 2792 }
duke@1 2793 }
duke@1 2794
duke@1 2795 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2796 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 2797 }
duke@1 2798
duke@1 2799 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2800 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 2801 }
duke@1 2802 }

mercurial