src/share/classes/com/sun/tools/javac/comp/Check.java

Thu, 24 Jul 2008 19:06:57 +0100

author
mcimadamore
date
Thu, 24 Jul 2008 19:06:57 +0100
changeset 80
5c9cdeb740f2
parent 79
36df13bde238
child 89
b6d5f53b3b29
permissions
-rw-r--r--

6717241: some diagnostic argument is prematurely converted into a String object
Summary: removed early toString() conversions applied to diagnostic arguments
Reviewed-by: jjg

duke@1 1 /*
xdono@54 2 * Copyright 1999-2008 Sun Microsystems, Inc. All Rights Reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
duke@1 7 * published by the Free Software Foundation. Sun designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
duke@1 9 * by Sun in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
duke@1 21 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
duke@1 22 * CA 95054 USA or visit www.sun.com if you need additional information or
duke@1 23 * have any questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
duke@1 30
duke@1 31 import com.sun.tools.javac.code.*;
duke@1 32 import com.sun.tools.javac.jvm.*;
duke@1 33 import com.sun.tools.javac.tree.*;
duke@1 34 import com.sun.tools.javac.util.*;
duke@1 35 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 36 import com.sun.tools.javac.util.List;
duke@1 37
duke@1 38 import com.sun.tools.javac.tree.JCTree.*;
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
duke@1 43
duke@1 44 import static com.sun.tools.javac.code.Flags.*;
duke@1 45 import static com.sun.tools.javac.code.Kinds.*;
duke@1 46 import static com.sun.tools.javac.code.TypeTags.*;
duke@1 47
duke@1 48 /** Type checking helper class for the attribution phase.
duke@1 49 *
duke@1 50 * <p><b>This is NOT part of any API supported by Sun Microsystems. If
duke@1 51 * you write code that depends on this, you do so at your own risk.
duke@1 52 * This code and its internal interfaces are subject to change or
duke@1 53 * deletion without notice.</b>
duke@1 54 */
duke@1 55 public class Check {
duke@1 56 protected static final Context.Key<Check> checkKey =
duke@1 57 new Context.Key<Check>();
duke@1 58
duke@1 59 private final Name.Table names;
duke@1 60 private final Log log;
duke@1 61 private final Symtab syms;
duke@1 62 private final Infer infer;
duke@1 63 private final Target target;
duke@1 64 private final Source source;
duke@1 65 private final Types types;
duke@1 66 private final boolean skipAnnotations;
duke@1 67 private final TreeInfo treeinfo;
duke@1 68
duke@1 69 // The set of lint options currently in effect. It is initialized
duke@1 70 // from the context, and then is set/reset as needed by Attr as it
duke@1 71 // visits all the various parts of the trees during attribution.
duke@1 72 private Lint lint;
duke@1 73
duke@1 74 public static Check instance(Context context) {
duke@1 75 Check instance = context.get(checkKey);
duke@1 76 if (instance == null)
duke@1 77 instance = new Check(context);
duke@1 78 return instance;
duke@1 79 }
duke@1 80
duke@1 81 protected Check(Context context) {
duke@1 82 context.put(checkKey, this);
duke@1 83
duke@1 84 names = Name.Table.instance(context);
duke@1 85 log = Log.instance(context);
duke@1 86 syms = Symtab.instance(context);
duke@1 87 infer = Infer.instance(context);
duke@1 88 this.types = Types.instance(context);
duke@1 89 Options options = Options.instance(context);
duke@1 90 target = Target.instance(context);
duke@1 91 source = Source.instance(context);
duke@1 92 lint = Lint.instance(context);
duke@1 93 treeinfo = TreeInfo.instance(context);
duke@1 94
duke@1 95 Source source = Source.instance(context);
duke@1 96 allowGenerics = source.allowGenerics();
duke@1 97 allowAnnotations = source.allowAnnotations();
duke@1 98 complexInference = options.get("-complexinference") != null;
duke@1 99 skipAnnotations = options.get("skipAnnotations") != null;
duke@1 100
duke@1 101 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 102 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@60 103 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 104
jjg@60 105 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@60 106 enforceMandatoryWarnings, "deprecated");
jjg@60 107 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@60 108 enforceMandatoryWarnings, "unchecked");
duke@1 109 }
duke@1 110
duke@1 111 /** Switch: generics enabled?
duke@1 112 */
duke@1 113 boolean allowGenerics;
duke@1 114
duke@1 115 /** Switch: annotations enabled?
duke@1 116 */
duke@1 117 boolean allowAnnotations;
duke@1 118
duke@1 119 /** Switch: -complexinference option set?
duke@1 120 */
duke@1 121 boolean complexInference;
duke@1 122
duke@1 123 /** A table mapping flat names of all compiled classes in this run to their
duke@1 124 * symbols; maintained from outside.
duke@1 125 */
duke@1 126 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 127
duke@1 128 /** A handler for messages about deprecated usage.
duke@1 129 */
duke@1 130 private MandatoryWarningHandler deprecationHandler;
duke@1 131
duke@1 132 /** A handler for messages about unchecked or unsafe usage.
duke@1 133 */
duke@1 134 private MandatoryWarningHandler uncheckedHandler;
duke@1 135
duke@1 136
duke@1 137 /* *************************************************************************
duke@1 138 * Errors and Warnings
duke@1 139 **************************************************************************/
duke@1 140
duke@1 141 Lint setLint(Lint newLint) {
duke@1 142 Lint prev = lint;
duke@1 143 lint = newLint;
duke@1 144 return prev;
duke@1 145 }
duke@1 146
duke@1 147 /** Warn about deprecated symbol.
duke@1 148 * @param pos Position to be used for error reporting.
duke@1 149 * @param sym The deprecated symbol.
duke@1 150 */
duke@1 151 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 152 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 153 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 154 }
duke@1 155
duke@1 156 /** Warn about unchecked operation.
duke@1 157 * @param pos Position to be used for error reporting.
duke@1 158 * @param msg A string describing the problem.
duke@1 159 */
duke@1 160 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 161 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 162 uncheckedHandler.report(pos, msg, args);
duke@1 163 }
duke@1 164
duke@1 165 /**
duke@1 166 * Report any deferred diagnostics.
duke@1 167 */
duke@1 168 public void reportDeferredDiagnostics() {
duke@1 169 deprecationHandler.reportDeferredDiagnostic();
duke@1 170 uncheckedHandler.reportDeferredDiagnostic();
duke@1 171 }
duke@1 172
duke@1 173
duke@1 174 /** Report a failure to complete a class.
duke@1 175 * @param pos Position to be used for error reporting.
duke@1 176 * @param ex The failure to report.
duke@1 177 */
duke@1 178 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 179 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
duke@1 180 if (ex instanceof ClassReader.BadClassFile) throw new Abort();
duke@1 181 else return syms.errType;
duke@1 182 }
duke@1 183
duke@1 184 /** Report a type error.
duke@1 185 * @param pos Position to be used for error reporting.
duke@1 186 * @param problem A string describing the error.
duke@1 187 * @param found The type that was found.
duke@1 188 * @param req The type that was required.
duke@1 189 */
duke@1 190 Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
duke@1 191 log.error(pos, "prob.found.req",
duke@1 192 problem, found, req);
duke@1 193 return syms.errType;
duke@1 194 }
duke@1 195
duke@1 196 Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
duke@1 197 log.error(pos, "prob.found.req.1", problem, found, req, explanation);
duke@1 198 return syms.errType;
duke@1 199 }
duke@1 200
duke@1 201 /** Report an error that wrong type tag was found.
duke@1 202 * @param pos Position to be used for error reporting.
duke@1 203 * @param required An internationalized string describing the type tag
duke@1 204 * required.
duke@1 205 * @param found The type that was found.
duke@1 206 */
duke@1 207 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
duke@1 208 log.error(pos, "type.found.req", found, required);
duke@1 209 return syms.errType;
duke@1 210 }
duke@1 211
duke@1 212 /** Report an error that symbol cannot be referenced before super
duke@1 213 * has been called.
duke@1 214 * @param pos Position to be used for error reporting.
duke@1 215 * @param sym The referenced symbol.
duke@1 216 */
duke@1 217 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 218 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 219 }
duke@1 220
duke@1 221 /** Report duplicate declaration error.
duke@1 222 */
duke@1 223 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 224 if (!sym.type.isErroneous()) {
duke@1 225 log.error(pos, "already.defined", sym, sym.location());
duke@1 226 }
duke@1 227 }
duke@1 228
duke@1 229 /** Report array/varargs duplicate declaration
duke@1 230 */
duke@1 231 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 232 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 233 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 234 }
duke@1 235 }
duke@1 236
duke@1 237 /* ************************************************************************
duke@1 238 * duplicate declaration checking
duke@1 239 *************************************************************************/
duke@1 240
duke@1 241 /** Check that variable does not hide variable with same name in
duke@1 242 * immediately enclosing local scope.
duke@1 243 * @param pos Position for error reporting.
duke@1 244 * @param v The symbol.
duke@1 245 * @param s The scope.
duke@1 246 */
duke@1 247 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 248 if (s.next != null) {
duke@1 249 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 250 e.scope != null && e.sym.owner == v.owner;
duke@1 251 e = e.next()) {
duke@1 252 if (e.sym.kind == VAR &&
duke@1 253 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 254 v.name != names.error) {
duke@1 255 duplicateError(pos, e.sym);
duke@1 256 return;
duke@1 257 }
duke@1 258 }
duke@1 259 }
duke@1 260 }
duke@1 261
duke@1 262 /** Check that a class or interface does not hide a class or
duke@1 263 * interface with same name in immediately enclosing local scope.
duke@1 264 * @param pos Position for error reporting.
duke@1 265 * @param c The symbol.
duke@1 266 * @param s The scope.
duke@1 267 */
duke@1 268 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 269 if (s.next != null) {
duke@1 270 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 271 e.scope != null && e.sym.owner == c.owner;
duke@1 272 e = e.next()) {
duke@1 273 if (e.sym.kind == TYP &&
duke@1 274 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 275 c.name != names.error) {
duke@1 276 duplicateError(pos, e.sym);
duke@1 277 return;
duke@1 278 }
duke@1 279 }
duke@1 280 }
duke@1 281 }
duke@1 282
duke@1 283 /** Check that class does not have the same name as one of
duke@1 284 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 285 * return true if class is unique in its enclosing scope.
duke@1 286 * @param pos Position for error reporting.
duke@1 287 * @param name The class name.
duke@1 288 * @param s The enclosing scope.
duke@1 289 */
duke@1 290 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 291 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 292 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 293 duplicateError(pos, e.sym);
duke@1 294 return false;
duke@1 295 }
duke@1 296 }
duke@1 297 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 298 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 299 duplicateError(pos, sym);
duke@1 300 return true;
duke@1 301 }
duke@1 302 }
duke@1 303 return true;
duke@1 304 }
duke@1 305
duke@1 306 /* *************************************************************************
duke@1 307 * Class name generation
duke@1 308 **************************************************************************/
duke@1 309
duke@1 310 /** Return name of local class.
duke@1 311 * This is of the form <enclClass> $ n <classname>
duke@1 312 * where
duke@1 313 * enclClass is the flat name of the enclosing class,
duke@1 314 * classname is the simple name of the local class
duke@1 315 */
duke@1 316 Name localClassName(ClassSymbol c) {
duke@1 317 for (int i=1; ; i++) {
duke@1 318 Name flatname = names.
duke@1 319 fromString("" + c.owner.enclClass().flatname +
duke@1 320 target.syntheticNameChar() + i +
duke@1 321 c.name);
duke@1 322 if (compiled.get(flatname) == null) return flatname;
duke@1 323 }
duke@1 324 }
duke@1 325
duke@1 326 /* *************************************************************************
duke@1 327 * Type Checking
duke@1 328 **************************************************************************/
duke@1 329
duke@1 330 /** Check that a given type is assignable to a given proto-type.
duke@1 331 * If it is, return the type, otherwise return errType.
duke@1 332 * @param pos Position to be used for error reporting.
duke@1 333 * @param found The type that was found.
duke@1 334 * @param req The type that was required.
duke@1 335 */
duke@1 336 Type checkType(DiagnosticPosition pos, Type found, Type req) {
duke@1 337 if (req.tag == ERROR)
duke@1 338 return req;
duke@1 339 if (found.tag == FORALL)
duke@1 340 return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req));
duke@1 341 if (req.tag == NONE)
duke@1 342 return found;
duke@1 343 if (types.isAssignable(found, req, convertWarner(pos, found, req)))
duke@1 344 return found;
duke@1 345 if (found.tag <= DOUBLE && req.tag <= DOUBLE)
duke@1 346 return typeError(pos, JCDiagnostic.fragment("possible.loss.of.precision"), found, req);
duke@1 347 if (found.isSuperBound()) {
duke@1 348 log.error(pos, "assignment.from.super-bound", found);
duke@1 349 return syms.errType;
duke@1 350 }
duke@1 351 if (req.isExtendsBound()) {
duke@1 352 log.error(pos, "assignment.to.extends-bound", req);
duke@1 353 return syms.errType;
duke@1 354 }
duke@1 355 return typeError(pos, JCDiagnostic.fragment("incompatible.types"), found, req);
duke@1 356 }
duke@1 357
duke@1 358 /** Instantiate polymorphic type to some prototype, unless
duke@1 359 * prototype is `anyPoly' in which case polymorphic type
duke@1 360 * is returned unchanged.
duke@1 361 */
duke@1 362 Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) {
duke@1 363 if (pt == Infer.anyPoly && complexInference) {
duke@1 364 return t;
duke@1 365 } else if (pt == Infer.anyPoly || pt.tag == NONE) {
duke@1 366 Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
duke@1 367 return instantiatePoly(pos, t, newpt, warn);
duke@1 368 } else if (pt.tag == ERROR) {
duke@1 369 return pt;
duke@1 370 } else {
duke@1 371 try {
duke@1 372 return infer.instantiateExpr(t, pt, warn);
duke@1 373 } catch (Infer.NoInstanceException ex) {
duke@1 374 if (ex.isAmbiguous) {
duke@1 375 JCDiagnostic d = ex.getDiagnostic();
duke@1 376 log.error(pos,
duke@1 377 "undetermined.type" + (d!=null ? ".1" : ""),
duke@1 378 t, d);
duke@1 379 return syms.errType;
duke@1 380 } else {
duke@1 381 JCDiagnostic d = ex.getDiagnostic();
duke@1 382 return typeError(pos,
duke@1 383 JCDiagnostic.fragment("incompatible.types" + (d!=null ? ".1" : ""), d),
duke@1 384 t, pt);
duke@1 385 }
duke@1 386 }
duke@1 387 }
duke@1 388 }
duke@1 389
duke@1 390 /** Check that a given type can be cast to a given target type.
duke@1 391 * Return the result of the cast.
duke@1 392 * @param pos Position to be used for error reporting.
duke@1 393 * @param found The type that is being cast.
duke@1 394 * @param req The target type of the cast.
duke@1 395 */
duke@1 396 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
duke@1 397 if (found.tag == FORALL) {
duke@1 398 instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
duke@1 399 return req;
duke@1 400 } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 401 return req;
duke@1 402 } else {
duke@1 403 return typeError(pos,
duke@1 404 JCDiagnostic.fragment("inconvertible.types"),
duke@1 405 found, req);
duke@1 406 }
duke@1 407 }
duke@1 408 //where
duke@1 409 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 410 * type variables?
duke@1 411 */
duke@1 412 boolean isTypeVar(Type t) {
duke@1 413 return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
duke@1 414 }
duke@1 415
duke@1 416 /** Check that a type is within some bounds.
duke@1 417 *
duke@1 418 * Used in TypeApply to verify that, e.g., X in V<X> is a valid
duke@1 419 * type argument.
duke@1 420 * @param pos Position to be used for error reporting.
duke@1 421 * @param a The type that should be bounded by bs.
duke@1 422 * @param bs The bound.
duke@1 423 */
duke@1 424 private void checkExtends(DiagnosticPosition pos, Type a, TypeVar bs) {
mcimadamore@79 425 if (a.tag == TYPEVAR && ((TypeVar)a).isCaptured()) {
mcimadamore@79 426 CapturedType ct = (CapturedType)a;
mcimadamore@79 427 boolean ok;
mcimadamore@79 428 if (ct.bound.isErroneous()) {//capture doesn't exist
mcimadamore@79 429 ok = false;
mcimadamore@79 430 }
mcimadamore@79 431 else {
mcimadamore@79 432 switch (ct.wildcard.kind) {
mcimadamore@79 433 case EXTENDS:
mcimadamore@79 434 ok = types.isCastable(bs.getUpperBound(),
mcimadamore@79 435 types.upperBound(a),
mcimadamore@79 436 Warner.noWarnings);
mcimadamore@79 437 break;
mcimadamore@79 438 case SUPER:
mcimadamore@79 439 ok = !types.notSoftSubtype(types.lowerBound(a),
mcimadamore@79 440 bs.getUpperBound());
mcimadamore@79 441 break;
mcimadamore@79 442 case UNBOUND:
mcimadamore@79 443 ok = true;
mcimadamore@79 444 break;
mcimadamore@79 445 default:
mcimadamore@79 446 throw new AssertionError("Invalid bound kind");
mcimadamore@79 447 }
mcimadamore@79 448 }
mcimadamore@79 449 if (!ok)
mcimadamore@79 450 log.error(pos, "not.within.bounds", a);
mcimadamore@79 451 }
mcimadamore@79 452 else {
duke@1 453 a = types.upperBound(a);
duke@1 454 for (List<Type> l = types.getBounds(bs); l.nonEmpty(); l = l.tail) {
duke@1 455 if (!types.isSubtype(a, l.head)) {
duke@1 456 log.error(pos, "not.within.bounds", a);
duke@1 457 return;
duke@1 458 }
duke@1 459 }
mcimadamore@78 460 }
duke@1 461 }
duke@1 462
duke@1 463 /** Check that type is different from 'void'.
duke@1 464 * @param pos Position to be used for error reporting.
duke@1 465 * @param t The type to be checked.
duke@1 466 */
duke@1 467 Type checkNonVoid(DiagnosticPosition pos, Type t) {
duke@1 468 if (t.tag == VOID) {
duke@1 469 log.error(pos, "void.not.allowed.here");
duke@1 470 return syms.errType;
duke@1 471 } else {
duke@1 472 return t;
duke@1 473 }
duke@1 474 }
duke@1 475
duke@1 476 /** Check that type is a class or interface type.
duke@1 477 * @param pos Position to be used for error reporting.
duke@1 478 * @param t The type to be checked.
duke@1 479 */
duke@1 480 Type checkClassType(DiagnosticPosition pos, Type t) {
duke@1 481 if (t.tag != CLASS && t.tag != ERROR)
duke@1 482 return typeTagError(pos,
duke@1 483 JCDiagnostic.fragment("type.req.class"),
duke@1 484 (t.tag == TYPEVAR)
duke@1 485 ? JCDiagnostic.fragment("type.parameter", t)
duke@1 486 : t);
duke@1 487 else
duke@1 488 return t;
duke@1 489 }
duke@1 490
duke@1 491 /** Check that type is a class or interface type.
duke@1 492 * @param pos Position to be used for error reporting.
duke@1 493 * @param t The type to be checked.
duke@1 494 * @param noBounds True if type bounds are illegal here.
duke@1 495 */
duke@1 496 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 497 t = checkClassType(pos, t);
duke@1 498 if (noBounds && t.isParameterized()) {
duke@1 499 List<Type> args = t.getTypeArguments();
duke@1 500 while (args.nonEmpty()) {
duke@1 501 if (args.head.tag == WILDCARD)
duke@1 502 return typeTagError(pos,
duke@1 503 log.getLocalizedString("type.req.exact"),
duke@1 504 args.head);
duke@1 505 args = args.tail;
duke@1 506 }
duke@1 507 }
duke@1 508 return t;
duke@1 509 }
duke@1 510
duke@1 511 /** Check that type is a reifiable class, interface or array type.
duke@1 512 * @param pos Position to be used for error reporting.
duke@1 513 * @param t The type to be checked.
duke@1 514 */
duke@1 515 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
duke@1 516 if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
duke@1 517 return typeTagError(pos,
duke@1 518 JCDiagnostic.fragment("type.req.class.array"),
duke@1 519 t);
duke@1 520 } else if (!types.isReifiable(t)) {
duke@1 521 log.error(pos, "illegal.generic.type.for.instof");
duke@1 522 return syms.errType;
duke@1 523 } else {
duke@1 524 return t;
duke@1 525 }
duke@1 526 }
duke@1 527
duke@1 528 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 529 * or a type variable.
duke@1 530 * @param pos Position to be used for error reporting.
duke@1 531 * @param t The type to be checked.
duke@1 532 */
duke@1 533 Type checkRefType(DiagnosticPosition pos, Type t) {
duke@1 534 switch (t.tag) {
duke@1 535 case CLASS:
duke@1 536 case ARRAY:
duke@1 537 case TYPEVAR:
duke@1 538 case WILDCARD:
duke@1 539 case ERROR:
duke@1 540 return t;
duke@1 541 default:
duke@1 542 return typeTagError(pos,
duke@1 543 JCDiagnostic.fragment("type.req.ref"),
duke@1 544 t);
duke@1 545 }
duke@1 546 }
duke@1 547
duke@1 548 /** Check that type is a null or reference type.
duke@1 549 * @param pos Position to be used for error reporting.
duke@1 550 * @param t The type to be checked.
duke@1 551 */
duke@1 552 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
duke@1 553 switch (t.tag) {
duke@1 554 case CLASS:
duke@1 555 case ARRAY:
duke@1 556 case TYPEVAR:
duke@1 557 case WILDCARD:
duke@1 558 case BOT:
duke@1 559 case ERROR:
duke@1 560 return t;
duke@1 561 default:
duke@1 562 return typeTagError(pos,
duke@1 563 JCDiagnostic.fragment("type.req.ref"),
duke@1 564 t);
duke@1 565 }
duke@1 566 }
duke@1 567
duke@1 568 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 569 * Return true if it doesn't.
duke@1 570 * @param pos Position to be used for error reporting.
duke@1 571 * @param flags The set of flags to be checked.
duke@1 572 * @param set1 Conflicting flags set #1.
duke@1 573 * @param set2 Conflicting flags set #2.
duke@1 574 */
duke@1 575 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 576 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 577 log.error(pos,
duke@1 578 "illegal.combination.of.modifiers",
mcimadamore@80 579 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 580 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 581 return false;
duke@1 582 } else
duke@1 583 return true;
duke@1 584 }
duke@1 585
duke@1 586 /** Check that given modifiers are legal for given symbol and
duke@1 587 * return modifiers together with any implicit modififiers for that symbol.
duke@1 588 * Warning: we can't use flags() here since this method
duke@1 589 * is called during class enter, when flags() would cause a premature
duke@1 590 * completion.
duke@1 591 * @param pos Position to be used for error reporting.
duke@1 592 * @param flags The set of modifiers given in a definition.
duke@1 593 * @param sym The defined symbol.
duke@1 594 */
duke@1 595 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 596 long mask;
duke@1 597 long implicit = 0;
duke@1 598 switch (sym.kind) {
duke@1 599 case VAR:
duke@1 600 if (sym.owner.kind != TYP)
duke@1 601 mask = LocalVarFlags;
duke@1 602 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 603 mask = implicit = InterfaceVarFlags;
duke@1 604 else
duke@1 605 mask = VarFlags;
duke@1 606 break;
duke@1 607 case MTH:
duke@1 608 if (sym.name == names.init) {
duke@1 609 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 610 // enum constructors cannot be declared public or
duke@1 611 // protected and must be implicitly or explicitly
duke@1 612 // private
duke@1 613 implicit = PRIVATE;
duke@1 614 mask = PRIVATE;
duke@1 615 } else
duke@1 616 mask = ConstructorFlags;
duke@1 617 } else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 618 mask = implicit = InterfaceMethodFlags;
duke@1 619 else {
duke@1 620 mask = MethodFlags;
duke@1 621 }
duke@1 622 // Imply STRICTFP if owner has STRICTFP set.
duke@1 623 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 624 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 625 break;
duke@1 626 case TYP:
duke@1 627 if (sym.isLocal()) {
duke@1 628 mask = LocalClassFlags;
duke@1 629 if (sym.name.len == 0) { // Anonymous class
duke@1 630 // Anonymous classes in static methods are themselves static;
duke@1 631 // that's why we admit STATIC here.
duke@1 632 mask |= STATIC;
duke@1 633 // JLS: Anonymous classes are final.
duke@1 634 implicit |= FINAL;
duke@1 635 }
duke@1 636 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 637 (flags & ENUM) != 0)
duke@1 638 log.error(pos, "enums.must.be.static");
duke@1 639 } else if (sym.owner.kind == TYP) {
duke@1 640 mask = MemberClassFlags;
duke@1 641 if (sym.owner.owner.kind == PCK ||
duke@1 642 (sym.owner.flags_field & STATIC) != 0)
duke@1 643 mask |= STATIC;
duke@1 644 else if ((flags & ENUM) != 0)
duke@1 645 log.error(pos, "enums.must.be.static");
duke@1 646 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 647 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 648 } else {
duke@1 649 mask = ClassFlags;
duke@1 650 }
duke@1 651 // Interfaces are always ABSTRACT
duke@1 652 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 653
duke@1 654 if ((flags & ENUM) != 0) {
duke@1 655 // enums can't be declared abstract or final
duke@1 656 mask &= ~(ABSTRACT | FINAL);
duke@1 657 implicit |= implicitEnumFinalFlag(tree);
duke@1 658 }
duke@1 659 // Imply STRICTFP if owner has STRICTFP set.
duke@1 660 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 661 break;
duke@1 662 default:
duke@1 663 throw new AssertionError();
duke@1 664 }
duke@1 665 long illegal = flags & StandardFlags & ~mask;
duke@1 666 if (illegal != 0) {
duke@1 667 if ((illegal & INTERFACE) != 0) {
duke@1 668 log.error(pos, "intf.not.allowed.here");
duke@1 669 mask |= INTERFACE;
duke@1 670 }
duke@1 671 else {
duke@1 672 log.error(pos,
mcimadamore@80 673 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 674 }
duke@1 675 }
duke@1 676 else if ((sym.kind == TYP ||
duke@1 677 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 678 // in the presence of inner classes. Should it be deleted here?
duke@1 679 checkDisjoint(pos, flags,
duke@1 680 ABSTRACT,
duke@1 681 PRIVATE | STATIC))
duke@1 682 &&
duke@1 683 checkDisjoint(pos, flags,
duke@1 684 ABSTRACT | INTERFACE,
duke@1 685 FINAL | NATIVE | SYNCHRONIZED)
duke@1 686 &&
duke@1 687 checkDisjoint(pos, flags,
duke@1 688 PUBLIC,
duke@1 689 PRIVATE | PROTECTED)
duke@1 690 &&
duke@1 691 checkDisjoint(pos, flags,
duke@1 692 PRIVATE,
duke@1 693 PUBLIC | PROTECTED)
duke@1 694 &&
duke@1 695 checkDisjoint(pos, flags,
duke@1 696 FINAL,
duke@1 697 VOLATILE)
duke@1 698 &&
duke@1 699 (sym.kind == TYP ||
duke@1 700 checkDisjoint(pos, flags,
duke@1 701 ABSTRACT | NATIVE,
duke@1 702 STRICTFP))) {
duke@1 703 // skip
duke@1 704 }
duke@1 705 return flags & (mask | ~StandardFlags) | implicit;
duke@1 706 }
duke@1 707
duke@1 708
duke@1 709 /** Determine if this enum should be implicitly final.
duke@1 710 *
duke@1 711 * If the enum has no specialized enum contants, it is final.
duke@1 712 *
duke@1 713 * If the enum does have specialized enum contants, it is
duke@1 714 * <i>not</i> final.
duke@1 715 */
duke@1 716 private long implicitEnumFinalFlag(JCTree tree) {
duke@1 717 if (tree.getTag() != JCTree.CLASSDEF) return 0;
duke@1 718 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 719 boolean specialized;
duke@1 720 SpecialTreeVisitor() {
duke@1 721 this.specialized = false;
duke@1 722 };
duke@1 723
duke@1 724 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 725
duke@1 726 public void visitVarDef(JCVariableDecl tree) {
duke@1 727 if ((tree.mods.flags & ENUM) != 0) {
duke@1 728 if (tree.init instanceof JCNewClass &&
duke@1 729 ((JCNewClass) tree.init).def != null) {
duke@1 730 specialized = true;
duke@1 731 }
duke@1 732 }
duke@1 733 }
duke@1 734 }
duke@1 735
duke@1 736 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 737 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 738 for (JCTree defs: cdef.defs) {
duke@1 739 defs.accept(sts);
duke@1 740 if (sts.specialized) return 0;
duke@1 741 }
duke@1 742 return FINAL;
duke@1 743 }
duke@1 744
duke@1 745 /* *************************************************************************
duke@1 746 * Type Validation
duke@1 747 **************************************************************************/
duke@1 748
duke@1 749 /** Validate a type expression. That is,
duke@1 750 * check that all type arguments of a parametric type are within
duke@1 751 * their bounds. This must be done in a second phase after type attributon
duke@1 752 * since a class might have a subclass as type parameter bound. E.g:
duke@1 753 *
duke@1 754 * class B<A extends C> { ... }
duke@1 755 * class C extends B<C> { ... }
duke@1 756 *
duke@1 757 * and we can't make sure that the bound is already attributed because
duke@1 758 * of possible cycles.
duke@1 759 */
duke@1 760 private Validator validator = new Validator();
duke@1 761
duke@1 762 /** Visitor method: Validate a type expression, if it is not null, catching
duke@1 763 * and reporting any completion failures.
duke@1 764 */
duke@1 765 void validate(JCTree tree) {
duke@1 766 try {
duke@1 767 if (tree != null) tree.accept(validator);
duke@1 768 } catch (CompletionFailure ex) {
duke@1 769 completionError(tree.pos(), ex);
duke@1 770 }
duke@1 771 }
duke@1 772
duke@1 773 /** Visitor method: Validate a list of type expressions.
duke@1 774 */
duke@1 775 void validate(List<? extends JCTree> trees) {
duke@1 776 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
duke@1 777 validate(l.head);
duke@1 778 }
duke@1 779
duke@1 780 /** Visitor method: Validate a list of type parameters.
duke@1 781 */
duke@1 782 void validateTypeParams(List<JCTypeParameter> trees) {
duke@1 783 for (List<JCTypeParameter> l = trees; l.nonEmpty(); l = l.tail)
duke@1 784 validate(l.head);
duke@1 785 }
duke@1 786
duke@1 787 /** A visitor class for type validation.
duke@1 788 */
duke@1 789 class Validator extends JCTree.Visitor {
duke@1 790
duke@1 791 public void visitTypeArray(JCArrayTypeTree tree) {
duke@1 792 validate(tree.elemtype);
duke@1 793 }
duke@1 794
duke@1 795 public void visitTypeApply(JCTypeApply tree) {
duke@1 796 if (tree.type.tag == CLASS) {
duke@1 797 List<Type> formals = tree.type.tsym.type.getTypeArguments();
mcimadamore@78 798 List<Type> actuals = types.capture(tree.type).getTypeArguments();
duke@1 799 List<JCExpression> args = tree.arguments;
duke@1 800 List<Type> forms = formals;
duke@1 801 ListBuffer<TypeVar> tvars_buf = new ListBuffer<TypeVar>();
duke@1 802
duke@1 803 // For matching pairs of actual argument types `a' and
duke@1 804 // formal type parameters with declared bound `b' ...
duke@1 805 while (args.nonEmpty() && forms.nonEmpty()) {
duke@1 806 validate(args.head);
duke@1 807
duke@1 808 // exact type arguments needs to know their
duke@1 809 // bounds (for upper and lower bound
duke@1 810 // calculations). So we create new TypeVars with
duke@1 811 // bounds substed with actuals.
duke@1 812 tvars_buf.append(types.substBound(((TypeVar)forms.head),
duke@1 813 formals,
mcimadamore@78 814 actuals));
duke@1 815
duke@1 816 args = args.tail;
duke@1 817 forms = forms.tail;
duke@1 818 }
duke@1 819
duke@1 820 args = tree.arguments;
duke@1 821 List<TypeVar> tvars = tvars_buf.toList();
duke@1 822 while (args.nonEmpty() && tvars.nonEmpty()) {
duke@1 823 // Let the actual arguments know their bound
duke@1 824 args.head.type.withTypeVar(tvars.head);
duke@1 825 args = args.tail;
duke@1 826 tvars = tvars.tail;
duke@1 827 }
duke@1 828
duke@1 829 args = tree.arguments;
duke@1 830 tvars = tvars_buf.toList();
duke@1 831 while (args.nonEmpty() && tvars.nonEmpty()) {
duke@1 832 checkExtends(args.head.pos(),
mcimadamore@78 833 actuals.head,
duke@1 834 tvars.head);
duke@1 835 args = args.tail;
duke@1 836 tvars = tvars.tail;
mcimadamore@78 837 actuals = actuals.tail;
duke@1 838 }
duke@1 839
duke@1 840 // Check that this type is either fully parameterized, or
duke@1 841 // not parameterized at all.
duke@1 842 if (tree.type.getEnclosingType().isRaw())
duke@1 843 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
duke@1 844 if (tree.clazz.getTag() == JCTree.SELECT)
duke@1 845 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 846 }
duke@1 847 }
duke@1 848
duke@1 849 public void visitTypeParameter(JCTypeParameter tree) {
duke@1 850 validate(tree.bounds);
duke@1 851 checkClassBounds(tree.pos(), tree.type);
duke@1 852 }
duke@1 853
duke@1 854 @Override
duke@1 855 public void visitWildcard(JCWildcard tree) {
duke@1 856 if (tree.inner != null)
duke@1 857 validate(tree.inner);
duke@1 858 }
duke@1 859
duke@1 860 public void visitSelect(JCFieldAccess tree) {
duke@1 861 if (tree.type.tag == CLASS) {
duke@1 862 visitSelectInternal(tree);
duke@1 863
duke@1 864 // Check that this type is either fully parameterized, or
duke@1 865 // not parameterized at all.
duke@1 866 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 867 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 868 }
duke@1 869 }
duke@1 870 public void visitSelectInternal(JCFieldAccess tree) {
duke@1 871 if (tree.type.getEnclosingType().tag != CLASS &&
duke@1 872 tree.selected.type.isParameterized()) {
duke@1 873 // The enclosing type is not a class, so we are
duke@1 874 // looking at a static member type. However, the
duke@1 875 // qualifying expression is parameterized.
duke@1 876 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 877 } else {
duke@1 878 // otherwise validate the rest of the expression
duke@1 879 validate(tree.selected);
duke@1 880 }
duke@1 881 }
duke@1 882
duke@1 883 /** Default visitor method: do nothing.
duke@1 884 */
duke@1 885 public void visitTree(JCTree tree) {
duke@1 886 }
duke@1 887 }
duke@1 888
duke@1 889 /* *************************************************************************
duke@1 890 * Exception checking
duke@1 891 **************************************************************************/
duke@1 892
duke@1 893 /* The following methods treat classes as sets that contain
duke@1 894 * the class itself and all their subclasses
duke@1 895 */
duke@1 896
duke@1 897 /** Is given type a subtype of some of the types in given list?
duke@1 898 */
duke@1 899 boolean subset(Type t, List<Type> ts) {
duke@1 900 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 901 if (types.isSubtype(t, l.head)) return true;
duke@1 902 return false;
duke@1 903 }
duke@1 904
duke@1 905 /** Is given type a subtype or supertype of
duke@1 906 * some of the types in given list?
duke@1 907 */
duke@1 908 boolean intersects(Type t, List<Type> ts) {
duke@1 909 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 910 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 911 return false;
duke@1 912 }
duke@1 913
duke@1 914 /** Add type set to given type list, unless it is a subclass of some class
duke@1 915 * in the list.
duke@1 916 */
duke@1 917 List<Type> incl(Type t, List<Type> ts) {
duke@1 918 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 919 }
duke@1 920
duke@1 921 /** Remove type set from type set list.
duke@1 922 */
duke@1 923 List<Type> excl(Type t, List<Type> ts) {
duke@1 924 if (ts.isEmpty()) {
duke@1 925 return ts;
duke@1 926 } else {
duke@1 927 List<Type> ts1 = excl(t, ts.tail);
duke@1 928 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 929 else if (ts1 == ts.tail) return ts;
duke@1 930 else return ts1.prepend(ts.head);
duke@1 931 }
duke@1 932 }
duke@1 933
duke@1 934 /** Form the union of two type set lists.
duke@1 935 */
duke@1 936 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 937 List<Type> ts = ts1;
duke@1 938 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 939 ts = incl(l.head, ts);
duke@1 940 return ts;
duke@1 941 }
duke@1 942
duke@1 943 /** Form the difference of two type lists.
duke@1 944 */
duke@1 945 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 946 List<Type> ts = ts1;
duke@1 947 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 948 ts = excl(l.head, ts);
duke@1 949 return ts;
duke@1 950 }
duke@1 951
duke@1 952 /** Form the intersection of two type lists.
duke@1 953 */
duke@1 954 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 955 List<Type> ts = List.nil();
duke@1 956 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 957 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 958 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 959 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 960 return ts;
duke@1 961 }
duke@1 962
duke@1 963 /** Is exc an exception symbol that need not be declared?
duke@1 964 */
duke@1 965 boolean isUnchecked(ClassSymbol exc) {
duke@1 966 return
duke@1 967 exc.kind == ERR ||
duke@1 968 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 969 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 970 }
duke@1 971
duke@1 972 /** Is exc an exception type that need not be declared?
duke@1 973 */
duke@1 974 boolean isUnchecked(Type exc) {
duke@1 975 return
duke@1 976 (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
duke@1 977 (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
duke@1 978 exc.tag == BOT;
duke@1 979 }
duke@1 980
duke@1 981 /** Same, but handling completion failures.
duke@1 982 */
duke@1 983 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 984 try {
duke@1 985 return isUnchecked(exc);
duke@1 986 } catch (CompletionFailure ex) {
duke@1 987 completionError(pos, ex);
duke@1 988 return true;
duke@1 989 }
duke@1 990 }
duke@1 991
duke@1 992 /** Is exc handled by given exception list?
duke@1 993 */
duke@1 994 boolean isHandled(Type exc, List<Type> handled) {
duke@1 995 return isUnchecked(exc) || subset(exc, handled);
duke@1 996 }
duke@1 997
duke@1 998 /** Return all exceptions in thrown list that are not in handled list.
duke@1 999 * @param thrown The list of thrown exceptions.
duke@1 1000 * @param handled The list of handled exceptions.
duke@1 1001 */
duke@1 1002 List<Type> unHandled(List<Type> thrown, List<Type> handled) {
duke@1 1003 List<Type> unhandled = List.nil();
duke@1 1004 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1005 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1006 return unhandled;
duke@1 1007 }
duke@1 1008
duke@1 1009 /* *************************************************************************
duke@1 1010 * Overriding/Implementation checking
duke@1 1011 **************************************************************************/
duke@1 1012
duke@1 1013 /** The level of access protection given by a flag set,
duke@1 1014 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1015 */
duke@1 1016 static int protection(long flags) {
duke@1 1017 switch ((short)(flags & AccessFlags)) {
duke@1 1018 case PRIVATE: return 3;
duke@1 1019 case PROTECTED: return 1;
duke@1 1020 default:
duke@1 1021 case PUBLIC: return 0;
duke@1 1022 case 0: return 2;
duke@1 1023 }
duke@1 1024 }
duke@1 1025
duke@1 1026 /** A customized "cannot override" error message.
duke@1 1027 * @param m The overriding method.
duke@1 1028 * @param other The overridden method.
duke@1 1029 * @return An internationalized string.
duke@1 1030 */
duke@1 1031 static Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1032 String key;
duke@1 1033 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1034 key = "cant.override";
duke@1 1035 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1036 key = "cant.implement";
duke@1 1037 else
duke@1 1038 key = "clashes.with";
duke@1 1039 return JCDiagnostic.fragment(key, m, m.location(), other, other.location());
duke@1 1040 }
duke@1 1041
duke@1 1042 /** A customized "override" warning message.
duke@1 1043 * @param m The overriding method.
duke@1 1044 * @param other The overridden method.
duke@1 1045 * @return An internationalized string.
duke@1 1046 */
duke@1 1047 static Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1048 String key;
duke@1 1049 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1050 key = "unchecked.override";
duke@1 1051 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1052 key = "unchecked.implement";
duke@1 1053 else
duke@1 1054 key = "unchecked.clash.with";
duke@1 1055 return JCDiagnostic.fragment(key, m, m.location(), other, other.location());
duke@1 1056 }
duke@1 1057
duke@1 1058 /** A customized "override" warning message.
duke@1 1059 * @param m The overriding method.
duke@1 1060 * @param other The overridden method.
duke@1 1061 * @return An internationalized string.
duke@1 1062 */
duke@1 1063 static Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1064 String key;
duke@1 1065 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1066 key = "varargs.override";
duke@1 1067 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1068 key = "varargs.implement";
duke@1 1069 else
duke@1 1070 key = "varargs.clash.with";
duke@1 1071 return JCDiagnostic.fragment(key, m, m.location(), other, other.location());
duke@1 1072 }
duke@1 1073
duke@1 1074 /** Check that this method conforms with overridden method 'other'.
duke@1 1075 * where `origin' is the class where checking started.
duke@1 1076 * Complications:
duke@1 1077 * (1) Do not check overriding of synthetic methods
duke@1 1078 * (reason: they might be final).
duke@1 1079 * todo: check whether this is still necessary.
duke@1 1080 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1081 * than the method it implements. Augment the proxy methods with the
duke@1 1082 * undeclared exceptions in this case.
duke@1 1083 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1084 * has a result type
duke@1 1085 * extended by the result type of the method it implements.
duke@1 1086 * Change the proxies result type to the smaller type in this case.
duke@1 1087 *
duke@1 1088 * @param tree The tree from which positions
duke@1 1089 * are extracted for errors.
duke@1 1090 * @param m The overriding method.
duke@1 1091 * @param other The overridden method.
duke@1 1092 * @param origin The class of which the overriding method
duke@1 1093 * is a member.
duke@1 1094 */
duke@1 1095 void checkOverride(JCTree tree,
duke@1 1096 MethodSymbol m,
duke@1 1097 MethodSymbol other,
duke@1 1098 ClassSymbol origin) {
duke@1 1099 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1100 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1101 return;
duke@1 1102 }
duke@1 1103
duke@1 1104 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1105 if ((m.flags() & STATIC) != 0 &&
duke@1 1106 (other.flags() & STATIC) == 0) {
duke@1 1107 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1108 cannotOverride(m, other));
duke@1 1109 return;
duke@1 1110 }
duke@1 1111
duke@1 1112 // Error if instance method overrides static or final
duke@1 1113 // method (JLS 8.4.6.1).
duke@1 1114 if ((other.flags() & FINAL) != 0 ||
duke@1 1115 (m.flags() & STATIC) == 0 &&
duke@1 1116 (other.flags() & STATIC) != 0) {
duke@1 1117 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1118 cannotOverride(m, other),
mcimadamore@80 1119 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1120 return;
duke@1 1121 }
duke@1 1122
duke@1 1123 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1124 // handled in validateAnnotationMethod
duke@1 1125 return;
duke@1 1126 }
duke@1 1127
duke@1 1128 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1129 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1130 protection(m.flags()) > protection(other.flags())) {
duke@1 1131 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1132 cannotOverride(m, other),
mcimadamore@80 1133 other.flags() == 0 ?
mcimadamore@80 1134 Flag.PACKAGE :
mcimadamore@80 1135 asFlagSet(other.flags() & AccessFlags));
duke@1 1136 return;
duke@1 1137 }
duke@1 1138
duke@1 1139 Type mt = types.memberType(origin.type, m);
duke@1 1140 Type ot = types.memberType(origin.type, other);
duke@1 1141 // Error if overriding result type is different
duke@1 1142 // (or, in the case of generics mode, not a subtype) of
duke@1 1143 // overridden result type. We have to rename any type parameters
duke@1 1144 // before comparing types.
duke@1 1145 List<Type> mtvars = mt.getTypeArguments();
duke@1 1146 List<Type> otvars = ot.getTypeArguments();
duke@1 1147 Type mtres = mt.getReturnType();
duke@1 1148 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1149
duke@1 1150 overrideWarner.warned = false;
duke@1 1151 boolean resultTypesOK =
duke@1 1152 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1153 if (!resultTypesOK) {
duke@1 1154 if (!source.allowCovariantReturns() &&
duke@1 1155 m.owner != origin &&
duke@1 1156 m.owner.isSubClass(other.owner, types)) {
duke@1 1157 // allow limited interoperability with covariant returns
duke@1 1158 } else {
duke@1 1159 typeError(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1160 JCDiagnostic.fragment("override.incompatible.ret",
duke@1 1161 cannotOverride(m, other)),
duke@1 1162 mtres, otres);
duke@1 1163 return;
duke@1 1164 }
duke@1 1165 } else if (overrideWarner.warned) {
duke@1 1166 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1167 "prob.found.req",
duke@1 1168 JCDiagnostic.fragment("override.unchecked.ret",
duke@1 1169 uncheckedOverrides(m, other)),
duke@1 1170 mtres, otres);
duke@1 1171 }
duke@1 1172
duke@1 1173 // Error if overriding method throws an exception not reported
duke@1 1174 // by overridden method.
duke@1 1175 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
duke@1 1176 List<Type> unhandled = unHandled(mt.getThrownTypes(), otthrown);
duke@1 1177 if (unhandled.nonEmpty()) {
duke@1 1178 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1179 "override.meth.doesnt.throw",
duke@1 1180 cannotOverride(m, other),
duke@1 1181 unhandled.head);
duke@1 1182 return;
duke@1 1183 }
duke@1 1184
duke@1 1185 // Optional warning if varargs don't agree
duke@1 1186 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
duke@1 1187 && lint.isEnabled(Lint.LintCategory.OVERRIDES)) {
duke@1 1188 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1189 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1190 ? "override.varargs.missing"
duke@1 1191 : "override.varargs.extra",
duke@1 1192 varargsOverrides(m, other));
duke@1 1193 }
duke@1 1194
duke@1 1195 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1196 if ((other.flags() & BRIDGE) != 0) {
duke@1 1197 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1198 uncheckedOverrides(m, other));
duke@1 1199 }
duke@1 1200
duke@1 1201 // Warn if a deprecated method overridden by a non-deprecated one.
duke@1 1202 if ((other.flags() & DEPRECATED) != 0
duke@1 1203 && (m.flags() & DEPRECATED) == 0
duke@1 1204 && m.outermostClass() != other.outermostClass()
duke@1 1205 && !isDeprecatedOverrideIgnorable(other, origin)) {
duke@1 1206 warnDeprecated(TreeInfo.diagnosticPositionFor(m, tree), other);
duke@1 1207 }
duke@1 1208 }
duke@1 1209 // where
duke@1 1210 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1211 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1212 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1213 // because in that case, we will rediscover the issue when examining the method
duke@1 1214 // in the supertype.
duke@1 1215 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1216 // address the issue is when the method is the supertype implemementation: any other
duke@1 1217 // case, we will have dealt with when examining the supertype classes
duke@1 1218 ClassSymbol mc = m.enclClass();
duke@1 1219 Type st = types.supertype(origin.type);
duke@1 1220 if (st.tag != CLASS)
duke@1 1221 return true;
duke@1 1222 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1223
duke@1 1224 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1225 List<Type> intfs = types.interfaces(origin.type);
duke@1 1226 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1227 }
duke@1 1228 else
duke@1 1229 return (stimpl != m);
duke@1 1230 }
duke@1 1231
duke@1 1232
duke@1 1233 // used to check if there were any unchecked conversions
duke@1 1234 Warner overrideWarner = new Warner();
duke@1 1235
duke@1 1236 /** Check that a class does not inherit two concrete methods
duke@1 1237 * with the same signature.
duke@1 1238 * @param pos Position to be used for error reporting.
duke@1 1239 * @param site The class type to be checked.
duke@1 1240 */
duke@1 1241 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1242 Type sup = types.supertype(site);
duke@1 1243 if (sup.tag != CLASS) return;
duke@1 1244
duke@1 1245 for (Type t1 = sup;
duke@1 1246 t1.tsym.type.isParameterized();
duke@1 1247 t1 = types.supertype(t1)) {
duke@1 1248 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1249 e1 != null;
duke@1 1250 e1 = e1.sibling) {
duke@1 1251 Symbol s1 = e1.sym;
duke@1 1252 if (s1.kind != MTH ||
duke@1 1253 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1254 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1255 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1256 types,
duke@1 1257 true) != s1)
duke@1 1258 continue;
duke@1 1259 Type st1 = types.memberType(t1, s1);
duke@1 1260 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1261 if (st1 == s1.type) continue;
duke@1 1262
duke@1 1263 for (Type t2 = sup;
duke@1 1264 t2.tag == CLASS;
duke@1 1265 t2 = types.supertype(t2)) {
mcimadamore@24 1266 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1267 e2.scope != null;
duke@1 1268 e2 = e2.next()) {
duke@1 1269 Symbol s2 = e2.sym;
duke@1 1270 if (s2 == s1 ||
duke@1 1271 s2.kind != MTH ||
duke@1 1272 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1273 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1274 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1275 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1276 types,
duke@1 1277 true) != s2)
duke@1 1278 continue;
duke@1 1279 Type st2 = types.memberType(t2, s2);
duke@1 1280 if (types.overrideEquivalent(st1, st2))
duke@1 1281 log.error(pos, "concrete.inheritance.conflict",
duke@1 1282 s1, t1, s2, t2, sup);
duke@1 1283 }
duke@1 1284 }
duke@1 1285 }
duke@1 1286 }
duke@1 1287 }
duke@1 1288
duke@1 1289 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1290 * method with same name and arguments but incompatible return types.
duke@1 1291 * @param pos Position to be used for error reporting.
duke@1 1292 * @param t1 The first argument type.
duke@1 1293 * @param t2 The second argument type.
duke@1 1294 */
duke@1 1295 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1296 Type t1,
duke@1 1297 Type t2) {
duke@1 1298 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1299 types.makeCompoundType(t1, t2));
duke@1 1300 }
duke@1 1301
duke@1 1302 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1303 Type t1,
duke@1 1304 Type t2,
duke@1 1305 Type site) {
duke@1 1306 Symbol sym = firstIncompatibility(t1, t2, site);
duke@1 1307 if (sym != null) {
duke@1 1308 log.error(pos, "types.incompatible.diff.ret",
duke@1 1309 t1, t2, sym.name +
duke@1 1310 "(" + types.memberType(t2, sym).getParameterTypes() + ")");
duke@1 1311 return false;
duke@1 1312 }
duke@1 1313 return true;
duke@1 1314 }
duke@1 1315
duke@1 1316 /** Return the first method which is defined with same args
duke@1 1317 * but different return types in two given interfaces, or null if none
duke@1 1318 * exists.
duke@1 1319 * @param t1 The first type.
duke@1 1320 * @param t2 The second type.
duke@1 1321 * @param site The most derived type.
duke@1 1322 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1323 */
duke@1 1324 private Symbol firstIncompatibility(Type t1, Type t2, Type site) {
duke@1 1325 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1326 closure(t1, interfaces1);
duke@1 1327 Map<TypeSymbol,Type> interfaces2;
duke@1 1328 if (t1 == t2)
duke@1 1329 interfaces2 = interfaces1;
duke@1 1330 else
duke@1 1331 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1332
duke@1 1333 for (Type t3 : interfaces1.values()) {
duke@1 1334 for (Type t4 : interfaces2.values()) {
duke@1 1335 Symbol s = firstDirectIncompatibility(t3, t4, site);
duke@1 1336 if (s != null) return s;
duke@1 1337 }
duke@1 1338 }
duke@1 1339 return null;
duke@1 1340 }
duke@1 1341
duke@1 1342 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1343 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
duke@1 1344 if (t.tag != CLASS) return;
duke@1 1345 if (typeMap.put(t.tsym, t) == null) {
duke@1 1346 closure(types.supertype(t), typeMap);
duke@1 1347 for (Type i : types.interfaces(t))
duke@1 1348 closure(i, typeMap);
duke@1 1349 }
duke@1 1350 }
duke@1 1351
duke@1 1352 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1353 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
duke@1 1354 if (t.tag != CLASS) return;
duke@1 1355 if (typesSkip.get(t.tsym) != null) return;
duke@1 1356 if (typeMap.put(t.tsym, t) == null) {
duke@1 1357 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1358 for (Type i : types.interfaces(t))
duke@1 1359 closure(i, typesSkip, typeMap);
duke@1 1360 }
duke@1 1361 }
duke@1 1362
duke@1 1363 /** Return the first method in t2 that conflicts with a method from t1. */
duke@1 1364 private Symbol firstDirectIncompatibility(Type t1, Type t2, Type site) {
duke@1 1365 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1366 Symbol s1 = e1.sym;
duke@1 1367 Type st1 = null;
duke@1 1368 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
duke@1 1369 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1370 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1371 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1372 Symbol s2 = e2.sym;
duke@1 1373 if (s1 == s2) continue;
duke@1 1374 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
duke@1 1375 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1376 Type st2 = types.memberType(t2, s2);
duke@1 1377 if (types.overrideEquivalent(st1, st2)) {
duke@1 1378 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1379 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1380 Type rt1 = st1.getReturnType();
duke@1 1381 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1382 boolean compat =
duke@1 1383 types.isSameType(rt1, rt2) ||
duke@1 1384 rt1.tag >= CLASS && rt2.tag >= CLASS &&
duke@1 1385 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
mcimadamore@59 1386 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
mcimadamore@59 1387 checkCommonOverriderIn(s1,s2,site);
duke@1 1388 if (!compat) return s2;
duke@1 1389 }
duke@1 1390 }
duke@1 1391 }
duke@1 1392 return null;
duke@1 1393 }
mcimadamore@59 1394 //WHERE
mcimadamore@59 1395 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1396 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1397 Type st1 = types.memberType(site, s1);
mcimadamore@59 1398 Type st2 = types.memberType(site, s2);
mcimadamore@59 1399 closure(site, supertypes);
mcimadamore@59 1400 for (Type t : supertypes.values()) {
mcimadamore@59 1401 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1402 Symbol s3 = e.sym;
mcimadamore@59 1403 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1404 Type st3 = types.memberType(site,s3);
mcimadamore@59 1405 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1406 if (s3.owner == site.tsym) {
mcimadamore@59 1407 return true;
mcimadamore@59 1408 }
mcimadamore@59 1409 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1410 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1411 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1412 Type rt1 = st1.getReturnType();
mcimadamore@59 1413 Type rt2 = st2.getReturnType();
mcimadamore@59 1414 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1415 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1416 boolean compat =
mcimadamore@59 1417 rt13.tag >= CLASS && rt23.tag >= CLASS &&
mcimadamore@59 1418 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
mcimadamore@59 1419 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
mcimadamore@59 1420 if (compat)
mcimadamore@59 1421 return true;
mcimadamore@59 1422 }
mcimadamore@59 1423 }
mcimadamore@59 1424 }
mcimadamore@59 1425 return false;
mcimadamore@59 1426 }
duke@1 1427
duke@1 1428 /** Check that a given method conforms with any method it overrides.
duke@1 1429 * @param tree The tree from which positions are extracted
duke@1 1430 * for errors.
duke@1 1431 * @param m The overriding method.
duke@1 1432 */
duke@1 1433 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1434 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1435 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1436 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1437 log.error(tree.pos(), "enum.no.finalize");
duke@1 1438 return;
duke@1 1439 }
duke@1 1440 for (Type t = types.supertype(origin.type); t.tag == CLASS;
duke@1 1441 t = types.supertype(t)) {
duke@1 1442 TypeSymbol c = t.tsym;
duke@1 1443 Scope.Entry e = c.members().lookup(m.name);
duke@1 1444 while (e.scope != null) {
duke@1 1445 if (m.overrides(e.sym, origin, types, false))
duke@1 1446 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@24 1447 else if (e.sym.isInheritedIn(origin, types) && !m.isConstructor()) {
mcimadamore@24 1448 Type er1 = m.erasure(types);
mcimadamore@24 1449 Type er2 = e.sym.erasure(types);
mcimadamore@24 1450 if (types.isSameType(er1,er2)) {
mcimadamore@24 1451 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@24 1452 "name.clash.same.erasure.no.override",
mcimadamore@24 1453 m, m.location(),
mcimadamore@24 1454 e.sym, e.sym.location());
mcimadamore@24 1455 }
mcimadamore@24 1456 }
duke@1 1457 e = e.next();
duke@1 1458 }
duke@1 1459 }
duke@1 1460 }
duke@1 1461
duke@1 1462 /** Check that all abstract members of given class have definitions.
duke@1 1463 * @param pos Position to be used for error reporting.
duke@1 1464 * @param c The class.
duke@1 1465 */
duke@1 1466 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1467 try {
duke@1 1468 MethodSymbol undef = firstUndef(c, c);
duke@1 1469 if (undef != null) {
duke@1 1470 if ((c.flags() & ENUM) != 0 &&
duke@1 1471 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 1472 (c.flags() & FINAL) == 0) {
duke@1 1473 // add the ABSTRACT flag to an enum
duke@1 1474 c.flags_field |= ABSTRACT;
duke@1 1475 } else {
duke@1 1476 MethodSymbol undef1 =
duke@1 1477 new MethodSymbol(undef.flags(), undef.name,
duke@1 1478 types.memberType(c.type, undef), undef.owner);
duke@1 1479 log.error(pos, "does.not.override.abstract",
duke@1 1480 c, undef1, undef1.location());
duke@1 1481 }
duke@1 1482 }
duke@1 1483 } catch (CompletionFailure ex) {
duke@1 1484 completionError(pos, ex);
duke@1 1485 }
duke@1 1486 }
duke@1 1487 //where
duke@1 1488 /** Return first abstract member of class `c' that is not defined
duke@1 1489 * in `impl', null if there is none.
duke@1 1490 */
duke@1 1491 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 1492 MethodSymbol undef = null;
duke@1 1493 // Do not bother to search in classes that are not abstract,
duke@1 1494 // since they cannot have abstract members.
duke@1 1495 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 1496 Scope s = c.members();
duke@1 1497 for (Scope.Entry e = s.elems;
duke@1 1498 undef == null && e != null;
duke@1 1499 e = e.sibling) {
duke@1 1500 if (e.sym.kind == MTH &&
duke@1 1501 (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
duke@1 1502 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 1503 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
duke@1 1504 if (implmeth == null || implmeth == absmeth)
duke@1 1505 undef = absmeth;
duke@1 1506 }
duke@1 1507 }
duke@1 1508 if (undef == null) {
duke@1 1509 Type st = types.supertype(c.type);
duke@1 1510 if (st.tag == CLASS)
duke@1 1511 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 1512 }
duke@1 1513 for (List<Type> l = types.interfaces(c.type);
duke@1 1514 undef == null && l.nonEmpty();
duke@1 1515 l = l.tail) {
duke@1 1516 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 1517 }
duke@1 1518 }
duke@1 1519 return undef;
duke@1 1520 }
duke@1 1521
duke@1 1522 /** Check for cyclic references. Issue an error if the
duke@1 1523 * symbol of the type referred to has a LOCKED flag set.
duke@1 1524 *
duke@1 1525 * @param pos Position to be used for error reporting.
duke@1 1526 * @param t The type referred to.
duke@1 1527 */
duke@1 1528 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 1529 checkNonCyclicInternal(pos, t);
duke@1 1530 }
duke@1 1531
duke@1 1532
duke@1 1533 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
duke@1 1534 checkNonCyclic1(pos, t, new HashSet<TypeVar>());
duke@1 1535 }
duke@1 1536
duke@1 1537 private void checkNonCyclic1(DiagnosticPosition pos, Type t, Set<TypeVar> seen) {
duke@1 1538 final TypeVar tv;
mcimadamore@42 1539 if (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 1540 return;
duke@1 1541 if (seen.contains(t)) {
duke@1 1542 tv = (TypeVar)t;
duke@1 1543 tv.bound = new ErrorType();
duke@1 1544 log.error(pos, "cyclic.inheritance", t);
duke@1 1545 } else if (t.tag == TYPEVAR) {
duke@1 1546 tv = (TypeVar)t;
duke@1 1547 seen.add(tv);
duke@1 1548 for (Type b : types.getBounds(tv))
duke@1 1549 checkNonCyclic1(pos, b, seen);
duke@1 1550 }
duke@1 1551 }
duke@1 1552
duke@1 1553 /** Check for cyclic references. Issue an error if the
duke@1 1554 * symbol of the type referred to has a LOCKED flag set.
duke@1 1555 *
duke@1 1556 * @param pos Position to be used for error reporting.
duke@1 1557 * @param t The type referred to.
duke@1 1558 * @returns True if the check completed on all attributed classes
duke@1 1559 */
duke@1 1560 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 1561 boolean complete = true; // was the check complete?
duke@1 1562 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 1563 Symbol c = t.tsym;
duke@1 1564 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 1565
duke@1 1566 if ((c.flags_field & LOCKED) != 0) {
duke@1 1567 noteCyclic(pos, (ClassSymbol)c);
duke@1 1568 } else if (!c.type.isErroneous()) {
duke@1 1569 try {
duke@1 1570 c.flags_field |= LOCKED;
duke@1 1571 if (c.type.tag == CLASS) {
duke@1 1572 ClassType clazz = (ClassType)c.type;
duke@1 1573 if (clazz.interfaces_field != null)
duke@1 1574 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 1575 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 1576 if (clazz.supertype_field != null) {
duke@1 1577 Type st = clazz.supertype_field;
duke@1 1578 if (st != null && st.tag == CLASS)
duke@1 1579 complete &= checkNonCyclicInternal(pos, st);
duke@1 1580 }
duke@1 1581 if (c.owner.kind == TYP)
duke@1 1582 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 1583 }
duke@1 1584 } finally {
duke@1 1585 c.flags_field &= ~LOCKED;
duke@1 1586 }
duke@1 1587 }
duke@1 1588 if (complete)
duke@1 1589 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 1590 if (complete) c.flags_field |= ACYCLIC;
duke@1 1591 return complete;
duke@1 1592 }
duke@1 1593
duke@1 1594 /** Note that we found an inheritance cycle. */
duke@1 1595 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1596 log.error(pos, "cyclic.inheritance", c);
duke@1 1597 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
duke@1 1598 l.head = new ErrorType((ClassSymbol)l.head.tsym);
duke@1 1599 Type st = types.supertype(c.type);
duke@1 1600 if (st.tag == CLASS)
duke@1 1601 ((ClassType)c.type).supertype_field = new ErrorType((ClassSymbol)st.tsym);
duke@1 1602 c.type = new ErrorType(c);
duke@1 1603 c.flags_field |= ACYCLIC;
duke@1 1604 }
duke@1 1605
duke@1 1606 /** Check that all methods which implement some
duke@1 1607 * method conform to the method they implement.
duke@1 1608 * @param tree The class definition whose members are checked.
duke@1 1609 */
duke@1 1610 void checkImplementations(JCClassDecl tree) {
duke@1 1611 checkImplementations(tree, tree.sym);
duke@1 1612 }
duke@1 1613 //where
duke@1 1614 /** Check that all methods which implement some
duke@1 1615 * method in `ic' conform to the method they implement.
duke@1 1616 */
duke@1 1617 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
duke@1 1618 ClassSymbol origin = tree.sym;
duke@1 1619 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 1620 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 1621 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 1622 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 1623 if (e.sym.kind == MTH &&
duke@1 1624 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 1625 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 1626 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 1627 if (implmeth != null && implmeth != absmeth &&
duke@1 1628 (implmeth.owner.flags() & INTERFACE) ==
duke@1 1629 (origin.flags() & INTERFACE)) {
duke@1 1630 // don't check if implmeth is in a class, yet
duke@1 1631 // origin is an interface. This case arises only
duke@1 1632 // if implmeth is declared in Object. The reason is
duke@1 1633 // that interfaces really don't inherit from
duke@1 1634 // Object it's just that the compiler represents
duke@1 1635 // things that way.
duke@1 1636 checkOverride(tree, implmeth, absmeth, origin);
duke@1 1637 }
duke@1 1638 }
duke@1 1639 }
duke@1 1640 }
duke@1 1641 }
duke@1 1642 }
duke@1 1643
duke@1 1644 /** Check that all abstract methods implemented by a class are
duke@1 1645 * mutually compatible.
duke@1 1646 * @param pos Position to be used for error reporting.
duke@1 1647 * @param c The class whose interfaces are checked.
duke@1 1648 */
duke@1 1649 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 1650 List<Type> supertypes = types.interfaces(c);
duke@1 1651 Type supertype = types.supertype(c);
duke@1 1652 if (supertype.tag == CLASS &&
duke@1 1653 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 1654 supertypes = supertypes.prepend(supertype);
duke@1 1655 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 1656 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 1657 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 1658 return;
duke@1 1659 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 1660 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 1661 return;
duke@1 1662 }
duke@1 1663 checkCompatibleConcretes(pos, c);
duke@1 1664 }
duke@1 1665
duke@1 1666 /** Check that class c does not implement directly or indirectly
duke@1 1667 * the same parameterized interface with two different argument lists.
duke@1 1668 * @param pos Position to be used for error reporting.
duke@1 1669 * @param type The type whose interfaces are checked.
duke@1 1670 */
duke@1 1671 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 1672 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 1673 }
duke@1 1674 //where
duke@1 1675 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 1676 * with their class symbol as key and their type as value. Make
duke@1 1677 * sure no class is entered with two different types.
duke@1 1678 */
duke@1 1679 void checkClassBounds(DiagnosticPosition pos,
duke@1 1680 Map<TypeSymbol,Type> seensofar,
duke@1 1681 Type type) {
duke@1 1682 if (type.isErroneous()) return;
duke@1 1683 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 1684 Type it = l.head;
duke@1 1685 Type oldit = seensofar.put(it.tsym, it);
duke@1 1686 if (oldit != null) {
duke@1 1687 List<Type> oldparams = oldit.allparams();
duke@1 1688 List<Type> newparams = it.allparams();
duke@1 1689 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 1690 log.error(pos, "cant.inherit.diff.arg",
duke@1 1691 it.tsym, Type.toString(oldparams),
duke@1 1692 Type.toString(newparams));
duke@1 1693 }
duke@1 1694 checkClassBounds(pos, seensofar, it);
duke@1 1695 }
duke@1 1696 Type st = types.supertype(type);
duke@1 1697 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 1698 }
duke@1 1699
duke@1 1700 /** Enter interface into into set.
duke@1 1701 * If it existed already, issue a "repeated interface" error.
duke@1 1702 */
duke@1 1703 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 1704 if (its.contains(it))
duke@1 1705 log.error(pos, "repeated.interface");
duke@1 1706 else {
duke@1 1707 its.add(it);
duke@1 1708 }
duke@1 1709 }
duke@1 1710
duke@1 1711 /* *************************************************************************
duke@1 1712 * Check annotations
duke@1 1713 **************************************************************************/
duke@1 1714
duke@1 1715 /** Annotation types are restricted to primitives, String, an
duke@1 1716 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 1717 * Anything>, arrays of the preceding.
duke@1 1718 */
duke@1 1719 void validateAnnotationType(JCTree restype) {
duke@1 1720 // restype may be null if an error occurred, so don't bother validating it
duke@1 1721 if (restype != null) {
duke@1 1722 validateAnnotationType(restype.pos(), restype.type);
duke@1 1723 }
duke@1 1724 }
duke@1 1725
duke@1 1726 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 1727 if (type.isPrimitive()) return;
duke@1 1728 if (types.isSameType(type, syms.stringType)) return;
duke@1 1729 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 1730 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 1731 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 1732 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 1733 validateAnnotationType(pos, types.elemtype(type));
duke@1 1734 return;
duke@1 1735 }
duke@1 1736 log.error(pos, "invalid.annotation.member.type");
duke@1 1737 }
duke@1 1738
duke@1 1739 /**
duke@1 1740 * "It is also a compile-time error if any method declared in an
duke@1 1741 * annotation type has a signature that is override-equivalent to
duke@1 1742 * that of any public or protected method declared in class Object
duke@1 1743 * or in the interface annotation.Annotation."
duke@1 1744 *
duke@1 1745 * @jls3 9.6 Annotation Types
duke@1 1746 */
duke@1 1747 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
duke@1 1748 for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
duke@1 1749 Scope s = sup.tsym.members();
duke@1 1750 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 1751 if (e.sym.kind == MTH &&
duke@1 1752 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 1753 types.overrideEquivalent(m.type, e.sym.type))
duke@1 1754 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 1755 }
duke@1 1756 }
duke@1 1757 }
duke@1 1758
duke@1 1759 /** Check the annotations of a symbol.
duke@1 1760 */
duke@1 1761 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 1762 if (skipAnnotations) return;
duke@1 1763 for (JCAnnotation a : annotations)
duke@1 1764 validateAnnotation(a, s);
duke@1 1765 }
duke@1 1766
duke@1 1767 /** Check an annotation of a symbol.
duke@1 1768 */
duke@1 1769 public void validateAnnotation(JCAnnotation a, Symbol s) {
duke@1 1770 validateAnnotation(a);
duke@1 1771
duke@1 1772 if (!annotationApplicable(a, s))
duke@1 1773 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 1774
duke@1 1775 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 1776 if (!isOverrider(s))
duke@1 1777 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 1778 }
duke@1 1779 }
duke@1 1780
duke@1 1781 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 1782 boolean isOverrider(Symbol s) {
duke@1 1783 if (s.kind != MTH || s.isStatic())
duke@1 1784 return false;
duke@1 1785 MethodSymbol m = (MethodSymbol)s;
duke@1 1786 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 1787 for (Type sup : types.closure(owner.type)) {
duke@1 1788 if (sup == owner.type)
duke@1 1789 continue; // skip "this"
duke@1 1790 Scope scope = sup.tsym.members();
duke@1 1791 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 1792 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 1793 return true;
duke@1 1794 }
duke@1 1795 }
duke@1 1796 return false;
duke@1 1797 }
duke@1 1798
duke@1 1799 /** Is the annotation applicable to the symbol? */
duke@1 1800 boolean annotationApplicable(JCAnnotation a, Symbol s) {
duke@1 1801 Attribute.Compound atTarget =
duke@1 1802 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
duke@1 1803 if (atTarget == null) return true;
duke@1 1804 Attribute atValue = atTarget.member(names.value);
duke@1 1805 if (!(atValue instanceof Attribute.Array)) return true; // error recovery
duke@1 1806 Attribute.Array arr = (Attribute.Array) atValue;
duke@1 1807 for (Attribute app : arr.values) {
duke@1 1808 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 1809 Attribute.Enum e = (Attribute.Enum) app;
duke@1 1810 if (e.value.name == names.TYPE)
duke@1 1811 { if (s.kind == TYP) return true; }
duke@1 1812 else if (e.value.name == names.FIELD)
duke@1 1813 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 1814 else if (e.value.name == names.METHOD)
duke@1 1815 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 1816 else if (e.value.name == names.PARAMETER)
duke@1 1817 { if (s.kind == VAR &&
duke@1 1818 s.owner.kind == MTH &&
duke@1 1819 (s.flags() & PARAMETER) != 0)
duke@1 1820 return true;
duke@1 1821 }
duke@1 1822 else if (e.value.name == names.CONSTRUCTOR)
duke@1 1823 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 1824 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 1825 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 1826 (s.flags() & PARAMETER) == 0)
duke@1 1827 return true;
duke@1 1828 }
duke@1 1829 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 1830 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 1831 return true;
duke@1 1832 }
duke@1 1833 else if (e.value.name == names.PACKAGE)
duke@1 1834 { if (s.kind == PCK) return true; }
duke@1 1835 else
duke@1 1836 return true; // recovery
duke@1 1837 }
duke@1 1838 return false;
duke@1 1839 }
duke@1 1840
duke@1 1841 /** Check an annotation value.
duke@1 1842 */
duke@1 1843 public void validateAnnotation(JCAnnotation a) {
duke@1 1844 if (a.type.isErroneous()) return;
duke@1 1845
duke@1 1846 // collect an inventory of the members
duke@1 1847 Set<MethodSymbol> members = new HashSet<MethodSymbol>();
duke@1 1848 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 1849 e != null;
duke@1 1850 e = e.sibling)
duke@1 1851 if (e.sym.kind == MTH)
duke@1 1852 members.add((MethodSymbol) e.sym);
duke@1 1853
duke@1 1854 // count them off as they're annotated
duke@1 1855 for (JCTree arg : a.args) {
duke@1 1856 if (arg.getTag() != JCTree.ASSIGN) continue; // recovery
duke@1 1857 JCAssign assign = (JCAssign) arg;
duke@1 1858 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 1859 if (m == null || m.type.isErroneous()) continue;
duke@1 1860 if (!members.remove(m))
duke@1 1861 log.error(arg.pos(), "duplicate.annotation.member.value",
duke@1 1862 m.name, a.type);
duke@1 1863 if (assign.rhs.getTag() == ANNOTATION)
duke@1 1864 validateAnnotation((JCAnnotation)assign.rhs);
duke@1 1865 }
duke@1 1866
duke@1 1867 // all the remaining ones better have default values
duke@1 1868 for (MethodSymbol m : members)
duke@1 1869 if (m.defaultValue == null && !m.type.isErroneous())
duke@1 1870 log.error(a.pos(), "annotation.missing.default.value",
duke@1 1871 a.type, m.name);
duke@1 1872
duke@1 1873 // special case: java.lang.annotation.Target must not have
duke@1 1874 // repeated values in its value member
duke@1 1875 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 1876 a.args.tail == null)
duke@1 1877 return;
duke@1 1878
duke@1 1879 if (a.args.head.getTag() != JCTree.ASSIGN) return; // error recovery
duke@1 1880 JCAssign assign = (JCAssign) a.args.head;
duke@1 1881 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 1882 if (m.name != names.value) return;
duke@1 1883 JCTree rhs = assign.rhs;
duke@1 1884 if (rhs.getTag() != JCTree.NEWARRAY) return;
duke@1 1885 JCNewArray na = (JCNewArray) rhs;
duke@1 1886 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 1887 for (JCTree elem : na.elems) {
duke@1 1888 if (!targets.add(TreeInfo.symbol(elem))) {
duke@1 1889 log.error(elem.pos(), "repeated.annotation.target");
duke@1 1890 }
duke@1 1891 }
duke@1 1892 }
duke@1 1893
duke@1 1894 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 1895 if (allowAnnotations &&
duke@1 1896 lint.isEnabled(Lint.LintCategory.DEP_ANN) &&
duke@1 1897 (s.flags() & DEPRECATED) != 0 &&
duke@1 1898 !syms.deprecatedType.isErroneous() &&
duke@1 1899 s.attribute(syms.deprecatedType.tsym) == null) {
duke@1 1900 log.warning(pos, "missing.deprecated.annotation");
duke@1 1901 }
duke@1 1902 }
duke@1 1903
duke@1 1904 /* *************************************************************************
duke@1 1905 * Check for recursive annotation elements.
duke@1 1906 **************************************************************************/
duke@1 1907
duke@1 1908 /** Check for cycles in the graph of annotation elements.
duke@1 1909 */
duke@1 1910 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 1911 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
duke@1 1912 assert (tree.sym.flags_field & LOCKED) == 0;
duke@1 1913 try {
duke@1 1914 tree.sym.flags_field |= LOCKED;
duke@1 1915 for (JCTree def : tree.defs) {
duke@1 1916 if (def.getTag() != JCTree.METHODDEF) continue;
duke@1 1917 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 1918 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 1919 }
duke@1 1920 } finally {
duke@1 1921 tree.sym.flags_field &= ~LOCKED;
duke@1 1922 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 1923 }
duke@1 1924 }
duke@1 1925
duke@1 1926 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 1927 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 1928 return;
duke@1 1929 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 1930 log.error(pos, "cyclic.annotation.element");
duke@1 1931 return;
duke@1 1932 }
duke@1 1933 try {
duke@1 1934 tsym.flags_field |= LOCKED;
duke@1 1935 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 1936 Symbol s = e.sym;
duke@1 1937 if (s.kind != Kinds.MTH)
duke@1 1938 continue;
duke@1 1939 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 1940 }
duke@1 1941 } finally {
duke@1 1942 tsym.flags_field &= ~LOCKED;
duke@1 1943 tsym.flags_field |= ACYCLIC_ANN;
duke@1 1944 }
duke@1 1945 }
duke@1 1946
duke@1 1947 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
duke@1 1948 switch (type.tag) {
duke@1 1949 case TypeTags.CLASS:
duke@1 1950 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 1951 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 1952 break;
duke@1 1953 case TypeTags.ARRAY:
duke@1 1954 checkAnnotationResType(pos, types.elemtype(type));
duke@1 1955 break;
duke@1 1956 default:
duke@1 1957 break; // int etc
duke@1 1958 }
duke@1 1959 }
duke@1 1960
duke@1 1961 /* *************************************************************************
duke@1 1962 * Check for cycles in the constructor call graph.
duke@1 1963 **************************************************************************/
duke@1 1964
duke@1 1965 /** Check for cycles in the graph of constructors calling other
duke@1 1966 * constructors.
duke@1 1967 */
duke@1 1968 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 1969 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 1970
duke@1 1971 // enter each constructor this-call into the map
duke@1 1972 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 1973 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 1974 if (app == null) continue;
duke@1 1975 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 1976 if (TreeInfo.name(app.meth) == names._this) {
duke@1 1977 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 1978 } else {
duke@1 1979 meth.sym.flags_field |= ACYCLIC;
duke@1 1980 }
duke@1 1981 }
duke@1 1982
duke@1 1983 // Check for cycles in the map
duke@1 1984 Symbol[] ctors = new Symbol[0];
duke@1 1985 ctors = callMap.keySet().toArray(ctors);
duke@1 1986 for (Symbol caller : ctors) {
duke@1 1987 checkCyclicConstructor(tree, caller, callMap);
duke@1 1988 }
duke@1 1989 }
duke@1 1990
duke@1 1991 /** Look in the map to see if the given constructor is part of a
duke@1 1992 * call cycle.
duke@1 1993 */
duke@1 1994 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 1995 Map<Symbol,Symbol> callMap) {
duke@1 1996 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 1997 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 1998 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 1999 "recursive.ctor.invocation");
duke@1 2000 } else {
duke@1 2001 ctor.flags_field |= LOCKED;
duke@1 2002 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 2003 ctor.flags_field &= ~LOCKED;
duke@1 2004 }
duke@1 2005 ctor.flags_field |= ACYCLIC;
duke@1 2006 }
duke@1 2007 }
duke@1 2008
duke@1 2009 /* *************************************************************************
duke@1 2010 * Miscellaneous
duke@1 2011 **************************************************************************/
duke@1 2012
duke@1 2013 /**
duke@1 2014 * Return the opcode of the operator but emit an error if it is an
duke@1 2015 * error.
duke@1 2016 * @param pos position for error reporting.
duke@1 2017 * @param operator an operator
duke@1 2018 * @param tag a tree tag
duke@1 2019 * @param left type of left hand side
duke@1 2020 * @param right type of right hand side
duke@1 2021 */
duke@1 2022 int checkOperator(DiagnosticPosition pos,
duke@1 2023 OperatorSymbol operator,
duke@1 2024 int tag,
duke@1 2025 Type left,
duke@1 2026 Type right) {
duke@1 2027 if (operator.opcode == ByteCodes.error) {
duke@1 2028 log.error(pos,
duke@1 2029 "operator.cant.be.applied",
duke@1 2030 treeinfo.operatorName(tag),
mcimadamore@80 2031 List.of(left, right));
duke@1 2032 }
duke@1 2033 return operator.opcode;
duke@1 2034 }
duke@1 2035
duke@1 2036
duke@1 2037 /**
duke@1 2038 * Check for division by integer constant zero
duke@1 2039 * @param pos Position for error reporting.
duke@1 2040 * @param operator The operator for the expression
duke@1 2041 * @param operand The right hand operand for the expression
duke@1 2042 */
duke@1 2043 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 2044 if (operand.constValue() != null
duke@1 2045 && lint.isEnabled(Lint.LintCategory.DIVZERO)
duke@1 2046 && operand.tag <= LONG
duke@1 2047 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 2048 int opc = ((OperatorSymbol)operator).opcode;
duke@1 2049 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 2050 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
duke@1 2051 log.warning(pos, "div.zero");
duke@1 2052 }
duke@1 2053 }
duke@1 2054 }
duke@1 2055
duke@1 2056 /**
duke@1 2057 * Check for empty statements after if
duke@1 2058 */
duke@1 2059 void checkEmptyIf(JCIf tree) {
duke@1 2060 if (tree.thenpart.getTag() == JCTree.SKIP && tree.elsepart == null && lint.isEnabled(Lint.LintCategory.EMPTY))
duke@1 2061 log.warning(tree.thenpart.pos(), "empty.if");
duke@1 2062 }
duke@1 2063
duke@1 2064 /** Check that symbol is unique in given scope.
duke@1 2065 * @param pos Position for error reporting.
duke@1 2066 * @param sym The symbol.
duke@1 2067 * @param s The scope.
duke@1 2068 */
duke@1 2069 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2070 if (sym.type.isErroneous())
duke@1 2071 return true;
duke@1 2072 if (sym.owner.name == names.any) return false;
duke@1 2073 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 2074 if (sym != e.sym &&
duke@1 2075 sym.kind == e.sym.kind &&
duke@1 2076 sym.name != names.error &&
duke@1 2077 (sym.kind != MTH || types.overrideEquivalent(sym.type, e.sym.type))) {
duke@1 2078 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS))
duke@1 2079 varargsDuplicateError(pos, sym, e.sym);
duke@1 2080 else
duke@1 2081 duplicateError(pos, e.sym);
duke@1 2082 return false;
duke@1 2083 }
duke@1 2084 }
duke@1 2085 return true;
duke@1 2086 }
duke@1 2087
duke@1 2088 /** Check that single-type import is not already imported or top-level defined,
duke@1 2089 * but make an exception for two single-type imports which denote the same type.
duke@1 2090 * @param pos Position for error reporting.
duke@1 2091 * @param sym The symbol.
duke@1 2092 * @param s The scope
duke@1 2093 */
duke@1 2094 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2095 return checkUniqueImport(pos, sym, s, false);
duke@1 2096 }
duke@1 2097
duke@1 2098 /** Check that static single-type import is not already imported or top-level defined,
duke@1 2099 * but make an exception for two single-type imports which denote the same type.
duke@1 2100 * @param pos Position for error reporting.
duke@1 2101 * @param sym The symbol.
duke@1 2102 * @param s The scope
duke@1 2103 * @param staticImport Whether or not this was a static import
duke@1 2104 */
duke@1 2105 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2106 return checkUniqueImport(pos, sym, s, true);
duke@1 2107 }
duke@1 2108
duke@1 2109 /** Check that single-type import is not already imported or top-level defined,
duke@1 2110 * but make an exception for two single-type imports which denote the same type.
duke@1 2111 * @param pos Position for error reporting.
duke@1 2112 * @param sym The symbol.
duke@1 2113 * @param s The scope.
duke@1 2114 * @param staticImport Whether or not this was a static import
duke@1 2115 */
duke@1 2116 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 2117 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 2118 // is encountered class entered via a class declaration?
duke@1 2119 boolean isClassDecl = e.scope == s;
duke@1 2120 if ((isClassDecl || sym != e.sym) &&
duke@1 2121 sym.kind == e.sym.kind &&
duke@1 2122 sym.name != names.error) {
duke@1 2123 if (!e.sym.type.isErroneous()) {
duke@1 2124 String what = e.sym.toString();
duke@1 2125 if (!isClassDecl) {
duke@1 2126 if (staticImport)
duke@1 2127 log.error(pos, "already.defined.static.single.import", what);
duke@1 2128 else
duke@1 2129 log.error(pos, "already.defined.single.import", what);
duke@1 2130 }
duke@1 2131 else if (sym != e.sym)
duke@1 2132 log.error(pos, "already.defined.this.unit", what);
duke@1 2133 }
duke@1 2134 return false;
duke@1 2135 }
duke@1 2136 }
duke@1 2137 return true;
duke@1 2138 }
duke@1 2139
duke@1 2140 /** Check that a qualified name is in canonical form (for import decls).
duke@1 2141 */
duke@1 2142 public void checkCanonical(JCTree tree) {
duke@1 2143 if (!isCanonical(tree))
duke@1 2144 log.error(tree.pos(), "import.requires.canonical",
duke@1 2145 TreeInfo.symbol(tree));
duke@1 2146 }
duke@1 2147 // where
duke@1 2148 private boolean isCanonical(JCTree tree) {
duke@1 2149 while (tree.getTag() == JCTree.SELECT) {
duke@1 2150 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 2151 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 2152 return false;
duke@1 2153 tree = s.selected;
duke@1 2154 }
duke@1 2155 return true;
duke@1 2156 }
duke@1 2157
duke@1 2158 private class ConversionWarner extends Warner {
duke@1 2159 final String key;
duke@1 2160 final Type found;
duke@1 2161 final Type expected;
duke@1 2162 public ConversionWarner(DiagnosticPosition pos, String key, Type found, Type expected) {
duke@1 2163 super(pos);
duke@1 2164 this.key = key;
duke@1 2165 this.found = found;
duke@1 2166 this.expected = expected;
duke@1 2167 }
duke@1 2168
duke@1 2169 public void warnUnchecked() {
duke@1 2170 boolean warned = this.warned;
duke@1 2171 super.warnUnchecked();
duke@1 2172 if (warned) return; // suppress redundant diagnostics
duke@1 2173 Object problem = JCDiagnostic.fragment(key);
duke@1 2174 Check.this.warnUnchecked(pos(), "prob.found.req", problem, found, expected);
duke@1 2175 }
duke@1 2176 }
duke@1 2177
duke@1 2178 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2179 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 2180 }
duke@1 2181
duke@1 2182 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2183 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 2184 }
duke@1 2185 }

mercurial