Fri, 02 Mar 2012 12:57:47 +0000
7148242: Regression: valid code rejected during generic type well-formedness check
Summary: Redundant type-var substitution makes generic-type well-formedness check to fail
Reviewed-by: jjg
duke@1 | 1 | /* |
mcimadamore@1198 | 2 | * Copyright (c) 1999, 2012, Oracle and/or its affiliates. All rights reserved. |
duke@1 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@1 | 4 | * |
duke@1 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@1 | 6 | * under the terms of the GNU General Public License version 2 only, as |
ohair@554 | 7 | * published by the Free Software Foundation. Oracle designates this |
duke@1 | 8 | * particular file as subject to the "Classpath" exception as provided |
ohair@554 | 9 | * by Oracle in the LICENSE file that accompanied this code. |
duke@1 | 10 | * |
duke@1 | 11 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@1 | 12 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@1 | 13 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@1 | 14 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@1 | 15 | * accompanied this code). |
duke@1 | 16 | * |
duke@1 | 17 | * You should have received a copy of the GNU General Public License version |
duke@1 | 18 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@1 | 19 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@1 | 20 | * |
ohair@554 | 21 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
ohair@554 | 22 | * or visit www.oracle.com if you need additional information or have any |
ohair@554 | 23 | * questions. |
duke@1 | 24 | */ |
duke@1 | 25 | |
duke@1 | 26 | package com.sun.tools.javac.comp; |
duke@1 | 27 | |
duke@1 | 28 | import java.util.*; |
duke@1 | 29 | import java.util.Set; |
duke@1 | 30 | |
duke@1 | 31 | import com.sun.tools.javac.code.*; |
duke@1 | 32 | import com.sun.tools.javac.jvm.*; |
duke@1 | 33 | import com.sun.tools.javac.tree.*; |
duke@1 | 34 | import com.sun.tools.javac.util.*; |
duke@1 | 35 | import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition; |
duke@1 | 36 | import com.sun.tools.javac.util.List; |
duke@1 | 37 | |
duke@1 | 38 | import com.sun.tools.javac.tree.JCTree.*; |
duke@1 | 39 | import com.sun.tools.javac.code.Lint; |
duke@1 | 40 | import com.sun.tools.javac.code.Lint.LintCategory; |
duke@1 | 41 | import com.sun.tools.javac.code.Type.*; |
duke@1 | 42 | import com.sun.tools.javac.code.Symbol.*; |
duke@1 | 43 | |
duke@1 | 44 | import static com.sun.tools.javac.code.Flags.*; |
jjg@1127 | 45 | import static com.sun.tools.javac.code.Flags.ANNOTATION; |
jjg@1127 | 46 | import static com.sun.tools.javac.code.Flags.SYNCHRONIZED; |
duke@1 | 47 | import static com.sun.tools.javac.code.Kinds.*; |
duke@1 | 48 | import static com.sun.tools.javac.code.TypeTags.*; |
jjg@1127 | 49 | import static com.sun.tools.javac.code.TypeTags.WILDCARD; |
duke@1 | 50 | |
jjg@1127 | 51 | import static com.sun.tools.javac.tree.JCTree.Tag.*; |
jjg@700 | 52 | |
duke@1 | 53 | /** Type checking helper class for the attribution phase. |
duke@1 | 54 | * |
jjg@581 | 55 | * <p><b>This is NOT part of any supported API. |
jjg@581 | 56 | * If you write code that depends on this, you do so at your own risk. |
duke@1 | 57 | * This code and its internal interfaces are subject to change or |
duke@1 | 58 | * deletion without notice.</b> |
duke@1 | 59 | */ |
duke@1 | 60 | public class Check { |
duke@1 | 61 | protected static final Context.Key<Check> checkKey = |
duke@1 | 62 | new Context.Key<Check>(); |
duke@1 | 63 | |
jjg@113 | 64 | private final Names names; |
duke@1 | 65 | private final Log log; |
duke@1 | 66 | private final Symtab syms; |
mcimadamore@690 | 67 | private final Enter enter; |
duke@1 | 68 | private final Infer infer; |
duke@1 | 69 | private final Types types; |
mcimadamore@89 | 70 | private final JCDiagnostic.Factory diags; |
duke@1 | 71 | private final boolean skipAnnotations; |
mcimadamore@359 | 72 | private boolean warnOnSyntheticConflicts; |
jjg@576 | 73 | private boolean suppressAbortOnBadClassFile; |
mcimadamore@852 | 74 | private boolean enableSunApiLintControl; |
duke@1 | 75 | private final TreeInfo treeinfo; |
duke@1 | 76 | |
duke@1 | 77 | // The set of lint options currently in effect. It is initialized |
duke@1 | 78 | // from the context, and then is set/reset as needed by Attr as it |
duke@1 | 79 | // visits all the various parts of the trees during attribution. |
duke@1 | 80 | private Lint lint; |
duke@1 | 81 | |
mcimadamore@795 | 82 | // The method being analyzed in Attr - it is set/reset as needed by |
mcimadamore@795 | 83 | // Attr as it visits new method declarations. |
mcimadamore@795 | 84 | private MethodSymbol method; |
mcimadamore@795 | 85 | |
duke@1 | 86 | public static Check instance(Context context) { |
duke@1 | 87 | Check instance = context.get(checkKey); |
duke@1 | 88 | if (instance == null) |
duke@1 | 89 | instance = new Check(context); |
duke@1 | 90 | return instance; |
duke@1 | 91 | } |
duke@1 | 92 | |
duke@1 | 93 | protected Check(Context context) { |
duke@1 | 94 | context.put(checkKey, this); |
duke@1 | 95 | |
jjg@113 | 96 | names = Names.instance(context); |
duke@1 | 97 | log = Log.instance(context); |
duke@1 | 98 | syms = Symtab.instance(context); |
mcimadamore@690 | 99 | enter = Enter.instance(context); |
duke@1 | 100 | infer = Infer.instance(context); |
duke@1 | 101 | this.types = Types.instance(context); |
mcimadamore@89 | 102 | diags = JCDiagnostic.Factory.instance(context); |
duke@1 | 103 | Options options = Options.instance(context); |
duke@1 | 104 | lint = Lint.instance(context); |
duke@1 | 105 | treeinfo = TreeInfo.instance(context); |
duke@1 | 106 | |
duke@1 | 107 | Source source = Source.instance(context); |
duke@1 | 108 | allowGenerics = source.allowGenerics(); |
duke@1 | 109 | allowAnnotations = source.allowAnnotations(); |
jjg@398 | 110 | allowCovariantReturns = source.allowCovariantReturns(); |
mcimadamore@795 | 111 | allowSimplifiedVarargs = source.allowSimplifiedVarargs(); |
jjg@1157 | 112 | complexInference = options.isSet("complexinference"); |
jjg@700 | 113 | skipAnnotations = options.isSet("skipAnnotations"); |
jjg@700 | 114 | warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts"); |
jjg@700 | 115 | suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile"); |
mcimadamore@852 | 116 | enableSunApiLintControl = options.isSet("enableSunApiLintControl"); |
duke@1 | 117 | |
jjg@398 | 118 | Target target = Target.instance(context); |
jjg@398 | 119 | syntheticNameChar = target.syntheticNameChar(); |
jjg@398 | 120 | |
duke@1 | 121 | boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION); |
duke@1 | 122 | boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED); |
jjg@377 | 123 | boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI); |
jjg@60 | 124 | boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings(); |
duke@1 | 125 | |
jjg@60 | 126 | deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated, |
jjg@612 | 127 | enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION); |
jjg@60 | 128 | uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked, |
jjg@612 | 129 | enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED); |
jjg@377 | 130 | sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi, |
jjg@612 | 131 | enforceMandatoryWarnings, "sunapi", null); |
mcimadamore@852 | 132 | |
mcimadamore@852 | 133 | deferredLintHandler = DeferredLintHandler.immediateHandler; |
duke@1 | 134 | } |
duke@1 | 135 | |
duke@1 | 136 | /** Switch: generics enabled? |
duke@1 | 137 | */ |
duke@1 | 138 | boolean allowGenerics; |
duke@1 | 139 | |
duke@1 | 140 | /** Switch: annotations enabled? |
duke@1 | 141 | */ |
duke@1 | 142 | boolean allowAnnotations; |
duke@1 | 143 | |
jjg@398 | 144 | /** Switch: covariant returns enabled? |
jjg@398 | 145 | */ |
jjg@398 | 146 | boolean allowCovariantReturns; |
jjg@398 | 147 | |
mcimadamore@795 | 148 | /** Switch: simplified varargs enabled? |
mcimadamore@795 | 149 | */ |
mcimadamore@795 | 150 | boolean allowSimplifiedVarargs; |
mcimadamore@795 | 151 | |
duke@1 | 152 | /** Switch: -complexinference option set? |
duke@1 | 153 | */ |
duke@1 | 154 | boolean complexInference; |
duke@1 | 155 | |
jjg@398 | 156 | /** Character for synthetic names |
jjg@398 | 157 | */ |
jjg@398 | 158 | char syntheticNameChar; |
jjg@398 | 159 | |
duke@1 | 160 | /** A table mapping flat names of all compiled classes in this run to their |
duke@1 | 161 | * symbols; maintained from outside. |
duke@1 | 162 | */ |
duke@1 | 163 | public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>(); |
duke@1 | 164 | |
duke@1 | 165 | /** A handler for messages about deprecated usage. |
duke@1 | 166 | */ |
duke@1 | 167 | private MandatoryWarningHandler deprecationHandler; |
duke@1 | 168 | |
duke@1 | 169 | /** A handler for messages about unchecked or unsafe usage. |
duke@1 | 170 | */ |
duke@1 | 171 | private MandatoryWarningHandler uncheckedHandler; |
duke@1 | 172 | |
jjg@582 | 173 | /** A handler for messages about using proprietary API. |
jjg@377 | 174 | */ |
jjg@377 | 175 | private MandatoryWarningHandler sunApiHandler; |
duke@1 | 176 | |
mcimadamore@852 | 177 | /** A handler for deferred lint warnings. |
mcimadamore@852 | 178 | */ |
mcimadamore@852 | 179 | private DeferredLintHandler deferredLintHandler; |
mcimadamore@852 | 180 | |
duke@1 | 181 | /* ************************************************************************* |
duke@1 | 182 | * Errors and Warnings |
duke@1 | 183 | **************************************************************************/ |
duke@1 | 184 | |
duke@1 | 185 | Lint setLint(Lint newLint) { |
duke@1 | 186 | Lint prev = lint; |
duke@1 | 187 | lint = newLint; |
duke@1 | 188 | return prev; |
duke@1 | 189 | } |
duke@1 | 190 | |
mcimadamore@852 | 191 | DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) { |
mcimadamore@852 | 192 | DeferredLintHandler prev = deferredLintHandler; |
mcimadamore@852 | 193 | deferredLintHandler = newDeferredLintHandler; |
mcimadamore@852 | 194 | return prev; |
mcimadamore@852 | 195 | } |
mcimadamore@852 | 196 | |
mcimadamore@795 | 197 | MethodSymbol setMethod(MethodSymbol newMethod) { |
mcimadamore@795 | 198 | MethodSymbol prev = method; |
mcimadamore@795 | 199 | method = newMethod; |
mcimadamore@795 | 200 | return prev; |
mcimadamore@795 | 201 | } |
mcimadamore@795 | 202 | |
duke@1 | 203 | /** Warn about deprecated symbol. |
duke@1 | 204 | * @param pos Position to be used for error reporting. |
duke@1 | 205 | * @param sym The deprecated symbol. |
duke@1 | 206 | */ |
duke@1 | 207 | void warnDeprecated(DiagnosticPosition pos, Symbol sym) { |
duke@1 | 208 | if (!lint.isSuppressed(LintCategory.DEPRECATION)) |
duke@1 | 209 | deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location()); |
duke@1 | 210 | } |
duke@1 | 211 | |
duke@1 | 212 | /** Warn about unchecked operation. |
duke@1 | 213 | * @param pos Position to be used for error reporting. |
duke@1 | 214 | * @param msg A string describing the problem. |
duke@1 | 215 | */ |
duke@1 | 216 | public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) { |
duke@1 | 217 | if (!lint.isSuppressed(LintCategory.UNCHECKED)) |
duke@1 | 218 | uncheckedHandler.report(pos, msg, args); |
duke@1 | 219 | } |
duke@1 | 220 | |
mcimadamore@580 | 221 | /** Warn about unsafe vararg method decl. |
mcimadamore@580 | 222 | * @param pos Position to be used for error reporting. |
mcimadamore@580 | 223 | * @param sym The deprecated symbol. |
mcimadamore@580 | 224 | */ |
mcimadamore@795 | 225 | void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) { |
mcimadamore@795 | 226 | if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs) |
mcimadamore@795 | 227 | log.warning(LintCategory.VARARGS, pos, key, args); |
mcimadamore@580 | 228 | } |
mcimadamore@580 | 229 | |
jjg@582 | 230 | /** Warn about using proprietary API. |
jjg@377 | 231 | * @param pos Position to be used for error reporting. |
jjg@377 | 232 | * @param msg A string describing the problem. |
jjg@377 | 233 | */ |
jjg@377 | 234 | public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) { |
jjg@377 | 235 | if (!lint.isSuppressed(LintCategory.SUNAPI)) |
jjg@377 | 236 | sunApiHandler.report(pos, msg, args); |
jjg@377 | 237 | } |
jjg@377 | 238 | |
jjg@505 | 239 | public void warnStatic(DiagnosticPosition pos, String msg, Object... args) { |
jjg@505 | 240 | if (lint.isEnabled(LintCategory.STATIC)) |
jjg@612 | 241 | log.warning(LintCategory.STATIC, pos, msg, args); |
jjg@505 | 242 | } |
jjg@505 | 243 | |
duke@1 | 244 | /** |
duke@1 | 245 | * Report any deferred diagnostics. |
duke@1 | 246 | */ |
duke@1 | 247 | public void reportDeferredDiagnostics() { |
duke@1 | 248 | deprecationHandler.reportDeferredDiagnostic(); |
duke@1 | 249 | uncheckedHandler.reportDeferredDiagnostic(); |
jjg@377 | 250 | sunApiHandler.reportDeferredDiagnostic(); |
duke@1 | 251 | } |
duke@1 | 252 | |
duke@1 | 253 | |
duke@1 | 254 | /** Report a failure to complete a class. |
duke@1 | 255 | * @param pos Position to be used for error reporting. |
duke@1 | 256 | * @param ex The failure to report. |
duke@1 | 257 | */ |
duke@1 | 258 | public Type completionError(DiagnosticPosition pos, CompletionFailure ex) { |
jjg@12 | 259 | log.error(pos, "cant.access", ex.sym, ex.getDetailValue()); |
jjg@576 | 260 | if (ex instanceof ClassReader.BadClassFile |
jjg@576 | 261 | && !suppressAbortOnBadClassFile) throw new Abort(); |
duke@1 | 262 | else return syms.errType; |
duke@1 | 263 | } |
duke@1 | 264 | |
duke@1 | 265 | /** Report a type error. |
duke@1 | 266 | * @param pos Position to be used for error reporting. |
duke@1 | 267 | * @param problem A string describing the error. |
duke@1 | 268 | * @param found The type that was found. |
duke@1 | 269 | * @param req The type that was required. |
duke@1 | 270 | */ |
duke@1 | 271 | Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) { |
duke@1 | 272 | log.error(pos, "prob.found.req", |
duke@1 | 273 | problem, found, req); |
jjg@110 | 274 | return types.createErrorType(found); |
duke@1 | 275 | } |
duke@1 | 276 | |
duke@1 | 277 | Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) { |
duke@1 | 278 | log.error(pos, "prob.found.req.1", problem, found, req, explanation); |
jjg@110 | 279 | return types.createErrorType(found); |
duke@1 | 280 | } |
duke@1 | 281 | |
duke@1 | 282 | /** Report an error that wrong type tag was found. |
duke@1 | 283 | * @param pos Position to be used for error reporting. |
duke@1 | 284 | * @param required An internationalized string describing the type tag |
duke@1 | 285 | * required. |
duke@1 | 286 | * @param found The type that was found. |
duke@1 | 287 | */ |
duke@1 | 288 | Type typeTagError(DiagnosticPosition pos, Object required, Object found) { |
jrose@267 | 289 | // this error used to be raised by the parser, |
jrose@267 | 290 | // but has been delayed to this point: |
jrose@267 | 291 | if (found instanceof Type && ((Type)found).tag == VOID) { |
jrose@267 | 292 | log.error(pos, "illegal.start.of.type"); |
jrose@267 | 293 | return syms.errType; |
jrose@267 | 294 | } |
duke@1 | 295 | log.error(pos, "type.found.req", found, required); |
jjg@110 | 296 | return types.createErrorType(found instanceof Type ? (Type)found : syms.errType); |
duke@1 | 297 | } |
duke@1 | 298 | |
duke@1 | 299 | /** Report an error that symbol cannot be referenced before super |
duke@1 | 300 | * has been called. |
duke@1 | 301 | * @param pos Position to be used for error reporting. |
duke@1 | 302 | * @param sym The referenced symbol. |
duke@1 | 303 | */ |
duke@1 | 304 | void earlyRefError(DiagnosticPosition pos, Symbol sym) { |
duke@1 | 305 | log.error(pos, "cant.ref.before.ctor.called", sym); |
duke@1 | 306 | } |
duke@1 | 307 | |
duke@1 | 308 | /** Report duplicate declaration error. |
duke@1 | 309 | */ |
duke@1 | 310 | void duplicateError(DiagnosticPosition pos, Symbol sym) { |
duke@1 | 311 | if (!sym.type.isErroneous()) { |
mcimadamore@1085 | 312 | Symbol location = sym.location(); |
mcimadamore@1085 | 313 | if (location.kind == MTH && |
mcimadamore@1085 | 314 | ((MethodSymbol)location).isStaticOrInstanceInit()) { |
mcimadamore@1085 | 315 | log.error(pos, "already.defined.in.clinit", kindName(sym), sym, |
mcimadamore@1085 | 316 | kindName(sym.location()), kindName(sym.location().enclClass()), |
mcimadamore@1085 | 317 | sym.location().enclClass()); |
mcimadamore@1085 | 318 | } else { |
mcimadamore@1085 | 319 | log.error(pos, "already.defined", kindName(sym), sym, |
mcimadamore@1085 | 320 | kindName(sym.location()), sym.location()); |
mcimadamore@1085 | 321 | } |
duke@1 | 322 | } |
duke@1 | 323 | } |
duke@1 | 324 | |
duke@1 | 325 | /** Report array/varargs duplicate declaration |
duke@1 | 326 | */ |
duke@1 | 327 | void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) { |
duke@1 | 328 | if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) { |
duke@1 | 329 | log.error(pos, "array.and.varargs", sym1, sym2, sym2.location()); |
duke@1 | 330 | } |
duke@1 | 331 | } |
duke@1 | 332 | |
duke@1 | 333 | /* ************************************************************************ |
duke@1 | 334 | * duplicate declaration checking |
duke@1 | 335 | *************************************************************************/ |
duke@1 | 336 | |
duke@1 | 337 | /** Check that variable does not hide variable with same name in |
duke@1 | 338 | * immediately enclosing local scope. |
duke@1 | 339 | * @param pos Position for error reporting. |
duke@1 | 340 | * @param v The symbol. |
duke@1 | 341 | * @param s The scope. |
duke@1 | 342 | */ |
duke@1 | 343 | void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) { |
duke@1 | 344 | if (s.next != null) { |
duke@1 | 345 | for (Scope.Entry e = s.next.lookup(v.name); |
duke@1 | 346 | e.scope != null && e.sym.owner == v.owner; |
duke@1 | 347 | e = e.next()) { |
duke@1 | 348 | if (e.sym.kind == VAR && |
duke@1 | 349 | (e.sym.owner.kind & (VAR | MTH)) != 0 && |
duke@1 | 350 | v.name != names.error) { |
duke@1 | 351 | duplicateError(pos, e.sym); |
duke@1 | 352 | return; |
duke@1 | 353 | } |
duke@1 | 354 | } |
duke@1 | 355 | } |
duke@1 | 356 | } |
duke@1 | 357 | |
duke@1 | 358 | /** Check that a class or interface does not hide a class or |
duke@1 | 359 | * interface with same name in immediately enclosing local scope. |
duke@1 | 360 | * @param pos Position for error reporting. |
duke@1 | 361 | * @param c The symbol. |
duke@1 | 362 | * @param s The scope. |
duke@1 | 363 | */ |
duke@1 | 364 | void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) { |
duke@1 | 365 | if (s.next != null) { |
duke@1 | 366 | for (Scope.Entry e = s.next.lookup(c.name); |
duke@1 | 367 | e.scope != null && e.sym.owner == c.owner; |
duke@1 | 368 | e = e.next()) { |
mcimadamore@639 | 369 | if (e.sym.kind == TYP && e.sym.type.tag != TYPEVAR && |
duke@1 | 370 | (e.sym.owner.kind & (VAR | MTH)) != 0 && |
duke@1 | 371 | c.name != names.error) { |
duke@1 | 372 | duplicateError(pos, e.sym); |
duke@1 | 373 | return; |
duke@1 | 374 | } |
duke@1 | 375 | } |
duke@1 | 376 | } |
duke@1 | 377 | } |
duke@1 | 378 | |
duke@1 | 379 | /** Check that class does not have the same name as one of |
duke@1 | 380 | * its enclosing classes, or as a class defined in its enclosing scope. |
duke@1 | 381 | * return true if class is unique in its enclosing scope. |
duke@1 | 382 | * @param pos Position for error reporting. |
duke@1 | 383 | * @param name The class name. |
duke@1 | 384 | * @param s The enclosing scope. |
duke@1 | 385 | */ |
duke@1 | 386 | boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) { |
duke@1 | 387 | for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) { |
duke@1 | 388 | if (e.sym.kind == TYP && e.sym.name != names.error) { |
duke@1 | 389 | duplicateError(pos, e.sym); |
duke@1 | 390 | return false; |
duke@1 | 391 | } |
duke@1 | 392 | } |
duke@1 | 393 | for (Symbol sym = s.owner; sym != null; sym = sym.owner) { |
duke@1 | 394 | if (sym.kind == TYP && sym.name == name && sym.name != names.error) { |
duke@1 | 395 | duplicateError(pos, sym); |
duke@1 | 396 | return true; |
duke@1 | 397 | } |
duke@1 | 398 | } |
duke@1 | 399 | return true; |
duke@1 | 400 | } |
duke@1 | 401 | |
duke@1 | 402 | /* ************************************************************************* |
duke@1 | 403 | * Class name generation |
duke@1 | 404 | **************************************************************************/ |
duke@1 | 405 | |
duke@1 | 406 | /** Return name of local class. |
duke@1 | 407 | * This is of the form <enclClass> $ n <classname> |
duke@1 | 408 | * where |
duke@1 | 409 | * enclClass is the flat name of the enclosing class, |
duke@1 | 410 | * classname is the simple name of the local class |
duke@1 | 411 | */ |
duke@1 | 412 | Name localClassName(ClassSymbol c) { |
duke@1 | 413 | for (int i=1; ; i++) { |
duke@1 | 414 | Name flatname = names. |
duke@1 | 415 | fromString("" + c.owner.enclClass().flatname + |
jjg@398 | 416 | syntheticNameChar + i + |
duke@1 | 417 | c.name); |
duke@1 | 418 | if (compiled.get(flatname) == null) return flatname; |
duke@1 | 419 | } |
duke@1 | 420 | } |
duke@1 | 421 | |
duke@1 | 422 | /* ************************************************************************* |
duke@1 | 423 | * Type Checking |
duke@1 | 424 | **************************************************************************/ |
duke@1 | 425 | |
duke@1 | 426 | /** Check that a given type is assignable to a given proto-type. |
duke@1 | 427 | * If it is, return the type, otherwise return errType. |
duke@1 | 428 | * @param pos Position to be used for error reporting. |
duke@1 | 429 | * @param found The type that was found. |
duke@1 | 430 | * @param req The type that was required. |
duke@1 | 431 | */ |
duke@1 | 432 | Type checkType(DiagnosticPosition pos, Type found, Type req) { |
darcy@609 | 433 | return checkType(pos, found, req, "incompatible.types"); |
darcy@609 | 434 | } |
darcy@609 | 435 | |
darcy@609 | 436 | Type checkType(DiagnosticPosition pos, Type found, Type req, String errKey) { |
duke@1 | 437 | if (req.tag == ERROR) |
duke@1 | 438 | return req; |
mcimadamore@536 | 439 | if (found.tag == FORALL) |
mcimadamore@536 | 440 | return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req)); |
duke@1 | 441 | if (req.tag == NONE) |
duke@1 | 442 | return found; |
duke@1 | 443 | if (types.isAssignable(found, req, convertWarner(pos, found, req))) |
duke@1 | 444 | return found; |
duke@1 | 445 | if (found.tag <= DOUBLE && req.tag <= DOUBLE) |
mcimadamore@89 | 446 | return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req); |
duke@1 | 447 | if (found.isSuperBound()) { |
duke@1 | 448 | log.error(pos, "assignment.from.super-bound", found); |
jjg@110 | 449 | return types.createErrorType(found); |
duke@1 | 450 | } |
duke@1 | 451 | if (req.isExtendsBound()) { |
duke@1 | 452 | log.error(pos, "assignment.to.extends-bound", req); |
jjg@110 | 453 | return types.createErrorType(found); |
duke@1 | 454 | } |
darcy@609 | 455 | return typeError(pos, diags.fragment(errKey), found, req); |
duke@1 | 456 | } |
duke@1 | 457 | |
duke@1 | 458 | /** Instantiate polymorphic type to some prototype, unless |
duke@1 | 459 | * prototype is `anyPoly' in which case polymorphic type |
duke@1 | 460 | * is returned unchanged. |
duke@1 | 461 | */ |
mcimadamore@383 | 462 | Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException { |
duke@1 | 463 | if (pt == Infer.anyPoly && complexInference) { |
duke@1 | 464 | return t; |
duke@1 | 465 | } else if (pt == Infer.anyPoly || pt.tag == NONE) { |
duke@1 | 466 | Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType; |
duke@1 | 467 | return instantiatePoly(pos, t, newpt, warn); |
duke@1 | 468 | } else if (pt.tag == ERROR) { |
duke@1 | 469 | return pt; |
duke@1 | 470 | } else { |
mcimadamore@536 | 471 | try { |
mcimadamore@536 | 472 | return infer.instantiateExpr(t, pt, warn); |
mcimadamore@536 | 473 | } catch (Infer.NoInstanceException ex) { |
mcimadamore@536 | 474 | if (ex.isAmbiguous) { |
mcimadamore@536 | 475 | JCDiagnostic d = ex.getDiagnostic(); |
mcimadamore@536 | 476 | log.error(pos, |
mcimadamore@536 | 477 | "undetermined.type" + (d!=null ? ".1" : ""), |
mcimadamore@536 | 478 | t, d); |
mcimadamore@536 | 479 | return types.createErrorType(pt); |
mcimadamore@536 | 480 | } else { |
mcimadamore@536 | 481 | JCDiagnostic d = ex.getDiagnostic(); |
mcimadamore@536 | 482 | return typeError(pos, |
mcimadamore@536 | 483 | diags.fragment("incompatible.types" + (d!=null ? ".1" : ""), d), |
mcimadamore@536 | 484 | t, pt); |
mcimadamore@536 | 485 | } |
mcimadamore@536 | 486 | } catch (Infer.InvalidInstanceException ex) { |
mcimadamore@536 | 487 | JCDiagnostic d = ex.getDiagnostic(); |
mcimadamore@536 | 488 | log.error(pos, "invalid.inferred.types", t.tvars, d); |
mcimadamore@536 | 489 | return types.createErrorType(pt); |
mcimadamore@536 | 490 | } |
duke@1 | 491 | } |
mcimadamore@536 | 492 | } |
duke@1 | 493 | |
duke@1 | 494 | /** Check that a given type can be cast to a given target type. |
duke@1 | 495 | * Return the result of the cast. |
duke@1 | 496 | * @param pos Position to be used for error reporting. |
duke@1 | 497 | * @param found The type that is being cast. |
duke@1 | 498 | * @param req The target type of the cast. |
duke@1 | 499 | */ |
duke@1 | 500 | Type checkCastable(DiagnosticPosition pos, Type found, Type req) { |
duke@1 | 501 | if (found.tag == FORALL) { |
duke@1 | 502 | instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req)); |
duke@1 | 503 | return req; |
duke@1 | 504 | } else if (types.isCastable(found, req, castWarner(pos, found, req))) { |
duke@1 | 505 | return req; |
duke@1 | 506 | } else { |
duke@1 | 507 | return typeError(pos, |
mcimadamore@89 | 508 | diags.fragment("inconvertible.types"), |
duke@1 | 509 | found, req); |
duke@1 | 510 | } |
duke@1 | 511 | } |
duke@1 | 512 | //where |
duke@1 | 513 | /** Is type a type variable, or a (possibly multi-dimensional) array of |
duke@1 | 514 | * type variables? |
duke@1 | 515 | */ |
duke@1 | 516 | boolean isTypeVar(Type t) { |
duke@1 | 517 | return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t)); |
duke@1 | 518 | } |
duke@1 | 519 | |
duke@1 | 520 | /** Check that a type is within some bounds. |
duke@1 | 521 | * |
duke@1 | 522 | * Used in TypeApply to verify that, e.g., X in V<X> is a valid |
duke@1 | 523 | * type argument. |
duke@1 | 524 | * @param pos Position to be used for error reporting. |
duke@1 | 525 | * @param a The type that should be bounded by bs. |
duke@1 | 526 | * @param bs The bound. |
duke@1 | 527 | */ |
mcimadamore@1216 | 528 | private boolean checkExtends(Type a, Type bound) { |
mcimadamore@154 | 529 | if (a.isUnbound()) { |
mcimadamore@821 | 530 | return true; |
mcimadamore@154 | 531 | } else if (a.tag != WILDCARD) { |
mcimadamore@154 | 532 | a = types.upperBound(a); |
mcimadamore@1216 | 533 | return types.isSubtype(a, bound); |
mcimadamore@154 | 534 | } else if (a.isExtendsBound()) { |
mcimadamore@1216 | 535 | return types.isCastable(bound, types.upperBound(a), Warner.noWarnings); |
mcimadamore@154 | 536 | } else if (a.isSuperBound()) { |
mcimadamore@1216 | 537 | return !types.notSoftSubtype(types.lowerBound(a), bound); |
mcimadamore@154 | 538 | } |
mcimadamore@821 | 539 | return true; |
mcimadamore@154 | 540 | } |
duke@1 | 541 | |
duke@1 | 542 | /** Check that type is different from 'void'. |
duke@1 | 543 | * @param pos Position to be used for error reporting. |
duke@1 | 544 | * @param t The type to be checked. |
duke@1 | 545 | */ |
duke@1 | 546 | Type checkNonVoid(DiagnosticPosition pos, Type t) { |
duke@1 | 547 | if (t.tag == VOID) { |
duke@1 | 548 | log.error(pos, "void.not.allowed.here"); |
jjg@110 | 549 | return types.createErrorType(t); |
duke@1 | 550 | } else { |
duke@1 | 551 | return t; |
duke@1 | 552 | } |
duke@1 | 553 | } |
duke@1 | 554 | |
duke@1 | 555 | /** Check that type is a class or interface type. |
duke@1 | 556 | * @param pos Position to be used for error reporting. |
duke@1 | 557 | * @param t The type to be checked. |
duke@1 | 558 | */ |
duke@1 | 559 | Type checkClassType(DiagnosticPosition pos, Type t) { |
duke@1 | 560 | if (t.tag != CLASS && t.tag != ERROR) |
duke@1 | 561 | return typeTagError(pos, |
mcimadamore@89 | 562 | diags.fragment("type.req.class"), |
duke@1 | 563 | (t.tag == TYPEVAR) |
mcimadamore@89 | 564 | ? diags.fragment("type.parameter", t) |
duke@1 | 565 | : t); |
duke@1 | 566 | else |
duke@1 | 567 | return t; |
duke@1 | 568 | } |
duke@1 | 569 | |
duke@1 | 570 | /** Check that type is a class or interface type. |
duke@1 | 571 | * @param pos Position to be used for error reporting. |
duke@1 | 572 | * @param t The type to be checked. |
duke@1 | 573 | * @param noBounds True if type bounds are illegal here. |
duke@1 | 574 | */ |
duke@1 | 575 | Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) { |
duke@1 | 576 | t = checkClassType(pos, t); |
duke@1 | 577 | if (noBounds && t.isParameterized()) { |
duke@1 | 578 | List<Type> args = t.getTypeArguments(); |
duke@1 | 579 | while (args.nonEmpty()) { |
duke@1 | 580 | if (args.head.tag == WILDCARD) |
duke@1 | 581 | return typeTagError(pos, |
jjg@598 | 582 | diags.fragment("type.req.exact"), |
duke@1 | 583 | args.head); |
duke@1 | 584 | args = args.tail; |
duke@1 | 585 | } |
duke@1 | 586 | } |
duke@1 | 587 | return t; |
duke@1 | 588 | } |
duke@1 | 589 | |
duke@1 | 590 | /** Check that type is a reifiable class, interface or array type. |
duke@1 | 591 | * @param pos Position to be used for error reporting. |
duke@1 | 592 | * @param t The type to be checked. |
duke@1 | 593 | */ |
duke@1 | 594 | Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) { |
duke@1 | 595 | if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) { |
duke@1 | 596 | return typeTagError(pos, |
mcimadamore@89 | 597 | diags.fragment("type.req.class.array"), |
duke@1 | 598 | t); |
duke@1 | 599 | } else if (!types.isReifiable(t)) { |
duke@1 | 600 | log.error(pos, "illegal.generic.type.for.instof"); |
jjg@110 | 601 | return types.createErrorType(t); |
duke@1 | 602 | } else { |
duke@1 | 603 | return t; |
duke@1 | 604 | } |
duke@1 | 605 | } |
duke@1 | 606 | |
duke@1 | 607 | /** Check that type is a reference type, i.e. a class, interface or array type |
duke@1 | 608 | * or a type variable. |
duke@1 | 609 | * @param pos Position to be used for error reporting. |
duke@1 | 610 | * @param t The type to be checked. |
duke@1 | 611 | */ |
duke@1 | 612 | Type checkRefType(DiagnosticPosition pos, Type t) { |
duke@1 | 613 | switch (t.tag) { |
duke@1 | 614 | case CLASS: |
duke@1 | 615 | case ARRAY: |
duke@1 | 616 | case TYPEVAR: |
duke@1 | 617 | case WILDCARD: |
duke@1 | 618 | case ERROR: |
duke@1 | 619 | return t; |
duke@1 | 620 | default: |
duke@1 | 621 | return typeTagError(pos, |
mcimadamore@89 | 622 | diags.fragment("type.req.ref"), |
duke@1 | 623 | t); |
duke@1 | 624 | } |
duke@1 | 625 | } |
duke@1 | 626 | |
jrose@267 | 627 | /** Check that each type is a reference type, i.e. a class, interface or array type |
jrose@267 | 628 | * or a type variable. |
jrose@267 | 629 | * @param trees Original trees, used for error reporting. |
jrose@267 | 630 | * @param types The types to be checked. |
jrose@267 | 631 | */ |
jrose@267 | 632 | List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) { |
jrose@267 | 633 | List<JCExpression> tl = trees; |
jrose@267 | 634 | for (List<Type> l = types; l.nonEmpty(); l = l.tail) { |
jrose@267 | 635 | l.head = checkRefType(tl.head.pos(), l.head); |
jrose@267 | 636 | tl = tl.tail; |
jrose@267 | 637 | } |
jrose@267 | 638 | return types; |
jrose@267 | 639 | } |
jrose@267 | 640 | |
duke@1 | 641 | /** Check that type is a null or reference type. |
duke@1 | 642 | * @param pos Position to be used for error reporting. |
duke@1 | 643 | * @param t The type to be checked. |
duke@1 | 644 | */ |
duke@1 | 645 | Type checkNullOrRefType(DiagnosticPosition pos, Type t) { |
duke@1 | 646 | switch (t.tag) { |
duke@1 | 647 | case CLASS: |
duke@1 | 648 | case ARRAY: |
duke@1 | 649 | case TYPEVAR: |
duke@1 | 650 | case WILDCARD: |
duke@1 | 651 | case BOT: |
duke@1 | 652 | case ERROR: |
duke@1 | 653 | return t; |
duke@1 | 654 | default: |
duke@1 | 655 | return typeTagError(pos, |
mcimadamore@89 | 656 | diags.fragment("type.req.ref"), |
duke@1 | 657 | t); |
duke@1 | 658 | } |
duke@1 | 659 | } |
duke@1 | 660 | |
duke@1 | 661 | /** Check that flag set does not contain elements of two conflicting sets. s |
duke@1 | 662 | * Return true if it doesn't. |
duke@1 | 663 | * @param pos Position to be used for error reporting. |
duke@1 | 664 | * @param flags The set of flags to be checked. |
duke@1 | 665 | * @param set1 Conflicting flags set #1. |
duke@1 | 666 | * @param set2 Conflicting flags set #2. |
duke@1 | 667 | */ |
duke@1 | 668 | boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) { |
duke@1 | 669 | if ((flags & set1) != 0 && (flags & set2) != 0) { |
duke@1 | 670 | log.error(pos, |
duke@1 | 671 | "illegal.combination.of.modifiers", |
mcimadamore@80 | 672 | asFlagSet(TreeInfo.firstFlag(flags & set1)), |
mcimadamore@80 | 673 | asFlagSet(TreeInfo.firstFlag(flags & set2))); |
duke@1 | 674 | return false; |
duke@1 | 675 | } else |
duke@1 | 676 | return true; |
duke@1 | 677 | } |
duke@1 | 678 | |
mcimadamore@914 | 679 | /** Check that usage of diamond operator is correct (i.e. diamond should not |
mcimadamore@914 | 680 | * be used with non-generic classes or in anonymous class creation expressions) |
mcimadamore@537 | 681 | */ |
mcimadamore@914 | 682 | Type checkDiamond(JCNewClass tree, Type t) { |
mcimadamore@914 | 683 | if (!TreeInfo.isDiamond(tree) || |
mcimadamore@914 | 684 | t.isErroneous()) { |
mcimadamore@914 | 685 | return checkClassType(tree.clazz.pos(), t, true); |
mcimadamore@914 | 686 | } else if (tree.def != null) { |
mcimadamore@914 | 687 | log.error(tree.clazz.pos(), |
mcimadamore@914 | 688 | "cant.apply.diamond.1", |
mcimadamore@914 | 689 | t, diags.fragment("diamond.and.anon.class", t)); |
mcimadamore@914 | 690 | return types.createErrorType(t); |
mcimadamore@948 | 691 | } else if (t.tsym.type.getTypeArguments().isEmpty()) { |
mcimadamore@914 | 692 | log.error(tree.clazz.pos(), |
mcimadamore@914 | 693 | "cant.apply.diamond.1", |
mcimadamore@914 | 694 | t, diags.fragment("diamond.non.generic", t)); |
mcimadamore@914 | 695 | return types.createErrorType(t); |
mcimadamore@993 | 696 | } else if (tree.typeargs != null && |
mcimadamore@993 | 697 | tree.typeargs.nonEmpty()) { |
mcimadamore@993 | 698 | log.error(tree.clazz.pos(), |
mcimadamore@993 | 699 | "cant.apply.diamond.1", |
mcimadamore@993 | 700 | t, diags.fragment("diamond.and.explicit.params", t)); |
mcimadamore@993 | 701 | return types.createErrorType(t); |
mcimadamore@914 | 702 | } else { |
mcimadamore@914 | 703 | return t; |
mcimadamore@537 | 704 | } |
mcimadamore@537 | 705 | } |
mcimadamore@537 | 706 | |
mcimadamore@795 | 707 | void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) { |
mcimadamore@580 | 708 | MethodSymbol m = tree.sym; |
mcimadamore@795 | 709 | if (!allowSimplifiedVarargs) return; |
mcimadamore@795 | 710 | boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null; |
mcimadamore@795 | 711 | Type varargElemType = null; |
mcimadamore@580 | 712 | if (m.isVarArgs()) { |
mcimadamore@795 | 713 | varargElemType = types.elemtype(tree.params.last().type); |
mcimadamore@795 | 714 | } |
mcimadamore@795 | 715 | if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) { |
mcimadamore@795 | 716 | if (varargElemType != null) { |
mcimadamore@795 | 717 | log.error(tree, |
mcimadamore@795 | 718 | "varargs.invalid.trustme.anno", |
mcimadamore@795 | 719 | syms.trustMeType.tsym, |
mcimadamore@795 | 720 | diags.fragment("varargs.trustme.on.virtual.varargs", m)); |
mcimadamore@795 | 721 | } else { |
mcimadamore@795 | 722 | log.error(tree, |
mcimadamore@795 | 723 | "varargs.invalid.trustme.anno", |
mcimadamore@795 | 724 | syms.trustMeType.tsym, |
mcimadamore@795 | 725 | diags.fragment("varargs.trustme.on.non.varargs.meth", m)); |
mcimadamore@580 | 726 | } |
mcimadamore@795 | 727 | } else if (hasTrustMeAnno && varargElemType != null && |
mcimadamore@795 | 728 | types.isReifiable(varargElemType)) { |
mcimadamore@795 | 729 | warnUnsafeVararg(tree, |
mcimadamore@795 | 730 | "varargs.redundant.trustme.anno", |
mcimadamore@795 | 731 | syms.trustMeType.tsym, |
mcimadamore@795 | 732 | diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType)); |
mcimadamore@795 | 733 | } |
mcimadamore@795 | 734 | else if (!hasTrustMeAnno && varargElemType != null && |
mcimadamore@795 | 735 | !types.isReifiable(varargElemType)) { |
mcimadamore@795 | 736 | warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType); |
mcimadamore@580 | 737 | } |
mcimadamore@580 | 738 | } |
mcimadamore@795 | 739 | //where |
mcimadamore@795 | 740 | private boolean isTrustMeAllowedOnMethod(Symbol s) { |
mcimadamore@795 | 741 | return (s.flags() & VARARGS) != 0 && |
mcimadamore@795 | 742 | (s.isConstructor() || |
mcimadamore@795 | 743 | (s.flags() & (STATIC | FINAL)) != 0); |
mcimadamore@795 | 744 | } |
mcimadamore@580 | 745 | |
mcimadamore@547 | 746 | /** |
mcimadamore@547 | 747 | * Check that vararg method call is sound |
mcimadamore@547 | 748 | * @param pos Position to be used for error reporting. |
mcimadamore@547 | 749 | * @param argtypes Actual arguments supplied to vararg method. |
mcimadamore@547 | 750 | */ |
mcimadamore@795 | 751 | void checkVararg(DiagnosticPosition pos, List<Type> argtypes, Symbol msym) { |
mcimadamore@547 | 752 | Type argtype = argtypes.last(); |
mcimadamore@795 | 753 | if (!types.isReifiable(argtype) && |
mcimadamore@795 | 754 | (!allowSimplifiedVarargs || |
mcimadamore@795 | 755 | msym.attribute(syms.trustMeType.tsym) == null || |
mcimadamore@795 | 756 | !isTrustMeAllowedOnMethod(msym))) { |
mcimadamore@547 | 757 | warnUnchecked(pos, |
mcimadamore@547 | 758 | "unchecked.generic.array.creation", |
mcimadamore@547 | 759 | argtype); |
mcimadamore@580 | 760 | } |
mcimadamore@547 | 761 | } |
mcimadamore@547 | 762 | |
mcimadamore@821 | 763 | /** |
mcimadamore@821 | 764 | * Check that type 't' is a valid instantiation of a generic class |
mcimadamore@821 | 765 | * (see JLS 4.5) |
mcimadamore@821 | 766 | * |
mcimadamore@821 | 767 | * @param t class type to be checked |
mcimadamore@821 | 768 | * @return true if 't' is well-formed |
mcimadamore@821 | 769 | */ |
mcimadamore@821 | 770 | public boolean checkValidGenericType(Type t) { |
mcimadamore@821 | 771 | return firstIncompatibleTypeArg(t) == null; |
mcimadamore@821 | 772 | } |
mcimadamore@821 | 773 | //WHERE |
mcimadamore@821 | 774 | private Type firstIncompatibleTypeArg(Type type) { |
mcimadamore@821 | 775 | List<Type> formals = type.tsym.type.allparams(); |
mcimadamore@821 | 776 | List<Type> actuals = type.allparams(); |
mcimadamore@821 | 777 | List<Type> args = type.getTypeArguments(); |
mcimadamore@821 | 778 | List<Type> forms = type.tsym.type.getTypeArguments(); |
mcimadamore@1216 | 779 | ListBuffer<Type> bounds_buf = new ListBuffer<Type>(); |
mcimadamore@821 | 780 | |
mcimadamore@821 | 781 | // For matching pairs of actual argument types `a' and |
mcimadamore@821 | 782 | // formal type parameters with declared bound `b' ... |
mcimadamore@821 | 783 | while (args.nonEmpty() && forms.nonEmpty()) { |
mcimadamore@821 | 784 | // exact type arguments needs to know their |
mcimadamore@821 | 785 | // bounds (for upper and lower bound |
mcimadamore@1216 | 786 | // calculations). So we create new bounds where |
mcimadamore@1216 | 787 | // type-parameters are replaced with actuals argument types. |
mcimadamore@1216 | 788 | bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals)); |
mcimadamore@821 | 789 | args = args.tail; |
mcimadamore@821 | 790 | forms = forms.tail; |
mcimadamore@821 | 791 | } |
mcimadamore@821 | 792 | |
mcimadamore@821 | 793 | args = type.getTypeArguments(); |
mcimadamore@821 | 794 | List<Type> tvars_cap = types.substBounds(formals, |
mcimadamore@821 | 795 | formals, |
mcimadamore@821 | 796 | types.capture(type).allparams()); |
mcimadamore@821 | 797 | while (args.nonEmpty() && tvars_cap.nonEmpty()) { |
mcimadamore@821 | 798 | // Let the actual arguments know their bound |
mcimadamore@821 | 799 | args.head.withTypeVar((TypeVar)tvars_cap.head); |
mcimadamore@821 | 800 | args = args.tail; |
mcimadamore@821 | 801 | tvars_cap = tvars_cap.tail; |
mcimadamore@821 | 802 | } |
mcimadamore@821 | 803 | |
mcimadamore@821 | 804 | args = type.getTypeArguments(); |
mcimadamore@1216 | 805 | List<Type> bounds = bounds_buf.toList(); |
mcimadamore@821 | 806 | |
mcimadamore@1216 | 807 | while (args.nonEmpty() && bounds.nonEmpty()) { |
mcimadamore@1216 | 808 | Type actual = args.head; |
mcimadamore@854 | 809 | if (!isTypeArgErroneous(actual) && |
mcimadamore@1216 | 810 | !bounds.head.isErroneous() && |
mcimadamore@1216 | 811 | !checkExtends(actual, bounds.head)) { |
mcimadamore@821 | 812 | return args.head; |
mcimadamore@821 | 813 | } |
mcimadamore@821 | 814 | args = args.tail; |
mcimadamore@1216 | 815 | bounds = bounds.tail; |
mcimadamore@821 | 816 | } |
mcimadamore@821 | 817 | |
mcimadamore@821 | 818 | args = type.getTypeArguments(); |
mcimadamore@1216 | 819 | bounds = bounds_buf.toList(); |
mcimadamore@821 | 820 | |
mcimadamore@821 | 821 | for (Type arg : types.capture(type).getTypeArguments()) { |
mcimadamore@828 | 822 | if (arg.tag == TYPEVAR && |
mcimadamore@828 | 823 | arg.getUpperBound().isErroneous() && |
mcimadamore@1216 | 824 | !bounds.head.isErroneous() && |
mcimadamore@854 | 825 | !isTypeArgErroneous(args.head)) { |
mcimadamore@821 | 826 | return args.head; |
mcimadamore@821 | 827 | } |
mcimadamore@1216 | 828 | bounds = bounds.tail; |
mcimadamore@854 | 829 | args = args.tail; |
mcimadamore@821 | 830 | } |
mcimadamore@821 | 831 | |
mcimadamore@821 | 832 | return null; |
mcimadamore@821 | 833 | } |
mcimadamore@854 | 834 | //where |
mcimadamore@854 | 835 | boolean isTypeArgErroneous(Type t) { |
mcimadamore@854 | 836 | return isTypeArgErroneous.visit(t); |
mcimadamore@854 | 837 | } |
mcimadamore@854 | 838 | |
mcimadamore@854 | 839 | Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() { |
mcimadamore@854 | 840 | public Boolean visitType(Type t, Void s) { |
mcimadamore@854 | 841 | return t.isErroneous(); |
mcimadamore@854 | 842 | } |
mcimadamore@854 | 843 | @Override |
mcimadamore@854 | 844 | public Boolean visitTypeVar(TypeVar t, Void s) { |
mcimadamore@854 | 845 | return visit(t.getUpperBound()); |
mcimadamore@854 | 846 | } |
mcimadamore@854 | 847 | @Override |
mcimadamore@854 | 848 | public Boolean visitCapturedType(CapturedType t, Void s) { |
mcimadamore@854 | 849 | return visit(t.getUpperBound()) || |
mcimadamore@854 | 850 | visit(t.getLowerBound()); |
mcimadamore@854 | 851 | } |
mcimadamore@854 | 852 | @Override |
mcimadamore@854 | 853 | public Boolean visitWildcardType(WildcardType t, Void s) { |
mcimadamore@854 | 854 | return visit(t.type); |
mcimadamore@854 | 855 | } |
mcimadamore@854 | 856 | }; |
mcimadamore@821 | 857 | |
duke@1 | 858 | /** Check that given modifiers are legal for given symbol and |
duke@1 | 859 | * return modifiers together with any implicit modififiers for that symbol. |
duke@1 | 860 | * Warning: we can't use flags() here since this method |
duke@1 | 861 | * is called during class enter, when flags() would cause a premature |
duke@1 | 862 | * completion. |
duke@1 | 863 | * @param pos Position to be used for error reporting. |
duke@1 | 864 | * @param flags The set of modifiers given in a definition. |
duke@1 | 865 | * @param sym The defined symbol. |
duke@1 | 866 | */ |
duke@1 | 867 | long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) { |
duke@1 | 868 | long mask; |
duke@1 | 869 | long implicit = 0; |
duke@1 | 870 | switch (sym.kind) { |
duke@1 | 871 | case VAR: |
duke@1 | 872 | if (sym.owner.kind != TYP) |
duke@1 | 873 | mask = LocalVarFlags; |
duke@1 | 874 | else if ((sym.owner.flags_field & INTERFACE) != 0) |
duke@1 | 875 | mask = implicit = InterfaceVarFlags; |
duke@1 | 876 | else |
duke@1 | 877 | mask = VarFlags; |
duke@1 | 878 | break; |
duke@1 | 879 | case MTH: |
duke@1 | 880 | if (sym.name == names.init) { |
duke@1 | 881 | if ((sym.owner.flags_field & ENUM) != 0) { |
duke@1 | 882 | // enum constructors cannot be declared public or |
duke@1 | 883 | // protected and must be implicitly or explicitly |
duke@1 | 884 | // private |
duke@1 | 885 | implicit = PRIVATE; |
duke@1 | 886 | mask = PRIVATE; |
duke@1 | 887 | } else |
duke@1 | 888 | mask = ConstructorFlags; |
duke@1 | 889 | } else if ((sym.owner.flags_field & INTERFACE) != 0) |
duke@1 | 890 | mask = implicit = InterfaceMethodFlags; |
duke@1 | 891 | else { |
duke@1 | 892 | mask = MethodFlags; |
duke@1 | 893 | } |
duke@1 | 894 | // Imply STRICTFP if owner has STRICTFP set. |
duke@1 | 895 | if (((flags|implicit) & Flags.ABSTRACT) == 0) |
duke@1 | 896 | implicit |= sym.owner.flags_field & STRICTFP; |
duke@1 | 897 | break; |
duke@1 | 898 | case TYP: |
duke@1 | 899 | if (sym.isLocal()) { |
duke@1 | 900 | mask = LocalClassFlags; |
jjg@113 | 901 | if (sym.name.isEmpty()) { // Anonymous class |
duke@1 | 902 | // Anonymous classes in static methods are themselves static; |
duke@1 | 903 | // that's why we admit STATIC here. |
duke@1 | 904 | mask |= STATIC; |
duke@1 | 905 | // JLS: Anonymous classes are final. |
duke@1 | 906 | implicit |= FINAL; |
duke@1 | 907 | } |
duke@1 | 908 | if ((sym.owner.flags_field & STATIC) == 0 && |
duke@1 | 909 | (flags & ENUM) != 0) |
duke@1 | 910 | log.error(pos, "enums.must.be.static"); |
duke@1 | 911 | } else if (sym.owner.kind == TYP) { |
duke@1 | 912 | mask = MemberClassFlags; |
duke@1 | 913 | if (sym.owner.owner.kind == PCK || |
duke@1 | 914 | (sym.owner.flags_field & STATIC) != 0) |
duke@1 | 915 | mask |= STATIC; |
duke@1 | 916 | else if ((flags & ENUM) != 0) |
duke@1 | 917 | log.error(pos, "enums.must.be.static"); |
duke@1 | 918 | // Nested interfaces and enums are always STATIC (Spec ???) |
duke@1 | 919 | if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC; |
duke@1 | 920 | } else { |
duke@1 | 921 | mask = ClassFlags; |
duke@1 | 922 | } |
duke@1 | 923 | // Interfaces are always ABSTRACT |
duke@1 | 924 | if ((flags & INTERFACE) != 0) implicit |= ABSTRACT; |
duke@1 | 925 | |
duke@1 | 926 | if ((flags & ENUM) != 0) { |
duke@1 | 927 | // enums can't be declared abstract or final |
duke@1 | 928 | mask &= ~(ABSTRACT | FINAL); |
duke@1 | 929 | implicit |= implicitEnumFinalFlag(tree); |
duke@1 | 930 | } |
duke@1 | 931 | // Imply STRICTFP if owner has STRICTFP set. |
duke@1 | 932 | implicit |= sym.owner.flags_field & STRICTFP; |
duke@1 | 933 | break; |
duke@1 | 934 | default: |
duke@1 | 935 | throw new AssertionError(); |
duke@1 | 936 | } |
duke@1 | 937 | long illegal = flags & StandardFlags & ~mask; |
duke@1 | 938 | if (illegal != 0) { |
duke@1 | 939 | if ((illegal & INTERFACE) != 0) { |
duke@1 | 940 | log.error(pos, "intf.not.allowed.here"); |
duke@1 | 941 | mask |= INTERFACE; |
duke@1 | 942 | } |
duke@1 | 943 | else { |
duke@1 | 944 | log.error(pos, |
mcimadamore@80 | 945 | "mod.not.allowed.here", asFlagSet(illegal)); |
duke@1 | 946 | } |
duke@1 | 947 | } |
duke@1 | 948 | else if ((sym.kind == TYP || |
duke@1 | 949 | // ISSUE: Disallowing abstract&private is no longer appropriate |
duke@1 | 950 | // in the presence of inner classes. Should it be deleted here? |
duke@1 | 951 | checkDisjoint(pos, flags, |
duke@1 | 952 | ABSTRACT, |
duke@1 | 953 | PRIVATE | STATIC)) |
duke@1 | 954 | && |
duke@1 | 955 | checkDisjoint(pos, flags, |
duke@1 | 956 | ABSTRACT | INTERFACE, |
duke@1 | 957 | FINAL | NATIVE | SYNCHRONIZED) |
duke@1 | 958 | && |
duke@1 | 959 | checkDisjoint(pos, flags, |
duke@1 | 960 | PUBLIC, |
duke@1 | 961 | PRIVATE | PROTECTED) |
duke@1 | 962 | && |
duke@1 | 963 | checkDisjoint(pos, flags, |
duke@1 | 964 | PRIVATE, |
duke@1 | 965 | PUBLIC | PROTECTED) |
duke@1 | 966 | && |
duke@1 | 967 | checkDisjoint(pos, flags, |
duke@1 | 968 | FINAL, |
duke@1 | 969 | VOLATILE) |
duke@1 | 970 | && |
duke@1 | 971 | (sym.kind == TYP || |
duke@1 | 972 | checkDisjoint(pos, flags, |
duke@1 | 973 | ABSTRACT | NATIVE, |
duke@1 | 974 | STRICTFP))) { |
duke@1 | 975 | // skip |
duke@1 | 976 | } |
duke@1 | 977 | return flags & (mask | ~StandardFlags) | implicit; |
duke@1 | 978 | } |
duke@1 | 979 | |
duke@1 | 980 | |
duke@1 | 981 | /** Determine if this enum should be implicitly final. |
duke@1 | 982 | * |
duke@1 | 983 | * If the enum has no specialized enum contants, it is final. |
duke@1 | 984 | * |
duke@1 | 985 | * If the enum does have specialized enum contants, it is |
duke@1 | 986 | * <i>not</i> final. |
duke@1 | 987 | */ |
duke@1 | 988 | private long implicitEnumFinalFlag(JCTree tree) { |
jjg@1127 | 989 | if (!tree.hasTag(CLASSDEF)) return 0; |
duke@1 | 990 | class SpecialTreeVisitor extends JCTree.Visitor { |
duke@1 | 991 | boolean specialized; |
duke@1 | 992 | SpecialTreeVisitor() { |
duke@1 | 993 | this.specialized = false; |
duke@1 | 994 | }; |
duke@1 | 995 | |
jjg@398 | 996 | @Override |
duke@1 | 997 | public void visitTree(JCTree tree) { /* no-op */ } |
duke@1 | 998 | |
jjg@398 | 999 | @Override |
duke@1 | 1000 | public void visitVarDef(JCVariableDecl tree) { |
duke@1 | 1001 | if ((tree.mods.flags & ENUM) != 0) { |
duke@1 | 1002 | if (tree.init instanceof JCNewClass && |
duke@1 | 1003 | ((JCNewClass) tree.init).def != null) { |
duke@1 | 1004 | specialized = true; |
duke@1 | 1005 | } |
duke@1 | 1006 | } |
duke@1 | 1007 | } |
duke@1 | 1008 | } |
duke@1 | 1009 | |
duke@1 | 1010 | SpecialTreeVisitor sts = new SpecialTreeVisitor(); |
duke@1 | 1011 | JCClassDecl cdef = (JCClassDecl) tree; |
duke@1 | 1012 | for (JCTree defs: cdef.defs) { |
duke@1 | 1013 | defs.accept(sts); |
duke@1 | 1014 | if (sts.specialized) return 0; |
duke@1 | 1015 | } |
duke@1 | 1016 | return FINAL; |
duke@1 | 1017 | } |
duke@1 | 1018 | |
duke@1 | 1019 | /* ************************************************************************* |
duke@1 | 1020 | * Type Validation |
duke@1 | 1021 | **************************************************************************/ |
duke@1 | 1022 | |
duke@1 | 1023 | /** Validate a type expression. That is, |
duke@1 | 1024 | * check that all type arguments of a parametric type are within |
duke@1 | 1025 | * their bounds. This must be done in a second phase after type attributon |
duke@1 | 1026 | * since a class might have a subclass as type parameter bound. E.g: |
duke@1 | 1027 | * |
duke@1 | 1028 | * class B<A extends C> { ... } |
duke@1 | 1029 | * class C extends B<C> { ... } |
duke@1 | 1030 | * |
duke@1 | 1031 | * and we can't make sure that the bound is already attributed because |
duke@1 | 1032 | * of possible cycles. |
mcimadamore@638 | 1033 | * |
mcimadamore@638 | 1034 | * Visitor method: Validate a type expression, if it is not null, catching |
duke@1 | 1035 | * and reporting any completion failures. |
duke@1 | 1036 | */ |
mcimadamore@122 | 1037 | void validate(JCTree tree, Env<AttrContext> env) { |
mcimadamore@638 | 1038 | validate(tree, env, true); |
duke@1 | 1039 | } |
mcimadamore@638 | 1040 | void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) { |
mcimadamore@638 | 1041 | new Validator(env).validateTree(tree, checkRaw, true); |
mcimadamore@122 | 1042 | } |
duke@1 | 1043 | |
duke@1 | 1044 | /** Visitor method: Validate a list of type expressions. |
duke@1 | 1045 | */ |
mcimadamore@122 | 1046 | void validate(List<? extends JCTree> trees, Env<AttrContext> env) { |
duke@1 | 1047 | for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail) |
mcimadamore@122 | 1048 | validate(l.head, env); |
duke@1 | 1049 | } |
duke@1 | 1050 | |
duke@1 | 1051 | /** A visitor class for type validation. |
duke@1 | 1052 | */ |
duke@1 | 1053 | class Validator extends JCTree.Visitor { |
duke@1 | 1054 | |
mcimadamore@638 | 1055 | boolean isOuter; |
mcimadamore@638 | 1056 | Env<AttrContext> env; |
mcimadamore@638 | 1057 | |
mcimadamore@638 | 1058 | Validator(Env<AttrContext> env) { |
mcimadamore@638 | 1059 | this.env = env; |
mcimadamore@638 | 1060 | } |
mcimadamore@638 | 1061 | |
jjg@398 | 1062 | @Override |
duke@1 | 1063 | public void visitTypeArray(JCArrayTypeTree tree) { |
mcimadamore@638 | 1064 | tree.elemtype.accept(this); |
duke@1 | 1065 | } |
duke@1 | 1066 | |
jjg@398 | 1067 | @Override |
duke@1 | 1068 | public void visitTypeApply(JCTypeApply tree) { |
duke@1 | 1069 | if (tree.type.tag == CLASS) { |
duke@1 | 1070 | List<JCExpression> args = tree.arguments; |
mcimadamore@158 | 1071 | List<Type> forms = tree.type.tsym.type.getTypeArguments(); |
mcimadamore@821 | 1072 | |
mcimadamore@821 | 1073 | Type incompatibleArg = firstIncompatibleTypeArg(tree.type); |
mcimadamore@821 | 1074 | if (incompatibleArg != null) { |
mcimadamore@821 | 1075 | for (JCTree arg : tree.arguments) { |
mcimadamore@821 | 1076 | if (arg.type == incompatibleArg) { |
mcimadamore@829 | 1077 | log.error(arg, "not.within.bounds", incompatibleArg, forms.head); |
mcimadamore@821 | 1078 | } |
mcimadamore@829 | 1079 | forms = forms.tail; |
mcimadamore@829 | 1080 | } |
mcimadamore@829 | 1081 | } |
mcimadamore@829 | 1082 | |
mcimadamore@829 | 1083 | forms = tree.type.tsym.type.getTypeArguments(); |
duke@1 | 1084 | |
mcimadamore@638 | 1085 | boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class; |
mcimadamore@638 | 1086 | |
duke@1 | 1087 | // For matching pairs of actual argument types `a' and |
duke@1 | 1088 | // formal type parameters with declared bound `b' ... |
duke@1 | 1089 | while (args.nonEmpty() && forms.nonEmpty()) { |
mcimadamore@638 | 1090 | validateTree(args.head, |
mcimadamore@638 | 1091 | !(isOuter && is_java_lang_Class), |
mcimadamore@638 | 1092 | false); |
duke@1 | 1093 | args = args.tail; |
duke@1 | 1094 | forms = forms.tail; |
duke@1 | 1095 | } |
duke@1 | 1096 | |
duke@1 | 1097 | // Check that this type is either fully parameterized, or |
duke@1 | 1098 | // not parameterized at all. |
duke@1 | 1099 | if (tree.type.getEnclosingType().isRaw()) |
duke@1 | 1100 | log.error(tree.pos(), "improperly.formed.type.inner.raw.param"); |
jjg@1127 | 1101 | if (tree.clazz.hasTag(SELECT)) |
duke@1 | 1102 | visitSelectInternal((JCFieldAccess)tree.clazz); |
duke@1 | 1103 | } |
duke@1 | 1104 | } |
duke@1 | 1105 | |
jjg@398 | 1106 | @Override |
duke@1 | 1107 | public void visitTypeParameter(JCTypeParameter tree) { |
mcimadamore@638 | 1108 | validateTrees(tree.bounds, true, isOuter); |
duke@1 | 1109 | checkClassBounds(tree.pos(), tree.type); |
duke@1 | 1110 | } |
duke@1 | 1111 | |
duke@1 | 1112 | @Override |
duke@1 | 1113 | public void visitWildcard(JCWildcard tree) { |
duke@1 | 1114 | if (tree.inner != null) |
mcimadamore@638 | 1115 | validateTree(tree.inner, true, isOuter); |
duke@1 | 1116 | } |
duke@1 | 1117 | |
jjg@398 | 1118 | @Override |
duke@1 | 1119 | public void visitSelect(JCFieldAccess tree) { |
duke@1 | 1120 | if (tree.type.tag == CLASS) { |
duke@1 | 1121 | visitSelectInternal(tree); |
duke@1 | 1122 | |
duke@1 | 1123 | // Check that this type is either fully parameterized, or |
duke@1 | 1124 | // not parameterized at all. |
duke@1 | 1125 | if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty()) |
duke@1 | 1126 | log.error(tree.pos(), "improperly.formed.type.param.missing"); |
duke@1 | 1127 | } |
duke@1 | 1128 | } |
mcimadamore@852 | 1129 | |
duke@1 | 1130 | public void visitSelectInternal(JCFieldAccess tree) { |
mcimadamore@122 | 1131 | if (tree.type.tsym.isStatic() && |
duke@1 | 1132 | tree.selected.type.isParameterized()) { |
duke@1 | 1133 | // The enclosing type is not a class, so we are |
duke@1 | 1134 | // looking at a static member type. However, the |
duke@1 | 1135 | // qualifying expression is parameterized. |
duke@1 | 1136 | log.error(tree.pos(), "cant.select.static.class.from.param.type"); |
duke@1 | 1137 | } else { |
duke@1 | 1138 | // otherwise validate the rest of the expression |
mcimadamore@122 | 1139 | tree.selected.accept(this); |
duke@1 | 1140 | } |
duke@1 | 1141 | } |
duke@1 | 1142 | |
duke@1 | 1143 | /** Default visitor method: do nothing. |
duke@1 | 1144 | */ |
jjg@398 | 1145 | @Override |
duke@1 | 1146 | public void visitTree(JCTree tree) { |
duke@1 | 1147 | } |
mcimadamore@122 | 1148 | |
mcimadamore@638 | 1149 | public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) { |
mcimadamore@638 | 1150 | try { |
mcimadamore@638 | 1151 | if (tree != null) { |
mcimadamore@638 | 1152 | this.isOuter = isOuter; |
mcimadamore@638 | 1153 | tree.accept(this); |
mcimadamore@638 | 1154 | if (checkRaw) |
mcimadamore@638 | 1155 | checkRaw(tree, env); |
mcimadamore@638 | 1156 | } |
mcimadamore@638 | 1157 | } catch (CompletionFailure ex) { |
mcimadamore@638 | 1158 | completionError(tree.pos(), ex); |
mcimadamore@638 | 1159 | } |
mcimadamore@638 | 1160 | } |
mcimadamore@638 | 1161 | |
mcimadamore@638 | 1162 | public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) { |
mcimadamore@638 | 1163 | for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail) |
mcimadamore@638 | 1164 | validateTree(l.head, checkRaw, isOuter); |
mcimadamore@638 | 1165 | } |
mcimadamore@638 | 1166 | |
mcimadamore@638 | 1167 | void checkRaw(JCTree tree, Env<AttrContext> env) { |
mcimadamore@795 | 1168 | if (lint.isEnabled(LintCategory.RAW) && |
mcimadamore@638 | 1169 | tree.type.tag == CLASS && |
mcimadamore@638 | 1170 | !TreeInfo.isDiamond(tree) && |
mcimadamore@1103 | 1171 | !withinAnonConstr(env) && |
mcimadamore@638 | 1172 | tree.type.isRaw()) { |
mcimadamore@795 | 1173 | log.warning(LintCategory.RAW, |
mcimadamore@638 | 1174 | tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type); |
mcimadamore@638 | 1175 | } |
mcimadamore@638 | 1176 | } |
mcimadamore@1103 | 1177 | |
mcimadamore@1103 | 1178 | boolean withinAnonConstr(Env<AttrContext> env) { |
mcimadamore@1103 | 1179 | return env.enclClass.name.isEmpty() && |
mcimadamore@1103 | 1180 | env.enclMethod != null && env.enclMethod.name == names.init; |
mcimadamore@1103 | 1181 | } |
duke@1 | 1182 | } |
duke@1 | 1183 | |
duke@1 | 1184 | /* ************************************************************************* |
duke@1 | 1185 | * Exception checking |
duke@1 | 1186 | **************************************************************************/ |
duke@1 | 1187 | |
duke@1 | 1188 | /* The following methods treat classes as sets that contain |
duke@1 | 1189 | * the class itself and all their subclasses |
duke@1 | 1190 | */ |
duke@1 | 1191 | |
duke@1 | 1192 | /** Is given type a subtype of some of the types in given list? |
duke@1 | 1193 | */ |
duke@1 | 1194 | boolean subset(Type t, List<Type> ts) { |
duke@1 | 1195 | for (List<Type> l = ts; l.nonEmpty(); l = l.tail) |
duke@1 | 1196 | if (types.isSubtype(t, l.head)) return true; |
duke@1 | 1197 | return false; |
duke@1 | 1198 | } |
duke@1 | 1199 | |
duke@1 | 1200 | /** Is given type a subtype or supertype of |
duke@1 | 1201 | * some of the types in given list? |
duke@1 | 1202 | */ |
duke@1 | 1203 | boolean intersects(Type t, List<Type> ts) { |
duke@1 | 1204 | for (List<Type> l = ts; l.nonEmpty(); l = l.tail) |
duke@1 | 1205 | if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true; |
duke@1 | 1206 | return false; |
duke@1 | 1207 | } |
duke@1 | 1208 | |
duke@1 | 1209 | /** Add type set to given type list, unless it is a subclass of some class |
duke@1 | 1210 | * in the list. |
duke@1 | 1211 | */ |
duke@1 | 1212 | List<Type> incl(Type t, List<Type> ts) { |
duke@1 | 1213 | return subset(t, ts) ? ts : excl(t, ts).prepend(t); |
duke@1 | 1214 | } |
duke@1 | 1215 | |
duke@1 | 1216 | /** Remove type set from type set list. |
duke@1 | 1217 | */ |
duke@1 | 1218 | List<Type> excl(Type t, List<Type> ts) { |
duke@1 | 1219 | if (ts.isEmpty()) { |
duke@1 | 1220 | return ts; |
duke@1 | 1221 | } else { |
duke@1 | 1222 | List<Type> ts1 = excl(t, ts.tail); |
duke@1 | 1223 | if (types.isSubtype(ts.head, t)) return ts1; |
duke@1 | 1224 | else if (ts1 == ts.tail) return ts; |
duke@1 | 1225 | else return ts1.prepend(ts.head); |
duke@1 | 1226 | } |
duke@1 | 1227 | } |
duke@1 | 1228 | |
duke@1 | 1229 | /** Form the union of two type set lists. |
duke@1 | 1230 | */ |
duke@1 | 1231 | List<Type> union(List<Type> ts1, List<Type> ts2) { |
duke@1 | 1232 | List<Type> ts = ts1; |
duke@1 | 1233 | for (List<Type> l = ts2; l.nonEmpty(); l = l.tail) |
duke@1 | 1234 | ts = incl(l.head, ts); |
duke@1 | 1235 | return ts; |
duke@1 | 1236 | } |
duke@1 | 1237 | |
duke@1 | 1238 | /** Form the difference of two type lists. |
duke@1 | 1239 | */ |
duke@1 | 1240 | List<Type> diff(List<Type> ts1, List<Type> ts2) { |
duke@1 | 1241 | List<Type> ts = ts1; |
duke@1 | 1242 | for (List<Type> l = ts2; l.nonEmpty(); l = l.tail) |
duke@1 | 1243 | ts = excl(l.head, ts); |
duke@1 | 1244 | return ts; |
duke@1 | 1245 | } |
duke@1 | 1246 | |
duke@1 | 1247 | /** Form the intersection of two type lists. |
duke@1 | 1248 | */ |
duke@1 | 1249 | public List<Type> intersect(List<Type> ts1, List<Type> ts2) { |
duke@1 | 1250 | List<Type> ts = List.nil(); |
duke@1 | 1251 | for (List<Type> l = ts1; l.nonEmpty(); l = l.tail) |
duke@1 | 1252 | if (subset(l.head, ts2)) ts = incl(l.head, ts); |
duke@1 | 1253 | for (List<Type> l = ts2; l.nonEmpty(); l = l.tail) |
duke@1 | 1254 | if (subset(l.head, ts1)) ts = incl(l.head, ts); |
duke@1 | 1255 | return ts; |
duke@1 | 1256 | } |
duke@1 | 1257 | |
duke@1 | 1258 | /** Is exc an exception symbol that need not be declared? |
duke@1 | 1259 | */ |
duke@1 | 1260 | boolean isUnchecked(ClassSymbol exc) { |
duke@1 | 1261 | return |
duke@1 | 1262 | exc.kind == ERR || |
duke@1 | 1263 | exc.isSubClass(syms.errorType.tsym, types) || |
duke@1 | 1264 | exc.isSubClass(syms.runtimeExceptionType.tsym, types); |
duke@1 | 1265 | } |
duke@1 | 1266 | |
duke@1 | 1267 | /** Is exc an exception type that need not be declared? |
duke@1 | 1268 | */ |
duke@1 | 1269 | boolean isUnchecked(Type exc) { |
duke@1 | 1270 | return |
duke@1 | 1271 | (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) : |
duke@1 | 1272 | (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) : |
duke@1 | 1273 | exc.tag == BOT; |
duke@1 | 1274 | } |
duke@1 | 1275 | |
duke@1 | 1276 | /** Same, but handling completion failures. |
duke@1 | 1277 | */ |
duke@1 | 1278 | boolean isUnchecked(DiagnosticPosition pos, Type exc) { |
duke@1 | 1279 | try { |
duke@1 | 1280 | return isUnchecked(exc); |
duke@1 | 1281 | } catch (CompletionFailure ex) { |
duke@1 | 1282 | completionError(pos, ex); |
duke@1 | 1283 | return true; |
duke@1 | 1284 | } |
duke@1 | 1285 | } |
duke@1 | 1286 | |
duke@1 | 1287 | /** Is exc handled by given exception list? |
duke@1 | 1288 | */ |
duke@1 | 1289 | boolean isHandled(Type exc, List<Type> handled) { |
duke@1 | 1290 | return isUnchecked(exc) || subset(exc, handled); |
duke@1 | 1291 | } |
duke@1 | 1292 | |
duke@1 | 1293 | /** Return all exceptions in thrown list that are not in handled list. |
duke@1 | 1294 | * @param thrown The list of thrown exceptions. |
duke@1 | 1295 | * @param handled The list of handled exceptions. |
duke@1 | 1296 | */ |
mcimadamore@362 | 1297 | List<Type> unhandled(List<Type> thrown, List<Type> handled) { |
duke@1 | 1298 | List<Type> unhandled = List.nil(); |
duke@1 | 1299 | for (List<Type> l = thrown; l.nonEmpty(); l = l.tail) |
duke@1 | 1300 | if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head); |
duke@1 | 1301 | return unhandled; |
duke@1 | 1302 | } |
duke@1 | 1303 | |
duke@1 | 1304 | /* ************************************************************************* |
duke@1 | 1305 | * Overriding/Implementation checking |
duke@1 | 1306 | **************************************************************************/ |
duke@1 | 1307 | |
duke@1 | 1308 | /** The level of access protection given by a flag set, |
duke@1 | 1309 | * where PRIVATE is highest and PUBLIC is lowest. |
duke@1 | 1310 | */ |
duke@1 | 1311 | static int protection(long flags) { |
duke@1 | 1312 | switch ((short)(flags & AccessFlags)) { |
duke@1 | 1313 | case PRIVATE: return 3; |
duke@1 | 1314 | case PROTECTED: return 1; |
duke@1 | 1315 | default: |
duke@1 | 1316 | case PUBLIC: return 0; |
duke@1 | 1317 | case 0: return 2; |
duke@1 | 1318 | } |
duke@1 | 1319 | } |
duke@1 | 1320 | |
duke@1 | 1321 | /** A customized "cannot override" error message. |
duke@1 | 1322 | * @param m The overriding method. |
duke@1 | 1323 | * @param other The overridden method. |
duke@1 | 1324 | * @return An internationalized string. |
duke@1 | 1325 | */ |
mcimadamore@89 | 1326 | Object cannotOverride(MethodSymbol m, MethodSymbol other) { |
duke@1 | 1327 | String key; |
duke@1 | 1328 | if ((other.owner.flags() & INTERFACE) == 0) |
duke@1 | 1329 | key = "cant.override"; |
duke@1 | 1330 | else if ((m.owner.flags() & INTERFACE) == 0) |
duke@1 | 1331 | key = "cant.implement"; |
duke@1 | 1332 | else |
duke@1 | 1333 | key = "clashes.with"; |
mcimadamore@89 | 1334 | return diags.fragment(key, m, m.location(), other, other.location()); |
duke@1 | 1335 | } |
duke@1 | 1336 | |
duke@1 | 1337 | /** A customized "override" warning message. |
duke@1 | 1338 | * @param m The overriding method. |
duke@1 | 1339 | * @param other The overridden method. |
duke@1 | 1340 | * @return An internationalized string. |
duke@1 | 1341 | */ |
mcimadamore@89 | 1342 | Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) { |
duke@1 | 1343 | String key; |
duke@1 | 1344 | if ((other.owner.flags() & INTERFACE) == 0) |
duke@1 | 1345 | key = "unchecked.override"; |
duke@1 | 1346 | else if ((m.owner.flags() & INTERFACE) == 0) |
duke@1 | 1347 | key = "unchecked.implement"; |
duke@1 | 1348 | else |
duke@1 | 1349 | key = "unchecked.clash.with"; |
mcimadamore@89 | 1350 | return diags.fragment(key, m, m.location(), other, other.location()); |
duke@1 | 1351 | } |
duke@1 | 1352 | |
duke@1 | 1353 | /** A customized "override" warning message. |
duke@1 | 1354 | * @param m The overriding method. |
duke@1 | 1355 | * @param other The overridden method. |
duke@1 | 1356 | * @return An internationalized string. |
duke@1 | 1357 | */ |
mcimadamore@89 | 1358 | Object varargsOverrides(MethodSymbol m, MethodSymbol other) { |
duke@1 | 1359 | String key; |
duke@1 | 1360 | if ((other.owner.flags() & INTERFACE) == 0) |
duke@1 | 1361 | key = "varargs.override"; |
duke@1 | 1362 | else if ((m.owner.flags() & INTERFACE) == 0) |
duke@1 | 1363 | key = "varargs.implement"; |
duke@1 | 1364 | else |
duke@1 | 1365 | key = "varargs.clash.with"; |
mcimadamore@89 | 1366 | return diags.fragment(key, m, m.location(), other, other.location()); |
duke@1 | 1367 | } |
duke@1 | 1368 | |
duke@1 | 1369 | /** Check that this method conforms with overridden method 'other'. |
duke@1 | 1370 | * where `origin' is the class where checking started. |
duke@1 | 1371 | * Complications: |
duke@1 | 1372 | * (1) Do not check overriding of synthetic methods |
duke@1 | 1373 | * (reason: they might be final). |
duke@1 | 1374 | * todo: check whether this is still necessary. |
duke@1 | 1375 | * (2) Admit the case where an interface proxy throws fewer exceptions |
duke@1 | 1376 | * than the method it implements. Augment the proxy methods with the |
duke@1 | 1377 | * undeclared exceptions in this case. |
duke@1 | 1378 | * (3) When generics are enabled, admit the case where an interface proxy |
duke@1 | 1379 | * has a result type |
duke@1 | 1380 | * extended by the result type of the method it implements. |
duke@1 | 1381 | * Change the proxies result type to the smaller type in this case. |
duke@1 | 1382 | * |
duke@1 | 1383 | * @param tree The tree from which positions |
duke@1 | 1384 | * are extracted for errors. |
duke@1 | 1385 | * @param m The overriding method. |
duke@1 | 1386 | * @param other The overridden method. |
duke@1 | 1387 | * @param origin The class of which the overriding method |
duke@1 | 1388 | * is a member. |
duke@1 | 1389 | */ |
duke@1 | 1390 | void checkOverride(JCTree tree, |
duke@1 | 1391 | MethodSymbol m, |
duke@1 | 1392 | MethodSymbol other, |
duke@1 | 1393 | ClassSymbol origin) { |
duke@1 | 1394 | // Don't check overriding of synthetic methods or by bridge methods. |
duke@1 | 1395 | if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) { |
duke@1 | 1396 | return; |
duke@1 | 1397 | } |
duke@1 | 1398 | |
duke@1 | 1399 | // Error if static method overrides instance method (JLS 8.4.6.2). |
duke@1 | 1400 | if ((m.flags() & STATIC) != 0 && |
duke@1 | 1401 | (other.flags() & STATIC) == 0) { |
duke@1 | 1402 | log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static", |
duke@1 | 1403 | cannotOverride(m, other)); |
duke@1 | 1404 | return; |
duke@1 | 1405 | } |
duke@1 | 1406 | |
duke@1 | 1407 | // Error if instance method overrides static or final |
duke@1 | 1408 | // method (JLS 8.4.6.1). |
duke@1 | 1409 | if ((other.flags() & FINAL) != 0 || |
duke@1 | 1410 | (m.flags() & STATIC) == 0 && |
duke@1 | 1411 | (other.flags() & STATIC) != 0) { |
duke@1 | 1412 | log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth", |
duke@1 | 1413 | cannotOverride(m, other), |
mcimadamore@80 | 1414 | asFlagSet(other.flags() & (FINAL | STATIC))); |
duke@1 | 1415 | return; |
duke@1 | 1416 | } |
duke@1 | 1417 | |
duke@1 | 1418 | if ((m.owner.flags() & ANNOTATION) != 0) { |
duke@1 | 1419 | // handled in validateAnnotationMethod |
duke@1 | 1420 | return; |
duke@1 | 1421 | } |
duke@1 | 1422 | |
duke@1 | 1423 | // Error if overriding method has weaker access (JLS 8.4.6.3). |
duke@1 | 1424 | if ((origin.flags() & INTERFACE) == 0 && |
duke@1 | 1425 | protection(m.flags()) > protection(other.flags())) { |
duke@1 | 1426 | log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access", |
duke@1 | 1427 | cannotOverride(m, other), |
mcimadamore@80 | 1428 | other.flags() == 0 ? |
mcimadamore@80 | 1429 | Flag.PACKAGE : |
mcimadamore@80 | 1430 | asFlagSet(other.flags() & AccessFlags)); |
duke@1 | 1431 | return; |
duke@1 | 1432 | } |
duke@1 | 1433 | |
duke@1 | 1434 | Type mt = types.memberType(origin.type, m); |
duke@1 | 1435 | Type ot = types.memberType(origin.type, other); |
duke@1 | 1436 | // Error if overriding result type is different |
duke@1 | 1437 | // (or, in the case of generics mode, not a subtype) of |
duke@1 | 1438 | // overridden result type. We have to rename any type parameters |
duke@1 | 1439 | // before comparing types. |
duke@1 | 1440 | List<Type> mtvars = mt.getTypeArguments(); |
duke@1 | 1441 | List<Type> otvars = ot.getTypeArguments(); |
duke@1 | 1442 | Type mtres = mt.getReturnType(); |
duke@1 | 1443 | Type otres = types.subst(ot.getReturnType(), otvars, mtvars); |
duke@1 | 1444 | |
mcimadamore@795 | 1445 | overrideWarner.clear(); |
duke@1 | 1446 | boolean resultTypesOK = |
tbell@202 | 1447 | types.returnTypeSubstitutable(mt, ot, otres, overrideWarner); |
duke@1 | 1448 | if (!resultTypesOK) { |
jjg@398 | 1449 | if (!allowCovariantReturns && |
duke@1 | 1450 | m.owner != origin && |
duke@1 | 1451 | m.owner.isSubClass(other.owner, types)) { |
duke@1 | 1452 | // allow limited interoperability with covariant returns |
duke@1 | 1453 | } else { |
mcimadamore@362 | 1454 | log.error(TreeInfo.diagnosticPositionFor(m, tree), |
mcimadamore@362 | 1455 | "override.incompatible.ret", |
mcimadamore@362 | 1456 | cannotOverride(m, other), |
duke@1 | 1457 | mtres, otres); |
duke@1 | 1458 | return; |
duke@1 | 1459 | } |
mcimadamore@795 | 1460 | } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) { |
duke@1 | 1461 | warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree), |
mcimadamore@362 | 1462 | "override.unchecked.ret", |
mcimadamore@362 | 1463 | uncheckedOverrides(m, other), |
mcimadamore@362 | 1464 | mtres, otres); |
duke@1 | 1465 | } |
duke@1 | 1466 | |
duke@1 | 1467 | // Error if overriding method throws an exception not reported |
duke@1 | 1468 | // by overridden method. |
duke@1 | 1469 | List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars); |
mcimadamore@362 | 1470 | List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown)); |
mcimadamore@362 | 1471 | List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown); |
mcimadamore@362 | 1472 | if (unhandledErased.nonEmpty()) { |
duke@1 | 1473 | log.error(TreeInfo.diagnosticPositionFor(m, tree), |
duke@1 | 1474 | "override.meth.doesnt.throw", |
duke@1 | 1475 | cannotOverride(m, other), |
mcimadamore@362 | 1476 | unhandledUnerased.head); |
mcimadamore@362 | 1477 | return; |
mcimadamore@362 | 1478 | } |
mcimadamore@362 | 1479 | else if (unhandledUnerased.nonEmpty()) { |
mcimadamore@362 | 1480 | warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree), |
mcimadamore@362 | 1481 | "override.unchecked.thrown", |
mcimadamore@362 | 1482 | cannotOverride(m, other), |
mcimadamore@362 | 1483 | unhandledUnerased.head); |
duke@1 | 1484 | return; |
duke@1 | 1485 | } |
duke@1 | 1486 | |
duke@1 | 1487 | // Optional warning if varargs don't agree |
duke@1 | 1488 | if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0) |
mcimadamore@795 | 1489 | && lint.isEnabled(LintCategory.OVERRIDES)) { |
duke@1 | 1490 | log.warning(TreeInfo.diagnosticPositionFor(m, tree), |
duke@1 | 1491 | ((m.flags() & Flags.VARARGS) != 0) |
duke@1 | 1492 | ? "override.varargs.missing" |
duke@1 | 1493 | : "override.varargs.extra", |
duke@1 | 1494 | varargsOverrides(m, other)); |
duke@1 | 1495 | } |
duke@1 | 1496 | |
duke@1 | 1497 | // Warn if instance method overrides bridge method (compiler spec ??) |
duke@1 | 1498 | if ((other.flags() & BRIDGE) != 0) { |
duke@1 | 1499 | log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge", |
duke@1 | 1500 | uncheckedOverrides(m, other)); |
duke@1 | 1501 | } |
duke@1 | 1502 | |
duke@1 | 1503 | // Warn if a deprecated method overridden by a non-deprecated one. |
mcimadamore@852 | 1504 | if (!isDeprecatedOverrideIgnorable(other, origin)) { |
mcimadamore@852 | 1505 | checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other); |
duke@1 | 1506 | } |
duke@1 | 1507 | } |
duke@1 | 1508 | // where |
duke@1 | 1509 | private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) { |
duke@1 | 1510 | // If the method, m, is defined in an interface, then ignore the issue if the method |
duke@1 | 1511 | // is only inherited via a supertype and also implemented in the supertype, |
duke@1 | 1512 | // because in that case, we will rediscover the issue when examining the method |
duke@1 | 1513 | // in the supertype. |
duke@1 | 1514 | // If the method, m, is not defined in an interface, then the only time we need to |
duke@1 | 1515 | // address the issue is when the method is the supertype implemementation: any other |
duke@1 | 1516 | // case, we will have dealt with when examining the supertype classes |
duke@1 | 1517 | ClassSymbol mc = m.enclClass(); |
duke@1 | 1518 | Type st = types.supertype(origin.type); |
duke@1 | 1519 | if (st.tag != CLASS) |
duke@1 | 1520 | return true; |
duke@1 | 1521 | MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false); |
duke@1 | 1522 | |
duke@1 | 1523 | if (mc != null && ((mc.flags() & INTERFACE) != 0)) { |
duke@1 | 1524 | List<Type> intfs = types.interfaces(origin.type); |
duke@1 | 1525 | return (intfs.contains(mc.type) ? false : (stimpl != null)); |
duke@1 | 1526 | } |
duke@1 | 1527 | else |
duke@1 | 1528 | return (stimpl != m); |
duke@1 | 1529 | } |
duke@1 | 1530 | |
duke@1 | 1531 | |
duke@1 | 1532 | // used to check if there were any unchecked conversions |
duke@1 | 1533 | Warner overrideWarner = new Warner(); |
duke@1 | 1534 | |
duke@1 | 1535 | /** Check that a class does not inherit two concrete methods |
duke@1 | 1536 | * with the same signature. |
duke@1 | 1537 | * @param pos Position to be used for error reporting. |
duke@1 | 1538 | * @param site The class type to be checked. |
duke@1 | 1539 | */ |
duke@1 | 1540 | public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) { |
duke@1 | 1541 | Type sup = types.supertype(site); |
duke@1 | 1542 | if (sup.tag != CLASS) return; |
duke@1 | 1543 | |
duke@1 | 1544 | for (Type t1 = sup; |
duke@1 | 1545 | t1.tsym.type.isParameterized(); |
duke@1 | 1546 | t1 = types.supertype(t1)) { |
duke@1 | 1547 | for (Scope.Entry e1 = t1.tsym.members().elems; |
duke@1 | 1548 | e1 != null; |
duke@1 | 1549 | e1 = e1.sibling) { |
duke@1 | 1550 | Symbol s1 = e1.sym; |
duke@1 | 1551 | if (s1.kind != MTH || |
duke@1 | 1552 | (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 || |
duke@1 | 1553 | !s1.isInheritedIn(site.tsym, types) || |
duke@1 | 1554 | ((MethodSymbol)s1).implementation(site.tsym, |
duke@1 | 1555 | types, |
duke@1 | 1556 | true) != s1) |
duke@1 | 1557 | continue; |
duke@1 | 1558 | Type st1 = types.memberType(t1, s1); |
duke@1 | 1559 | int s1ArgsLength = st1.getParameterTypes().length(); |
duke@1 | 1560 | if (st1 == s1.type) continue; |
duke@1 | 1561 | |
duke@1 | 1562 | for (Type t2 = sup; |
duke@1 | 1563 | t2.tag == CLASS; |
duke@1 | 1564 | t2 = types.supertype(t2)) { |
mcimadamore@24 | 1565 | for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); |
duke@1 | 1566 | e2.scope != null; |
duke@1 | 1567 | e2 = e2.next()) { |
duke@1 | 1568 | Symbol s2 = e2.sym; |
duke@1 | 1569 | if (s2 == s1 || |
duke@1 | 1570 | s2.kind != MTH || |
duke@1 | 1571 | (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 || |
duke@1 | 1572 | s2.type.getParameterTypes().length() != s1ArgsLength || |
duke@1 | 1573 | !s2.isInheritedIn(site.tsym, types) || |
duke@1 | 1574 | ((MethodSymbol)s2).implementation(site.tsym, |
duke@1 | 1575 | types, |
duke@1 | 1576 | true) != s2) |
duke@1 | 1577 | continue; |
duke@1 | 1578 | Type st2 = types.memberType(t2, s2); |
duke@1 | 1579 | if (types.overrideEquivalent(st1, st2)) |
duke@1 | 1580 | log.error(pos, "concrete.inheritance.conflict", |
duke@1 | 1581 | s1, t1, s2, t2, sup); |
duke@1 | 1582 | } |
duke@1 | 1583 | } |
duke@1 | 1584 | } |
duke@1 | 1585 | } |
duke@1 | 1586 | } |
duke@1 | 1587 | |
duke@1 | 1588 | /** Check that classes (or interfaces) do not each define an abstract |
duke@1 | 1589 | * method with same name and arguments but incompatible return types. |
duke@1 | 1590 | * @param pos Position to be used for error reporting. |
duke@1 | 1591 | * @param t1 The first argument type. |
duke@1 | 1592 | * @param t2 The second argument type. |
duke@1 | 1593 | */ |
duke@1 | 1594 | public boolean checkCompatibleAbstracts(DiagnosticPosition pos, |
duke@1 | 1595 | Type t1, |
duke@1 | 1596 | Type t2) { |
duke@1 | 1597 | return checkCompatibleAbstracts(pos, t1, t2, |
duke@1 | 1598 | types.makeCompoundType(t1, t2)); |
duke@1 | 1599 | } |
duke@1 | 1600 | |
duke@1 | 1601 | public boolean checkCompatibleAbstracts(DiagnosticPosition pos, |
duke@1 | 1602 | Type t1, |
duke@1 | 1603 | Type t2, |
duke@1 | 1604 | Type site) { |
mcimadamore@746 | 1605 | return firstIncompatibility(pos, t1, t2, site) == null; |
duke@1 | 1606 | } |
duke@1 | 1607 | |
duke@1 | 1608 | /** Return the first method which is defined with same args |
duke@1 | 1609 | * but different return types in two given interfaces, or null if none |
duke@1 | 1610 | * exists. |
duke@1 | 1611 | * @param t1 The first type. |
duke@1 | 1612 | * @param t2 The second type. |
duke@1 | 1613 | * @param site The most derived type. |
duke@1 | 1614 | * @returns symbol from t2 that conflicts with one in t1. |
duke@1 | 1615 | */ |
mcimadamore@746 | 1616 | private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) { |
duke@1 | 1617 | Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>(); |
duke@1 | 1618 | closure(t1, interfaces1); |
duke@1 | 1619 | Map<TypeSymbol,Type> interfaces2; |
duke@1 | 1620 | if (t1 == t2) |
duke@1 | 1621 | interfaces2 = interfaces1; |
duke@1 | 1622 | else |
duke@1 | 1623 | closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>()); |
duke@1 | 1624 | |
duke@1 | 1625 | for (Type t3 : interfaces1.values()) { |
duke@1 | 1626 | for (Type t4 : interfaces2.values()) { |
mcimadamore@746 | 1627 | Symbol s = firstDirectIncompatibility(pos, t3, t4, site); |
duke@1 | 1628 | if (s != null) return s; |
duke@1 | 1629 | } |
duke@1 | 1630 | } |
duke@1 | 1631 | return null; |
duke@1 | 1632 | } |
duke@1 | 1633 | |
duke@1 | 1634 | /** Compute all the supertypes of t, indexed by type symbol. */ |
duke@1 | 1635 | private void closure(Type t, Map<TypeSymbol,Type> typeMap) { |
duke@1 | 1636 | if (t.tag != CLASS) return; |
duke@1 | 1637 | if (typeMap.put(t.tsym, t) == null) { |
duke@1 | 1638 | closure(types.supertype(t), typeMap); |
duke@1 | 1639 | for (Type i : types.interfaces(t)) |
duke@1 | 1640 | closure(i, typeMap); |
duke@1 | 1641 | } |
duke@1 | 1642 | } |
duke@1 | 1643 | |
duke@1 | 1644 | /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */ |
duke@1 | 1645 | private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) { |
duke@1 | 1646 | if (t.tag != CLASS) return; |
duke@1 | 1647 | if (typesSkip.get(t.tsym) != null) return; |
duke@1 | 1648 | if (typeMap.put(t.tsym, t) == null) { |
duke@1 | 1649 | closure(types.supertype(t), typesSkip, typeMap); |
duke@1 | 1650 | for (Type i : types.interfaces(t)) |
duke@1 | 1651 | closure(i, typesSkip, typeMap); |
duke@1 | 1652 | } |
duke@1 | 1653 | } |
duke@1 | 1654 | |
duke@1 | 1655 | /** Return the first method in t2 that conflicts with a method from t1. */ |
mcimadamore@746 | 1656 | private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) { |
duke@1 | 1657 | for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) { |
duke@1 | 1658 | Symbol s1 = e1.sym; |
duke@1 | 1659 | Type st1 = null; |
duke@1 | 1660 | if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue; |
duke@1 | 1661 | Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false); |
duke@1 | 1662 | if (impl != null && (impl.flags() & ABSTRACT) == 0) continue; |
duke@1 | 1663 | for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) { |
duke@1 | 1664 | Symbol s2 = e2.sym; |
duke@1 | 1665 | if (s1 == s2) continue; |
duke@1 | 1666 | if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue; |
duke@1 | 1667 | if (st1 == null) st1 = types.memberType(t1, s1); |
duke@1 | 1668 | Type st2 = types.memberType(t2, s2); |
duke@1 | 1669 | if (types.overrideEquivalent(st1, st2)) { |
duke@1 | 1670 | List<Type> tvars1 = st1.getTypeArguments(); |
duke@1 | 1671 | List<Type> tvars2 = st2.getTypeArguments(); |
duke@1 | 1672 | Type rt1 = st1.getReturnType(); |
duke@1 | 1673 | Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1); |
duke@1 | 1674 | boolean compat = |
duke@1 | 1675 | types.isSameType(rt1, rt2) || |
duke@1 | 1676 | rt1.tag >= CLASS && rt2.tag >= CLASS && |
duke@1 | 1677 | (types.covariantReturnType(rt1, rt2, Warner.noWarnings) || |
mcimadamore@59 | 1678 | types.covariantReturnType(rt2, rt1, Warner.noWarnings)) || |
mcimadamore@59 | 1679 | checkCommonOverriderIn(s1,s2,site); |
mcimadamore@746 | 1680 | if (!compat) { |
mcimadamore@746 | 1681 | log.error(pos, "types.incompatible.diff.ret", |
mcimadamore@746 | 1682 | t1, t2, s2.name + |
mcimadamore@746 | 1683 | "(" + types.memberType(t2, s2).getParameterTypes() + ")"); |
mcimadamore@746 | 1684 | return s2; |
mcimadamore@746 | 1685 | } |
mcimadamore@889 | 1686 | } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) && |
mcimadamore@889 | 1687 | !checkCommonOverriderIn(s1, s2, site)) { |
mcimadamore@746 | 1688 | log.error(pos, |
mcimadamore@746 | 1689 | "name.clash.same.erasure.no.override", |
mcimadamore@746 | 1690 | s1, s1.location(), |
mcimadamore@746 | 1691 | s2, s2.location()); |
mcimadamore@746 | 1692 | return s2; |
duke@1 | 1693 | } |
duke@1 | 1694 | } |
duke@1 | 1695 | } |
duke@1 | 1696 | return null; |
duke@1 | 1697 | } |
mcimadamore@59 | 1698 | //WHERE |
mcimadamore@59 | 1699 | boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) { |
mcimadamore@59 | 1700 | Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>(); |
mcimadamore@59 | 1701 | Type st1 = types.memberType(site, s1); |
mcimadamore@59 | 1702 | Type st2 = types.memberType(site, s2); |
mcimadamore@59 | 1703 | closure(site, supertypes); |
mcimadamore@59 | 1704 | for (Type t : supertypes.values()) { |
mcimadamore@59 | 1705 | for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) { |
mcimadamore@59 | 1706 | Symbol s3 = e.sym; |
mcimadamore@59 | 1707 | if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue; |
mcimadamore@59 | 1708 | Type st3 = types.memberType(site,s3); |
mcimadamore@59 | 1709 | if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) { |
mcimadamore@59 | 1710 | if (s3.owner == site.tsym) { |
mcimadamore@59 | 1711 | return true; |
mcimadamore@59 | 1712 | } |
mcimadamore@59 | 1713 | List<Type> tvars1 = st1.getTypeArguments(); |
mcimadamore@59 | 1714 | List<Type> tvars2 = st2.getTypeArguments(); |
mcimadamore@59 | 1715 | List<Type> tvars3 = st3.getTypeArguments(); |
mcimadamore@59 | 1716 | Type rt1 = st1.getReturnType(); |
mcimadamore@59 | 1717 | Type rt2 = st2.getReturnType(); |
mcimadamore@59 | 1718 | Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1); |
mcimadamore@59 | 1719 | Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2); |
mcimadamore@59 | 1720 | boolean compat = |
mcimadamore@59 | 1721 | rt13.tag >= CLASS && rt23.tag >= CLASS && |
mcimadamore@59 | 1722 | (types.covariantReturnType(rt13, rt1, Warner.noWarnings) && |
mcimadamore@59 | 1723 | types.covariantReturnType(rt23, rt2, Warner.noWarnings)); |
mcimadamore@59 | 1724 | if (compat) |
mcimadamore@59 | 1725 | return true; |
mcimadamore@59 | 1726 | } |
mcimadamore@59 | 1727 | } |
mcimadamore@59 | 1728 | } |
mcimadamore@59 | 1729 | return false; |
mcimadamore@59 | 1730 | } |
duke@1 | 1731 | |
duke@1 | 1732 | /** Check that a given method conforms with any method it overrides. |
duke@1 | 1733 | * @param tree The tree from which positions are extracted |
duke@1 | 1734 | * for errors. |
duke@1 | 1735 | * @param m The overriding method. |
duke@1 | 1736 | */ |
duke@1 | 1737 | void checkOverride(JCTree tree, MethodSymbol m) { |
duke@1 | 1738 | ClassSymbol origin = (ClassSymbol)m.owner; |
duke@1 | 1739 | if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name)) |
duke@1 | 1740 | if (m.overrides(syms.enumFinalFinalize, origin, types, false)) { |
duke@1 | 1741 | log.error(tree.pos(), "enum.no.finalize"); |
duke@1 | 1742 | return; |
duke@1 | 1743 | } |
mcimadamore@746 | 1744 | for (Type t = origin.type; t.tag == CLASS; |
duke@1 | 1745 | t = types.supertype(t)) { |
mcimadamore@746 | 1746 | if (t != origin.type) { |
mcimadamore@746 | 1747 | checkOverride(tree, t, origin, m); |
mcimadamore@746 | 1748 | } |
mcimadamore@746 | 1749 | for (Type t2 : types.interfaces(t)) { |
mcimadamore@746 | 1750 | checkOverride(tree, t2, origin, m); |
duke@1 | 1751 | } |
duke@1 | 1752 | } |
duke@1 | 1753 | } |
duke@1 | 1754 | |
mcimadamore@746 | 1755 | void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) { |
mcimadamore@746 | 1756 | TypeSymbol c = site.tsym; |
mcimadamore@746 | 1757 | Scope.Entry e = c.members().lookup(m.name); |
mcimadamore@746 | 1758 | while (e.scope != null) { |
mcimadamore@746 | 1759 | if (m.overrides(e.sym, origin, types, false)) { |
mcimadamore@746 | 1760 | if ((e.sym.flags() & ABSTRACT) == 0) { |
mcimadamore@746 | 1761 | checkOverride(tree, m, (MethodSymbol)e.sym, origin); |
mcimadamore@746 | 1762 | } |
mcimadamore@746 | 1763 | } |
mcimadamore@746 | 1764 | e = e.next(); |
mcimadamore@746 | 1765 | } |
mcimadamore@746 | 1766 | } |
mcimadamore@746 | 1767 | |
mcimadamore@746 | 1768 | private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) { |
mcimadamore@858 | 1769 | ClashFilter cf = new ClashFilter(origin.type); |
mcimadamore@858 | 1770 | return (cf.accepts(s1) && |
mcimadamore@858 | 1771 | cf.accepts(s2) && |
mcimadamore@858 | 1772 | types.hasSameArgs(s1.erasure(types), s2.erasure(types))); |
mcimadamore@746 | 1773 | } |
mcimadamore@746 | 1774 | |
mcimadamore@746 | 1775 | |
duke@1 | 1776 | /** Check that all abstract members of given class have definitions. |
duke@1 | 1777 | * @param pos Position to be used for error reporting. |
duke@1 | 1778 | * @param c The class. |
duke@1 | 1779 | */ |
duke@1 | 1780 | void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) { |
duke@1 | 1781 | try { |
duke@1 | 1782 | MethodSymbol undef = firstUndef(c, c); |
duke@1 | 1783 | if (undef != null) { |
duke@1 | 1784 | if ((c.flags() & ENUM) != 0 && |
duke@1 | 1785 | types.supertype(c.type).tsym == syms.enumSym && |
duke@1 | 1786 | (c.flags() & FINAL) == 0) { |
duke@1 | 1787 | // add the ABSTRACT flag to an enum |
duke@1 | 1788 | c.flags_field |= ABSTRACT; |
duke@1 | 1789 | } else { |
duke@1 | 1790 | MethodSymbol undef1 = |
duke@1 | 1791 | new MethodSymbol(undef.flags(), undef.name, |
duke@1 | 1792 | types.memberType(c.type, undef), undef.owner); |
duke@1 | 1793 | log.error(pos, "does.not.override.abstract", |
duke@1 | 1794 | c, undef1, undef1.location()); |
duke@1 | 1795 | } |
duke@1 | 1796 | } |
duke@1 | 1797 | } catch (CompletionFailure ex) { |
duke@1 | 1798 | completionError(pos, ex); |
duke@1 | 1799 | } |
duke@1 | 1800 | } |
duke@1 | 1801 | //where |
duke@1 | 1802 | /** Return first abstract member of class `c' that is not defined |
duke@1 | 1803 | * in `impl', null if there is none. |
duke@1 | 1804 | */ |
duke@1 | 1805 | private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) { |
duke@1 | 1806 | MethodSymbol undef = null; |
duke@1 | 1807 | // Do not bother to search in classes that are not abstract, |
duke@1 | 1808 | // since they cannot have abstract members. |
duke@1 | 1809 | if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) { |
duke@1 | 1810 | Scope s = c.members(); |
duke@1 | 1811 | for (Scope.Entry e = s.elems; |
duke@1 | 1812 | undef == null && e != null; |
duke@1 | 1813 | e = e.sibling) { |
duke@1 | 1814 | if (e.sym.kind == MTH && |
duke@1 | 1815 | (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) { |
duke@1 | 1816 | MethodSymbol absmeth = (MethodSymbol)e.sym; |
duke@1 | 1817 | MethodSymbol implmeth = absmeth.implementation(impl, types, true); |
duke@1 | 1818 | if (implmeth == null || implmeth == absmeth) |
duke@1 | 1819 | undef = absmeth; |
duke@1 | 1820 | } |
duke@1 | 1821 | } |
duke@1 | 1822 | if (undef == null) { |
duke@1 | 1823 | Type st = types.supertype(c.type); |
duke@1 | 1824 | if (st.tag == CLASS) |
duke@1 | 1825 | undef = firstUndef(impl, (ClassSymbol)st.tsym); |
duke@1 | 1826 | } |
duke@1 | 1827 | for (List<Type> l = types.interfaces(c.type); |
duke@1 | 1828 | undef == null && l.nonEmpty(); |
duke@1 | 1829 | l = l.tail) { |
duke@1 | 1830 | undef = firstUndef(impl, (ClassSymbol)l.head.tsym); |
duke@1 | 1831 | } |
duke@1 | 1832 | } |
duke@1 | 1833 | return undef; |
duke@1 | 1834 | } |
duke@1 | 1835 | |
mcimadamore@690 | 1836 | void checkNonCyclicDecl(JCClassDecl tree) { |
mcimadamore@690 | 1837 | CycleChecker cc = new CycleChecker(); |
mcimadamore@690 | 1838 | cc.scan(tree); |
mcimadamore@690 | 1839 | if (!cc.errorFound && !cc.partialCheck) { |
mcimadamore@690 | 1840 | tree.sym.flags_field |= ACYCLIC; |
mcimadamore@690 | 1841 | } |
mcimadamore@690 | 1842 | } |
mcimadamore@690 | 1843 | |
mcimadamore@690 | 1844 | class CycleChecker extends TreeScanner { |
mcimadamore@690 | 1845 | |
mcimadamore@690 | 1846 | List<Symbol> seenClasses = List.nil(); |
mcimadamore@690 | 1847 | boolean errorFound = false; |
mcimadamore@690 | 1848 | boolean partialCheck = false; |
mcimadamore@690 | 1849 | |
mcimadamore@690 | 1850 | private void checkSymbol(DiagnosticPosition pos, Symbol sym) { |
mcimadamore@690 | 1851 | if (sym != null && sym.kind == TYP) { |
mcimadamore@690 | 1852 | Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym); |
mcimadamore@690 | 1853 | if (classEnv != null) { |
mcimadamore@690 | 1854 | DiagnosticSource prevSource = log.currentSource(); |
mcimadamore@690 | 1855 | try { |
mcimadamore@690 | 1856 | log.useSource(classEnv.toplevel.sourcefile); |
mcimadamore@690 | 1857 | scan(classEnv.tree); |
mcimadamore@690 | 1858 | } |
mcimadamore@690 | 1859 | finally { |
mcimadamore@690 | 1860 | log.useSource(prevSource.getFile()); |
mcimadamore@690 | 1861 | } |
mcimadamore@690 | 1862 | } else if (sym.kind == TYP) { |
mcimadamore@690 | 1863 | checkClass(pos, sym, List.<JCTree>nil()); |
mcimadamore@690 | 1864 | } |
mcimadamore@690 | 1865 | } else { |
mcimadamore@690 | 1866 | //not completed yet |
mcimadamore@690 | 1867 | partialCheck = true; |
mcimadamore@690 | 1868 | } |
mcimadamore@690 | 1869 | } |
mcimadamore@690 | 1870 | |
mcimadamore@690 | 1871 | @Override |
mcimadamore@690 | 1872 | public void visitSelect(JCFieldAccess tree) { |
mcimadamore@690 | 1873 | super.visitSelect(tree); |
mcimadamore@690 | 1874 | checkSymbol(tree.pos(), tree.sym); |
mcimadamore@690 | 1875 | } |
mcimadamore@690 | 1876 | |
mcimadamore@690 | 1877 | @Override |
mcimadamore@690 | 1878 | public void visitIdent(JCIdent tree) { |
mcimadamore@690 | 1879 | checkSymbol(tree.pos(), tree.sym); |
mcimadamore@690 | 1880 | } |
mcimadamore@690 | 1881 | |
mcimadamore@690 | 1882 | @Override |
mcimadamore@690 | 1883 | public void visitTypeApply(JCTypeApply tree) { |
mcimadamore@690 | 1884 | scan(tree.clazz); |
mcimadamore@690 | 1885 | } |
mcimadamore@690 | 1886 | |
mcimadamore@690 | 1887 | @Override |
mcimadamore@690 | 1888 | public void visitTypeArray(JCArrayTypeTree tree) { |
mcimadamore@690 | 1889 | scan(tree.elemtype); |
mcimadamore@690 | 1890 | } |
mcimadamore@690 | 1891 | |
mcimadamore@690 | 1892 | @Override |
mcimadamore@690 | 1893 | public void visitClassDef(JCClassDecl tree) { |
mcimadamore@690 | 1894 | List<JCTree> supertypes = List.nil(); |
mcimadamore@690 | 1895 | if (tree.getExtendsClause() != null) { |
mcimadamore@690 | 1896 | supertypes = supertypes.prepend(tree.getExtendsClause()); |
mcimadamore@690 | 1897 | } |
mcimadamore@690 | 1898 | if (tree.getImplementsClause() != null) { |
mcimadamore@690 | 1899 | for (JCTree intf : tree.getImplementsClause()) { |
mcimadamore@690 | 1900 | supertypes = supertypes.prepend(intf); |
mcimadamore@690 | 1901 | } |
mcimadamore@690 | 1902 | } |
mcimadamore@690 | 1903 | checkClass(tree.pos(), tree.sym, supertypes); |
mcimadamore@690 | 1904 | } |
mcimadamore@690 | 1905 | |
mcimadamore@690 | 1906 | void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) { |
mcimadamore@690 | 1907 | if ((c.flags_field & ACYCLIC) != 0) |
mcimadamore@690 | 1908 | return; |
mcimadamore@690 | 1909 | if (seenClasses.contains(c)) { |
mcimadamore@690 | 1910 | errorFound = true; |
mcimadamore@690 | 1911 | noteCyclic(pos, (ClassSymbol)c); |
mcimadamore@690 | 1912 | } else if (!c.type.isErroneous()) { |
mcimadamore@690 | 1913 | try { |
mcimadamore@690 | 1914 | seenClasses = seenClasses.prepend(c); |
mcimadamore@690 | 1915 | if (c.type.tag == CLASS) { |
mcimadamore@690 | 1916 | if (supertypes.nonEmpty()) { |
mcimadamore@690 | 1917 | scan(supertypes); |
mcimadamore@690 | 1918 | } |
mcimadamore@690 | 1919 | else { |
mcimadamore@690 | 1920 | ClassType ct = (ClassType)c.type; |
mcimadamore@690 | 1921 | if (ct.supertype_field == null || |
mcimadamore@690 | 1922 | ct.interfaces_field == null) { |
mcimadamore@690 | 1923 | //not completed yet |
mcimadamore@690 | 1924 | partialCheck = true; |
mcimadamore@690 | 1925 | return; |
mcimadamore@690 | 1926 | } |
mcimadamore@690 | 1927 | checkSymbol(pos, ct.supertype_field.tsym); |
mcimadamore@690 | 1928 | for (Type intf : ct.interfaces_field) { |
mcimadamore@690 | 1929 | checkSymbol(pos, intf.tsym); |
mcimadamore@690 | 1930 | } |
mcimadamore@690 | 1931 | } |
mcimadamore@690 | 1932 | if (c.owner.kind == TYP) { |
mcimadamore@690 | 1933 | checkSymbol(pos, c.owner); |
mcimadamore@690 | 1934 | } |
mcimadamore@690 | 1935 | } |
mcimadamore@690 | 1936 | } finally { |
mcimadamore@690 | 1937 | seenClasses = seenClasses.tail; |
mcimadamore@690 | 1938 | } |
mcimadamore@690 | 1939 | } |
mcimadamore@690 | 1940 | } |
mcimadamore@690 | 1941 | } |
mcimadamore@690 | 1942 | |
duke@1 | 1943 | /** Check for cyclic references. Issue an error if the |
duke@1 | 1944 | * symbol of the type referred to has a LOCKED flag set. |
duke@1 | 1945 | * |
duke@1 | 1946 | * @param pos Position to be used for error reporting. |
duke@1 | 1947 | * @param t The type referred to. |
duke@1 | 1948 | */ |
duke@1 | 1949 | void checkNonCyclic(DiagnosticPosition pos, Type t) { |
duke@1 | 1950 | checkNonCyclicInternal(pos, t); |
duke@1 | 1951 | } |
duke@1 | 1952 | |
duke@1 | 1953 | |
duke@1 | 1954 | void checkNonCyclic(DiagnosticPosition pos, TypeVar t) { |
mcimadamore@236 | 1955 | checkNonCyclic1(pos, t, List.<TypeVar>nil()); |
duke@1 | 1956 | } |
duke@1 | 1957 | |
mcimadamore@236 | 1958 | private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) { |
duke@1 | 1959 | final TypeVar tv; |
mcimadamore@42 | 1960 | if (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0) |
mcimadamore@42 | 1961 | return; |
duke@1 | 1962 | if (seen.contains(t)) { |
duke@1 | 1963 | tv = (TypeVar)t; |
jjg@110 | 1964 | tv.bound = types.createErrorType(t); |
duke@1 | 1965 | log.error(pos, "cyclic.inheritance", t); |
duke@1 | 1966 | } else if (t.tag == TYPEVAR) { |
duke@1 | 1967 | tv = (TypeVar)t; |
mcimadamore@236 | 1968 | seen = seen.prepend(tv); |
duke@1 | 1969 | for (Type b : types.getBounds(tv)) |
duke@1 | 1970 | checkNonCyclic1(pos, b, seen); |
duke@1 | 1971 | } |
duke@1 | 1972 | } |
duke@1 | 1973 | |
duke@1 | 1974 | /** Check for cyclic references. Issue an error if the |
duke@1 | 1975 | * symbol of the type referred to has a LOCKED flag set. |
duke@1 | 1976 | * |
duke@1 | 1977 | * @param pos Position to be used for error reporting. |
duke@1 | 1978 | * @param t The type referred to. |
duke@1 | 1979 | * @returns True if the check completed on all attributed classes |
duke@1 | 1980 | */ |
duke@1 | 1981 | private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) { |
duke@1 | 1982 | boolean complete = true; // was the check complete? |
duke@1 | 1983 | //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG |
duke@1 | 1984 | Symbol c = t.tsym; |
duke@1 | 1985 | if ((c.flags_field & ACYCLIC) != 0) return true; |
duke@1 | 1986 | |
duke@1 | 1987 | if ((c.flags_field & LOCKED) != 0) { |
duke@1 | 1988 | noteCyclic(pos, (ClassSymbol)c); |
duke@1 | 1989 | } else if (!c.type.isErroneous()) { |
duke@1 | 1990 | try { |
duke@1 | 1991 | c.flags_field |= LOCKED; |
duke@1 | 1992 | if (c.type.tag == CLASS) { |
duke@1 | 1993 | ClassType clazz = (ClassType)c.type; |
duke@1 | 1994 | if (clazz.interfaces_field != null) |
duke@1 | 1995 | for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail) |
duke@1 | 1996 | complete &= checkNonCyclicInternal(pos, l.head); |
duke@1 | 1997 | if (clazz.supertype_field != null) { |
duke@1 | 1998 | Type st = clazz.supertype_field; |
duke@1 | 1999 | if (st != null && st.tag == CLASS) |
duke@1 | 2000 | complete &= checkNonCyclicInternal(pos, st); |
duke@1 | 2001 | } |
duke@1 | 2002 | if (c.owner.kind == TYP) |
duke@1 | 2003 | complete &= checkNonCyclicInternal(pos, c.owner.type); |
duke@1 | 2004 | } |
duke@1 | 2005 | } finally { |
duke@1 | 2006 | c.flags_field &= ~LOCKED; |
duke@1 | 2007 | } |
duke@1 | 2008 | } |
duke@1 | 2009 | if (complete) |
duke@1 | 2010 | complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null; |
duke@1 | 2011 | if (complete) c.flags_field |= ACYCLIC; |
duke@1 | 2012 | return complete; |
duke@1 | 2013 | } |
duke@1 | 2014 | |
duke@1 | 2015 | /** Note that we found an inheritance cycle. */ |
duke@1 | 2016 | private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) { |
duke@1 | 2017 | log.error(pos, "cyclic.inheritance", c); |
duke@1 | 2018 | for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail) |
jjg@110 | 2019 | l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType); |
duke@1 | 2020 | Type st = types.supertype(c.type); |
duke@1 | 2021 | if (st.tag == CLASS) |
jjg@110 | 2022 | ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType); |
jjg@110 | 2023 | c.type = types.createErrorType(c, c.type); |
duke@1 | 2024 | c.flags_field |= ACYCLIC; |
duke@1 | 2025 | } |
duke@1 | 2026 | |
duke@1 | 2027 | /** Check that all methods which implement some |
duke@1 | 2028 | * method conform to the method they implement. |
duke@1 | 2029 | * @param tree The class definition whose members are checked. |
duke@1 | 2030 | */ |
duke@1 | 2031 | void checkImplementations(JCClassDecl tree) { |
duke@1 | 2032 | checkImplementations(tree, tree.sym); |
duke@1 | 2033 | } |
duke@1 | 2034 | //where |
duke@1 | 2035 | /** Check that all methods which implement some |
duke@1 | 2036 | * method in `ic' conform to the method they implement. |
duke@1 | 2037 | */ |
duke@1 | 2038 | void checkImplementations(JCClassDecl tree, ClassSymbol ic) { |
duke@1 | 2039 | ClassSymbol origin = tree.sym; |
duke@1 | 2040 | for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) { |
duke@1 | 2041 | ClassSymbol lc = (ClassSymbol)l.head.tsym; |
duke@1 | 2042 | if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) { |
duke@1 | 2043 | for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) { |
duke@1 | 2044 | if (e.sym.kind == MTH && |
duke@1 | 2045 | (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) { |
duke@1 | 2046 | MethodSymbol absmeth = (MethodSymbol)e.sym; |
duke@1 | 2047 | MethodSymbol implmeth = absmeth.implementation(origin, types, false); |
duke@1 | 2048 | if (implmeth != null && implmeth != absmeth && |
duke@1 | 2049 | (implmeth.owner.flags() & INTERFACE) == |
duke@1 | 2050 | (origin.flags() & INTERFACE)) { |
duke@1 | 2051 | // don't check if implmeth is in a class, yet |
duke@1 | 2052 | // origin is an interface. This case arises only |
duke@1 | 2053 | // if implmeth is declared in Object. The reason is |
duke@1 | 2054 | // that interfaces really don't inherit from |
duke@1 | 2055 | // Object it's just that the compiler represents |
duke@1 | 2056 | // things that way. |
duke@1 | 2057 | checkOverride(tree, implmeth, absmeth, origin); |
duke@1 | 2058 | } |
duke@1 | 2059 | } |
duke@1 | 2060 | } |
duke@1 | 2061 | } |
duke@1 | 2062 | } |
duke@1 | 2063 | } |
duke@1 | 2064 | |
duke@1 | 2065 | /** Check that all abstract methods implemented by a class are |
duke@1 | 2066 | * mutually compatible. |
duke@1 | 2067 | * @param pos Position to be used for error reporting. |
duke@1 | 2068 | * @param c The class whose interfaces are checked. |
duke@1 | 2069 | */ |
duke@1 | 2070 | void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) { |
duke@1 | 2071 | List<Type> supertypes = types.interfaces(c); |
duke@1 | 2072 | Type supertype = types.supertype(c); |
duke@1 | 2073 | if (supertype.tag == CLASS && |
duke@1 | 2074 | (supertype.tsym.flags() & ABSTRACT) != 0) |
duke@1 | 2075 | supertypes = supertypes.prepend(supertype); |
duke@1 | 2076 | for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) { |
duke@1 | 2077 | if (allowGenerics && !l.head.getTypeArguments().isEmpty() && |
duke@1 | 2078 | !checkCompatibleAbstracts(pos, l.head, l.head, c)) |
duke@1 | 2079 | return; |
duke@1 | 2080 | for (List<Type> m = supertypes; m != l; m = m.tail) |
duke@1 | 2081 | if (!checkCompatibleAbstracts(pos, l.head, m.head, c)) |
duke@1 | 2082 | return; |
duke@1 | 2083 | } |
duke@1 | 2084 | checkCompatibleConcretes(pos, c); |
duke@1 | 2085 | } |
duke@1 | 2086 | |
mcimadamore@359 | 2087 | void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) { |
mcimadamore@359 | 2088 | for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) { |
mcimadamore@359 | 2089 | for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) { |
mcimadamore@359 | 2090 | // VM allows methods and variables with differing types |
mcimadamore@359 | 2091 | if (sym.kind == e.sym.kind && |
mcimadamore@359 | 2092 | types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) && |
mcimadamore@359 | 2093 | sym != e.sym && |
mcimadamore@359 | 2094 | (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) && |
mcimadamore@608 | 2095 | (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 && |
mcimadamore@359 | 2096 | (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) { |
mcimadamore@359 | 2097 | syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym); |
mcimadamore@359 | 2098 | return; |
mcimadamore@359 | 2099 | } |
mcimadamore@359 | 2100 | } |
mcimadamore@359 | 2101 | } |
mcimadamore@359 | 2102 | } |
mcimadamore@359 | 2103 | |
mcimadamore@780 | 2104 | /** Check that all non-override equivalent methods accessible from 'site' |
mcimadamore@780 | 2105 | * are mutually compatible (JLS 8.4.8/9.4.1). |
mcimadamore@780 | 2106 | * |
mcimadamore@780 | 2107 | * @param pos Position to be used for error reporting. |
mcimadamore@780 | 2108 | * @param site The class whose methods are checked. |
mcimadamore@780 | 2109 | * @param sym The method symbol to be checked. |
mcimadamore@780 | 2110 | */ |
mcimadamore@858 | 2111 | void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) { |
mcimadamore@858 | 2112 | ClashFilter cf = new ClashFilter(site); |
mcimadamore@1198 | 2113 | //for each method m1 that is overridden (directly or indirectly) |
mcimadamore@1198 | 2114 | //by method 'sym' in 'site'... |
mcimadamore@1198 | 2115 | for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) { |
mcimadamore@1198 | 2116 | if (!sym.overrides(m1, site.tsym, types, false)) continue; |
mcimadamore@1198 | 2117 | //...check each method m2 that is a member of 'site' |
mcimadamore@1198 | 2118 | for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) { |
mcimadamore@1198 | 2119 | if (m2 == m1) continue; |
mcimadamore@858 | 2120 | //if (i) the signature of 'sym' is not a subsignature of m1 (seen as |
mcimadamore@858 | 2121 | //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error |
mcimadamore@1198 | 2122 | if (!types.isSubSignature(sym.type, types.memberType(site, m2), false) && |
mcimadamore@1198 | 2123 | types.hasSameArgs(m2.erasure(types), m1.erasure(types))) { |
mcimadamore@858 | 2124 | sym.flags_field |= CLASH; |
mcimadamore@1198 | 2125 | String key = m1 == sym ? |
mcimadamore@858 | 2126 | "name.clash.same.erasure.no.override" : |
mcimadamore@858 | 2127 | "name.clash.same.erasure.no.override.1"; |
mcimadamore@858 | 2128 | log.error(pos, |
mcimadamore@858 | 2129 | key, |
mcimadamore@858 | 2130 | sym, sym.location(), |
mcimadamore@1198 | 2131 | m2, m2.location(), |
mcimadamore@1198 | 2132 | m1, m1.location()); |
mcimadamore@858 | 2133 | return; |
mcimadamore@858 | 2134 | } |
mcimadamore@780 | 2135 | } |
mcimadamore@780 | 2136 | } |
mcimadamore@780 | 2137 | } |
mcimadamore@780 | 2138 | |
mcimadamore@877 | 2139 | |
mcimadamore@877 | 2140 | |
mcimadamore@858 | 2141 | /** Check that all static methods accessible from 'site' are |
mcimadamore@858 | 2142 | * mutually compatible (JLS 8.4.8). |
mcimadamore@858 | 2143 | * |
mcimadamore@858 | 2144 | * @param pos Position to be used for error reporting. |
mcimadamore@858 | 2145 | * @param site The class whose methods are checked. |
mcimadamore@858 | 2146 | * @param sym The method symbol to be checked. |
mcimadamore@780 | 2147 | */ |
mcimadamore@858 | 2148 | void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) { |
mcimadamore@780 | 2149 | ClashFilter cf = new ClashFilter(site); |
mcimadamore@858 | 2150 | //for each method m1 that is a member of 'site'... |
mcimadamore@1015 | 2151 | for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) { |
mcimadamore@858 | 2152 | //if (i) the signature of 'sym' is not a subsignature of m1 (seen as |
mcimadamore@858 | 2153 | //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error |
mcimadamore@907 | 2154 | if (!types.isSubSignature(sym.type, types.memberType(site, s), false) && |
mcimadamore@877 | 2155 | types.hasSameArgs(s.erasure(types), sym.erasure(types))) { |
mcimadamore@780 | 2156 | log.error(pos, |
mcimadamore@858 | 2157 | "name.clash.same.erasure.no.hide", |
mcimadamore@858 | 2158 | sym, sym.location(), |
mcimadamore@877 | 2159 | s, s.location()); |
mcimadamore@858 | 2160 | return; |
mcimadamore@858 | 2161 | } |
mcimadamore@858 | 2162 | } |
mcimadamore@858 | 2163 | } |
mcimadamore@780 | 2164 | |
mcimadamore@858 | 2165 | //where |
mcimadamore@858 | 2166 | private class ClashFilter implements Filter<Symbol> { |
mcimadamore@780 | 2167 | |
mcimadamore@858 | 2168 | Type site; |
mcimadamore@780 | 2169 | |
mcimadamore@858 | 2170 | ClashFilter(Type site) { |
mcimadamore@858 | 2171 | this.site = site; |
mcimadamore@858 | 2172 | } |
mcimadamore@858 | 2173 | |
mcimadamore@858 | 2174 | boolean shouldSkip(Symbol s) { |
mcimadamore@858 | 2175 | return (s.flags() & CLASH) != 0 && |
mcimadamore@858 | 2176 | s.owner == site.tsym; |
mcimadamore@858 | 2177 | } |
mcimadamore@858 | 2178 | |
mcimadamore@858 | 2179 | public boolean accepts(Symbol s) { |
mcimadamore@858 | 2180 | return s.kind == MTH && |
mcimadamore@858 | 2181 | (s.flags() & SYNTHETIC) == 0 && |
mcimadamore@858 | 2182 | !shouldSkip(s) && |
mcimadamore@858 | 2183 | s.isInheritedIn(site.tsym, types) && |
mcimadamore@858 | 2184 | !s.isConstructor(); |
mcimadamore@858 | 2185 | } |
mcimadamore@858 | 2186 | } |
mcimadamore@780 | 2187 | |
mcimadamore@359 | 2188 | /** Report a conflict between a user symbol and a synthetic symbol. |
mcimadamore@359 | 2189 | */ |
mcimadamore@359 | 2190 | private void syntheticError(DiagnosticPosition pos, Symbol sym) { |
mcimadamore@359 | 2191 | if (!sym.type.isErroneous()) { |
mcimadamore@359 | 2192 | if (warnOnSyntheticConflicts) { |
mcimadamore@359 | 2193 | log.warning(pos, "synthetic.name.conflict", sym, sym.location()); |
mcimadamore@359 | 2194 | } |
mcimadamore@359 | 2195 | else { |
mcimadamore@359 | 2196 | log.error(pos, "synthetic.name.conflict", sym, sym.location()); |
mcimadamore@359 | 2197 | } |
mcimadamore@359 | 2198 | } |
mcimadamore@359 | 2199 | } |
mcimadamore@359 | 2200 | |
duke@1 | 2201 | /** Check that class c does not implement directly or indirectly |
duke@1 | 2202 | * the same parameterized interface with two different argument lists. |
duke@1 | 2203 | * @param pos Position to be used for error reporting. |
duke@1 | 2204 | * @param type The type whose interfaces are checked. |
duke@1 | 2205 | */ |
duke@1 | 2206 | void checkClassBounds(DiagnosticPosition pos, Type type) { |
duke@1 | 2207 | checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type); |
duke@1 | 2208 | } |
duke@1 | 2209 | //where |
duke@1 | 2210 | /** Enter all interfaces of type `type' into the hash table `seensofar' |
duke@1 | 2211 | * with their class symbol as key and their type as value. Make |
duke@1 | 2212 | * sure no class is entered with two different types. |
duke@1 | 2213 | */ |
duke@1 | 2214 | void checkClassBounds(DiagnosticPosition pos, |
duke@1 | 2215 | Map<TypeSymbol,Type> seensofar, |
duke@1 | 2216 | Type type) { |
duke@1 | 2217 | if (type.isErroneous()) return; |
duke@1 | 2218 | for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) { |
duke@1 | 2219 | Type it = l.head; |
duke@1 | 2220 | Type oldit = seensofar.put(it.tsym, it); |
duke@1 | 2221 | if (oldit != null) { |
duke@1 | 2222 | List<Type> oldparams = oldit.allparams(); |
duke@1 | 2223 | List<Type> newparams = it.allparams(); |
duke@1 | 2224 | if (!types.containsTypeEquivalent(oldparams, newparams)) |
duke@1 | 2225 | log.error(pos, "cant.inherit.diff.arg", |
duke@1 | 2226 | it.tsym, Type.toString(oldparams), |
duke@1 | 2227 | Type.toString(newparams)); |
duke@1 | 2228 | } |
duke@1 | 2229 | checkClassBounds(pos, seensofar, it); |
duke@1 | 2230 | } |
duke@1 | 2231 | Type st = types.supertype(type); |
duke@1 | 2232 | if (st != null) checkClassBounds(pos, seensofar, st); |
duke@1 | 2233 | } |
duke@1 | 2234 | |
duke@1 | 2235 | /** Enter interface into into set. |
duke@1 | 2236 | * If it existed already, issue a "repeated interface" error. |
duke@1 | 2237 | */ |
duke@1 | 2238 | void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) { |
duke@1 | 2239 | if (its.contains(it)) |
duke@1 | 2240 | log.error(pos, "repeated.interface"); |
duke@1 | 2241 | else { |
duke@1 | 2242 | its.add(it); |
duke@1 | 2243 | } |
duke@1 | 2244 | } |
duke@1 | 2245 | |
duke@1 | 2246 | /* ************************************************************************* |
duke@1 | 2247 | * Check annotations |
duke@1 | 2248 | **************************************************************************/ |
duke@1 | 2249 | |
mcimadamore@629 | 2250 | /** |
mcimadamore@634 | 2251 | * Recursively validate annotations values |
mcimadamore@629 | 2252 | */ |
mcimadamore@634 | 2253 | void validateAnnotationTree(JCTree tree) { |
mcimadamore@634 | 2254 | class AnnotationValidator extends TreeScanner { |
mcimadamore@629 | 2255 | @Override |
mcimadamore@629 | 2256 | public void visitAnnotation(JCAnnotation tree) { |
jjg@1017 | 2257 | if (!tree.type.isErroneous()) { |
jjg@1017 | 2258 | super.visitAnnotation(tree); |
jjg@1017 | 2259 | validateAnnotation(tree); |
jjg@1017 | 2260 | } |
mcimadamore@629 | 2261 | } |
mcimadamore@629 | 2262 | } |
mcimadamore@634 | 2263 | tree.accept(new AnnotationValidator()); |
mcimadamore@629 | 2264 | } |
mcimadamore@629 | 2265 | |
duke@1 | 2266 | /** Annotation types are restricted to primitives, String, an |
duke@1 | 2267 | * enum, an annotation, Class, Class<?>, Class<? extends |
duke@1 | 2268 | * Anything>, arrays of the preceding. |
duke@1 | 2269 | */ |
duke@1 | 2270 | void validateAnnotationType(JCTree restype) { |
duke@1 | 2271 | // restype may be null if an error occurred, so don't bother validating it |
duke@1 | 2272 | if (restype != null) { |
duke@1 | 2273 | validateAnnotationType(restype.pos(), restype.type); |
duke@1 | 2274 | } |
duke@1 | 2275 | } |
duke@1 | 2276 | |
duke@1 | 2277 | void validateAnnotationType(DiagnosticPosition pos, Type type) { |
duke@1 | 2278 | if (type.isPrimitive()) return; |
duke@1 | 2279 | if (types.isSameType(type, syms.stringType)) return; |
duke@1 | 2280 | if ((type.tsym.flags() & Flags.ENUM) != 0) return; |
duke@1 | 2281 | if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return; |
duke@1 | 2282 | if (types.lowerBound(type).tsym == syms.classType.tsym) return; |
duke@1 | 2283 | if (types.isArray(type) && !types.isArray(types.elemtype(type))) { |
duke@1 | 2284 | validateAnnotationType(pos, types.elemtype(type)); |
duke@1 | 2285 | return; |
duke@1 | 2286 | } |
duke@1 | 2287 | log.error(pos, "invalid.annotation.member.type"); |
duke@1 | 2288 | } |
duke@1 | 2289 | |
duke@1 | 2290 | /** |
duke@1 | 2291 | * "It is also a compile-time error if any method declared in an |
duke@1 | 2292 | * annotation type has a signature that is override-equivalent to |
duke@1 | 2293 | * that of any public or protected method declared in class Object |
duke@1 | 2294 | * or in the interface annotation.Annotation." |
duke@1 | 2295 | * |
jjh@972 | 2296 | * @jls 9.6 Annotation Types |
duke@1 | 2297 | */ |
duke@1 | 2298 | void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) { |
duke@1 | 2299 | for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) { |
duke@1 | 2300 | Scope s = sup.tsym.members(); |
duke@1 | 2301 | for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) { |
duke@1 | 2302 | if (e.sym.kind == MTH && |
duke@1 | 2303 | (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 && |
duke@1 | 2304 | types.overrideEquivalent(m.type, e.sym.type)) |
duke@1 | 2305 | log.error(pos, "intf.annotation.member.clash", e.sym, sup); |
duke@1 | 2306 | } |
duke@1 | 2307 | } |
duke@1 | 2308 | } |
duke@1 | 2309 | |
duke@1 | 2310 | /** Check the annotations of a symbol. |
duke@1 | 2311 | */ |
duke@1 | 2312 | public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) { |
duke@1 | 2313 | if (skipAnnotations) return; |
duke@1 | 2314 | for (JCAnnotation a : annotations) |
duke@1 | 2315 | validateAnnotation(a, s); |
duke@1 | 2316 | } |
duke@1 | 2317 | |
duke@1 | 2318 | /** Check an annotation of a symbol. |
duke@1 | 2319 | */ |
duke@1 | 2320 | public void validateAnnotation(JCAnnotation a, Symbol s) { |
mcimadamore@634 | 2321 | validateAnnotationTree(a); |
duke@1 | 2322 | |
duke@1 | 2323 | if (!annotationApplicable(a, s)) |
duke@1 | 2324 | log.error(a.pos(), "annotation.type.not.applicable"); |
duke@1 | 2325 | |
duke@1 | 2326 | if (a.annotationType.type.tsym == syms.overrideType.tsym) { |
duke@1 | 2327 | if (!isOverrider(s)) |
duke@1 | 2328 | log.error(a.pos(), "method.does.not.override.superclass"); |
duke@1 | 2329 | } |
duke@1 | 2330 | } |
duke@1 | 2331 | |
duke@1 | 2332 | /** Is s a method symbol that overrides a method in a superclass? */ |
duke@1 | 2333 | boolean isOverrider(Symbol s) { |
duke@1 | 2334 | if (s.kind != MTH || s.isStatic()) |
duke@1 | 2335 | return false; |
duke@1 | 2336 | MethodSymbol m = (MethodSymbol)s; |
duke@1 | 2337 | TypeSymbol owner = (TypeSymbol)m.owner; |
duke@1 | 2338 | for (Type sup : types.closure(owner.type)) { |
duke@1 | 2339 | if (sup == owner.type) |
duke@1 | 2340 | continue; // skip "this" |
duke@1 | 2341 | Scope scope = sup.tsym.members(); |
duke@1 | 2342 | for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) { |
duke@1 | 2343 | if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true)) |
duke@1 | 2344 | return true; |
duke@1 | 2345 | } |
duke@1 | 2346 | } |
duke@1 | 2347 | return false; |
duke@1 | 2348 | } |
duke@1 | 2349 | |
duke@1 | 2350 | /** Is the annotation applicable to the symbol? */ |
duke@1 | 2351 | boolean annotationApplicable(JCAnnotation a, Symbol s) { |
duke@1 | 2352 | Attribute.Compound atTarget = |
duke@1 | 2353 | a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym); |
duke@1 | 2354 | if (atTarget == null) return true; |
duke@1 | 2355 | Attribute atValue = atTarget.member(names.value); |
duke@1 | 2356 | if (!(atValue instanceof Attribute.Array)) return true; // error recovery |
duke@1 | 2357 | Attribute.Array arr = (Attribute.Array) atValue; |
duke@1 | 2358 | for (Attribute app : arr.values) { |
duke@1 | 2359 | if (!(app instanceof Attribute.Enum)) return true; // recovery |
duke@1 | 2360 | Attribute.Enum e = (Attribute.Enum) app; |
duke@1 | 2361 | if (e.value.name == names.TYPE) |
duke@1 | 2362 | { if (s.kind == TYP) return true; } |
duke@1 | 2363 | else if (e.value.name == names.FIELD) |
duke@1 | 2364 | { if (s.kind == VAR && s.owner.kind != MTH) return true; } |
duke@1 | 2365 | else if (e.value.name == names.METHOD) |
duke@1 | 2366 | { if (s.kind == MTH && !s.isConstructor()) return true; } |
duke@1 | 2367 | else if (e.value.name == names.PARAMETER) |
duke@1 | 2368 | { if (s.kind == VAR && |
duke@1 | 2369 | s.owner.kind == MTH && |
duke@1 | 2370 | (s.flags() & PARAMETER) != 0) |
duke@1 | 2371 | return true; |
duke@1 | 2372 | } |
duke@1 | 2373 | else if (e.value.name == names.CONSTRUCTOR) |
duke@1 | 2374 | { if (s.kind == MTH && s.isConstructor()) return true; } |
duke@1 | 2375 | else if (e.value.name == names.LOCAL_VARIABLE) |
duke@1 | 2376 | { if (s.kind == VAR && s.owner.kind == MTH && |
duke@1 | 2377 | (s.flags() & PARAMETER) == 0) |
duke@1 | 2378 | return true; |
duke@1 | 2379 | } |
duke@1 | 2380 | else if (e.value.name == names.ANNOTATION_TYPE) |
duke@1 | 2381 | { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0) |
duke@1 | 2382 | return true; |
duke@1 | 2383 | } |
duke@1 | 2384 | else if (e.value.name == names.PACKAGE) |
duke@1 | 2385 | { if (s.kind == PCK) return true; } |
jjg@308 | 2386 | else if (e.value.name == names.TYPE_USE) |
jjg@308 | 2387 | { if (s.kind == TYP || |
jjg@308 | 2388 | s.kind == VAR || |
jjg@308 | 2389 | (s.kind == MTH && !s.isConstructor() && |
jjg@308 | 2390 | s.type.getReturnType().tag != VOID)) |
jjg@308 | 2391 | return true; |
jjg@308 | 2392 | } |
duke@1 | 2393 | else |
duke@1 | 2394 | return true; // recovery |
duke@1 | 2395 | } |
duke@1 | 2396 | return false; |
duke@1 | 2397 | } |
duke@1 | 2398 | |
duke@1 | 2399 | /** Check an annotation value. |
duke@1 | 2400 | */ |
duke@1 | 2401 | public void validateAnnotation(JCAnnotation a) { |
mcimadamore@632 | 2402 | // collect an inventory of the members (sorted alphabetically) |
mcimadamore@632 | 2403 | Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() { |
mcimadamore@632 | 2404 | public int compare(Symbol t, Symbol t1) { |
mcimadamore@632 | 2405 | return t.name.compareTo(t1.name); |
mcimadamore@632 | 2406 | } |
mcimadamore@632 | 2407 | }); |
duke@1 | 2408 | for (Scope.Entry e = a.annotationType.type.tsym.members().elems; |
duke@1 | 2409 | e != null; |
duke@1 | 2410 | e = e.sibling) |
duke@1 | 2411 | if (e.sym.kind == MTH) |
duke@1 | 2412 | members.add((MethodSymbol) e.sym); |
duke@1 | 2413 | |
duke@1 | 2414 | // count them off as they're annotated |
duke@1 | 2415 | for (JCTree arg : a.args) { |
jjg@1127 | 2416 | if (!arg.hasTag(ASSIGN)) continue; // recovery |
duke@1 | 2417 | JCAssign assign = (JCAssign) arg; |
duke@1 | 2418 | Symbol m = TreeInfo.symbol(assign.lhs); |
duke@1 | 2419 | if (m == null || m.type.isErroneous()) continue; |
duke@1 | 2420 | if (!members.remove(m)) |
jjg@479 | 2421 | log.error(assign.lhs.pos(), "duplicate.annotation.member.value", |
duke@1 | 2422 | m.name, a.type); |
duke@1 | 2423 | } |
duke@1 | 2424 | |
duke@1 | 2425 | // all the remaining ones better have default values |
mcimadamore@632 | 2426 | ListBuffer<Name> missingDefaults = ListBuffer.lb(); |
mcimadamore@632 | 2427 | for (MethodSymbol m : members) { |
mcimadamore@632 | 2428 | if (m.defaultValue == null && !m.type.isErroneous()) { |
mcimadamore@632 | 2429 | missingDefaults.append(m.name); |
mcimadamore@632 | 2430 | } |
mcimadamore@632 | 2431 | } |
mcimadamore@632 | 2432 | if (missingDefaults.nonEmpty()) { |
mcimadamore@632 | 2433 | String key = (missingDefaults.size() > 1) |
mcimadamore@632 | 2434 | ? "annotation.missing.default.value.1" |
mcimadamore@632 | 2435 | : "annotation.missing.default.value"; |
mcimadamore@632 | 2436 | log.error(a.pos(), key, a.type, missingDefaults); |
mcimadamore@632 | 2437 | } |
duke@1 | 2438 | |
duke@1 | 2439 | // special case: java.lang.annotation.Target must not have |
duke@1 | 2440 | // repeated values in its value member |
duke@1 | 2441 | if (a.annotationType.type.tsym != syms.annotationTargetType.tsym || |
duke@1 | 2442 | a.args.tail == null) |
duke@1 | 2443 | return; |
duke@1 | 2444 | |
jjg@1127 | 2445 | if (!a.args.head.hasTag(ASSIGN)) return; // error recovery |
duke@1 | 2446 | JCAssign assign = (JCAssign) a.args.head; |
duke@1 | 2447 | Symbol m = TreeInfo.symbol(assign.lhs); |
duke@1 | 2448 | if (m.name != names.value) return; |
duke@1 | 2449 | JCTree rhs = assign.rhs; |
jjg@1127 | 2450 | if (!rhs.hasTag(NEWARRAY)) return; |
duke@1 | 2451 | JCNewArray na = (JCNewArray) rhs; |
duke@1 | 2452 | Set<Symbol> targets = new HashSet<Symbol>(); |
duke@1 | 2453 | for (JCTree elem : na.elems) { |
duke@1 | 2454 | if (!targets.add(TreeInfo.symbol(elem))) { |
duke@1 | 2455 | log.error(elem.pos(), "repeated.annotation.target"); |
duke@1 | 2456 | } |
duke@1 | 2457 | } |
duke@1 | 2458 | } |
duke@1 | 2459 | |
duke@1 | 2460 | void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) { |
duke@1 | 2461 | if (allowAnnotations && |
mcimadamore@795 | 2462 | lint.isEnabled(LintCategory.DEP_ANN) && |
duke@1 | 2463 | (s.flags() & DEPRECATED) != 0 && |
duke@1 | 2464 | !syms.deprecatedType.isErroneous() && |
duke@1 | 2465 | s.attribute(syms.deprecatedType.tsym) == null) { |
mcimadamore@795 | 2466 | log.warning(LintCategory.DEP_ANN, |
jjg@612 | 2467 | pos, "missing.deprecated.annotation"); |
duke@1 | 2468 | } |
duke@1 | 2469 | } |
duke@1 | 2470 | |
mcimadamore@852 | 2471 | void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) { |
mcimadamore@852 | 2472 | if ((s.flags() & DEPRECATED) != 0 && |
mcimadamore@852 | 2473 | (other.flags() & DEPRECATED) == 0 && |
mcimadamore@852 | 2474 | s.outermostClass() != other.outermostClass()) { |
mcimadamore@852 | 2475 | deferredLintHandler.report(new DeferredLintHandler.LintLogger() { |
mcimadamore@852 | 2476 | @Override |
mcimadamore@852 | 2477 | public void report() { |
mcimadamore@852 | 2478 | warnDeprecated(pos, s); |
mcimadamore@852 | 2479 | } |
mcimadamore@852 | 2480 | }); |
jjg@1157 | 2481 | } |
mcimadamore@852 | 2482 | } |
mcimadamore@852 | 2483 | |
mcimadamore@852 | 2484 | void checkSunAPI(final DiagnosticPosition pos, final Symbol s) { |
mcimadamore@852 | 2485 | if ((s.flags() & PROPRIETARY) != 0) { |
mcimadamore@852 | 2486 | deferredLintHandler.report(new DeferredLintHandler.LintLogger() { |
mcimadamore@852 | 2487 | public void report() { |
mcimadamore@852 | 2488 | if (enableSunApiLintControl) |
mcimadamore@852 | 2489 | warnSunApi(pos, "sun.proprietary", s); |
mcimadamore@852 | 2490 | else |
mcimadamore@852 | 2491 | log.strictWarning(pos, "sun.proprietary", s); |
mcimadamore@852 | 2492 | } |
mcimadamore@852 | 2493 | }); |
mcimadamore@852 | 2494 | } |
mcimadamore@852 | 2495 | } |
mcimadamore@852 | 2496 | |
duke@1 | 2497 | /* ************************************************************************* |
duke@1 | 2498 | * Check for recursive annotation elements. |
duke@1 | 2499 | **************************************************************************/ |
duke@1 | 2500 | |
duke@1 | 2501 | /** Check for cycles in the graph of annotation elements. |
duke@1 | 2502 | */ |
duke@1 | 2503 | void checkNonCyclicElements(JCClassDecl tree) { |
duke@1 | 2504 | if ((tree.sym.flags_field & ANNOTATION) == 0) return; |
jjg@816 | 2505 | Assert.check((tree.sym.flags_field & LOCKED) == 0); |
duke@1 | 2506 | try { |
duke@1 | 2507 | tree.sym.flags_field |= LOCKED; |
duke@1 | 2508 | for (JCTree def : tree.defs) { |
jjg@1127 | 2509 | if (!def.hasTag(METHODDEF)) continue; |
duke@1 | 2510 | JCMethodDecl meth = (JCMethodDecl)def; |
duke@1 | 2511 | checkAnnotationResType(meth.pos(), meth.restype.type); |
duke@1 | 2512 | } |
duke@1 | 2513 | } finally { |
duke@1 | 2514 | tree.sym.flags_field &= ~LOCKED; |
duke@1 | 2515 | tree.sym.flags_field |= ACYCLIC_ANN; |
duke@1 | 2516 | } |
duke@1 | 2517 | } |
duke@1 | 2518 | |
duke@1 | 2519 | void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) { |
duke@1 | 2520 | if ((tsym.flags_field & ACYCLIC_ANN) != 0) |
duke@1 | 2521 | return; |
duke@1 | 2522 | if ((tsym.flags_field & LOCKED) != 0) { |
duke@1 | 2523 | log.error(pos, "cyclic.annotation.element"); |
duke@1 | 2524 | return; |
duke@1 | 2525 | } |
duke@1 | 2526 | try { |
duke@1 | 2527 | tsym.flags_field |= LOCKED; |
duke@1 | 2528 | for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) { |
duke@1 | 2529 | Symbol s = e.sym; |
duke@1 | 2530 | if (s.kind != Kinds.MTH) |
duke@1 | 2531 | continue; |
duke@1 | 2532 | checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType()); |
duke@1 | 2533 | } |
duke@1 | 2534 | } finally { |
duke@1 | 2535 | tsym.flags_field &= ~LOCKED; |
duke@1 | 2536 | tsym.flags_field |= ACYCLIC_ANN; |
duke@1 | 2537 | } |
duke@1 | 2538 | } |
duke@1 | 2539 | |
duke@1 | 2540 | void checkAnnotationResType(DiagnosticPosition pos, Type type) { |
duke@1 | 2541 | switch (type.tag) { |
duke@1 | 2542 | case TypeTags.CLASS: |
duke@1 | 2543 | if ((type.tsym.flags() & ANNOTATION) != 0) |
duke@1 | 2544 | checkNonCyclicElementsInternal(pos, type.tsym); |
duke@1 | 2545 | break; |
duke@1 | 2546 | case TypeTags.ARRAY: |
duke@1 | 2547 | checkAnnotationResType(pos, types.elemtype(type)); |
duke@1 | 2548 | break; |
duke@1 | 2549 | default: |
duke@1 | 2550 | break; // int etc |
duke@1 | 2551 | } |
duke@1 | 2552 | } |
duke@1 | 2553 | |
duke@1 | 2554 | /* ************************************************************************* |
duke@1 | 2555 | * Check for cycles in the constructor call graph. |
duke@1 | 2556 | **************************************************************************/ |
duke@1 | 2557 | |
duke@1 | 2558 | /** Check for cycles in the graph of constructors calling other |
duke@1 | 2559 | * constructors. |
duke@1 | 2560 | */ |
duke@1 | 2561 | void checkCyclicConstructors(JCClassDecl tree) { |
duke@1 | 2562 | Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>(); |
duke@1 | 2563 | |
duke@1 | 2564 | // enter each constructor this-call into the map |
duke@1 | 2565 | for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) { |
duke@1 | 2566 | JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head); |
duke@1 | 2567 | if (app == null) continue; |
duke@1 | 2568 | JCMethodDecl meth = (JCMethodDecl) l.head; |
duke@1 | 2569 | if (TreeInfo.name(app.meth) == names._this) { |
duke@1 | 2570 | callMap.put(meth.sym, TreeInfo.symbol(app.meth)); |
duke@1 | 2571 | } else { |
duke@1 | 2572 | meth.sym.flags_field |= ACYCLIC; |
duke@1 | 2573 | } |
duke@1 | 2574 | } |
duke@1 | 2575 | |
duke@1 | 2576 | // Check for cycles in the map |
duke@1 | 2577 | Symbol[] ctors = new Symbol[0]; |
duke@1 | 2578 | ctors = callMap.keySet().toArray(ctors); |
duke@1 | 2579 | for (Symbol caller : ctors) { |
duke@1 | 2580 | checkCyclicConstructor(tree, caller, callMap); |
duke@1 | 2581 | } |
duke@1 | 2582 | } |
duke@1 | 2583 | |
duke@1 | 2584 | /** Look in the map to see if the given constructor is part of a |
duke@1 | 2585 | * call cycle. |
duke@1 | 2586 | */ |
duke@1 | 2587 | private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor, |
duke@1 | 2588 | Map<Symbol,Symbol> callMap) { |
duke@1 | 2589 | if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) { |
duke@1 | 2590 | if ((ctor.flags_field & LOCKED) != 0) { |
duke@1 | 2591 | log.error(TreeInfo.diagnosticPositionFor(ctor, tree), |
duke@1 | 2592 | "recursive.ctor.invocation"); |
duke@1 | 2593 | } else { |
duke@1 | 2594 | ctor.flags_field |= LOCKED; |
duke@1 | 2595 | checkCyclicConstructor(tree, callMap.remove(ctor), callMap); |
duke@1 | 2596 | ctor.flags_field &= ~LOCKED; |
duke@1 | 2597 | } |
duke@1 | 2598 | ctor.flags_field |= ACYCLIC; |
duke@1 | 2599 | } |
duke@1 | 2600 | } |
duke@1 | 2601 | |
duke@1 | 2602 | /* ************************************************************************* |
duke@1 | 2603 | * Miscellaneous |
duke@1 | 2604 | **************************************************************************/ |
duke@1 | 2605 | |
duke@1 | 2606 | /** |
duke@1 | 2607 | * Return the opcode of the operator but emit an error if it is an |
duke@1 | 2608 | * error. |
duke@1 | 2609 | * @param pos position for error reporting. |
duke@1 | 2610 | * @param operator an operator |
duke@1 | 2611 | * @param tag a tree tag |
duke@1 | 2612 | * @param left type of left hand side |
duke@1 | 2613 | * @param right type of right hand side |
duke@1 | 2614 | */ |
duke@1 | 2615 | int checkOperator(DiagnosticPosition pos, |
duke@1 | 2616 | OperatorSymbol operator, |
jjg@1127 | 2617 | JCTree.Tag tag, |
duke@1 | 2618 | Type left, |
duke@1 | 2619 | Type right) { |
duke@1 | 2620 | if (operator.opcode == ByteCodes.error) { |
duke@1 | 2621 | log.error(pos, |
mcimadamore@853 | 2622 | "operator.cant.be.applied.1", |
duke@1 | 2623 | treeinfo.operatorName(tag), |
mcimadamore@853 | 2624 | left, right); |
duke@1 | 2625 | } |
duke@1 | 2626 | return operator.opcode; |
duke@1 | 2627 | } |
duke@1 | 2628 | |
duke@1 | 2629 | |
duke@1 | 2630 | /** |
duke@1 | 2631 | * Check for division by integer constant zero |
duke@1 | 2632 | * @param pos Position for error reporting. |
duke@1 | 2633 | * @param operator The operator for the expression |
duke@1 | 2634 | * @param operand The right hand operand for the expression |
duke@1 | 2635 | */ |
duke@1 | 2636 | void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) { |
duke@1 | 2637 | if (operand.constValue() != null |
mcimadamore@795 | 2638 | && lint.isEnabled(LintCategory.DIVZERO) |
duke@1 | 2639 | && operand.tag <= LONG |
duke@1 | 2640 | && ((Number) (operand.constValue())).longValue() == 0) { |
duke@1 | 2641 | int opc = ((OperatorSymbol)operator).opcode; |
duke@1 | 2642 | if (opc == ByteCodes.idiv || opc == ByteCodes.imod |
duke@1 | 2643 | || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) { |
mcimadamore@795 | 2644 | log.warning(LintCategory.DIVZERO, pos, "div.zero"); |
duke@1 | 2645 | } |
duke@1 | 2646 | } |
duke@1 | 2647 | } |
duke@1 | 2648 | |
duke@1 | 2649 | /** |
duke@1 | 2650 | * Check for empty statements after if |
duke@1 | 2651 | */ |
duke@1 | 2652 | void checkEmptyIf(JCIf tree) { |
jjg@1127 | 2653 | if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null && |
jjg@1127 | 2654 | lint.isEnabled(LintCategory.EMPTY)) |
mcimadamore@795 | 2655 | log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if"); |
duke@1 | 2656 | } |
duke@1 | 2657 | |
duke@1 | 2658 | /** Check that symbol is unique in given scope. |
duke@1 | 2659 | * @param pos Position for error reporting. |
duke@1 | 2660 | * @param sym The symbol. |
duke@1 | 2661 | * @param s The scope. |
duke@1 | 2662 | */ |
duke@1 | 2663 | boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) { |
duke@1 | 2664 | if (sym.type.isErroneous()) |
duke@1 | 2665 | return true; |
duke@1 | 2666 | if (sym.owner.name == names.any) return false; |
duke@1 | 2667 | for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) { |
duke@1 | 2668 | if (sym != e.sym && |
mcimadamore@858 | 2669 | (e.sym.flags() & CLASH) == 0 && |
mcimadamore@858 | 2670 | sym.kind == e.sym.kind && |
mcimadamore@858 | 2671 | sym.name != names.error && |
mcimadamore@858 | 2672 | (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) { |
mcimadamore@844 | 2673 | if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) { |
duke@1 | 2674 | varargsDuplicateError(pos, sym, e.sym); |
mcimadamore@844 | 2675 | return true; |
mcimadamore@907 | 2676 | } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) { |
mcimadamore@252 | 2677 | duplicateErasureError(pos, sym, e.sym); |
mcimadamore@844 | 2678 | sym.flags_field |= CLASH; |
mcimadamore@844 | 2679 | return true; |
mcimadamore@844 | 2680 | } else { |
duke@1 | 2681 | duplicateError(pos, e.sym); |
mcimadamore@844 | 2682 | return false; |
mcimadamore@844 | 2683 | } |
duke@1 | 2684 | } |
duke@1 | 2685 | } |
duke@1 | 2686 | return true; |
duke@1 | 2687 | } |
mcimadamore@844 | 2688 | |
mcimadamore@858 | 2689 | /** Report duplicate declaration error. |
mcimadamore@858 | 2690 | */ |
mcimadamore@858 | 2691 | void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) { |
mcimadamore@858 | 2692 | if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) { |
mcimadamore@858 | 2693 | log.error(pos, "name.clash.same.erasure", sym1, sym2); |
mcimadamore@844 | 2694 | } |
mcimadamore@858 | 2695 | } |
duke@1 | 2696 | |
duke@1 | 2697 | /** Check that single-type import is not already imported or top-level defined, |
duke@1 | 2698 | * but make an exception for two single-type imports which denote the same type. |
duke@1 | 2699 | * @param pos Position for error reporting. |
duke@1 | 2700 | * @param sym The symbol. |
duke@1 | 2701 | * @param s The scope |
duke@1 | 2702 | */ |
duke@1 | 2703 | boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) { |
duke@1 | 2704 | return checkUniqueImport(pos, sym, s, false); |
duke@1 | 2705 | } |
duke@1 | 2706 | |
duke@1 | 2707 | /** Check that static single-type import is not already imported or top-level defined, |
duke@1 | 2708 | * but make an exception for two single-type imports which denote the same type. |
duke@1 | 2709 | * @param pos Position for error reporting. |
duke@1 | 2710 | * @param sym The symbol. |
duke@1 | 2711 | * @param s The scope |
duke@1 | 2712 | * @param staticImport Whether or not this was a static import |
duke@1 | 2713 | */ |
duke@1 | 2714 | boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) { |
duke@1 | 2715 | return checkUniqueImport(pos, sym, s, true); |
duke@1 | 2716 | } |
duke@1 | 2717 | |
duke@1 | 2718 | /** Check that single-type import is not already imported or top-level defined, |
duke@1 | 2719 | * but make an exception for two single-type imports which denote the same type. |
duke@1 | 2720 | * @param pos Position for error reporting. |
duke@1 | 2721 | * @param sym The symbol. |
duke@1 | 2722 | * @param s The scope. |
duke@1 | 2723 | * @param staticImport Whether or not this was a static import |
duke@1 | 2724 | */ |
duke@1 | 2725 | private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) { |
duke@1 | 2726 | for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) { |
duke@1 | 2727 | // is encountered class entered via a class declaration? |
duke@1 | 2728 | boolean isClassDecl = e.scope == s; |
duke@1 | 2729 | if ((isClassDecl || sym != e.sym) && |
duke@1 | 2730 | sym.kind == e.sym.kind && |
duke@1 | 2731 | sym.name != names.error) { |
duke@1 | 2732 | if (!e.sym.type.isErroneous()) { |
duke@1 | 2733 | String what = e.sym.toString(); |
duke@1 | 2734 | if (!isClassDecl) { |
duke@1 | 2735 | if (staticImport) |
duke@1 | 2736 | log.error(pos, "already.defined.static.single.import", what); |
duke@1 | 2737 | else |
duke@1 | 2738 | log.error(pos, "already.defined.single.import", what); |
duke@1 | 2739 | } |
duke@1 | 2740 | else if (sym != e.sym) |
duke@1 | 2741 | log.error(pos, "already.defined.this.unit", what); |
duke@1 | 2742 | } |
duke@1 | 2743 | return false; |
duke@1 | 2744 | } |
duke@1 | 2745 | } |
duke@1 | 2746 | return true; |
duke@1 | 2747 | } |
duke@1 | 2748 | |
duke@1 | 2749 | /** Check that a qualified name is in canonical form (for import decls). |
duke@1 | 2750 | */ |
duke@1 | 2751 | public void checkCanonical(JCTree tree) { |
duke@1 | 2752 | if (!isCanonical(tree)) |
duke@1 | 2753 | log.error(tree.pos(), "import.requires.canonical", |
duke@1 | 2754 | TreeInfo.symbol(tree)); |
duke@1 | 2755 | } |
duke@1 | 2756 | // where |
duke@1 | 2757 | private boolean isCanonical(JCTree tree) { |
jjg@1127 | 2758 | while (tree.hasTag(SELECT)) { |
duke@1 | 2759 | JCFieldAccess s = (JCFieldAccess) tree; |
duke@1 | 2760 | if (s.sym.owner != TreeInfo.symbol(s.selected)) |
duke@1 | 2761 | return false; |
duke@1 | 2762 | tree = s.selected; |
duke@1 | 2763 | } |
duke@1 | 2764 | return true; |
duke@1 | 2765 | } |
duke@1 | 2766 | |
duke@1 | 2767 | private class ConversionWarner extends Warner { |
mcimadamore@795 | 2768 | final String uncheckedKey; |
duke@1 | 2769 | final Type found; |
duke@1 | 2770 | final Type expected; |
mcimadamore@795 | 2771 | public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) { |
duke@1 | 2772 | super(pos); |
mcimadamore@795 | 2773 | this.uncheckedKey = uncheckedKey; |
duke@1 | 2774 | this.found = found; |
duke@1 | 2775 | this.expected = expected; |
duke@1 | 2776 | } |
duke@1 | 2777 | |
jjg@398 | 2778 | @Override |
mcimadamore@795 | 2779 | public void warn(LintCategory lint) { |
duke@1 | 2780 | boolean warned = this.warned; |
mcimadamore@795 | 2781 | super.warn(lint); |
duke@1 | 2782 | if (warned) return; // suppress redundant diagnostics |
mcimadamore@795 | 2783 | switch (lint) { |
mcimadamore@795 | 2784 | case UNCHECKED: |
mcimadamore@795 | 2785 | Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected); |
mcimadamore@795 | 2786 | break; |
mcimadamore@795 | 2787 | case VARARGS: |
mcimadamore@795 | 2788 | if (method != null && |
mcimadamore@795 | 2789 | method.attribute(syms.trustMeType.tsym) != null && |
mcimadamore@795 | 2790 | isTrustMeAllowedOnMethod(method) && |
mcimadamore@795 | 2791 | !types.isReifiable(method.type.getParameterTypes().last())) { |
mcimadamore@795 | 2792 | Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last()); |
mcimadamore@795 | 2793 | } |
mcimadamore@795 | 2794 | break; |
mcimadamore@795 | 2795 | default: |
mcimadamore@795 | 2796 | throw new AssertionError("Unexpected lint: " + lint); |
mcimadamore@795 | 2797 | } |
duke@1 | 2798 | } |
duke@1 | 2799 | } |
duke@1 | 2800 | |
duke@1 | 2801 | public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) { |
duke@1 | 2802 | return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected); |
duke@1 | 2803 | } |
duke@1 | 2804 | |
duke@1 | 2805 | public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) { |
duke@1 | 2806 | return new ConversionWarner(pos, "unchecked.assign", found, expected); |
duke@1 | 2807 | } |
duke@1 | 2808 | } |