src/share/classes/com/sun/tools/javac/comp/Check.java

Tue, 26 Feb 2013 09:04:19 +0000

author
vromero
date
Tue, 26 Feb 2013 09:04:19 +0000
changeset 1607
bd49e0304281
parent 1603
6118072811e5
child 1613
d2a98dde7ecc
permissions
-rw-r--r--

8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
Reviewed-by: jjg, mcimadamore

duke@1 1 /*
jjg@1492 2 * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
jjg@1521 29
ohrstrom@1384 30 import javax.tools.JavaFileManager;
duke@1 31
duke@1 32 import com.sun.tools.javac.code.*;
duke@1 33 import com.sun.tools.javac.jvm.*;
duke@1 34 import com.sun.tools.javac.tree.*;
duke@1 35 import com.sun.tools.javac.util.*;
duke@1 36 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 37 import com.sun.tools.javac.util.List;
duke@1 38
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 43 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 44 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1550 45 import com.sun.tools.javac.comp.Infer.FreeTypeListener;
mcimadamore@1510 46 import com.sun.tools.javac.tree.JCTree.*;
mcimadamore@1510 47 import com.sun.tools.javac.tree.JCTree.JCPolyExpression.*;
duke@1 48
duke@1 49 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 50 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 51 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 52 import static com.sun.tools.javac.code.Kinds.*;
jjg@1374 53 import static com.sun.tools.javac.code.TypeTag.*;
jjg@1374 54 import static com.sun.tools.javac.code.TypeTag.WILDCARD;
duke@1 55
jjg@1127 56 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 57
duke@1 58 /** Type checking helper class for the attribution phase.
duke@1 59 *
jjg@581 60 * <p><b>This is NOT part of any supported API.
jjg@581 61 * If you write code that depends on this, you do so at your own risk.
duke@1 62 * This code and its internal interfaces are subject to change or
duke@1 63 * deletion without notice.</b>
duke@1 64 */
duke@1 65 public class Check {
duke@1 66 protected static final Context.Key<Check> checkKey =
duke@1 67 new Context.Key<Check>();
duke@1 68
jjg@113 69 private final Names names;
duke@1 70 private final Log log;
mcimadamore@1219 71 private final Resolve rs;
duke@1 72 private final Symtab syms;
mcimadamore@690 73 private final Enter enter;
mcimadamore@1347 74 private final DeferredAttr deferredAttr;
duke@1 75 private final Infer infer;
duke@1 76 private final Types types;
mcimadamore@89 77 private final JCDiagnostic.Factory diags;
mcimadamore@359 78 private boolean warnOnSyntheticConflicts;
jjg@576 79 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 80 private boolean enableSunApiLintControl;
duke@1 81 private final TreeInfo treeinfo;
ohrstrom@1384 82 private final JavaFileManager fileManager;
jjg@1569 83 private final Profile profile;
duke@1 84
duke@1 85 // The set of lint options currently in effect. It is initialized
duke@1 86 // from the context, and then is set/reset as needed by Attr as it
duke@1 87 // visits all the various parts of the trees during attribution.
duke@1 88 private Lint lint;
duke@1 89
mcimadamore@795 90 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 91 // Attr as it visits new method declarations.
mcimadamore@795 92 private MethodSymbol method;
mcimadamore@795 93
duke@1 94 public static Check instance(Context context) {
duke@1 95 Check instance = context.get(checkKey);
duke@1 96 if (instance == null)
duke@1 97 instance = new Check(context);
duke@1 98 return instance;
duke@1 99 }
duke@1 100
duke@1 101 protected Check(Context context) {
duke@1 102 context.put(checkKey, this);
duke@1 103
jjg@113 104 names = Names.instance(context);
jjg@1521 105 dfltTargetMeta = new Name[] { names.PACKAGE, names.TYPE,
jjg@1521 106 names.FIELD, names.METHOD, names.CONSTRUCTOR,
jjg@1521 107 names.ANNOTATION_TYPE, names.LOCAL_VARIABLE, names.PARAMETER};
duke@1 108 log = Log.instance(context);
mcimadamore@1219 109 rs = Resolve.instance(context);
duke@1 110 syms = Symtab.instance(context);
mcimadamore@690 111 enter = Enter.instance(context);
mcimadamore@1347 112 deferredAttr = DeferredAttr.instance(context);
duke@1 113 infer = Infer.instance(context);
jjg@1569 114 types = Types.instance(context);
mcimadamore@89 115 diags = JCDiagnostic.Factory.instance(context);
duke@1 116 Options options = Options.instance(context);
duke@1 117 lint = Lint.instance(context);
duke@1 118 treeinfo = TreeInfo.instance(context);
ohrstrom@1384 119 fileManager = context.get(JavaFileManager.class);
duke@1 120
duke@1 121 Source source = Source.instance(context);
duke@1 122 allowGenerics = source.allowGenerics();
mcimadamore@1219 123 allowVarargs = source.allowVarargs();
duke@1 124 allowAnnotations = source.allowAnnotations();
jjg@398 125 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 126 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
mcimadamore@1393 127 allowDefaultMethods = source.allowDefaultMethods();
mcimadamore@1415 128 allowStrictMethodClashCheck = source.allowStrictMethodClashCheck();
jjg@1157 129 complexInference = options.isSet("complexinference");
jjg@700 130 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 131 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 132 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 133
jjg@398 134 Target target = Target.instance(context);
jjg@398 135 syntheticNameChar = target.syntheticNameChar();
jjg@398 136
jjg@1569 137 profile = Profile.instance(context);
jjg@1569 138
duke@1 139 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 140 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 141 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 142 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 143
jjg@60 144 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 145 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 146 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 147 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 148 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 149 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 150
mcimadamore@852 151 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 152 }
duke@1 153
duke@1 154 /** Switch: generics enabled?
duke@1 155 */
duke@1 156 boolean allowGenerics;
duke@1 157
mcimadamore@1219 158 /** Switch: varargs enabled?
mcimadamore@1219 159 */
mcimadamore@1219 160 boolean allowVarargs;
mcimadamore@1219 161
duke@1 162 /** Switch: annotations enabled?
duke@1 163 */
duke@1 164 boolean allowAnnotations;
duke@1 165
jjg@398 166 /** Switch: covariant returns enabled?
jjg@398 167 */
jjg@398 168 boolean allowCovariantReturns;
jjg@398 169
mcimadamore@795 170 /** Switch: simplified varargs enabled?
mcimadamore@795 171 */
mcimadamore@795 172 boolean allowSimplifiedVarargs;
mcimadamore@795 173
mcimadamore@1393 174 /** Switch: default methods enabled?
mcimadamore@1393 175 */
mcimadamore@1393 176 boolean allowDefaultMethods;
mcimadamore@1393 177
mcimadamore@1393 178 /** Switch: should unrelated return types trigger a method clash?
mcimadamore@1393 179 */
mcimadamore@1393 180 boolean allowStrictMethodClashCheck;
mcimadamore@1393 181
duke@1 182 /** Switch: -complexinference option set?
duke@1 183 */
duke@1 184 boolean complexInference;
duke@1 185
jjg@398 186 /** Character for synthetic names
jjg@398 187 */
jjg@398 188 char syntheticNameChar;
jjg@398 189
duke@1 190 /** A table mapping flat names of all compiled classes in this run to their
duke@1 191 * symbols; maintained from outside.
duke@1 192 */
duke@1 193 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 194
duke@1 195 /** A handler for messages about deprecated usage.
duke@1 196 */
duke@1 197 private MandatoryWarningHandler deprecationHandler;
duke@1 198
duke@1 199 /** A handler for messages about unchecked or unsafe usage.
duke@1 200 */
duke@1 201 private MandatoryWarningHandler uncheckedHandler;
duke@1 202
jjg@582 203 /** A handler for messages about using proprietary API.
jjg@377 204 */
jjg@377 205 private MandatoryWarningHandler sunApiHandler;
duke@1 206
mcimadamore@852 207 /** A handler for deferred lint warnings.
mcimadamore@852 208 */
mcimadamore@852 209 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 210
duke@1 211 /* *************************************************************************
duke@1 212 * Errors and Warnings
duke@1 213 **************************************************************************/
duke@1 214
duke@1 215 Lint setLint(Lint newLint) {
duke@1 216 Lint prev = lint;
duke@1 217 lint = newLint;
duke@1 218 return prev;
duke@1 219 }
duke@1 220
mcimadamore@852 221 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 222 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 223 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 224 return prev;
mcimadamore@852 225 }
mcimadamore@852 226
mcimadamore@795 227 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 228 MethodSymbol prev = method;
mcimadamore@795 229 method = newMethod;
mcimadamore@795 230 return prev;
mcimadamore@795 231 }
mcimadamore@795 232
duke@1 233 /** Warn about deprecated symbol.
duke@1 234 * @param pos Position to be used for error reporting.
duke@1 235 * @param sym The deprecated symbol.
duke@1 236 */
duke@1 237 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 238 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 239 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 240 }
duke@1 241
duke@1 242 /** Warn about unchecked operation.
duke@1 243 * @param pos Position to be used for error reporting.
duke@1 244 * @param msg A string describing the problem.
duke@1 245 */
duke@1 246 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 247 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 248 uncheckedHandler.report(pos, msg, args);
duke@1 249 }
duke@1 250
mcimadamore@580 251 /** Warn about unsafe vararg method decl.
mcimadamore@580 252 * @param pos Position to be used for error reporting.
mcimadamore@580 253 */
mcimadamore@795 254 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 255 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 256 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 257 }
mcimadamore@580 258
jjg@582 259 /** Warn about using proprietary API.
jjg@377 260 * @param pos Position to be used for error reporting.
jjg@377 261 * @param msg A string describing the problem.
jjg@377 262 */
jjg@377 263 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 264 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 265 sunApiHandler.report(pos, msg, args);
jjg@377 266 }
jjg@377 267
jjg@505 268 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 269 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 270 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 271 }
jjg@505 272
duke@1 273 /**
duke@1 274 * Report any deferred diagnostics.
duke@1 275 */
duke@1 276 public void reportDeferredDiagnostics() {
duke@1 277 deprecationHandler.reportDeferredDiagnostic();
duke@1 278 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 279 sunApiHandler.reportDeferredDiagnostic();
duke@1 280 }
duke@1 281
duke@1 282
duke@1 283 /** Report a failure to complete a class.
duke@1 284 * @param pos Position to be used for error reporting.
duke@1 285 * @param ex The failure to report.
duke@1 286 */
duke@1 287 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 288 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 289 if (ex instanceof ClassReader.BadClassFile
jjg@576 290 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 291 else return syms.errType;
duke@1 292 }
duke@1 293
duke@1 294 /** Report an error that wrong type tag was found.
duke@1 295 * @param pos Position to be used for error reporting.
duke@1 296 * @param required An internationalized string describing the type tag
duke@1 297 * required.
duke@1 298 * @param found The type that was found.
duke@1 299 */
duke@1 300 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 301 // this error used to be raised by the parser,
jrose@267 302 // but has been delayed to this point:
jjg@1374 303 if (found instanceof Type && ((Type)found).hasTag(VOID)) {
jrose@267 304 log.error(pos, "illegal.start.of.type");
jrose@267 305 return syms.errType;
jrose@267 306 }
duke@1 307 log.error(pos, "type.found.req", found, required);
jjg@110 308 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 309 }
duke@1 310
duke@1 311 /** Report an error that symbol cannot be referenced before super
duke@1 312 * has been called.
duke@1 313 * @param pos Position to be used for error reporting.
duke@1 314 * @param sym The referenced symbol.
duke@1 315 */
duke@1 316 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 317 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 318 }
duke@1 319
duke@1 320 /** Report duplicate declaration error.
duke@1 321 */
duke@1 322 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 323 if (!sym.type.isErroneous()) {
mcimadamore@1085 324 Symbol location = sym.location();
mcimadamore@1085 325 if (location.kind == MTH &&
mcimadamore@1085 326 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 327 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 328 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 329 sym.location().enclClass());
mcimadamore@1085 330 } else {
mcimadamore@1085 331 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 332 kindName(sym.location()), sym.location());
mcimadamore@1085 333 }
duke@1 334 }
duke@1 335 }
duke@1 336
duke@1 337 /** Report array/varargs duplicate declaration
duke@1 338 */
duke@1 339 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 340 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 341 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 342 }
duke@1 343 }
duke@1 344
duke@1 345 /* ************************************************************************
duke@1 346 * duplicate declaration checking
duke@1 347 *************************************************************************/
duke@1 348
duke@1 349 /** Check that variable does not hide variable with same name in
duke@1 350 * immediately enclosing local scope.
duke@1 351 * @param pos Position for error reporting.
duke@1 352 * @param v The symbol.
duke@1 353 * @param s The scope.
duke@1 354 */
duke@1 355 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 356 if (s.next != null) {
duke@1 357 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 358 e.scope != null && e.sym.owner == v.owner;
duke@1 359 e = e.next()) {
duke@1 360 if (e.sym.kind == VAR &&
duke@1 361 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 362 v.name != names.error) {
duke@1 363 duplicateError(pos, e.sym);
duke@1 364 return;
duke@1 365 }
duke@1 366 }
duke@1 367 }
duke@1 368 }
duke@1 369
duke@1 370 /** Check that a class or interface does not hide a class or
duke@1 371 * interface with same name in immediately enclosing local scope.
duke@1 372 * @param pos Position for error reporting.
duke@1 373 * @param c The symbol.
duke@1 374 * @param s The scope.
duke@1 375 */
duke@1 376 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 377 if (s.next != null) {
duke@1 378 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 379 e.scope != null && e.sym.owner == c.owner;
duke@1 380 e = e.next()) {
jjg@1374 381 if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) &&
duke@1 382 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 383 c.name != names.error) {
duke@1 384 duplicateError(pos, e.sym);
duke@1 385 return;
duke@1 386 }
duke@1 387 }
duke@1 388 }
duke@1 389 }
duke@1 390
duke@1 391 /** Check that class does not have the same name as one of
duke@1 392 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 393 * return true if class is unique in its enclosing scope.
duke@1 394 * @param pos Position for error reporting.
duke@1 395 * @param name The class name.
duke@1 396 * @param s The enclosing scope.
duke@1 397 */
duke@1 398 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 399 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 400 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 401 duplicateError(pos, e.sym);
duke@1 402 return false;
duke@1 403 }
duke@1 404 }
duke@1 405 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 406 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 407 duplicateError(pos, sym);
duke@1 408 return true;
duke@1 409 }
duke@1 410 }
duke@1 411 return true;
duke@1 412 }
duke@1 413
duke@1 414 /* *************************************************************************
duke@1 415 * Class name generation
duke@1 416 **************************************************************************/
duke@1 417
duke@1 418 /** Return name of local class.
jjg@1358 419 * This is of the form {@code <enclClass> $ n <classname> }
duke@1 420 * where
duke@1 421 * enclClass is the flat name of the enclosing class,
duke@1 422 * classname is the simple name of the local class
duke@1 423 */
duke@1 424 Name localClassName(ClassSymbol c) {
duke@1 425 for (int i=1; ; i++) {
duke@1 426 Name flatname = names.
duke@1 427 fromString("" + c.owner.enclClass().flatname +
jjg@398 428 syntheticNameChar + i +
duke@1 429 c.name);
duke@1 430 if (compiled.get(flatname) == null) return flatname;
duke@1 431 }
duke@1 432 }
duke@1 433
duke@1 434 /* *************************************************************************
duke@1 435 * Type Checking
duke@1 436 **************************************************************************/
duke@1 437
mcimadamore@1238 438 /**
mcimadamore@1238 439 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 440 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 441 * vary significantly.
mcimadamore@1238 442 */
mcimadamore@1348 443 public interface CheckContext {
mcimadamore@1238 444 /**
mcimadamore@1238 445 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 446 */
mcimadamore@1238 447 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 448 /**
mcimadamore@1238 449 * Report a check error
mcimadamore@1238 450 */
mcimadamore@1296 451 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 452 /**
mcimadamore@1238 453 * Obtain a warner for this check context
mcimadamore@1238 454 */
mcimadamore@1238 455 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 456
mcimadamore@1337 457 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 458
mcimadamore@1347 459 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1238 460 }
mcimadamore@1238 461
mcimadamore@1238 462 /**
mcimadamore@1238 463 * This class represent a check context that is nested within another check
mcimadamore@1238 464 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 465 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 466 * the forwarding pattern.
mcimadamore@1238 467 */
mcimadamore@1238 468 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 469 CheckContext enclosingContext;
mcimadamore@1238 470
mcimadamore@1238 471 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 472 this.enclosingContext = enclosingContext;
mcimadamore@1238 473 }
mcimadamore@1238 474
mcimadamore@1238 475 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 476 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 477 }
mcimadamore@1238 478
mcimadamore@1296 479 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 480 enclosingContext.report(pos, details);
mcimadamore@1238 481 }
mcimadamore@1238 482
mcimadamore@1238 483 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 484 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 485 }
mcimadamore@1337 486
mcimadamore@1337 487 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 488 return enclosingContext.inferenceContext();
mcimadamore@1337 489 }
mcimadamore@1347 490
mcimadamore@1347 491 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 492 return enclosingContext.deferredAttrContext();
mcimadamore@1347 493 }
mcimadamore@1238 494 }
mcimadamore@1238 495
mcimadamore@1238 496 /**
mcimadamore@1238 497 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 498 */
mcimadamore@1238 499 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 500 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 501 log.error(pos, "prob.found.req", details);
mcimadamore@1238 502 }
mcimadamore@1238 503 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 504 return types.isAssignable(found, req, warn);
mcimadamore@1238 505 }
mcimadamore@1238 506
mcimadamore@1238 507 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 508 return convertWarner(pos, found, req);
mcimadamore@1238 509 }
mcimadamore@1337 510
mcimadamore@1337 511 public InferenceContext inferenceContext() {
mcimadamore@1337 512 return infer.emptyContext;
mcimadamore@1337 513 }
mcimadamore@1347 514
mcimadamore@1347 515 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 516 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 517 }
mcimadamore@1238 518 };
mcimadamore@1238 519
duke@1 520 /** Check that a given type is assignable to a given proto-type.
duke@1 521 * If it is, return the type, otherwise return errType.
duke@1 522 * @param pos Position to be used for error reporting.
duke@1 523 * @param found The type that was found.
duke@1 524 * @param req The type that was required.
duke@1 525 */
duke@1 526 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 527 return checkType(pos, found, req, basicHandler);
darcy@609 528 }
darcy@609 529
mcimadamore@1337 530 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 531 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 532 if (inferenceContext.free(req)) {
mcimadamore@1337 533 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 534 @Override
mcimadamore@1337 535 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1550 536 checkType(pos, found, inferenceContext.asInstType(req), checkContext);
mcimadamore@1337 537 }
mcimadamore@1337 538 });
mcimadamore@1337 539 }
jjg@1374 540 if (req.hasTag(ERROR))
duke@1 541 return req;
jjg@1374 542 if (req.hasTag(NONE))
duke@1 543 return found;
mcimadamore@1238 544 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 545 return found;
mcimadamore@1238 546 } else {
jjg@1374 547 if (found.getTag().isSubRangeOf(DOUBLE) && req.getTag().isSubRangeOf(DOUBLE)) {
mcimadamore@1296 548 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 549 return types.createErrorType(found);
mcimadamore@1238 550 }
mcimadamore@1296 551 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 552 return types.createErrorType(found);
duke@1 553 }
duke@1 554 }
duke@1 555
duke@1 556 /** Check that a given type can be cast to a given target type.
duke@1 557 * Return the result of the cast.
duke@1 558 * @param pos Position to be used for error reporting.
duke@1 559 * @param found The type that is being cast.
duke@1 560 * @param req The target type of the cast.
duke@1 561 */
duke@1 562 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 563 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 564 }
mcimadamore@1238 565 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 566 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 567 return req;
duke@1 568 } else {
mcimadamore@1296 569 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 570 return types.createErrorType(found);
duke@1 571 }
duke@1 572 }
mcimadamore@1237 573
mcimadamore@1237 574 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 575 * The problem should only be reported for non-292 cast
mcimadamore@1237 576 */
mcimadamore@1237 577 public void checkRedundantCast(Env<AttrContext> env, JCTypeCast tree) {
mcimadamore@1237 578 if (!tree.type.isErroneous() &&
mcimadamore@1348 579 (env.info.lint == null || env.info.lint.isEnabled(Lint.LintCategory.CAST))
mcimadamore@1348 580 && types.isSameType(tree.expr.type, tree.clazz.type)
jjg@1521 581 && !(ignoreAnnotatedCasts && TreeInfo.containsTypeAnnotation(tree.clazz))
mcimadamore@1348 582 && !is292targetTypeCast(tree)) {
mcimadamore@1237 583 log.warning(Lint.LintCategory.CAST,
mcimadamore@1237 584 tree.pos(), "redundant.cast", tree.expr.type);
mcimadamore@1237 585 }
mcimadamore@1237 586 }
mcimadamore@1237 587 //where
jjg@1521 588 private boolean is292targetTypeCast(JCTypeCast tree) {
jjg@1521 589 boolean is292targetTypeCast = false;
jjg@1521 590 JCExpression expr = TreeInfo.skipParens(tree.expr);
jjg@1521 591 if (expr.hasTag(APPLY)) {
jjg@1521 592 JCMethodInvocation apply = (JCMethodInvocation)expr;
jjg@1521 593 Symbol sym = TreeInfo.symbol(apply.meth);
jjg@1521 594 is292targetTypeCast = sym != null &&
jjg@1521 595 sym.kind == MTH &&
jjg@1521 596 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 597 }
jjg@1521 598 return is292targetTypeCast;
jjg@1521 599 }
mcimadamore@1237 600
jjg@1521 601 private static final boolean ignoreAnnotatedCasts = true;
duke@1 602
duke@1 603 /** Check that a type is within some bounds.
duke@1 604 *
jjg@1358 605 * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
duke@1 606 * type argument.
duke@1 607 * @param a The type that should be bounded by bs.
jjg@1358 608 * @param bound The bound.
duke@1 609 */
mcimadamore@1216 610 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 611 if (a.isUnbound()) {
mcimadamore@821 612 return true;
jjg@1374 613 } else if (!a.hasTag(WILDCARD)) {
mcimadamore@154 614 a = types.upperBound(a);
mcimadamore@1216 615 return types.isSubtype(a, bound);
mcimadamore@154 616 } else if (a.isExtendsBound()) {
mcimadamore@1415 617 return types.isCastable(bound, types.upperBound(a), types.noWarnings);
mcimadamore@154 618 } else if (a.isSuperBound()) {
mcimadamore@1216 619 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 620 }
mcimadamore@821 621 return true;
mcimadamore@154 622 }
duke@1 623
duke@1 624 /** Check that type is different from 'void'.
duke@1 625 * @param pos Position to be used for error reporting.
duke@1 626 * @param t The type to be checked.
duke@1 627 */
duke@1 628 Type checkNonVoid(DiagnosticPosition pos, Type t) {
jjg@1374 629 if (t.hasTag(VOID)) {
duke@1 630 log.error(pos, "void.not.allowed.here");
jjg@110 631 return types.createErrorType(t);
duke@1 632 } else {
duke@1 633 return t;
duke@1 634 }
duke@1 635 }
duke@1 636
mcimadamore@1496 637 Type checkClassOrArrayType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 638 if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
mcimadamore@1496 639 return typeTagError(pos,
mcimadamore@1496 640 diags.fragment("type.req.class.array"),
mcimadamore@1496 641 asTypeParam(t));
mcimadamore@1496 642 } else {
mcimadamore@1496 643 return t;
mcimadamore@1496 644 }
mcimadamore@1496 645 }
mcimadamore@1496 646
duke@1 647 /** Check that type is a class or interface type.
duke@1 648 * @param pos Position to be used for error reporting.
duke@1 649 * @param t The type to be checked.
duke@1 650 */
duke@1 651 Type checkClassType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 652 if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) {
duke@1 653 return typeTagError(pos,
mcimadamore@89 654 diags.fragment("type.req.class"),
mcimadamore@1496 655 asTypeParam(t));
mcimadamore@1496 656 } else {
duke@1 657 return t;
mcimadamore@1496 658 }
duke@1 659 }
mcimadamore@1496 660 //where
mcimadamore@1496 661 private Object asTypeParam(Type t) {
mcimadamore@1496 662 return (t.hasTag(TYPEVAR))
mcimadamore@1496 663 ? diags.fragment("type.parameter", t)
mcimadamore@1496 664 : t;
mcimadamore@1496 665 }
duke@1 666
mcimadamore@1352 667 /** Check that type is a valid qualifier for a constructor reference expression
mcimadamore@1352 668 */
mcimadamore@1352 669 Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 670 t = checkClassOrArrayType(pos, t);
jjg@1374 671 if (t.hasTag(CLASS)) {
mcimadamore@1352 672 if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
mcimadamore@1352 673 log.error(pos, "abstract.cant.be.instantiated");
mcimadamore@1352 674 t = types.createErrorType(t);
mcimadamore@1352 675 } else if ((t.tsym.flags() & ENUM) != 0) {
mcimadamore@1352 676 log.error(pos, "enum.cant.be.instantiated");
mcimadamore@1352 677 t = types.createErrorType(t);
mcimadamore@1352 678 }
mcimadamore@1352 679 }
mcimadamore@1352 680 return t;
mcimadamore@1352 681 }
mcimadamore@1352 682
duke@1 683 /** Check that type is a class or interface type.
duke@1 684 * @param pos Position to be used for error reporting.
duke@1 685 * @param t The type to be checked.
duke@1 686 * @param noBounds True if type bounds are illegal here.
duke@1 687 */
duke@1 688 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 689 t = checkClassType(pos, t);
duke@1 690 if (noBounds && t.isParameterized()) {
duke@1 691 List<Type> args = t.getTypeArguments();
duke@1 692 while (args.nonEmpty()) {
jjg@1374 693 if (args.head.hasTag(WILDCARD))
duke@1 694 return typeTagError(pos,
jjg@598 695 diags.fragment("type.req.exact"),
duke@1 696 args.head);
duke@1 697 args = args.tail;
duke@1 698 }
duke@1 699 }
duke@1 700 return t;
duke@1 701 }
duke@1 702
duke@1 703 /** Check that type is a reifiable class, interface or array type.
duke@1 704 * @param pos Position to be used for error reporting.
duke@1 705 * @param t The type to be checked.
duke@1 706 */
duke@1 707 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 708 t = checkClassOrArrayType(pos, t);
mcimadamore@1496 709 if (!t.isErroneous() && !types.isReifiable(t)) {
duke@1 710 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 711 return types.createErrorType(t);
duke@1 712 } else {
duke@1 713 return t;
duke@1 714 }
duke@1 715 }
duke@1 716
duke@1 717 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 718 * or a type variable.
duke@1 719 * @param pos Position to be used for error reporting.
duke@1 720 * @param t The type to be checked.
duke@1 721 */
duke@1 722 Type checkRefType(DiagnosticPosition pos, Type t) {
jjg@1374 723 if (t.isReference())
duke@1 724 return t;
jjg@1374 725 else
duke@1 726 return typeTagError(pos,
mcimadamore@89 727 diags.fragment("type.req.ref"),
duke@1 728 t);
duke@1 729 }
duke@1 730
jrose@267 731 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 732 * or a type variable.
jrose@267 733 * @param trees Original trees, used for error reporting.
jrose@267 734 * @param types The types to be checked.
jrose@267 735 */
jrose@267 736 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 737 List<JCExpression> tl = trees;
jrose@267 738 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 739 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 740 tl = tl.tail;
jrose@267 741 }
jrose@267 742 return types;
jrose@267 743 }
jrose@267 744
duke@1 745 /** Check that type is a null or reference type.
duke@1 746 * @param pos Position to be used for error reporting.
duke@1 747 * @param t The type to be checked.
duke@1 748 */
duke@1 749 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
jjg@1374 750 if (t.isNullOrReference())
duke@1 751 return t;
jjg@1374 752 else
duke@1 753 return typeTagError(pos,
mcimadamore@89 754 diags.fragment("type.req.ref"),
duke@1 755 t);
duke@1 756 }
duke@1 757
duke@1 758 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 759 * Return true if it doesn't.
duke@1 760 * @param pos Position to be used for error reporting.
duke@1 761 * @param flags The set of flags to be checked.
duke@1 762 * @param set1 Conflicting flags set #1.
duke@1 763 * @param set2 Conflicting flags set #2.
duke@1 764 */
duke@1 765 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 766 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 767 log.error(pos,
duke@1 768 "illegal.combination.of.modifiers",
mcimadamore@80 769 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 770 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 771 return false;
duke@1 772 } else
duke@1 773 return true;
duke@1 774 }
duke@1 775
mcimadamore@914 776 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 777 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 778 */
mcimadamore@914 779 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 780 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 781 t.isErroneous()) {
mcimadamore@914 782 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 783 } else if (tree.def != null) {
mcimadamore@914 784 log.error(tree.clazz.pos(),
mcimadamore@914 785 "cant.apply.diamond.1",
mcimadamore@914 786 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 787 return types.createErrorType(t);
mcimadamore@948 788 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 789 log.error(tree.clazz.pos(),
mcimadamore@914 790 "cant.apply.diamond.1",
mcimadamore@914 791 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 792 return types.createErrorType(t);
mcimadamore@993 793 } else if (tree.typeargs != null &&
mcimadamore@993 794 tree.typeargs.nonEmpty()) {
mcimadamore@993 795 log.error(tree.clazz.pos(),
mcimadamore@993 796 "cant.apply.diamond.1",
mcimadamore@993 797 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 798 return types.createErrorType(t);
mcimadamore@914 799 } else {
mcimadamore@914 800 return t;
mcimadamore@537 801 }
mcimadamore@537 802 }
mcimadamore@537 803
mcimadamore@795 804 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 805 MethodSymbol m = tree.sym;
mcimadamore@795 806 if (!allowSimplifiedVarargs) return;
mcimadamore@795 807 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 808 Type varargElemType = null;
mcimadamore@580 809 if (m.isVarArgs()) {
mcimadamore@795 810 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 811 }
mcimadamore@795 812 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 813 if (varargElemType != null) {
mcimadamore@795 814 log.error(tree,
mcimadamore@795 815 "varargs.invalid.trustme.anno",
mcimadamore@795 816 syms.trustMeType.tsym,
mcimadamore@795 817 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 818 } else {
mcimadamore@795 819 log.error(tree,
mcimadamore@795 820 "varargs.invalid.trustme.anno",
mcimadamore@795 821 syms.trustMeType.tsym,
mcimadamore@795 822 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 823 }
mcimadamore@795 824 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 825 types.isReifiable(varargElemType)) {
mcimadamore@795 826 warnUnsafeVararg(tree,
mcimadamore@795 827 "varargs.redundant.trustme.anno",
mcimadamore@795 828 syms.trustMeType.tsym,
mcimadamore@795 829 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 830 }
mcimadamore@795 831 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 832 !types.isReifiable(varargElemType)) {
mcimadamore@795 833 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 834 }
mcimadamore@580 835 }
mcimadamore@795 836 //where
mcimadamore@795 837 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 838 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 839 (s.isConstructor() ||
mcimadamore@795 840 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 841 }
mcimadamore@580 842
mcimadamore@1219 843 Type checkMethod(Type owntype,
mcimadamore@1219 844 Symbol sym,
mcimadamore@1219 845 Env<AttrContext> env,
mcimadamore@1219 846 final List<JCExpression> argtrees,
mcimadamore@1219 847 List<Type> argtypes,
mcimadamore@1226 848 boolean useVarargs,
mcimadamore@1226 849 boolean unchecked) {
mcimadamore@1219 850 // System.out.println("call : " + env.tree);
mcimadamore@1219 851 // System.out.println("method : " + owntype);
mcimadamore@1219 852 // System.out.println("actuals: " + argtypes);
mcimadamore@1219 853 List<Type> formals = owntype.getParameterTypes();
mcimadamore@1219 854 Type last = useVarargs ? formals.last() : null;
jjg@1521 855 if (sym.name == names.init &&
mcimadamore@1219 856 sym.owner == syms.enumSym)
mcimadamore@1219 857 formals = formals.tail.tail;
mcimadamore@1219 858 List<JCExpression> args = argtrees;
mcimadamore@1347 859 DeferredAttr.DeferredTypeMap checkDeferredMap =
mcimadamore@1347 860 deferredAttr.new DeferredTypeMap(DeferredAttr.AttrMode.CHECK, sym, env.info.pendingResolutionPhase);
mcimadamore@1352 861 if (args != null) {
mcimadamore@1352 862 //this is null when type-checking a method reference
mcimadamore@1352 863 while (formals.head != last) {
mcimadamore@1219 864 JCTree arg = args.head;
mcimadamore@1352 865 Warner warn = convertWarner(arg.pos(), arg.type, formals.head);
mcimadamore@1352 866 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 867 args = args.tail;
mcimadamore@1352 868 formals = formals.tail;
mcimadamore@1219 869 }
mcimadamore@1352 870 if (useVarargs) {
mcimadamore@1352 871 Type varArg = types.elemtype(last);
mcimadamore@1352 872 while (args.tail != null) {
mcimadamore@1352 873 JCTree arg = args.head;
mcimadamore@1352 874 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1352 875 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1352 876 args = args.tail;
mcimadamore@1352 877 }
mcimadamore@1352 878 } else if ((sym.flags() & VARARGS) != 0 && allowVarargs) {
mcimadamore@1352 879 // non-varargs call to varargs method
mcimadamore@1352 880 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1352 881 Type lastArg = checkDeferredMap.apply(argtypes.last());
mcimadamore@1352 882 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
mcimadamore@1352 883 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1352 884 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
mcimadamore@1352 885 types.elemtype(varParam), varParam);
mcimadamore@1352 886 }
mcimadamore@1219 887 }
mcimadamore@1226 888 if (unchecked) {
mcimadamore@1219 889 warnUnchecked(env.tree.pos(),
mcimadamore@1219 890 "unchecked.meth.invocation.applied",
mcimadamore@1219 891 kindName(sym),
mcimadamore@1219 892 sym.name,
mcimadamore@1219 893 rs.methodArguments(sym.type.getParameterTypes()),
mcimadamore@1347 894 rs.methodArguments(Type.map(argtypes, checkDeferredMap)),
mcimadamore@1219 895 kindName(sym.location()),
mcimadamore@1219 896 sym.location());
mcimadamore@1219 897 owntype = new MethodType(owntype.getParameterTypes(),
mcimadamore@1219 898 types.erasure(owntype.getReturnType()),
mcimadamore@1219 899 types.erasure(owntype.getThrownTypes()),
mcimadamore@1219 900 syms.methodClass);
mcimadamore@1219 901 }
mcimadamore@1219 902 if (useVarargs) {
mcimadamore@1219 903 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 904 if (!types.isReifiable(argtype) &&
mcimadamore@1219 905 (!allowSimplifiedVarargs ||
mcimadamore@1219 906 sym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@1219 907 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 908 warnUnchecked(env.tree.pos(),
mcimadamore@1219 909 "unchecked.generic.array.creation",
mcimadamore@1219 910 argtype);
mcimadamore@1219 911 }
mcimadamore@1415 912 if (!((MethodSymbol)sym.baseSymbol()).isSignaturePolymorphic(types)) {
mcimadamore@1510 913 TreeInfo.setVarargsElement(env.tree, types.elemtype(argtype));
mcimadamore@1219 914 }
mcimadamore@1219 915 }
mcimadamore@1510 916 PolyKind pkind = (sym.type.hasTag(FORALL) &&
mcimadamore@1510 917 sym.type.getReturnType().containsAny(((ForAll)sym.type).tvars)) ?
mcimadamore@1510 918 PolyKind.POLY : PolyKind.STANDALONE;
mcimadamore@1510 919 TreeInfo.setPolyKind(env.tree, pkind);
mcimadamore@1219 920 return owntype;
mcimadamore@547 921 }
mcimadamore@1219 922 //where
mcimadamore@1219 923 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
mcimadamore@1219 924 if (types.isConvertible(actual, formal, warn))
mcimadamore@1219 925 return;
mcimadamore@1219 926
mcimadamore@1219 927 if (formal.isCompound()
mcimadamore@1219 928 && types.isSubtype(actual, types.supertype(formal))
mcimadamore@1219 929 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
mcimadamore@1219 930 return;
mcimadamore@1219 931 }
mcimadamore@547 932
mcimadamore@821 933 /**
mcimadamore@821 934 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 935 * (see JLS 4.5)
mcimadamore@821 936 *
mcimadamore@821 937 * @param t class type to be checked
mcimadamore@821 938 * @return true if 't' is well-formed
mcimadamore@821 939 */
mcimadamore@821 940 public boolean checkValidGenericType(Type t) {
mcimadamore@821 941 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 942 }
mcimadamore@821 943 //WHERE
mcimadamore@821 944 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 945 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 946 List<Type> actuals = type.allparams();
mcimadamore@821 947 List<Type> args = type.getTypeArguments();
mcimadamore@821 948 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 949 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 950
mcimadamore@821 951 // For matching pairs of actual argument types `a' and
mcimadamore@821 952 // formal type parameters with declared bound `b' ...
mcimadamore@821 953 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 954 // exact type arguments needs to know their
mcimadamore@821 955 // bounds (for upper and lower bound
mcimadamore@1216 956 // calculations). So we create new bounds where
mcimadamore@1216 957 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 958 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 959 args = args.tail;
mcimadamore@821 960 forms = forms.tail;
mcimadamore@821 961 }
mcimadamore@821 962
mcimadamore@821 963 args = type.getTypeArguments();
mcimadamore@821 964 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 965 formals,
mcimadamore@821 966 types.capture(type).allparams());
mcimadamore@821 967 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 968 // Let the actual arguments know their bound
mcimadamore@821 969 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 970 args = args.tail;
mcimadamore@821 971 tvars_cap = tvars_cap.tail;
mcimadamore@821 972 }
mcimadamore@821 973
mcimadamore@821 974 args = type.getTypeArguments();
mcimadamore@1216 975 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 976
mcimadamore@1216 977 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 978 Type actual = args.head;
mcimadamore@854 979 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 980 !bounds.head.isErroneous() &&
mcimadamore@1216 981 !checkExtends(actual, bounds.head)) {
mcimadamore@821 982 return args.head;
mcimadamore@821 983 }
mcimadamore@821 984 args = args.tail;
mcimadamore@1216 985 bounds = bounds.tail;
mcimadamore@821 986 }
mcimadamore@821 987
mcimadamore@821 988 args = type.getTypeArguments();
mcimadamore@1216 989 bounds = bounds_buf.toList();
mcimadamore@821 990
mcimadamore@821 991 for (Type arg : types.capture(type).getTypeArguments()) {
jjg@1374 992 if (arg.hasTag(TYPEVAR) &&
mcimadamore@828 993 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 994 !bounds.head.isErroneous() &&
mcimadamore@854 995 !isTypeArgErroneous(args.head)) {
mcimadamore@821 996 return args.head;
mcimadamore@821 997 }
mcimadamore@1216 998 bounds = bounds.tail;
mcimadamore@854 999 args = args.tail;
mcimadamore@821 1000 }
mcimadamore@821 1001
mcimadamore@821 1002 return null;
mcimadamore@821 1003 }
mcimadamore@854 1004 //where
mcimadamore@854 1005 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 1006 return isTypeArgErroneous.visit(t);
mcimadamore@854 1007 }
mcimadamore@854 1008
mcimadamore@854 1009 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 1010 public Boolean visitType(Type t, Void s) {
mcimadamore@854 1011 return t.isErroneous();
mcimadamore@854 1012 }
mcimadamore@854 1013 @Override
mcimadamore@854 1014 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 1015 return visit(t.getUpperBound());
mcimadamore@854 1016 }
mcimadamore@854 1017 @Override
mcimadamore@854 1018 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 1019 return visit(t.getUpperBound()) ||
mcimadamore@854 1020 visit(t.getLowerBound());
mcimadamore@854 1021 }
mcimadamore@854 1022 @Override
mcimadamore@854 1023 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1024 return visit(t.type);
mcimadamore@854 1025 }
mcimadamore@854 1026 };
mcimadamore@821 1027
duke@1 1028 /** Check that given modifiers are legal for given symbol and
vromero@1555 1029 * return modifiers together with any implicit modifiers for that symbol.
duke@1 1030 * Warning: we can't use flags() here since this method
duke@1 1031 * is called during class enter, when flags() would cause a premature
duke@1 1032 * completion.
duke@1 1033 * @param pos Position to be used for error reporting.
duke@1 1034 * @param flags The set of modifiers given in a definition.
duke@1 1035 * @param sym The defined symbol.
duke@1 1036 */
duke@1 1037 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1038 long mask;
duke@1 1039 long implicit = 0;
duke@1 1040 switch (sym.kind) {
duke@1 1041 case VAR:
duke@1 1042 if (sym.owner.kind != TYP)
duke@1 1043 mask = LocalVarFlags;
duke@1 1044 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1045 mask = implicit = InterfaceVarFlags;
duke@1 1046 else
duke@1 1047 mask = VarFlags;
duke@1 1048 break;
duke@1 1049 case MTH:
duke@1 1050 if (sym.name == names.init) {
duke@1 1051 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1052 // enum constructors cannot be declared public or
duke@1 1053 // protected and must be implicitly or explicitly
duke@1 1054 // private
duke@1 1055 implicit = PRIVATE;
duke@1 1056 mask = PRIVATE;
duke@1 1057 } else
duke@1 1058 mask = ConstructorFlags;
mcimadamore@1366 1059 } else if ((sym.owner.flags_field & INTERFACE) != 0) {
mcimadamore@1513 1060 if ((flags & (DEFAULT | STATIC)) != 0) {
mcimadamore@1513 1061 mask = InterfaceMethodMask;
mcimadamore@1513 1062 implicit = PUBLIC;
mcimadamore@1513 1063 if ((flags & DEFAULT) != 0) {
mcimadamore@1513 1064 implicit |= ABSTRACT;
mcimadamore@1513 1065 }
mcimadamore@1366 1066 } else {
mcimadamore@1366 1067 mask = implicit = InterfaceMethodFlags;
mcimadamore@1366 1068 }
mcimadamore@1366 1069 }
duke@1 1070 else {
duke@1 1071 mask = MethodFlags;
duke@1 1072 }
duke@1 1073 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1074 if (((flags|implicit) & Flags.ABSTRACT) == 0)
vromero@1555 1075 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1076 break;
duke@1 1077 case TYP:
duke@1 1078 if (sym.isLocal()) {
duke@1 1079 mask = LocalClassFlags;
jjg@113 1080 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1081 // Anonymous classes in static methods are themselves static;
duke@1 1082 // that's why we admit STATIC here.
duke@1 1083 mask |= STATIC;
duke@1 1084 // JLS: Anonymous classes are final.
duke@1 1085 implicit |= FINAL;
duke@1 1086 }
duke@1 1087 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1088 (flags & ENUM) != 0)
duke@1 1089 log.error(pos, "enums.must.be.static");
duke@1 1090 } else if (sym.owner.kind == TYP) {
duke@1 1091 mask = MemberClassFlags;
duke@1 1092 if (sym.owner.owner.kind == PCK ||
duke@1 1093 (sym.owner.flags_field & STATIC) != 0)
duke@1 1094 mask |= STATIC;
duke@1 1095 else if ((flags & ENUM) != 0)
duke@1 1096 log.error(pos, "enums.must.be.static");
duke@1 1097 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1098 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1099 } else {
duke@1 1100 mask = ClassFlags;
duke@1 1101 }
duke@1 1102 // Interfaces are always ABSTRACT
duke@1 1103 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1104
duke@1 1105 if ((flags & ENUM) != 0) {
duke@1 1106 // enums can't be declared abstract or final
duke@1 1107 mask &= ~(ABSTRACT | FINAL);
duke@1 1108 implicit |= implicitEnumFinalFlag(tree);
duke@1 1109 }
duke@1 1110 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1111 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1112 break;
duke@1 1113 default:
duke@1 1114 throw new AssertionError();
duke@1 1115 }
mcimadamore@1366 1116 long illegal = flags & ExtendedStandardFlags & ~mask;
duke@1 1117 if (illegal != 0) {
duke@1 1118 if ((illegal & INTERFACE) != 0) {
duke@1 1119 log.error(pos, "intf.not.allowed.here");
duke@1 1120 mask |= INTERFACE;
duke@1 1121 }
duke@1 1122 else {
duke@1 1123 log.error(pos,
mcimadamore@80 1124 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1125 }
duke@1 1126 }
duke@1 1127 else if ((sym.kind == TYP ||
duke@1 1128 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1129 // in the presence of inner classes. Should it be deleted here?
duke@1 1130 checkDisjoint(pos, flags,
duke@1 1131 ABSTRACT,
mcimadamore@1366 1132 PRIVATE | STATIC | DEFAULT))
duke@1 1133 &&
duke@1 1134 checkDisjoint(pos, flags,
mcimadamore@1513 1135 STATIC,
mcimadamore@1513 1136 DEFAULT)
mcimadamore@1513 1137 &&
mcimadamore@1513 1138 checkDisjoint(pos, flags,
duke@1 1139 ABSTRACT | INTERFACE,
duke@1 1140 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1141 &&
duke@1 1142 checkDisjoint(pos, flags,
duke@1 1143 PUBLIC,
duke@1 1144 PRIVATE | PROTECTED)
duke@1 1145 &&
duke@1 1146 checkDisjoint(pos, flags,
duke@1 1147 PRIVATE,
duke@1 1148 PUBLIC | PROTECTED)
duke@1 1149 &&
duke@1 1150 checkDisjoint(pos, flags,
duke@1 1151 FINAL,
duke@1 1152 VOLATILE)
duke@1 1153 &&
duke@1 1154 (sym.kind == TYP ||
duke@1 1155 checkDisjoint(pos, flags,
duke@1 1156 ABSTRACT | NATIVE,
duke@1 1157 STRICTFP))) {
duke@1 1158 // skip
duke@1 1159 }
mcimadamore@1366 1160 return flags & (mask | ~ExtendedStandardFlags) | implicit;
duke@1 1161 }
duke@1 1162
duke@1 1163
duke@1 1164 /** Determine if this enum should be implicitly final.
duke@1 1165 *
duke@1 1166 * If the enum has no specialized enum contants, it is final.
duke@1 1167 *
duke@1 1168 * If the enum does have specialized enum contants, it is
duke@1 1169 * <i>not</i> final.
duke@1 1170 */
duke@1 1171 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1172 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1173 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1174 boolean specialized;
duke@1 1175 SpecialTreeVisitor() {
duke@1 1176 this.specialized = false;
duke@1 1177 };
duke@1 1178
jjg@398 1179 @Override
duke@1 1180 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1181
jjg@398 1182 @Override
duke@1 1183 public void visitVarDef(JCVariableDecl tree) {
duke@1 1184 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1185 if (tree.init instanceof JCNewClass &&
duke@1 1186 ((JCNewClass) tree.init).def != null) {
duke@1 1187 specialized = true;
duke@1 1188 }
duke@1 1189 }
duke@1 1190 }
duke@1 1191 }
duke@1 1192
duke@1 1193 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1194 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1195 for (JCTree defs: cdef.defs) {
duke@1 1196 defs.accept(sts);
duke@1 1197 if (sts.specialized) return 0;
duke@1 1198 }
duke@1 1199 return FINAL;
duke@1 1200 }
duke@1 1201
duke@1 1202 /* *************************************************************************
duke@1 1203 * Type Validation
duke@1 1204 **************************************************************************/
duke@1 1205
duke@1 1206 /** Validate a type expression. That is,
duke@1 1207 * check that all type arguments of a parametric type are within
duke@1 1208 * their bounds. This must be done in a second phase after type attributon
duke@1 1209 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1210 *
jjg@1358 1211 * <pre>{@code
duke@1 1212 * class B<A extends C> { ... }
duke@1 1213 * class C extends B<C> { ... }
jjg@1358 1214 * }</pre>
duke@1 1215 *
duke@1 1216 * and we can't make sure that the bound is already attributed because
duke@1 1217 * of possible cycles.
mcimadamore@638 1218 *
mcimadamore@638 1219 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1220 * and reporting any completion failures.
duke@1 1221 */
mcimadamore@122 1222 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1223 validate(tree, env, true);
duke@1 1224 }
mcimadamore@638 1225 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1226 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1227 }
duke@1 1228
duke@1 1229 /** Visitor method: Validate a list of type expressions.
duke@1 1230 */
mcimadamore@122 1231 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1232 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1233 validate(l.head, env);
duke@1 1234 }
duke@1 1235
duke@1 1236 /** A visitor class for type validation.
duke@1 1237 */
duke@1 1238 class Validator extends JCTree.Visitor {
duke@1 1239
mcimadamore@638 1240 boolean isOuter;
mcimadamore@638 1241 Env<AttrContext> env;
mcimadamore@638 1242
mcimadamore@638 1243 Validator(Env<AttrContext> env) {
mcimadamore@638 1244 this.env = env;
mcimadamore@638 1245 }
mcimadamore@638 1246
jjg@398 1247 @Override
duke@1 1248 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1249 tree.elemtype.accept(this);
duke@1 1250 }
duke@1 1251
jjg@398 1252 @Override
duke@1 1253 public void visitTypeApply(JCTypeApply tree) {
jjg@1374 1254 if (tree.type.hasTag(CLASS)) {
duke@1 1255 List<JCExpression> args = tree.arguments;
mcimadamore@158 1256 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1257
mcimadamore@821 1258 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1259 if (incompatibleArg != null) {
mcimadamore@821 1260 for (JCTree arg : tree.arguments) {
mcimadamore@821 1261 if (arg.type == incompatibleArg) {
mcimadamore@829 1262 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1263 }
mcimadamore@829 1264 forms = forms.tail;
mcimadamore@829 1265 }
mcimadamore@829 1266 }
mcimadamore@829 1267
mcimadamore@829 1268 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1269
mcimadamore@638 1270 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1271
duke@1 1272 // For matching pairs of actual argument types `a' and
duke@1 1273 // formal type parameters with declared bound `b' ...
duke@1 1274 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1275 validateTree(args.head,
mcimadamore@638 1276 !(isOuter && is_java_lang_Class),
mcimadamore@638 1277 false);
duke@1 1278 args = args.tail;
duke@1 1279 forms = forms.tail;
duke@1 1280 }
duke@1 1281
duke@1 1282 // Check that this type is either fully parameterized, or
duke@1 1283 // not parameterized at all.
duke@1 1284 if (tree.type.getEnclosingType().isRaw())
duke@1 1285 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1286 if (tree.clazz.hasTag(SELECT))
duke@1 1287 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1288 }
duke@1 1289 }
duke@1 1290
jjg@398 1291 @Override
duke@1 1292 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1293 validateTrees(tree.bounds, true, isOuter);
duke@1 1294 checkClassBounds(tree.pos(), tree.type);
duke@1 1295 }
duke@1 1296
duke@1 1297 @Override
duke@1 1298 public void visitWildcard(JCWildcard tree) {
duke@1 1299 if (tree.inner != null)
mcimadamore@638 1300 validateTree(tree.inner, true, isOuter);
duke@1 1301 }
duke@1 1302
jjg@398 1303 @Override
duke@1 1304 public void visitSelect(JCFieldAccess tree) {
jjg@1374 1305 if (tree.type.hasTag(CLASS)) {
duke@1 1306 visitSelectInternal(tree);
duke@1 1307
duke@1 1308 // Check that this type is either fully parameterized, or
duke@1 1309 // not parameterized at all.
duke@1 1310 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1311 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1312 }
duke@1 1313 }
mcimadamore@852 1314
duke@1 1315 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1316 if (tree.type.tsym.isStatic() &&
duke@1 1317 tree.selected.type.isParameterized()) {
duke@1 1318 // The enclosing type is not a class, so we are
duke@1 1319 // looking at a static member type. However, the
duke@1 1320 // qualifying expression is parameterized.
duke@1 1321 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1322 } else {
duke@1 1323 // otherwise validate the rest of the expression
mcimadamore@122 1324 tree.selected.accept(this);
duke@1 1325 }
duke@1 1326 }
duke@1 1327
jjg@1521 1328 @Override
jjg@1521 1329 public void visitAnnotatedType(JCAnnotatedType tree) {
jjg@1521 1330 tree.underlyingType.accept(this);
jjg@1521 1331 }
jjg@1521 1332
duke@1 1333 /** Default visitor method: do nothing.
duke@1 1334 */
jjg@398 1335 @Override
duke@1 1336 public void visitTree(JCTree tree) {
duke@1 1337 }
mcimadamore@122 1338
mcimadamore@638 1339 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1340 try {
mcimadamore@638 1341 if (tree != null) {
mcimadamore@638 1342 this.isOuter = isOuter;
mcimadamore@638 1343 tree.accept(this);
mcimadamore@638 1344 if (checkRaw)
mcimadamore@638 1345 checkRaw(tree, env);
mcimadamore@638 1346 }
mcimadamore@638 1347 } catch (CompletionFailure ex) {
mcimadamore@638 1348 completionError(tree.pos(), ex);
mcimadamore@638 1349 }
mcimadamore@638 1350 }
mcimadamore@638 1351
mcimadamore@638 1352 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1353 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1354 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1355 }
mcimadamore@638 1356
mcimadamore@638 1357 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1358 if (lint.isEnabled(LintCategory.RAW) &&
jjg@1374 1359 tree.type.hasTag(CLASS) &&
mcimadamore@638 1360 !TreeInfo.isDiamond(tree) &&
mcimadamore@1103 1361 !withinAnonConstr(env) &&
mcimadamore@638 1362 tree.type.isRaw()) {
mcimadamore@795 1363 log.warning(LintCategory.RAW,
mcimadamore@638 1364 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1365 }
mcimadamore@638 1366 }
mcimadamore@1103 1367
mcimadamore@1103 1368 boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1369 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1370 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1371 }
duke@1 1372 }
duke@1 1373
duke@1 1374 /* *************************************************************************
duke@1 1375 * Exception checking
duke@1 1376 **************************************************************************/
duke@1 1377
duke@1 1378 /* The following methods treat classes as sets that contain
duke@1 1379 * the class itself and all their subclasses
duke@1 1380 */
duke@1 1381
duke@1 1382 /** Is given type a subtype of some of the types in given list?
duke@1 1383 */
duke@1 1384 boolean subset(Type t, List<Type> ts) {
duke@1 1385 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1386 if (types.isSubtype(t, l.head)) return true;
duke@1 1387 return false;
duke@1 1388 }
duke@1 1389
duke@1 1390 /** Is given type a subtype or supertype of
duke@1 1391 * some of the types in given list?
duke@1 1392 */
duke@1 1393 boolean intersects(Type t, List<Type> ts) {
duke@1 1394 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1395 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1396 return false;
duke@1 1397 }
duke@1 1398
duke@1 1399 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1400 * in the list.
duke@1 1401 */
duke@1 1402 List<Type> incl(Type t, List<Type> ts) {
duke@1 1403 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1404 }
duke@1 1405
duke@1 1406 /** Remove type set from type set list.
duke@1 1407 */
duke@1 1408 List<Type> excl(Type t, List<Type> ts) {
duke@1 1409 if (ts.isEmpty()) {
duke@1 1410 return ts;
duke@1 1411 } else {
duke@1 1412 List<Type> ts1 = excl(t, ts.tail);
duke@1 1413 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1414 else if (ts1 == ts.tail) return ts;
duke@1 1415 else return ts1.prepend(ts.head);
duke@1 1416 }
duke@1 1417 }
duke@1 1418
duke@1 1419 /** Form the union of two type set lists.
duke@1 1420 */
duke@1 1421 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1422 List<Type> ts = ts1;
duke@1 1423 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1424 ts = incl(l.head, ts);
duke@1 1425 return ts;
duke@1 1426 }
duke@1 1427
duke@1 1428 /** Form the difference of two type lists.
duke@1 1429 */
duke@1 1430 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1431 List<Type> ts = ts1;
duke@1 1432 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1433 ts = excl(l.head, ts);
duke@1 1434 return ts;
duke@1 1435 }
duke@1 1436
duke@1 1437 /** Form the intersection of two type lists.
duke@1 1438 */
duke@1 1439 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1440 List<Type> ts = List.nil();
duke@1 1441 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1442 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1443 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1444 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1445 return ts;
duke@1 1446 }
duke@1 1447
duke@1 1448 /** Is exc an exception symbol that need not be declared?
duke@1 1449 */
duke@1 1450 boolean isUnchecked(ClassSymbol exc) {
duke@1 1451 return
duke@1 1452 exc.kind == ERR ||
duke@1 1453 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1454 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1455 }
duke@1 1456
duke@1 1457 /** Is exc an exception type that need not be declared?
duke@1 1458 */
duke@1 1459 boolean isUnchecked(Type exc) {
duke@1 1460 return
jjg@1374 1461 (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
jjg@1374 1462 (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
jjg@1374 1463 exc.hasTag(BOT);
duke@1 1464 }
duke@1 1465
duke@1 1466 /** Same, but handling completion failures.
duke@1 1467 */
duke@1 1468 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1469 try {
duke@1 1470 return isUnchecked(exc);
duke@1 1471 } catch (CompletionFailure ex) {
duke@1 1472 completionError(pos, ex);
duke@1 1473 return true;
duke@1 1474 }
duke@1 1475 }
duke@1 1476
duke@1 1477 /** Is exc handled by given exception list?
duke@1 1478 */
duke@1 1479 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1480 return isUnchecked(exc) || subset(exc, handled);
duke@1 1481 }
duke@1 1482
duke@1 1483 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1484 * @param thrown The list of thrown exceptions.
duke@1 1485 * @param handled The list of handled exceptions.
duke@1 1486 */
mcimadamore@362 1487 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1488 List<Type> unhandled = List.nil();
duke@1 1489 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1490 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1491 return unhandled;
duke@1 1492 }
duke@1 1493
duke@1 1494 /* *************************************************************************
duke@1 1495 * Overriding/Implementation checking
duke@1 1496 **************************************************************************/
duke@1 1497
duke@1 1498 /** The level of access protection given by a flag set,
duke@1 1499 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1500 */
duke@1 1501 static int protection(long flags) {
duke@1 1502 switch ((short)(flags & AccessFlags)) {
duke@1 1503 case PRIVATE: return 3;
duke@1 1504 case PROTECTED: return 1;
duke@1 1505 default:
duke@1 1506 case PUBLIC: return 0;
duke@1 1507 case 0: return 2;
duke@1 1508 }
duke@1 1509 }
duke@1 1510
duke@1 1511 /** A customized "cannot override" error message.
duke@1 1512 * @param m The overriding method.
duke@1 1513 * @param other The overridden method.
duke@1 1514 * @return An internationalized string.
duke@1 1515 */
mcimadamore@89 1516 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1517 String key;
duke@1 1518 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1519 key = "cant.override";
duke@1 1520 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1521 key = "cant.implement";
duke@1 1522 else
duke@1 1523 key = "clashes.with";
mcimadamore@89 1524 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1525 }
duke@1 1526
duke@1 1527 /** A customized "override" warning message.
duke@1 1528 * @param m The overriding method.
duke@1 1529 * @param other The overridden method.
duke@1 1530 * @return An internationalized string.
duke@1 1531 */
mcimadamore@89 1532 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1533 String key;
duke@1 1534 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1535 key = "unchecked.override";
duke@1 1536 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1537 key = "unchecked.implement";
duke@1 1538 else
duke@1 1539 key = "unchecked.clash.with";
mcimadamore@89 1540 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1541 }
duke@1 1542
duke@1 1543 /** A customized "override" warning message.
duke@1 1544 * @param m The overriding method.
duke@1 1545 * @param other The overridden method.
duke@1 1546 * @return An internationalized string.
duke@1 1547 */
mcimadamore@89 1548 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1549 String key;
duke@1 1550 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1551 key = "varargs.override";
duke@1 1552 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1553 key = "varargs.implement";
duke@1 1554 else
duke@1 1555 key = "varargs.clash.with";
mcimadamore@89 1556 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1557 }
duke@1 1558
duke@1 1559 /** Check that this method conforms with overridden method 'other'.
duke@1 1560 * where `origin' is the class where checking started.
duke@1 1561 * Complications:
duke@1 1562 * (1) Do not check overriding of synthetic methods
duke@1 1563 * (reason: they might be final).
duke@1 1564 * todo: check whether this is still necessary.
duke@1 1565 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1566 * than the method it implements. Augment the proxy methods with the
duke@1 1567 * undeclared exceptions in this case.
duke@1 1568 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1569 * has a result type
duke@1 1570 * extended by the result type of the method it implements.
duke@1 1571 * Change the proxies result type to the smaller type in this case.
duke@1 1572 *
duke@1 1573 * @param tree The tree from which positions
duke@1 1574 * are extracted for errors.
duke@1 1575 * @param m The overriding method.
duke@1 1576 * @param other The overridden method.
duke@1 1577 * @param origin The class of which the overriding method
duke@1 1578 * is a member.
duke@1 1579 */
duke@1 1580 void checkOverride(JCTree tree,
duke@1 1581 MethodSymbol m,
duke@1 1582 MethodSymbol other,
duke@1 1583 ClassSymbol origin) {
duke@1 1584 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1585 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1586 return;
duke@1 1587 }
duke@1 1588
duke@1 1589 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1590 if ((m.flags() & STATIC) != 0 &&
duke@1 1591 (other.flags() & STATIC) == 0) {
duke@1 1592 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1593 cannotOverride(m, other));
vromero@1588 1594 m.flags_field |= BAD_OVERRIDE;
duke@1 1595 return;
duke@1 1596 }
duke@1 1597
duke@1 1598 // Error if instance method overrides static or final
duke@1 1599 // method (JLS 8.4.6.1).
duke@1 1600 if ((other.flags() & FINAL) != 0 ||
duke@1 1601 (m.flags() & STATIC) == 0 &&
duke@1 1602 (other.flags() & STATIC) != 0) {
duke@1 1603 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1604 cannotOverride(m, other),
mcimadamore@80 1605 asFlagSet(other.flags() & (FINAL | STATIC)));
vromero@1588 1606 m.flags_field |= BAD_OVERRIDE;
duke@1 1607 return;
duke@1 1608 }
duke@1 1609
duke@1 1610 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1611 // handled in validateAnnotationMethod
duke@1 1612 return;
duke@1 1613 }
duke@1 1614
duke@1 1615 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1616 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1617 protection(m.flags()) > protection(other.flags())) {
duke@1 1618 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1619 cannotOverride(m, other),
mcimadamore@80 1620 other.flags() == 0 ?
mcimadamore@80 1621 Flag.PACKAGE :
mcimadamore@80 1622 asFlagSet(other.flags() & AccessFlags));
vromero@1588 1623 m.flags_field |= BAD_OVERRIDE;
duke@1 1624 return;
duke@1 1625 }
duke@1 1626
duke@1 1627 Type mt = types.memberType(origin.type, m);
duke@1 1628 Type ot = types.memberType(origin.type, other);
duke@1 1629 // Error if overriding result type is different
duke@1 1630 // (or, in the case of generics mode, not a subtype) of
duke@1 1631 // overridden result type. We have to rename any type parameters
duke@1 1632 // before comparing types.
duke@1 1633 List<Type> mtvars = mt.getTypeArguments();
duke@1 1634 List<Type> otvars = ot.getTypeArguments();
duke@1 1635 Type mtres = mt.getReturnType();
duke@1 1636 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1637
mcimadamore@795 1638 overrideWarner.clear();
duke@1 1639 boolean resultTypesOK =
tbell@202 1640 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1641 if (!resultTypesOK) {
jjg@398 1642 if (!allowCovariantReturns &&
duke@1 1643 m.owner != origin &&
duke@1 1644 m.owner.isSubClass(other.owner, types)) {
duke@1 1645 // allow limited interoperability with covariant returns
duke@1 1646 } else {
mcimadamore@362 1647 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1648 "override.incompatible.ret",
mcimadamore@362 1649 cannotOverride(m, other),
duke@1 1650 mtres, otres);
vromero@1588 1651 m.flags_field |= BAD_OVERRIDE;
duke@1 1652 return;
duke@1 1653 }
mcimadamore@795 1654 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1655 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1656 "override.unchecked.ret",
mcimadamore@362 1657 uncheckedOverrides(m, other),
mcimadamore@362 1658 mtres, otres);
duke@1 1659 }
duke@1 1660
duke@1 1661 // Error if overriding method throws an exception not reported
duke@1 1662 // by overridden method.
duke@1 1663 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1664 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1665 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1666 if (unhandledErased.nonEmpty()) {
duke@1 1667 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1668 "override.meth.doesnt.throw",
duke@1 1669 cannotOverride(m, other),
mcimadamore@362 1670 unhandledUnerased.head);
vromero@1588 1671 m.flags_field |= BAD_OVERRIDE;
mcimadamore@362 1672 return;
mcimadamore@362 1673 }
mcimadamore@362 1674 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1675 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1676 "override.unchecked.thrown",
mcimadamore@362 1677 cannotOverride(m, other),
mcimadamore@362 1678 unhandledUnerased.head);
duke@1 1679 return;
duke@1 1680 }
duke@1 1681
duke@1 1682 // Optional warning if varargs don't agree
duke@1 1683 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1684 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1685 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1686 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1687 ? "override.varargs.missing"
duke@1 1688 : "override.varargs.extra",
duke@1 1689 varargsOverrides(m, other));
duke@1 1690 }
duke@1 1691
duke@1 1692 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1693 if ((other.flags() & BRIDGE) != 0) {
duke@1 1694 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1695 uncheckedOverrides(m, other));
duke@1 1696 }
duke@1 1697
duke@1 1698 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1699 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1700 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1701 }
duke@1 1702 }
duke@1 1703 // where
duke@1 1704 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1705 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1706 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1707 // because in that case, we will rediscover the issue when examining the method
duke@1 1708 // in the supertype.
duke@1 1709 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1710 // address the issue is when the method is the supertype implemementation: any other
duke@1 1711 // case, we will have dealt with when examining the supertype classes
duke@1 1712 ClassSymbol mc = m.enclClass();
duke@1 1713 Type st = types.supertype(origin.type);
jjg@1374 1714 if (!st.hasTag(CLASS))
duke@1 1715 return true;
duke@1 1716 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1717
duke@1 1718 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1719 List<Type> intfs = types.interfaces(origin.type);
duke@1 1720 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1721 }
duke@1 1722 else
duke@1 1723 return (stimpl != m);
duke@1 1724 }
duke@1 1725
duke@1 1726
duke@1 1727 // used to check if there were any unchecked conversions
duke@1 1728 Warner overrideWarner = new Warner();
duke@1 1729
duke@1 1730 /** Check that a class does not inherit two concrete methods
duke@1 1731 * with the same signature.
duke@1 1732 * @param pos Position to be used for error reporting.
duke@1 1733 * @param site The class type to be checked.
duke@1 1734 */
duke@1 1735 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1736 Type sup = types.supertype(site);
jjg@1374 1737 if (!sup.hasTag(CLASS)) return;
duke@1 1738
duke@1 1739 for (Type t1 = sup;
duke@1 1740 t1.tsym.type.isParameterized();
duke@1 1741 t1 = types.supertype(t1)) {
duke@1 1742 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1743 e1 != null;
duke@1 1744 e1 = e1.sibling) {
duke@1 1745 Symbol s1 = e1.sym;
duke@1 1746 if (s1.kind != MTH ||
duke@1 1747 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1748 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1749 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1750 types,
duke@1 1751 true) != s1)
duke@1 1752 continue;
duke@1 1753 Type st1 = types.memberType(t1, s1);
duke@1 1754 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1755 if (st1 == s1.type) continue;
duke@1 1756
duke@1 1757 for (Type t2 = sup;
jjg@1374 1758 t2.hasTag(CLASS);
duke@1 1759 t2 = types.supertype(t2)) {
mcimadamore@24 1760 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1761 e2.scope != null;
duke@1 1762 e2 = e2.next()) {
duke@1 1763 Symbol s2 = e2.sym;
duke@1 1764 if (s2 == s1 ||
duke@1 1765 s2.kind != MTH ||
duke@1 1766 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1767 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1768 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1769 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1770 types,
duke@1 1771 true) != s2)
duke@1 1772 continue;
duke@1 1773 Type st2 = types.memberType(t2, s2);
duke@1 1774 if (types.overrideEquivalent(st1, st2))
duke@1 1775 log.error(pos, "concrete.inheritance.conflict",
duke@1 1776 s1, t1, s2, t2, sup);
duke@1 1777 }
duke@1 1778 }
duke@1 1779 }
duke@1 1780 }
duke@1 1781 }
duke@1 1782
duke@1 1783 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1784 * method with same name and arguments but incompatible return types.
duke@1 1785 * @param pos Position to be used for error reporting.
duke@1 1786 * @param t1 The first argument type.
duke@1 1787 * @param t2 The second argument type.
duke@1 1788 */
duke@1 1789 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1790 Type t1,
duke@1 1791 Type t2) {
duke@1 1792 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1793 types.makeCompoundType(t1, t2));
duke@1 1794 }
duke@1 1795
duke@1 1796 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1797 Type t1,
duke@1 1798 Type t2,
duke@1 1799 Type site) {
mcimadamore@746 1800 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1801 }
duke@1 1802
duke@1 1803 /** Return the first method which is defined with same args
duke@1 1804 * but different return types in two given interfaces, or null if none
duke@1 1805 * exists.
duke@1 1806 * @param t1 The first type.
duke@1 1807 * @param t2 The second type.
duke@1 1808 * @param site The most derived type.
duke@1 1809 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1810 */
mcimadamore@746 1811 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1812 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1813 closure(t1, interfaces1);
duke@1 1814 Map<TypeSymbol,Type> interfaces2;
duke@1 1815 if (t1 == t2)
duke@1 1816 interfaces2 = interfaces1;
duke@1 1817 else
duke@1 1818 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1819
duke@1 1820 for (Type t3 : interfaces1.values()) {
duke@1 1821 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1822 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1823 if (s != null) return s;
duke@1 1824 }
duke@1 1825 }
duke@1 1826 return null;
duke@1 1827 }
duke@1 1828
duke@1 1829 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1830 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1831 if (!t.hasTag(CLASS)) return;
duke@1 1832 if (typeMap.put(t.tsym, t) == null) {
duke@1 1833 closure(types.supertype(t), typeMap);
duke@1 1834 for (Type i : types.interfaces(t))
duke@1 1835 closure(i, typeMap);
duke@1 1836 }
duke@1 1837 }
duke@1 1838
duke@1 1839 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1840 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1841 if (!t.hasTag(CLASS)) return;
duke@1 1842 if (typesSkip.get(t.tsym) != null) return;
duke@1 1843 if (typeMap.put(t.tsym, t) == null) {
duke@1 1844 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1845 for (Type i : types.interfaces(t))
duke@1 1846 closure(i, typesSkip, typeMap);
duke@1 1847 }
duke@1 1848 }
duke@1 1849
duke@1 1850 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1851 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1852 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1853 Symbol s1 = e1.sym;
duke@1 1854 Type st1 = null;
mcimadamore@1441 1855 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1856 (s1.flags() & SYNTHETIC) != 0) continue;
duke@1 1857 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1858 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1859 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1860 Symbol s2 = e2.sym;
duke@1 1861 if (s1 == s2) continue;
mcimadamore@1441 1862 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1863 (s2.flags() & SYNTHETIC) != 0) continue;
duke@1 1864 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1865 Type st2 = types.memberType(t2, s2);
duke@1 1866 if (types.overrideEquivalent(st1, st2)) {
duke@1 1867 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1868 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1869 Type rt1 = st1.getReturnType();
duke@1 1870 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1871 boolean compat =
duke@1 1872 types.isSameType(rt1, rt2) ||
jjg@1374 1873 !rt1.isPrimitiveOrVoid() &&
jjg@1374 1874 !rt2.isPrimitiveOrVoid() &&
mcimadamore@1415 1875 (types.covariantReturnType(rt1, rt2, types.noWarnings) ||
mcimadamore@1415 1876 types.covariantReturnType(rt2, rt1, types.noWarnings)) ||
mcimadamore@59 1877 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1878 if (!compat) {
mcimadamore@746 1879 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1880 t1, t2, s2.name +
mcimadamore@746 1881 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1882 return s2;
mcimadamore@746 1883 }
mcimadamore@889 1884 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1885 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1886 log.error(pos,
mcimadamore@746 1887 "name.clash.same.erasure.no.override",
mcimadamore@746 1888 s1, s1.location(),
mcimadamore@746 1889 s2, s2.location());
mcimadamore@746 1890 return s2;
duke@1 1891 }
duke@1 1892 }
duke@1 1893 }
duke@1 1894 return null;
duke@1 1895 }
mcimadamore@59 1896 //WHERE
mcimadamore@59 1897 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1898 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1899 Type st1 = types.memberType(site, s1);
mcimadamore@59 1900 Type st2 = types.memberType(site, s2);
mcimadamore@59 1901 closure(site, supertypes);
mcimadamore@59 1902 for (Type t : supertypes.values()) {
mcimadamore@59 1903 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1904 Symbol s3 = e.sym;
mcimadamore@59 1905 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1906 Type st3 = types.memberType(site,s3);
mcimadamore@59 1907 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1908 if (s3.owner == site.tsym) {
mcimadamore@59 1909 return true;
mcimadamore@59 1910 }
mcimadamore@59 1911 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1912 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1913 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1914 Type rt1 = st1.getReturnType();
mcimadamore@59 1915 Type rt2 = st2.getReturnType();
mcimadamore@59 1916 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1917 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1918 boolean compat =
jjg@1374 1919 !rt13.isPrimitiveOrVoid() &&
jjg@1374 1920 !rt23.isPrimitiveOrVoid() &&
mcimadamore@1415 1921 (types.covariantReturnType(rt13, rt1, types.noWarnings) &&
mcimadamore@1415 1922 types.covariantReturnType(rt23, rt2, types.noWarnings));
mcimadamore@59 1923 if (compat)
mcimadamore@59 1924 return true;
mcimadamore@59 1925 }
mcimadamore@59 1926 }
mcimadamore@59 1927 }
mcimadamore@59 1928 return false;
mcimadamore@59 1929 }
duke@1 1930
duke@1 1931 /** Check that a given method conforms with any method it overrides.
duke@1 1932 * @param tree The tree from which positions are extracted
duke@1 1933 * for errors.
duke@1 1934 * @param m The overriding method.
duke@1 1935 */
duke@1 1936 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1937 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1938 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1939 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1940 log.error(tree.pos(), "enum.no.finalize");
duke@1 1941 return;
duke@1 1942 }
jjg@1374 1943 for (Type t = origin.type; t.hasTag(CLASS);
duke@1 1944 t = types.supertype(t)) {
mcimadamore@746 1945 if (t != origin.type) {
mcimadamore@746 1946 checkOverride(tree, t, origin, m);
mcimadamore@746 1947 }
mcimadamore@746 1948 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1949 checkOverride(tree, t2, origin, m);
duke@1 1950 }
duke@1 1951 }
duke@1 1952 }
duke@1 1953
mcimadamore@746 1954 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1955 TypeSymbol c = site.tsym;
mcimadamore@746 1956 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1957 while (e.scope != null) {
mcimadamore@746 1958 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1959 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1960 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1961 }
mcimadamore@746 1962 }
mcimadamore@746 1963 e = e.next();
mcimadamore@746 1964 }
mcimadamore@746 1965 }
mcimadamore@746 1966
vromero@1607 1967 private Filter<Symbol> equalsHasCodeFilter = new Filter<Symbol>() {
vromero@1607 1968 public boolean accepts(Symbol s) {
vromero@1607 1969 return MethodSymbol.implementation_filter.accepts(s) &&
vromero@1607 1970 (s.flags() & BAD_OVERRIDE) == 0;
vromero@1607 1971
vromero@1607 1972 }
vromero@1607 1973 };
vromero@1607 1974
vromero@1607 1975 public void checkClassOverrideEqualsAndHash(DiagnosticPosition pos,
vromero@1607 1976 ClassSymbol someClass) {
vromero@1588 1977 if (lint.isEnabled(LintCategory.OVERRIDES)) {
vromero@1607 1978 MethodSymbol equalsAtObject = (MethodSymbol)syms.objectType
vromero@1607 1979 .tsym.members().lookup(names.equals).sym;
vromero@1607 1980 MethodSymbol hashCodeAtObject = (MethodSymbol)syms.objectType
vromero@1607 1981 .tsym.members().lookup(names.hashCode).sym;
vromero@1607 1982
vromero@1607 1983 boolean overridesEquals = types.implementation(equalsAtObject,
vromero@1607 1984 someClass, false, equalsHasCodeFilter).owner == someClass;
vromero@1607 1985 boolean overridesHashCode = types.implementation(hashCodeAtObject,
vromero@1607 1986 someClass, false, equalsHasCodeFilter) != hashCodeAtObject;
vromero@1607 1987
vromero@1607 1988 if (overridesEquals && !overridesHashCode) {
vromero@1607 1989 log.warning(LintCategory.OVERRIDES, pos,
vromero@1588 1990 "override.equals.but.not.hashcode", someClass.fullname);
vromero@1588 1991 }
vromero@1588 1992 }
vromero@1588 1993 }
vromero@1588 1994
mcimadamore@746 1995 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 1996 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 1997 return (cf.accepts(s1) &&
mcimadamore@858 1998 cf.accepts(s2) &&
mcimadamore@858 1999 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 2000 }
mcimadamore@746 2001
mcimadamore@746 2002
duke@1 2003 /** Check that all abstract members of given class have definitions.
duke@1 2004 * @param pos Position to be used for error reporting.
duke@1 2005 * @param c The class.
duke@1 2006 */
duke@1 2007 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2008 try {
duke@1 2009 MethodSymbol undef = firstUndef(c, c);
duke@1 2010 if (undef != null) {
duke@1 2011 if ((c.flags() & ENUM) != 0 &&
duke@1 2012 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 2013 (c.flags() & FINAL) == 0) {
duke@1 2014 // add the ABSTRACT flag to an enum
duke@1 2015 c.flags_field |= ABSTRACT;
duke@1 2016 } else {
duke@1 2017 MethodSymbol undef1 =
duke@1 2018 new MethodSymbol(undef.flags(), undef.name,
duke@1 2019 types.memberType(c.type, undef), undef.owner);
duke@1 2020 log.error(pos, "does.not.override.abstract",
duke@1 2021 c, undef1, undef1.location());
duke@1 2022 }
duke@1 2023 }
duke@1 2024 } catch (CompletionFailure ex) {
duke@1 2025 completionError(pos, ex);
duke@1 2026 }
duke@1 2027 }
duke@1 2028 //where
duke@1 2029 /** Return first abstract member of class `c' that is not defined
duke@1 2030 * in `impl', null if there is none.
duke@1 2031 */
duke@1 2032 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 2033 MethodSymbol undef = null;
duke@1 2034 // Do not bother to search in classes that are not abstract,
duke@1 2035 // since they cannot have abstract members.
duke@1 2036 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 2037 Scope s = c.members();
duke@1 2038 for (Scope.Entry e = s.elems;
duke@1 2039 undef == null && e != null;
duke@1 2040 e = e.sibling) {
duke@1 2041 if (e.sym.kind == MTH &&
mcimadamore@1393 2042 (e.sym.flags() & (ABSTRACT|IPROXY|DEFAULT)) == ABSTRACT) {
duke@1 2043 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2044 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
mcimadamore@1393 2045 if (implmeth == null || implmeth == absmeth) {
mcimadamore@1393 2046 //look for default implementations
mcimadamore@1393 2047 if (allowDefaultMethods) {
mcimadamore@1393 2048 MethodSymbol prov = types.interfaceCandidates(impl.type, absmeth).head;
mcimadamore@1393 2049 if (prov != null && prov.overrides(absmeth, impl, types, true)) {
mcimadamore@1393 2050 implmeth = prov;
mcimadamore@1393 2051 }
mcimadamore@1393 2052 }
mcimadamore@1393 2053 }
mcimadamore@1393 2054 if (implmeth == null || implmeth == absmeth) {
duke@1 2055 undef = absmeth;
mcimadamore@1393 2056 }
duke@1 2057 }
duke@1 2058 }
duke@1 2059 if (undef == null) {
duke@1 2060 Type st = types.supertype(c.type);
jjg@1374 2061 if (st.hasTag(CLASS))
duke@1 2062 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 2063 }
duke@1 2064 for (List<Type> l = types.interfaces(c.type);
duke@1 2065 undef == null && l.nonEmpty();
duke@1 2066 l = l.tail) {
duke@1 2067 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 2068 }
duke@1 2069 }
duke@1 2070 return undef;
duke@1 2071 }
duke@1 2072
mcimadamore@690 2073 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 2074 CycleChecker cc = new CycleChecker();
mcimadamore@690 2075 cc.scan(tree);
mcimadamore@690 2076 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 2077 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 2078 }
mcimadamore@690 2079 }
mcimadamore@690 2080
mcimadamore@690 2081 class CycleChecker extends TreeScanner {
mcimadamore@690 2082
mcimadamore@690 2083 List<Symbol> seenClasses = List.nil();
mcimadamore@690 2084 boolean errorFound = false;
mcimadamore@690 2085 boolean partialCheck = false;
mcimadamore@690 2086
mcimadamore@690 2087 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 2088 if (sym != null && sym.kind == TYP) {
mcimadamore@690 2089 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 2090 if (classEnv != null) {
mcimadamore@690 2091 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2092 try {
mcimadamore@690 2093 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2094 scan(classEnv.tree);
mcimadamore@690 2095 }
mcimadamore@690 2096 finally {
mcimadamore@690 2097 log.useSource(prevSource.getFile());
mcimadamore@690 2098 }
mcimadamore@690 2099 } else if (sym.kind == TYP) {
mcimadamore@690 2100 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2101 }
mcimadamore@690 2102 } else {
mcimadamore@690 2103 //not completed yet
mcimadamore@690 2104 partialCheck = true;
mcimadamore@690 2105 }
mcimadamore@690 2106 }
mcimadamore@690 2107
mcimadamore@690 2108 @Override
mcimadamore@690 2109 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2110 super.visitSelect(tree);
mcimadamore@690 2111 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2112 }
mcimadamore@690 2113
mcimadamore@690 2114 @Override
mcimadamore@690 2115 public void visitIdent(JCIdent tree) {
mcimadamore@690 2116 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2117 }
mcimadamore@690 2118
mcimadamore@690 2119 @Override
mcimadamore@690 2120 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2121 scan(tree.clazz);
mcimadamore@690 2122 }
mcimadamore@690 2123
mcimadamore@690 2124 @Override
mcimadamore@690 2125 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2126 scan(tree.elemtype);
mcimadamore@690 2127 }
mcimadamore@690 2128
mcimadamore@690 2129 @Override
mcimadamore@690 2130 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2131 List<JCTree> supertypes = List.nil();
mcimadamore@690 2132 if (tree.getExtendsClause() != null) {
mcimadamore@690 2133 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2134 }
mcimadamore@690 2135 if (tree.getImplementsClause() != null) {
mcimadamore@690 2136 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2137 supertypes = supertypes.prepend(intf);
mcimadamore@690 2138 }
mcimadamore@690 2139 }
mcimadamore@690 2140 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2141 }
mcimadamore@690 2142
mcimadamore@690 2143 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2144 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2145 return;
mcimadamore@690 2146 if (seenClasses.contains(c)) {
mcimadamore@690 2147 errorFound = true;
mcimadamore@690 2148 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2149 } else if (!c.type.isErroneous()) {
mcimadamore@690 2150 try {
mcimadamore@690 2151 seenClasses = seenClasses.prepend(c);
jjg@1374 2152 if (c.type.hasTag(CLASS)) {
mcimadamore@690 2153 if (supertypes.nonEmpty()) {
mcimadamore@690 2154 scan(supertypes);
mcimadamore@690 2155 }
mcimadamore@690 2156 else {
mcimadamore@690 2157 ClassType ct = (ClassType)c.type;
mcimadamore@690 2158 if (ct.supertype_field == null ||
mcimadamore@690 2159 ct.interfaces_field == null) {
mcimadamore@690 2160 //not completed yet
mcimadamore@690 2161 partialCheck = true;
mcimadamore@690 2162 return;
mcimadamore@690 2163 }
mcimadamore@690 2164 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2165 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2166 checkSymbol(pos, intf.tsym);
mcimadamore@690 2167 }
mcimadamore@690 2168 }
mcimadamore@690 2169 if (c.owner.kind == TYP) {
mcimadamore@690 2170 checkSymbol(pos, c.owner);
mcimadamore@690 2171 }
mcimadamore@690 2172 }
mcimadamore@690 2173 } finally {
mcimadamore@690 2174 seenClasses = seenClasses.tail;
mcimadamore@690 2175 }
mcimadamore@690 2176 }
mcimadamore@690 2177 }
mcimadamore@690 2178 }
mcimadamore@690 2179
duke@1 2180 /** Check for cyclic references. Issue an error if the
duke@1 2181 * symbol of the type referred to has a LOCKED flag set.
duke@1 2182 *
duke@1 2183 * @param pos Position to be used for error reporting.
duke@1 2184 * @param t The type referred to.
duke@1 2185 */
duke@1 2186 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2187 checkNonCyclicInternal(pos, t);
duke@1 2188 }
duke@1 2189
duke@1 2190
duke@1 2191 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2192 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2193 }
duke@1 2194
mcimadamore@236 2195 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2196 final TypeVar tv;
jjg@1374 2197 if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2198 return;
duke@1 2199 if (seen.contains(t)) {
duke@1 2200 tv = (TypeVar)t;
jjg@110 2201 tv.bound = types.createErrorType(t);
duke@1 2202 log.error(pos, "cyclic.inheritance", t);
jjg@1374 2203 } else if (t.hasTag(TYPEVAR)) {
duke@1 2204 tv = (TypeVar)t;
mcimadamore@236 2205 seen = seen.prepend(tv);
duke@1 2206 for (Type b : types.getBounds(tv))
duke@1 2207 checkNonCyclic1(pos, b, seen);
duke@1 2208 }
duke@1 2209 }
duke@1 2210
duke@1 2211 /** Check for cyclic references. Issue an error if the
duke@1 2212 * symbol of the type referred to has a LOCKED flag set.
duke@1 2213 *
duke@1 2214 * @param pos Position to be used for error reporting.
duke@1 2215 * @param t The type referred to.
duke@1 2216 * @returns True if the check completed on all attributed classes
duke@1 2217 */
duke@1 2218 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2219 boolean complete = true; // was the check complete?
duke@1 2220 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2221 Symbol c = t.tsym;
duke@1 2222 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2223
duke@1 2224 if ((c.flags_field & LOCKED) != 0) {
duke@1 2225 noteCyclic(pos, (ClassSymbol)c);
duke@1 2226 } else if (!c.type.isErroneous()) {
duke@1 2227 try {
duke@1 2228 c.flags_field |= LOCKED;
jjg@1374 2229 if (c.type.hasTag(CLASS)) {
duke@1 2230 ClassType clazz = (ClassType)c.type;
duke@1 2231 if (clazz.interfaces_field != null)
duke@1 2232 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2233 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2234 if (clazz.supertype_field != null) {
duke@1 2235 Type st = clazz.supertype_field;
jjg@1374 2236 if (st != null && st.hasTag(CLASS))
duke@1 2237 complete &= checkNonCyclicInternal(pos, st);
duke@1 2238 }
duke@1 2239 if (c.owner.kind == TYP)
duke@1 2240 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2241 }
duke@1 2242 } finally {
duke@1 2243 c.flags_field &= ~LOCKED;
duke@1 2244 }
duke@1 2245 }
duke@1 2246 if (complete)
duke@1 2247 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2248 if (complete) c.flags_field |= ACYCLIC;
duke@1 2249 return complete;
duke@1 2250 }
duke@1 2251
duke@1 2252 /** Note that we found an inheritance cycle. */
duke@1 2253 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2254 log.error(pos, "cyclic.inheritance", c);
duke@1 2255 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2256 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2257 Type st = types.supertype(c.type);
jjg@1374 2258 if (st.hasTag(CLASS))
jjg@110 2259 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2260 c.type = types.createErrorType(c, c.type);
duke@1 2261 c.flags_field |= ACYCLIC;
duke@1 2262 }
duke@1 2263
mcimadamore@1415 2264 /**
mcimadamore@1415 2265 * Check that functional interface methods would make sense when seen
mcimadamore@1415 2266 * from the perspective of the implementing class
mcimadamore@1415 2267 */
mcimadamore@1415 2268 void checkFunctionalInterface(JCTree tree, Type funcInterface) {
mcimadamore@1415 2269 ClassType c = new ClassType(Type.noType, List.<Type>nil(), null);
mcimadamore@1415 2270 ClassSymbol csym = new ClassSymbol(0, names.empty, c, syms.noSymbol);
mcimadamore@1579 2271 c.interfaces_field = List.of(types.removeWildcards(funcInterface));
mcimadamore@1415 2272 c.supertype_field = syms.objectType;
mcimadamore@1415 2273 c.tsym = csym;
mcimadamore@1415 2274 csym.members_field = new Scope(csym);
mcimadamore@1579 2275 Symbol descSym = types.findDescriptorSymbol(funcInterface.tsym);
mcimadamore@1579 2276 Type descType = types.findDescriptorType(funcInterface);
mcimadamore@1579 2277 csym.members_field.enter(new MethodSymbol(PUBLIC, descSym.name, descType, csym));
mcimadamore@1415 2278 csym.completer = null;
mcimadamore@1415 2279 checkImplementations(tree, csym, csym);
mcimadamore@1415 2280 }
mcimadamore@1415 2281
duke@1 2282 /** Check that all methods which implement some
duke@1 2283 * method conform to the method they implement.
duke@1 2284 * @param tree The class definition whose members are checked.
duke@1 2285 */
duke@1 2286 void checkImplementations(JCClassDecl tree) {
mcimadamore@1415 2287 checkImplementations(tree, tree.sym, tree.sym);
duke@1 2288 }
jjg@1521 2289 //where
duke@1 2290 /** Check that all methods which implement some
duke@1 2291 * method in `ic' conform to the method they implement.
duke@1 2292 */
mcimadamore@1415 2293 void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) {
duke@1 2294 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2295 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2296 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2297 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2298 if (e.sym.kind == MTH &&
duke@1 2299 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2300 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2301 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2302 if (implmeth != null && implmeth != absmeth &&
duke@1 2303 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2304 (origin.flags() & INTERFACE)) {
duke@1 2305 // don't check if implmeth is in a class, yet
duke@1 2306 // origin is an interface. This case arises only
duke@1 2307 // if implmeth is declared in Object. The reason is
duke@1 2308 // that interfaces really don't inherit from
duke@1 2309 // Object it's just that the compiler represents
duke@1 2310 // things that way.
duke@1 2311 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2312 }
duke@1 2313 }
duke@1 2314 }
duke@1 2315 }
duke@1 2316 }
duke@1 2317 }
duke@1 2318
duke@1 2319 /** Check that all abstract methods implemented by a class are
duke@1 2320 * mutually compatible.
duke@1 2321 * @param pos Position to be used for error reporting.
duke@1 2322 * @param c The class whose interfaces are checked.
duke@1 2323 */
duke@1 2324 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2325 List<Type> supertypes = types.interfaces(c);
duke@1 2326 Type supertype = types.supertype(c);
jjg@1374 2327 if (supertype.hasTag(CLASS) &&
duke@1 2328 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2329 supertypes = supertypes.prepend(supertype);
duke@1 2330 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2331 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2332 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2333 return;
duke@1 2334 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2335 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2336 return;
duke@1 2337 }
duke@1 2338 checkCompatibleConcretes(pos, c);
duke@1 2339 }
duke@1 2340
mcimadamore@359 2341 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2342 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2343 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2344 // VM allows methods and variables with differing types
mcimadamore@359 2345 if (sym.kind == e.sym.kind &&
mcimadamore@359 2346 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2347 sym != e.sym &&
mcimadamore@359 2348 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2349 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2350 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2351 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2352 return;
mcimadamore@359 2353 }
mcimadamore@359 2354 }
mcimadamore@359 2355 }
mcimadamore@359 2356 }
mcimadamore@359 2357
mcimadamore@780 2358 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2359 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2360 *
mcimadamore@780 2361 * @param pos Position to be used for error reporting.
mcimadamore@780 2362 * @param site The class whose methods are checked.
mcimadamore@780 2363 * @param sym The method symbol to be checked.
mcimadamore@780 2364 */
mcimadamore@858 2365 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2366 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2367 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2368 //by method 'sym' in 'site'...
mcimadamore@1198 2369 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2370 if (!sym.overrides(m1, site.tsym, types, false)) continue;
mcimadamore@1198 2371 //...check each method m2 that is a member of 'site'
mcimadamore@1198 2372 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2373 if (m2 == m1) continue;
mcimadamore@858 2374 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2375 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1393 2376 if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) &&
mcimadamore@1198 2377 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2378 sym.flags_field |= CLASH;
mcimadamore@1198 2379 String key = m1 == sym ?
mcimadamore@858 2380 "name.clash.same.erasure.no.override" :
mcimadamore@858 2381 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2382 log.error(pos,
mcimadamore@858 2383 key,
mcimadamore@858 2384 sym, sym.location(),
mcimadamore@1198 2385 m2, m2.location(),
mcimadamore@1198 2386 m1, m1.location());
mcimadamore@858 2387 return;
mcimadamore@858 2388 }
mcimadamore@780 2389 }
mcimadamore@780 2390 }
mcimadamore@780 2391 }
mcimadamore@780 2392
mcimadamore@877 2393
mcimadamore@877 2394
mcimadamore@858 2395 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2396 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2397 *
mcimadamore@858 2398 * @param pos Position to be used for error reporting.
mcimadamore@858 2399 * @param site The class whose methods are checked.
mcimadamore@858 2400 * @param sym The method symbol to be checked.
mcimadamore@780 2401 */
mcimadamore@858 2402 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2403 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2404 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2405 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2406 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2407 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@1393 2408 if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck) &&
mcimadamore@877 2409 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2410 log.error(pos,
mcimadamore@858 2411 "name.clash.same.erasure.no.hide",
mcimadamore@858 2412 sym, sym.location(),
mcimadamore@877 2413 s, s.location());
mcimadamore@858 2414 return;
mcimadamore@858 2415 }
mcimadamore@858 2416 }
mcimadamore@858 2417 }
mcimadamore@780 2418
mcimadamore@858 2419 //where
mcimadamore@858 2420 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2421
mcimadamore@858 2422 Type site;
mcimadamore@780 2423
mcimadamore@858 2424 ClashFilter(Type site) {
mcimadamore@858 2425 this.site = site;
mcimadamore@858 2426 }
mcimadamore@858 2427
mcimadamore@858 2428 boolean shouldSkip(Symbol s) {
mcimadamore@858 2429 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2430 s.owner == site.tsym;
mcimadamore@858 2431 }
mcimadamore@858 2432
mcimadamore@858 2433 public boolean accepts(Symbol s) {
mcimadamore@858 2434 return s.kind == MTH &&
mcimadamore@858 2435 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2436 !shouldSkip(s) &&
mcimadamore@858 2437 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2438 !s.isConstructor();
mcimadamore@858 2439 }
mcimadamore@858 2440 }
mcimadamore@780 2441
mcimadamore@1393 2442 void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) {
mcimadamore@1393 2443 DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site);
mcimadamore@1393 2444 for (Symbol m : types.membersClosure(site, false).getElements(dcf)) {
mcimadamore@1393 2445 Assert.check(m.kind == MTH);
mcimadamore@1393 2446 List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m);
mcimadamore@1393 2447 if (prov.size() > 1) {
mcimadamore@1393 2448 ListBuffer<Symbol> abstracts = ListBuffer.lb();
mcimadamore@1393 2449 ListBuffer<Symbol> defaults = ListBuffer.lb();
mcimadamore@1393 2450 for (MethodSymbol provSym : prov) {
mcimadamore@1393 2451 if ((provSym.flags() & DEFAULT) != 0) {
mcimadamore@1393 2452 defaults = defaults.append(provSym);
mcimadamore@1393 2453 } else if ((provSym.flags() & ABSTRACT) != 0) {
mcimadamore@1393 2454 abstracts = abstracts.append(provSym);
mcimadamore@1393 2455 }
mcimadamore@1393 2456 if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) {
mcimadamore@1393 2457 //strong semantics - issue an error if two sibling interfaces
mcimadamore@1393 2458 //have two override-equivalent defaults - or if one is abstract
mcimadamore@1393 2459 //and the other is default
mcimadamore@1393 2460 String errKey;
mcimadamore@1393 2461 Symbol s1 = defaults.first();
mcimadamore@1393 2462 Symbol s2;
mcimadamore@1393 2463 if (defaults.size() > 1) {
mcimadamore@1393 2464 errKey = "types.incompatible.unrelated.defaults";
mcimadamore@1393 2465 s2 = defaults.toList().tail.head;
mcimadamore@1393 2466 } else {
mcimadamore@1393 2467 errKey = "types.incompatible.abstract.default";
mcimadamore@1393 2468 s2 = abstracts.first();
mcimadamore@1393 2469 }
mcimadamore@1393 2470 log.error(pos, errKey,
mcimadamore@1393 2471 Kinds.kindName(site.tsym), site,
mcimadamore@1393 2472 m.name, types.memberType(site, m).getParameterTypes(),
mcimadamore@1393 2473 s1.location(), s2.location());
mcimadamore@1393 2474 break;
mcimadamore@1393 2475 }
mcimadamore@1393 2476 }
mcimadamore@1393 2477 }
mcimadamore@1393 2478 }
mcimadamore@1393 2479 }
mcimadamore@1393 2480
mcimadamore@1393 2481 //where
mcimadamore@1393 2482 private class DefaultMethodClashFilter implements Filter<Symbol> {
mcimadamore@1393 2483
mcimadamore@1393 2484 Type site;
mcimadamore@1393 2485
mcimadamore@1393 2486 DefaultMethodClashFilter(Type site) {
mcimadamore@1393 2487 this.site = site;
mcimadamore@1393 2488 }
mcimadamore@1393 2489
mcimadamore@1393 2490 public boolean accepts(Symbol s) {
mcimadamore@1393 2491 return s.kind == MTH &&
mcimadamore@1393 2492 (s.flags() & DEFAULT) != 0 &&
mcimadamore@1393 2493 s.isInheritedIn(site.tsym, types) &&
mcimadamore@1393 2494 !s.isConstructor();
mcimadamore@1393 2495 }
mcimadamore@1393 2496 }
mcimadamore@1393 2497
mcimadamore@359 2498 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2499 */
mcimadamore@359 2500 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2501 if (!sym.type.isErroneous()) {
mcimadamore@359 2502 if (warnOnSyntheticConflicts) {
mcimadamore@359 2503 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2504 }
mcimadamore@359 2505 else {
mcimadamore@359 2506 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2507 }
mcimadamore@359 2508 }
mcimadamore@359 2509 }
mcimadamore@359 2510
duke@1 2511 /** Check that class c does not implement directly or indirectly
duke@1 2512 * the same parameterized interface with two different argument lists.
duke@1 2513 * @param pos Position to be used for error reporting.
duke@1 2514 * @param type The type whose interfaces are checked.
duke@1 2515 */
duke@1 2516 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2517 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2518 }
duke@1 2519 //where
duke@1 2520 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2521 * with their class symbol as key and their type as value. Make
duke@1 2522 * sure no class is entered with two different types.
duke@1 2523 */
duke@1 2524 void checkClassBounds(DiagnosticPosition pos,
duke@1 2525 Map<TypeSymbol,Type> seensofar,
duke@1 2526 Type type) {
duke@1 2527 if (type.isErroneous()) return;
duke@1 2528 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2529 Type it = l.head;
duke@1 2530 Type oldit = seensofar.put(it.tsym, it);
duke@1 2531 if (oldit != null) {
duke@1 2532 List<Type> oldparams = oldit.allparams();
duke@1 2533 List<Type> newparams = it.allparams();
duke@1 2534 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2535 log.error(pos, "cant.inherit.diff.arg",
duke@1 2536 it.tsym, Type.toString(oldparams),
duke@1 2537 Type.toString(newparams));
duke@1 2538 }
duke@1 2539 checkClassBounds(pos, seensofar, it);
duke@1 2540 }
duke@1 2541 Type st = types.supertype(type);
duke@1 2542 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2543 }
duke@1 2544
duke@1 2545 /** Enter interface into into set.
duke@1 2546 * If it existed already, issue a "repeated interface" error.
duke@1 2547 */
duke@1 2548 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2549 if (its.contains(it))
duke@1 2550 log.error(pos, "repeated.interface");
duke@1 2551 else {
duke@1 2552 its.add(it);
duke@1 2553 }
duke@1 2554 }
duke@1 2555
duke@1 2556 /* *************************************************************************
duke@1 2557 * Check annotations
duke@1 2558 **************************************************************************/
duke@1 2559
mcimadamore@629 2560 /**
mcimadamore@634 2561 * Recursively validate annotations values
mcimadamore@629 2562 */
mcimadamore@634 2563 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2564 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2565 @Override
mcimadamore@629 2566 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2567 if (!tree.type.isErroneous()) {
jjg@1017 2568 super.visitAnnotation(tree);
jjg@1017 2569 validateAnnotation(tree);
jjg@1017 2570 }
mcimadamore@629 2571 }
mcimadamore@629 2572 }
mcimadamore@634 2573 tree.accept(new AnnotationValidator());
mcimadamore@629 2574 }
mcimadamore@629 2575
jjg@1326 2576 /**
jjg@1326 2577 * {@literal
jjg@1326 2578 * Annotation types are restricted to primitives, String, an
duke@1 2579 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2580 * Anything>, arrays of the preceding.
jjg@1326 2581 * }
duke@1 2582 */
duke@1 2583 void validateAnnotationType(JCTree restype) {
duke@1 2584 // restype may be null if an error occurred, so don't bother validating it
duke@1 2585 if (restype != null) {
duke@1 2586 validateAnnotationType(restype.pos(), restype.type);
duke@1 2587 }
duke@1 2588 }
duke@1 2589
duke@1 2590 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2591 if (type.isPrimitive()) return;
duke@1 2592 if (types.isSameType(type, syms.stringType)) return;
duke@1 2593 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2594 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2595 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2596 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2597 validateAnnotationType(pos, types.elemtype(type));
duke@1 2598 return;
duke@1 2599 }
duke@1 2600 log.error(pos, "invalid.annotation.member.type");
duke@1 2601 }
duke@1 2602
duke@1 2603 /**
duke@1 2604 * "It is also a compile-time error if any method declared in an
duke@1 2605 * annotation type has a signature that is override-equivalent to
duke@1 2606 * that of any public or protected method declared in class Object
duke@1 2607 * or in the interface annotation.Annotation."
duke@1 2608 *
jjh@972 2609 * @jls 9.6 Annotation Types
duke@1 2610 */
duke@1 2611 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
jjg@1374 2612 for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
duke@1 2613 Scope s = sup.tsym.members();
duke@1 2614 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2615 if (e.sym.kind == MTH &&
duke@1 2616 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2617 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2618 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2619 }
duke@1 2620 }
duke@1 2621 }
duke@1 2622
duke@1 2623 /** Check the annotations of a symbol.
duke@1 2624 */
duke@1 2625 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2626 for (JCAnnotation a : annotations)
duke@1 2627 validateAnnotation(a, s);
duke@1 2628 }
duke@1 2629
jjg@1521 2630 /** Check the type annotations.
jjg@1521 2631 */
jjg@1521 2632 public void validateTypeAnnotations(List<JCAnnotation> annotations, boolean isTypeParameter) {
jjg@1521 2633 for (JCAnnotation a : annotations)
jjg@1521 2634 validateTypeAnnotation(a, isTypeParameter);
jjg@1521 2635 }
jjg@1521 2636
duke@1 2637 /** Check an annotation of a symbol.
duke@1 2638 */
jfranck@1313 2639 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2640 validateAnnotationTree(a);
duke@1 2641
duke@1 2642 if (!annotationApplicable(a, s))
duke@1 2643 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2644
duke@1 2645 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2646 if (!isOverrider(s))
duke@1 2647 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2648 }
mcimadamore@1497 2649
mcimadamore@1497 2650 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
mcimadamore@1497 2651 if (s.kind != TYP) {
mcimadamore@1497 2652 log.error(a.pos(), "bad.functional.intf.anno");
mcimadamore@1497 2653 } else {
mcimadamore@1497 2654 try {
mcimadamore@1497 2655 types.findDescriptorSymbol((TypeSymbol)s);
mcimadamore@1497 2656 } catch (Types.FunctionDescriptorLookupError ex) {
mcimadamore@1497 2657 log.error(a.pos(), "bad.functional.intf.anno.1", ex.getDiagnostic());
mcimadamore@1497 2658 }
mcimadamore@1497 2659 }
mcimadamore@1497 2660 }
duke@1 2661 }
duke@1 2662
jjg@1521 2663 public void validateTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2664 Assert.checkNonNull(a.type, "annotation tree hasn't been attributed yet: " + a);
jjg@1521 2665 validateAnnotationTree(a);
jjg@1521 2666
jjg@1521 2667 if (!isTypeAnnotation(a, isTypeParameter))
jjg@1521 2668 log.error(a.pos(), "annotation.type.not.applicable");
jjg@1521 2669 }
jjg@1521 2670
jfranck@1313 2671 /**
jjg@1492 2672 * Validate the proposed container 'repeatable' on the
jfranck@1313 2673 * annotation type symbol 's'. Report errors at position
jfranck@1313 2674 * 'pos'.
jfranck@1313 2675 *
jjg@1492 2676 * @param s The (annotation)type declaration annotated with a @Repeatable
jjg@1492 2677 * @param repeatable the @Repeatable on 's'
jfranck@1313 2678 * @param pos where to report errors
jfranck@1313 2679 */
jjg@1492 2680 public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) {
jjg@1492 2681 Assert.check(types.isSameType(repeatable.type, syms.repeatableType));
jfranck@1313 2682
jfranck@1313 2683 Type t = null;
jjg@1492 2684 List<Pair<MethodSymbol,Attribute>> l = repeatable.values;
jfranck@1313 2685 if (!l.isEmpty()) {
jfranck@1313 2686 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2687 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2688 }
jfranck@1313 2689
jfranck@1313 2690 if (t == null) {
jjg@1492 2691 // errors should already have been reported during Annotate
jfranck@1313 2692 return;
jfranck@1313 2693 }
jfranck@1313 2694
jjg@1492 2695 validateValue(t.tsym, s, pos);
jfranck@1313 2696 validateRetention(t.tsym, s, pos);
jfranck@1313 2697 validateDocumented(t.tsym, s, pos);
jfranck@1313 2698 validateInherited(t.tsym, s, pos);
jfranck@1313 2699 validateTarget(t.tsym, s, pos);
jfranck@1344 2700 validateDefault(t.tsym, s, pos);
jfranck@1313 2701 }
jfranck@1313 2702
jjg@1492 2703 private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jjg@1492 2704 Scope.Entry e = container.members().lookup(names.value);
jjg@1492 2705 if (e.scope != null && e.sym.kind == MTH) {
jjg@1492 2706 MethodSymbol m = (MethodSymbol) e.sym;
jjg@1492 2707 Type ret = m.getReturnType();
jjg@1492 2708 if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) {
jjg@1492 2709 log.error(pos, "invalid.repeatable.annotation.value.return",
jjg@1492 2710 container, ret, types.makeArrayType(contained.type));
jjg@1492 2711 }
jjg@1492 2712 } else {
jjg@1492 2713 log.error(pos, "invalid.repeatable.annotation.no.value", container);
jfranck@1313 2714 }
jfranck@1313 2715 }
jfranck@1313 2716
jfranck@1313 2717 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2718 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2719 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2720
jfranck@1313 2721 boolean error = false;
jfranck@1313 2722 switch (containedRetention) {
jfranck@1313 2723 case RUNTIME:
jfranck@1313 2724 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2725 error = true;
jfranck@1313 2726 }
jfranck@1313 2727 break;
jfranck@1313 2728 case CLASS:
jfranck@1313 2729 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2730 error = true;
jfranck@1313 2731 }
jfranck@1313 2732 }
jfranck@1313 2733 if (error ) {
jjg@1492 2734 log.error(pos, "invalid.repeatable.annotation.retention",
jfranck@1313 2735 container, containerRetention,
jfranck@1313 2736 contained, containedRetention);
jfranck@1313 2737 }
jfranck@1313 2738 }
jfranck@1313 2739
jfranck@1313 2740 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2741 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2742 if (container.attribute(syms.documentedType.tsym) == null) {
jjg@1492 2743 log.error(pos, "invalid.repeatable.annotation.not.documented", container, contained);
jfranck@1313 2744 }
jfranck@1313 2745 }
jfranck@1313 2746 }
jfranck@1313 2747
jfranck@1313 2748 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2749 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2750 if (container.attribute(syms.inheritedType.tsym) == null) {
jjg@1492 2751 log.error(pos, "invalid.repeatable.annotation.not.inherited", container, contained);
jfranck@1313 2752 }
jfranck@1313 2753 }
jfranck@1313 2754 }
jfranck@1313 2755
jfranck@1313 2756 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2757 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1313 2758
jfranck@1313 2759 // If contained has no Target, we are done
jfranck@1313 2760 if (containedTarget == null) {
jfranck@1313 2761 return;
jfranck@1313 2762 }
jfranck@1313 2763
jfranck@1313 2764 // If contained has Target m1, container must have a Target
jfranck@1313 2765 // annotation, m2, and m2 must be a subset of m1. (This is
jfranck@1313 2766 // trivially true if contained has no target as per above).
jfranck@1313 2767
jfranck@1313 2768 // contained has target, but container has not, error
jfranck@1313 2769 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2770 if (containerTarget == null) {
jjg@1492 2771 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2772 return;
jfranck@1313 2773 }
jfranck@1313 2774
jfranck@1313 2775 Set<Name> containerTargets = new HashSet<Name>();
jfranck@1313 2776 for (Attribute app : containerTarget.values) {
jfranck@1313 2777 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2778 continue; // recovery
jfranck@1313 2779 }
jfranck@1313 2780 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2781 containerTargets.add(e.value.name);
jfranck@1313 2782 }
jfranck@1313 2783
jfranck@1313 2784 Set<Name> containedTargets = new HashSet<Name>();
jfranck@1313 2785 for (Attribute app : containedTarget.values) {
jfranck@1313 2786 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2787 continue; // recovery
jfranck@1313 2788 }
jfranck@1313 2789 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2790 containedTargets.add(e.value.name);
jfranck@1313 2791 }
jfranck@1313 2792
jfranck@1313 2793 if (!isTargetSubset(containedTargets, containerTargets)) {
jjg@1492 2794 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2795 }
jfranck@1313 2796 }
jfranck@1313 2797
jfranck@1313 2798 /** Checks that t is a subset of s, with respect to ElementType
jfranck@1313 2799 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE}
jfranck@1313 2800 */
jfranck@1313 2801 private boolean isTargetSubset(Set<Name> s, Set<Name> t) {
jfranck@1313 2802 // Check that all elements in t are present in s
jfranck@1313 2803 for (Name n2 : t) {
jfranck@1313 2804 boolean currentElementOk = false;
jfranck@1313 2805 for (Name n1 : s) {
jfranck@1313 2806 if (n1 == n2) {
jfranck@1313 2807 currentElementOk = true;
jfranck@1313 2808 break;
jfranck@1313 2809 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2810 currentElementOk = true;
jfranck@1313 2811 break;
jfranck@1313 2812 }
jfranck@1313 2813 }
jfranck@1313 2814 if (!currentElementOk)
jfranck@1313 2815 return false;
jfranck@1313 2816 }
jfranck@1313 2817 return true;
jfranck@1313 2818 }
jfranck@1313 2819
jfranck@1344 2820 private void validateDefault(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1344 2821 // validate that all other elements of containing type has defaults
jfranck@1344 2822 Scope scope = container.members();
jfranck@1344 2823 for(Symbol elm : scope.getElements()) {
jfranck@1344 2824 if (elm.name != names.value &&
jfranck@1344 2825 elm.kind == Kinds.MTH &&
jfranck@1344 2826 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2827 log.error(pos,
jjg@1492 2828 "invalid.repeatable.annotation.elem.nondefault",
jfranck@1344 2829 container,
jfranck@1344 2830 elm);
jfranck@1344 2831 }
jfranck@1344 2832 }
jfranck@1344 2833 }
jfranck@1344 2834
duke@1 2835 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2836 boolean isOverrider(Symbol s) {
duke@1 2837 if (s.kind != MTH || s.isStatic())
duke@1 2838 return false;
duke@1 2839 MethodSymbol m = (MethodSymbol)s;
duke@1 2840 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2841 for (Type sup : types.closure(owner.type)) {
duke@1 2842 if (sup == owner.type)
duke@1 2843 continue; // skip "this"
duke@1 2844 Scope scope = sup.tsym.members();
duke@1 2845 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2846 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2847 return true;
duke@1 2848 }
duke@1 2849 }
duke@1 2850 return false;
duke@1 2851 }
duke@1 2852
jjg@1521 2853 /** Is the annotation applicable to type annotations? */
jjg@1521 2854 protected boolean isTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2855 Attribute.Compound atTarget =
jjg@1521 2856 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
jjg@1521 2857 if (atTarget == null) {
jjg@1521 2858 // An annotation without @Target is not a type annotation.
jjg@1521 2859 return false;
jjg@1521 2860 }
jjg@1521 2861
jjg@1521 2862 Attribute atValue = atTarget.member(names.value);
jjg@1521 2863 if (!(atValue instanceof Attribute.Array)) {
jjg@1521 2864 return false; // error recovery
jjg@1521 2865 }
jjg@1521 2866
jjg@1521 2867 Attribute.Array arr = (Attribute.Array) atValue;
jjg@1521 2868 for (Attribute app : arr.values) {
jjg@1521 2869 if (!(app instanceof Attribute.Enum)) {
jjg@1521 2870 return false; // recovery
jjg@1521 2871 }
jjg@1521 2872 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 2873
jjg@1521 2874 if (e.value.name == names.TYPE_USE)
jjg@1521 2875 return true;
jjg@1521 2876 else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER)
jjg@1521 2877 return true;
jjg@1521 2878 }
jjg@1521 2879 return false;
jjg@1521 2880 }
jjg@1521 2881
duke@1 2882 /** Is the annotation applicable to the symbol? */
duke@1 2883 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 2884 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jjg@1521 2885 Name[] targets;
jjg@1521 2886
jfranck@1313 2887 if (arr == null) {
jjg@1521 2888 targets = defaultTargetMetaInfo(a, s);
jjg@1521 2889 } else {
jjg@1521 2890 // TODO: can we optimize this?
jjg@1521 2891 targets = new Name[arr.values.length];
jjg@1521 2892 for (int i=0; i<arr.values.length; ++i) {
jjg@1521 2893 Attribute app = arr.values[i];
jjg@1521 2894 if (!(app instanceof Attribute.Enum)) {
jjg@1521 2895 return true; // recovery
jjg@1521 2896 }
jjg@1521 2897 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 2898 targets[i] = e.value.name;
jjg@1521 2899 }
jfranck@1313 2900 }
jjg@1521 2901 for (Name target : targets) {
jjg@1521 2902 if (target == names.TYPE)
duke@1 2903 { if (s.kind == TYP) return true; }
jjg@1521 2904 else if (target == names.FIELD)
duke@1 2905 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
jjg@1521 2906 else if (target == names.METHOD)
duke@1 2907 { if (s.kind == MTH && !s.isConstructor()) return true; }
jjg@1521 2908 else if (target == names.PARAMETER)
duke@1 2909 { if (s.kind == VAR &&
duke@1 2910 s.owner.kind == MTH &&
duke@1 2911 (s.flags() & PARAMETER) != 0)
duke@1 2912 return true;
duke@1 2913 }
jjg@1521 2914 else if (target == names.CONSTRUCTOR)
duke@1 2915 { if (s.kind == MTH && s.isConstructor()) return true; }
jjg@1521 2916 else if (target == names.LOCAL_VARIABLE)
duke@1 2917 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2918 (s.flags() & PARAMETER) == 0)
duke@1 2919 return true;
duke@1 2920 }
jjg@1521 2921 else if (target == names.ANNOTATION_TYPE)
duke@1 2922 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2923 return true;
duke@1 2924 }
jjg@1521 2925 else if (target == names.PACKAGE)
duke@1 2926 { if (s.kind == PCK) return true; }
jjg@1521 2927 else if (target == names.TYPE_USE)
jjg@308 2928 { if (s.kind == TYP ||
jjg@308 2929 s.kind == VAR ||
jjg@308 2930 (s.kind == MTH && !s.isConstructor() &&
jjg@1521 2931 !s.type.getReturnType().hasTag(VOID)) ||
jjg@1521 2932 (s.kind == MTH && s.isConstructor()))
jjg@1521 2933 return true;
jjg@1521 2934 }
jjg@1521 2935 else if (target == names.TYPE_PARAMETER)
jjg@1521 2936 { if (s.kind == TYP && s.type.hasTag(TYPEVAR))
jjg@308 2937 return true;
jjg@308 2938 }
duke@1 2939 else
duke@1 2940 return true; // recovery
duke@1 2941 }
duke@1 2942 return false;
duke@1 2943 }
duke@1 2944
jfranck@1313 2945
jfranck@1313 2946 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 2947 Attribute.Compound atTarget =
jfranck@1313 2948 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 2949 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 2950 Attribute atValue = atTarget.member(names.value);
jfranck@1313 2951 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 2952 return (Attribute.Array) atValue;
jfranck@1313 2953 }
jfranck@1313 2954
jjg@1521 2955 private final Name[] dfltTargetMeta;
jjg@1521 2956 private Name[] defaultTargetMetaInfo(JCAnnotation a, Symbol s) {
jjg@1521 2957 return dfltTargetMeta;
jjg@1521 2958 }
jjg@1521 2959
duke@1 2960 /** Check an annotation value.
jfranck@1445 2961 *
jfranck@1445 2962 * @param a The annotation tree to check
jfranck@1445 2963 * @return true if this annotation tree is valid, otherwise false
duke@1 2964 */
jfranck@1445 2965 public boolean validateAnnotationDeferErrors(JCAnnotation a) {
jfranck@1445 2966 boolean res = false;
jfranck@1445 2967 final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log);
jfranck@1445 2968 try {
jfranck@1445 2969 res = validateAnnotation(a);
jfranck@1445 2970 } finally {
jfranck@1445 2971 log.popDiagnosticHandler(diagHandler);
jfranck@1445 2972 }
jfranck@1445 2973 return res;
jfranck@1445 2974 }
jfranck@1445 2975
jfranck@1445 2976 private boolean validateAnnotation(JCAnnotation a) {
jfranck@1445 2977 boolean isValid = true;
jfranck@1445 2978 // collect an inventory of the annotation elements
jfranck@1445 2979 Set<MethodSymbol> members = new LinkedHashSet<MethodSymbol>();
duke@1 2980 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2981 e != null;
duke@1 2982 e = e.sibling)
duke@1 2983 if (e.sym.kind == MTH)
duke@1 2984 members.add((MethodSymbol) e.sym);
duke@1 2985
jfranck@1445 2986 // remove the ones that are assigned values
duke@1 2987 for (JCTree arg : a.args) {
jjg@1127 2988 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 2989 JCAssign assign = (JCAssign) arg;
duke@1 2990 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2991 if (m == null || m.type.isErroneous()) continue;
jfranck@1445 2992 if (!members.remove(m)) {
jfranck@1445 2993 isValid = false;
jjg@479 2994 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2995 m.name, a.type);
jfranck@1445 2996 }
duke@1 2997 }
duke@1 2998
duke@1 2999 // all the remaining ones better have default values
jfranck@1445 3000 List<Name> missingDefaults = List.nil();
mcimadamore@632 3001 for (MethodSymbol m : members) {
mcimadamore@632 3002 if (m.defaultValue == null && !m.type.isErroneous()) {
jfranck@1445 3003 missingDefaults = missingDefaults.append(m.name);
mcimadamore@632 3004 }
mcimadamore@632 3005 }
jfranck@1445 3006 missingDefaults = missingDefaults.reverse();
mcimadamore@632 3007 if (missingDefaults.nonEmpty()) {
jfranck@1445 3008 isValid = false;
mcimadamore@632 3009 String key = (missingDefaults.size() > 1)
mcimadamore@632 3010 ? "annotation.missing.default.value.1"
mcimadamore@632 3011 : "annotation.missing.default.value";
mcimadamore@632 3012 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 3013 }
duke@1 3014
duke@1 3015 // special case: java.lang.annotation.Target must not have
duke@1 3016 // repeated values in its value member
duke@1 3017 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 3018 a.args.tail == null)
jfranck@1445 3019 return isValid;
duke@1 3020
jfranck@1445 3021 if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery
duke@1 3022 JCAssign assign = (JCAssign) a.args.head;
duke@1 3023 Symbol m = TreeInfo.symbol(assign.lhs);
jfranck@1445 3024 if (m.name != names.value) return false;
duke@1 3025 JCTree rhs = assign.rhs;
jfranck@1445 3026 if (!rhs.hasTag(NEWARRAY)) return false;
duke@1 3027 JCNewArray na = (JCNewArray) rhs;
duke@1 3028 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 3029 for (JCTree elem : na.elems) {
duke@1 3030 if (!targets.add(TreeInfo.symbol(elem))) {
jfranck@1445 3031 isValid = false;
duke@1 3032 log.error(elem.pos(), "repeated.annotation.target");
duke@1 3033 }
duke@1 3034 }
jfranck@1445 3035 return isValid;
duke@1 3036 }
duke@1 3037
duke@1 3038 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 3039 if (allowAnnotations &&
mcimadamore@795 3040 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 3041 (s.flags() & DEPRECATED) != 0 &&
duke@1 3042 !syms.deprecatedType.isErroneous() &&
duke@1 3043 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 3044 log.warning(LintCategory.DEP_ANN,
jjg@612 3045 pos, "missing.deprecated.annotation");
duke@1 3046 }
duke@1 3047 }
duke@1 3048
mcimadamore@852 3049 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 3050 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 3051 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 3052 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 3053 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3054 @Override
mcimadamore@852 3055 public void report() {
mcimadamore@852 3056 warnDeprecated(pos, s);
mcimadamore@852 3057 }
mcimadamore@852 3058 });
jjg@1157 3059 }
mcimadamore@852 3060 }
mcimadamore@852 3061
mcimadamore@852 3062 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 3063 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 3064 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3065 public void report() {
mcimadamore@852 3066 if (enableSunApiLintControl)
mcimadamore@852 3067 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 3068 else
mcimadamore@1218 3069 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 3070 }
mcimadamore@852 3071 });
mcimadamore@852 3072 }
mcimadamore@852 3073 }
mcimadamore@852 3074
jjg@1569 3075 void checkProfile(final DiagnosticPosition pos, final Symbol s) {
jjg@1569 3076 if (profile != Profile.DEFAULT && (s.flags() & NOT_IN_PROFILE) != 0) {
jjg@1569 3077 log.error(pos, "not.in.profile", s, profile);
jjg@1569 3078 }
jjg@1569 3079 }
jjg@1569 3080
duke@1 3081 /* *************************************************************************
duke@1 3082 * Check for recursive annotation elements.
duke@1 3083 **************************************************************************/
duke@1 3084
duke@1 3085 /** Check for cycles in the graph of annotation elements.
duke@1 3086 */
duke@1 3087 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 3088 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 3089 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 3090 try {
duke@1 3091 tree.sym.flags_field |= LOCKED;
duke@1 3092 for (JCTree def : tree.defs) {
jjg@1127 3093 if (!def.hasTag(METHODDEF)) continue;
duke@1 3094 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 3095 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 3096 }
duke@1 3097 } finally {
duke@1 3098 tree.sym.flags_field &= ~LOCKED;
duke@1 3099 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 3100 }
duke@1 3101 }
duke@1 3102
duke@1 3103 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 3104 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 3105 return;
duke@1 3106 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 3107 log.error(pos, "cyclic.annotation.element");
duke@1 3108 return;
duke@1 3109 }
duke@1 3110 try {
duke@1 3111 tsym.flags_field |= LOCKED;
duke@1 3112 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 3113 Symbol s = e.sym;
duke@1 3114 if (s.kind != Kinds.MTH)
duke@1 3115 continue;
duke@1 3116 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 3117 }
duke@1 3118 } finally {
duke@1 3119 tsym.flags_field &= ~LOCKED;
duke@1 3120 tsym.flags_field |= ACYCLIC_ANN;
duke@1 3121 }
duke@1 3122 }
duke@1 3123
duke@1 3124 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
jjg@1374 3125 switch (type.getTag()) {
jjg@1374 3126 case CLASS:
duke@1 3127 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 3128 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 3129 break;
jjg@1374 3130 case ARRAY:
duke@1 3131 checkAnnotationResType(pos, types.elemtype(type));
duke@1 3132 break;
duke@1 3133 default:
duke@1 3134 break; // int etc
duke@1 3135 }
duke@1 3136 }
duke@1 3137
duke@1 3138 /* *************************************************************************
duke@1 3139 * Check for cycles in the constructor call graph.
duke@1 3140 **************************************************************************/
duke@1 3141
duke@1 3142 /** Check for cycles in the graph of constructors calling other
duke@1 3143 * constructors.
duke@1 3144 */
duke@1 3145 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 3146 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 3147
duke@1 3148 // enter each constructor this-call into the map
duke@1 3149 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 3150 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 3151 if (app == null) continue;
duke@1 3152 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 3153 if (TreeInfo.name(app.meth) == names._this) {
duke@1 3154 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 3155 } else {
duke@1 3156 meth.sym.flags_field |= ACYCLIC;
duke@1 3157 }
duke@1 3158 }
duke@1 3159
duke@1 3160 // Check for cycles in the map
duke@1 3161 Symbol[] ctors = new Symbol[0];
duke@1 3162 ctors = callMap.keySet().toArray(ctors);
duke@1 3163 for (Symbol caller : ctors) {
duke@1 3164 checkCyclicConstructor(tree, caller, callMap);
duke@1 3165 }
duke@1 3166 }
duke@1 3167
duke@1 3168 /** Look in the map to see if the given constructor is part of a
duke@1 3169 * call cycle.
duke@1 3170 */
duke@1 3171 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 3172 Map<Symbol,Symbol> callMap) {
duke@1 3173 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 3174 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 3175 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 3176 "recursive.ctor.invocation");
duke@1 3177 } else {
duke@1 3178 ctor.flags_field |= LOCKED;
duke@1 3179 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 3180 ctor.flags_field &= ~LOCKED;
duke@1 3181 }
duke@1 3182 ctor.flags_field |= ACYCLIC;
duke@1 3183 }
duke@1 3184 }
duke@1 3185
duke@1 3186 /* *************************************************************************
duke@1 3187 * Miscellaneous
duke@1 3188 **************************************************************************/
duke@1 3189
duke@1 3190 /**
duke@1 3191 * Return the opcode of the operator but emit an error if it is an
duke@1 3192 * error.
duke@1 3193 * @param pos position for error reporting.
duke@1 3194 * @param operator an operator
duke@1 3195 * @param tag a tree tag
duke@1 3196 * @param left type of left hand side
duke@1 3197 * @param right type of right hand side
duke@1 3198 */
duke@1 3199 int checkOperator(DiagnosticPosition pos,
duke@1 3200 OperatorSymbol operator,
jjg@1127 3201 JCTree.Tag tag,
duke@1 3202 Type left,
duke@1 3203 Type right) {
duke@1 3204 if (operator.opcode == ByteCodes.error) {
duke@1 3205 log.error(pos,
mcimadamore@853 3206 "operator.cant.be.applied.1",
duke@1 3207 treeinfo.operatorName(tag),
mcimadamore@853 3208 left, right);
duke@1 3209 }
duke@1 3210 return operator.opcode;
duke@1 3211 }
duke@1 3212
duke@1 3213
duke@1 3214 /**
duke@1 3215 * Check for division by integer constant zero
duke@1 3216 * @param pos Position for error reporting.
duke@1 3217 * @param operator The operator for the expression
duke@1 3218 * @param operand The right hand operand for the expression
duke@1 3219 */
duke@1 3220 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3221 if (operand.constValue() != null
mcimadamore@795 3222 && lint.isEnabled(LintCategory.DIVZERO)
jjg@1374 3223 && (operand.getTag().isSubRangeOf(LONG))
duke@1 3224 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3225 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3226 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3227 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3228 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3229 }
duke@1 3230 }
duke@1 3231 }
duke@1 3232
duke@1 3233 /**
duke@1 3234 * Check for empty statements after if
duke@1 3235 */
duke@1 3236 void checkEmptyIf(JCIf tree) {
jjg@1127 3237 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3238 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3239 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3240 }
duke@1 3241
duke@1 3242 /** Check that symbol is unique in given scope.
duke@1 3243 * @param pos Position for error reporting.
duke@1 3244 * @param sym The symbol.
duke@1 3245 * @param s The scope.
duke@1 3246 */
duke@1 3247 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3248 if (sym.type.isErroneous())
duke@1 3249 return true;
duke@1 3250 if (sym.owner.name == names.any) return false;
duke@1 3251 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3252 if (sym != e.sym &&
mcimadamore@858 3253 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3254 sym.kind == e.sym.kind &&
mcimadamore@858 3255 sym.name != names.error &&
mcimadamore@858 3256 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3257 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3258 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3259 return true;
mcimadamore@907 3260 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3261 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3262 sym.flags_field |= CLASH;
mcimadamore@844 3263 return true;
mcimadamore@844 3264 } else {
duke@1 3265 duplicateError(pos, e.sym);
mcimadamore@844 3266 return false;
mcimadamore@844 3267 }
duke@1 3268 }
duke@1 3269 }
duke@1 3270 return true;
duke@1 3271 }
mcimadamore@844 3272
mcimadamore@858 3273 /** Report duplicate declaration error.
mcimadamore@858 3274 */
mcimadamore@858 3275 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3276 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3277 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3278 }
mcimadamore@858 3279 }
duke@1 3280
duke@1 3281 /** Check that single-type import is not already imported or top-level defined,
duke@1 3282 * but make an exception for two single-type imports which denote the same type.
duke@1 3283 * @param pos Position for error reporting.
duke@1 3284 * @param sym The symbol.
duke@1 3285 * @param s The scope
duke@1 3286 */
duke@1 3287 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3288 return checkUniqueImport(pos, sym, s, false);
duke@1 3289 }
duke@1 3290
duke@1 3291 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3292 * but make an exception for two single-type imports which denote the same type.
duke@1 3293 * @param pos Position for error reporting.
duke@1 3294 * @param sym The symbol.
duke@1 3295 * @param s The scope
duke@1 3296 */
duke@1 3297 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3298 return checkUniqueImport(pos, sym, s, true);
duke@1 3299 }
duke@1 3300
duke@1 3301 /** Check that single-type import is not already imported or top-level defined,
duke@1 3302 * but make an exception for two single-type imports which denote the same type.
duke@1 3303 * @param pos Position for error reporting.
duke@1 3304 * @param sym The symbol.
duke@1 3305 * @param s The scope.
duke@1 3306 * @param staticImport Whether or not this was a static import
duke@1 3307 */
duke@1 3308 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3309 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3310 // is encountered class entered via a class declaration?
duke@1 3311 boolean isClassDecl = e.scope == s;
duke@1 3312 if ((isClassDecl || sym != e.sym) &&
duke@1 3313 sym.kind == e.sym.kind &&
duke@1 3314 sym.name != names.error) {
duke@1 3315 if (!e.sym.type.isErroneous()) {
duke@1 3316 String what = e.sym.toString();
duke@1 3317 if (!isClassDecl) {
duke@1 3318 if (staticImport)
duke@1 3319 log.error(pos, "already.defined.static.single.import", what);
duke@1 3320 else
duke@1 3321 log.error(pos, "already.defined.single.import", what);
duke@1 3322 }
duke@1 3323 else if (sym != e.sym)
duke@1 3324 log.error(pos, "already.defined.this.unit", what);
duke@1 3325 }
duke@1 3326 return false;
duke@1 3327 }
duke@1 3328 }
duke@1 3329 return true;
duke@1 3330 }
duke@1 3331
duke@1 3332 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3333 */
duke@1 3334 public void checkCanonical(JCTree tree) {
duke@1 3335 if (!isCanonical(tree))
duke@1 3336 log.error(tree.pos(), "import.requires.canonical",
duke@1 3337 TreeInfo.symbol(tree));
duke@1 3338 }
duke@1 3339 // where
duke@1 3340 private boolean isCanonical(JCTree tree) {
jjg@1127 3341 while (tree.hasTag(SELECT)) {
duke@1 3342 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3343 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3344 return false;
duke@1 3345 tree = s.selected;
duke@1 3346 }
duke@1 3347 return true;
duke@1 3348 }
duke@1 3349
ohrstrom@1384 3350 /** Check that an auxiliary class is not accessed from any other file than its own.
ohrstrom@1384 3351 */
ohrstrom@1384 3352 void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) {
ohrstrom@1384 3353 if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) &&
ohrstrom@1384 3354 (c.flags() & AUXILIARY) != 0 &&
ohrstrom@1384 3355 rs.isAccessible(env, c) &&
ohrstrom@1384 3356 !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile))
ohrstrom@1384 3357 {
ohrstrom@1384 3358 log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file",
ohrstrom@1384 3359 c, c.sourcefile);
ohrstrom@1384 3360 }
ohrstrom@1384 3361 }
ohrstrom@1384 3362
duke@1 3363 private class ConversionWarner extends Warner {
mcimadamore@795 3364 final String uncheckedKey;
duke@1 3365 final Type found;
duke@1 3366 final Type expected;
mcimadamore@795 3367 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3368 super(pos);
mcimadamore@795 3369 this.uncheckedKey = uncheckedKey;
duke@1 3370 this.found = found;
duke@1 3371 this.expected = expected;
duke@1 3372 }
duke@1 3373
jjg@398 3374 @Override
mcimadamore@795 3375 public void warn(LintCategory lint) {
duke@1 3376 boolean warned = this.warned;
mcimadamore@795 3377 super.warn(lint);
duke@1 3378 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3379 switch (lint) {
mcimadamore@795 3380 case UNCHECKED:
mcimadamore@795 3381 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3382 break;
mcimadamore@795 3383 case VARARGS:
mcimadamore@795 3384 if (method != null &&
mcimadamore@795 3385 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3386 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3387 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3388 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3389 }
mcimadamore@795 3390 break;
mcimadamore@795 3391 default:
mcimadamore@795 3392 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3393 }
duke@1 3394 }
duke@1 3395 }
duke@1 3396
duke@1 3397 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3398 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3399 }
duke@1 3400
duke@1 3401 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3402 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3403 }
duke@1 3404 }

mercurial