src/share/classes/com/sun/tools/javac/comp/Check.java

Tue, 09 Oct 2012 19:31:58 -0700

author
jjg
date
Tue, 09 Oct 2012 19:31:58 -0700
changeset 1358
fc123bdeddb8
parent 1352
d4b3cb1ece84
child 1366
12cf6bfd8c05
permissions
-rw-r--r--

8000208: fix langtools javadoc comment issues
Reviewed-by: bpatel, mcimadamore

duke@1 1 /*
mcimadamore@1198 2 * Copyright (c) 1999, 2012, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
duke@1 30
duke@1 31 import com.sun.tools.javac.code.*;
duke@1 32 import com.sun.tools.javac.jvm.*;
duke@1 33 import com.sun.tools.javac.tree.*;
duke@1 34 import com.sun.tools.javac.util.*;
duke@1 35 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 36 import com.sun.tools.javac.util.List;
duke@1 37
duke@1 38 import com.sun.tools.javac.tree.JCTree.*;
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 43 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 44 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1337 45 import com.sun.tools.javac.comp.Infer.InferenceContext.FreeTypeListener;
duke@1 46
duke@1 47 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 48 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 49 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 50 import static com.sun.tools.javac.code.Kinds.*;
duke@1 51 import static com.sun.tools.javac.code.TypeTags.*;
jjg@1127 52 import static com.sun.tools.javac.code.TypeTags.WILDCARD;
duke@1 53
jjg@1127 54 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 55
duke@1 56 /** Type checking helper class for the attribution phase.
duke@1 57 *
jjg@581 58 * <p><b>This is NOT part of any supported API.
jjg@581 59 * If you write code that depends on this, you do so at your own risk.
duke@1 60 * This code and its internal interfaces are subject to change or
duke@1 61 * deletion without notice.</b>
duke@1 62 */
duke@1 63 public class Check {
duke@1 64 protected static final Context.Key<Check> checkKey =
duke@1 65 new Context.Key<Check>();
duke@1 66
jjg@113 67 private final Names names;
duke@1 68 private final Log log;
mcimadamore@1219 69 private final Resolve rs;
duke@1 70 private final Symtab syms;
mcimadamore@690 71 private final Enter enter;
mcimadamore@1347 72 private final DeferredAttr deferredAttr;
duke@1 73 private final Infer infer;
duke@1 74 private final Types types;
mcimadamore@89 75 private final JCDiagnostic.Factory diags;
mcimadamore@359 76 private boolean warnOnSyntheticConflicts;
jjg@576 77 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 78 private boolean enableSunApiLintControl;
duke@1 79 private final TreeInfo treeinfo;
duke@1 80
duke@1 81 // The set of lint options currently in effect. It is initialized
duke@1 82 // from the context, and then is set/reset as needed by Attr as it
duke@1 83 // visits all the various parts of the trees during attribution.
duke@1 84 private Lint lint;
duke@1 85
mcimadamore@795 86 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 87 // Attr as it visits new method declarations.
mcimadamore@795 88 private MethodSymbol method;
mcimadamore@795 89
duke@1 90 public static Check instance(Context context) {
duke@1 91 Check instance = context.get(checkKey);
duke@1 92 if (instance == null)
duke@1 93 instance = new Check(context);
duke@1 94 return instance;
duke@1 95 }
duke@1 96
duke@1 97 protected Check(Context context) {
duke@1 98 context.put(checkKey, this);
duke@1 99
jjg@113 100 names = Names.instance(context);
duke@1 101 log = Log.instance(context);
mcimadamore@1219 102 rs = Resolve.instance(context);
duke@1 103 syms = Symtab.instance(context);
mcimadamore@690 104 enter = Enter.instance(context);
mcimadamore@1347 105 deferredAttr = DeferredAttr.instance(context);
duke@1 106 infer = Infer.instance(context);
duke@1 107 this.types = Types.instance(context);
mcimadamore@89 108 diags = JCDiagnostic.Factory.instance(context);
duke@1 109 Options options = Options.instance(context);
duke@1 110 lint = Lint.instance(context);
duke@1 111 treeinfo = TreeInfo.instance(context);
duke@1 112
duke@1 113 Source source = Source.instance(context);
duke@1 114 allowGenerics = source.allowGenerics();
mcimadamore@1219 115 allowVarargs = source.allowVarargs();
duke@1 116 allowAnnotations = source.allowAnnotations();
jjg@398 117 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 118 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
jjg@1157 119 complexInference = options.isSet("complexinference");
jjg@700 120 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 121 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 122 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 123
jjg@398 124 Target target = Target.instance(context);
jjg@398 125 syntheticNameChar = target.syntheticNameChar();
jjg@398 126
duke@1 127 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 128 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 129 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 130 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 131
jjg@60 132 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 133 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 134 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 135 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 136 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 137 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 138
mcimadamore@852 139 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 140 }
duke@1 141
duke@1 142 /** Switch: generics enabled?
duke@1 143 */
duke@1 144 boolean allowGenerics;
duke@1 145
mcimadamore@1219 146 /** Switch: varargs enabled?
mcimadamore@1219 147 */
mcimadamore@1219 148 boolean allowVarargs;
mcimadamore@1219 149
duke@1 150 /** Switch: annotations enabled?
duke@1 151 */
duke@1 152 boolean allowAnnotations;
duke@1 153
jjg@398 154 /** Switch: covariant returns enabled?
jjg@398 155 */
jjg@398 156 boolean allowCovariantReturns;
jjg@398 157
mcimadamore@795 158 /** Switch: simplified varargs enabled?
mcimadamore@795 159 */
mcimadamore@795 160 boolean allowSimplifiedVarargs;
mcimadamore@795 161
duke@1 162 /** Switch: -complexinference option set?
duke@1 163 */
duke@1 164 boolean complexInference;
duke@1 165
jjg@398 166 /** Character for synthetic names
jjg@398 167 */
jjg@398 168 char syntheticNameChar;
jjg@398 169
duke@1 170 /** A table mapping flat names of all compiled classes in this run to their
duke@1 171 * symbols; maintained from outside.
duke@1 172 */
duke@1 173 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 174
duke@1 175 /** A handler for messages about deprecated usage.
duke@1 176 */
duke@1 177 private MandatoryWarningHandler deprecationHandler;
duke@1 178
duke@1 179 /** A handler for messages about unchecked or unsafe usage.
duke@1 180 */
duke@1 181 private MandatoryWarningHandler uncheckedHandler;
duke@1 182
jjg@582 183 /** A handler for messages about using proprietary API.
jjg@377 184 */
jjg@377 185 private MandatoryWarningHandler sunApiHandler;
duke@1 186
mcimadamore@852 187 /** A handler for deferred lint warnings.
mcimadamore@852 188 */
mcimadamore@852 189 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 190
duke@1 191 /* *************************************************************************
duke@1 192 * Errors and Warnings
duke@1 193 **************************************************************************/
duke@1 194
duke@1 195 Lint setLint(Lint newLint) {
duke@1 196 Lint prev = lint;
duke@1 197 lint = newLint;
duke@1 198 return prev;
duke@1 199 }
duke@1 200
mcimadamore@852 201 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 202 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 203 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 204 return prev;
mcimadamore@852 205 }
mcimadamore@852 206
mcimadamore@795 207 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 208 MethodSymbol prev = method;
mcimadamore@795 209 method = newMethod;
mcimadamore@795 210 return prev;
mcimadamore@795 211 }
mcimadamore@795 212
duke@1 213 /** Warn about deprecated symbol.
duke@1 214 * @param pos Position to be used for error reporting.
duke@1 215 * @param sym The deprecated symbol.
duke@1 216 */
duke@1 217 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 218 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 219 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 220 }
duke@1 221
duke@1 222 /** Warn about unchecked operation.
duke@1 223 * @param pos Position to be used for error reporting.
duke@1 224 * @param msg A string describing the problem.
duke@1 225 */
duke@1 226 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 227 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 228 uncheckedHandler.report(pos, msg, args);
duke@1 229 }
duke@1 230
mcimadamore@580 231 /** Warn about unsafe vararg method decl.
mcimadamore@580 232 * @param pos Position to be used for error reporting.
mcimadamore@580 233 */
mcimadamore@795 234 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 235 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 236 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 237 }
mcimadamore@580 238
jjg@582 239 /** Warn about using proprietary API.
jjg@377 240 * @param pos Position to be used for error reporting.
jjg@377 241 * @param msg A string describing the problem.
jjg@377 242 */
jjg@377 243 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 244 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 245 sunApiHandler.report(pos, msg, args);
jjg@377 246 }
jjg@377 247
jjg@505 248 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 249 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 250 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 251 }
jjg@505 252
duke@1 253 /**
duke@1 254 * Report any deferred diagnostics.
duke@1 255 */
duke@1 256 public void reportDeferredDiagnostics() {
duke@1 257 deprecationHandler.reportDeferredDiagnostic();
duke@1 258 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 259 sunApiHandler.reportDeferredDiagnostic();
duke@1 260 }
duke@1 261
duke@1 262
duke@1 263 /** Report a failure to complete a class.
duke@1 264 * @param pos Position to be used for error reporting.
duke@1 265 * @param ex The failure to report.
duke@1 266 */
duke@1 267 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 268 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 269 if (ex instanceof ClassReader.BadClassFile
jjg@576 270 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 271 else return syms.errType;
duke@1 272 }
duke@1 273
duke@1 274 /** Report an error that wrong type tag was found.
duke@1 275 * @param pos Position to be used for error reporting.
duke@1 276 * @param required An internationalized string describing the type tag
duke@1 277 * required.
duke@1 278 * @param found The type that was found.
duke@1 279 */
duke@1 280 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 281 // this error used to be raised by the parser,
jrose@267 282 // but has been delayed to this point:
jrose@267 283 if (found instanceof Type && ((Type)found).tag == VOID) {
jrose@267 284 log.error(pos, "illegal.start.of.type");
jrose@267 285 return syms.errType;
jrose@267 286 }
duke@1 287 log.error(pos, "type.found.req", found, required);
jjg@110 288 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 289 }
duke@1 290
duke@1 291 /** Report an error that symbol cannot be referenced before super
duke@1 292 * has been called.
duke@1 293 * @param pos Position to be used for error reporting.
duke@1 294 * @param sym The referenced symbol.
duke@1 295 */
duke@1 296 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 297 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 298 }
duke@1 299
duke@1 300 /** Report duplicate declaration error.
duke@1 301 */
duke@1 302 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 303 if (!sym.type.isErroneous()) {
mcimadamore@1085 304 Symbol location = sym.location();
mcimadamore@1085 305 if (location.kind == MTH &&
mcimadamore@1085 306 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 307 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 308 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 309 sym.location().enclClass());
mcimadamore@1085 310 } else {
mcimadamore@1085 311 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 312 kindName(sym.location()), sym.location());
mcimadamore@1085 313 }
duke@1 314 }
duke@1 315 }
duke@1 316
duke@1 317 /** Report array/varargs duplicate declaration
duke@1 318 */
duke@1 319 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 320 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 321 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 322 }
duke@1 323 }
duke@1 324
duke@1 325 /* ************************************************************************
duke@1 326 * duplicate declaration checking
duke@1 327 *************************************************************************/
duke@1 328
duke@1 329 /** Check that variable does not hide variable with same name in
duke@1 330 * immediately enclosing local scope.
duke@1 331 * @param pos Position for error reporting.
duke@1 332 * @param v The symbol.
duke@1 333 * @param s The scope.
duke@1 334 */
duke@1 335 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 336 if (s.next != null) {
duke@1 337 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 338 e.scope != null && e.sym.owner == v.owner;
duke@1 339 e = e.next()) {
duke@1 340 if (e.sym.kind == VAR &&
duke@1 341 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 342 v.name != names.error) {
duke@1 343 duplicateError(pos, e.sym);
duke@1 344 return;
duke@1 345 }
duke@1 346 }
duke@1 347 }
duke@1 348 }
duke@1 349
duke@1 350 /** Check that a class or interface does not hide a class or
duke@1 351 * interface with same name in immediately enclosing local scope.
duke@1 352 * @param pos Position for error reporting.
duke@1 353 * @param c The symbol.
duke@1 354 * @param s The scope.
duke@1 355 */
duke@1 356 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 357 if (s.next != null) {
duke@1 358 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 359 e.scope != null && e.sym.owner == c.owner;
duke@1 360 e = e.next()) {
mcimadamore@639 361 if (e.sym.kind == TYP && e.sym.type.tag != TYPEVAR &&
duke@1 362 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 363 c.name != names.error) {
duke@1 364 duplicateError(pos, e.sym);
duke@1 365 return;
duke@1 366 }
duke@1 367 }
duke@1 368 }
duke@1 369 }
duke@1 370
duke@1 371 /** Check that class does not have the same name as one of
duke@1 372 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 373 * return true if class is unique in its enclosing scope.
duke@1 374 * @param pos Position for error reporting.
duke@1 375 * @param name The class name.
duke@1 376 * @param s The enclosing scope.
duke@1 377 */
duke@1 378 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 379 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 380 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 381 duplicateError(pos, e.sym);
duke@1 382 return false;
duke@1 383 }
duke@1 384 }
duke@1 385 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 386 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 387 duplicateError(pos, sym);
duke@1 388 return true;
duke@1 389 }
duke@1 390 }
duke@1 391 return true;
duke@1 392 }
duke@1 393
duke@1 394 /* *************************************************************************
duke@1 395 * Class name generation
duke@1 396 **************************************************************************/
duke@1 397
duke@1 398 /** Return name of local class.
jjg@1358 399 * This is of the form {@code <enclClass> $ n <classname> }
duke@1 400 * where
duke@1 401 * enclClass is the flat name of the enclosing class,
duke@1 402 * classname is the simple name of the local class
duke@1 403 */
duke@1 404 Name localClassName(ClassSymbol c) {
duke@1 405 for (int i=1; ; i++) {
duke@1 406 Name flatname = names.
duke@1 407 fromString("" + c.owner.enclClass().flatname +
jjg@398 408 syntheticNameChar + i +
duke@1 409 c.name);
duke@1 410 if (compiled.get(flatname) == null) return flatname;
duke@1 411 }
duke@1 412 }
duke@1 413
duke@1 414 /* *************************************************************************
duke@1 415 * Type Checking
duke@1 416 **************************************************************************/
duke@1 417
mcimadamore@1238 418 /**
mcimadamore@1238 419 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 420 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 421 * vary significantly.
mcimadamore@1238 422 */
mcimadamore@1348 423 public interface CheckContext {
mcimadamore@1238 424 /**
mcimadamore@1238 425 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 426 */
mcimadamore@1238 427 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 428 /**
mcimadamore@1238 429 * Report a check error
mcimadamore@1238 430 */
mcimadamore@1296 431 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 432 /**
mcimadamore@1238 433 * Obtain a warner for this check context
mcimadamore@1238 434 */
mcimadamore@1238 435 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 436
mcimadamore@1337 437 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 438
mcimadamore@1347 439 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1348 440
mcimadamore@1348 441 public boolean allowBoxing();
mcimadamore@1238 442 }
mcimadamore@1238 443
mcimadamore@1238 444 /**
mcimadamore@1238 445 * This class represent a check context that is nested within another check
mcimadamore@1238 446 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 447 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 448 * the forwarding pattern.
mcimadamore@1238 449 */
mcimadamore@1238 450 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 451 CheckContext enclosingContext;
mcimadamore@1238 452
mcimadamore@1238 453 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 454 this.enclosingContext = enclosingContext;
mcimadamore@1238 455 }
mcimadamore@1238 456
mcimadamore@1238 457 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 458 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 459 }
mcimadamore@1238 460
mcimadamore@1296 461 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 462 enclosingContext.report(pos, details);
mcimadamore@1238 463 }
mcimadamore@1238 464
mcimadamore@1238 465 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 466 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 467 }
mcimadamore@1337 468
mcimadamore@1337 469 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 470 return enclosingContext.inferenceContext();
mcimadamore@1337 471 }
mcimadamore@1347 472
mcimadamore@1347 473 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 474 return enclosingContext.deferredAttrContext();
mcimadamore@1347 475 }
mcimadamore@1348 476
mcimadamore@1348 477 public boolean allowBoxing() {
mcimadamore@1348 478 return enclosingContext.allowBoxing();
mcimadamore@1348 479 }
mcimadamore@1238 480 }
mcimadamore@1238 481
mcimadamore@1238 482 /**
mcimadamore@1238 483 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 484 */
mcimadamore@1238 485 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 486 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 487 log.error(pos, "prob.found.req", details);
mcimadamore@1238 488 }
mcimadamore@1238 489 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 490 return types.isAssignable(found, req, warn);
mcimadamore@1238 491 }
mcimadamore@1238 492
mcimadamore@1238 493 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 494 return convertWarner(pos, found, req);
mcimadamore@1238 495 }
mcimadamore@1337 496
mcimadamore@1337 497 public InferenceContext inferenceContext() {
mcimadamore@1337 498 return infer.emptyContext;
mcimadamore@1337 499 }
mcimadamore@1347 500
mcimadamore@1347 501 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 502 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 503 }
mcimadamore@1348 504
mcimadamore@1348 505 public boolean allowBoxing() {
mcimadamore@1348 506 return true;
mcimadamore@1348 507 }
mcimadamore@1238 508 };
mcimadamore@1238 509
duke@1 510 /** Check that a given type is assignable to a given proto-type.
duke@1 511 * If it is, return the type, otherwise return errType.
duke@1 512 * @param pos Position to be used for error reporting.
duke@1 513 * @param found The type that was found.
duke@1 514 * @param req The type that was required.
duke@1 515 */
duke@1 516 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 517 return checkType(pos, found, req, basicHandler);
darcy@609 518 }
darcy@609 519
mcimadamore@1337 520 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 521 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 522 if (inferenceContext.free(req)) {
mcimadamore@1337 523 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 524 @Override
mcimadamore@1337 525 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1337 526 checkType(pos, found, inferenceContext.asInstType(req, types), checkContext);
mcimadamore@1337 527 }
mcimadamore@1337 528 });
mcimadamore@1337 529 }
duke@1 530 if (req.tag == ERROR)
duke@1 531 return req;
duke@1 532 if (req.tag == NONE)
duke@1 533 return found;
mcimadamore@1238 534 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 535 return found;
mcimadamore@1238 536 } else {
mcimadamore@1238 537 if (found.tag <= DOUBLE && req.tag <= DOUBLE) {
mcimadamore@1296 538 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 539 return types.createErrorType(found);
mcimadamore@1238 540 }
mcimadamore@1296 541 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 542 return types.createErrorType(found);
duke@1 543 }
duke@1 544 }
duke@1 545
duke@1 546 /** Check that a given type can be cast to a given target type.
duke@1 547 * Return the result of the cast.
duke@1 548 * @param pos Position to be used for error reporting.
duke@1 549 * @param found The type that is being cast.
duke@1 550 * @param req The target type of the cast.
duke@1 551 */
duke@1 552 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 553 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 554 }
mcimadamore@1238 555 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 556 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 557 return req;
duke@1 558 } else {
mcimadamore@1296 559 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 560 return types.createErrorType(found);
duke@1 561 }
duke@1 562 }
mcimadamore@1237 563
mcimadamore@1237 564 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 565 * The problem should only be reported for non-292 cast
mcimadamore@1237 566 */
mcimadamore@1237 567 public void checkRedundantCast(Env<AttrContext> env, JCTypeCast tree) {
mcimadamore@1237 568 if (!tree.type.isErroneous() &&
mcimadamore@1348 569 (env.info.lint == null || env.info.lint.isEnabled(Lint.LintCategory.CAST))
mcimadamore@1348 570 && types.isSameType(tree.expr.type, tree.clazz.type)
mcimadamore@1348 571 && !is292targetTypeCast(tree)) {
mcimadamore@1237 572 log.warning(Lint.LintCategory.CAST,
mcimadamore@1237 573 tree.pos(), "redundant.cast", tree.expr.type);
mcimadamore@1237 574 }
mcimadamore@1237 575 }
mcimadamore@1237 576 //where
mcimadamore@1237 577 private boolean is292targetTypeCast(JCTypeCast tree) {
mcimadamore@1237 578 boolean is292targetTypeCast = false;
mcimadamore@1237 579 JCExpression expr = TreeInfo.skipParens(tree.expr);
mcimadamore@1237 580 if (expr.hasTag(APPLY)) {
mcimadamore@1237 581 JCMethodInvocation apply = (JCMethodInvocation)expr;
mcimadamore@1237 582 Symbol sym = TreeInfo.symbol(apply.meth);
mcimadamore@1237 583 is292targetTypeCast = sym != null &&
mcimadamore@1237 584 sym.kind == MTH &&
mcimadamore@1239 585 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 586 }
mcimadamore@1237 587 return is292targetTypeCast;
mcimadamore@1237 588 }
mcimadamore@1237 589
mcimadamore@1237 590
mcimadamore@1237 591
duke@1 592 //where
duke@1 593 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 594 * type variables?
duke@1 595 */
duke@1 596 boolean isTypeVar(Type t) {
duke@1 597 return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
duke@1 598 }
duke@1 599
duke@1 600 /** Check that a type is within some bounds.
duke@1 601 *
jjg@1358 602 * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
duke@1 603 * type argument.
duke@1 604 * @param a The type that should be bounded by bs.
jjg@1358 605 * @param bound The bound.
duke@1 606 */
mcimadamore@1216 607 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 608 if (a.isUnbound()) {
mcimadamore@821 609 return true;
mcimadamore@154 610 } else if (a.tag != WILDCARD) {
mcimadamore@154 611 a = types.upperBound(a);
mcimadamore@1216 612 return types.isSubtype(a, bound);
mcimadamore@154 613 } else if (a.isExtendsBound()) {
mcimadamore@1216 614 return types.isCastable(bound, types.upperBound(a), Warner.noWarnings);
mcimadamore@154 615 } else if (a.isSuperBound()) {
mcimadamore@1216 616 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 617 }
mcimadamore@821 618 return true;
mcimadamore@154 619 }
duke@1 620
duke@1 621 /** Check that type is different from 'void'.
duke@1 622 * @param pos Position to be used for error reporting.
duke@1 623 * @param t The type to be checked.
duke@1 624 */
duke@1 625 Type checkNonVoid(DiagnosticPosition pos, Type t) {
duke@1 626 if (t.tag == VOID) {
duke@1 627 log.error(pos, "void.not.allowed.here");
jjg@110 628 return types.createErrorType(t);
duke@1 629 } else {
duke@1 630 return t;
duke@1 631 }
duke@1 632 }
duke@1 633
duke@1 634 /** Check that type is a class or interface type.
duke@1 635 * @param pos Position to be used for error reporting.
duke@1 636 * @param t The type to be checked.
duke@1 637 */
duke@1 638 Type checkClassType(DiagnosticPosition pos, Type t) {
duke@1 639 if (t.tag != CLASS && t.tag != ERROR)
duke@1 640 return typeTagError(pos,
mcimadamore@89 641 diags.fragment("type.req.class"),
duke@1 642 (t.tag == TYPEVAR)
mcimadamore@89 643 ? diags.fragment("type.parameter", t)
duke@1 644 : t);
duke@1 645 else
duke@1 646 return t;
duke@1 647 }
duke@1 648
mcimadamore@1352 649 /** Check that type is a valid qualifier for a constructor reference expression
mcimadamore@1352 650 */
mcimadamore@1352 651 Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
mcimadamore@1352 652 t = checkClassType(pos, t);
mcimadamore@1352 653 if (t.tag == CLASS) {
mcimadamore@1352 654 if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
mcimadamore@1352 655 log.error(pos, "abstract.cant.be.instantiated");
mcimadamore@1352 656 t = types.createErrorType(t);
mcimadamore@1352 657 } else if ((t.tsym.flags() & ENUM) != 0) {
mcimadamore@1352 658 log.error(pos, "enum.cant.be.instantiated");
mcimadamore@1352 659 t = types.createErrorType(t);
mcimadamore@1352 660 }
mcimadamore@1352 661 }
mcimadamore@1352 662 return t;
mcimadamore@1352 663 }
mcimadamore@1352 664
duke@1 665 /** Check that type is a class or interface type.
duke@1 666 * @param pos Position to be used for error reporting.
duke@1 667 * @param t The type to be checked.
duke@1 668 * @param noBounds True if type bounds are illegal here.
duke@1 669 */
duke@1 670 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 671 t = checkClassType(pos, t);
duke@1 672 if (noBounds && t.isParameterized()) {
duke@1 673 List<Type> args = t.getTypeArguments();
duke@1 674 while (args.nonEmpty()) {
duke@1 675 if (args.head.tag == WILDCARD)
duke@1 676 return typeTagError(pos,
jjg@598 677 diags.fragment("type.req.exact"),
duke@1 678 args.head);
duke@1 679 args = args.tail;
duke@1 680 }
duke@1 681 }
duke@1 682 return t;
duke@1 683 }
duke@1 684
duke@1 685 /** Check that type is a reifiable class, interface or array type.
duke@1 686 * @param pos Position to be used for error reporting.
duke@1 687 * @param t The type to be checked.
duke@1 688 */
duke@1 689 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
duke@1 690 if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
duke@1 691 return typeTagError(pos,
mcimadamore@89 692 diags.fragment("type.req.class.array"),
duke@1 693 t);
duke@1 694 } else if (!types.isReifiable(t)) {
duke@1 695 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 696 return types.createErrorType(t);
duke@1 697 } else {
duke@1 698 return t;
duke@1 699 }
duke@1 700 }
duke@1 701
duke@1 702 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 703 * or a type variable.
duke@1 704 * @param pos Position to be used for error reporting.
duke@1 705 * @param t The type to be checked.
duke@1 706 */
duke@1 707 Type checkRefType(DiagnosticPosition pos, Type t) {
duke@1 708 switch (t.tag) {
duke@1 709 case CLASS:
duke@1 710 case ARRAY:
duke@1 711 case TYPEVAR:
duke@1 712 case WILDCARD:
duke@1 713 case ERROR:
duke@1 714 return t;
duke@1 715 default:
duke@1 716 return typeTagError(pos,
mcimadamore@89 717 diags.fragment("type.req.ref"),
duke@1 718 t);
duke@1 719 }
duke@1 720 }
duke@1 721
jrose@267 722 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 723 * or a type variable.
jrose@267 724 * @param trees Original trees, used for error reporting.
jrose@267 725 * @param types The types to be checked.
jrose@267 726 */
jrose@267 727 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 728 List<JCExpression> tl = trees;
jrose@267 729 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 730 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 731 tl = tl.tail;
jrose@267 732 }
jrose@267 733 return types;
jrose@267 734 }
jrose@267 735
duke@1 736 /** Check that type is a null or reference type.
duke@1 737 * @param pos Position to be used for error reporting.
duke@1 738 * @param t The type to be checked.
duke@1 739 */
duke@1 740 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
duke@1 741 switch (t.tag) {
duke@1 742 case CLASS:
duke@1 743 case ARRAY:
duke@1 744 case TYPEVAR:
duke@1 745 case WILDCARD:
duke@1 746 case BOT:
duke@1 747 case ERROR:
duke@1 748 return t;
duke@1 749 default:
duke@1 750 return typeTagError(pos,
mcimadamore@89 751 diags.fragment("type.req.ref"),
duke@1 752 t);
duke@1 753 }
duke@1 754 }
duke@1 755
duke@1 756 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 757 * Return true if it doesn't.
duke@1 758 * @param pos Position to be used for error reporting.
duke@1 759 * @param flags The set of flags to be checked.
duke@1 760 * @param set1 Conflicting flags set #1.
duke@1 761 * @param set2 Conflicting flags set #2.
duke@1 762 */
duke@1 763 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 764 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 765 log.error(pos,
duke@1 766 "illegal.combination.of.modifiers",
mcimadamore@80 767 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 768 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 769 return false;
duke@1 770 } else
duke@1 771 return true;
duke@1 772 }
duke@1 773
mcimadamore@914 774 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 775 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 776 */
mcimadamore@914 777 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 778 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 779 t.isErroneous()) {
mcimadamore@914 780 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 781 } else if (tree.def != null) {
mcimadamore@914 782 log.error(tree.clazz.pos(),
mcimadamore@914 783 "cant.apply.diamond.1",
mcimadamore@914 784 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 785 return types.createErrorType(t);
mcimadamore@948 786 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 787 log.error(tree.clazz.pos(),
mcimadamore@914 788 "cant.apply.diamond.1",
mcimadamore@914 789 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 790 return types.createErrorType(t);
mcimadamore@993 791 } else if (tree.typeargs != null &&
mcimadamore@993 792 tree.typeargs.nonEmpty()) {
mcimadamore@993 793 log.error(tree.clazz.pos(),
mcimadamore@993 794 "cant.apply.diamond.1",
mcimadamore@993 795 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 796 return types.createErrorType(t);
mcimadamore@914 797 } else {
mcimadamore@914 798 return t;
mcimadamore@537 799 }
mcimadamore@537 800 }
mcimadamore@537 801
mcimadamore@795 802 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 803 MethodSymbol m = tree.sym;
mcimadamore@795 804 if (!allowSimplifiedVarargs) return;
mcimadamore@795 805 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 806 Type varargElemType = null;
mcimadamore@580 807 if (m.isVarArgs()) {
mcimadamore@795 808 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 809 }
mcimadamore@795 810 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 811 if (varargElemType != null) {
mcimadamore@795 812 log.error(tree,
mcimadamore@795 813 "varargs.invalid.trustme.anno",
mcimadamore@795 814 syms.trustMeType.tsym,
mcimadamore@795 815 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 816 } else {
mcimadamore@795 817 log.error(tree,
mcimadamore@795 818 "varargs.invalid.trustme.anno",
mcimadamore@795 819 syms.trustMeType.tsym,
mcimadamore@795 820 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 821 }
mcimadamore@795 822 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 823 types.isReifiable(varargElemType)) {
mcimadamore@795 824 warnUnsafeVararg(tree,
mcimadamore@795 825 "varargs.redundant.trustme.anno",
mcimadamore@795 826 syms.trustMeType.tsym,
mcimadamore@795 827 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 828 }
mcimadamore@795 829 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 830 !types.isReifiable(varargElemType)) {
mcimadamore@795 831 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 832 }
mcimadamore@580 833 }
mcimadamore@795 834 //where
mcimadamore@795 835 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 836 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 837 (s.isConstructor() ||
mcimadamore@795 838 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 839 }
mcimadamore@580 840
mcimadamore@1219 841 Type checkMethod(Type owntype,
mcimadamore@1219 842 Symbol sym,
mcimadamore@1219 843 Env<AttrContext> env,
mcimadamore@1219 844 final List<JCExpression> argtrees,
mcimadamore@1219 845 List<Type> argtypes,
mcimadamore@1226 846 boolean useVarargs,
mcimadamore@1226 847 boolean unchecked) {
mcimadamore@1219 848 // System.out.println("call : " + env.tree);
mcimadamore@1219 849 // System.out.println("method : " + owntype);
mcimadamore@1219 850 // System.out.println("actuals: " + argtypes);
mcimadamore@1219 851 List<Type> formals = owntype.getParameterTypes();
mcimadamore@1219 852 Type last = useVarargs ? formals.last() : null;
mcimadamore@1219 853 if (sym.name==names.init &&
mcimadamore@1219 854 sym.owner == syms.enumSym)
mcimadamore@1219 855 formals = formals.tail.tail;
mcimadamore@1219 856 List<JCExpression> args = argtrees;
mcimadamore@1347 857 DeferredAttr.DeferredTypeMap checkDeferredMap =
mcimadamore@1347 858 deferredAttr.new DeferredTypeMap(DeferredAttr.AttrMode.CHECK, sym, env.info.pendingResolutionPhase);
mcimadamore@1352 859 if (args != null) {
mcimadamore@1352 860 //this is null when type-checking a method reference
mcimadamore@1352 861 while (formals.head != last) {
mcimadamore@1219 862 JCTree arg = args.head;
mcimadamore@1352 863 Warner warn = convertWarner(arg.pos(), arg.type, formals.head);
mcimadamore@1352 864 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 865 args = args.tail;
mcimadamore@1352 866 formals = formals.tail;
mcimadamore@1219 867 }
mcimadamore@1352 868 if (useVarargs) {
mcimadamore@1352 869 Type varArg = types.elemtype(last);
mcimadamore@1352 870 while (args.tail != null) {
mcimadamore@1352 871 JCTree arg = args.head;
mcimadamore@1352 872 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1352 873 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1352 874 args = args.tail;
mcimadamore@1352 875 }
mcimadamore@1352 876 } else if ((sym.flags() & VARARGS) != 0 && allowVarargs) {
mcimadamore@1352 877 // non-varargs call to varargs method
mcimadamore@1352 878 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1352 879 Type lastArg = checkDeferredMap.apply(argtypes.last());
mcimadamore@1352 880 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
mcimadamore@1352 881 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1352 882 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
mcimadamore@1352 883 types.elemtype(varParam), varParam);
mcimadamore@1352 884 }
mcimadamore@1219 885 }
mcimadamore@1226 886 if (unchecked) {
mcimadamore@1219 887 warnUnchecked(env.tree.pos(),
mcimadamore@1219 888 "unchecked.meth.invocation.applied",
mcimadamore@1219 889 kindName(sym),
mcimadamore@1219 890 sym.name,
mcimadamore@1219 891 rs.methodArguments(sym.type.getParameterTypes()),
mcimadamore@1347 892 rs.methodArguments(Type.map(argtypes, checkDeferredMap)),
mcimadamore@1219 893 kindName(sym.location()),
mcimadamore@1219 894 sym.location());
mcimadamore@1219 895 owntype = new MethodType(owntype.getParameterTypes(),
mcimadamore@1219 896 types.erasure(owntype.getReturnType()),
mcimadamore@1219 897 types.erasure(owntype.getThrownTypes()),
mcimadamore@1219 898 syms.methodClass);
mcimadamore@1219 899 }
mcimadamore@1219 900 if (useVarargs) {
mcimadamore@1219 901 JCTree tree = env.tree;
mcimadamore@1219 902 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 903 if (!types.isReifiable(argtype) &&
mcimadamore@1219 904 (!allowSimplifiedVarargs ||
mcimadamore@1219 905 sym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@1219 906 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 907 warnUnchecked(env.tree.pos(),
mcimadamore@1219 908 "unchecked.generic.array.creation",
mcimadamore@1219 909 argtype);
mcimadamore@1219 910 }
mcimadamore@1219 911 Type elemtype = types.elemtype(argtype);
mcimadamore@1219 912 switch (tree.getTag()) {
mcimadamore@1219 913 case APPLY:
mcimadamore@1219 914 ((JCMethodInvocation) tree).varargsElement = elemtype;
mcimadamore@1219 915 break;
mcimadamore@1219 916 case NEWCLASS:
mcimadamore@1219 917 ((JCNewClass) tree).varargsElement = elemtype;
mcimadamore@1219 918 break;
mcimadamore@1352 919 case REFERENCE:
mcimadamore@1352 920 ((JCMemberReference) tree).varargsElement = elemtype;
mcimadamore@1352 921 break;
mcimadamore@1219 922 default:
mcimadamore@1219 923 throw new AssertionError(""+tree);
mcimadamore@1219 924 }
mcimadamore@1219 925 }
mcimadamore@1219 926 return owntype;
mcimadamore@547 927 }
mcimadamore@1219 928 //where
mcimadamore@1219 929 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
mcimadamore@1219 930 if (types.isConvertible(actual, formal, warn))
mcimadamore@1219 931 return;
mcimadamore@1219 932
mcimadamore@1219 933 if (formal.isCompound()
mcimadamore@1219 934 && types.isSubtype(actual, types.supertype(formal))
mcimadamore@1219 935 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
mcimadamore@1219 936 return;
mcimadamore@1219 937 }
mcimadamore@547 938
mcimadamore@1348 939 void checkAccessibleFunctionalDescriptor(DiagnosticPosition pos, Env<AttrContext> env, Type desc) {
mcimadamore@1348 940 AccessChecker accessChecker = new AccessChecker(env);
mcimadamore@1348 941 //check args accessibility (only if implicit parameter types)
mcimadamore@1348 942 for (Type arg : desc.getParameterTypes()) {
mcimadamore@1348 943 if (!accessChecker.visit(arg)) {
mcimadamore@1348 944 log.error(pos, "cant.access.arg.type.in.functional.desc", arg);
mcimadamore@1348 945 return;
mcimadamore@1348 946 }
mcimadamore@1348 947 }
mcimadamore@1348 948 //check return type accessibility
mcimadamore@1348 949 if (!accessChecker.visit(desc.getReturnType())) {
mcimadamore@1348 950 log.error(pos, "cant.access.return.in.functional.desc", desc.getReturnType());
mcimadamore@1348 951 return;
mcimadamore@1348 952 }
mcimadamore@1348 953 //check thrown types accessibility
mcimadamore@1348 954 for (Type thrown : desc.getThrownTypes()) {
mcimadamore@1348 955 if (!accessChecker.visit(thrown)) {
mcimadamore@1348 956 log.error(pos, "cant.access.thrown.in.functional.desc", thrown);
mcimadamore@1348 957 return;
mcimadamore@1348 958 }
mcimadamore@1348 959 }
mcimadamore@1348 960 }
mcimadamore@1348 961
mcimadamore@1348 962 class AccessChecker extends Types.UnaryVisitor<Boolean> {
mcimadamore@1348 963
mcimadamore@1348 964 Env<AttrContext> env;
mcimadamore@1348 965
mcimadamore@1348 966 AccessChecker(Env<AttrContext> env) {
mcimadamore@1348 967 this.env = env;
mcimadamore@1348 968 }
mcimadamore@1348 969
mcimadamore@1348 970 Boolean visit(List<Type> ts) {
mcimadamore@1348 971 for (Type t : ts) {
mcimadamore@1348 972 if (!visit(t))
mcimadamore@1348 973 return false;
mcimadamore@1348 974 }
mcimadamore@1348 975 return true;
mcimadamore@1348 976 }
mcimadamore@1348 977
mcimadamore@1348 978 public Boolean visitType(Type t, Void s) {
mcimadamore@1348 979 return true;
mcimadamore@1348 980 }
mcimadamore@1348 981
mcimadamore@1348 982 @Override
mcimadamore@1348 983 public Boolean visitArrayType(ArrayType t, Void s) {
mcimadamore@1348 984 return visit(t.elemtype);
mcimadamore@1348 985 }
mcimadamore@1348 986
mcimadamore@1348 987 @Override
mcimadamore@1348 988 public Boolean visitClassType(ClassType t, Void s) {
mcimadamore@1348 989 return rs.isAccessible(env, t, true) &&
mcimadamore@1348 990 visit(t.getTypeArguments());
mcimadamore@1348 991 }
mcimadamore@1348 992
mcimadamore@1348 993 @Override
mcimadamore@1348 994 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@1348 995 return visit(t.type);
mcimadamore@1348 996 }
mcimadamore@1348 997 };
mcimadamore@821 998 /**
mcimadamore@821 999 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 1000 * (see JLS 4.5)
mcimadamore@821 1001 *
mcimadamore@821 1002 * @param t class type to be checked
mcimadamore@821 1003 * @return true if 't' is well-formed
mcimadamore@821 1004 */
mcimadamore@821 1005 public boolean checkValidGenericType(Type t) {
mcimadamore@821 1006 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 1007 }
mcimadamore@821 1008 //WHERE
mcimadamore@821 1009 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 1010 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 1011 List<Type> actuals = type.allparams();
mcimadamore@821 1012 List<Type> args = type.getTypeArguments();
mcimadamore@821 1013 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 1014 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 1015
mcimadamore@821 1016 // For matching pairs of actual argument types `a' and
mcimadamore@821 1017 // formal type parameters with declared bound `b' ...
mcimadamore@821 1018 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 1019 // exact type arguments needs to know their
mcimadamore@821 1020 // bounds (for upper and lower bound
mcimadamore@1216 1021 // calculations). So we create new bounds where
mcimadamore@1216 1022 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 1023 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 1024 args = args.tail;
mcimadamore@821 1025 forms = forms.tail;
mcimadamore@821 1026 }
mcimadamore@821 1027
mcimadamore@821 1028 args = type.getTypeArguments();
mcimadamore@821 1029 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 1030 formals,
mcimadamore@821 1031 types.capture(type).allparams());
mcimadamore@821 1032 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 1033 // Let the actual arguments know their bound
mcimadamore@821 1034 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 1035 args = args.tail;
mcimadamore@821 1036 tvars_cap = tvars_cap.tail;
mcimadamore@821 1037 }
mcimadamore@821 1038
mcimadamore@821 1039 args = type.getTypeArguments();
mcimadamore@1216 1040 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 1041
mcimadamore@1216 1042 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 1043 Type actual = args.head;
mcimadamore@854 1044 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 1045 !bounds.head.isErroneous() &&
mcimadamore@1216 1046 !checkExtends(actual, bounds.head)) {
mcimadamore@821 1047 return args.head;
mcimadamore@821 1048 }
mcimadamore@821 1049 args = args.tail;
mcimadamore@1216 1050 bounds = bounds.tail;
mcimadamore@821 1051 }
mcimadamore@821 1052
mcimadamore@821 1053 args = type.getTypeArguments();
mcimadamore@1216 1054 bounds = bounds_buf.toList();
mcimadamore@821 1055
mcimadamore@821 1056 for (Type arg : types.capture(type).getTypeArguments()) {
mcimadamore@828 1057 if (arg.tag == TYPEVAR &&
mcimadamore@828 1058 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 1059 !bounds.head.isErroneous() &&
mcimadamore@854 1060 !isTypeArgErroneous(args.head)) {
mcimadamore@821 1061 return args.head;
mcimadamore@821 1062 }
mcimadamore@1216 1063 bounds = bounds.tail;
mcimadamore@854 1064 args = args.tail;
mcimadamore@821 1065 }
mcimadamore@821 1066
mcimadamore@821 1067 return null;
mcimadamore@821 1068 }
mcimadamore@854 1069 //where
mcimadamore@854 1070 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 1071 return isTypeArgErroneous.visit(t);
mcimadamore@854 1072 }
mcimadamore@854 1073
mcimadamore@854 1074 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 1075 public Boolean visitType(Type t, Void s) {
mcimadamore@854 1076 return t.isErroneous();
mcimadamore@854 1077 }
mcimadamore@854 1078 @Override
mcimadamore@854 1079 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 1080 return visit(t.getUpperBound());
mcimadamore@854 1081 }
mcimadamore@854 1082 @Override
mcimadamore@854 1083 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 1084 return visit(t.getUpperBound()) ||
mcimadamore@854 1085 visit(t.getLowerBound());
mcimadamore@854 1086 }
mcimadamore@854 1087 @Override
mcimadamore@854 1088 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1089 return visit(t.type);
mcimadamore@854 1090 }
mcimadamore@854 1091 };
mcimadamore@821 1092
duke@1 1093 /** Check that given modifiers are legal for given symbol and
duke@1 1094 * return modifiers together with any implicit modififiers for that symbol.
duke@1 1095 * Warning: we can't use flags() here since this method
duke@1 1096 * is called during class enter, when flags() would cause a premature
duke@1 1097 * completion.
duke@1 1098 * @param pos Position to be used for error reporting.
duke@1 1099 * @param flags The set of modifiers given in a definition.
duke@1 1100 * @param sym The defined symbol.
duke@1 1101 */
duke@1 1102 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1103 long mask;
duke@1 1104 long implicit = 0;
duke@1 1105 switch (sym.kind) {
duke@1 1106 case VAR:
duke@1 1107 if (sym.owner.kind != TYP)
duke@1 1108 mask = LocalVarFlags;
duke@1 1109 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1110 mask = implicit = InterfaceVarFlags;
duke@1 1111 else
duke@1 1112 mask = VarFlags;
duke@1 1113 break;
duke@1 1114 case MTH:
duke@1 1115 if (sym.name == names.init) {
duke@1 1116 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1117 // enum constructors cannot be declared public or
duke@1 1118 // protected and must be implicitly or explicitly
duke@1 1119 // private
duke@1 1120 implicit = PRIVATE;
duke@1 1121 mask = PRIVATE;
duke@1 1122 } else
duke@1 1123 mask = ConstructorFlags;
duke@1 1124 } else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1125 mask = implicit = InterfaceMethodFlags;
duke@1 1126 else {
duke@1 1127 mask = MethodFlags;
duke@1 1128 }
duke@1 1129 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1130 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 1131 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1132 break;
duke@1 1133 case TYP:
duke@1 1134 if (sym.isLocal()) {
duke@1 1135 mask = LocalClassFlags;
jjg@113 1136 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1137 // Anonymous classes in static methods are themselves static;
duke@1 1138 // that's why we admit STATIC here.
duke@1 1139 mask |= STATIC;
duke@1 1140 // JLS: Anonymous classes are final.
duke@1 1141 implicit |= FINAL;
duke@1 1142 }
duke@1 1143 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1144 (flags & ENUM) != 0)
duke@1 1145 log.error(pos, "enums.must.be.static");
duke@1 1146 } else if (sym.owner.kind == TYP) {
duke@1 1147 mask = MemberClassFlags;
duke@1 1148 if (sym.owner.owner.kind == PCK ||
duke@1 1149 (sym.owner.flags_field & STATIC) != 0)
duke@1 1150 mask |= STATIC;
duke@1 1151 else if ((flags & ENUM) != 0)
duke@1 1152 log.error(pos, "enums.must.be.static");
duke@1 1153 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1154 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1155 } else {
duke@1 1156 mask = ClassFlags;
duke@1 1157 }
duke@1 1158 // Interfaces are always ABSTRACT
duke@1 1159 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1160
duke@1 1161 if ((flags & ENUM) != 0) {
duke@1 1162 // enums can't be declared abstract or final
duke@1 1163 mask &= ~(ABSTRACT | FINAL);
duke@1 1164 implicit |= implicitEnumFinalFlag(tree);
duke@1 1165 }
duke@1 1166 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1167 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1168 break;
duke@1 1169 default:
duke@1 1170 throw new AssertionError();
duke@1 1171 }
duke@1 1172 long illegal = flags & StandardFlags & ~mask;
duke@1 1173 if (illegal != 0) {
duke@1 1174 if ((illegal & INTERFACE) != 0) {
duke@1 1175 log.error(pos, "intf.not.allowed.here");
duke@1 1176 mask |= INTERFACE;
duke@1 1177 }
duke@1 1178 else {
duke@1 1179 log.error(pos,
mcimadamore@80 1180 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1181 }
duke@1 1182 }
duke@1 1183 else if ((sym.kind == TYP ||
duke@1 1184 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1185 // in the presence of inner classes. Should it be deleted here?
duke@1 1186 checkDisjoint(pos, flags,
duke@1 1187 ABSTRACT,
duke@1 1188 PRIVATE | STATIC))
duke@1 1189 &&
duke@1 1190 checkDisjoint(pos, flags,
duke@1 1191 ABSTRACT | INTERFACE,
duke@1 1192 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1193 &&
duke@1 1194 checkDisjoint(pos, flags,
duke@1 1195 PUBLIC,
duke@1 1196 PRIVATE | PROTECTED)
duke@1 1197 &&
duke@1 1198 checkDisjoint(pos, flags,
duke@1 1199 PRIVATE,
duke@1 1200 PUBLIC | PROTECTED)
duke@1 1201 &&
duke@1 1202 checkDisjoint(pos, flags,
duke@1 1203 FINAL,
duke@1 1204 VOLATILE)
duke@1 1205 &&
duke@1 1206 (sym.kind == TYP ||
duke@1 1207 checkDisjoint(pos, flags,
duke@1 1208 ABSTRACT | NATIVE,
duke@1 1209 STRICTFP))) {
duke@1 1210 // skip
duke@1 1211 }
duke@1 1212 return flags & (mask | ~StandardFlags) | implicit;
duke@1 1213 }
duke@1 1214
duke@1 1215
duke@1 1216 /** Determine if this enum should be implicitly final.
duke@1 1217 *
duke@1 1218 * If the enum has no specialized enum contants, it is final.
duke@1 1219 *
duke@1 1220 * If the enum does have specialized enum contants, it is
duke@1 1221 * <i>not</i> final.
duke@1 1222 */
duke@1 1223 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1224 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1225 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1226 boolean specialized;
duke@1 1227 SpecialTreeVisitor() {
duke@1 1228 this.specialized = false;
duke@1 1229 };
duke@1 1230
jjg@398 1231 @Override
duke@1 1232 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1233
jjg@398 1234 @Override
duke@1 1235 public void visitVarDef(JCVariableDecl tree) {
duke@1 1236 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1237 if (tree.init instanceof JCNewClass &&
duke@1 1238 ((JCNewClass) tree.init).def != null) {
duke@1 1239 specialized = true;
duke@1 1240 }
duke@1 1241 }
duke@1 1242 }
duke@1 1243 }
duke@1 1244
duke@1 1245 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1246 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1247 for (JCTree defs: cdef.defs) {
duke@1 1248 defs.accept(sts);
duke@1 1249 if (sts.specialized) return 0;
duke@1 1250 }
duke@1 1251 return FINAL;
duke@1 1252 }
duke@1 1253
duke@1 1254 /* *************************************************************************
duke@1 1255 * Type Validation
duke@1 1256 **************************************************************************/
duke@1 1257
duke@1 1258 /** Validate a type expression. That is,
duke@1 1259 * check that all type arguments of a parametric type are within
duke@1 1260 * their bounds. This must be done in a second phase after type attributon
duke@1 1261 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1262 *
jjg@1358 1263 * <pre>{@code
duke@1 1264 * class B<A extends C> { ... }
duke@1 1265 * class C extends B<C> { ... }
jjg@1358 1266 * }</pre>
duke@1 1267 *
duke@1 1268 * and we can't make sure that the bound is already attributed because
duke@1 1269 * of possible cycles.
mcimadamore@638 1270 *
mcimadamore@638 1271 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1272 * and reporting any completion failures.
duke@1 1273 */
mcimadamore@122 1274 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1275 validate(tree, env, true);
duke@1 1276 }
mcimadamore@638 1277 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1278 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1279 }
duke@1 1280
duke@1 1281 /** Visitor method: Validate a list of type expressions.
duke@1 1282 */
mcimadamore@122 1283 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1284 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1285 validate(l.head, env);
duke@1 1286 }
duke@1 1287
duke@1 1288 /** A visitor class for type validation.
duke@1 1289 */
duke@1 1290 class Validator extends JCTree.Visitor {
duke@1 1291
mcimadamore@638 1292 boolean isOuter;
mcimadamore@638 1293 Env<AttrContext> env;
mcimadamore@638 1294
mcimadamore@638 1295 Validator(Env<AttrContext> env) {
mcimadamore@638 1296 this.env = env;
mcimadamore@638 1297 }
mcimadamore@638 1298
jjg@398 1299 @Override
duke@1 1300 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1301 tree.elemtype.accept(this);
duke@1 1302 }
duke@1 1303
jjg@398 1304 @Override
duke@1 1305 public void visitTypeApply(JCTypeApply tree) {
duke@1 1306 if (tree.type.tag == CLASS) {
duke@1 1307 List<JCExpression> args = tree.arguments;
mcimadamore@158 1308 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1309
mcimadamore@821 1310 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1311 if (incompatibleArg != null) {
mcimadamore@821 1312 for (JCTree arg : tree.arguments) {
mcimadamore@821 1313 if (arg.type == incompatibleArg) {
mcimadamore@829 1314 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1315 }
mcimadamore@829 1316 forms = forms.tail;
mcimadamore@829 1317 }
mcimadamore@829 1318 }
mcimadamore@829 1319
mcimadamore@829 1320 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1321
mcimadamore@638 1322 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1323
duke@1 1324 // For matching pairs of actual argument types `a' and
duke@1 1325 // formal type parameters with declared bound `b' ...
duke@1 1326 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1327 validateTree(args.head,
mcimadamore@638 1328 !(isOuter && is_java_lang_Class),
mcimadamore@638 1329 false);
duke@1 1330 args = args.tail;
duke@1 1331 forms = forms.tail;
duke@1 1332 }
duke@1 1333
duke@1 1334 // Check that this type is either fully parameterized, or
duke@1 1335 // not parameterized at all.
duke@1 1336 if (tree.type.getEnclosingType().isRaw())
duke@1 1337 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1338 if (tree.clazz.hasTag(SELECT))
duke@1 1339 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1340 }
duke@1 1341 }
duke@1 1342
jjg@398 1343 @Override
duke@1 1344 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1345 validateTrees(tree.bounds, true, isOuter);
duke@1 1346 checkClassBounds(tree.pos(), tree.type);
duke@1 1347 }
duke@1 1348
duke@1 1349 @Override
duke@1 1350 public void visitWildcard(JCWildcard tree) {
duke@1 1351 if (tree.inner != null)
mcimadamore@638 1352 validateTree(tree.inner, true, isOuter);
duke@1 1353 }
duke@1 1354
jjg@398 1355 @Override
duke@1 1356 public void visitSelect(JCFieldAccess tree) {
duke@1 1357 if (tree.type.tag == CLASS) {
duke@1 1358 visitSelectInternal(tree);
duke@1 1359
duke@1 1360 // Check that this type is either fully parameterized, or
duke@1 1361 // not parameterized at all.
duke@1 1362 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1363 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1364 }
duke@1 1365 }
mcimadamore@852 1366
duke@1 1367 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1368 if (tree.type.tsym.isStatic() &&
duke@1 1369 tree.selected.type.isParameterized()) {
duke@1 1370 // The enclosing type is not a class, so we are
duke@1 1371 // looking at a static member type. However, the
duke@1 1372 // qualifying expression is parameterized.
duke@1 1373 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1374 } else {
duke@1 1375 // otherwise validate the rest of the expression
mcimadamore@122 1376 tree.selected.accept(this);
duke@1 1377 }
duke@1 1378 }
duke@1 1379
duke@1 1380 /** Default visitor method: do nothing.
duke@1 1381 */
jjg@398 1382 @Override
duke@1 1383 public void visitTree(JCTree tree) {
duke@1 1384 }
mcimadamore@122 1385
mcimadamore@638 1386 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1387 try {
mcimadamore@638 1388 if (tree != null) {
mcimadamore@638 1389 this.isOuter = isOuter;
mcimadamore@638 1390 tree.accept(this);
mcimadamore@638 1391 if (checkRaw)
mcimadamore@638 1392 checkRaw(tree, env);
mcimadamore@638 1393 }
mcimadamore@638 1394 } catch (CompletionFailure ex) {
mcimadamore@638 1395 completionError(tree.pos(), ex);
mcimadamore@638 1396 }
mcimadamore@638 1397 }
mcimadamore@638 1398
mcimadamore@638 1399 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1400 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1401 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1402 }
mcimadamore@638 1403
mcimadamore@638 1404 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1405 if (lint.isEnabled(LintCategory.RAW) &&
mcimadamore@638 1406 tree.type.tag == CLASS &&
mcimadamore@638 1407 !TreeInfo.isDiamond(tree) &&
mcimadamore@1103 1408 !withinAnonConstr(env) &&
mcimadamore@638 1409 tree.type.isRaw()) {
mcimadamore@795 1410 log.warning(LintCategory.RAW,
mcimadamore@638 1411 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1412 }
mcimadamore@638 1413 }
mcimadamore@1103 1414
mcimadamore@1103 1415 boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1416 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1417 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1418 }
duke@1 1419 }
duke@1 1420
duke@1 1421 /* *************************************************************************
duke@1 1422 * Exception checking
duke@1 1423 **************************************************************************/
duke@1 1424
duke@1 1425 /* The following methods treat classes as sets that contain
duke@1 1426 * the class itself and all their subclasses
duke@1 1427 */
duke@1 1428
duke@1 1429 /** Is given type a subtype of some of the types in given list?
duke@1 1430 */
duke@1 1431 boolean subset(Type t, List<Type> ts) {
duke@1 1432 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1433 if (types.isSubtype(t, l.head)) return true;
duke@1 1434 return false;
duke@1 1435 }
duke@1 1436
duke@1 1437 /** Is given type a subtype or supertype of
duke@1 1438 * some of the types in given list?
duke@1 1439 */
duke@1 1440 boolean intersects(Type t, List<Type> ts) {
duke@1 1441 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1442 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1443 return false;
duke@1 1444 }
duke@1 1445
duke@1 1446 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1447 * in the list.
duke@1 1448 */
duke@1 1449 List<Type> incl(Type t, List<Type> ts) {
duke@1 1450 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1451 }
duke@1 1452
duke@1 1453 /** Remove type set from type set list.
duke@1 1454 */
duke@1 1455 List<Type> excl(Type t, List<Type> ts) {
duke@1 1456 if (ts.isEmpty()) {
duke@1 1457 return ts;
duke@1 1458 } else {
duke@1 1459 List<Type> ts1 = excl(t, ts.tail);
duke@1 1460 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1461 else if (ts1 == ts.tail) return ts;
duke@1 1462 else return ts1.prepend(ts.head);
duke@1 1463 }
duke@1 1464 }
duke@1 1465
duke@1 1466 /** Form the union of two type set lists.
duke@1 1467 */
duke@1 1468 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1469 List<Type> ts = ts1;
duke@1 1470 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1471 ts = incl(l.head, ts);
duke@1 1472 return ts;
duke@1 1473 }
duke@1 1474
duke@1 1475 /** Form the difference of two type lists.
duke@1 1476 */
duke@1 1477 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1478 List<Type> ts = ts1;
duke@1 1479 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1480 ts = excl(l.head, ts);
duke@1 1481 return ts;
duke@1 1482 }
duke@1 1483
duke@1 1484 /** Form the intersection of two type lists.
duke@1 1485 */
duke@1 1486 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1487 List<Type> ts = List.nil();
duke@1 1488 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1489 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1490 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1491 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1492 return ts;
duke@1 1493 }
duke@1 1494
duke@1 1495 /** Is exc an exception symbol that need not be declared?
duke@1 1496 */
duke@1 1497 boolean isUnchecked(ClassSymbol exc) {
duke@1 1498 return
duke@1 1499 exc.kind == ERR ||
duke@1 1500 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1501 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1502 }
duke@1 1503
duke@1 1504 /** Is exc an exception type that need not be declared?
duke@1 1505 */
duke@1 1506 boolean isUnchecked(Type exc) {
duke@1 1507 return
duke@1 1508 (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
duke@1 1509 (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
duke@1 1510 exc.tag == BOT;
duke@1 1511 }
duke@1 1512
duke@1 1513 /** Same, but handling completion failures.
duke@1 1514 */
duke@1 1515 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1516 try {
duke@1 1517 return isUnchecked(exc);
duke@1 1518 } catch (CompletionFailure ex) {
duke@1 1519 completionError(pos, ex);
duke@1 1520 return true;
duke@1 1521 }
duke@1 1522 }
duke@1 1523
duke@1 1524 /** Is exc handled by given exception list?
duke@1 1525 */
duke@1 1526 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1527 return isUnchecked(exc) || subset(exc, handled);
duke@1 1528 }
duke@1 1529
duke@1 1530 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1531 * @param thrown The list of thrown exceptions.
duke@1 1532 * @param handled The list of handled exceptions.
duke@1 1533 */
mcimadamore@362 1534 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1535 List<Type> unhandled = List.nil();
duke@1 1536 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1537 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1538 return unhandled;
duke@1 1539 }
duke@1 1540
duke@1 1541 /* *************************************************************************
duke@1 1542 * Overriding/Implementation checking
duke@1 1543 **************************************************************************/
duke@1 1544
duke@1 1545 /** The level of access protection given by a flag set,
duke@1 1546 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1547 */
duke@1 1548 static int protection(long flags) {
duke@1 1549 switch ((short)(flags & AccessFlags)) {
duke@1 1550 case PRIVATE: return 3;
duke@1 1551 case PROTECTED: return 1;
duke@1 1552 default:
duke@1 1553 case PUBLIC: return 0;
duke@1 1554 case 0: return 2;
duke@1 1555 }
duke@1 1556 }
duke@1 1557
duke@1 1558 /** A customized "cannot override" error message.
duke@1 1559 * @param m The overriding method.
duke@1 1560 * @param other The overridden method.
duke@1 1561 * @return An internationalized string.
duke@1 1562 */
mcimadamore@89 1563 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1564 String key;
duke@1 1565 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1566 key = "cant.override";
duke@1 1567 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1568 key = "cant.implement";
duke@1 1569 else
duke@1 1570 key = "clashes.with";
mcimadamore@89 1571 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1572 }
duke@1 1573
duke@1 1574 /** A customized "override" warning message.
duke@1 1575 * @param m The overriding method.
duke@1 1576 * @param other The overridden method.
duke@1 1577 * @return An internationalized string.
duke@1 1578 */
mcimadamore@89 1579 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1580 String key;
duke@1 1581 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1582 key = "unchecked.override";
duke@1 1583 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1584 key = "unchecked.implement";
duke@1 1585 else
duke@1 1586 key = "unchecked.clash.with";
mcimadamore@89 1587 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1588 }
duke@1 1589
duke@1 1590 /** A customized "override" warning message.
duke@1 1591 * @param m The overriding method.
duke@1 1592 * @param other The overridden method.
duke@1 1593 * @return An internationalized string.
duke@1 1594 */
mcimadamore@89 1595 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1596 String key;
duke@1 1597 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1598 key = "varargs.override";
duke@1 1599 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1600 key = "varargs.implement";
duke@1 1601 else
duke@1 1602 key = "varargs.clash.with";
mcimadamore@89 1603 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1604 }
duke@1 1605
duke@1 1606 /** Check that this method conforms with overridden method 'other'.
duke@1 1607 * where `origin' is the class where checking started.
duke@1 1608 * Complications:
duke@1 1609 * (1) Do not check overriding of synthetic methods
duke@1 1610 * (reason: they might be final).
duke@1 1611 * todo: check whether this is still necessary.
duke@1 1612 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1613 * than the method it implements. Augment the proxy methods with the
duke@1 1614 * undeclared exceptions in this case.
duke@1 1615 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1616 * has a result type
duke@1 1617 * extended by the result type of the method it implements.
duke@1 1618 * Change the proxies result type to the smaller type in this case.
duke@1 1619 *
duke@1 1620 * @param tree The tree from which positions
duke@1 1621 * are extracted for errors.
duke@1 1622 * @param m The overriding method.
duke@1 1623 * @param other The overridden method.
duke@1 1624 * @param origin The class of which the overriding method
duke@1 1625 * is a member.
duke@1 1626 */
duke@1 1627 void checkOverride(JCTree tree,
duke@1 1628 MethodSymbol m,
duke@1 1629 MethodSymbol other,
duke@1 1630 ClassSymbol origin) {
duke@1 1631 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1632 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1633 return;
duke@1 1634 }
duke@1 1635
duke@1 1636 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1637 if ((m.flags() & STATIC) != 0 &&
duke@1 1638 (other.flags() & STATIC) == 0) {
duke@1 1639 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1640 cannotOverride(m, other));
duke@1 1641 return;
duke@1 1642 }
duke@1 1643
duke@1 1644 // Error if instance method overrides static or final
duke@1 1645 // method (JLS 8.4.6.1).
duke@1 1646 if ((other.flags() & FINAL) != 0 ||
duke@1 1647 (m.flags() & STATIC) == 0 &&
duke@1 1648 (other.flags() & STATIC) != 0) {
duke@1 1649 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1650 cannotOverride(m, other),
mcimadamore@80 1651 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1652 return;
duke@1 1653 }
duke@1 1654
duke@1 1655 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1656 // handled in validateAnnotationMethod
duke@1 1657 return;
duke@1 1658 }
duke@1 1659
duke@1 1660 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1661 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1662 protection(m.flags()) > protection(other.flags())) {
duke@1 1663 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1664 cannotOverride(m, other),
mcimadamore@80 1665 other.flags() == 0 ?
mcimadamore@80 1666 Flag.PACKAGE :
mcimadamore@80 1667 asFlagSet(other.flags() & AccessFlags));
duke@1 1668 return;
duke@1 1669 }
duke@1 1670
duke@1 1671 Type mt = types.memberType(origin.type, m);
duke@1 1672 Type ot = types.memberType(origin.type, other);
duke@1 1673 // Error if overriding result type is different
duke@1 1674 // (or, in the case of generics mode, not a subtype) of
duke@1 1675 // overridden result type. We have to rename any type parameters
duke@1 1676 // before comparing types.
duke@1 1677 List<Type> mtvars = mt.getTypeArguments();
duke@1 1678 List<Type> otvars = ot.getTypeArguments();
duke@1 1679 Type mtres = mt.getReturnType();
duke@1 1680 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1681
mcimadamore@795 1682 overrideWarner.clear();
duke@1 1683 boolean resultTypesOK =
tbell@202 1684 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1685 if (!resultTypesOK) {
jjg@398 1686 if (!allowCovariantReturns &&
duke@1 1687 m.owner != origin &&
duke@1 1688 m.owner.isSubClass(other.owner, types)) {
duke@1 1689 // allow limited interoperability with covariant returns
duke@1 1690 } else {
mcimadamore@362 1691 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1692 "override.incompatible.ret",
mcimadamore@362 1693 cannotOverride(m, other),
duke@1 1694 mtres, otres);
duke@1 1695 return;
duke@1 1696 }
mcimadamore@795 1697 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1698 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1699 "override.unchecked.ret",
mcimadamore@362 1700 uncheckedOverrides(m, other),
mcimadamore@362 1701 mtres, otres);
duke@1 1702 }
duke@1 1703
duke@1 1704 // Error if overriding method throws an exception not reported
duke@1 1705 // by overridden method.
duke@1 1706 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1707 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1708 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1709 if (unhandledErased.nonEmpty()) {
duke@1 1710 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1711 "override.meth.doesnt.throw",
duke@1 1712 cannotOverride(m, other),
mcimadamore@362 1713 unhandledUnerased.head);
mcimadamore@362 1714 return;
mcimadamore@362 1715 }
mcimadamore@362 1716 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1717 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1718 "override.unchecked.thrown",
mcimadamore@362 1719 cannotOverride(m, other),
mcimadamore@362 1720 unhandledUnerased.head);
duke@1 1721 return;
duke@1 1722 }
duke@1 1723
duke@1 1724 // Optional warning if varargs don't agree
duke@1 1725 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1726 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1727 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1728 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1729 ? "override.varargs.missing"
duke@1 1730 : "override.varargs.extra",
duke@1 1731 varargsOverrides(m, other));
duke@1 1732 }
duke@1 1733
duke@1 1734 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1735 if ((other.flags() & BRIDGE) != 0) {
duke@1 1736 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1737 uncheckedOverrides(m, other));
duke@1 1738 }
duke@1 1739
duke@1 1740 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1741 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1742 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1743 }
duke@1 1744 }
duke@1 1745 // where
duke@1 1746 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1747 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1748 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1749 // because in that case, we will rediscover the issue when examining the method
duke@1 1750 // in the supertype.
duke@1 1751 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1752 // address the issue is when the method is the supertype implemementation: any other
duke@1 1753 // case, we will have dealt with when examining the supertype classes
duke@1 1754 ClassSymbol mc = m.enclClass();
duke@1 1755 Type st = types.supertype(origin.type);
duke@1 1756 if (st.tag != CLASS)
duke@1 1757 return true;
duke@1 1758 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1759
duke@1 1760 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1761 List<Type> intfs = types.interfaces(origin.type);
duke@1 1762 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1763 }
duke@1 1764 else
duke@1 1765 return (stimpl != m);
duke@1 1766 }
duke@1 1767
duke@1 1768
duke@1 1769 // used to check if there were any unchecked conversions
duke@1 1770 Warner overrideWarner = new Warner();
duke@1 1771
duke@1 1772 /** Check that a class does not inherit two concrete methods
duke@1 1773 * with the same signature.
duke@1 1774 * @param pos Position to be used for error reporting.
duke@1 1775 * @param site The class type to be checked.
duke@1 1776 */
duke@1 1777 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1778 Type sup = types.supertype(site);
duke@1 1779 if (sup.tag != CLASS) return;
duke@1 1780
duke@1 1781 for (Type t1 = sup;
duke@1 1782 t1.tsym.type.isParameterized();
duke@1 1783 t1 = types.supertype(t1)) {
duke@1 1784 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1785 e1 != null;
duke@1 1786 e1 = e1.sibling) {
duke@1 1787 Symbol s1 = e1.sym;
duke@1 1788 if (s1.kind != MTH ||
duke@1 1789 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1790 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1791 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1792 types,
duke@1 1793 true) != s1)
duke@1 1794 continue;
duke@1 1795 Type st1 = types.memberType(t1, s1);
duke@1 1796 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1797 if (st1 == s1.type) continue;
duke@1 1798
duke@1 1799 for (Type t2 = sup;
duke@1 1800 t2.tag == CLASS;
duke@1 1801 t2 = types.supertype(t2)) {
mcimadamore@24 1802 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1803 e2.scope != null;
duke@1 1804 e2 = e2.next()) {
duke@1 1805 Symbol s2 = e2.sym;
duke@1 1806 if (s2 == s1 ||
duke@1 1807 s2.kind != MTH ||
duke@1 1808 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1809 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1810 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1811 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1812 types,
duke@1 1813 true) != s2)
duke@1 1814 continue;
duke@1 1815 Type st2 = types.memberType(t2, s2);
duke@1 1816 if (types.overrideEquivalent(st1, st2))
duke@1 1817 log.error(pos, "concrete.inheritance.conflict",
duke@1 1818 s1, t1, s2, t2, sup);
duke@1 1819 }
duke@1 1820 }
duke@1 1821 }
duke@1 1822 }
duke@1 1823 }
duke@1 1824
duke@1 1825 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1826 * method with same name and arguments but incompatible return types.
duke@1 1827 * @param pos Position to be used for error reporting.
duke@1 1828 * @param t1 The first argument type.
duke@1 1829 * @param t2 The second argument type.
duke@1 1830 */
duke@1 1831 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1832 Type t1,
duke@1 1833 Type t2) {
duke@1 1834 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1835 types.makeCompoundType(t1, t2));
duke@1 1836 }
duke@1 1837
duke@1 1838 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1839 Type t1,
duke@1 1840 Type t2,
duke@1 1841 Type site) {
mcimadamore@746 1842 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1843 }
duke@1 1844
duke@1 1845 /** Return the first method which is defined with same args
duke@1 1846 * but different return types in two given interfaces, or null if none
duke@1 1847 * exists.
duke@1 1848 * @param t1 The first type.
duke@1 1849 * @param t2 The second type.
duke@1 1850 * @param site The most derived type.
duke@1 1851 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1852 */
mcimadamore@746 1853 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1854 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1855 closure(t1, interfaces1);
duke@1 1856 Map<TypeSymbol,Type> interfaces2;
duke@1 1857 if (t1 == t2)
duke@1 1858 interfaces2 = interfaces1;
duke@1 1859 else
duke@1 1860 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1861
duke@1 1862 for (Type t3 : interfaces1.values()) {
duke@1 1863 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1864 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1865 if (s != null) return s;
duke@1 1866 }
duke@1 1867 }
duke@1 1868 return null;
duke@1 1869 }
duke@1 1870
duke@1 1871 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1872 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
duke@1 1873 if (t.tag != CLASS) return;
duke@1 1874 if (typeMap.put(t.tsym, t) == null) {
duke@1 1875 closure(types.supertype(t), typeMap);
duke@1 1876 for (Type i : types.interfaces(t))
duke@1 1877 closure(i, typeMap);
duke@1 1878 }
duke@1 1879 }
duke@1 1880
duke@1 1881 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1882 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
duke@1 1883 if (t.tag != CLASS) return;
duke@1 1884 if (typesSkip.get(t.tsym) != null) return;
duke@1 1885 if (typeMap.put(t.tsym, t) == null) {
duke@1 1886 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1887 for (Type i : types.interfaces(t))
duke@1 1888 closure(i, typesSkip, typeMap);
duke@1 1889 }
duke@1 1890 }
duke@1 1891
duke@1 1892 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1893 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1894 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1895 Symbol s1 = e1.sym;
duke@1 1896 Type st1 = null;
duke@1 1897 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
duke@1 1898 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1899 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1900 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1901 Symbol s2 = e2.sym;
duke@1 1902 if (s1 == s2) continue;
duke@1 1903 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
duke@1 1904 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1905 Type st2 = types.memberType(t2, s2);
duke@1 1906 if (types.overrideEquivalent(st1, st2)) {
duke@1 1907 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1908 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1909 Type rt1 = st1.getReturnType();
duke@1 1910 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1911 boolean compat =
duke@1 1912 types.isSameType(rt1, rt2) ||
duke@1 1913 rt1.tag >= CLASS && rt2.tag >= CLASS &&
duke@1 1914 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
mcimadamore@59 1915 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
mcimadamore@59 1916 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1917 if (!compat) {
mcimadamore@746 1918 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1919 t1, t2, s2.name +
mcimadamore@746 1920 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1921 return s2;
mcimadamore@746 1922 }
mcimadamore@889 1923 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1924 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1925 log.error(pos,
mcimadamore@746 1926 "name.clash.same.erasure.no.override",
mcimadamore@746 1927 s1, s1.location(),
mcimadamore@746 1928 s2, s2.location());
mcimadamore@746 1929 return s2;
duke@1 1930 }
duke@1 1931 }
duke@1 1932 }
duke@1 1933 return null;
duke@1 1934 }
mcimadamore@59 1935 //WHERE
mcimadamore@59 1936 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1937 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1938 Type st1 = types.memberType(site, s1);
mcimadamore@59 1939 Type st2 = types.memberType(site, s2);
mcimadamore@59 1940 closure(site, supertypes);
mcimadamore@59 1941 for (Type t : supertypes.values()) {
mcimadamore@59 1942 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1943 Symbol s3 = e.sym;
mcimadamore@59 1944 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1945 Type st3 = types.memberType(site,s3);
mcimadamore@59 1946 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1947 if (s3.owner == site.tsym) {
mcimadamore@59 1948 return true;
mcimadamore@59 1949 }
mcimadamore@59 1950 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1951 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1952 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1953 Type rt1 = st1.getReturnType();
mcimadamore@59 1954 Type rt2 = st2.getReturnType();
mcimadamore@59 1955 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1956 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1957 boolean compat =
mcimadamore@59 1958 rt13.tag >= CLASS && rt23.tag >= CLASS &&
mcimadamore@59 1959 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
mcimadamore@59 1960 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
mcimadamore@59 1961 if (compat)
mcimadamore@59 1962 return true;
mcimadamore@59 1963 }
mcimadamore@59 1964 }
mcimadamore@59 1965 }
mcimadamore@59 1966 return false;
mcimadamore@59 1967 }
duke@1 1968
duke@1 1969 /** Check that a given method conforms with any method it overrides.
duke@1 1970 * @param tree The tree from which positions are extracted
duke@1 1971 * for errors.
duke@1 1972 * @param m The overriding method.
duke@1 1973 */
duke@1 1974 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1975 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1976 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1977 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1978 log.error(tree.pos(), "enum.no.finalize");
duke@1 1979 return;
duke@1 1980 }
mcimadamore@746 1981 for (Type t = origin.type; t.tag == CLASS;
duke@1 1982 t = types.supertype(t)) {
mcimadamore@746 1983 if (t != origin.type) {
mcimadamore@746 1984 checkOverride(tree, t, origin, m);
mcimadamore@746 1985 }
mcimadamore@746 1986 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1987 checkOverride(tree, t2, origin, m);
duke@1 1988 }
duke@1 1989 }
duke@1 1990 }
duke@1 1991
mcimadamore@746 1992 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1993 TypeSymbol c = site.tsym;
mcimadamore@746 1994 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1995 while (e.scope != null) {
mcimadamore@746 1996 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1997 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1998 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1999 }
mcimadamore@746 2000 }
mcimadamore@746 2001 e = e.next();
mcimadamore@746 2002 }
mcimadamore@746 2003 }
mcimadamore@746 2004
mcimadamore@746 2005 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 2006 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 2007 return (cf.accepts(s1) &&
mcimadamore@858 2008 cf.accepts(s2) &&
mcimadamore@858 2009 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 2010 }
mcimadamore@746 2011
mcimadamore@746 2012
duke@1 2013 /** Check that all abstract members of given class have definitions.
duke@1 2014 * @param pos Position to be used for error reporting.
duke@1 2015 * @param c The class.
duke@1 2016 */
duke@1 2017 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2018 try {
duke@1 2019 MethodSymbol undef = firstUndef(c, c);
duke@1 2020 if (undef != null) {
duke@1 2021 if ((c.flags() & ENUM) != 0 &&
duke@1 2022 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 2023 (c.flags() & FINAL) == 0) {
duke@1 2024 // add the ABSTRACT flag to an enum
duke@1 2025 c.flags_field |= ABSTRACT;
duke@1 2026 } else {
duke@1 2027 MethodSymbol undef1 =
duke@1 2028 new MethodSymbol(undef.flags(), undef.name,
duke@1 2029 types.memberType(c.type, undef), undef.owner);
duke@1 2030 log.error(pos, "does.not.override.abstract",
duke@1 2031 c, undef1, undef1.location());
duke@1 2032 }
duke@1 2033 }
duke@1 2034 } catch (CompletionFailure ex) {
duke@1 2035 completionError(pos, ex);
duke@1 2036 }
duke@1 2037 }
duke@1 2038 //where
duke@1 2039 /** Return first abstract member of class `c' that is not defined
duke@1 2040 * in `impl', null if there is none.
duke@1 2041 */
duke@1 2042 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 2043 MethodSymbol undef = null;
duke@1 2044 // Do not bother to search in classes that are not abstract,
duke@1 2045 // since they cannot have abstract members.
duke@1 2046 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 2047 Scope s = c.members();
duke@1 2048 for (Scope.Entry e = s.elems;
duke@1 2049 undef == null && e != null;
duke@1 2050 e = e.sibling) {
duke@1 2051 if (e.sym.kind == MTH &&
duke@1 2052 (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
duke@1 2053 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2054 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
duke@1 2055 if (implmeth == null || implmeth == absmeth)
duke@1 2056 undef = absmeth;
duke@1 2057 }
duke@1 2058 }
duke@1 2059 if (undef == null) {
duke@1 2060 Type st = types.supertype(c.type);
duke@1 2061 if (st.tag == CLASS)
duke@1 2062 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 2063 }
duke@1 2064 for (List<Type> l = types.interfaces(c.type);
duke@1 2065 undef == null && l.nonEmpty();
duke@1 2066 l = l.tail) {
duke@1 2067 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 2068 }
duke@1 2069 }
duke@1 2070 return undef;
duke@1 2071 }
duke@1 2072
mcimadamore@690 2073 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 2074 CycleChecker cc = new CycleChecker();
mcimadamore@690 2075 cc.scan(tree);
mcimadamore@690 2076 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 2077 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 2078 }
mcimadamore@690 2079 }
mcimadamore@690 2080
mcimadamore@690 2081 class CycleChecker extends TreeScanner {
mcimadamore@690 2082
mcimadamore@690 2083 List<Symbol> seenClasses = List.nil();
mcimadamore@690 2084 boolean errorFound = false;
mcimadamore@690 2085 boolean partialCheck = false;
mcimadamore@690 2086
mcimadamore@690 2087 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 2088 if (sym != null && sym.kind == TYP) {
mcimadamore@690 2089 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 2090 if (classEnv != null) {
mcimadamore@690 2091 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2092 try {
mcimadamore@690 2093 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2094 scan(classEnv.tree);
mcimadamore@690 2095 }
mcimadamore@690 2096 finally {
mcimadamore@690 2097 log.useSource(prevSource.getFile());
mcimadamore@690 2098 }
mcimadamore@690 2099 } else if (sym.kind == TYP) {
mcimadamore@690 2100 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2101 }
mcimadamore@690 2102 } else {
mcimadamore@690 2103 //not completed yet
mcimadamore@690 2104 partialCheck = true;
mcimadamore@690 2105 }
mcimadamore@690 2106 }
mcimadamore@690 2107
mcimadamore@690 2108 @Override
mcimadamore@690 2109 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2110 super.visitSelect(tree);
mcimadamore@690 2111 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2112 }
mcimadamore@690 2113
mcimadamore@690 2114 @Override
mcimadamore@690 2115 public void visitIdent(JCIdent tree) {
mcimadamore@690 2116 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2117 }
mcimadamore@690 2118
mcimadamore@690 2119 @Override
mcimadamore@690 2120 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2121 scan(tree.clazz);
mcimadamore@690 2122 }
mcimadamore@690 2123
mcimadamore@690 2124 @Override
mcimadamore@690 2125 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2126 scan(tree.elemtype);
mcimadamore@690 2127 }
mcimadamore@690 2128
mcimadamore@690 2129 @Override
mcimadamore@690 2130 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2131 List<JCTree> supertypes = List.nil();
mcimadamore@690 2132 if (tree.getExtendsClause() != null) {
mcimadamore@690 2133 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2134 }
mcimadamore@690 2135 if (tree.getImplementsClause() != null) {
mcimadamore@690 2136 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2137 supertypes = supertypes.prepend(intf);
mcimadamore@690 2138 }
mcimadamore@690 2139 }
mcimadamore@690 2140 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2141 }
mcimadamore@690 2142
mcimadamore@690 2143 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2144 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2145 return;
mcimadamore@690 2146 if (seenClasses.contains(c)) {
mcimadamore@690 2147 errorFound = true;
mcimadamore@690 2148 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2149 } else if (!c.type.isErroneous()) {
mcimadamore@690 2150 try {
mcimadamore@690 2151 seenClasses = seenClasses.prepend(c);
mcimadamore@690 2152 if (c.type.tag == CLASS) {
mcimadamore@690 2153 if (supertypes.nonEmpty()) {
mcimadamore@690 2154 scan(supertypes);
mcimadamore@690 2155 }
mcimadamore@690 2156 else {
mcimadamore@690 2157 ClassType ct = (ClassType)c.type;
mcimadamore@690 2158 if (ct.supertype_field == null ||
mcimadamore@690 2159 ct.interfaces_field == null) {
mcimadamore@690 2160 //not completed yet
mcimadamore@690 2161 partialCheck = true;
mcimadamore@690 2162 return;
mcimadamore@690 2163 }
mcimadamore@690 2164 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2165 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2166 checkSymbol(pos, intf.tsym);
mcimadamore@690 2167 }
mcimadamore@690 2168 }
mcimadamore@690 2169 if (c.owner.kind == TYP) {
mcimadamore@690 2170 checkSymbol(pos, c.owner);
mcimadamore@690 2171 }
mcimadamore@690 2172 }
mcimadamore@690 2173 } finally {
mcimadamore@690 2174 seenClasses = seenClasses.tail;
mcimadamore@690 2175 }
mcimadamore@690 2176 }
mcimadamore@690 2177 }
mcimadamore@690 2178 }
mcimadamore@690 2179
duke@1 2180 /** Check for cyclic references. Issue an error if the
duke@1 2181 * symbol of the type referred to has a LOCKED flag set.
duke@1 2182 *
duke@1 2183 * @param pos Position to be used for error reporting.
duke@1 2184 * @param t The type referred to.
duke@1 2185 */
duke@1 2186 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2187 checkNonCyclicInternal(pos, t);
duke@1 2188 }
duke@1 2189
duke@1 2190
duke@1 2191 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2192 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2193 }
duke@1 2194
mcimadamore@236 2195 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2196 final TypeVar tv;
mcimadamore@42 2197 if (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2198 return;
duke@1 2199 if (seen.contains(t)) {
duke@1 2200 tv = (TypeVar)t;
jjg@110 2201 tv.bound = types.createErrorType(t);
duke@1 2202 log.error(pos, "cyclic.inheritance", t);
duke@1 2203 } else if (t.tag == TYPEVAR) {
duke@1 2204 tv = (TypeVar)t;
mcimadamore@236 2205 seen = seen.prepend(tv);
duke@1 2206 for (Type b : types.getBounds(tv))
duke@1 2207 checkNonCyclic1(pos, b, seen);
duke@1 2208 }
duke@1 2209 }
duke@1 2210
duke@1 2211 /** Check for cyclic references. Issue an error if the
duke@1 2212 * symbol of the type referred to has a LOCKED flag set.
duke@1 2213 *
duke@1 2214 * @param pos Position to be used for error reporting.
duke@1 2215 * @param t The type referred to.
duke@1 2216 * @returns True if the check completed on all attributed classes
duke@1 2217 */
duke@1 2218 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2219 boolean complete = true; // was the check complete?
duke@1 2220 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2221 Symbol c = t.tsym;
duke@1 2222 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2223
duke@1 2224 if ((c.flags_field & LOCKED) != 0) {
duke@1 2225 noteCyclic(pos, (ClassSymbol)c);
duke@1 2226 } else if (!c.type.isErroneous()) {
duke@1 2227 try {
duke@1 2228 c.flags_field |= LOCKED;
duke@1 2229 if (c.type.tag == CLASS) {
duke@1 2230 ClassType clazz = (ClassType)c.type;
duke@1 2231 if (clazz.interfaces_field != null)
duke@1 2232 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2233 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2234 if (clazz.supertype_field != null) {
duke@1 2235 Type st = clazz.supertype_field;
duke@1 2236 if (st != null && st.tag == CLASS)
duke@1 2237 complete &= checkNonCyclicInternal(pos, st);
duke@1 2238 }
duke@1 2239 if (c.owner.kind == TYP)
duke@1 2240 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2241 }
duke@1 2242 } finally {
duke@1 2243 c.flags_field &= ~LOCKED;
duke@1 2244 }
duke@1 2245 }
duke@1 2246 if (complete)
duke@1 2247 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2248 if (complete) c.flags_field |= ACYCLIC;
duke@1 2249 return complete;
duke@1 2250 }
duke@1 2251
duke@1 2252 /** Note that we found an inheritance cycle. */
duke@1 2253 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2254 log.error(pos, "cyclic.inheritance", c);
duke@1 2255 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2256 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2257 Type st = types.supertype(c.type);
duke@1 2258 if (st.tag == CLASS)
jjg@110 2259 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2260 c.type = types.createErrorType(c, c.type);
duke@1 2261 c.flags_field |= ACYCLIC;
duke@1 2262 }
duke@1 2263
duke@1 2264 /** Check that all methods which implement some
duke@1 2265 * method conform to the method they implement.
duke@1 2266 * @param tree The class definition whose members are checked.
duke@1 2267 */
duke@1 2268 void checkImplementations(JCClassDecl tree) {
duke@1 2269 checkImplementations(tree, tree.sym);
duke@1 2270 }
duke@1 2271 //where
duke@1 2272 /** Check that all methods which implement some
duke@1 2273 * method in `ic' conform to the method they implement.
duke@1 2274 */
duke@1 2275 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
duke@1 2276 ClassSymbol origin = tree.sym;
duke@1 2277 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2278 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2279 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2280 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2281 if (e.sym.kind == MTH &&
duke@1 2282 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2283 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2284 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2285 if (implmeth != null && implmeth != absmeth &&
duke@1 2286 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2287 (origin.flags() & INTERFACE)) {
duke@1 2288 // don't check if implmeth is in a class, yet
duke@1 2289 // origin is an interface. This case arises only
duke@1 2290 // if implmeth is declared in Object. The reason is
duke@1 2291 // that interfaces really don't inherit from
duke@1 2292 // Object it's just that the compiler represents
duke@1 2293 // things that way.
duke@1 2294 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2295 }
duke@1 2296 }
duke@1 2297 }
duke@1 2298 }
duke@1 2299 }
duke@1 2300 }
duke@1 2301
duke@1 2302 /** Check that all abstract methods implemented by a class are
duke@1 2303 * mutually compatible.
duke@1 2304 * @param pos Position to be used for error reporting.
duke@1 2305 * @param c The class whose interfaces are checked.
duke@1 2306 */
duke@1 2307 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2308 List<Type> supertypes = types.interfaces(c);
duke@1 2309 Type supertype = types.supertype(c);
duke@1 2310 if (supertype.tag == CLASS &&
duke@1 2311 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2312 supertypes = supertypes.prepend(supertype);
duke@1 2313 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2314 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2315 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2316 return;
duke@1 2317 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2318 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2319 return;
duke@1 2320 }
duke@1 2321 checkCompatibleConcretes(pos, c);
duke@1 2322 }
duke@1 2323
mcimadamore@359 2324 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2325 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2326 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2327 // VM allows methods and variables with differing types
mcimadamore@359 2328 if (sym.kind == e.sym.kind &&
mcimadamore@359 2329 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2330 sym != e.sym &&
mcimadamore@359 2331 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2332 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2333 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2334 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2335 return;
mcimadamore@359 2336 }
mcimadamore@359 2337 }
mcimadamore@359 2338 }
mcimadamore@359 2339 }
mcimadamore@359 2340
mcimadamore@780 2341 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2342 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2343 *
mcimadamore@780 2344 * @param pos Position to be used for error reporting.
mcimadamore@780 2345 * @param site The class whose methods are checked.
mcimadamore@780 2346 * @param sym The method symbol to be checked.
mcimadamore@780 2347 */
mcimadamore@858 2348 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2349 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2350 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2351 //by method 'sym' in 'site'...
mcimadamore@1198 2352 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2353 if (!sym.overrides(m1, site.tsym, types, false)) continue;
mcimadamore@1198 2354 //...check each method m2 that is a member of 'site'
mcimadamore@1198 2355 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2356 if (m2 == m1) continue;
mcimadamore@858 2357 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2358 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1198 2359 if (!types.isSubSignature(sym.type, types.memberType(site, m2), false) &&
mcimadamore@1198 2360 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2361 sym.flags_field |= CLASH;
mcimadamore@1198 2362 String key = m1 == sym ?
mcimadamore@858 2363 "name.clash.same.erasure.no.override" :
mcimadamore@858 2364 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2365 log.error(pos,
mcimadamore@858 2366 key,
mcimadamore@858 2367 sym, sym.location(),
mcimadamore@1198 2368 m2, m2.location(),
mcimadamore@1198 2369 m1, m1.location());
mcimadamore@858 2370 return;
mcimadamore@858 2371 }
mcimadamore@780 2372 }
mcimadamore@780 2373 }
mcimadamore@780 2374 }
mcimadamore@780 2375
mcimadamore@877 2376
mcimadamore@877 2377
mcimadamore@858 2378 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2379 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2380 *
mcimadamore@858 2381 * @param pos Position to be used for error reporting.
mcimadamore@858 2382 * @param site The class whose methods are checked.
mcimadamore@858 2383 * @param sym The method symbol to be checked.
mcimadamore@780 2384 */
mcimadamore@858 2385 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2386 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2387 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2388 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2389 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2390 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@907 2391 if (!types.isSubSignature(sym.type, types.memberType(site, s), false) &&
mcimadamore@877 2392 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2393 log.error(pos,
mcimadamore@858 2394 "name.clash.same.erasure.no.hide",
mcimadamore@858 2395 sym, sym.location(),
mcimadamore@877 2396 s, s.location());
mcimadamore@858 2397 return;
mcimadamore@858 2398 }
mcimadamore@858 2399 }
mcimadamore@858 2400 }
mcimadamore@780 2401
mcimadamore@858 2402 //where
mcimadamore@858 2403 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2404
mcimadamore@858 2405 Type site;
mcimadamore@780 2406
mcimadamore@858 2407 ClashFilter(Type site) {
mcimadamore@858 2408 this.site = site;
mcimadamore@858 2409 }
mcimadamore@858 2410
mcimadamore@858 2411 boolean shouldSkip(Symbol s) {
mcimadamore@858 2412 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2413 s.owner == site.tsym;
mcimadamore@858 2414 }
mcimadamore@858 2415
mcimadamore@858 2416 public boolean accepts(Symbol s) {
mcimadamore@858 2417 return s.kind == MTH &&
mcimadamore@858 2418 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2419 !shouldSkip(s) &&
mcimadamore@858 2420 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2421 !s.isConstructor();
mcimadamore@858 2422 }
mcimadamore@858 2423 }
mcimadamore@780 2424
mcimadamore@359 2425 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2426 */
mcimadamore@359 2427 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2428 if (!sym.type.isErroneous()) {
mcimadamore@359 2429 if (warnOnSyntheticConflicts) {
mcimadamore@359 2430 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2431 }
mcimadamore@359 2432 else {
mcimadamore@359 2433 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2434 }
mcimadamore@359 2435 }
mcimadamore@359 2436 }
mcimadamore@359 2437
duke@1 2438 /** Check that class c does not implement directly or indirectly
duke@1 2439 * the same parameterized interface with two different argument lists.
duke@1 2440 * @param pos Position to be used for error reporting.
duke@1 2441 * @param type The type whose interfaces are checked.
duke@1 2442 */
duke@1 2443 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2444 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2445 }
duke@1 2446 //where
duke@1 2447 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2448 * with their class symbol as key and their type as value. Make
duke@1 2449 * sure no class is entered with two different types.
duke@1 2450 */
duke@1 2451 void checkClassBounds(DiagnosticPosition pos,
duke@1 2452 Map<TypeSymbol,Type> seensofar,
duke@1 2453 Type type) {
duke@1 2454 if (type.isErroneous()) return;
duke@1 2455 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2456 Type it = l.head;
duke@1 2457 Type oldit = seensofar.put(it.tsym, it);
duke@1 2458 if (oldit != null) {
duke@1 2459 List<Type> oldparams = oldit.allparams();
duke@1 2460 List<Type> newparams = it.allparams();
duke@1 2461 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2462 log.error(pos, "cant.inherit.diff.arg",
duke@1 2463 it.tsym, Type.toString(oldparams),
duke@1 2464 Type.toString(newparams));
duke@1 2465 }
duke@1 2466 checkClassBounds(pos, seensofar, it);
duke@1 2467 }
duke@1 2468 Type st = types.supertype(type);
duke@1 2469 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2470 }
duke@1 2471
duke@1 2472 /** Enter interface into into set.
duke@1 2473 * If it existed already, issue a "repeated interface" error.
duke@1 2474 */
duke@1 2475 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2476 if (its.contains(it))
duke@1 2477 log.error(pos, "repeated.interface");
duke@1 2478 else {
duke@1 2479 its.add(it);
duke@1 2480 }
duke@1 2481 }
duke@1 2482
duke@1 2483 /* *************************************************************************
duke@1 2484 * Check annotations
duke@1 2485 **************************************************************************/
duke@1 2486
mcimadamore@629 2487 /**
mcimadamore@634 2488 * Recursively validate annotations values
mcimadamore@629 2489 */
mcimadamore@634 2490 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2491 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2492 @Override
mcimadamore@629 2493 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2494 if (!tree.type.isErroneous()) {
jjg@1017 2495 super.visitAnnotation(tree);
jjg@1017 2496 validateAnnotation(tree);
jjg@1017 2497 }
mcimadamore@629 2498 }
mcimadamore@629 2499 }
mcimadamore@634 2500 tree.accept(new AnnotationValidator());
mcimadamore@629 2501 }
mcimadamore@629 2502
jjg@1326 2503 /**
jjg@1326 2504 * {@literal
jjg@1326 2505 * Annotation types are restricted to primitives, String, an
duke@1 2506 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2507 * Anything>, arrays of the preceding.
jjg@1326 2508 * }
duke@1 2509 */
duke@1 2510 void validateAnnotationType(JCTree restype) {
duke@1 2511 // restype may be null if an error occurred, so don't bother validating it
duke@1 2512 if (restype != null) {
duke@1 2513 validateAnnotationType(restype.pos(), restype.type);
duke@1 2514 }
duke@1 2515 }
duke@1 2516
duke@1 2517 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2518 if (type.isPrimitive()) return;
duke@1 2519 if (types.isSameType(type, syms.stringType)) return;
duke@1 2520 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2521 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2522 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2523 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2524 validateAnnotationType(pos, types.elemtype(type));
duke@1 2525 return;
duke@1 2526 }
duke@1 2527 log.error(pos, "invalid.annotation.member.type");
duke@1 2528 }
duke@1 2529
duke@1 2530 /**
duke@1 2531 * "It is also a compile-time error if any method declared in an
duke@1 2532 * annotation type has a signature that is override-equivalent to
duke@1 2533 * that of any public or protected method declared in class Object
duke@1 2534 * or in the interface annotation.Annotation."
duke@1 2535 *
jjh@972 2536 * @jls 9.6 Annotation Types
duke@1 2537 */
duke@1 2538 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
duke@1 2539 for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
duke@1 2540 Scope s = sup.tsym.members();
duke@1 2541 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2542 if (e.sym.kind == MTH &&
duke@1 2543 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2544 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2545 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2546 }
duke@1 2547 }
duke@1 2548 }
duke@1 2549
duke@1 2550 /** Check the annotations of a symbol.
duke@1 2551 */
duke@1 2552 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2553 for (JCAnnotation a : annotations)
duke@1 2554 validateAnnotation(a, s);
duke@1 2555 }
duke@1 2556
duke@1 2557 /** Check an annotation of a symbol.
duke@1 2558 */
jfranck@1313 2559 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2560 validateAnnotationTree(a);
duke@1 2561
duke@1 2562 if (!annotationApplicable(a, s))
duke@1 2563 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2564
duke@1 2565 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2566 if (!isOverrider(s))
duke@1 2567 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2568 }
duke@1 2569 }
duke@1 2570
jfranck@1313 2571 /**
jfranck@1313 2572 * Validate the proposed container 'containedBy' on the
jfranck@1313 2573 * annotation type symbol 's'. Report errors at position
jfranck@1313 2574 * 'pos'.
jfranck@1313 2575 *
jfranck@1313 2576 * @param s The (annotation)type declaration annotated with a @ContainedBy
jjg@1358 2577 * @param containedBy the @ContainedBy on 's'
jfranck@1313 2578 * @param pos where to report errors
jfranck@1313 2579 */
jfranck@1313 2580 public void validateContainedBy(TypeSymbol s, Attribute.Compound containedBy, DiagnosticPosition pos) {
jfranck@1313 2581 Assert.check(types.isSameType(containedBy.type, syms.containedByType));
jfranck@1313 2582
jfranck@1313 2583 Type t = null;
jfranck@1313 2584 List<Pair<MethodSymbol,Attribute>> l = containedBy.values;
jfranck@1313 2585 if (!l.isEmpty()) {
jfranck@1313 2586 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2587 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2588 }
jfranck@1313 2589
jfranck@1313 2590 if (t == null) {
jfranck@1313 2591 log.error(pos, "invalid.container.wrong.containedby", s, containedBy);
jfranck@1313 2592 return;
jfranck@1313 2593 }
jfranck@1313 2594
jfranck@1313 2595 validateHasContainerFor(t.tsym, s, pos);
jfranck@1313 2596 validateRetention(t.tsym, s, pos);
jfranck@1313 2597 validateDocumented(t.tsym, s, pos);
jfranck@1313 2598 validateInherited(t.tsym, s, pos);
jfranck@1313 2599 validateTarget(t.tsym, s, pos);
jfranck@1344 2600 validateDefault(t.tsym, s, pos);
jfranck@1313 2601 }
jfranck@1313 2602
jfranck@1313 2603 /**
jfranck@1313 2604 * Validate the proposed container 'containerFor' on the
jfranck@1313 2605 * annotation type symbol 's'. Report errors at position
jfranck@1313 2606 * 'pos'.
jfranck@1313 2607 *
jfranck@1313 2608 * @param s The (annotation)type declaration annotated with a @ContainerFor
jfranck@1313 2609 * @param containerFor the @ContainedFor on 's'
jfranck@1313 2610 * @param pos where to report errors
jfranck@1313 2611 */
jfranck@1313 2612 public void validateContainerFor(TypeSymbol s, Attribute.Compound containerFor, DiagnosticPosition pos) {
jfranck@1313 2613 Assert.check(types.isSameType(containerFor.type, syms.containerForType));
jfranck@1313 2614
jfranck@1313 2615 Type t = null;
jfranck@1313 2616 List<Pair<MethodSymbol,Attribute>> l = containerFor.values;
jfranck@1313 2617 if (!l.isEmpty()) {
jfranck@1313 2618 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2619 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2620 }
jfranck@1313 2621
jfranck@1313 2622 if (t == null) {
jfranck@1313 2623 log.error(pos, "invalid.container.wrong.containerfor", s, containerFor);
jfranck@1313 2624 return;
jfranck@1313 2625 }
jfranck@1313 2626
jfranck@1313 2627 validateHasContainedBy(t.tsym, s, pos);
jfranck@1313 2628 }
jfranck@1313 2629
jfranck@1313 2630 private void validateHasContainedBy(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jfranck@1313 2631 Attribute.Compound containedBy = container.attribute(syms.containedByType.tsym);
jfranck@1313 2632
jfranck@1313 2633 if (containedBy == null) {
jfranck@1313 2634 log.error(pos, "invalid.container.no.containedby", container, syms.containedByType.tsym);
jfranck@1313 2635 return;
jfranck@1313 2636 }
jfranck@1313 2637
jfranck@1313 2638 Type t = null;
jfranck@1313 2639 List<Pair<MethodSymbol,Attribute>> l = containedBy.values;
jfranck@1313 2640 if (!l.isEmpty()) {
jfranck@1313 2641 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2642 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2643 }
jfranck@1313 2644
jfranck@1313 2645 if (t == null) {
jfranck@1313 2646 log.error(pos, "invalid.container.wrong.containedby", container, contained);
jfranck@1313 2647 return;
jfranck@1313 2648 }
jfranck@1313 2649
jfranck@1313 2650 if (!types.isSameType(t, contained.type))
jfranck@1313 2651 log.error(pos, "invalid.container.wrong.containedby", t.tsym, contained);
jfranck@1313 2652 }
jfranck@1313 2653
jfranck@1313 2654 private void validateHasContainerFor(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jfranck@1313 2655 Attribute.Compound containerFor = container.attribute(syms.containerForType.tsym);
jfranck@1313 2656
jfranck@1313 2657 if (containerFor == null) {
jfranck@1313 2658 log.error(pos, "invalid.container.no.containerfor", container, syms.containerForType.tsym);
jfranck@1313 2659 return;
jfranck@1313 2660 }
jfranck@1313 2661
jfranck@1313 2662 Type t = null;
jfranck@1313 2663 List<Pair<MethodSymbol,Attribute>> l = containerFor.values;
jfranck@1313 2664 if (!l.isEmpty()) {
jfranck@1313 2665 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2666 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2667 }
jfranck@1313 2668
jfranck@1313 2669 if (t == null) {
jfranck@1313 2670 log.error(pos, "invalid.container.wrong.containerfor", container, contained);
jfranck@1313 2671 return;
jfranck@1313 2672 }
jfranck@1313 2673
jfranck@1313 2674 if (!types.isSameType(t, contained.type))
jfranck@1313 2675 log.error(pos, "invalid.container.wrong.containerfor", t.tsym, contained);
jfranck@1313 2676 }
jfranck@1313 2677
jfranck@1313 2678 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2679 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2680 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2681
jfranck@1313 2682 boolean error = false;
jfranck@1313 2683 switch (containedRetention) {
jfranck@1313 2684 case RUNTIME:
jfranck@1313 2685 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2686 error = true;
jfranck@1313 2687 }
jfranck@1313 2688 break;
jfranck@1313 2689 case CLASS:
jfranck@1313 2690 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2691 error = true;
jfranck@1313 2692 }
jfranck@1313 2693 }
jfranck@1313 2694 if (error ) {
jfranck@1313 2695 log.error(pos, "invalid.containedby.annotation.retention",
jfranck@1313 2696 container, containerRetention,
jfranck@1313 2697 contained, containedRetention);
jfranck@1313 2698 }
jfranck@1313 2699 }
jfranck@1313 2700
jfranck@1313 2701 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2702 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2703 if (container.attribute(syms.documentedType.tsym) == null) {
jfranck@1313 2704 log.error(pos, "invalid.containedby.annotation.not.documented", container, contained);
jfranck@1313 2705 }
jfranck@1313 2706 }
jfranck@1313 2707 }
jfranck@1313 2708
jfranck@1313 2709 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2710 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2711 if (container.attribute(syms.inheritedType.tsym) == null) {
jfranck@1313 2712 log.error(pos, "invalid.containedby.annotation.not.inherited", container, contained);
jfranck@1313 2713 }
jfranck@1313 2714 }
jfranck@1313 2715 }
jfranck@1313 2716
jfranck@1313 2717 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2718 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1313 2719
jfranck@1313 2720 // If contained has no Target, we are done
jfranck@1313 2721 if (containedTarget == null) {
jfranck@1313 2722 return;
jfranck@1313 2723 }
jfranck@1313 2724
jfranck@1313 2725 // If contained has Target m1, container must have a Target
jfranck@1313 2726 // annotation, m2, and m2 must be a subset of m1. (This is
jfranck@1313 2727 // trivially true if contained has no target as per above).
jfranck@1313 2728
jfranck@1313 2729 // contained has target, but container has not, error
jfranck@1313 2730 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2731 if (containerTarget == null) {
jfranck@1313 2732 log.error(pos, "invalid.containedby.annotation.incompatible.target", container, contained);
jfranck@1313 2733 return;
jfranck@1313 2734 }
jfranck@1313 2735
jfranck@1313 2736 Set<Name> containerTargets = new HashSet<Name>();
jfranck@1313 2737 for (Attribute app : containerTarget.values) {
jfranck@1313 2738 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2739 continue; // recovery
jfranck@1313 2740 }
jfranck@1313 2741 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2742 containerTargets.add(e.value.name);
jfranck@1313 2743 }
jfranck@1313 2744
jfranck@1313 2745 Set<Name> containedTargets = new HashSet<Name>();
jfranck@1313 2746 for (Attribute app : containedTarget.values) {
jfranck@1313 2747 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2748 continue; // recovery
jfranck@1313 2749 }
jfranck@1313 2750 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2751 containedTargets.add(e.value.name);
jfranck@1313 2752 }
jfranck@1313 2753
jfranck@1313 2754 if (!isTargetSubset(containedTargets, containerTargets)) {
jfranck@1313 2755 log.error(pos, "invalid.containedby.annotation.incompatible.target", container, contained);
jfranck@1313 2756 }
jfranck@1313 2757 }
jfranck@1313 2758
jfranck@1313 2759 /** Checks that t is a subset of s, with respect to ElementType
jfranck@1313 2760 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE}
jfranck@1313 2761 */
jfranck@1313 2762 private boolean isTargetSubset(Set<Name> s, Set<Name> t) {
jfranck@1313 2763 // Check that all elements in t are present in s
jfranck@1313 2764 for (Name n2 : t) {
jfranck@1313 2765 boolean currentElementOk = false;
jfranck@1313 2766 for (Name n1 : s) {
jfranck@1313 2767 if (n1 == n2) {
jfranck@1313 2768 currentElementOk = true;
jfranck@1313 2769 break;
jfranck@1313 2770 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2771 currentElementOk = true;
jfranck@1313 2772 break;
jfranck@1313 2773 }
jfranck@1313 2774 }
jfranck@1313 2775 if (!currentElementOk)
jfranck@1313 2776 return false;
jfranck@1313 2777 }
jfranck@1313 2778 return true;
jfranck@1313 2779 }
jfranck@1313 2780
jfranck@1344 2781 private void validateDefault(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1344 2782 // validate that all other elements of containing type has defaults
jfranck@1344 2783 Scope scope = container.members();
jfranck@1344 2784 for(Symbol elm : scope.getElements()) {
jfranck@1344 2785 if (elm.name != names.value &&
jfranck@1344 2786 elm.kind == Kinds.MTH &&
jfranck@1344 2787 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2788 log.error(pos,
jfranck@1344 2789 "invalid.containedby.annotation.elem.nondefault",
jfranck@1344 2790 container,
jfranck@1344 2791 elm);
jfranck@1344 2792 }
jfranck@1344 2793 }
jfranck@1344 2794 }
jfranck@1344 2795
duke@1 2796 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2797 boolean isOverrider(Symbol s) {
duke@1 2798 if (s.kind != MTH || s.isStatic())
duke@1 2799 return false;
duke@1 2800 MethodSymbol m = (MethodSymbol)s;
duke@1 2801 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2802 for (Type sup : types.closure(owner.type)) {
duke@1 2803 if (sup == owner.type)
duke@1 2804 continue; // skip "this"
duke@1 2805 Scope scope = sup.tsym.members();
duke@1 2806 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2807 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2808 return true;
duke@1 2809 }
duke@1 2810 }
duke@1 2811 return false;
duke@1 2812 }
duke@1 2813
duke@1 2814 /** Is the annotation applicable to the symbol? */
duke@1 2815 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 2816 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jfranck@1313 2817 if (arr == null) {
jfranck@1313 2818 return true;
jfranck@1313 2819 }
duke@1 2820 for (Attribute app : arr.values) {
duke@1 2821 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2822 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2823 if (e.value.name == names.TYPE)
duke@1 2824 { if (s.kind == TYP) return true; }
duke@1 2825 else if (e.value.name == names.FIELD)
duke@1 2826 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2827 else if (e.value.name == names.METHOD)
duke@1 2828 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2829 else if (e.value.name == names.PARAMETER)
duke@1 2830 { if (s.kind == VAR &&
duke@1 2831 s.owner.kind == MTH &&
duke@1 2832 (s.flags() & PARAMETER) != 0)
duke@1 2833 return true;
duke@1 2834 }
duke@1 2835 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2836 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2837 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2838 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2839 (s.flags() & PARAMETER) == 0)
duke@1 2840 return true;
duke@1 2841 }
duke@1 2842 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2843 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2844 return true;
duke@1 2845 }
duke@1 2846 else if (e.value.name == names.PACKAGE)
duke@1 2847 { if (s.kind == PCK) return true; }
jjg@308 2848 else if (e.value.name == names.TYPE_USE)
jjg@308 2849 { if (s.kind == TYP ||
jjg@308 2850 s.kind == VAR ||
jjg@308 2851 (s.kind == MTH && !s.isConstructor() &&
jjg@308 2852 s.type.getReturnType().tag != VOID))
jjg@308 2853 return true;
jjg@308 2854 }
duke@1 2855 else
duke@1 2856 return true; // recovery
duke@1 2857 }
duke@1 2858 return false;
duke@1 2859 }
duke@1 2860
jfranck@1313 2861
jfranck@1313 2862 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 2863 Attribute.Compound atTarget =
jfranck@1313 2864 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 2865 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 2866 Attribute atValue = atTarget.member(names.value);
jfranck@1313 2867 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 2868 return (Attribute.Array) atValue;
jfranck@1313 2869 }
jfranck@1313 2870
duke@1 2871 /** Check an annotation value.
duke@1 2872 */
duke@1 2873 public void validateAnnotation(JCAnnotation a) {
mcimadamore@632 2874 // collect an inventory of the members (sorted alphabetically)
mcimadamore@632 2875 Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
mcimadamore@632 2876 public int compare(Symbol t, Symbol t1) {
mcimadamore@632 2877 return t.name.compareTo(t1.name);
mcimadamore@632 2878 }
mcimadamore@632 2879 });
duke@1 2880 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2881 e != null;
duke@1 2882 e = e.sibling)
duke@1 2883 if (e.sym.kind == MTH)
duke@1 2884 members.add((MethodSymbol) e.sym);
duke@1 2885
duke@1 2886 // count them off as they're annotated
duke@1 2887 for (JCTree arg : a.args) {
jjg@1127 2888 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 2889 JCAssign assign = (JCAssign) arg;
duke@1 2890 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2891 if (m == null || m.type.isErroneous()) continue;
duke@1 2892 if (!members.remove(m))
jjg@479 2893 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2894 m.name, a.type);
duke@1 2895 }
duke@1 2896
duke@1 2897 // all the remaining ones better have default values
mcimadamore@632 2898 ListBuffer<Name> missingDefaults = ListBuffer.lb();
mcimadamore@632 2899 for (MethodSymbol m : members) {
mcimadamore@632 2900 if (m.defaultValue == null && !m.type.isErroneous()) {
mcimadamore@632 2901 missingDefaults.append(m.name);
mcimadamore@632 2902 }
mcimadamore@632 2903 }
mcimadamore@632 2904 if (missingDefaults.nonEmpty()) {
mcimadamore@632 2905 String key = (missingDefaults.size() > 1)
mcimadamore@632 2906 ? "annotation.missing.default.value.1"
mcimadamore@632 2907 : "annotation.missing.default.value";
mcimadamore@632 2908 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 2909 }
duke@1 2910
duke@1 2911 // special case: java.lang.annotation.Target must not have
duke@1 2912 // repeated values in its value member
duke@1 2913 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2914 a.args.tail == null)
duke@1 2915 return;
duke@1 2916
jjg@1127 2917 if (!a.args.head.hasTag(ASSIGN)) return; // error recovery
duke@1 2918 JCAssign assign = (JCAssign) a.args.head;
duke@1 2919 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2920 if (m.name != names.value) return;
duke@1 2921 JCTree rhs = assign.rhs;
jjg@1127 2922 if (!rhs.hasTag(NEWARRAY)) return;
duke@1 2923 JCNewArray na = (JCNewArray) rhs;
duke@1 2924 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2925 for (JCTree elem : na.elems) {
duke@1 2926 if (!targets.add(TreeInfo.symbol(elem))) {
duke@1 2927 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2928 }
duke@1 2929 }
duke@1 2930 }
duke@1 2931
duke@1 2932 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 2933 if (allowAnnotations &&
mcimadamore@795 2934 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 2935 (s.flags() & DEPRECATED) != 0 &&
duke@1 2936 !syms.deprecatedType.isErroneous() &&
duke@1 2937 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 2938 log.warning(LintCategory.DEP_ANN,
jjg@612 2939 pos, "missing.deprecated.annotation");
duke@1 2940 }
duke@1 2941 }
duke@1 2942
mcimadamore@852 2943 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 2944 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 2945 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 2946 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 2947 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2948 @Override
mcimadamore@852 2949 public void report() {
mcimadamore@852 2950 warnDeprecated(pos, s);
mcimadamore@852 2951 }
mcimadamore@852 2952 });
jjg@1157 2953 }
mcimadamore@852 2954 }
mcimadamore@852 2955
mcimadamore@852 2956 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 2957 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 2958 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2959 public void report() {
mcimadamore@852 2960 if (enableSunApiLintControl)
mcimadamore@852 2961 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 2962 else
mcimadamore@1218 2963 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 2964 }
mcimadamore@852 2965 });
mcimadamore@852 2966 }
mcimadamore@852 2967 }
mcimadamore@852 2968
duke@1 2969 /* *************************************************************************
duke@1 2970 * Check for recursive annotation elements.
duke@1 2971 **************************************************************************/
duke@1 2972
duke@1 2973 /** Check for cycles in the graph of annotation elements.
duke@1 2974 */
duke@1 2975 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 2976 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 2977 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 2978 try {
duke@1 2979 tree.sym.flags_field |= LOCKED;
duke@1 2980 for (JCTree def : tree.defs) {
jjg@1127 2981 if (!def.hasTag(METHODDEF)) continue;
duke@1 2982 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 2983 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 2984 }
duke@1 2985 } finally {
duke@1 2986 tree.sym.flags_field &= ~LOCKED;
duke@1 2987 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 2988 }
duke@1 2989 }
duke@1 2990
duke@1 2991 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 2992 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 2993 return;
duke@1 2994 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 2995 log.error(pos, "cyclic.annotation.element");
duke@1 2996 return;
duke@1 2997 }
duke@1 2998 try {
duke@1 2999 tsym.flags_field |= LOCKED;
duke@1 3000 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 3001 Symbol s = e.sym;
duke@1 3002 if (s.kind != Kinds.MTH)
duke@1 3003 continue;
duke@1 3004 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 3005 }
duke@1 3006 } finally {
duke@1 3007 tsym.flags_field &= ~LOCKED;
duke@1 3008 tsym.flags_field |= ACYCLIC_ANN;
duke@1 3009 }
duke@1 3010 }
duke@1 3011
duke@1 3012 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
duke@1 3013 switch (type.tag) {
duke@1 3014 case TypeTags.CLASS:
duke@1 3015 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 3016 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 3017 break;
duke@1 3018 case TypeTags.ARRAY:
duke@1 3019 checkAnnotationResType(pos, types.elemtype(type));
duke@1 3020 break;
duke@1 3021 default:
duke@1 3022 break; // int etc
duke@1 3023 }
duke@1 3024 }
duke@1 3025
duke@1 3026 /* *************************************************************************
duke@1 3027 * Check for cycles in the constructor call graph.
duke@1 3028 **************************************************************************/
duke@1 3029
duke@1 3030 /** Check for cycles in the graph of constructors calling other
duke@1 3031 * constructors.
duke@1 3032 */
duke@1 3033 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 3034 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 3035
duke@1 3036 // enter each constructor this-call into the map
duke@1 3037 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 3038 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 3039 if (app == null) continue;
duke@1 3040 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 3041 if (TreeInfo.name(app.meth) == names._this) {
duke@1 3042 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 3043 } else {
duke@1 3044 meth.sym.flags_field |= ACYCLIC;
duke@1 3045 }
duke@1 3046 }
duke@1 3047
duke@1 3048 // Check for cycles in the map
duke@1 3049 Symbol[] ctors = new Symbol[0];
duke@1 3050 ctors = callMap.keySet().toArray(ctors);
duke@1 3051 for (Symbol caller : ctors) {
duke@1 3052 checkCyclicConstructor(tree, caller, callMap);
duke@1 3053 }
duke@1 3054 }
duke@1 3055
duke@1 3056 /** Look in the map to see if the given constructor is part of a
duke@1 3057 * call cycle.
duke@1 3058 */
duke@1 3059 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 3060 Map<Symbol,Symbol> callMap) {
duke@1 3061 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 3062 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 3063 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 3064 "recursive.ctor.invocation");
duke@1 3065 } else {
duke@1 3066 ctor.flags_field |= LOCKED;
duke@1 3067 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 3068 ctor.flags_field &= ~LOCKED;
duke@1 3069 }
duke@1 3070 ctor.flags_field |= ACYCLIC;
duke@1 3071 }
duke@1 3072 }
duke@1 3073
duke@1 3074 /* *************************************************************************
duke@1 3075 * Miscellaneous
duke@1 3076 **************************************************************************/
duke@1 3077
duke@1 3078 /**
duke@1 3079 * Return the opcode of the operator but emit an error if it is an
duke@1 3080 * error.
duke@1 3081 * @param pos position for error reporting.
duke@1 3082 * @param operator an operator
duke@1 3083 * @param tag a tree tag
duke@1 3084 * @param left type of left hand side
duke@1 3085 * @param right type of right hand side
duke@1 3086 */
duke@1 3087 int checkOperator(DiagnosticPosition pos,
duke@1 3088 OperatorSymbol operator,
jjg@1127 3089 JCTree.Tag tag,
duke@1 3090 Type left,
duke@1 3091 Type right) {
duke@1 3092 if (operator.opcode == ByteCodes.error) {
duke@1 3093 log.error(pos,
mcimadamore@853 3094 "operator.cant.be.applied.1",
duke@1 3095 treeinfo.operatorName(tag),
mcimadamore@853 3096 left, right);
duke@1 3097 }
duke@1 3098 return operator.opcode;
duke@1 3099 }
duke@1 3100
duke@1 3101
duke@1 3102 /**
duke@1 3103 * Check for division by integer constant zero
duke@1 3104 * @param pos Position for error reporting.
duke@1 3105 * @param operator The operator for the expression
duke@1 3106 * @param operand The right hand operand for the expression
duke@1 3107 */
duke@1 3108 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3109 if (operand.constValue() != null
mcimadamore@795 3110 && lint.isEnabled(LintCategory.DIVZERO)
duke@1 3111 && operand.tag <= LONG
duke@1 3112 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3113 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3114 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3115 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3116 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3117 }
duke@1 3118 }
duke@1 3119 }
duke@1 3120
duke@1 3121 /**
duke@1 3122 * Check for empty statements after if
duke@1 3123 */
duke@1 3124 void checkEmptyIf(JCIf tree) {
jjg@1127 3125 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3126 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3127 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3128 }
duke@1 3129
duke@1 3130 /** Check that symbol is unique in given scope.
duke@1 3131 * @param pos Position for error reporting.
duke@1 3132 * @param sym The symbol.
duke@1 3133 * @param s The scope.
duke@1 3134 */
duke@1 3135 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3136 if (sym.type.isErroneous())
duke@1 3137 return true;
duke@1 3138 if (sym.owner.name == names.any) return false;
duke@1 3139 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3140 if (sym != e.sym &&
mcimadamore@858 3141 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3142 sym.kind == e.sym.kind &&
mcimadamore@858 3143 sym.name != names.error &&
mcimadamore@858 3144 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3145 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3146 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3147 return true;
mcimadamore@907 3148 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3149 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3150 sym.flags_field |= CLASH;
mcimadamore@844 3151 return true;
mcimadamore@844 3152 } else {
duke@1 3153 duplicateError(pos, e.sym);
mcimadamore@844 3154 return false;
mcimadamore@844 3155 }
duke@1 3156 }
duke@1 3157 }
duke@1 3158 return true;
duke@1 3159 }
mcimadamore@844 3160
mcimadamore@858 3161 /** Report duplicate declaration error.
mcimadamore@858 3162 */
mcimadamore@858 3163 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3164 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3165 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3166 }
mcimadamore@858 3167 }
duke@1 3168
duke@1 3169 /** Check that single-type import is not already imported or top-level defined,
duke@1 3170 * but make an exception for two single-type imports which denote the same type.
duke@1 3171 * @param pos Position for error reporting.
duke@1 3172 * @param sym The symbol.
duke@1 3173 * @param s The scope
duke@1 3174 */
duke@1 3175 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3176 return checkUniqueImport(pos, sym, s, false);
duke@1 3177 }
duke@1 3178
duke@1 3179 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3180 * but make an exception for two single-type imports which denote the same type.
duke@1 3181 * @param pos Position for error reporting.
duke@1 3182 * @param sym The symbol.
duke@1 3183 * @param s The scope
duke@1 3184 */
duke@1 3185 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3186 return checkUniqueImport(pos, sym, s, true);
duke@1 3187 }
duke@1 3188
duke@1 3189 /** Check that single-type import is not already imported or top-level defined,
duke@1 3190 * but make an exception for two single-type imports which denote the same type.
duke@1 3191 * @param pos Position for error reporting.
duke@1 3192 * @param sym The symbol.
duke@1 3193 * @param s The scope.
duke@1 3194 * @param staticImport Whether or not this was a static import
duke@1 3195 */
duke@1 3196 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3197 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3198 // is encountered class entered via a class declaration?
duke@1 3199 boolean isClassDecl = e.scope == s;
duke@1 3200 if ((isClassDecl || sym != e.sym) &&
duke@1 3201 sym.kind == e.sym.kind &&
duke@1 3202 sym.name != names.error) {
duke@1 3203 if (!e.sym.type.isErroneous()) {
duke@1 3204 String what = e.sym.toString();
duke@1 3205 if (!isClassDecl) {
duke@1 3206 if (staticImport)
duke@1 3207 log.error(pos, "already.defined.static.single.import", what);
duke@1 3208 else
duke@1 3209 log.error(pos, "already.defined.single.import", what);
duke@1 3210 }
duke@1 3211 else if (sym != e.sym)
duke@1 3212 log.error(pos, "already.defined.this.unit", what);
duke@1 3213 }
duke@1 3214 return false;
duke@1 3215 }
duke@1 3216 }
duke@1 3217 return true;
duke@1 3218 }
duke@1 3219
duke@1 3220 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3221 */
duke@1 3222 public void checkCanonical(JCTree tree) {
duke@1 3223 if (!isCanonical(tree))
duke@1 3224 log.error(tree.pos(), "import.requires.canonical",
duke@1 3225 TreeInfo.symbol(tree));
duke@1 3226 }
duke@1 3227 // where
duke@1 3228 private boolean isCanonical(JCTree tree) {
jjg@1127 3229 while (tree.hasTag(SELECT)) {
duke@1 3230 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3231 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3232 return false;
duke@1 3233 tree = s.selected;
duke@1 3234 }
duke@1 3235 return true;
duke@1 3236 }
duke@1 3237
duke@1 3238 private class ConversionWarner extends Warner {
mcimadamore@795 3239 final String uncheckedKey;
duke@1 3240 final Type found;
duke@1 3241 final Type expected;
mcimadamore@795 3242 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3243 super(pos);
mcimadamore@795 3244 this.uncheckedKey = uncheckedKey;
duke@1 3245 this.found = found;
duke@1 3246 this.expected = expected;
duke@1 3247 }
duke@1 3248
jjg@398 3249 @Override
mcimadamore@795 3250 public void warn(LintCategory lint) {
duke@1 3251 boolean warned = this.warned;
mcimadamore@795 3252 super.warn(lint);
duke@1 3253 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3254 switch (lint) {
mcimadamore@795 3255 case UNCHECKED:
mcimadamore@795 3256 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3257 break;
mcimadamore@795 3258 case VARARGS:
mcimadamore@795 3259 if (method != null &&
mcimadamore@795 3260 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3261 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3262 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3263 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3264 }
mcimadamore@795 3265 break;
mcimadamore@795 3266 default:
mcimadamore@795 3267 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3268 }
duke@1 3269 }
duke@1 3270 }
duke@1 3271
duke@1 3272 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3273 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3274 }
duke@1 3275
duke@1 3276 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3277 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3278 }
duke@1 3279 }

mercurial