src/share/classes/com/sun/tools/javac/comp/Check.java

Sun, 04 Nov 2012 10:59:42 +0000

author
mcimadamore
date
Sun, 04 Nov 2012 10:59:42 +0000
changeset 1393
d7d932236fee
parent 1384
bf54daa9dcd8
child 1415
01c9d4161882
permissions
-rw-r--r--

7192246: Add type-checking support for default methods
Summary: Add type-checking support for default methods as per Featherweight-Defender document
Reviewed-by: jjg, dlsmith

duke@1 1 /*
mcimadamore@1198 2 * Copyright (c) 1999, 2012, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
ohrstrom@1384 30 import javax.tools.JavaFileManager;
duke@1 31
duke@1 32 import com.sun.tools.javac.code.*;
duke@1 33 import com.sun.tools.javac.jvm.*;
duke@1 34 import com.sun.tools.javac.tree.*;
duke@1 35 import com.sun.tools.javac.util.*;
duke@1 36 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 37 import com.sun.tools.javac.util.List;
duke@1 38
duke@1 39 import com.sun.tools.javac.tree.JCTree.*;
duke@1 40 import com.sun.tools.javac.code.Lint;
duke@1 41 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 42 import com.sun.tools.javac.code.Type.*;
duke@1 43 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 44 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 45 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1337 46 import com.sun.tools.javac.comp.Infer.InferenceContext.FreeTypeListener;
duke@1 47
duke@1 48 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 49 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 50 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 51 import static com.sun.tools.javac.code.Kinds.*;
jjg@1374 52 import static com.sun.tools.javac.code.TypeTag.*;
jjg@1374 53 import static com.sun.tools.javac.code.TypeTag.WILDCARD;
duke@1 54
jjg@1127 55 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 56
duke@1 57 /** Type checking helper class for the attribution phase.
duke@1 58 *
jjg@581 59 * <p><b>This is NOT part of any supported API.
jjg@581 60 * If you write code that depends on this, you do so at your own risk.
duke@1 61 * This code and its internal interfaces are subject to change or
duke@1 62 * deletion without notice.</b>
duke@1 63 */
duke@1 64 public class Check {
duke@1 65 protected static final Context.Key<Check> checkKey =
duke@1 66 new Context.Key<Check>();
duke@1 67
jjg@113 68 private final Names names;
duke@1 69 private final Log log;
mcimadamore@1219 70 private final Resolve rs;
duke@1 71 private final Symtab syms;
mcimadamore@690 72 private final Enter enter;
mcimadamore@1347 73 private final DeferredAttr deferredAttr;
duke@1 74 private final Infer infer;
duke@1 75 private final Types types;
mcimadamore@89 76 private final JCDiagnostic.Factory diags;
mcimadamore@359 77 private boolean warnOnSyntheticConflicts;
jjg@576 78 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 79 private boolean enableSunApiLintControl;
duke@1 80 private final TreeInfo treeinfo;
ohrstrom@1384 81 private final JavaFileManager fileManager;
duke@1 82
duke@1 83 // The set of lint options currently in effect. It is initialized
duke@1 84 // from the context, and then is set/reset as needed by Attr as it
duke@1 85 // visits all the various parts of the trees during attribution.
duke@1 86 private Lint lint;
duke@1 87
mcimadamore@795 88 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 89 // Attr as it visits new method declarations.
mcimadamore@795 90 private MethodSymbol method;
mcimadamore@795 91
duke@1 92 public static Check instance(Context context) {
duke@1 93 Check instance = context.get(checkKey);
duke@1 94 if (instance == null)
duke@1 95 instance = new Check(context);
duke@1 96 return instance;
duke@1 97 }
duke@1 98
duke@1 99 protected Check(Context context) {
duke@1 100 context.put(checkKey, this);
duke@1 101
jjg@113 102 names = Names.instance(context);
duke@1 103 log = Log.instance(context);
mcimadamore@1219 104 rs = Resolve.instance(context);
duke@1 105 syms = Symtab.instance(context);
mcimadamore@690 106 enter = Enter.instance(context);
mcimadamore@1347 107 deferredAttr = DeferredAttr.instance(context);
duke@1 108 infer = Infer.instance(context);
duke@1 109 this.types = Types.instance(context);
mcimadamore@89 110 diags = JCDiagnostic.Factory.instance(context);
duke@1 111 Options options = Options.instance(context);
duke@1 112 lint = Lint.instance(context);
duke@1 113 treeinfo = TreeInfo.instance(context);
ohrstrom@1384 114 fileManager = context.get(JavaFileManager.class);
duke@1 115
duke@1 116 Source source = Source.instance(context);
duke@1 117 allowGenerics = source.allowGenerics();
mcimadamore@1219 118 allowVarargs = source.allowVarargs();
duke@1 119 allowAnnotations = source.allowAnnotations();
jjg@398 120 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 121 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
mcimadamore@1393 122 allowDefaultMethods = source.allowDefaultMethods();
mcimadamore@1393 123 allowStrictMethodClashCheck = source.allowStrictMethodClashCheck() &&
mcimadamore@1393 124 options.isSet("strictMethodClashCheck"); //pre-lambda guard
jjg@1157 125 complexInference = options.isSet("complexinference");
jjg@700 126 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 127 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 128 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 129
jjg@398 130 Target target = Target.instance(context);
jjg@398 131 syntheticNameChar = target.syntheticNameChar();
jjg@398 132
duke@1 133 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 134 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 135 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 136 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 137
jjg@60 138 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 139 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 140 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 141 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 142 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 143 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 144
mcimadamore@852 145 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 146 }
duke@1 147
duke@1 148 /** Switch: generics enabled?
duke@1 149 */
duke@1 150 boolean allowGenerics;
duke@1 151
mcimadamore@1219 152 /** Switch: varargs enabled?
mcimadamore@1219 153 */
mcimadamore@1219 154 boolean allowVarargs;
mcimadamore@1219 155
duke@1 156 /** Switch: annotations enabled?
duke@1 157 */
duke@1 158 boolean allowAnnotations;
duke@1 159
jjg@398 160 /** Switch: covariant returns enabled?
jjg@398 161 */
jjg@398 162 boolean allowCovariantReturns;
jjg@398 163
mcimadamore@795 164 /** Switch: simplified varargs enabled?
mcimadamore@795 165 */
mcimadamore@795 166 boolean allowSimplifiedVarargs;
mcimadamore@795 167
mcimadamore@1393 168 /** Switch: default methods enabled?
mcimadamore@1393 169 */
mcimadamore@1393 170 boolean allowDefaultMethods;
mcimadamore@1393 171
mcimadamore@1393 172 /** Switch: should unrelated return types trigger a method clash?
mcimadamore@1393 173 */
mcimadamore@1393 174 boolean allowStrictMethodClashCheck;
mcimadamore@1393 175
duke@1 176 /** Switch: -complexinference option set?
duke@1 177 */
duke@1 178 boolean complexInference;
duke@1 179
jjg@398 180 /** Character for synthetic names
jjg@398 181 */
jjg@398 182 char syntheticNameChar;
jjg@398 183
duke@1 184 /** A table mapping flat names of all compiled classes in this run to their
duke@1 185 * symbols; maintained from outside.
duke@1 186 */
duke@1 187 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 188
duke@1 189 /** A handler for messages about deprecated usage.
duke@1 190 */
duke@1 191 private MandatoryWarningHandler deprecationHandler;
duke@1 192
duke@1 193 /** A handler for messages about unchecked or unsafe usage.
duke@1 194 */
duke@1 195 private MandatoryWarningHandler uncheckedHandler;
duke@1 196
jjg@582 197 /** A handler for messages about using proprietary API.
jjg@377 198 */
jjg@377 199 private MandatoryWarningHandler sunApiHandler;
duke@1 200
mcimadamore@852 201 /** A handler for deferred lint warnings.
mcimadamore@852 202 */
mcimadamore@852 203 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 204
duke@1 205 /* *************************************************************************
duke@1 206 * Errors and Warnings
duke@1 207 **************************************************************************/
duke@1 208
duke@1 209 Lint setLint(Lint newLint) {
duke@1 210 Lint prev = lint;
duke@1 211 lint = newLint;
duke@1 212 return prev;
duke@1 213 }
duke@1 214
mcimadamore@852 215 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 216 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 217 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 218 return prev;
mcimadamore@852 219 }
mcimadamore@852 220
mcimadamore@795 221 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 222 MethodSymbol prev = method;
mcimadamore@795 223 method = newMethod;
mcimadamore@795 224 return prev;
mcimadamore@795 225 }
mcimadamore@795 226
duke@1 227 /** Warn about deprecated symbol.
duke@1 228 * @param pos Position to be used for error reporting.
duke@1 229 * @param sym The deprecated symbol.
duke@1 230 */
duke@1 231 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 232 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 233 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 234 }
duke@1 235
duke@1 236 /** Warn about unchecked operation.
duke@1 237 * @param pos Position to be used for error reporting.
duke@1 238 * @param msg A string describing the problem.
duke@1 239 */
duke@1 240 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 241 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 242 uncheckedHandler.report(pos, msg, args);
duke@1 243 }
duke@1 244
mcimadamore@580 245 /** Warn about unsafe vararg method decl.
mcimadamore@580 246 * @param pos Position to be used for error reporting.
mcimadamore@580 247 */
mcimadamore@795 248 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 249 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 250 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 251 }
mcimadamore@580 252
jjg@582 253 /** Warn about using proprietary API.
jjg@377 254 * @param pos Position to be used for error reporting.
jjg@377 255 * @param msg A string describing the problem.
jjg@377 256 */
jjg@377 257 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 258 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 259 sunApiHandler.report(pos, msg, args);
jjg@377 260 }
jjg@377 261
jjg@505 262 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 263 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 264 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 265 }
jjg@505 266
duke@1 267 /**
duke@1 268 * Report any deferred diagnostics.
duke@1 269 */
duke@1 270 public void reportDeferredDiagnostics() {
duke@1 271 deprecationHandler.reportDeferredDiagnostic();
duke@1 272 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 273 sunApiHandler.reportDeferredDiagnostic();
duke@1 274 }
duke@1 275
duke@1 276
duke@1 277 /** Report a failure to complete a class.
duke@1 278 * @param pos Position to be used for error reporting.
duke@1 279 * @param ex The failure to report.
duke@1 280 */
duke@1 281 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 282 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 283 if (ex instanceof ClassReader.BadClassFile
jjg@576 284 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 285 else return syms.errType;
duke@1 286 }
duke@1 287
duke@1 288 /** Report an error that wrong type tag was found.
duke@1 289 * @param pos Position to be used for error reporting.
duke@1 290 * @param required An internationalized string describing the type tag
duke@1 291 * required.
duke@1 292 * @param found The type that was found.
duke@1 293 */
duke@1 294 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 295 // this error used to be raised by the parser,
jrose@267 296 // but has been delayed to this point:
jjg@1374 297 if (found instanceof Type && ((Type)found).hasTag(VOID)) {
jrose@267 298 log.error(pos, "illegal.start.of.type");
jrose@267 299 return syms.errType;
jrose@267 300 }
duke@1 301 log.error(pos, "type.found.req", found, required);
jjg@110 302 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 303 }
duke@1 304
duke@1 305 /** Report an error that symbol cannot be referenced before super
duke@1 306 * has been called.
duke@1 307 * @param pos Position to be used for error reporting.
duke@1 308 * @param sym The referenced symbol.
duke@1 309 */
duke@1 310 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 311 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 312 }
duke@1 313
duke@1 314 /** Report duplicate declaration error.
duke@1 315 */
duke@1 316 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 317 if (!sym.type.isErroneous()) {
mcimadamore@1085 318 Symbol location = sym.location();
mcimadamore@1085 319 if (location.kind == MTH &&
mcimadamore@1085 320 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 321 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 322 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 323 sym.location().enclClass());
mcimadamore@1085 324 } else {
mcimadamore@1085 325 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 326 kindName(sym.location()), sym.location());
mcimadamore@1085 327 }
duke@1 328 }
duke@1 329 }
duke@1 330
duke@1 331 /** Report array/varargs duplicate declaration
duke@1 332 */
duke@1 333 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 334 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 335 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 336 }
duke@1 337 }
duke@1 338
duke@1 339 /* ************************************************************************
duke@1 340 * duplicate declaration checking
duke@1 341 *************************************************************************/
duke@1 342
duke@1 343 /** Check that variable does not hide variable with same name in
duke@1 344 * immediately enclosing local scope.
duke@1 345 * @param pos Position for error reporting.
duke@1 346 * @param v The symbol.
duke@1 347 * @param s The scope.
duke@1 348 */
duke@1 349 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 350 if (s.next != null) {
duke@1 351 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 352 e.scope != null && e.sym.owner == v.owner;
duke@1 353 e = e.next()) {
duke@1 354 if (e.sym.kind == VAR &&
duke@1 355 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 356 v.name != names.error) {
duke@1 357 duplicateError(pos, e.sym);
duke@1 358 return;
duke@1 359 }
duke@1 360 }
duke@1 361 }
duke@1 362 }
duke@1 363
duke@1 364 /** Check that a class or interface does not hide a class or
duke@1 365 * interface with same name in immediately enclosing local scope.
duke@1 366 * @param pos Position for error reporting.
duke@1 367 * @param c The symbol.
duke@1 368 * @param s The scope.
duke@1 369 */
duke@1 370 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 371 if (s.next != null) {
duke@1 372 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 373 e.scope != null && e.sym.owner == c.owner;
duke@1 374 e = e.next()) {
jjg@1374 375 if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) &&
duke@1 376 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 377 c.name != names.error) {
duke@1 378 duplicateError(pos, e.sym);
duke@1 379 return;
duke@1 380 }
duke@1 381 }
duke@1 382 }
duke@1 383 }
duke@1 384
duke@1 385 /** Check that class does not have the same name as one of
duke@1 386 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 387 * return true if class is unique in its enclosing scope.
duke@1 388 * @param pos Position for error reporting.
duke@1 389 * @param name The class name.
duke@1 390 * @param s The enclosing scope.
duke@1 391 */
duke@1 392 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 393 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 394 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 395 duplicateError(pos, e.sym);
duke@1 396 return false;
duke@1 397 }
duke@1 398 }
duke@1 399 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 400 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 401 duplicateError(pos, sym);
duke@1 402 return true;
duke@1 403 }
duke@1 404 }
duke@1 405 return true;
duke@1 406 }
duke@1 407
duke@1 408 /* *************************************************************************
duke@1 409 * Class name generation
duke@1 410 **************************************************************************/
duke@1 411
duke@1 412 /** Return name of local class.
jjg@1358 413 * This is of the form {@code <enclClass> $ n <classname> }
duke@1 414 * where
duke@1 415 * enclClass is the flat name of the enclosing class,
duke@1 416 * classname is the simple name of the local class
duke@1 417 */
duke@1 418 Name localClassName(ClassSymbol c) {
duke@1 419 for (int i=1; ; i++) {
duke@1 420 Name flatname = names.
duke@1 421 fromString("" + c.owner.enclClass().flatname +
jjg@398 422 syntheticNameChar + i +
duke@1 423 c.name);
duke@1 424 if (compiled.get(flatname) == null) return flatname;
duke@1 425 }
duke@1 426 }
duke@1 427
duke@1 428 /* *************************************************************************
duke@1 429 * Type Checking
duke@1 430 **************************************************************************/
duke@1 431
mcimadamore@1238 432 /**
mcimadamore@1238 433 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 434 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 435 * vary significantly.
mcimadamore@1238 436 */
mcimadamore@1348 437 public interface CheckContext {
mcimadamore@1238 438 /**
mcimadamore@1238 439 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 440 */
mcimadamore@1238 441 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 442 /**
mcimadamore@1238 443 * Report a check error
mcimadamore@1238 444 */
mcimadamore@1296 445 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 446 /**
mcimadamore@1238 447 * Obtain a warner for this check context
mcimadamore@1238 448 */
mcimadamore@1238 449 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 450
mcimadamore@1337 451 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 452
mcimadamore@1347 453 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1348 454
mcimadamore@1348 455 public boolean allowBoxing();
mcimadamore@1238 456 }
mcimadamore@1238 457
mcimadamore@1238 458 /**
mcimadamore@1238 459 * This class represent a check context that is nested within another check
mcimadamore@1238 460 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 461 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 462 * the forwarding pattern.
mcimadamore@1238 463 */
mcimadamore@1238 464 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 465 CheckContext enclosingContext;
mcimadamore@1238 466
mcimadamore@1238 467 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 468 this.enclosingContext = enclosingContext;
mcimadamore@1238 469 }
mcimadamore@1238 470
mcimadamore@1238 471 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 472 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 473 }
mcimadamore@1238 474
mcimadamore@1296 475 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 476 enclosingContext.report(pos, details);
mcimadamore@1238 477 }
mcimadamore@1238 478
mcimadamore@1238 479 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 480 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 481 }
mcimadamore@1337 482
mcimadamore@1337 483 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 484 return enclosingContext.inferenceContext();
mcimadamore@1337 485 }
mcimadamore@1347 486
mcimadamore@1347 487 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 488 return enclosingContext.deferredAttrContext();
mcimadamore@1347 489 }
mcimadamore@1348 490
mcimadamore@1348 491 public boolean allowBoxing() {
mcimadamore@1348 492 return enclosingContext.allowBoxing();
mcimadamore@1348 493 }
mcimadamore@1238 494 }
mcimadamore@1238 495
mcimadamore@1238 496 /**
mcimadamore@1238 497 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 498 */
mcimadamore@1238 499 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 500 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 501 log.error(pos, "prob.found.req", details);
mcimadamore@1238 502 }
mcimadamore@1238 503 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 504 return types.isAssignable(found, req, warn);
mcimadamore@1238 505 }
mcimadamore@1238 506
mcimadamore@1238 507 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 508 return convertWarner(pos, found, req);
mcimadamore@1238 509 }
mcimadamore@1337 510
mcimadamore@1337 511 public InferenceContext inferenceContext() {
mcimadamore@1337 512 return infer.emptyContext;
mcimadamore@1337 513 }
mcimadamore@1347 514
mcimadamore@1347 515 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 516 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 517 }
mcimadamore@1348 518
mcimadamore@1348 519 public boolean allowBoxing() {
mcimadamore@1348 520 return true;
mcimadamore@1348 521 }
mcimadamore@1238 522 };
mcimadamore@1238 523
duke@1 524 /** Check that a given type is assignable to a given proto-type.
duke@1 525 * If it is, return the type, otherwise return errType.
duke@1 526 * @param pos Position to be used for error reporting.
duke@1 527 * @param found The type that was found.
duke@1 528 * @param req The type that was required.
duke@1 529 */
duke@1 530 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 531 return checkType(pos, found, req, basicHandler);
darcy@609 532 }
darcy@609 533
mcimadamore@1337 534 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 535 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 536 if (inferenceContext.free(req)) {
mcimadamore@1337 537 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 538 @Override
mcimadamore@1337 539 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1337 540 checkType(pos, found, inferenceContext.asInstType(req, types), checkContext);
mcimadamore@1337 541 }
mcimadamore@1337 542 });
mcimadamore@1337 543 }
jjg@1374 544 if (req.hasTag(ERROR))
duke@1 545 return req;
jjg@1374 546 if (req.hasTag(NONE))
duke@1 547 return found;
mcimadamore@1238 548 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 549 return found;
mcimadamore@1238 550 } else {
jjg@1374 551 if (found.getTag().isSubRangeOf(DOUBLE) && req.getTag().isSubRangeOf(DOUBLE)) {
mcimadamore@1296 552 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 553 return types.createErrorType(found);
mcimadamore@1238 554 }
mcimadamore@1296 555 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 556 return types.createErrorType(found);
duke@1 557 }
duke@1 558 }
duke@1 559
duke@1 560 /** Check that a given type can be cast to a given target type.
duke@1 561 * Return the result of the cast.
duke@1 562 * @param pos Position to be used for error reporting.
duke@1 563 * @param found The type that is being cast.
duke@1 564 * @param req The target type of the cast.
duke@1 565 */
duke@1 566 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 567 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 568 }
mcimadamore@1238 569 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 570 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 571 return req;
duke@1 572 } else {
mcimadamore@1296 573 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 574 return types.createErrorType(found);
duke@1 575 }
duke@1 576 }
mcimadamore@1237 577
mcimadamore@1237 578 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 579 * The problem should only be reported for non-292 cast
mcimadamore@1237 580 */
mcimadamore@1237 581 public void checkRedundantCast(Env<AttrContext> env, JCTypeCast tree) {
mcimadamore@1237 582 if (!tree.type.isErroneous() &&
mcimadamore@1348 583 (env.info.lint == null || env.info.lint.isEnabled(Lint.LintCategory.CAST))
mcimadamore@1348 584 && types.isSameType(tree.expr.type, tree.clazz.type)
mcimadamore@1348 585 && !is292targetTypeCast(tree)) {
mcimadamore@1237 586 log.warning(Lint.LintCategory.CAST,
mcimadamore@1237 587 tree.pos(), "redundant.cast", tree.expr.type);
mcimadamore@1237 588 }
mcimadamore@1237 589 }
mcimadamore@1237 590 //where
mcimadamore@1237 591 private boolean is292targetTypeCast(JCTypeCast tree) {
mcimadamore@1237 592 boolean is292targetTypeCast = false;
mcimadamore@1237 593 JCExpression expr = TreeInfo.skipParens(tree.expr);
mcimadamore@1237 594 if (expr.hasTag(APPLY)) {
mcimadamore@1237 595 JCMethodInvocation apply = (JCMethodInvocation)expr;
mcimadamore@1237 596 Symbol sym = TreeInfo.symbol(apply.meth);
mcimadamore@1237 597 is292targetTypeCast = sym != null &&
mcimadamore@1237 598 sym.kind == MTH &&
mcimadamore@1239 599 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 600 }
mcimadamore@1237 601 return is292targetTypeCast;
mcimadamore@1237 602 }
mcimadamore@1237 603
mcimadamore@1237 604
mcimadamore@1237 605
duke@1 606 //where
duke@1 607 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 608 * type variables?
duke@1 609 */
duke@1 610 boolean isTypeVar(Type t) {
jjg@1374 611 return t.hasTag(TYPEVAR) || t.hasTag(ARRAY) && isTypeVar(types.elemtype(t));
duke@1 612 }
duke@1 613
duke@1 614 /** Check that a type is within some bounds.
duke@1 615 *
jjg@1358 616 * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
duke@1 617 * type argument.
duke@1 618 * @param a The type that should be bounded by bs.
jjg@1358 619 * @param bound The bound.
duke@1 620 */
mcimadamore@1216 621 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 622 if (a.isUnbound()) {
mcimadamore@821 623 return true;
jjg@1374 624 } else if (!a.hasTag(WILDCARD)) {
mcimadamore@154 625 a = types.upperBound(a);
mcimadamore@1216 626 return types.isSubtype(a, bound);
mcimadamore@154 627 } else if (a.isExtendsBound()) {
mcimadamore@1216 628 return types.isCastable(bound, types.upperBound(a), Warner.noWarnings);
mcimadamore@154 629 } else if (a.isSuperBound()) {
mcimadamore@1216 630 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 631 }
mcimadamore@821 632 return true;
mcimadamore@154 633 }
duke@1 634
duke@1 635 /** Check that type is different from 'void'.
duke@1 636 * @param pos Position to be used for error reporting.
duke@1 637 * @param t The type to be checked.
duke@1 638 */
duke@1 639 Type checkNonVoid(DiagnosticPosition pos, Type t) {
jjg@1374 640 if (t.hasTag(VOID)) {
duke@1 641 log.error(pos, "void.not.allowed.here");
jjg@110 642 return types.createErrorType(t);
duke@1 643 } else {
duke@1 644 return t;
duke@1 645 }
duke@1 646 }
duke@1 647
duke@1 648 /** Check that type is a class or interface type.
duke@1 649 * @param pos Position to be used for error reporting.
duke@1 650 * @param t The type to be checked.
duke@1 651 */
duke@1 652 Type checkClassType(DiagnosticPosition pos, Type t) {
jjg@1374 653 if (!t.hasTag(CLASS) && !t.hasTag(ERROR))
duke@1 654 return typeTagError(pos,
mcimadamore@89 655 diags.fragment("type.req.class"),
jjg@1374 656 (t.hasTag(TYPEVAR))
mcimadamore@89 657 ? diags.fragment("type.parameter", t)
duke@1 658 : t);
duke@1 659 else
duke@1 660 return t;
duke@1 661 }
duke@1 662
mcimadamore@1352 663 /** Check that type is a valid qualifier for a constructor reference expression
mcimadamore@1352 664 */
mcimadamore@1352 665 Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
mcimadamore@1352 666 t = checkClassType(pos, t);
jjg@1374 667 if (t.hasTag(CLASS)) {
mcimadamore@1352 668 if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
mcimadamore@1352 669 log.error(pos, "abstract.cant.be.instantiated");
mcimadamore@1352 670 t = types.createErrorType(t);
mcimadamore@1352 671 } else if ((t.tsym.flags() & ENUM) != 0) {
mcimadamore@1352 672 log.error(pos, "enum.cant.be.instantiated");
mcimadamore@1352 673 t = types.createErrorType(t);
mcimadamore@1352 674 }
mcimadamore@1352 675 }
mcimadamore@1352 676 return t;
mcimadamore@1352 677 }
mcimadamore@1352 678
duke@1 679 /** Check that type is a class or interface type.
duke@1 680 * @param pos Position to be used for error reporting.
duke@1 681 * @param t The type to be checked.
duke@1 682 * @param noBounds True if type bounds are illegal here.
duke@1 683 */
duke@1 684 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 685 t = checkClassType(pos, t);
duke@1 686 if (noBounds && t.isParameterized()) {
duke@1 687 List<Type> args = t.getTypeArguments();
duke@1 688 while (args.nonEmpty()) {
jjg@1374 689 if (args.head.hasTag(WILDCARD))
duke@1 690 return typeTagError(pos,
jjg@598 691 diags.fragment("type.req.exact"),
duke@1 692 args.head);
duke@1 693 args = args.tail;
duke@1 694 }
duke@1 695 }
duke@1 696 return t;
duke@1 697 }
duke@1 698
duke@1 699 /** Check that type is a reifiable class, interface or array type.
duke@1 700 * @param pos Position to be used for error reporting.
duke@1 701 * @param t The type to be checked.
duke@1 702 */
duke@1 703 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
jjg@1374 704 if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
duke@1 705 return typeTagError(pos,
mcimadamore@89 706 diags.fragment("type.req.class.array"),
duke@1 707 t);
duke@1 708 } else if (!types.isReifiable(t)) {
duke@1 709 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 710 return types.createErrorType(t);
duke@1 711 } else {
duke@1 712 return t;
duke@1 713 }
duke@1 714 }
duke@1 715
duke@1 716 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 717 * or a type variable.
duke@1 718 * @param pos Position to be used for error reporting.
duke@1 719 * @param t The type to be checked.
duke@1 720 */
duke@1 721 Type checkRefType(DiagnosticPosition pos, Type t) {
jjg@1374 722 if (t.isReference())
duke@1 723 return t;
jjg@1374 724 else
duke@1 725 return typeTagError(pos,
mcimadamore@89 726 diags.fragment("type.req.ref"),
duke@1 727 t);
duke@1 728 }
duke@1 729
jrose@267 730 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 731 * or a type variable.
jrose@267 732 * @param trees Original trees, used for error reporting.
jrose@267 733 * @param types The types to be checked.
jrose@267 734 */
jrose@267 735 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 736 List<JCExpression> tl = trees;
jrose@267 737 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 738 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 739 tl = tl.tail;
jrose@267 740 }
jrose@267 741 return types;
jrose@267 742 }
jrose@267 743
duke@1 744 /** Check that type is a null or reference type.
duke@1 745 * @param pos Position to be used for error reporting.
duke@1 746 * @param t The type to be checked.
duke@1 747 */
duke@1 748 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
jjg@1374 749 if (t.isNullOrReference())
duke@1 750 return t;
jjg@1374 751 else
duke@1 752 return typeTagError(pos,
mcimadamore@89 753 diags.fragment("type.req.ref"),
duke@1 754 t);
duke@1 755 }
duke@1 756
duke@1 757 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 758 * Return true if it doesn't.
duke@1 759 * @param pos Position to be used for error reporting.
duke@1 760 * @param flags The set of flags to be checked.
duke@1 761 * @param set1 Conflicting flags set #1.
duke@1 762 * @param set2 Conflicting flags set #2.
duke@1 763 */
duke@1 764 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 765 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 766 log.error(pos,
duke@1 767 "illegal.combination.of.modifiers",
mcimadamore@80 768 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 769 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 770 return false;
duke@1 771 } else
duke@1 772 return true;
duke@1 773 }
duke@1 774
mcimadamore@914 775 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 776 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 777 */
mcimadamore@914 778 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 779 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 780 t.isErroneous()) {
mcimadamore@914 781 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 782 } else if (tree.def != null) {
mcimadamore@914 783 log.error(tree.clazz.pos(),
mcimadamore@914 784 "cant.apply.diamond.1",
mcimadamore@914 785 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 786 return types.createErrorType(t);
mcimadamore@948 787 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 788 log.error(tree.clazz.pos(),
mcimadamore@914 789 "cant.apply.diamond.1",
mcimadamore@914 790 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 791 return types.createErrorType(t);
mcimadamore@993 792 } else if (tree.typeargs != null &&
mcimadamore@993 793 tree.typeargs.nonEmpty()) {
mcimadamore@993 794 log.error(tree.clazz.pos(),
mcimadamore@993 795 "cant.apply.diamond.1",
mcimadamore@993 796 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 797 return types.createErrorType(t);
mcimadamore@914 798 } else {
mcimadamore@914 799 return t;
mcimadamore@537 800 }
mcimadamore@537 801 }
mcimadamore@537 802
mcimadamore@795 803 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 804 MethodSymbol m = tree.sym;
mcimadamore@795 805 if (!allowSimplifiedVarargs) return;
mcimadamore@795 806 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 807 Type varargElemType = null;
mcimadamore@580 808 if (m.isVarArgs()) {
mcimadamore@795 809 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 810 }
mcimadamore@795 811 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 812 if (varargElemType != null) {
mcimadamore@795 813 log.error(tree,
mcimadamore@795 814 "varargs.invalid.trustme.anno",
mcimadamore@795 815 syms.trustMeType.tsym,
mcimadamore@795 816 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 817 } else {
mcimadamore@795 818 log.error(tree,
mcimadamore@795 819 "varargs.invalid.trustme.anno",
mcimadamore@795 820 syms.trustMeType.tsym,
mcimadamore@795 821 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 822 }
mcimadamore@795 823 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 824 types.isReifiable(varargElemType)) {
mcimadamore@795 825 warnUnsafeVararg(tree,
mcimadamore@795 826 "varargs.redundant.trustme.anno",
mcimadamore@795 827 syms.trustMeType.tsym,
mcimadamore@795 828 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 829 }
mcimadamore@795 830 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 831 !types.isReifiable(varargElemType)) {
mcimadamore@795 832 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 833 }
mcimadamore@580 834 }
mcimadamore@795 835 //where
mcimadamore@795 836 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 837 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 838 (s.isConstructor() ||
mcimadamore@795 839 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 840 }
mcimadamore@580 841
mcimadamore@1219 842 Type checkMethod(Type owntype,
mcimadamore@1219 843 Symbol sym,
mcimadamore@1219 844 Env<AttrContext> env,
mcimadamore@1219 845 final List<JCExpression> argtrees,
mcimadamore@1219 846 List<Type> argtypes,
mcimadamore@1226 847 boolean useVarargs,
mcimadamore@1226 848 boolean unchecked) {
mcimadamore@1219 849 // System.out.println("call : " + env.tree);
mcimadamore@1219 850 // System.out.println("method : " + owntype);
mcimadamore@1219 851 // System.out.println("actuals: " + argtypes);
mcimadamore@1219 852 List<Type> formals = owntype.getParameterTypes();
mcimadamore@1219 853 Type last = useVarargs ? formals.last() : null;
mcimadamore@1219 854 if (sym.name==names.init &&
mcimadamore@1219 855 sym.owner == syms.enumSym)
mcimadamore@1219 856 formals = formals.tail.tail;
mcimadamore@1219 857 List<JCExpression> args = argtrees;
mcimadamore@1347 858 DeferredAttr.DeferredTypeMap checkDeferredMap =
mcimadamore@1347 859 deferredAttr.new DeferredTypeMap(DeferredAttr.AttrMode.CHECK, sym, env.info.pendingResolutionPhase);
mcimadamore@1352 860 if (args != null) {
mcimadamore@1352 861 //this is null when type-checking a method reference
mcimadamore@1352 862 while (formals.head != last) {
mcimadamore@1219 863 JCTree arg = args.head;
mcimadamore@1352 864 Warner warn = convertWarner(arg.pos(), arg.type, formals.head);
mcimadamore@1352 865 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 866 args = args.tail;
mcimadamore@1352 867 formals = formals.tail;
mcimadamore@1219 868 }
mcimadamore@1352 869 if (useVarargs) {
mcimadamore@1352 870 Type varArg = types.elemtype(last);
mcimadamore@1352 871 while (args.tail != null) {
mcimadamore@1352 872 JCTree arg = args.head;
mcimadamore@1352 873 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1352 874 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1352 875 args = args.tail;
mcimadamore@1352 876 }
mcimadamore@1352 877 } else if ((sym.flags() & VARARGS) != 0 && allowVarargs) {
mcimadamore@1352 878 // non-varargs call to varargs method
mcimadamore@1352 879 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1352 880 Type lastArg = checkDeferredMap.apply(argtypes.last());
mcimadamore@1352 881 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
mcimadamore@1352 882 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1352 883 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
mcimadamore@1352 884 types.elemtype(varParam), varParam);
mcimadamore@1352 885 }
mcimadamore@1219 886 }
mcimadamore@1226 887 if (unchecked) {
mcimadamore@1219 888 warnUnchecked(env.tree.pos(),
mcimadamore@1219 889 "unchecked.meth.invocation.applied",
mcimadamore@1219 890 kindName(sym),
mcimadamore@1219 891 sym.name,
mcimadamore@1219 892 rs.methodArguments(sym.type.getParameterTypes()),
mcimadamore@1347 893 rs.methodArguments(Type.map(argtypes, checkDeferredMap)),
mcimadamore@1219 894 kindName(sym.location()),
mcimadamore@1219 895 sym.location());
mcimadamore@1219 896 owntype = new MethodType(owntype.getParameterTypes(),
mcimadamore@1219 897 types.erasure(owntype.getReturnType()),
mcimadamore@1219 898 types.erasure(owntype.getThrownTypes()),
mcimadamore@1219 899 syms.methodClass);
mcimadamore@1219 900 }
mcimadamore@1219 901 if (useVarargs) {
mcimadamore@1219 902 JCTree tree = env.tree;
mcimadamore@1219 903 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 904 if (!types.isReifiable(argtype) &&
mcimadamore@1219 905 (!allowSimplifiedVarargs ||
mcimadamore@1219 906 sym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@1219 907 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 908 warnUnchecked(env.tree.pos(),
mcimadamore@1219 909 "unchecked.generic.array.creation",
mcimadamore@1219 910 argtype);
mcimadamore@1219 911 }
mcimadamore@1219 912 Type elemtype = types.elemtype(argtype);
mcimadamore@1219 913 switch (tree.getTag()) {
mcimadamore@1219 914 case APPLY:
mcimadamore@1219 915 ((JCMethodInvocation) tree).varargsElement = elemtype;
mcimadamore@1219 916 break;
mcimadamore@1219 917 case NEWCLASS:
mcimadamore@1219 918 ((JCNewClass) tree).varargsElement = elemtype;
mcimadamore@1219 919 break;
mcimadamore@1352 920 case REFERENCE:
mcimadamore@1352 921 ((JCMemberReference) tree).varargsElement = elemtype;
mcimadamore@1352 922 break;
mcimadamore@1219 923 default:
mcimadamore@1219 924 throw new AssertionError(""+tree);
mcimadamore@1219 925 }
mcimadamore@1219 926 }
mcimadamore@1219 927 return owntype;
mcimadamore@547 928 }
mcimadamore@1219 929 //where
mcimadamore@1219 930 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
mcimadamore@1219 931 if (types.isConvertible(actual, formal, warn))
mcimadamore@1219 932 return;
mcimadamore@1219 933
mcimadamore@1219 934 if (formal.isCompound()
mcimadamore@1219 935 && types.isSubtype(actual, types.supertype(formal))
mcimadamore@1219 936 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
mcimadamore@1219 937 return;
mcimadamore@1219 938 }
mcimadamore@547 939
mcimadamore@1348 940 void checkAccessibleFunctionalDescriptor(DiagnosticPosition pos, Env<AttrContext> env, Type desc) {
mcimadamore@1348 941 AccessChecker accessChecker = new AccessChecker(env);
mcimadamore@1348 942 //check args accessibility (only if implicit parameter types)
mcimadamore@1348 943 for (Type arg : desc.getParameterTypes()) {
mcimadamore@1348 944 if (!accessChecker.visit(arg)) {
mcimadamore@1348 945 log.error(pos, "cant.access.arg.type.in.functional.desc", arg);
mcimadamore@1348 946 return;
mcimadamore@1348 947 }
mcimadamore@1348 948 }
mcimadamore@1348 949 //check return type accessibility
mcimadamore@1348 950 if (!accessChecker.visit(desc.getReturnType())) {
mcimadamore@1348 951 log.error(pos, "cant.access.return.in.functional.desc", desc.getReturnType());
mcimadamore@1348 952 return;
mcimadamore@1348 953 }
mcimadamore@1348 954 //check thrown types accessibility
mcimadamore@1348 955 for (Type thrown : desc.getThrownTypes()) {
mcimadamore@1348 956 if (!accessChecker.visit(thrown)) {
mcimadamore@1348 957 log.error(pos, "cant.access.thrown.in.functional.desc", thrown);
mcimadamore@1348 958 return;
mcimadamore@1348 959 }
mcimadamore@1348 960 }
mcimadamore@1348 961 }
mcimadamore@1348 962
mcimadamore@1348 963 class AccessChecker extends Types.UnaryVisitor<Boolean> {
mcimadamore@1348 964
mcimadamore@1348 965 Env<AttrContext> env;
mcimadamore@1348 966
mcimadamore@1348 967 AccessChecker(Env<AttrContext> env) {
mcimadamore@1348 968 this.env = env;
mcimadamore@1348 969 }
mcimadamore@1348 970
mcimadamore@1348 971 Boolean visit(List<Type> ts) {
mcimadamore@1348 972 for (Type t : ts) {
mcimadamore@1348 973 if (!visit(t))
mcimadamore@1348 974 return false;
mcimadamore@1348 975 }
mcimadamore@1348 976 return true;
mcimadamore@1348 977 }
mcimadamore@1348 978
mcimadamore@1348 979 public Boolean visitType(Type t, Void s) {
mcimadamore@1348 980 return true;
mcimadamore@1348 981 }
mcimadamore@1348 982
mcimadamore@1348 983 @Override
mcimadamore@1348 984 public Boolean visitArrayType(ArrayType t, Void s) {
mcimadamore@1348 985 return visit(t.elemtype);
mcimadamore@1348 986 }
mcimadamore@1348 987
mcimadamore@1348 988 @Override
mcimadamore@1348 989 public Boolean visitClassType(ClassType t, Void s) {
mcimadamore@1348 990 return rs.isAccessible(env, t, true) &&
mcimadamore@1348 991 visit(t.getTypeArguments());
mcimadamore@1348 992 }
mcimadamore@1348 993
mcimadamore@1348 994 @Override
mcimadamore@1348 995 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@1348 996 return visit(t.type);
mcimadamore@1348 997 }
mcimadamore@1348 998 };
mcimadamore@821 999 /**
mcimadamore@821 1000 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 1001 * (see JLS 4.5)
mcimadamore@821 1002 *
mcimadamore@821 1003 * @param t class type to be checked
mcimadamore@821 1004 * @return true if 't' is well-formed
mcimadamore@821 1005 */
mcimadamore@821 1006 public boolean checkValidGenericType(Type t) {
mcimadamore@821 1007 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 1008 }
mcimadamore@821 1009 //WHERE
mcimadamore@821 1010 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 1011 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 1012 List<Type> actuals = type.allparams();
mcimadamore@821 1013 List<Type> args = type.getTypeArguments();
mcimadamore@821 1014 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 1015 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 1016
mcimadamore@821 1017 // For matching pairs of actual argument types `a' and
mcimadamore@821 1018 // formal type parameters with declared bound `b' ...
mcimadamore@821 1019 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 1020 // exact type arguments needs to know their
mcimadamore@821 1021 // bounds (for upper and lower bound
mcimadamore@1216 1022 // calculations). So we create new bounds where
mcimadamore@1216 1023 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 1024 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 1025 args = args.tail;
mcimadamore@821 1026 forms = forms.tail;
mcimadamore@821 1027 }
mcimadamore@821 1028
mcimadamore@821 1029 args = type.getTypeArguments();
mcimadamore@821 1030 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 1031 formals,
mcimadamore@821 1032 types.capture(type).allparams());
mcimadamore@821 1033 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 1034 // Let the actual arguments know their bound
mcimadamore@821 1035 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 1036 args = args.tail;
mcimadamore@821 1037 tvars_cap = tvars_cap.tail;
mcimadamore@821 1038 }
mcimadamore@821 1039
mcimadamore@821 1040 args = type.getTypeArguments();
mcimadamore@1216 1041 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 1042
mcimadamore@1216 1043 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 1044 Type actual = args.head;
mcimadamore@854 1045 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 1046 !bounds.head.isErroneous() &&
mcimadamore@1216 1047 !checkExtends(actual, bounds.head)) {
mcimadamore@821 1048 return args.head;
mcimadamore@821 1049 }
mcimadamore@821 1050 args = args.tail;
mcimadamore@1216 1051 bounds = bounds.tail;
mcimadamore@821 1052 }
mcimadamore@821 1053
mcimadamore@821 1054 args = type.getTypeArguments();
mcimadamore@1216 1055 bounds = bounds_buf.toList();
mcimadamore@821 1056
mcimadamore@821 1057 for (Type arg : types.capture(type).getTypeArguments()) {
jjg@1374 1058 if (arg.hasTag(TYPEVAR) &&
mcimadamore@828 1059 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 1060 !bounds.head.isErroneous() &&
mcimadamore@854 1061 !isTypeArgErroneous(args.head)) {
mcimadamore@821 1062 return args.head;
mcimadamore@821 1063 }
mcimadamore@1216 1064 bounds = bounds.tail;
mcimadamore@854 1065 args = args.tail;
mcimadamore@821 1066 }
mcimadamore@821 1067
mcimadamore@821 1068 return null;
mcimadamore@821 1069 }
mcimadamore@854 1070 //where
mcimadamore@854 1071 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 1072 return isTypeArgErroneous.visit(t);
mcimadamore@854 1073 }
mcimadamore@854 1074
mcimadamore@854 1075 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 1076 public Boolean visitType(Type t, Void s) {
mcimadamore@854 1077 return t.isErroneous();
mcimadamore@854 1078 }
mcimadamore@854 1079 @Override
mcimadamore@854 1080 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 1081 return visit(t.getUpperBound());
mcimadamore@854 1082 }
mcimadamore@854 1083 @Override
mcimadamore@854 1084 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 1085 return visit(t.getUpperBound()) ||
mcimadamore@854 1086 visit(t.getLowerBound());
mcimadamore@854 1087 }
mcimadamore@854 1088 @Override
mcimadamore@854 1089 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1090 return visit(t.type);
mcimadamore@854 1091 }
mcimadamore@854 1092 };
mcimadamore@821 1093
duke@1 1094 /** Check that given modifiers are legal for given symbol and
duke@1 1095 * return modifiers together with any implicit modififiers for that symbol.
duke@1 1096 * Warning: we can't use flags() here since this method
duke@1 1097 * is called during class enter, when flags() would cause a premature
duke@1 1098 * completion.
duke@1 1099 * @param pos Position to be used for error reporting.
duke@1 1100 * @param flags The set of modifiers given in a definition.
duke@1 1101 * @param sym The defined symbol.
duke@1 1102 */
duke@1 1103 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1104 long mask;
duke@1 1105 long implicit = 0;
duke@1 1106 switch (sym.kind) {
duke@1 1107 case VAR:
duke@1 1108 if (sym.owner.kind != TYP)
duke@1 1109 mask = LocalVarFlags;
duke@1 1110 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1111 mask = implicit = InterfaceVarFlags;
duke@1 1112 else
duke@1 1113 mask = VarFlags;
duke@1 1114 break;
duke@1 1115 case MTH:
duke@1 1116 if (sym.name == names.init) {
duke@1 1117 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1118 // enum constructors cannot be declared public or
duke@1 1119 // protected and must be implicitly or explicitly
duke@1 1120 // private
duke@1 1121 implicit = PRIVATE;
duke@1 1122 mask = PRIVATE;
duke@1 1123 } else
duke@1 1124 mask = ConstructorFlags;
mcimadamore@1366 1125 } else if ((sym.owner.flags_field & INTERFACE) != 0) {
mcimadamore@1366 1126 if ((flags & DEFAULT) != 0) {
mcimadamore@1366 1127 mask = InterfaceDefaultMethodMask;
mcimadamore@1393 1128 implicit = PUBLIC | ABSTRACT;
mcimadamore@1366 1129 } else {
mcimadamore@1366 1130 mask = implicit = InterfaceMethodFlags;
mcimadamore@1366 1131 }
mcimadamore@1366 1132 }
duke@1 1133 else {
duke@1 1134 mask = MethodFlags;
duke@1 1135 }
duke@1 1136 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1137 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 1138 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1139 break;
duke@1 1140 case TYP:
duke@1 1141 if (sym.isLocal()) {
duke@1 1142 mask = LocalClassFlags;
jjg@113 1143 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1144 // Anonymous classes in static methods are themselves static;
duke@1 1145 // that's why we admit STATIC here.
duke@1 1146 mask |= STATIC;
duke@1 1147 // JLS: Anonymous classes are final.
duke@1 1148 implicit |= FINAL;
duke@1 1149 }
duke@1 1150 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1151 (flags & ENUM) != 0)
duke@1 1152 log.error(pos, "enums.must.be.static");
duke@1 1153 } else if (sym.owner.kind == TYP) {
duke@1 1154 mask = MemberClassFlags;
duke@1 1155 if (sym.owner.owner.kind == PCK ||
duke@1 1156 (sym.owner.flags_field & STATIC) != 0)
duke@1 1157 mask |= STATIC;
duke@1 1158 else if ((flags & ENUM) != 0)
duke@1 1159 log.error(pos, "enums.must.be.static");
duke@1 1160 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1161 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1162 } else {
duke@1 1163 mask = ClassFlags;
duke@1 1164 }
duke@1 1165 // Interfaces are always ABSTRACT
duke@1 1166 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1167
duke@1 1168 if ((flags & ENUM) != 0) {
duke@1 1169 // enums can't be declared abstract or final
duke@1 1170 mask &= ~(ABSTRACT | FINAL);
duke@1 1171 implicit |= implicitEnumFinalFlag(tree);
duke@1 1172 }
duke@1 1173 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1174 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1175 break;
duke@1 1176 default:
duke@1 1177 throw new AssertionError();
duke@1 1178 }
mcimadamore@1366 1179 long illegal = flags & ExtendedStandardFlags & ~mask;
duke@1 1180 if (illegal != 0) {
duke@1 1181 if ((illegal & INTERFACE) != 0) {
duke@1 1182 log.error(pos, "intf.not.allowed.here");
duke@1 1183 mask |= INTERFACE;
duke@1 1184 }
duke@1 1185 else {
duke@1 1186 log.error(pos,
mcimadamore@80 1187 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1188 }
duke@1 1189 }
duke@1 1190 else if ((sym.kind == TYP ||
duke@1 1191 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1192 // in the presence of inner classes. Should it be deleted here?
duke@1 1193 checkDisjoint(pos, flags,
duke@1 1194 ABSTRACT,
mcimadamore@1366 1195 PRIVATE | STATIC | DEFAULT))
duke@1 1196 &&
duke@1 1197 checkDisjoint(pos, flags,
duke@1 1198 ABSTRACT | INTERFACE,
duke@1 1199 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1200 &&
duke@1 1201 checkDisjoint(pos, flags,
duke@1 1202 PUBLIC,
duke@1 1203 PRIVATE | PROTECTED)
duke@1 1204 &&
duke@1 1205 checkDisjoint(pos, flags,
duke@1 1206 PRIVATE,
duke@1 1207 PUBLIC | PROTECTED)
duke@1 1208 &&
duke@1 1209 checkDisjoint(pos, flags,
duke@1 1210 FINAL,
duke@1 1211 VOLATILE)
duke@1 1212 &&
duke@1 1213 (sym.kind == TYP ||
duke@1 1214 checkDisjoint(pos, flags,
duke@1 1215 ABSTRACT | NATIVE,
duke@1 1216 STRICTFP))) {
duke@1 1217 // skip
duke@1 1218 }
mcimadamore@1366 1219 return flags & (mask | ~ExtendedStandardFlags) | implicit;
duke@1 1220 }
duke@1 1221
duke@1 1222
duke@1 1223 /** Determine if this enum should be implicitly final.
duke@1 1224 *
duke@1 1225 * If the enum has no specialized enum contants, it is final.
duke@1 1226 *
duke@1 1227 * If the enum does have specialized enum contants, it is
duke@1 1228 * <i>not</i> final.
duke@1 1229 */
duke@1 1230 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1231 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1232 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1233 boolean specialized;
duke@1 1234 SpecialTreeVisitor() {
duke@1 1235 this.specialized = false;
duke@1 1236 };
duke@1 1237
jjg@398 1238 @Override
duke@1 1239 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1240
jjg@398 1241 @Override
duke@1 1242 public void visitVarDef(JCVariableDecl tree) {
duke@1 1243 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1244 if (tree.init instanceof JCNewClass &&
duke@1 1245 ((JCNewClass) tree.init).def != null) {
duke@1 1246 specialized = true;
duke@1 1247 }
duke@1 1248 }
duke@1 1249 }
duke@1 1250 }
duke@1 1251
duke@1 1252 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1253 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1254 for (JCTree defs: cdef.defs) {
duke@1 1255 defs.accept(sts);
duke@1 1256 if (sts.specialized) return 0;
duke@1 1257 }
duke@1 1258 return FINAL;
duke@1 1259 }
duke@1 1260
duke@1 1261 /* *************************************************************************
duke@1 1262 * Type Validation
duke@1 1263 **************************************************************************/
duke@1 1264
duke@1 1265 /** Validate a type expression. That is,
duke@1 1266 * check that all type arguments of a parametric type are within
duke@1 1267 * their bounds. This must be done in a second phase after type attributon
duke@1 1268 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1269 *
jjg@1358 1270 * <pre>{@code
duke@1 1271 * class B<A extends C> { ... }
duke@1 1272 * class C extends B<C> { ... }
jjg@1358 1273 * }</pre>
duke@1 1274 *
duke@1 1275 * and we can't make sure that the bound is already attributed because
duke@1 1276 * of possible cycles.
mcimadamore@638 1277 *
mcimadamore@638 1278 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1279 * and reporting any completion failures.
duke@1 1280 */
mcimadamore@122 1281 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1282 validate(tree, env, true);
duke@1 1283 }
mcimadamore@638 1284 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1285 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1286 }
duke@1 1287
duke@1 1288 /** Visitor method: Validate a list of type expressions.
duke@1 1289 */
mcimadamore@122 1290 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1291 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1292 validate(l.head, env);
duke@1 1293 }
duke@1 1294
duke@1 1295 /** A visitor class for type validation.
duke@1 1296 */
duke@1 1297 class Validator extends JCTree.Visitor {
duke@1 1298
mcimadamore@638 1299 boolean isOuter;
mcimadamore@638 1300 Env<AttrContext> env;
mcimadamore@638 1301
mcimadamore@638 1302 Validator(Env<AttrContext> env) {
mcimadamore@638 1303 this.env = env;
mcimadamore@638 1304 }
mcimadamore@638 1305
jjg@398 1306 @Override
duke@1 1307 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1308 tree.elemtype.accept(this);
duke@1 1309 }
duke@1 1310
jjg@398 1311 @Override
duke@1 1312 public void visitTypeApply(JCTypeApply tree) {
jjg@1374 1313 if (tree.type.hasTag(CLASS)) {
duke@1 1314 List<JCExpression> args = tree.arguments;
mcimadamore@158 1315 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1316
mcimadamore@821 1317 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1318 if (incompatibleArg != null) {
mcimadamore@821 1319 for (JCTree arg : tree.arguments) {
mcimadamore@821 1320 if (arg.type == incompatibleArg) {
mcimadamore@829 1321 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1322 }
mcimadamore@829 1323 forms = forms.tail;
mcimadamore@829 1324 }
mcimadamore@829 1325 }
mcimadamore@829 1326
mcimadamore@829 1327 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1328
mcimadamore@638 1329 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1330
duke@1 1331 // For matching pairs of actual argument types `a' and
duke@1 1332 // formal type parameters with declared bound `b' ...
duke@1 1333 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1334 validateTree(args.head,
mcimadamore@638 1335 !(isOuter && is_java_lang_Class),
mcimadamore@638 1336 false);
duke@1 1337 args = args.tail;
duke@1 1338 forms = forms.tail;
duke@1 1339 }
duke@1 1340
duke@1 1341 // Check that this type is either fully parameterized, or
duke@1 1342 // not parameterized at all.
duke@1 1343 if (tree.type.getEnclosingType().isRaw())
duke@1 1344 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1345 if (tree.clazz.hasTag(SELECT))
duke@1 1346 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1347 }
duke@1 1348 }
duke@1 1349
jjg@398 1350 @Override
duke@1 1351 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1352 validateTrees(tree.bounds, true, isOuter);
duke@1 1353 checkClassBounds(tree.pos(), tree.type);
duke@1 1354 }
duke@1 1355
duke@1 1356 @Override
duke@1 1357 public void visitWildcard(JCWildcard tree) {
duke@1 1358 if (tree.inner != null)
mcimadamore@638 1359 validateTree(tree.inner, true, isOuter);
duke@1 1360 }
duke@1 1361
jjg@398 1362 @Override
duke@1 1363 public void visitSelect(JCFieldAccess tree) {
jjg@1374 1364 if (tree.type.hasTag(CLASS)) {
duke@1 1365 visitSelectInternal(tree);
duke@1 1366
duke@1 1367 // Check that this type is either fully parameterized, or
duke@1 1368 // not parameterized at all.
duke@1 1369 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1370 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1371 }
duke@1 1372 }
mcimadamore@852 1373
duke@1 1374 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1375 if (tree.type.tsym.isStatic() &&
duke@1 1376 tree.selected.type.isParameterized()) {
duke@1 1377 // The enclosing type is not a class, so we are
duke@1 1378 // looking at a static member type. However, the
duke@1 1379 // qualifying expression is parameterized.
duke@1 1380 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1381 } else {
duke@1 1382 // otherwise validate the rest of the expression
mcimadamore@122 1383 tree.selected.accept(this);
duke@1 1384 }
duke@1 1385 }
duke@1 1386
duke@1 1387 /** Default visitor method: do nothing.
duke@1 1388 */
jjg@398 1389 @Override
duke@1 1390 public void visitTree(JCTree tree) {
duke@1 1391 }
mcimadamore@122 1392
mcimadamore@638 1393 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1394 try {
mcimadamore@638 1395 if (tree != null) {
mcimadamore@638 1396 this.isOuter = isOuter;
mcimadamore@638 1397 tree.accept(this);
mcimadamore@638 1398 if (checkRaw)
mcimadamore@638 1399 checkRaw(tree, env);
mcimadamore@638 1400 }
mcimadamore@638 1401 } catch (CompletionFailure ex) {
mcimadamore@638 1402 completionError(tree.pos(), ex);
mcimadamore@638 1403 }
mcimadamore@638 1404 }
mcimadamore@638 1405
mcimadamore@638 1406 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1407 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1408 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1409 }
mcimadamore@638 1410
mcimadamore@638 1411 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1412 if (lint.isEnabled(LintCategory.RAW) &&
jjg@1374 1413 tree.type.hasTag(CLASS) &&
mcimadamore@638 1414 !TreeInfo.isDiamond(tree) &&
mcimadamore@1103 1415 !withinAnonConstr(env) &&
mcimadamore@638 1416 tree.type.isRaw()) {
mcimadamore@795 1417 log.warning(LintCategory.RAW,
mcimadamore@638 1418 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1419 }
mcimadamore@638 1420 }
mcimadamore@1103 1421
mcimadamore@1103 1422 boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1423 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1424 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1425 }
duke@1 1426 }
duke@1 1427
duke@1 1428 /* *************************************************************************
duke@1 1429 * Exception checking
duke@1 1430 **************************************************************************/
duke@1 1431
duke@1 1432 /* The following methods treat classes as sets that contain
duke@1 1433 * the class itself and all their subclasses
duke@1 1434 */
duke@1 1435
duke@1 1436 /** Is given type a subtype of some of the types in given list?
duke@1 1437 */
duke@1 1438 boolean subset(Type t, List<Type> ts) {
duke@1 1439 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1440 if (types.isSubtype(t, l.head)) return true;
duke@1 1441 return false;
duke@1 1442 }
duke@1 1443
duke@1 1444 /** Is given type a subtype or supertype of
duke@1 1445 * some of the types in given list?
duke@1 1446 */
duke@1 1447 boolean intersects(Type t, List<Type> ts) {
duke@1 1448 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1449 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1450 return false;
duke@1 1451 }
duke@1 1452
duke@1 1453 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1454 * in the list.
duke@1 1455 */
duke@1 1456 List<Type> incl(Type t, List<Type> ts) {
duke@1 1457 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1458 }
duke@1 1459
duke@1 1460 /** Remove type set from type set list.
duke@1 1461 */
duke@1 1462 List<Type> excl(Type t, List<Type> ts) {
duke@1 1463 if (ts.isEmpty()) {
duke@1 1464 return ts;
duke@1 1465 } else {
duke@1 1466 List<Type> ts1 = excl(t, ts.tail);
duke@1 1467 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1468 else if (ts1 == ts.tail) return ts;
duke@1 1469 else return ts1.prepend(ts.head);
duke@1 1470 }
duke@1 1471 }
duke@1 1472
duke@1 1473 /** Form the union of two type set lists.
duke@1 1474 */
duke@1 1475 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1476 List<Type> ts = ts1;
duke@1 1477 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1478 ts = incl(l.head, ts);
duke@1 1479 return ts;
duke@1 1480 }
duke@1 1481
duke@1 1482 /** Form the difference of two type lists.
duke@1 1483 */
duke@1 1484 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1485 List<Type> ts = ts1;
duke@1 1486 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1487 ts = excl(l.head, ts);
duke@1 1488 return ts;
duke@1 1489 }
duke@1 1490
duke@1 1491 /** Form the intersection of two type lists.
duke@1 1492 */
duke@1 1493 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1494 List<Type> ts = List.nil();
duke@1 1495 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1496 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1497 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1498 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1499 return ts;
duke@1 1500 }
duke@1 1501
duke@1 1502 /** Is exc an exception symbol that need not be declared?
duke@1 1503 */
duke@1 1504 boolean isUnchecked(ClassSymbol exc) {
duke@1 1505 return
duke@1 1506 exc.kind == ERR ||
duke@1 1507 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1508 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1509 }
duke@1 1510
duke@1 1511 /** Is exc an exception type that need not be declared?
duke@1 1512 */
duke@1 1513 boolean isUnchecked(Type exc) {
duke@1 1514 return
jjg@1374 1515 (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
jjg@1374 1516 (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
jjg@1374 1517 exc.hasTag(BOT);
duke@1 1518 }
duke@1 1519
duke@1 1520 /** Same, but handling completion failures.
duke@1 1521 */
duke@1 1522 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1523 try {
duke@1 1524 return isUnchecked(exc);
duke@1 1525 } catch (CompletionFailure ex) {
duke@1 1526 completionError(pos, ex);
duke@1 1527 return true;
duke@1 1528 }
duke@1 1529 }
duke@1 1530
duke@1 1531 /** Is exc handled by given exception list?
duke@1 1532 */
duke@1 1533 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1534 return isUnchecked(exc) || subset(exc, handled);
duke@1 1535 }
duke@1 1536
duke@1 1537 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1538 * @param thrown The list of thrown exceptions.
duke@1 1539 * @param handled The list of handled exceptions.
duke@1 1540 */
mcimadamore@362 1541 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1542 List<Type> unhandled = List.nil();
duke@1 1543 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1544 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1545 return unhandled;
duke@1 1546 }
duke@1 1547
duke@1 1548 /* *************************************************************************
duke@1 1549 * Overriding/Implementation checking
duke@1 1550 **************************************************************************/
duke@1 1551
duke@1 1552 /** The level of access protection given by a flag set,
duke@1 1553 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1554 */
duke@1 1555 static int protection(long flags) {
duke@1 1556 switch ((short)(flags & AccessFlags)) {
duke@1 1557 case PRIVATE: return 3;
duke@1 1558 case PROTECTED: return 1;
duke@1 1559 default:
duke@1 1560 case PUBLIC: return 0;
duke@1 1561 case 0: return 2;
duke@1 1562 }
duke@1 1563 }
duke@1 1564
duke@1 1565 /** A customized "cannot override" error message.
duke@1 1566 * @param m The overriding method.
duke@1 1567 * @param other The overridden method.
duke@1 1568 * @return An internationalized string.
duke@1 1569 */
mcimadamore@89 1570 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1571 String key;
duke@1 1572 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1573 key = "cant.override";
duke@1 1574 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1575 key = "cant.implement";
duke@1 1576 else
duke@1 1577 key = "clashes.with";
mcimadamore@89 1578 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1579 }
duke@1 1580
duke@1 1581 /** A customized "override" warning message.
duke@1 1582 * @param m The overriding method.
duke@1 1583 * @param other The overridden method.
duke@1 1584 * @return An internationalized string.
duke@1 1585 */
mcimadamore@89 1586 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1587 String key;
duke@1 1588 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1589 key = "unchecked.override";
duke@1 1590 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1591 key = "unchecked.implement";
duke@1 1592 else
duke@1 1593 key = "unchecked.clash.with";
mcimadamore@89 1594 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1595 }
duke@1 1596
duke@1 1597 /** A customized "override" warning message.
duke@1 1598 * @param m The overriding method.
duke@1 1599 * @param other The overridden method.
duke@1 1600 * @return An internationalized string.
duke@1 1601 */
mcimadamore@89 1602 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1603 String key;
duke@1 1604 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1605 key = "varargs.override";
duke@1 1606 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1607 key = "varargs.implement";
duke@1 1608 else
duke@1 1609 key = "varargs.clash.with";
mcimadamore@89 1610 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1611 }
duke@1 1612
duke@1 1613 /** Check that this method conforms with overridden method 'other'.
duke@1 1614 * where `origin' is the class where checking started.
duke@1 1615 * Complications:
duke@1 1616 * (1) Do not check overriding of synthetic methods
duke@1 1617 * (reason: they might be final).
duke@1 1618 * todo: check whether this is still necessary.
duke@1 1619 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1620 * than the method it implements. Augment the proxy methods with the
duke@1 1621 * undeclared exceptions in this case.
duke@1 1622 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1623 * has a result type
duke@1 1624 * extended by the result type of the method it implements.
duke@1 1625 * Change the proxies result type to the smaller type in this case.
duke@1 1626 *
duke@1 1627 * @param tree The tree from which positions
duke@1 1628 * are extracted for errors.
duke@1 1629 * @param m The overriding method.
duke@1 1630 * @param other The overridden method.
duke@1 1631 * @param origin The class of which the overriding method
duke@1 1632 * is a member.
duke@1 1633 */
duke@1 1634 void checkOverride(JCTree tree,
duke@1 1635 MethodSymbol m,
duke@1 1636 MethodSymbol other,
duke@1 1637 ClassSymbol origin) {
duke@1 1638 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1639 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1640 return;
duke@1 1641 }
duke@1 1642
duke@1 1643 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1644 if ((m.flags() & STATIC) != 0 &&
duke@1 1645 (other.flags() & STATIC) == 0) {
duke@1 1646 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1647 cannotOverride(m, other));
duke@1 1648 return;
duke@1 1649 }
duke@1 1650
duke@1 1651 // Error if instance method overrides static or final
duke@1 1652 // method (JLS 8.4.6.1).
duke@1 1653 if ((other.flags() & FINAL) != 0 ||
duke@1 1654 (m.flags() & STATIC) == 0 &&
duke@1 1655 (other.flags() & STATIC) != 0) {
duke@1 1656 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1657 cannotOverride(m, other),
mcimadamore@80 1658 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1659 return;
duke@1 1660 }
duke@1 1661
duke@1 1662 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1663 // handled in validateAnnotationMethod
duke@1 1664 return;
duke@1 1665 }
duke@1 1666
duke@1 1667 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1668 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1669 protection(m.flags()) > protection(other.flags())) {
duke@1 1670 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1671 cannotOverride(m, other),
mcimadamore@80 1672 other.flags() == 0 ?
mcimadamore@80 1673 Flag.PACKAGE :
mcimadamore@80 1674 asFlagSet(other.flags() & AccessFlags));
duke@1 1675 return;
duke@1 1676 }
duke@1 1677
duke@1 1678 Type mt = types.memberType(origin.type, m);
duke@1 1679 Type ot = types.memberType(origin.type, other);
duke@1 1680 // Error if overriding result type is different
duke@1 1681 // (or, in the case of generics mode, not a subtype) of
duke@1 1682 // overridden result type. We have to rename any type parameters
duke@1 1683 // before comparing types.
duke@1 1684 List<Type> mtvars = mt.getTypeArguments();
duke@1 1685 List<Type> otvars = ot.getTypeArguments();
duke@1 1686 Type mtres = mt.getReturnType();
duke@1 1687 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1688
mcimadamore@795 1689 overrideWarner.clear();
duke@1 1690 boolean resultTypesOK =
tbell@202 1691 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1692 if (!resultTypesOK) {
jjg@398 1693 if (!allowCovariantReturns &&
duke@1 1694 m.owner != origin &&
duke@1 1695 m.owner.isSubClass(other.owner, types)) {
duke@1 1696 // allow limited interoperability with covariant returns
duke@1 1697 } else {
mcimadamore@362 1698 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1699 "override.incompatible.ret",
mcimadamore@362 1700 cannotOverride(m, other),
duke@1 1701 mtres, otres);
duke@1 1702 return;
duke@1 1703 }
mcimadamore@795 1704 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1705 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1706 "override.unchecked.ret",
mcimadamore@362 1707 uncheckedOverrides(m, other),
mcimadamore@362 1708 mtres, otres);
duke@1 1709 }
duke@1 1710
duke@1 1711 // Error if overriding method throws an exception not reported
duke@1 1712 // by overridden method.
duke@1 1713 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1714 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1715 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1716 if (unhandledErased.nonEmpty()) {
duke@1 1717 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1718 "override.meth.doesnt.throw",
duke@1 1719 cannotOverride(m, other),
mcimadamore@362 1720 unhandledUnerased.head);
mcimadamore@362 1721 return;
mcimadamore@362 1722 }
mcimadamore@362 1723 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1724 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1725 "override.unchecked.thrown",
mcimadamore@362 1726 cannotOverride(m, other),
mcimadamore@362 1727 unhandledUnerased.head);
duke@1 1728 return;
duke@1 1729 }
duke@1 1730
duke@1 1731 // Optional warning if varargs don't agree
duke@1 1732 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1733 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1734 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1735 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1736 ? "override.varargs.missing"
duke@1 1737 : "override.varargs.extra",
duke@1 1738 varargsOverrides(m, other));
duke@1 1739 }
duke@1 1740
duke@1 1741 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1742 if ((other.flags() & BRIDGE) != 0) {
duke@1 1743 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1744 uncheckedOverrides(m, other));
duke@1 1745 }
duke@1 1746
duke@1 1747 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1748 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1749 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1750 }
duke@1 1751 }
duke@1 1752 // where
duke@1 1753 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1754 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1755 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1756 // because in that case, we will rediscover the issue when examining the method
duke@1 1757 // in the supertype.
duke@1 1758 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1759 // address the issue is when the method is the supertype implemementation: any other
duke@1 1760 // case, we will have dealt with when examining the supertype classes
duke@1 1761 ClassSymbol mc = m.enclClass();
duke@1 1762 Type st = types.supertype(origin.type);
jjg@1374 1763 if (!st.hasTag(CLASS))
duke@1 1764 return true;
duke@1 1765 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1766
duke@1 1767 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1768 List<Type> intfs = types.interfaces(origin.type);
duke@1 1769 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1770 }
duke@1 1771 else
duke@1 1772 return (stimpl != m);
duke@1 1773 }
duke@1 1774
duke@1 1775
duke@1 1776 // used to check if there were any unchecked conversions
duke@1 1777 Warner overrideWarner = new Warner();
duke@1 1778
duke@1 1779 /** Check that a class does not inherit two concrete methods
duke@1 1780 * with the same signature.
duke@1 1781 * @param pos Position to be used for error reporting.
duke@1 1782 * @param site The class type to be checked.
duke@1 1783 */
duke@1 1784 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1785 Type sup = types.supertype(site);
jjg@1374 1786 if (!sup.hasTag(CLASS)) return;
duke@1 1787
duke@1 1788 for (Type t1 = sup;
duke@1 1789 t1.tsym.type.isParameterized();
duke@1 1790 t1 = types.supertype(t1)) {
duke@1 1791 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1792 e1 != null;
duke@1 1793 e1 = e1.sibling) {
duke@1 1794 Symbol s1 = e1.sym;
duke@1 1795 if (s1.kind != MTH ||
duke@1 1796 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1797 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1798 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1799 types,
duke@1 1800 true) != s1)
duke@1 1801 continue;
duke@1 1802 Type st1 = types.memberType(t1, s1);
duke@1 1803 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1804 if (st1 == s1.type) continue;
duke@1 1805
duke@1 1806 for (Type t2 = sup;
jjg@1374 1807 t2.hasTag(CLASS);
duke@1 1808 t2 = types.supertype(t2)) {
mcimadamore@24 1809 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1810 e2.scope != null;
duke@1 1811 e2 = e2.next()) {
duke@1 1812 Symbol s2 = e2.sym;
duke@1 1813 if (s2 == s1 ||
duke@1 1814 s2.kind != MTH ||
duke@1 1815 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1816 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1817 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1818 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1819 types,
duke@1 1820 true) != s2)
duke@1 1821 continue;
duke@1 1822 Type st2 = types.memberType(t2, s2);
duke@1 1823 if (types.overrideEquivalent(st1, st2))
duke@1 1824 log.error(pos, "concrete.inheritance.conflict",
duke@1 1825 s1, t1, s2, t2, sup);
duke@1 1826 }
duke@1 1827 }
duke@1 1828 }
duke@1 1829 }
duke@1 1830 }
duke@1 1831
duke@1 1832 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1833 * method with same name and arguments but incompatible return types.
duke@1 1834 * @param pos Position to be used for error reporting.
duke@1 1835 * @param t1 The first argument type.
duke@1 1836 * @param t2 The second argument type.
duke@1 1837 */
duke@1 1838 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1839 Type t1,
duke@1 1840 Type t2) {
duke@1 1841 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1842 types.makeCompoundType(t1, t2));
duke@1 1843 }
duke@1 1844
duke@1 1845 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1846 Type t1,
duke@1 1847 Type t2,
duke@1 1848 Type site) {
mcimadamore@746 1849 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1850 }
duke@1 1851
duke@1 1852 /** Return the first method which is defined with same args
duke@1 1853 * but different return types in two given interfaces, or null if none
duke@1 1854 * exists.
duke@1 1855 * @param t1 The first type.
duke@1 1856 * @param t2 The second type.
duke@1 1857 * @param site The most derived type.
duke@1 1858 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1859 */
mcimadamore@746 1860 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1861 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1862 closure(t1, interfaces1);
duke@1 1863 Map<TypeSymbol,Type> interfaces2;
duke@1 1864 if (t1 == t2)
duke@1 1865 interfaces2 = interfaces1;
duke@1 1866 else
duke@1 1867 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1868
duke@1 1869 for (Type t3 : interfaces1.values()) {
duke@1 1870 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1871 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1872 if (s != null) return s;
duke@1 1873 }
duke@1 1874 }
duke@1 1875 return null;
duke@1 1876 }
duke@1 1877
duke@1 1878 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1879 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1880 if (!t.hasTag(CLASS)) return;
duke@1 1881 if (typeMap.put(t.tsym, t) == null) {
duke@1 1882 closure(types.supertype(t), typeMap);
duke@1 1883 for (Type i : types.interfaces(t))
duke@1 1884 closure(i, typeMap);
duke@1 1885 }
duke@1 1886 }
duke@1 1887
duke@1 1888 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1889 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1890 if (!t.hasTag(CLASS)) return;
duke@1 1891 if (typesSkip.get(t.tsym) != null) return;
duke@1 1892 if (typeMap.put(t.tsym, t) == null) {
duke@1 1893 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1894 for (Type i : types.interfaces(t))
duke@1 1895 closure(i, typesSkip, typeMap);
duke@1 1896 }
duke@1 1897 }
duke@1 1898
duke@1 1899 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1900 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1901 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1902 Symbol s1 = e1.sym;
duke@1 1903 Type st1 = null;
duke@1 1904 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
duke@1 1905 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1906 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1907 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1908 Symbol s2 = e2.sym;
duke@1 1909 if (s1 == s2) continue;
duke@1 1910 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
duke@1 1911 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1912 Type st2 = types.memberType(t2, s2);
duke@1 1913 if (types.overrideEquivalent(st1, st2)) {
duke@1 1914 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1915 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1916 Type rt1 = st1.getReturnType();
duke@1 1917 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1918 boolean compat =
duke@1 1919 types.isSameType(rt1, rt2) ||
jjg@1374 1920 !rt1.isPrimitiveOrVoid() &&
jjg@1374 1921 !rt2.isPrimitiveOrVoid() &&
duke@1 1922 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
mcimadamore@59 1923 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
mcimadamore@59 1924 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1925 if (!compat) {
mcimadamore@746 1926 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1927 t1, t2, s2.name +
mcimadamore@746 1928 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1929 return s2;
mcimadamore@746 1930 }
mcimadamore@889 1931 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1932 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1933 log.error(pos,
mcimadamore@746 1934 "name.clash.same.erasure.no.override",
mcimadamore@746 1935 s1, s1.location(),
mcimadamore@746 1936 s2, s2.location());
mcimadamore@746 1937 return s2;
duke@1 1938 }
duke@1 1939 }
duke@1 1940 }
duke@1 1941 return null;
duke@1 1942 }
mcimadamore@59 1943 //WHERE
mcimadamore@59 1944 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1945 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1946 Type st1 = types.memberType(site, s1);
mcimadamore@59 1947 Type st2 = types.memberType(site, s2);
mcimadamore@59 1948 closure(site, supertypes);
mcimadamore@59 1949 for (Type t : supertypes.values()) {
mcimadamore@59 1950 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1951 Symbol s3 = e.sym;
mcimadamore@59 1952 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1953 Type st3 = types.memberType(site,s3);
mcimadamore@59 1954 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1955 if (s3.owner == site.tsym) {
mcimadamore@59 1956 return true;
mcimadamore@59 1957 }
mcimadamore@59 1958 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1959 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1960 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1961 Type rt1 = st1.getReturnType();
mcimadamore@59 1962 Type rt2 = st2.getReturnType();
mcimadamore@59 1963 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1964 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1965 boolean compat =
jjg@1374 1966 !rt13.isPrimitiveOrVoid() &&
jjg@1374 1967 !rt23.isPrimitiveOrVoid() &&
mcimadamore@59 1968 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
mcimadamore@59 1969 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
mcimadamore@59 1970 if (compat)
mcimadamore@59 1971 return true;
mcimadamore@59 1972 }
mcimadamore@59 1973 }
mcimadamore@59 1974 }
mcimadamore@59 1975 return false;
mcimadamore@59 1976 }
duke@1 1977
duke@1 1978 /** Check that a given method conforms with any method it overrides.
duke@1 1979 * @param tree The tree from which positions are extracted
duke@1 1980 * for errors.
duke@1 1981 * @param m The overriding method.
duke@1 1982 */
duke@1 1983 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1984 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1985 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1986 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1987 log.error(tree.pos(), "enum.no.finalize");
duke@1 1988 return;
duke@1 1989 }
jjg@1374 1990 for (Type t = origin.type; t.hasTag(CLASS);
duke@1 1991 t = types.supertype(t)) {
mcimadamore@746 1992 if (t != origin.type) {
mcimadamore@746 1993 checkOverride(tree, t, origin, m);
mcimadamore@746 1994 }
mcimadamore@746 1995 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1996 checkOverride(tree, t2, origin, m);
duke@1 1997 }
duke@1 1998 }
duke@1 1999 }
duke@1 2000
mcimadamore@746 2001 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 2002 TypeSymbol c = site.tsym;
mcimadamore@746 2003 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 2004 while (e.scope != null) {
mcimadamore@746 2005 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 2006 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 2007 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 2008 }
mcimadamore@746 2009 }
mcimadamore@746 2010 e = e.next();
mcimadamore@746 2011 }
mcimadamore@746 2012 }
mcimadamore@746 2013
mcimadamore@746 2014 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 2015 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 2016 return (cf.accepts(s1) &&
mcimadamore@858 2017 cf.accepts(s2) &&
mcimadamore@858 2018 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 2019 }
mcimadamore@746 2020
mcimadamore@746 2021
duke@1 2022 /** Check that all abstract members of given class have definitions.
duke@1 2023 * @param pos Position to be used for error reporting.
duke@1 2024 * @param c The class.
duke@1 2025 */
duke@1 2026 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2027 try {
duke@1 2028 MethodSymbol undef = firstUndef(c, c);
duke@1 2029 if (undef != null) {
duke@1 2030 if ((c.flags() & ENUM) != 0 &&
duke@1 2031 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 2032 (c.flags() & FINAL) == 0) {
duke@1 2033 // add the ABSTRACT flag to an enum
duke@1 2034 c.flags_field |= ABSTRACT;
duke@1 2035 } else {
duke@1 2036 MethodSymbol undef1 =
duke@1 2037 new MethodSymbol(undef.flags(), undef.name,
duke@1 2038 types.memberType(c.type, undef), undef.owner);
duke@1 2039 log.error(pos, "does.not.override.abstract",
duke@1 2040 c, undef1, undef1.location());
duke@1 2041 }
duke@1 2042 }
duke@1 2043 } catch (CompletionFailure ex) {
duke@1 2044 completionError(pos, ex);
duke@1 2045 }
duke@1 2046 }
duke@1 2047 //where
duke@1 2048 /** Return first abstract member of class `c' that is not defined
duke@1 2049 * in `impl', null if there is none.
duke@1 2050 */
duke@1 2051 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 2052 MethodSymbol undef = null;
duke@1 2053 // Do not bother to search in classes that are not abstract,
duke@1 2054 // since they cannot have abstract members.
duke@1 2055 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 2056 Scope s = c.members();
duke@1 2057 for (Scope.Entry e = s.elems;
duke@1 2058 undef == null && e != null;
duke@1 2059 e = e.sibling) {
duke@1 2060 if (e.sym.kind == MTH &&
mcimadamore@1393 2061 (e.sym.flags() & (ABSTRACT|IPROXY|DEFAULT)) == ABSTRACT) {
duke@1 2062 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2063 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
mcimadamore@1393 2064 if (implmeth == null || implmeth == absmeth) {
mcimadamore@1393 2065 //look for default implementations
mcimadamore@1393 2066 if (allowDefaultMethods) {
mcimadamore@1393 2067 MethodSymbol prov = types.interfaceCandidates(impl.type, absmeth).head;
mcimadamore@1393 2068 if (prov != null && prov.overrides(absmeth, impl, types, true)) {
mcimadamore@1393 2069 implmeth = prov;
mcimadamore@1393 2070 }
mcimadamore@1393 2071 }
mcimadamore@1393 2072 }
mcimadamore@1393 2073 if (implmeth == null || implmeth == absmeth) {
duke@1 2074 undef = absmeth;
mcimadamore@1393 2075 }
duke@1 2076 }
duke@1 2077 }
duke@1 2078 if (undef == null) {
duke@1 2079 Type st = types.supertype(c.type);
jjg@1374 2080 if (st.hasTag(CLASS))
duke@1 2081 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 2082 }
duke@1 2083 for (List<Type> l = types.interfaces(c.type);
duke@1 2084 undef == null && l.nonEmpty();
duke@1 2085 l = l.tail) {
duke@1 2086 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 2087 }
duke@1 2088 }
duke@1 2089 return undef;
duke@1 2090 }
duke@1 2091
mcimadamore@690 2092 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 2093 CycleChecker cc = new CycleChecker();
mcimadamore@690 2094 cc.scan(tree);
mcimadamore@690 2095 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 2096 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 2097 }
mcimadamore@690 2098 }
mcimadamore@690 2099
mcimadamore@690 2100 class CycleChecker extends TreeScanner {
mcimadamore@690 2101
mcimadamore@690 2102 List<Symbol> seenClasses = List.nil();
mcimadamore@690 2103 boolean errorFound = false;
mcimadamore@690 2104 boolean partialCheck = false;
mcimadamore@690 2105
mcimadamore@690 2106 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 2107 if (sym != null && sym.kind == TYP) {
mcimadamore@690 2108 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 2109 if (classEnv != null) {
mcimadamore@690 2110 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2111 try {
mcimadamore@690 2112 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2113 scan(classEnv.tree);
mcimadamore@690 2114 }
mcimadamore@690 2115 finally {
mcimadamore@690 2116 log.useSource(prevSource.getFile());
mcimadamore@690 2117 }
mcimadamore@690 2118 } else if (sym.kind == TYP) {
mcimadamore@690 2119 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2120 }
mcimadamore@690 2121 } else {
mcimadamore@690 2122 //not completed yet
mcimadamore@690 2123 partialCheck = true;
mcimadamore@690 2124 }
mcimadamore@690 2125 }
mcimadamore@690 2126
mcimadamore@690 2127 @Override
mcimadamore@690 2128 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2129 super.visitSelect(tree);
mcimadamore@690 2130 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2131 }
mcimadamore@690 2132
mcimadamore@690 2133 @Override
mcimadamore@690 2134 public void visitIdent(JCIdent tree) {
mcimadamore@690 2135 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2136 }
mcimadamore@690 2137
mcimadamore@690 2138 @Override
mcimadamore@690 2139 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2140 scan(tree.clazz);
mcimadamore@690 2141 }
mcimadamore@690 2142
mcimadamore@690 2143 @Override
mcimadamore@690 2144 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2145 scan(tree.elemtype);
mcimadamore@690 2146 }
mcimadamore@690 2147
mcimadamore@690 2148 @Override
mcimadamore@690 2149 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2150 List<JCTree> supertypes = List.nil();
mcimadamore@690 2151 if (tree.getExtendsClause() != null) {
mcimadamore@690 2152 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2153 }
mcimadamore@690 2154 if (tree.getImplementsClause() != null) {
mcimadamore@690 2155 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2156 supertypes = supertypes.prepend(intf);
mcimadamore@690 2157 }
mcimadamore@690 2158 }
mcimadamore@690 2159 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2160 }
mcimadamore@690 2161
mcimadamore@690 2162 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2163 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2164 return;
mcimadamore@690 2165 if (seenClasses.contains(c)) {
mcimadamore@690 2166 errorFound = true;
mcimadamore@690 2167 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2168 } else if (!c.type.isErroneous()) {
mcimadamore@690 2169 try {
mcimadamore@690 2170 seenClasses = seenClasses.prepend(c);
jjg@1374 2171 if (c.type.hasTag(CLASS)) {
mcimadamore@690 2172 if (supertypes.nonEmpty()) {
mcimadamore@690 2173 scan(supertypes);
mcimadamore@690 2174 }
mcimadamore@690 2175 else {
mcimadamore@690 2176 ClassType ct = (ClassType)c.type;
mcimadamore@690 2177 if (ct.supertype_field == null ||
mcimadamore@690 2178 ct.interfaces_field == null) {
mcimadamore@690 2179 //not completed yet
mcimadamore@690 2180 partialCheck = true;
mcimadamore@690 2181 return;
mcimadamore@690 2182 }
mcimadamore@690 2183 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2184 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2185 checkSymbol(pos, intf.tsym);
mcimadamore@690 2186 }
mcimadamore@690 2187 }
mcimadamore@690 2188 if (c.owner.kind == TYP) {
mcimadamore@690 2189 checkSymbol(pos, c.owner);
mcimadamore@690 2190 }
mcimadamore@690 2191 }
mcimadamore@690 2192 } finally {
mcimadamore@690 2193 seenClasses = seenClasses.tail;
mcimadamore@690 2194 }
mcimadamore@690 2195 }
mcimadamore@690 2196 }
mcimadamore@690 2197 }
mcimadamore@690 2198
duke@1 2199 /** Check for cyclic references. Issue an error if the
duke@1 2200 * symbol of the type referred to has a LOCKED flag set.
duke@1 2201 *
duke@1 2202 * @param pos Position to be used for error reporting.
duke@1 2203 * @param t The type referred to.
duke@1 2204 */
duke@1 2205 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2206 checkNonCyclicInternal(pos, t);
duke@1 2207 }
duke@1 2208
duke@1 2209
duke@1 2210 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2211 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2212 }
duke@1 2213
mcimadamore@236 2214 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2215 final TypeVar tv;
jjg@1374 2216 if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2217 return;
duke@1 2218 if (seen.contains(t)) {
duke@1 2219 tv = (TypeVar)t;
jjg@110 2220 tv.bound = types.createErrorType(t);
duke@1 2221 log.error(pos, "cyclic.inheritance", t);
jjg@1374 2222 } else if (t.hasTag(TYPEVAR)) {
duke@1 2223 tv = (TypeVar)t;
mcimadamore@236 2224 seen = seen.prepend(tv);
duke@1 2225 for (Type b : types.getBounds(tv))
duke@1 2226 checkNonCyclic1(pos, b, seen);
duke@1 2227 }
duke@1 2228 }
duke@1 2229
duke@1 2230 /** Check for cyclic references. Issue an error if the
duke@1 2231 * symbol of the type referred to has a LOCKED flag set.
duke@1 2232 *
duke@1 2233 * @param pos Position to be used for error reporting.
duke@1 2234 * @param t The type referred to.
duke@1 2235 * @returns True if the check completed on all attributed classes
duke@1 2236 */
duke@1 2237 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2238 boolean complete = true; // was the check complete?
duke@1 2239 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2240 Symbol c = t.tsym;
duke@1 2241 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2242
duke@1 2243 if ((c.flags_field & LOCKED) != 0) {
duke@1 2244 noteCyclic(pos, (ClassSymbol)c);
duke@1 2245 } else if (!c.type.isErroneous()) {
duke@1 2246 try {
duke@1 2247 c.flags_field |= LOCKED;
jjg@1374 2248 if (c.type.hasTag(CLASS)) {
duke@1 2249 ClassType clazz = (ClassType)c.type;
duke@1 2250 if (clazz.interfaces_field != null)
duke@1 2251 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2252 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2253 if (clazz.supertype_field != null) {
duke@1 2254 Type st = clazz.supertype_field;
jjg@1374 2255 if (st != null && st.hasTag(CLASS))
duke@1 2256 complete &= checkNonCyclicInternal(pos, st);
duke@1 2257 }
duke@1 2258 if (c.owner.kind == TYP)
duke@1 2259 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2260 }
duke@1 2261 } finally {
duke@1 2262 c.flags_field &= ~LOCKED;
duke@1 2263 }
duke@1 2264 }
duke@1 2265 if (complete)
duke@1 2266 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2267 if (complete) c.flags_field |= ACYCLIC;
duke@1 2268 return complete;
duke@1 2269 }
duke@1 2270
duke@1 2271 /** Note that we found an inheritance cycle. */
duke@1 2272 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2273 log.error(pos, "cyclic.inheritance", c);
duke@1 2274 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2275 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2276 Type st = types.supertype(c.type);
jjg@1374 2277 if (st.hasTag(CLASS))
jjg@110 2278 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2279 c.type = types.createErrorType(c, c.type);
duke@1 2280 c.flags_field |= ACYCLIC;
duke@1 2281 }
duke@1 2282
duke@1 2283 /** Check that all methods which implement some
duke@1 2284 * method conform to the method they implement.
duke@1 2285 * @param tree The class definition whose members are checked.
duke@1 2286 */
duke@1 2287 void checkImplementations(JCClassDecl tree) {
duke@1 2288 checkImplementations(tree, tree.sym);
duke@1 2289 }
duke@1 2290 //where
duke@1 2291 /** Check that all methods which implement some
duke@1 2292 * method in `ic' conform to the method they implement.
duke@1 2293 */
duke@1 2294 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
duke@1 2295 ClassSymbol origin = tree.sym;
duke@1 2296 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2297 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2298 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2299 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2300 if (e.sym.kind == MTH &&
duke@1 2301 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2302 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2303 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2304 if (implmeth != null && implmeth != absmeth &&
duke@1 2305 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2306 (origin.flags() & INTERFACE)) {
duke@1 2307 // don't check if implmeth is in a class, yet
duke@1 2308 // origin is an interface. This case arises only
duke@1 2309 // if implmeth is declared in Object. The reason is
duke@1 2310 // that interfaces really don't inherit from
duke@1 2311 // Object it's just that the compiler represents
duke@1 2312 // things that way.
duke@1 2313 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2314 }
duke@1 2315 }
duke@1 2316 }
duke@1 2317 }
duke@1 2318 }
duke@1 2319 }
duke@1 2320
duke@1 2321 /** Check that all abstract methods implemented by a class are
duke@1 2322 * mutually compatible.
duke@1 2323 * @param pos Position to be used for error reporting.
duke@1 2324 * @param c The class whose interfaces are checked.
duke@1 2325 */
duke@1 2326 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2327 List<Type> supertypes = types.interfaces(c);
duke@1 2328 Type supertype = types.supertype(c);
jjg@1374 2329 if (supertype.hasTag(CLASS) &&
duke@1 2330 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2331 supertypes = supertypes.prepend(supertype);
duke@1 2332 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2333 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2334 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2335 return;
duke@1 2336 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2337 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2338 return;
duke@1 2339 }
duke@1 2340 checkCompatibleConcretes(pos, c);
duke@1 2341 }
duke@1 2342
mcimadamore@359 2343 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2344 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2345 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2346 // VM allows methods and variables with differing types
mcimadamore@359 2347 if (sym.kind == e.sym.kind &&
mcimadamore@359 2348 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2349 sym != e.sym &&
mcimadamore@359 2350 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2351 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2352 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2353 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2354 return;
mcimadamore@359 2355 }
mcimadamore@359 2356 }
mcimadamore@359 2357 }
mcimadamore@359 2358 }
mcimadamore@359 2359
mcimadamore@780 2360 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2361 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2362 *
mcimadamore@780 2363 * @param pos Position to be used for error reporting.
mcimadamore@780 2364 * @param site The class whose methods are checked.
mcimadamore@780 2365 * @param sym The method symbol to be checked.
mcimadamore@780 2366 */
mcimadamore@858 2367 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2368 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2369 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2370 //by method 'sym' in 'site'...
mcimadamore@1198 2371 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2372 if (!sym.overrides(m1, site.tsym, types, false)) continue;
mcimadamore@1198 2373 //...check each method m2 that is a member of 'site'
mcimadamore@1198 2374 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2375 if (m2 == m1) continue;
mcimadamore@858 2376 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2377 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1393 2378 if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) &&
mcimadamore@1198 2379 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2380 sym.flags_field |= CLASH;
mcimadamore@1198 2381 String key = m1 == sym ?
mcimadamore@858 2382 "name.clash.same.erasure.no.override" :
mcimadamore@858 2383 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2384 log.error(pos,
mcimadamore@858 2385 key,
mcimadamore@858 2386 sym, sym.location(),
mcimadamore@1198 2387 m2, m2.location(),
mcimadamore@1198 2388 m1, m1.location());
mcimadamore@858 2389 return;
mcimadamore@858 2390 }
mcimadamore@780 2391 }
mcimadamore@780 2392 }
mcimadamore@780 2393 }
mcimadamore@780 2394
mcimadamore@877 2395
mcimadamore@877 2396
mcimadamore@858 2397 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2398 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2399 *
mcimadamore@858 2400 * @param pos Position to be used for error reporting.
mcimadamore@858 2401 * @param site The class whose methods are checked.
mcimadamore@858 2402 * @param sym The method symbol to be checked.
mcimadamore@780 2403 */
mcimadamore@858 2404 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2405 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2406 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2407 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2408 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2409 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@1393 2410 if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck) &&
mcimadamore@877 2411 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2412 log.error(pos,
mcimadamore@858 2413 "name.clash.same.erasure.no.hide",
mcimadamore@858 2414 sym, sym.location(),
mcimadamore@877 2415 s, s.location());
mcimadamore@858 2416 return;
mcimadamore@858 2417 }
mcimadamore@858 2418 }
mcimadamore@858 2419 }
mcimadamore@780 2420
mcimadamore@858 2421 //where
mcimadamore@858 2422 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2423
mcimadamore@858 2424 Type site;
mcimadamore@780 2425
mcimadamore@858 2426 ClashFilter(Type site) {
mcimadamore@858 2427 this.site = site;
mcimadamore@858 2428 }
mcimadamore@858 2429
mcimadamore@858 2430 boolean shouldSkip(Symbol s) {
mcimadamore@858 2431 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2432 s.owner == site.tsym;
mcimadamore@858 2433 }
mcimadamore@858 2434
mcimadamore@858 2435 public boolean accepts(Symbol s) {
mcimadamore@858 2436 return s.kind == MTH &&
mcimadamore@858 2437 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2438 !shouldSkip(s) &&
mcimadamore@858 2439 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2440 !s.isConstructor();
mcimadamore@858 2441 }
mcimadamore@858 2442 }
mcimadamore@780 2443
mcimadamore@1393 2444 void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) {
mcimadamore@1393 2445 DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site);
mcimadamore@1393 2446 for (Symbol m : types.membersClosure(site, false).getElements(dcf)) {
mcimadamore@1393 2447 Assert.check(m.kind == MTH);
mcimadamore@1393 2448 List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m);
mcimadamore@1393 2449 if (prov.size() > 1) {
mcimadamore@1393 2450 ListBuffer<Symbol> abstracts = ListBuffer.lb();
mcimadamore@1393 2451 ListBuffer<Symbol> defaults = ListBuffer.lb();
mcimadamore@1393 2452 for (MethodSymbol provSym : prov) {
mcimadamore@1393 2453 if ((provSym.flags() & DEFAULT) != 0) {
mcimadamore@1393 2454 defaults = defaults.append(provSym);
mcimadamore@1393 2455 } else if ((provSym.flags() & ABSTRACT) != 0) {
mcimadamore@1393 2456 abstracts = abstracts.append(provSym);
mcimadamore@1393 2457 }
mcimadamore@1393 2458 if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) {
mcimadamore@1393 2459 //strong semantics - issue an error if two sibling interfaces
mcimadamore@1393 2460 //have two override-equivalent defaults - or if one is abstract
mcimadamore@1393 2461 //and the other is default
mcimadamore@1393 2462 String errKey;
mcimadamore@1393 2463 Symbol s1 = defaults.first();
mcimadamore@1393 2464 Symbol s2;
mcimadamore@1393 2465 if (defaults.size() > 1) {
mcimadamore@1393 2466 errKey = "types.incompatible.unrelated.defaults";
mcimadamore@1393 2467 s2 = defaults.toList().tail.head;
mcimadamore@1393 2468 } else {
mcimadamore@1393 2469 errKey = "types.incompatible.abstract.default";
mcimadamore@1393 2470 s2 = abstracts.first();
mcimadamore@1393 2471 }
mcimadamore@1393 2472 log.error(pos, errKey,
mcimadamore@1393 2473 Kinds.kindName(site.tsym), site,
mcimadamore@1393 2474 m.name, types.memberType(site, m).getParameterTypes(),
mcimadamore@1393 2475 s1.location(), s2.location());
mcimadamore@1393 2476 break;
mcimadamore@1393 2477 }
mcimadamore@1393 2478 }
mcimadamore@1393 2479 }
mcimadamore@1393 2480 }
mcimadamore@1393 2481 }
mcimadamore@1393 2482
mcimadamore@1393 2483 //where
mcimadamore@1393 2484 private class DefaultMethodClashFilter implements Filter<Symbol> {
mcimadamore@1393 2485
mcimadamore@1393 2486 Type site;
mcimadamore@1393 2487
mcimadamore@1393 2488 DefaultMethodClashFilter(Type site) {
mcimadamore@1393 2489 this.site = site;
mcimadamore@1393 2490 }
mcimadamore@1393 2491
mcimadamore@1393 2492 public boolean accepts(Symbol s) {
mcimadamore@1393 2493 return s.kind == MTH &&
mcimadamore@1393 2494 (s.flags() & DEFAULT) != 0 &&
mcimadamore@1393 2495 s.isInheritedIn(site.tsym, types) &&
mcimadamore@1393 2496 !s.isConstructor();
mcimadamore@1393 2497 }
mcimadamore@1393 2498 }
mcimadamore@1393 2499
mcimadamore@359 2500 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2501 */
mcimadamore@359 2502 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2503 if (!sym.type.isErroneous()) {
mcimadamore@359 2504 if (warnOnSyntheticConflicts) {
mcimadamore@359 2505 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2506 }
mcimadamore@359 2507 else {
mcimadamore@359 2508 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2509 }
mcimadamore@359 2510 }
mcimadamore@359 2511 }
mcimadamore@359 2512
duke@1 2513 /** Check that class c does not implement directly or indirectly
duke@1 2514 * the same parameterized interface with two different argument lists.
duke@1 2515 * @param pos Position to be used for error reporting.
duke@1 2516 * @param type The type whose interfaces are checked.
duke@1 2517 */
duke@1 2518 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2519 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2520 }
duke@1 2521 //where
duke@1 2522 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2523 * with their class symbol as key and their type as value. Make
duke@1 2524 * sure no class is entered with two different types.
duke@1 2525 */
duke@1 2526 void checkClassBounds(DiagnosticPosition pos,
duke@1 2527 Map<TypeSymbol,Type> seensofar,
duke@1 2528 Type type) {
duke@1 2529 if (type.isErroneous()) return;
duke@1 2530 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2531 Type it = l.head;
duke@1 2532 Type oldit = seensofar.put(it.tsym, it);
duke@1 2533 if (oldit != null) {
duke@1 2534 List<Type> oldparams = oldit.allparams();
duke@1 2535 List<Type> newparams = it.allparams();
duke@1 2536 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2537 log.error(pos, "cant.inherit.diff.arg",
duke@1 2538 it.tsym, Type.toString(oldparams),
duke@1 2539 Type.toString(newparams));
duke@1 2540 }
duke@1 2541 checkClassBounds(pos, seensofar, it);
duke@1 2542 }
duke@1 2543 Type st = types.supertype(type);
duke@1 2544 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2545 }
duke@1 2546
duke@1 2547 /** Enter interface into into set.
duke@1 2548 * If it existed already, issue a "repeated interface" error.
duke@1 2549 */
duke@1 2550 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2551 if (its.contains(it))
duke@1 2552 log.error(pos, "repeated.interface");
duke@1 2553 else {
duke@1 2554 its.add(it);
duke@1 2555 }
duke@1 2556 }
duke@1 2557
duke@1 2558 /* *************************************************************************
duke@1 2559 * Check annotations
duke@1 2560 **************************************************************************/
duke@1 2561
mcimadamore@629 2562 /**
mcimadamore@634 2563 * Recursively validate annotations values
mcimadamore@629 2564 */
mcimadamore@634 2565 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2566 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2567 @Override
mcimadamore@629 2568 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2569 if (!tree.type.isErroneous()) {
jjg@1017 2570 super.visitAnnotation(tree);
jjg@1017 2571 validateAnnotation(tree);
jjg@1017 2572 }
mcimadamore@629 2573 }
mcimadamore@629 2574 }
mcimadamore@634 2575 tree.accept(new AnnotationValidator());
mcimadamore@629 2576 }
mcimadamore@629 2577
jjg@1326 2578 /**
jjg@1326 2579 * {@literal
jjg@1326 2580 * Annotation types are restricted to primitives, String, an
duke@1 2581 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2582 * Anything>, arrays of the preceding.
jjg@1326 2583 * }
duke@1 2584 */
duke@1 2585 void validateAnnotationType(JCTree restype) {
duke@1 2586 // restype may be null if an error occurred, so don't bother validating it
duke@1 2587 if (restype != null) {
duke@1 2588 validateAnnotationType(restype.pos(), restype.type);
duke@1 2589 }
duke@1 2590 }
duke@1 2591
duke@1 2592 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2593 if (type.isPrimitive()) return;
duke@1 2594 if (types.isSameType(type, syms.stringType)) return;
duke@1 2595 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2596 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2597 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2598 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2599 validateAnnotationType(pos, types.elemtype(type));
duke@1 2600 return;
duke@1 2601 }
duke@1 2602 log.error(pos, "invalid.annotation.member.type");
duke@1 2603 }
duke@1 2604
duke@1 2605 /**
duke@1 2606 * "It is also a compile-time error if any method declared in an
duke@1 2607 * annotation type has a signature that is override-equivalent to
duke@1 2608 * that of any public or protected method declared in class Object
duke@1 2609 * or in the interface annotation.Annotation."
duke@1 2610 *
jjh@972 2611 * @jls 9.6 Annotation Types
duke@1 2612 */
duke@1 2613 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
jjg@1374 2614 for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
duke@1 2615 Scope s = sup.tsym.members();
duke@1 2616 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2617 if (e.sym.kind == MTH &&
duke@1 2618 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2619 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2620 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2621 }
duke@1 2622 }
duke@1 2623 }
duke@1 2624
duke@1 2625 /** Check the annotations of a symbol.
duke@1 2626 */
duke@1 2627 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2628 for (JCAnnotation a : annotations)
duke@1 2629 validateAnnotation(a, s);
duke@1 2630 }
duke@1 2631
duke@1 2632 /** Check an annotation of a symbol.
duke@1 2633 */
jfranck@1313 2634 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2635 validateAnnotationTree(a);
duke@1 2636
duke@1 2637 if (!annotationApplicable(a, s))
duke@1 2638 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2639
duke@1 2640 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2641 if (!isOverrider(s))
duke@1 2642 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2643 }
duke@1 2644 }
duke@1 2645
jfranck@1313 2646 /**
jfranck@1313 2647 * Validate the proposed container 'containedBy' on the
jfranck@1313 2648 * annotation type symbol 's'. Report errors at position
jfranck@1313 2649 * 'pos'.
jfranck@1313 2650 *
jfranck@1313 2651 * @param s The (annotation)type declaration annotated with a @ContainedBy
jjg@1358 2652 * @param containedBy the @ContainedBy on 's'
jfranck@1313 2653 * @param pos where to report errors
jfranck@1313 2654 */
jfranck@1313 2655 public void validateContainedBy(TypeSymbol s, Attribute.Compound containedBy, DiagnosticPosition pos) {
jfranck@1313 2656 Assert.check(types.isSameType(containedBy.type, syms.containedByType));
jfranck@1313 2657
jfranck@1313 2658 Type t = null;
jfranck@1313 2659 List<Pair<MethodSymbol,Attribute>> l = containedBy.values;
jfranck@1313 2660 if (!l.isEmpty()) {
jfranck@1313 2661 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2662 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2663 }
jfranck@1313 2664
jfranck@1313 2665 if (t == null) {
jfranck@1313 2666 log.error(pos, "invalid.container.wrong.containedby", s, containedBy);
jfranck@1313 2667 return;
jfranck@1313 2668 }
jfranck@1313 2669
jfranck@1313 2670 validateHasContainerFor(t.tsym, s, pos);
jfranck@1313 2671 validateRetention(t.tsym, s, pos);
jfranck@1313 2672 validateDocumented(t.tsym, s, pos);
jfranck@1313 2673 validateInherited(t.tsym, s, pos);
jfranck@1313 2674 validateTarget(t.tsym, s, pos);
jfranck@1344 2675 validateDefault(t.tsym, s, pos);
jfranck@1313 2676 }
jfranck@1313 2677
jfranck@1313 2678 /**
jfranck@1313 2679 * Validate the proposed container 'containerFor' on the
jfranck@1313 2680 * annotation type symbol 's'. Report errors at position
jfranck@1313 2681 * 'pos'.
jfranck@1313 2682 *
jfranck@1313 2683 * @param s The (annotation)type declaration annotated with a @ContainerFor
jfranck@1313 2684 * @param containerFor the @ContainedFor on 's'
jfranck@1313 2685 * @param pos where to report errors
jfranck@1313 2686 */
jfranck@1313 2687 public void validateContainerFor(TypeSymbol s, Attribute.Compound containerFor, DiagnosticPosition pos) {
jfranck@1313 2688 Assert.check(types.isSameType(containerFor.type, syms.containerForType));
jfranck@1313 2689
jfranck@1313 2690 Type t = null;
jfranck@1313 2691 List<Pair<MethodSymbol,Attribute>> l = containerFor.values;
jfranck@1313 2692 if (!l.isEmpty()) {
jfranck@1313 2693 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2694 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2695 }
jfranck@1313 2696
jfranck@1313 2697 if (t == null) {
jfranck@1313 2698 log.error(pos, "invalid.container.wrong.containerfor", s, containerFor);
jfranck@1313 2699 return;
jfranck@1313 2700 }
jfranck@1313 2701
jfranck@1313 2702 validateHasContainedBy(t.tsym, s, pos);
jfranck@1313 2703 }
jfranck@1313 2704
jfranck@1313 2705 private void validateHasContainedBy(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jfranck@1313 2706 Attribute.Compound containedBy = container.attribute(syms.containedByType.tsym);
jfranck@1313 2707
jfranck@1313 2708 if (containedBy == null) {
jfranck@1313 2709 log.error(pos, "invalid.container.no.containedby", container, syms.containedByType.tsym);
jfranck@1313 2710 return;
jfranck@1313 2711 }
jfranck@1313 2712
jfranck@1313 2713 Type t = null;
jfranck@1313 2714 List<Pair<MethodSymbol,Attribute>> l = containedBy.values;
jfranck@1313 2715 if (!l.isEmpty()) {
jfranck@1313 2716 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2717 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2718 }
jfranck@1313 2719
jfranck@1313 2720 if (t == null) {
jfranck@1313 2721 log.error(pos, "invalid.container.wrong.containedby", container, contained);
jfranck@1313 2722 return;
jfranck@1313 2723 }
jfranck@1313 2724
jfranck@1313 2725 if (!types.isSameType(t, contained.type))
jfranck@1313 2726 log.error(pos, "invalid.container.wrong.containedby", t.tsym, contained);
jfranck@1313 2727 }
jfranck@1313 2728
jfranck@1313 2729 private void validateHasContainerFor(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jfranck@1313 2730 Attribute.Compound containerFor = container.attribute(syms.containerForType.tsym);
jfranck@1313 2731
jfranck@1313 2732 if (containerFor == null) {
jfranck@1313 2733 log.error(pos, "invalid.container.no.containerfor", container, syms.containerForType.tsym);
jfranck@1313 2734 return;
jfranck@1313 2735 }
jfranck@1313 2736
jfranck@1313 2737 Type t = null;
jfranck@1313 2738 List<Pair<MethodSymbol,Attribute>> l = containerFor.values;
jfranck@1313 2739 if (!l.isEmpty()) {
jfranck@1313 2740 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2741 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2742 }
jfranck@1313 2743
jfranck@1313 2744 if (t == null) {
jfranck@1313 2745 log.error(pos, "invalid.container.wrong.containerfor", container, contained);
jfranck@1313 2746 return;
jfranck@1313 2747 }
jfranck@1313 2748
jfranck@1313 2749 if (!types.isSameType(t, contained.type))
jfranck@1313 2750 log.error(pos, "invalid.container.wrong.containerfor", t.tsym, contained);
jfranck@1313 2751 }
jfranck@1313 2752
jfranck@1313 2753 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2754 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2755 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2756
jfranck@1313 2757 boolean error = false;
jfranck@1313 2758 switch (containedRetention) {
jfranck@1313 2759 case RUNTIME:
jfranck@1313 2760 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2761 error = true;
jfranck@1313 2762 }
jfranck@1313 2763 break;
jfranck@1313 2764 case CLASS:
jfranck@1313 2765 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2766 error = true;
jfranck@1313 2767 }
jfranck@1313 2768 }
jfranck@1313 2769 if (error ) {
jfranck@1313 2770 log.error(pos, "invalid.containedby.annotation.retention",
jfranck@1313 2771 container, containerRetention,
jfranck@1313 2772 contained, containedRetention);
jfranck@1313 2773 }
jfranck@1313 2774 }
jfranck@1313 2775
jfranck@1313 2776 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2777 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2778 if (container.attribute(syms.documentedType.tsym) == null) {
jfranck@1313 2779 log.error(pos, "invalid.containedby.annotation.not.documented", container, contained);
jfranck@1313 2780 }
jfranck@1313 2781 }
jfranck@1313 2782 }
jfranck@1313 2783
jfranck@1313 2784 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2785 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2786 if (container.attribute(syms.inheritedType.tsym) == null) {
jfranck@1313 2787 log.error(pos, "invalid.containedby.annotation.not.inherited", container, contained);
jfranck@1313 2788 }
jfranck@1313 2789 }
jfranck@1313 2790 }
jfranck@1313 2791
jfranck@1313 2792 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2793 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1313 2794
jfranck@1313 2795 // If contained has no Target, we are done
jfranck@1313 2796 if (containedTarget == null) {
jfranck@1313 2797 return;
jfranck@1313 2798 }
jfranck@1313 2799
jfranck@1313 2800 // If contained has Target m1, container must have a Target
jfranck@1313 2801 // annotation, m2, and m2 must be a subset of m1. (This is
jfranck@1313 2802 // trivially true if contained has no target as per above).
jfranck@1313 2803
jfranck@1313 2804 // contained has target, but container has not, error
jfranck@1313 2805 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2806 if (containerTarget == null) {
jfranck@1313 2807 log.error(pos, "invalid.containedby.annotation.incompatible.target", container, contained);
jfranck@1313 2808 return;
jfranck@1313 2809 }
jfranck@1313 2810
jfranck@1313 2811 Set<Name> containerTargets = new HashSet<Name>();
jfranck@1313 2812 for (Attribute app : containerTarget.values) {
jfranck@1313 2813 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2814 continue; // recovery
jfranck@1313 2815 }
jfranck@1313 2816 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2817 containerTargets.add(e.value.name);
jfranck@1313 2818 }
jfranck@1313 2819
jfranck@1313 2820 Set<Name> containedTargets = new HashSet<Name>();
jfranck@1313 2821 for (Attribute app : containedTarget.values) {
jfranck@1313 2822 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2823 continue; // recovery
jfranck@1313 2824 }
jfranck@1313 2825 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2826 containedTargets.add(e.value.name);
jfranck@1313 2827 }
jfranck@1313 2828
jfranck@1313 2829 if (!isTargetSubset(containedTargets, containerTargets)) {
jfranck@1313 2830 log.error(pos, "invalid.containedby.annotation.incompatible.target", container, contained);
jfranck@1313 2831 }
jfranck@1313 2832 }
jfranck@1313 2833
jfranck@1313 2834 /** Checks that t is a subset of s, with respect to ElementType
jfranck@1313 2835 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE}
jfranck@1313 2836 */
jfranck@1313 2837 private boolean isTargetSubset(Set<Name> s, Set<Name> t) {
jfranck@1313 2838 // Check that all elements in t are present in s
jfranck@1313 2839 for (Name n2 : t) {
jfranck@1313 2840 boolean currentElementOk = false;
jfranck@1313 2841 for (Name n1 : s) {
jfranck@1313 2842 if (n1 == n2) {
jfranck@1313 2843 currentElementOk = true;
jfranck@1313 2844 break;
jfranck@1313 2845 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2846 currentElementOk = true;
jfranck@1313 2847 break;
jfranck@1313 2848 }
jfranck@1313 2849 }
jfranck@1313 2850 if (!currentElementOk)
jfranck@1313 2851 return false;
jfranck@1313 2852 }
jfranck@1313 2853 return true;
jfranck@1313 2854 }
jfranck@1313 2855
jfranck@1344 2856 private void validateDefault(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1344 2857 // validate that all other elements of containing type has defaults
jfranck@1344 2858 Scope scope = container.members();
jfranck@1344 2859 for(Symbol elm : scope.getElements()) {
jfranck@1344 2860 if (elm.name != names.value &&
jfranck@1344 2861 elm.kind == Kinds.MTH &&
jfranck@1344 2862 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2863 log.error(pos,
jfranck@1344 2864 "invalid.containedby.annotation.elem.nondefault",
jfranck@1344 2865 container,
jfranck@1344 2866 elm);
jfranck@1344 2867 }
jfranck@1344 2868 }
jfranck@1344 2869 }
jfranck@1344 2870
duke@1 2871 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2872 boolean isOverrider(Symbol s) {
duke@1 2873 if (s.kind != MTH || s.isStatic())
duke@1 2874 return false;
duke@1 2875 MethodSymbol m = (MethodSymbol)s;
duke@1 2876 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2877 for (Type sup : types.closure(owner.type)) {
duke@1 2878 if (sup == owner.type)
duke@1 2879 continue; // skip "this"
duke@1 2880 Scope scope = sup.tsym.members();
duke@1 2881 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2882 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2883 return true;
duke@1 2884 }
duke@1 2885 }
duke@1 2886 return false;
duke@1 2887 }
duke@1 2888
duke@1 2889 /** Is the annotation applicable to the symbol? */
duke@1 2890 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 2891 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jfranck@1313 2892 if (arr == null) {
jfranck@1313 2893 return true;
jfranck@1313 2894 }
duke@1 2895 for (Attribute app : arr.values) {
duke@1 2896 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2897 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2898 if (e.value.name == names.TYPE)
duke@1 2899 { if (s.kind == TYP) return true; }
duke@1 2900 else if (e.value.name == names.FIELD)
duke@1 2901 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2902 else if (e.value.name == names.METHOD)
duke@1 2903 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2904 else if (e.value.name == names.PARAMETER)
duke@1 2905 { if (s.kind == VAR &&
duke@1 2906 s.owner.kind == MTH &&
duke@1 2907 (s.flags() & PARAMETER) != 0)
duke@1 2908 return true;
duke@1 2909 }
duke@1 2910 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2911 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2912 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2913 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2914 (s.flags() & PARAMETER) == 0)
duke@1 2915 return true;
duke@1 2916 }
duke@1 2917 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2918 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2919 return true;
duke@1 2920 }
duke@1 2921 else if (e.value.name == names.PACKAGE)
duke@1 2922 { if (s.kind == PCK) return true; }
jjg@308 2923 else if (e.value.name == names.TYPE_USE)
jjg@308 2924 { if (s.kind == TYP ||
jjg@308 2925 s.kind == VAR ||
jjg@308 2926 (s.kind == MTH && !s.isConstructor() &&
jjg@1374 2927 !s.type.getReturnType().hasTag(VOID)))
jjg@308 2928 return true;
jjg@308 2929 }
duke@1 2930 else
duke@1 2931 return true; // recovery
duke@1 2932 }
duke@1 2933 return false;
duke@1 2934 }
duke@1 2935
jfranck@1313 2936
jfranck@1313 2937 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 2938 Attribute.Compound atTarget =
jfranck@1313 2939 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 2940 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 2941 Attribute atValue = atTarget.member(names.value);
jfranck@1313 2942 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 2943 return (Attribute.Array) atValue;
jfranck@1313 2944 }
jfranck@1313 2945
duke@1 2946 /** Check an annotation value.
duke@1 2947 */
duke@1 2948 public void validateAnnotation(JCAnnotation a) {
mcimadamore@632 2949 // collect an inventory of the members (sorted alphabetically)
mcimadamore@632 2950 Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
mcimadamore@632 2951 public int compare(Symbol t, Symbol t1) {
mcimadamore@632 2952 return t.name.compareTo(t1.name);
mcimadamore@632 2953 }
mcimadamore@632 2954 });
duke@1 2955 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2956 e != null;
duke@1 2957 e = e.sibling)
duke@1 2958 if (e.sym.kind == MTH)
duke@1 2959 members.add((MethodSymbol) e.sym);
duke@1 2960
duke@1 2961 // count them off as they're annotated
duke@1 2962 for (JCTree arg : a.args) {
jjg@1127 2963 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 2964 JCAssign assign = (JCAssign) arg;
duke@1 2965 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2966 if (m == null || m.type.isErroneous()) continue;
duke@1 2967 if (!members.remove(m))
jjg@479 2968 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2969 m.name, a.type);
duke@1 2970 }
duke@1 2971
duke@1 2972 // all the remaining ones better have default values
mcimadamore@632 2973 ListBuffer<Name> missingDefaults = ListBuffer.lb();
mcimadamore@632 2974 for (MethodSymbol m : members) {
mcimadamore@632 2975 if (m.defaultValue == null && !m.type.isErroneous()) {
mcimadamore@632 2976 missingDefaults.append(m.name);
mcimadamore@632 2977 }
mcimadamore@632 2978 }
mcimadamore@632 2979 if (missingDefaults.nonEmpty()) {
mcimadamore@632 2980 String key = (missingDefaults.size() > 1)
mcimadamore@632 2981 ? "annotation.missing.default.value.1"
mcimadamore@632 2982 : "annotation.missing.default.value";
mcimadamore@632 2983 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 2984 }
duke@1 2985
duke@1 2986 // special case: java.lang.annotation.Target must not have
duke@1 2987 // repeated values in its value member
duke@1 2988 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2989 a.args.tail == null)
duke@1 2990 return;
duke@1 2991
jjg@1127 2992 if (!a.args.head.hasTag(ASSIGN)) return; // error recovery
duke@1 2993 JCAssign assign = (JCAssign) a.args.head;
duke@1 2994 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2995 if (m.name != names.value) return;
duke@1 2996 JCTree rhs = assign.rhs;
jjg@1127 2997 if (!rhs.hasTag(NEWARRAY)) return;
duke@1 2998 JCNewArray na = (JCNewArray) rhs;
duke@1 2999 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 3000 for (JCTree elem : na.elems) {
duke@1 3001 if (!targets.add(TreeInfo.symbol(elem))) {
duke@1 3002 log.error(elem.pos(), "repeated.annotation.target");
duke@1 3003 }
duke@1 3004 }
duke@1 3005 }
duke@1 3006
duke@1 3007 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 3008 if (allowAnnotations &&
mcimadamore@795 3009 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 3010 (s.flags() & DEPRECATED) != 0 &&
duke@1 3011 !syms.deprecatedType.isErroneous() &&
duke@1 3012 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 3013 log.warning(LintCategory.DEP_ANN,
jjg@612 3014 pos, "missing.deprecated.annotation");
duke@1 3015 }
duke@1 3016 }
duke@1 3017
mcimadamore@852 3018 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 3019 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 3020 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 3021 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 3022 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3023 @Override
mcimadamore@852 3024 public void report() {
mcimadamore@852 3025 warnDeprecated(pos, s);
mcimadamore@852 3026 }
mcimadamore@852 3027 });
jjg@1157 3028 }
mcimadamore@852 3029 }
mcimadamore@852 3030
mcimadamore@852 3031 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 3032 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 3033 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3034 public void report() {
mcimadamore@852 3035 if (enableSunApiLintControl)
mcimadamore@852 3036 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 3037 else
mcimadamore@1218 3038 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 3039 }
mcimadamore@852 3040 });
mcimadamore@852 3041 }
mcimadamore@852 3042 }
mcimadamore@852 3043
duke@1 3044 /* *************************************************************************
duke@1 3045 * Check for recursive annotation elements.
duke@1 3046 **************************************************************************/
duke@1 3047
duke@1 3048 /** Check for cycles in the graph of annotation elements.
duke@1 3049 */
duke@1 3050 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 3051 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 3052 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 3053 try {
duke@1 3054 tree.sym.flags_field |= LOCKED;
duke@1 3055 for (JCTree def : tree.defs) {
jjg@1127 3056 if (!def.hasTag(METHODDEF)) continue;
duke@1 3057 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 3058 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 3059 }
duke@1 3060 } finally {
duke@1 3061 tree.sym.flags_field &= ~LOCKED;
duke@1 3062 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 3063 }
duke@1 3064 }
duke@1 3065
duke@1 3066 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 3067 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 3068 return;
duke@1 3069 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 3070 log.error(pos, "cyclic.annotation.element");
duke@1 3071 return;
duke@1 3072 }
duke@1 3073 try {
duke@1 3074 tsym.flags_field |= LOCKED;
duke@1 3075 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 3076 Symbol s = e.sym;
duke@1 3077 if (s.kind != Kinds.MTH)
duke@1 3078 continue;
duke@1 3079 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 3080 }
duke@1 3081 } finally {
duke@1 3082 tsym.flags_field &= ~LOCKED;
duke@1 3083 tsym.flags_field |= ACYCLIC_ANN;
duke@1 3084 }
duke@1 3085 }
duke@1 3086
duke@1 3087 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
jjg@1374 3088 switch (type.getTag()) {
jjg@1374 3089 case CLASS:
duke@1 3090 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 3091 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 3092 break;
jjg@1374 3093 case ARRAY:
duke@1 3094 checkAnnotationResType(pos, types.elemtype(type));
duke@1 3095 break;
duke@1 3096 default:
duke@1 3097 break; // int etc
duke@1 3098 }
duke@1 3099 }
duke@1 3100
duke@1 3101 /* *************************************************************************
duke@1 3102 * Check for cycles in the constructor call graph.
duke@1 3103 **************************************************************************/
duke@1 3104
duke@1 3105 /** Check for cycles in the graph of constructors calling other
duke@1 3106 * constructors.
duke@1 3107 */
duke@1 3108 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 3109 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 3110
duke@1 3111 // enter each constructor this-call into the map
duke@1 3112 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 3113 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 3114 if (app == null) continue;
duke@1 3115 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 3116 if (TreeInfo.name(app.meth) == names._this) {
duke@1 3117 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 3118 } else {
duke@1 3119 meth.sym.flags_field |= ACYCLIC;
duke@1 3120 }
duke@1 3121 }
duke@1 3122
duke@1 3123 // Check for cycles in the map
duke@1 3124 Symbol[] ctors = new Symbol[0];
duke@1 3125 ctors = callMap.keySet().toArray(ctors);
duke@1 3126 for (Symbol caller : ctors) {
duke@1 3127 checkCyclicConstructor(tree, caller, callMap);
duke@1 3128 }
duke@1 3129 }
duke@1 3130
duke@1 3131 /** Look in the map to see if the given constructor is part of a
duke@1 3132 * call cycle.
duke@1 3133 */
duke@1 3134 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 3135 Map<Symbol,Symbol> callMap) {
duke@1 3136 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 3137 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 3138 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 3139 "recursive.ctor.invocation");
duke@1 3140 } else {
duke@1 3141 ctor.flags_field |= LOCKED;
duke@1 3142 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 3143 ctor.flags_field &= ~LOCKED;
duke@1 3144 }
duke@1 3145 ctor.flags_field |= ACYCLIC;
duke@1 3146 }
duke@1 3147 }
duke@1 3148
duke@1 3149 /* *************************************************************************
duke@1 3150 * Miscellaneous
duke@1 3151 **************************************************************************/
duke@1 3152
duke@1 3153 /**
duke@1 3154 * Return the opcode of the operator but emit an error if it is an
duke@1 3155 * error.
duke@1 3156 * @param pos position for error reporting.
duke@1 3157 * @param operator an operator
duke@1 3158 * @param tag a tree tag
duke@1 3159 * @param left type of left hand side
duke@1 3160 * @param right type of right hand side
duke@1 3161 */
duke@1 3162 int checkOperator(DiagnosticPosition pos,
duke@1 3163 OperatorSymbol operator,
jjg@1127 3164 JCTree.Tag tag,
duke@1 3165 Type left,
duke@1 3166 Type right) {
duke@1 3167 if (operator.opcode == ByteCodes.error) {
duke@1 3168 log.error(pos,
mcimadamore@853 3169 "operator.cant.be.applied.1",
duke@1 3170 treeinfo.operatorName(tag),
mcimadamore@853 3171 left, right);
duke@1 3172 }
duke@1 3173 return operator.opcode;
duke@1 3174 }
duke@1 3175
duke@1 3176
duke@1 3177 /**
duke@1 3178 * Check for division by integer constant zero
duke@1 3179 * @param pos Position for error reporting.
duke@1 3180 * @param operator The operator for the expression
duke@1 3181 * @param operand The right hand operand for the expression
duke@1 3182 */
duke@1 3183 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3184 if (operand.constValue() != null
mcimadamore@795 3185 && lint.isEnabled(LintCategory.DIVZERO)
jjg@1374 3186 && (operand.getTag().isSubRangeOf(LONG))
duke@1 3187 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3188 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3189 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3190 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3191 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3192 }
duke@1 3193 }
duke@1 3194 }
duke@1 3195
duke@1 3196 /**
duke@1 3197 * Check for empty statements after if
duke@1 3198 */
duke@1 3199 void checkEmptyIf(JCIf tree) {
jjg@1127 3200 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3201 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3202 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3203 }
duke@1 3204
duke@1 3205 /** Check that symbol is unique in given scope.
duke@1 3206 * @param pos Position for error reporting.
duke@1 3207 * @param sym The symbol.
duke@1 3208 * @param s The scope.
duke@1 3209 */
duke@1 3210 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3211 if (sym.type.isErroneous())
duke@1 3212 return true;
duke@1 3213 if (sym.owner.name == names.any) return false;
duke@1 3214 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3215 if (sym != e.sym &&
mcimadamore@858 3216 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3217 sym.kind == e.sym.kind &&
mcimadamore@858 3218 sym.name != names.error &&
mcimadamore@858 3219 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3220 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3221 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3222 return true;
mcimadamore@907 3223 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3224 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3225 sym.flags_field |= CLASH;
mcimadamore@844 3226 return true;
mcimadamore@844 3227 } else {
duke@1 3228 duplicateError(pos, e.sym);
mcimadamore@844 3229 return false;
mcimadamore@844 3230 }
duke@1 3231 }
duke@1 3232 }
duke@1 3233 return true;
duke@1 3234 }
mcimadamore@844 3235
mcimadamore@858 3236 /** Report duplicate declaration error.
mcimadamore@858 3237 */
mcimadamore@858 3238 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3239 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3240 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3241 }
mcimadamore@858 3242 }
duke@1 3243
duke@1 3244 /** Check that single-type import is not already imported or top-level defined,
duke@1 3245 * but make an exception for two single-type imports which denote the same type.
duke@1 3246 * @param pos Position for error reporting.
duke@1 3247 * @param sym The symbol.
duke@1 3248 * @param s The scope
duke@1 3249 */
duke@1 3250 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3251 return checkUniqueImport(pos, sym, s, false);
duke@1 3252 }
duke@1 3253
duke@1 3254 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3255 * but make an exception for two single-type imports which denote the same type.
duke@1 3256 * @param pos Position for error reporting.
duke@1 3257 * @param sym The symbol.
duke@1 3258 * @param s The scope
duke@1 3259 */
duke@1 3260 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3261 return checkUniqueImport(pos, sym, s, true);
duke@1 3262 }
duke@1 3263
duke@1 3264 /** Check that single-type import is not already imported or top-level defined,
duke@1 3265 * but make an exception for two single-type imports which denote the same type.
duke@1 3266 * @param pos Position for error reporting.
duke@1 3267 * @param sym The symbol.
duke@1 3268 * @param s The scope.
duke@1 3269 * @param staticImport Whether or not this was a static import
duke@1 3270 */
duke@1 3271 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3272 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3273 // is encountered class entered via a class declaration?
duke@1 3274 boolean isClassDecl = e.scope == s;
duke@1 3275 if ((isClassDecl || sym != e.sym) &&
duke@1 3276 sym.kind == e.sym.kind &&
duke@1 3277 sym.name != names.error) {
duke@1 3278 if (!e.sym.type.isErroneous()) {
duke@1 3279 String what = e.sym.toString();
duke@1 3280 if (!isClassDecl) {
duke@1 3281 if (staticImport)
duke@1 3282 log.error(pos, "already.defined.static.single.import", what);
duke@1 3283 else
duke@1 3284 log.error(pos, "already.defined.single.import", what);
duke@1 3285 }
duke@1 3286 else if (sym != e.sym)
duke@1 3287 log.error(pos, "already.defined.this.unit", what);
duke@1 3288 }
duke@1 3289 return false;
duke@1 3290 }
duke@1 3291 }
duke@1 3292 return true;
duke@1 3293 }
duke@1 3294
duke@1 3295 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3296 */
duke@1 3297 public void checkCanonical(JCTree tree) {
duke@1 3298 if (!isCanonical(tree))
duke@1 3299 log.error(tree.pos(), "import.requires.canonical",
duke@1 3300 TreeInfo.symbol(tree));
duke@1 3301 }
duke@1 3302 // where
duke@1 3303 private boolean isCanonical(JCTree tree) {
jjg@1127 3304 while (tree.hasTag(SELECT)) {
duke@1 3305 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3306 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3307 return false;
duke@1 3308 tree = s.selected;
duke@1 3309 }
duke@1 3310 return true;
duke@1 3311 }
duke@1 3312
ohrstrom@1384 3313 /** Check that an auxiliary class is not accessed from any other file than its own.
ohrstrom@1384 3314 */
ohrstrom@1384 3315 void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) {
ohrstrom@1384 3316 if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) &&
ohrstrom@1384 3317 (c.flags() & AUXILIARY) != 0 &&
ohrstrom@1384 3318 rs.isAccessible(env, c) &&
ohrstrom@1384 3319 !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile))
ohrstrom@1384 3320 {
ohrstrom@1384 3321 log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file",
ohrstrom@1384 3322 c, c.sourcefile);
ohrstrom@1384 3323 }
ohrstrom@1384 3324 }
ohrstrom@1384 3325
duke@1 3326 private class ConversionWarner extends Warner {
mcimadamore@795 3327 final String uncheckedKey;
duke@1 3328 final Type found;
duke@1 3329 final Type expected;
mcimadamore@795 3330 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3331 super(pos);
mcimadamore@795 3332 this.uncheckedKey = uncheckedKey;
duke@1 3333 this.found = found;
duke@1 3334 this.expected = expected;
duke@1 3335 }
duke@1 3336
jjg@398 3337 @Override
mcimadamore@795 3338 public void warn(LintCategory lint) {
duke@1 3339 boolean warned = this.warned;
mcimadamore@795 3340 super.warn(lint);
duke@1 3341 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3342 switch (lint) {
mcimadamore@795 3343 case UNCHECKED:
mcimadamore@795 3344 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3345 break;
mcimadamore@795 3346 case VARARGS:
mcimadamore@795 3347 if (method != null &&
mcimadamore@795 3348 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3349 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3350 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3351 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3352 }
mcimadamore@795 3353 break;
mcimadamore@795 3354 default:
mcimadamore@795 3355 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3356 }
duke@1 3357 }
duke@1 3358 }
duke@1 3359
duke@1 3360 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3361 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3362 }
duke@1 3363
duke@1 3364 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3365 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3366 }
duke@1 3367 }

mercurial