src/share/classes/com/sun/tools/javac/comp/Check.java

Mon, 26 Jul 2010 14:25:56 -0700

author
jjg
date
Mon, 26 Jul 2010 14:25:56 -0700
changeset 612
d1bd93028447
parent 609
13354e1abba7
child 629
0fe472f4a332
permissions
-rw-r--r--

6957438: improve code for generating warning messages containing option names
Reviewed-by: mcimadamore

duke@1 1 /*
ohair@554 2 * Copyright (c) 1999, 2009, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
duke@1 30
duke@1 31 import com.sun.tools.javac.code.*;
duke@1 32 import com.sun.tools.javac.jvm.*;
duke@1 33 import com.sun.tools.javac.tree.*;
duke@1 34 import com.sun.tools.javac.util.*;
duke@1 35 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 36 import com.sun.tools.javac.util.List;
duke@1 37
duke@1 38 import com.sun.tools.javac.tree.JCTree.*;
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
duke@1 43
duke@1 44 import static com.sun.tools.javac.code.Flags.*;
duke@1 45 import static com.sun.tools.javac.code.Kinds.*;
duke@1 46 import static com.sun.tools.javac.code.TypeTags.*;
duke@1 47
duke@1 48 /** Type checking helper class for the attribution phase.
duke@1 49 *
jjg@581 50 * <p><b>This is NOT part of any supported API.
jjg@581 51 * If you write code that depends on this, you do so at your own risk.
duke@1 52 * This code and its internal interfaces are subject to change or
duke@1 53 * deletion without notice.</b>
duke@1 54 */
duke@1 55 public class Check {
duke@1 56 protected static final Context.Key<Check> checkKey =
duke@1 57 new Context.Key<Check>();
duke@1 58
jjg@113 59 private final Names names;
duke@1 60 private final Log log;
duke@1 61 private final Symtab syms;
duke@1 62 private final Infer infer;
duke@1 63 private final Types types;
mcimadamore@89 64 private final JCDiagnostic.Factory diags;
duke@1 65 private final boolean skipAnnotations;
mcimadamore@359 66 private boolean warnOnSyntheticConflicts;
jjg@576 67 private boolean suppressAbortOnBadClassFile;
duke@1 68 private final TreeInfo treeinfo;
duke@1 69
duke@1 70 // The set of lint options currently in effect. It is initialized
duke@1 71 // from the context, and then is set/reset as needed by Attr as it
duke@1 72 // visits all the various parts of the trees during attribution.
duke@1 73 private Lint lint;
duke@1 74
duke@1 75 public static Check instance(Context context) {
duke@1 76 Check instance = context.get(checkKey);
duke@1 77 if (instance == null)
duke@1 78 instance = new Check(context);
duke@1 79 return instance;
duke@1 80 }
duke@1 81
duke@1 82 protected Check(Context context) {
duke@1 83 context.put(checkKey, this);
duke@1 84
jjg@113 85 names = Names.instance(context);
duke@1 86 log = Log.instance(context);
duke@1 87 syms = Symtab.instance(context);
duke@1 88 infer = Infer.instance(context);
duke@1 89 this.types = Types.instance(context);
mcimadamore@89 90 diags = JCDiagnostic.Factory.instance(context);
duke@1 91 Options options = Options.instance(context);
duke@1 92 lint = Lint.instance(context);
duke@1 93 treeinfo = TreeInfo.instance(context);
duke@1 94
duke@1 95 Source source = Source.instance(context);
duke@1 96 allowGenerics = source.allowGenerics();
duke@1 97 allowAnnotations = source.allowAnnotations();
jjg@398 98 allowCovariantReturns = source.allowCovariantReturns();
duke@1 99 complexInference = options.get("-complexinference") != null;
duke@1 100 skipAnnotations = options.get("skipAnnotations") != null;
mcimadamore@359 101 warnOnSyntheticConflicts = options.get("warnOnSyntheticConflicts") != null;
jjg@576 102 suppressAbortOnBadClassFile = options.get("suppressAbortOnBadClassFile") != null;
duke@1 103
jjg@398 104 Target target = Target.instance(context);
jjg@398 105 syntheticNameChar = target.syntheticNameChar();
jjg@398 106
duke@1 107 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 108 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
mcimadamore@580 109 boolean verboseVarargs = lint.isEnabled(LintCategory.VARARGS);
jjg@377 110 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 111 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 112
jjg@60 113 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 114 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 115 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 116 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
mcimadamore@580 117 unsafeVarargsHandler = new MandatoryWarningHandler(log, verboseVarargs,
jjg@612 118 enforceMandatoryWarnings, "varargs", LintCategory.VARARGS);
jjg@377 119 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 120 enforceMandatoryWarnings, "sunapi", null);
duke@1 121 }
duke@1 122
duke@1 123 /** Switch: generics enabled?
duke@1 124 */
duke@1 125 boolean allowGenerics;
duke@1 126
duke@1 127 /** Switch: annotations enabled?
duke@1 128 */
duke@1 129 boolean allowAnnotations;
duke@1 130
jjg@398 131 /** Switch: covariant returns enabled?
jjg@398 132 */
jjg@398 133 boolean allowCovariantReturns;
jjg@398 134
duke@1 135 /** Switch: -complexinference option set?
duke@1 136 */
duke@1 137 boolean complexInference;
duke@1 138
jjg@398 139 /** Character for synthetic names
jjg@398 140 */
jjg@398 141 char syntheticNameChar;
jjg@398 142
duke@1 143 /** A table mapping flat names of all compiled classes in this run to their
duke@1 144 * symbols; maintained from outside.
duke@1 145 */
duke@1 146 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 147
duke@1 148 /** A handler for messages about deprecated usage.
duke@1 149 */
duke@1 150 private MandatoryWarningHandler deprecationHandler;
duke@1 151
duke@1 152 /** A handler for messages about unchecked or unsafe usage.
duke@1 153 */
duke@1 154 private MandatoryWarningHandler uncheckedHandler;
duke@1 155
mcimadamore@580 156 /** A handler for messages about unchecked or unsafe vararg method decl.
mcimadamore@580 157 */
mcimadamore@580 158 private MandatoryWarningHandler unsafeVarargsHandler;
mcimadamore@580 159
jjg@582 160 /** A handler for messages about using proprietary API.
jjg@377 161 */
jjg@377 162 private MandatoryWarningHandler sunApiHandler;
duke@1 163
duke@1 164 /* *************************************************************************
duke@1 165 * Errors and Warnings
duke@1 166 **************************************************************************/
duke@1 167
duke@1 168 Lint setLint(Lint newLint) {
duke@1 169 Lint prev = lint;
duke@1 170 lint = newLint;
duke@1 171 return prev;
duke@1 172 }
duke@1 173
duke@1 174 /** Warn about deprecated symbol.
duke@1 175 * @param pos Position to be used for error reporting.
duke@1 176 * @param sym The deprecated symbol.
duke@1 177 */
duke@1 178 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 179 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 180 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 181 }
duke@1 182
duke@1 183 /** Warn about unchecked operation.
duke@1 184 * @param pos Position to be used for error reporting.
duke@1 185 * @param msg A string describing the problem.
duke@1 186 */
duke@1 187 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 188 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 189 uncheckedHandler.report(pos, msg, args);
duke@1 190 }
duke@1 191
mcimadamore@580 192 /** Warn about unsafe vararg method decl.
mcimadamore@580 193 * @param pos Position to be used for error reporting.
mcimadamore@580 194 * @param sym The deprecated symbol.
mcimadamore@580 195 */
mcimadamore@580 196 void warnUnsafeVararg(DiagnosticPosition pos, Type elemType) {
mcimadamore@580 197 if (!lint.isSuppressed(LintCategory.VARARGS))
mcimadamore@580 198 unsafeVarargsHandler.report(pos, "varargs.non.reifiable.type", elemType);
mcimadamore@580 199 }
mcimadamore@580 200
jjg@582 201 /** Warn about using proprietary API.
jjg@377 202 * @param pos Position to be used for error reporting.
jjg@377 203 * @param msg A string describing the problem.
jjg@377 204 */
jjg@377 205 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 206 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 207 sunApiHandler.report(pos, msg, args);
jjg@377 208 }
jjg@377 209
jjg@505 210 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 211 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 212 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 213 }
jjg@505 214
duke@1 215 /**
duke@1 216 * Report any deferred diagnostics.
duke@1 217 */
duke@1 218 public void reportDeferredDiagnostics() {
duke@1 219 deprecationHandler.reportDeferredDiagnostic();
duke@1 220 uncheckedHandler.reportDeferredDiagnostic();
mcimadamore@580 221 unsafeVarargsHandler.reportDeferredDiagnostic();
jjg@377 222 sunApiHandler.reportDeferredDiagnostic();
duke@1 223 }
duke@1 224
duke@1 225
duke@1 226 /** Report a failure to complete a class.
duke@1 227 * @param pos Position to be used for error reporting.
duke@1 228 * @param ex The failure to report.
duke@1 229 */
duke@1 230 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 231 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 232 if (ex instanceof ClassReader.BadClassFile
jjg@576 233 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 234 else return syms.errType;
duke@1 235 }
duke@1 236
duke@1 237 /** Report a type error.
duke@1 238 * @param pos Position to be used for error reporting.
duke@1 239 * @param problem A string describing the error.
duke@1 240 * @param found The type that was found.
duke@1 241 * @param req The type that was required.
duke@1 242 */
duke@1 243 Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
duke@1 244 log.error(pos, "prob.found.req",
duke@1 245 problem, found, req);
jjg@110 246 return types.createErrorType(found);
duke@1 247 }
duke@1 248
duke@1 249 Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
duke@1 250 log.error(pos, "prob.found.req.1", problem, found, req, explanation);
jjg@110 251 return types.createErrorType(found);
duke@1 252 }
duke@1 253
duke@1 254 /** Report an error that wrong type tag was found.
duke@1 255 * @param pos Position to be used for error reporting.
duke@1 256 * @param required An internationalized string describing the type tag
duke@1 257 * required.
duke@1 258 * @param found The type that was found.
duke@1 259 */
duke@1 260 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 261 // this error used to be raised by the parser,
jrose@267 262 // but has been delayed to this point:
jrose@267 263 if (found instanceof Type && ((Type)found).tag == VOID) {
jrose@267 264 log.error(pos, "illegal.start.of.type");
jrose@267 265 return syms.errType;
jrose@267 266 }
duke@1 267 log.error(pos, "type.found.req", found, required);
jjg@110 268 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 269 }
duke@1 270
duke@1 271 /** Report an error that symbol cannot be referenced before super
duke@1 272 * has been called.
duke@1 273 * @param pos Position to be used for error reporting.
duke@1 274 * @param sym The referenced symbol.
duke@1 275 */
duke@1 276 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 277 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 278 }
duke@1 279
duke@1 280 /** Report duplicate declaration error.
duke@1 281 */
duke@1 282 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 283 if (!sym.type.isErroneous()) {
duke@1 284 log.error(pos, "already.defined", sym, sym.location());
duke@1 285 }
duke@1 286 }
duke@1 287
duke@1 288 /** Report array/varargs duplicate declaration
duke@1 289 */
duke@1 290 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 291 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 292 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 293 }
duke@1 294 }
duke@1 295
duke@1 296 /* ************************************************************************
duke@1 297 * duplicate declaration checking
duke@1 298 *************************************************************************/
duke@1 299
duke@1 300 /** Check that variable does not hide variable with same name in
duke@1 301 * immediately enclosing local scope.
duke@1 302 * @param pos Position for error reporting.
duke@1 303 * @param v The symbol.
duke@1 304 * @param s The scope.
duke@1 305 */
duke@1 306 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 307 if (s.next != null) {
duke@1 308 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 309 e.scope != null && e.sym.owner == v.owner;
duke@1 310 e = e.next()) {
duke@1 311 if (e.sym.kind == VAR &&
duke@1 312 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 313 v.name != names.error) {
duke@1 314 duplicateError(pos, e.sym);
duke@1 315 return;
duke@1 316 }
duke@1 317 }
duke@1 318 }
duke@1 319 }
duke@1 320
duke@1 321 /** Check that a class or interface does not hide a class or
duke@1 322 * interface with same name in immediately enclosing local scope.
duke@1 323 * @param pos Position for error reporting.
duke@1 324 * @param c The symbol.
duke@1 325 * @param s The scope.
duke@1 326 */
duke@1 327 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 328 if (s.next != null) {
duke@1 329 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 330 e.scope != null && e.sym.owner == c.owner;
duke@1 331 e = e.next()) {
duke@1 332 if (e.sym.kind == TYP &&
duke@1 333 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 334 c.name != names.error) {
duke@1 335 duplicateError(pos, e.sym);
duke@1 336 return;
duke@1 337 }
duke@1 338 }
duke@1 339 }
duke@1 340 }
duke@1 341
duke@1 342 /** Check that class does not have the same name as one of
duke@1 343 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 344 * return true if class is unique in its enclosing scope.
duke@1 345 * @param pos Position for error reporting.
duke@1 346 * @param name The class name.
duke@1 347 * @param s The enclosing scope.
duke@1 348 */
duke@1 349 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 350 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 351 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 352 duplicateError(pos, e.sym);
duke@1 353 return false;
duke@1 354 }
duke@1 355 }
duke@1 356 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 357 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 358 duplicateError(pos, sym);
duke@1 359 return true;
duke@1 360 }
duke@1 361 }
duke@1 362 return true;
duke@1 363 }
duke@1 364
duke@1 365 /* *************************************************************************
duke@1 366 * Class name generation
duke@1 367 **************************************************************************/
duke@1 368
duke@1 369 /** Return name of local class.
duke@1 370 * This is of the form <enclClass> $ n <classname>
duke@1 371 * where
duke@1 372 * enclClass is the flat name of the enclosing class,
duke@1 373 * classname is the simple name of the local class
duke@1 374 */
duke@1 375 Name localClassName(ClassSymbol c) {
duke@1 376 for (int i=1; ; i++) {
duke@1 377 Name flatname = names.
duke@1 378 fromString("" + c.owner.enclClass().flatname +
jjg@398 379 syntheticNameChar + i +
duke@1 380 c.name);
duke@1 381 if (compiled.get(flatname) == null) return flatname;
duke@1 382 }
duke@1 383 }
duke@1 384
duke@1 385 /* *************************************************************************
duke@1 386 * Type Checking
duke@1 387 **************************************************************************/
duke@1 388
duke@1 389 /** Check that a given type is assignable to a given proto-type.
duke@1 390 * If it is, return the type, otherwise return errType.
duke@1 391 * @param pos Position to be used for error reporting.
duke@1 392 * @param found The type that was found.
duke@1 393 * @param req The type that was required.
duke@1 394 */
duke@1 395 Type checkType(DiagnosticPosition pos, Type found, Type req) {
darcy@609 396 return checkType(pos, found, req, "incompatible.types");
darcy@609 397 }
darcy@609 398
darcy@609 399 Type checkType(DiagnosticPosition pos, Type found, Type req, String errKey) {
duke@1 400 if (req.tag == ERROR)
duke@1 401 return req;
mcimadamore@536 402 if (found.tag == FORALL)
mcimadamore@536 403 return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req));
duke@1 404 if (req.tag == NONE)
duke@1 405 return found;
duke@1 406 if (types.isAssignable(found, req, convertWarner(pos, found, req)))
duke@1 407 return found;
duke@1 408 if (found.tag <= DOUBLE && req.tag <= DOUBLE)
mcimadamore@89 409 return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req);
duke@1 410 if (found.isSuperBound()) {
duke@1 411 log.error(pos, "assignment.from.super-bound", found);
jjg@110 412 return types.createErrorType(found);
duke@1 413 }
duke@1 414 if (req.isExtendsBound()) {
duke@1 415 log.error(pos, "assignment.to.extends-bound", req);
jjg@110 416 return types.createErrorType(found);
duke@1 417 }
darcy@609 418 return typeError(pos, diags.fragment(errKey), found, req);
duke@1 419 }
duke@1 420
duke@1 421 /** Instantiate polymorphic type to some prototype, unless
duke@1 422 * prototype is `anyPoly' in which case polymorphic type
duke@1 423 * is returned unchanged.
duke@1 424 */
mcimadamore@383 425 Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException {
duke@1 426 if (pt == Infer.anyPoly && complexInference) {
duke@1 427 return t;
duke@1 428 } else if (pt == Infer.anyPoly || pt.tag == NONE) {
duke@1 429 Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
duke@1 430 return instantiatePoly(pos, t, newpt, warn);
duke@1 431 } else if (pt.tag == ERROR) {
duke@1 432 return pt;
duke@1 433 } else {
mcimadamore@536 434 try {
mcimadamore@536 435 return infer.instantiateExpr(t, pt, warn);
mcimadamore@536 436 } catch (Infer.NoInstanceException ex) {
mcimadamore@536 437 if (ex.isAmbiguous) {
mcimadamore@536 438 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 439 log.error(pos,
mcimadamore@536 440 "undetermined.type" + (d!=null ? ".1" : ""),
mcimadamore@536 441 t, d);
mcimadamore@536 442 return types.createErrorType(pt);
mcimadamore@536 443 } else {
mcimadamore@536 444 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 445 return typeError(pos,
mcimadamore@536 446 diags.fragment("incompatible.types" + (d!=null ? ".1" : ""), d),
mcimadamore@536 447 t, pt);
mcimadamore@536 448 }
mcimadamore@536 449 } catch (Infer.InvalidInstanceException ex) {
mcimadamore@536 450 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 451 log.error(pos, "invalid.inferred.types", t.tvars, d);
mcimadamore@536 452 return types.createErrorType(pt);
mcimadamore@536 453 }
duke@1 454 }
mcimadamore@536 455 }
duke@1 456
duke@1 457 /** Check that a given type can be cast to a given target type.
duke@1 458 * Return the result of the cast.
duke@1 459 * @param pos Position to be used for error reporting.
duke@1 460 * @param found The type that is being cast.
duke@1 461 * @param req The target type of the cast.
duke@1 462 */
duke@1 463 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
duke@1 464 if (found.tag == FORALL) {
duke@1 465 instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
duke@1 466 return req;
duke@1 467 } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 468 return req;
duke@1 469 } else {
duke@1 470 return typeError(pos,
mcimadamore@89 471 diags.fragment("inconvertible.types"),
duke@1 472 found, req);
duke@1 473 }
duke@1 474 }
duke@1 475 //where
duke@1 476 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 477 * type variables?
duke@1 478 */
duke@1 479 boolean isTypeVar(Type t) {
duke@1 480 return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
duke@1 481 }
duke@1 482
duke@1 483 /** Check that a type is within some bounds.
duke@1 484 *
duke@1 485 * Used in TypeApply to verify that, e.g., X in V<X> is a valid
duke@1 486 * type argument.
duke@1 487 * @param pos Position to be used for error reporting.
duke@1 488 * @param a The type that should be bounded by bs.
duke@1 489 * @param bs The bound.
duke@1 490 */
duke@1 491 private void checkExtends(DiagnosticPosition pos, Type a, TypeVar bs) {
mcimadamore@154 492 if (a.isUnbound()) {
mcimadamore@154 493 return;
mcimadamore@154 494 } else if (a.tag != WILDCARD) {
mcimadamore@154 495 a = types.upperBound(a);
mcimadamore@154 496 for (List<Type> l = types.getBounds(bs); l.nonEmpty(); l = l.tail) {
mcimadamore@154 497 if (!types.isSubtype(a, l.head)) {
mcimadamore@154 498 log.error(pos, "not.within.bounds", a);
mcimadamore@154 499 return;
mcimadamore@154 500 }
mcimadamore@154 501 }
mcimadamore@154 502 } else if (a.isExtendsBound()) {
mcimadamore@154 503 if (!types.isCastable(bs.getUpperBound(), types.upperBound(a), Warner.noWarnings))
mcimadamore@154 504 log.error(pos, "not.within.bounds", a);
mcimadamore@154 505 } else if (a.isSuperBound()) {
mcimadamore@154 506 if (types.notSoftSubtype(types.lowerBound(a), bs.getUpperBound()))
mcimadamore@154 507 log.error(pos, "not.within.bounds", a);
mcimadamore@154 508 }
mcimadamore@154 509 }
mcimadamore@154 510
mcimadamore@154 511 /** Check that a type is within some bounds.
mcimadamore@154 512 *
mcimadamore@154 513 * Used in TypeApply to verify that, e.g., X in V<X> is a valid
mcimadamore@154 514 * type argument.
mcimadamore@154 515 * @param pos Position to be used for error reporting.
mcimadamore@154 516 * @param a The type that should be bounded by bs.
mcimadamore@154 517 * @param bs The bound.
mcimadamore@154 518 */
mcimadamore@154 519 private void checkCapture(JCTypeApply tree) {
mcimadamore@154 520 List<JCExpression> args = tree.getTypeArguments();
mcimadamore@154 521 for (Type arg : types.capture(tree.type).getTypeArguments()) {
mcimadamore@154 522 if (arg.tag == TYPEVAR && arg.getUpperBound().isErroneous()) {
mcimadamore@154 523 log.error(args.head.pos, "not.within.bounds", args.head.type);
mcimadamore@154 524 break;
mcimadamore@79 525 }
mcimadamore@154 526 args = args.tail;
mcimadamore@79 527 }
mcimadamore@154 528 }
duke@1 529
duke@1 530 /** Check that type is different from 'void'.
duke@1 531 * @param pos Position to be used for error reporting.
duke@1 532 * @param t The type to be checked.
duke@1 533 */
duke@1 534 Type checkNonVoid(DiagnosticPosition pos, Type t) {
duke@1 535 if (t.tag == VOID) {
duke@1 536 log.error(pos, "void.not.allowed.here");
jjg@110 537 return types.createErrorType(t);
duke@1 538 } else {
duke@1 539 return t;
duke@1 540 }
duke@1 541 }
duke@1 542
duke@1 543 /** Check that type is a class or interface type.
duke@1 544 * @param pos Position to be used for error reporting.
duke@1 545 * @param t The type to be checked.
duke@1 546 */
duke@1 547 Type checkClassType(DiagnosticPosition pos, Type t) {
duke@1 548 if (t.tag != CLASS && t.tag != ERROR)
duke@1 549 return typeTagError(pos,
mcimadamore@89 550 diags.fragment("type.req.class"),
duke@1 551 (t.tag == TYPEVAR)
mcimadamore@89 552 ? diags.fragment("type.parameter", t)
duke@1 553 : t);
duke@1 554 else
duke@1 555 return t;
duke@1 556 }
duke@1 557
duke@1 558 /** Check that type is a class or interface type.
duke@1 559 * @param pos Position to be used for error reporting.
duke@1 560 * @param t The type to be checked.
duke@1 561 * @param noBounds True if type bounds are illegal here.
duke@1 562 */
duke@1 563 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 564 t = checkClassType(pos, t);
duke@1 565 if (noBounds && t.isParameterized()) {
duke@1 566 List<Type> args = t.getTypeArguments();
duke@1 567 while (args.nonEmpty()) {
duke@1 568 if (args.head.tag == WILDCARD)
duke@1 569 return typeTagError(pos,
jjg@598 570 diags.fragment("type.req.exact"),
duke@1 571 args.head);
duke@1 572 args = args.tail;
duke@1 573 }
duke@1 574 }
duke@1 575 return t;
duke@1 576 }
duke@1 577
duke@1 578 /** Check that type is a reifiable class, interface or array type.
duke@1 579 * @param pos Position to be used for error reporting.
duke@1 580 * @param t The type to be checked.
duke@1 581 */
duke@1 582 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
duke@1 583 if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
duke@1 584 return typeTagError(pos,
mcimadamore@89 585 diags.fragment("type.req.class.array"),
duke@1 586 t);
duke@1 587 } else if (!types.isReifiable(t)) {
duke@1 588 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 589 return types.createErrorType(t);
duke@1 590 } else {
duke@1 591 return t;
duke@1 592 }
duke@1 593 }
duke@1 594
duke@1 595 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 596 * or a type variable.
duke@1 597 * @param pos Position to be used for error reporting.
duke@1 598 * @param t The type to be checked.
duke@1 599 */
duke@1 600 Type checkRefType(DiagnosticPosition pos, Type t) {
duke@1 601 switch (t.tag) {
duke@1 602 case CLASS:
duke@1 603 case ARRAY:
duke@1 604 case TYPEVAR:
duke@1 605 case WILDCARD:
duke@1 606 case ERROR:
duke@1 607 return t;
duke@1 608 default:
duke@1 609 return typeTagError(pos,
mcimadamore@89 610 diags.fragment("type.req.ref"),
duke@1 611 t);
duke@1 612 }
duke@1 613 }
duke@1 614
jrose@267 615 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 616 * or a type variable.
jrose@267 617 * @param trees Original trees, used for error reporting.
jrose@267 618 * @param types The types to be checked.
jrose@267 619 */
jrose@267 620 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 621 List<JCExpression> tl = trees;
jrose@267 622 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 623 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 624 tl = tl.tail;
jrose@267 625 }
jrose@267 626 return types;
jrose@267 627 }
jrose@267 628
duke@1 629 /** Check that type is a null or reference type.
duke@1 630 * @param pos Position to be used for error reporting.
duke@1 631 * @param t The type to be checked.
duke@1 632 */
duke@1 633 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
duke@1 634 switch (t.tag) {
duke@1 635 case CLASS:
duke@1 636 case ARRAY:
duke@1 637 case TYPEVAR:
duke@1 638 case WILDCARD:
duke@1 639 case BOT:
duke@1 640 case ERROR:
duke@1 641 return t;
duke@1 642 default:
duke@1 643 return typeTagError(pos,
mcimadamore@89 644 diags.fragment("type.req.ref"),
duke@1 645 t);
duke@1 646 }
duke@1 647 }
duke@1 648
duke@1 649 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 650 * Return true if it doesn't.
duke@1 651 * @param pos Position to be used for error reporting.
duke@1 652 * @param flags The set of flags to be checked.
duke@1 653 * @param set1 Conflicting flags set #1.
duke@1 654 * @param set2 Conflicting flags set #2.
duke@1 655 */
duke@1 656 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 657 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 658 log.error(pos,
duke@1 659 "illegal.combination.of.modifiers",
mcimadamore@80 660 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 661 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 662 return false;
duke@1 663 } else
duke@1 664 return true;
duke@1 665 }
duke@1 666
mcimadamore@537 667 /** Check that the type inferred using the diamond operator does not contain
mcimadamore@537 668 * non-denotable types such as captured types or intersection types.
mcimadamore@537 669 * @param t the type inferred using the diamond operator
mcimadamore@537 670 */
mcimadamore@537 671 List<Type> checkDiamond(ClassType t) {
mcimadamore@537 672 DiamondTypeChecker dtc = new DiamondTypeChecker();
mcimadamore@537 673 ListBuffer<Type> buf = ListBuffer.lb();
mcimadamore@537 674 for (Type arg : t.getTypeArguments()) {
mcimadamore@537 675 if (!dtc.visit(arg, null)) {
mcimadamore@537 676 buf.append(arg);
mcimadamore@537 677 }
mcimadamore@537 678 }
mcimadamore@537 679 return buf.toList();
mcimadamore@537 680 }
mcimadamore@537 681
mcimadamore@537 682 static class DiamondTypeChecker extends Types.SimpleVisitor<Boolean, Void> {
mcimadamore@537 683 public Boolean visitType(Type t, Void s) {
mcimadamore@537 684 return true;
mcimadamore@537 685 }
mcimadamore@537 686 @Override
mcimadamore@537 687 public Boolean visitClassType(ClassType t, Void s) {
mcimadamore@537 688 if (t.isCompound()) {
mcimadamore@537 689 return false;
mcimadamore@537 690 }
mcimadamore@537 691 for (Type targ : t.getTypeArguments()) {
mcimadamore@537 692 if (!visit(targ, s)) {
mcimadamore@537 693 return false;
mcimadamore@537 694 }
mcimadamore@537 695 }
mcimadamore@537 696 return true;
mcimadamore@537 697 }
mcimadamore@537 698 @Override
mcimadamore@537 699 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@537 700 return false;
mcimadamore@537 701 }
mcimadamore@537 702 }
mcimadamore@537 703
mcimadamore@580 704 void checkVarargMethodDecl(JCMethodDecl tree) {
mcimadamore@580 705 MethodSymbol m = tree.sym;
mcimadamore@580 706 //check the element type of the vararg
mcimadamore@580 707 if (m.isVarArgs()) {
mcimadamore@580 708 Type varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@580 709 if (!types.isReifiable(varargElemType)) {
mcimadamore@580 710 warnUnsafeVararg(tree.params.head.pos(), varargElemType);
mcimadamore@580 711 }
mcimadamore@580 712 }
mcimadamore@580 713 }
mcimadamore@580 714
mcimadamore@547 715 /**
mcimadamore@547 716 * Check that vararg method call is sound
mcimadamore@547 717 * @param pos Position to be used for error reporting.
mcimadamore@547 718 * @param argtypes Actual arguments supplied to vararg method.
mcimadamore@547 719 */
mcimadamore@580 720 void checkVararg(DiagnosticPosition pos, List<Type> argtypes, Symbol msym, Env<AttrContext> env) {
mcimadamore@580 721 Env<AttrContext> calleeLintEnv = env;
mcimadamore@580 722 while (calleeLintEnv.info.lint == null)
mcimadamore@580 723 calleeLintEnv = calleeLintEnv.next;
mcimadamore@580 724 Lint calleeLint = calleeLintEnv.info.lint.augment(msym.attributes_field, msym.flags());
mcimadamore@547 725 Type argtype = argtypes.last();
mcimadamore@580 726 if (!types.isReifiable(argtype) && !calleeLint.isSuppressed(Lint.LintCategory.VARARGS)) {
mcimadamore@547 727 warnUnchecked(pos,
mcimadamore@547 728 "unchecked.generic.array.creation",
mcimadamore@547 729 argtype);
mcimadamore@580 730 }
mcimadamore@547 731 }
mcimadamore@547 732
duke@1 733 /** Check that given modifiers are legal for given symbol and
duke@1 734 * return modifiers together with any implicit modififiers for that symbol.
duke@1 735 * Warning: we can't use flags() here since this method
duke@1 736 * is called during class enter, when flags() would cause a premature
duke@1 737 * completion.
duke@1 738 * @param pos Position to be used for error reporting.
duke@1 739 * @param flags The set of modifiers given in a definition.
duke@1 740 * @param sym The defined symbol.
duke@1 741 */
duke@1 742 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 743 long mask;
duke@1 744 long implicit = 0;
duke@1 745 switch (sym.kind) {
duke@1 746 case VAR:
duke@1 747 if (sym.owner.kind != TYP)
duke@1 748 mask = LocalVarFlags;
duke@1 749 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 750 mask = implicit = InterfaceVarFlags;
duke@1 751 else
duke@1 752 mask = VarFlags;
duke@1 753 break;
duke@1 754 case MTH:
duke@1 755 if (sym.name == names.init) {
duke@1 756 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 757 // enum constructors cannot be declared public or
duke@1 758 // protected and must be implicitly or explicitly
duke@1 759 // private
duke@1 760 implicit = PRIVATE;
duke@1 761 mask = PRIVATE;
duke@1 762 } else
duke@1 763 mask = ConstructorFlags;
duke@1 764 } else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 765 mask = implicit = InterfaceMethodFlags;
duke@1 766 else {
duke@1 767 mask = MethodFlags;
duke@1 768 }
duke@1 769 // Imply STRICTFP if owner has STRICTFP set.
duke@1 770 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 771 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 772 break;
duke@1 773 case TYP:
duke@1 774 if (sym.isLocal()) {
duke@1 775 mask = LocalClassFlags;
jjg@113 776 if (sym.name.isEmpty()) { // Anonymous class
duke@1 777 // Anonymous classes in static methods are themselves static;
duke@1 778 // that's why we admit STATIC here.
duke@1 779 mask |= STATIC;
duke@1 780 // JLS: Anonymous classes are final.
duke@1 781 implicit |= FINAL;
duke@1 782 }
duke@1 783 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 784 (flags & ENUM) != 0)
duke@1 785 log.error(pos, "enums.must.be.static");
duke@1 786 } else if (sym.owner.kind == TYP) {
duke@1 787 mask = MemberClassFlags;
duke@1 788 if (sym.owner.owner.kind == PCK ||
duke@1 789 (sym.owner.flags_field & STATIC) != 0)
duke@1 790 mask |= STATIC;
duke@1 791 else if ((flags & ENUM) != 0)
duke@1 792 log.error(pos, "enums.must.be.static");
duke@1 793 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 794 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 795 } else {
duke@1 796 mask = ClassFlags;
duke@1 797 }
duke@1 798 // Interfaces are always ABSTRACT
duke@1 799 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 800
duke@1 801 if ((flags & ENUM) != 0) {
duke@1 802 // enums can't be declared abstract or final
duke@1 803 mask &= ~(ABSTRACT | FINAL);
duke@1 804 implicit |= implicitEnumFinalFlag(tree);
duke@1 805 }
duke@1 806 // Imply STRICTFP if owner has STRICTFP set.
duke@1 807 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 808 break;
duke@1 809 default:
duke@1 810 throw new AssertionError();
duke@1 811 }
duke@1 812 long illegal = flags & StandardFlags & ~mask;
duke@1 813 if (illegal != 0) {
duke@1 814 if ((illegal & INTERFACE) != 0) {
duke@1 815 log.error(pos, "intf.not.allowed.here");
duke@1 816 mask |= INTERFACE;
duke@1 817 }
duke@1 818 else {
duke@1 819 log.error(pos,
mcimadamore@80 820 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 821 }
duke@1 822 }
duke@1 823 else if ((sym.kind == TYP ||
duke@1 824 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 825 // in the presence of inner classes. Should it be deleted here?
duke@1 826 checkDisjoint(pos, flags,
duke@1 827 ABSTRACT,
duke@1 828 PRIVATE | STATIC))
duke@1 829 &&
duke@1 830 checkDisjoint(pos, flags,
duke@1 831 ABSTRACT | INTERFACE,
duke@1 832 FINAL | NATIVE | SYNCHRONIZED)
duke@1 833 &&
duke@1 834 checkDisjoint(pos, flags,
duke@1 835 PUBLIC,
duke@1 836 PRIVATE | PROTECTED)
duke@1 837 &&
duke@1 838 checkDisjoint(pos, flags,
duke@1 839 PRIVATE,
duke@1 840 PUBLIC | PROTECTED)
duke@1 841 &&
duke@1 842 checkDisjoint(pos, flags,
duke@1 843 FINAL,
duke@1 844 VOLATILE)
duke@1 845 &&
duke@1 846 (sym.kind == TYP ||
duke@1 847 checkDisjoint(pos, flags,
duke@1 848 ABSTRACT | NATIVE,
duke@1 849 STRICTFP))) {
duke@1 850 // skip
duke@1 851 }
duke@1 852 return flags & (mask | ~StandardFlags) | implicit;
duke@1 853 }
duke@1 854
duke@1 855
duke@1 856 /** Determine if this enum should be implicitly final.
duke@1 857 *
duke@1 858 * If the enum has no specialized enum contants, it is final.
duke@1 859 *
duke@1 860 * If the enum does have specialized enum contants, it is
duke@1 861 * <i>not</i> final.
duke@1 862 */
duke@1 863 private long implicitEnumFinalFlag(JCTree tree) {
duke@1 864 if (tree.getTag() != JCTree.CLASSDEF) return 0;
duke@1 865 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 866 boolean specialized;
duke@1 867 SpecialTreeVisitor() {
duke@1 868 this.specialized = false;
duke@1 869 };
duke@1 870
jjg@398 871 @Override
duke@1 872 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 873
jjg@398 874 @Override
duke@1 875 public void visitVarDef(JCVariableDecl tree) {
duke@1 876 if ((tree.mods.flags & ENUM) != 0) {
duke@1 877 if (tree.init instanceof JCNewClass &&
duke@1 878 ((JCNewClass) tree.init).def != null) {
duke@1 879 specialized = true;
duke@1 880 }
duke@1 881 }
duke@1 882 }
duke@1 883 }
duke@1 884
duke@1 885 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 886 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 887 for (JCTree defs: cdef.defs) {
duke@1 888 defs.accept(sts);
duke@1 889 if (sts.specialized) return 0;
duke@1 890 }
duke@1 891 return FINAL;
duke@1 892 }
duke@1 893
duke@1 894 /* *************************************************************************
duke@1 895 * Type Validation
duke@1 896 **************************************************************************/
duke@1 897
duke@1 898 /** Validate a type expression. That is,
duke@1 899 * check that all type arguments of a parametric type are within
duke@1 900 * their bounds. This must be done in a second phase after type attributon
duke@1 901 * since a class might have a subclass as type parameter bound. E.g:
duke@1 902 *
duke@1 903 * class B<A extends C> { ... }
duke@1 904 * class C extends B<C> { ... }
duke@1 905 *
duke@1 906 * and we can't make sure that the bound is already attributed because
duke@1 907 * of possible cycles.
duke@1 908 */
duke@1 909 private Validator validator = new Validator();
duke@1 910
duke@1 911 /** Visitor method: Validate a type expression, if it is not null, catching
duke@1 912 * and reporting any completion failures.
duke@1 913 */
mcimadamore@122 914 void validate(JCTree tree, Env<AttrContext> env) {
duke@1 915 try {
mcimadamore@122 916 if (tree != null) {
mcimadamore@122 917 validator.env = env;
mcimadamore@122 918 tree.accept(validator);
mcimadamore@122 919 checkRaw(tree, env);
mcimadamore@122 920 }
duke@1 921 } catch (CompletionFailure ex) {
duke@1 922 completionError(tree.pos(), ex);
duke@1 923 }
duke@1 924 }
mcimadamore@122 925 //where
mcimadamore@122 926 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@122 927 if (lint.isEnabled(Lint.LintCategory.RAW) &&
mcimadamore@122 928 tree.type.tag == CLASS &&
mcimadamore@564 929 !TreeInfo.isDiamond(tree) &&
mcimadamore@122 930 !env.enclClass.name.isEmpty() && //anonymous or intersection
mcimadamore@122 931 tree.type.isRaw()) {
jjg@612 932 log.warning(Lint.LintCategory.RAW,
jjg@612 933 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@122 934 }
mcimadamore@122 935 }
duke@1 936
duke@1 937 /** Visitor method: Validate a list of type expressions.
duke@1 938 */
mcimadamore@122 939 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 940 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 941 validate(l.head, env);
duke@1 942 }
duke@1 943
duke@1 944 /** A visitor class for type validation.
duke@1 945 */
duke@1 946 class Validator extends JCTree.Visitor {
duke@1 947
jjg@398 948 @Override
duke@1 949 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@122 950 validate(tree.elemtype, env);
duke@1 951 }
duke@1 952
jjg@398 953 @Override
duke@1 954 public void visitTypeApply(JCTypeApply tree) {
duke@1 955 if (tree.type.tag == CLASS) {
mcimadamore@158 956 List<Type> formals = tree.type.tsym.type.allparams();
mcimadamore@158 957 List<Type> actuals = tree.type.allparams();
duke@1 958 List<JCExpression> args = tree.arguments;
mcimadamore@158 959 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@561 960 ListBuffer<Type> tvars_buf = new ListBuffer<Type>();
duke@1 961
duke@1 962 // For matching pairs of actual argument types `a' and
duke@1 963 // formal type parameters with declared bound `b' ...
duke@1 964 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@122 965 validate(args.head, env);
duke@1 966
duke@1 967 // exact type arguments needs to know their
duke@1 968 // bounds (for upper and lower bound
duke@1 969 // calculations). So we create new TypeVars with
duke@1 970 // bounds substed with actuals.
duke@1 971 tvars_buf.append(types.substBound(((TypeVar)forms.head),
duke@1 972 formals,
mcimadamore@78 973 actuals));
duke@1 974
duke@1 975 args = args.tail;
duke@1 976 forms = forms.tail;
duke@1 977 }
duke@1 978
duke@1 979 args = tree.arguments;
mcimadamore@154 980 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@154 981 formals,
mcimadamore@158 982 types.capture(tree.type).allparams());
mcimadamore@154 983 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@154 984 // Let the actual arguments know their bound
mcimadamore@154 985 args.head.type.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@154 986 args = args.tail;
mcimadamore@154 987 tvars_cap = tvars_cap.tail;
mcimadamore@154 988 }
mcimadamore@154 989
mcimadamore@154 990 args = tree.arguments;
mcimadamore@561 991 List<Type> tvars = tvars_buf.toList();
mcimadamore@154 992
duke@1 993 while (args.nonEmpty() && tvars.nonEmpty()) {
mcimadamore@561 994 Type actual = types.subst(args.head.type,
mcimadamore@561 995 tree.type.tsym.type.getTypeArguments(),
mcimadamore@561 996 tvars_buf.toList());
mcimadamore@154 997 checkExtends(args.head.pos(),
mcimadamore@561 998 actual,
mcimadamore@561 999 (TypeVar)tvars.head);
duke@1 1000 args = args.tail;
duke@1 1001 tvars = tvars.tail;
duke@1 1002 }
duke@1 1003
mcimadamore@154 1004 checkCapture(tree);
mcimadamore@536 1005
duke@1 1006 // Check that this type is either fully parameterized, or
duke@1 1007 // not parameterized at all.
duke@1 1008 if (tree.type.getEnclosingType().isRaw())
duke@1 1009 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
duke@1 1010 if (tree.clazz.getTag() == JCTree.SELECT)
duke@1 1011 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1012 }
duke@1 1013 }
duke@1 1014
jjg@398 1015 @Override
duke@1 1016 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@122 1017 validate(tree.bounds, env);
duke@1 1018 checkClassBounds(tree.pos(), tree.type);
duke@1 1019 }
duke@1 1020
duke@1 1021 @Override
duke@1 1022 public void visitWildcard(JCWildcard tree) {
duke@1 1023 if (tree.inner != null)
mcimadamore@122 1024 validate(tree.inner, env);
duke@1 1025 }
duke@1 1026
jjg@398 1027 @Override
duke@1 1028 public void visitSelect(JCFieldAccess tree) {
duke@1 1029 if (tree.type.tag == CLASS) {
duke@1 1030 visitSelectInternal(tree);
duke@1 1031
duke@1 1032 // Check that this type is either fully parameterized, or
duke@1 1033 // not parameterized at all.
duke@1 1034 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1035 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1036 }
duke@1 1037 }
duke@1 1038 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1039 if (tree.type.tsym.isStatic() &&
duke@1 1040 tree.selected.type.isParameterized()) {
duke@1 1041 // The enclosing type is not a class, so we are
duke@1 1042 // looking at a static member type. However, the
duke@1 1043 // qualifying expression is parameterized.
duke@1 1044 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1045 } else {
duke@1 1046 // otherwise validate the rest of the expression
mcimadamore@122 1047 tree.selected.accept(this);
duke@1 1048 }
duke@1 1049 }
duke@1 1050
jjg@398 1051 @Override
jjg@308 1052 public void visitAnnotatedType(JCAnnotatedType tree) {
jjg@308 1053 tree.underlyingType.accept(this);
jjg@308 1054 }
jjg@308 1055
duke@1 1056 /** Default visitor method: do nothing.
duke@1 1057 */
jjg@398 1058 @Override
duke@1 1059 public void visitTree(JCTree tree) {
duke@1 1060 }
mcimadamore@122 1061
mcimadamore@122 1062 Env<AttrContext> env;
duke@1 1063 }
duke@1 1064
duke@1 1065 /* *************************************************************************
duke@1 1066 * Exception checking
duke@1 1067 **************************************************************************/
duke@1 1068
duke@1 1069 /* The following methods treat classes as sets that contain
duke@1 1070 * the class itself and all their subclasses
duke@1 1071 */
duke@1 1072
duke@1 1073 /** Is given type a subtype of some of the types in given list?
duke@1 1074 */
duke@1 1075 boolean subset(Type t, List<Type> ts) {
duke@1 1076 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1077 if (types.isSubtype(t, l.head)) return true;
duke@1 1078 return false;
duke@1 1079 }
duke@1 1080
duke@1 1081 /** Is given type a subtype or supertype of
duke@1 1082 * some of the types in given list?
duke@1 1083 */
duke@1 1084 boolean intersects(Type t, List<Type> ts) {
duke@1 1085 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1086 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1087 return false;
duke@1 1088 }
duke@1 1089
duke@1 1090 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1091 * in the list.
duke@1 1092 */
duke@1 1093 List<Type> incl(Type t, List<Type> ts) {
duke@1 1094 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1095 }
duke@1 1096
duke@1 1097 /** Remove type set from type set list.
duke@1 1098 */
duke@1 1099 List<Type> excl(Type t, List<Type> ts) {
duke@1 1100 if (ts.isEmpty()) {
duke@1 1101 return ts;
duke@1 1102 } else {
duke@1 1103 List<Type> ts1 = excl(t, ts.tail);
duke@1 1104 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1105 else if (ts1 == ts.tail) return ts;
duke@1 1106 else return ts1.prepend(ts.head);
duke@1 1107 }
duke@1 1108 }
duke@1 1109
duke@1 1110 /** Form the union of two type set lists.
duke@1 1111 */
duke@1 1112 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1113 List<Type> ts = ts1;
duke@1 1114 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1115 ts = incl(l.head, ts);
duke@1 1116 return ts;
duke@1 1117 }
duke@1 1118
duke@1 1119 /** Form the difference of two type lists.
duke@1 1120 */
duke@1 1121 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1122 List<Type> ts = ts1;
duke@1 1123 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1124 ts = excl(l.head, ts);
duke@1 1125 return ts;
duke@1 1126 }
duke@1 1127
duke@1 1128 /** Form the intersection of two type lists.
duke@1 1129 */
duke@1 1130 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1131 List<Type> ts = List.nil();
duke@1 1132 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1133 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1134 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1135 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1136 return ts;
duke@1 1137 }
duke@1 1138
duke@1 1139 /** Is exc an exception symbol that need not be declared?
duke@1 1140 */
duke@1 1141 boolean isUnchecked(ClassSymbol exc) {
duke@1 1142 return
duke@1 1143 exc.kind == ERR ||
duke@1 1144 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1145 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1146 }
duke@1 1147
duke@1 1148 /** Is exc an exception type that need not be declared?
duke@1 1149 */
duke@1 1150 boolean isUnchecked(Type exc) {
duke@1 1151 return
duke@1 1152 (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
duke@1 1153 (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
duke@1 1154 exc.tag == BOT;
duke@1 1155 }
duke@1 1156
duke@1 1157 /** Same, but handling completion failures.
duke@1 1158 */
duke@1 1159 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1160 try {
duke@1 1161 return isUnchecked(exc);
duke@1 1162 } catch (CompletionFailure ex) {
duke@1 1163 completionError(pos, ex);
duke@1 1164 return true;
duke@1 1165 }
duke@1 1166 }
duke@1 1167
duke@1 1168 /** Is exc handled by given exception list?
duke@1 1169 */
duke@1 1170 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1171 return isUnchecked(exc) || subset(exc, handled);
duke@1 1172 }
duke@1 1173
duke@1 1174 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1175 * @param thrown The list of thrown exceptions.
duke@1 1176 * @param handled The list of handled exceptions.
duke@1 1177 */
mcimadamore@362 1178 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1179 List<Type> unhandled = List.nil();
duke@1 1180 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1181 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1182 return unhandled;
duke@1 1183 }
duke@1 1184
duke@1 1185 /* *************************************************************************
duke@1 1186 * Overriding/Implementation checking
duke@1 1187 **************************************************************************/
duke@1 1188
duke@1 1189 /** The level of access protection given by a flag set,
duke@1 1190 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1191 */
duke@1 1192 static int protection(long flags) {
duke@1 1193 switch ((short)(flags & AccessFlags)) {
duke@1 1194 case PRIVATE: return 3;
duke@1 1195 case PROTECTED: return 1;
duke@1 1196 default:
duke@1 1197 case PUBLIC: return 0;
duke@1 1198 case 0: return 2;
duke@1 1199 }
duke@1 1200 }
duke@1 1201
duke@1 1202 /** A customized "cannot override" error message.
duke@1 1203 * @param m The overriding method.
duke@1 1204 * @param other The overridden method.
duke@1 1205 * @return An internationalized string.
duke@1 1206 */
mcimadamore@89 1207 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1208 String key;
duke@1 1209 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1210 key = "cant.override";
duke@1 1211 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1212 key = "cant.implement";
duke@1 1213 else
duke@1 1214 key = "clashes.with";
mcimadamore@89 1215 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1216 }
duke@1 1217
duke@1 1218 /** A customized "override" warning message.
duke@1 1219 * @param m The overriding method.
duke@1 1220 * @param other The overridden method.
duke@1 1221 * @return An internationalized string.
duke@1 1222 */
mcimadamore@89 1223 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1224 String key;
duke@1 1225 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1226 key = "unchecked.override";
duke@1 1227 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1228 key = "unchecked.implement";
duke@1 1229 else
duke@1 1230 key = "unchecked.clash.with";
mcimadamore@89 1231 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1232 }
duke@1 1233
duke@1 1234 /** A customized "override" warning message.
duke@1 1235 * @param m The overriding method.
duke@1 1236 * @param other The overridden method.
duke@1 1237 * @return An internationalized string.
duke@1 1238 */
mcimadamore@89 1239 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1240 String key;
duke@1 1241 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1242 key = "varargs.override";
duke@1 1243 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1244 key = "varargs.implement";
duke@1 1245 else
duke@1 1246 key = "varargs.clash.with";
mcimadamore@89 1247 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1248 }
duke@1 1249
duke@1 1250 /** Check that this method conforms with overridden method 'other'.
duke@1 1251 * where `origin' is the class where checking started.
duke@1 1252 * Complications:
duke@1 1253 * (1) Do not check overriding of synthetic methods
duke@1 1254 * (reason: they might be final).
duke@1 1255 * todo: check whether this is still necessary.
duke@1 1256 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1257 * than the method it implements. Augment the proxy methods with the
duke@1 1258 * undeclared exceptions in this case.
duke@1 1259 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1260 * has a result type
duke@1 1261 * extended by the result type of the method it implements.
duke@1 1262 * Change the proxies result type to the smaller type in this case.
duke@1 1263 *
duke@1 1264 * @param tree The tree from which positions
duke@1 1265 * are extracted for errors.
duke@1 1266 * @param m The overriding method.
duke@1 1267 * @param other The overridden method.
duke@1 1268 * @param origin The class of which the overriding method
duke@1 1269 * is a member.
duke@1 1270 */
duke@1 1271 void checkOverride(JCTree tree,
duke@1 1272 MethodSymbol m,
duke@1 1273 MethodSymbol other,
duke@1 1274 ClassSymbol origin) {
duke@1 1275 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1276 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1277 return;
duke@1 1278 }
duke@1 1279
duke@1 1280 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1281 if ((m.flags() & STATIC) != 0 &&
duke@1 1282 (other.flags() & STATIC) == 0) {
duke@1 1283 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1284 cannotOverride(m, other));
duke@1 1285 return;
duke@1 1286 }
duke@1 1287
duke@1 1288 // Error if instance method overrides static or final
duke@1 1289 // method (JLS 8.4.6.1).
duke@1 1290 if ((other.flags() & FINAL) != 0 ||
duke@1 1291 (m.flags() & STATIC) == 0 &&
duke@1 1292 (other.flags() & STATIC) != 0) {
duke@1 1293 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1294 cannotOverride(m, other),
mcimadamore@80 1295 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1296 return;
duke@1 1297 }
duke@1 1298
duke@1 1299 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1300 // handled in validateAnnotationMethod
duke@1 1301 return;
duke@1 1302 }
duke@1 1303
duke@1 1304 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1305 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1306 protection(m.flags()) > protection(other.flags())) {
duke@1 1307 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1308 cannotOverride(m, other),
mcimadamore@80 1309 other.flags() == 0 ?
mcimadamore@80 1310 Flag.PACKAGE :
mcimadamore@80 1311 asFlagSet(other.flags() & AccessFlags));
duke@1 1312 return;
duke@1 1313 }
duke@1 1314
duke@1 1315 Type mt = types.memberType(origin.type, m);
duke@1 1316 Type ot = types.memberType(origin.type, other);
duke@1 1317 // Error if overriding result type is different
duke@1 1318 // (or, in the case of generics mode, not a subtype) of
duke@1 1319 // overridden result type. We have to rename any type parameters
duke@1 1320 // before comparing types.
duke@1 1321 List<Type> mtvars = mt.getTypeArguments();
duke@1 1322 List<Type> otvars = ot.getTypeArguments();
duke@1 1323 Type mtres = mt.getReturnType();
duke@1 1324 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1325
duke@1 1326 overrideWarner.warned = false;
duke@1 1327 boolean resultTypesOK =
tbell@202 1328 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1329 if (!resultTypesOK) {
jjg@398 1330 if (!allowCovariantReturns &&
duke@1 1331 m.owner != origin &&
duke@1 1332 m.owner.isSubClass(other.owner, types)) {
duke@1 1333 // allow limited interoperability with covariant returns
duke@1 1334 } else {
mcimadamore@362 1335 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1336 "override.incompatible.ret",
mcimadamore@362 1337 cannotOverride(m, other),
duke@1 1338 mtres, otres);
duke@1 1339 return;
duke@1 1340 }
duke@1 1341 } else if (overrideWarner.warned) {
duke@1 1342 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1343 "override.unchecked.ret",
mcimadamore@362 1344 uncheckedOverrides(m, other),
mcimadamore@362 1345 mtres, otres);
duke@1 1346 }
duke@1 1347
duke@1 1348 // Error if overriding method throws an exception not reported
duke@1 1349 // by overridden method.
duke@1 1350 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1351 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1352 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1353 if (unhandledErased.nonEmpty()) {
duke@1 1354 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1355 "override.meth.doesnt.throw",
duke@1 1356 cannotOverride(m, other),
mcimadamore@362 1357 unhandledUnerased.head);
mcimadamore@362 1358 return;
mcimadamore@362 1359 }
mcimadamore@362 1360 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1361 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1362 "override.unchecked.thrown",
mcimadamore@362 1363 cannotOverride(m, other),
mcimadamore@362 1364 unhandledUnerased.head);
duke@1 1365 return;
duke@1 1366 }
duke@1 1367
duke@1 1368 // Optional warning if varargs don't agree
duke@1 1369 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
duke@1 1370 && lint.isEnabled(Lint.LintCategory.OVERRIDES)) {
duke@1 1371 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1372 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1373 ? "override.varargs.missing"
duke@1 1374 : "override.varargs.extra",
duke@1 1375 varargsOverrides(m, other));
duke@1 1376 }
duke@1 1377
duke@1 1378 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1379 if ((other.flags() & BRIDGE) != 0) {
duke@1 1380 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1381 uncheckedOverrides(m, other));
duke@1 1382 }
duke@1 1383
duke@1 1384 // Warn if a deprecated method overridden by a non-deprecated one.
duke@1 1385 if ((other.flags() & DEPRECATED) != 0
duke@1 1386 && (m.flags() & DEPRECATED) == 0
duke@1 1387 && m.outermostClass() != other.outermostClass()
duke@1 1388 && !isDeprecatedOverrideIgnorable(other, origin)) {
duke@1 1389 warnDeprecated(TreeInfo.diagnosticPositionFor(m, tree), other);
duke@1 1390 }
duke@1 1391 }
duke@1 1392 // where
duke@1 1393 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1394 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1395 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1396 // because in that case, we will rediscover the issue when examining the method
duke@1 1397 // in the supertype.
duke@1 1398 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1399 // address the issue is when the method is the supertype implemementation: any other
duke@1 1400 // case, we will have dealt with when examining the supertype classes
duke@1 1401 ClassSymbol mc = m.enclClass();
duke@1 1402 Type st = types.supertype(origin.type);
duke@1 1403 if (st.tag != CLASS)
duke@1 1404 return true;
duke@1 1405 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1406
duke@1 1407 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1408 List<Type> intfs = types.interfaces(origin.type);
duke@1 1409 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1410 }
duke@1 1411 else
duke@1 1412 return (stimpl != m);
duke@1 1413 }
duke@1 1414
duke@1 1415
duke@1 1416 // used to check if there were any unchecked conversions
duke@1 1417 Warner overrideWarner = new Warner();
duke@1 1418
duke@1 1419 /** Check that a class does not inherit two concrete methods
duke@1 1420 * with the same signature.
duke@1 1421 * @param pos Position to be used for error reporting.
duke@1 1422 * @param site The class type to be checked.
duke@1 1423 */
duke@1 1424 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1425 Type sup = types.supertype(site);
duke@1 1426 if (sup.tag != CLASS) return;
duke@1 1427
duke@1 1428 for (Type t1 = sup;
duke@1 1429 t1.tsym.type.isParameterized();
duke@1 1430 t1 = types.supertype(t1)) {
duke@1 1431 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1432 e1 != null;
duke@1 1433 e1 = e1.sibling) {
duke@1 1434 Symbol s1 = e1.sym;
duke@1 1435 if (s1.kind != MTH ||
duke@1 1436 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1437 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1438 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1439 types,
duke@1 1440 true) != s1)
duke@1 1441 continue;
duke@1 1442 Type st1 = types.memberType(t1, s1);
duke@1 1443 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1444 if (st1 == s1.type) continue;
duke@1 1445
duke@1 1446 for (Type t2 = sup;
duke@1 1447 t2.tag == CLASS;
duke@1 1448 t2 = types.supertype(t2)) {
mcimadamore@24 1449 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1450 e2.scope != null;
duke@1 1451 e2 = e2.next()) {
duke@1 1452 Symbol s2 = e2.sym;
duke@1 1453 if (s2 == s1 ||
duke@1 1454 s2.kind != MTH ||
duke@1 1455 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1456 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1457 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1458 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1459 types,
duke@1 1460 true) != s2)
duke@1 1461 continue;
duke@1 1462 Type st2 = types.memberType(t2, s2);
duke@1 1463 if (types.overrideEquivalent(st1, st2))
duke@1 1464 log.error(pos, "concrete.inheritance.conflict",
duke@1 1465 s1, t1, s2, t2, sup);
duke@1 1466 }
duke@1 1467 }
duke@1 1468 }
duke@1 1469 }
duke@1 1470 }
duke@1 1471
duke@1 1472 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1473 * method with same name and arguments but incompatible return types.
duke@1 1474 * @param pos Position to be used for error reporting.
duke@1 1475 * @param t1 The first argument type.
duke@1 1476 * @param t2 The second argument type.
duke@1 1477 */
duke@1 1478 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1479 Type t1,
duke@1 1480 Type t2) {
duke@1 1481 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1482 types.makeCompoundType(t1, t2));
duke@1 1483 }
duke@1 1484
duke@1 1485 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1486 Type t1,
duke@1 1487 Type t2,
duke@1 1488 Type site) {
duke@1 1489 Symbol sym = firstIncompatibility(t1, t2, site);
duke@1 1490 if (sym != null) {
duke@1 1491 log.error(pos, "types.incompatible.diff.ret",
duke@1 1492 t1, t2, sym.name +
duke@1 1493 "(" + types.memberType(t2, sym).getParameterTypes() + ")");
duke@1 1494 return false;
duke@1 1495 }
duke@1 1496 return true;
duke@1 1497 }
duke@1 1498
duke@1 1499 /** Return the first method which is defined with same args
duke@1 1500 * but different return types in two given interfaces, or null if none
duke@1 1501 * exists.
duke@1 1502 * @param t1 The first type.
duke@1 1503 * @param t2 The second type.
duke@1 1504 * @param site The most derived type.
duke@1 1505 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1506 */
duke@1 1507 private Symbol firstIncompatibility(Type t1, Type t2, Type site) {
duke@1 1508 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1509 closure(t1, interfaces1);
duke@1 1510 Map<TypeSymbol,Type> interfaces2;
duke@1 1511 if (t1 == t2)
duke@1 1512 interfaces2 = interfaces1;
duke@1 1513 else
duke@1 1514 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1515
duke@1 1516 for (Type t3 : interfaces1.values()) {
duke@1 1517 for (Type t4 : interfaces2.values()) {
duke@1 1518 Symbol s = firstDirectIncompatibility(t3, t4, site);
duke@1 1519 if (s != null) return s;
duke@1 1520 }
duke@1 1521 }
duke@1 1522 return null;
duke@1 1523 }
duke@1 1524
duke@1 1525 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1526 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
duke@1 1527 if (t.tag != CLASS) return;
duke@1 1528 if (typeMap.put(t.tsym, t) == null) {
duke@1 1529 closure(types.supertype(t), typeMap);
duke@1 1530 for (Type i : types.interfaces(t))
duke@1 1531 closure(i, typeMap);
duke@1 1532 }
duke@1 1533 }
duke@1 1534
duke@1 1535 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1536 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
duke@1 1537 if (t.tag != CLASS) return;
duke@1 1538 if (typesSkip.get(t.tsym) != null) return;
duke@1 1539 if (typeMap.put(t.tsym, t) == null) {
duke@1 1540 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1541 for (Type i : types.interfaces(t))
duke@1 1542 closure(i, typesSkip, typeMap);
duke@1 1543 }
duke@1 1544 }
duke@1 1545
duke@1 1546 /** Return the first method in t2 that conflicts with a method from t1. */
duke@1 1547 private Symbol firstDirectIncompatibility(Type t1, Type t2, Type site) {
duke@1 1548 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1549 Symbol s1 = e1.sym;
duke@1 1550 Type st1 = null;
duke@1 1551 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
duke@1 1552 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1553 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1554 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1555 Symbol s2 = e2.sym;
duke@1 1556 if (s1 == s2) continue;
duke@1 1557 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
duke@1 1558 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1559 Type st2 = types.memberType(t2, s2);
duke@1 1560 if (types.overrideEquivalent(st1, st2)) {
duke@1 1561 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1562 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1563 Type rt1 = st1.getReturnType();
duke@1 1564 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1565 boolean compat =
duke@1 1566 types.isSameType(rt1, rt2) ||
duke@1 1567 rt1.tag >= CLASS && rt2.tag >= CLASS &&
duke@1 1568 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
mcimadamore@59 1569 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
mcimadamore@59 1570 checkCommonOverriderIn(s1,s2,site);
duke@1 1571 if (!compat) return s2;
duke@1 1572 }
duke@1 1573 }
duke@1 1574 }
duke@1 1575 return null;
duke@1 1576 }
mcimadamore@59 1577 //WHERE
mcimadamore@59 1578 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1579 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1580 Type st1 = types.memberType(site, s1);
mcimadamore@59 1581 Type st2 = types.memberType(site, s2);
mcimadamore@59 1582 closure(site, supertypes);
mcimadamore@59 1583 for (Type t : supertypes.values()) {
mcimadamore@59 1584 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1585 Symbol s3 = e.sym;
mcimadamore@59 1586 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1587 Type st3 = types.memberType(site,s3);
mcimadamore@59 1588 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1589 if (s3.owner == site.tsym) {
mcimadamore@59 1590 return true;
mcimadamore@59 1591 }
mcimadamore@59 1592 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1593 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1594 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1595 Type rt1 = st1.getReturnType();
mcimadamore@59 1596 Type rt2 = st2.getReturnType();
mcimadamore@59 1597 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1598 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1599 boolean compat =
mcimadamore@59 1600 rt13.tag >= CLASS && rt23.tag >= CLASS &&
mcimadamore@59 1601 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
mcimadamore@59 1602 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
mcimadamore@59 1603 if (compat)
mcimadamore@59 1604 return true;
mcimadamore@59 1605 }
mcimadamore@59 1606 }
mcimadamore@59 1607 }
mcimadamore@59 1608 return false;
mcimadamore@59 1609 }
duke@1 1610
duke@1 1611 /** Check that a given method conforms with any method it overrides.
duke@1 1612 * @param tree The tree from which positions are extracted
duke@1 1613 * for errors.
duke@1 1614 * @param m The overriding method.
duke@1 1615 */
duke@1 1616 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1617 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1618 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1619 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1620 log.error(tree.pos(), "enum.no.finalize");
duke@1 1621 return;
duke@1 1622 }
duke@1 1623 for (Type t = types.supertype(origin.type); t.tag == CLASS;
duke@1 1624 t = types.supertype(t)) {
duke@1 1625 TypeSymbol c = t.tsym;
duke@1 1626 Scope.Entry e = c.members().lookup(m.name);
duke@1 1627 while (e.scope != null) {
duke@1 1628 if (m.overrides(e.sym, origin, types, false))
duke@1 1629 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@252 1630 else if (e.sym.kind == MTH &&
mcimadamore@252 1631 e.sym.isInheritedIn(origin, types) &&
mcimadamore@252 1632 (e.sym.flags() & SYNTHETIC) == 0 &&
mcimadamore@252 1633 !m.isConstructor()) {
mcimadamore@24 1634 Type er1 = m.erasure(types);
mcimadamore@24 1635 Type er2 = e.sym.erasure(types);
mcimadamore@252 1636 if (types.isSameTypes(er1.getParameterTypes(),
mcimadamore@252 1637 er2.getParameterTypes())) {
mcimadamore@24 1638 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@24 1639 "name.clash.same.erasure.no.override",
mcimadamore@24 1640 m, m.location(),
mcimadamore@24 1641 e.sym, e.sym.location());
mcimadamore@24 1642 }
mcimadamore@24 1643 }
duke@1 1644 e = e.next();
duke@1 1645 }
duke@1 1646 }
duke@1 1647 }
duke@1 1648
duke@1 1649 /** Check that all abstract members of given class have definitions.
duke@1 1650 * @param pos Position to be used for error reporting.
duke@1 1651 * @param c The class.
duke@1 1652 */
duke@1 1653 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1654 try {
duke@1 1655 MethodSymbol undef = firstUndef(c, c);
duke@1 1656 if (undef != null) {
duke@1 1657 if ((c.flags() & ENUM) != 0 &&
duke@1 1658 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 1659 (c.flags() & FINAL) == 0) {
duke@1 1660 // add the ABSTRACT flag to an enum
duke@1 1661 c.flags_field |= ABSTRACT;
duke@1 1662 } else {
duke@1 1663 MethodSymbol undef1 =
duke@1 1664 new MethodSymbol(undef.flags(), undef.name,
duke@1 1665 types.memberType(c.type, undef), undef.owner);
duke@1 1666 log.error(pos, "does.not.override.abstract",
duke@1 1667 c, undef1, undef1.location());
duke@1 1668 }
duke@1 1669 }
duke@1 1670 } catch (CompletionFailure ex) {
duke@1 1671 completionError(pos, ex);
duke@1 1672 }
duke@1 1673 }
duke@1 1674 //where
duke@1 1675 /** Return first abstract member of class `c' that is not defined
duke@1 1676 * in `impl', null if there is none.
duke@1 1677 */
duke@1 1678 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 1679 MethodSymbol undef = null;
duke@1 1680 // Do not bother to search in classes that are not abstract,
duke@1 1681 // since they cannot have abstract members.
duke@1 1682 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 1683 Scope s = c.members();
duke@1 1684 for (Scope.Entry e = s.elems;
duke@1 1685 undef == null && e != null;
duke@1 1686 e = e.sibling) {
duke@1 1687 if (e.sym.kind == MTH &&
duke@1 1688 (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
duke@1 1689 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 1690 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
duke@1 1691 if (implmeth == null || implmeth == absmeth)
duke@1 1692 undef = absmeth;
duke@1 1693 }
duke@1 1694 }
duke@1 1695 if (undef == null) {
duke@1 1696 Type st = types.supertype(c.type);
duke@1 1697 if (st.tag == CLASS)
duke@1 1698 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 1699 }
duke@1 1700 for (List<Type> l = types.interfaces(c.type);
duke@1 1701 undef == null && l.nonEmpty();
duke@1 1702 l = l.tail) {
duke@1 1703 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 1704 }
duke@1 1705 }
duke@1 1706 return undef;
duke@1 1707 }
duke@1 1708
duke@1 1709 /** Check for cyclic references. Issue an error if the
duke@1 1710 * symbol of the type referred to has a LOCKED flag set.
duke@1 1711 *
duke@1 1712 * @param pos Position to be used for error reporting.
duke@1 1713 * @param t The type referred to.
duke@1 1714 */
duke@1 1715 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 1716 checkNonCyclicInternal(pos, t);
duke@1 1717 }
duke@1 1718
duke@1 1719
duke@1 1720 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 1721 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 1722 }
duke@1 1723
mcimadamore@236 1724 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 1725 final TypeVar tv;
mcimadamore@42 1726 if (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 1727 return;
duke@1 1728 if (seen.contains(t)) {
duke@1 1729 tv = (TypeVar)t;
jjg@110 1730 tv.bound = types.createErrorType(t);
duke@1 1731 log.error(pos, "cyclic.inheritance", t);
duke@1 1732 } else if (t.tag == TYPEVAR) {
duke@1 1733 tv = (TypeVar)t;
mcimadamore@236 1734 seen = seen.prepend(tv);
duke@1 1735 for (Type b : types.getBounds(tv))
duke@1 1736 checkNonCyclic1(pos, b, seen);
duke@1 1737 }
duke@1 1738 }
duke@1 1739
duke@1 1740 /** Check for cyclic references. Issue an error if the
duke@1 1741 * symbol of the type referred to has a LOCKED flag set.
duke@1 1742 *
duke@1 1743 * @param pos Position to be used for error reporting.
duke@1 1744 * @param t The type referred to.
duke@1 1745 * @returns True if the check completed on all attributed classes
duke@1 1746 */
duke@1 1747 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 1748 boolean complete = true; // was the check complete?
duke@1 1749 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 1750 Symbol c = t.tsym;
duke@1 1751 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 1752
duke@1 1753 if ((c.flags_field & LOCKED) != 0) {
duke@1 1754 noteCyclic(pos, (ClassSymbol)c);
duke@1 1755 } else if (!c.type.isErroneous()) {
duke@1 1756 try {
duke@1 1757 c.flags_field |= LOCKED;
duke@1 1758 if (c.type.tag == CLASS) {
duke@1 1759 ClassType clazz = (ClassType)c.type;
duke@1 1760 if (clazz.interfaces_field != null)
duke@1 1761 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 1762 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 1763 if (clazz.supertype_field != null) {
duke@1 1764 Type st = clazz.supertype_field;
duke@1 1765 if (st != null && st.tag == CLASS)
duke@1 1766 complete &= checkNonCyclicInternal(pos, st);
duke@1 1767 }
duke@1 1768 if (c.owner.kind == TYP)
duke@1 1769 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 1770 }
duke@1 1771 } finally {
duke@1 1772 c.flags_field &= ~LOCKED;
duke@1 1773 }
duke@1 1774 }
duke@1 1775 if (complete)
duke@1 1776 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 1777 if (complete) c.flags_field |= ACYCLIC;
duke@1 1778 return complete;
duke@1 1779 }
duke@1 1780
duke@1 1781 /** Note that we found an inheritance cycle. */
duke@1 1782 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1783 log.error(pos, "cyclic.inheritance", c);
duke@1 1784 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 1785 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 1786 Type st = types.supertype(c.type);
duke@1 1787 if (st.tag == CLASS)
jjg@110 1788 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 1789 c.type = types.createErrorType(c, c.type);
duke@1 1790 c.flags_field |= ACYCLIC;
duke@1 1791 }
duke@1 1792
duke@1 1793 /** Check that all methods which implement some
duke@1 1794 * method conform to the method they implement.
duke@1 1795 * @param tree The class definition whose members are checked.
duke@1 1796 */
duke@1 1797 void checkImplementations(JCClassDecl tree) {
duke@1 1798 checkImplementations(tree, tree.sym);
duke@1 1799 }
duke@1 1800 //where
duke@1 1801 /** Check that all methods which implement some
duke@1 1802 * method in `ic' conform to the method they implement.
duke@1 1803 */
duke@1 1804 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
duke@1 1805 ClassSymbol origin = tree.sym;
duke@1 1806 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 1807 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 1808 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 1809 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 1810 if (e.sym.kind == MTH &&
duke@1 1811 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 1812 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 1813 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 1814 if (implmeth != null && implmeth != absmeth &&
duke@1 1815 (implmeth.owner.flags() & INTERFACE) ==
duke@1 1816 (origin.flags() & INTERFACE)) {
duke@1 1817 // don't check if implmeth is in a class, yet
duke@1 1818 // origin is an interface. This case arises only
duke@1 1819 // if implmeth is declared in Object. The reason is
duke@1 1820 // that interfaces really don't inherit from
duke@1 1821 // Object it's just that the compiler represents
duke@1 1822 // things that way.
duke@1 1823 checkOverride(tree, implmeth, absmeth, origin);
duke@1 1824 }
duke@1 1825 }
duke@1 1826 }
duke@1 1827 }
duke@1 1828 }
duke@1 1829 }
duke@1 1830
duke@1 1831 /** Check that all abstract methods implemented by a class are
duke@1 1832 * mutually compatible.
duke@1 1833 * @param pos Position to be used for error reporting.
duke@1 1834 * @param c The class whose interfaces are checked.
duke@1 1835 */
duke@1 1836 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 1837 List<Type> supertypes = types.interfaces(c);
duke@1 1838 Type supertype = types.supertype(c);
duke@1 1839 if (supertype.tag == CLASS &&
duke@1 1840 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 1841 supertypes = supertypes.prepend(supertype);
duke@1 1842 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 1843 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 1844 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 1845 return;
duke@1 1846 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 1847 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 1848 return;
duke@1 1849 }
duke@1 1850 checkCompatibleConcretes(pos, c);
duke@1 1851 }
duke@1 1852
mcimadamore@359 1853 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 1854 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 1855 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 1856 // VM allows methods and variables with differing types
mcimadamore@359 1857 if (sym.kind == e.sym.kind &&
mcimadamore@359 1858 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 1859 sym != e.sym &&
mcimadamore@359 1860 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 1861 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 1862 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 1863 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 1864 return;
mcimadamore@359 1865 }
mcimadamore@359 1866 }
mcimadamore@359 1867 }
mcimadamore@359 1868 }
mcimadamore@359 1869
mcimadamore@359 1870 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 1871 */
mcimadamore@359 1872 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 1873 if (!sym.type.isErroneous()) {
mcimadamore@359 1874 if (warnOnSyntheticConflicts) {
mcimadamore@359 1875 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 1876 }
mcimadamore@359 1877 else {
mcimadamore@359 1878 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 1879 }
mcimadamore@359 1880 }
mcimadamore@359 1881 }
mcimadamore@359 1882
duke@1 1883 /** Check that class c does not implement directly or indirectly
duke@1 1884 * the same parameterized interface with two different argument lists.
duke@1 1885 * @param pos Position to be used for error reporting.
duke@1 1886 * @param type The type whose interfaces are checked.
duke@1 1887 */
duke@1 1888 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 1889 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 1890 }
duke@1 1891 //where
duke@1 1892 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 1893 * with their class symbol as key and their type as value. Make
duke@1 1894 * sure no class is entered with two different types.
duke@1 1895 */
duke@1 1896 void checkClassBounds(DiagnosticPosition pos,
duke@1 1897 Map<TypeSymbol,Type> seensofar,
duke@1 1898 Type type) {
duke@1 1899 if (type.isErroneous()) return;
duke@1 1900 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 1901 Type it = l.head;
duke@1 1902 Type oldit = seensofar.put(it.tsym, it);
duke@1 1903 if (oldit != null) {
duke@1 1904 List<Type> oldparams = oldit.allparams();
duke@1 1905 List<Type> newparams = it.allparams();
duke@1 1906 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 1907 log.error(pos, "cant.inherit.diff.arg",
duke@1 1908 it.tsym, Type.toString(oldparams),
duke@1 1909 Type.toString(newparams));
duke@1 1910 }
duke@1 1911 checkClassBounds(pos, seensofar, it);
duke@1 1912 }
duke@1 1913 Type st = types.supertype(type);
duke@1 1914 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 1915 }
duke@1 1916
duke@1 1917 /** Enter interface into into set.
duke@1 1918 * If it existed already, issue a "repeated interface" error.
duke@1 1919 */
duke@1 1920 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 1921 if (its.contains(it))
duke@1 1922 log.error(pos, "repeated.interface");
duke@1 1923 else {
duke@1 1924 its.add(it);
duke@1 1925 }
duke@1 1926 }
duke@1 1927
duke@1 1928 /* *************************************************************************
duke@1 1929 * Check annotations
duke@1 1930 **************************************************************************/
duke@1 1931
duke@1 1932 /** Annotation types are restricted to primitives, String, an
duke@1 1933 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 1934 * Anything>, arrays of the preceding.
duke@1 1935 */
duke@1 1936 void validateAnnotationType(JCTree restype) {
duke@1 1937 // restype may be null if an error occurred, so don't bother validating it
duke@1 1938 if (restype != null) {
duke@1 1939 validateAnnotationType(restype.pos(), restype.type);
duke@1 1940 }
duke@1 1941 }
duke@1 1942
duke@1 1943 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 1944 if (type.isPrimitive()) return;
duke@1 1945 if (types.isSameType(type, syms.stringType)) return;
duke@1 1946 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 1947 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 1948 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 1949 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 1950 validateAnnotationType(pos, types.elemtype(type));
duke@1 1951 return;
duke@1 1952 }
duke@1 1953 log.error(pos, "invalid.annotation.member.type");
duke@1 1954 }
duke@1 1955
duke@1 1956 /**
duke@1 1957 * "It is also a compile-time error if any method declared in an
duke@1 1958 * annotation type has a signature that is override-equivalent to
duke@1 1959 * that of any public or protected method declared in class Object
duke@1 1960 * or in the interface annotation.Annotation."
duke@1 1961 *
duke@1 1962 * @jls3 9.6 Annotation Types
duke@1 1963 */
duke@1 1964 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
duke@1 1965 for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
duke@1 1966 Scope s = sup.tsym.members();
duke@1 1967 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 1968 if (e.sym.kind == MTH &&
duke@1 1969 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 1970 types.overrideEquivalent(m.type, e.sym.type))
duke@1 1971 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 1972 }
duke@1 1973 }
duke@1 1974 }
duke@1 1975
duke@1 1976 /** Check the annotations of a symbol.
duke@1 1977 */
duke@1 1978 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 1979 if (skipAnnotations) return;
duke@1 1980 for (JCAnnotation a : annotations)
duke@1 1981 validateAnnotation(a, s);
duke@1 1982 }
duke@1 1983
jjg@308 1984 /** Check the type annotations
jjg@308 1985 */
jjg@308 1986 public void validateTypeAnnotations(List<JCTypeAnnotation> annotations, boolean isTypeParameter) {
jjg@308 1987 if (skipAnnotations) return;
jjg@308 1988 for (JCTypeAnnotation a : annotations)
jjg@308 1989 validateTypeAnnotation(a, isTypeParameter);
jjg@308 1990 }
jjg@308 1991
duke@1 1992 /** Check an annotation of a symbol.
duke@1 1993 */
duke@1 1994 public void validateAnnotation(JCAnnotation a, Symbol s) {
duke@1 1995 validateAnnotation(a);
duke@1 1996
duke@1 1997 if (!annotationApplicable(a, s))
duke@1 1998 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 1999
duke@1 2000 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2001 if (!isOverrider(s))
duke@1 2002 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2003 }
duke@1 2004 }
duke@1 2005
jjg@308 2006 public void validateTypeAnnotation(JCTypeAnnotation a, boolean isTypeParameter) {
jjg@308 2007 if (a.type == null)
jjg@308 2008 throw new AssertionError("annotation tree hasn't been attributed yet: " + a);
jjg@308 2009 validateAnnotation(a);
jjg@308 2010
jjg@308 2011 if (!isTypeAnnotation(a, isTypeParameter))
jjg@308 2012 log.error(a.pos(), "annotation.type.not.applicable");
jjg@308 2013 }
jjg@308 2014
duke@1 2015 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2016 boolean isOverrider(Symbol s) {
duke@1 2017 if (s.kind != MTH || s.isStatic())
duke@1 2018 return false;
duke@1 2019 MethodSymbol m = (MethodSymbol)s;
duke@1 2020 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2021 for (Type sup : types.closure(owner.type)) {
duke@1 2022 if (sup == owner.type)
duke@1 2023 continue; // skip "this"
duke@1 2024 Scope scope = sup.tsym.members();
duke@1 2025 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2026 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2027 return true;
duke@1 2028 }
duke@1 2029 }
duke@1 2030 return false;
duke@1 2031 }
duke@1 2032
jjg@308 2033 /** Is the annotation applicable to type annotations */
jjg@308 2034 boolean isTypeAnnotation(JCTypeAnnotation a, boolean isTypeParameter) {
jjg@308 2035 Attribute.Compound atTarget =
jjg@308 2036 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
jjg@308 2037 if (atTarget == null) return true;
jjg@308 2038 Attribute atValue = atTarget.member(names.value);
jjg@308 2039 if (!(atValue instanceof Attribute.Array)) return true; // error recovery
jjg@308 2040 Attribute.Array arr = (Attribute.Array) atValue;
jjg@308 2041 for (Attribute app : arr.values) {
jjg@308 2042 if (!(app instanceof Attribute.Enum)) return true; // recovery
jjg@308 2043 Attribute.Enum e = (Attribute.Enum) app;
jjg@308 2044 if (!isTypeParameter && e.value.name == names.TYPE_USE)
jjg@308 2045 return true;
jjg@308 2046 else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER)
jjg@308 2047 return true;
jjg@308 2048 }
jjg@308 2049 return false;
jjg@308 2050 }
jjg@308 2051
duke@1 2052 /** Is the annotation applicable to the symbol? */
duke@1 2053 boolean annotationApplicable(JCAnnotation a, Symbol s) {
duke@1 2054 Attribute.Compound atTarget =
duke@1 2055 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
duke@1 2056 if (atTarget == null) return true;
duke@1 2057 Attribute atValue = atTarget.member(names.value);
duke@1 2058 if (!(atValue instanceof Attribute.Array)) return true; // error recovery
duke@1 2059 Attribute.Array arr = (Attribute.Array) atValue;
duke@1 2060 for (Attribute app : arr.values) {
duke@1 2061 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2062 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2063 if (e.value.name == names.TYPE)
duke@1 2064 { if (s.kind == TYP) return true; }
duke@1 2065 else if (e.value.name == names.FIELD)
duke@1 2066 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2067 else if (e.value.name == names.METHOD)
duke@1 2068 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2069 else if (e.value.name == names.PARAMETER)
duke@1 2070 { if (s.kind == VAR &&
duke@1 2071 s.owner.kind == MTH &&
duke@1 2072 (s.flags() & PARAMETER) != 0)
duke@1 2073 return true;
duke@1 2074 }
duke@1 2075 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2076 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2077 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2078 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2079 (s.flags() & PARAMETER) == 0)
duke@1 2080 return true;
duke@1 2081 }
duke@1 2082 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2083 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2084 return true;
duke@1 2085 }
duke@1 2086 else if (e.value.name == names.PACKAGE)
duke@1 2087 { if (s.kind == PCK) return true; }
jjg@308 2088 else if (e.value.name == names.TYPE_USE)
jjg@308 2089 { if (s.kind == TYP ||
jjg@308 2090 s.kind == VAR ||
jjg@308 2091 (s.kind == MTH && !s.isConstructor() &&
jjg@308 2092 s.type.getReturnType().tag != VOID))
jjg@308 2093 return true;
jjg@308 2094 }
duke@1 2095 else
duke@1 2096 return true; // recovery
duke@1 2097 }
duke@1 2098 return false;
duke@1 2099 }
duke@1 2100
duke@1 2101 /** Check an annotation value.
duke@1 2102 */
duke@1 2103 public void validateAnnotation(JCAnnotation a) {
duke@1 2104 if (a.type.isErroneous()) return;
duke@1 2105
duke@1 2106 // collect an inventory of the members
duke@1 2107 Set<MethodSymbol> members = new HashSet<MethodSymbol>();
duke@1 2108 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2109 e != null;
duke@1 2110 e = e.sibling)
duke@1 2111 if (e.sym.kind == MTH)
duke@1 2112 members.add((MethodSymbol) e.sym);
duke@1 2113
duke@1 2114 // count them off as they're annotated
duke@1 2115 for (JCTree arg : a.args) {
duke@1 2116 if (arg.getTag() != JCTree.ASSIGN) continue; // recovery
duke@1 2117 JCAssign assign = (JCAssign) arg;
duke@1 2118 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2119 if (m == null || m.type.isErroneous()) continue;
duke@1 2120 if (!members.remove(m))
jjg@479 2121 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2122 m.name, a.type);
duke@1 2123 if (assign.rhs.getTag() == ANNOTATION)
duke@1 2124 validateAnnotation((JCAnnotation)assign.rhs);
duke@1 2125 }
duke@1 2126
duke@1 2127 // all the remaining ones better have default values
duke@1 2128 for (MethodSymbol m : members)
duke@1 2129 if (m.defaultValue == null && !m.type.isErroneous())
duke@1 2130 log.error(a.pos(), "annotation.missing.default.value",
duke@1 2131 a.type, m.name);
duke@1 2132
duke@1 2133 // special case: java.lang.annotation.Target must not have
duke@1 2134 // repeated values in its value member
duke@1 2135 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2136 a.args.tail == null)
duke@1 2137 return;
duke@1 2138
duke@1 2139 if (a.args.head.getTag() != JCTree.ASSIGN) return; // error recovery
duke@1 2140 JCAssign assign = (JCAssign) a.args.head;
duke@1 2141 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2142 if (m.name != names.value) return;
duke@1 2143 JCTree rhs = assign.rhs;
duke@1 2144 if (rhs.getTag() != JCTree.NEWARRAY) return;
duke@1 2145 JCNewArray na = (JCNewArray) rhs;
duke@1 2146 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2147 for (JCTree elem : na.elems) {
duke@1 2148 if (!targets.add(TreeInfo.symbol(elem))) {
duke@1 2149 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2150 }
duke@1 2151 }
duke@1 2152 }
duke@1 2153
duke@1 2154 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 2155 if (allowAnnotations &&
duke@1 2156 lint.isEnabled(Lint.LintCategory.DEP_ANN) &&
duke@1 2157 (s.flags() & DEPRECATED) != 0 &&
duke@1 2158 !syms.deprecatedType.isErroneous() &&
duke@1 2159 s.attribute(syms.deprecatedType.tsym) == null) {
jjg@612 2160 log.warning(Lint.LintCategory.DEP_ANN,
jjg@612 2161 pos, "missing.deprecated.annotation");
duke@1 2162 }
duke@1 2163 }
duke@1 2164
duke@1 2165 /* *************************************************************************
duke@1 2166 * Check for recursive annotation elements.
duke@1 2167 **************************************************************************/
duke@1 2168
duke@1 2169 /** Check for cycles in the graph of annotation elements.
duke@1 2170 */
duke@1 2171 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 2172 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
duke@1 2173 assert (tree.sym.flags_field & LOCKED) == 0;
duke@1 2174 try {
duke@1 2175 tree.sym.flags_field |= LOCKED;
duke@1 2176 for (JCTree def : tree.defs) {
duke@1 2177 if (def.getTag() != JCTree.METHODDEF) continue;
duke@1 2178 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 2179 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 2180 }
duke@1 2181 } finally {
duke@1 2182 tree.sym.flags_field &= ~LOCKED;
duke@1 2183 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 2184 }
duke@1 2185 }
duke@1 2186
duke@1 2187 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 2188 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 2189 return;
duke@1 2190 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 2191 log.error(pos, "cyclic.annotation.element");
duke@1 2192 return;
duke@1 2193 }
duke@1 2194 try {
duke@1 2195 tsym.flags_field |= LOCKED;
duke@1 2196 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 2197 Symbol s = e.sym;
duke@1 2198 if (s.kind != Kinds.MTH)
duke@1 2199 continue;
duke@1 2200 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 2201 }
duke@1 2202 } finally {
duke@1 2203 tsym.flags_field &= ~LOCKED;
duke@1 2204 tsym.flags_field |= ACYCLIC_ANN;
duke@1 2205 }
duke@1 2206 }
duke@1 2207
duke@1 2208 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
duke@1 2209 switch (type.tag) {
duke@1 2210 case TypeTags.CLASS:
duke@1 2211 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 2212 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 2213 break;
duke@1 2214 case TypeTags.ARRAY:
duke@1 2215 checkAnnotationResType(pos, types.elemtype(type));
duke@1 2216 break;
duke@1 2217 default:
duke@1 2218 break; // int etc
duke@1 2219 }
duke@1 2220 }
duke@1 2221
duke@1 2222 /* *************************************************************************
duke@1 2223 * Check for cycles in the constructor call graph.
duke@1 2224 **************************************************************************/
duke@1 2225
duke@1 2226 /** Check for cycles in the graph of constructors calling other
duke@1 2227 * constructors.
duke@1 2228 */
duke@1 2229 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 2230 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 2231
duke@1 2232 // enter each constructor this-call into the map
duke@1 2233 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 2234 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 2235 if (app == null) continue;
duke@1 2236 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 2237 if (TreeInfo.name(app.meth) == names._this) {
duke@1 2238 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 2239 } else {
duke@1 2240 meth.sym.flags_field |= ACYCLIC;
duke@1 2241 }
duke@1 2242 }
duke@1 2243
duke@1 2244 // Check for cycles in the map
duke@1 2245 Symbol[] ctors = new Symbol[0];
duke@1 2246 ctors = callMap.keySet().toArray(ctors);
duke@1 2247 for (Symbol caller : ctors) {
duke@1 2248 checkCyclicConstructor(tree, caller, callMap);
duke@1 2249 }
duke@1 2250 }
duke@1 2251
duke@1 2252 /** Look in the map to see if the given constructor is part of a
duke@1 2253 * call cycle.
duke@1 2254 */
duke@1 2255 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 2256 Map<Symbol,Symbol> callMap) {
duke@1 2257 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 2258 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 2259 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 2260 "recursive.ctor.invocation");
duke@1 2261 } else {
duke@1 2262 ctor.flags_field |= LOCKED;
duke@1 2263 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 2264 ctor.flags_field &= ~LOCKED;
duke@1 2265 }
duke@1 2266 ctor.flags_field |= ACYCLIC;
duke@1 2267 }
duke@1 2268 }
duke@1 2269
duke@1 2270 /* *************************************************************************
duke@1 2271 * Miscellaneous
duke@1 2272 **************************************************************************/
duke@1 2273
duke@1 2274 /**
duke@1 2275 * Return the opcode of the operator but emit an error if it is an
duke@1 2276 * error.
duke@1 2277 * @param pos position for error reporting.
duke@1 2278 * @param operator an operator
duke@1 2279 * @param tag a tree tag
duke@1 2280 * @param left type of left hand side
duke@1 2281 * @param right type of right hand side
duke@1 2282 */
duke@1 2283 int checkOperator(DiagnosticPosition pos,
duke@1 2284 OperatorSymbol operator,
duke@1 2285 int tag,
duke@1 2286 Type left,
duke@1 2287 Type right) {
duke@1 2288 if (operator.opcode == ByteCodes.error) {
duke@1 2289 log.error(pos,
duke@1 2290 "operator.cant.be.applied",
duke@1 2291 treeinfo.operatorName(tag),
mcimadamore@80 2292 List.of(left, right));
duke@1 2293 }
duke@1 2294 return operator.opcode;
duke@1 2295 }
duke@1 2296
duke@1 2297
duke@1 2298 /**
duke@1 2299 * Check for division by integer constant zero
duke@1 2300 * @param pos Position for error reporting.
duke@1 2301 * @param operator The operator for the expression
duke@1 2302 * @param operand The right hand operand for the expression
duke@1 2303 */
duke@1 2304 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 2305 if (operand.constValue() != null
duke@1 2306 && lint.isEnabled(Lint.LintCategory.DIVZERO)
duke@1 2307 && operand.tag <= LONG
duke@1 2308 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 2309 int opc = ((OperatorSymbol)operator).opcode;
duke@1 2310 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 2311 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
jjg@612 2312 log.warning(Lint.LintCategory.DIVZERO, pos, "div.zero");
duke@1 2313 }
duke@1 2314 }
duke@1 2315 }
duke@1 2316
duke@1 2317 /**
duke@1 2318 * Check for empty statements after if
duke@1 2319 */
duke@1 2320 void checkEmptyIf(JCIf tree) {
duke@1 2321 if (tree.thenpart.getTag() == JCTree.SKIP && tree.elsepart == null && lint.isEnabled(Lint.LintCategory.EMPTY))
jjg@612 2322 log.warning(Lint.LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 2323 }
duke@1 2324
duke@1 2325 /** Check that symbol is unique in given scope.
duke@1 2326 * @param pos Position for error reporting.
duke@1 2327 * @param sym The symbol.
duke@1 2328 * @param s The scope.
duke@1 2329 */
duke@1 2330 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2331 if (sym.type.isErroneous())
duke@1 2332 return true;
duke@1 2333 if (sym.owner.name == names.any) return false;
duke@1 2334 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 2335 if (sym != e.sym &&
duke@1 2336 sym.kind == e.sym.kind &&
duke@1 2337 sym.name != names.error &&
mcimadamore@252 2338 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
duke@1 2339 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS))
duke@1 2340 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@252 2341 else if (sym.kind == MTH && !types.overrideEquivalent(sym.type, e.sym.type))
mcimadamore@252 2342 duplicateErasureError(pos, sym, e.sym);
duke@1 2343 else
duke@1 2344 duplicateError(pos, e.sym);
duke@1 2345 return false;
duke@1 2346 }
duke@1 2347 }
duke@1 2348 return true;
duke@1 2349 }
mcimadamore@252 2350 //where
mcimadamore@252 2351 /** Report duplicate declaration error.
mcimadamore@252 2352 */
mcimadamore@252 2353 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@252 2354 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@252 2355 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@252 2356 }
mcimadamore@252 2357 }
duke@1 2358
duke@1 2359 /** Check that single-type import is not already imported or top-level defined,
duke@1 2360 * but make an exception for two single-type imports which denote the same type.
duke@1 2361 * @param pos Position for error reporting.
duke@1 2362 * @param sym The symbol.
duke@1 2363 * @param s The scope
duke@1 2364 */
duke@1 2365 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2366 return checkUniqueImport(pos, sym, s, false);
duke@1 2367 }
duke@1 2368
duke@1 2369 /** Check that static single-type import is not already imported or top-level defined,
duke@1 2370 * but make an exception for two single-type imports which denote the same type.
duke@1 2371 * @param pos Position for error reporting.
duke@1 2372 * @param sym The symbol.
duke@1 2373 * @param s The scope
duke@1 2374 * @param staticImport Whether or not this was a static import
duke@1 2375 */
duke@1 2376 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2377 return checkUniqueImport(pos, sym, s, true);
duke@1 2378 }
duke@1 2379
duke@1 2380 /** Check that single-type import is not already imported or top-level defined,
duke@1 2381 * but make an exception for two single-type imports which denote the same type.
duke@1 2382 * @param pos Position for error reporting.
duke@1 2383 * @param sym The symbol.
duke@1 2384 * @param s The scope.
duke@1 2385 * @param staticImport Whether or not this was a static import
duke@1 2386 */
duke@1 2387 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 2388 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 2389 // is encountered class entered via a class declaration?
duke@1 2390 boolean isClassDecl = e.scope == s;
duke@1 2391 if ((isClassDecl || sym != e.sym) &&
duke@1 2392 sym.kind == e.sym.kind &&
duke@1 2393 sym.name != names.error) {
duke@1 2394 if (!e.sym.type.isErroneous()) {
duke@1 2395 String what = e.sym.toString();
duke@1 2396 if (!isClassDecl) {
duke@1 2397 if (staticImport)
duke@1 2398 log.error(pos, "already.defined.static.single.import", what);
duke@1 2399 else
duke@1 2400 log.error(pos, "already.defined.single.import", what);
duke@1 2401 }
duke@1 2402 else if (sym != e.sym)
duke@1 2403 log.error(pos, "already.defined.this.unit", what);
duke@1 2404 }
duke@1 2405 return false;
duke@1 2406 }
duke@1 2407 }
duke@1 2408 return true;
duke@1 2409 }
duke@1 2410
duke@1 2411 /** Check that a qualified name is in canonical form (for import decls).
duke@1 2412 */
duke@1 2413 public void checkCanonical(JCTree tree) {
duke@1 2414 if (!isCanonical(tree))
duke@1 2415 log.error(tree.pos(), "import.requires.canonical",
duke@1 2416 TreeInfo.symbol(tree));
duke@1 2417 }
duke@1 2418 // where
duke@1 2419 private boolean isCanonical(JCTree tree) {
duke@1 2420 while (tree.getTag() == JCTree.SELECT) {
duke@1 2421 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 2422 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 2423 return false;
duke@1 2424 tree = s.selected;
duke@1 2425 }
duke@1 2426 return true;
duke@1 2427 }
duke@1 2428
duke@1 2429 private class ConversionWarner extends Warner {
duke@1 2430 final String key;
duke@1 2431 final Type found;
duke@1 2432 final Type expected;
duke@1 2433 public ConversionWarner(DiagnosticPosition pos, String key, Type found, Type expected) {
duke@1 2434 super(pos);
duke@1 2435 this.key = key;
duke@1 2436 this.found = found;
duke@1 2437 this.expected = expected;
duke@1 2438 }
duke@1 2439
jjg@398 2440 @Override
duke@1 2441 public void warnUnchecked() {
duke@1 2442 boolean warned = this.warned;
duke@1 2443 super.warnUnchecked();
duke@1 2444 if (warned) return; // suppress redundant diagnostics
mcimadamore@89 2445 Object problem = diags.fragment(key);
duke@1 2446 Check.this.warnUnchecked(pos(), "prob.found.req", problem, found, expected);
duke@1 2447 }
duke@1 2448 }
duke@1 2449
duke@1 2450 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2451 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 2452 }
duke@1 2453
duke@1 2454 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2455 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 2456 }
duke@1 2457 }

mercurial