src/share/classes/com/sun/tools/javac/comp/Check.java

Thu, 15 Aug 2013 22:36:08 +0200

author
jlahoda
date
Thu, 15 Aug 2013 22:36:08 +0200
changeset 1956
f657d400c736
parent 1945
f7f271bd74a2
child 1959
55da6b3a6940
permissions
-rw-r--r--

8022508: javac crashes if the generics arity of a base class is wrong
Reviewed-by: mcimadamore, vromero

duke@1 1 /*
jjg@1492 2 * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
jjg@1521 29
ohrstrom@1384 30 import javax.tools.JavaFileManager;
duke@1 31
duke@1 32 import com.sun.tools.javac.code.*;
duke@1 33 import com.sun.tools.javac.jvm.*;
duke@1 34 import com.sun.tools.javac.tree.*;
duke@1 35 import com.sun.tools.javac.util.*;
duke@1 36 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 37 import com.sun.tools.javac.util.List;
duke@1 38
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 43 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 44 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1550 45 import com.sun.tools.javac.comp.Infer.FreeTypeListener;
mcimadamore@1510 46 import com.sun.tools.javac.tree.JCTree.*;
mcimadamore@1510 47 import com.sun.tools.javac.tree.JCTree.JCPolyExpression.*;
duke@1 48
duke@1 49 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 50 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 51 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 52 import static com.sun.tools.javac.code.Kinds.*;
jjg@1374 53 import static com.sun.tools.javac.code.TypeTag.*;
jjg@1374 54 import static com.sun.tools.javac.code.TypeTag.WILDCARD;
duke@1 55
jjg@1127 56 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 57
duke@1 58 /** Type checking helper class for the attribution phase.
duke@1 59 *
jjg@581 60 * <p><b>This is NOT part of any supported API.
jjg@581 61 * If you write code that depends on this, you do so at your own risk.
duke@1 62 * This code and its internal interfaces are subject to change or
duke@1 63 * deletion without notice.</b>
duke@1 64 */
duke@1 65 public class Check {
duke@1 66 protected static final Context.Key<Check> checkKey =
duke@1 67 new Context.Key<Check>();
duke@1 68
jjg@113 69 private final Names names;
duke@1 70 private final Log log;
mcimadamore@1219 71 private final Resolve rs;
duke@1 72 private final Symtab syms;
mcimadamore@690 73 private final Enter enter;
mcimadamore@1347 74 private final DeferredAttr deferredAttr;
duke@1 75 private final Infer infer;
duke@1 76 private final Types types;
mcimadamore@89 77 private final JCDiagnostic.Factory diags;
mcimadamore@359 78 private boolean warnOnSyntheticConflicts;
jjg@576 79 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 80 private boolean enableSunApiLintControl;
duke@1 81 private final TreeInfo treeinfo;
ohrstrom@1384 82 private final JavaFileManager fileManager;
jjg@1569 83 private final Profile profile;
duke@1 84
duke@1 85 // The set of lint options currently in effect. It is initialized
duke@1 86 // from the context, and then is set/reset as needed by Attr as it
duke@1 87 // visits all the various parts of the trees during attribution.
duke@1 88 private Lint lint;
duke@1 89
mcimadamore@795 90 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 91 // Attr as it visits new method declarations.
mcimadamore@795 92 private MethodSymbol method;
mcimadamore@795 93
duke@1 94 public static Check instance(Context context) {
duke@1 95 Check instance = context.get(checkKey);
duke@1 96 if (instance == null)
duke@1 97 instance = new Check(context);
duke@1 98 return instance;
duke@1 99 }
duke@1 100
duke@1 101 protected Check(Context context) {
duke@1 102 context.put(checkKey, this);
duke@1 103
jjg@113 104 names = Names.instance(context);
jjg@1521 105 dfltTargetMeta = new Name[] { names.PACKAGE, names.TYPE,
jjg@1521 106 names.FIELD, names.METHOD, names.CONSTRUCTOR,
jjg@1521 107 names.ANNOTATION_TYPE, names.LOCAL_VARIABLE, names.PARAMETER};
duke@1 108 log = Log.instance(context);
mcimadamore@1219 109 rs = Resolve.instance(context);
duke@1 110 syms = Symtab.instance(context);
mcimadamore@690 111 enter = Enter.instance(context);
mcimadamore@1347 112 deferredAttr = DeferredAttr.instance(context);
duke@1 113 infer = Infer.instance(context);
jjg@1569 114 types = Types.instance(context);
mcimadamore@89 115 diags = JCDiagnostic.Factory.instance(context);
duke@1 116 Options options = Options.instance(context);
duke@1 117 lint = Lint.instance(context);
duke@1 118 treeinfo = TreeInfo.instance(context);
ohrstrom@1384 119 fileManager = context.get(JavaFileManager.class);
duke@1 120
duke@1 121 Source source = Source.instance(context);
duke@1 122 allowGenerics = source.allowGenerics();
mcimadamore@1219 123 allowVarargs = source.allowVarargs();
duke@1 124 allowAnnotations = source.allowAnnotations();
jjg@398 125 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 126 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
mcimadamore@1393 127 allowDefaultMethods = source.allowDefaultMethods();
mcimadamore@1415 128 allowStrictMethodClashCheck = source.allowStrictMethodClashCheck();
jjg@1157 129 complexInference = options.isSet("complexinference");
jjg@700 130 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 131 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 132 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 133
jjg@398 134 Target target = Target.instance(context);
jjg@398 135 syntheticNameChar = target.syntheticNameChar();
jjg@398 136
jjg@1569 137 profile = Profile.instance(context);
jjg@1569 138
duke@1 139 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 140 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 141 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 142 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 143
jjg@60 144 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 145 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 146 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 147 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 148 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 149 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 150
mcimadamore@852 151 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 152 }
duke@1 153
duke@1 154 /** Switch: generics enabled?
duke@1 155 */
duke@1 156 boolean allowGenerics;
duke@1 157
mcimadamore@1219 158 /** Switch: varargs enabled?
mcimadamore@1219 159 */
mcimadamore@1219 160 boolean allowVarargs;
mcimadamore@1219 161
duke@1 162 /** Switch: annotations enabled?
duke@1 163 */
duke@1 164 boolean allowAnnotations;
duke@1 165
jjg@398 166 /** Switch: covariant returns enabled?
jjg@398 167 */
jjg@398 168 boolean allowCovariantReturns;
jjg@398 169
mcimadamore@795 170 /** Switch: simplified varargs enabled?
mcimadamore@795 171 */
mcimadamore@795 172 boolean allowSimplifiedVarargs;
mcimadamore@795 173
mcimadamore@1393 174 /** Switch: default methods enabled?
mcimadamore@1393 175 */
mcimadamore@1393 176 boolean allowDefaultMethods;
mcimadamore@1393 177
mcimadamore@1393 178 /** Switch: should unrelated return types trigger a method clash?
mcimadamore@1393 179 */
mcimadamore@1393 180 boolean allowStrictMethodClashCheck;
mcimadamore@1393 181
duke@1 182 /** Switch: -complexinference option set?
duke@1 183 */
duke@1 184 boolean complexInference;
duke@1 185
jjg@398 186 /** Character for synthetic names
jjg@398 187 */
jjg@398 188 char syntheticNameChar;
jjg@398 189
duke@1 190 /** A table mapping flat names of all compiled classes in this run to their
duke@1 191 * symbols; maintained from outside.
duke@1 192 */
duke@1 193 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 194
duke@1 195 /** A handler for messages about deprecated usage.
duke@1 196 */
duke@1 197 private MandatoryWarningHandler deprecationHandler;
duke@1 198
duke@1 199 /** A handler for messages about unchecked or unsafe usage.
duke@1 200 */
duke@1 201 private MandatoryWarningHandler uncheckedHandler;
duke@1 202
jjg@582 203 /** A handler for messages about using proprietary API.
jjg@377 204 */
jjg@377 205 private MandatoryWarningHandler sunApiHandler;
duke@1 206
mcimadamore@852 207 /** A handler for deferred lint warnings.
mcimadamore@852 208 */
mcimadamore@852 209 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 210
duke@1 211 /* *************************************************************************
duke@1 212 * Errors and Warnings
duke@1 213 **************************************************************************/
duke@1 214
duke@1 215 Lint setLint(Lint newLint) {
duke@1 216 Lint prev = lint;
duke@1 217 lint = newLint;
duke@1 218 return prev;
duke@1 219 }
duke@1 220
vromero@1864 221 /* This idiom should be used only in cases when it is needed to set the lint
vromero@1864 222 * of an environment that has been created in a phase previous to annotations
vromero@1864 223 * processing.
vromero@1864 224 */
vromero@1864 225 Lint getLint() {
vromero@1864 226 return lint;
vromero@1864 227 }
vromero@1864 228
mcimadamore@852 229 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 230 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 231 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 232 return prev;
mcimadamore@852 233 }
mcimadamore@852 234
mcimadamore@795 235 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 236 MethodSymbol prev = method;
mcimadamore@795 237 method = newMethod;
mcimadamore@795 238 return prev;
mcimadamore@795 239 }
mcimadamore@795 240
duke@1 241 /** Warn about deprecated symbol.
duke@1 242 * @param pos Position to be used for error reporting.
duke@1 243 * @param sym The deprecated symbol.
duke@1 244 */
duke@1 245 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 246 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 247 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 248 }
duke@1 249
duke@1 250 /** Warn about unchecked operation.
duke@1 251 * @param pos Position to be used for error reporting.
duke@1 252 * @param msg A string describing the problem.
duke@1 253 */
duke@1 254 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 255 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 256 uncheckedHandler.report(pos, msg, args);
duke@1 257 }
duke@1 258
mcimadamore@580 259 /** Warn about unsafe vararg method decl.
mcimadamore@580 260 * @param pos Position to be used for error reporting.
mcimadamore@580 261 */
mcimadamore@795 262 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 263 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 264 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 265 }
mcimadamore@580 266
jjg@582 267 /** Warn about using proprietary API.
jjg@377 268 * @param pos Position to be used for error reporting.
jjg@377 269 * @param msg A string describing the problem.
jjg@377 270 */
jjg@377 271 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 272 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 273 sunApiHandler.report(pos, msg, args);
jjg@377 274 }
jjg@377 275
jjg@505 276 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 277 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 278 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 279 }
jjg@505 280
duke@1 281 /**
duke@1 282 * Report any deferred diagnostics.
duke@1 283 */
duke@1 284 public void reportDeferredDiagnostics() {
duke@1 285 deprecationHandler.reportDeferredDiagnostic();
duke@1 286 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 287 sunApiHandler.reportDeferredDiagnostic();
duke@1 288 }
duke@1 289
duke@1 290
duke@1 291 /** Report a failure to complete a class.
duke@1 292 * @param pos Position to be used for error reporting.
duke@1 293 * @param ex The failure to report.
duke@1 294 */
duke@1 295 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
mcimadamore@1613 296 log.error(JCDiagnostic.DiagnosticFlag.NON_DEFERRABLE, pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 297 if (ex instanceof ClassReader.BadClassFile
jjg@576 298 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 299 else return syms.errType;
duke@1 300 }
duke@1 301
duke@1 302 /** Report an error that wrong type tag was found.
duke@1 303 * @param pos Position to be used for error reporting.
duke@1 304 * @param required An internationalized string describing the type tag
duke@1 305 * required.
duke@1 306 * @param found The type that was found.
duke@1 307 */
duke@1 308 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 309 // this error used to be raised by the parser,
jrose@267 310 // but has been delayed to this point:
jjg@1374 311 if (found instanceof Type && ((Type)found).hasTag(VOID)) {
jrose@267 312 log.error(pos, "illegal.start.of.type");
jrose@267 313 return syms.errType;
jrose@267 314 }
duke@1 315 log.error(pos, "type.found.req", found, required);
jjg@110 316 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 317 }
duke@1 318
duke@1 319 /** Report an error that symbol cannot be referenced before super
duke@1 320 * has been called.
duke@1 321 * @param pos Position to be used for error reporting.
duke@1 322 * @param sym The referenced symbol.
duke@1 323 */
duke@1 324 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 325 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 326 }
duke@1 327
duke@1 328 /** Report duplicate declaration error.
duke@1 329 */
duke@1 330 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 331 if (!sym.type.isErroneous()) {
mcimadamore@1085 332 Symbol location = sym.location();
mcimadamore@1085 333 if (location.kind == MTH &&
mcimadamore@1085 334 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 335 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 336 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 337 sym.location().enclClass());
mcimadamore@1085 338 } else {
mcimadamore@1085 339 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 340 kindName(sym.location()), sym.location());
mcimadamore@1085 341 }
duke@1 342 }
duke@1 343 }
duke@1 344
duke@1 345 /** Report array/varargs duplicate declaration
duke@1 346 */
duke@1 347 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 348 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 349 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 350 }
duke@1 351 }
duke@1 352
duke@1 353 /* ************************************************************************
duke@1 354 * duplicate declaration checking
duke@1 355 *************************************************************************/
duke@1 356
duke@1 357 /** Check that variable does not hide variable with same name in
duke@1 358 * immediately enclosing local scope.
duke@1 359 * @param pos Position for error reporting.
duke@1 360 * @param v The symbol.
duke@1 361 * @param s The scope.
duke@1 362 */
duke@1 363 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 364 if (s.next != null) {
duke@1 365 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 366 e.scope != null && e.sym.owner == v.owner;
duke@1 367 e = e.next()) {
duke@1 368 if (e.sym.kind == VAR &&
duke@1 369 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 370 v.name != names.error) {
duke@1 371 duplicateError(pos, e.sym);
duke@1 372 return;
duke@1 373 }
duke@1 374 }
duke@1 375 }
duke@1 376 }
duke@1 377
duke@1 378 /** Check that a class or interface does not hide a class or
duke@1 379 * interface with same name in immediately enclosing local scope.
duke@1 380 * @param pos Position for error reporting.
duke@1 381 * @param c The symbol.
duke@1 382 * @param s The scope.
duke@1 383 */
duke@1 384 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 385 if (s.next != null) {
duke@1 386 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 387 e.scope != null && e.sym.owner == c.owner;
duke@1 388 e = e.next()) {
jjg@1374 389 if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) &&
duke@1 390 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 391 c.name != names.error) {
duke@1 392 duplicateError(pos, e.sym);
duke@1 393 return;
duke@1 394 }
duke@1 395 }
duke@1 396 }
duke@1 397 }
duke@1 398
duke@1 399 /** Check that class does not have the same name as one of
duke@1 400 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 401 * return true if class is unique in its enclosing scope.
duke@1 402 * @param pos Position for error reporting.
duke@1 403 * @param name The class name.
duke@1 404 * @param s The enclosing scope.
duke@1 405 */
duke@1 406 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 407 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 408 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 409 duplicateError(pos, e.sym);
duke@1 410 return false;
duke@1 411 }
duke@1 412 }
duke@1 413 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 414 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 415 duplicateError(pos, sym);
duke@1 416 return true;
duke@1 417 }
duke@1 418 }
duke@1 419 return true;
duke@1 420 }
duke@1 421
duke@1 422 /* *************************************************************************
duke@1 423 * Class name generation
duke@1 424 **************************************************************************/
duke@1 425
duke@1 426 /** Return name of local class.
jjg@1358 427 * This is of the form {@code <enclClass> $ n <classname> }
duke@1 428 * where
duke@1 429 * enclClass is the flat name of the enclosing class,
duke@1 430 * classname is the simple name of the local class
duke@1 431 */
duke@1 432 Name localClassName(ClassSymbol c) {
duke@1 433 for (int i=1; ; i++) {
duke@1 434 Name flatname = names.
duke@1 435 fromString("" + c.owner.enclClass().flatname +
jjg@398 436 syntheticNameChar + i +
duke@1 437 c.name);
duke@1 438 if (compiled.get(flatname) == null) return flatname;
duke@1 439 }
duke@1 440 }
duke@1 441
duke@1 442 /* *************************************************************************
duke@1 443 * Type Checking
duke@1 444 **************************************************************************/
duke@1 445
mcimadamore@1238 446 /**
mcimadamore@1238 447 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 448 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 449 * vary significantly.
mcimadamore@1238 450 */
mcimadamore@1348 451 public interface CheckContext {
mcimadamore@1238 452 /**
mcimadamore@1238 453 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 454 */
mcimadamore@1238 455 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 456 /**
mcimadamore@1238 457 * Report a check error
mcimadamore@1238 458 */
mcimadamore@1296 459 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 460 /**
mcimadamore@1238 461 * Obtain a warner for this check context
mcimadamore@1238 462 */
mcimadamore@1238 463 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 464
mcimadamore@1337 465 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 466
mcimadamore@1347 467 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1238 468 }
mcimadamore@1238 469
mcimadamore@1238 470 /**
mcimadamore@1238 471 * This class represent a check context that is nested within another check
mcimadamore@1238 472 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 473 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 474 * the forwarding pattern.
mcimadamore@1238 475 */
mcimadamore@1238 476 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 477 CheckContext enclosingContext;
mcimadamore@1238 478
mcimadamore@1238 479 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 480 this.enclosingContext = enclosingContext;
mcimadamore@1238 481 }
mcimadamore@1238 482
mcimadamore@1238 483 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 484 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 485 }
mcimadamore@1238 486
mcimadamore@1296 487 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 488 enclosingContext.report(pos, details);
mcimadamore@1238 489 }
mcimadamore@1238 490
mcimadamore@1238 491 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 492 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 493 }
mcimadamore@1337 494
mcimadamore@1337 495 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 496 return enclosingContext.inferenceContext();
mcimadamore@1337 497 }
mcimadamore@1347 498
mcimadamore@1347 499 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 500 return enclosingContext.deferredAttrContext();
mcimadamore@1347 501 }
mcimadamore@1238 502 }
mcimadamore@1238 503
mcimadamore@1238 504 /**
mcimadamore@1238 505 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 506 */
mcimadamore@1238 507 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 508 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 509 log.error(pos, "prob.found.req", details);
mcimadamore@1238 510 }
mcimadamore@1238 511 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 512 return types.isAssignable(found, req, warn);
mcimadamore@1238 513 }
mcimadamore@1238 514
mcimadamore@1238 515 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 516 return convertWarner(pos, found, req);
mcimadamore@1238 517 }
mcimadamore@1337 518
mcimadamore@1337 519 public InferenceContext inferenceContext() {
mcimadamore@1337 520 return infer.emptyContext;
mcimadamore@1337 521 }
mcimadamore@1347 522
mcimadamore@1347 523 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 524 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 525 }
mcimadamore@1238 526 };
mcimadamore@1238 527
duke@1 528 /** Check that a given type is assignable to a given proto-type.
duke@1 529 * If it is, return the type, otherwise return errType.
duke@1 530 * @param pos Position to be used for error reporting.
duke@1 531 * @param found The type that was found.
duke@1 532 * @param req The type that was required.
duke@1 533 */
duke@1 534 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 535 return checkType(pos, found, req, basicHandler);
darcy@609 536 }
darcy@609 537
mcimadamore@1337 538 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 539 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 540 if (inferenceContext.free(req)) {
mcimadamore@1337 541 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 542 @Override
mcimadamore@1337 543 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1550 544 checkType(pos, found, inferenceContext.asInstType(req), checkContext);
mcimadamore@1337 545 }
mcimadamore@1337 546 });
mcimadamore@1337 547 }
jjg@1374 548 if (req.hasTag(ERROR))
duke@1 549 return req;
jjg@1374 550 if (req.hasTag(NONE))
duke@1 551 return found;
mcimadamore@1238 552 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 553 return found;
mcimadamore@1238 554 } else {
vromero@1826 555 if (found.isNumeric() && req.isNumeric()) {
mcimadamore@1296 556 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 557 return types.createErrorType(found);
mcimadamore@1238 558 }
mcimadamore@1296 559 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 560 return types.createErrorType(found);
duke@1 561 }
duke@1 562 }
duke@1 563
duke@1 564 /** Check that a given type can be cast to a given target type.
duke@1 565 * Return the result of the cast.
duke@1 566 * @param pos Position to be used for error reporting.
duke@1 567 * @param found The type that is being cast.
duke@1 568 * @param req The target type of the cast.
duke@1 569 */
duke@1 570 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 571 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 572 }
mcimadamore@1238 573 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 574 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 575 return req;
duke@1 576 } else {
mcimadamore@1296 577 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 578 return types.createErrorType(found);
duke@1 579 }
duke@1 580 }
mcimadamore@1237 581
mcimadamore@1237 582 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 583 * The problem should only be reported for non-292 cast
mcimadamore@1237 584 */
mcimadamore@1237 585 public void checkRedundantCast(Env<AttrContext> env, JCTypeCast tree) {
mcimadamore@1237 586 if (!tree.type.isErroneous() &&
mcimadamore@1348 587 (env.info.lint == null || env.info.lint.isEnabled(Lint.LintCategory.CAST))
mcimadamore@1348 588 && types.isSameType(tree.expr.type, tree.clazz.type)
jjg@1521 589 && !(ignoreAnnotatedCasts && TreeInfo.containsTypeAnnotation(tree.clazz))
mcimadamore@1348 590 && !is292targetTypeCast(tree)) {
mcimadamore@1237 591 log.warning(Lint.LintCategory.CAST,
mcimadamore@1237 592 tree.pos(), "redundant.cast", tree.expr.type);
mcimadamore@1237 593 }
mcimadamore@1237 594 }
mcimadamore@1237 595 //where
jjg@1521 596 private boolean is292targetTypeCast(JCTypeCast tree) {
jjg@1521 597 boolean is292targetTypeCast = false;
jjg@1521 598 JCExpression expr = TreeInfo.skipParens(tree.expr);
jjg@1521 599 if (expr.hasTag(APPLY)) {
jjg@1521 600 JCMethodInvocation apply = (JCMethodInvocation)expr;
jjg@1521 601 Symbol sym = TreeInfo.symbol(apply.meth);
jjg@1521 602 is292targetTypeCast = sym != null &&
jjg@1521 603 sym.kind == MTH &&
jjg@1521 604 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 605 }
jjg@1521 606 return is292targetTypeCast;
jjg@1521 607 }
mcimadamore@1237 608
jjg@1521 609 private static final boolean ignoreAnnotatedCasts = true;
duke@1 610
duke@1 611 /** Check that a type is within some bounds.
duke@1 612 *
jjg@1358 613 * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
duke@1 614 * type argument.
duke@1 615 * @param a The type that should be bounded by bs.
jjg@1358 616 * @param bound The bound.
duke@1 617 */
mcimadamore@1216 618 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 619 if (a.isUnbound()) {
mcimadamore@821 620 return true;
jjg@1374 621 } else if (!a.hasTag(WILDCARD)) {
mcimadamore@154 622 a = types.upperBound(a);
mcimadamore@1216 623 return types.isSubtype(a, bound);
mcimadamore@154 624 } else if (a.isExtendsBound()) {
mcimadamore@1415 625 return types.isCastable(bound, types.upperBound(a), types.noWarnings);
mcimadamore@154 626 } else if (a.isSuperBound()) {
mcimadamore@1216 627 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 628 }
mcimadamore@821 629 return true;
mcimadamore@154 630 }
duke@1 631
duke@1 632 /** Check that type is different from 'void'.
duke@1 633 * @param pos Position to be used for error reporting.
duke@1 634 * @param t The type to be checked.
duke@1 635 */
duke@1 636 Type checkNonVoid(DiagnosticPosition pos, Type t) {
jjg@1374 637 if (t.hasTag(VOID)) {
duke@1 638 log.error(pos, "void.not.allowed.here");
jjg@110 639 return types.createErrorType(t);
duke@1 640 } else {
duke@1 641 return t;
duke@1 642 }
duke@1 643 }
duke@1 644
mcimadamore@1496 645 Type checkClassOrArrayType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 646 if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
mcimadamore@1496 647 return typeTagError(pos,
mcimadamore@1496 648 diags.fragment("type.req.class.array"),
mcimadamore@1496 649 asTypeParam(t));
mcimadamore@1496 650 } else {
mcimadamore@1496 651 return t;
mcimadamore@1496 652 }
mcimadamore@1496 653 }
mcimadamore@1496 654
duke@1 655 /** Check that type is a class or interface type.
duke@1 656 * @param pos Position to be used for error reporting.
duke@1 657 * @param t The type to be checked.
duke@1 658 */
duke@1 659 Type checkClassType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 660 if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) {
duke@1 661 return typeTagError(pos,
mcimadamore@89 662 diags.fragment("type.req.class"),
mcimadamore@1496 663 asTypeParam(t));
mcimadamore@1496 664 } else {
duke@1 665 return t;
mcimadamore@1496 666 }
duke@1 667 }
mcimadamore@1496 668 //where
mcimadamore@1496 669 private Object asTypeParam(Type t) {
mcimadamore@1496 670 return (t.hasTag(TYPEVAR))
mcimadamore@1496 671 ? diags.fragment("type.parameter", t)
mcimadamore@1496 672 : t;
mcimadamore@1496 673 }
duke@1 674
mcimadamore@1352 675 /** Check that type is a valid qualifier for a constructor reference expression
mcimadamore@1352 676 */
mcimadamore@1352 677 Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 678 t = checkClassOrArrayType(pos, t);
jjg@1374 679 if (t.hasTag(CLASS)) {
mcimadamore@1352 680 if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
mcimadamore@1627 681 log.error(pos, "abstract.cant.be.instantiated", t.tsym);
mcimadamore@1352 682 t = types.createErrorType(t);
mcimadamore@1352 683 } else if ((t.tsym.flags() & ENUM) != 0) {
mcimadamore@1352 684 log.error(pos, "enum.cant.be.instantiated");
mcimadamore@1352 685 t = types.createErrorType(t);
mcimadamore@1627 686 } else {
mcimadamore@1627 687 t = checkClassType(pos, t, true);
mcimadamore@1627 688 }
mcimadamore@1627 689 } else if (t.hasTag(ARRAY)) {
mcimadamore@1627 690 if (!types.isReifiable(((ArrayType)t).elemtype)) {
mcimadamore@1627 691 log.error(pos, "generic.array.creation");
mcimadamore@1627 692 t = types.createErrorType(t);
mcimadamore@1352 693 }
mcimadamore@1352 694 }
mcimadamore@1352 695 return t;
mcimadamore@1352 696 }
mcimadamore@1352 697
duke@1 698 /** Check that type is a class or interface type.
duke@1 699 * @param pos Position to be used for error reporting.
duke@1 700 * @param t The type to be checked.
duke@1 701 * @param noBounds True if type bounds are illegal here.
duke@1 702 */
duke@1 703 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 704 t = checkClassType(pos, t);
duke@1 705 if (noBounds && t.isParameterized()) {
duke@1 706 List<Type> args = t.getTypeArguments();
duke@1 707 while (args.nonEmpty()) {
jjg@1374 708 if (args.head.hasTag(WILDCARD))
duke@1 709 return typeTagError(pos,
jjg@598 710 diags.fragment("type.req.exact"),
duke@1 711 args.head);
duke@1 712 args = args.tail;
duke@1 713 }
duke@1 714 }
duke@1 715 return t;
duke@1 716 }
duke@1 717
duke@1 718 /** Check that type is a reifiable class, interface or array type.
duke@1 719 * @param pos Position to be used for error reporting.
duke@1 720 * @param t The type to be checked.
duke@1 721 */
duke@1 722 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 723 t = checkClassOrArrayType(pos, t);
mcimadamore@1496 724 if (!t.isErroneous() && !types.isReifiable(t)) {
duke@1 725 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 726 return types.createErrorType(t);
duke@1 727 } else {
duke@1 728 return t;
duke@1 729 }
duke@1 730 }
duke@1 731
duke@1 732 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 733 * or a type variable.
duke@1 734 * @param pos Position to be used for error reporting.
duke@1 735 * @param t The type to be checked.
duke@1 736 */
duke@1 737 Type checkRefType(DiagnosticPosition pos, Type t) {
jjg@1374 738 if (t.isReference())
duke@1 739 return t;
jjg@1374 740 else
duke@1 741 return typeTagError(pos,
mcimadamore@89 742 diags.fragment("type.req.ref"),
duke@1 743 t);
duke@1 744 }
duke@1 745
jrose@267 746 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 747 * or a type variable.
jrose@267 748 * @param trees Original trees, used for error reporting.
jrose@267 749 * @param types The types to be checked.
jrose@267 750 */
jrose@267 751 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 752 List<JCExpression> tl = trees;
jrose@267 753 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 754 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 755 tl = tl.tail;
jrose@267 756 }
jrose@267 757 return types;
jrose@267 758 }
jrose@267 759
duke@1 760 /** Check that type is a null or reference type.
duke@1 761 * @param pos Position to be used for error reporting.
duke@1 762 * @param t The type to be checked.
duke@1 763 */
duke@1 764 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
vromero@1826 765 if (t.isReference() || t.hasTag(BOT))
duke@1 766 return t;
jjg@1374 767 else
duke@1 768 return typeTagError(pos,
mcimadamore@89 769 diags.fragment("type.req.ref"),
duke@1 770 t);
duke@1 771 }
duke@1 772
duke@1 773 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 774 * Return true if it doesn't.
duke@1 775 * @param pos Position to be used for error reporting.
duke@1 776 * @param flags The set of flags to be checked.
duke@1 777 * @param set1 Conflicting flags set #1.
duke@1 778 * @param set2 Conflicting flags set #2.
duke@1 779 */
duke@1 780 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 781 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 782 log.error(pos,
duke@1 783 "illegal.combination.of.modifiers",
mcimadamore@80 784 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 785 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 786 return false;
duke@1 787 } else
duke@1 788 return true;
duke@1 789 }
duke@1 790
mcimadamore@914 791 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 792 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 793 */
mcimadamore@914 794 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 795 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 796 t.isErroneous()) {
mcimadamore@914 797 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 798 } else if (tree.def != null) {
mcimadamore@914 799 log.error(tree.clazz.pos(),
mcimadamore@914 800 "cant.apply.diamond.1",
mcimadamore@914 801 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 802 return types.createErrorType(t);
mcimadamore@948 803 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 804 log.error(tree.clazz.pos(),
mcimadamore@914 805 "cant.apply.diamond.1",
mcimadamore@914 806 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 807 return types.createErrorType(t);
mcimadamore@993 808 } else if (tree.typeargs != null &&
mcimadamore@993 809 tree.typeargs.nonEmpty()) {
mcimadamore@993 810 log.error(tree.clazz.pos(),
mcimadamore@993 811 "cant.apply.diamond.1",
mcimadamore@993 812 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 813 return types.createErrorType(t);
mcimadamore@914 814 } else {
mcimadamore@914 815 return t;
mcimadamore@537 816 }
mcimadamore@537 817 }
mcimadamore@537 818
mcimadamore@795 819 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 820 MethodSymbol m = tree.sym;
mcimadamore@795 821 if (!allowSimplifiedVarargs) return;
mcimadamore@795 822 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 823 Type varargElemType = null;
mcimadamore@580 824 if (m.isVarArgs()) {
mcimadamore@795 825 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 826 }
mcimadamore@795 827 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 828 if (varargElemType != null) {
mcimadamore@795 829 log.error(tree,
mcimadamore@795 830 "varargs.invalid.trustme.anno",
mcimadamore@795 831 syms.trustMeType.tsym,
mcimadamore@795 832 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 833 } else {
mcimadamore@795 834 log.error(tree,
mcimadamore@795 835 "varargs.invalid.trustme.anno",
mcimadamore@795 836 syms.trustMeType.tsym,
mcimadamore@795 837 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 838 }
mcimadamore@795 839 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 840 types.isReifiable(varargElemType)) {
mcimadamore@795 841 warnUnsafeVararg(tree,
mcimadamore@795 842 "varargs.redundant.trustme.anno",
mcimadamore@795 843 syms.trustMeType.tsym,
mcimadamore@795 844 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 845 }
mcimadamore@795 846 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 847 !types.isReifiable(varargElemType)) {
mcimadamore@795 848 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 849 }
mcimadamore@580 850 }
mcimadamore@795 851 //where
mcimadamore@795 852 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 853 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 854 (s.isConstructor() ||
mcimadamore@795 855 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 856 }
mcimadamore@580 857
mcimadamore@1812 858 Type checkMethod(final Type mtype,
mcimadamore@1812 859 final Symbol sym,
mcimadamore@1812 860 final Env<AttrContext> env,
mcimadamore@1812 861 final List<JCExpression> argtrees,
mcimadamore@1812 862 final List<Type> argtypes,
mcimadamore@1812 863 final boolean useVarargs,
mcimadamore@1812 864 InferenceContext inferenceContext) {
mcimadamore@1219 865 // System.out.println("call : " + env.tree);
mcimadamore@1219 866 // System.out.println("method : " + owntype);
mcimadamore@1219 867 // System.out.println("actuals: " + argtypes);
mcimadamore@1812 868 if (inferenceContext.free(mtype)) {
mcimadamore@1812 869 inferenceContext.addFreeTypeListener(List.of(mtype), new FreeTypeListener() {
mcimadamore@1812 870 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1812 871 checkMethod(inferenceContext.asInstType(mtype), sym, env, argtrees, argtypes, useVarargs, inferenceContext);
mcimadamore@1812 872 }
mcimadamore@1812 873 });
mcimadamore@1812 874 return mtype;
mcimadamore@1812 875 }
mcimadamore@1812 876 Type owntype = mtype;
mcimadamore@1219 877 List<Type> formals = owntype.getParameterTypes();
mcimadamore@1219 878 Type last = useVarargs ? formals.last() : null;
jjg@1521 879 if (sym.name == names.init &&
mcimadamore@1219 880 sym.owner == syms.enumSym)
mcimadamore@1219 881 formals = formals.tail.tail;
mcimadamore@1219 882 List<JCExpression> args = argtrees;
mcimadamore@1352 883 if (args != null) {
mcimadamore@1352 884 //this is null when type-checking a method reference
mcimadamore@1352 885 while (formals.head != last) {
mcimadamore@1219 886 JCTree arg = args.head;
mcimadamore@1352 887 Warner warn = convertWarner(arg.pos(), arg.type, formals.head);
mcimadamore@1352 888 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 889 args = args.tail;
mcimadamore@1352 890 formals = formals.tail;
mcimadamore@1219 891 }
mcimadamore@1352 892 if (useVarargs) {
mcimadamore@1352 893 Type varArg = types.elemtype(last);
mcimadamore@1352 894 while (args.tail != null) {
mcimadamore@1352 895 JCTree arg = args.head;
mcimadamore@1352 896 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1352 897 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1352 898 args = args.tail;
mcimadamore@1352 899 }
mcimadamore@1904 900 } else if ((sym.flags() & (VARARGS | SIGNATURE_POLYMORPHIC)) == VARARGS &&
mcimadamore@1904 901 allowVarargs) {
mcimadamore@1352 902 // non-varargs call to varargs method
mcimadamore@1352 903 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1812 904 Type lastArg = argtypes.last();
mcimadamore@1352 905 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
mcimadamore@1352 906 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1352 907 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
mcimadamore@1352 908 types.elemtype(varParam), varParam);
mcimadamore@1352 909 }
mcimadamore@1219 910 }
mcimadamore@1219 911 if (useVarargs) {
mcimadamore@1219 912 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 913 if (!types.isReifiable(argtype) &&
mcimadamore@1219 914 (!allowSimplifiedVarargs ||
mcimadamore@1219 915 sym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@1219 916 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 917 warnUnchecked(env.tree.pos(),
mcimadamore@1219 918 "unchecked.generic.array.creation",
mcimadamore@1219 919 argtype);
mcimadamore@1219 920 }
vromero@1820 921 if ((sym.baseSymbol().flags() & SIGNATURE_POLYMORPHIC) == 0) {
mcimadamore@1812 922 TreeInfo.setVarargsElement(env.tree, types.elemtype(argtype));
mcimadamore@1219 923 }
mcimadamore@1219 924 }
mcimadamore@1510 925 PolyKind pkind = (sym.type.hasTag(FORALL) &&
mcimadamore@1510 926 sym.type.getReturnType().containsAny(((ForAll)sym.type).tvars)) ?
mcimadamore@1510 927 PolyKind.POLY : PolyKind.STANDALONE;
mcimadamore@1510 928 TreeInfo.setPolyKind(env.tree, pkind);
mcimadamore@1219 929 return owntype;
mcimadamore@547 930 }
mcimadamore@1219 931 //where
mcimadamore@1219 932 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
mcimadamore@1219 933 if (types.isConvertible(actual, formal, warn))
mcimadamore@1219 934 return;
mcimadamore@1219 935
mcimadamore@1219 936 if (formal.isCompound()
mcimadamore@1219 937 && types.isSubtype(actual, types.supertype(formal))
mcimadamore@1219 938 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
mcimadamore@1219 939 return;
mcimadamore@1219 940 }
mcimadamore@547 941
mcimadamore@821 942 /**
mcimadamore@821 943 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 944 * (see JLS 4.5)
mcimadamore@821 945 *
mcimadamore@821 946 * @param t class type to be checked
mcimadamore@821 947 * @return true if 't' is well-formed
mcimadamore@821 948 */
mcimadamore@821 949 public boolean checkValidGenericType(Type t) {
mcimadamore@821 950 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 951 }
mcimadamore@821 952 //WHERE
mcimadamore@821 953 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 954 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 955 List<Type> actuals = type.allparams();
mcimadamore@821 956 List<Type> args = type.getTypeArguments();
mcimadamore@821 957 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 958 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 959
mcimadamore@821 960 // For matching pairs of actual argument types `a' and
mcimadamore@821 961 // formal type parameters with declared bound `b' ...
mcimadamore@821 962 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 963 // exact type arguments needs to know their
mcimadamore@821 964 // bounds (for upper and lower bound
mcimadamore@1216 965 // calculations). So we create new bounds where
mcimadamore@1216 966 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 967 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 968 args = args.tail;
mcimadamore@821 969 forms = forms.tail;
mcimadamore@821 970 }
mcimadamore@821 971
mcimadamore@821 972 args = type.getTypeArguments();
mcimadamore@821 973 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 974 formals,
mcimadamore@821 975 types.capture(type).allparams());
mcimadamore@821 976 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 977 // Let the actual arguments know their bound
mcimadamore@821 978 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 979 args = args.tail;
mcimadamore@821 980 tvars_cap = tvars_cap.tail;
mcimadamore@821 981 }
mcimadamore@821 982
mcimadamore@821 983 args = type.getTypeArguments();
mcimadamore@1216 984 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 985
mcimadamore@1216 986 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 987 Type actual = args.head;
mcimadamore@854 988 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 989 !bounds.head.isErroneous() &&
mcimadamore@1216 990 !checkExtends(actual, bounds.head)) {
mcimadamore@821 991 return args.head;
mcimadamore@821 992 }
mcimadamore@821 993 args = args.tail;
mcimadamore@1216 994 bounds = bounds.tail;
mcimadamore@821 995 }
mcimadamore@821 996
mcimadamore@821 997 args = type.getTypeArguments();
mcimadamore@1216 998 bounds = bounds_buf.toList();
mcimadamore@821 999
mcimadamore@821 1000 for (Type arg : types.capture(type).getTypeArguments()) {
jjg@1374 1001 if (arg.hasTag(TYPEVAR) &&
mcimadamore@828 1002 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 1003 !bounds.head.isErroneous() &&
mcimadamore@854 1004 !isTypeArgErroneous(args.head)) {
mcimadamore@821 1005 return args.head;
mcimadamore@821 1006 }
mcimadamore@1216 1007 bounds = bounds.tail;
mcimadamore@854 1008 args = args.tail;
mcimadamore@821 1009 }
mcimadamore@821 1010
mcimadamore@821 1011 return null;
mcimadamore@821 1012 }
mcimadamore@854 1013 //where
mcimadamore@854 1014 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 1015 return isTypeArgErroneous.visit(t);
mcimadamore@854 1016 }
mcimadamore@854 1017
mcimadamore@854 1018 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 1019 public Boolean visitType(Type t, Void s) {
mcimadamore@854 1020 return t.isErroneous();
mcimadamore@854 1021 }
mcimadamore@854 1022 @Override
mcimadamore@854 1023 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 1024 return visit(t.getUpperBound());
mcimadamore@854 1025 }
mcimadamore@854 1026 @Override
mcimadamore@854 1027 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 1028 return visit(t.getUpperBound()) ||
mcimadamore@854 1029 visit(t.getLowerBound());
mcimadamore@854 1030 }
mcimadamore@854 1031 @Override
mcimadamore@854 1032 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1033 return visit(t.type);
mcimadamore@854 1034 }
mcimadamore@854 1035 };
mcimadamore@821 1036
duke@1 1037 /** Check that given modifiers are legal for given symbol and
vromero@1555 1038 * return modifiers together with any implicit modifiers for that symbol.
duke@1 1039 * Warning: we can't use flags() here since this method
duke@1 1040 * is called during class enter, when flags() would cause a premature
duke@1 1041 * completion.
duke@1 1042 * @param pos Position to be used for error reporting.
duke@1 1043 * @param flags The set of modifiers given in a definition.
duke@1 1044 * @param sym The defined symbol.
duke@1 1045 */
duke@1 1046 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1047 long mask;
duke@1 1048 long implicit = 0;
duke@1 1049 switch (sym.kind) {
duke@1 1050 case VAR:
duke@1 1051 if (sym.owner.kind != TYP)
duke@1 1052 mask = LocalVarFlags;
duke@1 1053 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1054 mask = implicit = InterfaceVarFlags;
duke@1 1055 else
duke@1 1056 mask = VarFlags;
duke@1 1057 break;
duke@1 1058 case MTH:
duke@1 1059 if (sym.name == names.init) {
duke@1 1060 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1061 // enum constructors cannot be declared public or
duke@1 1062 // protected and must be implicitly or explicitly
duke@1 1063 // private
duke@1 1064 implicit = PRIVATE;
duke@1 1065 mask = PRIVATE;
duke@1 1066 } else
duke@1 1067 mask = ConstructorFlags;
mcimadamore@1366 1068 } else if ((sym.owner.flags_field & INTERFACE) != 0) {
mcimadamore@1513 1069 if ((flags & (DEFAULT | STATIC)) != 0) {
mcimadamore@1513 1070 mask = InterfaceMethodMask;
mcimadamore@1513 1071 implicit = PUBLIC;
mcimadamore@1513 1072 if ((flags & DEFAULT) != 0) {
mcimadamore@1513 1073 implicit |= ABSTRACT;
mcimadamore@1513 1074 }
mcimadamore@1366 1075 } else {
mcimadamore@1366 1076 mask = implicit = InterfaceMethodFlags;
mcimadamore@1366 1077 }
mcimadamore@1366 1078 }
duke@1 1079 else {
duke@1 1080 mask = MethodFlags;
duke@1 1081 }
duke@1 1082 // Imply STRICTFP if owner has STRICTFP set.
vromero@1712 1083 if (((flags|implicit) & Flags.ABSTRACT) == 0 ||
vromero@1712 1084 ((flags) & Flags.DEFAULT) != 0)
vromero@1555 1085 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1086 break;
duke@1 1087 case TYP:
duke@1 1088 if (sym.isLocal()) {
duke@1 1089 mask = LocalClassFlags;
jjg@113 1090 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1091 // Anonymous classes in static methods are themselves static;
duke@1 1092 // that's why we admit STATIC here.
duke@1 1093 mask |= STATIC;
duke@1 1094 // JLS: Anonymous classes are final.
duke@1 1095 implicit |= FINAL;
duke@1 1096 }
duke@1 1097 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1098 (flags & ENUM) != 0)
duke@1 1099 log.error(pos, "enums.must.be.static");
duke@1 1100 } else if (sym.owner.kind == TYP) {
duke@1 1101 mask = MemberClassFlags;
duke@1 1102 if (sym.owner.owner.kind == PCK ||
duke@1 1103 (sym.owner.flags_field & STATIC) != 0)
duke@1 1104 mask |= STATIC;
duke@1 1105 else if ((flags & ENUM) != 0)
duke@1 1106 log.error(pos, "enums.must.be.static");
duke@1 1107 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1108 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1109 } else {
duke@1 1110 mask = ClassFlags;
duke@1 1111 }
duke@1 1112 // Interfaces are always ABSTRACT
duke@1 1113 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1114
duke@1 1115 if ((flags & ENUM) != 0) {
duke@1 1116 // enums can't be declared abstract or final
duke@1 1117 mask &= ~(ABSTRACT | FINAL);
duke@1 1118 implicit |= implicitEnumFinalFlag(tree);
duke@1 1119 }
duke@1 1120 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1121 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1122 break;
duke@1 1123 default:
duke@1 1124 throw new AssertionError();
duke@1 1125 }
mcimadamore@1366 1126 long illegal = flags & ExtendedStandardFlags & ~mask;
duke@1 1127 if (illegal != 0) {
duke@1 1128 if ((illegal & INTERFACE) != 0) {
duke@1 1129 log.error(pos, "intf.not.allowed.here");
duke@1 1130 mask |= INTERFACE;
duke@1 1131 }
duke@1 1132 else {
duke@1 1133 log.error(pos,
mcimadamore@80 1134 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1135 }
duke@1 1136 }
duke@1 1137 else if ((sym.kind == TYP ||
duke@1 1138 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1139 // in the presence of inner classes. Should it be deleted here?
duke@1 1140 checkDisjoint(pos, flags,
duke@1 1141 ABSTRACT,
mcimadamore@1366 1142 PRIVATE | STATIC | DEFAULT))
duke@1 1143 &&
duke@1 1144 checkDisjoint(pos, flags,
mcimadamore@1513 1145 STATIC,
mcimadamore@1513 1146 DEFAULT)
mcimadamore@1513 1147 &&
mcimadamore@1513 1148 checkDisjoint(pos, flags,
duke@1 1149 ABSTRACT | INTERFACE,
duke@1 1150 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1151 &&
duke@1 1152 checkDisjoint(pos, flags,
duke@1 1153 PUBLIC,
duke@1 1154 PRIVATE | PROTECTED)
duke@1 1155 &&
duke@1 1156 checkDisjoint(pos, flags,
duke@1 1157 PRIVATE,
duke@1 1158 PUBLIC | PROTECTED)
duke@1 1159 &&
duke@1 1160 checkDisjoint(pos, flags,
duke@1 1161 FINAL,
duke@1 1162 VOLATILE)
duke@1 1163 &&
duke@1 1164 (sym.kind == TYP ||
duke@1 1165 checkDisjoint(pos, flags,
duke@1 1166 ABSTRACT | NATIVE,
duke@1 1167 STRICTFP))) {
duke@1 1168 // skip
duke@1 1169 }
mcimadamore@1366 1170 return flags & (mask | ~ExtendedStandardFlags) | implicit;
duke@1 1171 }
duke@1 1172
duke@1 1173
duke@1 1174 /** Determine if this enum should be implicitly final.
duke@1 1175 *
duke@1 1176 * If the enum has no specialized enum contants, it is final.
duke@1 1177 *
duke@1 1178 * If the enum does have specialized enum contants, it is
duke@1 1179 * <i>not</i> final.
duke@1 1180 */
duke@1 1181 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1182 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1183 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1184 boolean specialized;
duke@1 1185 SpecialTreeVisitor() {
duke@1 1186 this.specialized = false;
duke@1 1187 };
duke@1 1188
jjg@398 1189 @Override
duke@1 1190 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1191
jjg@398 1192 @Override
duke@1 1193 public void visitVarDef(JCVariableDecl tree) {
duke@1 1194 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1195 if (tree.init instanceof JCNewClass &&
duke@1 1196 ((JCNewClass) tree.init).def != null) {
duke@1 1197 specialized = true;
duke@1 1198 }
duke@1 1199 }
duke@1 1200 }
duke@1 1201 }
duke@1 1202
duke@1 1203 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1204 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1205 for (JCTree defs: cdef.defs) {
duke@1 1206 defs.accept(sts);
duke@1 1207 if (sts.specialized) return 0;
duke@1 1208 }
duke@1 1209 return FINAL;
duke@1 1210 }
duke@1 1211
duke@1 1212 /* *************************************************************************
duke@1 1213 * Type Validation
duke@1 1214 **************************************************************************/
duke@1 1215
duke@1 1216 /** Validate a type expression. That is,
duke@1 1217 * check that all type arguments of a parametric type are within
jjg@1755 1218 * their bounds. This must be done in a second phase after type attribution
duke@1 1219 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1220 *
jjg@1358 1221 * <pre>{@code
duke@1 1222 * class B<A extends C> { ... }
duke@1 1223 * class C extends B<C> { ... }
jjg@1358 1224 * }</pre>
duke@1 1225 *
duke@1 1226 * and we can't make sure that the bound is already attributed because
duke@1 1227 * of possible cycles.
mcimadamore@638 1228 *
mcimadamore@638 1229 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1230 * and reporting any completion failures.
duke@1 1231 */
mcimadamore@122 1232 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1233 validate(tree, env, true);
duke@1 1234 }
mcimadamore@638 1235 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1236 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1237 }
duke@1 1238
duke@1 1239 /** Visitor method: Validate a list of type expressions.
duke@1 1240 */
mcimadamore@122 1241 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1242 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1243 validate(l.head, env);
duke@1 1244 }
duke@1 1245
duke@1 1246 /** A visitor class for type validation.
duke@1 1247 */
duke@1 1248 class Validator extends JCTree.Visitor {
duke@1 1249
mcimadamore@638 1250 boolean isOuter;
mcimadamore@638 1251 Env<AttrContext> env;
mcimadamore@638 1252
mcimadamore@638 1253 Validator(Env<AttrContext> env) {
mcimadamore@638 1254 this.env = env;
mcimadamore@638 1255 }
mcimadamore@638 1256
jjg@398 1257 @Override
duke@1 1258 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1259 tree.elemtype.accept(this);
duke@1 1260 }
duke@1 1261
jjg@398 1262 @Override
duke@1 1263 public void visitTypeApply(JCTypeApply tree) {
jjg@1374 1264 if (tree.type.hasTag(CLASS)) {
duke@1 1265 List<JCExpression> args = tree.arguments;
mcimadamore@158 1266 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1267
mcimadamore@821 1268 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1269 if (incompatibleArg != null) {
mcimadamore@821 1270 for (JCTree arg : tree.arguments) {
mcimadamore@821 1271 if (arg.type == incompatibleArg) {
mcimadamore@829 1272 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1273 }
mcimadamore@829 1274 forms = forms.tail;
mcimadamore@829 1275 }
mcimadamore@829 1276 }
mcimadamore@829 1277
mcimadamore@829 1278 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1279
mcimadamore@638 1280 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1281
duke@1 1282 // For matching pairs of actual argument types `a' and
duke@1 1283 // formal type parameters with declared bound `b' ...
duke@1 1284 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1285 validateTree(args.head,
mcimadamore@638 1286 !(isOuter && is_java_lang_Class),
mcimadamore@638 1287 false);
duke@1 1288 args = args.tail;
duke@1 1289 forms = forms.tail;
duke@1 1290 }
duke@1 1291
duke@1 1292 // Check that this type is either fully parameterized, or
duke@1 1293 // not parameterized at all.
duke@1 1294 if (tree.type.getEnclosingType().isRaw())
duke@1 1295 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1296 if (tree.clazz.hasTag(SELECT))
duke@1 1297 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1298 }
duke@1 1299 }
duke@1 1300
jjg@398 1301 @Override
duke@1 1302 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1303 validateTrees(tree.bounds, true, isOuter);
duke@1 1304 checkClassBounds(tree.pos(), tree.type);
duke@1 1305 }
duke@1 1306
duke@1 1307 @Override
duke@1 1308 public void visitWildcard(JCWildcard tree) {
duke@1 1309 if (tree.inner != null)
mcimadamore@638 1310 validateTree(tree.inner, true, isOuter);
duke@1 1311 }
duke@1 1312
jjg@398 1313 @Override
duke@1 1314 public void visitSelect(JCFieldAccess tree) {
jjg@1374 1315 if (tree.type.hasTag(CLASS)) {
duke@1 1316 visitSelectInternal(tree);
duke@1 1317
duke@1 1318 // Check that this type is either fully parameterized, or
duke@1 1319 // not parameterized at all.
duke@1 1320 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1321 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1322 }
duke@1 1323 }
mcimadamore@852 1324
duke@1 1325 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1326 if (tree.type.tsym.isStatic() &&
duke@1 1327 tree.selected.type.isParameterized()) {
duke@1 1328 // The enclosing type is not a class, so we are
duke@1 1329 // looking at a static member type. However, the
duke@1 1330 // qualifying expression is parameterized.
duke@1 1331 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1332 } else {
duke@1 1333 // otherwise validate the rest of the expression
mcimadamore@122 1334 tree.selected.accept(this);
duke@1 1335 }
duke@1 1336 }
duke@1 1337
jjg@1521 1338 @Override
jjg@1521 1339 public void visitAnnotatedType(JCAnnotatedType tree) {
jjg@1521 1340 tree.underlyingType.accept(this);
jjg@1521 1341 }
jjg@1521 1342
duke@1 1343 /** Default visitor method: do nothing.
duke@1 1344 */
jjg@398 1345 @Override
duke@1 1346 public void visitTree(JCTree tree) {
duke@1 1347 }
mcimadamore@122 1348
mcimadamore@638 1349 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1350 try {
mcimadamore@638 1351 if (tree != null) {
mcimadamore@638 1352 this.isOuter = isOuter;
mcimadamore@638 1353 tree.accept(this);
mcimadamore@638 1354 if (checkRaw)
mcimadamore@638 1355 checkRaw(tree, env);
mcimadamore@638 1356 }
mcimadamore@638 1357 } catch (CompletionFailure ex) {
mcimadamore@638 1358 completionError(tree.pos(), ex);
mcimadamore@638 1359 }
mcimadamore@638 1360 }
mcimadamore@638 1361
mcimadamore@638 1362 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1363 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1364 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1365 }
mcimadamore@1760 1366 }
mcimadamore@1760 1367
mcimadamore@1760 1368 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@1760 1369 if (lint.isEnabled(LintCategory.RAW) &&
mcimadamore@1760 1370 tree.type.hasTag(CLASS) &&
mcimadamore@1760 1371 !TreeInfo.isDiamond(tree) &&
mcimadamore@1760 1372 !withinAnonConstr(env) &&
mcimadamore@1760 1373 tree.type.isRaw()) {
mcimadamore@1760 1374 log.warning(LintCategory.RAW,
mcimadamore@1760 1375 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1376 }
mcimadamore@1760 1377 }
mcimadamore@1760 1378 //where
mcimadamore@1760 1379 private boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1380 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1381 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1382 }
duke@1 1383
duke@1 1384 /* *************************************************************************
duke@1 1385 * Exception checking
duke@1 1386 **************************************************************************/
duke@1 1387
duke@1 1388 /* The following methods treat classes as sets that contain
duke@1 1389 * the class itself and all their subclasses
duke@1 1390 */
duke@1 1391
duke@1 1392 /** Is given type a subtype of some of the types in given list?
duke@1 1393 */
duke@1 1394 boolean subset(Type t, List<Type> ts) {
duke@1 1395 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1396 if (types.isSubtype(t, l.head)) return true;
duke@1 1397 return false;
duke@1 1398 }
duke@1 1399
duke@1 1400 /** Is given type a subtype or supertype of
duke@1 1401 * some of the types in given list?
duke@1 1402 */
duke@1 1403 boolean intersects(Type t, List<Type> ts) {
duke@1 1404 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1405 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1406 return false;
duke@1 1407 }
duke@1 1408
duke@1 1409 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1410 * in the list.
duke@1 1411 */
duke@1 1412 List<Type> incl(Type t, List<Type> ts) {
duke@1 1413 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1414 }
duke@1 1415
duke@1 1416 /** Remove type set from type set list.
duke@1 1417 */
duke@1 1418 List<Type> excl(Type t, List<Type> ts) {
duke@1 1419 if (ts.isEmpty()) {
duke@1 1420 return ts;
duke@1 1421 } else {
duke@1 1422 List<Type> ts1 = excl(t, ts.tail);
duke@1 1423 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1424 else if (ts1 == ts.tail) return ts;
duke@1 1425 else return ts1.prepend(ts.head);
duke@1 1426 }
duke@1 1427 }
duke@1 1428
duke@1 1429 /** Form the union of two type set lists.
duke@1 1430 */
duke@1 1431 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1432 List<Type> ts = ts1;
duke@1 1433 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1434 ts = incl(l.head, ts);
duke@1 1435 return ts;
duke@1 1436 }
duke@1 1437
duke@1 1438 /** Form the difference of two type lists.
duke@1 1439 */
duke@1 1440 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1441 List<Type> ts = ts1;
duke@1 1442 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1443 ts = excl(l.head, ts);
duke@1 1444 return ts;
duke@1 1445 }
duke@1 1446
duke@1 1447 /** Form the intersection of two type lists.
duke@1 1448 */
duke@1 1449 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1450 List<Type> ts = List.nil();
duke@1 1451 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1452 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1453 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1454 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1455 return ts;
duke@1 1456 }
duke@1 1457
duke@1 1458 /** Is exc an exception symbol that need not be declared?
duke@1 1459 */
duke@1 1460 boolean isUnchecked(ClassSymbol exc) {
duke@1 1461 return
duke@1 1462 exc.kind == ERR ||
duke@1 1463 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1464 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1465 }
duke@1 1466
duke@1 1467 /** Is exc an exception type that need not be declared?
duke@1 1468 */
duke@1 1469 boolean isUnchecked(Type exc) {
duke@1 1470 return
jjg@1374 1471 (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
jjg@1374 1472 (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
jjg@1374 1473 exc.hasTag(BOT);
duke@1 1474 }
duke@1 1475
duke@1 1476 /** Same, but handling completion failures.
duke@1 1477 */
duke@1 1478 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1479 try {
duke@1 1480 return isUnchecked(exc);
duke@1 1481 } catch (CompletionFailure ex) {
duke@1 1482 completionError(pos, ex);
duke@1 1483 return true;
duke@1 1484 }
duke@1 1485 }
duke@1 1486
duke@1 1487 /** Is exc handled by given exception list?
duke@1 1488 */
duke@1 1489 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1490 return isUnchecked(exc) || subset(exc, handled);
duke@1 1491 }
duke@1 1492
duke@1 1493 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1494 * @param thrown The list of thrown exceptions.
duke@1 1495 * @param handled The list of handled exceptions.
duke@1 1496 */
mcimadamore@362 1497 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1498 List<Type> unhandled = List.nil();
duke@1 1499 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1500 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1501 return unhandled;
duke@1 1502 }
duke@1 1503
duke@1 1504 /* *************************************************************************
duke@1 1505 * Overriding/Implementation checking
duke@1 1506 **************************************************************************/
duke@1 1507
duke@1 1508 /** The level of access protection given by a flag set,
duke@1 1509 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1510 */
duke@1 1511 static int protection(long flags) {
duke@1 1512 switch ((short)(flags & AccessFlags)) {
duke@1 1513 case PRIVATE: return 3;
duke@1 1514 case PROTECTED: return 1;
duke@1 1515 default:
duke@1 1516 case PUBLIC: return 0;
duke@1 1517 case 0: return 2;
duke@1 1518 }
duke@1 1519 }
duke@1 1520
duke@1 1521 /** A customized "cannot override" error message.
duke@1 1522 * @param m The overriding method.
duke@1 1523 * @param other The overridden method.
duke@1 1524 * @return An internationalized string.
duke@1 1525 */
mcimadamore@89 1526 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1527 String key;
duke@1 1528 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1529 key = "cant.override";
duke@1 1530 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1531 key = "cant.implement";
duke@1 1532 else
duke@1 1533 key = "clashes.with";
mcimadamore@89 1534 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1535 }
duke@1 1536
duke@1 1537 /** A customized "override" warning message.
duke@1 1538 * @param m The overriding method.
duke@1 1539 * @param other The overridden method.
duke@1 1540 * @return An internationalized string.
duke@1 1541 */
mcimadamore@89 1542 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1543 String key;
duke@1 1544 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1545 key = "unchecked.override";
duke@1 1546 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1547 key = "unchecked.implement";
duke@1 1548 else
duke@1 1549 key = "unchecked.clash.with";
mcimadamore@89 1550 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1551 }
duke@1 1552
duke@1 1553 /** A customized "override" warning message.
duke@1 1554 * @param m The overriding method.
duke@1 1555 * @param other The overridden method.
duke@1 1556 * @return An internationalized string.
duke@1 1557 */
mcimadamore@89 1558 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1559 String key;
duke@1 1560 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1561 key = "varargs.override";
duke@1 1562 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1563 key = "varargs.implement";
duke@1 1564 else
duke@1 1565 key = "varargs.clash.with";
mcimadamore@89 1566 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1567 }
duke@1 1568
duke@1 1569 /** Check that this method conforms with overridden method 'other'.
duke@1 1570 * where `origin' is the class where checking started.
duke@1 1571 * Complications:
duke@1 1572 * (1) Do not check overriding of synthetic methods
duke@1 1573 * (reason: they might be final).
duke@1 1574 * todo: check whether this is still necessary.
duke@1 1575 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1576 * than the method it implements. Augment the proxy methods with the
duke@1 1577 * undeclared exceptions in this case.
duke@1 1578 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1579 * has a result type
duke@1 1580 * extended by the result type of the method it implements.
duke@1 1581 * Change the proxies result type to the smaller type in this case.
duke@1 1582 *
duke@1 1583 * @param tree The tree from which positions
duke@1 1584 * are extracted for errors.
duke@1 1585 * @param m The overriding method.
duke@1 1586 * @param other The overridden method.
duke@1 1587 * @param origin The class of which the overriding method
duke@1 1588 * is a member.
duke@1 1589 */
duke@1 1590 void checkOverride(JCTree tree,
duke@1 1591 MethodSymbol m,
duke@1 1592 MethodSymbol other,
duke@1 1593 ClassSymbol origin) {
duke@1 1594 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1595 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1596 return;
duke@1 1597 }
duke@1 1598
duke@1 1599 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1600 if ((m.flags() & STATIC) != 0 &&
duke@1 1601 (other.flags() & STATIC) == 0) {
duke@1 1602 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1603 cannotOverride(m, other));
vromero@1588 1604 m.flags_field |= BAD_OVERRIDE;
duke@1 1605 return;
duke@1 1606 }
duke@1 1607
duke@1 1608 // Error if instance method overrides static or final
duke@1 1609 // method (JLS 8.4.6.1).
duke@1 1610 if ((other.flags() & FINAL) != 0 ||
duke@1 1611 (m.flags() & STATIC) == 0 &&
duke@1 1612 (other.flags() & STATIC) != 0) {
duke@1 1613 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1614 cannotOverride(m, other),
mcimadamore@80 1615 asFlagSet(other.flags() & (FINAL | STATIC)));
vromero@1588 1616 m.flags_field |= BAD_OVERRIDE;
duke@1 1617 return;
duke@1 1618 }
duke@1 1619
duke@1 1620 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1621 // handled in validateAnnotationMethod
duke@1 1622 return;
duke@1 1623 }
duke@1 1624
duke@1 1625 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1626 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1627 protection(m.flags()) > protection(other.flags())) {
duke@1 1628 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1629 cannotOverride(m, other),
mcimadamore@80 1630 other.flags() == 0 ?
vromero@1842 1631 "package" :
mcimadamore@80 1632 asFlagSet(other.flags() & AccessFlags));
vromero@1588 1633 m.flags_field |= BAD_OVERRIDE;
duke@1 1634 return;
duke@1 1635 }
duke@1 1636
duke@1 1637 Type mt = types.memberType(origin.type, m);
duke@1 1638 Type ot = types.memberType(origin.type, other);
duke@1 1639 // Error if overriding result type is different
duke@1 1640 // (or, in the case of generics mode, not a subtype) of
duke@1 1641 // overridden result type. We have to rename any type parameters
duke@1 1642 // before comparing types.
duke@1 1643 List<Type> mtvars = mt.getTypeArguments();
duke@1 1644 List<Type> otvars = ot.getTypeArguments();
duke@1 1645 Type mtres = mt.getReturnType();
duke@1 1646 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1647
mcimadamore@795 1648 overrideWarner.clear();
duke@1 1649 boolean resultTypesOK =
tbell@202 1650 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1651 if (!resultTypesOK) {
jjg@398 1652 if (!allowCovariantReturns &&
duke@1 1653 m.owner != origin &&
duke@1 1654 m.owner.isSubClass(other.owner, types)) {
duke@1 1655 // allow limited interoperability with covariant returns
duke@1 1656 } else {
mcimadamore@362 1657 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1658 "override.incompatible.ret",
mcimadamore@362 1659 cannotOverride(m, other),
duke@1 1660 mtres, otres);
vromero@1588 1661 m.flags_field |= BAD_OVERRIDE;
duke@1 1662 return;
duke@1 1663 }
mcimadamore@795 1664 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1665 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1666 "override.unchecked.ret",
mcimadamore@362 1667 uncheckedOverrides(m, other),
mcimadamore@362 1668 mtres, otres);
duke@1 1669 }
duke@1 1670
duke@1 1671 // Error if overriding method throws an exception not reported
duke@1 1672 // by overridden method.
duke@1 1673 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1674 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1675 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1676 if (unhandledErased.nonEmpty()) {
duke@1 1677 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1678 "override.meth.doesnt.throw",
duke@1 1679 cannotOverride(m, other),
mcimadamore@362 1680 unhandledUnerased.head);
vromero@1588 1681 m.flags_field |= BAD_OVERRIDE;
mcimadamore@362 1682 return;
mcimadamore@362 1683 }
mcimadamore@362 1684 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1685 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1686 "override.unchecked.thrown",
mcimadamore@362 1687 cannotOverride(m, other),
mcimadamore@362 1688 unhandledUnerased.head);
duke@1 1689 return;
duke@1 1690 }
duke@1 1691
duke@1 1692 // Optional warning if varargs don't agree
duke@1 1693 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1694 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1695 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1696 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1697 ? "override.varargs.missing"
duke@1 1698 : "override.varargs.extra",
duke@1 1699 varargsOverrides(m, other));
duke@1 1700 }
duke@1 1701
duke@1 1702 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1703 if ((other.flags() & BRIDGE) != 0) {
duke@1 1704 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1705 uncheckedOverrides(m, other));
duke@1 1706 }
duke@1 1707
duke@1 1708 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1709 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1710 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1711 }
duke@1 1712 }
duke@1 1713 // where
duke@1 1714 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1715 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1716 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1717 // because in that case, we will rediscover the issue when examining the method
duke@1 1718 // in the supertype.
duke@1 1719 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1720 // address the issue is when the method is the supertype implemementation: any other
duke@1 1721 // case, we will have dealt with when examining the supertype classes
duke@1 1722 ClassSymbol mc = m.enclClass();
duke@1 1723 Type st = types.supertype(origin.type);
jjg@1374 1724 if (!st.hasTag(CLASS))
duke@1 1725 return true;
duke@1 1726 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1727
duke@1 1728 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1729 List<Type> intfs = types.interfaces(origin.type);
duke@1 1730 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1731 }
duke@1 1732 else
duke@1 1733 return (stimpl != m);
duke@1 1734 }
duke@1 1735
duke@1 1736
duke@1 1737 // used to check if there were any unchecked conversions
duke@1 1738 Warner overrideWarner = new Warner();
duke@1 1739
duke@1 1740 /** Check that a class does not inherit two concrete methods
duke@1 1741 * with the same signature.
duke@1 1742 * @param pos Position to be used for error reporting.
duke@1 1743 * @param site The class type to be checked.
duke@1 1744 */
duke@1 1745 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1746 Type sup = types.supertype(site);
jjg@1374 1747 if (!sup.hasTag(CLASS)) return;
duke@1 1748
duke@1 1749 for (Type t1 = sup;
jlahoda@1956 1750 t1.hasTag(CLASS) && t1.tsym.type.isParameterized();
duke@1 1751 t1 = types.supertype(t1)) {
duke@1 1752 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1753 e1 != null;
duke@1 1754 e1 = e1.sibling) {
duke@1 1755 Symbol s1 = e1.sym;
duke@1 1756 if (s1.kind != MTH ||
duke@1 1757 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1758 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1759 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1760 types,
duke@1 1761 true) != s1)
duke@1 1762 continue;
duke@1 1763 Type st1 = types.memberType(t1, s1);
duke@1 1764 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1765 if (st1 == s1.type) continue;
duke@1 1766
duke@1 1767 for (Type t2 = sup;
jjg@1374 1768 t2.hasTag(CLASS);
duke@1 1769 t2 = types.supertype(t2)) {
mcimadamore@24 1770 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1771 e2.scope != null;
duke@1 1772 e2 = e2.next()) {
duke@1 1773 Symbol s2 = e2.sym;
duke@1 1774 if (s2 == s1 ||
duke@1 1775 s2.kind != MTH ||
duke@1 1776 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1777 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1778 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1779 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1780 types,
duke@1 1781 true) != s2)
duke@1 1782 continue;
duke@1 1783 Type st2 = types.memberType(t2, s2);
duke@1 1784 if (types.overrideEquivalent(st1, st2))
duke@1 1785 log.error(pos, "concrete.inheritance.conflict",
duke@1 1786 s1, t1, s2, t2, sup);
duke@1 1787 }
duke@1 1788 }
duke@1 1789 }
duke@1 1790 }
duke@1 1791 }
duke@1 1792
duke@1 1793 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1794 * method with same name and arguments but incompatible return types.
duke@1 1795 * @param pos Position to be used for error reporting.
duke@1 1796 * @param t1 The first argument type.
duke@1 1797 * @param t2 The second argument type.
duke@1 1798 */
duke@1 1799 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1800 Type t1,
duke@1 1801 Type t2) {
duke@1 1802 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1803 types.makeCompoundType(t1, t2));
duke@1 1804 }
duke@1 1805
duke@1 1806 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1807 Type t1,
duke@1 1808 Type t2,
duke@1 1809 Type site) {
mcimadamore@746 1810 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1811 }
duke@1 1812
duke@1 1813 /** Return the first method which is defined with same args
duke@1 1814 * but different return types in two given interfaces, or null if none
duke@1 1815 * exists.
duke@1 1816 * @param t1 The first type.
duke@1 1817 * @param t2 The second type.
duke@1 1818 * @param site The most derived type.
duke@1 1819 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1820 */
mcimadamore@746 1821 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1822 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1823 closure(t1, interfaces1);
duke@1 1824 Map<TypeSymbol,Type> interfaces2;
duke@1 1825 if (t1 == t2)
duke@1 1826 interfaces2 = interfaces1;
duke@1 1827 else
duke@1 1828 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1829
duke@1 1830 for (Type t3 : interfaces1.values()) {
duke@1 1831 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1832 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1833 if (s != null) return s;
duke@1 1834 }
duke@1 1835 }
duke@1 1836 return null;
duke@1 1837 }
duke@1 1838
duke@1 1839 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1840 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1841 if (!t.hasTag(CLASS)) return;
duke@1 1842 if (typeMap.put(t.tsym, t) == null) {
duke@1 1843 closure(types.supertype(t), typeMap);
duke@1 1844 for (Type i : types.interfaces(t))
duke@1 1845 closure(i, typeMap);
duke@1 1846 }
duke@1 1847 }
duke@1 1848
duke@1 1849 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1850 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1851 if (!t.hasTag(CLASS)) return;
duke@1 1852 if (typesSkip.get(t.tsym) != null) return;
duke@1 1853 if (typeMap.put(t.tsym, t) == null) {
duke@1 1854 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1855 for (Type i : types.interfaces(t))
duke@1 1856 closure(i, typesSkip, typeMap);
duke@1 1857 }
duke@1 1858 }
duke@1 1859
duke@1 1860 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1861 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1862 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1863 Symbol s1 = e1.sym;
duke@1 1864 Type st1 = null;
mcimadamore@1441 1865 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1866 (s1.flags() & SYNTHETIC) != 0) continue;
duke@1 1867 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1868 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1869 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1870 Symbol s2 = e2.sym;
duke@1 1871 if (s1 == s2) continue;
mcimadamore@1441 1872 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1873 (s2.flags() & SYNTHETIC) != 0) continue;
duke@1 1874 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1875 Type st2 = types.memberType(t2, s2);
duke@1 1876 if (types.overrideEquivalent(st1, st2)) {
duke@1 1877 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1878 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1879 Type rt1 = st1.getReturnType();
duke@1 1880 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1881 boolean compat =
duke@1 1882 types.isSameType(rt1, rt2) ||
jjg@1374 1883 !rt1.isPrimitiveOrVoid() &&
jjg@1374 1884 !rt2.isPrimitiveOrVoid() &&
mcimadamore@1415 1885 (types.covariantReturnType(rt1, rt2, types.noWarnings) ||
mcimadamore@1415 1886 types.covariantReturnType(rt2, rt1, types.noWarnings)) ||
mcimadamore@59 1887 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1888 if (!compat) {
mcimadamore@746 1889 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1890 t1, t2, s2.name +
mcimadamore@746 1891 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1892 return s2;
mcimadamore@746 1893 }
mcimadamore@889 1894 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1895 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1896 log.error(pos,
mcimadamore@746 1897 "name.clash.same.erasure.no.override",
mcimadamore@746 1898 s1, s1.location(),
mcimadamore@746 1899 s2, s2.location());
mcimadamore@746 1900 return s2;
duke@1 1901 }
duke@1 1902 }
duke@1 1903 }
duke@1 1904 return null;
duke@1 1905 }
mcimadamore@59 1906 //WHERE
mcimadamore@59 1907 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1908 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1909 Type st1 = types.memberType(site, s1);
mcimadamore@59 1910 Type st2 = types.memberType(site, s2);
mcimadamore@59 1911 closure(site, supertypes);
mcimadamore@59 1912 for (Type t : supertypes.values()) {
mcimadamore@59 1913 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1914 Symbol s3 = e.sym;
mcimadamore@59 1915 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1916 Type st3 = types.memberType(site,s3);
mcimadamore@1811 1917 if (types.overrideEquivalent(st3, st1) &&
mcimadamore@1811 1918 types.overrideEquivalent(st3, st2) &&
mcimadamore@1811 1919 types.returnTypeSubstitutable(st3, st1) &&
mcimadamore@1811 1920 types.returnTypeSubstitutable(st3, st2)) {
mcimadamore@1811 1921 return true;
mcimadamore@59 1922 }
mcimadamore@59 1923 }
mcimadamore@59 1924 }
mcimadamore@59 1925 return false;
mcimadamore@59 1926 }
duke@1 1927
duke@1 1928 /** Check that a given method conforms with any method it overrides.
duke@1 1929 * @param tree The tree from which positions are extracted
duke@1 1930 * for errors.
duke@1 1931 * @param m The overriding method.
duke@1 1932 */
duke@1 1933 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1934 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1935 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1936 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1937 log.error(tree.pos(), "enum.no.finalize");
duke@1 1938 return;
duke@1 1939 }
jjg@1374 1940 for (Type t = origin.type; t.hasTag(CLASS);
duke@1 1941 t = types.supertype(t)) {
mcimadamore@746 1942 if (t != origin.type) {
mcimadamore@746 1943 checkOverride(tree, t, origin, m);
mcimadamore@746 1944 }
mcimadamore@746 1945 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1946 checkOverride(tree, t2, origin, m);
duke@1 1947 }
duke@1 1948 }
duke@1 1949 }
duke@1 1950
mcimadamore@746 1951 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1952 TypeSymbol c = site.tsym;
mcimadamore@746 1953 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1954 while (e.scope != null) {
mcimadamore@746 1955 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1956 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1957 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1958 }
mcimadamore@746 1959 }
mcimadamore@746 1960 e = e.next();
mcimadamore@746 1961 }
mcimadamore@746 1962 }
mcimadamore@746 1963
vromero@1607 1964 private Filter<Symbol> equalsHasCodeFilter = new Filter<Symbol>() {
vromero@1607 1965 public boolean accepts(Symbol s) {
vromero@1607 1966 return MethodSymbol.implementation_filter.accepts(s) &&
vromero@1607 1967 (s.flags() & BAD_OVERRIDE) == 0;
vromero@1607 1968
vromero@1607 1969 }
vromero@1607 1970 };
vromero@1607 1971
vromero@1620 1972 public void checkClassOverrideEqualsAndHashIfNeeded(DiagnosticPosition pos,
vromero@1620 1973 ClassSymbol someClass) {
vromero@1620 1974 /* At present, annotations cannot possibly have a method that is override
vromero@1620 1975 * equivalent with Object.equals(Object) but in any case the condition is
vromero@1620 1976 * fine for completeness.
vromero@1620 1977 */
vromero@1620 1978 if (someClass == (ClassSymbol)syms.objectType.tsym ||
vromero@1620 1979 someClass.isInterface() || someClass.isEnum() ||
vromero@1620 1980 (someClass.flags() & ANNOTATION) != 0 ||
vromero@1620 1981 (someClass.flags() & ABSTRACT) != 0) return;
vromero@1620 1982 //anonymous inner classes implementing interfaces need especial treatment
vromero@1620 1983 if (someClass.isAnonymous()) {
vromero@1620 1984 List<Type> interfaces = types.interfaces(someClass.type);
vromero@1620 1985 if (interfaces != null && !interfaces.isEmpty() &&
vromero@1620 1986 interfaces.head.tsym == syms.comparatorType.tsym) return;
vromero@1620 1987 }
vromero@1620 1988 checkClassOverrideEqualsAndHash(pos, someClass);
vromero@1620 1989 }
vromero@1620 1990
vromero@1620 1991 private void checkClassOverrideEqualsAndHash(DiagnosticPosition pos,
vromero@1607 1992 ClassSymbol someClass) {
vromero@1588 1993 if (lint.isEnabled(LintCategory.OVERRIDES)) {
vromero@1607 1994 MethodSymbol equalsAtObject = (MethodSymbol)syms.objectType
vromero@1607 1995 .tsym.members().lookup(names.equals).sym;
vromero@1607 1996 MethodSymbol hashCodeAtObject = (MethodSymbol)syms.objectType
vromero@1607 1997 .tsym.members().lookup(names.hashCode).sym;
vromero@1607 1998 boolean overridesEquals = types.implementation(equalsAtObject,
vromero@1607 1999 someClass, false, equalsHasCodeFilter).owner == someClass;
vromero@1607 2000 boolean overridesHashCode = types.implementation(hashCodeAtObject,
vromero@1607 2001 someClass, false, equalsHasCodeFilter) != hashCodeAtObject;
vromero@1607 2002
vromero@1607 2003 if (overridesEquals && !overridesHashCode) {
vromero@1607 2004 log.warning(LintCategory.OVERRIDES, pos,
vromero@1620 2005 "override.equals.but.not.hashcode", someClass);
vromero@1588 2006 }
vromero@1588 2007 }
vromero@1588 2008 }
vromero@1588 2009
mcimadamore@746 2010 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 2011 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 2012 return (cf.accepts(s1) &&
mcimadamore@858 2013 cf.accepts(s2) &&
mcimadamore@858 2014 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 2015 }
mcimadamore@746 2016
mcimadamore@746 2017
duke@1 2018 /** Check that all abstract members of given class have definitions.
duke@1 2019 * @param pos Position to be used for error reporting.
duke@1 2020 * @param c The class.
duke@1 2021 */
duke@1 2022 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2023 try {
duke@1 2024 MethodSymbol undef = firstUndef(c, c);
duke@1 2025 if (undef != null) {
duke@1 2026 if ((c.flags() & ENUM) != 0 &&
duke@1 2027 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 2028 (c.flags() & FINAL) == 0) {
duke@1 2029 // add the ABSTRACT flag to an enum
duke@1 2030 c.flags_field |= ABSTRACT;
duke@1 2031 } else {
duke@1 2032 MethodSymbol undef1 =
duke@1 2033 new MethodSymbol(undef.flags(), undef.name,
duke@1 2034 types.memberType(c.type, undef), undef.owner);
duke@1 2035 log.error(pos, "does.not.override.abstract",
duke@1 2036 c, undef1, undef1.location());
duke@1 2037 }
duke@1 2038 }
duke@1 2039 } catch (CompletionFailure ex) {
duke@1 2040 completionError(pos, ex);
duke@1 2041 }
duke@1 2042 }
duke@1 2043 //where
duke@1 2044 /** Return first abstract member of class `c' that is not defined
duke@1 2045 * in `impl', null if there is none.
duke@1 2046 */
duke@1 2047 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 2048 MethodSymbol undef = null;
duke@1 2049 // Do not bother to search in classes that are not abstract,
duke@1 2050 // since they cannot have abstract members.
duke@1 2051 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 2052 Scope s = c.members();
duke@1 2053 for (Scope.Entry e = s.elems;
duke@1 2054 undef == null && e != null;
duke@1 2055 e = e.sibling) {
duke@1 2056 if (e.sym.kind == MTH &&
mcimadamore@1393 2057 (e.sym.flags() & (ABSTRACT|IPROXY|DEFAULT)) == ABSTRACT) {
duke@1 2058 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2059 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
mcimadamore@1393 2060 if (implmeth == null || implmeth == absmeth) {
mcimadamore@1393 2061 //look for default implementations
mcimadamore@1393 2062 if (allowDefaultMethods) {
mcimadamore@1393 2063 MethodSymbol prov = types.interfaceCandidates(impl.type, absmeth).head;
mcimadamore@1393 2064 if (prov != null && prov.overrides(absmeth, impl, types, true)) {
mcimadamore@1393 2065 implmeth = prov;
mcimadamore@1393 2066 }
mcimadamore@1393 2067 }
mcimadamore@1393 2068 }
mcimadamore@1393 2069 if (implmeth == null || implmeth == absmeth) {
duke@1 2070 undef = absmeth;
mcimadamore@1393 2071 }
duke@1 2072 }
duke@1 2073 }
duke@1 2074 if (undef == null) {
duke@1 2075 Type st = types.supertype(c.type);
jjg@1374 2076 if (st.hasTag(CLASS))
duke@1 2077 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 2078 }
duke@1 2079 for (List<Type> l = types.interfaces(c.type);
duke@1 2080 undef == null && l.nonEmpty();
duke@1 2081 l = l.tail) {
duke@1 2082 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 2083 }
duke@1 2084 }
duke@1 2085 return undef;
duke@1 2086 }
duke@1 2087
mcimadamore@690 2088 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 2089 CycleChecker cc = new CycleChecker();
mcimadamore@690 2090 cc.scan(tree);
mcimadamore@690 2091 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 2092 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 2093 }
mcimadamore@690 2094 }
mcimadamore@690 2095
mcimadamore@690 2096 class CycleChecker extends TreeScanner {
mcimadamore@690 2097
mcimadamore@690 2098 List<Symbol> seenClasses = List.nil();
mcimadamore@690 2099 boolean errorFound = false;
mcimadamore@690 2100 boolean partialCheck = false;
mcimadamore@690 2101
mcimadamore@690 2102 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 2103 if (sym != null && sym.kind == TYP) {
mcimadamore@690 2104 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 2105 if (classEnv != null) {
mcimadamore@690 2106 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2107 try {
mcimadamore@690 2108 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2109 scan(classEnv.tree);
mcimadamore@690 2110 }
mcimadamore@690 2111 finally {
mcimadamore@690 2112 log.useSource(prevSource.getFile());
mcimadamore@690 2113 }
mcimadamore@690 2114 } else if (sym.kind == TYP) {
mcimadamore@690 2115 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2116 }
mcimadamore@690 2117 } else {
mcimadamore@690 2118 //not completed yet
mcimadamore@690 2119 partialCheck = true;
mcimadamore@690 2120 }
mcimadamore@690 2121 }
mcimadamore@690 2122
mcimadamore@690 2123 @Override
mcimadamore@690 2124 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2125 super.visitSelect(tree);
mcimadamore@690 2126 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2127 }
mcimadamore@690 2128
mcimadamore@690 2129 @Override
mcimadamore@690 2130 public void visitIdent(JCIdent tree) {
mcimadamore@690 2131 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2132 }
mcimadamore@690 2133
mcimadamore@690 2134 @Override
mcimadamore@690 2135 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2136 scan(tree.clazz);
mcimadamore@690 2137 }
mcimadamore@690 2138
mcimadamore@690 2139 @Override
mcimadamore@690 2140 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2141 scan(tree.elemtype);
mcimadamore@690 2142 }
mcimadamore@690 2143
mcimadamore@690 2144 @Override
mcimadamore@690 2145 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2146 List<JCTree> supertypes = List.nil();
mcimadamore@690 2147 if (tree.getExtendsClause() != null) {
mcimadamore@690 2148 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2149 }
mcimadamore@690 2150 if (tree.getImplementsClause() != null) {
mcimadamore@690 2151 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2152 supertypes = supertypes.prepend(intf);
mcimadamore@690 2153 }
mcimadamore@690 2154 }
mcimadamore@690 2155 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2156 }
mcimadamore@690 2157
mcimadamore@690 2158 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2159 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2160 return;
mcimadamore@690 2161 if (seenClasses.contains(c)) {
mcimadamore@690 2162 errorFound = true;
mcimadamore@690 2163 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2164 } else if (!c.type.isErroneous()) {
mcimadamore@690 2165 try {
mcimadamore@690 2166 seenClasses = seenClasses.prepend(c);
jjg@1374 2167 if (c.type.hasTag(CLASS)) {
mcimadamore@690 2168 if (supertypes.nonEmpty()) {
mcimadamore@690 2169 scan(supertypes);
mcimadamore@690 2170 }
mcimadamore@690 2171 else {
mcimadamore@690 2172 ClassType ct = (ClassType)c.type;
mcimadamore@690 2173 if (ct.supertype_field == null ||
mcimadamore@690 2174 ct.interfaces_field == null) {
mcimadamore@690 2175 //not completed yet
mcimadamore@690 2176 partialCheck = true;
mcimadamore@690 2177 return;
mcimadamore@690 2178 }
mcimadamore@690 2179 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2180 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2181 checkSymbol(pos, intf.tsym);
mcimadamore@690 2182 }
mcimadamore@690 2183 }
mcimadamore@690 2184 if (c.owner.kind == TYP) {
mcimadamore@690 2185 checkSymbol(pos, c.owner);
mcimadamore@690 2186 }
mcimadamore@690 2187 }
mcimadamore@690 2188 } finally {
mcimadamore@690 2189 seenClasses = seenClasses.tail;
mcimadamore@690 2190 }
mcimadamore@690 2191 }
mcimadamore@690 2192 }
mcimadamore@690 2193 }
mcimadamore@690 2194
duke@1 2195 /** Check for cyclic references. Issue an error if the
duke@1 2196 * symbol of the type referred to has a LOCKED flag set.
duke@1 2197 *
duke@1 2198 * @param pos Position to be used for error reporting.
duke@1 2199 * @param t The type referred to.
duke@1 2200 */
duke@1 2201 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2202 checkNonCyclicInternal(pos, t);
duke@1 2203 }
duke@1 2204
duke@1 2205
duke@1 2206 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2207 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2208 }
duke@1 2209
mcimadamore@236 2210 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2211 final TypeVar tv;
jjg@1374 2212 if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2213 return;
duke@1 2214 if (seen.contains(t)) {
duke@1 2215 tv = (TypeVar)t;
jjg@110 2216 tv.bound = types.createErrorType(t);
duke@1 2217 log.error(pos, "cyclic.inheritance", t);
jjg@1374 2218 } else if (t.hasTag(TYPEVAR)) {
duke@1 2219 tv = (TypeVar)t;
mcimadamore@236 2220 seen = seen.prepend(tv);
duke@1 2221 for (Type b : types.getBounds(tv))
duke@1 2222 checkNonCyclic1(pos, b, seen);
duke@1 2223 }
duke@1 2224 }
duke@1 2225
duke@1 2226 /** Check for cyclic references. Issue an error if the
duke@1 2227 * symbol of the type referred to has a LOCKED flag set.
duke@1 2228 *
duke@1 2229 * @param pos Position to be used for error reporting.
duke@1 2230 * @param t The type referred to.
duke@1 2231 * @returns True if the check completed on all attributed classes
duke@1 2232 */
duke@1 2233 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2234 boolean complete = true; // was the check complete?
duke@1 2235 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2236 Symbol c = t.tsym;
duke@1 2237 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2238
duke@1 2239 if ((c.flags_field & LOCKED) != 0) {
duke@1 2240 noteCyclic(pos, (ClassSymbol)c);
duke@1 2241 } else if (!c.type.isErroneous()) {
duke@1 2242 try {
duke@1 2243 c.flags_field |= LOCKED;
jjg@1374 2244 if (c.type.hasTag(CLASS)) {
duke@1 2245 ClassType clazz = (ClassType)c.type;
duke@1 2246 if (clazz.interfaces_field != null)
duke@1 2247 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2248 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2249 if (clazz.supertype_field != null) {
duke@1 2250 Type st = clazz.supertype_field;
jjg@1374 2251 if (st != null && st.hasTag(CLASS))
duke@1 2252 complete &= checkNonCyclicInternal(pos, st);
duke@1 2253 }
duke@1 2254 if (c.owner.kind == TYP)
duke@1 2255 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2256 }
duke@1 2257 } finally {
duke@1 2258 c.flags_field &= ~LOCKED;
duke@1 2259 }
duke@1 2260 }
duke@1 2261 if (complete)
duke@1 2262 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2263 if (complete) c.flags_field |= ACYCLIC;
duke@1 2264 return complete;
duke@1 2265 }
duke@1 2266
duke@1 2267 /** Note that we found an inheritance cycle. */
duke@1 2268 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2269 log.error(pos, "cyclic.inheritance", c);
duke@1 2270 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2271 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2272 Type st = types.supertype(c.type);
jjg@1374 2273 if (st.hasTag(CLASS))
jjg@110 2274 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2275 c.type = types.createErrorType(c, c.type);
duke@1 2276 c.flags_field |= ACYCLIC;
duke@1 2277 }
duke@1 2278
duke@1 2279 /** Check that all methods which implement some
duke@1 2280 * method conform to the method they implement.
duke@1 2281 * @param tree The class definition whose members are checked.
duke@1 2282 */
duke@1 2283 void checkImplementations(JCClassDecl tree) {
mcimadamore@1415 2284 checkImplementations(tree, tree.sym, tree.sym);
duke@1 2285 }
jjg@1521 2286 //where
duke@1 2287 /** Check that all methods which implement some
duke@1 2288 * method in `ic' conform to the method they implement.
duke@1 2289 */
mcimadamore@1415 2290 void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) {
duke@1 2291 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2292 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2293 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2294 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2295 if (e.sym.kind == MTH &&
duke@1 2296 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2297 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2298 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2299 if (implmeth != null && implmeth != absmeth &&
duke@1 2300 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2301 (origin.flags() & INTERFACE)) {
duke@1 2302 // don't check if implmeth is in a class, yet
duke@1 2303 // origin is an interface. This case arises only
duke@1 2304 // if implmeth is declared in Object. The reason is
duke@1 2305 // that interfaces really don't inherit from
duke@1 2306 // Object it's just that the compiler represents
duke@1 2307 // things that way.
duke@1 2308 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2309 }
duke@1 2310 }
duke@1 2311 }
duke@1 2312 }
duke@1 2313 }
duke@1 2314 }
duke@1 2315
duke@1 2316 /** Check that all abstract methods implemented by a class are
duke@1 2317 * mutually compatible.
duke@1 2318 * @param pos Position to be used for error reporting.
duke@1 2319 * @param c The class whose interfaces are checked.
duke@1 2320 */
duke@1 2321 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2322 List<Type> supertypes = types.interfaces(c);
duke@1 2323 Type supertype = types.supertype(c);
jjg@1374 2324 if (supertype.hasTag(CLASS) &&
duke@1 2325 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2326 supertypes = supertypes.prepend(supertype);
duke@1 2327 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2328 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2329 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2330 return;
duke@1 2331 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2332 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2333 return;
duke@1 2334 }
duke@1 2335 checkCompatibleConcretes(pos, c);
duke@1 2336 }
duke@1 2337
mcimadamore@359 2338 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2339 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2340 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2341 // VM allows methods and variables with differing types
mcimadamore@359 2342 if (sym.kind == e.sym.kind &&
mcimadamore@359 2343 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2344 sym != e.sym &&
mcimadamore@359 2345 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2346 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2347 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2348 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2349 return;
mcimadamore@359 2350 }
mcimadamore@359 2351 }
mcimadamore@359 2352 }
mcimadamore@359 2353 }
mcimadamore@359 2354
mcimadamore@780 2355 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2356 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2357 *
mcimadamore@780 2358 * @param pos Position to be used for error reporting.
mcimadamore@780 2359 * @param site The class whose methods are checked.
mcimadamore@780 2360 * @param sym The method symbol to be checked.
mcimadamore@780 2361 */
mcimadamore@858 2362 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2363 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2364 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2365 //by method 'sym' in 'site'...
mcimadamore@1198 2366 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2367 if (!sym.overrides(m1, site.tsym, types, false)) continue;
mcimadamore@1198 2368 //...check each method m2 that is a member of 'site'
mcimadamore@1198 2369 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2370 if (m2 == m1) continue;
mcimadamore@858 2371 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2372 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1393 2373 if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) &&
mcimadamore@1198 2374 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2375 sym.flags_field |= CLASH;
mcimadamore@1198 2376 String key = m1 == sym ?
mcimadamore@858 2377 "name.clash.same.erasure.no.override" :
mcimadamore@858 2378 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2379 log.error(pos,
mcimadamore@858 2380 key,
mcimadamore@858 2381 sym, sym.location(),
mcimadamore@1198 2382 m2, m2.location(),
mcimadamore@1198 2383 m1, m1.location());
mcimadamore@858 2384 return;
mcimadamore@858 2385 }
mcimadamore@780 2386 }
mcimadamore@780 2387 }
mcimadamore@780 2388 }
mcimadamore@780 2389
mcimadamore@877 2390
mcimadamore@877 2391
mcimadamore@858 2392 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2393 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2394 *
mcimadamore@858 2395 * @param pos Position to be used for error reporting.
mcimadamore@858 2396 * @param site The class whose methods are checked.
mcimadamore@858 2397 * @param sym The method symbol to be checked.
mcimadamore@780 2398 */
mcimadamore@858 2399 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2400 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2401 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2402 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2403 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2404 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@1393 2405 if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck) &&
mcimadamore@877 2406 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2407 log.error(pos,
mcimadamore@858 2408 "name.clash.same.erasure.no.hide",
mcimadamore@858 2409 sym, sym.location(),
mcimadamore@877 2410 s, s.location());
mcimadamore@858 2411 return;
mcimadamore@858 2412 }
mcimadamore@858 2413 }
mcimadamore@858 2414 }
mcimadamore@780 2415
mcimadamore@858 2416 //where
mcimadamore@858 2417 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2418
mcimadamore@858 2419 Type site;
mcimadamore@780 2420
mcimadamore@858 2421 ClashFilter(Type site) {
mcimadamore@858 2422 this.site = site;
mcimadamore@858 2423 }
mcimadamore@858 2424
mcimadamore@858 2425 boolean shouldSkip(Symbol s) {
mcimadamore@858 2426 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2427 s.owner == site.tsym;
mcimadamore@858 2428 }
mcimadamore@858 2429
mcimadamore@858 2430 public boolean accepts(Symbol s) {
mcimadamore@858 2431 return s.kind == MTH &&
mcimadamore@858 2432 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2433 !shouldSkip(s) &&
mcimadamore@858 2434 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2435 !s.isConstructor();
mcimadamore@858 2436 }
mcimadamore@858 2437 }
mcimadamore@780 2438
mcimadamore@1393 2439 void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) {
mcimadamore@1393 2440 DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site);
mcimadamore@1393 2441 for (Symbol m : types.membersClosure(site, false).getElements(dcf)) {
mcimadamore@1393 2442 Assert.check(m.kind == MTH);
mcimadamore@1393 2443 List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m);
mcimadamore@1393 2444 if (prov.size() > 1) {
mcimadamore@1393 2445 ListBuffer<Symbol> abstracts = ListBuffer.lb();
mcimadamore@1393 2446 ListBuffer<Symbol> defaults = ListBuffer.lb();
mcimadamore@1393 2447 for (MethodSymbol provSym : prov) {
mcimadamore@1393 2448 if ((provSym.flags() & DEFAULT) != 0) {
mcimadamore@1393 2449 defaults = defaults.append(provSym);
mcimadamore@1393 2450 } else if ((provSym.flags() & ABSTRACT) != 0) {
mcimadamore@1393 2451 abstracts = abstracts.append(provSym);
mcimadamore@1393 2452 }
mcimadamore@1393 2453 if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) {
mcimadamore@1393 2454 //strong semantics - issue an error if two sibling interfaces
mcimadamore@1393 2455 //have two override-equivalent defaults - or if one is abstract
mcimadamore@1393 2456 //and the other is default
mcimadamore@1393 2457 String errKey;
mcimadamore@1393 2458 Symbol s1 = defaults.first();
mcimadamore@1393 2459 Symbol s2;
mcimadamore@1393 2460 if (defaults.size() > 1) {
mcimadamore@1393 2461 errKey = "types.incompatible.unrelated.defaults";
mcimadamore@1393 2462 s2 = defaults.toList().tail.head;
mcimadamore@1393 2463 } else {
mcimadamore@1393 2464 errKey = "types.incompatible.abstract.default";
mcimadamore@1393 2465 s2 = abstracts.first();
mcimadamore@1393 2466 }
mcimadamore@1393 2467 log.error(pos, errKey,
mcimadamore@1393 2468 Kinds.kindName(site.tsym), site,
mcimadamore@1393 2469 m.name, types.memberType(site, m).getParameterTypes(),
mcimadamore@1393 2470 s1.location(), s2.location());
mcimadamore@1393 2471 break;
mcimadamore@1393 2472 }
mcimadamore@1393 2473 }
mcimadamore@1393 2474 }
mcimadamore@1393 2475 }
mcimadamore@1393 2476 }
mcimadamore@1393 2477
mcimadamore@1393 2478 //where
mcimadamore@1393 2479 private class DefaultMethodClashFilter implements Filter<Symbol> {
mcimadamore@1393 2480
mcimadamore@1393 2481 Type site;
mcimadamore@1393 2482
mcimadamore@1393 2483 DefaultMethodClashFilter(Type site) {
mcimadamore@1393 2484 this.site = site;
mcimadamore@1393 2485 }
mcimadamore@1393 2486
mcimadamore@1393 2487 public boolean accepts(Symbol s) {
mcimadamore@1393 2488 return s.kind == MTH &&
mcimadamore@1393 2489 (s.flags() & DEFAULT) != 0 &&
mcimadamore@1393 2490 s.isInheritedIn(site.tsym, types) &&
mcimadamore@1393 2491 !s.isConstructor();
mcimadamore@1393 2492 }
mcimadamore@1393 2493 }
mcimadamore@1393 2494
mcimadamore@359 2495 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2496 */
mcimadamore@359 2497 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2498 if (!sym.type.isErroneous()) {
mcimadamore@359 2499 if (warnOnSyntheticConflicts) {
mcimadamore@359 2500 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2501 }
mcimadamore@359 2502 else {
mcimadamore@359 2503 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2504 }
mcimadamore@359 2505 }
mcimadamore@359 2506 }
mcimadamore@359 2507
duke@1 2508 /** Check that class c does not implement directly or indirectly
duke@1 2509 * the same parameterized interface with two different argument lists.
duke@1 2510 * @param pos Position to be used for error reporting.
duke@1 2511 * @param type The type whose interfaces are checked.
duke@1 2512 */
duke@1 2513 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2514 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2515 }
duke@1 2516 //where
duke@1 2517 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2518 * with their class symbol as key and their type as value. Make
duke@1 2519 * sure no class is entered with two different types.
duke@1 2520 */
duke@1 2521 void checkClassBounds(DiagnosticPosition pos,
duke@1 2522 Map<TypeSymbol,Type> seensofar,
duke@1 2523 Type type) {
duke@1 2524 if (type.isErroneous()) return;
duke@1 2525 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2526 Type it = l.head;
duke@1 2527 Type oldit = seensofar.put(it.tsym, it);
duke@1 2528 if (oldit != null) {
duke@1 2529 List<Type> oldparams = oldit.allparams();
duke@1 2530 List<Type> newparams = it.allparams();
duke@1 2531 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2532 log.error(pos, "cant.inherit.diff.arg",
duke@1 2533 it.tsym, Type.toString(oldparams),
duke@1 2534 Type.toString(newparams));
duke@1 2535 }
duke@1 2536 checkClassBounds(pos, seensofar, it);
duke@1 2537 }
duke@1 2538 Type st = types.supertype(type);
duke@1 2539 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2540 }
duke@1 2541
duke@1 2542 /** Enter interface into into set.
duke@1 2543 * If it existed already, issue a "repeated interface" error.
duke@1 2544 */
duke@1 2545 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2546 if (its.contains(it))
duke@1 2547 log.error(pos, "repeated.interface");
duke@1 2548 else {
duke@1 2549 its.add(it);
duke@1 2550 }
duke@1 2551 }
duke@1 2552
duke@1 2553 /* *************************************************************************
duke@1 2554 * Check annotations
duke@1 2555 **************************************************************************/
duke@1 2556
mcimadamore@629 2557 /**
mcimadamore@634 2558 * Recursively validate annotations values
mcimadamore@629 2559 */
mcimadamore@634 2560 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2561 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2562 @Override
mcimadamore@629 2563 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2564 if (!tree.type.isErroneous()) {
jjg@1017 2565 super.visitAnnotation(tree);
jjg@1017 2566 validateAnnotation(tree);
jjg@1017 2567 }
mcimadamore@629 2568 }
mcimadamore@629 2569 }
mcimadamore@634 2570 tree.accept(new AnnotationValidator());
mcimadamore@629 2571 }
mcimadamore@629 2572
jjg@1326 2573 /**
jjg@1326 2574 * {@literal
jjg@1326 2575 * Annotation types are restricted to primitives, String, an
duke@1 2576 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2577 * Anything>, arrays of the preceding.
jjg@1326 2578 * }
duke@1 2579 */
duke@1 2580 void validateAnnotationType(JCTree restype) {
duke@1 2581 // restype may be null if an error occurred, so don't bother validating it
duke@1 2582 if (restype != null) {
duke@1 2583 validateAnnotationType(restype.pos(), restype.type);
duke@1 2584 }
duke@1 2585 }
duke@1 2586
duke@1 2587 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2588 if (type.isPrimitive()) return;
duke@1 2589 if (types.isSameType(type, syms.stringType)) return;
duke@1 2590 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2591 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2592 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2593 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2594 validateAnnotationType(pos, types.elemtype(type));
duke@1 2595 return;
duke@1 2596 }
duke@1 2597 log.error(pos, "invalid.annotation.member.type");
duke@1 2598 }
duke@1 2599
duke@1 2600 /**
duke@1 2601 * "It is also a compile-time error if any method declared in an
duke@1 2602 * annotation type has a signature that is override-equivalent to
duke@1 2603 * that of any public or protected method declared in class Object
duke@1 2604 * or in the interface annotation.Annotation."
duke@1 2605 *
jjh@972 2606 * @jls 9.6 Annotation Types
duke@1 2607 */
duke@1 2608 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
jjg@1374 2609 for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
duke@1 2610 Scope s = sup.tsym.members();
duke@1 2611 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2612 if (e.sym.kind == MTH &&
duke@1 2613 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2614 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2615 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2616 }
duke@1 2617 }
duke@1 2618 }
duke@1 2619
duke@1 2620 /** Check the annotations of a symbol.
duke@1 2621 */
duke@1 2622 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2623 for (JCAnnotation a : annotations)
duke@1 2624 validateAnnotation(a, s);
duke@1 2625 }
duke@1 2626
jjg@1521 2627 /** Check the type annotations.
jjg@1521 2628 */
jjg@1521 2629 public void validateTypeAnnotations(List<JCAnnotation> annotations, boolean isTypeParameter) {
jjg@1521 2630 for (JCAnnotation a : annotations)
jjg@1521 2631 validateTypeAnnotation(a, isTypeParameter);
jjg@1521 2632 }
jjg@1521 2633
duke@1 2634 /** Check an annotation of a symbol.
duke@1 2635 */
jfranck@1313 2636 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2637 validateAnnotationTree(a);
duke@1 2638
duke@1 2639 if (!annotationApplicable(a, s))
duke@1 2640 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2641
duke@1 2642 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2643 if (!isOverrider(s))
duke@1 2644 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2645 }
mcimadamore@1497 2646
mcimadamore@1497 2647 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
mcimadamore@1497 2648 if (s.kind != TYP) {
mcimadamore@1497 2649 log.error(a.pos(), "bad.functional.intf.anno");
mcimadamore@1497 2650 } else {
mcimadamore@1497 2651 try {
mcimadamore@1497 2652 types.findDescriptorSymbol((TypeSymbol)s);
mcimadamore@1497 2653 } catch (Types.FunctionDescriptorLookupError ex) {
mcimadamore@1497 2654 log.error(a.pos(), "bad.functional.intf.anno.1", ex.getDiagnostic());
mcimadamore@1497 2655 }
mcimadamore@1497 2656 }
mcimadamore@1497 2657 }
duke@1 2658 }
duke@1 2659
jjg@1521 2660 public void validateTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2661 Assert.checkNonNull(a.type, "annotation tree hasn't been attributed yet: " + a);
jjg@1521 2662 validateAnnotationTree(a);
jjg@1521 2663
jjg@1521 2664 if (!isTypeAnnotation(a, isTypeParameter))
jjg@1521 2665 log.error(a.pos(), "annotation.type.not.applicable");
jjg@1521 2666 }
jjg@1521 2667
jfranck@1313 2668 /**
jjg@1492 2669 * Validate the proposed container 'repeatable' on the
jfranck@1313 2670 * annotation type symbol 's'. Report errors at position
jfranck@1313 2671 * 'pos'.
jfranck@1313 2672 *
jjg@1492 2673 * @param s The (annotation)type declaration annotated with a @Repeatable
jjg@1492 2674 * @param repeatable the @Repeatable on 's'
jfranck@1313 2675 * @param pos where to report errors
jfranck@1313 2676 */
jjg@1492 2677 public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) {
jjg@1492 2678 Assert.check(types.isSameType(repeatable.type, syms.repeatableType));
jfranck@1313 2679
jfranck@1313 2680 Type t = null;
jjg@1492 2681 List<Pair<MethodSymbol,Attribute>> l = repeatable.values;
jfranck@1313 2682 if (!l.isEmpty()) {
jfranck@1313 2683 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2684 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2685 }
jfranck@1313 2686
jfranck@1313 2687 if (t == null) {
jjg@1492 2688 // errors should already have been reported during Annotate
jfranck@1313 2689 return;
jfranck@1313 2690 }
jfranck@1313 2691
jjg@1492 2692 validateValue(t.tsym, s, pos);
jfranck@1313 2693 validateRetention(t.tsym, s, pos);
jfranck@1313 2694 validateDocumented(t.tsym, s, pos);
jfranck@1313 2695 validateInherited(t.tsym, s, pos);
jfranck@1313 2696 validateTarget(t.tsym, s, pos);
jfranck@1344 2697 validateDefault(t.tsym, s, pos);
jfranck@1313 2698 }
jfranck@1313 2699
jjg@1492 2700 private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jjg@1492 2701 Scope.Entry e = container.members().lookup(names.value);
jjg@1492 2702 if (e.scope != null && e.sym.kind == MTH) {
jjg@1492 2703 MethodSymbol m = (MethodSymbol) e.sym;
jjg@1492 2704 Type ret = m.getReturnType();
jjg@1492 2705 if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) {
jjg@1492 2706 log.error(pos, "invalid.repeatable.annotation.value.return",
jjg@1492 2707 container, ret, types.makeArrayType(contained.type));
jjg@1492 2708 }
jjg@1492 2709 } else {
jjg@1492 2710 log.error(pos, "invalid.repeatable.annotation.no.value", container);
jfranck@1313 2711 }
jfranck@1313 2712 }
jfranck@1313 2713
jfranck@1313 2714 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2715 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2716 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2717
jfranck@1313 2718 boolean error = false;
jfranck@1313 2719 switch (containedRetention) {
jfranck@1313 2720 case RUNTIME:
jfranck@1313 2721 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2722 error = true;
jfranck@1313 2723 }
jfranck@1313 2724 break;
jfranck@1313 2725 case CLASS:
jfranck@1313 2726 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2727 error = true;
jfranck@1313 2728 }
jfranck@1313 2729 }
jfranck@1313 2730 if (error ) {
jjg@1492 2731 log.error(pos, "invalid.repeatable.annotation.retention",
jfranck@1313 2732 container, containerRetention,
jfranck@1313 2733 contained, containedRetention);
jfranck@1313 2734 }
jfranck@1313 2735 }
jfranck@1313 2736
jfranck@1313 2737 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2738 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2739 if (container.attribute(syms.documentedType.tsym) == null) {
jjg@1492 2740 log.error(pos, "invalid.repeatable.annotation.not.documented", container, contained);
jfranck@1313 2741 }
jfranck@1313 2742 }
jfranck@1313 2743 }
jfranck@1313 2744
jfranck@1313 2745 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2746 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2747 if (container.attribute(syms.inheritedType.tsym) == null) {
jjg@1492 2748 log.error(pos, "invalid.repeatable.annotation.not.inherited", container, contained);
jfranck@1313 2749 }
jfranck@1313 2750 }
jfranck@1313 2751 }
jfranck@1313 2752
jfranck@1313 2753 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1634 2754 // The set of targets the container is applicable to must be a subset
jfranck@1634 2755 // (with respect to annotation target semantics) of the set of targets
jfranck@1634 2756 // the contained is applicable to. The target sets may be implicit or
jfranck@1634 2757 // explicit.
jfranck@1634 2758
jfranck@1634 2759 Set<Name> containerTargets;
jfranck@1313 2760 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2761 if (containerTarget == null) {
jfranck@1634 2762 containerTargets = getDefaultTargetSet();
jfranck@1634 2763 } else {
jfranck@1634 2764 containerTargets = new HashSet<Name>();
jfranck@1313 2765 for (Attribute app : containerTarget.values) {
jfranck@1313 2766 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2767 continue; // recovery
jfranck@1313 2768 }
jfranck@1313 2769 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2770 containerTargets.add(e.value.name);
jfranck@1313 2771 }
jfranck@1634 2772 }
jfranck@1634 2773
jfranck@1634 2774 Set<Name> containedTargets;
jfranck@1634 2775 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1634 2776 if (containedTarget == null) {
jfranck@1634 2777 containedTargets = getDefaultTargetSet();
jfranck@1634 2778 } else {
jfranck@1634 2779 containedTargets = new HashSet<Name>();
jfranck@1313 2780 for (Attribute app : containedTarget.values) {
jfranck@1313 2781 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2782 continue; // recovery
jfranck@1313 2783 }
jfranck@1313 2784 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2785 containedTargets.add(e.value.name);
jfranck@1313 2786 }
jfranck@1634 2787 }
jfranck@1634 2788
jfranck@1634 2789 if (!isTargetSubsetOf(containerTargets, containedTargets)) {
jjg@1492 2790 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2791 }
jfranck@1313 2792 }
jfranck@1313 2793
jfranck@1634 2794 /* get a set of names for the default target */
jfranck@1634 2795 private Set<Name> getDefaultTargetSet() {
jfranck@1634 2796 if (defaultTargets == null) {
jfranck@1634 2797 Set<Name> targets = new HashSet<Name>();
jfranck@1634 2798 targets.add(names.ANNOTATION_TYPE);
jfranck@1634 2799 targets.add(names.CONSTRUCTOR);
jfranck@1634 2800 targets.add(names.FIELD);
jfranck@1634 2801 targets.add(names.LOCAL_VARIABLE);
jfranck@1634 2802 targets.add(names.METHOD);
jfranck@1634 2803 targets.add(names.PACKAGE);
jfranck@1634 2804 targets.add(names.PARAMETER);
jfranck@1634 2805 targets.add(names.TYPE);
jfranck@1634 2806
jfranck@1634 2807 defaultTargets = java.util.Collections.unmodifiableSet(targets);
jfranck@1634 2808 }
jfranck@1634 2809
jfranck@1634 2810 return defaultTargets;
jfranck@1634 2811 }
jfranck@1634 2812 private Set<Name> defaultTargets;
jfranck@1634 2813
jfranck@1634 2814
jfranck@1634 2815 /** Checks that s is a subset of t, with respect to ElementType
jfranck@1313 2816 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE}
jfranck@1313 2817 */
jfranck@1634 2818 private boolean isTargetSubsetOf(Set<Name> s, Set<Name> t) {
jfranck@1634 2819 // Check that all elements in s are present in t
jfranck@1634 2820 for (Name n2 : s) {
jfranck@1313 2821 boolean currentElementOk = false;
jfranck@1634 2822 for (Name n1 : t) {
jfranck@1313 2823 if (n1 == n2) {
jfranck@1313 2824 currentElementOk = true;
jfranck@1313 2825 break;
jfranck@1313 2826 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2827 currentElementOk = true;
jfranck@1313 2828 break;
jfranck@1313 2829 }
jfranck@1313 2830 }
jfranck@1313 2831 if (!currentElementOk)
jfranck@1313 2832 return false;
jfranck@1313 2833 }
jfranck@1313 2834 return true;
jfranck@1313 2835 }
jfranck@1313 2836
jfranck@1344 2837 private void validateDefault(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1344 2838 // validate that all other elements of containing type has defaults
jfranck@1344 2839 Scope scope = container.members();
jfranck@1344 2840 for(Symbol elm : scope.getElements()) {
jfranck@1344 2841 if (elm.name != names.value &&
jfranck@1344 2842 elm.kind == Kinds.MTH &&
jfranck@1344 2843 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2844 log.error(pos,
jjg@1492 2845 "invalid.repeatable.annotation.elem.nondefault",
jfranck@1344 2846 container,
jfranck@1344 2847 elm);
jfranck@1344 2848 }
jfranck@1344 2849 }
jfranck@1344 2850 }
jfranck@1344 2851
duke@1 2852 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2853 boolean isOverrider(Symbol s) {
duke@1 2854 if (s.kind != MTH || s.isStatic())
duke@1 2855 return false;
duke@1 2856 MethodSymbol m = (MethodSymbol)s;
duke@1 2857 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2858 for (Type sup : types.closure(owner.type)) {
duke@1 2859 if (sup == owner.type)
duke@1 2860 continue; // skip "this"
duke@1 2861 Scope scope = sup.tsym.members();
duke@1 2862 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2863 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2864 return true;
duke@1 2865 }
duke@1 2866 }
duke@1 2867 return false;
duke@1 2868 }
duke@1 2869
jjg@1521 2870 /** Is the annotation applicable to type annotations? */
jjg@1521 2871 protected boolean isTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2872 Attribute.Compound atTarget =
jjg@1521 2873 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
jjg@1521 2874 if (atTarget == null) {
jjg@1521 2875 // An annotation without @Target is not a type annotation.
jjg@1521 2876 return false;
jjg@1521 2877 }
jjg@1521 2878
jjg@1521 2879 Attribute atValue = atTarget.member(names.value);
jjg@1521 2880 if (!(atValue instanceof Attribute.Array)) {
jjg@1521 2881 return false; // error recovery
jjg@1521 2882 }
jjg@1521 2883
jjg@1521 2884 Attribute.Array arr = (Attribute.Array) atValue;
jjg@1521 2885 for (Attribute app : arr.values) {
jjg@1521 2886 if (!(app instanceof Attribute.Enum)) {
jjg@1521 2887 return false; // recovery
jjg@1521 2888 }
jjg@1521 2889 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 2890
jjg@1521 2891 if (e.value.name == names.TYPE_USE)
jjg@1521 2892 return true;
jjg@1521 2893 else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER)
jjg@1521 2894 return true;
jjg@1521 2895 }
jjg@1521 2896 return false;
jjg@1521 2897 }
jjg@1521 2898
duke@1 2899 /** Is the annotation applicable to the symbol? */
duke@1 2900 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 2901 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jjg@1521 2902 Name[] targets;
jjg@1521 2903
jfranck@1313 2904 if (arr == null) {
jjg@1521 2905 targets = defaultTargetMetaInfo(a, s);
jjg@1521 2906 } else {
jjg@1521 2907 // TODO: can we optimize this?
jjg@1521 2908 targets = new Name[arr.values.length];
jjg@1521 2909 for (int i=0; i<arr.values.length; ++i) {
jjg@1521 2910 Attribute app = arr.values[i];
jjg@1521 2911 if (!(app instanceof Attribute.Enum)) {
jjg@1521 2912 return true; // recovery
jjg@1521 2913 }
jjg@1521 2914 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 2915 targets[i] = e.value.name;
jjg@1521 2916 }
jfranck@1313 2917 }
jjg@1521 2918 for (Name target : targets) {
jjg@1521 2919 if (target == names.TYPE)
duke@1 2920 { if (s.kind == TYP) return true; }
jjg@1521 2921 else if (target == names.FIELD)
duke@1 2922 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
jjg@1521 2923 else if (target == names.METHOD)
duke@1 2924 { if (s.kind == MTH && !s.isConstructor()) return true; }
jjg@1521 2925 else if (target == names.PARAMETER)
duke@1 2926 { if (s.kind == VAR &&
duke@1 2927 s.owner.kind == MTH &&
duke@1 2928 (s.flags() & PARAMETER) != 0)
duke@1 2929 return true;
duke@1 2930 }
jjg@1521 2931 else if (target == names.CONSTRUCTOR)
duke@1 2932 { if (s.kind == MTH && s.isConstructor()) return true; }
jjg@1521 2933 else if (target == names.LOCAL_VARIABLE)
duke@1 2934 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2935 (s.flags() & PARAMETER) == 0)
duke@1 2936 return true;
duke@1 2937 }
jjg@1521 2938 else if (target == names.ANNOTATION_TYPE)
duke@1 2939 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2940 return true;
duke@1 2941 }
jjg@1521 2942 else if (target == names.PACKAGE)
duke@1 2943 { if (s.kind == PCK) return true; }
jjg@1521 2944 else if (target == names.TYPE_USE)
jjg@308 2945 { if (s.kind == TYP ||
jjg@308 2946 s.kind == VAR ||
jjg@308 2947 (s.kind == MTH && !s.isConstructor() &&
jjg@1521 2948 !s.type.getReturnType().hasTag(VOID)) ||
jjg@1521 2949 (s.kind == MTH && s.isConstructor()))
jjg@1521 2950 return true;
jjg@1521 2951 }
jjg@1521 2952 else if (target == names.TYPE_PARAMETER)
jjg@1521 2953 { if (s.kind == TYP && s.type.hasTag(TYPEVAR))
jjg@308 2954 return true;
jjg@308 2955 }
duke@1 2956 else
duke@1 2957 return true; // recovery
duke@1 2958 }
duke@1 2959 return false;
duke@1 2960 }
duke@1 2961
jfranck@1313 2962
jfranck@1313 2963 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 2964 Attribute.Compound atTarget =
jfranck@1313 2965 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 2966 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 2967 Attribute atValue = atTarget.member(names.value);
jfranck@1313 2968 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 2969 return (Attribute.Array) atValue;
jfranck@1313 2970 }
jfranck@1313 2971
jjg@1521 2972 private final Name[] dfltTargetMeta;
jjg@1521 2973 private Name[] defaultTargetMetaInfo(JCAnnotation a, Symbol s) {
jjg@1521 2974 return dfltTargetMeta;
jjg@1521 2975 }
jjg@1521 2976
duke@1 2977 /** Check an annotation value.
jfranck@1445 2978 *
jfranck@1445 2979 * @param a The annotation tree to check
jfranck@1445 2980 * @return true if this annotation tree is valid, otherwise false
duke@1 2981 */
jfranck@1445 2982 public boolean validateAnnotationDeferErrors(JCAnnotation a) {
jfranck@1445 2983 boolean res = false;
jfranck@1445 2984 final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log);
jfranck@1445 2985 try {
jfranck@1445 2986 res = validateAnnotation(a);
jfranck@1445 2987 } finally {
jfranck@1445 2988 log.popDiagnosticHandler(diagHandler);
jfranck@1445 2989 }
jfranck@1445 2990 return res;
jfranck@1445 2991 }
jfranck@1445 2992
jfranck@1445 2993 private boolean validateAnnotation(JCAnnotation a) {
jfranck@1445 2994 boolean isValid = true;
jfranck@1445 2995 // collect an inventory of the annotation elements
jfranck@1445 2996 Set<MethodSymbol> members = new LinkedHashSet<MethodSymbol>();
duke@1 2997 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
jfranck@1729 2998 e != null;
jfranck@1729 2999 e = e.sibling)
mcimadamore@1920 3000 if (e.sym.kind == MTH && e.sym.name != names.clinit &&
mcimadamore@1920 3001 (e.sym.flags() & SYNTHETIC) == 0)
duke@1 3002 members.add((MethodSymbol) e.sym);
duke@1 3003
jfranck@1445 3004 // remove the ones that are assigned values
duke@1 3005 for (JCTree arg : a.args) {
jjg@1127 3006 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 3007 JCAssign assign = (JCAssign) arg;
duke@1 3008 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 3009 if (m == null || m.type.isErroneous()) continue;
jfranck@1445 3010 if (!members.remove(m)) {
jfranck@1445 3011 isValid = false;
jjg@479 3012 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 3013 m.name, a.type);
jfranck@1445 3014 }
duke@1 3015 }
duke@1 3016
duke@1 3017 // all the remaining ones better have default values
jfranck@1445 3018 List<Name> missingDefaults = List.nil();
mcimadamore@632 3019 for (MethodSymbol m : members) {
mcimadamore@632 3020 if (m.defaultValue == null && !m.type.isErroneous()) {
jfranck@1445 3021 missingDefaults = missingDefaults.append(m.name);
mcimadamore@632 3022 }
mcimadamore@632 3023 }
jfranck@1445 3024 missingDefaults = missingDefaults.reverse();
mcimadamore@632 3025 if (missingDefaults.nonEmpty()) {
jfranck@1445 3026 isValid = false;
mcimadamore@632 3027 String key = (missingDefaults.size() > 1)
mcimadamore@632 3028 ? "annotation.missing.default.value.1"
mcimadamore@632 3029 : "annotation.missing.default.value";
mcimadamore@632 3030 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 3031 }
duke@1 3032
duke@1 3033 // special case: java.lang.annotation.Target must not have
duke@1 3034 // repeated values in its value member
duke@1 3035 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 3036 a.args.tail == null)
jfranck@1445 3037 return isValid;
duke@1 3038
jfranck@1445 3039 if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery
duke@1 3040 JCAssign assign = (JCAssign) a.args.head;
duke@1 3041 Symbol m = TreeInfo.symbol(assign.lhs);
jfranck@1445 3042 if (m.name != names.value) return false;
duke@1 3043 JCTree rhs = assign.rhs;
jfranck@1445 3044 if (!rhs.hasTag(NEWARRAY)) return false;
duke@1 3045 JCNewArray na = (JCNewArray) rhs;
duke@1 3046 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 3047 for (JCTree elem : na.elems) {
duke@1 3048 if (!targets.add(TreeInfo.symbol(elem))) {
jfranck@1445 3049 isValid = false;
duke@1 3050 log.error(elem.pos(), "repeated.annotation.target");
duke@1 3051 }
duke@1 3052 }
jfranck@1445 3053 return isValid;
duke@1 3054 }
duke@1 3055
duke@1 3056 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 3057 if (allowAnnotations &&
mcimadamore@795 3058 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 3059 (s.flags() & DEPRECATED) != 0 &&
duke@1 3060 !syms.deprecatedType.isErroneous() &&
duke@1 3061 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 3062 log.warning(LintCategory.DEP_ANN,
jjg@612 3063 pos, "missing.deprecated.annotation");
duke@1 3064 }
duke@1 3065 }
duke@1 3066
mcimadamore@852 3067 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 3068 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 3069 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 3070 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 3071 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3072 @Override
mcimadamore@852 3073 public void report() {
mcimadamore@852 3074 warnDeprecated(pos, s);
mcimadamore@852 3075 }
mcimadamore@852 3076 });
jjg@1157 3077 }
mcimadamore@852 3078 }
mcimadamore@852 3079
mcimadamore@852 3080 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 3081 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 3082 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3083 public void report() {
mcimadamore@852 3084 if (enableSunApiLintControl)
mcimadamore@852 3085 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 3086 else
mcimadamore@1218 3087 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 3088 }
mcimadamore@852 3089 });
mcimadamore@852 3090 }
mcimadamore@852 3091 }
mcimadamore@852 3092
jjg@1569 3093 void checkProfile(final DiagnosticPosition pos, final Symbol s) {
jjg@1569 3094 if (profile != Profile.DEFAULT && (s.flags() & NOT_IN_PROFILE) != 0) {
jjg@1569 3095 log.error(pos, "not.in.profile", s, profile);
jjg@1569 3096 }
jjg@1569 3097 }
jjg@1569 3098
duke@1 3099 /* *************************************************************************
duke@1 3100 * Check for recursive annotation elements.
duke@1 3101 **************************************************************************/
duke@1 3102
duke@1 3103 /** Check for cycles in the graph of annotation elements.
duke@1 3104 */
duke@1 3105 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 3106 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 3107 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 3108 try {
duke@1 3109 tree.sym.flags_field |= LOCKED;
duke@1 3110 for (JCTree def : tree.defs) {
jjg@1127 3111 if (!def.hasTag(METHODDEF)) continue;
duke@1 3112 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 3113 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 3114 }
duke@1 3115 } finally {
duke@1 3116 tree.sym.flags_field &= ~LOCKED;
duke@1 3117 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 3118 }
duke@1 3119 }
duke@1 3120
duke@1 3121 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 3122 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 3123 return;
duke@1 3124 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 3125 log.error(pos, "cyclic.annotation.element");
duke@1 3126 return;
duke@1 3127 }
duke@1 3128 try {
duke@1 3129 tsym.flags_field |= LOCKED;
duke@1 3130 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 3131 Symbol s = e.sym;
duke@1 3132 if (s.kind != Kinds.MTH)
duke@1 3133 continue;
duke@1 3134 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 3135 }
duke@1 3136 } finally {
duke@1 3137 tsym.flags_field &= ~LOCKED;
duke@1 3138 tsym.flags_field |= ACYCLIC_ANN;
duke@1 3139 }
duke@1 3140 }
duke@1 3141
duke@1 3142 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
jjg@1374 3143 switch (type.getTag()) {
jjg@1374 3144 case CLASS:
duke@1 3145 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 3146 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 3147 break;
jjg@1374 3148 case ARRAY:
duke@1 3149 checkAnnotationResType(pos, types.elemtype(type));
duke@1 3150 break;
duke@1 3151 default:
duke@1 3152 break; // int etc
duke@1 3153 }
duke@1 3154 }
duke@1 3155
duke@1 3156 /* *************************************************************************
duke@1 3157 * Check for cycles in the constructor call graph.
duke@1 3158 **************************************************************************/
duke@1 3159
duke@1 3160 /** Check for cycles in the graph of constructors calling other
duke@1 3161 * constructors.
duke@1 3162 */
duke@1 3163 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 3164 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 3165
duke@1 3166 // enter each constructor this-call into the map
duke@1 3167 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 3168 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 3169 if (app == null) continue;
duke@1 3170 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 3171 if (TreeInfo.name(app.meth) == names._this) {
duke@1 3172 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 3173 } else {
duke@1 3174 meth.sym.flags_field |= ACYCLIC;
duke@1 3175 }
duke@1 3176 }
duke@1 3177
duke@1 3178 // Check for cycles in the map
duke@1 3179 Symbol[] ctors = new Symbol[0];
duke@1 3180 ctors = callMap.keySet().toArray(ctors);
duke@1 3181 for (Symbol caller : ctors) {
duke@1 3182 checkCyclicConstructor(tree, caller, callMap);
duke@1 3183 }
duke@1 3184 }
duke@1 3185
duke@1 3186 /** Look in the map to see if the given constructor is part of a
duke@1 3187 * call cycle.
duke@1 3188 */
duke@1 3189 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 3190 Map<Symbol,Symbol> callMap) {
duke@1 3191 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 3192 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 3193 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 3194 "recursive.ctor.invocation");
duke@1 3195 } else {
duke@1 3196 ctor.flags_field |= LOCKED;
duke@1 3197 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 3198 ctor.flags_field &= ~LOCKED;
duke@1 3199 }
duke@1 3200 ctor.flags_field |= ACYCLIC;
duke@1 3201 }
duke@1 3202 }
duke@1 3203
duke@1 3204 /* *************************************************************************
duke@1 3205 * Miscellaneous
duke@1 3206 **************************************************************************/
duke@1 3207
duke@1 3208 /**
duke@1 3209 * Return the opcode of the operator but emit an error if it is an
duke@1 3210 * error.
duke@1 3211 * @param pos position for error reporting.
duke@1 3212 * @param operator an operator
duke@1 3213 * @param tag a tree tag
duke@1 3214 * @param left type of left hand side
duke@1 3215 * @param right type of right hand side
duke@1 3216 */
duke@1 3217 int checkOperator(DiagnosticPosition pos,
duke@1 3218 OperatorSymbol operator,
jjg@1127 3219 JCTree.Tag tag,
duke@1 3220 Type left,
duke@1 3221 Type right) {
duke@1 3222 if (operator.opcode == ByteCodes.error) {
duke@1 3223 log.error(pos,
mcimadamore@853 3224 "operator.cant.be.applied.1",
duke@1 3225 treeinfo.operatorName(tag),
mcimadamore@853 3226 left, right);
duke@1 3227 }
duke@1 3228 return operator.opcode;
duke@1 3229 }
duke@1 3230
duke@1 3231
duke@1 3232 /**
duke@1 3233 * Check for division by integer constant zero
duke@1 3234 * @param pos Position for error reporting.
duke@1 3235 * @param operator The operator for the expression
duke@1 3236 * @param operand The right hand operand for the expression
duke@1 3237 */
duke@1 3238 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3239 if (operand.constValue() != null
mcimadamore@795 3240 && lint.isEnabled(LintCategory.DIVZERO)
vromero@1826 3241 && operand.getTag().isSubRangeOf(LONG)
duke@1 3242 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3243 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3244 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3245 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3246 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3247 }
duke@1 3248 }
duke@1 3249 }
duke@1 3250
duke@1 3251 /**
duke@1 3252 * Check for empty statements after if
duke@1 3253 */
duke@1 3254 void checkEmptyIf(JCIf tree) {
jjg@1127 3255 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3256 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3257 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3258 }
duke@1 3259
duke@1 3260 /** Check that symbol is unique in given scope.
duke@1 3261 * @param pos Position for error reporting.
duke@1 3262 * @param sym The symbol.
duke@1 3263 * @param s The scope.
duke@1 3264 */
duke@1 3265 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3266 if (sym.type.isErroneous())
duke@1 3267 return true;
duke@1 3268 if (sym.owner.name == names.any) return false;
duke@1 3269 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3270 if (sym != e.sym &&
mcimadamore@858 3271 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3272 sym.kind == e.sym.kind &&
mcimadamore@858 3273 sym.name != names.error &&
mcimadamore@858 3274 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3275 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3276 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3277 return true;
mcimadamore@907 3278 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3279 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3280 sym.flags_field |= CLASH;
mcimadamore@844 3281 return true;
mcimadamore@844 3282 } else {
duke@1 3283 duplicateError(pos, e.sym);
mcimadamore@844 3284 return false;
mcimadamore@844 3285 }
duke@1 3286 }
duke@1 3287 }
duke@1 3288 return true;
duke@1 3289 }
mcimadamore@844 3290
mcimadamore@858 3291 /** Report duplicate declaration error.
mcimadamore@858 3292 */
mcimadamore@858 3293 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3294 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3295 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3296 }
mcimadamore@858 3297 }
duke@1 3298
duke@1 3299 /** Check that single-type import is not already imported or top-level defined,
duke@1 3300 * but make an exception for two single-type imports which denote the same type.
duke@1 3301 * @param pos Position for error reporting.
duke@1 3302 * @param sym The symbol.
duke@1 3303 * @param s The scope
duke@1 3304 */
duke@1 3305 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3306 return checkUniqueImport(pos, sym, s, false);
duke@1 3307 }
duke@1 3308
duke@1 3309 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3310 * but make an exception for two single-type imports which denote the same type.
duke@1 3311 * @param pos Position for error reporting.
duke@1 3312 * @param sym The symbol.
duke@1 3313 * @param s The scope
duke@1 3314 */
duke@1 3315 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3316 return checkUniqueImport(pos, sym, s, true);
duke@1 3317 }
duke@1 3318
duke@1 3319 /** Check that single-type import is not already imported or top-level defined,
duke@1 3320 * but make an exception for two single-type imports which denote the same type.
duke@1 3321 * @param pos Position for error reporting.
duke@1 3322 * @param sym The symbol.
duke@1 3323 * @param s The scope.
duke@1 3324 * @param staticImport Whether or not this was a static import
duke@1 3325 */
duke@1 3326 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3327 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3328 // is encountered class entered via a class declaration?
duke@1 3329 boolean isClassDecl = e.scope == s;
duke@1 3330 if ((isClassDecl || sym != e.sym) &&
duke@1 3331 sym.kind == e.sym.kind &&
mcimadamore@1945 3332 sym.name != names.error &&
mcimadamore@1945 3333 (!staticImport || !e.isStaticallyImported())) {
duke@1 3334 if (!e.sym.type.isErroneous()) {
duke@1 3335 String what = e.sym.toString();
duke@1 3336 if (!isClassDecl) {
duke@1 3337 if (staticImport)
duke@1 3338 log.error(pos, "already.defined.static.single.import", what);
duke@1 3339 else
mcimadamore@1945 3340 log.error(pos, "already.defined.single.import", what);
duke@1 3341 }
duke@1 3342 else if (sym != e.sym)
duke@1 3343 log.error(pos, "already.defined.this.unit", what);
duke@1 3344 }
duke@1 3345 return false;
duke@1 3346 }
duke@1 3347 }
duke@1 3348 return true;
duke@1 3349 }
duke@1 3350
duke@1 3351 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3352 */
duke@1 3353 public void checkCanonical(JCTree tree) {
duke@1 3354 if (!isCanonical(tree))
duke@1 3355 log.error(tree.pos(), "import.requires.canonical",
duke@1 3356 TreeInfo.symbol(tree));
duke@1 3357 }
duke@1 3358 // where
duke@1 3359 private boolean isCanonical(JCTree tree) {
jjg@1127 3360 while (tree.hasTag(SELECT)) {
duke@1 3361 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3362 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3363 return false;
duke@1 3364 tree = s.selected;
duke@1 3365 }
duke@1 3366 return true;
duke@1 3367 }
duke@1 3368
ohrstrom@1384 3369 /** Check that an auxiliary class is not accessed from any other file than its own.
ohrstrom@1384 3370 */
ohrstrom@1384 3371 void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) {
ohrstrom@1384 3372 if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) &&
ohrstrom@1384 3373 (c.flags() & AUXILIARY) != 0 &&
ohrstrom@1384 3374 rs.isAccessible(env, c) &&
ohrstrom@1384 3375 !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile))
ohrstrom@1384 3376 {
ohrstrom@1384 3377 log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file",
ohrstrom@1384 3378 c, c.sourcefile);
ohrstrom@1384 3379 }
ohrstrom@1384 3380 }
ohrstrom@1384 3381
duke@1 3382 private class ConversionWarner extends Warner {
mcimadamore@795 3383 final String uncheckedKey;
duke@1 3384 final Type found;
duke@1 3385 final Type expected;
mcimadamore@795 3386 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3387 super(pos);
mcimadamore@795 3388 this.uncheckedKey = uncheckedKey;
duke@1 3389 this.found = found;
duke@1 3390 this.expected = expected;
duke@1 3391 }
duke@1 3392
jjg@398 3393 @Override
mcimadamore@795 3394 public void warn(LintCategory lint) {
duke@1 3395 boolean warned = this.warned;
mcimadamore@795 3396 super.warn(lint);
duke@1 3397 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3398 switch (lint) {
mcimadamore@795 3399 case UNCHECKED:
mcimadamore@795 3400 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3401 break;
mcimadamore@795 3402 case VARARGS:
mcimadamore@795 3403 if (method != null &&
mcimadamore@795 3404 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3405 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3406 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3407 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3408 }
mcimadamore@795 3409 break;
mcimadamore@795 3410 default:
mcimadamore@795 3411 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3412 }
duke@1 3413 }
duke@1 3414 }
duke@1 3415
duke@1 3416 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3417 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3418 }
duke@1 3419
duke@1 3420 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3421 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3422 }
duke@1 3423 }

mercurial