src/share/classes/com/sun/tools/javac/comp/Check.java

Thu, 04 Oct 2012 13:04:53 +0100

author
mcimadamore
date
Thu, 04 Oct 2012 13:04:53 +0100
changeset 1347
1408af4cd8b0
parent 1344
73312ec2cf7c
child 1348
573ceb23beeb
permissions
-rw-r--r--

7177387: Add target-typing support in method context
Summary: Add support for deferred types and speculative attribution
Reviewed-by: jjg, dlsmith

duke@1 1 /*
mcimadamore@1198 2 * Copyright (c) 1999, 2012, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
duke@1 30
duke@1 31 import com.sun.tools.javac.code.*;
duke@1 32 import com.sun.tools.javac.jvm.*;
duke@1 33 import com.sun.tools.javac.tree.*;
duke@1 34 import com.sun.tools.javac.util.*;
duke@1 35 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 36 import com.sun.tools.javac.util.List;
duke@1 37
duke@1 38 import com.sun.tools.javac.tree.JCTree.*;
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 43 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 44 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1337 45 import com.sun.tools.javac.comp.Infer.InferenceContext.FreeTypeListener;
duke@1 46
duke@1 47 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 48 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 49 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 50 import static com.sun.tools.javac.code.Kinds.*;
duke@1 51 import static com.sun.tools.javac.code.TypeTags.*;
jjg@1127 52 import static com.sun.tools.javac.code.TypeTags.WILDCARD;
duke@1 53
jjg@1127 54 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 55
duke@1 56 /** Type checking helper class for the attribution phase.
duke@1 57 *
jjg@581 58 * <p><b>This is NOT part of any supported API.
jjg@581 59 * If you write code that depends on this, you do so at your own risk.
duke@1 60 * This code and its internal interfaces are subject to change or
duke@1 61 * deletion without notice.</b>
duke@1 62 */
duke@1 63 public class Check {
duke@1 64 protected static final Context.Key<Check> checkKey =
duke@1 65 new Context.Key<Check>();
duke@1 66
jjg@113 67 private final Names names;
duke@1 68 private final Log log;
mcimadamore@1219 69 private final Resolve rs;
duke@1 70 private final Symtab syms;
mcimadamore@690 71 private final Enter enter;
mcimadamore@1347 72 private final DeferredAttr deferredAttr;
duke@1 73 private final Infer infer;
duke@1 74 private final Types types;
mcimadamore@89 75 private final JCDiagnostic.Factory diags;
mcimadamore@359 76 private boolean warnOnSyntheticConflicts;
jjg@576 77 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 78 private boolean enableSunApiLintControl;
duke@1 79 private final TreeInfo treeinfo;
duke@1 80
duke@1 81 // The set of lint options currently in effect. It is initialized
duke@1 82 // from the context, and then is set/reset as needed by Attr as it
duke@1 83 // visits all the various parts of the trees during attribution.
duke@1 84 private Lint lint;
duke@1 85
mcimadamore@795 86 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 87 // Attr as it visits new method declarations.
mcimadamore@795 88 private MethodSymbol method;
mcimadamore@795 89
duke@1 90 public static Check instance(Context context) {
duke@1 91 Check instance = context.get(checkKey);
duke@1 92 if (instance == null)
duke@1 93 instance = new Check(context);
duke@1 94 return instance;
duke@1 95 }
duke@1 96
duke@1 97 protected Check(Context context) {
duke@1 98 context.put(checkKey, this);
duke@1 99
jjg@113 100 names = Names.instance(context);
duke@1 101 log = Log.instance(context);
mcimadamore@1219 102 rs = Resolve.instance(context);
duke@1 103 syms = Symtab.instance(context);
mcimadamore@690 104 enter = Enter.instance(context);
mcimadamore@1347 105 deferredAttr = DeferredAttr.instance(context);
duke@1 106 infer = Infer.instance(context);
duke@1 107 this.types = Types.instance(context);
mcimadamore@89 108 diags = JCDiagnostic.Factory.instance(context);
duke@1 109 Options options = Options.instance(context);
duke@1 110 lint = Lint.instance(context);
duke@1 111 treeinfo = TreeInfo.instance(context);
duke@1 112
duke@1 113 Source source = Source.instance(context);
duke@1 114 allowGenerics = source.allowGenerics();
mcimadamore@1219 115 allowVarargs = source.allowVarargs();
duke@1 116 allowAnnotations = source.allowAnnotations();
jjg@398 117 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 118 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
jjg@1157 119 complexInference = options.isSet("complexinference");
jjg@700 120 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 121 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 122 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 123
jjg@398 124 Target target = Target.instance(context);
jjg@398 125 syntheticNameChar = target.syntheticNameChar();
jjg@398 126
duke@1 127 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 128 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 129 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 130 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 131
jjg@60 132 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 133 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 134 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 135 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 136 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 137 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 138
mcimadamore@852 139 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 140 }
duke@1 141
duke@1 142 /** Switch: generics enabled?
duke@1 143 */
duke@1 144 boolean allowGenerics;
duke@1 145
mcimadamore@1219 146 /** Switch: varargs enabled?
mcimadamore@1219 147 */
mcimadamore@1219 148 boolean allowVarargs;
mcimadamore@1219 149
duke@1 150 /** Switch: annotations enabled?
duke@1 151 */
duke@1 152 boolean allowAnnotations;
duke@1 153
jjg@398 154 /** Switch: covariant returns enabled?
jjg@398 155 */
jjg@398 156 boolean allowCovariantReturns;
jjg@398 157
mcimadamore@795 158 /** Switch: simplified varargs enabled?
mcimadamore@795 159 */
mcimadamore@795 160 boolean allowSimplifiedVarargs;
mcimadamore@795 161
duke@1 162 /** Switch: -complexinference option set?
duke@1 163 */
duke@1 164 boolean complexInference;
duke@1 165
jjg@398 166 /** Character for synthetic names
jjg@398 167 */
jjg@398 168 char syntheticNameChar;
jjg@398 169
duke@1 170 /** A table mapping flat names of all compiled classes in this run to their
duke@1 171 * symbols; maintained from outside.
duke@1 172 */
duke@1 173 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 174
duke@1 175 /** A handler for messages about deprecated usage.
duke@1 176 */
duke@1 177 private MandatoryWarningHandler deprecationHandler;
duke@1 178
duke@1 179 /** A handler for messages about unchecked or unsafe usage.
duke@1 180 */
duke@1 181 private MandatoryWarningHandler uncheckedHandler;
duke@1 182
jjg@582 183 /** A handler for messages about using proprietary API.
jjg@377 184 */
jjg@377 185 private MandatoryWarningHandler sunApiHandler;
duke@1 186
mcimadamore@852 187 /** A handler for deferred lint warnings.
mcimadamore@852 188 */
mcimadamore@852 189 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 190
duke@1 191 /* *************************************************************************
duke@1 192 * Errors and Warnings
duke@1 193 **************************************************************************/
duke@1 194
duke@1 195 Lint setLint(Lint newLint) {
duke@1 196 Lint prev = lint;
duke@1 197 lint = newLint;
duke@1 198 return prev;
duke@1 199 }
duke@1 200
mcimadamore@852 201 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 202 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 203 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 204 return prev;
mcimadamore@852 205 }
mcimadamore@852 206
mcimadamore@795 207 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 208 MethodSymbol prev = method;
mcimadamore@795 209 method = newMethod;
mcimadamore@795 210 return prev;
mcimadamore@795 211 }
mcimadamore@795 212
duke@1 213 /** Warn about deprecated symbol.
duke@1 214 * @param pos Position to be used for error reporting.
duke@1 215 * @param sym The deprecated symbol.
duke@1 216 */
duke@1 217 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 218 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 219 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 220 }
duke@1 221
duke@1 222 /** Warn about unchecked operation.
duke@1 223 * @param pos Position to be used for error reporting.
duke@1 224 * @param msg A string describing the problem.
duke@1 225 */
duke@1 226 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 227 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 228 uncheckedHandler.report(pos, msg, args);
duke@1 229 }
duke@1 230
mcimadamore@580 231 /** Warn about unsafe vararg method decl.
mcimadamore@580 232 * @param pos Position to be used for error reporting.
mcimadamore@580 233 * @param sym The deprecated symbol.
mcimadamore@580 234 */
mcimadamore@795 235 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 236 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 237 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 238 }
mcimadamore@580 239
jjg@582 240 /** Warn about using proprietary API.
jjg@377 241 * @param pos Position to be used for error reporting.
jjg@377 242 * @param msg A string describing the problem.
jjg@377 243 */
jjg@377 244 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 245 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 246 sunApiHandler.report(pos, msg, args);
jjg@377 247 }
jjg@377 248
jjg@505 249 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 250 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 251 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 252 }
jjg@505 253
duke@1 254 /**
duke@1 255 * Report any deferred diagnostics.
duke@1 256 */
duke@1 257 public void reportDeferredDiagnostics() {
duke@1 258 deprecationHandler.reportDeferredDiagnostic();
duke@1 259 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 260 sunApiHandler.reportDeferredDiagnostic();
duke@1 261 }
duke@1 262
duke@1 263
duke@1 264 /** Report a failure to complete a class.
duke@1 265 * @param pos Position to be used for error reporting.
duke@1 266 * @param ex The failure to report.
duke@1 267 */
duke@1 268 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 269 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 270 if (ex instanceof ClassReader.BadClassFile
jjg@576 271 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 272 else return syms.errType;
duke@1 273 }
duke@1 274
duke@1 275 /** Report an error that wrong type tag was found.
duke@1 276 * @param pos Position to be used for error reporting.
duke@1 277 * @param required An internationalized string describing the type tag
duke@1 278 * required.
duke@1 279 * @param found The type that was found.
duke@1 280 */
duke@1 281 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 282 // this error used to be raised by the parser,
jrose@267 283 // but has been delayed to this point:
jrose@267 284 if (found instanceof Type && ((Type)found).tag == VOID) {
jrose@267 285 log.error(pos, "illegal.start.of.type");
jrose@267 286 return syms.errType;
jrose@267 287 }
duke@1 288 log.error(pos, "type.found.req", found, required);
jjg@110 289 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 290 }
duke@1 291
duke@1 292 /** Report an error that symbol cannot be referenced before super
duke@1 293 * has been called.
duke@1 294 * @param pos Position to be used for error reporting.
duke@1 295 * @param sym The referenced symbol.
duke@1 296 */
duke@1 297 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 298 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 299 }
duke@1 300
duke@1 301 /** Report duplicate declaration error.
duke@1 302 */
duke@1 303 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 304 if (!sym.type.isErroneous()) {
mcimadamore@1085 305 Symbol location = sym.location();
mcimadamore@1085 306 if (location.kind == MTH &&
mcimadamore@1085 307 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 308 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 309 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 310 sym.location().enclClass());
mcimadamore@1085 311 } else {
mcimadamore@1085 312 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 313 kindName(sym.location()), sym.location());
mcimadamore@1085 314 }
duke@1 315 }
duke@1 316 }
duke@1 317
duke@1 318 /** Report array/varargs duplicate declaration
duke@1 319 */
duke@1 320 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 321 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 322 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 323 }
duke@1 324 }
duke@1 325
duke@1 326 /* ************************************************************************
duke@1 327 * duplicate declaration checking
duke@1 328 *************************************************************************/
duke@1 329
duke@1 330 /** Check that variable does not hide variable with same name in
duke@1 331 * immediately enclosing local scope.
duke@1 332 * @param pos Position for error reporting.
duke@1 333 * @param v The symbol.
duke@1 334 * @param s The scope.
duke@1 335 */
duke@1 336 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 337 if (s.next != null) {
duke@1 338 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 339 e.scope != null && e.sym.owner == v.owner;
duke@1 340 e = e.next()) {
duke@1 341 if (e.sym.kind == VAR &&
duke@1 342 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 343 v.name != names.error) {
duke@1 344 duplicateError(pos, e.sym);
duke@1 345 return;
duke@1 346 }
duke@1 347 }
duke@1 348 }
duke@1 349 }
duke@1 350
duke@1 351 /** Check that a class or interface does not hide a class or
duke@1 352 * interface with same name in immediately enclosing local scope.
duke@1 353 * @param pos Position for error reporting.
duke@1 354 * @param c The symbol.
duke@1 355 * @param s The scope.
duke@1 356 */
duke@1 357 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 358 if (s.next != null) {
duke@1 359 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 360 e.scope != null && e.sym.owner == c.owner;
duke@1 361 e = e.next()) {
mcimadamore@639 362 if (e.sym.kind == TYP && e.sym.type.tag != TYPEVAR &&
duke@1 363 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 364 c.name != names.error) {
duke@1 365 duplicateError(pos, e.sym);
duke@1 366 return;
duke@1 367 }
duke@1 368 }
duke@1 369 }
duke@1 370 }
duke@1 371
duke@1 372 /** Check that class does not have the same name as one of
duke@1 373 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 374 * return true if class is unique in its enclosing scope.
duke@1 375 * @param pos Position for error reporting.
duke@1 376 * @param name The class name.
duke@1 377 * @param s The enclosing scope.
duke@1 378 */
duke@1 379 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 380 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 381 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 382 duplicateError(pos, e.sym);
duke@1 383 return false;
duke@1 384 }
duke@1 385 }
duke@1 386 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 387 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 388 duplicateError(pos, sym);
duke@1 389 return true;
duke@1 390 }
duke@1 391 }
duke@1 392 return true;
duke@1 393 }
duke@1 394
duke@1 395 /* *************************************************************************
duke@1 396 * Class name generation
duke@1 397 **************************************************************************/
duke@1 398
duke@1 399 /** Return name of local class.
duke@1 400 * This is of the form <enclClass> $ n <classname>
duke@1 401 * where
duke@1 402 * enclClass is the flat name of the enclosing class,
duke@1 403 * classname is the simple name of the local class
duke@1 404 */
duke@1 405 Name localClassName(ClassSymbol c) {
duke@1 406 for (int i=1; ; i++) {
duke@1 407 Name flatname = names.
duke@1 408 fromString("" + c.owner.enclClass().flatname +
jjg@398 409 syntheticNameChar + i +
duke@1 410 c.name);
duke@1 411 if (compiled.get(flatname) == null) return flatname;
duke@1 412 }
duke@1 413 }
duke@1 414
duke@1 415 /* *************************************************************************
duke@1 416 * Type Checking
duke@1 417 **************************************************************************/
duke@1 418
mcimadamore@1238 419 /**
mcimadamore@1238 420 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 421 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 422 * vary significantly.
mcimadamore@1238 423 */
mcimadamore@1238 424 interface CheckContext {
mcimadamore@1238 425 /**
mcimadamore@1238 426 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 427 */
mcimadamore@1238 428 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 429 /**
mcimadamore@1238 430 * Report a check error
mcimadamore@1238 431 */
mcimadamore@1296 432 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 433 /**
mcimadamore@1238 434 * Obtain a warner for this check context
mcimadamore@1238 435 */
mcimadamore@1238 436 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 437
mcimadamore@1337 438 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 439
mcimadamore@1347 440 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1238 441 }
mcimadamore@1238 442
mcimadamore@1238 443 /**
mcimadamore@1238 444 * This class represent a check context that is nested within another check
mcimadamore@1238 445 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 446 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 447 * the forwarding pattern.
mcimadamore@1238 448 */
mcimadamore@1238 449 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 450 CheckContext enclosingContext;
mcimadamore@1238 451
mcimadamore@1238 452 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 453 this.enclosingContext = enclosingContext;
mcimadamore@1238 454 }
mcimadamore@1238 455
mcimadamore@1238 456 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 457 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 458 }
mcimadamore@1238 459
mcimadamore@1296 460 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 461 enclosingContext.report(pos, details);
mcimadamore@1238 462 }
mcimadamore@1238 463
mcimadamore@1238 464 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 465 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 466 }
mcimadamore@1337 467
mcimadamore@1337 468 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 469 return enclosingContext.inferenceContext();
mcimadamore@1337 470 }
mcimadamore@1347 471
mcimadamore@1347 472 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 473 return enclosingContext.deferredAttrContext();
mcimadamore@1347 474 }
mcimadamore@1238 475 }
mcimadamore@1238 476
mcimadamore@1238 477 /**
mcimadamore@1238 478 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 479 */
mcimadamore@1238 480 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 481 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 482 log.error(pos, "prob.found.req", details);
mcimadamore@1238 483 }
mcimadamore@1238 484 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 485 return types.isAssignable(found, req, warn);
mcimadamore@1238 486 }
mcimadamore@1238 487
mcimadamore@1238 488 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 489 return convertWarner(pos, found, req);
mcimadamore@1238 490 }
mcimadamore@1337 491
mcimadamore@1337 492 public InferenceContext inferenceContext() {
mcimadamore@1337 493 return infer.emptyContext;
mcimadamore@1337 494 }
mcimadamore@1347 495
mcimadamore@1347 496 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 497 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 498 }
mcimadamore@1238 499 };
mcimadamore@1238 500
duke@1 501 /** Check that a given type is assignable to a given proto-type.
duke@1 502 * If it is, return the type, otherwise return errType.
duke@1 503 * @param pos Position to be used for error reporting.
duke@1 504 * @param found The type that was found.
duke@1 505 * @param req The type that was required.
duke@1 506 */
duke@1 507 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 508 return checkType(pos, found, req, basicHandler);
darcy@609 509 }
darcy@609 510
mcimadamore@1337 511 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 512 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 513 if (inferenceContext.free(req)) {
mcimadamore@1337 514 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 515 @Override
mcimadamore@1337 516 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1337 517 checkType(pos, found, inferenceContext.asInstType(req, types), checkContext);
mcimadamore@1337 518 }
mcimadamore@1337 519 });
mcimadamore@1337 520 }
duke@1 521 if (req.tag == ERROR)
duke@1 522 return req;
duke@1 523 if (req.tag == NONE)
duke@1 524 return found;
mcimadamore@1238 525 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 526 return found;
mcimadamore@1238 527 } else {
mcimadamore@1238 528 if (found.tag <= DOUBLE && req.tag <= DOUBLE) {
mcimadamore@1296 529 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 530 return types.createErrorType(found);
mcimadamore@1238 531 }
mcimadamore@1296 532 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 533 return types.createErrorType(found);
duke@1 534 }
duke@1 535 }
duke@1 536
duke@1 537 /** Check that a given type can be cast to a given target type.
duke@1 538 * Return the result of the cast.
duke@1 539 * @param pos Position to be used for error reporting.
duke@1 540 * @param found The type that is being cast.
duke@1 541 * @param req The target type of the cast.
duke@1 542 */
duke@1 543 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 544 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 545 }
mcimadamore@1238 546 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 547 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 548 return req;
duke@1 549 } else {
mcimadamore@1296 550 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 551 return types.createErrorType(found);
duke@1 552 }
duke@1 553 }
mcimadamore@1237 554
mcimadamore@1237 555 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 556 * The problem should only be reported for non-292 cast
mcimadamore@1237 557 */
mcimadamore@1237 558 public void checkRedundantCast(Env<AttrContext> env, JCTypeCast tree) {
mcimadamore@1237 559 if (!tree.type.isErroneous() &&
mcimadamore@1237 560 (env.info.lint == null || env.info.lint.isEnabled(Lint.LintCategory.CAST))
mcimadamore@1237 561 && types.isSameType(tree.expr.type, tree.clazz.type)
mcimadamore@1237 562 && !is292targetTypeCast(tree)) {
mcimadamore@1237 563 log.warning(Lint.LintCategory.CAST,
mcimadamore@1237 564 tree.pos(), "redundant.cast", tree.expr.type);
mcimadamore@1237 565 }
mcimadamore@1237 566 }
mcimadamore@1237 567 //where
mcimadamore@1237 568 private boolean is292targetTypeCast(JCTypeCast tree) {
mcimadamore@1237 569 boolean is292targetTypeCast = false;
mcimadamore@1237 570 JCExpression expr = TreeInfo.skipParens(tree.expr);
mcimadamore@1237 571 if (expr.hasTag(APPLY)) {
mcimadamore@1237 572 JCMethodInvocation apply = (JCMethodInvocation)expr;
mcimadamore@1237 573 Symbol sym = TreeInfo.symbol(apply.meth);
mcimadamore@1237 574 is292targetTypeCast = sym != null &&
mcimadamore@1237 575 sym.kind == MTH &&
mcimadamore@1239 576 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 577 }
mcimadamore@1237 578 return is292targetTypeCast;
mcimadamore@1237 579 }
mcimadamore@1237 580
mcimadamore@1237 581
mcimadamore@1237 582
duke@1 583 //where
duke@1 584 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 585 * type variables?
duke@1 586 */
duke@1 587 boolean isTypeVar(Type t) {
duke@1 588 return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
duke@1 589 }
duke@1 590
duke@1 591 /** Check that a type is within some bounds.
duke@1 592 *
duke@1 593 * Used in TypeApply to verify that, e.g., X in V<X> is a valid
duke@1 594 * type argument.
duke@1 595 * @param pos Position to be used for error reporting.
duke@1 596 * @param a The type that should be bounded by bs.
duke@1 597 * @param bs The bound.
duke@1 598 */
mcimadamore@1216 599 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 600 if (a.isUnbound()) {
mcimadamore@821 601 return true;
mcimadamore@154 602 } else if (a.tag != WILDCARD) {
mcimadamore@154 603 a = types.upperBound(a);
mcimadamore@1216 604 return types.isSubtype(a, bound);
mcimadamore@154 605 } else if (a.isExtendsBound()) {
mcimadamore@1216 606 return types.isCastable(bound, types.upperBound(a), Warner.noWarnings);
mcimadamore@154 607 } else if (a.isSuperBound()) {
mcimadamore@1216 608 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 609 }
mcimadamore@821 610 return true;
mcimadamore@154 611 }
duke@1 612
duke@1 613 /** Check that type is different from 'void'.
duke@1 614 * @param pos Position to be used for error reporting.
duke@1 615 * @param t The type to be checked.
duke@1 616 */
duke@1 617 Type checkNonVoid(DiagnosticPosition pos, Type t) {
duke@1 618 if (t.tag == VOID) {
duke@1 619 log.error(pos, "void.not.allowed.here");
jjg@110 620 return types.createErrorType(t);
duke@1 621 } else {
duke@1 622 return t;
duke@1 623 }
duke@1 624 }
duke@1 625
duke@1 626 /** Check that type is a class or interface type.
duke@1 627 * @param pos Position to be used for error reporting.
duke@1 628 * @param t The type to be checked.
duke@1 629 */
duke@1 630 Type checkClassType(DiagnosticPosition pos, Type t) {
duke@1 631 if (t.tag != CLASS && t.tag != ERROR)
duke@1 632 return typeTagError(pos,
mcimadamore@89 633 diags.fragment("type.req.class"),
duke@1 634 (t.tag == TYPEVAR)
mcimadamore@89 635 ? diags.fragment("type.parameter", t)
duke@1 636 : t);
duke@1 637 else
duke@1 638 return t;
duke@1 639 }
duke@1 640
duke@1 641 /** Check that type is a class or interface type.
duke@1 642 * @param pos Position to be used for error reporting.
duke@1 643 * @param t The type to be checked.
duke@1 644 * @param noBounds True if type bounds are illegal here.
duke@1 645 */
duke@1 646 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 647 t = checkClassType(pos, t);
duke@1 648 if (noBounds && t.isParameterized()) {
duke@1 649 List<Type> args = t.getTypeArguments();
duke@1 650 while (args.nonEmpty()) {
duke@1 651 if (args.head.tag == WILDCARD)
duke@1 652 return typeTagError(pos,
jjg@598 653 diags.fragment("type.req.exact"),
duke@1 654 args.head);
duke@1 655 args = args.tail;
duke@1 656 }
duke@1 657 }
duke@1 658 return t;
duke@1 659 }
duke@1 660
duke@1 661 /** Check that type is a reifiable class, interface or array type.
duke@1 662 * @param pos Position to be used for error reporting.
duke@1 663 * @param t The type to be checked.
duke@1 664 */
duke@1 665 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
duke@1 666 if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
duke@1 667 return typeTagError(pos,
mcimadamore@89 668 diags.fragment("type.req.class.array"),
duke@1 669 t);
duke@1 670 } else if (!types.isReifiable(t)) {
duke@1 671 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 672 return types.createErrorType(t);
duke@1 673 } else {
duke@1 674 return t;
duke@1 675 }
duke@1 676 }
duke@1 677
duke@1 678 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 679 * or a type variable.
duke@1 680 * @param pos Position to be used for error reporting.
duke@1 681 * @param t The type to be checked.
duke@1 682 */
duke@1 683 Type checkRefType(DiagnosticPosition pos, Type t) {
duke@1 684 switch (t.tag) {
duke@1 685 case CLASS:
duke@1 686 case ARRAY:
duke@1 687 case TYPEVAR:
duke@1 688 case WILDCARD:
duke@1 689 case ERROR:
duke@1 690 return t;
duke@1 691 default:
duke@1 692 return typeTagError(pos,
mcimadamore@89 693 diags.fragment("type.req.ref"),
duke@1 694 t);
duke@1 695 }
duke@1 696 }
duke@1 697
jrose@267 698 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 699 * or a type variable.
jrose@267 700 * @param trees Original trees, used for error reporting.
jrose@267 701 * @param types The types to be checked.
jrose@267 702 */
jrose@267 703 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 704 List<JCExpression> tl = trees;
jrose@267 705 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 706 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 707 tl = tl.tail;
jrose@267 708 }
jrose@267 709 return types;
jrose@267 710 }
jrose@267 711
duke@1 712 /** Check that type is a null or reference type.
duke@1 713 * @param pos Position to be used for error reporting.
duke@1 714 * @param t The type to be checked.
duke@1 715 */
duke@1 716 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
duke@1 717 switch (t.tag) {
duke@1 718 case CLASS:
duke@1 719 case ARRAY:
duke@1 720 case TYPEVAR:
duke@1 721 case WILDCARD:
duke@1 722 case BOT:
duke@1 723 case ERROR:
duke@1 724 return t;
duke@1 725 default:
duke@1 726 return typeTagError(pos,
mcimadamore@89 727 diags.fragment("type.req.ref"),
duke@1 728 t);
duke@1 729 }
duke@1 730 }
duke@1 731
duke@1 732 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 733 * Return true if it doesn't.
duke@1 734 * @param pos Position to be used for error reporting.
duke@1 735 * @param flags The set of flags to be checked.
duke@1 736 * @param set1 Conflicting flags set #1.
duke@1 737 * @param set2 Conflicting flags set #2.
duke@1 738 */
duke@1 739 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 740 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 741 log.error(pos,
duke@1 742 "illegal.combination.of.modifiers",
mcimadamore@80 743 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 744 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 745 return false;
duke@1 746 } else
duke@1 747 return true;
duke@1 748 }
duke@1 749
mcimadamore@914 750 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 751 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 752 */
mcimadamore@914 753 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 754 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 755 t.isErroneous()) {
mcimadamore@914 756 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 757 } else if (tree.def != null) {
mcimadamore@914 758 log.error(tree.clazz.pos(),
mcimadamore@914 759 "cant.apply.diamond.1",
mcimadamore@914 760 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 761 return types.createErrorType(t);
mcimadamore@948 762 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 763 log.error(tree.clazz.pos(),
mcimadamore@914 764 "cant.apply.diamond.1",
mcimadamore@914 765 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 766 return types.createErrorType(t);
mcimadamore@993 767 } else if (tree.typeargs != null &&
mcimadamore@993 768 tree.typeargs.nonEmpty()) {
mcimadamore@993 769 log.error(tree.clazz.pos(),
mcimadamore@993 770 "cant.apply.diamond.1",
mcimadamore@993 771 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 772 return types.createErrorType(t);
mcimadamore@914 773 } else {
mcimadamore@914 774 return t;
mcimadamore@537 775 }
mcimadamore@537 776 }
mcimadamore@537 777
mcimadamore@795 778 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 779 MethodSymbol m = tree.sym;
mcimadamore@795 780 if (!allowSimplifiedVarargs) return;
mcimadamore@795 781 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 782 Type varargElemType = null;
mcimadamore@580 783 if (m.isVarArgs()) {
mcimadamore@795 784 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 785 }
mcimadamore@795 786 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 787 if (varargElemType != null) {
mcimadamore@795 788 log.error(tree,
mcimadamore@795 789 "varargs.invalid.trustme.anno",
mcimadamore@795 790 syms.trustMeType.tsym,
mcimadamore@795 791 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 792 } else {
mcimadamore@795 793 log.error(tree,
mcimadamore@795 794 "varargs.invalid.trustme.anno",
mcimadamore@795 795 syms.trustMeType.tsym,
mcimadamore@795 796 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 797 }
mcimadamore@795 798 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 799 types.isReifiable(varargElemType)) {
mcimadamore@795 800 warnUnsafeVararg(tree,
mcimadamore@795 801 "varargs.redundant.trustme.anno",
mcimadamore@795 802 syms.trustMeType.tsym,
mcimadamore@795 803 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 804 }
mcimadamore@795 805 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 806 !types.isReifiable(varargElemType)) {
mcimadamore@795 807 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 808 }
mcimadamore@580 809 }
mcimadamore@795 810 //where
mcimadamore@795 811 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 812 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 813 (s.isConstructor() ||
mcimadamore@795 814 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 815 }
mcimadamore@580 816
mcimadamore@1219 817 Type checkMethod(Type owntype,
mcimadamore@1219 818 Symbol sym,
mcimadamore@1219 819 Env<AttrContext> env,
mcimadamore@1219 820 final List<JCExpression> argtrees,
mcimadamore@1219 821 List<Type> argtypes,
mcimadamore@1226 822 boolean useVarargs,
mcimadamore@1226 823 boolean unchecked) {
mcimadamore@1219 824 // System.out.println("call : " + env.tree);
mcimadamore@1219 825 // System.out.println("method : " + owntype);
mcimadamore@1219 826 // System.out.println("actuals: " + argtypes);
mcimadamore@1219 827 List<Type> formals = owntype.getParameterTypes();
mcimadamore@1219 828 Type last = useVarargs ? formals.last() : null;
mcimadamore@1219 829 if (sym.name==names.init &&
mcimadamore@1219 830 sym.owner == syms.enumSym)
mcimadamore@1219 831 formals = formals.tail.tail;
mcimadamore@1219 832 List<JCExpression> args = argtrees;
mcimadamore@1347 833 DeferredAttr.DeferredTypeMap checkDeferredMap =
mcimadamore@1347 834 deferredAttr.new DeferredTypeMap(DeferredAttr.AttrMode.CHECK, sym, env.info.pendingResolutionPhase);
mcimadamore@1219 835 while (formals.head != last) {
mcimadamore@1219 836 JCTree arg = args.head;
mcimadamore@1219 837 Warner warn = convertWarner(arg.pos(), arg.type, formals.head);
mcimadamore@1219 838 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 839 args = args.tail;
mcimadamore@1219 840 formals = formals.tail;
mcimadamore@580 841 }
mcimadamore@1219 842 if (useVarargs) {
mcimadamore@1219 843 Type varArg = types.elemtype(last);
mcimadamore@1219 844 while (args.tail != null) {
mcimadamore@1219 845 JCTree arg = args.head;
mcimadamore@1219 846 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1219 847 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1219 848 args = args.tail;
mcimadamore@1219 849 }
mcimadamore@1219 850 } else if ((sym.flags() & VARARGS) != 0 && allowVarargs) {
mcimadamore@1219 851 // non-varargs call to varargs method
mcimadamore@1219 852 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1347 853 Type lastArg = checkDeferredMap.apply(argtypes.last());
mcimadamore@1219 854 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
mcimadamore@1219 855 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1219 856 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
mcimadamore@1219 857 types.elemtype(varParam), varParam);
mcimadamore@1219 858 }
mcimadamore@1226 859 if (unchecked) {
mcimadamore@1219 860 warnUnchecked(env.tree.pos(),
mcimadamore@1219 861 "unchecked.meth.invocation.applied",
mcimadamore@1219 862 kindName(sym),
mcimadamore@1219 863 sym.name,
mcimadamore@1219 864 rs.methodArguments(sym.type.getParameterTypes()),
mcimadamore@1347 865 rs.methodArguments(Type.map(argtypes, checkDeferredMap)),
mcimadamore@1219 866 kindName(sym.location()),
mcimadamore@1219 867 sym.location());
mcimadamore@1219 868 owntype = new MethodType(owntype.getParameterTypes(),
mcimadamore@1219 869 types.erasure(owntype.getReturnType()),
mcimadamore@1219 870 types.erasure(owntype.getThrownTypes()),
mcimadamore@1219 871 syms.methodClass);
mcimadamore@1219 872 }
mcimadamore@1219 873 if (useVarargs) {
mcimadamore@1219 874 JCTree tree = env.tree;
mcimadamore@1219 875 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 876 if (!types.isReifiable(argtype) &&
mcimadamore@1219 877 (!allowSimplifiedVarargs ||
mcimadamore@1219 878 sym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@1219 879 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 880 warnUnchecked(env.tree.pos(),
mcimadamore@1219 881 "unchecked.generic.array.creation",
mcimadamore@1219 882 argtype);
mcimadamore@1219 883 }
mcimadamore@1219 884 Type elemtype = types.elemtype(argtype);
mcimadamore@1219 885 switch (tree.getTag()) {
mcimadamore@1219 886 case APPLY:
mcimadamore@1219 887 ((JCMethodInvocation) tree).varargsElement = elemtype;
mcimadamore@1219 888 break;
mcimadamore@1219 889 case NEWCLASS:
mcimadamore@1219 890 ((JCNewClass) tree).varargsElement = elemtype;
mcimadamore@1219 891 break;
mcimadamore@1219 892 default:
mcimadamore@1219 893 throw new AssertionError(""+tree);
mcimadamore@1219 894 }
mcimadamore@1219 895 }
mcimadamore@1219 896 return owntype;
mcimadamore@547 897 }
mcimadamore@1219 898 //where
mcimadamore@1219 899 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
mcimadamore@1219 900 if (types.isConvertible(actual, formal, warn))
mcimadamore@1219 901 return;
mcimadamore@1219 902
mcimadamore@1219 903 if (formal.isCompound()
mcimadamore@1219 904 && types.isSubtype(actual, types.supertype(formal))
mcimadamore@1219 905 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
mcimadamore@1219 906 return;
mcimadamore@1219 907 }
mcimadamore@547 908
mcimadamore@821 909 /**
mcimadamore@821 910 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 911 * (see JLS 4.5)
mcimadamore@821 912 *
mcimadamore@821 913 * @param t class type to be checked
mcimadamore@821 914 * @return true if 't' is well-formed
mcimadamore@821 915 */
mcimadamore@821 916 public boolean checkValidGenericType(Type t) {
mcimadamore@821 917 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 918 }
mcimadamore@821 919 //WHERE
mcimadamore@821 920 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 921 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 922 List<Type> actuals = type.allparams();
mcimadamore@821 923 List<Type> args = type.getTypeArguments();
mcimadamore@821 924 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 925 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 926
mcimadamore@821 927 // For matching pairs of actual argument types `a' and
mcimadamore@821 928 // formal type parameters with declared bound `b' ...
mcimadamore@821 929 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 930 // exact type arguments needs to know their
mcimadamore@821 931 // bounds (for upper and lower bound
mcimadamore@1216 932 // calculations). So we create new bounds where
mcimadamore@1216 933 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 934 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 935 args = args.tail;
mcimadamore@821 936 forms = forms.tail;
mcimadamore@821 937 }
mcimadamore@821 938
mcimadamore@821 939 args = type.getTypeArguments();
mcimadamore@821 940 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 941 formals,
mcimadamore@821 942 types.capture(type).allparams());
mcimadamore@821 943 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 944 // Let the actual arguments know their bound
mcimadamore@821 945 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 946 args = args.tail;
mcimadamore@821 947 tvars_cap = tvars_cap.tail;
mcimadamore@821 948 }
mcimadamore@821 949
mcimadamore@821 950 args = type.getTypeArguments();
mcimadamore@1216 951 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 952
mcimadamore@1216 953 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 954 Type actual = args.head;
mcimadamore@854 955 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 956 !bounds.head.isErroneous() &&
mcimadamore@1216 957 !checkExtends(actual, bounds.head)) {
mcimadamore@821 958 return args.head;
mcimadamore@821 959 }
mcimadamore@821 960 args = args.tail;
mcimadamore@1216 961 bounds = bounds.tail;
mcimadamore@821 962 }
mcimadamore@821 963
mcimadamore@821 964 args = type.getTypeArguments();
mcimadamore@1216 965 bounds = bounds_buf.toList();
mcimadamore@821 966
mcimadamore@821 967 for (Type arg : types.capture(type).getTypeArguments()) {
mcimadamore@828 968 if (arg.tag == TYPEVAR &&
mcimadamore@828 969 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 970 !bounds.head.isErroneous() &&
mcimadamore@854 971 !isTypeArgErroneous(args.head)) {
mcimadamore@821 972 return args.head;
mcimadamore@821 973 }
mcimadamore@1216 974 bounds = bounds.tail;
mcimadamore@854 975 args = args.tail;
mcimadamore@821 976 }
mcimadamore@821 977
mcimadamore@821 978 return null;
mcimadamore@821 979 }
mcimadamore@854 980 //where
mcimadamore@854 981 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 982 return isTypeArgErroneous.visit(t);
mcimadamore@854 983 }
mcimadamore@854 984
mcimadamore@854 985 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 986 public Boolean visitType(Type t, Void s) {
mcimadamore@854 987 return t.isErroneous();
mcimadamore@854 988 }
mcimadamore@854 989 @Override
mcimadamore@854 990 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 991 return visit(t.getUpperBound());
mcimadamore@854 992 }
mcimadamore@854 993 @Override
mcimadamore@854 994 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 995 return visit(t.getUpperBound()) ||
mcimadamore@854 996 visit(t.getLowerBound());
mcimadamore@854 997 }
mcimadamore@854 998 @Override
mcimadamore@854 999 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1000 return visit(t.type);
mcimadamore@854 1001 }
mcimadamore@854 1002 };
mcimadamore@821 1003
duke@1 1004 /** Check that given modifiers are legal for given symbol and
duke@1 1005 * return modifiers together with any implicit modififiers for that symbol.
duke@1 1006 * Warning: we can't use flags() here since this method
duke@1 1007 * is called during class enter, when flags() would cause a premature
duke@1 1008 * completion.
duke@1 1009 * @param pos Position to be used for error reporting.
duke@1 1010 * @param flags The set of modifiers given in a definition.
duke@1 1011 * @param sym The defined symbol.
duke@1 1012 */
duke@1 1013 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1014 long mask;
duke@1 1015 long implicit = 0;
duke@1 1016 switch (sym.kind) {
duke@1 1017 case VAR:
duke@1 1018 if (sym.owner.kind != TYP)
duke@1 1019 mask = LocalVarFlags;
duke@1 1020 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1021 mask = implicit = InterfaceVarFlags;
duke@1 1022 else
duke@1 1023 mask = VarFlags;
duke@1 1024 break;
duke@1 1025 case MTH:
duke@1 1026 if (sym.name == names.init) {
duke@1 1027 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1028 // enum constructors cannot be declared public or
duke@1 1029 // protected and must be implicitly or explicitly
duke@1 1030 // private
duke@1 1031 implicit = PRIVATE;
duke@1 1032 mask = PRIVATE;
duke@1 1033 } else
duke@1 1034 mask = ConstructorFlags;
duke@1 1035 } else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1036 mask = implicit = InterfaceMethodFlags;
duke@1 1037 else {
duke@1 1038 mask = MethodFlags;
duke@1 1039 }
duke@1 1040 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1041 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 1042 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1043 break;
duke@1 1044 case TYP:
duke@1 1045 if (sym.isLocal()) {
duke@1 1046 mask = LocalClassFlags;
jjg@113 1047 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1048 // Anonymous classes in static methods are themselves static;
duke@1 1049 // that's why we admit STATIC here.
duke@1 1050 mask |= STATIC;
duke@1 1051 // JLS: Anonymous classes are final.
duke@1 1052 implicit |= FINAL;
duke@1 1053 }
duke@1 1054 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1055 (flags & ENUM) != 0)
duke@1 1056 log.error(pos, "enums.must.be.static");
duke@1 1057 } else if (sym.owner.kind == TYP) {
duke@1 1058 mask = MemberClassFlags;
duke@1 1059 if (sym.owner.owner.kind == PCK ||
duke@1 1060 (sym.owner.flags_field & STATIC) != 0)
duke@1 1061 mask |= STATIC;
duke@1 1062 else if ((flags & ENUM) != 0)
duke@1 1063 log.error(pos, "enums.must.be.static");
duke@1 1064 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1065 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1066 } else {
duke@1 1067 mask = ClassFlags;
duke@1 1068 }
duke@1 1069 // Interfaces are always ABSTRACT
duke@1 1070 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1071
duke@1 1072 if ((flags & ENUM) != 0) {
duke@1 1073 // enums can't be declared abstract or final
duke@1 1074 mask &= ~(ABSTRACT | FINAL);
duke@1 1075 implicit |= implicitEnumFinalFlag(tree);
duke@1 1076 }
duke@1 1077 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1078 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1079 break;
duke@1 1080 default:
duke@1 1081 throw new AssertionError();
duke@1 1082 }
duke@1 1083 long illegal = flags & StandardFlags & ~mask;
duke@1 1084 if (illegal != 0) {
duke@1 1085 if ((illegal & INTERFACE) != 0) {
duke@1 1086 log.error(pos, "intf.not.allowed.here");
duke@1 1087 mask |= INTERFACE;
duke@1 1088 }
duke@1 1089 else {
duke@1 1090 log.error(pos,
mcimadamore@80 1091 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1092 }
duke@1 1093 }
duke@1 1094 else if ((sym.kind == TYP ||
duke@1 1095 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1096 // in the presence of inner classes. Should it be deleted here?
duke@1 1097 checkDisjoint(pos, flags,
duke@1 1098 ABSTRACT,
duke@1 1099 PRIVATE | STATIC))
duke@1 1100 &&
duke@1 1101 checkDisjoint(pos, flags,
duke@1 1102 ABSTRACT | INTERFACE,
duke@1 1103 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1104 &&
duke@1 1105 checkDisjoint(pos, flags,
duke@1 1106 PUBLIC,
duke@1 1107 PRIVATE | PROTECTED)
duke@1 1108 &&
duke@1 1109 checkDisjoint(pos, flags,
duke@1 1110 PRIVATE,
duke@1 1111 PUBLIC | PROTECTED)
duke@1 1112 &&
duke@1 1113 checkDisjoint(pos, flags,
duke@1 1114 FINAL,
duke@1 1115 VOLATILE)
duke@1 1116 &&
duke@1 1117 (sym.kind == TYP ||
duke@1 1118 checkDisjoint(pos, flags,
duke@1 1119 ABSTRACT | NATIVE,
duke@1 1120 STRICTFP))) {
duke@1 1121 // skip
duke@1 1122 }
duke@1 1123 return flags & (mask | ~StandardFlags) | implicit;
duke@1 1124 }
duke@1 1125
duke@1 1126
duke@1 1127 /** Determine if this enum should be implicitly final.
duke@1 1128 *
duke@1 1129 * If the enum has no specialized enum contants, it is final.
duke@1 1130 *
duke@1 1131 * If the enum does have specialized enum contants, it is
duke@1 1132 * <i>not</i> final.
duke@1 1133 */
duke@1 1134 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1135 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1136 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1137 boolean specialized;
duke@1 1138 SpecialTreeVisitor() {
duke@1 1139 this.specialized = false;
duke@1 1140 };
duke@1 1141
jjg@398 1142 @Override
duke@1 1143 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1144
jjg@398 1145 @Override
duke@1 1146 public void visitVarDef(JCVariableDecl tree) {
duke@1 1147 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1148 if (tree.init instanceof JCNewClass &&
duke@1 1149 ((JCNewClass) tree.init).def != null) {
duke@1 1150 specialized = true;
duke@1 1151 }
duke@1 1152 }
duke@1 1153 }
duke@1 1154 }
duke@1 1155
duke@1 1156 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1157 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1158 for (JCTree defs: cdef.defs) {
duke@1 1159 defs.accept(sts);
duke@1 1160 if (sts.specialized) return 0;
duke@1 1161 }
duke@1 1162 return FINAL;
duke@1 1163 }
duke@1 1164
duke@1 1165 /* *************************************************************************
duke@1 1166 * Type Validation
duke@1 1167 **************************************************************************/
duke@1 1168
duke@1 1169 /** Validate a type expression. That is,
duke@1 1170 * check that all type arguments of a parametric type are within
duke@1 1171 * their bounds. This must be done in a second phase after type attributon
duke@1 1172 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1173 *
duke@1 1174 * class B<A extends C> { ... }
duke@1 1175 * class C extends B<C> { ... }
duke@1 1176 *
duke@1 1177 * and we can't make sure that the bound is already attributed because
duke@1 1178 * of possible cycles.
mcimadamore@638 1179 *
mcimadamore@638 1180 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1181 * and reporting any completion failures.
duke@1 1182 */
mcimadamore@122 1183 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1184 validate(tree, env, true);
duke@1 1185 }
mcimadamore@638 1186 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1187 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1188 }
duke@1 1189
duke@1 1190 /** Visitor method: Validate a list of type expressions.
duke@1 1191 */
mcimadamore@122 1192 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1193 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1194 validate(l.head, env);
duke@1 1195 }
duke@1 1196
duke@1 1197 /** A visitor class for type validation.
duke@1 1198 */
duke@1 1199 class Validator extends JCTree.Visitor {
duke@1 1200
mcimadamore@638 1201 boolean isOuter;
mcimadamore@638 1202 Env<AttrContext> env;
mcimadamore@638 1203
mcimadamore@638 1204 Validator(Env<AttrContext> env) {
mcimadamore@638 1205 this.env = env;
mcimadamore@638 1206 }
mcimadamore@638 1207
jjg@398 1208 @Override
duke@1 1209 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1210 tree.elemtype.accept(this);
duke@1 1211 }
duke@1 1212
jjg@398 1213 @Override
duke@1 1214 public void visitTypeApply(JCTypeApply tree) {
duke@1 1215 if (tree.type.tag == CLASS) {
duke@1 1216 List<JCExpression> args = tree.arguments;
mcimadamore@158 1217 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1218
mcimadamore@821 1219 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1220 if (incompatibleArg != null) {
mcimadamore@821 1221 for (JCTree arg : tree.arguments) {
mcimadamore@821 1222 if (arg.type == incompatibleArg) {
mcimadamore@829 1223 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1224 }
mcimadamore@829 1225 forms = forms.tail;
mcimadamore@829 1226 }
mcimadamore@829 1227 }
mcimadamore@829 1228
mcimadamore@829 1229 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1230
mcimadamore@638 1231 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1232
duke@1 1233 // For matching pairs of actual argument types `a' and
duke@1 1234 // formal type parameters with declared bound `b' ...
duke@1 1235 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1236 validateTree(args.head,
mcimadamore@638 1237 !(isOuter && is_java_lang_Class),
mcimadamore@638 1238 false);
duke@1 1239 args = args.tail;
duke@1 1240 forms = forms.tail;
duke@1 1241 }
duke@1 1242
duke@1 1243 // Check that this type is either fully parameterized, or
duke@1 1244 // not parameterized at all.
duke@1 1245 if (tree.type.getEnclosingType().isRaw())
duke@1 1246 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1247 if (tree.clazz.hasTag(SELECT))
duke@1 1248 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1249 }
duke@1 1250 }
duke@1 1251
jjg@398 1252 @Override
duke@1 1253 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1254 validateTrees(tree.bounds, true, isOuter);
duke@1 1255 checkClassBounds(tree.pos(), tree.type);
duke@1 1256 }
duke@1 1257
duke@1 1258 @Override
duke@1 1259 public void visitWildcard(JCWildcard tree) {
duke@1 1260 if (tree.inner != null)
mcimadamore@638 1261 validateTree(tree.inner, true, isOuter);
duke@1 1262 }
duke@1 1263
jjg@398 1264 @Override
duke@1 1265 public void visitSelect(JCFieldAccess tree) {
duke@1 1266 if (tree.type.tag == CLASS) {
duke@1 1267 visitSelectInternal(tree);
duke@1 1268
duke@1 1269 // Check that this type is either fully parameterized, or
duke@1 1270 // not parameterized at all.
duke@1 1271 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1272 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1273 }
duke@1 1274 }
mcimadamore@852 1275
duke@1 1276 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1277 if (tree.type.tsym.isStatic() &&
duke@1 1278 tree.selected.type.isParameterized()) {
duke@1 1279 // The enclosing type is not a class, so we are
duke@1 1280 // looking at a static member type. However, the
duke@1 1281 // qualifying expression is parameterized.
duke@1 1282 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1283 } else {
duke@1 1284 // otherwise validate the rest of the expression
mcimadamore@122 1285 tree.selected.accept(this);
duke@1 1286 }
duke@1 1287 }
duke@1 1288
duke@1 1289 /** Default visitor method: do nothing.
duke@1 1290 */
jjg@398 1291 @Override
duke@1 1292 public void visitTree(JCTree tree) {
duke@1 1293 }
mcimadamore@122 1294
mcimadamore@638 1295 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1296 try {
mcimadamore@638 1297 if (tree != null) {
mcimadamore@638 1298 this.isOuter = isOuter;
mcimadamore@638 1299 tree.accept(this);
mcimadamore@638 1300 if (checkRaw)
mcimadamore@638 1301 checkRaw(tree, env);
mcimadamore@638 1302 }
mcimadamore@638 1303 } catch (CompletionFailure ex) {
mcimadamore@638 1304 completionError(tree.pos(), ex);
mcimadamore@638 1305 }
mcimadamore@638 1306 }
mcimadamore@638 1307
mcimadamore@638 1308 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1309 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1310 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1311 }
mcimadamore@638 1312
mcimadamore@638 1313 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1314 if (lint.isEnabled(LintCategory.RAW) &&
mcimadamore@638 1315 tree.type.tag == CLASS &&
mcimadamore@638 1316 !TreeInfo.isDiamond(tree) &&
mcimadamore@1103 1317 !withinAnonConstr(env) &&
mcimadamore@638 1318 tree.type.isRaw()) {
mcimadamore@795 1319 log.warning(LintCategory.RAW,
mcimadamore@638 1320 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1321 }
mcimadamore@638 1322 }
mcimadamore@1103 1323
mcimadamore@1103 1324 boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1325 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1326 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1327 }
duke@1 1328 }
duke@1 1329
duke@1 1330 /* *************************************************************************
duke@1 1331 * Exception checking
duke@1 1332 **************************************************************************/
duke@1 1333
duke@1 1334 /* The following methods treat classes as sets that contain
duke@1 1335 * the class itself and all their subclasses
duke@1 1336 */
duke@1 1337
duke@1 1338 /** Is given type a subtype of some of the types in given list?
duke@1 1339 */
duke@1 1340 boolean subset(Type t, List<Type> ts) {
duke@1 1341 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1342 if (types.isSubtype(t, l.head)) return true;
duke@1 1343 return false;
duke@1 1344 }
duke@1 1345
duke@1 1346 /** Is given type a subtype or supertype of
duke@1 1347 * some of the types in given list?
duke@1 1348 */
duke@1 1349 boolean intersects(Type t, List<Type> ts) {
duke@1 1350 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1351 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1352 return false;
duke@1 1353 }
duke@1 1354
duke@1 1355 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1356 * in the list.
duke@1 1357 */
duke@1 1358 List<Type> incl(Type t, List<Type> ts) {
duke@1 1359 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1360 }
duke@1 1361
duke@1 1362 /** Remove type set from type set list.
duke@1 1363 */
duke@1 1364 List<Type> excl(Type t, List<Type> ts) {
duke@1 1365 if (ts.isEmpty()) {
duke@1 1366 return ts;
duke@1 1367 } else {
duke@1 1368 List<Type> ts1 = excl(t, ts.tail);
duke@1 1369 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1370 else if (ts1 == ts.tail) return ts;
duke@1 1371 else return ts1.prepend(ts.head);
duke@1 1372 }
duke@1 1373 }
duke@1 1374
duke@1 1375 /** Form the union of two type set lists.
duke@1 1376 */
duke@1 1377 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1378 List<Type> ts = ts1;
duke@1 1379 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1380 ts = incl(l.head, ts);
duke@1 1381 return ts;
duke@1 1382 }
duke@1 1383
duke@1 1384 /** Form the difference of two type lists.
duke@1 1385 */
duke@1 1386 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1387 List<Type> ts = ts1;
duke@1 1388 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1389 ts = excl(l.head, ts);
duke@1 1390 return ts;
duke@1 1391 }
duke@1 1392
duke@1 1393 /** Form the intersection of two type lists.
duke@1 1394 */
duke@1 1395 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1396 List<Type> ts = List.nil();
duke@1 1397 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1398 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1399 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1400 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1401 return ts;
duke@1 1402 }
duke@1 1403
duke@1 1404 /** Is exc an exception symbol that need not be declared?
duke@1 1405 */
duke@1 1406 boolean isUnchecked(ClassSymbol exc) {
duke@1 1407 return
duke@1 1408 exc.kind == ERR ||
duke@1 1409 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1410 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1411 }
duke@1 1412
duke@1 1413 /** Is exc an exception type that need not be declared?
duke@1 1414 */
duke@1 1415 boolean isUnchecked(Type exc) {
duke@1 1416 return
duke@1 1417 (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
duke@1 1418 (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
duke@1 1419 exc.tag == BOT;
duke@1 1420 }
duke@1 1421
duke@1 1422 /** Same, but handling completion failures.
duke@1 1423 */
duke@1 1424 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1425 try {
duke@1 1426 return isUnchecked(exc);
duke@1 1427 } catch (CompletionFailure ex) {
duke@1 1428 completionError(pos, ex);
duke@1 1429 return true;
duke@1 1430 }
duke@1 1431 }
duke@1 1432
duke@1 1433 /** Is exc handled by given exception list?
duke@1 1434 */
duke@1 1435 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1436 return isUnchecked(exc) || subset(exc, handled);
duke@1 1437 }
duke@1 1438
duke@1 1439 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1440 * @param thrown The list of thrown exceptions.
duke@1 1441 * @param handled The list of handled exceptions.
duke@1 1442 */
mcimadamore@362 1443 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1444 List<Type> unhandled = List.nil();
duke@1 1445 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1446 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1447 return unhandled;
duke@1 1448 }
duke@1 1449
duke@1 1450 /* *************************************************************************
duke@1 1451 * Overriding/Implementation checking
duke@1 1452 **************************************************************************/
duke@1 1453
duke@1 1454 /** The level of access protection given by a flag set,
duke@1 1455 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1456 */
duke@1 1457 static int protection(long flags) {
duke@1 1458 switch ((short)(flags & AccessFlags)) {
duke@1 1459 case PRIVATE: return 3;
duke@1 1460 case PROTECTED: return 1;
duke@1 1461 default:
duke@1 1462 case PUBLIC: return 0;
duke@1 1463 case 0: return 2;
duke@1 1464 }
duke@1 1465 }
duke@1 1466
duke@1 1467 /** A customized "cannot override" error message.
duke@1 1468 * @param m The overriding method.
duke@1 1469 * @param other The overridden method.
duke@1 1470 * @return An internationalized string.
duke@1 1471 */
mcimadamore@89 1472 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1473 String key;
duke@1 1474 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1475 key = "cant.override";
duke@1 1476 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1477 key = "cant.implement";
duke@1 1478 else
duke@1 1479 key = "clashes.with";
mcimadamore@89 1480 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1481 }
duke@1 1482
duke@1 1483 /** A customized "override" warning message.
duke@1 1484 * @param m The overriding method.
duke@1 1485 * @param other The overridden method.
duke@1 1486 * @return An internationalized string.
duke@1 1487 */
mcimadamore@89 1488 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1489 String key;
duke@1 1490 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1491 key = "unchecked.override";
duke@1 1492 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1493 key = "unchecked.implement";
duke@1 1494 else
duke@1 1495 key = "unchecked.clash.with";
mcimadamore@89 1496 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1497 }
duke@1 1498
duke@1 1499 /** A customized "override" warning message.
duke@1 1500 * @param m The overriding method.
duke@1 1501 * @param other The overridden method.
duke@1 1502 * @return An internationalized string.
duke@1 1503 */
mcimadamore@89 1504 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1505 String key;
duke@1 1506 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1507 key = "varargs.override";
duke@1 1508 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1509 key = "varargs.implement";
duke@1 1510 else
duke@1 1511 key = "varargs.clash.with";
mcimadamore@89 1512 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1513 }
duke@1 1514
duke@1 1515 /** Check that this method conforms with overridden method 'other'.
duke@1 1516 * where `origin' is the class where checking started.
duke@1 1517 * Complications:
duke@1 1518 * (1) Do not check overriding of synthetic methods
duke@1 1519 * (reason: they might be final).
duke@1 1520 * todo: check whether this is still necessary.
duke@1 1521 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1522 * than the method it implements. Augment the proxy methods with the
duke@1 1523 * undeclared exceptions in this case.
duke@1 1524 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1525 * has a result type
duke@1 1526 * extended by the result type of the method it implements.
duke@1 1527 * Change the proxies result type to the smaller type in this case.
duke@1 1528 *
duke@1 1529 * @param tree The tree from which positions
duke@1 1530 * are extracted for errors.
duke@1 1531 * @param m The overriding method.
duke@1 1532 * @param other The overridden method.
duke@1 1533 * @param origin The class of which the overriding method
duke@1 1534 * is a member.
duke@1 1535 */
duke@1 1536 void checkOverride(JCTree tree,
duke@1 1537 MethodSymbol m,
duke@1 1538 MethodSymbol other,
duke@1 1539 ClassSymbol origin) {
duke@1 1540 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1541 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1542 return;
duke@1 1543 }
duke@1 1544
duke@1 1545 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1546 if ((m.flags() & STATIC) != 0 &&
duke@1 1547 (other.flags() & STATIC) == 0) {
duke@1 1548 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1549 cannotOverride(m, other));
duke@1 1550 return;
duke@1 1551 }
duke@1 1552
duke@1 1553 // Error if instance method overrides static or final
duke@1 1554 // method (JLS 8.4.6.1).
duke@1 1555 if ((other.flags() & FINAL) != 0 ||
duke@1 1556 (m.flags() & STATIC) == 0 &&
duke@1 1557 (other.flags() & STATIC) != 0) {
duke@1 1558 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1559 cannotOverride(m, other),
mcimadamore@80 1560 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1561 return;
duke@1 1562 }
duke@1 1563
duke@1 1564 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1565 // handled in validateAnnotationMethod
duke@1 1566 return;
duke@1 1567 }
duke@1 1568
duke@1 1569 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1570 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1571 protection(m.flags()) > protection(other.flags())) {
duke@1 1572 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1573 cannotOverride(m, other),
mcimadamore@80 1574 other.flags() == 0 ?
mcimadamore@80 1575 Flag.PACKAGE :
mcimadamore@80 1576 asFlagSet(other.flags() & AccessFlags));
duke@1 1577 return;
duke@1 1578 }
duke@1 1579
duke@1 1580 Type mt = types.memberType(origin.type, m);
duke@1 1581 Type ot = types.memberType(origin.type, other);
duke@1 1582 // Error if overriding result type is different
duke@1 1583 // (or, in the case of generics mode, not a subtype) of
duke@1 1584 // overridden result type. We have to rename any type parameters
duke@1 1585 // before comparing types.
duke@1 1586 List<Type> mtvars = mt.getTypeArguments();
duke@1 1587 List<Type> otvars = ot.getTypeArguments();
duke@1 1588 Type mtres = mt.getReturnType();
duke@1 1589 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1590
mcimadamore@795 1591 overrideWarner.clear();
duke@1 1592 boolean resultTypesOK =
tbell@202 1593 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1594 if (!resultTypesOK) {
jjg@398 1595 if (!allowCovariantReturns &&
duke@1 1596 m.owner != origin &&
duke@1 1597 m.owner.isSubClass(other.owner, types)) {
duke@1 1598 // allow limited interoperability with covariant returns
duke@1 1599 } else {
mcimadamore@362 1600 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1601 "override.incompatible.ret",
mcimadamore@362 1602 cannotOverride(m, other),
duke@1 1603 mtres, otres);
duke@1 1604 return;
duke@1 1605 }
mcimadamore@795 1606 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1607 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1608 "override.unchecked.ret",
mcimadamore@362 1609 uncheckedOverrides(m, other),
mcimadamore@362 1610 mtres, otres);
duke@1 1611 }
duke@1 1612
duke@1 1613 // Error if overriding method throws an exception not reported
duke@1 1614 // by overridden method.
duke@1 1615 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1616 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1617 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1618 if (unhandledErased.nonEmpty()) {
duke@1 1619 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1620 "override.meth.doesnt.throw",
duke@1 1621 cannotOverride(m, other),
mcimadamore@362 1622 unhandledUnerased.head);
mcimadamore@362 1623 return;
mcimadamore@362 1624 }
mcimadamore@362 1625 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1626 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1627 "override.unchecked.thrown",
mcimadamore@362 1628 cannotOverride(m, other),
mcimadamore@362 1629 unhandledUnerased.head);
duke@1 1630 return;
duke@1 1631 }
duke@1 1632
duke@1 1633 // Optional warning if varargs don't agree
duke@1 1634 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1635 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1636 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1637 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1638 ? "override.varargs.missing"
duke@1 1639 : "override.varargs.extra",
duke@1 1640 varargsOverrides(m, other));
duke@1 1641 }
duke@1 1642
duke@1 1643 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1644 if ((other.flags() & BRIDGE) != 0) {
duke@1 1645 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1646 uncheckedOverrides(m, other));
duke@1 1647 }
duke@1 1648
duke@1 1649 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1650 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1651 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1652 }
duke@1 1653 }
duke@1 1654 // where
duke@1 1655 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1656 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1657 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1658 // because in that case, we will rediscover the issue when examining the method
duke@1 1659 // in the supertype.
duke@1 1660 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1661 // address the issue is when the method is the supertype implemementation: any other
duke@1 1662 // case, we will have dealt with when examining the supertype classes
duke@1 1663 ClassSymbol mc = m.enclClass();
duke@1 1664 Type st = types.supertype(origin.type);
duke@1 1665 if (st.tag != CLASS)
duke@1 1666 return true;
duke@1 1667 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1668
duke@1 1669 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1670 List<Type> intfs = types.interfaces(origin.type);
duke@1 1671 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1672 }
duke@1 1673 else
duke@1 1674 return (stimpl != m);
duke@1 1675 }
duke@1 1676
duke@1 1677
duke@1 1678 // used to check if there were any unchecked conversions
duke@1 1679 Warner overrideWarner = new Warner();
duke@1 1680
duke@1 1681 /** Check that a class does not inherit two concrete methods
duke@1 1682 * with the same signature.
duke@1 1683 * @param pos Position to be used for error reporting.
duke@1 1684 * @param site The class type to be checked.
duke@1 1685 */
duke@1 1686 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1687 Type sup = types.supertype(site);
duke@1 1688 if (sup.tag != CLASS) return;
duke@1 1689
duke@1 1690 for (Type t1 = sup;
duke@1 1691 t1.tsym.type.isParameterized();
duke@1 1692 t1 = types.supertype(t1)) {
duke@1 1693 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1694 e1 != null;
duke@1 1695 e1 = e1.sibling) {
duke@1 1696 Symbol s1 = e1.sym;
duke@1 1697 if (s1.kind != MTH ||
duke@1 1698 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1699 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1700 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1701 types,
duke@1 1702 true) != s1)
duke@1 1703 continue;
duke@1 1704 Type st1 = types.memberType(t1, s1);
duke@1 1705 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1706 if (st1 == s1.type) continue;
duke@1 1707
duke@1 1708 for (Type t2 = sup;
duke@1 1709 t2.tag == CLASS;
duke@1 1710 t2 = types.supertype(t2)) {
mcimadamore@24 1711 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1712 e2.scope != null;
duke@1 1713 e2 = e2.next()) {
duke@1 1714 Symbol s2 = e2.sym;
duke@1 1715 if (s2 == s1 ||
duke@1 1716 s2.kind != MTH ||
duke@1 1717 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1718 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1719 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1720 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1721 types,
duke@1 1722 true) != s2)
duke@1 1723 continue;
duke@1 1724 Type st2 = types.memberType(t2, s2);
duke@1 1725 if (types.overrideEquivalent(st1, st2))
duke@1 1726 log.error(pos, "concrete.inheritance.conflict",
duke@1 1727 s1, t1, s2, t2, sup);
duke@1 1728 }
duke@1 1729 }
duke@1 1730 }
duke@1 1731 }
duke@1 1732 }
duke@1 1733
duke@1 1734 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1735 * method with same name and arguments but incompatible return types.
duke@1 1736 * @param pos Position to be used for error reporting.
duke@1 1737 * @param t1 The first argument type.
duke@1 1738 * @param t2 The second argument type.
duke@1 1739 */
duke@1 1740 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1741 Type t1,
duke@1 1742 Type t2) {
duke@1 1743 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1744 types.makeCompoundType(t1, t2));
duke@1 1745 }
duke@1 1746
duke@1 1747 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1748 Type t1,
duke@1 1749 Type t2,
duke@1 1750 Type site) {
mcimadamore@746 1751 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1752 }
duke@1 1753
duke@1 1754 /** Return the first method which is defined with same args
duke@1 1755 * but different return types in two given interfaces, or null if none
duke@1 1756 * exists.
duke@1 1757 * @param t1 The first type.
duke@1 1758 * @param t2 The second type.
duke@1 1759 * @param site The most derived type.
duke@1 1760 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1761 */
mcimadamore@746 1762 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1763 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1764 closure(t1, interfaces1);
duke@1 1765 Map<TypeSymbol,Type> interfaces2;
duke@1 1766 if (t1 == t2)
duke@1 1767 interfaces2 = interfaces1;
duke@1 1768 else
duke@1 1769 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1770
duke@1 1771 for (Type t3 : interfaces1.values()) {
duke@1 1772 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1773 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1774 if (s != null) return s;
duke@1 1775 }
duke@1 1776 }
duke@1 1777 return null;
duke@1 1778 }
duke@1 1779
duke@1 1780 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1781 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
duke@1 1782 if (t.tag != CLASS) return;
duke@1 1783 if (typeMap.put(t.tsym, t) == null) {
duke@1 1784 closure(types.supertype(t), typeMap);
duke@1 1785 for (Type i : types.interfaces(t))
duke@1 1786 closure(i, typeMap);
duke@1 1787 }
duke@1 1788 }
duke@1 1789
duke@1 1790 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1791 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
duke@1 1792 if (t.tag != CLASS) return;
duke@1 1793 if (typesSkip.get(t.tsym) != null) return;
duke@1 1794 if (typeMap.put(t.tsym, t) == null) {
duke@1 1795 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1796 for (Type i : types.interfaces(t))
duke@1 1797 closure(i, typesSkip, typeMap);
duke@1 1798 }
duke@1 1799 }
duke@1 1800
duke@1 1801 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1802 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1803 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1804 Symbol s1 = e1.sym;
duke@1 1805 Type st1 = null;
duke@1 1806 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
duke@1 1807 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1808 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1809 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1810 Symbol s2 = e2.sym;
duke@1 1811 if (s1 == s2) continue;
duke@1 1812 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
duke@1 1813 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1814 Type st2 = types.memberType(t2, s2);
duke@1 1815 if (types.overrideEquivalent(st1, st2)) {
duke@1 1816 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1817 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1818 Type rt1 = st1.getReturnType();
duke@1 1819 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1820 boolean compat =
duke@1 1821 types.isSameType(rt1, rt2) ||
duke@1 1822 rt1.tag >= CLASS && rt2.tag >= CLASS &&
duke@1 1823 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
mcimadamore@59 1824 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
mcimadamore@59 1825 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1826 if (!compat) {
mcimadamore@746 1827 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1828 t1, t2, s2.name +
mcimadamore@746 1829 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1830 return s2;
mcimadamore@746 1831 }
mcimadamore@889 1832 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1833 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1834 log.error(pos,
mcimadamore@746 1835 "name.clash.same.erasure.no.override",
mcimadamore@746 1836 s1, s1.location(),
mcimadamore@746 1837 s2, s2.location());
mcimadamore@746 1838 return s2;
duke@1 1839 }
duke@1 1840 }
duke@1 1841 }
duke@1 1842 return null;
duke@1 1843 }
mcimadamore@59 1844 //WHERE
mcimadamore@59 1845 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1846 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1847 Type st1 = types.memberType(site, s1);
mcimadamore@59 1848 Type st2 = types.memberType(site, s2);
mcimadamore@59 1849 closure(site, supertypes);
mcimadamore@59 1850 for (Type t : supertypes.values()) {
mcimadamore@59 1851 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1852 Symbol s3 = e.sym;
mcimadamore@59 1853 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1854 Type st3 = types.memberType(site,s3);
mcimadamore@59 1855 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1856 if (s3.owner == site.tsym) {
mcimadamore@59 1857 return true;
mcimadamore@59 1858 }
mcimadamore@59 1859 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1860 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1861 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1862 Type rt1 = st1.getReturnType();
mcimadamore@59 1863 Type rt2 = st2.getReturnType();
mcimadamore@59 1864 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1865 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1866 boolean compat =
mcimadamore@59 1867 rt13.tag >= CLASS && rt23.tag >= CLASS &&
mcimadamore@59 1868 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
mcimadamore@59 1869 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
mcimadamore@59 1870 if (compat)
mcimadamore@59 1871 return true;
mcimadamore@59 1872 }
mcimadamore@59 1873 }
mcimadamore@59 1874 }
mcimadamore@59 1875 return false;
mcimadamore@59 1876 }
duke@1 1877
duke@1 1878 /** Check that a given method conforms with any method it overrides.
duke@1 1879 * @param tree The tree from which positions are extracted
duke@1 1880 * for errors.
duke@1 1881 * @param m The overriding method.
duke@1 1882 */
duke@1 1883 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1884 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1885 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1886 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1887 log.error(tree.pos(), "enum.no.finalize");
duke@1 1888 return;
duke@1 1889 }
mcimadamore@746 1890 for (Type t = origin.type; t.tag == CLASS;
duke@1 1891 t = types.supertype(t)) {
mcimadamore@746 1892 if (t != origin.type) {
mcimadamore@746 1893 checkOverride(tree, t, origin, m);
mcimadamore@746 1894 }
mcimadamore@746 1895 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1896 checkOverride(tree, t2, origin, m);
duke@1 1897 }
duke@1 1898 }
duke@1 1899 }
duke@1 1900
mcimadamore@746 1901 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1902 TypeSymbol c = site.tsym;
mcimadamore@746 1903 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1904 while (e.scope != null) {
mcimadamore@746 1905 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1906 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1907 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1908 }
mcimadamore@746 1909 }
mcimadamore@746 1910 e = e.next();
mcimadamore@746 1911 }
mcimadamore@746 1912 }
mcimadamore@746 1913
mcimadamore@746 1914 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 1915 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 1916 return (cf.accepts(s1) &&
mcimadamore@858 1917 cf.accepts(s2) &&
mcimadamore@858 1918 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 1919 }
mcimadamore@746 1920
mcimadamore@746 1921
duke@1 1922 /** Check that all abstract members of given class have definitions.
duke@1 1923 * @param pos Position to be used for error reporting.
duke@1 1924 * @param c The class.
duke@1 1925 */
duke@1 1926 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1927 try {
duke@1 1928 MethodSymbol undef = firstUndef(c, c);
duke@1 1929 if (undef != null) {
duke@1 1930 if ((c.flags() & ENUM) != 0 &&
duke@1 1931 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 1932 (c.flags() & FINAL) == 0) {
duke@1 1933 // add the ABSTRACT flag to an enum
duke@1 1934 c.flags_field |= ABSTRACT;
duke@1 1935 } else {
duke@1 1936 MethodSymbol undef1 =
duke@1 1937 new MethodSymbol(undef.flags(), undef.name,
duke@1 1938 types.memberType(c.type, undef), undef.owner);
duke@1 1939 log.error(pos, "does.not.override.abstract",
duke@1 1940 c, undef1, undef1.location());
duke@1 1941 }
duke@1 1942 }
duke@1 1943 } catch (CompletionFailure ex) {
duke@1 1944 completionError(pos, ex);
duke@1 1945 }
duke@1 1946 }
duke@1 1947 //where
duke@1 1948 /** Return first abstract member of class `c' that is not defined
duke@1 1949 * in `impl', null if there is none.
duke@1 1950 */
duke@1 1951 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 1952 MethodSymbol undef = null;
duke@1 1953 // Do not bother to search in classes that are not abstract,
duke@1 1954 // since they cannot have abstract members.
duke@1 1955 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 1956 Scope s = c.members();
duke@1 1957 for (Scope.Entry e = s.elems;
duke@1 1958 undef == null && e != null;
duke@1 1959 e = e.sibling) {
duke@1 1960 if (e.sym.kind == MTH &&
duke@1 1961 (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
duke@1 1962 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 1963 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
duke@1 1964 if (implmeth == null || implmeth == absmeth)
duke@1 1965 undef = absmeth;
duke@1 1966 }
duke@1 1967 }
duke@1 1968 if (undef == null) {
duke@1 1969 Type st = types.supertype(c.type);
duke@1 1970 if (st.tag == CLASS)
duke@1 1971 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 1972 }
duke@1 1973 for (List<Type> l = types.interfaces(c.type);
duke@1 1974 undef == null && l.nonEmpty();
duke@1 1975 l = l.tail) {
duke@1 1976 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 1977 }
duke@1 1978 }
duke@1 1979 return undef;
duke@1 1980 }
duke@1 1981
mcimadamore@690 1982 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 1983 CycleChecker cc = new CycleChecker();
mcimadamore@690 1984 cc.scan(tree);
mcimadamore@690 1985 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 1986 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 1987 }
mcimadamore@690 1988 }
mcimadamore@690 1989
mcimadamore@690 1990 class CycleChecker extends TreeScanner {
mcimadamore@690 1991
mcimadamore@690 1992 List<Symbol> seenClasses = List.nil();
mcimadamore@690 1993 boolean errorFound = false;
mcimadamore@690 1994 boolean partialCheck = false;
mcimadamore@690 1995
mcimadamore@690 1996 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 1997 if (sym != null && sym.kind == TYP) {
mcimadamore@690 1998 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 1999 if (classEnv != null) {
mcimadamore@690 2000 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2001 try {
mcimadamore@690 2002 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2003 scan(classEnv.tree);
mcimadamore@690 2004 }
mcimadamore@690 2005 finally {
mcimadamore@690 2006 log.useSource(prevSource.getFile());
mcimadamore@690 2007 }
mcimadamore@690 2008 } else if (sym.kind == TYP) {
mcimadamore@690 2009 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2010 }
mcimadamore@690 2011 } else {
mcimadamore@690 2012 //not completed yet
mcimadamore@690 2013 partialCheck = true;
mcimadamore@690 2014 }
mcimadamore@690 2015 }
mcimadamore@690 2016
mcimadamore@690 2017 @Override
mcimadamore@690 2018 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2019 super.visitSelect(tree);
mcimadamore@690 2020 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2021 }
mcimadamore@690 2022
mcimadamore@690 2023 @Override
mcimadamore@690 2024 public void visitIdent(JCIdent tree) {
mcimadamore@690 2025 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2026 }
mcimadamore@690 2027
mcimadamore@690 2028 @Override
mcimadamore@690 2029 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2030 scan(tree.clazz);
mcimadamore@690 2031 }
mcimadamore@690 2032
mcimadamore@690 2033 @Override
mcimadamore@690 2034 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2035 scan(tree.elemtype);
mcimadamore@690 2036 }
mcimadamore@690 2037
mcimadamore@690 2038 @Override
mcimadamore@690 2039 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2040 List<JCTree> supertypes = List.nil();
mcimadamore@690 2041 if (tree.getExtendsClause() != null) {
mcimadamore@690 2042 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2043 }
mcimadamore@690 2044 if (tree.getImplementsClause() != null) {
mcimadamore@690 2045 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2046 supertypes = supertypes.prepend(intf);
mcimadamore@690 2047 }
mcimadamore@690 2048 }
mcimadamore@690 2049 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2050 }
mcimadamore@690 2051
mcimadamore@690 2052 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2053 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2054 return;
mcimadamore@690 2055 if (seenClasses.contains(c)) {
mcimadamore@690 2056 errorFound = true;
mcimadamore@690 2057 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2058 } else if (!c.type.isErroneous()) {
mcimadamore@690 2059 try {
mcimadamore@690 2060 seenClasses = seenClasses.prepend(c);
mcimadamore@690 2061 if (c.type.tag == CLASS) {
mcimadamore@690 2062 if (supertypes.nonEmpty()) {
mcimadamore@690 2063 scan(supertypes);
mcimadamore@690 2064 }
mcimadamore@690 2065 else {
mcimadamore@690 2066 ClassType ct = (ClassType)c.type;
mcimadamore@690 2067 if (ct.supertype_field == null ||
mcimadamore@690 2068 ct.interfaces_field == null) {
mcimadamore@690 2069 //not completed yet
mcimadamore@690 2070 partialCheck = true;
mcimadamore@690 2071 return;
mcimadamore@690 2072 }
mcimadamore@690 2073 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2074 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2075 checkSymbol(pos, intf.tsym);
mcimadamore@690 2076 }
mcimadamore@690 2077 }
mcimadamore@690 2078 if (c.owner.kind == TYP) {
mcimadamore@690 2079 checkSymbol(pos, c.owner);
mcimadamore@690 2080 }
mcimadamore@690 2081 }
mcimadamore@690 2082 } finally {
mcimadamore@690 2083 seenClasses = seenClasses.tail;
mcimadamore@690 2084 }
mcimadamore@690 2085 }
mcimadamore@690 2086 }
mcimadamore@690 2087 }
mcimadamore@690 2088
duke@1 2089 /** Check for cyclic references. Issue an error if the
duke@1 2090 * symbol of the type referred to has a LOCKED flag set.
duke@1 2091 *
duke@1 2092 * @param pos Position to be used for error reporting.
duke@1 2093 * @param t The type referred to.
duke@1 2094 */
duke@1 2095 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2096 checkNonCyclicInternal(pos, t);
duke@1 2097 }
duke@1 2098
duke@1 2099
duke@1 2100 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2101 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2102 }
duke@1 2103
mcimadamore@236 2104 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2105 final TypeVar tv;
mcimadamore@42 2106 if (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2107 return;
duke@1 2108 if (seen.contains(t)) {
duke@1 2109 tv = (TypeVar)t;
jjg@110 2110 tv.bound = types.createErrorType(t);
duke@1 2111 log.error(pos, "cyclic.inheritance", t);
duke@1 2112 } else if (t.tag == TYPEVAR) {
duke@1 2113 tv = (TypeVar)t;
mcimadamore@236 2114 seen = seen.prepend(tv);
duke@1 2115 for (Type b : types.getBounds(tv))
duke@1 2116 checkNonCyclic1(pos, b, seen);
duke@1 2117 }
duke@1 2118 }
duke@1 2119
duke@1 2120 /** Check for cyclic references. Issue an error if the
duke@1 2121 * symbol of the type referred to has a LOCKED flag set.
duke@1 2122 *
duke@1 2123 * @param pos Position to be used for error reporting.
duke@1 2124 * @param t The type referred to.
duke@1 2125 * @returns True if the check completed on all attributed classes
duke@1 2126 */
duke@1 2127 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2128 boolean complete = true; // was the check complete?
duke@1 2129 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2130 Symbol c = t.tsym;
duke@1 2131 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2132
duke@1 2133 if ((c.flags_field & LOCKED) != 0) {
duke@1 2134 noteCyclic(pos, (ClassSymbol)c);
duke@1 2135 } else if (!c.type.isErroneous()) {
duke@1 2136 try {
duke@1 2137 c.flags_field |= LOCKED;
duke@1 2138 if (c.type.tag == CLASS) {
duke@1 2139 ClassType clazz = (ClassType)c.type;
duke@1 2140 if (clazz.interfaces_field != null)
duke@1 2141 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2142 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2143 if (clazz.supertype_field != null) {
duke@1 2144 Type st = clazz.supertype_field;
duke@1 2145 if (st != null && st.tag == CLASS)
duke@1 2146 complete &= checkNonCyclicInternal(pos, st);
duke@1 2147 }
duke@1 2148 if (c.owner.kind == TYP)
duke@1 2149 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2150 }
duke@1 2151 } finally {
duke@1 2152 c.flags_field &= ~LOCKED;
duke@1 2153 }
duke@1 2154 }
duke@1 2155 if (complete)
duke@1 2156 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2157 if (complete) c.flags_field |= ACYCLIC;
duke@1 2158 return complete;
duke@1 2159 }
duke@1 2160
duke@1 2161 /** Note that we found an inheritance cycle. */
duke@1 2162 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2163 log.error(pos, "cyclic.inheritance", c);
duke@1 2164 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2165 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2166 Type st = types.supertype(c.type);
duke@1 2167 if (st.tag == CLASS)
jjg@110 2168 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2169 c.type = types.createErrorType(c, c.type);
duke@1 2170 c.flags_field |= ACYCLIC;
duke@1 2171 }
duke@1 2172
duke@1 2173 /** Check that all methods which implement some
duke@1 2174 * method conform to the method they implement.
duke@1 2175 * @param tree The class definition whose members are checked.
duke@1 2176 */
duke@1 2177 void checkImplementations(JCClassDecl tree) {
duke@1 2178 checkImplementations(tree, tree.sym);
duke@1 2179 }
duke@1 2180 //where
duke@1 2181 /** Check that all methods which implement some
duke@1 2182 * method in `ic' conform to the method they implement.
duke@1 2183 */
duke@1 2184 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
duke@1 2185 ClassSymbol origin = tree.sym;
duke@1 2186 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2187 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2188 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2189 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2190 if (e.sym.kind == MTH &&
duke@1 2191 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2192 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2193 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2194 if (implmeth != null && implmeth != absmeth &&
duke@1 2195 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2196 (origin.flags() & INTERFACE)) {
duke@1 2197 // don't check if implmeth is in a class, yet
duke@1 2198 // origin is an interface. This case arises only
duke@1 2199 // if implmeth is declared in Object. The reason is
duke@1 2200 // that interfaces really don't inherit from
duke@1 2201 // Object it's just that the compiler represents
duke@1 2202 // things that way.
duke@1 2203 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2204 }
duke@1 2205 }
duke@1 2206 }
duke@1 2207 }
duke@1 2208 }
duke@1 2209 }
duke@1 2210
duke@1 2211 /** Check that all abstract methods implemented by a class are
duke@1 2212 * mutually compatible.
duke@1 2213 * @param pos Position to be used for error reporting.
duke@1 2214 * @param c The class whose interfaces are checked.
duke@1 2215 */
duke@1 2216 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2217 List<Type> supertypes = types.interfaces(c);
duke@1 2218 Type supertype = types.supertype(c);
duke@1 2219 if (supertype.tag == CLASS &&
duke@1 2220 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2221 supertypes = supertypes.prepend(supertype);
duke@1 2222 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2223 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2224 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2225 return;
duke@1 2226 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2227 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2228 return;
duke@1 2229 }
duke@1 2230 checkCompatibleConcretes(pos, c);
duke@1 2231 }
duke@1 2232
mcimadamore@359 2233 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2234 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2235 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2236 // VM allows methods and variables with differing types
mcimadamore@359 2237 if (sym.kind == e.sym.kind &&
mcimadamore@359 2238 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2239 sym != e.sym &&
mcimadamore@359 2240 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2241 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2242 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2243 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2244 return;
mcimadamore@359 2245 }
mcimadamore@359 2246 }
mcimadamore@359 2247 }
mcimadamore@359 2248 }
mcimadamore@359 2249
mcimadamore@780 2250 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2251 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2252 *
mcimadamore@780 2253 * @param pos Position to be used for error reporting.
mcimadamore@780 2254 * @param site The class whose methods are checked.
mcimadamore@780 2255 * @param sym The method symbol to be checked.
mcimadamore@780 2256 */
mcimadamore@858 2257 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2258 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2259 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2260 //by method 'sym' in 'site'...
mcimadamore@1198 2261 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2262 if (!sym.overrides(m1, site.tsym, types, false)) continue;
mcimadamore@1198 2263 //...check each method m2 that is a member of 'site'
mcimadamore@1198 2264 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2265 if (m2 == m1) continue;
mcimadamore@858 2266 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2267 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1198 2268 if (!types.isSubSignature(sym.type, types.memberType(site, m2), false) &&
mcimadamore@1198 2269 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2270 sym.flags_field |= CLASH;
mcimadamore@1198 2271 String key = m1 == sym ?
mcimadamore@858 2272 "name.clash.same.erasure.no.override" :
mcimadamore@858 2273 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2274 log.error(pos,
mcimadamore@858 2275 key,
mcimadamore@858 2276 sym, sym.location(),
mcimadamore@1198 2277 m2, m2.location(),
mcimadamore@1198 2278 m1, m1.location());
mcimadamore@858 2279 return;
mcimadamore@858 2280 }
mcimadamore@780 2281 }
mcimadamore@780 2282 }
mcimadamore@780 2283 }
mcimadamore@780 2284
mcimadamore@877 2285
mcimadamore@877 2286
mcimadamore@858 2287 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2288 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2289 *
mcimadamore@858 2290 * @param pos Position to be used for error reporting.
mcimadamore@858 2291 * @param site The class whose methods are checked.
mcimadamore@858 2292 * @param sym The method symbol to be checked.
mcimadamore@780 2293 */
mcimadamore@858 2294 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2295 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2296 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2297 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2298 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2299 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@907 2300 if (!types.isSubSignature(sym.type, types.memberType(site, s), false) &&
mcimadamore@877 2301 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2302 log.error(pos,
mcimadamore@858 2303 "name.clash.same.erasure.no.hide",
mcimadamore@858 2304 sym, sym.location(),
mcimadamore@877 2305 s, s.location());
mcimadamore@858 2306 return;
mcimadamore@858 2307 }
mcimadamore@858 2308 }
mcimadamore@858 2309 }
mcimadamore@780 2310
mcimadamore@858 2311 //where
mcimadamore@858 2312 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2313
mcimadamore@858 2314 Type site;
mcimadamore@780 2315
mcimadamore@858 2316 ClashFilter(Type site) {
mcimadamore@858 2317 this.site = site;
mcimadamore@858 2318 }
mcimadamore@858 2319
mcimadamore@858 2320 boolean shouldSkip(Symbol s) {
mcimadamore@858 2321 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2322 s.owner == site.tsym;
mcimadamore@858 2323 }
mcimadamore@858 2324
mcimadamore@858 2325 public boolean accepts(Symbol s) {
mcimadamore@858 2326 return s.kind == MTH &&
mcimadamore@858 2327 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2328 !shouldSkip(s) &&
mcimadamore@858 2329 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2330 !s.isConstructor();
mcimadamore@858 2331 }
mcimadamore@858 2332 }
mcimadamore@780 2333
mcimadamore@359 2334 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2335 */
mcimadamore@359 2336 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2337 if (!sym.type.isErroneous()) {
mcimadamore@359 2338 if (warnOnSyntheticConflicts) {
mcimadamore@359 2339 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2340 }
mcimadamore@359 2341 else {
mcimadamore@359 2342 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2343 }
mcimadamore@359 2344 }
mcimadamore@359 2345 }
mcimadamore@359 2346
duke@1 2347 /** Check that class c does not implement directly or indirectly
duke@1 2348 * the same parameterized interface with two different argument lists.
duke@1 2349 * @param pos Position to be used for error reporting.
duke@1 2350 * @param type The type whose interfaces are checked.
duke@1 2351 */
duke@1 2352 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2353 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2354 }
duke@1 2355 //where
duke@1 2356 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2357 * with their class symbol as key and their type as value. Make
duke@1 2358 * sure no class is entered with two different types.
duke@1 2359 */
duke@1 2360 void checkClassBounds(DiagnosticPosition pos,
duke@1 2361 Map<TypeSymbol,Type> seensofar,
duke@1 2362 Type type) {
duke@1 2363 if (type.isErroneous()) return;
duke@1 2364 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2365 Type it = l.head;
duke@1 2366 Type oldit = seensofar.put(it.tsym, it);
duke@1 2367 if (oldit != null) {
duke@1 2368 List<Type> oldparams = oldit.allparams();
duke@1 2369 List<Type> newparams = it.allparams();
duke@1 2370 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2371 log.error(pos, "cant.inherit.diff.arg",
duke@1 2372 it.tsym, Type.toString(oldparams),
duke@1 2373 Type.toString(newparams));
duke@1 2374 }
duke@1 2375 checkClassBounds(pos, seensofar, it);
duke@1 2376 }
duke@1 2377 Type st = types.supertype(type);
duke@1 2378 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2379 }
duke@1 2380
duke@1 2381 /** Enter interface into into set.
duke@1 2382 * If it existed already, issue a "repeated interface" error.
duke@1 2383 */
duke@1 2384 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2385 if (its.contains(it))
duke@1 2386 log.error(pos, "repeated.interface");
duke@1 2387 else {
duke@1 2388 its.add(it);
duke@1 2389 }
duke@1 2390 }
duke@1 2391
duke@1 2392 /* *************************************************************************
duke@1 2393 * Check annotations
duke@1 2394 **************************************************************************/
duke@1 2395
mcimadamore@629 2396 /**
mcimadamore@634 2397 * Recursively validate annotations values
mcimadamore@629 2398 */
mcimadamore@634 2399 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2400 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2401 @Override
mcimadamore@629 2402 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2403 if (!tree.type.isErroneous()) {
jjg@1017 2404 super.visitAnnotation(tree);
jjg@1017 2405 validateAnnotation(tree);
jjg@1017 2406 }
mcimadamore@629 2407 }
mcimadamore@629 2408 }
mcimadamore@634 2409 tree.accept(new AnnotationValidator());
mcimadamore@629 2410 }
mcimadamore@629 2411
jjg@1326 2412 /**
jjg@1326 2413 * {@literal
jjg@1326 2414 * Annotation types are restricted to primitives, String, an
duke@1 2415 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2416 * Anything>, arrays of the preceding.
jjg@1326 2417 * }
duke@1 2418 */
duke@1 2419 void validateAnnotationType(JCTree restype) {
duke@1 2420 // restype may be null if an error occurred, so don't bother validating it
duke@1 2421 if (restype != null) {
duke@1 2422 validateAnnotationType(restype.pos(), restype.type);
duke@1 2423 }
duke@1 2424 }
duke@1 2425
duke@1 2426 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2427 if (type.isPrimitive()) return;
duke@1 2428 if (types.isSameType(type, syms.stringType)) return;
duke@1 2429 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2430 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2431 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2432 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2433 validateAnnotationType(pos, types.elemtype(type));
duke@1 2434 return;
duke@1 2435 }
duke@1 2436 log.error(pos, "invalid.annotation.member.type");
duke@1 2437 }
duke@1 2438
duke@1 2439 /**
duke@1 2440 * "It is also a compile-time error if any method declared in an
duke@1 2441 * annotation type has a signature that is override-equivalent to
duke@1 2442 * that of any public or protected method declared in class Object
duke@1 2443 * or in the interface annotation.Annotation."
duke@1 2444 *
jjh@972 2445 * @jls 9.6 Annotation Types
duke@1 2446 */
duke@1 2447 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
duke@1 2448 for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
duke@1 2449 Scope s = sup.tsym.members();
duke@1 2450 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2451 if (e.sym.kind == MTH &&
duke@1 2452 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2453 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2454 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2455 }
duke@1 2456 }
duke@1 2457 }
duke@1 2458
duke@1 2459 /** Check the annotations of a symbol.
duke@1 2460 */
duke@1 2461 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2462 for (JCAnnotation a : annotations)
duke@1 2463 validateAnnotation(a, s);
duke@1 2464 }
duke@1 2465
duke@1 2466 /** Check an annotation of a symbol.
duke@1 2467 */
jfranck@1313 2468 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2469 validateAnnotationTree(a);
duke@1 2470
duke@1 2471 if (!annotationApplicable(a, s))
duke@1 2472 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2473
duke@1 2474 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2475 if (!isOverrider(s))
duke@1 2476 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2477 }
duke@1 2478 }
duke@1 2479
jfranck@1313 2480 /**
jfranck@1313 2481 * Validate the proposed container 'containedBy' on the
jfranck@1313 2482 * annotation type symbol 's'. Report errors at position
jfranck@1313 2483 * 'pos'.
jfranck@1313 2484 *
jfranck@1313 2485 * @param s The (annotation)type declaration annotated with a @ContainedBy
jfranck@1313 2486 * @param containerAnno the @ContainedBy on 's'
jfranck@1313 2487 * @param pos where to report errors
jfranck@1313 2488 */
jfranck@1313 2489 public void validateContainedBy(TypeSymbol s, Attribute.Compound containedBy, DiagnosticPosition pos) {
jfranck@1313 2490 Assert.check(types.isSameType(containedBy.type, syms.containedByType));
jfranck@1313 2491
jfranck@1313 2492 Type t = null;
jfranck@1313 2493 List<Pair<MethodSymbol,Attribute>> l = containedBy.values;
jfranck@1313 2494 if (!l.isEmpty()) {
jfranck@1313 2495 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2496 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2497 }
jfranck@1313 2498
jfranck@1313 2499 if (t == null) {
jfranck@1313 2500 log.error(pos, "invalid.container.wrong.containedby", s, containedBy);
jfranck@1313 2501 return;
jfranck@1313 2502 }
jfranck@1313 2503
jfranck@1313 2504 validateHasContainerFor(t.tsym, s, pos);
jfranck@1313 2505 validateRetention(t.tsym, s, pos);
jfranck@1313 2506 validateDocumented(t.tsym, s, pos);
jfranck@1313 2507 validateInherited(t.tsym, s, pos);
jfranck@1313 2508 validateTarget(t.tsym, s, pos);
jfranck@1344 2509 validateDefault(t.tsym, s, pos);
jfranck@1313 2510 }
jfranck@1313 2511
jfranck@1313 2512 /**
jfranck@1313 2513 * Validate the proposed container 'containerFor' on the
jfranck@1313 2514 * annotation type symbol 's'. Report errors at position
jfranck@1313 2515 * 'pos'.
jfranck@1313 2516 *
jfranck@1313 2517 * @param s The (annotation)type declaration annotated with a @ContainerFor
jfranck@1313 2518 * @param containerFor the @ContainedFor on 's'
jfranck@1313 2519 * @param pos where to report errors
jfranck@1313 2520 */
jfranck@1313 2521 public void validateContainerFor(TypeSymbol s, Attribute.Compound containerFor, DiagnosticPosition pos) {
jfranck@1313 2522 Assert.check(types.isSameType(containerFor.type, syms.containerForType));
jfranck@1313 2523
jfranck@1313 2524 Type t = null;
jfranck@1313 2525 List<Pair<MethodSymbol,Attribute>> l = containerFor.values;
jfranck@1313 2526 if (!l.isEmpty()) {
jfranck@1313 2527 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2528 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2529 }
jfranck@1313 2530
jfranck@1313 2531 if (t == null) {
jfranck@1313 2532 log.error(pos, "invalid.container.wrong.containerfor", s, containerFor);
jfranck@1313 2533 return;
jfranck@1313 2534 }
jfranck@1313 2535
jfranck@1313 2536 validateHasContainedBy(t.tsym, s, pos);
jfranck@1313 2537 }
jfranck@1313 2538
jfranck@1313 2539 private void validateHasContainedBy(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jfranck@1313 2540 Attribute.Compound containedBy = container.attribute(syms.containedByType.tsym);
jfranck@1313 2541
jfranck@1313 2542 if (containedBy == null) {
jfranck@1313 2543 log.error(pos, "invalid.container.no.containedby", container, syms.containedByType.tsym);
jfranck@1313 2544 return;
jfranck@1313 2545 }
jfranck@1313 2546
jfranck@1313 2547 Type t = null;
jfranck@1313 2548 List<Pair<MethodSymbol,Attribute>> l = containedBy.values;
jfranck@1313 2549 if (!l.isEmpty()) {
jfranck@1313 2550 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2551 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2552 }
jfranck@1313 2553
jfranck@1313 2554 if (t == null) {
jfranck@1313 2555 log.error(pos, "invalid.container.wrong.containedby", container, contained);
jfranck@1313 2556 return;
jfranck@1313 2557 }
jfranck@1313 2558
jfranck@1313 2559 if (!types.isSameType(t, contained.type))
jfranck@1313 2560 log.error(pos, "invalid.container.wrong.containedby", t.tsym, contained);
jfranck@1313 2561 }
jfranck@1313 2562
jfranck@1313 2563 private void validateHasContainerFor(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jfranck@1313 2564 Attribute.Compound containerFor = container.attribute(syms.containerForType.tsym);
jfranck@1313 2565
jfranck@1313 2566 if (containerFor == null) {
jfranck@1313 2567 log.error(pos, "invalid.container.no.containerfor", container, syms.containerForType.tsym);
jfranck@1313 2568 return;
jfranck@1313 2569 }
jfranck@1313 2570
jfranck@1313 2571 Type t = null;
jfranck@1313 2572 List<Pair<MethodSymbol,Attribute>> l = containerFor.values;
jfranck@1313 2573 if (!l.isEmpty()) {
jfranck@1313 2574 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2575 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2576 }
jfranck@1313 2577
jfranck@1313 2578 if (t == null) {
jfranck@1313 2579 log.error(pos, "invalid.container.wrong.containerfor", container, contained);
jfranck@1313 2580 return;
jfranck@1313 2581 }
jfranck@1313 2582
jfranck@1313 2583 if (!types.isSameType(t, contained.type))
jfranck@1313 2584 log.error(pos, "invalid.container.wrong.containerfor", t.tsym, contained);
jfranck@1313 2585 }
jfranck@1313 2586
jfranck@1313 2587 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2588 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2589 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2590
jfranck@1313 2591 boolean error = false;
jfranck@1313 2592 switch (containedRetention) {
jfranck@1313 2593 case RUNTIME:
jfranck@1313 2594 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2595 error = true;
jfranck@1313 2596 }
jfranck@1313 2597 break;
jfranck@1313 2598 case CLASS:
jfranck@1313 2599 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2600 error = true;
jfranck@1313 2601 }
jfranck@1313 2602 }
jfranck@1313 2603 if (error ) {
jfranck@1313 2604 log.error(pos, "invalid.containedby.annotation.retention",
jfranck@1313 2605 container, containerRetention,
jfranck@1313 2606 contained, containedRetention);
jfranck@1313 2607 }
jfranck@1313 2608 }
jfranck@1313 2609
jfranck@1313 2610 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2611 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2612 if (container.attribute(syms.documentedType.tsym) == null) {
jfranck@1313 2613 log.error(pos, "invalid.containedby.annotation.not.documented", container, contained);
jfranck@1313 2614 }
jfranck@1313 2615 }
jfranck@1313 2616 }
jfranck@1313 2617
jfranck@1313 2618 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2619 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2620 if (container.attribute(syms.inheritedType.tsym) == null) {
jfranck@1313 2621 log.error(pos, "invalid.containedby.annotation.not.inherited", container, contained);
jfranck@1313 2622 }
jfranck@1313 2623 }
jfranck@1313 2624 }
jfranck@1313 2625
jfranck@1313 2626 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2627 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1313 2628
jfranck@1313 2629 // If contained has no Target, we are done
jfranck@1313 2630 if (containedTarget == null) {
jfranck@1313 2631 return;
jfranck@1313 2632 }
jfranck@1313 2633
jfranck@1313 2634 // If contained has Target m1, container must have a Target
jfranck@1313 2635 // annotation, m2, and m2 must be a subset of m1. (This is
jfranck@1313 2636 // trivially true if contained has no target as per above).
jfranck@1313 2637
jfranck@1313 2638 // contained has target, but container has not, error
jfranck@1313 2639 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2640 if (containerTarget == null) {
jfranck@1313 2641 log.error(pos, "invalid.containedby.annotation.incompatible.target", container, contained);
jfranck@1313 2642 return;
jfranck@1313 2643 }
jfranck@1313 2644
jfranck@1313 2645 Set<Name> containerTargets = new HashSet<Name>();
jfranck@1313 2646 for (Attribute app : containerTarget.values) {
jfranck@1313 2647 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2648 continue; // recovery
jfranck@1313 2649 }
jfranck@1313 2650 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2651 containerTargets.add(e.value.name);
jfranck@1313 2652 }
jfranck@1313 2653
jfranck@1313 2654 Set<Name> containedTargets = new HashSet<Name>();
jfranck@1313 2655 for (Attribute app : containedTarget.values) {
jfranck@1313 2656 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2657 continue; // recovery
jfranck@1313 2658 }
jfranck@1313 2659 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2660 containedTargets.add(e.value.name);
jfranck@1313 2661 }
jfranck@1313 2662
jfranck@1313 2663 if (!isTargetSubset(containedTargets, containerTargets)) {
jfranck@1313 2664 log.error(pos, "invalid.containedby.annotation.incompatible.target", container, contained);
jfranck@1313 2665 }
jfranck@1313 2666 }
jfranck@1313 2667
jfranck@1313 2668 /** Checks that t is a subset of s, with respect to ElementType
jfranck@1313 2669 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE}
jfranck@1313 2670 */
jfranck@1313 2671 private boolean isTargetSubset(Set<Name> s, Set<Name> t) {
jfranck@1313 2672 // Check that all elements in t are present in s
jfranck@1313 2673 for (Name n2 : t) {
jfranck@1313 2674 boolean currentElementOk = false;
jfranck@1313 2675 for (Name n1 : s) {
jfranck@1313 2676 if (n1 == n2) {
jfranck@1313 2677 currentElementOk = true;
jfranck@1313 2678 break;
jfranck@1313 2679 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2680 currentElementOk = true;
jfranck@1313 2681 break;
jfranck@1313 2682 }
jfranck@1313 2683 }
jfranck@1313 2684 if (!currentElementOk)
jfranck@1313 2685 return false;
jfranck@1313 2686 }
jfranck@1313 2687 return true;
jfranck@1313 2688 }
jfranck@1313 2689
jfranck@1344 2690 private void validateDefault(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1344 2691 // validate that all other elements of containing type has defaults
jfranck@1344 2692 Scope scope = container.members();
jfranck@1344 2693 for(Symbol elm : scope.getElements()) {
jfranck@1344 2694 if (elm.name != names.value &&
jfranck@1344 2695 elm.kind == Kinds.MTH &&
jfranck@1344 2696 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2697 log.error(pos,
jfranck@1344 2698 "invalid.containedby.annotation.elem.nondefault",
jfranck@1344 2699 container,
jfranck@1344 2700 elm);
jfranck@1344 2701 }
jfranck@1344 2702 }
jfranck@1344 2703 }
jfranck@1344 2704
duke@1 2705 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2706 boolean isOverrider(Symbol s) {
duke@1 2707 if (s.kind != MTH || s.isStatic())
duke@1 2708 return false;
duke@1 2709 MethodSymbol m = (MethodSymbol)s;
duke@1 2710 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2711 for (Type sup : types.closure(owner.type)) {
duke@1 2712 if (sup == owner.type)
duke@1 2713 continue; // skip "this"
duke@1 2714 Scope scope = sup.tsym.members();
duke@1 2715 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2716 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2717 return true;
duke@1 2718 }
duke@1 2719 }
duke@1 2720 return false;
duke@1 2721 }
duke@1 2722
duke@1 2723 /** Is the annotation applicable to the symbol? */
duke@1 2724 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 2725 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jfranck@1313 2726 if (arr == null) {
jfranck@1313 2727 return true;
jfranck@1313 2728 }
duke@1 2729 for (Attribute app : arr.values) {
duke@1 2730 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2731 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2732 if (e.value.name == names.TYPE)
duke@1 2733 { if (s.kind == TYP) return true; }
duke@1 2734 else if (e.value.name == names.FIELD)
duke@1 2735 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2736 else if (e.value.name == names.METHOD)
duke@1 2737 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2738 else if (e.value.name == names.PARAMETER)
duke@1 2739 { if (s.kind == VAR &&
duke@1 2740 s.owner.kind == MTH &&
duke@1 2741 (s.flags() & PARAMETER) != 0)
duke@1 2742 return true;
duke@1 2743 }
duke@1 2744 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2745 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2746 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2747 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2748 (s.flags() & PARAMETER) == 0)
duke@1 2749 return true;
duke@1 2750 }
duke@1 2751 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2752 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2753 return true;
duke@1 2754 }
duke@1 2755 else if (e.value.name == names.PACKAGE)
duke@1 2756 { if (s.kind == PCK) return true; }
jjg@308 2757 else if (e.value.name == names.TYPE_USE)
jjg@308 2758 { if (s.kind == TYP ||
jjg@308 2759 s.kind == VAR ||
jjg@308 2760 (s.kind == MTH && !s.isConstructor() &&
jjg@308 2761 s.type.getReturnType().tag != VOID))
jjg@308 2762 return true;
jjg@308 2763 }
duke@1 2764 else
duke@1 2765 return true; // recovery
duke@1 2766 }
duke@1 2767 return false;
duke@1 2768 }
duke@1 2769
jfranck@1313 2770
jfranck@1313 2771 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 2772 Attribute.Compound atTarget =
jfranck@1313 2773 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 2774 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 2775 Attribute atValue = atTarget.member(names.value);
jfranck@1313 2776 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 2777 return (Attribute.Array) atValue;
jfranck@1313 2778 }
jfranck@1313 2779
duke@1 2780 /** Check an annotation value.
duke@1 2781 */
duke@1 2782 public void validateAnnotation(JCAnnotation a) {
mcimadamore@632 2783 // collect an inventory of the members (sorted alphabetically)
mcimadamore@632 2784 Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
mcimadamore@632 2785 public int compare(Symbol t, Symbol t1) {
mcimadamore@632 2786 return t.name.compareTo(t1.name);
mcimadamore@632 2787 }
mcimadamore@632 2788 });
duke@1 2789 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2790 e != null;
duke@1 2791 e = e.sibling)
duke@1 2792 if (e.sym.kind == MTH)
duke@1 2793 members.add((MethodSymbol) e.sym);
duke@1 2794
duke@1 2795 // count them off as they're annotated
duke@1 2796 for (JCTree arg : a.args) {
jjg@1127 2797 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 2798 JCAssign assign = (JCAssign) arg;
duke@1 2799 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2800 if (m == null || m.type.isErroneous()) continue;
duke@1 2801 if (!members.remove(m))
jjg@479 2802 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2803 m.name, a.type);
duke@1 2804 }
duke@1 2805
duke@1 2806 // all the remaining ones better have default values
mcimadamore@632 2807 ListBuffer<Name> missingDefaults = ListBuffer.lb();
mcimadamore@632 2808 for (MethodSymbol m : members) {
mcimadamore@632 2809 if (m.defaultValue == null && !m.type.isErroneous()) {
mcimadamore@632 2810 missingDefaults.append(m.name);
mcimadamore@632 2811 }
mcimadamore@632 2812 }
mcimadamore@632 2813 if (missingDefaults.nonEmpty()) {
mcimadamore@632 2814 String key = (missingDefaults.size() > 1)
mcimadamore@632 2815 ? "annotation.missing.default.value.1"
mcimadamore@632 2816 : "annotation.missing.default.value";
mcimadamore@632 2817 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 2818 }
duke@1 2819
duke@1 2820 // special case: java.lang.annotation.Target must not have
duke@1 2821 // repeated values in its value member
duke@1 2822 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2823 a.args.tail == null)
duke@1 2824 return;
duke@1 2825
jjg@1127 2826 if (!a.args.head.hasTag(ASSIGN)) return; // error recovery
duke@1 2827 JCAssign assign = (JCAssign) a.args.head;
duke@1 2828 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2829 if (m.name != names.value) return;
duke@1 2830 JCTree rhs = assign.rhs;
jjg@1127 2831 if (!rhs.hasTag(NEWARRAY)) return;
duke@1 2832 JCNewArray na = (JCNewArray) rhs;
duke@1 2833 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2834 for (JCTree elem : na.elems) {
duke@1 2835 if (!targets.add(TreeInfo.symbol(elem))) {
duke@1 2836 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2837 }
duke@1 2838 }
duke@1 2839 }
duke@1 2840
duke@1 2841 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 2842 if (allowAnnotations &&
mcimadamore@795 2843 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 2844 (s.flags() & DEPRECATED) != 0 &&
duke@1 2845 !syms.deprecatedType.isErroneous() &&
duke@1 2846 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 2847 log.warning(LintCategory.DEP_ANN,
jjg@612 2848 pos, "missing.deprecated.annotation");
duke@1 2849 }
duke@1 2850 }
duke@1 2851
mcimadamore@852 2852 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 2853 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 2854 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 2855 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 2856 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2857 @Override
mcimadamore@852 2858 public void report() {
mcimadamore@852 2859 warnDeprecated(pos, s);
mcimadamore@852 2860 }
mcimadamore@852 2861 });
jjg@1157 2862 }
mcimadamore@852 2863 }
mcimadamore@852 2864
mcimadamore@852 2865 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 2866 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 2867 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2868 public void report() {
mcimadamore@852 2869 if (enableSunApiLintControl)
mcimadamore@852 2870 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 2871 else
mcimadamore@1218 2872 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 2873 }
mcimadamore@852 2874 });
mcimadamore@852 2875 }
mcimadamore@852 2876 }
mcimadamore@852 2877
duke@1 2878 /* *************************************************************************
duke@1 2879 * Check for recursive annotation elements.
duke@1 2880 **************************************************************************/
duke@1 2881
duke@1 2882 /** Check for cycles in the graph of annotation elements.
duke@1 2883 */
duke@1 2884 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 2885 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 2886 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 2887 try {
duke@1 2888 tree.sym.flags_field |= LOCKED;
duke@1 2889 for (JCTree def : tree.defs) {
jjg@1127 2890 if (!def.hasTag(METHODDEF)) continue;
duke@1 2891 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 2892 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 2893 }
duke@1 2894 } finally {
duke@1 2895 tree.sym.flags_field &= ~LOCKED;
duke@1 2896 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 2897 }
duke@1 2898 }
duke@1 2899
duke@1 2900 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 2901 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 2902 return;
duke@1 2903 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 2904 log.error(pos, "cyclic.annotation.element");
duke@1 2905 return;
duke@1 2906 }
duke@1 2907 try {
duke@1 2908 tsym.flags_field |= LOCKED;
duke@1 2909 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 2910 Symbol s = e.sym;
duke@1 2911 if (s.kind != Kinds.MTH)
duke@1 2912 continue;
duke@1 2913 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 2914 }
duke@1 2915 } finally {
duke@1 2916 tsym.flags_field &= ~LOCKED;
duke@1 2917 tsym.flags_field |= ACYCLIC_ANN;
duke@1 2918 }
duke@1 2919 }
duke@1 2920
duke@1 2921 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
duke@1 2922 switch (type.tag) {
duke@1 2923 case TypeTags.CLASS:
duke@1 2924 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 2925 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 2926 break;
duke@1 2927 case TypeTags.ARRAY:
duke@1 2928 checkAnnotationResType(pos, types.elemtype(type));
duke@1 2929 break;
duke@1 2930 default:
duke@1 2931 break; // int etc
duke@1 2932 }
duke@1 2933 }
duke@1 2934
duke@1 2935 /* *************************************************************************
duke@1 2936 * Check for cycles in the constructor call graph.
duke@1 2937 **************************************************************************/
duke@1 2938
duke@1 2939 /** Check for cycles in the graph of constructors calling other
duke@1 2940 * constructors.
duke@1 2941 */
duke@1 2942 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 2943 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 2944
duke@1 2945 // enter each constructor this-call into the map
duke@1 2946 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 2947 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 2948 if (app == null) continue;
duke@1 2949 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 2950 if (TreeInfo.name(app.meth) == names._this) {
duke@1 2951 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 2952 } else {
duke@1 2953 meth.sym.flags_field |= ACYCLIC;
duke@1 2954 }
duke@1 2955 }
duke@1 2956
duke@1 2957 // Check for cycles in the map
duke@1 2958 Symbol[] ctors = new Symbol[0];
duke@1 2959 ctors = callMap.keySet().toArray(ctors);
duke@1 2960 for (Symbol caller : ctors) {
duke@1 2961 checkCyclicConstructor(tree, caller, callMap);
duke@1 2962 }
duke@1 2963 }
duke@1 2964
duke@1 2965 /** Look in the map to see if the given constructor is part of a
duke@1 2966 * call cycle.
duke@1 2967 */
duke@1 2968 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 2969 Map<Symbol,Symbol> callMap) {
duke@1 2970 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 2971 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 2972 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 2973 "recursive.ctor.invocation");
duke@1 2974 } else {
duke@1 2975 ctor.flags_field |= LOCKED;
duke@1 2976 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 2977 ctor.flags_field &= ~LOCKED;
duke@1 2978 }
duke@1 2979 ctor.flags_field |= ACYCLIC;
duke@1 2980 }
duke@1 2981 }
duke@1 2982
duke@1 2983 /* *************************************************************************
duke@1 2984 * Miscellaneous
duke@1 2985 **************************************************************************/
duke@1 2986
duke@1 2987 /**
duke@1 2988 * Return the opcode of the operator but emit an error if it is an
duke@1 2989 * error.
duke@1 2990 * @param pos position for error reporting.
duke@1 2991 * @param operator an operator
duke@1 2992 * @param tag a tree tag
duke@1 2993 * @param left type of left hand side
duke@1 2994 * @param right type of right hand side
duke@1 2995 */
duke@1 2996 int checkOperator(DiagnosticPosition pos,
duke@1 2997 OperatorSymbol operator,
jjg@1127 2998 JCTree.Tag tag,
duke@1 2999 Type left,
duke@1 3000 Type right) {
duke@1 3001 if (operator.opcode == ByteCodes.error) {
duke@1 3002 log.error(pos,
mcimadamore@853 3003 "operator.cant.be.applied.1",
duke@1 3004 treeinfo.operatorName(tag),
mcimadamore@853 3005 left, right);
duke@1 3006 }
duke@1 3007 return operator.opcode;
duke@1 3008 }
duke@1 3009
duke@1 3010
duke@1 3011 /**
duke@1 3012 * Check for division by integer constant zero
duke@1 3013 * @param pos Position for error reporting.
duke@1 3014 * @param operator The operator for the expression
duke@1 3015 * @param operand The right hand operand for the expression
duke@1 3016 */
duke@1 3017 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3018 if (operand.constValue() != null
mcimadamore@795 3019 && lint.isEnabled(LintCategory.DIVZERO)
duke@1 3020 && operand.tag <= LONG
duke@1 3021 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3022 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3023 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3024 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3025 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3026 }
duke@1 3027 }
duke@1 3028 }
duke@1 3029
duke@1 3030 /**
duke@1 3031 * Check for empty statements after if
duke@1 3032 */
duke@1 3033 void checkEmptyIf(JCIf tree) {
jjg@1127 3034 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3035 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3036 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3037 }
duke@1 3038
duke@1 3039 /** Check that symbol is unique in given scope.
duke@1 3040 * @param pos Position for error reporting.
duke@1 3041 * @param sym The symbol.
duke@1 3042 * @param s The scope.
duke@1 3043 */
duke@1 3044 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3045 if (sym.type.isErroneous())
duke@1 3046 return true;
duke@1 3047 if (sym.owner.name == names.any) return false;
duke@1 3048 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3049 if (sym != e.sym &&
mcimadamore@858 3050 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3051 sym.kind == e.sym.kind &&
mcimadamore@858 3052 sym.name != names.error &&
mcimadamore@858 3053 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3054 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3055 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3056 return true;
mcimadamore@907 3057 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3058 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3059 sym.flags_field |= CLASH;
mcimadamore@844 3060 return true;
mcimadamore@844 3061 } else {
duke@1 3062 duplicateError(pos, e.sym);
mcimadamore@844 3063 return false;
mcimadamore@844 3064 }
duke@1 3065 }
duke@1 3066 }
duke@1 3067 return true;
duke@1 3068 }
mcimadamore@844 3069
mcimadamore@858 3070 /** Report duplicate declaration error.
mcimadamore@858 3071 */
mcimadamore@858 3072 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3073 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3074 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3075 }
mcimadamore@858 3076 }
duke@1 3077
duke@1 3078 /** Check that single-type import is not already imported or top-level defined,
duke@1 3079 * but make an exception for two single-type imports which denote the same type.
duke@1 3080 * @param pos Position for error reporting.
duke@1 3081 * @param sym The symbol.
duke@1 3082 * @param s The scope
duke@1 3083 */
duke@1 3084 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3085 return checkUniqueImport(pos, sym, s, false);
duke@1 3086 }
duke@1 3087
duke@1 3088 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3089 * but make an exception for two single-type imports which denote the same type.
duke@1 3090 * @param pos Position for error reporting.
duke@1 3091 * @param sym The symbol.
duke@1 3092 * @param s The scope
duke@1 3093 * @param staticImport Whether or not this was a static import
duke@1 3094 */
duke@1 3095 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3096 return checkUniqueImport(pos, sym, s, true);
duke@1 3097 }
duke@1 3098
duke@1 3099 /** Check that single-type import is not already imported or top-level defined,
duke@1 3100 * but make an exception for two single-type imports which denote the same type.
duke@1 3101 * @param pos Position for error reporting.
duke@1 3102 * @param sym The symbol.
duke@1 3103 * @param s The scope.
duke@1 3104 * @param staticImport Whether or not this was a static import
duke@1 3105 */
duke@1 3106 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3107 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3108 // is encountered class entered via a class declaration?
duke@1 3109 boolean isClassDecl = e.scope == s;
duke@1 3110 if ((isClassDecl || sym != e.sym) &&
duke@1 3111 sym.kind == e.sym.kind &&
duke@1 3112 sym.name != names.error) {
duke@1 3113 if (!e.sym.type.isErroneous()) {
duke@1 3114 String what = e.sym.toString();
duke@1 3115 if (!isClassDecl) {
duke@1 3116 if (staticImport)
duke@1 3117 log.error(pos, "already.defined.static.single.import", what);
duke@1 3118 else
duke@1 3119 log.error(pos, "already.defined.single.import", what);
duke@1 3120 }
duke@1 3121 else if (sym != e.sym)
duke@1 3122 log.error(pos, "already.defined.this.unit", what);
duke@1 3123 }
duke@1 3124 return false;
duke@1 3125 }
duke@1 3126 }
duke@1 3127 return true;
duke@1 3128 }
duke@1 3129
duke@1 3130 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3131 */
duke@1 3132 public void checkCanonical(JCTree tree) {
duke@1 3133 if (!isCanonical(tree))
duke@1 3134 log.error(tree.pos(), "import.requires.canonical",
duke@1 3135 TreeInfo.symbol(tree));
duke@1 3136 }
duke@1 3137 // where
duke@1 3138 private boolean isCanonical(JCTree tree) {
jjg@1127 3139 while (tree.hasTag(SELECT)) {
duke@1 3140 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3141 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3142 return false;
duke@1 3143 tree = s.selected;
duke@1 3144 }
duke@1 3145 return true;
duke@1 3146 }
duke@1 3147
duke@1 3148 private class ConversionWarner extends Warner {
mcimadamore@795 3149 final String uncheckedKey;
duke@1 3150 final Type found;
duke@1 3151 final Type expected;
mcimadamore@795 3152 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3153 super(pos);
mcimadamore@795 3154 this.uncheckedKey = uncheckedKey;
duke@1 3155 this.found = found;
duke@1 3156 this.expected = expected;
duke@1 3157 }
duke@1 3158
jjg@398 3159 @Override
mcimadamore@795 3160 public void warn(LintCategory lint) {
duke@1 3161 boolean warned = this.warned;
mcimadamore@795 3162 super.warn(lint);
duke@1 3163 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3164 switch (lint) {
mcimadamore@795 3165 case UNCHECKED:
mcimadamore@795 3166 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3167 break;
mcimadamore@795 3168 case VARARGS:
mcimadamore@795 3169 if (method != null &&
mcimadamore@795 3170 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3171 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3172 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3173 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3174 }
mcimadamore@795 3175 break;
mcimadamore@795 3176 default:
mcimadamore@795 3177 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3178 }
duke@1 3179 }
duke@1 3180 }
duke@1 3181
duke@1 3182 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3183 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3184 }
duke@1 3185
duke@1 3186 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3187 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3188 }
duke@1 3189 }

mercurial