src/share/classes/com/sun/tools/javac/comp/Check.java

Thu, 03 Jun 2010 17:14:20 -0700

author
jjg
date
Thu, 03 Jun 2010 17:14:20 -0700
changeset 576
559c9a37d9f6
parent 567
593a59e40bdb
child 580
46cf751559ae
permissions
-rw-r--r--

6955264: add option to suppress Abort in Check.completionError
Reviewed-by: mcimadamore

duke@1 1 /*
ohair@554 2 * Copyright (c) 1999, 2009, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
duke@1 30
duke@1 31 import com.sun.tools.javac.code.*;
duke@1 32 import com.sun.tools.javac.jvm.*;
duke@1 33 import com.sun.tools.javac.tree.*;
duke@1 34 import com.sun.tools.javac.util.*;
duke@1 35 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 36 import com.sun.tools.javac.util.List;
duke@1 37
duke@1 38 import com.sun.tools.javac.tree.JCTree.*;
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
duke@1 43
duke@1 44 import static com.sun.tools.javac.code.Flags.*;
duke@1 45 import static com.sun.tools.javac.code.Kinds.*;
duke@1 46 import static com.sun.tools.javac.code.TypeTags.*;
duke@1 47
duke@1 48 /** Type checking helper class for the attribution phase.
duke@1 49 *
duke@1 50 * <p><b>This is NOT part of any API supported by Sun Microsystems. If
duke@1 51 * you write code that depends on this, you do so at your own risk.
duke@1 52 * This code and its internal interfaces are subject to change or
duke@1 53 * deletion without notice.</b>
duke@1 54 */
duke@1 55 public class Check {
duke@1 56 protected static final Context.Key<Check> checkKey =
duke@1 57 new Context.Key<Check>();
duke@1 58
jjg@113 59 private final Names names;
duke@1 60 private final Log log;
duke@1 61 private final Symtab syms;
duke@1 62 private final Infer infer;
duke@1 63 private final Types types;
mcimadamore@89 64 private final JCDiagnostic.Factory diags;
duke@1 65 private final boolean skipAnnotations;
mcimadamore@359 66 private boolean warnOnSyntheticConflicts;
jjg@576 67 private boolean suppressAbortOnBadClassFile;
duke@1 68 private final TreeInfo treeinfo;
duke@1 69
duke@1 70 // The set of lint options currently in effect. It is initialized
duke@1 71 // from the context, and then is set/reset as needed by Attr as it
duke@1 72 // visits all the various parts of the trees during attribution.
duke@1 73 private Lint lint;
duke@1 74
duke@1 75 public static Check instance(Context context) {
duke@1 76 Check instance = context.get(checkKey);
duke@1 77 if (instance == null)
duke@1 78 instance = new Check(context);
duke@1 79 return instance;
duke@1 80 }
duke@1 81
duke@1 82 protected Check(Context context) {
duke@1 83 context.put(checkKey, this);
duke@1 84
jjg@113 85 names = Names.instance(context);
duke@1 86 log = Log.instance(context);
duke@1 87 syms = Symtab.instance(context);
duke@1 88 infer = Infer.instance(context);
duke@1 89 this.types = Types.instance(context);
mcimadamore@89 90 diags = JCDiagnostic.Factory.instance(context);
duke@1 91 Options options = Options.instance(context);
duke@1 92 lint = Lint.instance(context);
duke@1 93 treeinfo = TreeInfo.instance(context);
duke@1 94
duke@1 95 Source source = Source.instance(context);
duke@1 96 allowGenerics = source.allowGenerics();
duke@1 97 allowAnnotations = source.allowAnnotations();
jjg@398 98 allowCovariantReturns = source.allowCovariantReturns();
duke@1 99 complexInference = options.get("-complexinference") != null;
duke@1 100 skipAnnotations = options.get("skipAnnotations") != null;
mcimadamore@359 101 warnOnSyntheticConflicts = options.get("warnOnSyntheticConflicts") != null;
jjg@576 102 suppressAbortOnBadClassFile = options.get("suppressAbortOnBadClassFile") != null;
duke@1 103
jjg@398 104 Target target = Target.instance(context);
jjg@398 105 syntheticNameChar = target.syntheticNameChar();
jjg@398 106
duke@1 107 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 108 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 109 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 110 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 111
jjg@60 112 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@60 113 enforceMandatoryWarnings, "deprecated");
jjg@60 114 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@60 115 enforceMandatoryWarnings, "unchecked");
jjg@377 116 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@377 117 enforceMandatoryWarnings, "sunapi");
duke@1 118 }
duke@1 119
duke@1 120 /** Switch: generics enabled?
duke@1 121 */
duke@1 122 boolean allowGenerics;
duke@1 123
duke@1 124 /** Switch: annotations enabled?
duke@1 125 */
duke@1 126 boolean allowAnnotations;
duke@1 127
jjg@398 128 /** Switch: covariant returns enabled?
jjg@398 129 */
jjg@398 130 boolean allowCovariantReturns;
jjg@398 131
duke@1 132 /** Switch: -complexinference option set?
duke@1 133 */
duke@1 134 boolean complexInference;
duke@1 135
jjg@398 136 /** Character for synthetic names
jjg@398 137 */
jjg@398 138 char syntheticNameChar;
jjg@398 139
duke@1 140 /** A table mapping flat names of all compiled classes in this run to their
duke@1 141 * symbols; maintained from outside.
duke@1 142 */
duke@1 143 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 144
duke@1 145 /** A handler for messages about deprecated usage.
duke@1 146 */
duke@1 147 private MandatoryWarningHandler deprecationHandler;
duke@1 148
duke@1 149 /** A handler for messages about unchecked or unsafe usage.
duke@1 150 */
duke@1 151 private MandatoryWarningHandler uncheckedHandler;
duke@1 152
jjg@377 153 /** A handler for messages about using Sun proprietary API.
jjg@377 154 */
jjg@377 155 private MandatoryWarningHandler sunApiHandler;
duke@1 156
duke@1 157 /* *************************************************************************
duke@1 158 * Errors and Warnings
duke@1 159 **************************************************************************/
duke@1 160
duke@1 161 Lint setLint(Lint newLint) {
duke@1 162 Lint prev = lint;
duke@1 163 lint = newLint;
duke@1 164 return prev;
duke@1 165 }
duke@1 166
duke@1 167 /** Warn about deprecated symbol.
duke@1 168 * @param pos Position to be used for error reporting.
duke@1 169 * @param sym The deprecated symbol.
duke@1 170 */
duke@1 171 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 172 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 173 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 174 }
duke@1 175
duke@1 176 /** Warn about unchecked operation.
duke@1 177 * @param pos Position to be used for error reporting.
duke@1 178 * @param msg A string describing the problem.
duke@1 179 */
duke@1 180 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 181 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 182 uncheckedHandler.report(pos, msg, args);
duke@1 183 }
duke@1 184
jjg@377 185 /** Warn about using Sun proprietary API.
jjg@377 186 * @param pos Position to be used for error reporting.
jjg@377 187 * @param msg A string describing the problem.
jjg@377 188 */
jjg@377 189 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 190 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 191 sunApiHandler.report(pos, msg, args);
jjg@377 192 }
jjg@377 193
jjg@505 194 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 195 if (lint.isEnabled(LintCategory.STATIC))
jjg@505 196 log.warning(pos, msg, args);
jjg@505 197 }
jjg@505 198
duke@1 199 /**
duke@1 200 * Report any deferred diagnostics.
duke@1 201 */
duke@1 202 public void reportDeferredDiagnostics() {
duke@1 203 deprecationHandler.reportDeferredDiagnostic();
duke@1 204 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 205 sunApiHandler.reportDeferredDiagnostic();
duke@1 206 }
duke@1 207
duke@1 208
duke@1 209 /** Report a failure to complete a class.
duke@1 210 * @param pos Position to be used for error reporting.
duke@1 211 * @param ex The failure to report.
duke@1 212 */
duke@1 213 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 214 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 215 if (ex instanceof ClassReader.BadClassFile
jjg@576 216 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 217 else return syms.errType;
duke@1 218 }
duke@1 219
duke@1 220 /** Report a type error.
duke@1 221 * @param pos Position to be used for error reporting.
duke@1 222 * @param problem A string describing the error.
duke@1 223 * @param found The type that was found.
duke@1 224 * @param req The type that was required.
duke@1 225 */
duke@1 226 Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
duke@1 227 log.error(pos, "prob.found.req",
duke@1 228 problem, found, req);
jjg@110 229 return types.createErrorType(found);
duke@1 230 }
duke@1 231
duke@1 232 Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
duke@1 233 log.error(pos, "prob.found.req.1", problem, found, req, explanation);
jjg@110 234 return types.createErrorType(found);
duke@1 235 }
duke@1 236
duke@1 237 /** Report an error that wrong type tag was found.
duke@1 238 * @param pos Position to be used for error reporting.
duke@1 239 * @param required An internationalized string describing the type tag
duke@1 240 * required.
duke@1 241 * @param found The type that was found.
duke@1 242 */
duke@1 243 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 244 // this error used to be raised by the parser,
jrose@267 245 // but has been delayed to this point:
jrose@267 246 if (found instanceof Type && ((Type)found).tag == VOID) {
jrose@267 247 log.error(pos, "illegal.start.of.type");
jrose@267 248 return syms.errType;
jrose@267 249 }
duke@1 250 log.error(pos, "type.found.req", found, required);
jjg@110 251 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 252 }
duke@1 253
duke@1 254 /** Report an error that symbol cannot be referenced before super
duke@1 255 * has been called.
duke@1 256 * @param pos Position to be used for error reporting.
duke@1 257 * @param sym The referenced symbol.
duke@1 258 */
duke@1 259 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 260 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 261 }
duke@1 262
duke@1 263 /** Report duplicate declaration error.
duke@1 264 */
duke@1 265 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 266 if (!sym.type.isErroneous()) {
duke@1 267 log.error(pos, "already.defined", sym, sym.location());
duke@1 268 }
duke@1 269 }
duke@1 270
duke@1 271 /** Report array/varargs duplicate declaration
duke@1 272 */
duke@1 273 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 274 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 275 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 276 }
duke@1 277 }
duke@1 278
duke@1 279 /* ************************************************************************
duke@1 280 * duplicate declaration checking
duke@1 281 *************************************************************************/
duke@1 282
duke@1 283 /** Check that variable does not hide variable with same name in
duke@1 284 * immediately enclosing local scope.
duke@1 285 * @param pos Position for error reporting.
duke@1 286 * @param v The symbol.
duke@1 287 * @param s The scope.
duke@1 288 */
duke@1 289 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 290 if (s.next != null) {
duke@1 291 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 292 e.scope != null && e.sym.owner == v.owner;
duke@1 293 e = e.next()) {
duke@1 294 if (e.sym.kind == VAR &&
duke@1 295 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 296 v.name != names.error) {
duke@1 297 duplicateError(pos, e.sym);
duke@1 298 return;
duke@1 299 }
duke@1 300 }
duke@1 301 }
duke@1 302 }
duke@1 303
duke@1 304 /** Check that a class or interface does not hide a class or
duke@1 305 * interface with same name in immediately enclosing local scope.
duke@1 306 * @param pos Position for error reporting.
duke@1 307 * @param c The symbol.
duke@1 308 * @param s The scope.
duke@1 309 */
duke@1 310 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 311 if (s.next != null) {
duke@1 312 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 313 e.scope != null && e.sym.owner == c.owner;
duke@1 314 e = e.next()) {
duke@1 315 if (e.sym.kind == TYP &&
duke@1 316 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 317 c.name != names.error) {
duke@1 318 duplicateError(pos, e.sym);
duke@1 319 return;
duke@1 320 }
duke@1 321 }
duke@1 322 }
duke@1 323 }
duke@1 324
duke@1 325 /** Check that class does not have the same name as one of
duke@1 326 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 327 * return true if class is unique in its enclosing scope.
duke@1 328 * @param pos Position for error reporting.
duke@1 329 * @param name The class name.
duke@1 330 * @param s The enclosing scope.
duke@1 331 */
duke@1 332 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 333 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 334 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 335 duplicateError(pos, e.sym);
duke@1 336 return false;
duke@1 337 }
duke@1 338 }
duke@1 339 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 340 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 341 duplicateError(pos, sym);
duke@1 342 return true;
duke@1 343 }
duke@1 344 }
duke@1 345 return true;
duke@1 346 }
duke@1 347
duke@1 348 /* *************************************************************************
duke@1 349 * Class name generation
duke@1 350 **************************************************************************/
duke@1 351
duke@1 352 /** Return name of local class.
duke@1 353 * This is of the form <enclClass> $ n <classname>
duke@1 354 * where
duke@1 355 * enclClass is the flat name of the enclosing class,
duke@1 356 * classname is the simple name of the local class
duke@1 357 */
duke@1 358 Name localClassName(ClassSymbol c) {
duke@1 359 for (int i=1; ; i++) {
duke@1 360 Name flatname = names.
duke@1 361 fromString("" + c.owner.enclClass().flatname +
jjg@398 362 syntheticNameChar + i +
duke@1 363 c.name);
duke@1 364 if (compiled.get(flatname) == null) return flatname;
duke@1 365 }
duke@1 366 }
duke@1 367
duke@1 368 /* *************************************************************************
duke@1 369 * Type Checking
duke@1 370 **************************************************************************/
duke@1 371
duke@1 372 /** Check that a given type is assignable to a given proto-type.
duke@1 373 * If it is, return the type, otherwise return errType.
duke@1 374 * @param pos Position to be used for error reporting.
duke@1 375 * @param found The type that was found.
duke@1 376 * @param req The type that was required.
duke@1 377 */
duke@1 378 Type checkType(DiagnosticPosition pos, Type found, Type req) {
duke@1 379 if (req.tag == ERROR)
duke@1 380 return req;
mcimadamore@536 381 if (found.tag == FORALL)
mcimadamore@536 382 return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req));
duke@1 383 if (req.tag == NONE)
duke@1 384 return found;
duke@1 385 if (types.isAssignable(found, req, convertWarner(pos, found, req)))
duke@1 386 return found;
duke@1 387 if (found.tag <= DOUBLE && req.tag <= DOUBLE)
mcimadamore@89 388 return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req);
duke@1 389 if (found.isSuperBound()) {
duke@1 390 log.error(pos, "assignment.from.super-bound", found);
jjg@110 391 return types.createErrorType(found);
duke@1 392 }
duke@1 393 if (req.isExtendsBound()) {
duke@1 394 log.error(pos, "assignment.to.extends-bound", req);
jjg@110 395 return types.createErrorType(found);
duke@1 396 }
mcimadamore@89 397 return typeError(pos, diags.fragment("incompatible.types"), found, req);
duke@1 398 }
duke@1 399
duke@1 400 /** Instantiate polymorphic type to some prototype, unless
duke@1 401 * prototype is `anyPoly' in which case polymorphic type
duke@1 402 * is returned unchanged.
duke@1 403 */
mcimadamore@383 404 Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException {
duke@1 405 if (pt == Infer.anyPoly && complexInference) {
duke@1 406 return t;
duke@1 407 } else if (pt == Infer.anyPoly || pt.tag == NONE) {
duke@1 408 Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
duke@1 409 return instantiatePoly(pos, t, newpt, warn);
duke@1 410 } else if (pt.tag == ERROR) {
duke@1 411 return pt;
duke@1 412 } else {
mcimadamore@536 413 try {
mcimadamore@536 414 return infer.instantiateExpr(t, pt, warn);
mcimadamore@536 415 } catch (Infer.NoInstanceException ex) {
mcimadamore@536 416 if (ex.isAmbiguous) {
mcimadamore@536 417 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 418 log.error(pos,
mcimadamore@536 419 "undetermined.type" + (d!=null ? ".1" : ""),
mcimadamore@536 420 t, d);
mcimadamore@536 421 return types.createErrorType(pt);
mcimadamore@536 422 } else {
mcimadamore@536 423 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 424 return typeError(pos,
mcimadamore@536 425 diags.fragment("incompatible.types" + (d!=null ? ".1" : ""), d),
mcimadamore@536 426 t, pt);
mcimadamore@536 427 }
mcimadamore@536 428 } catch (Infer.InvalidInstanceException ex) {
mcimadamore@536 429 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 430 log.error(pos, "invalid.inferred.types", t.tvars, d);
mcimadamore@536 431 return types.createErrorType(pt);
mcimadamore@536 432 }
duke@1 433 }
mcimadamore@536 434 }
duke@1 435
duke@1 436 /** Check that a given type can be cast to a given target type.
duke@1 437 * Return the result of the cast.
duke@1 438 * @param pos Position to be used for error reporting.
duke@1 439 * @param found The type that is being cast.
duke@1 440 * @param req The target type of the cast.
duke@1 441 */
duke@1 442 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
duke@1 443 if (found.tag == FORALL) {
duke@1 444 instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
duke@1 445 return req;
duke@1 446 } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 447 return req;
duke@1 448 } else {
duke@1 449 return typeError(pos,
mcimadamore@89 450 diags.fragment("inconvertible.types"),
duke@1 451 found, req);
duke@1 452 }
duke@1 453 }
duke@1 454 //where
duke@1 455 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 456 * type variables?
duke@1 457 */
duke@1 458 boolean isTypeVar(Type t) {
duke@1 459 return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
duke@1 460 }
duke@1 461
duke@1 462 /** Check that a type is within some bounds.
duke@1 463 *
duke@1 464 * Used in TypeApply to verify that, e.g., X in V<X> is a valid
duke@1 465 * type argument.
duke@1 466 * @param pos Position to be used for error reporting.
duke@1 467 * @param a The type that should be bounded by bs.
duke@1 468 * @param bs The bound.
duke@1 469 */
duke@1 470 private void checkExtends(DiagnosticPosition pos, Type a, TypeVar bs) {
mcimadamore@154 471 if (a.isUnbound()) {
mcimadamore@154 472 return;
mcimadamore@154 473 } else if (a.tag != WILDCARD) {
mcimadamore@154 474 a = types.upperBound(a);
mcimadamore@154 475 for (List<Type> l = types.getBounds(bs); l.nonEmpty(); l = l.tail) {
mcimadamore@154 476 if (!types.isSubtype(a, l.head)) {
mcimadamore@154 477 log.error(pos, "not.within.bounds", a);
mcimadamore@154 478 return;
mcimadamore@154 479 }
mcimadamore@154 480 }
mcimadamore@154 481 } else if (a.isExtendsBound()) {
mcimadamore@154 482 if (!types.isCastable(bs.getUpperBound(), types.upperBound(a), Warner.noWarnings))
mcimadamore@154 483 log.error(pos, "not.within.bounds", a);
mcimadamore@154 484 } else if (a.isSuperBound()) {
mcimadamore@154 485 if (types.notSoftSubtype(types.lowerBound(a), bs.getUpperBound()))
mcimadamore@154 486 log.error(pos, "not.within.bounds", a);
mcimadamore@154 487 }
mcimadamore@154 488 }
mcimadamore@154 489
mcimadamore@154 490 /** Check that a type is within some bounds.
mcimadamore@154 491 *
mcimadamore@154 492 * Used in TypeApply to verify that, e.g., X in V<X> is a valid
mcimadamore@154 493 * type argument.
mcimadamore@154 494 * @param pos Position to be used for error reporting.
mcimadamore@154 495 * @param a The type that should be bounded by bs.
mcimadamore@154 496 * @param bs The bound.
mcimadamore@154 497 */
mcimadamore@154 498 private void checkCapture(JCTypeApply tree) {
mcimadamore@154 499 List<JCExpression> args = tree.getTypeArguments();
mcimadamore@154 500 for (Type arg : types.capture(tree.type).getTypeArguments()) {
mcimadamore@154 501 if (arg.tag == TYPEVAR && arg.getUpperBound().isErroneous()) {
mcimadamore@154 502 log.error(args.head.pos, "not.within.bounds", args.head.type);
mcimadamore@154 503 break;
mcimadamore@79 504 }
mcimadamore@154 505 args = args.tail;
mcimadamore@79 506 }
mcimadamore@154 507 }
duke@1 508
duke@1 509 /** Check that type is different from 'void'.
duke@1 510 * @param pos Position to be used for error reporting.
duke@1 511 * @param t The type to be checked.
duke@1 512 */
duke@1 513 Type checkNonVoid(DiagnosticPosition pos, Type t) {
duke@1 514 if (t.tag == VOID) {
duke@1 515 log.error(pos, "void.not.allowed.here");
jjg@110 516 return types.createErrorType(t);
duke@1 517 } else {
duke@1 518 return t;
duke@1 519 }
duke@1 520 }
duke@1 521
duke@1 522 /** Check that type is a class or interface type.
duke@1 523 * @param pos Position to be used for error reporting.
duke@1 524 * @param t The type to be checked.
duke@1 525 */
duke@1 526 Type checkClassType(DiagnosticPosition pos, Type t) {
duke@1 527 if (t.tag != CLASS && t.tag != ERROR)
duke@1 528 return typeTagError(pos,
mcimadamore@89 529 diags.fragment("type.req.class"),
duke@1 530 (t.tag == TYPEVAR)
mcimadamore@89 531 ? diags.fragment("type.parameter", t)
duke@1 532 : t);
duke@1 533 else
duke@1 534 return t;
duke@1 535 }
duke@1 536
duke@1 537 /** Check that type is a class or interface type.
duke@1 538 * @param pos Position to be used for error reporting.
duke@1 539 * @param t The type to be checked.
duke@1 540 * @param noBounds True if type bounds are illegal here.
duke@1 541 */
duke@1 542 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 543 t = checkClassType(pos, t);
duke@1 544 if (noBounds && t.isParameterized()) {
duke@1 545 List<Type> args = t.getTypeArguments();
duke@1 546 while (args.nonEmpty()) {
duke@1 547 if (args.head.tag == WILDCARD)
duke@1 548 return typeTagError(pos,
jjg@398 549 Log.getLocalizedString("type.req.exact"),
duke@1 550 args.head);
duke@1 551 args = args.tail;
duke@1 552 }
duke@1 553 }
duke@1 554 return t;
duke@1 555 }
duke@1 556
duke@1 557 /** Check that type is a reifiable class, interface or array type.
duke@1 558 * @param pos Position to be used for error reporting.
duke@1 559 * @param t The type to be checked.
duke@1 560 */
duke@1 561 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
duke@1 562 if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
duke@1 563 return typeTagError(pos,
mcimadamore@89 564 diags.fragment("type.req.class.array"),
duke@1 565 t);
duke@1 566 } else if (!types.isReifiable(t)) {
duke@1 567 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 568 return types.createErrorType(t);
duke@1 569 } else {
duke@1 570 return t;
duke@1 571 }
duke@1 572 }
duke@1 573
duke@1 574 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 575 * or a type variable.
duke@1 576 * @param pos Position to be used for error reporting.
duke@1 577 * @param t The type to be checked.
duke@1 578 */
duke@1 579 Type checkRefType(DiagnosticPosition pos, Type t) {
duke@1 580 switch (t.tag) {
duke@1 581 case CLASS:
duke@1 582 case ARRAY:
duke@1 583 case TYPEVAR:
duke@1 584 case WILDCARD:
duke@1 585 case ERROR:
duke@1 586 return t;
duke@1 587 default:
duke@1 588 return typeTagError(pos,
mcimadamore@89 589 diags.fragment("type.req.ref"),
duke@1 590 t);
duke@1 591 }
duke@1 592 }
duke@1 593
jrose@267 594 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 595 * or a type variable.
jrose@267 596 * @param trees Original trees, used for error reporting.
jrose@267 597 * @param types The types to be checked.
jrose@267 598 */
jrose@267 599 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 600 List<JCExpression> tl = trees;
jrose@267 601 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 602 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 603 tl = tl.tail;
jrose@267 604 }
jrose@267 605 return types;
jrose@267 606 }
jrose@267 607
duke@1 608 /** Check that type is a null or reference type.
duke@1 609 * @param pos Position to be used for error reporting.
duke@1 610 * @param t The type to be checked.
duke@1 611 */
duke@1 612 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
duke@1 613 switch (t.tag) {
duke@1 614 case CLASS:
duke@1 615 case ARRAY:
duke@1 616 case TYPEVAR:
duke@1 617 case WILDCARD:
duke@1 618 case BOT:
duke@1 619 case ERROR:
duke@1 620 return t;
duke@1 621 default:
duke@1 622 return typeTagError(pos,
mcimadamore@89 623 diags.fragment("type.req.ref"),
duke@1 624 t);
duke@1 625 }
duke@1 626 }
duke@1 627
duke@1 628 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 629 * Return true if it doesn't.
duke@1 630 * @param pos Position to be used for error reporting.
duke@1 631 * @param flags The set of flags to be checked.
duke@1 632 * @param set1 Conflicting flags set #1.
duke@1 633 * @param set2 Conflicting flags set #2.
duke@1 634 */
duke@1 635 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 636 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 637 log.error(pos,
duke@1 638 "illegal.combination.of.modifiers",
mcimadamore@80 639 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 640 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 641 return false;
duke@1 642 } else
duke@1 643 return true;
duke@1 644 }
duke@1 645
mcimadamore@537 646 /** Check that the type inferred using the diamond operator does not contain
mcimadamore@537 647 * non-denotable types such as captured types or intersection types.
mcimadamore@537 648 * @param t the type inferred using the diamond operator
mcimadamore@537 649 */
mcimadamore@537 650 List<Type> checkDiamond(ClassType t) {
mcimadamore@537 651 DiamondTypeChecker dtc = new DiamondTypeChecker();
mcimadamore@537 652 ListBuffer<Type> buf = ListBuffer.lb();
mcimadamore@537 653 for (Type arg : t.getTypeArguments()) {
mcimadamore@537 654 if (!dtc.visit(arg, null)) {
mcimadamore@537 655 buf.append(arg);
mcimadamore@537 656 }
mcimadamore@537 657 }
mcimadamore@537 658 return buf.toList();
mcimadamore@537 659 }
mcimadamore@537 660
mcimadamore@537 661 static class DiamondTypeChecker extends Types.SimpleVisitor<Boolean, Void> {
mcimadamore@537 662 public Boolean visitType(Type t, Void s) {
mcimadamore@537 663 return true;
mcimadamore@537 664 }
mcimadamore@537 665 @Override
mcimadamore@537 666 public Boolean visitClassType(ClassType t, Void s) {
mcimadamore@537 667 if (t.isCompound()) {
mcimadamore@537 668 return false;
mcimadamore@537 669 }
mcimadamore@537 670 for (Type targ : t.getTypeArguments()) {
mcimadamore@537 671 if (!visit(targ, s)) {
mcimadamore@537 672 return false;
mcimadamore@537 673 }
mcimadamore@537 674 }
mcimadamore@537 675 return true;
mcimadamore@537 676 }
mcimadamore@537 677 @Override
mcimadamore@537 678 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@537 679 return false;
mcimadamore@537 680 }
mcimadamore@537 681 }
mcimadamore@537 682
mcimadamore@547 683 /**
mcimadamore@547 684 * Check that vararg method call is sound
mcimadamore@547 685 * @param pos Position to be used for error reporting.
mcimadamore@547 686 * @param argtypes Actual arguments supplied to vararg method.
mcimadamore@547 687 */
mcimadamore@547 688 void checkVararg(DiagnosticPosition pos, List<Type> argtypes) {
mcimadamore@547 689 Type argtype = argtypes.last();
mcimadamore@547 690 if (!types.isReifiable(argtype))
mcimadamore@547 691 warnUnchecked(pos,
mcimadamore@547 692 "unchecked.generic.array.creation",
mcimadamore@547 693 argtype);
mcimadamore@547 694 }
mcimadamore@547 695
duke@1 696 /** Check that given modifiers are legal for given symbol and
duke@1 697 * return modifiers together with any implicit modififiers for that symbol.
duke@1 698 * Warning: we can't use flags() here since this method
duke@1 699 * is called during class enter, when flags() would cause a premature
duke@1 700 * completion.
duke@1 701 * @param pos Position to be used for error reporting.
duke@1 702 * @param flags The set of modifiers given in a definition.
duke@1 703 * @param sym The defined symbol.
duke@1 704 */
duke@1 705 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 706 long mask;
duke@1 707 long implicit = 0;
duke@1 708 switch (sym.kind) {
duke@1 709 case VAR:
duke@1 710 if (sym.owner.kind != TYP)
duke@1 711 mask = LocalVarFlags;
duke@1 712 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 713 mask = implicit = InterfaceVarFlags;
duke@1 714 else
duke@1 715 mask = VarFlags;
duke@1 716 break;
duke@1 717 case MTH:
duke@1 718 if (sym.name == names.init) {
duke@1 719 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 720 // enum constructors cannot be declared public or
duke@1 721 // protected and must be implicitly or explicitly
duke@1 722 // private
duke@1 723 implicit = PRIVATE;
duke@1 724 mask = PRIVATE;
duke@1 725 } else
duke@1 726 mask = ConstructorFlags;
duke@1 727 } else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 728 mask = implicit = InterfaceMethodFlags;
duke@1 729 else {
duke@1 730 mask = MethodFlags;
duke@1 731 }
duke@1 732 // Imply STRICTFP if owner has STRICTFP set.
duke@1 733 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 734 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 735 break;
duke@1 736 case TYP:
duke@1 737 if (sym.isLocal()) {
duke@1 738 mask = LocalClassFlags;
jjg@113 739 if (sym.name.isEmpty()) { // Anonymous class
duke@1 740 // Anonymous classes in static methods are themselves static;
duke@1 741 // that's why we admit STATIC here.
duke@1 742 mask |= STATIC;
duke@1 743 // JLS: Anonymous classes are final.
duke@1 744 implicit |= FINAL;
duke@1 745 }
duke@1 746 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 747 (flags & ENUM) != 0)
duke@1 748 log.error(pos, "enums.must.be.static");
duke@1 749 } else if (sym.owner.kind == TYP) {
duke@1 750 mask = MemberClassFlags;
duke@1 751 if (sym.owner.owner.kind == PCK ||
duke@1 752 (sym.owner.flags_field & STATIC) != 0)
duke@1 753 mask |= STATIC;
duke@1 754 else if ((flags & ENUM) != 0)
duke@1 755 log.error(pos, "enums.must.be.static");
duke@1 756 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 757 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 758 } else {
duke@1 759 mask = ClassFlags;
duke@1 760 }
duke@1 761 // Interfaces are always ABSTRACT
duke@1 762 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 763
duke@1 764 if ((flags & ENUM) != 0) {
duke@1 765 // enums can't be declared abstract or final
duke@1 766 mask &= ~(ABSTRACT | FINAL);
duke@1 767 implicit |= implicitEnumFinalFlag(tree);
duke@1 768 }
duke@1 769 // Imply STRICTFP if owner has STRICTFP set.
duke@1 770 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 771 break;
duke@1 772 default:
duke@1 773 throw new AssertionError();
duke@1 774 }
duke@1 775 long illegal = flags & StandardFlags & ~mask;
duke@1 776 if (illegal != 0) {
duke@1 777 if ((illegal & INTERFACE) != 0) {
duke@1 778 log.error(pos, "intf.not.allowed.here");
duke@1 779 mask |= INTERFACE;
duke@1 780 }
duke@1 781 else {
duke@1 782 log.error(pos,
mcimadamore@80 783 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 784 }
duke@1 785 }
duke@1 786 else if ((sym.kind == TYP ||
duke@1 787 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 788 // in the presence of inner classes. Should it be deleted here?
duke@1 789 checkDisjoint(pos, flags,
duke@1 790 ABSTRACT,
duke@1 791 PRIVATE | STATIC))
duke@1 792 &&
duke@1 793 checkDisjoint(pos, flags,
duke@1 794 ABSTRACT | INTERFACE,
duke@1 795 FINAL | NATIVE | SYNCHRONIZED)
duke@1 796 &&
duke@1 797 checkDisjoint(pos, flags,
duke@1 798 PUBLIC,
duke@1 799 PRIVATE | PROTECTED)
duke@1 800 &&
duke@1 801 checkDisjoint(pos, flags,
duke@1 802 PRIVATE,
duke@1 803 PUBLIC | PROTECTED)
duke@1 804 &&
duke@1 805 checkDisjoint(pos, flags,
duke@1 806 FINAL,
duke@1 807 VOLATILE)
duke@1 808 &&
duke@1 809 (sym.kind == TYP ||
duke@1 810 checkDisjoint(pos, flags,
duke@1 811 ABSTRACT | NATIVE,
duke@1 812 STRICTFP))) {
duke@1 813 // skip
duke@1 814 }
duke@1 815 return flags & (mask | ~StandardFlags) | implicit;
duke@1 816 }
duke@1 817
duke@1 818
duke@1 819 /** Determine if this enum should be implicitly final.
duke@1 820 *
duke@1 821 * If the enum has no specialized enum contants, it is final.
duke@1 822 *
duke@1 823 * If the enum does have specialized enum contants, it is
duke@1 824 * <i>not</i> final.
duke@1 825 */
duke@1 826 private long implicitEnumFinalFlag(JCTree tree) {
duke@1 827 if (tree.getTag() != JCTree.CLASSDEF) return 0;
duke@1 828 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 829 boolean specialized;
duke@1 830 SpecialTreeVisitor() {
duke@1 831 this.specialized = false;
duke@1 832 };
duke@1 833
jjg@398 834 @Override
duke@1 835 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 836
jjg@398 837 @Override
duke@1 838 public void visitVarDef(JCVariableDecl tree) {
duke@1 839 if ((tree.mods.flags & ENUM) != 0) {
duke@1 840 if (tree.init instanceof JCNewClass &&
duke@1 841 ((JCNewClass) tree.init).def != null) {
duke@1 842 specialized = true;
duke@1 843 }
duke@1 844 }
duke@1 845 }
duke@1 846 }
duke@1 847
duke@1 848 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 849 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 850 for (JCTree defs: cdef.defs) {
duke@1 851 defs.accept(sts);
duke@1 852 if (sts.specialized) return 0;
duke@1 853 }
duke@1 854 return FINAL;
duke@1 855 }
duke@1 856
duke@1 857 /* *************************************************************************
duke@1 858 * Type Validation
duke@1 859 **************************************************************************/
duke@1 860
duke@1 861 /** Validate a type expression. That is,
duke@1 862 * check that all type arguments of a parametric type are within
duke@1 863 * their bounds. This must be done in a second phase after type attributon
duke@1 864 * since a class might have a subclass as type parameter bound. E.g:
duke@1 865 *
duke@1 866 * class B<A extends C> { ... }
duke@1 867 * class C extends B<C> { ... }
duke@1 868 *
duke@1 869 * and we can't make sure that the bound is already attributed because
duke@1 870 * of possible cycles.
duke@1 871 */
duke@1 872 private Validator validator = new Validator();
duke@1 873
duke@1 874 /** Visitor method: Validate a type expression, if it is not null, catching
duke@1 875 * and reporting any completion failures.
duke@1 876 */
mcimadamore@122 877 void validate(JCTree tree, Env<AttrContext> env) {
duke@1 878 try {
mcimadamore@122 879 if (tree != null) {
mcimadamore@122 880 validator.env = env;
mcimadamore@122 881 tree.accept(validator);
mcimadamore@122 882 checkRaw(tree, env);
mcimadamore@122 883 }
duke@1 884 } catch (CompletionFailure ex) {
duke@1 885 completionError(tree.pos(), ex);
duke@1 886 }
duke@1 887 }
mcimadamore@122 888 //where
mcimadamore@122 889 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@122 890 if (lint.isEnabled(Lint.LintCategory.RAW) &&
mcimadamore@122 891 tree.type.tag == CLASS &&
mcimadamore@564 892 !TreeInfo.isDiamond(tree) &&
mcimadamore@122 893 !env.enclClass.name.isEmpty() && //anonymous or intersection
mcimadamore@122 894 tree.type.isRaw()) {
mcimadamore@122 895 log.warning(tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@122 896 }
mcimadamore@122 897 }
duke@1 898
duke@1 899 /** Visitor method: Validate a list of type expressions.
duke@1 900 */
mcimadamore@122 901 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 902 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 903 validate(l.head, env);
duke@1 904 }
duke@1 905
duke@1 906 /** A visitor class for type validation.
duke@1 907 */
duke@1 908 class Validator extends JCTree.Visitor {
duke@1 909
jjg@398 910 @Override
duke@1 911 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@122 912 validate(tree.elemtype, env);
duke@1 913 }
duke@1 914
jjg@398 915 @Override
duke@1 916 public void visitTypeApply(JCTypeApply tree) {
duke@1 917 if (tree.type.tag == CLASS) {
mcimadamore@158 918 List<Type> formals = tree.type.tsym.type.allparams();
mcimadamore@158 919 List<Type> actuals = tree.type.allparams();
duke@1 920 List<JCExpression> args = tree.arguments;
mcimadamore@158 921 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@561 922 ListBuffer<Type> tvars_buf = new ListBuffer<Type>();
duke@1 923
duke@1 924 // For matching pairs of actual argument types `a' and
duke@1 925 // formal type parameters with declared bound `b' ...
duke@1 926 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@122 927 validate(args.head, env);
duke@1 928
duke@1 929 // exact type arguments needs to know their
duke@1 930 // bounds (for upper and lower bound
duke@1 931 // calculations). So we create new TypeVars with
duke@1 932 // bounds substed with actuals.
duke@1 933 tvars_buf.append(types.substBound(((TypeVar)forms.head),
duke@1 934 formals,
mcimadamore@78 935 actuals));
duke@1 936
duke@1 937 args = args.tail;
duke@1 938 forms = forms.tail;
duke@1 939 }
duke@1 940
duke@1 941 args = tree.arguments;
mcimadamore@154 942 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@154 943 formals,
mcimadamore@158 944 types.capture(tree.type).allparams());
mcimadamore@154 945 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@154 946 // Let the actual arguments know their bound
mcimadamore@154 947 args.head.type.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@154 948 args = args.tail;
mcimadamore@154 949 tvars_cap = tvars_cap.tail;
mcimadamore@154 950 }
mcimadamore@154 951
mcimadamore@154 952 args = tree.arguments;
mcimadamore@561 953 List<Type> tvars = tvars_buf.toList();
mcimadamore@154 954
duke@1 955 while (args.nonEmpty() && tvars.nonEmpty()) {
mcimadamore@561 956 Type actual = types.subst(args.head.type,
mcimadamore@561 957 tree.type.tsym.type.getTypeArguments(),
mcimadamore@561 958 tvars_buf.toList());
mcimadamore@154 959 checkExtends(args.head.pos(),
mcimadamore@561 960 actual,
mcimadamore@561 961 (TypeVar)tvars.head);
duke@1 962 args = args.tail;
duke@1 963 tvars = tvars.tail;
duke@1 964 }
duke@1 965
mcimadamore@154 966 checkCapture(tree);
mcimadamore@536 967
duke@1 968 // Check that this type is either fully parameterized, or
duke@1 969 // not parameterized at all.
duke@1 970 if (tree.type.getEnclosingType().isRaw())
duke@1 971 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
duke@1 972 if (tree.clazz.getTag() == JCTree.SELECT)
duke@1 973 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 974 }
duke@1 975 }
duke@1 976
jjg@398 977 @Override
duke@1 978 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@122 979 validate(tree.bounds, env);
duke@1 980 checkClassBounds(tree.pos(), tree.type);
duke@1 981 }
duke@1 982
duke@1 983 @Override
duke@1 984 public void visitWildcard(JCWildcard tree) {
duke@1 985 if (tree.inner != null)
mcimadamore@122 986 validate(tree.inner, env);
duke@1 987 }
duke@1 988
jjg@398 989 @Override
duke@1 990 public void visitSelect(JCFieldAccess tree) {
duke@1 991 if (tree.type.tag == CLASS) {
duke@1 992 visitSelectInternal(tree);
duke@1 993
duke@1 994 // Check that this type is either fully parameterized, or
duke@1 995 // not parameterized at all.
duke@1 996 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 997 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 998 }
duke@1 999 }
duke@1 1000 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1001 if (tree.type.tsym.isStatic() &&
duke@1 1002 tree.selected.type.isParameterized()) {
duke@1 1003 // The enclosing type is not a class, so we are
duke@1 1004 // looking at a static member type. However, the
duke@1 1005 // qualifying expression is parameterized.
duke@1 1006 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1007 } else {
duke@1 1008 // otherwise validate the rest of the expression
mcimadamore@122 1009 tree.selected.accept(this);
duke@1 1010 }
duke@1 1011 }
duke@1 1012
jjg@398 1013 @Override
jjg@308 1014 public void visitAnnotatedType(JCAnnotatedType tree) {
jjg@308 1015 tree.underlyingType.accept(this);
jjg@308 1016 }
jjg@308 1017
duke@1 1018 /** Default visitor method: do nothing.
duke@1 1019 */
jjg@398 1020 @Override
duke@1 1021 public void visitTree(JCTree tree) {
duke@1 1022 }
mcimadamore@122 1023
mcimadamore@122 1024 Env<AttrContext> env;
duke@1 1025 }
duke@1 1026
duke@1 1027 /* *************************************************************************
duke@1 1028 * Exception checking
duke@1 1029 **************************************************************************/
duke@1 1030
duke@1 1031 /* The following methods treat classes as sets that contain
duke@1 1032 * the class itself and all their subclasses
duke@1 1033 */
duke@1 1034
duke@1 1035 /** Is given type a subtype of some of the types in given list?
duke@1 1036 */
duke@1 1037 boolean subset(Type t, List<Type> ts) {
duke@1 1038 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1039 if (types.isSubtype(t, l.head)) return true;
duke@1 1040 return false;
duke@1 1041 }
duke@1 1042
duke@1 1043 /** Is given type a subtype or supertype of
duke@1 1044 * some of the types in given list?
duke@1 1045 */
duke@1 1046 boolean intersects(Type t, List<Type> ts) {
duke@1 1047 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1048 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1049 return false;
duke@1 1050 }
duke@1 1051
duke@1 1052 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1053 * in the list.
duke@1 1054 */
duke@1 1055 List<Type> incl(Type t, List<Type> ts) {
duke@1 1056 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1057 }
duke@1 1058
duke@1 1059 /** Remove type set from type set list.
duke@1 1060 */
duke@1 1061 List<Type> excl(Type t, List<Type> ts) {
duke@1 1062 if (ts.isEmpty()) {
duke@1 1063 return ts;
duke@1 1064 } else {
duke@1 1065 List<Type> ts1 = excl(t, ts.tail);
duke@1 1066 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1067 else if (ts1 == ts.tail) return ts;
duke@1 1068 else return ts1.prepend(ts.head);
duke@1 1069 }
duke@1 1070 }
duke@1 1071
duke@1 1072 /** Form the union of two type set lists.
duke@1 1073 */
duke@1 1074 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1075 List<Type> ts = ts1;
duke@1 1076 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1077 ts = incl(l.head, ts);
duke@1 1078 return ts;
duke@1 1079 }
duke@1 1080
duke@1 1081 /** Form the difference of two type lists.
duke@1 1082 */
duke@1 1083 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1084 List<Type> ts = ts1;
duke@1 1085 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1086 ts = excl(l.head, ts);
duke@1 1087 return ts;
duke@1 1088 }
duke@1 1089
duke@1 1090 /** Form the intersection of two type lists.
duke@1 1091 */
duke@1 1092 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1093 List<Type> ts = List.nil();
duke@1 1094 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1095 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1096 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1097 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1098 return ts;
duke@1 1099 }
duke@1 1100
duke@1 1101 /** Is exc an exception symbol that need not be declared?
duke@1 1102 */
duke@1 1103 boolean isUnchecked(ClassSymbol exc) {
duke@1 1104 return
duke@1 1105 exc.kind == ERR ||
duke@1 1106 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1107 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1108 }
duke@1 1109
duke@1 1110 /** Is exc an exception type that need not be declared?
duke@1 1111 */
duke@1 1112 boolean isUnchecked(Type exc) {
duke@1 1113 return
duke@1 1114 (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
duke@1 1115 (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
duke@1 1116 exc.tag == BOT;
duke@1 1117 }
duke@1 1118
duke@1 1119 /** Same, but handling completion failures.
duke@1 1120 */
duke@1 1121 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1122 try {
duke@1 1123 return isUnchecked(exc);
duke@1 1124 } catch (CompletionFailure ex) {
duke@1 1125 completionError(pos, ex);
duke@1 1126 return true;
duke@1 1127 }
duke@1 1128 }
duke@1 1129
duke@1 1130 /** Is exc handled by given exception list?
duke@1 1131 */
duke@1 1132 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1133 return isUnchecked(exc) || subset(exc, handled);
duke@1 1134 }
duke@1 1135
duke@1 1136 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1137 * @param thrown The list of thrown exceptions.
duke@1 1138 * @param handled The list of handled exceptions.
duke@1 1139 */
mcimadamore@362 1140 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1141 List<Type> unhandled = List.nil();
duke@1 1142 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1143 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1144 return unhandled;
duke@1 1145 }
duke@1 1146
duke@1 1147 /* *************************************************************************
duke@1 1148 * Overriding/Implementation checking
duke@1 1149 **************************************************************************/
duke@1 1150
duke@1 1151 /** The level of access protection given by a flag set,
duke@1 1152 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1153 */
duke@1 1154 static int protection(long flags) {
duke@1 1155 switch ((short)(flags & AccessFlags)) {
duke@1 1156 case PRIVATE: return 3;
duke@1 1157 case PROTECTED: return 1;
duke@1 1158 default:
duke@1 1159 case PUBLIC: return 0;
duke@1 1160 case 0: return 2;
duke@1 1161 }
duke@1 1162 }
duke@1 1163
duke@1 1164 /** A customized "cannot override" error message.
duke@1 1165 * @param m The overriding method.
duke@1 1166 * @param other The overridden method.
duke@1 1167 * @return An internationalized string.
duke@1 1168 */
mcimadamore@89 1169 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1170 String key;
duke@1 1171 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1172 key = "cant.override";
duke@1 1173 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1174 key = "cant.implement";
duke@1 1175 else
duke@1 1176 key = "clashes.with";
mcimadamore@89 1177 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1178 }
duke@1 1179
duke@1 1180 /** A customized "override" warning message.
duke@1 1181 * @param m The overriding method.
duke@1 1182 * @param other The overridden method.
duke@1 1183 * @return An internationalized string.
duke@1 1184 */
mcimadamore@89 1185 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1186 String key;
duke@1 1187 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1188 key = "unchecked.override";
duke@1 1189 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1190 key = "unchecked.implement";
duke@1 1191 else
duke@1 1192 key = "unchecked.clash.with";
mcimadamore@89 1193 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1194 }
duke@1 1195
duke@1 1196 /** A customized "override" warning message.
duke@1 1197 * @param m The overriding method.
duke@1 1198 * @param other The overridden method.
duke@1 1199 * @return An internationalized string.
duke@1 1200 */
mcimadamore@89 1201 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1202 String key;
duke@1 1203 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1204 key = "varargs.override";
duke@1 1205 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1206 key = "varargs.implement";
duke@1 1207 else
duke@1 1208 key = "varargs.clash.with";
mcimadamore@89 1209 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1210 }
duke@1 1211
duke@1 1212 /** Check that this method conforms with overridden method 'other'.
duke@1 1213 * where `origin' is the class where checking started.
duke@1 1214 * Complications:
duke@1 1215 * (1) Do not check overriding of synthetic methods
duke@1 1216 * (reason: they might be final).
duke@1 1217 * todo: check whether this is still necessary.
duke@1 1218 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1219 * than the method it implements. Augment the proxy methods with the
duke@1 1220 * undeclared exceptions in this case.
duke@1 1221 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1222 * has a result type
duke@1 1223 * extended by the result type of the method it implements.
duke@1 1224 * Change the proxies result type to the smaller type in this case.
duke@1 1225 *
duke@1 1226 * @param tree The tree from which positions
duke@1 1227 * are extracted for errors.
duke@1 1228 * @param m The overriding method.
duke@1 1229 * @param other The overridden method.
duke@1 1230 * @param origin The class of which the overriding method
duke@1 1231 * is a member.
duke@1 1232 */
duke@1 1233 void checkOverride(JCTree tree,
duke@1 1234 MethodSymbol m,
duke@1 1235 MethodSymbol other,
duke@1 1236 ClassSymbol origin) {
duke@1 1237 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1238 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1239 return;
duke@1 1240 }
duke@1 1241
duke@1 1242 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1243 if ((m.flags() & STATIC) != 0 &&
duke@1 1244 (other.flags() & STATIC) == 0) {
duke@1 1245 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1246 cannotOverride(m, other));
duke@1 1247 return;
duke@1 1248 }
duke@1 1249
duke@1 1250 // Error if instance method overrides static or final
duke@1 1251 // method (JLS 8.4.6.1).
duke@1 1252 if ((other.flags() & FINAL) != 0 ||
duke@1 1253 (m.flags() & STATIC) == 0 &&
duke@1 1254 (other.flags() & STATIC) != 0) {
duke@1 1255 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1256 cannotOverride(m, other),
mcimadamore@80 1257 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1258 return;
duke@1 1259 }
duke@1 1260
duke@1 1261 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1262 // handled in validateAnnotationMethod
duke@1 1263 return;
duke@1 1264 }
duke@1 1265
duke@1 1266 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1267 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1268 protection(m.flags()) > protection(other.flags())) {
duke@1 1269 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1270 cannotOverride(m, other),
mcimadamore@80 1271 other.flags() == 0 ?
mcimadamore@80 1272 Flag.PACKAGE :
mcimadamore@80 1273 asFlagSet(other.flags() & AccessFlags));
duke@1 1274 return;
duke@1 1275 }
duke@1 1276
duke@1 1277 Type mt = types.memberType(origin.type, m);
duke@1 1278 Type ot = types.memberType(origin.type, other);
duke@1 1279 // Error if overriding result type is different
duke@1 1280 // (or, in the case of generics mode, not a subtype) of
duke@1 1281 // overridden result type. We have to rename any type parameters
duke@1 1282 // before comparing types.
duke@1 1283 List<Type> mtvars = mt.getTypeArguments();
duke@1 1284 List<Type> otvars = ot.getTypeArguments();
duke@1 1285 Type mtres = mt.getReturnType();
duke@1 1286 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1287
duke@1 1288 overrideWarner.warned = false;
duke@1 1289 boolean resultTypesOK =
tbell@202 1290 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1291 if (!resultTypesOK) {
jjg@398 1292 if (!allowCovariantReturns &&
duke@1 1293 m.owner != origin &&
duke@1 1294 m.owner.isSubClass(other.owner, types)) {
duke@1 1295 // allow limited interoperability with covariant returns
duke@1 1296 } else {
mcimadamore@362 1297 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1298 "override.incompatible.ret",
mcimadamore@362 1299 cannotOverride(m, other),
duke@1 1300 mtres, otres);
duke@1 1301 return;
duke@1 1302 }
duke@1 1303 } else if (overrideWarner.warned) {
duke@1 1304 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1305 "override.unchecked.ret",
mcimadamore@362 1306 uncheckedOverrides(m, other),
mcimadamore@362 1307 mtres, otres);
duke@1 1308 }
duke@1 1309
duke@1 1310 // Error if overriding method throws an exception not reported
duke@1 1311 // by overridden method.
duke@1 1312 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1313 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1314 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1315 if (unhandledErased.nonEmpty()) {
duke@1 1316 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1317 "override.meth.doesnt.throw",
duke@1 1318 cannotOverride(m, other),
mcimadamore@362 1319 unhandledUnerased.head);
mcimadamore@362 1320 return;
mcimadamore@362 1321 }
mcimadamore@362 1322 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1323 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1324 "override.unchecked.thrown",
mcimadamore@362 1325 cannotOverride(m, other),
mcimadamore@362 1326 unhandledUnerased.head);
duke@1 1327 return;
duke@1 1328 }
duke@1 1329
duke@1 1330 // Optional warning if varargs don't agree
duke@1 1331 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
duke@1 1332 && lint.isEnabled(Lint.LintCategory.OVERRIDES)) {
duke@1 1333 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1334 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1335 ? "override.varargs.missing"
duke@1 1336 : "override.varargs.extra",
duke@1 1337 varargsOverrides(m, other));
duke@1 1338 }
duke@1 1339
duke@1 1340 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1341 if ((other.flags() & BRIDGE) != 0) {
duke@1 1342 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1343 uncheckedOverrides(m, other));
duke@1 1344 }
duke@1 1345
duke@1 1346 // Warn if a deprecated method overridden by a non-deprecated one.
duke@1 1347 if ((other.flags() & DEPRECATED) != 0
duke@1 1348 && (m.flags() & DEPRECATED) == 0
duke@1 1349 && m.outermostClass() != other.outermostClass()
duke@1 1350 && !isDeprecatedOverrideIgnorable(other, origin)) {
duke@1 1351 warnDeprecated(TreeInfo.diagnosticPositionFor(m, tree), other);
duke@1 1352 }
duke@1 1353 }
duke@1 1354 // where
duke@1 1355 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1356 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1357 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1358 // because in that case, we will rediscover the issue when examining the method
duke@1 1359 // in the supertype.
duke@1 1360 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1361 // address the issue is when the method is the supertype implemementation: any other
duke@1 1362 // case, we will have dealt with when examining the supertype classes
duke@1 1363 ClassSymbol mc = m.enclClass();
duke@1 1364 Type st = types.supertype(origin.type);
duke@1 1365 if (st.tag != CLASS)
duke@1 1366 return true;
duke@1 1367 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1368
duke@1 1369 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1370 List<Type> intfs = types.interfaces(origin.type);
duke@1 1371 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1372 }
duke@1 1373 else
duke@1 1374 return (stimpl != m);
duke@1 1375 }
duke@1 1376
duke@1 1377
duke@1 1378 // used to check if there were any unchecked conversions
duke@1 1379 Warner overrideWarner = new Warner();
duke@1 1380
duke@1 1381 /** Check that a class does not inherit two concrete methods
duke@1 1382 * with the same signature.
duke@1 1383 * @param pos Position to be used for error reporting.
duke@1 1384 * @param site The class type to be checked.
duke@1 1385 */
duke@1 1386 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1387 Type sup = types.supertype(site);
duke@1 1388 if (sup.tag != CLASS) return;
duke@1 1389
duke@1 1390 for (Type t1 = sup;
duke@1 1391 t1.tsym.type.isParameterized();
duke@1 1392 t1 = types.supertype(t1)) {
duke@1 1393 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1394 e1 != null;
duke@1 1395 e1 = e1.sibling) {
duke@1 1396 Symbol s1 = e1.sym;
duke@1 1397 if (s1.kind != MTH ||
duke@1 1398 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1399 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1400 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1401 types,
duke@1 1402 true) != s1)
duke@1 1403 continue;
duke@1 1404 Type st1 = types.memberType(t1, s1);
duke@1 1405 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1406 if (st1 == s1.type) continue;
duke@1 1407
duke@1 1408 for (Type t2 = sup;
duke@1 1409 t2.tag == CLASS;
duke@1 1410 t2 = types.supertype(t2)) {
mcimadamore@24 1411 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1412 e2.scope != null;
duke@1 1413 e2 = e2.next()) {
duke@1 1414 Symbol s2 = e2.sym;
duke@1 1415 if (s2 == s1 ||
duke@1 1416 s2.kind != MTH ||
duke@1 1417 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1418 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1419 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1420 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1421 types,
duke@1 1422 true) != s2)
duke@1 1423 continue;
duke@1 1424 Type st2 = types.memberType(t2, s2);
duke@1 1425 if (types.overrideEquivalent(st1, st2))
duke@1 1426 log.error(pos, "concrete.inheritance.conflict",
duke@1 1427 s1, t1, s2, t2, sup);
duke@1 1428 }
duke@1 1429 }
duke@1 1430 }
duke@1 1431 }
duke@1 1432 }
duke@1 1433
duke@1 1434 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1435 * method with same name and arguments but incompatible return types.
duke@1 1436 * @param pos Position to be used for error reporting.
duke@1 1437 * @param t1 The first argument type.
duke@1 1438 * @param t2 The second argument type.
duke@1 1439 */
duke@1 1440 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1441 Type t1,
duke@1 1442 Type t2) {
duke@1 1443 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1444 types.makeCompoundType(t1, t2));
duke@1 1445 }
duke@1 1446
duke@1 1447 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1448 Type t1,
duke@1 1449 Type t2,
duke@1 1450 Type site) {
duke@1 1451 Symbol sym = firstIncompatibility(t1, t2, site);
duke@1 1452 if (sym != null) {
duke@1 1453 log.error(pos, "types.incompatible.diff.ret",
duke@1 1454 t1, t2, sym.name +
duke@1 1455 "(" + types.memberType(t2, sym).getParameterTypes() + ")");
duke@1 1456 return false;
duke@1 1457 }
duke@1 1458 return true;
duke@1 1459 }
duke@1 1460
duke@1 1461 /** Return the first method which is defined with same args
duke@1 1462 * but different return types in two given interfaces, or null if none
duke@1 1463 * exists.
duke@1 1464 * @param t1 The first type.
duke@1 1465 * @param t2 The second type.
duke@1 1466 * @param site The most derived type.
duke@1 1467 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1468 */
duke@1 1469 private Symbol firstIncompatibility(Type t1, Type t2, Type site) {
duke@1 1470 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1471 closure(t1, interfaces1);
duke@1 1472 Map<TypeSymbol,Type> interfaces2;
duke@1 1473 if (t1 == t2)
duke@1 1474 interfaces2 = interfaces1;
duke@1 1475 else
duke@1 1476 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1477
duke@1 1478 for (Type t3 : interfaces1.values()) {
duke@1 1479 for (Type t4 : interfaces2.values()) {
duke@1 1480 Symbol s = firstDirectIncompatibility(t3, t4, site);
duke@1 1481 if (s != null) return s;
duke@1 1482 }
duke@1 1483 }
duke@1 1484 return null;
duke@1 1485 }
duke@1 1486
duke@1 1487 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1488 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
duke@1 1489 if (t.tag != CLASS) return;
duke@1 1490 if (typeMap.put(t.tsym, t) == null) {
duke@1 1491 closure(types.supertype(t), typeMap);
duke@1 1492 for (Type i : types.interfaces(t))
duke@1 1493 closure(i, typeMap);
duke@1 1494 }
duke@1 1495 }
duke@1 1496
duke@1 1497 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1498 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
duke@1 1499 if (t.tag != CLASS) return;
duke@1 1500 if (typesSkip.get(t.tsym) != null) return;
duke@1 1501 if (typeMap.put(t.tsym, t) == null) {
duke@1 1502 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1503 for (Type i : types.interfaces(t))
duke@1 1504 closure(i, typesSkip, typeMap);
duke@1 1505 }
duke@1 1506 }
duke@1 1507
duke@1 1508 /** Return the first method in t2 that conflicts with a method from t1. */
duke@1 1509 private Symbol firstDirectIncompatibility(Type t1, Type t2, Type site) {
duke@1 1510 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1511 Symbol s1 = e1.sym;
duke@1 1512 Type st1 = null;
duke@1 1513 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
duke@1 1514 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1515 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1516 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1517 Symbol s2 = e2.sym;
duke@1 1518 if (s1 == s2) continue;
duke@1 1519 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
duke@1 1520 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1521 Type st2 = types.memberType(t2, s2);
duke@1 1522 if (types.overrideEquivalent(st1, st2)) {
duke@1 1523 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1524 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1525 Type rt1 = st1.getReturnType();
duke@1 1526 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1527 boolean compat =
duke@1 1528 types.isSameType(rt1, rt2) ||
duke@1 1529 rt1.tag >= CLASS && rt2.tag >= CLASS &&
duke@1 1530 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
mcimadamore@59 1531 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
mcimadamore@59 1532 checkCommonOverriderIn(s1,s2,site);
duke@1 1533 if (!compat) return s2;
duke@1 1534 }
duke@1 1535 }
duke@1 1536 }
duke@1 1537 return null;
duke@1 1538 }
mcimadamore@59 1539 //WHERE
mcimadamore@59 1540 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1541 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1542 Type st1 = types.memberType(site, s1);
mcimadamore@59 1543 Type st2 = types.memberType(site, s2);
mcimadamore@59 1544 closure(site, supertypes);
mcimadamore@59 1545 for (Type t : supertypes.values()) {
mcimadamore@59 1546 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1547 Symbol s3 = e.sym;
mcimadamore@59 1548 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1549 Type st3 = types.memberType(site,s3);
mcimadamore@59 1550 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1551 if (s3.owner == site.tsym) {
mcimadamore@59 1552 return true;
mcimadamore@59 1553 }
mcimadamore@59 1554 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1555 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1556 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1557 Type rt1 = st1.getReturnType();
mcimadamore@59 1558 Type rt2 = st2.getReturnType();
mcimadamore@59 1559 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1560 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1561 boolean compat =
mcimadamore@59 1562 rt13.tag >= CLASS && rt23.tag >= CLASS &&
mcimadamore@59 1563 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
mcimadamore@59 1564 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
mcimadamore@59 1565 if (compat)
mcimadamore@59 1566 return true;
mcimadamore@59 1567 }
mcimadamore@59 1568 }
mcimadamore@59 1569 }
mcimadamore@59 1570 return false;
mcimadamore@59 1571 }
duke@1 1572
duke@1 1573 /** Check that a given method conforms with any method it overrides.
duke@1 1574 * @param tree The tree from which positions are extracted
duke@1 1575 * for errors.
duke@1 1576 * @param m The overriding method.
duke@1 1577 */
duke@1 1578 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1579 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1580 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1581 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1582 log.error(tree.pos(), "enum.no.finalize");
duke@1 1583 return;
duke@1 1584 }
duke@1 1585 for (Type t = types.supertype(origin.type); t.tag == CLASS;
duke@1 1586 t = types.supertype(t)) {
duke@1 1587 TypeSymbol c = t.tsym;
duke@1 1588 Scope.Entry e = c.members().lookup(m.name);
duke@1 1589 while (e.scope != null) {
duke@1 1590 if (m.overrides(e.sym, origin, types, false))
duke@1 1591 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@252 1592 else if (e.sym.kind == MTH &&
mcimadamore@252 1593 e.sym.isInheritedIn(origin, types) &&
mcimadamore@252 1594 (e.sym.flags() & SYNTHETIC) == 0 &&
mcimadamore@252 1595 !m.isConstructor()) {
mcimadamore@24 1596 Type er1 = m.erasure(types);
mcimadamore@24 1597 Type er2 = e.sym.erasure(types);
mcimadamore@252 1598 if (types.isSameTypes(er1.getParameterTypes(),
mcimadamore@252 1599 er2.getParameterTypes())) {
mcimadamore@24 1600 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@24 1601 "name.clash.same.erasure.no.override",
mcimadamore@24 1602 m, m.location(),
mcimadamore@24 1603 e.sym, e.sym.location());
mcimadamore@24 1604 }
mcimadamore@24 1605 }
duke@1 1606 e = e.next();
duke@1 1607 }
duke@1 1608 }
duke@1 1609 }
duke@1 1610
duke@1 1611 /** Check that all abstract members of given class have definitions.
duke@1 1612 * @param pos Position to be used for error reporting.
duke@1 1613 * @param c The class.
duke@1 1614 */
duke@1 1615 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1616 try {
duke@1 1617 MethodSymbol undef = firstUndef(c, c);
duke@1 1618 if (undef != null) {
duke@1 1619 if ((c.flags() & ENUM) != 0 &&
duke@1 1620 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 1621 (c.flags() & FINAL) == 0) {
duke@1 1622 // add the ABSTRACT flag to an enum
duke@1 1623 c.flags_field |= ABSTRACT;
duke@1 1624 } else {
duke@1 1625 MethodSymbol undef1 =
duke@1 1626 new MethodSymbol(undef.flags(), undef.name,
duke@1 1627 types.memberType(c.type, undef), undef.owner);
duke@1 1628 log.error(pos, "does.not.override.abstract",
duke@1 1629 c, undef1, undef1.location());
duke@1 1630 }
duke@1 1631 }
duke@1 1632 } catch (CompletionFailure ex) {
duke@1 1633 completionError(pos, ex);
duke@1 1634 }
duke@1 1635 }
duke@1 1636 //where
duke@1 1637 /** Return first abstract member of class `c' that is not defined
duke@1 1638 * in `impl', null if there is none.
duke@1 1639 */
duke@1 1640 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 1641 MethodSymbol undef = null;
duke@1 1642 // Do not bother to search in classes that are not abstract,
duke@1 1643 // since they cannot have abstract members.
duke@1 1644 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 1645 Scope s = c.members();
duke@1 1646 for (Scope.Entry e = s.elems;
duke@1 1647 undef == null && e != null;
duke@1 1648 e = e.sibling) {
duke@1 1649 if (e.sym.kind == MTH &&
duke@1 1650 (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
duke@1 1651 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 1652 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
duke@1 1653 if (implmeth == null || implmeth == absmeth)
duke@1 1654 undef = absmeth;
duke@1 1655 }
duke@1 1656 }
duke@1 1657 if (undef == null) {
duke@1 1658 Type st = types.supertype(c.type);
duke@1 1659 if (st.tag == CLASS)
duke@1 1660 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 1661 }
duke@1 1662 for (List<Type> l = types.interfaces(c.type);
duke@1 1663 undef == null && l.nonEmpty();
duke@1 1664 l = l.tail) {
duke@1 1665 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 1666 }
duke@1 1667 }
duke@1 1668 return undef;
duke@1 1669 }
duke@1 1670
duke@1 1671 /** Check for cyclic references. Issue an error if the
duke@1 1672 * symbol of the type referred to has a LOCKED flag set.
duke@1 1673 *
duke@1 1674 * @param pos Position to be used for error reporting.
duke@1 1675 * @param t The type referred to.
duke@1 1676 */
duke@1 1677 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 1678 checkNonCyclicInternal(pos, t);
duke@1 1679 }
duke@1 1680
duke@1 1681
duke@1 1682 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 1683 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 1684 }
duke@1 1685
mcimadamore@236 1686 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 1687 final TypeVar tv;
mcimadamore@42 1688 if (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 1689 return;
duke@1 1690 if (seen.contains(t)) {
duke@1 1691 tv = (TypeVar)t;
jjg@110 1692 tv.bound = types.createErrorType(t);
duke@1 1693 log.error(pos, "cyclic.inheritance", t);
duke@1 1694 } else if (t.tag == TYPEVAR) {
duke@1 1695 tv = (TypeVar)t;
mcimadamore@236 1696 seen = seen.prepend(tv);
duke@1 1697 for (Type b : types.getBounds(tv))
duke@1 1698 checkNonCyclic1(pos, b, seen);
duke@1 1699 }
duke@1 1700 }
duke@1 1701
duke@1 1702 /** Check for cyclic references. Issue an error if the
duke@1 1703 * symbol of the type referred to has a LOCKED flag set.
duke@1 1704 *
duke@1 1705 * @param pos Position to be used for error reporting.
duke@1 1706 * @param t The type referred to.
duke@1 1707 * @returns True if the check completed on all attributed classes
duke@1 1708 */
duke@1 1709 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 1710 boolean complete = true; // was the check complete?
duke@1 1711 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 1712 Symbol c = t.tsym;
duke@1 1713 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 1714
duke@1 1715 if ((c.flags_field & LOCKED) != 0) {
duke@1 1716 noteCyclic(pos, (ClassSymbol)c);
duke@1 1717 } else if (!c.type.isErroneous()) {
duke@1 1718 try {
duke@1 1719 c.flags_field |= LOCKED;
duke@1 1720 if (c.type.tag == CLASS) {
duke@1 1721 ClassType clazz = (ClassType)c.type;
duke@1 1722 if (clazz.interfaces_field != null)
duke@1 1723 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 1724 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 1725 if (clazz.supertype_field != null) {
duke@1 1726 Type st = clazz.supertype_field;
duke@1 1727 if (st != null && st.tag == CLASS)
duke@1 1728 complete &= checkNonCyclicInternal(pos, st);
duke@1 1729 }
duke@1 1730 if (c.owner.kind == TYP)
duke@1 1731 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 1732 }
duke@1 1733 } finally {
duke@1 1734 c.flags_field &= ~LOCKED;
duke@1 1735 }
duke@1 1736 }
duke@1 1737 if (complete)
duke@1 1738 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 1739 if (complete) c.flags_field |= ACYCLIC;
duke@1 1740 return complete;
duke@1 1741 }
duke@1 1742
duke@1 1743 /** Note that we found an inheritance cycle. */
duke@1 1744 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1745 log.error(pos, "cyclic.inheritance", c);
duke@1 1746 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 1747 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 1748 Type st = types.supertype(c.type);
duke@1 1749 if (st.tag == CLASS)
jjg@110 1750 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 1751 c.type = types.createErrorType(c, c.type);
duke@1 1752 c.flags_field |= ACYCLIC;
duke@1 1753 }
duke@1 1754
duke@1 1755 /** Check that all methods which implement some
duke@1 1756 * method conform to the method they implement.
duke@1 1757 * @param tree The class definition whose members are checked.
duke@1 1758 */
duke@1 1759 void checkImplementations(JCClassDecl tree) {
duke@1 1760 checkImplementations(tree, tree.sym);
duke@1 1761 }
duke@1 1762 //where
duke@1 1763 /** Check that all methods which implement some
duke@1 1764 * method in `ic' conform to the method they implement.
duke@1 1765 */
duke@1 1766 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
duke@1 1767 ClassSymbol origin = tree.sym;
duke@1 1768 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 1769 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 1770 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 1771 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 1772 if (e.sym.kind == MTH &&
duke@1 1773 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 1774 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 1775 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 1776 if (implmeth != null && implmeth != absmeth &&
duke@1 1777 (implmeth.owner.flags() & INTERFACE) ==
duke@1 1778 (origin.flags() & INTERFACE)) {
duke@1 1779 // don't check if implmeth is in a class, yet
duke@1 1780 // origin is an interface. This case arises only
duke@1 1781 // if implmeth is declared in Object. The reason is
duke@1 1782 // that interfaces really don't inherit from
duke@1 1783 // Object it's just that the compiler represents
duke@1 1784 // things that way.
duke@1 1785 checkOverride(tree, implmeth, absmeth, origin);
duke@1 1786 }
duke@1 1787 }
duke@1 1788 }
duke@1 1789 }
duke@1 1790 }
duke@1 1791 }
duke@1 1792
duke@1 1793 /** Check that all abstract methods implemented by a class are
duke@1 1794 * mutually compatible.
duke@1 1795 * @param pos Position to be used for error reporting.
duke@1 1796 * @param c The class whose interfaces are checked.
duke@1 1797 */
duke@1 1798 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 1799 List<Type> supertypes = types.interfaces(c);
duke@1 1800 Type supertype = types.supertype(c);
duke@1 1801 if (supertype.tag == CLASS &&
duke@1 1802 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 1803 supertypes = supertypes.prepend(supertype);
duke@1 1804 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 1805 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 1806 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 1807 return;
duke@1 1808 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 1809 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 1810 return;
duke@1 1811 }
duke@1 1812 checkCompatibleConcretes(pos, c);
duke@1 1813 }
duke@1 1814
mcimadamore@359 1815 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 1816 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 1817 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 1818 // VM allows methods and variables with differing types
mcimadamore@359 1819 if (sym.kind == e.sym.kind &&
mcimadamore@359 1820 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 1821 sym != e.sym &&
mcimadamore@359 1822 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@359 1823 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 1824 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 1825 return;
mcimadamore@359 1826 }
mcimadamore@359 1827 }
mcimadamore@359 1828 }
mcimadamore@359 1829 }
mcimadamore@359 1830
mcimadamore@359 1831 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 1832 */
mcimadamore@359 1833 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 1834 if (!sym.type.isErroneous()) {
mcimadamore@359 1835 if (warnOnSyntheticConflicts) {
mcimadamore@359 1836 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 1837 }
mcimadamore@359 1838 else {
mcimadamore@359 1839 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 1840 }
mcimadamore@359 1841 }
mcimadamore@359 1842 }
mcimadamore@359 1843
duke@1 1844 /** Check that class c does not implement directly or indirectly
duke@1 1845 * the same parameterized interface with two different argument lists.
duke@1 1846 * @param pos Position to be used for error reporting.
duke@1 1847 * @param type The type whose interfaces are checked.
duke@1 1848 */
duke@1 1849 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 1850 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 1851 }
duke@1 1852 //where
duke@1 1853 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 1854 * with their class symbol as key and their type as value. Make
duke@1 1855 * sure no class is entered with two different types.
duke@1 1856 */
duke@1 1857 void checkClassBounds(DiagnosticPosition pos,
duke@1 1858 Map<TypeSymbol,Type> seensofar,
duke@1 1859 Type type) {
duke@1 1860 if (type.isErroneous()) return;
duke@1 1861 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 1862 Type it = l.head;
duke@1 1863 Type oldit = seensofar.put(it.tsym, it);
duke@1 1864 if (oldit != null) {
duke@1 1865 List<Type> oldparams = oldit.allparams();
duke@1 1866 List<Type> newparams = it.allparams();
duke@1 1867 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 1868 log.error(pos, "cant.inherit.diff.arg",
duke@1 1869 it.tsym, Type.toString(oldparams),
duke@1 1870 Type.toString(newparams));
duke@1 1871 }
duke@1 1872 checkClassBounds(pos, seensofar, it);
duke@1 1873 }
duke@1 1874 Type st = types.supertype(type);
duke@1 1875 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 1876 }
duke@1 1877
duke@1 1878 /** Enter interface into into set.
duke@1 1879 * If it existed already, issue a "repeated interface" error.
duke@1 1880 */
duke@1 1881 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 1882 if (its.contains(it))
duke@1 1883 log.error(pos, "repeated.interface");
duke@1 1884 else {
duke@1 1885 its.add(it);
duke@1 1886 }
duke@1 1887 }
duke@1 1888
duke@1 1889 /* *************************************************************************
duke@1 1890 * Check annotations
duke@1 1891 **************************************************************************/
duke@1 1892
duke@1 1893 /** Annotation types are restricted to primitives, String, an
duke@1 1894 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 1895 * Anything>, arrays of the preceding.
duke@1 1896 */
duke@1 1897 void validateAnnotationType(JCTree restype) {
duke@1 1898 // restype may be null if an error occurred, so don't bother validating it
duke@1 1899 if (restype != null) {
duke@1 1900 validateAnnotationType(restype.pos(), restype.type);
duke@1 1901 }
duke@1 1902 }
duke@1 1903
duke@1 1904 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 1905 if (type.isPrimitive()) return;
duke@1 1906 if (types.isSameType(type, syms.stringType)) return;
duke@1 1907 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 1908 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 1909 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 1910 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 1911 validateAnnotationType(pos, types.elemtype(type));
duke@1 1912 return;
duke@1 1913 }
duke@1 1914 log.error(pos, "invalid.annotation.member.type");
duke@1 1915 }
duke@1 1916
duke@1 1917 /**
duke@1 1918 * "It is also a compile-time error if any method declared in an
duke@1 1919 * annotation type has a signature that is override-equivalent to
duke@1 1920 * that of any public or protected method declared in class Object
duke@1 1921 * or in the interface annotation.Annotation."
duke@1 1922 *
duke@1 1923 * @jls3 9.6 Annotation Types
duke@1 1924 */
duke@1 1925 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
duke@1 1926 for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
duke@1 1927 Scope s = sup.tsym.members();
duke@1 1928 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 1929 if (e.sym.kind == MTH &&
duke@1 1930 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 1931 types.overrideEquivalent(m.type, e.sym.type))
duke@1 1932 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 1933 }
duke@1 1934 }
duke@1 1935 }
duke@1 1936
duke@1 1937 /** Check the annotations of a symbol.
duke@1 1938 */
duke@1 1939 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 1940 if (skipAnnotations) return;
duke@1 1941 for (JCAnnotation a : annotations)
duke@1 1942 validateAnnotation(a, s);
duke@1 1943 }
duke@1 1944
jjg@308 1945 /** Check the type annotations
jjg@308 1946 */
jjg@308 1947 public void validateTypeAnnotations(List<JCTypeAnnotation> annotations, boolean isTypeParameter) {
jjg@308 1948 if (skipAnnotations) return;
jjg@308 1949 for (JCTypeAnnotation a : annotations)
jjg@308 1950 validateTypeAnnotation(a, isTypeParameter);
jjg@308 1951 }
jjg@308 1952
duke@1 1953 /** Check an annotation of a symbol.
duke@1 1954 */
duke@1 1955 public void validateAnnotation(JCAnnotation a, Symbol s) {
duke@1 1956 validateAnnotation(a);
duke@1 1957
duke@1 1958 if (!annotationApplicable(a, s))
duke@1 1959 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 1960
duke@1 1961 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 1962 if (!isOverrider(s))
duke@1 1963 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 1964 }
duke@1 1965 }
duke@1 1966
jjg@308 1967 public void validateTypeAnnotation(JCTypeAnnotation a, boolean isTypeParameter) {
jjg@308 1968 if (a.type == null)
jjg@308 1969 throw new AssertionError("annotation tree hasn't been attributed yet: " + a);
jjg@308 1970 validateAnnotation(a);
jjg@308 1971
jjg@308 1972 if (!isTypeAnnotation(a, isTypeParameter))
jjg@308 1973 log.error(a.pos(), "annotation.type.not.applicable");
jjg@308 1974 }
jjg@308 1975
duke@1 1976 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 1977 boolean isOverrider(Symbol s) {
duke@1 1978 if (s.kind != MTH || s.isStatic())
duke@1 1979 return false;
duke@1 1980 MethodSymbol m = (MethodSymbol)s;
duke@1 1981 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 1982 for (Type sup : types.closure(owner.type)) {
duke@1 1983 if (sup == owner.type)
duke@1 1984 continue; // skip "this"
duke@1 1985 Scope scope = sup.tsym.members();
duke@1 1986 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 1987 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 1988 return true;
duke@1 1989 }
duke@1 1990 }
duke@1 1991 return false;
duke@1 1992 }
duke@1 1993
jjg@308 1994 /** Is the annotation applicable to type annotations */
jjg@308 1995 boolean isTypeAnnotation(JCTypeAnnotation a, boolean isTypeParameter) {
jjg@308 1996 Attribute.Compound atTarget =
jjg@308 1997 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
jjg@308 1998 if (atTarget == null) return true;
jjg@308 1999 Attribute atValue = atTarget.member(names.value);
jjg@308 2000 if (!(atValue instanceof Attribute.Array)) return true; // error recovery
jjg@308 2001 Attribute.Array arr = (Attribute.Array) atValue;
jjg@308 2002 for (Attribute app : arr.values) {
jjg@308 2003 if (!(app instanceof Attribute.Enum)) return true; // recovery
jjg@308 2004 Attribute.Enum e = (Attribute.Enum) app;
jjg@308 2005 if (!isTypeParameter && e.value.name == names.TYPE_USE)
jjg@308 2006 return true;
jjg@308 2007 else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER)
jjg@308 2008 return true;
jjg@308 2009 }
jjg@308 2010 return false;
jjg@308 2011 }
jjg@308 2012
duke@1 2013 /** Is the annotation applicable to the symbol? */
duke@1 2014 boolean annotationApplicable(JCAnnotation a, Symbol s) {
duke@1 2015 Attribute.Compound atTarget =
duke@1 2016 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
duke@1 2017 if (atTarget == null) return true;
duke@1 2018 Attribute atValue = atTarget.member(names.value);
duke@1 2019 if (!(atValue instanceof Attribute.Array)) return true; // error recovery
duke@1 2020 Attribute.Array arr = (Attribute.Array) atValue;
duke@1 2021 for (Attribute app : arr.values) {
duke@1 2022 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2023 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2024 if (e.value.name == names.TYPE)
duke@1 2025 { if (s.kind == TYP) return true; }
duke@1 2026 else if (e.value.name == names.FIELD)
duke@1 2027 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2028 else if (e.value.name == names.METHOD)
duke@1 2029 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2030 else if (e.value.name == names.PARAMETER)
duke@1 2031 { if (s.kind == VAR &&
duke@1 2032 s.owner.kind == MTH &&
duke@1 2033 (s.flags() & PARAMETER) != 0)
duke@1 2034 return true;
duke@1 2035 }
duke@1 2036 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2037 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2038 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2039 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2040 (s.flags() & PARAMETER) == 0)
duke@1 2041 return true;
duke@1 2042 }
duke@1 2043 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2044 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2045 return true;
duke@1 2046 }
duke@1 2047 else if (e.value.name == names.PACKAGE)
duke@1 2048 { if (s.kind == PCK) return true; }
jjg@308 2049 else if (e.value.name == names.TYPE_USE)
jjg@308 2050 { if (s.kind == TYP ||
jjg@308 2051 s.kind == VAR ||
jjg@308 2052 (s.kind == MTH && !s.isConstructor() &&
jjg@308 2053 s.type.getReturnType().tag != VOID))
jjg@308 2054 return true;
jjg@308 2055 }
duke@1 2056 else
duke@1 2057 return true; // recovery
duke@1 2058 }
duke@1 2059 return false;
duke@1 2060 }
duke@1 2061
duke@1 2062 /** Check an annotation value.
duke@1 2063 */
duke@1 2064 public void validateAnnotation(JCAnnotation a) {
duke@1 2065 if (a.type.isErroneous()) return;
duke@1 2066
duke@1 2067 // collect an inventory of the members
duke@1 2068 Set<MethodSymbol> members = new HashSet<MethodSymbol>();
duke@1 2069 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2070 e != null;
duke@1 2071 e = e.sibling)
duke@1 2072 if (e.sym.kind == MTH)
duke@1 2073 members.add((MethodSymbol) e.sym);
duke@1 2074
duke@1 2075 // count them off as they're annotated
duke@1 2076 for (JCTree arg : a.args) {
duke@1 2077 if (arg.getTag() != JCTree.ASSIGN) continue; // recovery
duke@1 2078 JCAssign assign = (JCAssign) arg;
duke@1 2079 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2080 if (m == null || m.type.isErroneous()) continue;
duke@1 2081 if (!members.remove(m))
jjg@479 2082 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2083 m.name, a.type);
duke@1 2084 if (assign.rhs.getTag() == ANNOTATION)
duke@1 2085 validateAnnotation((JCAnnotation)assign.rhs);
duke@1 2086 }
duke@1 2087
duke@1 2088 // all the remaining ones better have default values
duke@1 2089 for (MethodSymbol m : members)
duke@1 2090 if (m.defaultValue == null && !m.type.isErroneous())
duke@1 2091 log.error(a.pos(), "annotation.missing.default.value",
duke@1 2092 a.type, m.name);
duke@1 2093
duke@1 2094 // special case: java.lang.annotation.Target must not have
duke@1 2095 // repeated values in its value member
duke@1 2096 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2097 a.args.tail == null)
duke@1 2098 return;
duke@1 2099
duke@1 2100 if (a.args.head.getTag() != JCTree.ASSIGN) return; // error recovery
duke@1 2101 JCAssign assign = (JCAssign) a.args.head;
duke@1 2102 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2103 if (m.name != names.value) return;
duke@1 2104 JCTree rhs = assign.rhs;
duke@1 2105 if (rhs.getTag() != JCTree.NEWARRAY) return;
duke@1 2106 JCNewArray na = (JCNewArray) rhs;
duke@1 2107 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2108 for (JCTree elem : na.elems) {
duke@1 2109 if (!targets.add(TreeInfo.symbol(elem))) {
duke@1 2110 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2111 }
duke@1 2112 }
duke@1 2113 }
duke@1 2114
duke@1 2115 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 2116 if (allowAnnotations &&
duke@1 2117 lint.isEnabled(Lint.LintCategory.DEP_ANN) &&
duke@1 2118 (s.flags() & DEPRECATED) != 0 &&
duke@1 2119 !syms.deprecatedType.isErroneous() &&
duke@1 2120 s.attribute(syms.deprecatedType.tsym) == null) {
duke@1 2121 log.warning(pos, "missing.deprecated.annotation");
duke@1 2122 }
duke@1 2123 }
duke@1 2124
duke@1 2125 /* *************************************************************************
duke@1 2126 * Check for recursive annotation elements.
duke@1 2127 **************************************************************************/
duke@1 2128
duke@1 2129 /** Check for cycles in the graph of annotation elements.
duke@1 2130 */
duke@1 2131 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 2132 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
duke@1 2133 assert (tree.sym.flags_field & LOCKED) == 0;
duke@1 2134 try {
duke@1 2135 tree.sym.flags_field |= LOCKED;
duke@1 2136 for (JCTree def : tree.defs) {
duke@1 2137 if (def.getTag() != JCTree.METHODDEF) continue;
duke@1 2138 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 2139 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 2140 }
duke@1 2141 } finally {
duke@1 2142 tree.sym.flags_field &= ~LOCKED;
duke@1 2143 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 2144 }
duke@1 2145 }
duke@1 2146
duke@1 2147 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 2148 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 2149 return;
duke@1 2150 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 2151 log.error(pos, "cyclic.annotation.element");
duke@1 2152 return;
duke@1 2153 }
duke@1 2154 try {
duke@1 2155 tsym.flags_field |= LOCKED;
duke@1 2156 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 2157 Symbol s = e.sym;
duke@1 2158 if (s.kind != Kinds.MTH)
duke@1 2159 continue;
duke@1 2160 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 2161 }
duke@1 2162 } finally {
duke@1 2163 tsym.flags_field &= ~LOCKED;
duke@1 2164 tsym.flags_field |= ACYCLIC_ANN;
duke@1 2165 }
duke@1 2166 }
duke@1 2167
duke@1 2168 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
duke@1 2169 switch (type.tag) {
duke@1 2170 case TypeTags.CLASS:
duke@1 2171 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 2172 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 2173 break;
duke@1 2174 case TypeTags.ARRAY:
duke@1 2175 checkAnnotationResType(pos, types.elemtype(type));
duke@1 2176 break;
duke@1 2177 default:
duke@1 2178 break; // int etc
duke@1 2179 }
duke@1 2180 }
duke@1 2181
duke@1 2182 /* *************************************************************************
duke@1 2183 * Check for cycles in the constructor call graph.
duke@1 2184 **************************************************************************/
duke@1 2185
duke@1 2186 /** Check for cycles in the graph of constructors calling other
duke@1 2187 * constructors.
duke@1 2188 */
duke@1 2189 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 2190 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 2191
duke@1 2192 // enter each constructor this-call into the map
duke@1 2193 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 2194 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 2195 if (app == null) continue;
duke@1 2196 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 2197 if (TreeInfo.name(app.meth) == names._this) {
duke@1 2198 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 2199 } else {
duke@1 2200 meth.sym.flags_field |= ACYCLIC;
duke@1 2201 }
duke@1 2202 }
duke@1 2203
duke@1 2204 // Check for cycles in the map
duke@1 2205 Symbol[] ctors = new Symbol[0];
duke@1 2206 ctors = callMap.keySet().toArray(ctors);
duke@1 2207 for (Symbol caller : ctors) {
duke@1 2208 checkCyclicConstructor(tree, caller, callMap);
duke@1 2209 }
duke@1 2210 }
duke@1 2211
duke@1 2212 /** Look in the map to see if the given constructor is part of a
duke@1 2213 * call cycle.
duke@1 2214 */
duke@1 2215 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 2216 Map<Symbol,Symbol> callMap) {
duke@1 2217 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 2218 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 2219 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 2220 "recursive.ctor.invocation");
duke@1 2221 } else {
duke@1 2222 ctor.flags_field |= LOCKED;
duke@1 2223 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 2224 ctor.flags_field &= ~LOCKED;
duke@1 2225 }
duke@1 2226 ctor.flags_field |= ACYCLIC;
duke@1 2227 }
duke@1 2228 }
duke@1 2229
duke@1 2230 /* *************************************************************************
duke@1 2231 * Miscellaneous
duke@1 2232 **************************************************************************/
duke@1 2233
duke@1 2234 /**
duke@1 2235 * Return the opcode of the operator but emit an error if it is an
duke@1 2236 * error.
duke@1 2237 * @param pos position for error reporting.
duke@1 2238 * @param operator an operator
duke@1 2239 * @param tag a tree tag
duke@1 2240 * @param left type of left hand side
duke@1 2241 * @param right type of right hand side
duke@1 2242 */
duke@1 2243 int checkOperator(DiagnosticPosition pos,
duke@1 2244 OperatorSymbol operator,
duke@1 2245 int tag,
duke@1 2246 Type left,
duke@1 2247 Type right) {
duke@1 2248 if (operator.opcode == ByteCodes.error) {
duke@1 2249 log.error(pos,
duke@1 2250 "operator.cant.be.applied",
duke@1 2251 treeinfo.operatorName(tag),
mcimadamore@80 2252 List.of(left, right));
duke@1 2253 }
duke@1 2254 return operator.opcode;
duke@1 2255 }
duke@1 2256
duke@1 2257
duke@1 2258 /**
duke@1 2259 * Check for division by integer constant zero
duke@1 2260 * @param pos Position for error reporting.
duke@1 2261 * @param operator The operator for the expression
duke@1 2262 * @param operand The right hand operand for the expression
duke@1 2263 */
duke@1 2264 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 2265 if (operand.constValue() != null
duke@1 2266 && lint.isEnabled(Lint.LintCategory.DIVZERO)
duke@1 2267 && operand.tag <= LONG
duke@1 2268 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 2269 int opc = ((OperatorSymbol)operator).opcode;
duke@1 2270 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 2271 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
duke@1 2272 log.warning(pos, "div.zero");
duke@1 2273 }
duke@1 2274 }
duke@1 2275 }
duke@1 2276
duke@1 2277 /**
duke@1 2278 * Check for empty statements after if
duke@1 2279 */
duke@1 2280 void checkEmptyIf(JCIf tree) {
duke@1 2281 if (tree.thenpart.getTag() == JCTree.SKIP && tree.elsepart == null && lint.isEnabled(Lint.LintCategory.EMPTY))
duke@1 2282 log.warning(tree.thenpart.pos(), "empty.if");
duke@1 2283 }
duke@1 2284
duke@1 2285 /** Check that symbol is unique in given scope.
duke@1 2286 * @param pos Position for error reporting.
duke@1 2287 * @param sym The symbol.
duke@1 2288 * @param s The scope.
duke@1 2289 */
duke@1 2290 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2291 if (sym.type.isErroneous())
duke@1 2292 return true;
duke@1 2293 if (sym.owner.name == names.any) return false;
duke@1 2294 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 2295 if (sym != e.sym &&
duke@1 2296 sym.kind == e.sym.kind &&
duke@1 2297 sym.name != names.error &&
mcimadamore@252 2298 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
duke@1 2299 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS))
duke@1 2300 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@252 2301 else if (sym.kind == MTH && !types.overrideEquivalent(sym.type, e.sym.type))
mcimadamore@252 2302 duplicateErasureError(pos, sym, e.sym);
duke@1 2303 else
duke@1 2304 duplicateError(pos, e.sym);
duke@1 2305 return false;
duke@1 2306 }
duke@1 2307 }
duke@1 2308 return true;
duke@1 2309 }
mcimadamore@252 2310 //where
mcimadamore@252 2311 /** Report duplicate declaration error.
mcimadamore@252 2312 */
mcimadamore@252 2313 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@252 2314 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@252 2315 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@252 2316 }
mcimadamore@252 2317 }
duke@1 2318
duke@1 2319 /** Check that single-type import is not already imported or top-level defined,
duke@1 2320 * but make an exception for two single-type imports which denote the same type.
duke@1 2321 * @param pos Position for error reporting.
duke@1 2322 * @param sym The symbol.
duke@1 2323 * @param s The scope
duke@1 2324 */
duke@1 2325 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2326 return checkUniqueImport(pos, sym, s, false);
duke@1 2327 }
duke@1 2328
duke@1 2329 /** Check that static single-type import is not already imported or top-level defined,
duke@1 2330 * but make an exception for two single-type imports which denote the same type.
duke@1 2331 * @param pos Position for error reporting.
duke@1 2332 * @param sym The symbol.
duke@1 2333 * @param s The scope
duke@1 2334 * @param staticImport Whether or not this was a static import
duke@1 2335 */
duke@1 2336 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2337 return checkUniqueImport(pos, sym, s, true);
duke@1 2338 }
duke@1 2339
duke@1 2340 /** Check that single-type import is not already imported or top-level defined,
duke@1 2341 * but make an exception for two single-type imports which denote the same type.
duke@1 2342 * @param pos Position for error reporting.
duke@1 2343 * @param sym The symbol.
duke@1 2344 * @param s The scope.
duke@1 2345 * @param staticImport Whether or not this was a static import
duke@1 2346 */
duke@1 2347 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 2348 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 2349 // is encountered class entered via a class declaration?
duke@1 2350 boolean isClassDecl = e.scope == s;
duke@1 2351 if ((isClassDecl || sym != e.sym) &&
duke@1 2352 sym.kind == e.sym.kind &&
duke@1 2353 sym.name != names.error) {
duke@1 2354 if (!e.sym.type.isErroneous()) {
duke@1 2355 String what = e.sym.toString();
duke@1 2356 if (!isClassDecl) {
duke@1 2357 if (staticImport)
duke@1 2358 log.error(pos, "already.defined.static.single.import", what);
duke@1 2359 else
duke@1 2360 log.error(pos, "already.defined.single.import", what);
duke@1 2361 }
duke@1 2362 else if (sym != e.sym)
duke@1 2363 log.error(pos, "already.defined.this.unit", what);
duke@1 2364 }
duke@1 2365 return false;
duke@1 2366 }
duke@1 2367 }
duke@1 2368 return true;
duke@1 2369 }
duke@1 2370
duke@1 2371 /** Check that a qualified name is in canonical form (for import decls).
duke@1 2372 */
duke@1 2373 public void checkCanonical(JCTree tree) {
duke@1 2374 if (!isCanonical(tree))
duke@1 2375 log.error(tree.pos(), "import.requires.canonical",
duke@1 2376 TreeInfo.symbol(tree));
duke@1 2377 }
duke@1 2378 // where
duke@1 2379 private boolean isCanonical(JCTree tree) {
duke@1 2380 while (tree.getTag() == JCTree.SELECT) {
duke@1 2381 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 2382 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 2383 return false;
duke@1 2384 tree = s.selected;
duke@1 2385 }
duke@1 2386 return true;
duke@1 2387 }
duke@1 2388
duke@1 2389 private class ConversionWarner extends Warner {
duke@1 2390 final String key;
duke@1 2391 final Type found;
duke@1 2392 final Type expected;
duke@1 2393 public ConversionWarner(DiagnosticPosition pos, String key, Type found, Type expected) {
duke@1 2394 super(pos);
duke@1 2395 this.key = key;
duke@1 2396 this.found = found;
duke@1 2397 this.expected = expected;
duke@1 2398 }
duke@1 2399
jjg@398 2400 @Override
duke@1 2401 public void warnUnchecked() {
duke@1 2402 boolean warned = this.warned;
duke@1 2403 super.warnUnchecked();
duke@1 2404 if (warned) return; // suppress redundant diagnostics
mcimadamore@89 2405 Object problem = diags.fragment(key);
duke@1 2406 Check.this.warnUnchecked(pos(), "prob.found.req", problem, found, expected);
duke@1 2407 }
duke@1 2408 }
duke@1 2409
duke@1 2410 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2411 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 2412 }
duke@1 2413
duke@1 2414 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2415 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 2416 }
duke@1 2417 }

mercurial