src/share/classes/com/sun/tools/javac/comp/Check.java

Tue, 15 Oct 2013 15:57:13 -0700

author
jjg
date
Tue, 15 Oct 2013 15:57:13 -0700
changeset 2134
b0c086cd4520
parent 2118
d8d6b58f1ebf
child 2157
963c57175e40
permissions
-rw-r--r--

8026564: import changes from type-annotations forest
Reviewed-by: jjg
Contributed-by: wdietl@gmail.com, steve.sides@oracle.com

duke@1 1 /*
jjg@1492 2 * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
jjg@1521 29
ohrstrom@1384 30 import javax.tools.JavaFileManager;
duke@1 31
duke@1 32 import com.sun.tools.javac.code.*;
jlahoda@2111 33 import com.sun.tools.javac.code.Attribute.Compound;
duke@1 34 import com.sun.tools.javac.jvm.*;
duke@1 35 import com.sun.tools.javac.tree.*;
duke@1 36 import com.sun.tools.javac.util.*;
duke@1 37 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 38 import com.sun.tools.javac.util.List;
duke@1 39
duke@1 40 import com.sun.tools.javac.code.Lint;
duke@1 41 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 42 import com.sun.tools.javac.code.Type.*;
duke@1 43 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 44 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 45 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1550 46 import com.sun.tools.javac.comp.Infer.FreeTypeListener;
mcimadamore@1510 47 import com.sun.tools.javac.tree.JCTree.*;
mcimadamore@1510 48 import com.sun.tools.javac.tree.JCTree.JCPolyExpression.*;
duke@1 49
duke@1 50 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 51 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 52 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 53 import static com.sun.tools.javac.code.Kinds.*;
jjg@1374 54 import static com.sun.tools.javac.code.TypeTag.*;
jjg@1374 55 import static com.sun.tools.javac.code.TypeTag.WILDCARD;
duke@1 56
jjg@1127 57 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 58
duke@1 59 /** Type checking helper class for the attribution phase.
duke@1 60 *
jjg@581 61 * <p><b>This is NOT part of any supported API.
jjg@581 62 * If you write code that depends on this, you do so at your own risk.
duke@1 63 * This code and its internal interfaces are subject to change or
duke@1 64 * deletion without notice.</b>
duke@1 65 */
duke@1 66 public class Check {
duke@1 67 protected static final Context.Key<Check> checkKey =
duke@1 68 new Context.Key<Check>();
duke@1 69
jjg@113 70 private final Names names;
duke@1 71 private final Log log;
mcimadamore@1219 72 private final Resolve rs;
duke@1 73 private final Symtab syms;
mcimadamore@690 74 private final Enter enter;
mcimadamore@1347 75 private final DeferredAttr deferredAttr;
duke@1 76 private final Infer infer;
duke@1 77 private final Types types;
mcimadamore@89 78 private final JCDiagnostic.Factory diags;
mcimadamore@359 79 private boolean warnOnSyntheticConflicts;
jjg@576 80 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 81 private boolean enableSunApiLintControl;
duke@1 82 private final TreeInfo treeinfo;
ohrstrom@1384 83 private final JavaFileManager fileManager;
jjg@1569 84 private final Profile profile;
duke@1 85
duke@1 86 // The set of lint options currently in effect. It is initialized
duke@1 87 // from the context, and then is set/reset as needed by Attr as it
duke@1 88 // visits all the various parts of the trees during attribution.
duke@1 89 private Lint lint;
duke@1 90
mcimadamore@795 91 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 92 // Attr as it visits new method declarations.
mcimadamore@795 93 private MethodSymbol method;
mcimadamore@795 94
duke@1 95 public static Check instance(Context context) {
duke@1 96 Check instance = context.get(checkKey);
duke@1 97 if (instance == null)
duke@1 98 instance = new Check(context);
duke@1 99 return instance;
duke@1 100 }
duke@1 101
duke@1 102 protected Check(Context context) {
duke@1 103 context.put(checkKey, this);
duke@1 104
jjg@113 105 names = Names.instance(context);
jjg@1521 106 dfltTargetMeta = new Name[] { names.PACKAGE, names.TYPE,
jjg@1521 107 names.FIELD, names.METHOD, names.CONSTRUCTOR,
jjg@1521 108 names.ANNOTATION_TYPE, names.LOCAL_VARIABLE, names.PARAMETER};
duke@1 109 log = Log.instance(context);
mcimadamore@1219 110 rs = Resolve.instance(context);
duke@1 111 syms = Symtab.instance(context);
mcimadamore@690 112 enter = Enter.instance(context);
mcimadamore@1347 113 deferredAttr = DeferredAttr.instance(context);
duke@1 114 infer = Infer.instance(context);
jjg@1569 115 types = Types.instance(context);
mcimadamore@89 116 diags = JCDiagnostic.Factory.instance(context);
duke@1 117 Options options = Options.instance(context);
duke@1 118 lint = Lint.instance(context);
duke@1 119 treeinfo = TreeInfo.instance(context);
ohrstrom@1384 120 fileManager = context.get(JavaFileManager.class);
duke@1 121
duke@1 122 Source source = Source.instance(context);
duke@1 123 allowGenerics = source.allowGenerics();
mcimadamore@1219 124 allowVarargs = source.allowVarargs();
duke@1 125 allowAnnotations = source.allowAnnotations();
jjg@398 126 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 127 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
mcimadamore@1393 128 allowDefaultMethods = source.allowDefaultMethods();
mcimadamore@1415 129 allowStrictMethodClashCheck = source.allowStrictMethodClashCheck();
jjg@1157 130 complexInference = options.isSet("complexinference");
jjg@700 131 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 132 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 133 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 134
jjg@398 135 Target target = Target.instance(context);
jjg@398 136 syntheticNameChar = target.syntheticNameChar();
jjg@398 137
jjg@1569 138 profile = Profile.instance(context);
jjg@1569 139
duke@1 140 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 141 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 142 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 143 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 144
jjg@60 145 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 146 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 147 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 148 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 149 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 150 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 151
jlahoda@2028 152 deferredLintHandler = DeferredLintHandler.instance(context);
duke@1 153 }
duke@1 154
duke@1 155 /** Switch: generics enabled?
duke@1 156 */
duke@1 157 boolean allowGenerics;
duke@1 158
mcimadamore@1219 159 /** Switch: varargs enabled?
mcimadamore@1219 160 */
mcimadamore@1219 161 boolean allowVarargs;
mcimadamore@1219 162
duke@1 163 /** Switch: annotations enabled?
duke@1 164 */
duke@1 165 boolean allowAnnotations;
duke@1 166
jjg@398 167 /** Switch: covariant returns enabled?
jjg@398 168 */
jjg@398 169 boolean allowCovariantReturns;
jjg@398 170
mcimadamore@795 171 /** Switch: simplified varargs enabled?
mcimadamore@795 172 */
mcimadamore@795 173 boolean allowSimplifiedVarargs;
mcimadamore@795 174
mcimadamore@1393 175 /** Switch: default methods enabled?
mcimadamore@1393 176 */
mcimadamore@1393 177 boolean allowDefaultMethods;
mcimadamore@1393 178
mcimadamore@1393 179 /** Switch: should unrelated return types trigger a method clash?
mcimadamore@1393 180 */
mcimadamore@1393 181 boolean allowStrictMethodClashCheck;
mcimadamore@1393 182
duke@1 183 /** Switch: -complexinference option set?
duke@1 184 */
duke@1 185 boolean complexInference;
duke@1 186
jjg@398 187 /** Character for synthetic names
jjg@398 188 */
jjg@398 189 char syntheticNameChar;
jjg@398 190
duke@1 191 /** A table mapping flat names of all compiled classes in this run to their
duke@1 192 * symbols; maintained from outside.
duke@1 193 */
duke@1 194 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 195
duke@1 196 /** A handler for messages about deprecated usage.
duke@1 197 */
duke@1 198 private MandatoryWarningHandler deprecationHandler;
duke@1 199
duke@1 200 /** A handler for messages about unchecked or unsafe usage.
duke@1 201 */
duke@1 202 private MandatoryWarningHandler uncheckedHandler;
duke@1 203
jjg@582 204 /** A handler for messages about using proprietary API.
jjg@377 205 */
jjg@377 206 private MandatoryWarningHandler sunApiHandler;
duke@1 207
mcimadamore@852 208 /** A handler for deferred lint warnings.
mcimadamore@852 209 */
mcimadamore@852 210 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 211
duke@1 212 /* *************************************************************************
duke@1 213 * Errors and Warnings
duke@1 214 **************************************************************************/
duke@1 215
duke@1 216 Lint setLint(Lint newLint) {
duke@1 217 Lint prev = lint;
duke@1 218 lint = newLint;
duke@1 219 return prev;
duke@1 220 }
duke@1 221
mcimadamore@795 222 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 223 MethodSymbol prev = method;
mcimadamore@795 224 method = newMethod;
mcimadamore@795 225 return prev;
mcimadamore@795 226 }
mcimadamore@795 227
duke@1 228 /** Warn about deprecated symbol.
duke@1 229 * @param pos Position to be used for error reporting.
duke@1 230 * @param sym The deprecated symbol.
duke@1 231 */
duke@1 232 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 233 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 234 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 235 }
duke@1 236
duke@1 237 /** Warn about unchecked operation.
duke@1 238 * @param pos Position to be used for error reporting.
duke@1 239 * @param msg A string describing the problem.
duke@1 240 */
duke@1 241 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 242 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 243 uncheckedHandler.report(pos, msg, args);
duke@1 244 }
duke@1 245
mcimadamore@580 246 /** Warn about unsafe vararg method decl.
mcimadamore@580 247 * @param pos Position to be used for error reporting.
mcimadamore@580 248 */
mcimadamore@795 249 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 250 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 251 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 252 }
mcimadamore@580 253
jjg@582 254 /** Warn about using proprietary API.
jjg@377 255 * @param pos Position to be used for error reporting.
jjg@377 256 * @param msg A string describing the problem.
jjg@377 257 */
jjg@377 258 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 259 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 260 sunApiHandler.report(pos, msg, args);
jjg@377 261 }
jjg@377 262
jjg@505 263 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 264 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 265 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 266 }
jjg@505 267
duke@1 268 /**
duke@1 269 * Report any deferred diagnostics.
duke@1 270 */
duke@1 271 public void reportDeferredDiagnostics() {
duke@1 272 deprecationHandler.reportDeferredDiagnostic();
duke@1 273 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 274 sunApiHandler.reportDeferredDiagnostic();
duke@1 275 }
duke@1 276
duke@1 277
duke@1 278 /** Report a failure to complete a class.
duke@1 279 * @param pos Position to be used for error reporting.
duke@1 280 * @param ex The failure to report.
duke@1 281 */
duke@1 282 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
mcimadamore@1613 283 log.error(JCDiagnostic.DiagnosticFlag.NON_DEFERRABLE, pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 284 if (ex instanceof ClassReader.BadClassFile
jjg@576 285 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 286 else return syms.errType;
duke@1 287 }
duke@1 288
duke@1 289 /** Report an error that wrong type tag was found.
duke@1 290 * @param pos Position to be used for error reporting.
duke@1 291 * @param required An internationalized string describing the type tag
duke@1 292 * required.
duke@1 293 * @param found The type that was found.
duke@1 294 */
duke@1 295 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 296 // this error used to be raised by the parser,
jrose@267 297 // but has been delayed to this point:
jjg@1374 298 if (found instanceof Type && ((Type)found).hasTag(VOID)) {
jrose@267 299 log.error(pos, "illegal.start.of.type");
jrose@267 300 return syms.errType;
jrose@267 301 }
duke@1 302 log.error(pos, "type.found.req", found, required);
jjg@110 303 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 304 }
duke@1 305
duke@1 306 /** Report an error that symbol cannot be referenced before super
duke@1 307 * has been called.
duke@1 308 * @param pos Position to be used for error reporting.
duke@1 309 * @param sym The referenced symbol.
duke@1 310 */
duke@1 311 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 312 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 313 }
duke@1 314
duke@1 315 /** Report duplicate declaration error.
duke@1 316 */
duke@1 317 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 318 if (!sym.type.isErroneous()) {
mcimadamore@1085 319 Symbol location = sym.location();
mcimadamore@1085 320 if (location.kind == MTH &&
mcimadamore@1085 321 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 322 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 323 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 324 sym.location().enclClass());
mcimadamore@1085 325 } else {
mcimadamore@1085 326 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 327 kindName(sym.location()), sym.location());
mcimadamore@1085 328 }
duke@1 329 }
duke@1 330 }
duke@1 331
duke@1 332 /** Report array/varargs duplicate declaration
duke@1 333 */
duke@1 334 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 335 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 336 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 337 }
duke@1 338 }
duke@1 339
duke@1 340 /* ************************************************************************
duke@1 341 * duplicate declaration checking
duke@1 342 *************************************************************************/
duke@1 343
duke@1 344 /** Check that variable does not hide variable with same name in
duke@1 345 * immediately enclosing local scope.
duke@1 346 * @param pos Position for error reporting.
duke@1 347 * @param v The symbol.
duke@1 348 * @param s The scope.
duke@1 349 */
duke@1 350 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 351 if (s.next != null) {
duke@1 352 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 353 e.scope != null && e.sym.owner == v.owner;
duke@1 354 e = e.next()) {
duke@1 355 if (e.sym.kind == VAR &&
duke@1 356 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 357 v.name != names.error) {
duke@1 358 duplicateError(pos, e.sym);
duke@1 359 return;
duke@1 360 }
duke@1 361 }
duke@1 362 }
duke@1 363 }
duke@1 364
duke@1 365 /** Check that a class or interface does not hide a class or
duke@1 366 * interface with same name in immediately enclosing local scope.
duke@1 367 * @param pos Position for error reporting.
duke@1 368 * @param c The symbol.
duke@1 369 * @param s The scope.
duke@1 370 */
duke@1 371 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 372 if (s.next != null) {
duke@1 373 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 374 e.scope != null && e.sym.owner == c.owner;
duke@1 375 e = e.next()) {
jjg@1374 376 if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) &&
duke@1 377 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 378 c.name != names.error) {
duke@1 379 duplicateError(pos, e.sym);
duke@1 380 return;
duke@1 381 }
duke@1 382 }
duke@1 383 }
duke@1 384 }
duke@1 385
duke@1 386 /** Check that class does not have the same name as one of
duke@1 387 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 388 * return true if class is unique in its enclosing scope.
duke@1 389 * @param pos Position for error reporting.
duke@1 390 * @param name The class name.
duke@1 391 * @param s The enclosing scope.
duke@1 392 */
duke@1 393 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 394 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 395 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 396 duplicateError(pos, e.sym);
duke@1 397 return false;
duke@1 398 }
duke@1 399 }
duke@1 400 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 401 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 402 duplicateError(pos, sym);
duke@1 403 return true;
duke@1 404 }
duke@1 405 }
duke@1 406 return true;
duke@1 407 }
duke@1 408
duke@1 409 /* *************************************************************************
duke@1 410 * Class name generation
duke@1 411 **************************************************************************/
duke@1 412
duke@1 413 /** Return name of local class.
jjg@1358 414 * This is of the form {@code <enclClass> $ n <classname> }
duke@1 415 * where
duke@1 416 * enclClass is the flat name of the enclosing class,
duke@1 417 * classname is the simple name of the local class
duke@1 418 */
duke@1 419 Name localClassName(ClassSymbol c) {
duke@1 420 for (int i=1; ; i++) {
duke@1 421 Name flatname = names.
duke@1 422 fromString("" + c.owner.enclClass().flatname +
jjg@398 423 syntheticNameChar + i +
duke@1 424 c.name);
duke@1 425 if (compiled.get(flatname) == null) return flatname;
duke@1 426 }
duke@1 427 }
duke@1 428
duke@1 429 /* *************************************************************************
duke@1 430 * Type Checking
duke@1 431 **************************************************************************/
duke@1 432
mcimadamore@1238 433 /**
mcimadamore@1238 434 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 435 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 436 * vary significantly.
mcimadamore@1238 437 */
mcimadamore@1348 438 public interface CheckContext {
mcimadamore@1238 439 /**
mcimadamore@1238 440 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 441 */
mcimadamore@1238 442 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 443 /**
mcimadamore@1238 444 * Report a check error
mcimadamore@1238 445 */
mcimadamore@1296 446 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 447 /**
mcimadamore@1238 448 * Obtain a warner for this check context
mcimadamore@1238 449 */
mcimadamore@1238 450 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 451
mcimadamore@1337 452 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 453
mcimadamore@1347 454 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1238 455 }
mcimadamore@1238 456
mcimadamore@1238 457 /**
mcimadamore@1238 458 * This class represent a check context that is nested within another check
mcimadamore@1238 459 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 460 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 461 * the forwarding pattern.
mcimadamore@1238 462 */
mcimadamore@1238 463 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 464 CheckContext enclosingContext;
mcimadamore@1238 465
mcimadamore@1238 466 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 467 this.enclosingContext = enclosingContext;
mcimadamore@1238 468 }
mcimadamore@1238 469
mcimadamore@1238 470 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 471 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 472 }
mcimadamore@1238 473
mcimadamore@1296 474 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 475 enclosingContext.report(pos, details);
mcimadamore@1238 476 }
mcimadamore@1238 477
mcimadamore@1238 478 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 479 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 480 }
mcimadamore@1337 481
mcimadamore@1337 482 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 483 return enclosingContext.inferenceContext();
mcimadamore@1337 484 }
mcimadamore@1347 485
mcimadamore@1347 486 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 487 return enclosingContext.deferredAttrContext();
mcimadamore@1347 488 }
mcimadamore@1238 489 }
mcimadamore@1238 490
mcimadamore@1238 491 /**
mcimadamore@1238 492 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 493 */
mcimadamore@1238 494 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 495 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 496 log.error(pos, "prob.found.req", details);
mcimadamore@1238 497 }
mcimadamore@1238 498 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 499 return types.isAssignable(found, req, warn);
mcimadamore@1238 500 }
mcimadamore@1238 501
mcimadamore@1238 502 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 503 return convertWarner(pos, found, req);
mcimadamore@1238 504 }
mcimadamore@1337 505
mcimadamore@1337 506 public InferenceContext inferenceContext() {
mcimadamore@1337 507 return infer.emptyContext;
mcimadamore@1337 508 }
mcimadamore@1347 509
mcimadamore@1347 510 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 511 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 512 }
mcimadamore@1238 513 };
mcimadamore@1238 514
duke@1 515 /** Check that a given type is assignable to a given proto-type.
duke@1 516 * If it is, return the type, otherwise return errType.
duke@1 517 * @param pos Position to be used for error reporting.
duke@1 518 * @param found The type that was found.
duke@1 519 * @param req The type that was required.
duke@1 520 */
duke@1 521 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 522 return checkType(pos, found, req, basicHandler);
darcy@609 523 }
darcy@609 524
mcimadamore@1337 525 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 526 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 527 if (inferenceContext.free(req)) {
mcimadamore@1337 528 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 529 @Override
mcimadamore@1337 530 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1550 531 checkType(pos, found, inferenceContext.asInstType(req), checkContext);
mcimadamore@1337 532 }
mcimadamore@1337 533 });
mcimadamore@1337 534 }
jjg@1374 535 if (req.hasTag(ERROR))
duke@1 536 return req;
jjg@1374 537 if (req.hasTag(NONE))
duke@1 538 return found;
mcimadamore@1238 539 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 540 return found;
mcimadamore@1238 541 } else {
vromero@1826 542 if (found.isNumeric() && req.isNumeric()) {
mcimadamore@1296 543 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 544 return types.createErrorType(found);
mcimadamore@1238 545 }
mcimadamore@1296 546 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 547 return types.createErrorType(found);
duke@1 548 }
duke@1 549 }
duke@1 550
duke@1 551 /** Check that a given type can be cast to a given target type.
duke@1 552 * Return the result of the cast.
duke@1 553 * @param pos Position to be used for error reporting.
duke@1 554 * @param found The type that is being cast.
duke@1 555 * @param req The target type of the cast.
duke@1 556 */
duke@1 557 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 558 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 559 }
mcimadamore@1238 560 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 561 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 562 return req;
duke@1 563 } else {
mcimadamore@1296 564 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 565 return types.createErrorType(found);
duke@1 566 }
duke@1 567 }
mcimadamore@1237 568
mcimadamore@1237 569 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 570 * The problem should only be reported for non-292 cast
mcimadamore@1237 571 */
jlahoda@2028 572 public void checkRedundantCast(Env<AttrContext> env, final JCTypeCast tree) {
jlahoda@2028 573 if (!tree.type.isErroneous()
mcimadamore@1348 574 && types.isSameType(tree.expr.type, tree.clazz.type)
jjg@1521 575 && !(ignoreAnnotatedCasts && TreeInfo.containsTypeAnnotation(tree.clazz))
mcimadamore@1348 576 && !is292targetTypeCast(tree)) {
jlahoda@2028 577 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
jlahoda@2028 578 @Override
jlahoda@2028 579 public void report() {
jlahoda@2028 580 if (lint.isEnabled(Lint.LintCategory.CAST))
jlahoda@2028 581 log.warning(Lint.LintCategory.CAST,
jlahoda@2028 582 tree.pos(), "redundant.cast", tree.expr.type);
jlahoda@2028 583 }
jlahoda@2028 584 });
mcimadamore@1237 585 }
mcimadamore@1237 586 }
mcimadamore@1237 587 //where
jjg@1521 588 private boolean is292targetTypeCast(JCTypeCast tree) {
jjg@1521 589 boolean is292targetTypeCast = false;
jjg@1521 590 JCExpression expr = TreeInfo.skipParens(tree.expr);
jjg@1521 591 if (expr.hasTag(APPLY)) {
jjg@1521 592 JCMethodInvocation apply = (JCMethodInvocation)expr;
jjg@1521 593 Symbol sym = TreeInfo.symbol(apply.meth);
jjg@1521 594 is292targetTypeCast = sym != null &&
jjg@1521 595 sym.kind == MTH &&
jjg@1521 596 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 597 }
jjg@1521 598 return is292targetTypeCast;
jjg@1521 599 }
mcimadamore@1237 600
jjg@1521 601 private static final boolean ignoreAnnotatedCasts = true;
duke@1 602
duke@1 603 /** Check that a type is within some bounds.
duke@1 604 *
jjg@1358 605 * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
duke@1 606 * type argument.
duke@1 607 * @param a The type that should be bounded by bs.
jjg@1358 608 * @param bound The bound.
duke@1 609 */
mcimadamore@1216 610 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 611 if (a.isUnbound()) {
mcimadamore@821 612 return true;
jjg@1374 613 } else if (!a.hasTag(WILDCARD)) {
mcimadamore@154 614 a = types.upperBound(a);
mcimadamore@1216 615 return types.isSubtype(a, bound);
mcimadamore@154 616 } else if (a.isExtendsBound()) {
mcimadamore@1415 617 return types.isCastable(bound, types.upperBound(a), types.noWarnings);
mcimadamore@154 618 } else if (a.isSuperBound()) {
mcimadamore@1216 619 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 620 }
mcimadamore@821 621 return true;
mcimadamore@154 622 }
duke@1 623
duke@1 624 /** Check that type is different from 'void'.
duke@1 625 * @param pos Position to be used for error reporting.
duke@1 626 * @param t The type to be checked.
duke@1 627 */
duke@1 628 Type checkNonVoid(DiagnosticPosition pos, Type t) {
jjg@1374 629 if (t.hasTag(VOID)) {
duke@1 630 log.error(pos, "void.not.allowed.here");
jjg@110 631 return types.createErrorType(t);
duke@1 632 } else {
duke@1 633 return t;
duke@1 634 }
duke@1 635 }
duke@1 636
mcimadamore@1496 637 Type checkClassOrArrayType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 638 if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
mcimadamore@1496 639 return typeTagError(pos,
mcimadamore@1496 640 diags.fragment("type.req.class.array"),
mcimadamore@1496 641 asTypeParam(t));
mcimadamore@1496 642 } else {
mcimadamore@1496 643 return t;
mcimadamore@1496 644 }
mcimadamore@1496 645 }
mcimadamore@1496 646
duke@1 647 /** Check that type is a class or interface type.
duke@1 648 * @param pos Position to be used for error reporting.
duke@1 649 * @param t The type to be checked.
duke@1 650 */
duke@1 651 Type checkClassType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 652 if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) {
duke@1 653 return typeTagError(pos,
mcimadamore@89 654 diags.fragment("type.req.class"),
mcimadamore@1496 655 asTypeParam(t));
mcimadamore@1496 656 } else {
duke@1 657 return t;
mcimadamore@1496 658 }
duke@1 659 }
mcimadamore@1496 660 //where
mcimadamore@1496 661 private Object asTypeParam(Type t) {
mcimadamore@1496 662 return (t.hasTag(TYPEVAR))
mcimadamore@1496 663 ? diags.fragment("type.parameter", t)
mcimadamore@1496 664 : t;
mcimadamore@1496 665 }
duke@1 666
mcimadamore@1352 667 /** Check that type is a valid qualifier for a constructor reference expression
mcimadamore@1352 668 */
mcimadamore@1352 669 Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 670 t = checkClassOrArrayType(pos, t);
jjg@1374 671 if (t.hasTag(CLASS)) {
mcimadamore@1352 672 if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
mcimadamore@1627 673 log.error(pos, "abstract.cant.be.instantiated", t.tsym);
mcimadamore@1352 674 t = types.createErrorType(t);
mcimadamore@1352 675 } else if ((t.tsym.flags() & ENUM) != 0) {
mcimadamore@1352 676 log.error(pos, "enum.cant.be.instantiated");
mcimadamore@1352 677 t = types.createErrorType(t);
mcimadamore@1627 678 } else {
mcimadamore@1627 679 t = checkClassType(pos, t, true);
mcimadamore@1627 680 }
mcimadamore@1627 681 } else if (t.hasTag(ARRAY)) {
mcimadamore@1627 682 if (!types.isReifiable(((ArrayType)t).elemtype)) {
mcimadamore@1627 683 log.error(pos, "generic.array.creation");
mcimadamore@1627 684 t = types.createErrorType(t);
mcimadamore@1352 685 }
mcimadamore@1352 686 }
mcimadamore@1352 687 return t;
mcimadamore@1352 688 }
mcimadamore@1352 689
duke@1 690 /** Check that type is a class or interface type.
duke@1 691 * @param pos Position to be used for error reporting.
duke@1 692 * @param t The type to be checked.
duke@1 693 * @param noBounds True if type bounds are illegal here.
duke@1 694 */
duke@1 695 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 696 t = checkClassType(pos, t);
duke@1 697 if (noBounds && t.isParameterized()) {
duke@1 698 List<Type> args = t.getTypeArguments();
duke@1 699 while (args.nonEmpty()) {
jjg@1374 700 if (args.head.hasTag(WILDCARD))
duke@1 701 return typeTagError(pos,
jjg@598 702 diags.fragment("type.req.exact"),
duke@1 703 args.head);
duke@1 704 args = args.tail;
duke@1 705 }
duke@1 706 }
duke@1 707 return t;
duke@1 708 }
duke@1 709
emc@2079 710 // Analog of checkClassType that calls checkClassOrArrayType instead
emc@2079 711 Type checkClassOrArrayType(DiagnosticPosition pos,
emc@2079 712 Type t, boolean noBounds) {
emc@2079 713 t = checkClassOrArrayType(pos, t);
emc@2079 714 if (noBounds && t.isParameterized()) {
emc@2079 715 List<Type> args = t.getTypeArguments();
emc@2079 716 while (args.nonEmpty()) {
emc@2079 717 if (args.head.hasTag(WILDCARD))
emc@2079 718 return typeTagError(pos,
emc@2079 719 diags.fragment("type.req.exact"),
emc@2079 720 args.head);
emc@2079 721 args = args.tail;
emc@2079 722 }
emc@2079 723 }
emc@2079 724 return t;
emc@2079 725 }
emc@2079 726
emc@2079 727 /** Check that type is a reifiable class, interface or array type.
emc@2079 728 * @param pos Position to be used for error reporting.
emc@2079 729 * @param t The type to be checked.
emc@2079 730 */
emc@2079 731 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
emc@2079 732 t = checkClassOrArrayType(pos, t);
emc@2079 733 if (!t.isErroneous() && !types.isReifiable(t)) {
emc@2079 734 log.error(pos, "illegal.generic.type.for.instof");
emc@2079 735 return types.createErrorType(t);
emc@2079 736 } else {
emc@2079 737 return t;
emc@2079 738 }
emc@2079 739 }
emc@2079 740
duke@1 741 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 742 * or a type variable.
duke@1 743 * @param pos Position to be used for error reporting.
duke@1 744 * @param t The type to be checked.
duke@1 745 */
duke@1 746 Type checkRefType(DiagnosticPosition pos, Type t) {
jjg@1374 747 if (t.isReference())
duke@1 748 return t;
jjg@1374 749 else
duke@1 750 return typeTagError(pos,
mcimadamore@89 751 diags.fragment("type.req.ref"),
duke@1 752 t);
duke@1 753 }
duke@1 754
jrose@267 755 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 756 * or a type variable.
jrose@267 757 * @param trees Original trees, used for error reporting.
jrose@267 758 * @param types The types to be checked.
jrose@267 759 */
jrose@267 760 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 761 List<JCExpression> tl = trees;
jrose@267 762 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 763 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 764 tl = tl.tail;
jrose@267 765 }
jrose@267 766 return types;
jrose@267 767 }
jrose@267 768
duke@1 769 /** Check that type is a null or reference type.
duke@1 770 * @param pos Position to be used for error reporting.
duke@1 771 * @param t The type to be checked.
duke@1 772 */
duke@1 773 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
vromero@1826 774 if (t.isReference() || t.hasTag(BOT))
duke@1 775 return t;
jjg@1374 776 else
duke@1 777 return typeTagError(pos,
mcimadamore@89 778 diags.fragment("type.req.ref"),
duke@1 779 t);
duke@1 780 }
duke@1 781
duke@1 782 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 783 * Return true if it doesn't.
duke@1 784 * @param pos Position to be used for error reporting.
duke@1 785 * @param flags The set of flags to be checked.
duke@1 786 * @param set1 Conflicting flags set #1.
duke@1 787 * @param set2 Conflicting flags set #2.
duke@1 788 */
duke@1 789 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 790 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 791 log.error(pos,
duke@1 792 "illegal.combination.of.modifiers",
mcimadamore@80 793 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 794 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 795 return false;
duke@1 796 } else
duke@1 797 return true;
duke@1 798 }
duke@1 799
mcimadamore@914 800 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 801 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 802 */
mcimadamore@914 803 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 804 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 805 t.isErroneous()) {
mcimadamore@914 806 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 807 } else if (tree.def != null) {
mcimadamore@914 808 log.error(tree.clazz.pos(),
mcimadamore@914 809 "cant.apply.diamond.1",
mcimadamore@914 810 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 811 return types.createErrorType(t);
mcimadamore@948 812 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 813 log.error(tree.clazz.pos(),
mcimadamore@914 814 "cant.apply.diamond.1",
mcimadamore@914 815 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 816 return types.createErrorType(t);
mcimadamore@993 817 } else if (tree.typeargs != null &&
mcimadamore@993 818 tree.typeargs.nonEmpty()) {
mcimadamore@993 819 log.error(tree.clazz.pos(),
mcimadamore@993 820 "cant.apply.diamond.1",
mcimadamore@993 821 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 822 return types.createErrorType(t);
mcimadamore@914 823 } else {
mcimadamore@914 824 return t;
mcimadamore@537 825 }
mcimadamore@537 826 }
mcimadamore@537 827
mcimadamore@795 828 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 829 MethodSymbol m = tree.sym;
mcimadamore@795 830 if (!allowSimplifiedVarargs) return;
mcimadamore@795 831 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 832 Type varargElemType = null;
mcimadamore@580 833 if (m.isVarArgs()) {
mcimadamore@795 834 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 835 }
mcimadamore@795 836 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 837 if (varargElemType != null) {
mcimadamore@795 838 log.error(tree,
mcimadamore@795 839 "varargs.invalid.trustme.anno",
mcimadamore@795 840 syms.trustMeType.tsym,
mcimadamore@795 841 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 842 } else {
mcimadamore@795 843 log.error(tree,
mcimadamore@795 844 "varargs.invalid.trustme.anno",
mcimadamore@795 845 syms.trustMeType.tsym,
mcimadamore@795 846 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 847 }
mcimadamore@795 848 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 849 types.isReifiable(varargElemType)) {
mcimadamore@795 850 warnUnsafeVararg(tree,
mcimadamore@795 851 "varargs.redundant.trustme.anno",
mcimadamore@795 852 syms.trustMeType.tsym,
mcimadamore@795 853 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 854 }
mcimadamore@795 855 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 856 !types.isReifiable(varargElemType)) {
mcimadamore@795 857 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 858 }
mcimadamore@580 859 }
mcimadamore@795 860 //where
mcimadamore@795 861 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 862 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 863 (s.isConstructor() ||
mcimadamore@795 864 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 865 }
mcimadamore@580 866
mcimadamore@1812 867 Type checkMethod(final Type mtype,
mcimadamore@1812 868 final Symbol sym,
mcimadamore@1812 869 final Env<AttrContext> env,
mcimadamore@1812 870 final List<JCExpression> argtrees,
mcimadamore@1812 871 final List<Type> argtypes,
mcimadamore@1812 872 final boolean useVarargs,
mcimadamore@1812 873 InferenceContext inferenceContext) {
mcimadamore@1219 874 // System.out.println("call : " + env.tree);
mcimadamore@1219 875 // System.out.println("method : " + owntype);
mcimadamore@1219 876 // System.out.println("actuals: " + argtypes);
mcimadamore@1812 877 if (inferenceContext.free(mtype)) {
mcimadamore@1812 878 inferenceContext.addFreeTypeListener(List.of(mtype), new FreeTypeListener() {
mcimadamore@1812 879 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1812 880 checkMethod(inferenceContext.asInstType(mtype), sym, env, argtrees, argtypes, useVarargs, inferenceContext);
mcimadamore@1812 881 }
mcimadamore@1812 882 });
mcimadamore@1812 883 return mtype;
mcimadamore@1812 884 }
mcimadamore@1812 885 Type owntype = mtype;
mcimadamore@1219 886 List<Type> formals = owntype.getParameterTypes();
kizune@1959 887 List<Type> nonInferred = sym.type.getParameterTypes();
kizune@1959 888 if (nonInferred.length() != formals.length()) nonInferred = formals;
mcimadamore@1219 889 Type last = useVarargs ? formals.last() : null;
kizune@1959 890 if (sym.name == names.init && sym.owner == syms.enumSym) {
kizune@1959 891 formals = formals.tail.tail;
kizune@1959 892 nonInferred = nonInferred.tail.tail;
kizune@1959 893 }
mcimadamore@1219 894 List<JCExpression> args = argtrees;
mcimadamore@1352 895 if (args != null) {
mcimadamore@1352 896 //this is null when type-checking a method reference
mcimadamore@1352 897 while (formals.head != last) {
mcimadamore@1219 898 JCTree arg = args.head;
kizune@1959 899 Warner warn = convertWarner(arg.pos(), arg.type, nonInferred.head);
mcimadamore@1352 900 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 901 args = args.tail;
mcimadamore@1352 902 formals = formals.tail;
kizune@1959 903 nonInferred = nonInferred.tail;
mcimadamore@1219 904 }
mcimadamore@1352 905 if (useVarargs) {
mcimadamore@1352 906 Type varArg = types.elemtype(last);
mcimadamore@1352 907 while (args.tail != null) {
mcimadamore@1352 908 JCTree arg = args.head;
mcimadamore@1352 909 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1352 910 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1352 911 args = args.tail;
mcimadamore@1352 912 }
mcimadamore@1904 913 } else if ((sym.flags() & (VARARGS | SIGNATURE_POLYMORPHIC)) == VARARGS &&
mcimadamore@1904 914 allowVarargs) {
mcimadamore@1352 915 // non-varargs call to varargs method
mcimadamore@1352 916 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1812 917 Type lastArg = argtypes.last();
mcimadamore@1352 918 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
kizune@1959 919 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1352 920 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
kizune@1959 921 types.elemtype(varParam), varParam);
mcimadamore@1352 922 }
mcimadamore@1219 923 }
mcimadamore@1219 924 if (useVarargs) {
mcimadamore@1219 925 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 926 if (!types.isReifiable(argtype) &&
kizune@1959 927 (!allowSimplifiedVarargs ||
kizune@1959 928 sym.attribute(syms.trustMeType.tsym) == null ||
kizune@1959 929 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 930 warnUnchecked(env.tree.pos(),
mcimadamore@1219 931 "unchecked.generic.array.creation",
mcimadamore@1219 932 argtype);
mcimadamore@1219 933 }
vromero@1820 934 if ((sym.baseSymbol().flags() & SIGNATURE_POLYMORPHIC) == 0) {
mcimadamore@1812 935 TreeInfo.setVarargsElement(env.tree, types.elemtype(argtype));
mcimadamore@1219 936 }
mcimadamore@1219 937 }
mcimadamore@1510 938 PolyKind pkind = (sym.type.hasTag(FORALL) &&
mcimadamore@1510 939 sym.type.getReturnType().containsAny(((ForAll)sym.type).tvars)) ?
mcimadamore@1510 940 PolyKind.POLY : PolyKind.STANDALONE;
mcimadamore@1510 941 TreeInfo.setPolyKind(env.tree, pkind);
mcimadamore@1219 942 return owntype;
mcimadamore@547 943 }
mcimadamore@1219 944 //where
kizune@1959 945 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
kizune@1959 946 if (types.isConvertible(actual, formal, warn))
kizune@1959 947 return;
kizune@1959 948
kizune@1959 949 if (formal.isCompound()
kizune@1959 950 && types.isSubtype(actual, types.supertype(formal))
kizune@1959 951 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
kizune@1959 952 return;
kizune@1959 953 }
mcimadamore@547 954
mcimadamore@821 955 /**
mcimadamore@821 956 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 957 * (see JLS 4.5)
mcimadamore@821 958 *
mcimadamore@821 959 * @param t class type to be checked
mcimadamore@821 960 * @return true if 't' is well-formed
mcimadamore@821 961 */
mcimadamore@821 962 public boolean checkValidGenericType(Type t) {
mcimadamore@821 963 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 964 }
mcimadamore@821 965 //WHERE
mcimadamore@821 966 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 967 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 968 List<Type> actuals = type.allparams();
mcimadamore@821 969 List<Type> args = type.getTypeArguments();
mcimadamore@821 970 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 971 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 972
mcimadamore@821 973 // For matching pairs of actual argument types `a' and
mcimadamore@821 974 // formal type parameters with declared bound `b' ...
mcimadamore@821 975 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 976 // exact type arguments needs to know their
mcimadamore@821 977 // bounds (for upper and lower bound
mcimadamore@1216 978 // calculations). So we create new bounds where
mcimadamore@1216 979 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 980 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 981 args = args.tail;
mcimadamore@821 982 forms = forms.tail;
mcimadamore@821 983 }
mcimadamore@821 984
mcimadamore@821 985 args = type.getTypeArguments();
mcimadamore@821 986 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 987 formals,
mcimadamore@821 988 types.capture(type).allparams());
mcimadamore@821 989 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 990 // Let the actual arguments know their bound
mcimadamore@821 991 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 992 args = args.tail;
mcimadamore@821 993 tvars_cap = tvars_cap.tail;
mcimadamore@821 994 }
mcimadamore@821 995
mcimadamore@821 996 args = type.getTypeArguments();
mcimadamore@1216 997 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 998
mcimadamore@1216 999 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 1000 Type actual = args.head;
mcimadamore@854 1001 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 1002 !bounds.head.isErroneous() &&
mcimadamore@1216 1003 !checkExtends(actual, bounds.head)) {
mcimadamore@821 1004 return args.head;
mcimadamore@821 1005 }
mcimadamore@821 1006 args = args.tail;
mcimadamore@1216 1007 bounds = bounds.tail;
mcimadamore@821 1008 }
mcimadamore@821 1009
mcimadamore@821 1010 args = type.getTypeArguments();
mcimadamore@1216 1011 bounds = bounds_buf.toList();
mcimadamore@821 1012
mcimadamore@821 1013 for (Type arg : types.capture(type).getTypeArguments()) {
jjg@1374 1014 if (arg.hasTag(TYPEVAR) &&
mcimadamore@828 1015 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 1016 !bounds.head.isErroneous() &&
mcimadamore@854 1017 !isTypeArgErroneous(args.head)) {
mcimadamore@821 1018 return args.head;
mcimadamore@821 1019 }
mcimadamore@1216 1020 bounds = bounds.tail;
mcimadamore@854 1021 args = args.tail;
mcimadamore@821 1022 }
mcimadamore@821 1023
mcimadamore@821 1024 return null;
mcimadamore@821 1025 }
mcimadamore@854 1026 //where
mcimadamore@854 1027 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 1028 return isTypeArgErroneous.visit(t);
mcimadamore@854 1029 }
mcimadamore@854 1030
mcimadamore@854 1031 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 1032 public Boolean visitType(Type t, Void s) {
mcimadamore@854 1033 return t.isErroneous();
mcimadamore@854 1034 }
mcimadamore@854 1035 @Override
mcimadamore@854 1036 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 1037 return visit(t.getUpperBound());
mcimadamore@854 1038 }
mcimadamore@854 1039 @Override
mcimadamore@854 1040 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 1041 return visit(t.getUpperBound()) ||
mcimadamore@854 1042 visit(t.getLowerBound());
mcimadamore@854 1043 }
mcimadamore@854 1044 @Override
mcimadamore@854 1045 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1046 return visit(t.type);
mcimadamore@854 1047 }
mcimadamore@854 1048 };
mcimadamore@821 1049
duke@1 1050 /** Check that given modifiers are legal for given symbol and
vromero@1555 1051 * return modifiers together with any implicit modifiers for that symbol.
duke@1 1052 * Warning: we can't use flags() here since this method
duke@1 1053 * is called during class enter, when flags() would cause a premature
duke@1 1054 * completion.
duke@1 1055 * @param pos Position to be used for error reporting.
duke@1 1056 * @param flags The set of modifiers given in a definition.
duke@1 1057 * @param sym The defined symbol.
duke@1 1058 */
duke@1 1059 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1060 long mask;
duke@1 1061 long implicit = 0;
emc@2016 1062
duke@1 1063 switch (sym.kind) {
duke@1 1064 case VAR:
duke@1 1065 if (sym.owner.kind != TYP)
duke@1 1066 mask = LocalVarFlags;
duke@1 1067 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1068 mask = implicit = InterfaceVarFlags;
duke@1 1069 else
duke@1 1070 mask = VarFlags;
duke@1 1071 break;
duke@1 1072 case MTH:
duke@1 1073 if (sym.name == names.init) {
duke@1 1074 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1075 // enum constructors cannot be declared public or
duke@1 1076 // protected and must be implicitly or explicitly
duke@1 1077 // private
duke@1 1078 implicit = PRIVATE;
duke@1 1079 mask = PRIVATE;
duke@1 1080 } else
duke@1 1081 mask = ConstructorFlags;
mcimadamore@1366 1082 } else if ((sym.owner.flags_field & INTERFACE) != 0) {
emc@2016 1083 if ((sym.owner.flags_field & ANNOTATION) != 0) {
emc@2016 1084 mask = AnnotationTypeElementMask;
emc@2016 1085 implicit = PUBLIC | ABSTRACT;
emc@2016 1086 } else if ((flags & (DEFAULT | STATIC)) != 0) {
mcimadamore@1513 1087 mask = InterfaceMethodMask;
mcimadamore@1513 1088 implicit = PUBLIC;
mcimadamore@1513 1089 if ((flags & DEFAULT) != 0) {
mcimadamore@1513 1090 implicit |= ABSTRACT;
mcimadamore@1513 1091 }
mcimadamore@1366 1092 } else {
mcimadamore@1366 1093 mask = implicit = InterfaceMethodFlags;
mcimadamore@1366 1094 }
emc@2016 1095 } else {
duke@1 1096 mask = MethodFlags;
duke@1 1097 }
duke@1 1098 // Imply STRICTFP if owner has STRICTFP set.
vromero@1712 1099 if (((flags|implicit) & Flags.ABSTRACT) == 0 ||
vromero@1712 1100 ((flags) & Flags.DEFAULT) != 0)
vromero@1555 1101 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1102 break;
duke@1 1103 case TYP:
duke@1 1104 if (sym.isLocal()) {
duke@1 1105 mask = LocalClassFlags;
jjg@113 1106 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1107 // Anonymous classes in static methods are themselves static;
duke@1 1108 // that's why we admit STATIC here.
duke@1 1109 mask |= STATIC;
duke@1 1110 // JLS: Anonymous classes are final.
duke@1 1111 implicit |= FINAL;
duke@1 1112 }
duke@1 1113 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1114 (flags & ENUM) != 0)
duke@1 1115 log.error(pos, "enums.must.be.static");
duke@1 1116 } else if (sym.owner.kind == TYP) {
duke@1 1117 mask = MemberClassFlags;
duke@1 1118 if (sym.owner.owner.kind == PCK ||
duke@1 1119 (sym.owner.flags_field & STATIC) != 0)
duke@1 1120 mask |= STATIC;
duke@1 1121 else if ((flags & ENUM) != 0)
duke@1 1122 log.error(pos, "enums.must.be.static");
duke@1 1123 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1124 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1125 } else {
duke@1 1126 mask = ClassFlags;
duke@1 1127 }
duke@1 1128 // Interfaces are always ABSTRACT
duke@1 1129 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1130
duke@1 1131 if ((flags & ENUM) != 0) {
duke@1 1132 // enums can't be declared abstract or final
duke@1 1133 mask &= ~(ABSTRACT | FINAL);
duke@1 1134 implicit |= implicitEnumFinalFlag(tree);
duke@1 1135 }
duke@1 1136 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1137 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1138 break;
duke@1 1139 default:
duke@1 1140 throw new AssertionError();
duke@1 1141 }
mcimadamore@1366 1142 long illegal = flags & ExtendedStandardFlags & ~mask;
duke@1 1143 if (illegal != 0) {
duke@1 1144 if ((illegal & INTERFACE) != 0) {
duke@1 1145 log.error(pos, "intf.not.allowed.here");
duke@1 1146 mask |= INTERFACE;
duke@1 1147 }
duke@1 1148 else {
duke@1 1149 log.error(pos,
mcimadamore@80 1150 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1151 }
duke@1 1152 }
duke@1 1153 else if ((sym.kind == TYP ||
duke@1 1154 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1155 // in the presence of inner classes. Should it be deleted here?
duke@1 1156 checkDisjoint(pos, flags,
duke@1 1157 ABSTRACT,
mcimadamore@1366 1158 PRIVATE | STATIC | DEFAULT))
duke@1 1159 &&
duke@1 1160 checkDisjoint(pos, flags,
mcimadamore@1513 1161 STATIC,
mcimadamore@1513 1162 DEFAULT)
mcimadamore@1513 1163 &&
mcimadamore@1513 1164 checkDisjoint(pos, flags,
duke@1 1165 ABSTRACT | INTERFACE,
duke@1 1166 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1167 &&
duke@1 1168 checkDisjoint(pos, flags,
duke@1 1169 PUBLIC,
duke@1 1170 PRIVATE | PROTECTED)
duke@1 1171 &&
duke@1 1172 checkDisjoint(pos, flags,
duke@1 1173 PRIVATE,
duke@1 1174 PUBLIC | PROTECTED)
duke@1 1175 &&
duke@1 1176 checkDisjoint(pos, flags,
duke@1 1177 FINAL,
duke@1 1178 VOLATILE)
duke@1 1179 &&
duke@1 1180 (sym.kind == TYP ||
duke@1 1181 checkDisjoint(pos, flags,
duke@1 1182 ABSTRACT | NATIVE,
duke@1 1183 STRICTFP))) {
duke@1 1184 // skip
duke@1 1185 }
mcimadamore@1366 1186 return flags & (mask | ~ExtendedStandardFlags) | implicit;
duke@1 1187 }
duke@1 1188
duke@1 1189
duke@1 1190 /** Determine if this enum should be implicitly final.
duke@1 1191 *
duke@1 1192 * If the enum has no specialized enum contants, it is final.
duke@1 1193 *
duke@1 1194 * If the enum does have specialized enum contants, it is
duke@1 1195 * <i>not</i> final.
duke@1 1196 */
duke@1 1197 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1198 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1199 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1200 boolean specialized;
duke@1 1201 SpecialTreeVisitor() {
duke@1 1202 this.specialized = false;
duke@1 1203 };
duke@1 1204
jjg@398 1205 @Override
duke@1 1206 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1207
jjg@398 1208 @Override
duke@1 1209 public void visitVarDef(JCVariableDecl tree) {
duke@1 1210 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1211 if (tree.init instanceof JCNewClass &&
duke@1 1212 ((JCNewClass) tree.init).def != null) {
duke@1 1213 specialized = true;
duke@1 1214 }
duke@1 1215 }
duke@1 1216 }
duke@1 1217 }
duke@1 1218
duke@1 1219 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1220 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1221 for (JCTree defs: cdef.defs) {
duke@1 1222 defs.accept(sts);
duke@1 1223 if (sts.specialized) return 0;
duke@1 1224 }
duke@1 1225 return FINAL;
duke@1 1226 }
duke@1 1227
duke@1 1228 /* *************************************************************************
duke@1 1229 * Type Validation
duke@1 1230 **************************************************************************/
duke@1 1231
duke@1 1232 /** Validate a type expression. That is,
duke@1 1233 * check that all type arguments of a parametric type are within
jjg@1755 1234 * their bounds. This must be done in a second phase after type attribution
duke@1 1235 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1236 *
jjg@1358 1237 * <pre>{@code
duke@1 1238 * class B<A extends C> { ... }
duke@1 1239 * class C extends B<C> { ... }
jjg@1358 1240 * }</pre>
duke@1 1241 *
duke@1 1242 * and we can't make sure that the bound is already attributed because
duke@1 1243 * of possible cycles.
mcimadamore@638 1244 *
mcimadamore@638 1245 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1246 * and reporting any completion failures.
duke@1 1247 */
mcimadamore@122 1248 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1249 validate(tree, env, true);
duke@1 1250 }
mcimadamore@638 1251 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1252 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1253 }
duke@1 1254
duke@1 1255 /** Visitor method: Validate a list of type expressions.
duke@1 1256 */
mcimadamore@122 1257 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1258 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1259 validate(l.head, env);
duke@1 1260 }
duke@1 1261
duke@1 1262 /** A visitor class for type validation.
duke@1 1263 */
duke@1 1264 class Validator extends JCTree.Visitor {
duke@1 1265
jlahoda@2038 1266 boolean checkRaw;
mcimadamore@638 1267 boolean isOuter;
mcimadamore@638 1268 Env<AttrContext> env;
mcimadamore@638 1269
mcimadamore@638 1270 Validator(Env<AttrContext> env) {
mcimadamore@638 1271 this.env = env;
mcimadamore@638 1272 }
mcimadamore@638 1273
jjg@398 1274 @Override
duke@1 1275 public void visitTypeArray(JCArrayTypeTree tree) {
jlahoda@2038 1276 validateTree(tree.elemtype, checkRaw, isOuter);
duke@1 1277 }
duke@1 1278
jjg@398 1279 @Override
duke@1 1280 public void visitTypeApply(JCTypeApply tree) {
jjg@1374 1281 if (tree.type.hasTag(CLASS)) {
duke@1 1282 List<JCExpression> args = tree.arguments;
mcimadamore@158 1283 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1284
mcimadamore@821 1285 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1286 if (incompatibleArg != null) {
mcimadamore@821 1287 for (JCTree arg : tree.arguments) {
mcimadamore@821 1288 if (arg.type == incompatibleArg) {
mcimadamore@829 1289 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1290 }
mcimadamore@829 1291 forms = forms.tail;
mcimadamore@829 1292 }
mcimadamore@829 1293 }
mcimadamore@829 1294
mcimadamore@829 1295 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1296
mcimadamore@638 1297 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1298
duke@1 1299 // For matching pairs of actual argument types `a' and
duke@1 1300 // formal type parameters with declared bound `b' ...
duke@1 1301 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1302 validateTree(args.head,
mcimadamore@638 1303 !(isOuter && is_java_lang_Class),
mcimadamore@638 1304 false);
duke@1 1305 args = args.tail;
duke@1 1306 forms = forms.tail;
duke@1 1307 }
duke@1 1308
duke@1 1309 // Check that this type is either fully parameterized, or
duke@1 1310 // not parameterized at all.
duke@1 1311 if (tree.type.getEnclosingType().isRaw())
duke@1 1312 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1313 if (tree.clazz.hasTag(SELECT))
duke@1 1314 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1315 }
duke@1 1316 }
duke@1 1317
jjg@398 1318 @Override
duke@1 1319 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1320 validateTrees(tree.bounds, true, isOuter);
duke@1 1321 checkClassBounds(tree.pos(), tree.type);
duke@1 1322 }
duke@1 1323
duke@1 1324 @Override
duke@1 1325 public void visitWildcard(JCWildcard tree) {
duke@1 1326 if (tree.inner != null)
mcimadamore@638 1327 validateTree(tree.inner, true, isOuter);
duke@1 1328 }
duke@1 1329
jjg@398 1330 @Override
duke@1 1331 public void visitSelect(JCFieldAccess tree) {
jjg@1374 1332 if (tree.type.hasTag(CLASS)) {
duke@1 1333 visitSelectInternal(tree);
duke@1 1334
duke@1 1335 // Check that this type is either fully parameterized, or
duke@1 1336 // not parameterized at all.
duke@1 1337 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1338 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1339 }
duke@1 1340 }
mcimadamore@852 1341
duke@1 1342 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1343 if (tree.type.tsym.isStatic() &&
duke@1 1344 tree.selected.type.isParameterized()) {
duke@1 1345 // The enclosing type is not a class, so we are
duke@1 1346 // looking at a static member type. However, the
duke@1 1347 // qualifying expression is parameterized.
duke@1 1348 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1349 } else {
duke@1 1350 // otherwise validate the rest of the expression
mcimadamore@122 1351 tree.selected.accept(this);
duke@1 1352 }
duke@1 1353 }
duke@1 1354
jjg@1521 1355 @Override
jjg@1521 1356 public void visitAnnotatedType(JCAnnotatedType tree) {
jjg@1521 1357 tree.underlyingType.accept(this);
jjg@1521 1358 }
jjg@1521 1359
duke@1 1360 /** Default visitor method: do nothing.
duke@1 1361 */
jjg@398 1362 @Override
duke@1 1363 public void visitTree(JCTree tree) {
duke@1 1364 }
mcimadamore@122 1365
mcimadamore@638 1366 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
jlahoda@2038 1367 if (tree != null) {
jlahoda@2038 1368 boolean prevCheckRaw = this.checkRaw;
jlahoda@2038 1369 this.checkRaw = checkRaw;
jlahoda@2038 1370 this.isOuter = isOuter;
jlahoda@2038 1371
jlahoda@2038 1372 try {
mcimadamore@638 1373 tree.accept(this);
mcimadamore@638 1374 if (checkRaw)
mcimadamore@638 1375 checkRaw(tree, env);
jlahoda@2038 1376 } catch (CompletionFailure ex) {
jlahoda@2038 1377 completionError(tree.pos(), ex);
jlahoda@2038 1378 } finally {
jlahoda@2038 1379 this.checkRaw = prevCheckRaw;
mcimadamore@638 1380 }
mcimadamore@638 1381 }
mcimadamore@638 1382 }
mcimadamore@638 1383
mcimadamore@638 1384 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1385 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1386 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1387 }
mcimadamore@1760 1388 }
mcimadamore@1760 1389
mcimadamore@1760 1390 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@1760 1391 if (lint.isEnabled(LintCategory.RAW) &&
mcimadamore@1760 1392 tree.type.hasTag(CLASS) &&
mcimadamore@1760 1393 !TreeInfo.isDiamond(tree) &&
mcimadamore@1760 1394 !withinAnonConstr(env) &&
mcimadamore@1760 1395 tree.type.isRaw()) {
mcimadamore@1760 1396 log.warning(LintCategory.RAW,
mcimadamore@1760 1397 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1398 }
mcimadamore@1760 1399 }
mcimadamore@1760 1400 //where
mcimadamore@1760 1401 private boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1402 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1403 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1404 }
duke@1 1405
duke@1 1406 /* *************************************************************************
duke@1 1407 * Exception checking
duke@1 1408 **************************************************************************/
duke@1 1409
duke@1 1410 /* The following methods treat classes as sets that contain
duke@1 1411 * the class itself and all their subclasses
duke@1 1412 */
duke@1 1413
duke@1 1414 /** Is given type a subtype of some of the types in given list?
duke@1 1415 */
duke@1 1416 boolean subset(Type t, List<Type> ts) {
duke@1 1417 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1418 if (types.isSubtype(t, l.head)) return true;
duke@1 1419 return false;
duke@1 1420 }
duke@1 1421
duke@1 1422 /** Is given type a subtype or supertype of
duke@1 1423 * some of the types in given list?
duke@1 1424 */
duke@1 1425 boolean intersects(Type t, List<Type> ts) {
duke@1 1426 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1427 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1428 return false;
duke@1 1429 }
duke@1 1430
duke@1 1431 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1432 * in the list.
duke@1 1433 */
duke@1 1434 List<Type> incl(Type t, List<Type> ts) {
duke@1 1435 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1436 }
duke@1 1437
duke@1 1438 /** Remove type set from type set list.
duke@1 1439 */
duke@1 1440 List<Type> excl(Type t, List<Type> ts) {
duke@1 1441 if (ts.isEmpty()) {
duke@1 1442 return ts;
duke@1 1443 } else {
duke@1 1444 List<Type> ts1 = excl(t, ts.tail);
duke@1 1445 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1446 else if (ts1 == ts.tail) return ts;
duke@1 1447 else return ts1.prepend(ts.head);
duke@1 1448 }
duke@1 1449 }
duke@1 1450
duke@1 1451 /** Form the union of two type set lists.
duke@1 1452 */
duke@1 1453 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1454 List<Type> ts = ts1;
duke@1 1455 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1456 ts = incl(l.head, ts);
duke@1 1457 return ts;
duke@1 1458 }
duke@1 1459
duke@1 1460 /** Form the difference of two type lists.
duke@1 1461 */
duke@1 1462 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1463 List<Type> ts = ts1;
duke@1 1464 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1465 ts = excl(l.head, ts);
duke@1 1466 return ts;
duke@1 1467 }
duke@1 1468
duke@1 1469 /** Form the intersection of two type lists.
duke@1 1470 */
duke@1 1471 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1472 List<Type> ts = List.nil();
duke@1 1473 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1474 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1475 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1476 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1477 return ts;
duke@1 1478 }
duke@1 1479
duke@1 1480 /** Is exc an exception symbol that need not be declared?
duke@1 1481 */
duke@1 1482 boolean isUnchecked(ClassSymbol exc) {
duke@1 1483 return
duke@1 1484 exc.kind == ERR ||
duke@1 1485 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1486 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1487 }
duke@1 1488
duke@1 1489 /** Is exc an exception type that need not be declared?
duke@1 1490 */
duke@1 1491 boolean isUnchecked(Type exc) {
duke@1 1492 return
jjg@1374 1493 (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
jjg@1374 1494 (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
jjg@1374 1495 exc.hasTag(BOT);
duke@1 1496 }
duke@1 1497
duke@1 1498 /** Same, but handling completion failures.
duke@1 1499 */
duke@1 1500 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1501 try {
duke@1 1502 return isUnchecked(exc);
duke@1 1503 } catch (CompletionFailure ex) {
duke@1 1504 completionError(pos, ex);
duke@1 1505 return true;
duke@1 1506 }
duke@1 1507 }
duke@1 1508
duke@1 1509 /** Is exc handled by given exception list?
duke@1 1510 */
duke@1 1511 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1512 return isUnchecked(exc) || subset(exc, handled);
duke@1 1513 }
duke@1 1514
duke@1 1515 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1516 * @param thrown The list of thrown exceptions.
duke@1 1517 * @param handled The list of handled exceptions.
duke@1 1518 */
mcimadamore@362 1519 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1520 List<Type> unhandled = List.nil();
duke@1 1521 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1522 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1523 return unhandled;
duke@1 1524 }
duke@1 1525
duke@1 1526 /* *************************************************************************
duke@1 1527 * Overriding/Implementation checking
duke@1 1528 **************************************************************************/
duke@1 1529
duke@1 1530 /** The level of access protection given by a flag set,
duke@1 1531 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1532 */
duke@1 1533 static int protection(long flags) {
duke@1 1534 switch ((short)(flags & AccessFlags)) {
duke@1 1535 case PRIVATE: return 3;
duke@1 1536 case PROTECTED: return 1;
duke@1 1537 default:
duke@1 1538 case PUBLIC: return 0;
duke@1 1539 case 0: return 2;
duke@1 1540 }
duke@1 1541 }
duke@1 1542
duke@1 1543 /** A customized "cannot override" error message.
duke@1 1544 * @param m The overriding method.
duke@1 1545 * @param other The overridden method.
duke@1 1546 * @return An internationalized string.
duke@1 1547 */
mcimadamore@89 1548 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1549 String key;
duke@1 1550 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1551 key = "cant.override";
duke@1 1552 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1553 key = "cant.implement";
duke@1 1554 else
duke@1 1555 key = "clashes.with";
mcimadamore@89 1556 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1557 }
duke@1 1558
duke@1 1559 /** A customized "override" warning message.
duke@1 1560 * @param m The overriding method.
duke@1 1561 * @param other The overridden method.
duke@1 1562 * @return An internationalized string.
duke@1 1563 */
mcimadamore@89 1564 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1565 String key;
duke@1 1566 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1567 key = "unchecked.override";
duke@1 1568 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1569 key = "unchecked.implement";
duke@1 1570 else
duke@1 1571 key = "unchecked.clash.with";
mcimadamore@89 1572 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1573 }
duke@1 1574
duke@1 1575 /** A customized "override" warning message.
duke@1 1576 * @param m The overriding method.
duke@1 1577 * @param other The overridden method.
duke@1 1578 * @return An internationalized string.
duke@1 1579 */
mcimadamore@89 1580 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1581 String key;
duke@1 1582 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1583 key = "varargs.override";
duke@1 1584 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1585 key = "varargs.implement";
duke@1 1586 else
duke@1 1587 key = "varargs.clash.with";
mcimadamore@89 1588 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1589 }
duke@1 1590
duke@1 1591 /** Check that this method conforms with overridden method 'other'.
duke@1 1592 * where `origin' is the class where checking started.
duke@1 1593 * Complications:
duke@1 1594 * (1) Do not check overriding of synthetic methods
duke@1 1595 * (reason: they might be final).
duke@1 1596 * todo: check whether this is still necessary.
duke@1 1597 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1598 * than the method it implements. Augment the proxy methods with the
duke@1 1599 * undeclared exceptions in this case.
duke@1 1600 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1601 * has a result type
duke@1 1602 * extended by the result type of the method it implements.
duke@1 1603 * Change the proxies result type to the smaller type in this case.
duke@1 1604 *
duke@1 1605 * @param tree The tree from which positions
duke@1 1606 * are extracted for errors.
duke@1 1607 * @param m The overriding method.
duke@1 1608 * @param other The overridden method.
duke@1 1609 * @param origin The class of which the overriding method
duke@1 1610 * is a member.
duke@1 1611 */
duke@1 1612 void checkOverride(JCTree tree,
duke@1 1613 MethodSymbol m,
duke@1 1614 MethodSymbol other,
duke@1 1615 ClassSymbol origin) {
duke@1 1616 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1617 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1618 return;
duke@1 1619 }
duke@1 1620
duke@1 1621 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1622 if ((m.flags() & STATIC) != 0 &&
duke@1 1623 (other.flags() & STATIC) == 0) {
duke@1 1624 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1625 cannotOverride(m, other));
vromero@1588 1626 m.flags_field |= BAD_OVERRIDE;
duke@1 1627 return;
duke@1 1628 }
duke@1 1629
duke@1 1630 // Error if instance method overrides static or final
duke@1 1631 // method (JLS 8.4.6.1).
duke@1 1632 if ((other.flags() & FINAL) != 0 ||
duke@1 1633 (m.flags() & STATIC) == 0 &&
duke@1 1634 (other.flags() & STATIC) != 0) {
duke@1 1635 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1636 cannotOverride(m, other),
mcimadamore@80 1637 asFlagSet(other.flags() & (FINAL | STATIC)));
vromero@1588 1638 m.flags_field |= BAD_OVERRIDE;
duke@1 1639 return;
duke@1 1640 }
duke@1 1641
duke@1 1642 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1643 // handled in validateAnnotationMethod
duke@1 1644 return;
duke@1 1645 }
duke@1 1646
duke@1 1647 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1648 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1649 protection(m.flags()) > protection(other.flags())) {
duke@1 1650 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1651 cannotOverride(m, other),
mcimadamore@80 1652 other.flags() == 0 ?
vromero@1842 1653 "package" :
mcimadamore@80 1654 asFlagSet(other.flags() & AccessFlags));
vromero@1588 1655 m.flags_field |= BAD_OVERRIDE;
duke@1 1656 return;
duke@1 1657 }
duke@1 1658
duke@1 1659 Type mt = types.memberType(origin.type, m);
duke@1 1660 Type ot = types.memberType(origin.type, other);
duke@1 1661 // Error if overriding result type is different
duke@1 1662 // (or, in the case of generics mode, not a subtype) of
duke@1 1663 // overridden result type. We have to rename any type parameters
duke@1 1664 // before comparing types.
duke@1 1665 List<Type> mtvars = mt.getTypeArguments();
duke@1 1666 List<Type> otvars = ot.getTypeArguments();
duke@1 1667 Type mtres = mt.getReturnType();
duke@1 1668 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1669
mcimadamore@795 1670 overrideWarner.clear();
duke@1 1671 boolean resultTypesOK =
tbell@202 1672 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1673 if (!resultTypesOK) {
jjg@398 1674 if (!allowCovariantReturns &&
duke@1 1675 m.owner != origin &&
duke@1 1676 m.owner.isSubClass(other.owner, types)) {
duke@1 1677 // allow limited interoperability with covariant returns
duke@1 1678 } else {
mcimadamore@362 1679 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1680 "override.incompatible.ret",
mcimadamore@362 1681 cannotOverride(m, other),
duke@1 1682 mtres, otres);
vromero@1588 1683 m.flags_field |= BAD_OVERRIDE;
duke@1 1684 return;
duke@1 1685 }
mcimadamore@795 1686 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1687 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1688 "override.unchecked.ret",
mcimadamore@362 1689 uncheckedOverrides(m, other),
mcimadamore@362 1690 mtres, otres);
duke@1 1691 }
duke@1 1692
duke@1 1693 // Error if overriding method throws an exception not reported
duke@1 1694 // by overridden method.
duke@1 1695 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1696 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1697 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1698 if (unhandledErased.nonEmpty()) {
duke@1 1699 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1700 "override.meth.doesnt.throw",
duke@1 1701 cannotOverride(m, other),
mcimadamore@362 1702 unhandledUnerased.head);
vromero@1588 1703 m.flags_field |= BAD_OVERRIDE;
mcimadamore@362 1704 return;
mcimadamore@362 1705 }
mcimadamore@362 1706 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1707 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1708 "override.unchecked.thrown",
mcimadamore@362 1709 cannotOverride(m, other),
mcimadamore@362 1710 unhandledUnerased.head);
duke@1 1711 return;
duke@1 1712 }
duke@1 1713
duke@1 1714 // Optional warning if varargs don't agree
duke@1 1715 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1716 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1717 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1718 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1719 ? "override.varargs.missing"
duke@1 1720 : "override.varargs.extra",
duke@1 1721 varargsOverrides(m, other));
duke@1 1722 }
duke@1 1723
duke@1 1724 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1725 if ((other.flags() & BRIDGE) != 0) {
duke@1 1726 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1727 uncheckedOverrides(m, other));
duke@1 1728 }
duke@1 1729
duke@1 1730 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1731 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1732 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1733 }
duke@1 1734 }
duke@1 1735 // where
duke@1 1736 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1737 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1738 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1739 // because in that case, we will rediscover the issue when examining the method
duke@1 1740 // in the supertype.
duke@1 1741 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1742 // address the issue is when the method is the supertype implemementation: any other
duke@1 1743 // case, we will have dealt with when examining the supertype classes
duke@1 1744 ClassSymbol mc = m.enclClass();
duke@1 1745 Type st = types.supertype(origin.type);
jjg@1374 1746 if (!st.hasTag(CLASS))
duke@1 1747 return true;
duke@1 1748 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1749
duke@1 1750 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1751 List<Type> intfs = types.interfaces(origin.type);
duke@1 1752 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1753 }
duke@1 1754 else
duke@1 1755 return (stimpl != m);
duke@1 1756 }
duke@1 1757
duke@1 1758
duke@1 1759 // used to check if there were any unchecked conversions
duke@1 1760 Warner overrideWarner = new Warner();
duke@1 1761
duke@1 1762 /** Check that a class does not inherit two concrete methods
duke@1 1763 * with the same signature.
duke@1 1764 * @param pos Position to be used for error reporting.
duke@1 1765 * @param site The class type to be checked.
duke@1 1766 */
duke@1 1767 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1768 Type sup = types.supertype(site);
jjg@1374 1769 if (!sup.hasTag(CLASS)) return;
duke@1 1770
duke@1 1771 for (Type t1 = sup;
jlahoda@1956 1772 t1.hasTag(CLASS) && t1.tsym.type.isParameterized();
duke@1 1773 t1 = types.supertype(t1)) {
duke@1 1774 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1775 e1 != null;
duke@1 1776 e1 = e1.sibling) {
duke@1 1777 Symbol s1 = e1.sym;
duke@1 1778 if (s1.kind != MTH ||
duke@1 1779 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1780 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1781 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1782 types,
duke@1 1783 true) != s1)
duke@1 1784 continue;
duke@1 1785 Type st1 = types.memberType(t1, s1);
duke@1 1786 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1787 if (st1 == s1.type) continue;
duke@1 1788
duke@1 1789 for (Type t2 = sup;
jjg@1374 1790 t2.hasTag(CLASS);
duke@1 1791 t2 = types.supertype(t2)) {
mcimadamore@24 1792 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1793 e2.scope != null;
duke@1 1794 e2 = e2.next()) {
duke@1 1795 Symbol s2 = e2.sym;
duke@1 1796 if (s2 == s1 ||
duke@1 1797 s2.kind != MTH ||
duke@1 1798 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1799 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1800 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1801 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1802 types,
duke@1 1803 true) != s2)
duke@1 1804 continue;
duke@1 1805 Type st2 = types.memberType(t2, s2);
duke@1 1806 if (types.overrideEquivalent(st1, st2))
duke@1 1807 log.error(pos, "concrete.inheritance.conflict",
duke@1 1808 s1, t1, s2, t2, sup);
duke@1 1809 }
duke@1 1810 }
duke@1 1811 }
duke@1 1812 }
duke@1 1813 }
duke@1 1814
duke@1 1815 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1816 * method with same name and arguments but incompatible return types.
duke@1 1817 * @param pos Position to be used for error reporting.
duke@1 1818 * @param t1 The first argument type.
duke@1 1819 * @param t2 The second argument type.
duke@1 1820 */
duke@1 1821 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1822 Type t1,
duke@1 1823 Type t2) {
duke@1 1824 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1825 types.makeCompoundType(t1, t2));
duke@1 1826 }
duke@1 1827
duke@1 1828 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1829 Type t1,
duke@1 1830 Type t2,
duke@1 1831 Type site) {
mcimadamore@746 1832 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1833 }
duke@1 1834
duke@1 1835 /** Return the first method which is defined with same args
duke@1 1836 * but different return types in two given interfaces, or null if none
duke@1 1837 * exists.
duke@1 1838 * @param t1 The first type.
duke@1 1839 * @param t2 The second type.
duke@1 1840 * @param site The most derived type.
duke@1 1841 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1842 */
mcimadamore@746 1843 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1844 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1845 closure(t1, interfaces1);
duke@1 1846 Map<TypeSymbol,Type> interfaces2;
duke@1 1847 if (t1 == t2)
duke@1 1848 interfaces2 = interfaces1;
duke@1 1849 else
duke@1 1850 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1851
duke@1 1852 for (Type t3 : interfaces1.values()) {
duke@1 1853 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1854 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1855 if (s != null) return s;
duke@1 1856 }
duke@1 1857 }
duke@1 1858 return null;
duke@1 1859 }
duke@1 1860
duke@1 1861 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1862 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1863 if (!t.hasTag(CLASS)) return;
duke@1 1864 if (typeMap.put(t.tsym, t) == null) {
duke@1 1865 closure(types.supertype(t), typeMap);
duke@1 1866 for (Type i : types.interfaces(t))
duke@1 1867 closure(i, typeMap);
duke@1 1868 }
duke@1 1869 }
duke@1 1870
duke@1 1871 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1872 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1873 if (!t.hasTag(CLASS)) return;
duke@1 1874 if (typesSkip.get(t.tsym) != null) return;
duke@1 1875 if (typeMap.put(t.tsym, t) == null) {
duke@1 1876 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1877 for (Type i : types.interfaces(t))
duke@1 1878 closure(i, typesSkip, typeMap);
duke@1 1879 }
duke@1 1880 }
duke@1 1881
duke@1 1882 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1883 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1884 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1885 Symbol s1 = e1.sym;
duke@1 1886 Type st1 = null;
mcimadamore@1441 1887 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1888 (s1.flags() & SYNTHETIC) != 0) continue;
duke@1 1889 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1890 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1891 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1892 Symbol s2 = e2.sym;
duke@1 1893 if (s1 == s2) continue;
mcimadamore@1441 1894 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1895 (s2.flags() & SYNTHETIC) != 0) continue;
duke@1 1896 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1897 Type st2 = types.memberType(t2, s2);
duke@1 1898 if (types.overrideEquivalent(st1, st2)) {
duke@1 1899 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1900 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1901 Type rt1 = st1.getReturnType();
duke@1 1902 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1903 boolean compat =
duke@1 1904 types.isSameType(rt1, rt2) ||
jjg@1374 1905 !rt1.isPrimitiveOrVoid() &&
jjg@1374 1906 !rt2.isPrimitiveOrVoid() &&
mcimadamore@1415 1907 (types.covariantReturnType(rt1, rt2, types.noWarnings) ||
mcimadamore@1415 1908 types.covariantReturnType(rt2, rt1, types.noWarnings)) ||
mcimadamore@59 1909 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1910 if (!compat) {
mcimadamore@746 1911 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1912 t1, t2, s2.name +
mcimadamore@746 1913 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1914 return s2;
mcimadamore@746 1915 }
mcimadamore@889 1916 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1917 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1918 log.error(pos,
mcimadamore@746 1919 "name.clash.same.erasure.no.override",
mcimadamore@746 1920 s1, s1.location(),
mcimadamore@746 1921 s2, s2.location());
mcimadamore@746 1922 return s2;
duke@1 1923 }
duke@1 1924 }
duke@1 1925 }
duke@1 1926 return null;
duke@1 1927 }
mcimadamore@59 1928 //WHERE
mcimadamore@59 1929 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1930 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1931 Type st1 = types.memberType(site, s1);
mcimadamore@59 1932 Type st2 = types.memberType(site, s2);
mcimadamore@59 1933 closure(site, supertypes);
mcimadamore@59 1934 for (Type t : supertypes.values()) {
mcimadamore@59 1935 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1936 Symbol s3 = e.sym;
mcimadamore@59 1937 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1938 Type st3 = types.memberType(site,s3);
mcimadamore@1811 1939 if (types.overrideEquivalent(st3, st1) &&
mcimadamore@1811 1940 types.overrideEquivalent(st3, st2) &&
mcimadamore@1811 1941 types.returnTypeSubstitutable(st3, st1) &&
mcimadamore@1811 1942 types.returnTypeSubstitutable(st3, st2)) {
mcimadamore@1811 1943 return true;
mcimadamore@59 1944 }
mcimadamore@59 1945 }
mcimadamore@59 1946 }
mcimadamore@59 1947 return false;
mcimadamore@59 1948 }
duke@1 1949
duke@1 1950 /** Check that a given method conforms with any method it overrides.
duke@1 1951 * @param tree The tree from which positions are extracted
duke@1 1952 * for errors.
duke@1 1953 * @param m The overriding method.
duke@1 1954 */
jlahoda@2111 1955 void checkOverride(JCMethodDecl tree, MethodSymbol m) {
duke@1 1956 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1957 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1958 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1959 log.error(tree.pos(), "enum.no.finalize");
duke@1 1960 return;
duke@1 1961 }
jjg@1374 1962 for (Type t = origin.type; t.hasTag(CLASS);
duke@1 1963 t = types.supertype(t)) {
mcimadamore@746 1964 if (t != origin.type) {
mcimadamore@746 1965 checkOverride(tree, t, origin, m);
mcimadamore@746 1966 }
mcimadamore@746 1967 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1968 checkOverride(tree, t2, origin, m);
duke@1 1969 }
duke@1 1970 }
jlahoda@2111 1971
jlahoda@2111 1972 if (m.attribute(syms.overrideType.tsym) != null && !isOverrider(m)) {
jlahoda@2111 1973 DiagnosticPosition pos = tree.pos();
jlahoda@2111 1974 for (JCAnnotation a : tree.getModifiers().annotations) {
jlahoda@2111 1975 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
jlahoda@2111 1976 pos = a.pos();
jlahoda@2111 1977 break;
jlahoda@2111 1978 }
jlahoda@2111 1979 }
jlahoda@2111 1980 log.error(pos, "method.does.not.override.superclass");
jlahoda@2111 1981 }
duke@1 1982 }
duke@1 1983
mcimadamore@746 1984 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1985 TypeSymbol c = site.tsym;
mcimadamore@746 1986 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1987 while (e.scope != null) {
mcimadamore@746 1988 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1989 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1990 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1991 }
mcimadamore@746 1992 }
mcimadamore@746 1993 e = e.next();
mcimadamore@746 1994 }
mcimadamore@746 1995 }
mcimadamore@746 1996
vromero@1607 1997 private Filter<Symbol> equalsHasCodeFilter = new Filter<Symbol>() {
vromero@1607 1998 public boolean accepts(Symbol s) {
vromero@1607 1999 return MethodSymbol.implementation_filter.accepts(s) &&
vromero@1607 2000 (s.flags() & BAD_OVERRIDE) == 0;
vromero@1607 2001
vromero@1607 2002 }
vromero@1607 2003 };
vromero@1607 2004
vromero@1620 2005 public void checkClassOverrideEqualsAndHashIfNeeded(DiagnosticPosition pos,
vromero@1620 2006 ClassSymbol someClass) {
vromero@1620 2007 /* At present, annotations cannot possibly have a method that is override
vromero@1620 2008 * equivalent with Object.equals(Object) but in any case the condition is
vromero@1620 2009 * fine for completeness.
vromero@1620 2010 */
vromero@1620 2011 if (someClass == (ClassSymbol)syms.objectType.tsym ||
vromero@1620 2012 someClass.isInterface() || someClass.isEnum() ||
vromero@1620 2013 (someClass.flags() & ANNOTATION) != 0 ||
vromero@1620 2014 (someClass.flags() & ABSTRACT) != 0) return;
vromero@1620 2015 //anonymous inner classes implementing interfaces need especial treatment
vromero@1620 2016 if (someClass.isAnonymous()) {
vromero@1620 2017 List<Type> interfaces = types.interfaces(someClass.type);
vromero@1620 2018 if (interfaces != null && !interfaces.isEmpty() &&
vromero@1620 2019 interfaces.head.tsym == syms.comparatorType.tsym) return;
vromero@1620 2020 }
vromero@1620 2021 checkClassOverrideEqualsAndHash(pos, someClass);
vromero@1620 2022 }
vromero@1620 2023
vromero@1620 2024 private void checkClassOverrideEqualsAndHash(DiagnosticPosition pos,
vromero@1607 2025 ClassSymbol someClass) {
vromero@1588 2026 if (lint.isEnabled(LintCategory.OVERRIDES)) {
vromero@1607 2027 MethodSymbol equalsAtObject = (MethodSymbol)syms.objectType
vromero@1607 2028 .tsym.members().lookup(names.equals).sym;
vromero@1607 2029 MethodSymbol hashCodeAtObject = (MethodSymbol)syms.objectType
vromero@1607 2030 .tsym.members().lookup(names.hashCode).sym;
vromero@1607 2031 boolean overridesEquals = types.implementation(equalsAtObject,
vromero@1607 2032 someClass, false, equalsHasCodeFilter).owner == someClass;
vromero@1607 2033 boolean overridesHashCode = types.implementation(hashCodeAtObject,
vromero@1607 2034 someClass, false, equalsHasCodeFilter) != hashCodeAtObject;
vromero@1607 2035
vromero@1607 2036 if (overridesEquals && !overridesHashCode) {
vromero@1607 2037 log.warning(LintCategory.OVERRIDES, pos,
vromero@1620 2038 "override.equals.but.not.hashcode", someClass);
vromero@1588 2039 }
vromero@1588 2040 }
vromero@1588 2041 }
vromero@1588 2042
mcimadamore@746 2043 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 2044 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 2045 return (cf.accepts(s1) &&
mcimadamore@858 2046 cf.accepts(s2) &&
mcimadamore@858 2047 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 2048 }
mcimadamore@746 2049
mcimadamore@746 2050
duke@1 2051 /** Check that all abstract members of given class have definitions.
duke@1 2052 * @param pos Position to be used for error reporting.
duke@1 2053 * @param c The class.
duke@1 2054 */
duke@1 2055 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2056 try {
duke@1 2057 MethodSymbol undef = firstUndef(c, c);
duke@1 2058 if (undef != null) {
duke@1 2059 if ((c.flags() & ENUM) != 0 &&
duke@1 2060 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 2061 (c.flags() & FINAL) == 0) {
duke@1 2062 // add the ABSTRACT flag to an enum
duke@1 2063 c.flags_field |= ABSTRACT;
duke@1 2064 } else {
duke@1 2065 MethodSymbol undef1 =
duke@1 2066 new MethodSymbol(undef.flags(), undef.name,
duke@1 2067 types.memberType(c.type, undef), undef.owner);
duke@1 2068 log.error(pos, "does.not.override.abstract",
duke@1 2069 c, undef1, undef1.location());
duke@1 2070 }
duke@1 2071 }
duke@1 2072 } catch (CompletionFailure ex) {
duke@1 2073 completionError(pos, ex);
duke@1 2074 }
duke@1 2075 }
duke@1 2076 //where
duke@1 2077 /** Return first abstract member of class `c' that is not defined
duke@1 2078 * in `impl', null if there is none.
duke@1 2079 */
duke@1 2080 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 2081 MethodSymbol undef = null;
duke@1 2082 // Do not bother to search in classes that are not abstract,
duke@1 2083 // since they cannot have abstract members.
duke@1 2084 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 2085 Scope s = c.members();
duke@1 2086 for (Scope.Entry e = s.elems;
duke@1 2087 undef == null && e != null;
duke@1 2088 e = e.sibling) {
duke@1 2089 if (e.sym.kind == MTH &&
mcimadamore@1393 2090 (e.sym.flags() & (ABSTRACT|IPROXY|DEFAULT)) == ABSTRACT) {
duke@1 2091 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2092 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
mcimadamore@1393 2093 if (implmeth == null || implmeth == absmeth) {
mcimadamore@1393 2094 //look for default implementations
mcimadamore@1393 2095 if (allowDefaultMethods) {
mcimadamore@1393 2096 MethodSymbol prov = types.interfaceCandidates(impl.type, absmeth).head;
mcimadamore@1393 2097 if (prov != null && prov.overrides(absmeth, impl, types, true)) {
mcimadamore@1393 2098 implmeth = prov;
mcimadamore@1393 2099 }
mcimadamore@1393 2100 }
mcimadamore@1393 2101 }
mcimadamore@1393 2102 if (implmeth == null || implmeth == absmeth) {
duke@1 2103 undef = absmeth;
mcimadamore@1393 2104 }
duke@1 2105 }
duke@1 2106 }
duke@1 2107 if (undef == null) {
duke@1 2108 Type st = types.supertype(c.type);
jjg@1374 2109 if (st.hasTag(CLASS))
duke@1 2110 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 2111 }
duke@1 2112 for (List<Type> l = types.interfaces(c.type);
duke@1 2113 undef == null && l.nonEmpty();
duke@1 2114 l = l.tail) {
duke@1 2115 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 2116 }
duke@1 2117 }
duke@1 2118 return undef;
duke@1 2119 }
duke@1 2120
mcimadamore@690 2121 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 2122 CycleChecker cc = new CycleChecker();
mcimadamore@690 2123 cc.scan(tree);
mcimadamore@690 2124 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 2125 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 2126 }
mcimadamore@690 2127 }
mcimadamore@690 2128
mcimadamore@690 2129 class CycleChecker extends TreeScanner {
mcimadamore@690 2130
mcimadamore@690 2131 List<Symbol> seenClasses = List.nil();
mcimadamore@690 2132 boolean errorFound = false;
mcimadamore@690 2133 boolean partialCheck = false;
mcimadamore@690 2134
mcimadamore@690 2135 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 2136 if (sym != null && sym.kind == TYP) {
mcimadamore@690 2137 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 2138 if (classEnv != null) {
mcimadamore@690 2139 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2140 try {
mcimadamore@690 2141 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2142 scan(classEnv.tree);
mcimadamore@690 2143 }
mcimadamore@690 2144 finally {
mcimadamore@690 2145 log.useSource(prevSource.getFile());
mcimadamore@690 2146 }
mcimadamore@690 2147 } else if (sym.kind == TYP) {
mcimadamore@690 2148 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2149 }
mcimadamore@690 2150 } else {
mcimadamore@690 2151 //not completed yet
mcimadamore@690 2152 partialCheck = true;
mcimadamore@690 2153 }
mcimadamore@690 2154 }
mcimadamore@690 2155
mcimadamore@690 2156 @Override
mcimadamore@690 2157 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2158 super.visitSelect(tree);
mcimadamore@690 2159 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2160 }
mcimadamore@690 2161
mcimadamore@690 2162 @Override
mcimadamore@690 2163 public void visitIdent(JCIdent tree) {
mcimadamore@690 2164 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2165 }
mcimadamore@690 2166
mcimadamore@690 2167 @Override
mcimadamore@690 2168 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2169 scan(tree.clazz);
mcimadamore@690 2170 }
mcimadamore@690 2171
mcimadamore@690 2172 @Override
mcimadamore@690 2173 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2174 scan(tree.elemtype);
mcimadamore@690 2175 }
mcimadamore@690 2176
mcimadamore@690 2177 @Override
mcimadamore@690 2178 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2179 List<JCTree> supertypes = List.nil();
mcimadamore@690 2180 if (tree.getExtendsClause() != null) {
mcimadamore@690 2181 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2182 }
mcimadamore@690 2183 if (tree.getImplementsClause() != null) {
mcimadamore@690 2184 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2185 supertypes = supertypes.prepend(intf);
mcimadamore@690 2186 }
mcimadamore@690 2187 }
mcimadamore@690 2188 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2189 }
mcimadamore@690 2190
mcimadamore@690 2191 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2192 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2193 return;
mcimadamore@690 2194 if (seenClasses.contains(c)) {
mcimadamore@690 2195 errorFound = true;
mcimadamore@690 2196 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2197 } else if (!c.type.isErroneous()) {
mcimadamore@690 2198 try {
mcimadamore@690 2199 seenClasses = seenClasses.prepend(c);
jjg@1374 2200 if (c.type.hasTag(CLASS)) {
mcimadamore@690 2201 if (supertypes.nonEmpty()) {
mcimadamore@690 2202 scan(supertypes);
mcimadamore@690 2203 }
mcimadamore@690 2204 else {
mcimadamore@690 2205 ClassType ct = (ClassType)c.type;
mcimadamore@690 2206 if (ct.supertype_field == null ||
mcimadamore@690 2207 ct.interfaces_field == null) {
mcimadamore@690 2208 //not completed yet
mcimadamore@690 2209 partialCheck = true;
mcimadamore@690 2210 return;
mcimadamore@690 2211 }
mcimadamore@690 2212 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2213 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2214 checkSymbol(pos, intf.tsym);
mcimadamore@690 2215 }
mcimadamore@690 2216 }
mcimadamore@690 2217 if (c.owner.kind == TYP) {
mcimadamore@690 2218 checkSymbol(pos, c.owner);
mcimadamore@690 2219 }
mcimadamore@690 2220 }
mcimadamore@690 2221 } finally {
mcimadamore@690 2222 seenClasses = seenClasses.tail;
mcimadamore@690 2223 }
mcimadamore@690 2224 }
mcimadamore@690 2225 }
mcimadamore@690 2226 }
mcimadamore@690 2227
duke@1 2228 /** Check for cyclic references. Issue an error if the
duke@1 2229 * symbol of the type referred to has a LOCKED flag set.
duke@1 2230 *
duke@1 2231 * @param pos Position to be used for error reporting.
duke@1 2232 * @param t The type referred to.
duke@1 2233 */
duke@1 2234 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2235 checkNonCyclicInternal(pos, t);
duke@1 2236 }
duke@1 2237
duke@1 2238
duke@1 2239 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2240 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2241 }
duke@1 2242
mcimadamore@236 2243 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2244 final TypeVar tv;
jjg@1374 2245 if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2246 return;
duke@1 2247 if (seen.contains(t)) {
jjg@1978 2248 tv = (TypeVar)t.unannotatedType();
jjg@110 2249 tv.bound = types.createErrorType(t);
duke@1 2250 log.error(pos, "cyclic.inheritance", t);
jjg@1374 2251 } else if (t.hasTag(TYPEVAR)) {
jjg@1978 2252 tv = (TypeVar)t.unannotatedType();
mcimadamore@236 2253 seen = seen.prepend(tv);
duke@1 2254 for (Type b : types.getBounds(tv))
duke@1 2255 checkNonCyclic1(pos, b, seen);
emc@2079 2256 } else if (t.hasTag(ARRAY)) {
emc@2079 2257 final ArrayType at = (ArrayType)t.unannotatedType();
emc@2079 2258 checkNonCyclic1(pos, at.elemtype, seen);
duke@1 2259 }
duke@1 2260 }
duke@1 2261
duke@1 2262 /** Check for cyclic references. Issue an error if the
duke@1 2263 * symbol of the type referred to has a LOCKED flag set.
duke@1 2264 *
duke@1 2265 * @param pos Position to be used for error reporting.
duke@1 2266 * @param t The type referred to.
duke@1 2267 * @returns True if the check completed on all attributed classes
duke@1 2268 */
duke@1 2269 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2270 boolean complete = true; // was the check complete?
duke@1 2271 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2272 Symbol c = t.tsym;
duke@1 2273 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2274
duke@1 2275 if ((c.flags_field & LOCKED) != 0) {
duke@1 2276 noteCyclic(pos, (ClassSymbol)c);
duke@1 2277 } else if (!c.type.isErroneous()) {
duke@1 2278 try {
duke@1 2279 c.flags_field |= LOCKED;
jjg@1374 2280 if (c.type.hasTag(CLASS)) {
duke@1 2281 ClassType clazz = (ClassType)c.type;
duke@1 2282 if (clazz.interfaces_field != null)
duke@1 2283 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2284 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2285 if (clazz.supertype_field != null) {
duke@1 2286 Type st = clazz.supertype_field;
jjg@1374 2287 if (st != null && st.hasTag(CLASS))
duke@1 2288 complete &= checkNonCyclicInternal(pos, st);
duke@1 2289 }
duke@1 2290 if (c.owner.kind == TYP)
duke@1 2291 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2292 }
duke@1 2293 } finally {
duke@1 2294 c.flags_field &= ~LOCKED;
duke@1 2295 }
duke@1 2296 }
duke@1 2297 if (complete)
duke@1 2298 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2299 if (complete) c.flags_field |= ACYCLIC;
duke@1 2300 return complete;
duke@1 2301 }
duke@1 2302
duke@1 2303 /** Note that we found an inheritance cycle. */
duke@1 2304 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2305 log.error(pos, "cyclic.inheritance", c);
duke@1 2306 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2307 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2308 Type st = types.supertype(c.type);
jjg@1374 2309 if (st.hasTag(CLASS))
jjg@110 2310 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2311 c.type = types.createErrorType(c, c.type);
duke@1 2312 c.flags_field |= ACYCLIC;
duke@1 2313 }
duke@1 2314
duke@1 2315 /** Check that all methods which implement some
duke@1 2316 * method conform to the method they implement.
duke@1 2317 * @param tree The class definition whose members are checked.
duke@1 2318 */
duke@1 2319 void checkImplementations(JCClassDecl tree) {
mcimadamore@1415 2320 checkImplementations(tree, tree.sym, tree.sym);
duke@1 2321 }
jjg@1521 2322 //where
duke@1 2323 /** Check that all methods which implement some
duke@1 2324 * method in `ic' conform to the method they implement.
duke@1 2325 */
mcimadamore@1415 2326 void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) {
duke@1 2327 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2328 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2329 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2330 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2331 if (e.sym.kind == MTH &&
duke@1 2332 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2333 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2334 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2335 if (implmeth != null && implmeth != absmeth &&
duke@1 2336 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2337 (origin.flags() & INTERFACE)) {
duke@1 2338 // don't check if implmeth is in a class, yet
duke@1 2339 // origin is an interface. This case arises only
duke@1 2340 // if implmeth is declared in Object. The reason is
duke@1 2341 // that interfaces really don't inherit from
duke@1 2342 // Object it's just that the compiler represents
duke@1 2343 // things that way.
duke@1 2344 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2345 }
duke@1 2346 }
duke@1 2347 }
duke@1 2348 }
duke@1 2349 }
duke@1 2350 }
duke@1 2351
duke@1 2352 /** Check that all abstract methods implemented by a class are
duke@1 2353 * mutually compatible.
duke@1 2354 * @param pos Position to be used for error reporting.
duke@1 2355 * @param c The class whose interfaces are checked.
duke@1 2356 */
duke@1 2357 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2358 List<Type> supertypes = types.interfaces(c);
duke@1 2359 Type supertype = types.supertype(c);
jjg@1374 2360 if (supertype.hasTag(CLASS) &&
duke@1 2361 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2362 supertypes = supertypes.prepend(supertype);
duke@1 2363 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2364 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2365 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2366 return;
duke@1 2367 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2368 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2369 return;
duke@1 2370 }
duke@1 2371 checkCompatibleConcretes(pos, c);
duke@1 2372 }
duke@1 2373
mcimadamore@359 2374 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2375 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2376 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2377 // VM allows methods and variables with differing types
mcimadamore@359 2378 if (sym.kind == e.sym.kind &&
mcimadamore@359 2379 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2380 sym != e.sym &&
mcimadamore@359 2381 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2382 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2383 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2384 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2385 return;
mcimadamore@359 2386 }
mcimadamore@359 2387 }
mcimadamore@359 2388 }
mcimadamore@359 2389 }
mcimadamore@359 2390
mcimadamore@780 2391 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2392 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2393 *
mcimadamore@780 2394 * @param pos Position to be used for error reporting.
mcimadamore@780 2395 * @param site The class whose methods are checked.
mcimadamore@780 2396 * @param sym The method symbol to be checked.
mcimadamore@780 2397 */
mcimadamore@858 2398 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2399 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2400 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2401 //by method 'sym' in 'site'...
vromero@2118 2402
vromero@2118 2403 List<MethodSymbol> potentiallyAmbiguousList = List.nil();
vromero@2118 2404 boolean overridesAny = false;
mcimadamore@1198 2405 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
vromero@2118 2406 if (!sym.overrides(m1, site.tsym, types, false)) {
vromero@2118 2407 if (m1 == sym) {
vromero@2118 2408 continue;
vromero@2118 2409 }
vromero@2118 2410
vromero@2118 2411 if (!overridesAny) {
vromero@2118 2412 potentiallyAmbiguousList = potentiallyAmbiguousList.prepend((MethodSymbol)m1);
vromero@2118 2413 }
vromero@2118 2414 continue;
vromero@2118 2415 }
vromero@2118 2416
vromero@2118 2417 if (m1 != sym) {
vromero@2118 2418 overridesAny = true;
vromero@2118 2419 potentiallyAmbiguousList = List.nil();
vromero@2118 2420 }
vromero@2118 2421
vromero@2118 2422 //...check each method m2 that is a member of 'site'
vromero@2118 2423 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2424 if (m2 == m1) continue;
mcimadamore@858 2425 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2426 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1393 2427 if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) &&
mcimadamore@1198 2428 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2429 sym.flags_field |= CLASH;
mcimadamore@1198 2430 String key = m1 == sym ?
mcimadamore@858 2431 "name.clash.same.erasure.no.override" :
mcimadamore@858 2432 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2433 log.error(pos,
mcimadamore@858 2434 key,
mcimadamore@858 2435 sym, sym.location(),
mcimadamore@1198 2436 m2, m2.location(),
mcimadamore@1198 2437 m1, m1.location());
mcimadamore@858 2438 return;
mcimadamore@858 2439 }
mcimadamore@780 2440 }
mcimadamore@780 2441 }
vromero@2118 2442
vromero@2118 2443 if (!overridesAny) {
vromero@2118 2444 for (MethodSymbol m: potentiallyAmbiguousList) {
vromero@2118 2445 checkPotentiallyAmbiguousOverloads(pos, site, sym, m);
vromero@2118 2446 }
vromero@2118 2447 }
mcimadamore@780 2448 }
mcimadamore@780 2449
mcimadamore@858 2450 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2451 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2452 *
mcimadamore@858 2453 * @param pos Position to be used for error reporting.
mcimadamore@858 2454 * @param site The class whose methods are checked.
mcimadamore@858 2455 * @param sym The method symbol to be checked.
mcimadamore@780 2456 */
mcimadamore@858 2457 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2458 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2459 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2460 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2461 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2462 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
vromero@2000 2463 if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck)) {
vromero@2000 2464 if (types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
vromero@2000 2465 log.error(pos,
vromero@2000 2466 "name.clash.same.erasure.no.hide",
vromero@2000 2467 sym, sym.location(),
vromero@2000 2468 s, s.location());
vromero@2000 2469 return;
vromero@2000 2470 } else {
vromero@2000 2471 checkPotentiallyAmbiguousOverloads(pos, site, sym, (MethodSymbol)s);
vromero@2000 2472 }
vromero@2000 2473 }
mcimadamore@858 2474 }
mcimadamore@858 2475 }
mcimadamore@780 2476
mcimadamore@858 2477 //where
mcimadamore@858 2478 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2479
mcimadamore@858 2480 Type site;
mcimadamore@780 2481
mcimadamore@858 2482 ClashFilter(Type site) {
mcimadamore@858 2483 this.site = site;
mcimadamore@858 2484 }
mcimadamore@858 2485
mcimadamore@858 2486 boolean shouldSkip(Symbol s) {
mcimadamore@858 2487 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2488 s.owner == site.tsym;
mcimadamore@858 2489 }
mcimadamore@858 2490
mcimadamore@858 2491 public boolean accepts(Symbol s) {
mcimadamore@858 2492 return s.kind == MTH &&
mcimadamore@858 2493 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2494 !shouldSkip(s) &&
mcimadamore@858 2495 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2496 !s.isConstructor();
mcimadamore@858 2497 }
mcimadamore@858 2498 }
mcimadamore@780 2499
mcimadamore@1393 2500 void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) {
mcimadamore@1393 2501 DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site);
mcimadamore@1393 2502 for (Symbol m : types.membersClosure(site, false).getElements(dcf)) {
mcimadamore@1393 2503 Assert.check(m.kind == MTH);
mcimadamore@1393 2504 List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m);
mcimadamore@1393 2505 if (prov.size() > 1) {
alundblad@2047 2506 ListBuffer<Symbol> abstracts = new ListBuffer<>();
alundblad@2047 2507 ListBuffer<Symbol> defaults = new ListBuffer<>();
mcimadamore@1393 2508 for (MethodSymbol provSym : prov) {
mcimadamore@1393 2509 if ((provSym.flags() & DEFAULT) != 0) {
mcimadamore@1393 2510 defaults = defaults.append(provSym);
mcimadamore@1393 2511 } else if ((provSym.flags() & ABSTRACT) != 0) {
mcimadamore@1393 2512 abstracts = abstracts.append(provSym);
mcimadamore@1393 2513 }
mcimadamore@1393 2514 if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) {
mcimadamore@1393 2515 //strong semantics - issue an error if two sibling interfaces
mcimadamore@1393 2516 //have two override-equivalent defaults - or if one is abstract
mcimadamore@1393 2517 //and the other is default
mcimadamore@1393 2518 String errKey;
mcimadamore@1393 2519 Symbol s1 = defaults.first();
mcimadamore@1393 2520 Symbol s2;
mcimadamore@1393 2521 if (defaults.size() > 1) {
mcimadamore@1393 2522 errKey = "types.incompatible.unrelated.defaults";
mcimadamore@1393 2523 s2 = defaults.toList().tail.head;
mcimadamore@1393 2524 } else {
mcimadamore@1393 2525 errKey = "types.incompatible.abstract.default";
mcimadamore@1393 2526 s2 = abstracts.first();
mcimadamore@1393 2527 }
mcimadamore@1393 2528 log.error(pos, errKey,
mcimadamore@1393 2529 Kinds.kindName(site.tsym), site,
mcimadamore@1393 2530 m.name, types.memberType(site, m).getParameterTypes(),
mcimadamore@1393 2531 s1.location(), s2.location());
mcimadamore@1393 2532 break;
mcimadamore@1393 2533 }
mcimadamore@1393 2534 }
mcimadamore@1393 2535 }
mcimadamore@1393 2536 }
mcimadamore@1393 2537 }
mcimadamore@1393 2538
mcimadamore@1393 2539 //where
mcimadamore@1393 2540 private class DefaultMethodClashFilter implements Filter<Symbol> {
mcimadamore@1393 2541
mcimadamore@1393 2542 Type site;
mcimadamore@1393 2543
mcimadamore@1393 2544 DefaultMethodClashFilter(Type site) {
mcimadamore@1393 2545 this.site = site;
mcimadamore@1393 2546 }
mcimadamore@1393 2547
mcimadamore@1393 2548 public boolean accepts(Symbol s) {
mcimadamore@1393 2549 return s.kind == MTH &&
mcimadamore@1393 2550 (s.flags() & DEFAULT) != 0 &&
mcimadamore@1393 2551 s.isInheritedIn(site.tsym, types) &&
mcimadamore@1393 2552 !s.isConstructor();
mcimadamore@1393 2553 }
mcimadamore@1393 2554 }
mcimadamore@1393 2555
vromero@2000 2556 /**
vromero@2000 2557 * Report warnings for potentially ambiguous method declarations. Two declarations
vromero@2000 2558 * are potentially ambiguous if they feature two unrelated functional interface
vromero@2000 2559 * in same argument position (in which case, a call site passing an implicit
vromero@2000 2560 * lambda would be ambiguous).
vromero@2000 2561 */
vromero@2000 2562 void checkPotentiallyAmbiguousOverloads(DiagnosticPosition pos, Type site,
vromero@2000 2563 MethodSymbol msym1, MethodSymbol msym2) {
vromero@2000 2564 if (msym1 != msym2 &&
vromero@2000 2565 allowDefaultMethods &&
vromero@2000 2566 lint.isEnabled(LintCategory.OVERLOADS) &&
vromero@2000 2567 (msym1.flags() & POTENTIALLY_AMBIGUOUS) == 0 &&
vromero@2000 2568 (msym2.flags() & POTENTIALLY_AMBIGUOUS) == 0) {
vromero@2000 2569 Type mt1 = types.memberType(site, msym1);
vromero@2000 2570 Type mt2 = types.memberType(site, msym2);
vromero@2000 2571 //if both generic methods, adjust type variables
vromero@2000 2572 if (mt1.hasTag(FORALL) && mt2.hasTag(FORALL) &&
vromero@2000 2573 types.hasSameBounds((ForAll)mt1, (ForAll)mt2)) {
vromero@2000 2574 mt2 = types.subst(mt2, ((ForAll)mt2).tvars, ((ForAll)mt1).tvars);
vromero@2000 2575 }
vromero@2000 2576 //expand varargs methods if needed
vromero@2000 2577 int maxLength = Math.max(mt1.getParameterTypes().length(), mt2.getParameterTypes().length());
vromero@2000 2578 List<Type> args1 = rs.adjustArgs(mt1.getParameterTypes(), msym1, maxLength, true);
vromero@2000 2579 List<Type> args2 = rs.adjustArgs(mt2.getParameterTypes(), msym2, maxLength, true);
vromero@2000 2580 //if arities don't match, exit
vromero@2000 2581 if (args1.length() != args2.length()) return;
vromero@2000 2582 boolean potentiallyAmbiguous = false;
vromero@2000 2583 while (args1.nonEmpty() && args2.nonEmpty()) {
vromero@2000 2584 Type s = args1.head;
vromero@2000 2585 Type t = args2.head;
vromero@2000 2586 if (!types.isSubtype(t, s) && !types.isSubtype(s, t)) {
vromero@2000 2587 if (types.isFunctionalInterface(s) && types.isFunctionalInterface(t) &&
vromero@2000 2588 types.findDescriptorType(s).getParameterTypes().length() > 0 &&
vromero@2000 2589 types.findDescriptorType(s).getParameterTypes().length() ==
vromero@2000 2590 types.findDescriptorType(t).getParameterTypes().length()) {
vromero@2000 2591 potentiallyAmbiguous = true;
vromero@2000 2592 } else {
vromero@2000 2593 break;
vromero@2000 2594 }
vromero@2000 2595 }
vromero@2000 2596 args1 = args1.tail;
vromero@2000 2597 args2 = args2.tail;
vromero@2000 2598 }
vromero@2000 2599 if (potentiallyAmbiguous) {
vromero@2000 2600 //we found two incompatible functional interfaces with same arity
vromero@2000 2601 //this means a call site passing an implicit lambda would be ambigiuous
vromero@2000 2602 msym1.flags_field |= POTENTIALLY_AMBIGUOUS;
vromero@2000 2603 msym2.flags_field |= POTENTIALLY_AMBIGUOUS;
vromero@2000 2604 log.warning(LintCategory.OVERLOADS, pos, "potentially.ambiguous.overload",
vromero@2000 2605 msym1, msym1.location(),
vromero@2000 2606 msym2, msym2.location());
vromero@2000 2607 return;
vromero@2000 2608 }
vromero@2000 2609 }
vromero@2000 2610 }
vromero@2000 2611
mcimadamore@359 2612 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2613 */
mcimadamore@359 2614 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2615 if (!sym.type.isErroneous()) {
mcimadamore@359 2616 if (warnOnSyntheticConflicts) {
mcimadamore@359 2617 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2618 }
mcimadamore@359 2619 else {
mcimadamore@359 2620 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2621 }
mcimadamore@359 2622 }
mcimadamore@359 2623 }
mcimadamore@359 2624
duke@1 2625 /** Check that class c does not implement directly or indirectly
duke@1 2626 * the same parameterized interface with two different argument lists.
duke@1 2627 * @param pos Position to be used for error reporting.
duke@1 2628 * @param type The type whose interfaces are checked.
duke@1 2629 */
duke@1 2630 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2631 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2632 }
duke@1 2633 //where
duke@1 2634 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2635 * with their class symbol as key and their type as value. Make
duke@1 2636 * sure no class is entered with two different types.
duke@1 2637 */
duke@1 2638 void checkClassBounds(DiagnosticPosition pos,
duke@1 2639 Map<TypeSymbol,Type> seensofar,
duke@1 2640 Type type) {
duke@1 2641 if (type.isErroneous()) return;
duke@1 2642 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2643 Type it = l.head;
duke@1 2644 Type oldit = seensofar.put(it.tsym, it);
duke@1 2645 if (oldit != null) {
duke@1 2646 List<Type> oldparams = oldit.allparams();
duke@1 2647 List<Type> newparams = it.allparams();
duke@1 2648 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2649 log.error(pos, "cant.inherit.diff.arg",
duke@1 2650 it.tsym, Type.toString(oldparams),
duke@1 2651 Type.toString(newparams));
duke@1 2652 }
duke@1 2653 checkClassBounds(pos, seensofar, it);
duke@1 2654 }
duke@1 2655 Type st = types.supertype(type);
duke@1 2656 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2657 }
duke@1 2658
duke@1 2659 /** Enter interface into into set.
duke@1 2660 * If it existed already, issue a "repeated interface" error.
duke@1 2661 */
duke@1 2662 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2663 if (its.contains(it))
duke@1 2664 log.error(pos, "repeated.interface");
duke@1 2665 else {
duke@1 2666 its.add(it);
duke@1 2667 }
duke@1 2668 }
duke@1 2669
duke@1 2670 /* *************************************************************************
duke@1 2671 * Check annotations
duke@1 2672 **************************************************************************/
duke@1 2673
mcimadamore@629 2674 /**
mcimadamore@634 2675 * Recursively validate annotations values
mcimadamore@629 2676 */
mcimadamore@634 2677 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2678 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2679 @Override
mcimadamore@629 2680 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2681 if (!tree.type.isErroneous()) {
jjg@1017 2682 super.visitAnnotation(tree);
jjg@1017 2683 validateAnnotation(tree);
jjg@1017 2684 }
mcimadamore@629 2685 }
mcimadamore@629 2686 }
mcimadamore@634 2687 tree.accept(new AnnotationValidator());
mcimadamore@629 2688 }
mcimadamore@629 2689
jjg@1326 2690 /**
jjg@1326 2691 * {@literal
jjg@1326 2692 * Annotation types are restricted to primitives, String, an
duke@1 2693 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2694 * Anything>, arrays of the preceding.
jjg@1326 2695 * }
duke@1 2696 */
duke@1 2697 void validateAnnotationType(JCTree restype) {
duke@1 2698 // restype may be null if an error occurred, so don't bother validating it
duke@1 2699 if (restype != null) {
duke@1 2700 validateAnnotationType(restype.pos(), restype.type);
duke@1 2701 }
duke@1 2702 }
duke@1 2703
duke@1 2704 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2705 if (type.isPrimitive()) return;
duke@1 2706 if (types.isSameType(type, syms.stringType)) return;
duke@1 2707 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2708 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2709 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2710 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2711 validateAnnotationType(pos, types.elemtype(type));
duke@1 2712 return;
duke@1 2713 }
duke@1 2714 log.error(pos, "invalid.annotation.member.type");
duke@1 2715 }
duke@1 2716
duke@1 2717 /**
duke@1 2718 * "It is also a compile-time error if any method declared in an
duke@1 2719 * annotation type has a signature that is override-equivalent to
duke@1 2720 * that of any public or protected method declared in class Object
duke@1 2721 * or in the interface annotation.Annotation."
duke@1 2722 *
jjh@972 2723 * @jls 9.6 Annotation Types
duke@1 2724 */
duke@1 2725 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
jjg@1374 2726 for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
duke@1 2727 Scope s = sup.tsym.members();
duke@1 2728 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2729 if (e.sym.kind == MTH &&
duke@1 2730 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2731 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2732 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2733 }
duke@1 2734 }
duke@1 2735 }
duke@1 2736
duke@1 2737 /** Check the annotations of a symbol.
duke@1 2738 */
duke@1 2739 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2740 for (JCAnnotation a : annotations)
duke@1 2741 validateAnnotation(a, s);
duke@1 2742 }
duke@1 2743
jjg@1521 2744 /** Check the type annotations.
jjg@1521 2745 */
jjg@1521 2746 public void validateTypeAnnotations(List<JCAnnotation> annotations, boolean isTypeParameter) {
jjg@1521 2747 for (JCAnnotation a : annotations)
jjg@1521 2748 validateTypeAnnotation(a, isTypeParameter);
jjg@1521 2749 }
jjg@1521 2750
duke@1 2751 /** Check an annotation of a symbol.
duke@1 2752 */
jfranck@1313 2753 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2754 validateAnnotationTree(a);
duke@1 2755
duke@1 2756 if (!annotationApplicable(a, s))
duke@1 2757 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2758
mcimadamore@1497 2759 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
mcimadamore@1497 2760 if (s.kind != TYP) {
mcimadamore@1497 2761 log.error(a.pos(), "bad.functional.intf.anno");
jlahoda@2111 2762 } else if (!s.isInterface() || (s.flags() & ANNOTATION) != 0) {
jlahoda@2111 2763 log.error(a.pos(), "bad.functional.intf.anno.1", diags.fragment("not.a.functional.intf", s));
mcimadamore@1497 2764 }
mcimadamore@1497 2765 }
duke@1 2766 }
duke@1 2767
jjg@1521 2768 public void validateTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2769 Assert.checkNonNull(a.type, "annotation tree hasn't been attributed yet: " + a);
jjg@1521 2770 validateAnnotationTree(a);
jjg@1521 2771
jjg@2134 2772 if (a.hasTag(TYPE_ANNOTATION) &&
jjg@2134 2773 !a.annotationType.type.isErroneous() &&
jjg@2134 2774 !isTypeAnnotation(a, isTypeParameter)) {
jjg@1521 2775 log.error(a.pos(), "annotation.type.not.applicable");
jjg@2134 2776 }
jjg@1521 2777 }
jjg@1521 2778
jfranck@1313 2779 /**
jjg@1492 2780 * Validate the proposed container 'repeatable' on the
jfranck@1313 2781 * annotation type symbol 's'. Report errors at position
jfranck@1313 2782 * 'pos'.
jfranck@1313 2783 *
jjg@1492 2784 * @param s The (annotation)type declaration annotated with a @Repeatable
jjg@1492 2785 * @param repeatable the @Repeatable on 's'
jfranck@1313 2786 * @param pos where to report errors
jfranck@1313 2787 */
jjg@1492 2788 public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) {
jjg@1492 2789 Assert.check(types.isSameType(repeatable.type, syms.repeatableType));
jfranck@1313 2790
jfranck@1313 2791 Type t = null;
jjg@1492 2792 List<Pair<MethodSymbol,Attribute>> l = repeatable.values;
jfranck@1313 2793 if (!l.isEmpty()) {
jfranck@1313 2794 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2795 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2796 }
jfranck@1313 2797
jfranck@1313 2798 if (t == null) {
jjg@1492 2799 // errors should already have been reported during Annotate
jfranck@1313 2800 return;
jfranck@1313 2801 }
jfranck@1313 2802
jjg@1492 2803 validateValue(t.tsym, s, pos);
jfranck@1313 2804 validateRetention(t.tsym, s, pos);
jfranck@1313 2805 validateDocumented(t.tsym, s, pos);
jfranck@1313 2806 validateInherited(t.tsym, s, pos);
jfranck@1313 2807 validateTarget(t.tsym, s, pos);
jfranck@1344 2808 validateDefault(t.tsym, s, pos);
jfranck@1313 2809 }
jfranck@1313 2810
jjg@1492 2811 private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jjg@1492 2812 Scope.Entry e = container.members().lookup(names.value);
jjg@1492 2813 if (e.scope != null && e.sym.kind == MTH) {
jjg@1492 2814 MethodSymbol m = (MethodSymbol) e.sym;
jjg@1492 2815 Type ret = m.getReturnType();
jjg@1492 2816 if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) {
jjg@1492 2817 log.error(pos, "invalid.repeatable.annotation.value.return",
jjg@1492 2818 container, ret, types.makeArrayType(contained.type));
jjg@1492 2819 }
jjg@1492 2820 } else {
jjg@1492 2821 log.error(pos, "invalid.repeatable.annotation.no.value", container);
jfranck@1313 2822 }
jfranck@1313 2823 }
jfranck@1313 2824
jfranck@1313 2825 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2826 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2827 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2828
jfranck@1313 2829 boolean error = false;
jfranck@1313 2830 switch (containedRetention) {
jfranck@1313 2831 case RUNTIME:
jfranck@1313 2832 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2833 error = true;
jfranck@1313 2834 }
jfranck@1313 2835 break;
jfranck@1313 2836 case CLASS:
jfranck@1313 2837 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2838 error = true;
jfranck@1313 2839 }
jfranck@1313 2840 }
jfranck@1313 2841 if (error ) {
jjg@1492 2842 log.error(pos, "invalid.repeatable.annotation.retention",
jfranck@1313 2843 container, containerRetention,
jfranck@1313 2844 contained, containedRetention);
jfranck@1313 2845 }
jfranck@1313 2846 }
jfranck@1313 2847
jfranck@1313 2848 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2849 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2850 if (container.attribute(syms.documentedType.tsym) == null) {
jjg@1492 2851 log.error(pos, "invalid.repeatable.annotation.not.documented", container, contained);
jfranck@1313 2852 }
jfranck@1313 2853 }
jfranck@1313 2854 }
jfranck@1313 2855
jfranck@1313 2856 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2857 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2858 if (container.attribute(syms.inheritedType.tsym) == null) {
jjg@1492 2859 log.error(pos, "invalid.repeatable.annotation.not.inherited", container, contained);
jfranck@1313 2860 }
jfranck@1313 2861 }
jfranck@1313 2862 }
jfranck@1313 2863
jfranck@1313 2864 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1634 2865 // The set of targets the container is applicable to must be a subset
jfranck@1634 2866 // (with respect to annotation target semantics) of the set of targets
jfranck@1634 2867 // the contained is applicable to. The target sets may be implicit or
jfranck@1634 2868 // explicit.
jfranck@1634 2869
jfranck@1634 2870 Set<Name> containerTargets;
jfranck@1313 2871 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2872 if (containerTarget == null) {
jfranck@1634 2873 containerTargets = getDefaultTargetSet();
jfranck@1634 2874 } else {
jfranck@1634 2875 containerTargets = new HashSet<Name>();
jfranck@1313 2876 for (Attribute app : containerTarget.values) {
jfranck@1313 2877 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2878 continue; // recovery
jfranck@1313 2879 }
jfranck@1313 2880 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2881 containerTargets.add(e.value.name);
jfranck@1313 2882 }
jfranck@1634 2883 }
jfranck@1634 2884
jfranck@1634 2885 Set<Name> containedTargets;
jfranck@1634 2886 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1634 2887 if (containedTarget == null) {
jfranck@1634 2888 containedTargets = getDefaultTargetSet();
jfranck@1634 2889 } else {
jfranck@1634 2890 containedTargets = new HashSet<Name>();
jfranck@1313 2891 for (Attribute app : containedTarget.values) {
jfranck@1313 2892 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2893 continue; // recovery
jfranck@1313 2894 }
jfranck@1313 2895 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2896 containedTargets.add(e.value.name);
jfranck@1313 2897 }
jfranck@1634 2898 }
jfranck@1634 2899
jfranck@1634 2900 if (!isTargetSubsetOf(containerTargets, containedTargets)) {
jjg@1492 2901 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2902 }
jfranck@1313 2903 }
jfranck@1313 2904
jfranck@1634 2905 /* get a set of names for the default target */
jfranck@1634 2906 private Set<Name> getDefaultTargetSet() {
jfranck@1634 2907 if (defaultTargets == null) {
jfranck@1634 2908 Set<Name> targets = new HashSet<Name>();
jfranck@1634 2909 targets.add(names.ANNOTATION_TYPE);
jfranck@1634 2910 targets.add(names.CONSTRUCTOR);
jfranck@1634 2911 targets.add(names.FIELD);
jfranck@1634 2912 targets.add(names.LOCAL_VARIABLE);
jfranck@1634 2913 targets.add(names.METHOD);
jfranck@1634 2914 targets.add(names.PACKAGE);
jfranck@1634 2915 targets.add(names.PARAMETER);
jfranck@1634 2916 targets.add(names.TYPE);
jfranck@1634 2917
jfranck@1634 2918 defaultTargets = java.util.Collections.unmodifiableSet(targets);
jfranck@1634 2919 }
jfranck@1634 2920
jfranck@1634 2921 return defaultTargets;
jfranck@1634 2922 }
jfranck@1634 2923 private Set<Name> defaultTargets;
jfranck@1634 2924
jfranck@1634 2925
jfranck@1634 2926 /** Checks that s is a subset of t, with respect to ElementType
jfranck@1313 2927 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE}
jfranck@1313 2928 */
jfranck@1634 2929 private boolean isTargetSubsetOf(Set<Name> s, Set<Name> t) {
jfranck@1634 2930 // Check that all elements in s are present in t
jfranck@1634 2931 for (Name n2 : s) {
jfranck@1313 2932 boolean currentElementOk = false;
jfranck@1634 2933 for (Name n1 : t) {
jfranck@1313 2934 if (n1 == n2) {
jfranck@1313 2935 currentElementOk = true;
jfranck@1313 2936 break;
jfranck@1313 2937 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2938 currentElementOk = true;
jfranck@1313 2939 break;
jfranck@1313 2940 }
jfranck@1313 2941 }
jfranck@1313 2942 if (!currentElementOk)
jfranck@1313 2943 return false;
jfranck@1313 2944 }
jfranck@1313 2945 return true;
jfranck@1313 2946 }
jfranck@1313 2947
jfranck@1344 2948 private void validateDefault(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1344 2949 // validate that all other elements of containing type has defaults
jfranck@1344 2950 Scope scope = container.members();
jfranck@1344 2951 for(Symbol elm : scope.getElements()) {
jfranck@1344 2952 if (elm.name != names.value &&
jfranck@1344 2953 elm.kind == Kinds.MTH &&
jfranck@1344 2954 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2955 log.error(pos,
jjg@1492 2956 "invalid.repeatable.annotation.elem.nondefault",
jfranck@1344 2957 container,
jfranck@1344 2958 elm);
jfranck@1344 2959 }
jfranck@1344 2960 }
jfranck@1344 2961 }
jfranck@1344 2962
duke@1 2963 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2964 boolean isOverrider(Symbol s) {
duke@1 2965 if (s.kind != MTH || s.isStatic())
duke@1 2966 return false;
duke@1 2967 MethodSymbol m = (MethodSymbol)s;
duke@1 2968 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2969 for (Type sup : types.closure(owner.type)) {
duke@1 2970 if (sup == owner.type)
duke@1 2971 continue; // skip "this"
duke@1 2972 Scope scope = sup.tsym.members();
duke@1 2973 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2974 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2975 return true;
duke@1 2976 }
duke@1 2977 }
duke@1 2978 return false;
duke@1 2979 }
duke@1 2980
jlahoda@2111 2981 /** Is the annotation applicable to types? */
jjg@1521 2982 protected boolean isTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2983 Attribute.Compound atTarget =
jjg@1521 2984 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
jjg@1521 2985 if (atTarget == null) {
jjg@1521 2986 // An annotation without @Target is not a type annotation.
jjg@1521 2987 return false;
jjg@1521 2988 }
jjg@1521 2989
jjg@1521 2990 Attribute atValue = atTarget.member(names.value);
jjg@1521 2991 if (!(atValue instanceof Attribute.Array)) {
jjg@1521 2992 return false; // error recovery
jjg@1521 2993 }
jjg@1521 2994
jjg@1521 2995 Attribute.Array arr = (Attribute.Array) atValue;
jjg@1521 2996 for (Attribute app : arr.values) {
jjg@1521 2997 if (!(app instanceof Attribute.Enum)) {
jjg@1521 2998 return false; // recovery
jjg@1521 2999 }
jjg@1521 3000 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 3001
jjg@1521 3002 if (e.value.name == names.TYPE_USE)
jjg@1521 3003 return true;
jjg@1521 3004 else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER)
jjg@1521 3005 return true;
jjg@1521 3006 }
jjg@1521 3007 return false;
jjg@1521 3008 }
jjg@1521 3009
duke@1 3010 /** Is the annotation applicable to the symbol? */
duke@1 3011 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 3012 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jjg@1521 3013 Name[] targets;
jjg@1521 3014
jfranck@1313 3015 if (arr == null) {
jjg@1521 3016 targets = defaultTargetMetaInfo(a, s);
jjg@1521 3017 } else {
jjg@1521 3018 // TODO: can we optimize this?
jjg@1521 3019 targets = new Name[arr.values.length];
jjg@1521 3020 for (int i=0; i<arr.values.length; ++i) {
jjg@1521 3021 Attribute app = arr.values[i];
jjg@1521 3022 if (!(app instanceof Attribute.Enum)) {
jjg@1521 3023 return true; // recovery
jjg@1521 3024 }
jjg@1521 3025 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 3026 targets[i] = e.value.name;
jjg@1521 3027 }
jfranck@1313 3028 }
jjg@1521 3029 for (Name target : targets) {
jjg@1521 3030 if (target == names.TYPE)
duke@1 3031 { if (s.kind == TYP) return true; }
jjg@1521 3032 else if (target == names.FIELD)
duke@1 3033 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
jjg@1521 3034 else if (target == names.METHOD)
duke@1 3035 { if (s.kind == MTH && !s.isConstructor()) return true; }
jjg@1521 3036 else if (target == names.PARAMETER)
duke@1 3037 { if (s.kind == VAR &&
duke@1 3038 s.owner.kind == MTH &&
duke@1 3039 (s.flags() & PARAMETER) != 0)
duke@1 3040 return true;
duke@1 3041 }
jjg@1521 3042 else if (target == names.CONSTRUCTOR)
duke@1 3043 { if (s.kind == MTH && s.isConstructor()) return true; }
jjg@1521 3044 else if (target == names.LOCAL_VARIABLE)
duke@1 3045 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 3046 (s.flags() & PARAMETER) == 0)
duke@1 3047 return true;
duke@1 3048 }
jjg@1521 3049 else if (target == names.ANNOTATION_TYPE)
duke@1 3050 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 3051 return true;
duke@1 3052 }
jjg@1521 3053 else if (target == names.PACKAGE)
duke@1 3054 { if (s.kind == PCK) return true; }
jjg@1521 3055 else if (target == names.TYPE_USE)
jjg@308 3056 { if (s.kind == TYP ||
jjg@308 3057 s.kind == VAR ||
jjg@308 3058 (s.kind == MTH && !s.isConstructor() &&
jjg@1521 3059 !s.type.getReturnType().hasTag(VOID)) ||
jjg@1521 3060 (s.kind == MTH && s.isConstructor()))
jjg@1521 3061 return true;
jjg@1521 3062 }
jjg@1521 3063 else if (target == names.TYPE_PARAMETER)
jjg@1521 3064 { if (s.kind == TYP && s.type.hasTag(TYPEVAR))
jjg@308 3065 return true;
jjg@308 3066 }
duke@1 3067 else
duke@1 3068 return true; // recovery
duke@1 3069 }
duke@1 3070 return false;
duke@1 3071 }
duke@1 3072
jfranck@1313 3073
jfranck@1313 3074 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 3075 Attribute.Compound atTarget =
jfranck@1313 3076 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 3077 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 3078 Attribute atValue = atTarget.member(names.value);
jfranck@1313 3079 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 3080 return (Attribute.Array) atValue;
jfranck@1313 3081 }
jfranck@1313 3082
jjg@1521 3083 private final Name[] dfltTargetMeta;
jjg@1521 3084 private Name[] defaultTargetMetaInfo(JCAnnotation a, Symbol s) {
jjg@1521 3085 return dfltTargetMeta;
jjg@1521 3086 }
jjg@1521 3087
duke@1 3088 /** Check an annotation value.
jfranck@1445 3089 *
jfranck@1445 3090 * @param a The annotation tree to check
jfranck@1445 3091 * @return true if this annotation tree is valid, otherwise false
duke@1 3092 */
jfranck@1445 3093 public boolean validateAnnotationDeferErrors(JCAnnotation a) {
jfranck@1445 3094 boolean res = false;
jfranck@1445 3095 final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log);
jfranck@1445 3096 try {
jfranck@1445 3097 res = validateAnnotation(a);
jfranck@1445 3098 } finally {
jfranck@1445 3099 log.popDiagnosticHandler(diagHandler);
jfranck@1445 3100 }
jfranck@1445 3101 return res;
jfranck@1445 3102 }
jfranck@1445 3103
jfranck@1445 3104 private boolean validateAnnotation(JCAnnotation a) {
jfranck@1445 3105 boolean isValid = true;
jfranck@1445 3106 // collect an inventory of the annotation elements
jfranck@1445 3107 Set<MethodSymbol> members = new LinkedHashSet<MethodSymbol>();
duke@1 3108 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
jfranck@1729 3109 e != null;
jfranck@1729 3110 e = e.sibling)
mcimadamore@1920 3111 if (e.sym.kind == MTH && e.sym.name != names.clinit &&
mcimadamore@1920 3112 (e.sym.flags() & SYNTHETIC) == 0)
duke@1 3113 members.add((MethodSymbol) e.sym);
duke@1 3114
jfranck@1445 3115 // remove the ones that are assigned values
duke@1 3116 for (JCTree arg : a.args) {
jjg@1127 3117 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 3118 JCAssign assign = (JCAssign) arg;
duke@1 3119 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 3120 if (m == null || m.type.isErroneous()) continue;
jfranck@1445 3121 if (!members.remove(m)) {
jfranck@1445 3122 isValid = false;
jjg@479 3123 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 3124 m.name, a.type);
jfranck@1445 3125 }
duke@1 3126 }
duke@1 3127
duke@1 3128 // all the remaining ones better have default values
jfranck@1445 3129 List<Name> missingDefaults = List.nil();
mcimadamore@632 3130 for (MethodSymbol m : members) {
mcimadamore@632 3131 if (m.defaultValue == null && !m.type.isErroneous()) {
jfranck@1445 3132 missingDefaults = missingDefaults.append(m.name);
mcimadamore@632 3133 }
mcimadamore@632 3134 }
jfranck@1445 3135 missingDefaults = missingDefaults.reverse();
mcimadamore@632 3136 if (missingDefaults.nonEmpty()) {
jfranck@1445 3137 isValid = false;
mcimadamore@632 3138 String key = (missingDefaults.size() > 1)
mcimadamore@632 3139 ? "annotation.missing.default.value.1"
mcimadamore@632 3140 : "annotation.missing.default.value";
mcimadamore@632 3141 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 3142 }
duke@1 3143
duke@1 3144 // special case: java.lang.annotation.Target must not have
duke@1 3145 // repeated values in its value member
duke@1 3146 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 3147 a.args.tail == null)
jfranck@1445 3148 return isValid;
duke@1 3149
jfranck@1445 3150 if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery
duke@1 3151 JCAssign assign = (JCAssign) a.args.head;
duke@1 3152 Symbol m = TreeInfo.symbol(assign.lhs);
jfranck@1445 3153 if (m.name != names.value) return false;
duke@1 3154 JCTree rhs = assign.rhs;
jfranck@1445 3155 if (!rhs.hasTag(NEWARRAY)) return false;
duke@1 3156 JCNewArray na = (JCNewArray) rhs;
duke@1 3157 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 3158 for (JCTree elem : na.elems) {
duke@1 3159 if (!targets.add(TreeInfo.symbol(elem))) {
jfranck@1445 3160 isValid = false;
duke@1 3161 log.error(elem.pos(), "repeated.annotation.target");
duke@1 3162 }
duke@1 3163 }
jfranck@1445 3164 return isValid;
duke@1 3165 }
duke@1 3166
duke@1 3167 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 3168 if (allowAnnotations &&
mcimadamore@795 3169 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 3170 (s.flags() & DEPRECATED) != 0 &&
duke@1 3171 !syms.deprecatedType.isErroneous() &&
duke@1 3172 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 3173 log.warning(LintCategory.DEP_ANN,
jjg@612 3174 pos, "missing.deprecated.annotation");
duke@1 3175 }
duke@1 3176 }
duke@1 3177
mcimadamore@852 3178 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 3179 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 3180 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 3181 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 3182 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3183 @Override
mcimadamore@852 3184 public void report() {
mcimadamore@852 3185 warnDeprecated(pos, s);
mcimadamore@852 3186 }
mcimadamore@852 3187 });
jjg@1157 3188 }
mcimadamore@852 3189 }
mcimadamore@852 3190
mcimadamore@852 3191 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 3192 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 3193 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3194 public void report() {
mcimadamore@852 3195 if (enableSunApiLintControl)
mcimadamore@852 3196 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 3197 else
mcimadamore@1218 3198 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 3199 }
mcimadamore@852 3200 });
mcimadamore@852 3201 }
mcimadamore@852 3202 }
mcimadamore@852 3203
jjg@1569 3204 void checkProfile(final DiagnosticPosition pos, final Symbol s) {
jjg@1569 3205 if (profile != Profile.DEFAULT && (s.flags() & NOT_IN_PROFILE) != 0) {
jjg@1569 3206 log.error(pos, "not.in.profile", s, profile);
jjg@1569 3207 }
jjg@1569 3208 }
jjg@1569 3209
duke@1 3210 /* *************************************************************************
duke@1 3211 * Check for recursive annotation elements.
duke@1 3212 **************************************************************************/
duke@1 3213
duke@1 3214 /** Check for cycles in the graph of annotation elements.
duke@1 3215 */
duke@1 3216 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 3217 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 3218 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 3219 try {
duke@1 3220 tree.sym.flags_field |= LOCKED;
duke@1 3221 for (JCTree def : tree.defs) {
jjg@1127 3222 if (!def.hasTag(METHODDEF)) continue;
duke@1 3223 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 3224 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 3225 }
duke@1 3226 } finally {
duke@1 3227 tree.sym.flags_field &= ~LOCKED;
duke@1 3228 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 3229 }
duke@1 3230 }
duke@1 3231
duke@1 3232 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 3233 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 3234 return;
duke@1 3235 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 3236 log.error(pos, "cyclic.annotation.element");
duke@1 3237 return;
duke@1 3238 }
duke@1 3239 try {
duke@1 3240 tsym.flags_field |= LOCKED;
duke@1 3241 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 3242 Symbol s = e.sym;
duke@1 3243 if (s.kind != Kinds.MTH)
duke@1 3244 continue;
duke@1 3245 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 3246 }
duke@1 3247 } finally {
duke@1 3248 tsym.flags_field &= ~LOCKED;
duke@1 3249 tsym.flags_field |= ACYCLIC_ANN;
duke@1 3250 }
duke@1 3251 }
duke@1 3252
duke@1 3253 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
jjg@1374 3254 switch (type.getTag()) {
jjg@1374 3255 case CLASS:
duke@1 3256 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 3257 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 3258 break;
jjg@1374 3259 case ARRAY:
duke@1 3260 checkAnnotationResType(pos, types.elemtype(type));
duke@1 3261 break;
duke@1 3262 default:
duke@1 3263 break; // int etc
duke@1 3264 }
duke@1 3265 }
duke@1 3266
duke@1 3267 /* *************************************************************************
duke@1 3268 * Check for cycles in the constructor call graph.
duke@1 3269 **************************************************************************/
duke@1 3270
duke@1 3271 /** Check for cycles in the graph of constructors calling other
duke@1 3272 * constructors.
duke@1 3273 */
duke@1 3274 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 3275 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 3276
duke@1 3277 // enter each constructor this-call into the map
duke@1 3278 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 3279 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 3280 if (app == null) continue;
duke@1 3281 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 3282 if (TreeInfo.name(app.meth) == names._this) {
duke@1 3283 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 3284 } else {
duke@1 3285 meth.sym.flags_field |= ACYCLIC;
duke@1 3286 }
duke@1 3287 }
duke@1 3288
duke@1 3289 // Check for cycles in the map
duke@1 3290 Symbol[] ctors = new Symbol[0];
duke@1 3291 ctors = callMap.keySet().toArray(ctors);
duke@1 3292 for (Symbol caller : ctors) {
duke@1 3293 checkCyclicConstructor(tree, caller, callMap);
duke@1 3294 }
duke@1 3295 }
duke@1 3296
duke@1 3297 /** Look in the map to see if the given constructor is part of a
duke@1 3298 * call cycle.
duke@1 3299 */
duke@1 3300 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 3301 Map<Symbol,Symbol> callMap) {
duke@1 3302 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 3303 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 3304 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 3305 "recursive.ctor.invocation");
duke@1 3306 } else {
duke@1 3307 ctor.flags_field |= LOCKED;
duke@1 3308 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 3309 ctor.flags_field &= ~LOCKED;
duke@1 3310 }
duke@1 3311 ctor.flags_field |= ACYCLIC;
duke@1 3312 }
duke@1 3313 }
duke@1 3314
duke@1 3315 /* *************************************************************************
duke@1 3316 * Miscellaneous
duke@1 3317 **************************************************************************/
duke@1 3318
duke@1 3319 /**
duke@1 3320 * Return the opcode of the operator but emit an error if it is an
duke@1 3321 * error.
duke@1 3322 * @param pos position for error reporting.
duke@1 3323 * @param operator an operator
duke@1 3324 * @param tag a tree tag
duke@1 3325 * @param left type of left hand side
duke@1 3326 * @param right type of right hand side
duke@1 3327 */
duke@1 3328 int checkOperator(DiagnosticPosition pos,
duke@1 3329 OperatorSymbol operator,
jjg@1127 3330 JCTree.Tag tag,
duke@1 3331 Type left,
duke@1 3332 Type right) {
duke@1 3333 if (operator.opcode == ByteCodes.error) {
duke@1 3334 log.error(pos,
mcimadamore@853 3335 "operator.cant.be.applied.1",
duke@1 3336 treeinfo.operatorName(tag),
mcimadamore@853 3337 left, right);
duke@1 3338 }
duke@1 3339 return operator.opcode;
duke@1 3340 }
duke@1 3341
duke@1 3342
duke@1 3343 /**
duke@1 3344 * Check for division by integer constant zero
duke@1 3345 * @param pos Position for error reporting.
duke@1 3346 * @param operator The operator for the expression
duke@1 3347 * @param operand The right hand operand for the expression
duke@1 3348 */
duke@1 3349 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3350 if (operand.constValue() != null
mcimadamore@795 3351 && lint.isEnabled(LintCategory.DIVZERO)
vromero@1826 3352 && operand.getTag().isSubRangeOf(LONG)
duke@1 3353 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3354 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3355 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3356 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3357 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3358 }
duke@1 3359 }
duke@1 3360 }
duke@1 3361
duke@1 3362 /**
duke@1 3363 * Check for empty statements after if
duke@1 3364 */
duke@1 3365 void checkEmptyIf(JCIf tree) {
jjg@1127 3366 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3367 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3368 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3369 }
duke@1 3370
duke@1 3371 /** Check that symbol is unique in given scope.
duke@1 3372 * @param pos Position for error reporting.
duke@1 3373 * @param sym The symbol.
duke@1 3374 * @param s The scope.
duke@1 3375 */
duke@1 3376 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3377 if (sym.type.isErroneous())
duke@1 3378 return true;
duke@1 3379 if (sym.owner.name == names.any) return false;
duke@1 3380 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3381 if (sym != e.sym &&
mcimadamore@858 3382 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3383 sym.kind == e.sym.kind &&
mcimadamore@858 3384 sym.name != names.error &&
emc@2024 3385 (sym.kind != MTH ||
emc@2024 3386 types.hasSameArgs(sym.type, e.sym.type) ||
emc@2024 3387 types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3388 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3389 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3390 return true;
mcimadamore@907 3391 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3392 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3393 sym.flags_field |= CLASH;
mcimadamore@844 3394 return true;
mcimadamore@844 3395 } else {
duke@1 3396 duplicateError(pos, e.sym);
mcimadamore@844 3397 return false;
mcimadamore@844 3398 }
duke@1 3399 }
duke@1 3400 }
duke@1 3401 return true;
duke@1 3402 }
mcimadamore@844 3403
mcimadamore@858 3404 /** Report duplicate declaration error.
mcimadamore@858 3405 */
mcimadamore@858 3406 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3407 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3408 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3409 }
mcimadamore@858 3410 }
duke@1 3411
duke@1 3412 /** Check that single-type import is not already imported or top-level defined,
duke@1 3413 * but make an exception for two single-type imports which denote the same type.
duke@1 3414 * @param pos Position for error reporting.
duke@1 3415 * @param sym The symbol.
duke@1 3416 * @param s The scope
duke@1 3417 */
duke@1 3418 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3419 return checkUniqueImport(pos, sym, s, false);
duke@1 3420 }
duke@1 3421
duke@1 3422 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3423 * but make an exception for two single-type imports which denote the same type.
duke@1 3424 * @param pos Position for error reporting.
duke@1 3425 * @param sym The symbol.
duke@1 3426 * @param s The scope
duke@1 3427 */
duke@1 3428 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3429 return checkUniqueImport(pos, sym, s, true);
duke@1 3430 }
duke@1 3431
duke@1 3432 /** Check that single-type import is not already imported or top-level defined,
duke@1 3433 * but make an exception for two single-type imports which denote the same type.
duke@1 3434 * @param pos Position for error reporting.
duke@1 3435 * @param sym The symbol.
duke@1 3436 * @param s The scope.
duke@1 3437 * @param staticImport Whether or not this was a static import
duke@1 3438 */
duke@1 3439 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3440 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3441 // is encountered class entered via a class declaration?
duke@1 3442 boolean isClassDecl = e.scope == s;
duke@1 3443 if ((isClassDecl || sym != e.sym) &&
duke@1 3444 sym.kind == e.sym.kind &&
mcimadamore@1945 3445 sym.name != names.error &&
mcimadamore@1945 3446 (!staticImport || !e.isStaticallyImported())) {
duke@1 3447 if (!e.sym.type.isErroneous()) {
duke@1 3448 if (!isClassDecl) {
duke@1 3449 if (staticImport)
emc@2102 3450 log.error(pos, "already.defined.static.single.import", e.sym);
duke@1 3451 else
emc@2102 3452 log.error(pos, "already.defined.single.import", e.sym);
duke@1 3453 }
duke@1 3454 else if (sym != e.sym)
emc@2102 3455 log.error(pos, "already.defined.this.unit", e.sym);
duke@1 3456 }
duke@1 3457 return false;
duke@1 3458 }
duke@1 3459 }
duke@1 3460 return true;
duke@1 3461 }
duke@1 3462
duke@1 3463 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3464 */
duke@1 3465 public void checkCanonical(JCTree tree) {
duke@1 3466 if (!isCanonical(tree))
duke@1 3467 log.error(tree.pos(), "import.requires.canonical",
duke@1 3468 TreeInfo.symbol(tree));
duke@1 3469 }
duke@1 3470 // where
duke@1 3471 private boolean isCanonical(JCTree tree) {
jjg@1127 3472 while (tree.hasTag(SELECT)) {
duke@1 3473 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3474 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3475 return false;
duke@1 3476 tree = s.selected;
duke@1 3477 }
duke@1 3478 return true;
duke@1 3479 }
duke@1 3480
ohrstrom@1384 3481 /** Check that an auxiliary class is not accessed from any other file than its own.
ohrstrom@1384 3482 */
ohrstrom@1384 3483 void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) {
ohrstrom@1384 3484 if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) &&
ohrstrom@1384 3485 (c.flags() & AUXILIARY) != 0 &&
ohrstrom@1384 3486 rs.isAccessible(env, c) &&
ohrstrom@1384 3487 !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile))
ohrstrom@1384 3488 {
ohrstrom@1384 3489 log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file",
ohrstrom@1384 3490 c, c.sourcefile);
ohrstrom@1384 3491 }
ohrstrom@1384 3492 }
ohrstrom@1384 3493
duke@1 3494 private class ConversionWarner extends Warner {
mcimadamore@795 3495 final String uncheckedKey;
duke@1 3496 final Type found;
duke@1 3497 final Type expected;
mcimadamore@795 3498 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3499 super(pos);
mcimadamore@795 3500 this.uncheckedKey = uncheckedKey;
duke@1 3501 this.found = found;
duke@1 3502 this.expected = expected;
duke@1 3503 }
duke@1 3504
jjg@398 3505 @Override
mcimadamore@795 3506 public void warn(LintCategory lint) {
duke@1 3507 boolean warned = this.warned;
mcimadamore@795 3508 super.warn(lint);
duke@1 3509 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3510 switch (lint) {
mcimadamore@795 3511 case UNCHECKED:
mcimadamore@795 3512 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3513 break;
mcimadamore@795 3514 case VARARGS:
mcimadamore@795 3515 if (method != null &&
mcimadamore@795 3516 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3517 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3518 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3519 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3520 }
mcimadamore@795 3521 break;
mcimadamore@795 3522 default:
mcimadamore@795 3523 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3524 }
duke@1 3525 }
duke@1 3526 }
duke@1 3527
duke@1 3528 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3529 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3530 }
duke@1 3531
duke@1 3532 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3533 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3534 }
jlahoda@2111 3535
jlahoda@2111 3536 public void checkFunctionalInterface(JCClassDecl tree, ClassSymbol cs) {
jlahoda@2111 3537 Compound functionalType = cs.attribute(syms.functionalInterfaceType.tsym);
jlahoda@2111 3538
jlahoda@2111 3539 if (functionalType != null) {
jlahoda@2111 3540 try {
jlahoda@2111 3541 types.findDescriptorSymbol((TypeSymbol)cs);
jlahoda@2111 3542 } catch (Types.FunctionDescriptorLookupError ex) {
jlahoda@2111 3543 DiagnosticPosition pos = tree.pos();
jlahoda@2111 3544 for (JCAnnotation a : tree.getModifiers().annotations) {
jlahoda@2111 3545 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
jlahoda@2111 3546 pos = a.pos();
jlahoda@2111 3547 break;
jlahoda@2111 3548 }
jlahoda@2111 3549 }
jlahoda@2111 3550 log.error(pos, "bad.functional.intf.anno.1", ex.getDiagnostic());
jlahoda@2111 3551 }
jlahoda@2111 3552 }
jlahoda@2111 3553 }
duke@1 3554 }

mercurial