src/share/classes/com/sun/tools/javac/comp/Check.java

Thu, 25 Oct 2012 11:09:36 -0700

author
jjg
date
Thu, 25 Oct 2012 11:09:36 -0700
changeset 1374
c002fdee76fd
parent 1366
12cf6bfd8c05
child 1384
bf54daa9dcd8
permissions
-rw-r--r--

7200915: convert TypeTags from a series of small ints to an enum
Reviewed-by: jjg, mcimadamore
Contributed-by: vicente.romero@oracle.com

duke@1 1 /*
mcimadamore@1198 2 * Copyright (c) 1999, 2012, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
duke@1 30
duke@1 31 import com.sun.tools.javac.code.*;
duke@1 32 import com.sun.tools.javac.jvm.*;
duke@1 33 import com.sun.tools.javac.tree.*;
duke@1 34 import com.sun.tools.javac.util.*;
duke@1 35 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 36 import com.sun.tools.javac.util.List;
duke@1 37
duke@1 38 import com.sun.tools.javac.tree.JCTree.*;
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 43 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 44 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1337 45 import com.sun.tools.javac.comp.Infer.InferenceContext.FreeTypeListener;
duke@1 46
duke@1 47 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 48 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 49 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 50 import static com.sun.tools.javac.code.Kinds.*;
jjg@1374 51 import static com.sun.tools.javac.code.TypeTag.*;
jjg@1374 52 import static com.sun.tools.javac.code.TypeTag.WILDCARD;
duke@1 53
jjg@1127 54 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 55
duke@1 56 /** Type checking helper class for the attribution phase.
duke@1 57 *
jjg@581 58 * <p><b>This is NOT part of any supported API.
jjg@581 59 * If you write code that depends on this, you do so at your own risk.
duke@1 60 * This code and its internal interfaces are subject to change or
duke@1 61 * deletion without notice.</b>
duke@1 62 */
duke@1 63 public class Check {
duke@1 64 protected static final Context.Key<Check> checkKey =
duke@1 65 new Context.Key<Check>();
duke@1 66
jjg@113 67 private final Names names;
duke@1 68 private final Log log;
mcimadamore@1219 69 private final Resolve rs;
duke@1 70 private final Symtab syms;
mcimadamore@690 71 private final Enter enter;
mcimadamore@1347 72 private final DeferredAttr deferredAttr;
duke@1 73 private final Infer infer;
duke@1 74 private final Types types;
mcimadamore@89 75 private final JCDiagnostic.Factory diags;
mcimadamore@359 76 private boolean warnOnSyntheticConflicts;
jjg@576 77 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 78 private boolean enableSunApiLintControl;
duke@1 79 private final TreeInfo treeinfo;
duke@1 80
duke@1 81 // The set of lint options currently in effect. It is initialized
duke@1 82 // from the context, and then is set/reset as needed by Attr as it
duke@1 83 // visits all the various parts of the trees during attribution.
duke@1 84 private Lint lint;
duke@1 85
mcimadamore@795 86 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 87 // Attr as it visits new method declarations.
mcimadamore@795 88 private MethodSymbol method;
mcimadamore@795 89
duke@1 90 public static Check instance(Context context) {
duke@1 91 Check instance = context.get(checkKey);
duke@1 92 if (instance == null)
duke@1 93 instance = new Check(context);
duke@1 94 return instance;
duke@1 95 }
duke@1 96
duke@1 97 protected Check(Context context) {
duke@1 98 context.put(checkKey, this);
duke@1 99
jjg@113 100 names = Names.instance(context);
duke@1 101 log = Log.instance(context);
mcimadamore@1219 102 rs = Resolve.instance(context);
duke@1 103 syms = Symtab.instance(context);
mcimadamore@690 104 enter = Enter.instance(context);
mcimadamore@1347 105 deferredAttr = DeferredAttr.instance(context);
duke@1 106 infer = Infer.instance(context);
duke@1 107 this.types = Types.instance(context);
mcimadamore@89 108 diags = JCDiagnostic.Factory.instance(context);
duke@1 109 Options options = Options.instance(context);
duke@1 110 lint = Lint.instance(context);
duke@1 111 treeinfo = TreeInfo.instance(context);
duke@1 112
duke@1 113 Source source = Source.instance(context);
duke@1 114 allowGenerics = source.allowGenerics();
mcimadamore@1219 115 allowVarargs = source.allowVarargs();
duke@1 116 allowAnnotations = source.allowAnnotations();
jjg@398 117 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 118 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
jjg@1157 119 complexInference = options.isSet("complexinference");
jjg@700 120 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 121 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 122 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 123
jjg@398 124 Target target = Target.instance(context);
jjg@398 125 syntheticNameChar = target.syntheticNameChar();
jjg@398 126
duke@1 127 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 128 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 129 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 130 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 131
jjg@60 132 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 133 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 134 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 135 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 136 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 137 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 138
mcimadamore@852 139 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 140 }
duke@1 141
duke@1 142 /** Switch: generics enabled?
duke@1 143 */
duke@1 144 boolean allowGenerics;
duke@1 145
mcimadamore@1219 146 /** Switch: varargs enabled?
mcimadamore@1219 147 */
mcimadamore@1219 148 boolean allowVarargs;
mcimadamore@1219 149
duke@1 150 /** Switch: annotations enabled?
duke@1 151 */
duke@1 152 boolean allowAnnotations;
duke@1 153
jjg@398 154 /** Switch: covariant returns enabled?
jjg@398 155 */
jjg@398 156 boolean allowCovariantReturns;
jjg@398 157
mcimadamore@795 158 /** Switch: simplified varargs enabled?
mcimadamore@795 159 */
mcimadamore@795 160 boolean allowSimplifiedVarargs;
mcimadamore@795 161
duke@1 162 /** Switch: -complexinference option set?
duke@1 163 */
duke@1 164 boolean complexInference;
duke@1 165
jjg@398 166 /** Character for synthetic names
jjg@398 167 */
jjg@398 168 char syntheticNameChar;
jjg@398 169
duke@1 170 /** A table mapping flat names of all compiled classes in this run to their
duke@1 171 * symbols; maintained from outside.
duke@1 172 */
duke@1 173 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 174
duke@1 175 /** A handler for messages about deprecated usage.
duke@1 176 */
duke@1 177 private MandatoryWarningHandler deprecationHandler;
duke@1 178
duke@1 179 /** A handler for messages about unchecked or unsafe usage.
duke@1 180 */
duke@1 181 private MandatoryWarningHandler uncheckedHandler;
duke@1 182
jjg@582 183 /** A handler for messages about using proprietary API.
jjg@377 184 */
jjg@377 185 private MandatoryWarningHandler sunApiHandler;
duke@1 186
mcimadamore@852 187 /** A handler for deferred lint warnings.
mcimadamore@852 188 */
mcimadamore@852 189 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 190
duke@1 191 /* *************************************************************************
duke@1 192 * Errors and Warnings
duke@1 193 **************************************************************************/
duke@1 194
duke@1 195 Lint setLint(Lint newLint) {
duke@1 196 Lint prev = lint;
duke@1 197 lint = newLint;
duke@1 198 return prev;
duke@1 199 }
duke@1 200
mcimadamore@852 201 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 202 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 203 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 204 return prev;
mcimadamore@852 205 }
mcimadamore@852 206
mcimadamore@795 207 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 208 MethodSymbol prev = method;
mcimadamore@795 209 method = newMethod;
mcimadamore@795 210 return prev;
mcimadamore@795 211 }
mcimadamore@795 212
duke@1 213 /** Warn about deprecated symbol.
duke@1 214 * @param pos Position to be used for error reporting.
duke@1 215 * @param sym The deprecated symbol.
duke@1 216 */
duke@1 217 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 218 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 219 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 220 }
duke@1 221
duke@1 222 /** Warn about unchecked operation.
duke@1 223 * @param pos Position to be used for error reporting.
duke@1 224 * @param msg A string describing the problem.
duke@1 225 */
duke@1 226 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 227 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 228 uncheckedHandler.report(pos, msg, args);
duke@1 229 }
duke@1 230
mcimadamore@580 231 /** Warn about unsafe vararg method decl.
mcimadamore@580 232 * @param pos Position to be used for error reporting.
mcimadamore@580 233 */
mcimadamore@795 234 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 235 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 236 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 237 }
mcimadamore@580 238
jjg@582 239 /** Warn about using proprietary API.
jjg@377 240 * @param pos Position to be used for error reporting.
jjg@377 241 * @param msg A string describing the problem.
jjg@377 242 */
jjg@377 243 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 244 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 245 sunApiHandler.report(pos, msg, args);
jjg@377 246 }
jjg@377 247
jjg@505 248 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 249 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 250 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 251 }
jjg@505 252
duke@1 253 /**
duke@1 254 * Report any deferred diagnostics.
duke@1 255 */
duke@1 256 public void reportDeferredDiagnostics() {
duke@1 257 deprecationHandler.reportDeferredDiagnostic();
duke@1 258 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 259 sunApiHandler.reportDeferredDiagnostic();
duke@1 260 }
duke@1 261
duke@1 262
duke@1 263 /** Report a failure to complete a class.
duke@1 264 * @param pos Position to be used for error reporting.
duke@1 265 * @param ex The failure to report.
duke@1 266 */
duke@1 267 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 268 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 269 if (ex instanceof ClassReader.BadClassFile
jjg@576 270 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 271 else return syms.errType;
duke@1 272 }
duke@1 273
duke@1 274 /** Report an error that wrong type tag was found.
duke@1 275 * @param pos Position to be used for error reporting.
duke@1 276 * @param required An internationalized string describing the type tag
duke@1 277 * required.
duke@1 278 * @param found The type that was found.
duke@1 279 */
duke@1 280 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 281 // this error used to be raised by the parser,
jrose@267 282 // but has been delayed to this point:
jjg@1374 283 if (found instanceof Type && ((Type)found).hasTag(VOID)) {
jrose@267 284 log.error(pos, "illegal.start.of.type");
jrose@267 285 return syms.errType;
jrose@267 286 }
duke@1 287 log.error(pos, "type.found.req", found, required);
jjg@110 288 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 289 }
duke@1 290
duke@1 291 /** Report an error that symbol cannot be referenced before super
duke@1 292 * has been called.
duke@1 293 * @param pos Position to be used for error reporting.
duke@1 294 * @param sym The referenced symbol.
duke@1 295 */
duke@1 296 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 297 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 298 }
duke@1 299
duke@1 300 /** Report duplicate declaration error.
duke@1 301 */
duke@1 302 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 303 if (!sym.type.isErroneous()) {
mcimadamore@1085 304 Symbol location = sym.location();
mcimadamore@1085 305 if (location.kind == MTH &&
mcimadamore@1085 306 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 307 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 308 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 309 sym.location().enclClass());
mcimadamore@1085 310 } else {
mcimadamore@1085 311 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 312 kindName(sym.location()), sym.location());
mcimadamore@1085 313 }
duke@1 314 }
duke@1 315 }
duke@1 316
duke@1 317 /** Report array/varargs duplicate declaration
duke@1 318 */
duke@1 319 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 320 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 321 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 322 }
duke@1 323 }
duke@1 324
duke@1 325 /* ************************************************************************
duke@1 326 * duplicate declaration checking
duke@1 327 *************************************************************************/
duke@1 328
duke@1 329 /** Check that variable does not hide variable with same name in
duke@1 330 * immediately enclosing local scope.
duke@1 331 * @param pos Position for error reporting.
duke@1 332 * @param v The symbol.
duke@1 333 * @param s The scope.
duke@1 334 */
duke@1 335 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 336 if (s.next != null) {
duke@1 337 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 338 e.scope != null && e.sym.owner == v.owner;
duke@1 339 e = e.next()) {
duke@1 340 if (e.sym.kind == VAR &&
duke@1 341 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 342 v.name != names.error) {
duke@1 343 duplicateError(pos, e.sym);
duke@1 344 return;
duke@1 345 }
duke@1 346 }
duke@1 347 }
duke@1 348 }
duke@1 349
duke@1 350 /** Check that a class or interface does not hide a class or
duke@1 351 * interface with same name in immediately enclosing local scope.
duke@1 352 * @param pos Position for error reporting.
duke@1 353 * @param c The symbol.
duke@1 354 * @param s The scope.
duke@1 355 */
duke@1 356 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 357 if (s.next != null) {
duke@1 358 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 359 e.scope != null && e.sym.owner == c.owner;
duke@1 360 e = e.next()) {
jjg@1374 361 if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) &&
duke@1 362 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 363 c.name != names.error) {
duke@1 364 duplicateError(pos, e.sym);
duke@1 365 return;
duke@1 366 }
duke@1 367 }
duke@1 368 }
duke@1 369 }
duke@1 370
duke@1 371 /** Check that class does not have the same name as one of
duke@1 372 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 373 * return true if class is unique in its enclosing scope.
duke@1 374 * @param pos Position for error reporting.
duke@1 375 * @param name The class name.
duke@1 376 * @param s The enclosing scope.
duke@1 377 */
duke@1 378 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 379 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 380 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 381 duplicateError(pos, e.sym);
duke@1 382 return false;
duke@1 383 }
duke@1 384 }
duke@1 385 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 386 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 387 duplicateError(pos, sym);
duke@1 388 return true;
duke@1 389 }
duke@1 390 }
duke@1 391 return true;
duke@1 392 }
duke@1 393
duke@1 394 /* *************************************************************************
duke@1 395 * Class name generation
duke@1 396 **************************************************************************/
duke@1 397
duke@1 398 /** Return name of local class.
jjg@1358 399 * This is of the form {@code <enclClass> $ n <classname> }
duke@1 400 * where
duke@1 401 * enclClass is the flat name of the enclosing class,
duke@1 402 * classname is the simple name of the local class
duke@1 403 */
duke@1 404 Name localClassName(ClassSymbol c) {
duke@1 405 for (int i=1; ; i++) {
duke@1 406 Name flatname = names.
duke@1 407 fromString("" + c.owner.enclClass().flatname +
jjg@398 408 syntheticNameChar + i +
duke@1 409 c.name);
duke@1 410 if (compiled.get(flatname) == null) return flatname;
duke@1 411 }
duke@1 412 }
duke@1 413
duke@1 414 /* *************************************************************************
duke@1 415 * Type Checking
duke@1 416 **************************************************************************/
duke@1 417
mcimadamore@1238 418 /**
mcimadamore@1238 419 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 420 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 421 * vary significantly.
mcimadamore@1238 422 */
mcimadamore@1348 423 public interface CheckContext {
mcimadamore@1238 424 /**
mcimadamore@1238 425 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 426 */
mcimadamore@1238 427 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 428 /**
mcimadamore@1238 429 * Report a check error
mcimadamore@1238 430 */
mcimadamore@1296 431 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 432 /**
mcimadamore@1238 433 * Obtain a warner for this check context
mcimadamore@1238 434 */
mcimadamore@1238 435 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 436
mcimadamore@1337 437 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 438
mcimadamore@1347 439 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1348 440
mcimadamore@1348 441 public boolean allowBoxing();
mcimadamore@1238 442 }
mcimadamore@1238 443
mcimadamore@1238 444 /**
mcimadamore@1238 445 * This class represent a check context that is nested within another check
mcimadamore@1238 446 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 447 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 448 * the forwarding pattern.
mcimadamore@1238 449 */
mcimadamore@1238 450 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 451 CheckContext enclosingContext;
mcimadamore@1238 452
mcimadamore@1238 453 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 454 this.enclosingContext = enclosingContext;
mcimadamore@1238 455 }
mcimadamore@1238 456
mcimadamore@1238 457 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 458 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 459 }
mcimadamore@1238 460
mcimadamore@1296 461 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 462 enclosingContext.report(pos, details);
mcimadamore@1238 463 }
mcimadamore@1238 464
mcimadamore@1238 465 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 466 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 467 }
mcimadamore@1337 468
mcimadamore@1337 469 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 470 return enclosingContext.inferenceContext();
mcimadamore@1337 471 }
mcimadamore@1347 472
mcimadamore@1347 473 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 474 return enclosingContext.deferredAttrContext();
mcimadamore@1347 475 }
mcimadamore@1348 476
mcimadamore@1348 477 public boolean allowBoxing() {
mcimadamore@1348 478 return enclosingContext.allowBoxing();
mcimadamore@1348 479 }
mcimadamore@1238 480 }
mcimadamore@1238 481
mcimadamore@1238 482 /**
mcimadamore@1238 483 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 484 */
mcimadamore@1238 485 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 486 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 487 log.error(pos, "prob.found.req", details);
mcimadamore@1238 488 }
mcimadamore@1238 489 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 490 return types.isAssignable(found, req, warn);
mcimadamore@1238 491 }
mcimadamore@1238 492
mcimadamore@1238 493 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 494 return convertWarner(pos, found, req);
mcimadamore@1238 495 }
mcimadamore@1337 496
mcimadamore@1337 497 public InferenceContext inferenceContext() {
mcimadamore@1337 498 return infer.emptyContext;
mcimadamore@1337 499 }
mcimadamore@1347 500
mcimadamore@1347 501 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 502 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 503 }
mcimadamore@1348 504
mcimadamore@1348 505 public boolean allowBoxing() {
mcimadamore@1348 506 return true;
mcimadamore@1348 507 }
mcimadamore@1238 508 };
mcimadamore@1238 509
duke@1 510 /** Check that a given type is assignable to a given proto-type.
duke@1 511 * If it is, return the type, otherwise return errType.
duke@1 512 * @param pos Position to be used for error reporting.
duke@1 513 * @param found The type that was found.
duke@1 514 * @param req The type that was required.
duke@1 515 */
duke@1 516 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 517 return checkType(pos, found, req, basicHandler);
darcy@609 518 }
darcy@609 519
mcimadamore@1337 520 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 521 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 522 if (inferenceContext.free(req)) {
mcimadamore@1337 523 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 524 @Override
mcimadamore@1337 525 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1337 526 checkType(pos, found, inferenceContext.asInstType(req, types), checkContext);
mcimadamore@1337 527 }
mcimadamore@1337 528 });
mcimadamore@1337 529 }
jjg@1374 530 if (req.hasTag(ERROR))
duke@1 531 return req;
jjg@1374 532 if (req.hasTag(NONE))
duke@1 533 return found;
mcimadamore@1238 534 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 535 return found;
mcimadamore@1238 536 } else {
jjg@1374 537 if (found.getTag().isSubRangeOf(DOUBLE) && req.getTag().isSubRangeOf(DOUBLE)) {
mcimadamore@1296 538 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 539 return types.createErrorType(found);
mcimadamore@1238 540 }
mcimadamore@1296 541 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 542 return types.createErrorType(found);
duke@1 543 }
duke@1 544 }
duke@1 545
duke@1 546 /** Check that a given type can be cast to a given target type.
duke@1 547 * Return the result of the cast.
duke@1 548 * @param pos Position to be used for error reporting.
duke@1 549 * @param found The type that is being cast.
duke@1 550 * @param req The target type of the cast.
duke@1 551 */
duke@1 552 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 553 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 554 }
mcimadamore@1238 555 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 556 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 557 return req;
duke@1 558 } else {
mcimadamore@1296 559 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 560 return types.createErrorType(found);
duke@1 561 }
duke@1 562 }
mcimadamore@1237 563
mcimadamore@1237 564 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 565 * The problem should only be reported for non-292 cast
mcimadamore@1237 566 */
mcimadamore@1237 567 public void checkRedundantCast(Env<AttrContext> env, JCTypeCast tree) {
mcimadamore@1237 568 if (!tree.type.isErroneous() &&
mcimadamore@1348 569 (env.info.lint == null || env.info.lint.isEnabled(Lint.LintCategory.CAST))
mcimadamore@1348 570 && types.isSameType(tree.expr.type, tree.clazz.type)
mcimadamore@1348 571 && !is292targetTypeCast(tree)) {
mcimadamore@1237 572 log.warning(Lint.LintCategory.CAST,
mcimadamore@1237 573 tree.pos(), "redundant.cast", tree.expr.type);
mcimadamore@1237 574 }
mcimadamore@1237 575 }
mcimadamore@1237 576 //where
mcimadamore@1237 577 private boolean is292targetTypeCast(JCTypeCast tree) {
mcimadamore@1237 578 boolean is292targetTypeCast = false;
mcimadamore@1237 579 JCExpression expr = TreeInfo.skipParens(tree.expr);
mcimadamore@1237 580 if (expr.hasTag(APPLY)) {
mcimadamore@1237 581 JCMethodInvocation apply = (JCMethodInvocation)expr;
mcimadamore@1237 582 Symbol sym = TreeInfo.symbol(apply.meth);
mcimadamore@1237 583 is292targetTypeCast = sym != null &&
mcimadamore@1237 584 sym.kind == MTH &&
mcimadamore@1239 585 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 586 }
mcimadamore@1237 587 return is292targetTypeCast;
mcimadamore@1237 588 }
mcimadamore@1237 589
mcimadamore@1237 590
mcimadamore@1237 591
duke@1 592 //where
duke@1 593 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 594 * type variables?
duke@1 595 */
duke@1 596 boolean isTypeVar(Type t) {
jjg@1374 597 return t.hasTag(TYPEVAR) || t.hasTag(ARRAY) && isTypeVar(types.elemtype(t));
duke@1 598 }
duke@1 599
duke@1 600 /** Check that a type is within some bounds.
duke@1 601 *
jjg@1358 602 * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
duke@1 603 * type argument.
duke@1 604 * @param a The type that should be bounded by bs.
jjg@1358 605 * @param bound The bound.
duke@1 606 */
mcimadamore@1216 607 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 608 if (a.isUnbound()) {
mcimadamore@821 609 return true;
jjg@1374 610 } else if (!a.hasTag(WILDCARD)) {
mcimadamore@154 611 a = types.upperBound(a);
mcimadamore@1216 612 return types.isSubtype(a, bound);
mcimadamore@154 613 } else if (a.isExtendsBound()) {
mcimadamore@1216 614 return types.isCastable(bound, types.upperBound(a), Warner.noWarnings);
mcimadamore@154 615 } else if (a.isSuperBound()) {
mcimadamore@1216 616 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 617 }
mcimadamore@821 618 return true;
mcimadamore@154 619 }
duke@1 620
duke@1 621 /** Check that type is different from 'void'.
duke@1 622 * @param pos Position to be used for error reporting.
duke@1 623 * @param t The type to be checked.
duke@1 624 */
duke@1 625 Type checkNonVoid(DiagnosticPosition pos, Type t) {
jjg@1374 626 if (t.hasTag(VOID)) {
duke@1 627 log.error(pos, "void.not.allowed.here");
jjg@110 628 return types.createErrorType(t);
duke@1 629 } else {
duke@1 630 return t;
duke@1 631 }
duke@1 632 }
duke@1 633
duke@1 634 /** Check that type is a class or interface type.
duke@1 635 * @param pos Position to be used for error reporting.
duke@1 636 * @param t The type to be checked.
duke@1 637 */
duke@1 638 Type checkClassType(DiagnosticPosition pos, Type t) {
jjg@1374 639 if (!t.hasTag(CLASS) && !t.hasTag(ERROR))
duke@1 640 return typeTagError(pos,
mcimadamore@89 641 diags.fragment("type.req.class"),
jjg@1374 642 (t.hasTag(TYPEVAR))
mcimadamore@89 643 ? diags.fragment("type.parameter", t)
duke@1 644 : t);
duke@1 645 else
duke@1 646 return t;
duke@1 647 }
duke@1 648
mcimadamore@1352 649 /** Check that type is a valid qualifier for a constructor reference expression
mcimadamore@1352 650 */
mcimadamore@1352 651 Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
mcimadamore@1352 652 t = checkClassType(pos, t);
jjg@1374 653 if (t.hasTag(CLASS)) {
mcimadamore@1352 654 if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
mcimadamore@1352 655 log.error(pos, "abstract.cant.be.instantiated");
mcimadamore@1352 656 t = types.createErrorType(t);
mcimadamore@1352 657 } else if ((t.tsym.flags() & ENUM) != 0) {
mcimadamore@1352 658 log.error(pos, "enum.cant.be.instantiated");
mcimadamore@1352 659 t = types.createErrorType(t);
mcimadamore@1352 660 }
mcimadamore@1352 661 }
mcimadamore@1352 662 return t;
mcimadamore@1352 663 }
mcimadamore@1352 664
duke@1 665 /** Check that type is a class or interface type.
duke@1 666 * @param pos Position to be used for error reporting.
duke@1 667 * @param t The type to be checked.
duke@1 668 * @param noBounds True if type bounds are illegal here.
duke@1 669 */
duke@1 670 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 671 t = checkClassType(pos, t);
duke@1 672 if (noBounds && t.isParameterized()) {
duke@1 673 List<Type> args = t.getTypeArguments();
duke@1 674 while (args.nonEmpty()) {
jjg@1374 675 if (args.head.hasTag(WILDCARD))
duke@1 676 return typeTagError(pos,
jjg@598 677 diags.fragment("type.req.exact"),
duke@1 678 args.head);
duke@1 679 args = args.tail;
duke@1 680 }
duke@1 681 }
duke@1 682 return t;
duke@1 683 }
duke@1 684
duke@1 685 /** Check that type is a reifiable class, interface or array type.
duke@1 686 * @param pos Position to be used for error reporting.
duke@1 687 * @param t The type to be checked.
duke@1 688 */
duke@1 689 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
jjg@1374 690 if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
duke@1 691 return typeTagError(pos,
mcimadamore@89 692 diags.fragment("type.req.class.array"),
duke@1 693 t);
duke@1 694 } else if (!types.isReifiable(t)) {
duke@1 695 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 696 return types.createErrorType(t);
duke@1 697 } else {
duke@1 698 return t;
duke@1 699 }
duke@1 700 }
duke@1 701
duke@1 702 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 703 * or a type variable.
duke@1 704 * @param pos Position to be used for error reporting.
duke@1 705 * @param t The type to be checked.
duke@1 706 */
duke@1 707 Type checkRefType(DiagnosticPosition pos, Type t) {
jjg@1374 708 if (t.isReference())
duke@1 709 return t;
jjg@1374 710 else
duke@1 711 return typeTagError(pos,
mcimadamore@89 712 diags.fragment("type.req.ref"),
duke@1 713 t);
duke@1 714 }
duke@1 715
jrose@267 716 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 717 * or a type variable.
jrose@267 718 * @param trees Original trees, used for error reporting.
jrose@267 719 * @param types The types to be checked.
jrose@267 720 */
jrose@267 721 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 722 List<JCExpression> tl = trees;
jrose@267 723 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 724 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 725 tl = tl.tail;
jrose@267 726 }
jrose@267 727 return types;
jrose@267 728 }
jrose@267 729
duke@1 730 /** Check that type is a null or reference type.
duke@1 731 * @param pos Position to be used for error reporting.
duke@1 732 * @param t The type to be checked.
duke@1 733 */
duke@1 734 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
jjg@1374 735 if (t.isNullOrReference())
duke@1 736 return t;
jjg@1374 737 else
duke@1 738 return typeTagError(pos,
mcimadamore@89 739 diags.fragment("type.req.ref"),
duke@1 740 t);
duke@1 741 }
duke@1 742
duke@1 743 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 744 * Return true if it doesn't.
duke@1 745 * @param pos Position to be used for error reporting.
duke@1 746 * @param flags The set of flags to be checked.
duke@1 747 * @param set1 Conflicting flags set #1.
duke@1 748 * @param set2 Conflicting flags set #2.
duke@1 749 */
duke@1 750 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 751 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 752 log.error(pos,
duke@1 753 "illegal.combination.of.modifiers",
mcimadamore@80 754 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 755 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 756 return false;
duke@1 757 } else
duke@1 758 return true;
duke@1 759 }
duke@1 760
mcimadamore@914 761 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 762 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 763 */
mcimadamore@914 764 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 765 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 766 t.isErroneous()) {
mcimadamore@914 767 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 768 } else if (tree.def != null) {
mcimadamore@914 769 log.error(tree.clazz.pos(),
mcimadamore@914 770 "cant.apply.diamond.1",
mcimadamore@914 771 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 772 return types.createErrorType(t);
mcimadamore@948 773 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 774 log.error(tree.clazz.pos(),
mcimadamore@914 775 "cant.apply.diamond.1",
mcimadamore@914 776 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 777 return types.createErrorType(t);
mcimadamore@993 778 } else if (tree.typeargs != null &&
mcimadamore@993 779 tree.typeargs.nonEmpty()) {
mcimadamore@993 780 log.error(tree.clazz.pos(),
mcimadamore@993 781 "cant.apply.diamond.1",
mcimadamore@993 782 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 783 return types.createErrorType(t);
mcimadamore@914 784 } else {
mcimadamore@914 785 return t;
mcimadamore@537 786 }
mcimadamore@537 787 }
mcimadamore@537 788
mcimadamore@795 789 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 790 MethodSymbol m = tree.sym;
mcimadamore@795 791 if (!allowSimplifiedVarargs) return;
mcimadamore@795 792 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 793 Type varargElemType = null;
mcimadamore@580 794 if (m.isVarArgs()) {
mcimadamore@795 795 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 796 }
mcimadamore@795 797 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 798 if (varargElemType != null) {
mcimadamore@795 799 log.error(tree,
mcimadamore@795 800 "varargs.invalid.trustme.anno",
mcimadamore@795 801 syms.trustMeType.tsym,
mcimadamore@795 802 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 803 } else {
mcimadamore@795 804 log.error(tree,
mcimadamore@795 805 "varargs.invalid.trustme.anno",
mcimadamore@795 806 syms.trustMeType.tsym,
mcimadamore@795 807 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 808 }
mcimadamore@795 809 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 810 types.isReifiable(varargElemType)) {
mcimadamore@795 811 warnUnsafeVararg(tree,
mcimadamore@795 812 "varargs.redundant.trustme.anno",
mcimadamore@795 813 syms.trustMeType.tsym,
mcimadamore@795 814 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 815 }
mcimadamore@795 816 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 817 !types.isReifiable(varargElemType)) {
mcimadamore@795 818 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 819 }
mcimadamore@580 820 }
mcimadamore@795 821 //where
mcimadamore@795 822 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 823 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 824 (s.isConstructor() ||
mcimadamore@795 825 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 826 }
mcimadamore@580 827
mcimadamore@1219 828 Type checkMethod(Type owntype,
mcimadamore@1219 829 Symbol sym,
mcimadamore@1219 830 Env<AttrContext> env,
mcimadamore@1219 831 final List<JCExpression> argtrees,
mcimadamore@1219 832 List<Type> argtypes,
mcimadamore@1226 833 boolean useVarargs,
mcimadamore@1226 834 boolean unchecked) {
mcimadamore@1219 835 // System.out.println("call : " + env.tree);
mcimadamore@1219 836 // System.out.println("method : " + owntype);
mcimadamore@1219 837 // System.out.println("actuals: " + argtypes);
mcimadamore@1219 838 List<Type> formals = owntype.getParameterTypes();
mcimadamore@1219 839 Type last = useVarargs ? formals.last() : null;
mcimadamore@1219 840 if (sym.name==names.init &&
mcimadamore@1219 841 sym.owner == syms.enumSym)
mcimadamore@1219 842 formals = formals.tail.tail;
mcimadamore@1219 843 List<JCExpression> args = argtrees;
mcimadamore@1347 844 DeferredAttr.DeferredTypeMap checkDeferredMap =
mcimadamore@1347 845 deferredAttr.new DeferredTypeMap(DeferredAttr.AttrMode.CHECK, sym, env.info.pendingResolutionPhase);
mcimadamore@1352 846 if (args != null) {
mcimadamore@1352 847 //this is null when type-checking a method reference
mcimadamore@1352 848 while (formals.head != last) {
mcimadamore@1219 849 JCTree arg = args.head;
mcimadamore@1352 850 Warner warn = convertWarner(arg.pos(), arg.type, formals.head);
mcimadamore@1352 851 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 852 args = args.tail;
mcimadamore@1352 853 formals = formals.tail;
mcimadamore@1219 854 }
mcimadamore@1352 855 if (useVarargs) {
mcimadamore@1352 856 Type varArg = types.elemtype(last);
mcimadamore@1352 857 while (args.tail != null) {
mcimadamore@1352 858 JCTree arg = args.head;
mcimadamore@1352 859 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1352 860 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1352 861 args = args.tail;
mcimadamore@1352 862 }
mcimadamore@1352 863 } else if ((sym.flags() & VARARGS) != 0 && allowVarargs) {
mcimadamore@1352 864 // non-varargs call to varargs method
mcimadamore@1352 865 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1352 866 Type lastArg = checkDeferredMap.apply(argtypes.last());
mcimadamore@1352 867 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
mcimadamore@1352 868 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1352 869 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
mcimadamore@1352 870 types.elemtype(varParam), varParam);
mcimadamore@1352 871 }
mcimadamore@1219 872 }
mcimadamore@1226 873 if (unchecked) {
mcimadamore@1219 874 warnUnchecked(env.tree.pos(),
mcimadamore@1219 875 "unchecked.meth.invocation.applied",
mcimadamore@1219 876 kindName(sym),
mcimadamore@1219 877 sym.name,
mcimadamore@1219 878 rs.methodArguments(sym.type.getParameterTypes()),
mcimadamore@1347 879 rs.methodArguments(Type.map(argtypes, checkDeferredMap)),
mcimadamore@1219 880 kindName(sym.location()),
mcimadamore@1219 881 sym.location());
mcimadamore@1219 882 owntype = new MethodType(owntype.getParameterTypes(),
mcimadamore@1219 883 types.erasure(owntype.getReturnType()),
mcimadamore@1219 884 types.erasure(owntype.getThrownTypes()),
mcimadamore@1219 885 syms.methodClass);
mcimadamore@1219 886 }
mcimadamore@1219 887 if (useVarargs) {
mcimadamore@1219 888 JCTree tree = env.tree;
mcimadamore@1219 889 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 890 if (!types.isReifiable(argtype) &&
mcimadamore@1219 891 (!allowSimplifiedVarargs ||
mcimadamore@1219 892 sym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@1219 893 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 894 warnUnchecked(env.tree.pos(),
mcimadamore@1219 895 "unchecked.generic.array.creation",
mcimadamore@1219 896 argtype);
mcimadamore@1219 897 }
mcimadamore@1219 898 Type elemtype = types.elemtype(argtype);
mcimadamore@1219 899 switch (tree.getTag()) {
mcimadamore@1219 900 case APPLY:
mcimadamore@1219 901 ((JCMethodInvocation) tree).varargsElement = elemtype;
mcimadamore@1219 902 break;
mcimadamore@1219 903 case NEWCLASS:
mcimadamore@1219 904 ((JCNewClass) tree).varargsElement = elemtype;
mcimadamore@1219 905 break;
mcimadamore@1352 906 case REFERENCE:
mcimadamore@1352 907 ((JCMemberReference) tree).varargsElement = elemtype;
mcimadamore@1352 908 break;
mcimadamore@1219 909 default:
mcimadamore@1219 910 throw new AssertionError(""+tree);
mcimadamore@1219 911 }
mcimadamore@1219 912 }
mcimadamore@1219 913 return owntype;
mcimadamore@547 914 }
mcimadamore@1219 915 //where
mcimadamore@1219 916 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
mcimadamore@1219 917 if (types.isConvertible(actual, formal, warn))
mcimadamore@1219 918 return;
mcimadamore@1219 919
mcimadamore@1219 920 if (formal.isCompound()
mcimadamore@1219 921 && types.isSubtype(actual, types.supertype(formal))
mcimadamore@1219 922 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
mcimadamore@1219 923 return;
mcimadamore@1219 924 }
mcimadamore@547 925
mcimadamore@1348 926 void checkAccessibleFunctionalDescriptor(DiagnosticPosition pos, Env<AttrContext> env, Type desc) {
mcimadamore@1348 927 AccessChecker accessChecker = new AccessChecker(env);
mcimadamore@1348 928 //check args accessibility (only if implicit parameter types)
mcimadamore@1348 929 for (Type arg : desc.getParameterTypes()) {
mcimadamore@1348 930 if (!accessChecker.visit(arg)) {
mcimadamore@1348 931 log.error(pos, "cant.access.arg.type.in.functional.desc", arg);
mcimadamore@1348 932 return;
mcimadamore@1348 933 }
mcimadamore@1348 934 }
mcimadamore@1348 935 //check return type accessibility
mcimadamore@1348 936 if (!accessChecker.visit(desc.getReturnType())) {
mcimadamore@1348 937 log.error(pos, "cant.access.return.in.functional.desc", desc.getReturnType());
mcimadamore@1348 938 return;
mcimadamore@1348 939 }
mcimadamore@1348 940 //check thrown types accessibility
mcimadamore@1348 941 for (Type thrown : desc.getThrownTypes()) {
mcimadamore@1348 942 if (!accessChecker.visit(thrown)) {
mcimadamore@1348 943 log.error(pos, "cant.access.thrown.in.functional.desc", thrown);
mcimadamore@1348 944 return;
mcimadamore@1348 945 }
mcimadamore@1348 946 }
mcimadamore@1348 947 }
mcimadamore@1348 948
mcimadamore@1348 949 class AccessChecker extends Types.UnaryVisitor<Boolean> {
mcimadamore@1348 950
mcimadamore@1348 951 Env<AttrContext> env;
mcimadamore@1348 952
mcimadamore@1348 953 AccessChecker(Env<AttrContext> env) {
mcimadamore@1348 954 this.env = env;
mcimadamore@1348 955 }
mcimadamore@1348 956
mcimadamore@1348 957 Boolean visit(List<Type> ts) {
mcimadamore@1348 958 for (Type t : ts) {
mcimadamore@1348 959 if (!visit(t))
mcimadamore@1348 960 return false;
mcimadamore@1348 961 }
mcimadamore@1348 962 return true;
mcimadamore@1348 963 }
mcimadamore@1348 964
mcimadamore@1348 965 public Boolean visitType(Type t, Void s) {
mcimadamore@1348 966 return true;
mcimadamore@1348 967 }
mcimadamore@1348 968
mcimadamore@1348 969 @Override
mcimadamore@1348 970 public Boolean visitArrayType(ArrayType t, Void s) {
mcimadamore@1348 971 return visit(t.elemtype);
mcimadamore@1348 972 }
mcimadamore@1348 973
mcimadamore@1348 974 @Override
mcimadamore@1348 975 public Boolean visitClassType(ClassType t, Void s) {
mcimadamore@1348 976 return rs.isAccessible(env, t, true) &&
mcimadamore@1348 977 visit(t.getTypeArguments());
mcimadamore@1348 978 }
mcimadamore@1348 979
mcimadamore@1348 980 @Override
mcimadamore@1348 981 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@1348 982 return visit(t.type);
mcimadamore@1348 983 }
mcimadamore@1348 984 };
mcimadamore@821 985 /**
mcimadamore@821 986 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 987 * (see JLS 4.5)
mcimadamore@821 988 *
mcimadamore@821 989 * @param t class type to be checked
mcimadamore@821 990 * @return true if 't' is well-formed
mcimadamore@821 991 */
mcimadamore@821 992 public boolean checkValidGenericType(Type t) {
mcimadamore@821 993 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 994 }
mcimadamore@821 995 //WHERE
mcimadamore@821 996 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 997 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 998 List<Type> actuals = type.allparams();
mcimadamore@821 999 List<Type> args = type.getTypeArguments();
mcimadamore@821 1000 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 1001 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 1002
mcimadamore@821 1003 // For matching pairs of actual argument types `a' and
mcimadamore@821 1004 // formal type parameters with declared bound `b' ...
mcimadamore@821 1005 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 1006 // exact type arguments needs to know their
mcimadamore@821 1007 // bounds (for upper and lower bound
mcimadamore@1216 1008 // calculations). So we create new bounds where
mcimadamore@1216 1009 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 1010 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 1011 args = args.tail;
mcimadamore@821 1012 forms = forms.tail;
mcimadamore@821 1013 }
mcimadamore@821 1014
mcimadamore@821 1015 args = type.getTypeArguments();
mcimadamore@821 1016 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 1017 formals,
mcimadamore@821 1018 types.capture(type).allparams());
mcimadamore@821 1019 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 1020 // Let the actual arguments know their bound
mcimadamore@821 1021 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 1022 args = args.tail;
mcimadamore@821 1023 tvars_cap = tvars_cap.tail;
mcimadamore@821 1024 }
mcimadamore@821 1025
mcimadamore@821 1026 args = type.getTypeArguments();
mcimadamore@1216 1027 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 1028
mcimadamore@1216 1029 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 1030 Type actual = args.head;
mcimadamore@854 1031 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 1032 !bounds.head.isErroneous() &&
mcimadamore@1216 1033 !checkExtends(actual, bounds.head)) {
mcimadamore@821 1034 return args.head;
mcimadamore@821 1035 }
mcimadamore@821 1036 args = args.tail;
mcimadamore@1216 1037 bounds = bounds.tail;
mcimadamore@821 1038 }
mcimadamore@821 1039
mcimadamore@821 1040 args = type.getTypeArguments();
mcimadamore@1216 1041 bounds = bounds_buf.toList();
mcimadamore@821 1042
mcimadamore@821 1043 for (Type arg : types.capture(type).getTypeArguments()) {
jjg@1374 1044 if (arg.hasTag(TYPEVAR) &&
mcimadamore@828 1045 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 1046 !bounds.head.isErroneous() &&
mcimadamore@854 1047 !isTypeArgErroneous(args.head)) {
mcimadamore@821 1048 return args.head;
mcimadamore@821 1049 }
mcimadamore@1216 1050 bounds = bounds.tail;
mcimadamore@854 1051 args = args.tail;
mcimadamore@821 1052 }
mcimadamore@821 1053
mcimadamore@821 1054 return null;
mcimadamore@821 1055 }
mcimadamore@854 1056 //where
mcimadamore@854 1057 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 1058 return isTypeArgErroneous.visit(t);
mcimadamore@854 1059 }
mcimadamore@854 1060
mcimadamore@854 1061 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 1062 public Boolean visitType(Type t, Void s) {
mcimadamore@854 1063 return t.isErroneous();
mcimadamore@854 1064 }
mcimadamore@854 1065 @Override
mcimadamore@854 1066 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 1067 return visit(t.getUpperBound());
mcimadamore@854 1068 }
mcimadamore@854 1069 @Override
mcimadamore@854 1070 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 1071 return visit(t.getUpperBound()) ||
mcimadamore@854 1072 visit(t.getLowerBound());
mcimadamore@854 1073 }
mcimadamore@854 1074 @Override
mcimadamore@854 1075 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1076 return visit(t.type);
mcimadamore@854 1077 }
mcimadamore@854 1078 };
mcimadamore@821 1079
duke@1 1080 /** Check that given modifiers are legal for given symbol and
duke@1 1081 * return modifiers together with any implicit modififiers for that symbol.
duke@1 1082 * Warning: we can't use flags() here since this method
duke@1 1083 * is called during class enter, when flags() would cause a premature
duke@1 1084 * completion.
duke@1 1085 * @param pos Position to be used for error reporting.
duke@1 1086 * @param flags The set of modifiers given in a definition.
duke@1 1087 * @param sym The defined symbol.
duke@1 1088 */
duke@1 1089 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1090 long mask;
duke@1 1091 long implicit = 0;
duke@1 1092 switch (sym.kind) {
duke@1 1093 case VAR:
duke@1 1094 if (sym.owner.kind != TYP)
duke@1 1095 mask = LocalVarFlags;
duke@1 1096 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1097 mask = implicit = InterfaceVarFlags;
duke@1 1098 else
duke@1 1099 mask = VarFlags;
duke@1 1100 break;
duke@1 1101 case MTH:
duke@1 1102 if (sym.name == names.init) {
duke@1 1103 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1104 // enum constructors cannot be declared public or
duke@1 1105 // protected and must be implicitly or explicitly
duke@1 1106 // private
duke@1 1107 implicit = PRIVATE;
duke@1 1108 mask = PRIVATE;
duke@1 1109 } else
duke@1 1110 mask = ConstructorFlags;
mcimadamore@1366 1111 } else if ((sym.owner.flags_field & INTERFACE) != 0) {
mcimadamore@1366 1112 if ((flags & DEFAULT) != 0) {
mcimadamore@1366 1113 mask = InterfaceDefaultMethodMask;
mcimadamore@1366 1114 implicit = PUBLIC;
mcimadamore@1366 1115 } else {
mcimadamore@1366 1116 mask = implicit = InterfaceMethodFlags;
mcimadamore@1366 1117 }
mcimadamore@1366 1118 }
duke@1 1119 else {
duke@1 1120 mask = MethodFlags;
duke@1 1121 }
duke@1 1122 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1123 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 1124 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1125 break;
duke@1 1126 case TYP:
duke@1 1127 if (sym.isLocal()) {
duke@1 1128 mask = LocalClassFlags;
jjg@113 1129 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1130 // Anonymous classes in static methods are themselves static;
duke@1 1131 // that's why we admit STATIC here.
duke@1 1132 mask |= STATIC;
duke@1 1133 // JLS: Anonymous classes are final.
duke@1 1134 implicit |= FINAL;
duke@1 1135 }
duke@1 1136 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1137 (flags & ENUM) != 0)
duke@1 1138 log.error(pos, "enums.must.be.static");
duke@1 1139 } else if (sym.owner.kind == TYP) {
duke@1 1140 mask = MemberClassFlags;
duke@1 1141 if (sym.owner.owner.kind == PCK ||
duke@1 1142 (sym.owner.flags_field & STATIC) != 0)
duke@1 1143 mask |= STATIC;
duke@1 1144 else if ((flags & ENUM) != 0)
duke@1 1145 log.error(pos, "enums.must.be.static");
duke@1 1146 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1147 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1148 } else {
duke@1 1149 mask = ClassFlags;
duke@1 1150 }
duke@1 1151 // Interfaces are always ABSTRACT
duke@1 1152 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1153
duke@1 1154 if ((flags & ENUM) != 0) {
duke@1 1155 // enums can't be declared abstract or final
duke@1 1156 mask &= ~(ABSTRACT | FINAL);
duke@1 1157 implicit |= implicitEnumFinalFlag(tree);
duke@1 1158 }
duke@1 1159 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1160 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1161 break;
duke@1 1162 default:
duke@1 1163 throw new AssertionError();
duke@1 1164 }
mcimadamore@1366 1165 long illegal = flags & ExtendedStandardFlags & ~mask;
duke@1 1166 if (illegal != 0) {
duke@1 1167 if ((illegal & INTERFACE) != 0) {
duke@1 1168 log.error(pos, "intf.not.allowed.here");
duke@1 1169 mask |= INTERFACE;
duke@1 1170 }
duke@1 1171 else {
duke@1 1172 log.error(pos,
mcimadamore@80 1173 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1174 }
duke@1 1175 }
duke@1 1176 else if ((sym.kind == TYP ||
duke@1 1177 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1178 // in the presence of inner classes. Should it be deleted here?
duke@1 1179 checkDisjoint(pos, flags,
duke@1 1180 ABSTRACT,
mcimadamore@1366 1181 PRIVATE | STATIC | DEFAULT))
duke@1 1182 &&
duke@1 1183 checkDisjoint(pos, flags,
duke@1 1184 ABSTRACT | INTERFACE,
duke@1 1185 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1186 &&
duke@1 1187 checkDisjoint(pos, flags,
duke@1 1188 PUBLIC,
duke@1 1189 PRIVATE | PROTECTED)
duke@1 1190 &&
duke@1 1191 checkDisjoint(pos, flags,
duke@1 1192 PRIVATE,
duke@1 1193 PUBLIC | PROTECTED)
duke@1 1194 &&
duke@1 1195 checkDisjoint(pos, flags,
duke@1 1196 FINAL,
duke@1 1197 VOLATILE)
duke@1 1198 &&
duke@1 1199 (sym.kind == TYP ||
duke@1 1200 checkDisjoint(pos, flags,
duke@1 1201 ABSTRACT | NATIVE,
duke@1 1202 STRICTFP))) {
duke@1 1203 // skip
duke@1 1204 }
mcimadamore@1366 1205 return flags & (mask | ~ExtendedStandardFlags) | implicit;
duke@1 1206 }
duke@1 1207
duke@1 1208
duke@1 1209 /** Determine if this enum should be implicitly final.
duke@1 1210 *
duke@1 1211 * If the enum has no specialized enum contants, it is final.
duke@1 1212 *
duke@1 1213 * If the enum does have specialized enum contants, it is
duke@1 1214 * <i>not</i> final.
duke@1 1215 */
duke@1 1216 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1217 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1218 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1219 boolean specialized;
duke@1 1220 SpecialTreeVisitor() {
duke@1 1221 this.specialized = false;
duke@1 1222 };
duke@1 1223
jjg@398 1224 @Override
duke@1 1225 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1226
jjg@398 1227 @Override
duke@1 1228 public void visitVarDef(JCVariableDecl tree) {
duke@1 1229 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1230 if (tree.init instanceof JCNewClass &&
duke@1 1231 ((JCNewClass) tree.init).def != null) {
duke@1 1232 specialized = true;
duke@1 1233 }
duke@1 1234 }
duke@1 1235 }
duke@1 1236 }
duke@1 1237
duke@1 1238 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1239 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1240 for (JCTree defs: cdef.defs) {
duke@1 1241 defs.accept(sts);
duke@1 1242 if (sts.specialized) return 0;
duke@1 1243 }
duke@1 1244 return FINAL;
duke@1 1245 }
duke@1 1246
duke@1 1247 /* *************************************************************************
duke@1 1248 * Type Validation
duke@1 1249 **************************************************************************/
duke@1 1250
duke@1 1251 /** Validate a type expression. That is,
duke@1 1252 * check that all type arguments of a parametric type are within
duke@1 1253 * their bounds. This must be done in a second phase after type attributon
duke@1 1254 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1255 *
jjg@1358 1256 * <pre>{@code
duke@1 1257 * class B<A extends C> { ... }
duke@1 1258 * class C extends B<C> { ... }
jjg@1358 1259 * }</pre>
duke@1 1260 *
duke@1 1261 * and we can't make sure that the bound is already attributed because
duke@1 1262 * of possible cycles.
mcimadamore@638 1263 *
mcimadamore@638 1264 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1265 * and reporting any completion failures.
duke@1 1266 */
mcimadamore@122 1267 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1268 validate(tree, env, true);
duke@1 1269 }
mcimadamore@638 1270 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1271 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1272 }
duke@1 1273
duke@1 1274 /** Visitor method: Validate a list of type expressions.
duke@1 1275 */
mcimadamore@122 1276 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1277 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1278 validate(l.head, env);
duke@1 1279 }
duke@1 1280
duke@1 1281 /** A visitor class for type validation.
duke@1 1282 */
duke@1 1283 class Validator extends JCTree.Visitor {
duke@1 1284
mcimadamore@638 1285 boolean isOuter;
mcimadamore@638 1286 Env<AttrContext> env;
mcimadamore@638 1287
mcimadamore@638 1288 Validator(Env<AttrContext> env) {
mcimadamore@638 1289 this.env = env;
mcimadamore@638 1290 }
mcimadamore@638 1291
jjg@398 1292 @Override
duke@1 1293 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1294 tree.elemtype.accept(this);
duke@1 1295 }
duke@1 1296
jjg@398 1297 @Override
duke@1 1298 public void visitTypeApply(JCTypeApply tree) {
jjg@1374 1299 if (tree.type.hasTag(CLASS)) {
duke@1 1300 List<JCExpression> args = tree.arguments;
mcimadamore@158 1301 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1302
mcimadamore@821 1303 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1304 if (incompatibleArg != null) {
mcimadamore@821 1305 for (JCTree arg : tree.arguments) {
mcimadamore@821 1306 if (arg.type == incompatibleArg) {
mcimadamore@829 1307 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1308 }
mcimadamore@829 1309 forms = forms.tail;
mcimadamore@829 1310 }
mcimadamore@829 1311 }
mcimadamore@829 1312
mcimadamore@829 1313 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1314
mcimadamore@638 1315 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1316
duke@1 1317 // For matching pairs of actual argument types `a' and
duke@1 1318 // formal type parameters with declared bound `b' ...
duke@1 1319 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1320 validateTree(args.head,
mcimadamore@638 1321 !(isOuter && is_java_lang_Class),
mcimadamore@638 1322 false);
duke@1 1323 args = args.tail;
duke@1 1324 forms = forms.tail;
duke@1 1325 }
duke@1 1326
duke@1 1327 // Check that this type is either fully parameterized, or
duke@1 1328 // not parameterized at all.
duke@1 1329 if (tree.type.getEnclosingType().isRaw())
duke@1 1330 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1331 if (tree.clazz.hasTag(SELECT))
duke@1 1332 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1333 }
duke@1 1334 }
duke@1 1335
jjg@398 1336 @Override
duke@1 1337 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1338 validateTrees(tree.bounds, true, isOuter);
duke@1 1339 checkClassBounds(tree.pos(), tree.type);
duke@1 1340 }
duke@1 1341
duke@1 1342 @Override
duke@1 1343 public void visitWildcard(JCWildcard tree) {
duke@1 1344 if (tree.inner != null)
mcimadamore@638 1345 validateTree(tree.inner, true, isOuter);
duke@1 1346 }
duke@1 1347
jjg@398 1348 @Override
duke@1 1349 public void visitSelect(JCFieldAccess tree) {
jjg@1374 1350 if (tree.type.hasTag(CLASS)) {
duke@1 1351 visitSelectInternal(tree);
duke@1 1352
duke@1 1353 // Check that this type is either fully parameterized, or
duke@1 1354 // not parameterized at all.
duke@1 1355 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1356 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1357 }
duke@1 1358 }
mcimadamore@852 1359
duke@1 1360 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1361 if (tree.type.tsym.isStatic() &&
duke@1 1362 tree.selected.type.isParameterized()) {
duke@1 1363 // The enclosing type is not a class, so we are
duke@1 1364 // looking at a static member type. However, the
duke@1 1365 // qualifying expression is parameterized.
duke@1 1366 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1367 } else {
duke@1 1368 // otherwise validate the rest of the expression
mcimadamore@122 1369 tree.selected.accept(this);
duke@1 1370 }
duke@1 1371 }
duke@1 1372
duke@1 1373 /** Default visitor method: do nothing.
duke@1 1374 */
jjg@398 1375 @Override
duke@1 1376 public void visitTree(JCTree tree) {
duke@1 1377 }
mcimadamore@122 1378
mcimadamore@638 1379 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1380 try {
mcimadamore@638 1381 if (tree != null) {
mcimadamore@638 1382 this.isOuter = isOuter;
mcimadamore@638 1383 tree.accept(this);
mcimadamore@638 1384 if (checkRaw)
mcimadamore@638 1385 checkRaw(tree, env);
mcimadamore@638 1386 }
mcimadamore@638 1387 } catch (CompletionFailure ex) {
mcimadamore@638 1388 completionError(tree.pos(), ex);
mcimadamore@638 1389 }
mcimadamore@638 1390 }
mcimadamore@638 1391
mcimadamore@638 1392 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1393 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1394 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1395 }
mcimadamore@638 1396
mcimadamore@638 1397 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1398 if (lint.isEnabled(LintCategory.RAW) &&
jjg@1374 1399 tree.type.hasTag(CLASS) &&
mcimadamore@638 1400 !TreeInfo.isDiamond(tree) &&
mcimadamore@1103 1401 !withinAnonConstr(env) &&
mcimadamore@638 1402 tree.type.isRaw()) {
mcimadamore@795 1403 log.warning(LintCategory.RAW,
mcimadamore@638 1404 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1405 }
mcimadamore@638 1406 }
mcimadamore@1103 1407
mcimadamore@1103 1408 boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1409 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1410 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1411 }
duke@1 1412 }
duke@1 1413
duke@1 1414 /* *************************************************************************
duke@1 1415 * Exception checking
duke@1 1416 **************************************************************************/
duke@1 1417
duke@1 1418 /* The following methods treat classes as sets that contain
duke@1 1419 * the class itself and all their subclasses
duke@1 1420 */
duke@1 1421
duke@1 1422 /** Is given type a subtype of some of the types in given list?
duke@1 1423 */
duke@1 1424 boolean subset(Type t, List<Type> ts) {
duke@1 1425 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1426 if (types.isSubtype(t, l.head)) return true;
duke@1 1427 return false;
duke@1 1428 }
duke@1 1429
duke@1 1430 /** Is given type a subtype or supertype of
duke@1 1431 * some of the types in given list?
duke@1 1432 */
duke@1 1433 boolean intersects(Type t, List<Type> ts) {
duke@1 1434 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1435 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1436 return false;
duke@1 1437 }
duke@1 1438
duke@1 1439 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1440 * in the list.
duke@1 1441 */
duke@1 1442 List<Type> incl(Type t, List<Type> ts) {
duke@1 1443 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1444 }
duke@1 1445
duke@1 1446 /** Remove type set from type set list.
duke@1 1447 */
duke@1 1448 List<Type> excl(Type t, List<Type> ts) {
duke@1 1449 if (ts.isEmpty()) {
duke@1 1450 return ts;
duke@1 1451 } else {
duke@1 1452 List<Type> ts1 = excl(t, ts.tail);
duke@1 1453 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1454 else if (ts1 == ts.tail) return ts;
duke@1 1455 else return ts1.prepend(ts.head);
duke@1 1456 }
duke@1 1457 }
duke@1 1458
duke@1 1459 /** Form the union of two type set lists.
duke@1 1460 */
duke@1 1461 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1462 List<Type> ts = ts1;
duke@1 1463 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1464 ts = incl(l.head, ts);
duke@1 1465 return ts;
duke@1 1466 }
duke@1 1467
duke@1 1468 /** Form the difference of two type lists.
duke@1 1469 */
duke@1 1470 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1471 List<Type> ts = ts1;
duke@1 1472 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1473 ts = excl(l.head, ts);
duke@1 1474 return ts;
duke@1 1475 }
duke@1 1476
duke@1 1477 /** Form the intersection of two type lists.
duke@1 1478 */
duke@1 1479 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1480 List<Type> ts = List.nil();
duke@1 1481 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1482 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1483 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1484 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1485 return ts;
duke@1 1486 }
duke@1 1487
duke@1 1488 /** Is exc an exception symbol that need not be declared?
duke@1 1489 */
duke@1 1490 boolean isUnchecked(ClassSymbol exc) {
duke@1 1491 return
duke@1 1492 exc.kind == ERR ||
duke@1 1493 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1494 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1495 }
duke@1 1496
duke@1 1497 /** Is exc an exception type that need not be declared?
duke@1 1498 */
duke@1 1499 boolean isUnchecked(Type exc) {
duke@1 1500 return
jjg@1374 1501 (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
jjg@1374 1502 (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
jjg@1374 1503 exc.hasTag(BOT);
duke@1 1504 }
duke@1 1505
duke@1 1506 /** Same, but handling completion failures.
duke@1 1507 */
duke@1 1508 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1509 try {
duke@1 1510 return isUnchecked(exc);
duke@1 1511 } catch (CompletionFailure ex) {
duke@1 1512 completionError(pos, ex);
duke@1 1513 return true;
duke@1 1514 }
duke@1 1515 }
duke@1 1516
duke@1 1517 /** Is exc handled by given exception list?
duke@1 1518 */
duke@1 1519 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1520 return isUnchecked(exc) || subset(exc, handled);
duke@1 1521 }
duke@1 1522
duke@1 1523 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1524 * @param thrown The list of thrown exceptions.
duke@1 1525 * @param handled The list of handled exceptions.
duke@1 1526 */
mcimadamore@362 1527 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1528 List<Type> unhandled = List.nil();
duke@1 1529 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1530 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1531 return unhandled;
duke@1 1532 }
duke@1 1533
duke@1 1534 /* *************************************************************************
duke@1 1535 * Overriding/Implementation checking
duke@1 1536 **************************************************************************/
duke@1 1537
duke@1 1538 /** The level of access protection given by a flag set,
duke@1 1539 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1540 */
duke@1 1541 static int protection(long flags) {
duke@1 1542 switch ((short)(flags & AccessFlags)) {
duke@1 1543 case PRIVATE: return 3;
duke@1 1544 case PROTECTED: return 1;
duke@1 1545 default:
duke@1 1546 case PUBLIC: return 0;
duke@1 1547 case 0: return 2;
duke@1 1548 }
duke@1 1549 }
duke@1 1550
duke@1 1551 /** A customized "cannot override" error message.
duke@1 1552 * @param m The overriding method.
duke@1 1553 * @param other The overridden method.
duke@1 1554 * @return An internationalized string.
duke@1 1555 */
mcimadamore@89 1556 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1557 String key;
duke@1 1558 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1559 key = "cant.override";
duke@1 1560 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1561 key = "cant.implement";
duke@1 1562 else
duke@1 1563 key = "clashes.with";
mcimadamore@89 1564 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1565 }
duke@1 1566
duke@1 1567 /** A customized "override" warning message.
duke@1 1568 * @param m The overriding method.
duke@1 1569 * @param other The overridden method.
duke@1 1570 * @return An internationalized string.
duke@1 1571 */
mcimadamore@89 1572 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1573 String key;
duke@1 1574 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1575 key = "unchecked.override";
duke@1 1576 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1577 key = "unchecked.implement";
duke@1 1578 else
duke@1 1579 key = "unchecked.clash.with";
mcimadamore@89 1580 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1581 }
duke@1 1582
duke@1 1583 /** A customized "override" warning message.
duke@1 1584 * @param m The overriding method.
duke@1 1585 * @param other The overridden method.
duke@1 1586 * @return An internationalized string.
duke@1 1587 */
mcimadamore@89 1588 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1589 String key;
duke@1 1590 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1591 key = "varargs.override";
duke@1 1592 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1593 key = "varargs.implement";
duke@1 1594 else
duke@1 1595 key = "varargs.clash.with";
mcimadamore@89 1596 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1597 }
duke@1 1598
duke@1 1599 /** Check that this method conforms with overridden method 'other'.
duke@1 1600 * where `origin' is the class where checking started.
duke@1 1601 * Complications:
duke@1 1602 * (1) Do not check overriding of synthetic methods
duke@1 1603 * (reason: they might be final).
duke@1 1604 * todo: check whether this is still necessary.
duke@1 1605 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1606 * than the method it implements. Augment the proxy methods with the
duke@1 1607 * undeclared exceptions in this case.
duke@1 1608 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1609 * has a result type
duke@1 1610 * extended by the result type of the method it implements.
duke@1 1611 * Change the proxies result type to the smaller type in this case.
duke@1 1612 *
duke@1 1613 * @param tree The tree from which positions
duke@1 1614 * are extracted for errors.
duke@1 1615 * @param m The overriding method.
duke@1 1616 * @param other The overridden method.
duke@1 1617 * @param origin The class of which the overriding method
duke@1 1618 * is a member.
duke@1 1619 */
duke@1 1620 void checkOverride(JCTree tree,
duke@1 1621 MethodSymbol m,
duke@1 1622 MethodSymbol other,
duke@1 1623 ClassSymbol origin) {
duke@1 1624 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1625 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1626 return;
duke@1 1627 }
duke@1 1628
duke@1 1629 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1630 if ((m.flags() & STATIC) != 0 &&
duke@1 1631 (other.flags() & STATIC) == 0) {
duke@1 1632 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1633 cannotOverride(m, other));
duke@1 1634 return;
duke@1 1635 }
duke@1 1636
duke@1 1637 // Error if instance method overrides static or final
duke@1 1638 // method (JLS 8.4.6.1).
duke@1 1639 if ((other.flags() & FINAL) != 0 ||
duke@1 1640 (m.flags() & STATIC) == 0 &&
duke@1 1641 (other.flags() & STATIC) != 0) {
duke@1 1642 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1643 cannotOverride(m, other),
mcimadamore@80 1644 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1645 return;
duke@1 1646 }
duke@1 1647
duke@1 1648 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1649 // handled in validateAnnotationMethod
duke@1 1650 return;
duke@1 1651 }
duke@1 1652
duke@1 1653 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1654 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1655 protection(m.flags()) > protection(other.flags())) {
duke@1 1656 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1657 cannotOverride(m, other),
mcimadamore@80 1658 other.flags() == 0 ?
mcimadamore@80 1659 Flag.PACKAGE :
mcimadamore@80 1660 asFlagSet(other.flags() & AccessFlags));
duke@1 1661 return;
duke@1 1662 }
duke@1 1663
duke@1 1664 Type mt = types.memberType(origin.type, m);
duke@1 1665 Type ot = types.memberType(origin.type, other);
duke@1 1666 // Error if overriding result type is different
duke@1 1667 // (or, in the case of generics mode, not a subtype) of
duke@1 1668 // overridden result type. We have to rename any type parameters
duke@1 1669 // before comparing types.
duke@1 1670 List<Type> mtvars = mt.getTypeArguments();
duke@1 1671 List<Type> otvars = ot.getTypeArguments();
duke@1 1672 Type mtres = mt.getReturnType();
duke@1 1673 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1674
mcimadamore@795 1675 overrideWarner.clear();
duke@1 1676 boolean resultTypesOK =
tbell@202 1677 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1678 if (!resultTypesOK) {
jjg@398 1679 if (!allowCovariantReturns &&
duke@1 1680 m.owner != origin &&
duke@1 1681 m.owner.isSubClass(other.owner, types)) {
duke@1 1682 // allow limited interoperability with covariant returns
duke@1 1683 } else {
mcimadamore@362 1684 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1685 "override.incompatible.ret",
mcimadamore@362 1686 cannotOverride(m, other),
duke@1 1687 mtres, otres);
duke@1 1688 return;
duke@1 1689 }
mcimadamore@795 1690 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1691 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1692 "override.unchecked.ret",
mcimadamore@362 1693 uncheckedOverrides(m, other),
mcimadamore@362 1694 mtres, otres);
duke@1 1695 }
duke@1 1696
duke@1 1697 // Error if overriding method throws an exception not reported
duke@1 1698 // by overridden method.
duke@1 1699 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1700 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1701 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1702 if (unhandledErased.nonEmpty()) {
duke@1 1703 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1704 "override.meth.doesnt.throw",
duke@1 1705 cannotOverride(m, other),
mcimadamore@362 1706 unhandledUnerased.head);
mcimadamore@362 1707 return;
mcimadamore@362 1708 }
mcimadamore@362 1709 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1710 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1711 "override.unchecked.thrown",
mcimadamore@362 1712 cannotOverride(m, other),
mcimadamore@362 1713 unhandledUnerased.head);
duke@1 1714 return;
duke@1 1715 }
duke@1 1716
duke@1 1717 // Optional warning if varargs don't agree
duke@1 1718 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1719 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1720 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1721 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1722 ? "override.varargs.missing"
duke@1 1723 : "override.varargs.extra",
duke@1 1724 varargsOverrides(m, other));
duke@1 1725 }
duke@1 1726
duke@1 1727 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1728 if ((other.flags() & BRIDGE) != 0) {
duke@1 1729 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1730 uncheckedOverrides(m, other));
duke@1 1731 }
duke@1 1732
duke@1 1733 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1734 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1735 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1736 }
duke@1 1737 }
duke@1 1738 // where
duke@1 1739 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1740 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1741 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1742 // because in that case, we will rediscover the issue when examining the method
duke@1 1743 // in the supertype.
duke@1 1744 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1745 // address the issue is when the method is the supertype implemementation: any other
duke@1 1746 // case, we will have dealt with when examining the supertype classes
duke@1 1747 ClassSymbol mc = m.enclClass();
duke@1 1748 Type st = types.supertype(origin.type);
jjg@1374 1749 if (!st.hasTag(CLASS))
duke@1 1750 return true;
duke@1 1751 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1752
duke@1 1753 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1754 List<Type> intfs = types.interfaces(origin.type);
duke@1 1755 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1756 }
duke@1 1757 else
duke@1 1758 return (stimpl != m);
duke@1 1759 }
duke@1 1760
duke@1 1761
duke@1 1762 // used to check if there were any unchecked conversions
duke@1 1763 Warner overrideWarner = new Warner();
duke@1 1764
duke@1 1765 /** Check that a class does not inherit two concrete methods
duke@1 1766 * with the same signature.
duke@1 1767 * @param pos Position to be used for error reporting.
duke@1 1768 * @param site The class type to be checked.
duke@1 1769 */
duke@1 1770 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1771 Type sup = types.supertype(site);
jjg@1374 1772 if (!sup.hasTag(CLASS)) return;
duke@1 1773
duke@1 1774 for (Type t1 = sup;
duke@1 1775 t1.tsym.type.isParameterized();
duke@1 1776 t1 = types.supertype(t1)) {
duke@1 1777 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1778 e1 != null;
duke@1 1779 e1 = e1.sibling) {
duke@1 1780 Symbol s1 = e1.sym;
duke@1 1781 if (s1.kind != MTH ||
duke@1 1782 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1783 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1784 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1785 types,
duke@1 1786 true) != s1)
duke@1 1787 continue;
duke@1 1788 Type st1 = types.memberType(t1, s1);
duke@1 1789 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1790 if (st1 == s1.type) continue;
duke@1 1791
duke@1 1792 for (Type t2 = sup;
jjg@1374 1793 t2.hasTag(CLASS);
duke@1 1794 t2 = types.supertype(t2)) {
mcimadamore@24 1795 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1796 e2.scope != null;
duke@1 1797 e2 = e2.next()) {
duke@1 1798 Symbol s2 = e2.sym;
duke@1 1799 if (s2 == s1 ||
duke@1 1800 s2.kind != MTH ||
duke@1 1801 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1802 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1803 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1804 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1805 types,
duke@1 1806 true) != s2)
duke@1 1807 continue;
duke@1 1808 Type st2 = types.memberType(t2, s2);
duke@1 1809 if (types.overrideEquivalent(st1, st2))
duke@1 1810 log.error(pos, "concrete.inheritance.conflict",
duke@1 1811 s1, t1, s2, t2, sup);
duke@1 1812 }
duke@1 1813 }
duke@1 1814 }
duke@1 1815 }
duke@1 1816 }
duke@1 1817
duke@1 1818 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1819 * method with same name and arguments but incompatible return types.
duke@1 1820 * @param pos Position to be used for error reporting.
duke@1 1821 * @param t1 The first argument type.
duke@1 1822 * @param t2 The second argument type.
duke@1 1823 */
duke@1 1824 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1825 Type t1,
duke@1 1826 Type t2) {
duke@1 1827 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1828 types.makeCompoundType(t1, t2));
duke@1 1829 }
duke@1 1830
duke@1 1831 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1832 Type t1,
duke@1 1833 Type t2,
duke@1 1834 Type site) {
mcimadamore@746 1835 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1836 }
duke@1 1837
duke@1 1838 /** Return the first method which is defined with same args
duke@1 1839 * but different return types in two given interfaces, or null if none
duke@1 1840 * exists.
duke@1 1841 * @param t1 The first type.
duke@1 1842 * @param t2 The second type.
duke@1 1843 * @param site The most derived type.
duke@1 1844 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1845 */
mcimadamore@746 1846 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1847 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1848 closure(t1, interfaces1);
duke@1 1849 Map<TypeSymbol,Type> interfaces2;
duke@1 1850 if (t1 == t2)
duke@1 1851 interfaces2 = interfaces1;
duke@1 1852 else
duke@1 1853 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1854
duke@1 1855 for (Type t3 : interfaces1.values()) {
duke@1 1856 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1857 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1858 if (s != null) return s;
duke@1 1859 }
duke@1 1860 }
duke@1 1861 return null;
duke@1 1862 }
duke@1 1863
duke@1 1864 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1865 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1866 if (!t.hasTag(CLASS)) return;
duke@1 1867 if (typeMap.put(t.tsym, t) == null) {
duke@1 1868 closure(types.supertype(t), typeMap);
duke@1 1869 for (Type i : types.interfaces(t))
duke@1 1870 closure(i, typeMap);
duke@1 1871 }
duke@1 1872 }
duke@1 1873
duke@1 1874 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1875 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1876 if (!t.hasTag(CLASS)) return;
duke@1 1877 if (typesSkip.get(t.tsym) != null) return;
duke@1 1878 if (typeMap.put(t.tsym, t) == null) {
duke@1 1879 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1880 for (Type i : types.interfaces(t))
duke@1 1881 closure(i, typesSkip, typeMap);
duke@1 1882 }
duke@1 1883 }
duke@1 1884
duke@1 1885 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1886 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1887 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1888 Symbol s1 = e1.sym;
duke@1 1889 Type st1 = null;
duke@1 1890 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
duke@1 1891 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1892 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1893 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1894 Symbol s2 = e2.sym;
duke@1 1895 if (s1 == s2) continue;
duke@1 1896 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
duke@1 1897 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1898 Type st2 = types.memberType(t2, s2);
duke@1 1899 if (types.overrideEquivalent(st1, st2)) {
duke@1 1900 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1901 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1902 Type rt1 = st1.getReturnType();
duke@1 1903 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1904 boolean compat =
duke@1 1905 types.isSameType(rt1, rt2) ||
jjg@1374 1906 !rt1.isPrimitiveOrVoid() &&
jjg@1374 1907 !rt2.isPrimitiveOrVoid() &&
duke@1 1908 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
mcimadamore@59 1909 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
mcimadamore@59 1910 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1911 if (!compat) {
mcimadamore@746 1912 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1913 t1, t2, s2.name +
mcimadamore@746 1914 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1915 return s2;
mcimadamore@746 1916 }
mcimadamore@889 1917 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1918 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1919 log.error(pos,
mcimadamore@746 1920 "name.clash.same.erasure.no.override",
mcimadamore@746 1921 s1, s1.location(),
mcimadamore@746 1922 s2, s2.location());
mcimadamore@746 1923 return s2;
duke@1 1924 }
duke@1 1925 }
duke@1 1926 }
duke@1 1927 return null;
duke@1 1928 }
mcimadamore@59 1929 //WHERE
mcimadamore@59 1930 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1931 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1932 Type st1 = types.memberType(site, s1);
mcimadamore@59 1933 Type st2 = types.memberType(site, s2);
mcimadamore@59 1934 closure(site, supertypes);
mcimadamore@59 1935 for (Type t : supertypes.values()) {
mcimadamore@59 1936 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1937 Symbol s3 = e.sym;
mcimadamore@59 1938 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1939 Type st3 = types.memberType(site,s3);
mcimadamore@59 1940 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1941 if (s3.owner == site.tsym) {
mcimadamore@59 1942 return true;
mcimadamore@59 1943 }
mcimadamore@59 1944 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1945 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1946 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1947 Type rt1 = st1.getReturnType();
mcimadamore@59 1948 Type rt2 = st2.getReturnType();
mcimadamore@59 1949 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1950 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1951 boolean compat =
jjg@1374 1952 !rt13.isPrimitiveOrVoid() &&
jjg@1374 1953 !rt23.isPrimitiveOrVoid() &&
mcimadamore@59 1954 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
mcimadamore@59 1955 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
mcimadamore@59 1956 if (compat)
mcimadamore@59 1957 return true;
mcimadamore@59 1958 }
mcimadamore@59 1959 }
mcimadamore@59 1960 }
mcimadamore@59 1961 return false;
mcimadamore@59 1962 }
duke@1 1963
duke@1 1964 /** Check that a given method conforms with any method it overrides.
duke@1 1965 * @param tree The tree from which positions are extracted
duke@1 1966 * for errors.
duke@1 1967 * @param m The overriding method.
duke@1 1968 */
duke@1 1969 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1970 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1971 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1972 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1973 log.error(tree.pos(), "enum.no.finalize");
duke@1 1974 return;
duke@1 1975 }
jjg@1374 1976 for (Type t = origin.type; t.hasTag(CLASS);
duke@1 1977 t = types.supertype(t)) {
mcimadamore@746 1978 if (t != origin.type) {
mcimadamore@746 1979 checkOverride(tree, t, origin, m);
mcimadamore@746 1980 }
mcimadamore@746 1981 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1982 checkOverride(tree, t2, origin, m);
duke@1 1983 }
duke@1 1984 }
duke@1 1985 }
duke@1 1986
mcimadamore@746 1987 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1988 TypeSymbol c = site.tsym;
mcimadamore@746 1989 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1990 while (e.scope != null) {
mcimadamore@746 1991 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1992 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1993 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1994 }
mcimadamore@746 1995 }
mcimadamore@746 1996 e = e.next();
mcimadamore@746 1997 }
mcimadamore@746 1998 }
mcimadamore@746 1999
mcimadamore@746 2000 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 2001 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 2002 return (cf.accepts(s1) &&
mcimadamore@858 2003 cf.accepts(s2) &&
mcimadamore@858 2004 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 2005 }
mcimadamore@746 2006
mcimadamore@746 2007
duke@1 2008 /** Check that all abstract members of given class have definitions.
duke@1 2009 * @param pos Position to be used for error reporting.
duke@1 2010 * @param c The class.
duke@1 2011 */
duke@1 2012 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2013 try {
duke@1 2014 MethodSymbol undef = firstUndef(c, c);
duke@1 2015 if (undef != null) {
duke@1 2016 if ((c.flags() & ENUM) != 0 &&
duke@1 2017 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 2018 (c.flags() & FINAL) == 0) {
duke@1 2019 // add the ABSTRACT flag to an enum
duke@1 2020 c.flags_field |= ABSTRACT;
duke@1 2021 } else {
duke@1 2022 MethodSymbol undef1 =
duke@1 2023 new MethodSymbol(undef.flags(), undef.name,
duke@1 2024 types.memberType(c.type, undef), undef.owner);
duke@1 2025 log.error(pos, "does.not.override.abstract",
duke@1 2026 c, undef1, undef1.location());
duke@1 2027 }
duke@1 2028 }
duke@1 2029 } catch (CompletionFailure ex) {
duke@1 2030 completionError(pos, ex);
duke@1 2031 }
duke@1 2032 }
duke@1 2033 //where
duke@1 2034 /** Return first abstract member of class `c' that is not defined
duke@1 2035 * in `impl', null if there is none.
duke@1 2036 */
duke@1 2037 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 2038 MethodSymbol undef = null;
duke@1 2039 // Do not bother to search in classes that are not abstract,
duke@1 2040 // since they cannot have abstract members.
duke@1 2041 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 2042 Scope s = c.members();
duke@1 2043 for (Scope.Entry e = s.elems;
duke@1 2044 undef == null && e != null;
duke@1 2045 e = e.sibling) {
duke@1 2046 if (e.sym.kind == MTH &&
duke@1 2047 (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
duke@1 2048 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2049 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
duke@1 2050 if (implmeth == null || implmeth == absmeth)
duke@1 2051 undef = absmeth;
duke@1 2052 }
duke@1 2053 }
duke@1 2054 if (undef == null) {
duke@1 2055 Type st = types.supertype(c.type);
jjg@1374 2056 if (st.hasTag(CLASS))
duke@1 2057 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 2058 }
duke@1 2059 for (List<Type> l = types.interfaces(c.type);
duke@1 2060 undef == null && l.nonEmpty();
duke@1 2061 l = l.tail) {
duke@1 2062 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 2063 }
duke@1 2064 }
duke@1 2065 return undef;
duke@1 2066 }
duke@1 2067
mcimadamore@690 2068 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 2069 CycleChecker cc = new CycleChecker();
mcimadamore@690 2070 cc.scan(tree);
mcimadamore@690 2071 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 2072 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 2073 }
mcimadamore@690 2074 }
mcimadamore@690 2075
mcimadamore@690 2076 class CycleChecker extends TreeScanner {
mcimadamore@690 2077
mcimadamore@690 2078 List<Symbol> seenClasses = List.nil();
mcimadamore@690 2079 boolean errorFound = false;
mcimadamore@690 2080 boolean partialCheck = false;
mcimadamore@690 2081
mcimadamore@690 2082 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 2083 if (sym != null && sym.kind == TYP) {
mcimadamore@690 2084 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 2085 if (classEnv != null) {
mcimadamore@690 2086 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2087 try {
mcimadamore@690 2088 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2089 scan(classEnv.tree);
mcimadamore@690 2090 }
mcimadamore@690 2091 finally {
mcimadamore@690 2092 log.useSource(prevSource.getFile());
mcimadamore@690 2093 }
mcimadamore@690 2094 } else if (sym.kind == TYP) {
mcimadamore@690 2095 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2096 }
mcimadamore@690 2097 } else {
mcimadamore@690 2098 //not completed yet
mcimadamore@690 2099 partialCheck = true;
mcimadamore@690 2100 }
mcimadamore@690 2101 }
mcimadamore@690 2102
mcimadamore@690 2103 @Override
mcimadamore@690 2104 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2105 super.visitSelect(tree);
mcimadamore@690 2106 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2107 }
mcimadamore@690 2108
mcimadamore@690 2109 @Override
mcimadamore@690 2110 public void visitIdent(JCIdent tree) {
mcimadamore@690 2111 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2112 }
mcimadamore@690 2113
mcimadamore@690 2114 @Override
mcimadamore@690 2115 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2116 scan(tree.clazz);
mcimadamore@690 2117 }
mcimadamore@690 2118
mcimadamore@690 2119 @Override
mcimadamore@690 2120 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2121 scan(tree.elemtype);
mcimadamore@690 2122 }
mcimadamore@690 2123
mcimadamore@690 2124 @Override
mcimadamore@690 2125 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2126 List<JCTree> supertypes = List.nil();
mcimadamore@690 2127 if (tree.getExtendsClause() != null) {
mcimadamore@690 2128 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2129 }
mcimadamore@690 2130 if (tree.getImplementsClause() != null) {
mcimadamore@690 2131 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2132 supertypes = supertypes.prepend(intf);
mcimadamore@690 2133 }
mcimadamore@690 2134 }
mcimadamore@690 2135 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2136 }
mcimadamore@690 2137
mcimadamore@690 2138 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2139 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2140 return;
mcimadamore@690 2141 if (seenClasses.contains(c)) {
mcimadamore@690 2142 errorFound = true;
mcimadamore@690 2143 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2144 } else if (!c.type.isErroneous()) {
mcimadamore@690 2145 try {
mcimadamore@690 2146 seenClasses = seenClasses.prepend(c);
jjg@1374 2147 if (c.type.hasTag(CLASS)) {
mcimadamore@690 2148 if (supertypes.nonEmpty()) {
mcimadamore@690 2149 scan(supertypes);
mcimadamore@690 2150 }
mcimadamore@690 2151 else {
mcimadamore@690 2152 ClassType ct = (ClassType)c.type;
mcimadamore@690 2153 if (ct.supertype_field == null ||
mcimadamore@690 2154 ct.interfaces_field == null) {
mcimadamore@690 2155 //not completed yet
mcimadamore@690 2156 partialCheck = true;
mcimadamore@690 2157 return;
mcimadamore@690 2158 }
mcimadamore@690 2159 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2160 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2161 checkSymbol(pos, intf.tsym);
mcimadamore@690 2162 }
mcimadamore@690 2163 }
mcimadamore@690 2164 if (c.owner.kind == TYP) {
mcimadamore@690 2165 checkSymbol(pos, c.owner);
mcimadamore@690 2166 }
mcimadamore@690 2167 }
mcimadamore@690 2168 } finally {
mcimadamore@690 2169 seenClasses = seenClasses.tail;
mcimadamore@690 2170 }
mcimadamore@690 2171 }
mcimadamore@690 2172 }
mcimadamore@690 2173 }
mcimadamore@690 2174
duke@1 2175 /** Check for cyclic references. Issue an error if the
duke@1 2176 * symbol of the type referred to has a LOCKED flag set.
duke@1 2177 *
duke@1 2178 * @param pos Position to be used for error reporting.
duke@1 2179 * @param t The type referred to.
duke@1 2180 */
duke@1 2181 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2182 checkNonCyclicInternal(pos, t);
duke@1 2183 }
duke@1 2184
duke@1 2185
duke@1 2186 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2187 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2188 }
duke@1 2189
mcimadamore@236 2190 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2191 final TypeVar tv;
jjg@1374 2192 if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2193 return;
duke@1 2194 if (seen.contains(t)) {
duke@1 2195 tv = (TypeVar)t;
jjg@110 2196 tv.bound = types.createErrorType(t);
duke@1 2197 log.error(pos, "cyclic.inheritance", t);
jjg@1374 2198 } else if (t.hasTag(TYPEVAR)) {
duke@1 2199 tv = (TypeVar)t;
mcimadamore@236 2200 seen = seen.prepend(tv);
duke@1 2201 for (Type b : types.getBounds(tv))
duke@1 2202 checkNonCyclic1(pos, b, seen);
duke@1 2203 }
duke@1 2204 }
duke@1 2205
duke@1 2206 /** Check for cyclic references. Issue an error if the
duke@1 2207 * symbol of the type referred to has a LOCKED flag set.
duke@1 2208 *
duke@1 2209 * @param pos Position to be used for error reporting.
duke@1 2210 * @param t The type referred to.
duke@1 2211 * @returns True if the check completed on all attributed classes
duke@1 2212 */
duke@1 2213 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2214 boolean complete = true; // was the check complete?
duke@1 2215 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2216 Symbol c = t.tsym;
duke@1 2217 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2218
duke@1 2219 if ((c.flags_field & LOCKED) != 0) {
duke@1 2220 noteCyclic(pos, (ClassSymbol)c);
duke@1 2221 } else if (!c.type.isErroneous()) {
duke@1 2222 try {
duke@1 2223 c.flags_field |= LOCKED;
jjg@1374 2224 if (c.type.hasTag(CLASS)) {
duke@1 2225 ClassType clazz = (ClassType)c.type;
duke@1 2226 if (clazz.interfaces_field != null)
duke@1 2227 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2228 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2229 if (clazz.supertype_field != null) {
duke@1 2230 Type st = clazz.supertype_field;
jjg@1374 2231 if (st != null && st.hasTag(CLASS))
duke@1 2232 complete &= checkNonCyclicInternal(pos, st);
duke@1 2233 }
duke@1 2234 if (c.owner.kind == TYP)
duke@1 2235 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2236 }
duke@1 2237 } finally {
duke@1 2238 c.flags_field &= ~LOCKED;
duke@1 2239 }
duke@1 2240 }
duke@1 2241 if (complete)
duke@1 2242 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2243 if (complete) c.flags_field |= ACYCLIC;
duke@1 2244 return complete;
duke@1 2245 }
duke@1 2246
duke@1 2247 /** Note that we found an inheritance cycle. */
duke@1 2248 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2249 log.error(pos, "cyclic.inheritance", c);
duke@1 2250 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2251 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2252 Type st = types.supertype(c.type);
jjg@1374 2253 if (st.hasTag(CLASS))
jjg@110 2254 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2255 c.type = types.createErrorType(c, c.type);
duke@1 2256 c.flags_field |= ACYCLIC;
duke@1 2257 }
duke@1 2258
duke@1 2259 /** Check that all methods which implement some
duke@1 2260 * method conform to the method they implement.
duke@1 2261 * @param tree The class definition whose members are checked.
duke@1 2262 */
duke@1 2263 void checkImplementations(JCClassDecl tree) {
duke@1 2264 checkImplementations(tree, tree.sym);
duke@1 2265 }
duke@1 2266 //where
duke@1 2267 /** Check that all methods which implement some
duke@1 2268 * method in `ic' conform to the method they implement.
duke@1 2269 */
duke@1 2270 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
duke@1 2271 ClassSymbol origin = tree.sym;
duke@1 2272 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2273 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2274 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2275 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2276 if (e.sym.kind == MTH &&
duke@1 2277 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2278 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2279 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2280 if (implmeth != null && implmeth != absmeth &&
duke@1 2281 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2282 (origin.flags() & INTERFACE)) {
duke@1 2283 // don't check if implmeth is in a class, yet
duke@1 2284 // origin is an interface. This case arises only
duke@1 2285 // if implmeth is declared in Object. The reason is
duke@1 2286 // that interfaces really don't inherit from
duke@1 2287 // Object it's just that the compiler represents
duke@1 2288 // things that way.
duke@1 2289 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2290 }
duke@1 2291 }
duke@1 2292 }
duke@1 2293 }
duke@1 2294 }
duke@1 2295 }
duke@1 2296
duke@1 2297 /** Check that all abstract methods implemented by a class are
duke@1 2298 * mutually compatible.
duke@1 2299 * @param pos Position to be used for error reporting.
duke@1 2300 * @param c The class whose interfaces are checked.
duke@1 2301 */
duke@1 2302 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2303 List<Type> supertypes = types.interfaces(c);
duke@1 2304 Type supertype = types.supertype(c);
jjg@1374 2305 if (supertype.hasTag(CLASS) &&
duke@1 2306 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2307 supertypes = supertypes.prepend(supertype);
duke@1 2308 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2309 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2310 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2311 return;
duke@1 2312 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2313 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2314 return;
duke@1 2315 }
duke@1 2316 checkCompatibleConcretes(pos, c);
duke@1 2317 }
duke@1 2318
mcimadamore@359 2319 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2320 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2321 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2322 // VM allows methods and variables with differing types
mcimadamore@359 2323 if (sym.kind == e.sym.kind &&
mcimadamore@359 2324 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2325 sym != e.sym &&
mcimadamore@359 2326 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2327 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2328 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2329 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2330 return;
mcimadamore@359 2331 }
mcimadamore@359 2332 }
mcimadamore@359 2333 }
mcimadamore@359 2334 }
mcimadamore@359 2335
mcimadamore@780 2336 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2337 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2338 *
mcimadamore@780 2339 * @param pos Position to be used for error reporting.
mcimadamore@780 2340 * @param site The class whose methods are checked.
mcimadamore@780 2341 * @param sym The method symbol to be checked.
mcimadamore@780 2342 */
mcimadamore@858 2343 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2344 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2345 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2346 //by method 'sym' in 'site'...
mcimadamore@1198 2347 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2348 if (!sym.overrides(m1, site.tsym, types, false)) continue;
mcimadamore@1198 2349 //...check each method m2 that is a member of 'site'
mcimadamore@1198 2350 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2351 if (m2 == m1) continue;
mcimadamore@858 2352 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2353 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1198 2354 if (!types.isSubSignature(sym.type, types.memberType(site, m2), false) &&
mcimadamore@1198 2355 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2356 sym.flags_field |= CLASH;
mcimadamore@1198 2357 String key = m1 == sym ?
mcimadamore@858 2358 "name.clash.same.erasure.no.override" :
mcimadamore@858 2359 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2360 log.error(pos,
mcimadamore@858 2361 key,
mcimadamore@858 2362 sym, sym.location(),
mcimadamore@1198 2363 m2, m2.location(),
mcimadamore@1198 2364 m1, m1.location());
mcimadamore@858 2365 return;
mcimadamore@858 2366 }
mcimadamore@780 2367 }
mcimadamore@780 2368 }
mcimadamore@780 2369 }
mcimadamore@780 2370
mcimadamore@877 2371
mcimadamore@877 2372
mcimadamore@858 2373 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2374 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2375 *
mcimadamore@858 2376 * @param pos Position to be used for error reporting.
mcimadamore@858 2377 * @param site The class whose methods are checked.
mcimadamore@858 2378 * @param sym The method symbol to be checked.
mcimadamore@780 2379 */
mcimadamore@858 2380 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2381 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2382 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2383 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2384 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2385 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@907 2386 if (!types.isSubSignature(sym.type, types.memberType(site, s), false) &&
mcimadamore@877 2387 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2388 log.error(pos,
mcimadamore@858 2389 "name.clash.same.erasure.no.hide",
mcimadamore@858 2390 sym, sym.location(),
mcimadamore@877 2391 s, s.location());
mcimadamore@858 2392 return;
mcimadamore@858 2393 }
mcimadamore@858 2394 }
mcimadamore@858 2395 }
mcimadamore@780 2396
mcimadamore@858 2397 //where
mcimadamore@858 2398 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2399
mcimadamore@858 2400 Type site;
mcimadamore@780 2401
mcimadamore@858 2402 ClashFilter(Type site) {
mcimadamore@858 2403 this.site = site;
mcimadamore@858 2404 }
mcimadamore@858 2405
mcimadamore@858 2406 boolean shouldSkip(Symbol s) {
mcimadamore@858 2407 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2408 s.owner == site.tsym;
mcimadamore@858 2409 }
mcimadamore@858 2410
mcimadamore@858 2411 public boolean accepts(Symbol s) {
mcimadamore@858 2412 return s.kind == MTH &&
mcimadamore@858 2413 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2414 !shouldSkip(s) &&
mcimadamore@858 2415 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2416 !s.isConstructor();
mcimadamore@858 2417 }
mcimadamore@858 2418 }
mcimadamore@780 2419
mcimadamore@359 2420 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2421 */
mcimadamore@359 2422 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2423 if (!sym.type.isErroneous()) {
mcimadamore@359 2424 if (warnOnSyntheticConflicts) {
mcimadamore@359 2425 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2426 }
mcimadamore@359 2427 else {
mcimadamore@359 2428 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2429 }
mcimadamore@359 2430 }
mcimadamore@359 2431 }
mcimadamore@359 2432
duke@1 2433 /** Check that class c does not implement directly or indirectly
duke@1 2434 * the same parameterized interface with two different argument lists.
duke@1 2435 * @param pos Position to be used for error reporting.
duke@1 2436 * @param type The type whose interfaces are checked.
duke@1 2437 */
duke@1 2438 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2439 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2440 }
duke@1 2441 //where
duke@1 2442 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2443 * with their class symbol as key and their type as value. Make
duke@1 2444 * sure no class is entered with two different types.
duke@1 2445 */
duke@1 2446 void checkClassBounds(DiagnosticPosition pos,
duke@1 2447 Map<TypeSymbol,Type> seensofar,
duke@1 2448 Type type) {
duke@1 2449 if (type.isErroneous()) return;
duke@1 2450 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2451 Type it = l.head;
duke@1 2452 Type oldit = seensofar.put(it.tsym, it);
duke@1 2453 if (oldit != null) {
duke@1 2454 List<Type> oldparams = oldit.allparams();
duke@1 2455 List<Type> newparams = it.allparams();
duke@1 2456 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2457 log.error(pos, "cant.inherit.diff.arg",
duke@1 2458 it.tsym, Type.toString(oldparams),
duke@1 2459 Type.toString(newparams));
duke@1 2460 }
duke@1 2461 checkClassBounds(pos, seensofar, it);
duke@1 2462 }
duke@1 2463 Type st = types.supertype(type);
duke@1 2464 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2465 }
duke@1 2466
duke@1 2467 /** Enter interface into into set.
duke@1 2468 * If it existed already, issue a "repeated interface" error.
duke@1 2469 */
duke@1 2470 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2471 if (its.contains(it))
duke@1 2472 log.error(pos, "repeated.interface");
duke@1 2473 else {
duke@1 2474 its.add(it);
duke@1 2475 }
duke@1 2476 }
duke@1 2477
duke@1 2478 /* *************************************************************************
duke@1 2479 * Check annotations
duke@1 2480 **************************************************************************/
duke@1 2481
mcimadamore@629 2482 /**
mcimadamore@634 2483 * Recursively validate annotations values
mcimadamore@629 2484 */
mcimadamore@634 2485 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2486 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2487 @Override
mcimadamore@629 2488 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2489 if (!tree.type.isErroneous()) {
jjg@1017 2490 super.visitAnnotation(tree);
jjg@1017 2491 validateAnnotation(tree);
jjg@1017 2492 }
mcimadamore@629 2493 }
mcimadamore@629 2494 }
mcimadamore@634 2495 tree.accept(new AnnotationValidator());
mcimadamore@629 2496 }
mcimadamore@629 2497
jjg@1326 2498 /**
jjg@1326 2499 * {@literal
jjg@1326 2500 * Annotation types are restricted to primitives, String, an
duke@1 2501 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2502 * Anything>, arrays of the preceding.
jjg@1326 2503 * }
duke@1 2504 */
duke@1 2505 void validateAnnotationType(JCTree restype) {
duke@1 2506 // restype may be null if an error occurred, so don't bother validating it
duke@1 2507 if (restype != null) {
duke@1 2508 validateAnnotationType(restype.pos(), restype.type);
duke@1 2509 }
duke@1 2510 }
duke@1 2511
duke@1 2512 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2513 if (type.isPrimitive()) return;
duke@1 2514 if (types.isSameType(type, syms.stringType)) return;
duke@1 2515 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2516 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2517 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2518 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2519 validateAnnotationType(pos, types.elemtype(type));
duke@1 2520 return;
duke@1 2521 }
duke@1 2522 log.error(pos, "invalid.annotation.member.type");
duke@1 2523 }
duke@1 2524
duke@1 2525 /**
duke@1 2526 * "It is also a compile-time error if any method declared in an
duke@1 2527 * annotation type has a signature that is override-equivalent to
duke@1 2528 * that of any public or protected method declared in class Object
duke@1 2529 * or in the interface annotation.Annotation."
duke@1 2530 *
jjh@972 2531 * @jls 9.6 Annotation Types
duke@1 2532 */
duke@1 2533 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
jjg@1374 2534 for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
duke@1 2535 Scope s = sup.tsym.members();
duke@1 2536 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2537 if (e.sym.kind == MTH &&
duke@1 2538 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2539 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2540 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2541 }
duke@1 2542 }
duke@1 2543 }
duke@1 2544
duke@1 2545 /** Check the annotations of a symbol.
duke@1 2546 */
duke@1 2547 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2548 for (JCAnnotation a : annotations)
duke@1 2549 validateAnnotation(a, s);
duke@1 2550 }
duke@1 2551
duke@1 2552 /** Check an annotation of a symbol.
duke@1 2553 */
jfranck@1313 2554 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2555 validateAnnotationTree(a);
duke@1 2556
duke@1 2557 if (!annotationApplicable(a, s))
duke@1 2558 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2559
duke@1 2560 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2561 if (!isOverrider(s))
duke@1 2562 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2563 }
duke@1 2564 }
duke@1 2565
jfranck@1313 2566 /**
jfranck@1313 2567 * Validate the proposed container 'containedBy' on the
jfranck@1313 2568 * annotation type symbol 's'. Report errors at position
jfranck@1313 2569 * 'pos'.
jfranck@1313 2570 *
jfranck@1313 2571 * @param s The (annotation)type declaration annotated with a @ContainedBy
jjg@1358 2572 * @param containedBy the @ContainedBy on 's'
jfranck@1313 2573 * @param pos where to report errors
jfranck@1313 2574 */
jfranck@1313 2575 public void validateContainedBy(TypeSymbol s, Attribute.Compound containedBy, DiagnosticPosition pos) {
jfranck@1313 2576 Assert.check(types.isSameType(containedBy.type, syms.containedByType));
jfranck@1313 2577
jfranck@1313 2578 Type t = null;
jfranck@1313 2579 List<Pair<MethodSymbol,Attribute>> l = containedBy.values;
jfranck@1313 2580 if (!l.isEmpty()) {
jfranck@1313 2581 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2582 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2583 }
jfranck@1313 2584
jfranck@1313 2585 if (t == null) {
jfranck@1313 2586 log.error(pos, "invalid.container.wrong.containedby", s, containedBy);
jfranck@1313 2587 return;
jfranck@1313 2588 }
jfranck@1313 2589
jfranck@1313 2590 validateHasContainerFor(t.tsym, s, pos);
jfranck@1313 2591 validateRetention(t.tsym, s, pos);
jfranck@1313 2592 validateDocumented(t.tsym, s, pos);
jfranck@1313 2593 validateInherited(t.tsym, s, pos);
jfranck@1313 2594 validateTarget(t.tsym, s, pos);
jfranck@1344 2595 validateDefault(t.tsym, s, pos);
jfranck@1313 2596 }
jfranck@1313 2597
jfranck@1313 2598 /**
jfranck@1313 2599 * Validate the proposed container 'containerFor' on the
jfranck@1313 2600 * annotation type symbol 's'. Report errors at position
jfranck@1313 2601 * 'pos'.
jfranck@1313 2602 *
jfranck@1313 2603 * @param s The (annotation)type declaration annotated with a @ContainerFor
jfranck@1313 2604 * @param containerFor the @ContainedFor on 's'
jfranck@1313 2605 * @param pos where to report errors
jfranck@1313 2606 */
jfranck@1313 2607 public void validateContainerFor(TypeSymbol s, Attribute.Compound containerFor, DiagnosticPosition pos) {
jfranck@1313 2608 Assert.check(types.isSameType(containerFor.type, syms.containerForType));
jfranck@1313 2609
jfranck@1313 2610 Type t = null;
jfranck@1313 2611 List<Pair<MethodSymbol,Attribute>> l = containerFor.values;
jfranck@1313 2612 if (!l.isEmpty()) {
jfranck@1313 2613 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2614 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2615 }
jfranck@1313 2616
jfranck@1313 2617 if (t == null) {
jfranck@1313 2618 log.error(pos, "invalid.container.wrong.containerfor", s, containerFor);
jfranck@1313 2619 return;
jfranck@1313 2620 }
jfranck@1313 2621
jfranck@1313 2622 validateHasContainedBy(t.tsym, s, pos);
jfranck@1313 2623 }
jfranck@1313 2624
jfranck@1313 2625 private void validateHasContainedBy(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jfranck@1313 2626 Attribute.Compound containedBy = container.attribute(syms.containedByType.tsym);
jfranck@1313 2627
jfranck@1313 2628 if (containedBy == null) {
jfranck@1313 2629 log.error(pos, "invalid.container.no.containedby", container, syms.containedByType.tsym);
jfranck@1313 2630 return;
jfranck@1313 2631 }
jfranck@1313 2632
jfranck@1313 2633 Type t = null;
jfranck@1313 2634 List<Pair<MethodSymbol,Attribute>> l = containedBy.values;
jfranck@1313 2635 if (!l.isEmpty()) {
jfranck@1313 2636 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2637 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2638 }
jfranck@1313 2639
jfranck@1313 2640 if (t == null) {
jfranck@1313 2641 log.error(pos, "invalid.container.wrong.containedby", container, contained);
jfranck@1313 2642 return;
jfranck@1313 2643 }
jfranck@1313 2644
jfranck@1313 2645 if (!types.isSameType(t, contained.type))
jfranck@1313 2646 log.error(pos, "invalid.container.wrong.containedby", t.tsym, contained);
jfranck@1313 2647 }
jfranck@1313 2648
jfranck@1313 2649 private void validateHasContainerFor(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jfranck@1313 2650 Attribute.Compound containerFor = container.attribute(syms.containerForType.tsym);
jfranck@1313 2651
jfranck@1313 2652 if (containerFor == null) {
jfranck@1313 2653 log.error(pos, "invalid.container.no.containerfor", container, syms.containerForType.tsym);
jfranck@1313 2654 return;
jfranck@1313 2655 }
jfranck@1313 2656
jfranck@1313 2657 Type t = null;
jfranck@1313 2658 List<Pair<MethodSymbol,Attribute>> l = containerFor.values;
jfranck@1313 2659 if (!l.isEmpty()) {
jfranck@1313 2660 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2661 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2662 }
jfranck@1313 2663
jfranck@1313 2664 if (t == null) {
jfranck@1313 2665 log.error(pos, "invalid.container.wrong.containerfor", container, contained);
jfranck@1313 2666 return;
jfranck@1313 2667 }
jfranck@1313 2668
jfranck@1313 2669 if (!types.isSameType(t, contained.type))
jfranck@1313 2670 log.error(pos, "invalid.container.wrong.containerfor", t.tsym, contained);
jfranck@1313 2671 }
jfranck@1313 2672
jfranck@1313 2673 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2674 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2675 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2676
jfranck@1313 2677 boolean error = false;
jfranck@1313 2678 switch (containedRetention) {
jfranck@1313 2679 case RUNTIME:
jfranck@1313 2680 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2681 error = true;
jfranck@1313 2682 }
jfranck@1313 2683 break;
jfranck@1313 2684 case CLASS:
jfranck@1313 2685 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2686 error = true;
jfranck@1313 2687 }
jfranck@1313 2688 }
jfranck@1313 2689 if (error ) {
jfranck@1313 2690 log.error(pos, "invalid.containedby.annotation.retention",
jfranck@1313 2691 container, containerRetention,
jfranck@1313 2692 contained, containedRetention);
jfranck@1313 2693 }
jfranck@1313 2694 }
jfranck@1313 2695
jfranck@1313 2696 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2697 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2698 if (container.attribute(syms.documentedType.tsym) == null) {
jfranck@1313 2699 log.error(pos, "invalid.containedby.annotation.not.documented", container, contained);
jfranck@1313 2700 }
jfranck@1313 2701 }
jfranck@1313 2702 }
jfranck@1313 2703
jfranck@1313 2704 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2705 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2706 if (container.attribute(syms.inheritedType.tsym) == null) {
jfranck@1313 2707 log.error(pos, "invalid.containedby.annotation.not.inherited", container, contained);
jfranck@1313 2708 }
jfranck@1313 2709 }
jfranck@1313 2710 }
jfranck@1313 2711
jfranck@1313 2712 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2713 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1313 2714
jfranck@1313 2715 // If contained has no Target, we are done
jfranck@1313 2716 if (containedTarget == null) {
jfranck@1313 2717 return;
jfranck@1313 2718 }
jfranck@1313 2719
jfranck@1313 2720 // If contained has Target m1, container must have a Target
jfranck@1313 2721 // annotation, m2, and m2 must be a subset of m1. (This is
jfranck@1313 2722 // trivially true if contained has no target as per above).
jfranck@1313 2723
jfranck@1313 2724 // contained has target, but container has not, error
jfranck@1313 2725 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2726 if (containerTarget == null) {
jfranck@1313 2727 log.error(pos, "invalid.containedby.annotation.incompatible.target", container, contained);
jfranck@1313 2728 return;
jfranck@1313 2729 }
jfranck@1313 2730
jfranck@1313 2731 Set<Name> containerTargets = new HashSet<Name>();
jfranck@1313 2732 for (Attribute app : containerTarget.values) {
jfranck@1313 2733 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2734 continue; // recovery
jfranck@1313 2735 }
jfranck@1313 2736 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2737 containerTargets.add(e.value.name);
jfranck@1313 2738 }
jfranck@1313 2739
jfranck@1313 2740 Set<Name> containedTargets = new HashSet<Name>();
jfranck@1313 2741 for (Attribute app : containedTarget.values) {
jfranck@1313 2742 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2743 continue; // recovery
jfranck@1313 2744 }
jfranck@1313 2745 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2746 containedTargets.add(e.value.name);
jfranck@1313 2747 }
jfranck@1313 2748
jfranck@1313 2749 if (!isTargetSubset(containedTargets, containerTargets)) {
jfranck@1313 2750 log.error(pos, "invalid.containedby.annotation.incompatible.target", container, contained);
jfranck@1313 2751 }
jfranck@1313 2752 }
jfranck@1313 2753
jfranck@1313 2754 /** Checks that t is a subset of s, with respect to ElementType
jfranck@1313 2755 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE}
jfranck@1313 2756 */
jfranck@1313 2757 private boolean isTargetSubset(Set<Name> s, Set<Name> t) {
jfranck@1313 2758 // Check that all elements in t are present in s
jfranck@1313 2759 for (Name n2 : t) {
jfranck@1313 2760 boolean currentElementOk = false;
jfranck@1313 2761 for (Name n1 : s) {
jfranck@1313 2762 if (n1 == n2) {
jfranck@1313 2763 currentElementOk = true;
jfranck@1313 2764 break;
jfranck@1313 2765 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2766 currentElementOk = true;
jfranck@1313 2767 break;
jfranck@1313 2768 }
jfranck@1313 2769 }
jfranck@1313 2770 if (!currentElementOk)
jfranck@1313 2771 return false;
jfranck@1313 2772 }
jfranck@1313 2773 return true;
jfranck@1313 2774 }
jfranck@1313 2775
jfranck@1344 2776 private void validateDefault(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1344 2777 // validate that all other elements of containing type has defaults
jfranck@1344 2778 Scope scope = container.members();
jfranck@1344 2779 for(Symbol elm : scope.getElements()) {
jfranck@1344 2780 if (elm.name != names.value &&
jfranck@1344 2781 elm.kind == Kinds.MTH &&
jfranck@1344 2782 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2783 log.error(pos,
jfranck@1344 2784 "invalid.containedby.annotation.elem.nondefault",
jfranck@1344 2785 container,
jfranck@1344 2786 elm);
jfranck@1344 2787 }
jfranck@1344 2788 }
jfranck@1344 2789 }
jfranck@1344 2790
duke@1 2791 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2792 boolean isOverrider(Symbol s) {
duke@1 2793 if (s.kind != MTH || s.isStatic())
duke@1 2794 return false;
duke@1 2795 MethodSymbol m = (MethodSymbol)s;
duke@1 2796 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2797 for (Type sup : types.closure(owner.type)) {
duke@1 2798 if (sup == owner.type)
duke@1 2799 continue; // skip "this"
duke@1 2800 Scope scope = sup.tsym.members();
duke@1 2801 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2802 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2803 return true;
duke@1 2804 }
duke@1 2805 }
duke@1 2806 return false;
duke@1 2807 }
duke@1 2808
duke@1 2809 /** Is the annotation applicable to the symbol? */
duke@1 2810 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 2811 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jfranck@1313 2812 if (arr == null) {
jfranck@1313 2813 return true;
jfranck@1313 2814 }
duke@1 2815 for (Attribute app : arr.values) {
duke@1 2816 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2817 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2818 if (e.value.name == names.TYPE)
duke@1 2819 { if (s.kind == TYP) return true; }
duke@1 2820 else if (e.value.name == names.FIELD)
duke@1 2821 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2822 else if (e.value.name == names.METHOD)
duke@1 2823 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2824 else if (e.value.name == names.PARAMETER)
duke@1 2825 { if (s.kind == VAR &&
duke@1 2826 s.owner.kind == MTH &&
duke@1 2827 (s.flags() & PARAMETER) != 0)
duke@1 2828 return true;
duke@1 2829 }
duke@1 2830 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2831 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2832 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2833 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2834 (s.flags() & PARAMETER) == 0)
duke@1 2835 return true;
duke@1 2836 }
duke@1 2837 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2838 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2839 return true;
duke@1 2840 }
duke@1 2841 else if (e.value.name == names.PACKAGE)
duke@1 2842 { if (s.kind == PCK) return true; }
jjg@308 2843 else if (e.value.name == names.TYPE_USE)
jjg@308 2844 { if (s.kind == TYP ||
jjg@308 2845 s.kind == VAR ||
jjg@308 2846 (s.kind == MTH && !s.isConstructor() &&
jjg@1374 2847 !s.type.getReturnType().hasTag(VOID)))
jjg@308 2848 return true;
jjg@308 2849 }
duke@1 2850 else
duke@1 2851 return true; // recovery
duke@1 2852 }
duke@1 2853 return false;
duke@1 2854 }
duke@1 2855
jfranck@1313 2856
jfranck@1313 2857 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 2858 Attribute.Compound atTarget =
jfranck@1313 2859 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 2860 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 2861 Attribute atValue = atTarget.member(names.value);
jfranck@1313 2862 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 2863 return (Attribute.Array) atValue;
jfranck@1313 2864 }
jfranck@1313 2865
duke@1 2866 /** Check an annotation value.
duke@1 2867 */
duke@1 2868 public void validateAnnotation(JCAnnotation a) {
mcimadamore@632 2869 // collect an inventory of the members (sorted alphabetically)
mcimadamore@632 2870 Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
mcimadamore@632 2871 public int compare(Symbol t, Symbol t1) {
mcimadamore@632 2872 return t.name.compareTo(t1.name);
mcimadamore@632 2873 }
mcimadamore@632 2874 });
duke@1 2875 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2876 e != null;
duke@1 2877 e = e.sibling)
duke@1 2878 if (e.sym.kind == MTH)
duke@1 2879 members.add((MethodSymbol) e.sym);
duke@1 2880
duke@1 2881 // count them off as they're annotated
duke@1 2882 for (JCTree arg : a.args) {
jjg@1127 2883 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 2884 JCAssign assign = (JCAssign) arg;
duke@1 2885 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2886 if (m == null || m.type.isErroneous()) continue;
duke@1 2887 if (!members.remove(m))
jjg@479 2888 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2889 m.name, a.type);
duke@1 2890 }
duke@1 2891
duke@1 2892 // all the remaining ones better have default values
mcimadamore@632 2893 ListBuffer<Name> missingDefaults = ListBuffer.lb();
mcimadamore@632 2894 for (MethodSymbol m : members) {
mcimadamore@632 2895 if (m.defaultValue == null && !m.type.isErroneous()) {
mcimadamore@632 2896 missingDefaults.append(m.name);
mcimadamore@632 2897 }
mcimadamore@632 2898 }
mcimadamore@632 2899 if (missingDefaults.nonEmpty()) {
mcimadamore@632 2900 String key = (missingDefaults.size() > 1)
mcimadamore@632 2901 ? "annotation.missing.default.value.1"
mcimadamore@632 2902 : "annotation.missing.default.value";
mcimadamore@632 2903 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 2904 }
duke@1 2905
duke@1 2906 // special case: java.lang.annotation.Target must not have
duke@1 2907 // repeated values in its value member
duke@1 2908 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2909 a.args.tail == null)
duke@1 2910 return;
duke@1 2911
jjg@1127 2912 if (!a.args.head.hasTag(ASSIGN)) return; // error recovery
duke@1 2913 JCAssign assign = (JCAssign) a.args.head;
duke@1 2914 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2915 if (m.name != names.value) return;
duke@1 2916 JCTree rhs = assign.rhs;
jjg@1127 2917 if (!rhs.hasTag(NEWARRAY)) return;
duke@1 2918 JCNewArray na = (JCNewArray) rhs;
duke@1 2919 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2920 for (JCTree elem : na.elems) {
duke@1 2921 if (!targets.add(TreeInfo.symbol(elem))) {
duke@1 2922 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2923 }
duke@1 2924 }
duke@1 2925 }
duke@1 2926
duke@1 2927 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 2928 if (allowAnnotations &&
mcimadamore@795 2929 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 2930 (s.flags() & DEPRECATED) != 0 &&
duke@1 2931 !syms.deprecatedType.isErroneous() &&
duke@1 2932 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 2933 log.warning(LintCategory.DEP_ANN,
jjg@612 2934 pos, "missing.deprecated.annotation");
duke@1 2935 }
duke@1 2936 }
duke@1 2937
mcimadamore@852 2938 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 2939 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 2940 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 2941 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 2942 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2943 @Override
mcimadamore@852 2944 public void report() {
mcimadamore@852 2945 warnDeprecated(pos, s);
mcimadamore@852 2946 }
mcimadamore@852 2947 });
jjg@1157 2948 }
mcimadamore@852 2949 }
mcimadamore@852 2950
mcimadamore@852 2951 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 2952 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 2953 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2954 public void report() {
mcimadamore@852 2955 if (enableSunApiLintControl)
mcimadamore@852 2956 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 2957 else
mcimadamore@1218 2958 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 2959 }
mcimadamore@852 2960 });
mcimadamore@852 2961 }
mcimadamore@852 2962 }
mcimadamore@852 2963
duke@1 2964 /* *************************************************************************
duke@1 2965 * Check for recursive annotation elements.
duke@1 2966 **************************************************************************/
duke@1 2967
duke@1 2968 /** Check for cycles in the graph of annotation elements.
duke@1 2969 */
duke@1 2970 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 2971 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 2972 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 2973 try {
duke@1 2974 tree.sym.flags_field |= LOCKED;
duke@1 2975 for (JCTree def : tree.defs) {
jjg@1127 2976 if (!def.hasTag(METHODDEF)) continue;
duke@1 2977 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 2978 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 2979 }
duke@1 2980 } finally {
duke@1 2981 tree.sym.flags_field &= ~LOCKED;
duke@1 2982 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 2983 }
duke@1 2984 }
duke@1 2985
duke@1 2986 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 2987 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 2988 return;
duke@1 2989 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 2990 log.error(pos, "cyclic.annotation.element");
duke@1 2991 return;
duke@1 2992 }
duke@1 2993 try {
duke@1 2994 tsym.flags_field |= LOCKED;
duke@1 2995 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 2996 Symbol s = e.sym;
duke@1 2997 if (s.kind != Kinds.MTH)
duke@1 2998 continue;
duke@1 2999 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 3000 }
duke@1 3001 } finally {
duke@1 3002 tsym.flags_field &= ~LOCKED;
duke@1 3003 tsym.flags_field |= ACYCLIC_ANN;
duke@1 3004 }
duke@1 3005 }
duke@1 3006
duke@1 3007 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
jjg@1374 3008 switch (type.getTag()) {
jjg@1374 3009 case CLASS:
duke@1 3010 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 3011 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 3012 break;
jjg@1374 3013 case ARRAY:
duke@1 3014 checkAnnotationResType(pos, types.elemtype(type));
duke@1 3015 break;
duke@1 3016 default:
duke@1 3017 break; // int etc
duke@1 3018 }
duke@1 3019 }
duke@1 3020
duke@1 3021 /* *************************************************************************
duke@1 3022 * Check for cycles in the constructor call graph.
duke@1 3023 **************************************************************************/
duke@1 3024
duke@1 3025 /** Check for cycles in the graph of constructors calling other
duke@1 3026 * constructors.
duke@1 3027 */
duke@1 3028 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 3029 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 3030
duke@1 3031 // enter each constructor this-call into the map
duke@1 3032 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 3033 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 3034 if (app == null) continue;
duke@1 3035 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 3036 if (TreeInfo.name(app.meth) == names._this) {
duke@1 3037 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 3038 } else {
duke@1 3039 meth.sym.flags_field |= ACYCLIC;
duke@1 3040 }
duke@1 3041 }
duke@1 3042
duke@1 3043 // Check for cycles in the map
duke@1 3044 Symbol[] ctors = new Symbol[0];
duke@1 3045 ctors = callMap.keySet().toArray(ctors);
duke@1 3046 for (Symbol caller : ctors) {
duke@1 3047 checkCyclicConstructor(tree, caller, callMap);
duke@1 3048 }
duke@1 3049 }
duke@1 3050
duke@1 3051 /** Look in the map to see if the given constructor is part of a
duke@1 3052 * call cycle.
duke@1 3053 */
duke@1 3054 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 3055 Map<Symbol,Symbol> callMap) {
duke@1 3056 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 3057 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 3058 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 3059 "recursive.ctor.invocation");
duke@1 3060 } else {
duke@1 3061 ctor.flags_field |= LOCKED;
duke@1 3062 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 3063 ctor.flags_field &= ~LOCKED;
duke@1 3064 }
duke@1 3065 ctor.flags_field |= ACYCLIC;
duke@1 3066 }
duke@1 3067 }
duke@1 3068
duke@1 3069 /* *************************************************************************
duke@1 3070 * Miscellaneous
duke@1 3071 **************************************************************************/
duke@1 3072
duke@1 3073 /**
duke@1 3074 * Return the opcode of the operator but emit an error if it is an
duke@1 3075 * error.
duke@1 3076 * @param pos position for error reporting.
duke@1 3077 * @param operator an operator
duke@1 3078 * @param tag a tree tag
duke@1 3079 * @param left type of left hand side
duke@1 3080 * @param right type of right hand side
duke@1 3081 */
duke@1 3082 int checkOperator(DiagnosticPosition pos,
duke@1 3083 OperatorSymbol operator,
jjg@1127 3084 JCTree.Tag tag,
duke@1 3085 Type left,
duke@1 3086 Type right) {
duke@1 3087 if (operator.opcode == ByteCodes.error) {
duke@1 3088 log.error(pos,
mcimadamore@853 3089 "operator.cant.be.applied.1",
duke@1 3090 treeinfo.operatorName(tag),
mcimadamore@853 3091 left, right);
duke@1 3092 }
duke@1 3093 return operator.opcode;
duke@1 3094 }
duke@1 3095
duke@1 3096
duke@1 3097 /**
duke@1 3098 * Check for division by integer constant zero
duke@1 3099 * @param pos Position for error reporting.
duke@1 3100 * @param operator The operator for the expression
duke@1 3101 * @param operand The right hand operand for the expression
duke@1 3102 */
duke@1 3103 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3104 if (operand.constValue() != null
mcimadamore@795 3105 && lint.isEnabled(LintCategory.DIVZERO)
jjg@1374 3106 && (operand.getTag().isSubRangeOf(LONG))
duke@1 3107 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3108 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3109 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3110 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3111 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3112 }
duke@1 3113 }
duke@1 3114 }
duke@1 3115
duke@1 3116 /**
duke@1 3117 * Check for empty statements after if
duke@1 3118 */
duke@1 3119 void checkEmptyIf(JCIf tree) {
jjg@1127 3120 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3121 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3122 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3123 }
duke@1 3124
duke@1 3125 /** Check that symbol is unique in given scope.
duke@1 3126 * @param pos Position for error reporting.
duke@1 3127 * @param sym The symbol.
duke@1 3128 * @param s The scope.
duke@1 3129 */
duke@1 3130 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3131 if (sym.type.isErroneous())
duke@1 3132 return true;
duke@1 3133 if (sym.owner.name == names.any) return false;
duke@1 3134 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3135 if (sym != e.sym &&
mcimadamore@858 3136 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3137 sym.kind == e.sym.kind &&
mcimadamore@858 3138 sym.name != names.error &&
mcimadamore@858 3139 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3140 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3141 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3142 return true;
mcimadamore@907 3143 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3144 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3145 sym.flags_field |= CLASH;
mcimadamore@844 3146 return true;
mcimadamore@844 3147 } else {
duke@1 3148 duplicateError(pos, e.sym);
mcimadamore@844 3149 return false;
mcimadamore@844 3150 }
duke@1 3151 }
duke@1 3152 }
duke@1 3153 return true;
duke@1 3154 }
mcimadamore@844 3155
mcimadamore@858 3156 /** Report duplicate declaration error.
mcimadamore@858 3157 */
mcimadamore@858 3158 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3159 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3160 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3161 }
mcimadamore@858 3162 }
duke@1 3163
duke@1 3164 /** Check that single-type import is not already imported or top-level defined,
duke@1 3165 * but make an exception for two single-type imports which denote the same type.
duke@1 3166 * @param pos Position for error reporting.
duke@1 3167 * @param sym The symbol.
duke@1 3168 * @param s The scope
duke@1 3169 */
duke@1 3170 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3171 return checkUniqueImport(pos, sym, s, false);
duke@1 3172 }
duke@1 3173
duke@1 3174 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3175 * but make an exception for two single-type imports which denote the same type.
duke@1 3176 * @param pos Position for error reporting.
duke@1 3177 * @param sym The symbol.
duke@1 3178 * @param s The scope
duke@1 3179 */
duke@1 3180 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3181 return checkUniqueImport(pos, sym, s, true);
duke@1 3182 }
duke@1 3183
duke@1 3184 /** Check that single-type import is not already imported or top-level defined,
duke@1 3185 * but make an exception for two single-type imports which denote the same type.
duke@1 3186 * @param pos Position for error reporting.
duke@1 3187 * @param sym The symbol.
duke@1 3188 * @param s The scope.
duke@1 3189 * @param staticImport Whether or not this was a static import
duke@1 3190 */
duke@1 3191 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3192 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3193 // is encountered class entered via a class declaration?
duke@1 3194 boolean isClassDecl = e.scope == s;
duke@1 3195 if ((isClassDecl || sym != e.sym) &&
duke@1 3196 sym.kind == e.sym.kind &&
duke@1 3197 sym.name != names.error) {
duke@1 3198 if (!e.sym.type.isErroneous()) {
duke@1 3199 String what = e.sym.toString();
duke@1 3200 if (!isClassDecl) {
duke@1 3201 if (staticImport)
duke@1 3202 log.error(pos, "already.defined.static.single.import", what);
duke@1 3203 else
duke@1 3204 log.error(pos, "already.defined.single.import", what);
duke@1 3205 }
duke@1 3206 else if (sym != e.sym)
duke@1 3207 log.error(pos, "already.defined.this.unit", what);
duke@1 3208 }
duke@1 3209 return false;
duke@1 3210 }
duke@1 3211 }
duke@1 3212 return true;
duke@1 3213 }
duke@1 3214
duke@1 3215 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3216 */
duke@1 3217 public void checkCanonical(JCTree tree) {
duke@1 3218 if (!isCanonical(tree))
duke@1 3219 log.error(tree.pos(), "import.requires.canonical",
duke@1 3220 TreeInfo.symbol(tree));
duke@1 3221 }
duke@1 3222 // where
duke@1 3223 private boolean isCanonical(JCTree tree) {
jjg@1127 3224 while (tree.hasTag(SELECT)) {
duke@1 3225 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3226 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3227 return false;
duke@1 3228 tree = s.selected;
duke@1 3229 }
duke@1 3230 return true;
duke@1 3231 }
duke@1 3232
duke@1 3233 private class ConversionWarner extends Warner {
mcimadamore@795 3234 final String uncheckedKey;
duke@1 3235 final Type found;
duke@1 3236 final Type expected;
mcimadamore@795 3237 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3238 super(pos);
mcimadamore@795 3239 this.uncheckedKey = uncheckedKey;
duke@1 3240 this.found = found;
duke@1 3241 this.expected = expected;
duke@1 3242 }
duke@1 3243
jjg@398 3244 @Override
mcimadamore@795 3245 public void warn(LintCategory lint) {
duke@1 3246 boolean warned = this.warned;
mcimadamore@795 3247 super.warn(lint);
duke@1 3248 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3249 switch (lint) {
mcimadamore@795 3250 case UNCHECKED:
mcimadamore@795 3251 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3252 break;
mcimadamore@795 3253 case VARARGS:
mcimadamore@795 3254 if (method != null &&
mcimadamore@795 3255 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3256 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3257 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3258 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3259 }
mcimadamore@795 3260 break;
mcimadamore@795 3261 default:
mcimadamore@795 3262 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3263 }
duke@1 3264 }
duke@1 3265 }
duke@1 3266
duke@1 3267 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3268 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3269 }
duke@1 3270
duke@1 3271 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3272 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3273 }
duke@1 3274 }

mercurial