src/share/classes/com/sun/tools/javac/comp/Check.java

Mon, 26 Mar 2012 15:27:51 +0100

author
mcimadamore
date
Mon, 26 Mar 2012 15:27:51 +0100
changeset 1237
568e70bbd9aa
parent 1226
97bec6ab1227
child 1238
e28a06a3c5d9
permissions
-rw-r--r--

7151580: Separate DA/DU logic from exception checking logic in Flow.java
Summary: DA/DU analysis and exception checking analysis should live in two separate tree visitors
Reviewed-by: gafter, dlsmith, jjg

duke@1 1 /*
mcimadamore@1198 2 * Copyright (c) 1999, 2012, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
duke@1 30
duke@1 31 import com.sun.tools.javac.code.*;
duke@1 32 import com.sun.tools.javac.jvm.*;
duke@1 33 import com.sun.tools.javac.tree.*;
duke@1 34 import com.sun.tools.javac.util.*;
duke@1 35 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 36 import com.sun.tools.javac.util.List;
duke@1 37
duke@1 38 import com.sun.tools.javac.tree.JCTree.*;
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
duke@1 43
duke@1 44 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 45 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 46 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 47 import static com.sun.tools.javac.code.Kinds.*;
duke@1 48 import static com.sun.tools.javac.code.TypeTags.*;
jjg@1127 49 import static com.sun.tools.javac.code.TypeTags.WILDCARD;
duke@1 50
jjg@1127 51 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 52
duke@1 53 /** Type checking helper class for the attribution phase.
duke@1 54 *
jjg@581 55 * <p><b>This is NOT part of any supported API.
jjg@581 56 * If you write code that depends on this, you do so at your own risk.
duke@1 57 * This code and its internal interfaces are subject to change or
duke@1 58 * deletion without notice.</b>
duke@1 59 */
duke@1 60 public class Check {
duke@1 61 protected static final Context.Key<Check> checkKey =
duke@1 62 new Context.Key<Check>();
duke@1 63
jjg@113 64 private final Names names;
duke@1 65 private final Log log;
mcimadamore@1219 66 private final Resolve rs;
duke@1 67 private final Symtab syms;
mcimadamore@690 68 private final Enter enter;
duke@1 69 private final Infer infer;
duke@1 70 private final Types types;
mcimadamore@89 71 private final JCDiagnostic.Factory diags;
duke@1 72 private final boolean skipAnnotations;
mcimadamore@359 73 private boolean warnOnSyntheticConflicts;
jjg@576 74 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 75 private boolean enableSunApiLintControl;
duke@1 76 private final TreeInfo treeinfo;
duke@1 77
duke@1 78 // The set of lint options currently in effect. It is initialized
duke@1 79 // from the context, and then is set/reset as needed by Attr as it
duke@1 80 // visits all the various parts of the trees during attribution.
duke@1 81 private Lint lint;
duke@1 82
mcimadamore@795 83 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 84 // Attr as it visits new method declarations.
mcimadamore@795 85 private MethodSymbol method;
mcimadamore@795 86
duke@1 87 public static Check instance(Context context) {
duke@1 88 Check instance = context.get(checkKey);
duke@1 89 if (instance == null)
duke@1 90 instance = new Check(context);
duke@1 91 return instance;
duke@1 92 }
duke@1 93
duke@1 94 protected Check(Context context) {
duke@1 95 context.put(checkKey, this);
duke@1 96
jjg@113 97 names = Names.instance(context);
duke@1 98 log = Log.instance(context);
mcimadamore@1219 99 rs = Resolve.instance(context);
duke@1 100 syms = Symtab.instance(context);
mcimadamore@690 101 enter = Enter.instance(context);
duke@1 102 infer = Infer.instance(context);
duke@1 103 this.types = Types.instance(context);
mcimadamore@89 104 diags = JCDiagnostic.Factory.instance(context);
duke@1 105 Options options = Options.instance(context);
duke@1 106 lint = Lint.instance(context);
duke@1 107 treeinfo = TreeInfo.instance(context);
duke@1 108
duke@1 109 Source source = Source.instance(context);
duke@1 110 allowGenerics = source.allowGenerics();
mcimadamore@1219 111 allowVarargs = source.allowVarargs();
duke@1 112 allowAnnotations = source.allowAnnotations();
jjg@398 113 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 114 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
jjg@1157 115 complexInference = options.isSet("complexinference");
jjg@700 116 skipAnnotations = options.isSet("skipAnnotations");
jjg@700 117 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 118 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 119 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 120
jjg@398 121 Target target = Target.instance(context);
jjg@398 122 syntheticNameChar = target.syntheticNameChar();
jjg@398 123
duke@1 124 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 125 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 126 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 127 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 128
jjg@60 129 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 130 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 131 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 132 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 133 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 134 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 135
mcimadamore@852 136 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 137 }
duke@1 138
duke@1 139 /** Switch: generics enabled?
duke@1 140 */
duke@1 141 boolean allowGenerics;
duke@1 142
mcimadamore@1219 143 /** Switch: varargs enabled?
mcimadamore@1219 144 */
mcimadamore@1219 145 boolean allowVarargs;
mcimadamore@1219 146
duke@1 147 /** Switch: annotations enabled?
duke@1 148 */
duke@1 149 boolean allowAnnotations;
duke@1 150
jjg@398 151 /** Switch: covariant returns enabled?
jjg@398 152 */
jjg@398 153 boolean allowCovariantReturns;
jjg@398 154
mcimadamore@795 155 /** Switch: simplified varargs enabled?
mcimadamore@795 156 */
mcimadamore@795 157 boolean allowSimplifiedVarargs;
mcimadamore@795 158
duke@1 159 /** Switch: -complexinference option set?
duke@1 160 */
duke@1 161 boolean complexInference;
duke@1 162
jjg@398 163 /** Character for synthetic names
jjg@398 164 */
jjg@398 165 char syntheticNameChar;
jjg@398 166
duke@1 167 /** A table mapping flat names of all compiled classes in this run to their
duke@1 168 * symbols; maintained from outside.
duke@1 169 */
duke@1 170 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 171
duke@1 172 /** A handler for messages about deprecated usage.
duke@1 173 */
duke@1 174 private MandatoryWarningHandler deprecationHandler;
duke@1 175
duke@1 176 /** A handler for messages about unchecked or unsafe usage.
duke@1 177 */
duke@1 178 private MandatoryWarningHandler uncheckedHandler;
duke@1 179
jjg@582 180 /** A handler for messages about using proprietary API.
jjg@377 181 */
jjg@377 182 private MandatoryWarningHandler sunApiHandler;
duke@1 183
mcimadamore@852 184 /** A handler for deferred lint warnings.
mcimadamore@852 185 */
mcimadamore@852 186 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 187
duke@1 188 /* *************************************************************************
duke@1 189 * Errors and Warnings
duke@1 190 **************************************************************************/
duke@1 191
duke@1 192 Lint setLint(Lint newLint) {
duke@1 193 Lint prev = lint;
duke@1 194 lint = newLint;
duke@1 195 return prev;
duke@1 196 }
duke@1 197
mcimadamore@852 198 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 199 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 200 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 201 return prev;
mcimadamore@852 202 }
mcimadamore@852 203
mcimadamore@795 204 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 205 MethodSymbol prev = method;
mcimadamore@795 206 method = newMethod;
mcimadamore@795 207 return prev;
mcimadamore@795 208 }
mcimadamore@795 209
duke@1 210 /** Warn about deprecated symbol.
duke@1 211 * @param pos Position to be used for error reporting.
duke@1 212 * @param sym The deprecated symbol.
duke@1 213 */
duke@1 214 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 215 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 216 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 217 }
duke@1 218
duke@1 219 /** Warn about unchecked operation.
duke@1 220 * @param pos Position to be used for error reporting.
duke@1 221 * @param msg A string describing the problem.
duke@1 222 */
duke@1 223 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 224 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 225 uncheckedHandler.report(pos, msg, args);
duke@1 226 }
duke@1 227
mcimadamore@580 228 /** Warn about unsafe vararg method decl.
mcimadamore@580 229 * @param pos Position to be used for error reporting.
mcimadamore@580 230 * @param sym The deprecated symbol.
mcimadamore@580 231 */
mcimadamore@795 232 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 233 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 234 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 235 }
mcimadamore@580 236
jjg@582 237 /** Warn about using proprietary API.
jjg@377 238 * @param pos Position to be used for error reporting.
jjg@377 239 * @param msg A string describing the problem.
jjg@377 240 */
jjg@377 241 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 242 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 243 sunApiHandler.report(pos, msg, args);
jjg@377 244 }
jjg@377 245
jjg@505 246 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 247 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 248 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 249 }
jjg@505 250
duke@1 251 /**
duke@1 252 * Report any deferred diagnostics.
duke@1 253 */
duke@1 254 public void reportDeferredDiagnostics() {
duke@1 255 deprecationHandler.reportDeferredDiagnostic();
duke@1 256 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 257 sunApiHandler.reportDeferredDiagnostic();
duke@1 258 }
duke@1 259
duke@1 260
duke@1 261 /** Report a failure to complete a class.
duke@1 262 * @param pos Position to be used for error reporting.
duke@1 263 * @param ex The failure to report.
duke@1 264 */
duke@1 265 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 266 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 267 if (ex instanceof ClassReader.BadClassFile
jjg@576 268 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 269 else return syms.errType;
duke@1 270 }
duke@1 271
duke@1 272 /** Report a type error.
duke@1 273 * @param pos Position to be used for error reporting.
duke@1 274 * @param problem A string describing the error.
duke@1 275 * @param found The type that was found.
duke@1 276 * @param req The type that was required.
duke@1 277 */
duke@1 278 Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
duke@1 279 log.error(pos, "prob.found.req",
duke@1 280 problem, found, req);
jjg@110 281 return types.createErrorType(found);
duke@1 282 }
duke@1 283
duke@1 284 Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
duke@1 285 log.error(pos, "prob.found.req.1", problem, found, req, explanation);
jjg@110 286 return types.createErrorType(found);
duke@1 287 }
duke@1 288
duke@1 289 /** Report an error that wrong type tag was found.
duke@1 290 * @param pos Position to be used for error reporting.
duke@1 291 * @param required An internationalized string describing the type tag
duke@1 292 * required.
duke@1 293 * @param found The type that was found.
duke@1 294 */
duke@1 295 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 296 // this error used to be raised by the parser,
jrose@267 297 // but has been delayed to this point:
jrose@267 298 if (found instanceof Type && ((Type)found).tag == VOID) {
jrose@267 299 log.error(pos, "illegal.start.of.type");
jrose@267 300 return syms.errType;
jrose@267 301 }
duke@1 302 log.error(pos, "type.found.req", found, required);
jjg@110 303 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 304 }
duke@1 305
duke@1 306 /** Report an error that symbol cannot be referenced before super
duke@1 307 * has been called.
duke@1 308 * @param pos Position to be used for error reporting.
duke@1 309 * @param sym The referenced symbol.
duke@1 310 */
duke@1 311 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 312 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 313 }
duke@1 314
duke@1 315 /** Report duplicate declaration error.
duke@1 316 */
duke@1 317 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 318 if (!sym.type.isErroneous()) {
mcimadamore@1085 319 Symbol location = sym.location();
mcimadamore@1085 320 if (location.kind == MTH &&
mcimadamore@1085 321 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 322 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 323 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 324 sym.location().enclClass());
mcimadamore@1085 325 } else {
mcimadamore@1085 326 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 327 kindName(sym.location()), sym.location());
mcimadamore@1085 328 }
duke@1 329 }
duke@1 330 }
duke@1 331
duke@1 332 /** Report array/varargs duplicate declaration
duke@1 333 */
duke@1 334 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 335 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 336 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 337 }
duke@1 338 }
duke@1 339
duke@1 340 /* ************************************************************************
duke@1 341 * duplicate declaration checking
duke@1 342 *************************************************************************/
duke@1 343
duke@1 344 /** Check that variable does not hide variable with same name in
duke@1 345 * immediately enclosing local scope.
duke@1 346 * @param pos Position for error reporting.
duke@1 347 * @param v The symbol.
duke@1 348 * @param s The scope.
duke@1 349 */
duke@1 350 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 351 if (s.next != null) {
duke@1 352 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 353 e.scope != null && e.sym.owner == v.owner;
duke@1 354 e = e.next()) {
duke@1 355 if (e.sym.kind == VAR &&
duke@1 356 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 357 v.name != names.error) {
duke@1 358 duplicateError(pos, e.sym);
duke@1 359 return;
duke@1 360 }
duke@1 361 }
duke@1 362 }
duke@1 363 }
duke@1 364
duke@1 365 /** Check that a class or interface does not hide a class or
duke@1 366 * interface with same name in immediately enclosing local scope.
duke@1 367 * @param pos Position for error reporting.
duke@1 368 * @param c The symbol.
duke@1 369 * @param s The scope.
duke@1 370 */
duke@1 371 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 372 if (s.next != null) {
duke@1 373 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 374 e.scope != null && e.sym.owner == c.owner;
duke@1 375 e = e.next()) {
mcimadamore@639 376 if (e.sym.kind == TYP && e.sym.type.tag != TYPEVAR &&
duke@1 377 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 378 c.name != names.error) {
duke@1 379 duplicateError(pos, e.sym);
duke@1 380 return;
duke@1 381 }
duke@1 382 }
duke@1 383 }
duke@1 384 }
duke@1 385
duke@1 386 /** Check that class does not have the same name as one of
duke@1 387 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 388 * return true if class is unique in its enclosing scope.
duke@1 389 * @param pos Position for error reporting.
duke@1 390 * @param name The class name.
duke@1 391 * @param s The enclosing scope.
duke@1 392 */
duke@1 393 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 394 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 395 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 396 duplicateError(pos, e.sym);
duke@1 397 return false;
duke@1 398 }
duke@1 399 }
duke@1 400 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 401 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 402 duplicateError(pos, sym);
duke@1 403 return true;
duke@1 404 }
duke@1 405 }
duke@1 406 return true;
duke@1 407 }
duke@1 408
duke@1 409 /* *************************************************************************
duke@1 410 * Class name generation
duke@1 411 **************************************************************************/
duke@1 412
duke@1 413 /** Return name of local class.
duke@1 414 * This is of the form <enclClass> $ n <classname>
duke@1 415 * where
duke@1 416 * enclClass is the flat name of the enclosing class,
duke@1 417 * classname is the simple name of the local class
duke@1 418 */
duke@1 419 Name localClassName(ClassSymbol c) {
duke@1 420 for (int i=1; ; i++) {
duke@1 421 Name flatname = names.
duke@1 422 fromString("" + c.owner.enclClass().flatname +
jjg@398 423 syntheticNameChar + i +
duke@1 424 c.name);
duke@1 425 if (compiled.get(flatname) == null) return flatname;
duke@1 426 }
duke@1 427 }
duke@1 428
duke@1 429 /* *************************************************************************
duke@1 430 * Type Checking
duke@1 431 **************************************************************************/
duke@1 432
duke@1 433 /** Check that a given type is assignable to a given proto-type.
duke@1 434 * If it is, return the type, otherwise return errType.
duke@1 435 * @param pos Position to be used for error reporting.
duke@1 436 * @param found The type that was found.
duke@1 437 * @param req The type that was required.
duke@1 438 */
duke@1 439 Type checkType(DiagnosticPosition pos, Type found, Type req) {
darcy@609 440 return checkType(pos, found, req, "incompatible.types");
darcy@609 441 }
darcy@609 442
darcy@609 443 Type checkType(DiagnosticPosition pos, Type found, Type req, String errKey) {
duke@1 444 if (req.tag == ERROR)
duke@1 445 return req;
mcimadamore@536 446 if (found.tag == FORALL)
mcimadamore@536 447 return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req));
duke@1 448 if (req.tag == NONE)
duke@1 449 return found;
duke@1 450 if (types.isAssignable(found, req, convertWarner(pos, found, req)))
duke@1 451 return found;
duke@1 452 if (found.tag <= DOUBLE && req.tag <= DOUBLE)
mcimadamore@89 453 return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req);
duke@1 454 if (found.isSuperBound()) {
duke@1 455 log.error(pos, "assignment.from.super-bound", found);
jjg@110 456 return types.createErrorType(found);
duke@1 457 }
duke@1 458 if (req.isExtendsBound()) {
duke@1 459 log.error(pos, "assignment.to.extends-bound", req);
jjg@110 460 return types.createErrorType(found);
duke@1 461 }
darcy@609 462 return typeError(pos, diags.fragment(errKey), found, req);
duke@1 463 }
duke@1 464
duke@1 465 /** Instantiate polymorphic type to some prototype, unless
duke@1 466 * prototype is `anyPoly' in which case polymorphic type
duke@1 467 * is returned unchanged.
duke@1 468 */
mcimadamore@383 469 Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException {
duke@1 470 if (pt == Infer.anyPoly && complexInference) {
duke@1 471 return t;
duke@1 472 } else if (pt == Infer.anyPoly || pt.tag == NONE) {
duke@1 473 Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
duke@1 474 return instantiatePoly(pos, t, newpt, warn);
duke@1 475 } else if (pt.tag == ERROR) {
duke@1 476 return pt;
duke@1 477 } else {
mcimadamore@536 478 try {
mcimadamore@536 479 return infer.instantiateExpr(t, pt, warn);
mcimadamore@536 480 } catch (Infer.NoInstanceException ex) {
mcimadamore@536 481 if (ex.isAmbiguous) {
mcimadamore@536 482 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 483 log.error(pos,
mcimadamore@536 484 "undetermined.type" + (d!=null ? ".1" : ""),
mcimadamore@536 485 t, d);
mcimadamore@536 486 return types.createErrorType(pt);
mcimadamore@536 487 } else {
mcimadamore@536 488 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 489 return typeError(pos,
mcimadamore@536 490 diags.fragment("incompatible.types" + (d!=null ? ".1" : ""), d),
mcimadamore@536 491 t, pt);
mcimadamore@536 492 }
mcimadamore@536 493 } catch (Infer.InvalidInstanceException ex) {
mcimadamore@536 494 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 495 log.error(pos, "invalid.inferred.types", t.tvars, d);
mcimadamore@536 496 return types.createErrorType(pt);
mcimadamore@536 497 }
duke@1 498 }
mcimadamore@536 499 }
duke@1 500
duke@1 501 /** Check that a given type can be cast to a given target type.
duke@1 502 * Return the result of the cast.
duke@1 503 * @param pos Position to be used for error reporting.
duke@1 504 * @param found The type that is being cast.
duke@1 505 * @param req The target type of the cast.
duke@1 506 */
duke@1 507 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
duke@1 508 if (found.tag == FORALL) {
duke@1 509 instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
duke@1 510 return req;
duke@1 511 } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 512 return req;
duke@1 513 } else {
duke@1 514 return typeError(pos,
mcimadamore@89 515 diags.fragment("inconvertible.types"),
duke@1 516 found, req);
duke@1 517 }
duke@1 518 }
mcimadamore@1237 519
mcimadamore@1237 520 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 521 * The problem should only be reported for non-292 cast
mcimadamore@1237 522 */
mcimadamore@1237 523 public void checkRedundantCast(Env<AttrContext> env, JCTypeCast tree) {
mcimadamore@1237 524 if (!tree.type.isErroneous() &&
mcimadamore@1237 525 (env.info.lint == null || env.info.lint.isEnabled(Lint.LintCategory.CAST))
mcimadamore@1237 526 && types.isSameType(tree.expr.type, tree.clazz.type)
mcimadamore@1237 527 && !is292targetTypeCast(tree)) {
mcimadamore@1237 528 log.warning(Lint.LintCategory.CAST,
mcimadamore@1237 529 tree.pos(), "redundant.cast", tree.expr.type);
mcimadamore@1237 530 }
mcimadamore@1237 531 }
mcimadamore@1237 532 //where
mcimadamore@1237 533 private boolean is292targetTypeCast(JCTypeCast tree) {
mcimadamore@1237 534 boolean is292targetTypeCast = false;
mcimadamore@1237 535 JCExpression expr = TreeInfo.skipParens(tree.expr);
mcimadamore@1237 536 if (expr.hasTag(APPLY)) {
mcimadamore@1237 537 JCMethodInvocation apply = (JCMethodInvocation)expr;
mcimadamore@1237 538 Symbol sym = TreeInfo.symbol(apply.meth);
mcimadamore@1237 539 is292targetTypeCast = sym != null &&
mcimadamore@1237 540 sym.kind == MTH &&
mcimadamore@1237 541 (sym.flags() & POLYMORPHIC_SIGNATURE) != 0;
mcimadamore@1237 542 }
mcimadamore@1237 543 return is292targetTypeCast;
mcimadamore@1237 544 }
mcimadamore@1237 545
mcimadamore@1237 546
mcimadamore@1237 547
duke@1 548 //where
duke@1 549 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 550 * type variables?
duke@1 551 */
duke@1 552 boolean isTypeVar(Type t) {
duke@1 553 return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
duke@1 554 }
duke@1 555
duke@1 556 /** Check that a type is within some bounds.
duke@1 557 *
duke@1 558 * Used in TypeApply to verify that, e.g., X in V<X> is a valid
duke@1 559 * type argument.
duke@1 560 * @param pos Position to be used for error reporting.
duke@1 561 * @param a The type that should be bounded by bs.
duke@1 562 * @param bs The bound.
duke@1 563 */
mcimadamore@1216 564 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 565 if (a.isUnbound()) {
mcimadamore@821 566 return true;
mcimadamore@154 567 } else if (a.tag != WILDCARD) {
mcimadamore@154 568 a = types.upperBound(a);
mcimadamore@1216 569 return types.isSubtype(a, bound);
mcimadamore@154 570 } else if (a.isExtendsBound()) {
mcimadamore@1216 571 return types.isCastable(bound, types.upperBound(a), Warner.noWarnings);
mcimadamore@154 572 } else if (a.isSuperBound()) {
mcimadamore@1216 573 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 574 }
mcimadamore@821 575 return true;
mcimadamore@154 576 }
duke@1 577
duke@1 578 /** Check that type is different from 'void'.
duke@1 579 * @param pos Position to be used for error reporting.
duke@1 580 * @param t The type to be checked.
duke@1 581 */
duke@1 582 Type checkNonVoid(DiagnosticPosition pos, Type t) {
duke@1 583 if (t.tag == VOID) {
duke@1 584 log.error(pos, "void.not.allowed.here");
jjg@110 585 return types.createErrorType(t);
duke@1 586 } else {
duke@1 587 return t;
duke@1 588 }
duke@1 589 }
duke@1 590
duke@1 591 /** Check that type is a class or interface type.
duke@1 592 * @param pos Position to be used for error reporting.
duke@1 593 * @param t The type to be checked.
duke@1 594 */
duke@1 595 Type checkClassType(DiagnosticPosition pos, Type t) {
duke@1 596 if (t.tag != CLASS && t.tag != ERROR)
duke@1 597 return typeTagError(pos,
mcimadamore@89 598 diags.fragment("type.req.class"),
duke@1 599 (t.tag == TYPEVAR)
mcimadamore@89 600 ? diags.fragment("type.parameter", t)
duke@1 601 : t);
duke@1 602 else
duke@1 603 return t;
duke@1 604 }
duke@1 605
duke@1 606 /** Check that type is a class or interface type.
duke@1 607 * @param pos Position to be used for error reporting.
duke@1 608 * @param t The type to be checked.
duke@1 609 * @param noBounds True if type bounds are illegal here.
duke@1 610 */
duke@1 611 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 612 t = checkClassType(pos, t);
duke@1 613 if (noBounds && t.isParameterized()) {
duke@1 614 List<Type> args = t.getTypeArguments();
duke@1 615 while (args.nonEmpty()) {
duke@1 616 if (args.head.tag == WILDCARD)
duke@1 617 return typeTagError(pos,
jjg@598 618 diags.fragment("type.req.exact"),
duke@1 619 args.head);
duke@1 620 args = args.tail;
duke@1 621 }
duke@1 622 }
duke@1 623 return t;
duke@1 624 }
duke@1 625
duke@1 626 /** Check that type is a reifiable class, interface or array type.
duke@1 627 * @param pos Position to be used for error reporting.
duke@1 628 * @param t The type to be checked.
duke@1 629 */
duke@1 630 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
duke@1 631 if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
duke@1 632 return typeTagError(pos,
mcimadamore@89 633 diags.fragment("type.req.class.array"),
duke@1 634 t);
duke@1 635 } else if (!types.isReifiable(t)) {
duke@1 636 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 637 return types.createErrorType(t);
duke@1 638 } else {
duke@1 639 return t;
duke@1 640 }
duke@1 641 }
duke@1 642
duke@1 643 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 644 * or a type variable.
duke@1 645 * @param pos Position to be used for error reporting.
duke@1 646 * @param t The type to be checked.
duke@1 647 */
duke@1 648 Type checkRefType(DiagnosticPosition pos, Type t) {
duke@1 649 switch (t.tag) {
duke@1 650 case CLASS:
duke@1 651 case ARRAY:
duke@1 652 case TYPEVAR:
duke@1 653 case WILDCARD:
duke@1 654 case ERROR:
duke@1 655 return t;
duke@1 656 default:
duke@1 657 return typeTagError(pos,
mcimadamore@89 658 diags.fragment("type.req.ref"),
duke@1 659 t);
duke@1 660 }
duke@1 661 }
duke@1 662
jrose@267 663 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 664 * or a type variable.
jrose@267 665 * @param trees Original trees, used for error reporting.
jrose@267 666 * @param types The types to be checked.
jrose@267 667 */
jrose@267 668 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 669 List<JCExpression> tl = trees;
jrose@267 670 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 671 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 672 tl = tl.tail;
jrose@267 673 }
jrose@267 674 return types;
jrose@267 675 }
jrose@267 676
duke@1 677 /** Check that type is a null or reference type.
duke@1 678 * @param pos Position to be used for error reporting.
duke@1 679 * @param t The type to be checked.
duke@1 680 */
duke@1 681 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
duke@1 682 switch (t.tag) {
duke@1 683 case CLASS:
duke@1 684 case ARRAY:
duke@1 685 case TYPEVAR:
duke@1 686 case WILDCARD:
duke@1 687 case BOT:
duke@1 688 case ERROR:
duke@1 689 return t;
duke@1 690 default:
duke@1 691 return typeTagError(pos,
mcimadamore@89 692 diags.fragment("type.req.ref"),
duke@1 693 t);
duke@1 694 }
duke@1 695 }
duke@1 696
duke@1 697 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 698 * Return true if it doesn't.
duke@1 699 * @param pos Position to be used for error reporting.
duke@1 700 * @param flags The set of flags to be checked.
duke@1 701 * @param set1 Conflicting flags set #1.
duke@1 702 * @param set2 Conflicting flags set #2.
duke@1 703 */
duke@1 704 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 705 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 706 log.error(pos,
duke@1 707 "illegal.combination.of.modifiers",
mcimadamore@80 708 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 709 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 710 return false;
duke@1 711 } else
duke@1 712 return true;
duke@1 713 }
duke@1 714
mcimadamore@914 715 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 716 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 717 */
mcimadamore@914 718 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 719 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 720 t.isErroneous()) {
mcimadamore@914 721 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 722 } else if (tree.def != null) {
mcimadamore@914 723 log.error(tree.clazz.pos(),
mcimadamore@914 724 "cant.apply.diamond.1",
mcimadamore@914 725 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 726 return types.createErrorType(t);
mcimadamore@948 727 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 728 log.error(tree.clazz.pos(),
mcimadamore@914 729 "cant.apply.diamond.1",
mcimadamore@914 730 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 731 return types.createErrorType(t);
mcimadamore@993 732 } else if (tree.typeargs != null &&
mcimadamore@993 733 tree.typeargs.nonEmpty()) {
mcimadamore@993 734 log.error(tree.clazz.pos(),
mcimadamore@993 735 "cant.apply.diamond.1",
mcimadamore@993 736 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 737 return types.createErrorType(t);
mcimadamore@914 738 } else {
mcimadamore@914 739 return t;
mcimadamore@537 740 }
mcimadamore@537 741 }
mcimadamore@537 742
mcimadamore@795 743 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 744 MethodSymbol m = tree.sym;
mcimadamore@795 745 if (!allowSimplifiedVarargs) return;
mcimadamore@795 746 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 747 Type varargElemType = null;
mcimadamore@580 748 if (m.isVarArgs()) {
mcimadamore@795 749 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 750 }
mcimadamore@795 751 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 752 if (varargElemType != null) {
mcimadamore@795 753 log.error(tree,
mcimadamore@795 754 "varargs.invalid.trustme.anno",
mcimadamore@795 755 syms.trustMeType.tsym,
mcimadamore@795 756 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 757 } else {
mcimadamore@795 758 log.error(tree,
mcimadamore@795 759 "varargs.invalid.trustme.anno",
mcimadamore@795 760 syms.trustMeType.tsym,
mcimadamore@795 761 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 762 }
mcimadamore@795 763 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 764 types.isReifiable(varargElemType)) {
mcimadamore@795 765 warnUnsafeVararg(tree,
mcimadamore@795 766 "varargs.redundant.trustme.anno",
mcimadamore@795 767 syms.trustMeType.tsym,
mcimadamore@795 768 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 769 }
mcimadamore@795 770 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 771 !types.isReifiable(varargElemType)) {
mcimadamore@795 772 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 773 }
mcimadamore@580 774 }
mcimadamore@795 775 //where
mcimadamore@795 776 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 777 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 778 (s.isConstructor() ||
mcimadamore@795 779 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 780 }
mcimadamore@580 781
mcimadamore@1219 782 Type checkMethod(Type owntype,
mcimadamore@1219 783 Symbol sym,
mcimadamore@1219 784 Env<AttrContext> env,
mcimadamore@1219 785 final List<JCExpression> argtrees,
mcimadamore@1219 786 List<Type> argtypes,
mcimadamore@1226 787 boolean useVarargs,
mcimadamore@1226 788 boolean unchecked) {
mcimadamore@1219 789 // System.out.println("call : " + env.tree);
mcimadamore@1219 790 // System.out.println("method : " + owntype);
mcimadamore@1219 791 // System.out.println("actuals: " + argtypes);
mcimadamore@1219 792 List<Type> formals = owntype.getParameterTypes();
mcimadamore@1219 793 Type last = useVarargs ? formals.last() : null;
mcimadamore@1219 794 if (sym.name==names.init &&
mcimadamore@1219 795 sym.owner == syms.enumSym)
mcimadamore@1219 796 formals = formals.tail.tail;
mcimadamore@1219 797 List<JCExpression> args = argtrees;
mcimadamore@1219 798 while (formals.head != last) {
mcimadamore@1219 799 JCTree arg = args.head;
mcimadamore@1219 800 Warner warn = convertWarner(arg.pos(), arg.type, formals.head);
mcimadamore@1219 801 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 802 args = args.tail;
mcimadamore@1219 803 formals = formals.tail;
mcimadamore@580 804 }
mcimadamore@1219 805 if (useVarargs) {
mcimadamore@1219 806 Type varArg = types.elemtype(last);
mcimadamore@1219 807 while (args.tail != null) {
mcimadamore@1219 808 JCTree arg = args.head;
mcimadamore@1219 809 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1219 810 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1219 811 args = args.tail;
mcimadamore@1219 812 }
mcimadamore@1219 813 } else if ((sym.flags() & VARARGS) != 0 && allowVarargs) {
mcimadamore@1219 814 // non-varargs call to varargs method
mcimadamore@1219 815 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1219 816 Type lastArg = argtypes.last();
mcimadamore@1219 817 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
mcimadamore@1219 818 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1219 819 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
mcimadamore@1219 820 types.elemtype(varParam), varParam);
mcimadamore@1219 821 }
mcimadamore@1226 822 if (unchecked) {
mcimadamore@1219 823 warnUnchecked(env.tree.pos(),
mcimadamore@1219 824 "unchecked.meth.invocation.applied",
mcimadamore@1219 825 kindName(sym),
mcimadamore@1219 826 sym.name,
mcimadamore@1219 827 rs.methodArguments(sym.type.getParameterTypes()),
mcimadamore@1219 828 rs.methodArguments(argtypes),
mcimadamore@1219 829 kindName(sym.location()),
mcimadamore@1219 830 sym.location());
mcimadamore@1219 831 owntype = new MethodType(owntype.getParameterTypes(),
mcimadamore@1219 832 types.erasure(owntype.getReturnType()),
mcimadamore@1219 833 types.erasure(owntype.getThrownTypes()),
mcimadamore@1219 834 syms.methodClass);
mcimadamore@1219 835 }
mcimadamore@1219 836 if (useVarargs) {
mcimadamore@1219 837 JCTree tree = env.tree;
mcimadamore@1219 838 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 839 if (!types.isReifiable(argtype) &&
mcimadamore@1219 840 (!allowSimplifiedVarargs ||
mcimadamore@1219 841 sym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@1219 842 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 843 warnUnchecked(env.tree.pos(),
mcimadamore@1219 844 "unchecked.generic.array.creation",
mcimadamore@1219 845 argtype);
mcimadamore@1219 846 }
mcimadamore@1219 847 Type elemtype = types.elemtype(argtype);
mcimadamore@1219 848 switch (tree.getTag()) {
mcimadamore@1219 849 case APPLY:
mcimadamore@1219 850 ((JCMethodInvocation) tree).varargsElement = elemtype;
mcimadamore@1219 851 break;
mcimadamore@1219 852 case NEWCLASS:
mcimadamore@1219 853 ((JCNewClass) tree).varargsElement = elemtype;
mcimadamore@1219 854 break;
mcimadamore@1219 855 default:
mcimadamore@1219 856 throw new AssertionError(""+tree);
mcimadamore@1219 857 }
mcimadamore@1219 858 }
mcimadamore@1219 859 return owntype;
mcimadamore@547 860 }
mcimadamore@1219 861 //where
mcimadamore@1219 862 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
mcimadamore@1219 863 if (types.isConvertible(actual, formal, warn))
mcimadamore@1219 864 return;
mcimadamore@1219 865
mcimadamore@1219 866 if (formal.isCompound()
mcimadamore@1219 867 && types.isSubtype(actual, types.supertype(formal))
mcimadamore@1219 868 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
mcimadamore@1219 869 return;
mcimadamore@1219 870
mcimadamore@1219 871 if (false) {
mcimadamore@1219 872 // TODO: make assertConvertible work
mcimadamore@1219 873 typeError(tree.pos(), diags.fragment("incompatible.types"), actual, formal);
mcimadamore@1219 874 throw new AssertionError("Tree: " + tree
mcimadamore@1219 875 + " actual:" + actual
mcimadamore@1219 876 + " formal: " + formal);
mcimadamore@1219 877 }
mcimadamore@1219 878 }
mcimadamore@547 879
mcimadamore@821 880 /**
mcimadamore@821 881 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 882 * (see JLS 4.5)
mcimadamore@821 883 *
mcimadamore@821 884 * @param t class type to be checked
mcimadamore@821 885 * @return true if 't' is well-formed
mcimadamore@821 886 */
mcimadamore@821 887 public boolean checkValidGenericType(Type t) {
mcimadamore@821 888 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 889 }
mcimadamore@821 890 //WHERE
mcimadamore@821 891 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 892 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 893 List<Type> actuals = type.allparams();
mcimadamore@821 894 List<Type> args = type.getTypeArguments();
mcimadamore@821 895 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 896 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 897
mcimadamore@821 898 // For matching pairs of actual argument types `a' and
mcimadamore@821 899 // formal type parameters with declared bound `b' ...
mcimadamore@821 900 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 901 // exact type arguments needs to know their
mcimadamore@821 902 // bounds (for upper and lower bound
mcimadamore@1216 903 // calculations). So we create new bounds where
mcimadamore@1216 904 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 905 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 906 args = args.tail;
mcimadamore@821 907 forms = forms.tail;
mcimadamore@821 908 }
mcimadamore@821 909
mcimadamore@821 910 args = type.getTypeArguments();
mcimadamore@821 911 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 912 formals,
mcimadamore@821 913 types.capture(type).allparams());
mcimadamore@821 914 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 915 // Let the actual arguments know their bound
mcimadamore@821 916 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 917 args = args.tail;
mcimadamore@821 918 tvars_cap = tvars_cap.tail;
mcimadamore@821 919 }
mcimadamore@821 920
mcimadamore@821 921 args = type.getTypeArguments();
mcimadamore@1216 922 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 923
mcimadamore@1216 924 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 925 Type actual = args.head;
mcimadamore@854 926 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 927 !bounds.head.isErroneous() &&
mcimadamore@1216 928 !checkExtends(actual, bounds.head)) {
mcimadamore@821 929 return args.head;
mcimadamore@821 930 }
mcimadamore@821 931 args = args.tail;
mcimadamore@1216 932 bounds = bounds.tail;
mcimadamore@821 933 }
mcimadamore@821 934
mcimadamore@821 935 args = type.getTypeArguments();
mcimadamore@1216 936 bounds = bounds_buf.toList();
mcimadamore@821 937
mcimadamore@821 938 for (Type arg : types.capture(type).getTypeArguments()) {
mcimadamore@828 939 if (arg.tag == TYPEVAR &&
mcimadamore@828 940 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 941 !bounds.head.isErroneous() &&
mcimadamore@854 942 !isTypeArgErroneous(args.head)) {
mcimadamore@821 943 return args.head;
mcimadamore@821 944 }
mcimadamore@1216 945 bounds = bounds.tail;
mcimadamore@854 946 args = args.tail;
mcimadamore@821 947 }
mcimadamore@821 948
mcimadamore@821 949 return null;
mcimadamore@821 950 }
mcimadamore@854 951 //where
mcimadamore@854 952 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 953 return isTypeArgErroneous.visit(t);
mcimadamore@854 954 }
mcimadamore@854 955
mcimadamore@854 956 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 957 public Boolean visitType(Type t, Void s) {
mcimadamore@854 958 return t.isErroneous();
mcimadamore@854 959 }
mcimadamore@854 960 @Override
mcimadamore@854 961 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 962 return visit(t.getUpperBound());
mcimadamore@854 963 }
mcimadamore@854 964 @Override
mcimadamore@854 965 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 966 return visit(t.getUpperBound()) ||
mcimadamore@854 967 visit(t.getLowerBound());
mcimadamore@854 968 }
mcimadamore@854 969 @Override
mcimadamore@854 970 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 971 return visit(t.type);
mcimadamore@854 972 }
mcimadamore@854 973 };
mcimadamore@821 974
duke@1 975 /** Check that given modifiers are legal for given symbol and
duke@1 976 * return modifiers together with any implicit modififiers for that symbol.
duke@1 977 * Warning: we can't use flags() here since this method
duke@1 978 * is called during class enter, when flags() would cause a premature
duke@1 979 * completion.
duke@1 980 * @param pos Position to be used for error reporting.
duke@1 981 * @param flags The set of modifiers given in a definition.
duke@1 982 * @param sym The defined symbol.
duke@1 983 */
duke@1 984 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 985 long mask;
duke@1 986 long implicit = 0;
duke@1 987 switch (sym.kind) {
duke@1 988 case VAR:
duke@1 989 if (sym.owner.kind != TYP)
duke@1 990 mask = LocalVarFlags;
duke@1 991 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 992 mask = implicit = InterfaceVarFlags;
duke@1 993 else
duke@1 994 mask = VarFlags;
duke@1 995 break;
duke@1 996 case MTH:
duke@1 997 if (sym.name == names.init) {
duke@1 998 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 999 // enum constructors cannot be declared public or
duke@1 1000 // protected and must be implicitly or explicitly
duke@1 1001 // private
duke@1 1002 implicit = PRIVATE;
duke@1 1003 mask = PRIVATE;
duke@1 1004 } else
duke@1 1005 mask = ConstructorFlags;
duke@1 1006 } else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1007 mask = implicit = InterfaceMethodFlags;
duke@1 1008 else {
duke@1 1009 mask = MethodFlags;
duke@1 1010 }
duke@1 1011 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1012 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 1013 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1014 break;
duke@1 1015 case TYP:
duke@1 1016 if (sym.isLocal()) {
duke@1 1017 mask = LocalClassFlags;
jjg@113 1018 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1019 // Anonymous classes in static methods are themselves static;
duke@1 1020 // that's why we admit STATIC here.
duke@1 1021 mask |= STATIC;
duke@1 1022 // JLS: Anonymous classes are final.
duke@1 1023 implicit |= FINAL;
duke@1 1024 }
duke@1 1025 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1026 (flags & ENUM) != 0)
duke@1 1027 log.error(pos, "enums.must.be.static");
duke@1 1028 } else if (sym.owner.kind == TYP) {
duke@1 1029 mask = MemberClassFlags;
duke@1 1030 if (sym.owner.owner.kind == PCK ||
duke@1 1031 (sym.owner.flags_field & STATIC) != 0)
duke@1 1032 mask |= STATIC;
duke@1 1033 else if ((flags & ENUM) != 0)
duke@1 1034 log.error(pos, "enums.must.be.static");
duke@1 1035 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1036 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1037 } else {
duke@1 1038 mask = ClassFlags;
duke@1 1039 }
duke@1 1040 // Interfaces are always ABSTRACT
duke@1 1041 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1042
duke@1 1043 if ((flags & ENUM) != 0) {
duke@1 1044 // enums can't be declared abstract or final
duke@1 1045 mask &= ~(ABSTRACT | FINAL);
duke@1 1046 implicit |= implicitEnumFinalFlag(tree);
duke@1 1047 }
duke@1 1048 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1049 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1050 break;
duke@1 1051 default:
duke@1 1052 throw new AssertionError();
duke@1 1053 }
duke@1 1054 long illegal = flags & StandardFlags & ~mask;
duke@1 1055 if (illegal != 0) {
duke@1 1056 if ((illegal & INTERFACE) != 0) {
duke@1 1057 log.error(pos, "intf.not.allowed.here");
duke@1 1058 mask |= INTERFACE;
duke@1 1059 }
duke@1 1060 else {
duke@1 1061 log.error(pos,
mcimadamore@80 1062 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1063 }
duke@1 1064 }
duke@1 1065 else if ((sym.kind == TYP ||
duke@1 1066 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1067 // in the presence of inner classes. Should it be deleted here?
duke@1 1068 checkDisjoint(pos, flags,
duke@1 1069 ABSTRACT,
duke@1 1070 PRIVATE | STATIC))
duke@1 1071 &&
duke@1 1072 checkDisjoint(pos, flags,
duke@1 1073 ABSTRACT | INTERFACE,
duke@1 1074 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1075 &&
duke@1 1076 checkDisjoint(pos, flags,
duke@1 1077 PUBLIC,
duke@1 1078 PRIVATE | PROTECTED)
duke@1 1079 &&
duke@1 1080 checkDisjoint(pos, flags,
duke@1 1081 PRIVATE,
duke@1 1082 PUBLIC | PROTECTED)
duke@1 1083 &&
duke@1 1084 checkDisjoint(pos, flags,
duke@1 1085 FINAL,
duke@1 1086 VOLATILE)
duke@1 1087 &&
duke@1 1088 (sym.kind == TYP ||
duke@1 1089 checkDisjoint(pos, flags,
duke@1 1090 ABSTRACT | NATIVE,
duke@1 1091 STRICTFP))) {
duke@1 1092 // skip
duke@1 1093 }
duke@1 1094 return flags & (mask | ~StandardFlags) | implicit;
duke@1 1095 }
duke@1 1096
duke@1 1097
duke@1 1098 /** Determine if this enum should be implicitly final.
duke@1 1099 *
duke@1 1100 * If the enum has no specialized enum contants, it is final.
duke@1 1101 *
duke@1 1102 * If the enum does have specialized enum contants, it is
duke@1 1103 * <i>not</i> final.
duke@1 1104 */
duke@1 1105 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1106 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1107 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1108 boolean specialized;
duke@1 1109 SpecialTreeVisitor() {
duke@1 1110 this.specialized = false;
duke@1 1111 };
duke@1 1112
jjg@398 1113 @Override
duke@1 1114 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1115
jjg@398 1116 @Override
duke@1 1117 public void visitVarDef(JCVariableDecl tree) {
duke@1 1118 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1119 if (tree.init instanceof JCNewClass &&
duke@1 1120 ((JCNewClass) tree.init).def != null) {
duke@1 1121 specialized = true;
duke@1 1122 }
duke@1 1123 }
duke@1 1124 }
duke@1 1125 }
duke@1 1126
duke@1 1127 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1128 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1129 for (JCTree defs: cdef.defs) {
duke@1 1130 defs.accept(sts);
duke@1 1131 if (sts.specialized) return 0;
duke@1 1132 }
duke@1 1133 return FINAL;
duke@1 1134 }
duke@1 1135
duke@1 1136 /* *************************************************************************
duke@1 1137 * Type Validation
duke@1 1138 **************************************************************************/
duke@1 1139
duke@1 1140 /** Validate a type expression. That is,
duke@1 1141 * check that all type arguments of a parametric type are within
duke@1 1142 * their bounds. This must be done in a second phase after type attributon
duke@1 1143 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1144 *
duke@1 1145 * class B<A extends C> { ... }
duke@1 1146 * class C extends B<C> { ... }
duke@1 1147 *
duke@1 1148 * and we can't make sure that the bound is already attributed because
duke@1 1149 * of possible cycles.
mcimadamore@638 1150 *
mcimadamore@638 1151 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1152 * and reporting any completion failures.
duke@1 1153 */
mcimadamore@122 1154 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1155 validate(tree, env, true);
duke@1 1156 }
mcimadamore@638 1157 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1158 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1159 }
duke@1 1160
duke@1 1161 /** Visitor method: Validate a list of type expressions.
duke@1 1162 */
mcimadamore@122 1163 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1164 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1165 validate(l.head, env);
duke@1 1166 }
duke@1 1167
duke@1 1168 /** A visitor class for type validation.
duke@1 1169 */
duke@1 1170 class Validator extends JCTree.Visitor {
duke@1 1171
mcimadamore@638 1172 boolean isOuter;
mcimadamore@638 1173 Env<AttrContext> env;
mcimadamore@638 1174
mcimadamore@638 1175 Validator(Env<AttrContext> env) {
mcimadamore@638 1176 this.env = env;
mcimadamore@638 1177 }
mcimadamore@638 1178
jjg@398 1179 @Override
duke@1 1180 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1181 tree.elemtype.accept(this);
duke@1 1182 }
duke@1 1183
jjg@398 1184 @Override
duke@1 1185 public void visitTypeApply(JCTypeApply tree) {
duke@1 1186 if (tree.type.tag == CLASS) {
duke@1 1187 List<JCExpression> args = tree.arguments;
mcimadamore@158 1188 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1189
mcimadamore@821 1190 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1191 if (incompatibleArg != null) {
mcimadamore@821 1192 for (JCTree arg : tree.arguments) {
mcimadamore@821 1193 if (arg.type == incompatibleArg) {
mcimadamore@829 1194 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1195 }
mcimadamore@829 1196 forms = forms.tail;
mcimadamore@829 1197 }
mcimadamore@829 1198 }
mcimadamore@829 1199
mcimadamore@829 1200 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1201
mcimadamore@638 1202 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1203
duke@1 1204 // For matching pairs of actual argument types `a' and
duke@1 1205 // formal type parameters with declared bound `b' ...
duke@1 1206 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1207 validateTree(args.head,
mcimadamore@638 1208 !(isOuter && is_java_lang_Class),
mcimadamore@638 1209 false);
duke@1 1210 args = args.tail;
duke@1 1211 forms = forms.tail;
duke@1 1212 }
duke@1 1213
duke@1 1214 // Check that this type is either fully parameterized, or
duke@1 1215 // not parameterized at all.
duke@1 1216 if (tree.type.getEnclosingType().isRaw())
duke@1 1217 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1218 if (tree.clazz.hasTag(SELECT))
duke@1 1219 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1220 }
duke@1 1221 }
duke@1 1222
jjg@398 1223 @Override
duke@1 1224 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1225 validateTrees(tree.bounds, true, isOuter);
duke@1 1226 checkClassBounds(tree.pos(), tree.type);
duke@1 1227 }
duke@1 1228
duke@1 1229 @Override
duke@1 1230 public void visitWildcard(JCWildcard tree) {
duke@1 1231 if (tree.inner != null)
mcimadamore@638 1232 validateTree(tree.inner, true, isOuter);
duke@1 1233 }
duke@1 1234
jjg@398 1235 @Override
duke@1 1236 public void visitSelect(JCFieldAccess tree) {
duke@1 1237 if (tree.type.tag == CLASS) {
duke@1 1238 visitSelectInternal(tree);
duke@1 1239
duke@1 1240 // Check that this type is either fully parameterized, or
duke@1 1241 // not parameterized at all.
duke@1 1242 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1243 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1244 }
duke@1 1245 }
mcimadamore@852 1246
duke@1 1247 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1248 if (tree.type.tsym.isStatic() &&
duke@1 1249 tree.selected.type.isParameterized()) {
duke@1 1250 // The enclosing type is not a class, so we are
duke@1 1251 // looking at a static member type. However, the
duke@1 1252 // qualifying expression is parameterized.
duke@1 1253 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1254 } else {
duke@1 1255 // otherwise validate the rest of the expression
mcimadamore@122 1256 tree.selected.accept(this);
duke@1 1257 }
duke@1 1258 }
duke@1 1259
duke@1 1260 /** Default visitor method: do nothing.
duke@1 1261 */
jjg@398 1262 @Override
duke@1 1263 public void visitTree(JCTree tree) {
duke@1 1264 }
mcimadamore@122 1265
mcimadamore@638 1266 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1267 try {
mcimadamore@638 1268 if (tree != null) {
mcimadamore@638 1269 this.isOuter = isOuter;
mcimadamore@638 1270 tree.accept(this);
mcimadamore@638 1271 if (checkRaw)
mcimadamore@638 1272 checkRaw(tree, env);
mcimadamore@638 1273 }
mcimadamore@638 1274 } catch (CompletionFailure ex) {
mcimadamore@638 1275 completionError(tree.pos(), ex);
mcimadamore@638 1276 }
mcimadamore@638 1277 }
mcimadamore@638 1278
mcimadamore@638 1279 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1280 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1281 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1282 }
mcimadamore@638 1283
mcimadamore@638 1284 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1285 if (lint.isEnabled(LintCategory.RAW) &&
mcimadamore@638 1286 tree.type.tag == CLASS &&
mcimadamore@638 1287 !TreeInfo.isDiamond(tree) &&
mcimadamore@1103 1288 !withinAnonConstr(env) &&
mcimadamore@638 1289 tree.type.isRaw()) {
mcimadamore@795 1290 log.warning(LintCategory.RAW,
mcimadamore@638 1291 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1292 }
mcimadamore@638 1293 }
mcimadamore@1103 1294
mcimadamore@1103 1295 boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1296 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1297 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1298 }
duke@1 1299 }
duke@1 1300
duke@1 1301 /* *************************************************************************
duke@1 1302 * Exception checking
duke@1 1303 **************************************************************************/
duke@1 1304
duke@1 1305 /* The following methods treat classes as sets that contain
duke@1 1306 * the class itself and all their subclasses
duke@1 1307 */
duke@1 1308
duke@1 1309 /** Is given type a subtype of some of the types in given list?
duke@1 1310 */
duke@1 1311 boolean subset(Type t, List<Type> ts) {
duke@1 1312 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1313 if (types.isSubtype(t, l.head)) return true;
duke@1 1314 return false;
duke@1 1315 }
duke@1 1316
duke@1 1317 /** Is given type a subtype or supertype of
duke@1 1318 * some of the types in given list?
duke@1 1319 */
duke@1 1320 boolean intersects(Type t, List<Type> ts) {
duke@1 1321 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1322 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1323 return false;
duke@1 1324 }
duke@1 1325
duke@1 1326 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1327 * in the list.
duke@1 1328 */
duke@1 1329 List<Type> incl(Type t, List<Type> ts) {
duke@1 1330 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1331 }
duke@1 1332
duke@1 1333 /** Remove type set from type set list.
duke@1 1334 */
duke@1 1335 List<Type> excl(Type t, List<Type> ts) {
duke@1 1336 if (ts.isEmpty()) {
duke@1 1337 return ts;
duke@1 1338 } else {
duke@1 1339 List<Type> ts1 = excl(t, ts.tail);
duke@1 1340 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1341 else if (ts1 == ts.tail) return ts;
duke@1 1342 else return ts1.prepend(ts.head);
duke@1 1343 }
duke@1 1344 }
duke@1 1345
duke@1 1346 /** Form the union of two type set lists.
duke@1 1347 */
duke@1 1348 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1349 List<Type> ts = ts1;
duke@1 1350 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1351 ts = incl(l.head, ts);
duke@1 1352 return ts;
duke@1 1353 }
duke@1 1354
duke@1 1355 /** Form the difference of two type lists.
duke@1 1356 */
duke@1 1357 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1358 List<Type> ts = ts1;
duke@1 1359 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1360 ts = excl(l.head, ts);
duke@1 1361 return ts;
duke@1 1362 }
duke@1 1363
duke@1 1364 /** Form the intersection of two type lists.
duke@1 1365 */
duke@1 1366 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1367 List<Type> ts = List.nil();
duke@1 1368 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1369 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1370 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1371 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1372 return ts;
duke@1 1373 }
duke@1 1374
duke@1 1375 /** Is exc an exception symbol that need not be declared?
duke@1 1376 */
duke@1 1377 boolean isUnchecked(ClassSymbol exc) {
duke@1 1378 return
duke@1 1379 exc.kind == ERR ||
duke@1 1380 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1381 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1382 }
duke@1 1383
duke@1 1384 /** Is exc an exception type that need not be declared?
duke@1 1385 */
duke@1 1386 boolean isUnchecked(Type exc) {
duke@1 1387 return
duke@1 1388 (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
duke@1 1389 (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
duke@1 1390 exc.tag == BOT;
duke@1 1391 }
duke@1 1392
duke@1 1393 /** Same, but handling completion failures.
duke@1 1394 */
duke@1 1395 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1396 try {
duke@1 1397 return isUnchecked(exc);
duke@1 1398 } catch (CompletionFailure ex) {
duke@1 1399 completionError(pos, ex);
duke@1 1400 return true;
duke@1 1401 }
duke@1 1402 }
duke@1 1403
duke@1 1404 /** Is exc handled by given exception list?
duke@1 1405 */
duke@1 1406 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1407 return isUnchecked(exc) || subset(exc, handled);
duke@1 1408 }
duke@1 1409
duke@1 1410 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1411 * @param thrown The list of thrown exceptions.
duke@1 1412 * @param handled The list of handled exceptions.
duke@1 1413 */
mcimadamore@362 1414 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1415 List<Type> unhandled = List.nil();
duke@1 1416 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1417 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1418 return unhandled;
duke@1 1419 }
duke@1 1420
duke@1 1421 /* *************************************************************************
duke@1 1422 * Overriding/Implementation checking
duke@1 1423 **************************************************************************/
duke@1 1424
duke@1 1425 /** The level of access protection given by a flag set,
duke@1 1426 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1427 */
duke@1 1428 static int protection(long flags) {
duke@1 1429 switch ((short)(flags & AccessFlags)) {
duke@1 1430 case PRIVATE: return 3;
duke@1 1431 case PROTECTED: return 1;
duke@1 1432 default:
duke@1 1433 case PUBLIC: return 0;
duke@1 1434 case 0: return 2;
duke@1 1435 }
duke@1 1436 }
duke@1 1437
duke@1 1438 /** A customized "cannot override" error message.
duke@1 1439 * @param m The overriding method.
duke@1 1440 * @param other The overridden method.
duke@1 1441 * @return An internationalized string.
duke@1 1442 */
mcimadamore@89 1443 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1444 String key;
duke@1 1445 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1446 key = "cant.override";
duke@1 1447 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1448 key = "cant.implement";
duke@1 1449 else
duke@1 1450 key = "clashes.with";
mcimadamore@89 1451 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1452 }
duke@1 1453
duke@1 1454 /** A customized "override" warning message.
duke@1 1455 * @param m The overriding method.
duke@1 1456 * @param other The overridden method.
duke@1 1457 * @return An internationalized string.
duke@1 1458 */
mcimadamore@89 1459 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1460 String key;
duke@1 1461 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1462 key = "unchecked.override";
duke@1 1463 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1464 key = "unchecked.implement";
duke@1 1465 else
duke@1 1466 key = "unchecked.clash.with";
mcimadamore@89 1467 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1468 }
duke@1 1469
duke@1 1470 /** A customized "override" warning message.
duke@1 1471 * @param m The overriding method.
duke@1 1472 * @param other The overridden method.
duke@1 1473 * @return An internationalized string.
duke@1 1474 */
mcimadamore@89 1475 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1476 String key;
duke@1 1477 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1478 key = "varargs.override";
duke@1 1479 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1480 key = "varargs.implement";
duke@1 1481 else
duke@1 1482 key = "varargs.clash.with";
mcimadamore@89 1483 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1484 }
duke@1 1485
duke@1 1486 /** Check that this method conforms with overridden method 'other'.
duke@1 1487 * where `origin' is the class where checking started.
duke@1 1488 * Complications:
duke@1 1489 * (1) Do not check overriding of synthetic methods
duke@1 1490 * (reason: they might be final).
duke@1 1491 * todo: check whether this is still necessary.
duke@1 1492 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1493 * than the method it implements. Augment the proxy methods with the
duke@1 1494 * undeclared exceptions in this case.
duke@1 1495 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1496 * has a result type
duke@1 1497 * extended by the result type of the method it implements.
duke@1 1498 * Change the proxies result type to the smaller type in this case.
duke@1 1499 *
duke@1 1500 * @param tree The tree from which positions
duke@1 1501 * are extracted for errors.
duke@1 1502 * @param m The overriding method.
duke@1 1503 * @param other The overridden method.
duke@1 1504 * @param origin The class of which the overriding method
duke@1 1505 * is a member.
duke@1 1506 */
duke@1 1507 void checkOverride(JCTree tree,
duke@1 1508 MethodSymbol m,
duke@1 1509 MethodSymbol other,
duke@1 1510 ClassSymbol origin) {
duke@1 1511 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1512 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1513 return;
duke@1 1514 }
duke@1 1515
duke@1 1516 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1517 if ((m.flags() & STATIC) != 0 &&
duke@1 1518 (other.flags() & STATIC) == 0) {
duke@1 1519 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1520 cannotOverride(m, other));
duke@1 1521 return;
duke@1 1522 }
duke@1 1523
duke@1 1524 // Error if instance method overrides static or final
duke@1 1525 // method (JLS 8.4.6.1).
duke@1 1526 if ((other.flags() & FINAL) != 0 ||
duke@1 1527 (m.flags() & STATIC) == 0 &&
duke@1 1528 (other.flags() & STATIC) != 0) {
duke@1 1529 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1530 cannotOverride(m, other),
mcimadamore@80 1531 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1532 return;
duke@1 1533 }
duke@1 1534
duke@1 1535 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1536 // handled in validateAnnotationMethod
duke@1 1537 return;
duke@1 1538 }
duke@1 1539
duke@1 1540 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1541 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1542 protection(m.flags()) > protection(other.flags())) {
duke@1 1543 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1544 cannotOverride(m, other),
mcimadamore@80 1545 other.flags() == 0 ?
mcimadamore@80 1546 Flag.PACKAGE :
mcimadamore@80 1547 asFlagSet(other.flags() & AccessFlags));
duke@1 1548 return;
duke@1 1549 }
duke@1 1550
duke@1 1551 Type mt = types.memberType(origin.type, m);
duke@1 1552 Type ot = types.memberType(origin.type, other);
duke@1 1553 // Error if overriding result type is different
duke@1 1554 // (or, in the case of generics mode, not a subtype) of
duke@1 1555 // overridden result type. We have to rename any type parameters
duke@1 1556 // before comparing types.
duke@1 1557 List<Type> mtvars = mt.getTypeArguments();
duke@1 1558 List<Type> otvars = ot.getTypeArguments();
duke@1 1559 Type mtres = mt.getReturnType();
duke@1 1560 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1561
mcimadamore@795 1562 overrideWarner.clear();
duke@1 1563 boolean resultTypesOK =
tbell@202 1564 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1565 if (!resultTypesOK) {
jjg@398 1566 if (!allowCovariantReturns &&
duke@1 1567 m.owner != origin &&
duke@1 1568 m.owner.isSubClass(other.owner, types)) {
duke@1 1569 // allow limited interoperability with covariant returns
duke@1 1570 } else {
mcimadamore@362 1571 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1572 "override.incompatible.ret",
mcimadamore@362 1573 cannotOverride(m, other),
duke@1 1574 mtres, otres);
duke@1 1575 return;
duke@1 1576 }
mcimadamore@795 1577 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1578 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1579 "override.unchecked.ret",
mcimadamore@362 1580 uncheckedOverrides(m, other),
mcimadamore@362 1581 mtres, otres);
duke@1 1582 }
duke@1 1583
duke@1 1584 // Error if overriding method throws an exception not reported
duke@1 1585 // by overridden method.
duke@1 1586 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1587 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1588 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1589 if (unhandledErased.nonEmpty()) {
duke@1 1590 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1591 "override.meth.doesnt.throw",
duke@1 1592 cannotOverride(m, other),
mcimadamore@362 1593 unhandledUnerased.head);
mcimadamore@362 1594 return;
mcimadamore@362 1595 }
mcimadamore@362 1596 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1597 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1598 "override.unchecked.thrown",
mcimadamore@362 1599 cannotOverride(m, other),
mcimadamore@362 1600 unhandledUnerased.head);
duke@1 1601 return;
duke@1 1602 }
duke@1 1603
duke@1 1604 // Optional warning if varargs don't agree
duke@1 1605 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1606 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1607 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1608 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1609 ? "override.varargs.missing"
duke@1 1610 : "override.varargs.extra",
duke@1 1611 varargsOverrides(m, other));
duke@1 1612 }
duke@1 1613
duke@1 1614 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1615 if ((other.flags() & BRIDGE) != 0) {
duke@1 1616 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1617 uncheckedOverrides(m, other));
duke@1 1618 }
duke@1 1619
duke@1 1620 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1621 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1622 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1623 }
duke@1 1624 }
duke@1 1625 // where
duke@1 1626 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1627 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1628 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1629 // because in that case, we will rediscover the issue when examining the method
duke@1 1630 // in the supertype.
duke@1 1631 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1632 // address the issue is when the method is the supertype implemementation: any other
duke@1 1633 // case, we will have dealt with when examining the supertype classes
duke@1 1634 ClassSymbol mc = m.enclClass();
duke@1 1635 Type st = types.supertype(origin.type);
duke@1 1636 if (st.tag != CLASS)
duke@1 1637 return true;
duke@1 1638 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1639
duke@1 1640 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1641 List<Type> intfs = types.interfaces(origin.type);
duke@1 1642 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1643 }
duke@1 1644 else
duke@1 1645 return (stimpl != m);
duke@1 1646 }
duke@1 1647
duke@1 1648
duke@1 1649 // used to check if there were any unchecked conversions
duke@1 1650 Warner overrideWarner = new Warner();
duke@1 1651
duke@1 1652 /** Check that a class does not inherit two concrete methods
duke@1 1653 * with the same signature.
duke@1 1654 * @param pos Position to be used for error reporting.
duke@1 1655 * @param site The class type to be checked.
duke@1 1656 */
duke@1 1657 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1658 Type sup = types.supertype(site);
duke@1 1659 if (sup.tag != CLASS) return;
duke@1 1660
duke@1 1661 for (Type t1 = sup;
duke@1 1662 t1.tsym.type.isParameterized();
duke@1 1663 t1 = types.supertype(t1)) {
duke@1 1664 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1665 e1 != null;
duke@1 1666 e1 = e1.sibling) {
duke@1 1667 Symbol s1 = e1.sym;
duke@1 1668 if (s1.kind != MTH ||
duke@1 1669 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1670 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1671 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1672 types,
duke@1 1673 true) != s1)
duke@1 1674 continue;
duke@1 1675 Type st1 = types.memberType(t1, s1);
duke@1 1676 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1677 if (st1 == s1.type) continue;
duke@1 1678
duke@1 1679 for (Type t2 = sup;
duke@1 1680 t2.tag == CLASS;
duke@1 1681 t2 = types.supertype(t2)) {
mcimadamore@24 1682 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1683 e2.scope != null;
duke@1 1684 e2 = e2.next()) {
duke@1 1685 Symbol s2 = e2.sym;
duke@1 1686 if (s2 == s1 ||
duke@1 1687 s2.kind != MTH ||
duke@1 1688 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1689 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1690 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1691 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1692 types,
duke@1 1693 true) != s2)
duke@1 1694 continue;
duke@1 1695 Type st2 = types.memberType(t2, s2);
duke@1 1696 if (types.overrideEquivalent(st1, st2))
duke@1 1697 log.error(pos, "concrete.inheritance.conflict",
duke@1 1698 s1, t1, s2, t2, sup);
duke@1 1699 }
duke@1 1700 }
duke@1 1701 }
duke@1 1702 }
duke@1 1703 }
duke@1 1704
duke@1 1705 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1706 * method with same name and arguments but incompatible return types.
duke@1 1707 * @param pos Position to be used for error reporting.
duke@1 1708 * @param t1 The first argument type.
duke@1 1709 * @param t2 The second argument type.
duke@1 1710 */
duke@1 1711 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1712 Type t1,
duke@1 1713 Type t2) {
duke@1 1714 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1715 types.makeCompoundType(t1, t2));
duke@1 1716 }
duke@1 1717
duke@1 1718 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1719 Type t1,
duke@1 1720 Type t2,
duke@1 1721 Type site) {
mcimadamore@746 1722 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1723 }
duke@1 1724
duke@1 1725 /** Return the first method which is defined with same args
duke@1 1726 * but different return types in two given interfaces, or null if none
duke@1 1727 * exists.
duke@1 1728 * @param t1 The first type.
duke@1 1729 * @param t2 The second type.
duke@1 1730 * @param site The most derived type.
duke@1 1731 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1732 */
mcimadamore@746 1733 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1734 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1735 closure(t1, interfaces1);
duke@1 1736 Map<TypeSymbol,Type> interfaces2;
duke@1 1737 if (t1 == t2)
duke@1 1738 interfaces2 = interfaces1;
duke@1 1739 else
duke@1 1740 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1741
duke@1 1742 for (Type t3 : interfaces1.values()) {
duke@1 1743 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1744 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1745 if (s != null) return s;
duke@1 1746 }
duke@1 1747 }
duke@1 1748 return null;
duke@1 1749 }
duke@1 1750
duke@1 1751 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1752 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
duke@1 1753 if (t.tag != CLASS) return;
duke@1 1754 if (typeMap.put(t.tsym, t) == null) {
duke@1 1755 closure(types.supertype(t), typeMap);
duke@1 1756 for (Type i : types.interfaces(t))
duke@1 1757 closure(i, typeMap);
duke@1 1758 }
duke@1 1759 }
duke@1 1760
duke@1 1761 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1762 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
duke@1 1763 if (t.tag != CLASS) return;
duke@1 1764 if (typesSkip.get(t.tsym) != null) return;
duke@1 1765 if (typeMap.put(t.tsym, t) == null) {
duke@1 1766 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1767 for (Type i : types.interfaces(t))
duke@1 1768 closure(i, typesSkip, typeMap);
duke@1 1769 }
duke@1 1770 }
duke@1 1771
duke@1 1772 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1773 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1774 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1775 Symbol s1 = e1.sym;
duke@1 1776 Type st1 = null;
duke@1 1777 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
duke@1 1778 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1779 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1780 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1781 Symbol s2 = e2.sym;
duke@1 1782 if (s1 == s2) continue;
duke@1 1783 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
duke@1 1784 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1785 Type st2 = types.memberType(t2, s2);
duke@1 1786 if (types.overrideEquivalent(st1, st2)) {
duke@1 1787 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1788 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1789 Type rt1 = st1.getReturnType();
duke@1 1790 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1791 boolean compat =
duke@1 1792 types.isSameType(rt1, rt2) ||
duke@1 1793 rt1.tag >= CLASS && rt2.tag >= CLASS &&
duke@1 1794 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
mcimadamore@59 1795 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
mcimadamore@59 1796 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1797 if (!compat) {
mcimadamore@746 1798 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1799 t1, t2, s2.name +
mcimadamore@746 1800 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1801 return s2;
mcimadamore@746 1802 }
mcimadamore@889 1803 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1804 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1805 log.error(pos,
mcimadamore@746 1806 "name.clash.same.erasure.no.override",
mcimadamore@746 1807 s1, s1.location(),
mcimadamore@746 1808 s2, s2.location());
mcimadamore@746 1809 return s2;
duke@1 1810 }
duke@1 1811 }
duke@1 1812 }
duke@1 1813 return null;
duke@1 1814 }
mcimadamore@59 1815 //WHERE
mcimadamore@59 1816 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1817 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1818 Type st1 = types.memberType(site, s1);
mcimadamore@59 1819 Type st2 = types.memberType(site, s2);
mcimadamore@59 1820 closure(site, supertypes);
mcimadamore@59 1821 for (Type t : supertypes.values()) {
mcimadamore@59 1822 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1823 Symbol s3 = e.sym;
mcimadamore@59 1824 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1825 Type st3 = types.memberType(site,s3);
mcimadamore@59 1826 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1827 if (s3.owner == site.tsym) {
mcimadamore@59 1828 return true;
mcimadamore@59 1829 }
mcimadamore@59 1830 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1831 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1832 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1833 Type rt1 = st1.getReturnType();
mcimadamore@59 1834 Type rt2 = st2.getReturnType();
mcimadamore@59 1835 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1836 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1837 boolean compat =
mcimadamore@59 1838 rt13.tag >= CLASS && rt23.tag >= CLASS &&
mcimadamore@59 1839 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
mcimadamore@59 1840 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
mcimadamore@59 1841 if (compat)
mcimadamore@59 1842 return true;
mcimadamore@59 1843 }
mcimadamore@59 1844 }
mcimadamore@59 1845 }
mcimadamore@59 1846 return false;
mcimadamore@59 1847 }
duke@1 1848
duke@1 1849 /** Check that a given method conforms with any method it overrides.
duke@1 1850 * @param tree The tree from which positions are extracted
duke@1 1851 * for errors.
duke@1 1852 * @param m The overriding method.
duke@1 1853 */
duke@1 1854 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1855 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1856 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1857 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1858 log.error(tree.pos(), "enum.no.finalize");
duke@1 1859 return;
duke@1 1860 }
mcimadamore@746 1861 for (Type t = origin.type; t.tag == CLASS;
duke@1 1862 t = types.supertype(t)) {
mcimadamore@746 1863 if (t != origin.type) {
mcimadamore@746 1864 checkOverride(tree, t, origin, m);
mcimadamore@746 1865 }
mcimadamore@746 1866 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1867 checkOverride(tree, t2, origin, m);
duke@1 1868 }
duke@1 1869 }
duke@1 1870 }
duke@1 1871
mcimadamore@746 1872 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1873 TypeSymbol c = site.tsym;
mcimadamore@746 1874 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1875 while (e.scope != null) {
mcimadamore@746 1876 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1877 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1878 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1879 }
mcimadamore@746 1880 }
mcimadamore@746 1881 e = e.next();
mcimadamore@746 1882 }
mcimadamore@746 1883 }
mcimadamore@746 1884
mcimadamore@746 1885 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 1886 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 1887 return (cf.accepts(s1) &&
mcimadamore@858 1888 cf.accepts(s2) &&
mcimadamore@858 1889 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 1890 }
mcimadamore@746 1891
mcimadamore@746 1892
duke@1 1893 /** Check that all abstract members of given class have definitions.
duke@1 1894 * @param pos Position to be used for error reporting.
duke@1 1895 * @param c The class.
duke@1 1896 */
duke@1 1897 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1898 try {
duke@1 1899 MethodSymbol undef = firstUndef(c, c);
duke@1 1900 if (undef != null) {
duke@1 1901 if ((c.flags() & ENUM) != 0 &&
duke@1 1902 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 1903 (c.flags() & FINAL) == 0) {
duke@1 1904 // add the ABSTRACT flag to an enum
duke@1 1905 c.flags_field |= ABSTRACT;
duke@1 1906 } else {
duke@1 1907 MethodSymbol undef1 =
duke@1 1908 new MethodSymbol(undef.flags(), undef.name,
duke@1 1909 types.memberType(c.type, undef), undef.owner);
duke@1 1910 log.error(pos, "does.not.override.abstract",
duke@1 1911 c, undef1, undef1.location());
duke@1 1912 }
duke@1 1913 }
duke@1 1914 } catch (CompletionFailure ex) {
duke@1 1915 completionError(pos, ex);
duke@1 1916 }
duke@1 1917 }
duke@1 1918 //where
duke@1 1919 /** Return first abstract member of class `c' that is not defined
duke@1 1920 * in `impl', null if there is none.
duke@1 1921 */
duke@1 1922 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 1923 MethodSymbol undef = null;
duke@1 1924 // Do not bother to search in classes that are not abstract,
duke@1 1925 // since they cannot have abstract members.
duke@1 1926 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 1927 Scope s = c.members();
duke@1 1928 for (Scope.Entry e = s.elems;
duke@1 1929 undef == null && e != null;
duke@1 1930 e = e.sibling) {
duke@1 1931 if (e.sym.kind == MTH &&
duke@1 1932 (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
duke@1 1933 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 1934 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
duke@1 1935 if (implmeth == null || implmeth == absmeth)
duke@1 1936 undef = absmeth;
duke@1 1937 }
duke@1 1938 }
duke@1 1939 if (undef == null) {
duke@1 1940 Type st = types.supertype(c.type);
duke@1 1941 if (st.tag == CLASS)
duke@1 1942 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 1943 }
duke@1 1944 for (List<Type> l = types.interfaces(c.type);
duke@1 1945 undef == null && l.nonEmpty();
duke@1 1946 l = l.tail) {
duke@1 1947 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 1948 }
duke@1 1949 }
duke@1 1950 return undef;
duke@1 1951 }
duke@1 1952
mcimadamore@690 1953 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 1954 CycleChecker cc = new CycleChecker();
mcimadamore@690 1955 cc.scan(tree);
mcimadamore@690 1956 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 1957 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 1958 }
mcimadamore@690 1959 }
mcimadamore@690 1960
mcimadamore@690 1961 class CycleChecker extends TreeScanner {
mcimadamore@690 1962
mcimadamore@690 1963 List<Symbol> seenClasses = List.nil();
mcimadamore@690 1964 boolean errorFound = false;
mcimadamore@690 1965 boolean partialCheck = false;
mcimadamore@690 1966
mcimadamore@690 1967 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 1968 if (sym != null && sym.kind == TYP) {
mcimadamore@690 1969 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 1970 if (classEnv != null) {
mcimadamore@690 1971 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 1972 try {
mcimadamore@690 1973 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 1974 scan(classEnv.tree);
mcimadamore@690 1975 }
mcimadamore@690 1976 finally {
mcimadamore@690 1977 log.useSource(prevSource.getFile());
mcimadamore@690 1978 }
mcimadamore@690 1979 } else if (sym.kind == TYP) {
mcimadamore@690 1980 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 1981 }
mcimadamore@690 1982 } else {
mcimadamore@690 1983 //not completed yet
mcimadamore@690 1984 partialCheck = true;
mcimadamore@690 1985 }
mcimadamore@690 1986 }
mcimadamore@690 1987
mcimadamore@690 1988 @Override
mcimadamore@690 1989 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 1990 super.visitSelect(tree);
mcimadamore@690 1991 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 1992 }
mcimadamore@690 1993
mcimadamore@690 1994 @Override
mcimadamore@690 1995 public void visitIdent(JCIdent tree) {
mcimadamore@690 1996 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 1997 }
mcimadamore@690 1998
mcimadamore@690 1999 @Override
mcimadamore@690 2000 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2001 scan(tree.clazz);
mcimadamore@690 2002 }
mcimadamore@690 2003
mcimadamore@690 2004 @Override
mcimadamore@690 2005 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2006 scan(tree.elemtype);
mcimadamore@690 2007 }
mcimadamore@690 2008
mcimadamore@690 2009 @Override
mcimadamore@690 2010 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2011 List<JCTree> supertypes = List.nil();
mcimadamore@690 2012 if (tree.getExtendsClause() != null) {
mcimadamore@690 2013 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2014 }
mcimadamore@690 2015 if (tree.getImplementsClause() != null) {
mcimadamore@690 2016 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2017 supertypes = supertypes.prepend(intf);
mcimadamore@690 2018 }
mcimadamore@690 2019 }
mcimadamore@690 2020 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2021 }
mcimadamore@690 2022
mcimadamore@690 2023 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2024 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2025 return;
mcimadamore@690 2026 if (seenClasses.contains(c)) {
mcimadamore@690 2027 errorFound = true;
mcimadamore@690 2028 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2029 } else if (!c.type.isErroneous()) {
mcimadamore@690 2030 try {
mcimadamore@690 2031 seenClasses = seenClasses.prepend(c);
mcimadamore@690 2032 if (c.type.tag == CLASS) {
mcimadamore@690 2033 if (supertypes.nonEmpty()) {
mcimadamore@690 2034 scan(supertypes);
mcimadamore@690 2035 }
mcimadamore@690 2036 else {
mcimadamore@690 2037 ClassType ct = (ClassType)c.type;
mcimadamore@690 2038 if (ct.supertype_field == null ||
mcimadamore@690 2039 ct.interfaces_field == null) {
mcimadamore@690 2040 //not completed yet
mcimadamore@690 2041 partialCheck = true;
mcimadamore@690 2042 return;
mcimadamore@690 2043 }
mcimadamore@690 2044 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2045 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2046 checkSymbol(pos, intf.tsym);
mcimadamore@690 2047 }
mcimadamore@690 2048 }
mcimadamore@690 2049 if (c.owner.kind == TYP) {
mcimadamore@690 2050 checkSymbol(pos, c.owner);
mcimadamore@690 2051 }
mcimadamore@690 2052 }
mcimadamore@690 2053 } finally {
mcimadamore@690 2054 seenClasses = seenClasses.tail;
mcimadamore@690 2055 }
mcimadamore@690 2056 }
mcimadamore@690 2057 }
mcimadamore@690 2058 }
mcimadamore@690 2059
duke@1 2060 /** Check for cyclic references. Issue an error if the
duke@1 2061 * symbol of the type referred to has a LOCKED flag set.
duke@1 2062 *
duke@1 2063 * @param pos Position to be used for error reporting.
duke@1 2064 * @param t The type referred to.
duke@1 2065 */
duke@1 2066 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2067 checkNonCyclicInternal(pos, t);
duke@1 2068 }
duke@1 2069
duke@1 2070
duke@1 2071 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2072 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2073 }
duke@1 2074
mcimadamore@236 2075 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2076 final TypeVar tv;
mcimadamore@42 2077 if (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2078 return;
duke@1 2079 if (seen.contains(t)) {
duke@1 2080 tv = (TypeVar)t;
jjg@110 2081 tv.bound = types.createErrorType(t);
duke@1 2082 log.error(pos, "cyclic.inheritance", t);
duke@1 2083 } else if (t.tag == TYPEVAR) {
duke@1 2084 tv = (TypeVar)t;
mcimadamore@236 2085 seen = seen.prepend(tv);
duke@1 2086 for (Type b : types.getBounds(tv))
duke@1 2087 checkNonCyclic1(pos, b, seen);
duke@1 2088 }
duke@1 2089 }
duke@1 2090
duke@1 2091 /** Check for cyclic references. Issue an error if the
duke@1 2092 * symbol of the type referred to has a LOCKED flag set.
duke@1 2093 *
duke@1 2094 * @param pos Position to be used for error reporting.
duke@1 2095 * @param t The type referred to.
duke@1 2096 * @returns True if the check completed on all attributed classes
duke@1 2097 */
duke@1 2098 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2099 boolean complete = true; // was the check complete?
duke@1 2100 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2101 Symbol c = t.tsym;
duke@1 2102 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2103
duke@1 2104 if ((c.flags_field & LOCKED) != 0) {
duke@1 2105 noteCyclic(pos, (ClassSymbol)c);
duke@1 2106 } else if (!c.type.isErroneous()) {
duke@1 2107 try {
duke@1 2108 c.flags_field |= LOCKED;
duke@1 2109 if (c.type.tag == CLASS) {
duke@1 2110 ClassType clazz = (ClassType)c.type;
duke@1 2111 if (clazz.interfaces_field != null)
duke@1 2112 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2113 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2114 if (clazz.supertype_field != null) {
duke@1 2115 Type st = clazz.supertype_field;
duke@1 2116 if (st != null && st.tag == CLASS)
duke@1 2117 complete &= checkNonCyclicInternal(pos, st);
duke@1 2118 }
duke@1 2119 if (c.owner.kind == TYP)
duke@1 2120 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2121 }
duke@1 2122 } finally {
duke@1 2123 c.flags_field &= ~LOCKED;
duke@1 2124 }
duke@1 2125 }
duke@1 2126 if (complete)
duke@1 2127 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2128 if (complete) c.flags_field |= ACYCLIC;
duke@1 2129 return complete;
duke@1 2130 }
duke@1 2131
duke@1 2132 /** Note that we found an inheritance cycle. */
duke@1 2133 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2134 log.error(pos, "cyclic.inheritance", c);
duke@1 2135 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2136 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2137 Type st = types.supertype(c.type);
duke@1 2138 if (st.tag == CLASS)
jjg@110 2139 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2140 c.type = types.createErrorType(c, c.type);
duke@1 2141 c.flags_field |= ACYCLIC;
duke@1 2142 }
duke@1 2143
duke@1 2144 /** Check that all methods which implement some
duke@1 2145 * method conform to the method they implement.
duke@1 2146 * @param tree The class definition whose members are checked.
duke@1 2147 */
duke@1 2148 void checkImplementations(JCClassDecl tree) {
duke@1 2149 checkImplementations(tree, tree.sym);
duke@1 2150 }
duke@1 2151 //where
duke@1 2152 /** Check that all methods which implement some
duke@1 2153 * method in `ic' conform to the method they implement.
duke@1 2154 */
duke@1 2155 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
duke@1 2156 ClassSymbol origin = tree.sym;
duke@1 2157 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2158 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2159 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2160 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2161 if (e.sym.kind == MTH &&
duke@1 2162 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2163 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2164 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2165 if (implmeth != null && implmeth != absmeth &&
duke@1 2166 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2167 (origin.flags() & INTERFACE)) {
duke@1 2168 // don't check if implmeth is in a class, yet
duke@1 2169 // origin is an interface. This case arises only
duke@1 2170 // if implmeth is declared in Object. The reason is
duke@1 2171 // that interfaces really don't inherit from
duke@1 2172 // Object it's just that the compiler represents
duke@1 2173 // things that way.
duke@1 2174 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2175 }
duke@1 2176 }
duke@1 2177 }
duke@1 2178 }
duke@1 2179 }
duke@1 2180 }
duke@1 2181
duke@1 2182 /** Check that all abstract methods implemented by a class are
duke@1 2183 * mutually compatible.
duke@1 2184 * @param pos Position to be used for error reporting.
duke@1 2185 * @param c The class whose interfaces are checked.
duke@1 2186 */
duke@1 2187 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2188 List<Type> supertypes = types.interfaces(c);
duke@1 2189 Type supertype = types.supertype(c);
duke@1 2190 if (supertype.tag == CLASS &&
duke@1 2191 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2192 supertypes = supertypes.prepend(supertype);
duke@1 2193 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2194 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2195 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2196 return;
duke@1 2197 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2198 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2199 return;
duke@1 2200 }
duke@1 2201 checkCompatibleConcretes(pos, c);
duke@1 2202 }
duke@1 2203
mcimadamore@359 2204 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2205 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2206 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2207 // VM allows methods and variables with differing types
mcimadamore@359 2208 if (sym.kind == e.sym.kind &&
mcimadamore@359 2209 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2210 sym != e.sym &&
mcimadamore@359 2211 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2212 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2213 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2214 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2215 return;
mcimadamore@359 2216 }
mcimadamore@359 2217 }
mcimadamore@359 2218 }
mcimadamore@359 2219 }
mcimadamore@359 2220
mcimadamore@780 2221 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2222 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2223 *
mcimadamore@780 2224 * @param pos Position to be used for error reporting.
mcimadamore@780 2225 * @param site The class whose methods are checked.
mcimadamore@780 2226 * @param sym The method symbol to be checked.
mcimadamore@780 2227 */
mcimadamore@858 2228 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2229 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2230 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2231 //by method 'sym' in 'site'...
mcimadamore@1198 2232 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2233 if (!sym.overrides(m1, site.tsym, types, false)) continue;
mcimadamore@1198 2234 //...check each method m2 that is a member of 'site'
mcimadamore@1198 2235 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2236 if (m2 == m1) continue;
mcimadamore@858 2237 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2238 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1198 2239 if (!types.isSubSignature(sym.type, types.memberType(site, m2), false) &&
mcimadamore@1198 2240 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2241 sym.flags_field |= CLASH;
mcimadamore@1198 2242 String key = m1 == sym ?
mcimadamore@858 2243 "name.clash.same.erasure.no.override" :
mcimadamore@858 2244 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2245 log.error(pos,
mcimadamore@858 2246 key,
mcimadamore@858 2247 sym, sym.location(),
mcimadamore@1198 2248 m2, m2.location(),
mcimadamore@1198 2249 m1, m1.location());
mcimadamore@858 2250 return;
mcimadamore@858 2251 }
mcimadamore@780 2252 }
mcimadamore@780 2253 }
mcimadamore@780 2254 }
mcimadamore@780 2255
mcimadamore@877 2256
mcimadamore@877 2257
mcimadamore@858 2258 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2259 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2260 *
mcimadamore@858 2261 * @param pos Position to be used for error reporting.
mcimadamore@858 2262 * @param site The class whose methods are checked.
mcimadamore@858 2263 * @param sym The method symbol to be checked.
mcimadamore@780 2264 */
mcimadamore@858 2265 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2266 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2267 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2268 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2269 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2270 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@907 2271 if (!types.isSubSignature(sym.type, types.memberType(site, s), false) &&
mcimadamore@877 2272 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2273 log.error(pos,
mcimadamore@858 2274 "name.clash.same.erasure.no.hide",
mcimadamore@858 2275 sym, sym.location(),
mcimadamore@877 2276 s, s.location());
mcimadamore@858 2277 return;
mcimadamore@858 2278 }
mcimadamore@858 2279 }
mcimadamore@858 2280 }
mcimadamore@780 2281
mcimadamore@858 2282 //where
mcimadamore@858 2283 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2284
mcimadamore@858 2285 Type site;
mcimadamore@780 2286
mcimadamore@858 2287 ClashFilter(Type site) {
mcimadamore@858 2288 this.site = site;
mcimadamore@858 2289 }
mcimadamore@858 2290
mcimadamore@858 2291 boolean shouldSkip(Symbol s) {
mcimadamore@858 2292 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2293 s.owner == site.tsym;
mcimadamore@858 2294 }
mcimadamore@858 2295
mcimadamore@858 2296 public boolean accepts(Symbol s) {
mcimadamore@858 2297 return s.kind == MTH &&
mcimadamore@858 2298 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2299 !shouldSkip(s) &&
mcimadamore@858 2300 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2301 !s.isConstructor();
mcimadamore@858 2302 }
mcimadamore@858 2303 }
mcimadamore@780 2304
mcimadamore@359 2305 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2306 */
mcimadamore@359 2307 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2308 if (!sym.type.isErroneous()) {
mcimadamore@359 2309 if (warnOnSyntheticConflicts) {
mcimadamore@359 2310 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2311 }
mcimadamore@359 2312 else {
mcimadamore@359 2313 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2314 }
mcimadamore@359 2315 }
mcimadamore@359 2316 }
mcimadamore@359 2317
duke@1 2318 /** Check that class c does not implement directly or indirectly
duke@1 2319 * the same parameterized interface with two different argument lists.
duke@1 2320 * @param pos Position to be used for error reporting.
duke@1 2321 * @param type The type whose interfaces are checked.
duke@1 2322 */
duke@1 2323 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2324 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2325 }
duke@1 2326 //where
duke@1 2327 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2328 * with their class symbol as key and their type as value. Make
duke@1 2329 * sure no class is entered with two different types.
duke@1 2330 */
duke@1 2331 void checkClassBounds(DiagnosticPosition pos,
duke@1 2332 Map<TypeSymbol,Type> seensofar,
duke@1 2333 Type type) {
duke@1 2334 if (type.isErroneous()) return;
duke@1 2335 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2336 Type it = l.head;
duke@1 2337 Type oldit = seensofar.put(it.tsym, it);
duke@1 2338 if (oldit != null) {
duke@1 2339 List<Type> oldparams = oldit.allparams();
duke@1 2340 List<Type> newparams = it.allparams();
duke@1 2341 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2342 log.error(pos, "cant.inherit.diff.arg",
duke@1 2343 it.tsym, Type.toString(oldparams),
duke@1 2344 Type.toString(newparams));
duke@1 2345 }
duke@1 2346 checkClassBounds(pos, seensofar, it);
duke@1 2347 }
duke@1 2348 Type st = types.supertype(type);
duke@1 2349 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2350 }
duke@1 2351
duke@1 2352 /** Enter interface into into set.
duke@1 2353 * If it existed already, issue a "repeated interface" error.
duke@1 2354 */
duke@1 2355 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2356 if (its.contains(it))
duke@1 2357 log.error(pos, "repeated.interface");
duke@1 2358 else {
duke@1 2359 its.add(it);
duke@1 2360 }
duke@1 2361 }
duke@1 2362
duke@1 2363 /* *************************************************************************
duke@1 2364 * Check annotations
duke@1 2365 **************************************************************************/
duke@1 2366
mcimadamore@629 2367 /**
mcimadamore@634 2368 * Recursively validate annotations values
mcimadamore@629 2369 */
mcimadamore@634 2370 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2371 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2372 @Override
mcimadamore@629 2373 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2374 if (!tree.type.isErroneous()) {
jjg@1017 2375 super.visitAnnotation(tree);
jjg@1017 2376 validateAnnotation(tree);
jjg@1017 2377 }
mcimadamore@629 2378 }
mcimadamore@629 2379 }
mcimadamore@634 2380 tree.accept(new AnnotationValidator());
mcimadamore@629 2381 }
mcimadamore@629 2382
duke@1 2383 /** Annotation types are restricted to primitives, String, an
duke@1 2384 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2385 * Anything>, arrays of the preceding.
duke@1 2386 */
duke@1 2387 void validateAnnotationType(JCTree restype) {
duke@1 2388 // restype may be null if an error occurred, so don't bother validating it
duke@1 2389 if (restype != null) {
duke@1 2390 validateAnnotationType(restype.pos(), restype.type);
duke@1 2391 }
duke@1 2392 }
duke@1 2393
duke@1 2394 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2395 if (type.isPrimitive()) return;
duke@1 2396 if (types.isSameType(type, syms.stringType)) return;
duke@1 2397 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2398 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2399 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2400 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2401 validateAnnotationType(pos, types.elemtype(type));
duke@1 2402 return;
duke@1 2403 }
duke@1 2404 log.error(pos, "invalid.annotation.member.type");
duke@1 2405 }
duke@1 2406
duke@1 2407 /**
duke@1 2408 * "It is also a compile-time error if any method declared in an
duke@1 2409 * annotation type has a signature that is override-equivalent to
duke@1 2410 * that of any public or protected method declared in class Object
duke@1 2411 * or in the interface annotation.Annotation."
duke@1 2412 *
jjh@972 2413 * @jls 9.6 Annotation Types
duke@1 2414 */
duke@1 2415 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
duke@1 2416 for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
duke@1 2417 Scope s = sup.tsym.members();
duke@1 2418 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2419 if (e.sym.kind == MTH &&
duke@1 2420 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2421 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2422 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2423 }
duke@1 2424 }
duke@1 2425 }
duke@1 2426
duke@1 2427 /** Check the annotations of a symbol.
duke@1 2428 */
duke@1 2429 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2430 if (skipAnnotations) return;
duke@1 2431 for (JCAnnotation a : annotations)
duke@1 2432 validateAnnotation(a, s);
duke@1 2433 }
duke@1 2434
duke@1 2435 /** Check an annotation of a symbol.
duke@1 2436 */
duke@1 2437 public void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2438 validateAnnotationTree(a);
duke@1 2439
duke@1 2440 if (!annotationApplicable(a, s))
duke@1 2441 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2442
duke@1 2443 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2444 if (!isOverrider(s))
duke@1 2445 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2446 }
duke@1 2447 }
duke@1 2448
duke@1 2449 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2450 boolean isOverrider(Symbol s) {
duke@1 2451 if (s.kind != MTH || s.isStatic())
duke@1 2452 return false;
duke@1 2453 MethodSymbol m = (MethodSymbol)s;
duke@1 2454 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2455 for (Type sup : types.closure(owner.type)) {
duke@1 2456 if (sup == owner.type)
duke@1 2457 continue; // skip "this"
duke@1 2458 Scope scope = sup.tsym.members();
duke@1 2459 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2460 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2461 return true;
duke@1 2462 }
duke@1 2463 }
duke@1 2464 return false;
duke@1 2465 }
duke@1 2466
duke@1 2467 /** Is the annotation applicable to the symbol? */
duke@1 2468 boolean annotationApplicable(JCAnnotation a, Symbol s) {
duke@1 2469 Attribute.Compound atTarget =
duke@1 2470 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
duke@1 2471 if (atTarget == null) return true;
duke@1 2472 Attribute atValue = atTarget.member(names.value);
duke@1 2473 if (!(atValue instanceof Attribute.Array)) return true; // error recovery
duke@1 2474 Attribute.Array arr = (Attribute.Array) atValue;
duke@1 2475 for (Attribute app : arr.values) {
duke@1 2476 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2477 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2478 if (e.value.name == names.TYPE)
duke@1 2479 { if (s.kind == TYP) return true; }
duke@1 2480 else if (e.value.name == names.FIELD)
duke@1 2481 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2482 else if (e.value.name == names.METHOD)
duke@1 2483 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2484 else if (e.value.name == names.PARAMETER)
duke@1 2485 { if (s.kind == VAR &&
duke@1 2486 s.owner.kind == MTH &&
duke@1 2487 (s.flags() & PARAMETER) != 0)
duke@1 2488 return true;
duke@1 2489 }
duke@1 2490 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2491 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2492 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2493 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2494 (s.flags() & PARAMETER) == 0)
duke@1 2495 return true;
duke@1 2496 }
duke@1 2497 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2498 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2499 return true;
duke@1 2500 }
duke@1 2501 else if (e.value.name == names.PACKAGE)
duke@1 2502 { if (s.kind == PCK) return true; }
jjg@308 2503 else if (e.value.name == names.TYPE_USE)
jjg@308 2504 { if (s.kind == TYP ||
jjg@308 2505 s.kind == VAR ||
jjg@308 2506 (s.kind == MTH && !s.isConstructor() &&
jjg@308 2507 s.type.getReturnType().tag != VOID))
jjg@308 2508 return true;
jjg@308 2509 }
duke@1 2510 else
duke@1 2511 return true; // recovery
duke@1 2512 }
duke@1 2513 return false;
duke@1 2514 }
duke@1 2515
duke@1 2516 /** Check an annotation value.
duke@1 2517 */
duke@1 2518 public void validateAnnotation(JCAnnotation a) {
mcimadamore@632 2519 // collect an inventory of the members (sorted alphabetically)
mcimadamore@632 2520 Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
mcimadamore@632 2521 public int compare(Symbol t, Symbol t1) {
mcimadamore@632 2522 return t.name.compareTo(t1.name);
mcimadamore@632 2523 }
mcimadamore@632 2524 });
duke@1 2525 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2526 e != null;
duke@1 2527 e = e.sibling)
duke@1 2528 if (e.sym.kind == MTH)
duke@1 2529 members.add((MethodSymbol) e.sym);
duke@1 2530
duke@1 2531 // count them off as they're annotated
duke@1 2532 for (JCTree arg : a.args) {
jjg@1127 2533 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 2534 JCAssign assign = (JCAssign) arg;
duke@1 2535 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2536 if (m == null || m.type.isErroneous()) continue;
duke@1 2537 if (!members.remove(m))
jjg@479 2538 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2539 m.name, a.type);
duke@1 2540 }
duke@1 2541
duke@1 2542 // all the remaining ones better have default values
mcimadamore@632 2543 ListBuffer<Name> missingDefaults = ListBuffer.lb();
mcimadamore@632 2544 for (MethodSymbol m : members) {
mcimadamore@632 2545 if (m.defaultValue == null && !m.type.isErroneous()) {
mcimadamore@632 2546 missingDefaults.append(m.name);
mcimadamore@632 2547 }
mcimadamore@632 2548 }
mcimadamore@632 2549 if (missingDefaults.nonEmpty()) {
mcimadamore@632 2550 String key = (missingDefaults.size() > 1)
mcimadamore@632 2551 ? "annotation.missing.default.value.1"
mcimadamore@632 2552 : "annotation.missing.default.value";
mcimadamore@632 2553 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 2554 }
duke@1 2555
duke@1 2556 // special case: java.lang.annotation.Target must not have
duke@1 2557 // repeated values in its value member
duke@1 2558 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2559 a.args.tail == null)
duke@1 2560 return;
duke@1 2561
jjg@1127 2562 if (!a.args.head.hasTag(ASSIGN)) return; // error recovery
duke@1 2563 JCAssign assign = (JCAssign) a.args.head;
duke@1 2564 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2565 if (m.name != names.value) return;
duke@1 2566 JCTree rhs = assign.rhs;
jjg@1127 2567 if (!rhs.hasTag(NEWARRAY)) return;
duke@1 2568 JCNewArray na = (JCNewArray) rhs;
duke@1 2569 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2570 for (JCTree elem : na.elems) {
duke@1 2571 if (!targets.add(TreeInfo.symbol(elem))) {
duke@1 2572 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2573 }
duke@1 2574 }
duke@1 2575 }
duke@1 2576
duke@1 2577 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 2578 if (allowAnnotations &&
mcimadamore@795 2579 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 2580 (s.flags() & DEPRECATED) != 0 &&
duke@1 2581 !syms.deprecatedType.isErroneous() &&
duke@1 2582 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 2583 log.warning(LintCategory.DEP_ANN,
jjg@612 2584 pos, "missing.deprecated.annotation");
duke@1 2585 }
duke@1 2586 }
duke@1 2587
mcimadamore@852 2588 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 2589 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 2590 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 2591 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 2592 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2593 @Override
mcimadamore@852 2594 public void report() {
mcimadamore@852 2595 warnDeprecated(pos, s);
mcimadamore@852 2596 }
mcimadamore@852 2597 });
jjg@1157 2598 }
mcimadamore@852 2599 }
mcimadamore@852 2600
mcimadamore@852 2601 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 2602 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 2603 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2604 public void report() {
mcimadamore@852 2605 if (enableSunApiLintControl)
mcimadamore@852 2606 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 2607 else
mcimadamore@1218 2608 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 2609 }
mcimadamore@852 2610 });
mcimadamore@852 2611 }
mcimadamore@852 2612 }
mcimadamore@852 2613
duke@1 2614 /* *************************************************************************
duke@1 2615 * Check for recursive annotation elements.
duke@1 2616 **************************************************************************/
duke@1 2617
duke@1 2618 /** Check for cycles in the graph of annotation elements.
duke@1 2619 */
duke@1 2620 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 2621 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 2622 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 2623 try {
duke@1 2624 tree.sym.flags_field |= LOCKED;
duke@1 2625 for (JCTree def : tree.defs) {
jjg@1127 2626 if (!def.hasTag(METHODDEF)) continue;
duke@1 2627 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 2628 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 2629 }
duke@1 2630 } finally {
duke@1 2631 tree.sym.flags_field &= ~LOCKED;
duke@1 2632 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 2633 }
duke@1 2634 }
duke@1 2635
duke@1 2636 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 2637 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 2638 return;
duke@1 2639 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 2640 log.error(pos, "cyclic.annotation.element");
duke@1 2641 return;
duke@1 2642 }
duke@1 2643 try {
duke@1 2644 tsym.flags_field |= LOCKED;
duke@1 2645 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 2646 Symbol s = e.sym;
duke@1 2647 if (s.kind != Kinds.MTH)
duke@1 2648 continue;
duke@1 2649 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 2650 }
duke@1 2651 } finally {
duke@1 2652 tsym.flags_field &= ~LOCKED;
duke@1 2653 tsym.flags_field |= ACYCLIC_ANN;
duke@1 2654 }
duke@1 2655 }
duke@1 2656
duke@1 2657 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
duke@1 2658 switch (type.tag) {
duke@1 2659 case TypeTags.CLASS:
duke@1 2660 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 2661 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 2662 break;
duke@1 2663 case TypeTags.ARRAY:
duke@1 2664 checkAnnotationResType(pos, types.elemtype(type));
duke@1 2665 break;
duke@1 2666 default:
duke@1 2667 break; // int etc
duke@1 2668 }
duke@1 2669 }
duke@1 2670
duke@1 2671 /* *************************************************************************
duke@1 2672 * Check for cycles in the constructor call graph.
duke@1 2673 **************************************************************************/
duke@1 2674
duke@1 2675 /** Check for cycles in the graph of constructors calling other
duke@1 2676 * constructors.
duke@1 2677 */
duke@1 2678 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 2679 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 2680
duke@1 2681 // enter each constructor this-call into the map
duke@1 2682 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 2683 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 2684 if (app == null) continue;
duke@1 2685 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 2686 if (TreeInfo.name(app.meth) == names._this) {
duke@1 2687 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 2688 } else {
duke@1 2689 meth.sym.flags_field |= ACYCLIC;
duke@1 2690 }
duke@1 2691 }
duke@1 2692
duke@1 2693 // Check for cycles in the map
duke@1 2694 Symbol[] ctors = new Symbol[0];
duke@1 2695 ctors = callMap.keySet().toArray(ctors);
duke@1 2696 for (Symbol caller : ctors) {
duke@1 2697 checkCyclicConstructor(tree, caller, callMap);
duke@1 2698 }
duke@1 2699 }
duke@1 2700
duke@1 2701 /** Look in the map to see if the given constructor is part of a
duke@1 2702 * call cycle.
duke@1 2703 */
duke@1 2704 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 2705 Map<Symbol,Symbol> callMap) {
duke@1 2706 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 2707 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 2708 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 2709 "recursive.ctor.invocation");
duke@1 2710 } else {
duke@1 2711 ctor.flags_field |= LOCKED;
duke@1 2712 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 2713 ctor.flags_field &= ~LOCKED;
duke@1 2714 }
duke@1 2715 ctor.flags_field |= ACYCLIC;
duke@1 2716 }
duke@1 2717 }
duke@1 2718
duke@1 2719 /* *************************************************************************
duke@1 2720 * Miscellaneous
duke@1 2721 **************************************************************************/
duke@1 2722
duke@1 2723 /**
duke@1 2724 * Return the opcode of the operator but emit an error if it is an
duke@1 2725 * error.
duke@1 2726 * @param pos position for error reporting.
duke@1 2727 * @param operator an operator
duke@1 2728 * @param tag a tree tag
duke@1 2729 * @param left type of left hand side
duke@1 2730 * @param right type of right hand side
duke@1 2731 */
duke@1 2732 int checkOperator(DiagnosticPosition pos,
duke@1 2733 OperatorSymbol operator,
jjg@1127 2734 JCTree.Tag tag,
duke@1 2735 Type left,
duke@1 2736 Type right) {
duke@1 2737 if (operator.opcode == ByteCodes.error) {
duke@1 2738 log.error(pos,
mcimadamore@853 2739 "operator.cant.be.applied.1",
duke@1 2740 treeinfo.operatorName(tag),
mcimadamore@853 2741 left, right);
duke@1 2742 }
duke@1 2743 return operator.opcode;
duke@1 2744 }
duke@1 2745
duke@1 2746
duke@1 2747 /**
duke@1 2748 * Check for division by integer constant zero
duke@1 2749 * @param pos Position for error reporting.
duke@1 2750 * @param operator The operator for the expression
duke@1 2751 * @param operand The right hand operand for the expression
duke@1 2752 */
duke@1 2753 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 2754 if (operand.constValue() != null
mcimadamore@795 2755 && lint.isEnabled(LintCategory.DIVZERO)
duke@1 2756 && operand.tag <= LONG
duke@1 2757 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 2758 int opc = ((OperatorSymbol)operator).opcode;
duke@1 2759 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 2760 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 2761 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 2762 }
duke@1 2763 }
duke@1 2764 }
duke@1 2765
duke@1 2766 /**
duke@1 2767 * Check for empty statements after if
duke@1 2768 */
duke@1 2769 void checkEmptyIf(JCIf tree) {
jjg@1127 2770 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 2771 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 2772 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 2773 }
duke@1 2774
duke@1 2775 /** Check that symbol is unique in given scope.
duke@1 2776 * @param pos Position for error reporting.
duke@1 2777 * @param sym The symbol.
duke@1 2778 * @param s The scope.
duke@1 2779 */
duke@1 2780 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2781 if (sym.type.isErroneous())
duke@1 2782 return true;
duke@1 2783 if (sym.owner.name == names.any) return false;
duke@1 2784 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 2785 if (sym != e.sym &&
mcimadamore@858 2786 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 2787 sym.kind == e.sym.kind &&
mcimadamore@858 2788 sym.name != names.error &&
mcimadamore@858 2789 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 2790 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 2791 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 2792 return true;
mcimadamore@907 2793 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 2794 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 2795 sym.flags_field |= CLASH;
mcimadamore@844 2796 return true;
mcimadamore@844 2797 } else {
duke@1 2798 duplicateError(pos, e.sym);
mcimadamore@844 2799 return false;
mcimadamore@844 2800 }
duke@1 2801 }
duke@1 2802 }
duke@1 2803 return true;
duke@1 2804 }
mcimadamore@844 2805
mcimadamore@858 2806 /** Report duplicate declaration error.
mcimadamore@858 2807 */
mcimadamore@858 2808 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 2809 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 2810 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 2811 }
mcimadamore@858 2812 }
duke@1 2813
duke@1 2814 /** Check that single-type import is not already imported or top-level defined,
duke@1 2815 * but make an exception for two single-type imports which denote the same type.
duke@1 2816 * @param pos Position for error reporting.
duke@1 2817 * @param sym The symbol.
duke@1 2818 * @param s The scope
duke@1 2819 */
duke@1 2820 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2821 return checkUniqueImport(pos, sym, s, false);
duke@1 2822 }
duke@1 2823
duke@1 2824 /** Check that static single-type import is not already imported or top-level defined,
duke@1 2825 * but make an exception for two single-type imports which denote the same type.
duke@1 2826 * @param pos Position for error reporting.
duke@1 2827 * @param sym The symbol.
duke@1 2828 * @param s The scope
duke@1 2829 * @param staticImport Whether or not this was a static import
duke@1 2830 */
duke@1 2831 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2832 return checkUniqueImport(pos, sym, s, true);
duke@1 2833 }
duke@1 2834
duke@1 2835 /** Check that single-type import is not already imported or top-level defined,
duke@1 2836 * but make an exception for two single-type imports which denote the same type.
duke@1 2837 * @param pos Position for error reporting.
duke@1 2838 * @param sym The symbol.
duke@1 2839 * @param s The scope.
duke@1 2840 * @param staticImport Whether or not this was a static import
duke@1 2841 */
duke@1 2842 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 2843 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 2844 // is encountered class entered via a class declaration?
duke@1 2845 boolean isClassDecl = e.scope == s;
duke@1 2846 if ((isClassDecl || sym != e.sym) &&
duke@1 2847 sym.kind == e.sym.kind &&
duke@1 2848 sym.name != names.error) {
duke@1 2849 if (!e.sym.type.isErroneous()) {
duke@1 2850 String what = e.sym.toString();
duke@1 2851 if (!isClassDecl) {
duke@1 2852 if (staticImport)
duke@1 2853 log.error(pos, "already.defined.static.single.import", what);
duke@1 2854 else
duke@1 2855 log.error(pos, "already.defined.single.import", what);
duke@1 2856 }
duke@1 2857 else if (sym != e.sym)
duke@1 2858 log.error(pos, "already.defined.this.unit", what);
duke@1 2859 }
duke@1 2860 return false;
duke@1 2861 }
duke@1 2862 }
duke@1 2863 return true;
duke@1 2864 }
duke@1 2865
duke@1 2866 /** Check that a qualified name is in canonical form (for import decls).
duke@1 2867 */
duke@1 2868 public void checkCanonical(JCTree tree) {
duke@1 2869 if (!isCanonical(tree))
duke@1 2870 log.error(tree.pos(), "import.requires.canonical",
duke@1 2871 TreeInfo.symbol(tree));
duke@1 2872 }
duke@1 2873 // where
duke@1 2874 private boolean isCanonical(JCTree tree) {
jjg@1127 2875 while (tree.hasTag(SELECT)) {
duke@1 2876 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 2877 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 2878 return false;
duke@1 2879 tree = s.selected;
duke@1 2880 }
duke@1 2881 return true;
duke@1 2882 }
duke@1 2883
duke@1 2884 private class ConversionWarner extends Warner {
mcimadamore@795 2885 final String uncheckedKey;
duke@1 2886 final Type found;
duke@1 2887 final Type expected;
mcimadamore@795 2888 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 2889 super(pos);
mcimadamore@795 2890 this.uncheckedKey = uncheckedKey;
duke@1 2891 this.found = found;
duke@1 2892 this.expected = expected;
duke@1 2893 }
duke@1 2894
jjg@398 2895 @Override
mcimadamore@795 2896 public void warn(LintCategory lint) {
duke@1 2897 boolean warned = this.warned;
mcimadamore@795 2898 super.warn(lint);
duke@1 2899 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 2900 switch (lint) {
mcimadamore@795 2901 case UNCHECKED:
mcimadamore@795 2902 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 2903 break;
mcimadamore@795 2904 case VARARGS:
mcimadamore@795 2905 if (method != null &&
mcimadamore@795 2906 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 2907 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 2908 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 2909 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 2910 }
mcimadamore@795 2911 break;
mcimadamore@795 2912 default:
mcimadamore@795 2913 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 2914 }
duke@1 2915 }
duke@1 2916 }
duke@1 2917
duke@1 2918 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2919 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 2920 }
duke@1 2921
duke@1 2922 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2923 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 2924 }
duke@1 2925 }

mercurial