src/share/classes/com/sun/tools/javac/comp/Check.java

Fri, 02 May 2014 01:25:26 +0100

author
vromero
date
Fri, 02 May 2014 01:25:26 +0100
changeset 2382
14979dd5e034
parent 2250
66570bfdbdd7
child 2384
327122b01a9e
permissions
-rw-r--r--

8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
Reviewed-by: dlsmith, jjg

duke@1 1 /*
jfranck@2250 2 * Copyright (c) 1999, 2014, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
jjg@1521 29
ohrstrom@1384 30 import javax.tools.JavaFileManager;
duke@1 31
duke@1 32 import com.sun.tools.javac.code.*;
jlahoda@2111 33 import com.sun.tools.javac.code.Attribute.Compound;
duke@1 34 import com.sun.tools.javac.jvm.*;
duke@1 35 import com.sun.tools.javac.tree.*;
duke@1 36 import com.sun.tools.javac.util.*;
duke@1 37 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 38 import com.sun.tools.javac.util.List;
duke@1 39
duke@1 40 import com.sun.tools.javac.code.Lint;
duke@1 41 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 42 import com.sun.tools.javac.code.Type.*;
duke@1 43 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 44 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 45 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1550 46 import com.sun.tools.javac.comp.Infer.FreeTypeListener;
mcimadamore@1510 47 import com.sun.tools.javac.tree.JCTree.*;
mcimadamore@1510 48 import com.sun.tools.javac.tree.JCTree.JCPolyExpression.*;
duke@1 49
duke@1 50 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 51 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 52 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 53 import static com.sun.tools.javac.code.Kinds.*;
jjg@1374 54 import static com.sun.tools.javac.code.TypeTag.*;
jjg@1374 55 import static com.sun.tools.javac.code.TypeTag.WILDCARD;
duke@1 56
jjg@1127 57 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 58
duke@1 59 /** Type checking helper class for the attribution phase.
duke@1 60 *
jjg@581 61 * <p><b>This is NOT part of any supported API.
jjg@581 62 * If you write code that depends on this, you do so at your own risk.
duke@1 63 * This code and its internal interfaces are subject to change or
duke@1 64 * deletion without notice.</b>
duke@1 65 */
duke@1 66 public class Check {
duke@1 67 protected static final Context.Key<Check> checkKey =
duke@1 68 new Context.Key<Check>();
duke@1 69
jjg@113 70 private final Names names;
duke@1 71 private final Log log;
mcimadamore@1219 72 private final Resolve rs;
duke@1 73 private final Symtab syms;
mcimadamore@690 74 private final Enter enter;
mcimadamore@1347 75 private final DeferredAttr deferredAttr;
duke@1 76 private final Infer infer;
duke@1 77 private final Types types;
mcimadamore@89 78 private final JCDiagnostic.Factory diags;
mcimadamore@359 79 private boolean warnOnSyntheticConflicts;
jjg@576 80 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 81 private boolean enableSunApiLintControl;
duke@1 82 private final TreeInfo treeinfo;
ohrstrom@1384 83 private final JavaFileManager fileManager;
jjg@1569 84 private final Profile profile;
duke@1 85
duke@1 86 // The set of lint options currently in effect. It is initialized
duke@1 87 // from the context, and then is set/reset as needed by Attr as it
duke@1 88 // visits all the various parts of the trees during attribution.
duke@1 89 private Lint lint;
duke@1 90
mcimadamore@795 91 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 92 // Attr as it visits new method declarations.
mcimadamore@795 93 private MethodSymbol method;
mcimadamore@795 94
duke@1 95 public static Check instance(Context context) {
duke@1 96 Check instance = context.get(checkKey);
duke@1 97 if (instance == null)
duke@1 98 instance = new Check(context);
duke@1 99 return instance;
duke@1 100 }
duke@1 101
duke@1 102 protected Check(Context context) {
duke@1 103 context.put(checkKey, this);
duke@1 104
jjg@113 105 names = Names.instance(context);
jjg@1521 106 dfltTargetMeta = new Name[] { names.PACKAGE, names.TYPE,
jjg@1521 107 names.FIELD, names.METHOD, names.CONSTRUCTOR,
jjg@1521 108 names.ANNOTATION_TYPE, names.LOCAL_VARIABLE, names.PARAMETER};
duke@1 109 log = Log.instance(context);
mcimadamore@1219 110 rs = Resolve.instance(context);
duke@1 111 syms = Symtab.instance(context);
mcimadamore@690 112 enter = Enter.instance(context);
mcimadamore@1347 113 deferredAttr = DeferredAttr.instance(context);
duke@1 114 infer = Infer.instance(context);
jjg@1569 115 types = Types.instance(context);
mcimadamore@89 116 diags = JCDiagnostic.Factory.instance(context);
duke@1 117 Options options = Options.instance(context);
duke@1 118 lint = Lint.instance(context);
duke@1 119 treeinfo = TreeInfo.instance(context);
ohrstrom@1384 120 fileManager = context.get(JavaFileManager.class);
duke@1 121
duke@1 122 Source source = Source.instance(context);
duke@1 123 allowGenerics = source.allowGenerics();
mcimadamore@1219 124 allowVarargs = source.allowVarargs();
duke@1 125 allowAnnotations = source.allowAnnotations();
jjg@398 126 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 127 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
mcimadamore@1393 128 allowDefaultMethods = source.allowDefaultMethods();
mcimadamore@1415 129 allowStrictMethodClashCheck = source.allowStrictMethodClashCheck();
jjg@1157 130 complexInference = options.isSet("complexinference");
jjg@700 131 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 132 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 133 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 134
jjg@398 135 Target target = Target.instance(context);
jjg@398 136 syntheticNameChar = target.syntheticNameChar();
jjg@398 137
jjg@1569 138 profile = Profile.instance(context);
jjg@1569 139
duke@1 140 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 141 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 142 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 143 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 144
jjg@60 145 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 146 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 147 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 148 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 149 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 150 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 151
jlahoda@2028 152 deferredLintHandler = DeferredLintHandler.instance(context);
duke@1 153 }
duke@1 154
duke@1 155 /** Switch: generics enabled?
duke@1 156 */
duke@1 157 boolean allowGenerics;
duke@1 158
mcimadamore@1219 159 /** Switch: varargs enabled?
mcimadamore@1219 160 */
mcimadamore@1219 161 boolean allowVarargs;
mcimadamore@1219 162
duke@1 163 /** Switch: annotations enabled?
duke@1 164 */
duke@1 165 boolean allowAnnotations;
duke@1 166
jjg@398 167 /** Switch: covariant returns enabled?
jjg@398 168 */
jjg@398 169 boolean allowCovariantReturns;
jjg@398 170
mcimadamore@795 171 /** Switch: simplified varargs enabled?
mcimadamore@795 172 */
mcimadamore@795 173 boolean allowSimplifiedVarargs;
mcimadamore@795 174
mcimadamore@1393 175 /** Switch: default methods enabled?
mcimadamore@1393 176 */
mcimadamore@1393 177 boolean allowDefaultMethods;
mcimadamore@1393 178
mcimadamore@1393 179 /** Switch: should unrelated return types trigger a method clash?
mcimadamore@1393 180 */
mcimadamore@1393 181 boolean allowStrictMethodClashCheck;
mcimadamore@1393 182
duke@1 183 /** Switch: -complexinference option set?
duke@1 184 */
duke@1 185 boolean complexInference;
duke@1 186
jjg@398 187 /** Character for synthetic names
jjg@398 188 */
jjg@398 189 char syntheticNameChar;
jjg@398 190
duke@1 191 /** A table mapping flat names of all compiled classes in this run to their
duke@1 192 * symbols; maintained from outside.
duke@1 193 */
duke@1 194 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 195
duke@1 196 /** A handler for messages about deprecated usage.
duke@1 197 */
duke@1 198 private MandatoryWarningHandler deprecationHandler;
duke@1 199
duke@1 200 /** A handler for messages about unchecked or unsafe usage.
duke@1 201 */
duke@1 202 private MandatoryWarningHandler uncheckedHandler;
duke@1 203
jjg@582 204 /** A handler for messages about using proprietary API.
jjg@377 205 */
jjg@377 206 private MandatoryWarningHandler sunApiHandler;
duke@1 207
mcimadamore@852 208 /** A handler for deferred lint warnings.
mcimadamore@852 209 */
mcimadamore@852 210 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 211
duke@1 212 /* *************************************************************************
duke@1 213 * Errors and Warnings
duke@1 214 **************************************************************************/
duke@1 215
duke@1 216 Lint setLint(Lint newLint) {
duke@1 217 Lint prev = lint;
duke@1 218 lint = newLint;
duke@1 219 return prev;
duke@1 220 }
duke@1 221
mcimadamore@795 222 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 223 MethodSymbol prev = method;
mcimadamore@795 224 method = newMethod;
mcimadamore@795 225 return prev;
mcimadamore@795 226 }
mcimadamore@795 227
duke@1 228 /** Warn about deprecated symbol.
duke@1 229 * @param pos Position to be used for error reporting.
duke@1 230 * @param sym The deprecated symbol.
duke@1 231 */
duke@1 232 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 233 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 234 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 235 }
duke@1 236
duke@1 237 /** Warn about unchecked operation.
duke@1 238 * @param pos Position to be used for error reporting.
duke@1 239 * @param msg A string describing the problem.
duke@1 240 */
duke@1 241 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 242 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 243 uncheckedHandler.report(pos, msg, args);
duke@1 244 }
duke@1 245
mcimadamore@580 246 /** Warn about unsafe vararg method decl.
mcimadamore@580 247 * @param pos Position to be used for error reporting.
mcimadamore@580 248 */
mcimadamore@795 249 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 250 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 251 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 252 }
mcimadamore@580 253
jjg@582 254 /** Warn about using proprietary API.
jjg@377 255 * @param pos Position to be used for error reporting.
jjg@377 256 * @param msg A string describing the problem.
jjg@377 257 */
jjg@377 258 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 259 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 260 sunApiHandler.report(pos, msg, args);
jjg@377 261 }
jjg@377 262
jjg@505 263 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 264 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 265 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 266 }
jjg@505 267
duke@1 268 /**
duke@1 269 * Report any deferred diagnostics.
duke@1 270 */
duke@1 271 public void reportDeferredDiagnostics() {
duke@1 272 deprecationHandler.reportDeferredDiagnostic();
duke@1 273 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 274 sunApiHandler.reportDeferredDiagnostic();
duke@1 275 }
duke@1 276
duke@1 277
duke@1 278 /** Report a failure to complete a class.
duke@1 279 * @param pos Position to be used for error reporting.
duke@1 280 * @param ex The failure to report.
duke@1 281 */
duke@1 282 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
mcimadamore@1613 283 log.error(JCDiagnostic.DiagnosticFlag.NON_DEFERRABLE, pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 284 if (ex instanceof ClassReader.BadClassFile
jjg@576 285 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 286 else return syms.errType;
duke@1 287 }
duke@1 288
duke@1 289 /** Report an error that wrong type tag was found.
duke@1 290 * @param pos Position to be used for error reporting.
duke@1 291 * @param required An internationalized string describing the type tag
duke@1 292 * required.
duke@1 293 * @param found The type that was found.
duke@1 294 */
duke@1 295 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 296 // this error used to be raised by the parser,
jrose@267 297 // but has been delayed to this point:
jjg@1374 298 if (found instanceof Type && ((Type)found).hasTag(VOID)) {
jrose@267 299 log.error(pos, "illegal.start.of.type");
jrose@267 300 return syms.errType;
jrose@267 301 }
duke@1 302 log.error(pos, "type.found.req", found, required);
jjg@110 303 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 304 }
duke@1 305
duke@1 306 /** Report an error that symbol cannot be referenced before super
duke@1 307 * has been called.
duke@1 308 * @param pos Position to be used for error reporting.
duke@1 309 * @param sym The referenced symbol.
duke@1 310 */
duke@1 311 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 312 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 313 }
duke@1 314
duke@1 315 /** Report duplicate declaration error.
duke@1 316 */
duke@1 317 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 318 if (!sym.type.isErroneous()) {
mcimadamore@1085 319 Symbol location = sym.location();
mcimadamore@1085 320 if (location.kind == MTH &&
mcimadamore@1085 321 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 322 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 323 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 324 sym.location().enclClass());
mcimadamore@1085 325 } else {
mcimadamore@1085 326 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 327 kindName(sym.location()), sym.location());
mcimadamore@1085 328 }
duke@1 329 }
duke@1 330 }
duke@1 331
duke@1 332 /** Report array/varargs duplicate declaration
duke@1 333 */
duke@1 334 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 335 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 336 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 337 }
duke@1 338 }
duke@1 339
duke@1 340 /* ************************************************************************
duke@1 341 * duplicate declaration checking
duke@1 342 *************************************************************************/
duke@1 343
duke@1 344 /** Check that variable does not hide variable with same name in
duke@1 345 * immediately enclosing local scope.
duke@1 346 * @param pos Position for error reporting.
duke@1 347 * @param v The symbol.
duke@1 348 * @param s The scope.
duke@1 349 */
duke@1 350 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 351 if (s.next != null) {
duke@1 352 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 353 e.scope != null && e.sym.owner == v.owner;
duke@1 354 e = e.next()) {
duke@1 355 if (e.sym.kind == VAR &&
duke@1 356 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 357 v.name != names.error) {
duke@1 358 duplicateError(pos, e.sym);
duke@1 359 return;
duke@1 360 }
duke@1 361 }
duke@1 362 }
duke@1 363 }
duke@1 364
duke@1 365 /** Check that a class or interface does not hide a class or
duke@1 366 * interface with same name in immediately enclosing local scope.
duke@1 367 * @param pos Position for error reporting.
duke@1 368 * @param c The symbol.
duke@1 369 * @param s The scope.
duke@1 370 */
duke@1 371 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 372 if (s.next != null) {
duke@1 373 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 374 e.scope != null && e.sym.owner == c.owner;
duke@1 375 e = e.next()) {
jjg@1374 376 if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) &&
duke@1 377 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 378 c.name != names.error) {
duke@1 379 duplicateError(pos, e.sym);
duke@1 380 return;
duke@1 381 }
duke@1 382 }
duke@1 383 }
duke@1 384 }
duke@1 385
duke@1 386 /** Check that class does not have the same name as one of
duke@1 387 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 388 * return true if class is unique in its enclosing scope.
duke@1 389 * @param pos Position for error reporting.
duke@1 390 * @param name The class name.
duke@1 391 * @param s The enclosing scope.
duke@1 392 */
duke@1 393 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 394 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 395 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 396 duplicateError(pos, e.sym);
duke@1 397 return false;
duke@1 398 }
duke@1 399 }
duke@1 400 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 401 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 402 duplicateError(pos, sym);
duke@1 403 return true;
duke@1 404 }
duke@1 405 }
duke@1 406 return true;
duke@1 407 }
duke@1 408
duke@1 409 /* *************************************************************************
duke@1 410 * Class name generation
duke@1 411 **************************************************************************/
duke@1 412
duke@1 413 /** Return name of local class.
jjg@1358 414 * This is of the form {@code <enclClass> $ n <classname> }
duke@1 415 * where
duke@1 416 * enclClass is the flat name of the enclosing class,
duke@1 417 * classname is the simple name of the local class
duke@1 418 */
duke@1 419 Name localClassName(ClassSymbol c) {
duke@1 420 for (int i=1; ; i++) {
duke@1 421 Name flatname = names.
duke@1 422 fromString("" + c.owner.enclClass().flatname +
jjg@398 423 syntheticNameChar + i +
duke@1 424 c.name);
duke@1 425 if (compiled.get(flatname) == null) return flatname;
duke@1 426 }
duke@1 427 }
duke@1 428
duke@1 429 /* *************************************************************************
duke@1 430 * Type Checking
duke@1 431 **************************************************************************/
duke@1 432
mcimadamore@1238 433 /**
mcimadamore@1238 434 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 435 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 436 * vary significantly.
mcimadamore@1238 437 */
mcimadamore@1348 438 public interface CheckContext {
mcimadamore@1238 439 /**
mcimadamore@1238 440 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 441 */
mcimadamore@1238 442 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 443 /**
mcimadamore@1238 444 * Report a check error
mcimadamore@1238 445 */
mcimadamore@1296 446 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 447 /**
mcimadamore@1238 448 * Obtain a warner for this check context
mcimadamore@1238 449 */
mcimadamore@1238 450 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 451
mcimadamore@1337 452 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 453
mcimadamore@1347 454 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1238 455 }
mcimadamore@1238 456
mcimadamore@1238 457 /**
mcimadamore@1238 458 * This class represent a check context that is nested within another check
mcimadamore@1238 459 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 460 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 461 * the forwarding pattern.
mcimadamore@1238 462 */
mcimadamore@1238 463 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 464 CheckContext enclosingContext;
mcimadamore@1238 465
mcimadamore@1238 466 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 467 this.enclosingContext = enclosingContext;
mcimadamore@1238 468 }
mcimadamore@1238 469
mcimadamore@1238 470 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 471 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 472 }
mcimadamore@1238 473
mcimadamore@1296 474 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 475 enclosingContext.report(pos, details);
mcimadamore@1238 476 }
mcimadamore@1238 477
mcimadamore@1238 478 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 479 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 480 }
mcimadamore@1337 481
mcimadamore@1337 482 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 483 return enclosingContext.inferenceContext();
mcimadamore@1337 484 }
mcimadamore@1347 485
mcimadamore@1347 486 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 487 return enclosingContext.deferredAttrContext();
mcimadamore@1347 488 }
mcimadamore@1238 489 }
mcimadamore@1238 490
mcimadamore@1238 491 /**
mcimadamore@1238 492 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 493 */
mcimadamore@1238 494 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 495 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 496 log.error(pos, "prob.found.req", details);
mcimadamore@1238 497 }
mcimadamore@1238 498 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 499 return types.isAssignable(found, req, warn);
mcimadamore@1238 500 }
mcimadamore@1238 501
mcimadamore@1238 502 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 503 return convertWarner(pos, found, req);
mcimadamore@1238 504 }
mcimadamore@1337 505
mcimadamore@1337 506 public InferenceContext inferenceContext() {
mcimadamore@1337 507 return infer.emptyContext;
mcimadamore@1337 508 }
mcimadamore@1347 509
mcimadamore@1347 510 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 511 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 512 }
vromero@2382 513
vromero@2382 514 @Override
vromero@2382 515 public String toString() {
vromero@2382 516 return "CheckContext: basicHandler";
vromero@2382 517 }
mcimadamore@1238 518 };
mcimadamore@1238 519
duke@1 520 /** Check that a given type is assignable to a given proto-type.
duke@1 521 * If it is, return the type, otherwise return errType.
duke@1 522 * @param pos Position to be used for error reporting.
duke@1 523 * @param found The type that was found.
duke@1 524 * @param req The type that was required.
duke@1 525 */
duke@1 526 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 527 return checkType(pos, found, req, basicHandler);
darcy@609 528 }
darcy@609 529
mcimadamore@1337 530 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 531 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 532 if (inferenceContext.free(req)) {
mcimadamore@1337 533 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 534 @Override
mcimadamore@1337 535 public void typesInferred(InferenceContext inferenceContext) {
vromero@2157 536 checkType(pos, inferenceContext.asInstType(found), inferenceContext.asInstType(req), checkContext);
mcimadamore@1337 537 }
mcimadamore@1337 538 });
mcimadamore@1337 539 }
jjg@1374 540 if (req.hasTag(ERROR))
duke@1 541 return req;
jjg@1374 542 if (req.hasTag(NONE))
duke@1 543 return found;
mcimadamore@1238 544 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 545 return found;
mcimadamore@1238 546 } else {
vromero@1826 547 if (found.isNumeric() && req.isNumeric()) {
mcimadamore@1296 548 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 549 return types.createErrorType(found);
mcimadamore@1238 550 }
mcimadamore@1296 551 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 552 return types.createErrorType(found);
duke@1 553 }
duke@1 554 }
duke@1 555
duke@1 556 /** Check that a given type can be cast to a given target type.
duke@1 557 * Return the result of the cast.
duke@1 558 * @param pos Position to be used for error reporting.
duke@1 559 * @param found The type that is being cast.
duke@1 560 * @param req The target type of the cast.
duke@1 561 */
duke@1 562 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 563 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 564 }
mcimadamore@1238 565 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 566 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 567 return req;
duke@1 568 } else {
mcimadamore@1296 569 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 570 return types.createErrorType(found);
duke@1 571 }
duke@1 572 }
mcimadamore@1237 573
mcimadamore@1237 574 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 575 * The problem should only be reported for non-292 cast
mcimadamore@1237 576 */
jlahoda@2028 577 public void checkRedundantCast(Env<AttrContext> env, final JCTypeCast tree) {
jlahoda@2028 578 if (!tree.type.isErroneous()
mcimadamore@1348 579 && types.isSameType(tree.expr.type, tree.clazz.type)
jjg@1521 580 && !(ignoreAnnotatedCasts && TreeInfo.containsTypeAnnotation(tree.clazz))
mcimadamore@1348 581 && !is292targetTypeCast(tree)) {
jlahoda@2028 582 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
jlahoda@2028 583 @Override
jlahoda@2028 584 public void report() {
jlahoda@2028 585 if (lint.isEnabled(Lint.LintCategory.CAST))
jlahoda@2028 586 log.warning(Lint.LintCategory.CAST,
jlahoda@2028 587 tree.pos(), "redundant.cast", tree.expr.type);
jlahoda@2028 588 }
jlahoda@2028 589 });
mcimadamore@1237 590 }
mcimadamore@1237 591 }
mcimadamore@1237 592 //where
jjg@1521 593 private boolean is292targetTypeCast(JCTypeCast tree) {
jjg@1521 594 boolean is292targetTypeCast = false;
jjg@1521 595 JCExpression expr = TreeInfo.skipParens(tree.expr);
jjg@1521 596 if (expr.hasTag(APPLY)) {
jjg@1521 597 JCMethodInvocation apply = (JCMethodInvocation)expr;
jjg@1521 598 Symbol sym = TreeInfo.symbol(apply.meth);
jjg@1521 599 is292targetTypeCast = sym != null &&
jjg@1521 600 sym.kind == MTH &&
jjg@1521 601 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 602 }
jjg@1521 603 return is292targetTypeCast;
jjg@1521 604 }
mcimadamore@1237 605
jjg@1521 606 private static final boolean ignoreAnnotatedCasts = true;
duke@1 607
duke@1 608 /** Check that a type is within some bounds.
duke@1 609 *
jjg@1358 610 * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
duke@1 611 * type argument.
duke@1 612 * @param a The type that should be bounded by bs.
jjg@1358 613 * @param bound The bound.
duke@1 614 */
mcimadamore@1216 615 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 616 if (a.isUnbound()) {
mcimadamore@821 617 return true;
jjg@1374 618 } else if (!a.hasTag(WILDCARD)) {
mcimadamore@154 619 a = types.upperBound(a);
mcimadamore@1216 620 return types.isSubtype(a, bound);
mcimadamore@154 621 } else if (a.isExtendsBound()) {
mcimadamore@1415 622 return types.isCastable(bound, types.upperBound(a), types.noWarnings);
mcimadamore@154 623 } else if (a.isSuperBound()) {
mcimadamore@1216 624 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 625 }
mcimadamore@821 626 return true;
mcimadamore@154 627 }
duke@1 628
duke@1 629 /** Check that type is different from 'void'.
duke@1 630 * @param pos Position to be used for error reporting.
duke@1 631 * @param t The type to be checked.
duke@1 632 */
duke@1 633 Type checkNonVoid(DiagnosticPosition pos, Type t) {
jjg@1374 634 if (t.hasTag(VOID)) {
duke@1 635 log.error(pos, "void.not.allowed.here");
jjg@110 636 return types.createErrorType(t);
duke@1 637 } else {
duke@1 638 return t;
duke@1 639 }
duke@1 640 }
duke@1 641
mcimadamore@1496 642 Type checkClassOrArrayType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 643 if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
mcimadamore@1496 644 return typeTagError(pos,
mcimadamore@1496 645 diags.fragment("type.req.class.array"),
mcimadamore@1496 646 asTypeParam(t));
mcimadamore@1496 647 } else {
mcimadamore@1496 648 return t;
mcimadamore@1496 649 }
mcimadamore@1496 650 }
mcimadamore@1496 651
duke@1 652 /** Check that type is a class or interface type.
duke@1 653 * @param pos Position to be used for error reporting.
duke@1 654 * @param t The type to be checked.
duke@1 655 */
duke@1 656 Type checkClassType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 657 if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) {
duke@1 658 return typeTagError(pos,
mcimadamore@89 659 diags.fragment("type.req.class"),
mcimadamore@1496 660 asTypeParam(t));
mcimadamore@1496 661 } else {
duke@1 662 return t;
mcimadamore@1496 663 }
duke@1 664 }
mcimadamore@1496 665 //where
mcimadamore@1496 666 private Object asTypeParam(Type t) {
mcimadamore@1496 667 return (t.hasTag(TYPEVAR))
mcimadamore@1496 668 ? diags.fragment("type.parameter", t)
mcimadamore@1496 669 : t;
mcimadamore@1496 670 }
duke@1 671
mcimadamore@1352 672 /** Check that type is a valid qualifier for a constructor reference expression
mcimadamore@1352 673 */
mcimadamore@1352 674 Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 675 t = checkClassOrArrayType(pos, t);
jjg@1374 676 if (t.hasTag(CLASS)) {
mcimadamore@1352 677 if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
mcimadamore@1627 678 log.error(pos, "abstract.cant.be.instantiated", t.tsym);
mcimadamore@1352 679 t = types.createErrorType(t);
mcimadamore@1352 680 } else if ((t.tsym.flags() & ENUM) != 0) {
mcimadamore@1352 681 log.error(pos, "enum.cant.be.instantiated");
mcimadamore@1352 682 t = types.createErrorType(t);
mcimadamore@1627 683 } else {
mcimadamore@1627 684 t = checkClassType(pos, t, true);
mcimadamore@1627 685 }
mcimadamore@1627 686 } else if (t.hasTag(ARRAY)) {
mcimadamore@1627 687 if (!types.isReifiable(((ArrayType)t).elemtype)) {
mcimadamore@1627 688 log.error(pos, "generic.array.creation");
mcimadamore@1627 689 t = types.createErrorType(t);
mcimadamore@1352 690 }
mcimadamore@1352 691 }
mcimadamore@1352 692 return t;
mcimadamore@1352 693 }
mcimadamore@1352 694
duke@1 695 /** Check that type is a class or interface type.
duke@1 696 * @param pos Position to be used for error reporting.
duke@1 697 * @param t The type to be checked.
duke@1 698 * @param noBounds True if type bounds are illegal here.
duke@1 699 */
duke@1 700 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 701 t = checkClassType(pos, t);
duke@1 702 if (noBounds && t.isParameterized()) {
duke@1 703 List<Type> args = t.getTypeArguments();
duke@1 704 while (args.nonEmpty()) {
jjg@1374 705 if (args.head.hasTag(WILDCARD))
duke@1 706 return typeTagError(pos,
jjg@598 707 diags.fragment("type.req.exact"),
duke@1 708 args.head);
duke@1 709 args = args.tail;
duke@1 710 }
duke@1 711 }
duke@1 712 return t;
duke@1 713 }
duke@1 714
duke@1 715 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 716 * or a type variable.
duke@1 717 * @param pos Position to be used for error reporting.
duke@1 718 * @param t The type to be checked.
duke@1 719 */
duke@1 720 Type checkRefType(DiagnosticPosition pos, Type t) {
jjg@1374 721 if (t.isReference())
duke@1 722 return t;
jjg@1374 723 else
duke@1 724 return typeTagError(pos,
mcimadamore@89 725 diags.fragment("type.req.ref"),
duke@1 726 t);
duke@1 727 }
duke@1 728
jrose@267 729 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 730 * or a type variable.
jrose@267 731 * @param trees Original trees, used for error reporting.
jrose@267 732 * @param types The types to be checked.
jrose@267 733 */
jrose@267 734 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 735 List<JCExpression> tl = trees;
jrose@267 736 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 737 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 738 tl = tl.tail;
jrose@267 739 }
jrose@267 740 return types;
jrose@267 741 }
jrose@267 742
duke@1 743 /** Check that type is a null or reference type.
duke@1 744 * @param pos Position to be used for error reporting.
duke@1 745 * @param t The type to be checked.
duke@1 746 */
duke@1 747 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
vromero@1826 748 if (t.isReference() || t.hasTag(BOT))
duke@1 749 return t;
jjg@1374 750 else
duke@1 751 return typeTagError(pos,
mcimadamore@89 752 diags.fragment("type.req.ref"),
duke@1 753 t);
duke@1 754 }
duke@1 755
duke@1 756 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 757 * Return true if it doesn't.
duke@1 758 * @param pos Position to be used for error reporting.
duke@1 759 * @param flags The set of flags to be checked.
duke@1 760 * @param set1 Conflicting flags set #1.
duke@1 761 * @param set2 Conflicting flags set #2.
duke@1 762 */
duke@1 763 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 764 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 765 log.error(pos,
duke@1 766 "illegal.combination.of.modifiers",
mcimadamore@80 767 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 768 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 769 return false;
duke@1 770 } else
duke@1 771 return true;
duke@1 772 }
duke@1 773
mcimadamore@914 774 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 775 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 776 */
mcimadamore@914 777 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 778 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 779 t.isErroneous()) {
mcimadamore@914 780 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 781 } else if (tree.def != null) {
mcimadamore@914 782 log.error(tree.clazz.pos(),
mcimadamore@914 783 "cant.apply.diamond.1",
mcimadamore@914 784 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 785 return types.createErrorType(t);
mcimadamore@948 786 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 787 log.error(tree.clazz.pos(),
mcimadamore@914 788 "cant.apply.diamond.1",
mcimadamore@914 789 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 790 return types.createErrorType(t);
mcimadamore@993 791 } else if (tree.typeargs != null &&
mcimadamore@993 792 tree.typeargs.nonEmpty()) {
mcimadamore@993 793 log.error(tree.clazz.pos(),
mcimadamore@993 794 "cant.apply.diamond.1",
mcimadamore@993 795 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 796 return types.createErrorType(t);
mcimadamore@914 797 } else {
mcimadamore@914 798 return t;
mcimadamore@537 799 }
mcimadamore@537 800 }
mcimadamore@537 801
mcimadamore@795 802 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 803 MethodSymbol m = tree.sym;
mcimadamore@795 804 if (!allowSimplifiedVarargs) return;
mcimadamore@795 805 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 806 Type varargElemType = null;
mcimadamore@580 807 if (m.isVarArgs()) {
mcimadamore@795 808 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 809 }
mcimadamore@795 810 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 811 if (varargElemType != null) {
mcimadamore@795 812 log.error(tree,
mcimadamore@795 813 "varargs.invalid.trustme.anno",
mcimadamore@795 814 syms.trustMeType.tsym,
mcimadamore@795 815 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 816 } else {
mcimadamore@795 817 log.error(tree,
mcimadamore@795 818 "varargs.invalid.trustme.anno",
mcimadamore@795 819 syms.trustMeType.tsym,
mcimadamore@795 820 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 821 }
mcimadamore@795 822 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 823 types.isReifiable(varargElemType)) {
mcimadamore@795 824 warnUnsafeVararg(tree,
mcimadamore@795 825 "varargs.redundant.trustme.anno",
mcimadamore@795 826 syms.trustMeType.tsym,
mcimadamore@795 827 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 828 }
mcimadamore@795 829 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 830 !types.isReifiable(varargElemType)) {
mcimadamore@795 831 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 832 }
mcimadamore@580 833 }
mcimadamore@795 834 //where
mcimadamore@795 835 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 836 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 837 (s.isConstructor() ||
mcimadamore@795 838 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 839 }
mcimadamore@580 840
mcimadamore@1812 841 Type checkMethod(final Type mtype,
mcimadamore@1812 842 final Symbol sym,
mcimadamore@1812 843 final Env<AttrContext> env,
mcimadamore@1812 844 final List<JCExpression> argtrees,
mcimadamore@1812 845 final List<Type> argtypes,
mcimadamore@1812 846 final boolean useVarargs,
mcimadamore@1812 847 InferenceContext inferenceContext) {
mcimadamore@1219 848 // System.out.println("call : " + env.tree);
mcimadamore@1219 849 // System.out.println("method : " + owntype);
mcimadamore@1219 850 // System.out.println("actuals: " + argtypes);
mcimadamore@1812 851 if (inferenceContext.free(mtype)) {
mcimadamore@1812 852 inferenceContext.addFreeTypeListener(List.of(mtype), new FreeTypeListener() {
mcimadamore@1812 853 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1812 854 checkMethod(inferenceContext.asInstType(mtype), sym, env, argtrees, argtypes, useVarargs, inferenceContext);
mcimadamore@1812 855 }
mcimadamore@1812 856 });
mcimadamore@1812 857 return mtype;
mcimadamore@1812 858 }
mcimadamore@1812 859 Type owntype = mtype;
mcimadamore@1219 860 List<Type> formals = owntype.getParameterTypes();
kizune@1959 861 List<Type> nonInferred = sym.type.getParameterTypes();
kizune@1959 862 if (nonInferred.length() != formals.length()) nonInferred = formals;
mcimadamore@1219 863 Type last = useVarargs ? formals.last() : null;
kizune@1959 864 if (sym.name == names.init && sym.owner == syms.enumSym) {
kizune@1959 865 formals = formals.tail.tail;
kizune@1959 866 nonInferred = nonInferred.tail.tail;
kizune@1959 867 }
mcimadamore@1219 868 List<JCExpression> args = argtrees;
mcimadamore@1352 869 if (args != null) {
mcimadamore@1352 870 //this is null when type-checking a method reference
mcimadamore@1352 871 while (formals.head != last) {
mcimadamore@1219 872 JCTree arg = args.head;
kizune@1959 873 Warner warn = convertWarner(arg.pos(), arg.type, nonInferred.head);
mcimadamore@1352 874 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 875 args = args.tail;
mcimadamore@1352 876 formals = formals.tail;
kizune@1959 877 nonInferred = nonInferred.tail;
mcimadamore@1219 878 }
mcimadamore@1352 879 if (useVarargs) {
mcimadamore@1352 880 Type varArg = types.elemtype(last);
mcimadamore@1352 881 while (args.tail != null) {
mcimadamore@1352 882 JCTree arg = args.head;
mcimadamore@1352 883 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1352 884 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1352 885 args = args.tail;
mcimadamore@1352 886 }
mcimadamore@1904 887 } else if ((sym.flags() & (VARARGS | SIGNATURE_POLYMORPHIC)) == VARARGS &&
mcimadamore@1904 888 allowVarargs) {
mcimadamore@1352 889 // non-varargs call to varargs method
mcimadamore@1352 890 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1812 891 Type lastArg = argtypes.last();
mcimadamore@1352 892 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
kizune@1959 893 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1352 894 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
kizune@1959 895 types.elemtype(varParam), varParam);
mcimadamore@1352 896 }
mcimadamore@1219 897 }
mcimadamore@1219 898 if (useVarargs) {
mcimadamore@1219 899 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 900 if (!types.isReifiable(argtype) &&
kizune@1959 901 (!allowSimplifiedVarargs ||
kizune@1959 902 sym.attribute(syms.trustMeType.tsym) == null ||
kizune@1959 903 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 904 warnUnchecked(env.tree.pos(),
mcimadamore@1219 905 "unchecked.generic.array.creation",
mcimadamore@1219 906 argtype);
mcimadamore@1219 907 }
vromero@1820 908 if ((sym.baseSymbol().flags() & SIGNATURE_POLYMORPHIC) == 0) {
mcimadamore@1812 909 TreeInfo.setVarargsElement(env.tree, types.elemtype(argtype));
mcimadamore@1219 910 }
mcimadamore@1219 911 }
mcimadamore@1510 912 PolyKind pkind = (sym.type.hasTag(FORALL) &&
mcimadamore@1510 913 sym.type.getReturnType().containsAny(((ForAll)sym.type).tvars)) ?
mcimadamore@1510 914 PolyKind.POLY : PolyKind.STANDALONE;
mcimadamore@1510 915 TreeInfo.setPolyKind(env.tree, pkind);
mcimadamore@1219 916 return owntype;
mcimadamore@547 917 }
mcimadamore@1219 918 //where
kizune@1959 919 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
kizune@1959 920 if (types.isConvertible(actual, formal, warn))
kizune@1959 921 return;
kizune@1959 922
kizune@1959 923 if (formal.isCompound()
kizune@1959 924 && types.isSubtype(actual, types.supertype(formal))
kizune@1959 925 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
kizune@1959 926 return;
kizune@1959 927 }
mcimadamore@547 928
mcimadamore@821 929 /**
mcimadamore@821 930 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 931 * (see JLS 4.5)
mcimadamore@821 932 *
mcimadamore@821 933 * @param t class type to be checked
mcimadamore@821 934 * @return true if 't' is well-formed
mcimadamore@821 935 */
mcimadamore@821 936 public boolean checkValidGenericType(Type t) {
mcimadamore@821 937 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 938 }
mcimadamore@821 939 //WHERE
mcimadamore@821 940 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 941 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 942 List<Type> actuals = type.allparams();
mcimadamore@821 943 List<Type> args = type.getTypeArguments();
mcimadamore@821 944 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 945 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 946
mcimadamore@821 947 // For matching pairs of actual argument types `a' and
mcimadamore@821 948 // formal type parameters with declared bound `b' ...
mcimadamore@821 949 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 950 // exact type arguments needs to know their
mcimadamore@821 951 // bounds (for upper and lower bound
mcimadamore@1216 952 // calculations). So we create new bounds where
mcimadamore@1216 953 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 954 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 955 args = args.tail;
mcimadamore@821 956 forms = forms.tail;
mcimadamore@821 957 }
mcimadamore@821 958
mcimadamore@821 959 args = type.getTypeArguments();
mcimadamore@821 960 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 961 formals,
mcimadamore@821 962 types.capture(type).allparams());
mcimadamore@821 963 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 964 // Let the actual arguments know their bound
mcimadamore@821 965 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 966 args = args.tail;
mcimadamore@821 967 tvars_cap = tvars_cap.tail;
mcimadamore@821 968 }
mcimadamore@821 969
mcimadamore@821 970 args = type.getTypeArguments();
mcimadamore@1216 971 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 972
mcimadamore@1216 973 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 974 Type actual = args.head;
mcimadamore@854 975 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 976 !bounds.head.isErroneous() &&
mcimadamore@1216 977 !checkExtends(actual, bounds.head)) {
mcimadamore@821 978 return args.head;
mcimadamore@821 979 }
mcimadamore@821 980 args = args.tail;
mcimadamore@1216 981 bounds = bounds.tail;
mcimadamore@821 982 }
mcimadamore@821 983
mcimadamore@821 984 args = type.getTypeArguments();
mcimadamore@1216 985 bounds = bounds_buf.toList();
mcimadamore@821 986
mcimadamore@821 987 for (Type arg : types.capture(type).getTypeArguments()) {
jjg@1374 988 if (arg.hasTag(TYPEVAR) &&
mcimadamore@828 989 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 990 !bounds.head.isErroneous() &&
mcimadamore@854 991 !isTypeArgErroneous(args.head)) {
mcimadamore@821 992 return args.head;
mcimadamore@821 993 }
mcimadamore@1216 994 bounds = bounds.tail;
mcimadamore@854 995 args = args.tail;
mcimadamore@821 996 }
mcimadamore@821 997
mcimadamore@821 998 return null;
mcimadamore@821 999 }
mcimadamore@854 1000 //where
mcimadamore@854 1001 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 1002 return isTypeArgErroneous.visit(t);
mcimadamore@854 1003 }
mcimadamore@854 1004
mcimadamore@854 1005 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 1006 public Boolean visitType(Type t, Void s) {
mcimadamore@854 1007 return t.isErroneous();
mcimadamore@854 1008 }
mcimadamore@854 1009 @Override
mcimadamore@854 1010 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 1011 return visit(t.getUpperBound());
mcimadamore@854 1012 }
mcimadamore@854 1013 @Override
mcimadamore@854 1014 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 1015 return visit(t.getUpperBound()) ||
mcimadamore@854 1016 visit(t.getLowerBound());
mcimadamore@854 1017 }
mcimadamore@854 1018 @Override
mcimadamore@854 1019 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1020 return visit(t.type);
mcimadamore@854 1021 }
mcimadamore@854 1022 };
mcimadamore@821 1023
duke@1 1024 /** Check that given modifiers are legal for given symbol and
vromero@1555 1025 * return modifiers together with any implicit modifiers for that symbol.
duke@1 1026 * Warning: we can't use flags() here since this method
duke@1 1027 * is called during class enter, when flags() would cause a premature
duke@1 1028 * completion.
duke@1 1029 * @param pos Position to be used for error reporting.
duke@1 1030 * @param flags The set of modifiers given in a definition.
duke@1 1031 * @param sym The defined symbol.
duke@1 1032 */
duke@1 1033 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1034 long mask;
duke@1 1035 long implicit = 0;
emc@2016 1036
duke@1 1037 switch (sym.kind) {
duke@1 1038 case VAR:
duke@1 1039 if (sym.owner.kind != TYP)
duke@1 1040 mask = LocalVarFlags;
duke@1 1041 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1042 mask = implicit = InterfaceVarFlags;
duke@1 1043 else
duke@1 1044 mask = VarFlags;
duke@1 1045 break;
duke@1 1046 case MTH:
duke@1 1047 if (sym.name == names.init) {
duke@1 1048 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1049 // enum constructors cannot be declared public or
duke@1 1050 // protected and must be implicitly or explicitly
duke@1 1051 // private
duke@1 1052 implicit = PRIVATE;
duke@1 1053 mask = PRIVATE;
duke@1 1054 } else
duke@1 1055 mask = ConstructorFlags;
mcimadamore@1366 1056 } else if ((sym.owner.flags_field & INTERFACE) != 0) {
emc@2016 1057 if ((sym.owner.flags_field & ANNOTATION) != 0) {
emc@2016 1058 mask = AnnotationTypeElementMask;
emc@2016 1059 implicit = PUBLIC | ABSTRACT;
emc@2016 1060 } else if ((flags & (DEFAULT | STATIC)) != 0) {
mcimadamore@1513 1061 mask = InterfaceMethodMask;
mcimadamore@1513 1062 implicit = PUBLIC;
mcimadamore@1513 1063 if ((flags & DEFAULT) != 0) {
mcimadamore@1513 1064 implicit |= ABSTRACT;
mcimadamore@1513 1065 }
mcimadamore@1366 1066 } else {
mcimadamore@1366 1067 mask = implicit = InterfaceMethodFlags;
mcimadamore@1366 1068 }
emc@2016 1069 } else {
duke@1 1070 mask = MethodFlags;
duke@1 1071 }
duke@1 1072 // Imply STRICTFP if owner has STRICTFP set.
vromero@1712 1073 if (((flags|implicit) & Flags.ABSTRACT) == 0 ||
vromero@1712 1074 ((flags) & Flags.DEFAULT) != 0)
vromero@1555 1075 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1076 break;
duke@1 1077 case TYP:
duke@1 1078 if (sym.isLocal()) {
duke@1 1079 mask = LocalClassFlags;
jjg@113 1080 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1081 // Anonymous classes in static methods are themselves static;
duke@1 1082 // that's why we admit STATIC here.
duke@1 1083 mask |= STATIC;
duke@1 1084 // JLS: Anonymous classes are final.
duke@1 1085 implicit |= FINAL;
duke@1 1086 }
duke@1 1087 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1088 (flags & ENUM) != 0)
duke@1 1089 log.error(pos, "enums.must.be.static");
duke@1 1090 } else if (sym.owner.kind == TYP) {
duke@1 1091 mask = MemberClassFlags;
duke@1 1092 if (sym.owner.owner.kind == PCK ||
duke@1 1093 (sym.owner.flags_field & STATIC) != 0)
duke@1 1094 mask |= STATIC;
duke@1 1095 else if ((flags & ENUM) != 0)
duke@1 1096 log.error(pos, "enums.must.be.static");
duke@1 1097 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1098 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1099 } else {
duke@1 1100 mask = ClassFlags;
duke@1 1101 }
duke@1 1102 // Interfaces are always ABSTRACT
duke@1 1103 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1104
duke@1 1105 if ((flags & ENUM) != 0) {
duke@1 1106 // enums can't be declared abstract or final
duke@1 1107 mask &= ~(ABSTRACT | FINAL);
duke@1 1108 implicit |= implicitEnumFinalFlag(tree);
duke@1 1109 }
duke@1 1110 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1111 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1112 break;
duke@1 1113 default:
duke@1 1114 throw new AssertionError();
duke@1 1115 }
mcimadamore@1366 1116 long illegal = flags & ExtendedStandardFlags & ~mask;
duke@1 1117 if (illegal != 0) {
duke@1 1118 if ((illegal & INTERFACE) != 0) {
duke@1 1119 log.error(pos, "intf.not.allowed.here");
duke@1 1120 mask |= INTERFACE;
duke@1 1121 }
duke@1 1122 else {
duke@1 1123 log.error(pos,
mcimadamore@80 1124 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1125 }
duke@1 1126 }
duke@1 1127 else if ((sym.kind == TYP ||
duke@1 1128 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1129 // in the presence of inner classes. Should it be deleted here?
duke@1 1130 checkDisjoint(pos, flags,
duke@1 1131 ABSTRACT,
mcimadamore@1366 1132 PRIVATE | STATIC | DEFAULT))
duke@1 1133 &&
duke@1 1134 checkDisjoint(pos, flags,
mcimadamore@1513 1135 STATIC,
mcimadamore@1513 1136 DEFAULT)
mcimadamore@1513 1137 &&
mcimadamore@1513 1138 checkDisjoint(pos, flags,
duke@1 1139 ABSTRACT | INTERFACE,
duke@1 1140 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1141 &&
duke@1 1142 checkDisjoint(pos, flags,
duke@1 1143 PUBLIC,
duke@1 1144 PRIVATE | PROTECTED)
duke@1 1145 &&
duke@1 1146 checkDisjoint(pos, flags,
duke@1 1147 PRIVATE,
duke@1 1148 PUBLIC | PROTECTED)
duke@1 1149 &&
duke@1 1150 checkDisjoint(pos, flags,
duke@1 1151 FINAL,
duke@1 1152 VOLATILE)
duke@1 1153 &&
duke@1 1154 (sym.kind == TYP ||
duke@1 1155 checkDisjoint(pos, flags,
duke@1 1156 ABSTRACT | NATIVE,
duke@1 1157 STRICTFP))) {
duke@1 1158 // skip
duke@1 1159 }
mcimadamore@1366 1160 return flags & (mask | ~ExtendedStandardFlags) | implicit;
duke@1 1161 }
duke@1 1162
duke@1 1163
duke@1 1164 /** Determine if this enum should be implicitly final.
duke@1 1165 *
duke@1 1166 * If the enum has no specialized enum contants, it is final.
duke@1 1167 *
duke@1 1168 * If the enum does have specialized enum contants, it is
duke@1 1169 * <i>not</i> final.
duke@1 1170 */
duke@1 1171 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1172 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1173 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1174 boolean specialized;
duke@1 1175 SpecialTreeVisitor() {
duke@1 1176 this.specialized = false;
duke@1 1177 };
duke@1 1178
jjg@398 1179 @Override
duke@1 1180 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1181
jjg@398 1182 @Override
duke@1 1183 public void visitVarDef(JCVariableDecl tree) {
duke@1 1184 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1185 if (tree.init instanceof JCNewClass &&
duke@1 1186 ((JCNewClass) tree.init).def != null) {
duke@1 1187 specialized = true;
duke@1 1188 }
duke@1 1189 }
duke@1 1190 }
duke@1 1191 }
duke@1 1192
duke@1 1193 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1194 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1195 for (JCTree defs: cdef.defs) {
duke@1 1196 defs.accept(sts);
duke@1 1197 if (sts.specialized) return 0;
duke@1 1198 }
duke@1 1199 return FINAL;
duke@1 1200 }
duke@1 1201
duke@1 1202 /* *************************************************************************
duke@1 1203 * Type Validation
duke@1 1204 **************************************************************************/
duke@1 1205
duke@1 1206 /** Validate a type expression. That is,
duke@1 1207 * check that all type arguments of a parametric type are within
jjg@1755 1208 * their bounds. This must be done in a second phase after type attribution
duke@1 1209 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1210 *
jjg@1358 1211 * <pre>{@code
duke@1 1212 * class B<A extends C> { ... }
duke@1 1213 * class C extends B<C> { ... }
jjg@1358 1214 * }</pre>
duke@1 1215 *
duke@1 1216 * and we can't make sure that the bound is already attributed because
duke@1 1217 * of possible cycles.
mcimadamore@638 1218 *
mcimadamore@638 1219 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1220 * and reporting any completion failures.
duke@1 1221 */
mcimadamore@122 1222 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1223 validate(tree, env, true);
duke@1 1224 }
mcimadamore@638 1225 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1226 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1227 }
duke@1 1228
duke@1 1229 /** Visitor method: Validate a list of type expressions.
duke@1 1230 */
mcimadamore@122 1231 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1232 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1233 validate(l.head, env);
duke@1 1234 }
duke@1 1235
duke@1 1236 /** A visitor class for type validation.
duke@1 1237 */
duke@1 1238 class Validator extends JCTree.Visitor {
duke@1 1239
jlahoda@2038 1240 boolean checkRaw;
mcimadamore@638 1241 boolean isOuter;
mcimadamore@638 1242 Env<AttrContext> env;
mcimadamore@638 1243
mcimadamore@638 1244 Validator(Env<AttrContext> env) {
mcimadamore@638 1245 this.env = env;
mcimadamore@638 1246 }
mcimadamore@638 1247
jjg@398 1248 @Override
duke@1 1249 public void visitTypeArray(JCArrayTypeTree tree) {
jlahoda@2038 1250 validateTree(tree.elemtype, checkRaw, isOuter);
duke@1 1251 }
duke@1 1252
jjg@398 1253 @Override
duke@1 1254 public void visitTypeApply(JCTypeApply tree) {
jjg@1374 1255 if (tree.type.hasTag(CLASS)) {
duke@1 1256 List<JCExpression> args = tree.arguments;
mcimadamore@158 1257 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1258
mcimadamore@821 1259 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1260 if (incompatibleArg != null) {
mcimadamore@821 1261 for (JCTree arg : tree.arguments) {
mcimadamore@821 1262 if (arg.type == incompatibleArg) {
mcimadamore@829 1263 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1264 }
mcimadamore@829 1265 forms = forms.tail;
mcimadamore@829 1266 }
mcimadamore@829 1267 }
mcimadamore@829 1268
mcimadamore@829 1269 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1270
mcimadamore@638 1271 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1272
duke@1 1273 // For matching pairs of actual argument types `a' and
duke@1 1274 // formal type parameters with declared bound `b' ...
duke@1 1275 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1276 validateTree(args.head,
mcimadamore@638 1277 !(isOuter && is_java_lang_Class),
mcimadamore@638 1278 false);
duke@1 1279 args = args.tail;
duke@1 1280 forms = forms.tail;
duke@1 1281 }
duke@1 1282
duke@1 1283 // Check that this type is either fully parameterized, or
duke@1 1284 // not parameterized at all.
duke@1 1285 if (tree.type.getEnclosingType().isRaw())
duke@1 1286 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1287 if (tree.clazz.hasTag(SELECT))
duke@1 1288 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1289 }
duke@1 1290 }
duke@1 1291
jjg@398 1292 @Override
duke@1 1293 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1294 validateTrees(tree.bounds, true, isOuter);
duke@1 1295 checkClassBounds(tree.pos(), tree.type);
duke@1 1296 }
duke@1 1297
duke@1 1298 @Override
duke@1 1299 public void visitWildcard(JCWildcard tree) {
duke@1 1300 if (tree.inner != null)
mcimadamore@638 1301 validateTree(tree.inner, true, isOuter);
duke@1 1302 }
duke@1 1303
jjg@398 1304 @Override
duke@1 1305 public void visitSelect(JCFieldAccess tree) {
jjg@1374 1306 if (tree.type.hasTag(CLASS)) {
duke@1 1307 visitSelectInternal(tree);
duke@1 1308
duke@1 1309 // Check that this type is either fully parameterized, or
duke@1 1310 // not parameterized at all.
duke@1 1311 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1312 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1313 }
duke@1 1314 }
mcimadamore@852 1315
duke@1 1316 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1317 if (tree.type.tsym.isStatic() &&
duke@1 1318 tree.selected.type.isParameterized()) {
duke@1 1319 // The enclosing type is not a class, so we are
duke@1 1320 // looking at a static member type. However, the
duke@1 1321 // qualifying expression is parameterized.
duke@1 1322 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1323 } else {
duke@1 1324 // otherwise validate the rest of the expression
mcimadamore@122 1325 tree.selected.accept(this);
duke@1 1326 }
duke@1 1327 }
duke@1 1328
jjg@1521 1329 @Override
jjg@1521 1330 public void visitAnnotatedType(JCAnnotatedType tree) {
jjg@1521 1331 tree.underlyingType.accept(this);
jjg@1521 1332 }
jjg@1521 1333
jlahoda@2206 1334 @Override
jlahoda@2206 1335 public void visitTypeIdent(JCPrimitiveTypeTree that) {
jlahoda@2206 1336 if (that.type.hasTag(TypeTag.VOID)) {
jlahoda@2206 1337 log.error(that.pos(), "void.not.allowed.here");
jlahoda@2206 1338 }
jlahoda@2206 1339 super.visitTypeIdent(that);
jlahoda@2206 1340 }
jlahoda@2206 1341
duke@1 1342 /** Default visitor method: do nothing.
duke@1 1343 */
jjg@398 1344 @Override
duke@1 1345 public void visitTree(JCTree tree) {
duke@1 1346 }
mcimadamore@122 1347
mcimadamore@638 1348 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
jlahoda@2038 1349 if (tree != null) {
jlahoda@2038 1350 boolean prevCheckRaw = this.checkRaw;
jlahoda@2038 1351 this.checkRaw = checkRaw;
jlahoda@2038 1352 this.isOuter = isOuter;
jlahoda@2038 1353
jlahoda@2038 1354 try {
mcimadamore@638 1355 tree.accept(this);
mcimadamore@638 1356 if (checkRaw)
mcimadamore@638 1357 checkRaw(tree, env);
jlahoda@2038 1358 } catch (CompletionFailure ex) {
jlahoda@2038 1359 completionError(tree.pos(), ex);
jlahoda@2038 1360 } finally {
jlahoda@2038 1361 this.checkRaw = prevCheckRaw;
mcimadamore@638 1362 }
mcimadamore@638 1363 }
mcimadamore@638 1364 }
mcimadamore@638 1365
mcimadamore@638 1366 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1367 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1368 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1369 }
mcimadamore@1760 1370 }
mcimadamore@1760 1371
mcimadamore@1760 1372 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@1760 1373 if (lint.isEnabled(LintCategory.RAW) &&
mcimadamore@1760 1374 tree.type.hasTag(CLASS) &&
mcimadamore@1760 1375 !TreeInfo.isDiamond(tree) &&
mcimadamore@1760 1376 !withinAnonConstr(env) &&
mcimadamore@1760 1377 tree.type.isRaw()) {
mcimadamore@1760 1378 log.warning(LintCategory.RAW,
mcimadamore@1760 1379 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1380 }
mcimadamore@1760 1381 }
mcimadamore@1760 1382 //where
mcimadamore@1760 1383 private boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1384 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1385 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1386 }
duke@1 1387
duke@1 1388 /* *************************************************************************
duke@1 1389 * Exception checking
duke@1 1390 **************************************************************************/
duke@1 1391
duke@1 1392 /* The following methods treat classes as sets that contain
duke@1 1393 * the class itself and all their subclasses
duke@1 1394 */
duke@1 1395
duke@1 1396 /** Is given type a subtype of some of the types in given list?
duke@1 1397 */
duke@1 1398 boolean subset(Type t, List<Type> ts) {
duke@1 1399 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1400 if (types.isSubtype(t, l.head)) return true;
duke@1 1401 return false;
duke@1 1402 }
duke@1 1403
duke@1 1404 /** Is given type a subtype or supertype of
duke@1 1405 * some of the types in given list?
duke@1 1406 */
duke@1 1407 boolean intersects(Type t, List<Type> ts) {
duke@1 1408 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1409 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1410 return false;
duke@1 1411 }
duke@1 1412
duke@1 1413 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1414 * in the list.
duke@1 1415 */
duke@1 1416 List<Type> incl(Type t, List<Type> ts) {
duke@1 1417 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1418 }
duke@1 1419
duke@1 1420 /** Remove type set from type set list.
duke@1 1421 */
duke@1 1422 List<Type> excl(Type t, List<Type> ts) {
duke@1 1423 if (ts.isEmpty()) {
duke@1 1424 return ts;
duke@1 1425 } else {
duke@1 1426 List<Type> ts1 = excl(t, ts.tail);
duke@1 1427 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1428 else if (ts1 == ts.tail) return ts;
duke@1 1429 else return ts1.prepend(ts.head);
duke@1 1430 }
duke@1 1431 }
duke@1 1432
duke@1 1433 /** Form the union of two type set lists.
duke@1 1434 */
duke@1 1435 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1436 List<Type> ts = ts1;
duke@1 1437 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1438 ts = incl(l.head, ts);
duke@1 1439 return ts;
duke@1 1440 }
duke@1 1441
duke@1 1442 /** Form the difference of two type lists.
duke@1 1443 */
duke@1 1444 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1445 List<Type> ts = ts1;
duke@1 1446 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1447 ts = excl(l.head, ts);
duke@1 1448 return ts;
duke@1 1449 }
duke@1 1450
duke@1 1451 /** Form the intersection of two type lists.
duke@1 1452 */
duke@1 1453 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1454 List<Type> ts = List.nil();
duke@1 1455 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1456 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1457 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1458 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1459 return ts;
duke@1 1460 }
duke@1 1461
duke@1 1462 /** Is exc an exception symbol that need not be declared?
duke@1 1463 */
duke@1 1464 boolean isUnchecked(ClassSymbol exc) {
duke@1 1465 return
duke@1 1466 exc.kind == ERR ||
duke@1 1467 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1468 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1469 }
duke@1 1470
duke@1 1471 /** Is exc an exception type that need not be declared?
duke@1 1472 */
duke@1 1473 boolean isUnchecked(Type exc) {
duke@1 1474 return
jjg@1374 1475 (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
jjg@1374 1476 (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
jjg@1374 1477 exc.hasTag(BOT);
duke@1 1478 }
duke@1 1479
duke@1 1480 /** Same, but handling completion failures.
duke@1 1481 */
duke@1 1482 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1483 try {
duke@1 1484 return isUnchecked(exc);
duke@1 1485 } catch (CompletionFailure ex) {
duke@1 1486 completionError(pos, ex);
duke@1 1487 return true;
duke@1 1488 }
duke@1 1489 }
duke@1 1490
duke@1 1491 /** Is exc handled by given exception list?
duke@1 1492 */
duke@1 1493 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1494 return isUnchecked(exc) || subset(exc, handled);
duke@1 1495 }
duke@1 1496
duke@1 1497 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1498 * @param thrown The list of thrown exceptions.
duke@1 1499 * @param handled The list of handled exceptions.
duke@1 1500 */
mcimadamore@362 1501 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1502 List<Type> unhandled = List.nil();
duke@1 1503 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1504 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1505 return unhandled;
duke@1 1506 }
duke@1 1507
duke@1 1508 /* *************************************************************************
duke@1 1509 * Overriding/Implementation checking
duke@1 1510 **************************************************************************/
duke@1 1511
duke@1 1512 /** The level of access protection given by a flag set,
duke@1 1513 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1514 */
duke@1 1515 static int protection(long flags) {
duke@1 1516 switch ((short)(flags & AccessFlags)) {
duke@1 1517 case PRIVATE: return 3;
duke@1 1518 case PROTECTED: return 1;
duke@1 1519 default:
duke@1 1520 case PUBLIC: return 0;
duke@1 1521 case 0: return 2;
duke@1 1522 }
duke@1 1523 }
duke@1 1524
duke@1 1525 /** A customized "cannot override" error message.
duke@1 1526 * @param m The overriding method.
duke@1 1527 * @param other The overridden method.
duke@1 1528 * @return An internationalized string.
duke@1 1529 */
mcimadamore@89 1530 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1531 String key;
duke@1 1532 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1533 key = "cant.override";
duke@1 1534 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1535 key = "cant.implement";
duke@1 1536 else
duke@1 1537 key = "clashes.with";
mcimadamore@89 1538 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1539 }
duke@1 1540
duke@1 1541 /** A customized "override" warning message.
duke@1 1542 * @param m The overriding method.
duke@1 1543 * @param other The overridden method.
duke@1 1544 * @return An internationalized string.
duke@1 1545 */
mcimadamore@89 1546 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1547 String key;
duke@1 1548 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1549 key = "unchecked.override";
duke@1 1550 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1551 key = "unchecked.implement";
duke@1 1552 else
duke@1 1553 key = "unchecked.clash.with";
mcimadamore@89 1554 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1555 }
duke@1 1556
duke@1 1557 /** A customized "override" warning message.
duke@1 1558 * @param m The overriding method.
duke@1 1559 * @param other The overridden method.
duke@1 1560 * @return An internationalized string.
duke@1 1561 */
mcimadamore@89 1562 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1563 String key;
duke@1 1564 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1565 key = "varargs.override";
duke@1 1566 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1567 key = "varargs.implement";
duke@1 1568 else
duke@1 1569 key = "varargs.clash.with";
mcimadamore@89 1570 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1571 }
duke@1 1572
duke@1 1573 /** Check that this method conforms with overridden method 'other'.
duke@1 1574 * where `origin' is the class where checking started.
duke@1 1575 * Complications:
duke@1 1576 * (1) Do not check overriding of synthetic methods
duke@1 1577 * (reason: they might be final).
duke@1 1578 * todo: check whether this is still necessary.
duke@1 1579 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1580 * than the method it implements. Augment the proxy methods with the
duke@1 1581 * undeclared exceptions in this case.
duke@1 1582 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1583 * has a result type
duke@1 1584 * extended by the result type of the method it implements.
duke@1 1585 * Change the proxies result type to the smaller type in this case.
duke@1 1586 *
duke@1 1587 * @param tree The tree from which positions
duke@1 1588 * are extracted for errors.
duke@1 1589 * @param m The overriding method.
duke@1 1590 * @param other The overridden method.
duke@1 1591 * @param origin The class of which the overriding method
duke@1 1592 * is a member.
duke@1 1593 */
duke@1 1594 void checkOverride(JCTree tree,
duke@1 1595 MethodSymbol m,
duke@1 1596 MethodSymbol other,
duke@1 1597 ClassSymbol origin) {
duke@1 1598 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1599 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1600 return;
duke@1 1601 }
duke@1 1602
duke@1 1603 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1604 if ((m.flags() & STATIC) != 0 &&
duke@1 1605 (other.flags() & STATIC) == 0) {
duke@1 1606 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1607 cannotOverride(m, other));
vromero@1588 1608 m.flags_field |= BAD_OVERRIDE;
duke@1 1609 return;
duke@1 1610 }
duke@1 1611
duke@1 1612 // Error if instance method overrides static or final
duke@1 1613 // method (JLS 8.4.6.1).
duke@1 1614 if ((other.flags() & FINAL) != 0 ||
duke@1 1615 (m.flags() & STATIC) == 0 &&
duke@1 1616 (other.flags() & STATIC) != 0) {
duke@1 1617 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1618 cannotOverride(m, other),
mcimadamore@80 1619 asFlagSet(other.flags() & (FINAL | STATIC)));
vromero@1588 1620 m.flags_field |= BAD_OVERRIDE;
duke@1 1621 return;
duke@1 1622 }
duke@1 1623
duke@1 1624 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1625 // handled in validateAnnotationMethod
duke@1 1626 return;
duke@1 1627 }
duke@1 1628
duke@1 1629 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1630 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1631 protection(m.flags()) > protection(other.flags())) {
duke@1 1632 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1633 cannotOverride(m, other),
mcimadamore@80 1634 other.flags() == 0 ?
vromero@1842 1635 "package" :
mcimadamore@80 1636 asFlagSet(other.flags() & AccessFlags));
vromero@1588 1637 m.flags_field |= BAD_OVERRIDE;
duke@1 1638 return;
duke@1 1639 }
duke@1 1640
duke@1 1641 Type mt = types.memberType(origin.type, m);
duke@1 1642 Type ot = types.memberType(origin.type, other);
duke@1 1643 // Error if overriding result type is different
duke@1 1644 // (or, in the case of generics mode, not a subtype) of
duke@1 1645 // overridden result type. We have to rename any type parameters
duke@1 1646 // before comparing types.
duke@1 1647 List<Type> mtvars = mt.getTypeArguments();
duke@1 1648 List<Type> otvars = ot.getTypeArguments();
duke@1 1649 Type mtres = mt.getReturnType();
duke@1 1650 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1651
mcimadamore@795 1652 overrideWarner.clear();
duke@1 1653 boolean resultTypesOK =
tbell@202 1654 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1655 if (!resultTypesOK) {
jjg@398 1656 if (!allowCovariantReturns &&
duke@1 1657 m.owner != origin &&
duke@1 1658 m.owner.isSubClass(other.owner, types)) {
duke@1 1659 // allow limited interoperability with covariant returns
duke@1 1660 } else {
mcimadamore@362 1661 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1662 "override.incompatible.ret",
mcimadamore@362 1663 cannotOverride(m, other),
duke@1 1664 mtres, otres);
vromero@1588 1665 m.flags_field |= BAD_OVERRIDE;
duke@1 1666 return;
duke@1 1667 }
mcimadamore@795 1668 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1669 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1670 "override.unchecked.ret",
mcimadamore@362 1671 uncheckedOverrides(m, other),
mcimadamore@362 1672 mtres, otres);
duke@1 1673 }
duke@1 1674
duke@1 1675 // Error if overriding method throws an exception not reported
duke@1 1676 // by overridden method.
duke@1 1677 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1678 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1679 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1680 if (unhandledErased.nonEmpty()) {
duke@1 1681 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1682 "override.meth.doesnt.throw",
duke@1 1683 cannotOverride(m, other),
mcimadamore@362 1684 unhandledUnerased.head);
vromero@1588 1685 m.flags_field |= BAD_OVERRIDE;
mcimadamore@362 1686 return;
mcimadamore@362 1687 }
mcimadamore@362 1688 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1689 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1690 "override.unchecked.thrown",
mcimadamore@362 1691 cannotOverride(m, other),
mcimadamore@362 1692 unhandledUnerased.head);
duke@1 1693 return;
duke@1 1694 }
duke@1 1695
duke@1 1696 // Optional warning if varargs don't agree
duke@1 1697 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1698 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1699 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1700 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1701 ? "override.varargs.missing"
duke@1 1702 : "override.varargs.extra",
duke@1 1703 varargsOverrides(m, other));
duke@1 1704 }
duke@1 1705
duke@1 1706 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1707 if ((other.flags() & BRIDGE) != 0) {
duke@1 1708 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1709 uncheckedOverrides(m, other));
duke@1 1710 }
duke@1 1711
duke@1 1712 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1713 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1714 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1715 }
duke@1 1716 }
duke@1 1717 // where
duke@1 1718 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1719 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1720 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1721 // because in that case, we will rediscover the issue when examining the method
duke@1 1722 // in the supertype.
duke@1 1723 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1724 // address the issue is when the method is the supertype implemementation: any other
duke@1 1725 // case, we will have dealt with when examining the supertype classes
duke@1 1726 ClassSymbol mc = m.enclClass();
duke@1 1727 Type st = types.supertype(origin.type);
jjg@1374 1728 if (!st.hasTag(CLASS))
duke@1 1729 return true;
duke@1 1730 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1731
duke@1 1732 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1733 List<Type> intfs = types.interfaces(origin.type);
duke@1 1734 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1735 }
duke@1 1736 else
duke@1 1737 return (stimpl != m);
duke@1 1738 }
duke@1 1739
duke@1 1740
duke@1 1741 // used to check if there were any unchecked conversions
duke@1 1742 Warner overrideWarner = new Warner();
duke@1 1743
duke@1 1744 /** Check that a class does not inherit two concrete methods
duke@1 1745 * with the same signature.
duke@1 1746 * @param pos Position to be used for error reporting.
duke@1 1747 * @param site The class type to be checked.
duke@1 1748 */
duke@1 1749 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1750 Type sup = types.supertype(site);
jjg@1374 1751 if (!sup.hasTag(CLASS)) return;
duke@1 1752
duke@1 1753 for (Type t1 = sup;
jlahoda@1956 1754 t1.hasTag(CLASS) && t1.tsym.type.isParameterized();
duke@1 1755 t1 = types.supertype(t1)) {
duke@1 1756 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1757 e1 != null;
duke@1 1758 e1 = e1.sibling) {
duke@1 1759 Symbol s1 = e1.sym;
duke@1 1760 if (s1.kind != MTH ||
duke@1 1761 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1762 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1763 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1764 types,
duke@1 1765 true) != s1)
duke@1 1766 continue;
duke@1 1767 Type st1 = types.memberType(t1, s1);
duke@1 1768 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1769 if (st1 == s1.type) continue;
duke@1 1770
duke@1 1771 for (Type t2 = sup;
jjg@1374 1772 t2.hasTag(CLASS);
duke@1 1773 t2 = types.supertype(t2)) {
mcimadamore@24 1774 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1775 e2.scope != null;
duke@1 1776 e2 = e2.next()) {
duke@1 1777 Symbol s2 = e2.sym;
duke@1 1778 if (s2 == s1 ||
duke@1 1779 s2.kind != MTH ||
duke@1 1780 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1781 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1782 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1783 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1784 types,
duke@1 1785 true) != s2)
duke@1 1786 continue;
duke@1 1787 Type st2 = types.memberType(t2, s2);
duke@1 1788 if (types.overrideEquivalent(st1, st2))
duke@1 1789 log.error(pos, "concrete.inheritance.conflict",
duke@1 1790 s1, t1, s2, t2, sup);
duke@1 1791 }
duke@1 1792 }
duke@1 1793 }
duke@1 1794 }
duke@1 1795 }
duke@1 1796
duke@1 1797 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1798 * method with same name and arguments but incompatible return types.
duke@1 1799 * @param pos Position to be used for error reporting.
duke@1 1800 * @param t1 The first argument type.
duke@1 1801 * @param t2 The second argument type.
duke@1 1802 */
duke@1 1803 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1804 Type t1,
duke@1 1805 Type t2) {
duke@1 1806 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1807 types.makeCompoundType(t1, t2));
duke@1 1808 }
duke@1 1809
duke@1 1810 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1811 Type t1,
duke@1 1812 Type t2,
duke@1 1813 Type site) {
mcimadamore@746 1814 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1815 }
duke@1 1816
duke@1 1817 /** Return the first method which is defined with same args
duke@1 1818 * but different return types in two given interfaces, or null if none
duke@1 1819 * exists.
duke@1 1820 * @param t1 The first type.
duke@1 1821 * @param t2 The second type.
duke@1 1822 * @param site The most derived type.
duke@1 1823 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1824 */
mcimadamore@746 1825 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1826 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1827 closure(t1, interfaces1);
duke@1 1828 Map<TypeSymbol,Type> interfaces2;
duke@1 1829 if (t1 == t2)
duke@1 1830 interfaces2 = interfaces1;
duke@1 1831 else
duke@1 1832 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1833
duke@1 1834 for (Type t3 : interfaces1.values()) {
duke@1 1835 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1836 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1837 if (s != null) return s;
duke@1 1838 }
duke@1 1839 }
duke@1 1840 return null;
duke@1 1841 }
duke@1 1842
duke@1 1843 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1844 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1845 if (!t.hasTag(CLASS)) return;
duke@1 1846 if (typeMap.put(t.tsym, t) == null) {
duke@1 1847 closure(types.supertype(t), typeMap);
duke@1 1848 for (Type i : types.interfaces(t))
duke@1 1849 closure(i, typeMap);
duke@1 1850 }
duke@1 1851 }
duke@1 1852
duke@1 1853 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1854 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1855 if (!t.hasTag(CLASS)) return;
duke@1 1856 if (typesSkip.get(t.tsym) != null) return;
duke@1 1857 if (typeMap.put(t.tsym, t) == null) {
duke@1 1858 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1859 for (Type i : types.interfaces(t))
duke@1 1860 closure(i, typesSkip, typeMap);
duke@1 1861 }
duke@1 1862 }
duke@1 1863
duke@1 1864 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1865 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1866 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1867 Symbol s1 = e1.sym;
duke@1 1868 Type st1 = null;
mcimadamore@1441 1869 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1870 (s1.flags() & SYNTHETIC) != 0) continue;
duke@1 1871 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1872 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1873 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1874 Symbol s2 = e2.sym;
duke@1 1875 if (s1 == s2) continue;
mcimadamore@1441 1876 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1877 (s2.flags() & SYNTHETIC) != 0) continue;
duke@1 1878 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1879 Type st2 = types.memberType(t2, s2);
duke@1 1880 if (types.overrideEquivalent(st1, st2)) {
duke@1 1881 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1882 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1883 Type rt1 = st1.getReturnType();
duke@1 1884 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1885 boolean compat =
duke@1 1886 types.isSameType(rt1, rt2) ||
jjg@1374 1887 !rt1.isPrimitiveOrVoid() &&
jjg@1374 1888 !rt2.isPrimitiveOrVoid() &&
mcimadamore@1415 1889 (types.covariantReturnType(rt1, rt2, types.noWarnings) ||
mcimadamore@1415 1890 types.covariantReturnType(rt2, rt1, types.noWarnings)) ||
mcimadamore@59 1891 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1892 if (!compat) {
mcimadamore@746 1893 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1894 t1, t2, s2.name +
mcimadamore@746 1895 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1896 return s2;
mcimadamore@746 1897 }
mcimadamore@889 1898 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1899 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1900 log.error(pos,
mcimadamore@746 1901 "name.clash.same.erasure.no.override",
mcimadamore@746 1902 s1, s1.location(),
mcimadamore@746 1903 s2, s2.location());
mcimadamore@746 1904 return s2;
duke@1 1905 }
duke@1 1906 }
duke@1 1907 }
duke@1 1908 return null;
duke@1 1909 }
mcimadamore@59 1910 //WHERE
mcimadamore@59 1911 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1912 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1913 Type st1 = types.memberType(site, s1);
mcimadamore@59 1914 Type st2 = types.memberType(site, s2);
mcimadamore@59 1915 closure(site, supertypes);
mcimadamore@59 1916 for (Type t : supertypes.values()) {
mcimadamore@59 1917 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1918 Symbol s3 = e.sym;
mcimadamore@59 1919 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1920 Type st3 = types.memberType(site,s3);
mcimadamore@1811 1921 if (types.overrideEquivalent(st3, st1) &&
mcimadamore@1811 1922 types.overrideEquivalent(st3, st2) &&
mcimadamore@1811 1923 types.returnTypeSubstitutable(st3, st1) &&
mcimadamore@1811 1924 types.returnTypeSubstitutable(st3, st2)) {
mcimadamore@1811 1925 return true;
mcimadamore@59 1926 }
mcimadamore@59 1927 }
mcimadamore@59 1928 }
mcimadamore@59 1929 return false;
mcimadamore@59 1930 }
duke@1 1931
duke@1 1932 /** Check that a given method conforms with any method it overrides.
duke@1 1933 * @param tree The tree from which positions are extracted
duke@1 1934 * for errors.
duke@1 1935 * @param m The overriding method.
duke@1 1936 */
jlahoda@2111 1937 void checkOverride(JCMethodDecl tree, MethodSymbol m) {
duke@1 1938 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1939 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1940 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1941 log.error(tree.pos(), "enum.no.finalize");
duke@1 1942 return;
duke@1 1943 }
jjg@1374 1944 for (Type t = origin.type; t.hasTag(CLASS);
duke@1 1945 t = types.supertype(t)) {
mcimadamore@746 1946 if (t != origin.type) {
mcimadamore@746 1947 checkOverride(tree, t, origin, m);
mcimadamore@746 1948 }
mcimadamore@746 1949 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1950 checkOverride(tree, t2, origin, m);
duke@1 1951 }
duke@1 1952 }
jlahoda@2111 1953
jlahoda@2111 1954 if (m.attribute(syms.overrideType.tsym) != null && !isOverrider(m)) {
jlahoda@2111 1955 DiagnosticPosition pos = tree.pos();
jlahoda@2111 1956 for (JCAnnotation a : tree.getModifiers().annotations) {
jlahoda@2111 1957 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
jlahoda@2111 1958 pos = a.pos();
jlahoda@2111 1959 break;
jlahoda@2111 1960 }
jlahoda@2111 1961 }
jlahoda@2111 1962 log.error(pos, "method.does.not.override.superclass");
jlahoda@2111 1963 }
duke@1 1964 }
duke@1 1965
mcimadamore@746 1966 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1967 TypeSymbol c = site.tsym;
mcimadamore@746 1968 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1969 while (e.scope != null) {
mcimadamore@746 1970 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1971 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1972 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1973 }
mcimadamore@746 1974 }
mcimadamore@746 1975 e = e.next();
mcimadamore@746 1976 }
mcimadamore@746 1977 }
mcimadamore@746 1978
vromero@1607 1979 private Filter<Symbol> equalsHasCodeFilter = new Filter<Symbol>() {
vromero@1607 1980 public boolean accepts(Symbol s) {
vromero@1607 1981 return MethodSymbol.implementation_filter.accepts(s) &&
vromero@1607 1982 (s.flags() & BAD_OVERRIDE) == 0;
vromero@1607 1983
vromero@1607 1984 }
vromero@1607 1985 };
vromero@1607 1986
vromero@1620 1987 public void checkClassOverrideEqualsAndHashIfNeeded(DiagnosticPosition pos,
vromero@1620 1988 ClassSymbol someClass) {
vromero@1620 1989 /* At present, annotations cannot possibly have a method that is override
vromero@1620 1990 * equivalent with Object.equals(Object) but in any case the condition is
vromero@1620 1991 * fine for completeness.
vromero@1620 1992 */
vromero@1620 1993 if (someClass == (ClassSymbol)syms.objectType.tsym ||
vromero@1620 1994 someClass.isInterface() || someClass.isEnum() ||
vromero@1620 1995 (someClass.flags() & ANNOTATION) != 0 ||
vromero@1620 1996 (someClass.flags() & ABSTRACT) != 0) return;
vromero@1620 1997 //anonymous inner classes implementing interfaces need especial treatment
vromero@1620 1998 if (someClass.isAnonymous()) {
vromero@1620 1999 List<Type> interfaces = types.interfaces(someClass.type);
vromero@1620 2000 if (interfaces != null && !interfaces.isEmpty() &&
vromero@1620 2001 interfaces.head.tsym == syms.comparatorType.tsym) return;
vromero@1620 2002 }
vromero@1620 2003 checkClassOverrideEqualsAndHash(pos, someClass);
vromero@1620 2004 }
vromero@1620 2005
vromero@1620 2006 private void checkClassOverrideEqualsAndHash(DiagnosticPosition pos,
vromero@1607 2007 ClassSymbol someClass) {
vromero@1588 2008 if (lint.isEnabled(LintCategory.OVERRIDES)) {
vromero@1607 2009 MethodSymbol equalsAtObject = (MethodSymbol)syms.objectType
vromero@1607 2010 .tsym.members().lookup(names.equals).sym;
vromero@1607 2011 MethodSymbol hashCodeAtObject = (MethodSymbol)syms.objectType
vromero@1607 2012 .tsym.members().lookup(names.hashCode).sym;
vromero@1607 2013 boolean overridesEquals = types.implementation(equalsAtObject,
vromero@1607 2014 someClass, false, equalsHasCodeFilter).owner == someClass;
vromero@1607 2015 boolean overridesHashCode = types.implementation(hashCodeAtObject,
vromero@1607 2016 someClass, false, equalsHasCodeFilter) != hashCodeAtObject;
vromero@1607 2017
vromero@1607 2018 if (overridesEquals && !overridesHashCode) {
vromero@1607 2019 log.warning(LintCategory.OVERRIDES, pos,
vromero@1620 2020 "override.equals.but.not.hashcode", someClass);
vromero@1588 2021 }
vromero@1588 2022 }
vromero@1588 2023 }
vromero@1588 2024
mcimadamore@746 2025 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 2026 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 2027 return (cf.accepts(s1) &&
mcimadamore@858 2028 cf.accepts(s2) &&
mcimadamore@858 2029 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 2030 }
mcimadamore@746 2031
mcimadamore@746 2032
duke@1 2033 /** Check that all abstract members of given class have definitions.
duke@1 2034 * @param pos Position to be used for error reporting.
duke@1 2035 * @param c The class.
duke@1 2036 */
duke@1 2037 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2038 try {
duke@1 2039 MethodSymbol undef = firstUndef(c, c);
duke@1 2040 if (undef != null) {
duke@1 2041 if ((c.flags() & ENUM) != 0 &&
duke@1 2042 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 2043 (c.flags() & FINAL) == 0) {
duke@1 2044 // add the ABSTRACT flag to an enum
duke@1 2045 c.flags_field |= ABSTRACT;
duke@1 2046 } else {
duke@1 2047 MethodSymbol undef1 =
duke@1 2048 new MethodSymbol(undef.flags(), undef.name,
duke@1 2049 types.memberType(c.type, undef), undef.owner);
duke@1 2050 log.error(pos, "does.not.override.abstract",
duke@1 2051 c, undef1, undef1.location());
duke@1 2052 }
duke@1 2053 }
duke@1 2054 } catch (CompletionFailure ex) {
duke@1 2055 completionError(pos, ex);
duke@1 2056 }
duke@1 2057 }
duke@1 2058 //where
duke@1 2059 /** Return first abstract member of class `c' that is not defined
duke@1 2060 * in `impl', null if there is none.
duke@1 2061 */
duke@1 2062 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 2063 MethodSymbol undef = null;
duke@1 2064 // Do not bother to search in classes that are not abstract,
duke@1 2065 // since they cannot have abstract members.
duke@1 2066 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 2067 Scope s = c.members();
duke@1 2068 for (Scope.Entry e = s.elems;
duke@1 2069 undef == null && e != null;
duke@1 2070 e = e.sibling) {
duke@1 2071 if (e.sym.kind == MTH &&
mcimadamore@1393 2072 (e.sym.flags() & (ABSTRACT|IPROXY|DEFAULT)) == ABSTRACT) {
duke@1 2073 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2074 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
mcimadamore@1393 2075 if (implmeth == null || implmeth == absmeth) {
mcimadamore@1393 2076 //look for default implementations
mcimadamore@1393 2077 if (allowDefaultMethods) {
mcimadamore@1393 2078 MethodSymbol prov = types.interfaceCandidates(impl.type, absmeth).head;
mcimadamore@1393 2079 if (prov != null && prov.overrides(absmeth, impl, types, true)) {
mcimadamore@1393 2080 implmeth = prov;
mcimadamore@1393 2081 }
mcimadamore@1393 2082 }
mcimadamore@1393 2083 }
mcimadamore@1393 2084 if (implmeth == null || implmeth == absmeth) {
duke@1 2085 undef = absmeth;
mcimadamore@1393 2086 }
duke@1 2087 }
duke@1 2088 }
duke@1 2089 if (undef == null) {
duke@1 2090 Type st = types.supertype(c.type);
jjg@1374 2091 if (st.hasTag(CLASS))
duke@1 2092 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 2093 }
duke@1 2094 for (List<Type> l = types.interfaces(c.type);
duke@1 2095 undef == null && l.nonEmpty();
duke@1 2096 l = l.tail) {
duke@1 2097 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 2098 }
duke@1 2099 }
duke@1 2100 return undef;
duke@1 2101 }
duke@1 2102
mcimadamore@690 2103 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 2104 CycleChecker cc = new CycleChecker();
mcimadamore@690 2105 cc.scan(tree);
mcimadamore@690 2106 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 2107 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 2108 }
mcimadamore@690 2109 }
mcimadamore@690 2110
mcimadamore@690 2111 class CycleChecker extends TreeScanner {
mcimadamore@690 2112
mcimadamore@690 2113 List<Symbol> seenClasses = List.nil();
mcimadamore@690 2114 boolean errorFound = false;
mcimadamore@690 2115 boolean partialCheck = false;
mcimadamore@690 2116
mcimadamore@690 2117 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 2118 if (sym != null && sym.kind == TYP) {
mcimadamore@690 2119 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 2120 if (classEnv != null) {
mcimadamore@690 2121 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2122 try {
mcimadamore@690 2123 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2124 scan(classEnv.tree);
mcimadamore@690 2125 }
mcimadamore@690 2126 finally {
mcimadamore@690 2127 log.useSource(prevSource.getFile());
mcimadamore@690 2128 }
mcimadamore@690 2129 } else if (sym.kind == TYP) {
mcimadamore@690 2130 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2131 }
mcimadamore@690 2132 } else {
mcimadamore@690 2133 //not completed yet
mcimadamore@690 2134 partialCheck = true;
mcimadamore@690 2135 }
mcimadamore@690 2136 }
mcimadamore@690 2137
mcimadamore@690 2138 @Override
mcimadamore@690 2139 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2140 super.visitSelect(tree);
mcimadamore@690 2141 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2142 }
mcimadamore@690 2143
mcimadamore@690 2144 @Override
mcimadamore@690 2145 public void visitIdent(JCIdent tree) {
mcimadamore@690 2146 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2147 }
mcimadamore@690 2148
mcimadamore@690 2149 @Override
mcimadamore@690 2150 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2151 scan(tree.clazz);
mcimadamore@690 2152 }
mcimadamore@690 2153
mcimadamore@690 2154 @Override
mcimadamore@690 2155 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2156 scan(tree.elemtype);
mcimadamore@690 2157 }
mcimadamore@690 2158
mcimadamore@690 2159 @Override
mcimadamore@690 2160 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2161 List<JCTree> supertypes = List.nil();
mcimadamore@690 2162 if (tree.getExtendsClause() != null) {
mcimadamore@690 2163 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2164 }
mcimadamore@690 2165 if (tree.getImplementsClause() != null) {
mcimadamore@690 2166 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2167 supertypes = supertypes.prepend(intf);
mcimadamore@690 2168 }
mcimadamore@690 2169 }
mcimadamore@690 2170 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2171 }
mcimadamore@690 2172
mcimadamore@690 2173 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2174 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2175 return;
mcimadamore@690 2176 if (seenClasses.contains(c)) {
mcimadamore@690 2177 errorFound = true;
mcimadamore@690 2178 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2179 } else if (!c.type.isErroneous()) {
mcimadamore@690 2180 try {
mcimadamore@690 2181 seenClasses = seenClasses.prepend(c);
jjg@1374 2182 if (c.type.hasTag(CLASS)) {
mcimadamore@690 2183 if (supertypes.nonEmpty()) {
mcimadamore@690 2184 scan(supertypes);
mcimadamore@690 2185 }
mcimadamore@690 2186 else {
mcimadamore@690 2187 ClassType ct = (ClassType)c.type;
mcimadamore@690 2188 if (ct.supertype_field == null ||
mcimadamore@690 2189 ct.interfaces_field == null) {
mcimadamore@690 2190 //not completed yet
mcimadamore@690 2191 partialCheck = true;
mcimadamore@690 2192 return;
mcimadamore@690 2193 }
mcimadamore@690 2194 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2195 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2196 checkSymbol(pos, intf.tsym);
mcimadamore@690 2197 }
mcimadamore@690 2198 }
mcimadamore@690 2199 if (c.owner.kind == TYP) {
mcimadamore@690 2200 checkSymbol(pos, c.owner);
mcimadamore@690 2201 }
mcimadamore@690 2202 }
mcimadamore@690 2203 } finally {
mcimadamore@690 2204 seenClasses = seenClasses.tail;
mcimadamore@690 2205 }
mcimadamore@690 2206 }
mcimadamore@690 2207 }
mcimadamore@690 2208 }
mcimadamore@690 2209
duke@1 2210 /** Check for cyclic references. Issue an error if the
duke@1 2211 * symbol of the type referred to has a LOCKED flag set.
duke@1 2212 *
duke@1 2213 * @param pos Position to be used for error reporting.
duke@1 2214 * @param t The type referred to.
duke@1 2215 */
duke@1 2216 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2217 checkNonCyclicInternal(pos, t);
duke@1 2218 }
duke@1 2219
duke@1 2220
duke@1 2221 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2222 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2223 }
duke@1 2224
mcimadamore@236 2225 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2226 final TypeVar tv;
jjg@1374 2227 if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2228 return;
duke@1 2229 if (seen.contains(t)) {
jjg@1978 2230 tv = (TypeVar)t.unannotatedType();
jjg@110 2231 tv.bound = types.createErrorType(t);
duke@1 2232 log.error(pos, "cyclic.inheritance", t);
jjg@1374 2233 } else if (t.hasTag(TYPEVAR)) {
jjg@1978 2234 tv = (TypeVar)t.unannotatedType();
mcimadamore@236 2235 seen = seen.prepend(tv);
duke@1 2236 for (Type b : types.getBounds(tv))
duke@1 2237 checkNonCyclic1(pos, b, seen);
duke@1 2238 }
duke@1 2239 }
duke@1 2240
duke@1 2241 /** Check for cyclic references. Issue an error if the
duke@1 2242 * symbol of the type referred to has a LOCKED flag set.
duke@1 2243 *
duke@1 2244 * @param pos Position to be used for error reporting.
duke@1 2245 * @param t The type referred to.
duke@1 2246 * @returns True if the check completed on all attributed classes
duke@1 2247 */
duke@1 2248 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2249 boolean complete = true; // was the check complete?
duke@1 2250 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2251 Symbol c = t.tsym;
duke@1 2252 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2253
duke@1 2254 if ((c.flags_field & LOCKED) != 0) {
duke@1 2255 noteCyclic(pos, (ClassSymbol)c);
duke@1 2256 } else if (!c.type.isErroneous()) {
duke@1 2257 try {
duke@1 2258 c.flags_field |= LOCKED;
jjg@1374 2259 if (c.type.hasTag(CLASS)) {
duke@1 2260 ClassType clazz = (ClassType)c.type;
duke@1 2261 if (clazz.interfaces_field != null)
duke@1 2262 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2263 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2264 if (clazz.supertype_field != null) {
duke@1 2265 Type st = clazz.supertype_field;
jjg@1374 2266 if (st != null && st.hasTag(CLASS))
duke@1 2267 complete &= checkNonCyclicInternal(pos, st);
duke@1 2268 }
duke@1 2269 if (c.owner.kind == TYP)
duke@1 2270 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2271 }
duke@1 2272 } finally {
duke@1 2273 c.flags_field &= ~LOCKED;
duke@1 2274 }
duke@1 2275 }
duke@1 2276 if (complete)
duke@1 2277 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2278 if (complete) c.flags_field |= ACYCLIC;
duke@1 2279 return complete;
duke@1 2280 }
duke@1 2281
duke@1 2282 /** Note that we found an inheritance cycle. */
duke@1 2283 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2284 log.error(pos, "cyclic.inheritance", c);
duke@1 2285 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2286 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2287 Type st = types.supertype(c.type);
jjg@1374 2288 if (st.hasTag(CLASS))
jjg@110 2289 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2290 c.type = types.createErrorType(c, c.type);
duke@1 2291 c.flags_field |= ACYCLIC;
duke@1 2292 }
duke@1 2293
duke@1 2294 /** Check that all methods which implement some
duke@1 2295 * method conform to the method they implement.
duke@1 2296 * @param tree The class definition whose members are checked.
duke@1 2297 */
duke@1 2298 void checkImplementations(JCClassDecl tree) {
mcimadamore@1415 2299 checkImplementations(tree, tree.sym, tree.sym);
duke@1 2300 }
jjg@1521 2301 //where
duke@1 2302 /** Check that all methods which implement some
duke@1 2303 * method in `ic' conform to the method they implement.
duke@1 2304 */
mcimadamore@1415 2305 void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) {
duke@1 2306 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2307 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2308 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2309 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2310 if (e.sym.kind == MTH &&
duke@1 2311 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2312 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2313 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2314 if (implmeth != null && implmeth != absmeth &&
duke@1 2315 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2316 (origin.flags() & INTERFACE)) {
duke@1 2317 // don't check if implmeth is in a class, yet
duke@1 2318 // origin is an interface. This case arises only
duke@1 2319 // if implmeth is declared in Object. The reason is
duke@1 2320 // that interfaces really don't inherit from
duke@1 2321 // Object it's just that the compiler represents
duke@1 2322 // things that way.
duke@1 2323 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2324 }
duke@1 2325 }
duke@1 2326 }
duke@1 2327 }
duke@1 2328 }
duke@1 2329 }
duke@1 2330
duke@1 2331 /** Check that all abstract methods implemented by a class are
duke@1 2332 * mutually compatible.
duke@1 2333 * @param pos Position to be used for error reporting.
duke@1 2334 * @param c The class whose interfaces are checked.
duke@1 2335 */
duke@1 2336 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2337 List<Type> supertypes = types.interfaces(c);
duke@1 2338 Type supertype = types.supertype(c);
jjg@1374 2339 if (supertype.hasTag(CLASS) &&
duke@1 2340 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2341 supertypes = supertypes.prepend(supertype);
duke@1 2342 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2343 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2344 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2345 return;
duke@1 2346 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2347 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2348 return;
duke@1 2349 }
duke@1 2350 checkCompatibleConcretes(pos, c);
duke@1 2351 }
duke@1 2352
mcimadamore@359 2353 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2354 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2355 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2356 // VM allows methods and variables with differing types
mcimadamore@359 2357 if (sym.kind == e.sym.kind &&
mcimadamore@359 2358 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2359 sym != e.sym &&
mcimadamore@359 2360 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2361 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2362 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2363 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2364 return;
mcimadamore@359 2365 }
mcimadamore@359 2366 }
mcimadamore@359 2367 }
mcimadamore@359 2368 }
mcimadamore@359 2369
mcimadamore@780 2370 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2371 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2372 *
mcimadamore@780 2373 * @param pos Position to be used for error reporting.
mcimadamore@780 2374 * @param site The class whose methods are checked.
mcimadamore@780 2375 * @param sym The method symbol to be checked.
mcimadamore@780 2376 */
mcimadamore@858 2377 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2378 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2379 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2380 //by method 'sym' in 'site'...
vromero@2118 2381
vromero@2118 2382 List<MethodSymbol> potentiallyAmbiguousList = List.nil();
vromero@2118 2383 boolean overridesAny = false;
mcimadamore@1198 2384 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
vromero@2118 2385 if (!sym.overrides(m1, site.tsym, types, false)) {
vromero@2118 2386 if (m1 == sym) {
vromero@2118 2387 continue;
vromero@2118 2388 }
vromero@2118 2389
vromero@2118 2390 if (!overridesAny) {
vromero@2118 2391 potentiallyAmbiguousList = potentiallyAmbiguousList.prepend((MethodSymbol)m1);
vromero@2118 2392 }
vromero@2118 2393 continue;
vromero@2118 2394 }
vromero@2118 2395
vromero@2118 2396 if (m1 != sym) {
vromero@2118 2397 overridesAny = true;
vromero@2118 2398 potentiallyAmbiguousList = List.nil();
vromero@2118 2399 }
vromero@2118 2400
vromero@2118 2401 //...check each method m2 that is a member of 'site'
vromero@2118 2402 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2403 if (m2 == m1) continue;
mcimadamore@858 2404 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2405 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1393 2406 if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) &&
mcimadamore@1198 2407 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2408 sym.flags_field |= CLASH;
mcimadamore@1198 2409 String key = m1 == sym ?
mcimadamore@858 2410 "name.clash.same.erasure.no.override" :
mcimadamore@858 2411 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2412 log.error(pos,
mcimadamore@858 2413 key,
mcimadamore@858 2414 sym, sym.location(),
mcimadamore@1198 2415 m2, m2.location(),
mcimadamore@1198 2416 m1, m1.location());
mcimadamore@858 2417 return;
mcimadamore@858 2418 }
mcimadamore@780 2419 }
mcimadamore@780 2420 }
vromero@2118 2421
vromero@2118 2422 if (!overridesAny) {
vromero@2118 2423 for (MethodSymbol m: potentiallyAmbiguousList) {
vromero@2118 2424 checkPotentiallyAmbiguousOverloads(pos, site, sym, m);
vromero@2118 2425 }
vromero@2118 2426 }
mcimadamore@780 2427 }
mcimadamore@780 2428
mcimadamore@858 2429 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2430 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2431 *
mcimadamore@858 2432 * @param pos Position to be used for error reporting.
mcimadamore@858 2433 * @param site The class whose methods are checked.
mcimadamore@858 2434 * @param sym The method symbol to be checked.
mcimadamore@780 2435 */
mcimadamore@858 2436 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2437 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2438 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2439 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2440 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2441 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
vromero@2000 2442 if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck)) {
vromero@2000 2443 if (types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
vromero@2000 2444 log.error(pos,
vromero@2000 2445 "name.clash.same.erasure.no.hide",
vromero@2000 2446 sym, sym.location(),
vromero@2000 2447 s, s.location());
vromero@2000 2448 return;
vromero@2000 2449 } else {
vromero@2000 2450 checkPotentiallyAmbiguousOverloads(pos, site, sym, (MethodSymbol)s);
vromero@2000 2451 }
vromero@2000 2452 }
mcimadamore@858 2453 }
mcimadamore@858 2454 }
mcimadamore@780 2455
mcimadamore@858 2456 //where
mcimadamore@858 2457 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2458
mcimadamore@858 2459 Type site;
mcimadamore@780 2460
mcimadamore@858 2461 ClashFilter(Type site) {
mcimadamore@858 2462 this.site = site;
mcimadamore@858 2463 }
mcimadamore@858 2464
mcimadamore@858 2465 boolean shouldSkip(Symbol s) {
mcimadamore@858 2466 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2467 s.owner == site.tsym;
mcimadamore@858 2468 }
mcimadamore@858 2469
mcimadamore@858 2470 public boolean accepts(Symbol s) {
mcimadamore@858 2471 return s.kind == MTH &&
mcimadamore@858 2472 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2473 !shouldSkip(s) &&
mcimadamore@858 2474 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2475 !s.isConstructor();
mcimadamore@858 2476 }
mcimadamore@858 2477 }
mcimadamore@780 2478
mcimadamore@1393 2479 void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) {
mcimadamore@1393 2480 DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site);
mcimadamore@1393 2481 for (Symbol m : types.membersClosure(site, false).getElements(dcf)) {
mcimadamore@1393 2482 Assert.check(m.kind == MTH);
mcimadamore@1393 2483 List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m);
mcimadamore@1393 2484 if (prov.size() > 1) {
alundblad@2047 2485 ListBuffer<Symbol> abstracts = new ListBuffer<>();
alundblad@2047 2486 ListBuffer<Symbol> defaults = new ListBuffer<>();
mcimadamore@1393 2487 for (MethodSymbol provSym : prov) {
mcimadamore@1393 2488 if ((provSym.flags() & DEFAULT) != 0) {
mcimadamore@1393 2489 defaults = defaults.append(provSym);
mcimadamore@1393 2490 } else if ((provSym.flags() & ABSTRACT) != 0) {
mcimadamore@1393 2491 abstracts = abstracts.append(provSym);
mcimadamore@1393 2492 }
mcimadamore@1393 2493 if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) {
mcimadamore@1393 2494 //strong semantics - issue an error if two sibling interfaces
mcimadamore@1393 2495 //have two override-equivalent defaults - or if one is abstract
mcimadamore@1393 2496 //and the other is default
mcimadamore@1393 2497 String errKey;
mcimadamore@1393 2498 Symbol s1 = defaults.first();
mcimadamore@1393 2499 Symbol s2;
mcimadamore@1393 2500 if (defaults.size() > 1) {
mcimadamore@1393 2501 errKey = "types.incompatible.unrelated.defaults";
mcimadamore@1393 2502 s2 = defaults.toList().tail.head;
mcimadamore@1393 2503 } else {
mcimadamore@1393 2504 errKey = "types.incompatible.abstract.default";
mcimadamore@1393 2505 s2 = abstracts.first();
mcimadamore@1393 2506 }
mcimadamore@1393 2507 log.error(pos, errKey,
mcimadamore@1393 2508 Kinds.kindName(site.tsym), site,
mcimadamore@1393 2509 m.name, types.memberType(site, m).getParameterTypes(),
mcimadamore@1393 2510 s1.location(), s2.location());
mcimadamore@1393 2511 break;
mcimadamore@1393 2512 }
mcimadamore@1393 2513 }
mcimadamore@1393 2514 }
mcimadamore@1393 2515 }
mcimadamore@1393 2516 }
mcimadamore@1393 2517
mcimadamore@1393 2518 //where
mcimadamore@1393 2519 private class DefaultMethodClashFilter implements Filter<Symbol> {
mcimadamore@1393 2520
mcimadamore@1393 2521 Type site;
mcimadamore@1393 2522
mcimadamore@1393 2523 DefaultMethodClashFilter(Type site) {
mcimadamore@1393 2524 this.site = site;
mcimadamore@1393 2525 }
mcimadamore@1393 2526
mcimadamore@1393 2527 public boolean accepts(Symbol s) {
mcimadamore@1393 2528 return s.kind == MTH &&
mcimadamore@1393 2529 (s.flags() & DEFAULT) != 0 &&
mcimadamore@1393 2530 s.isInheritedIn(site.tsym, types) &&
mcimadamore@1393 2531 !s.isConstructor();
mcimadamore@1393 2532 }
mcimadamore@1393 2533 }
mcimadamore@1393 2534
vromero@2000 2535 /**
vromero@2000 2536 * Report warnings for potentially ambiguous method declarations. Two declarations
vromero@2000 2537 * are potentially ambiguous if they feature two unrelated functional interface
vromero@2000 2538 * in same argument position (in which case, a call site passing an implicit
vromero@2000 2539 * lambda would be ambiguous).
vromero@2000 2540 */
vromero@2000 2541 void checkPotentiallyAmbiguousOverloads(DiagnosticPosition pos, Type site,
vromero@2000 2542 MethodSymbol msym1, MethodSymbol msym2) {
vromero@2000 2543 if (msym1 != msym2 &&
vromero@2000 2544 allowDefaultMethods &&
vromero@2000 2545 lint.isEnabled(LintCategory.OVERLOADS) &&
vromero@2000 2546 (msym1.flags() & POTENTIALLY_AMBIGUOUS) == 0 &&
vromero@2000 2547 (msym2.flags() & POTENTIALLY_AMBIGUOUS) == 0) {
vromero@2000 2548 Type mt1 = types.memberType(site, msym1);
vromero@2000 2549 Type mt2 = types.memberType(site, msym2);
vromero@2000 2550 //if both generic methods, adjust type variables
vromero@2000 2551 if (mt1.hasTag(FORALL) && mt2.hasTag(FORALL) &&
vromero@2000 2552 types.hasSameBounds((ForAll)mt1, (ForAll)mt2)) {
vromero@2000 2553 mt2 = types.subst(mt2, ((ForAll)mt2).tvars, ((ForAll)mt1).tvars);
vromero@2000 2554 }
vromero@2000 2555 //expand varargs methods if needed
vromero@2000 2556 int maxLength = Math.max(mt1.getParameterTypes().length(), mt2.getParameterTypes().length());
vromero@2000 2557 List<Type> args1 = rs.adjustArgs(mt1.getParameterTypes(), msym1, maxLength, true);
vromero@2000 2558 List<Type> args2 = rs.adjustArgs(mt2.getParameterTypes(), msym2, maxLength, true);
vromero@2000 2559 //if arities don't match, exit
vromero@2000 2560 if (args1.length() != args2.length()) return;
vromero@2000 2561 boolean potentiallyAmbiguous = false;
vromero@2000 2562 while (args1.nonEmpty() && args2.nonEmpty()) {
vromero@2000 2563 Type s = args1.head;
vromero@2000 2564 Type t = args2.head;
vromero@2000 2565 if (!types.isSubtype(t, s) && !types.isSubtype(s, t)) {
vromero@2000 2566 if (types.isFunctionalInterface(s) && types.isFunctionalInterface(t) &&
vromero@2000 2567 types.findDescriptorType(s).getParameterTypes().length() > 0 &&
vromero@2000 2568 types.findDescriptorType(s).getParameterTypes().length() ==
vromero@2000 2569 types.findDescriptorType(t).getParameterTypes().length()) {
vromero@2000 2570 potentiallyAmbiguous = true;
vromero@2000 2571 } else {
vromero@2000 2572 break;
vromero@2000 2573 }
vromero@2000 2574 }
vromero@2000 2575 args1 = args1.tail;
vromero@2000 2576 args2 = args2.tail;
vromero@2000 2577 }
vromero@2000 2578 if (potentiallyAmbiguous) {
vromero@2000 2579 //we found two incompatible functional interfaces with same arity
vromero@2000 2580 //this means a call site passing an implicit lambda would be ambigiuous
vromero@2000 2581 msym1.flags_field |= POTENTIALLY_AMBIGUOUS;
vromero@2000 2582 msym2.flags_field |= POTENTIALLY_AMBIGUOUS;
vromero@2000 2583 log.warning(LintCategory.OVERLOADS, pos, "potentially.ambiguous.overload",
vromero@2000 2584 msym1, msym1.location(),
vromero@2000 2585 msym2, msym2.location());
vromero@2000 2586 return;
vromero@2000 2587 }
vromero@2000 2588 }
vromero@2000 2589 }
vromero@2000 2590
mcimadamore@359 2591 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2592 */
mcimadamore@359 2593 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2594 if (!sym.type.isErroneous()) {
mcimadamore@359 2595 if (warnOnSyntheticConflicts) {
mcimadamore@359 2596 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2597 }
mcimadamore@359 2598 else {
mcimadamore@359 2599 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2600 }
mcimadamore@359 2601 }
mcimadamore@359 2602 }
mcimadamore@359 2603
duke@1 2604 /** Check that class c does not implement directly or indirectly
duke@1 2605 * the same parameterized interface with two different argument lists.
duke@1 2606 * @param pos Position to be used for error reporting.
duke@1 2607 * @param type The type whose interfaces are checked.
duke@1 2608 */
duke@1 2609 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2610 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2611 }
duke@1 2612 //where
duke@1 2613 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2614 * with their class symbol as key and their type as value. Make
duke@1 2615 * sure no class is entered with two different types.
duke@1 2616 */
duke@1 2617 void checkClassBounds(DiagnosticPosition pos,
duke@1 2618 Map<TypeSymbol,Type> seensofar,
duke@1 2619 Type type) {
duke@1 2620 if (type.isErroneous()) return;
duke@1 2621 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2622 Type it = l.head;
duke@1 2623 Type oldit = seensofar.put(it.tsym, it);
duke@1 2624 if (oldit != null) {
duke@1 2625 List<Type> oldparams = oldit.allparams();
duke@1 2626 List<Type> newparams = it.allparams();
duke@1 2627 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2628 log.error(pos, "cant.inherit.diff.arg",
duke@1 2629 it.tsym, Type.toString(oldparams),
duke@1 2630 Type.toString(newparams));
duke@1 2631 }
duke@1 2632 checkClassBounds(pos, seensofar, it);
duke@1 2633 }
duke@1 2634 Type st = types.supertype(type);
duke@1 2635 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2636 }
duke@1 2637
duke@1 2638 /** Enter interface into into set.
duke@1 2639 * If it existed already, issue a "repeated interface" error.
duke@1 2640 */
duke@1 2641 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2642 if (its.contains(it))
duke@1 2643 log.error(pos, "repeated.interface");
duke@1 2644 else {
duke@1 2645 its.add(it);
duke@1 2646 }
duke@1 2647 }
duke@1 2648
duke@1 2649 /* *************************************************************************
duke@1 2650 * Check annotations
duke@1 2651 **************************************************************************/
duke@1 2652
mcimadamore@629 2653 /**
mcimadamore@634 2654 * Recursively validate annotations values
mcimadamore@629 2655 */
mcimadamore@634 2656 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2657 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2658 @Override
mcimadamore@629 2659 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2660 if (!tree.type.isErroneous()) {
jjg@1017 2661 super.visitAnnotation(tree);
jjg@1017 2662 validateAnnotation(tree);
jjg@1017 2663 }
mcimadamore@629 2664 }
mcimadamore@629 2665 }
mcimadamore@634 2666 tree.accept(new AnnotationValidator());
mcimadamore@629 2667 }
mcimadamore@629 2668
jjg@1326 2669 /**
jjg@1326 2670 * {@literal
jjg@1326 2671 * Annotation types are restricted to primitives, String, an
duke@1 2672 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2673 * Anything>, arrays of the preceding.
jjg@1326 2674 * }
duke@1 2675 */
duke@1 2676 void validateAnnotationType(JCTree restype) {
duke@1 2677 // restype may be null if an error occurred, so don't bother validating it
duke@1 2678 if (restype != null) {
duke@1 2679 validateAnnotationType(restype.pos(), restype.type);
duke@1 2680 }
duke@1 2681 }
duke@1 2682
duke@1 2683 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2684 if (type.isPrimitive()) return;
duke@1 2685 if (types.isSameType(type, syms.stringType)) return;
duke@1 2686 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2687 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2688 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2689 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2690 validateAnnotationType(pos, types.elemtype(type));
duke@1 2691 return;
duke@1 2692 }
duke@1 2693 log.error(pos, "invalid.annotation.member.type");
duke@1 2694 }
duke@1 2695
duke@1 2696 /**
duke@1 2697 * "It is also a compile-time error if any method declared in an
duke@1 2698 * annotation type has a signature that is override-equivalent to
duke@1 2699 * that of any public or protected method declared in class Object
duke@1 2700 * or in the interface annotation.Annotation."
duke@1 2701 *
jjh@972 2702 * @jls 9.6 Annotation Types
duke@1 2703 */
duke@1 2704 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
jjg@1374 2705 for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
duke@1 2706 Scope s = sup.tsym.members();
duke@1 2707 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2708 if (e.sym.kind == MTH &&
duke@1 2709 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2710 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2711 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2712 }
duke@1 2713 }
duke@1 2714 }
duke@1 2715
duke@1 2716 /** Check the annotations of a symbol.
duke@1 2717 */
duke@1 2718 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2719 for (JCAnnotation a : annotations)
duke@1 2720 validateAnnotation(a, s);
duke@1 2721 }
duke@1 2722
jjg@1521 2723 /** Check the type annotations.
jjg@1521 2724 */
jjg@1521 2725 public void validateTypeAnnotations(List<JCAnnotation> annotations, boolean isTypeParameter) {
jjg@1521 2726 for (JCAnnotation a : annotations)
jjg@1521 2727 validateTypeAnnotation(a, isTypeParameter);
jjg@1521 2728 }
jjg@1521 2729
duke@1 2730 /** Check an annotation of a symbol.
duke@1 2731 */
jfranck@1313 2732 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2733 validateAnnotationTree(a);
duke@1 2734
duke@1 2735 if (!annotationApplicable(a, s))
duke@1 2736 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2737
mcimadamore@1497 2738 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
mcimadamore@1497 2739 if (s.kind != TYP) {
mcimadamore@1497 2740 log.error(a.pos(), "bad.functional.intf.anno");
jlahoda@2111 2741 } else if (!s.isInterface() || (s.flags() & ANNOTATION) != 0) {
jlahoda@2111 2742 log.error(a.pos(), "bad.functional.intf.anno.1", diags.fragment("not.a.functional.intf", s));
mcimadamore@1497 2743 }
mcimadamore@1497 2744 }
duke@1 2745 }
duke@1 2746
jjg@1521 2747 public void validateTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2748 Assert.checkNonNull(a.type, "annotation tree hasn't been attributed yet: " + a);
jjg@1521 2749 validateAnnotationTree(a);
jjg@1521 2750
jjg@2134 2751 if (a.hasTag(TYPE_ANNOTATION) &&
jjg@2134 2752 !a.annotationType.type.isErroneous() &&
jjg@2134 2753 !isTypeAnnotation(a, isTypeParameter)) {
jjg@1521 2754 log.error(a.pos(), "annotation.type.not.applicable");
jjg@2134 2755 }
jjg@1521 2756 }
jjg@1521 2757
jfranck@1313 2758 /**
jjg@1492 2759 * Validate the proposed container 'repeatable' on the
jfranck@1313 2760 * annotation type symbol 's'. Report errors at position
jfranck@1313 2761 * 'pos'.
jfranck@1313 2762 *
jjg@1492 2763 * @param s The (annotation)type declaration annotated with a @Repeatable
jjg@1492 2764 * @param repeatable the @Repeatable on 's'
jfranck@1313 2765 * @param pos where to report errors
jfranck@1313 2766 */
jjg@1492 2767 public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) {
jjg@1492 2768 Assert.check(types.isSameType(repeatable.type, syms.repeatableType));
jfranck@1313 2769
jfranck@1313 2770 Type t = null;
jjg@1492 2771 List<Pair<MethodSymbol,Attribute>> l = repeatable.values;
jfranck@1313 2772 if (!l.isEmpty()) {
jfranck@1313 2773 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2774 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2775 }
jfranck@1313 2776
jfranck@1313 2777 if (t == null) {
jjg@1492 2778 // errors should already have been reported during Annotate
jfranck@1313 2779 return;
jfranck@1313 2780 }
jfranck@1313 2781
jjg@1492 2782 validateValue(t.tsym, s, pos);
jfranck@1313 2783 validateRetention(t.tsym, s, pos);
jfranck@1313 2784 validateDocumented(t.tsym, s, pos);
jfranck@1313 2785 validateInherited(t.tsym, s, pos);
jfranck@1313 2786 validateTarget(t.tsym, s, pos);
jfranck@2250 2787 validateDefault(t.tsym, pos);
jfranck@1313 2788 }
jfranck@1313 2789
jjg@1492 2790 private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jjg@1492 2791 Scope.Entry e = container.members().lookup(names.value);
jjg@1492 2792 if (e.scope != null && e.sym.kind == MTH) {
jjg@1492 2793 MethodSymbol m = (MethodSymbol) e.sym;
jjg@1492 2794 Type ret = m.getReturnType();
jjg@1492 2795 if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) {
jjg@1492 2796 log.error(pos, "invalid.repeatable.annotation.value.return",
jjg@1492 2797 container, ret, types.makeArrayType(contained.type));
jjg@1492 2798 }
jjg@1492 2799 } else {
jjg@1492 2800 log.error(pos, "invalid.repeatable.annotation.no.value", container);
jfranck@1313 2801 }
jfranck@1313 2802 }
jfranck@1313 2803
jfranck@1313 2804 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2805 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2806 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2807
jfranck@1313 2808 boolean error = false;
jfranck@1313 2809 switch (containedRetention) {
jfranck@1313 2810 case RUNTIME:
jfranck@1313 2811 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2812 error = true;
jfranck@1313 2813 }
jfranck@1313 2814 break;
jfranck@1313 2815 case CLASS:
jfranck@1313 2816 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2817 error = true;
jfranck@1313 2818 }
jfranck@1313 2819 }
jfranck@1313 2820 if (error ) {
jjg@1492 2821 log.error(pos, "invalid.repeatable.annotation.retention",
jfranck@1313 2822 container, containerRetention,
jfranck@1313 2823 contained, containedRetention);
jfranck@1313 2824 }
jfranck@1313 2825 }
jfranck@1313 2826
jfranck@1313 2827 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2828 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2829 if (container.attribute(syms.documentedType.tsym) == null) {
jjg@1492 2830 log.error(pos, "invalid.repeatable.annotation.not.documented", container, contained);
jfranck@1313 2831 }
jfranck@1313 2832 }
jfranck@1313 2833 }
jfranck@1313 2834
jfranck@1313 2835 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2836 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2837 if (container.attribute(syms.inheritedType.tsym) == null) {
jjg@1492 2838 log.error(pos, "invalid.repeatable.annotation.not.inherited", container, contained);
jfranck@1313 2839 }
jfranck@1313 2840 }
jfranck@1313 2841 }
jfranck@1313 2842
jfranck@1313 2843 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1634 2844 // The set of targets the container is applicable to must be a subset
jfranck@1634 2845 // (with respect to annotation target semantics) of the set of targets
jfranck@1634 2846 // the contained is applicable to. The target sets may be implicit or
jfranck@1634 2847 // explicit.
jfranck@1634 2848
jfranck@1634 2849 Set<Name> containerTargets;
jfranck@1313 2850 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2851 if (containerTarget == null) {
jfranck@1634 2852 containerTargets = getDefaultTargetSet();
jfranck@1634 2853 } else {
jfranck@1634 2854 containerTargets = new HashSet<Name>();
jfranck@1313 2855 for (Attribute app : containerTarget.values) {
jfranck@1313 2856 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2857 continue; // recovery
jfranck@1313 2858 }
jfranck@1313 2859 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2860 containerTargets.add(e.value.name);
jfranck@1313 2861 }
jfranck@1634 2862 }
jfranck@1634 2863
jfranck@1634 2864 Set<Name> containedTargets;
jfranck@1634 2865 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1634 2866 if (containedTarget == null) {
jfranck@1634 2867 containedTargets = getDefaultTargetSet();
jfranck@1634 2868 } else {
jfranck@1634 2869 containedTargets = new HashSet<Name>();
jfranck@1313 2870 for (Attribute app : containedTarget.values) {
jfranck@1313 2871 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2872 continue; // recovery
jfranck@1313 2873 }
jfranck@1313 2874 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2875 containedTargets.add(e.value.name);
jfranck@1313 2876 }
jfranck@1634 2877 }
jfranck@1634 2878
jfranck@1634 2879 if (!isTargetSubsetOf(containerTargets, containedTargets)) {
jjg@1492 2880 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2881 }
jfranck@1313 2882 }
jfranck@1313 2883
jfranck@1634 2884 /* get a set of names for the default target */
jfranck@1634 2885 private Set<Name> getDefaultTargetSet() {
jfranck@1634 2886 if (defaultTargets == null) {
jfranck@1634 2887 Set<Name> targets = new HashSet<Name>();
jfranck@1634 2888 targets.add(names.ANNOTATION_TYPE);
jfranck@1634 2889 targets.add(names.CONSTRUCTOR);
jfranck@1634 2890 targets.add(names.FIELD);
jfranck@1634 2891 targets.add(names.LOCAL_VARIABLE);
jfranck@1634 2892 targets.add(names.METHOD);
jfranck@1634 2893 targets.add(names.PACKAGE);
jfranck@1634 2894 targets.add(names.PARAMETER);
jfranck@1634 2895 targets.add(names.TYPE);
jfranck@1634 2896
jfranck@1634 2897 defaultTargets = java.util.Collections.unmodifiableSet(targets);
jfranck@1634 2898 }
jfranck@1634 2899
jfranck@1634 2900 return defaultTargets;
jfranck@1634 2901 }
jfranck@1634 2902 private Set<Name> defaultTargets;
jfranck@1634 2903
jfranck@1634 2904
jfranck@1634 2905 /** Checks that s is a subset of t, with respect to ElementType
jfranck@2250 2906 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE},
jfranck@2250 2907 * and {TYPE_USE} covers the set {ANNOTATION_TYPE, TYPE, TYPE_USE,
jfranck@2250 2908 * TYPE_PARAMETER}.
jfranck@1313 2909 */
jfranck@1634 2910 private boolean isTargetSubsetOf(Set<Name> s, Set<Name> t) {
jfranck@1634 2911 // Check that all elements in s are present in t
jfranck@1634 2912 for (Name n2 : s) {
jfranck@1313 2913 boolean currentElementOk = false;
jfranck@1634 2914 for (Name n1 : t) {
jfranck@1313 2915 if (n1 == n2) {
jfranck@1313 2916 currentElementOk = true;
jfranck@1313 2917 break;
jfranck@1313 2918 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2919 currentElementOk = true;
jfranck@1313 2920 break;
jfranck@2250 2921 } else if (n1 == names.TYPE_USE &&
jfranck@2250 2922 (n2 == names.TYPE ||
jfranck@2250 2923 n2 == names.ANNOTATION_TYPE ||
jfranck@2250 2924 n2 == names.TYPE_PARAMETER)) {
jfranck@2250 2925 currentElementOk = true;
jfranck@2250 2926 break;
jfranck@1313 2927 }
jfranck@1313 2928 }
jfranck@1313 2929 if (!currentElementOk)
jfranck@1313 2930 return false;
jfranck@1313 2931 }
jfranck@1313 2932 return true;
jfranck@1313 2933 }
jfranck@1313 2934
jfranck@2250 2935 private void validateDefault(Symbol container, DiagnosticPosition pos) {
jfranck@1344 2936 // validate that all other elements of containing type has defaults
jfranck@1344 2937 Scope scope = container.members();
jfranck@1344 2938 for(Symbol elm : scope.getElements()) {
jfranck@1344 2939 if (elm.name != names.value &&
jfranck@1344 2940 elm.kind == Kinds.MTH &&
jfranck@1344 2941 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2942 log.error(pos,
jjg@1492 2943 "invalid.repeatable.annotation.elem.nondefault",
jfranck@1344 2944 container,
jfranck@1344 2945 elm);
jfranck@1344 2946 }
jfranck@1344 2947 }
jfranck@1344 2948 }
jfranck@1344 2949
duke@1 2950 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2951 boolean isOverrider(Symbol s) {
duke@1 2952 if (s.kind != MTH || s.isStatic())
duke@1 2953 return false;
duke@1 2954 MethodSymbol m = (MethodSymbol)s;
duke@1 2955 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2956 for (Type sup : types.closure(owner.type)) {
duke@1 2957 if (sup == owner.type)
duke@1 2958 continue; // skip "this"
duke@1 2959 Scope scope = sup.tsym.members();
duke@1 2960 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2961 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2962 return true;
duke@1 2963 }
duke@1 2964 }
duke@1 2965 return false;
duke@1 2966 }
duke@1 2967
jlahoda@2111 2968 /** Is the annotation applicable to types? */
jjg@1521 2969 protected boolean isTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2970 Attribute.Compound atTarget =
jjg@1521 2971 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
jjg@1521 2972 if (atTarget == null) {
jjg@1521 2973 // An annotation without @Target is not a type annotation.
jjg@1521 2974 return false;
jjg@1521 2975 }
jjg@1521 2976
jjg@1521 2977 Attribute atValue = atTarget.member(names.value);
jjg@1521 2978 if (!(atValue instanceof Attribute.Array)) {
jjg@1521 2979 return false; // error recovery
jjg@1521 2980 }
jjg@1521 2981
jjg@1521 2982 Attribute.Array arr = (Attribute.Array) atValue;
jjg@1521 2983 for (Attribute app : arr.values) {
jjg@1521 2984 if (!(app instanceof Attribute.Enum)) {
jjg@1521 2985 return false; // recovery
jjg@1521 2986 }
jjg@1521 2987 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 2988
jjg@1521 2989 if (e.value.name == names.TYPE_USE)
jjg@1521 2990 return true;
jjg@1521 2991 else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER)
jjg@1521 2992 return true;
jjg@1521 2993 }
jjg@1521 2994 return false;
jjg@1521 2995 }
jjg@1521 2996
duke@1 2997 /** Is the annotation applicable to the symbol? */
duke@1 2998 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 2999 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jjg@1521 3000 Name[] targets;
jlahoda@2210 3001
jfranck@1313 3002 if (arr == null) {
jjg@1521 3003 targets = defaultTargetMetaInfo(a, s);
jjg@1521 3004 } else {
jjg@1521 3005 // TODO: can we optimize this?
jjg@1521 3006 targets = new Name[arr.values.length];
jjg@1521 3007 for (int i=0; i<arr.values.length; ++i) {
jjg@1521 3008 Attribute app = arr.values[i];
jjg@1521 3009 if (!(app instanceof Attribute.Enum)) {
jjg@1521 3010 return true; // recovery
jjg@1521 3011 }
jjg@1521 3012 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 3013 targets[i] = e.value.name;
jjg@1521 3014 }
jfranck@1313 3015 }
jjg@1521 3016 for (Name target : targets) {
jjg@1521 3017 if (target == names.TYPE)
jlahoda@2210 3018 { if (s.kind == TYP) return true; }
jjg@1521 3019 else if (target == names.FIELD)
duke@1 3020 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
jjg@1521 3021 else if (target == names.METHOD)
duke@1 3022 { if (s.kind == MTH && !s.isConstructor()) return true; }
jjg@1521 3023 else if (target == names.PARAMETER)
duke@1 3024 { if (s.kind == VAR &&
duke@1 3025 s.owner.kind == MTH &&
duke@1 3026 (s.flags() & PARAMETER) != 0)
duke@1 3027 return true;
duke@1 3028 }
jjg@1521 3029 else if (target == names.CONSTRUCTOR)
duke@1 3030 { if (s.kind == MTH && s.isConstructor()) return true; }
jjg@1521 3031 else if (target == names.LOCAL_VARIABLE)
duke@1 3032 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 3033 (s.flags() & PARAMETER) == 0)
duke@1 3034 return true;
duke@1 3035 }
jjg@1521 3036 else if (target == names.ANNOTATION_TYPE)
duke@1 3037 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 3038 return true;
duke@1 3039 }
jjg@1521 3040 else if (target == names.PACKAGE)
duke@1 3041 { if (s.kind == PCK) return true; }
jjg@1521 3042 else if (target == names.TYPE_USE)
jjg@308 3043 { if (s.kind == TYP ||
jjg@308 3044 s.kind == VAR ||
jjg@308 3045 (s.kind == MTH && !s.isConstructor() &&
jjg@1521 3046 !s.type.getReturnType().hasTag(VOID)) ||
jjg@1521 3047 (s.kind == MTH && s.isConstructor()))
jjg@1521 3048 return true;
jjg@1521 3049 }
jjg@1521 3050 else if (target == names.TYPE_PARAMETER)
jjg@1521 3051 { if (s.kind == TYP && s.type.hasTag(TYPEVAR))
jjg@308 3052 return true;
jjg@308 3053 }
duke@1 3054 else
duke@1 3055 return true; // recovery
duke@1 3056 }
duke@1 3057 return false;
duke@1 3058 }
duke@1 3059
jfranck@1313 3060
jfranck@1313 3061 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 3062 Attribute.Compound atTarget =
jfranck@1313 3063 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 3064 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 3065 Attribute atValue = atTarget.member(names.value);
jfranck@1313 3066 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 3067 return (Attribute.Array) atValue;
jfranck@1313 3068 }
jfranck@1313 3069
jjg@1521 3070 private final Name[] dfltTargetMeta;
jjg@1521 3071 private Name[] defaultTargetMetaInfo(JCAnnotation a, Symbol s) {
jjg@1521 3072 return dfltTargetMeta;
jjg@1521 3073 }
jjg@1521 3074
duke@1 3075 /** Check an annotation value.
jfranck@1445 3076 *
jfranck@1445 3077 * @param a The annotation tree to check
jfranck@1445 3078 * @return true if this annotation tree is valid, otherwise false
duke@1 3079 */
jfranck@1445 3080 public boolean validateAnnotationDeferErrors(JCAnnotation a) {
jfranck@1445 3081 boolean res = false;
jfranck@1445 3082 final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log);
jfranck@1445 3083 try {
jfranck@1445 3084 res = validateAnnotation(a);
jfranck@1445 3085 } finally {
jfranck@1445 3086 log.popDiagnosticHandler(diagHandler);
jfranck@1445 3087 }
jfranck@1445 3088 return res;
jfranck@1445 3089 }
jfranck@1445 3090
jfranck@1445 3091 private boolean validateAnnotation(JCAnnotation a) {
jfranck@1445 3092 boolean isValid = true;
jfranck@1445 3093 // collect an inventory of the annotation elements
jfranck@1445 3094 Set<MethodSymbol> members = new LinkedHashSet<MethodSymbol>();
duke@1 3095 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
jfranck@1729 3096 e != null;
jfranck@1729 3097 e = e.sibling)
mcimadamore@1920 3098 if (e.sym.kind == MTH && e.sym.name != names.clinit &&
mcimadamore@1920 3099 (e.sym.flags() & SYNTHETIC) == 0)
duke@1 3100 members.add((MethodSymbol) e.sym);
duke@1 3101
jfranck@1445 3102 // remove the ones that are assigned values
duke@1 3103 for (JCTree arg : a.args) {
jjg@1127 3104 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 3105 JCAssign assign = (JCAssign) arg;
duke@1 3106 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 3107 if (m == null || m.type.isErroneous()) continue;
jfranck@1445 3108 if (!members.remove(m)) {
jfranck@1445 3109 isValid = false;
jjg@479 3110 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 3111 m.name, a.type);
jfranck@1445 3112 }
duke@1 3113 }
duke@1 3114
duke@1 3115 // all the remaining ones better have default values
jfranck@1445 3116 List<Name> missingDefaults = List.nil();
mcimadamore@632 3117 for (MethodSymbol m : members) {
mcimadamore@632 3118 if (m.defaultValue == null && !m.type.isErroneous()) {
jfranck@1445 3119 missingDefaults = missingDefaults.append(m.name);
mcimadamore@632 3120 }
mcimadamore@632 3121 }
jfranck@1445 3122 missingDefaults = missingDefaults.reverse();
mcimadamore@632 3123 if (missingDefaults.nonEmpty()) {
jfranck@1445 3124 isValid = false;
mcimadamore@632 3125 String key = (missingDefaults.size() > 1)
mcimadamore@632 3126 ? "annotation.missing.default.value.1"
mcimadamore@632 3127 : "annotation.missing.default.value";
mcimadamore@632 3128 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 3129 }
duke@1 3130
duke@1 3131 // special case: java.lang.annotation.Target must not have
duke@1 3132 // repeated values in its value member
duke@1 3133 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 3134 a.args.tail == null)
jfranck@1445 3135 return isValid;
duke@1 3136
jfranck@1445 3137 if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery
duke@1 3138 JCAssign assign = (JCAssign) a.args.head;
duke@1 3139 Symbol m = TreeInfo.symbol(assign.lhs);
jfranck@1445 3140 if (m.name != names.value) return false;
duke@1 3141 JCTree rhs = assign.rhs;
jfranck@1445 3142 if (!rhs.hasTag(NEWARRAY)) return false;
duke@1 3143 JCNewArray na = (JCNewArray) rhs;
duke@1 3144 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 3145 for (JCTree elem : na.elems) {
duke@1 3146 if (!targets.add(TreeInfo.symbol(elem))) {
jfranck@1445 3147 isValid = false;
duke@1 3148 log.error(elem.pos(), "repeated.annotation.target");
duke@1 3149 }
duke@1 3150 }
jfranck@1445 3151 return isValid;
duke@1 3152 }
duke@1 3153
duke@1 3154 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 3155 if (allowAnnotations &&
mcimadamore@795 3156 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 3157 (s.flags() & DEPRECATED) != 0 &&
duke@1 3158 !syms.deprecatedType.isErroneous() &&
duke@1 3159 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 3160 log.warning(LintCategory.DEP_ANN,
jjg@612 3161 pos, "missing.deprecated.annotation");
duke@1 3162 }
duke@1 3163 }
duke@1 3164
mcimadamore@852 3165 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 3166 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 3167 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 3168 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 3169 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3170 @Override
mcimadamore@852 3171 public void report() {
mcimadamore@852 3172 warnDeprecated(pos, s);
mcimadamore@852 3173 }
mcimadamore@852 3174 });
jjg@1157 3175 }
mcimadamore@852 3176 }
mcimadamore@852 3177
mcimadamore@852 3178 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 3179 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 3180 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3181 public void report() {
mcimadamore@852 3182 if (enableSunApiLintControl)
mcimadamore@852 3183 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 3184 else
mcimadamore@1218 3185 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 3186 }
mcimadamore@852 3187 });
mcimadamore@852 3188 }
mcimadamore@852 3189 }
mcimadamore@852 3190
jjg@1569 3191 void checkProfile(final DiagnosticPosition pos, final Symbol s) {
jjg@1569 3192 if (profile != Profile.DEFAULT && (s.flags() & NOT_IN_PROFILE) != 0) {
jjg@1569 3193 log.error(pos, "not.in.profile", s, profile);
jjg@1569 3194 }
jjg@1569 3195 }
jjg@1569 3196
duke@1 3197 /* *************************************************************************
duke@1 3198 * Check for recursive annotation elements.
duke@1 3199 **************************************************************************/
duke@1 3200
duke@1 3201 /** Check for cycles in the graph of annotation elements.
duke@1 3202 */
duke@1 3203 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 3204 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 3205 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 3206 try {
duke@1 3207 tree.sym.flags_field |= LOCKED;
duke@1 3208 for (JCTree def : tree.defs) {
jjg@1127 3209 if (!def.hasTag(METHODDEF)) continue;
duke@1 3210 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 3211 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 3212 }
duke@1 3213 } finally {
duke@1 3214 tree.sym.flags_field &= ~LOCKED;
duke@1 3215 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 3216 }
duke@1 3217 }
duke@1 3218
duke@1 3219 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 3220 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 3221 return;
duke@1 3222 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 3223 log.error(pos, "cyclic.annotation.element");
duke@1 3224 return;
duke@1 3225 }
duke@1 3226 try {
duke@1 3227 tsym.flags_field |= LOCKED;
duke@1 3228 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 3229 Symbol s = e.sym;
duke@1 3230 if (s.kind != Kinds.MTH)
duke@1 3231 continue;
duke@1 3232 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 3233 }
duke@1 3234 } finally {
duke@1 3235 tsym.flags_field &= ~LOCKED;
duke@1 3236 tsym.flags_field |= ACYCLIC_ANN;
duke@1 3237 }
duke@1 3238 }
duke@1 3239
duke@1 3240 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
jjg@1374 3241 switch (type.getTag()) {
jjg@1374 3242 case CLASS:
duke@1 3243 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 3244 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 3245 break;
jjg@1374 3246 case ARRAY:
duke@1 3247 checkAnnotationResType(pos, types.elemtype(type));
duke@1 3248 break;
duke@1 3249 default:
duke@1 3250 break; // int etc
duke@1 3251 }
duke@1 3252 }
duke@1 3253
duke@1 3254 /* *************************************************************************
duke@1 3255 * Check for cycles in the constructor call graph.
duke@1 3256 **************************************************************************/
duke@1 3257
duke@1 3258 /** Check for cycles in the graph of constructors calling other
duke@1 3259 * constructors.
duke@1 3260 */
duke@1 3261 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 3262 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 3263
duke@1 3264 // enter each constructor this-call into the map
duke@1 3265 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 3266 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 3267 if (app == null) continue;
duke@1 3268 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 3269 if (TreeInfo.name(app.meth) == names._this) {
duke@1 3270 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 3271 } else {
duke@1 3272 meth.sym.flags_field |= ACYCLIC;
duke@1 3273 }
duke@1 3274 }
duke@1 3275
duke@1 3276 // Check for cycles in the map
duke@1 3277 Symbol[] ctors = new Symbol[0];
duke@1 3278 ctors = callMap.keySet().toArray(ctors);
duke@1 3279 for (Symbol caller : ctors) {
duke@1 3280 checkCyclicConstructor(tree, caller, callMap);
duke@1 3281 }
duke@1 3282 }
duke@1 3283
duke@1 3284 /** Look in the map to see if the given constructor is part of a
duke@1 3285 * call cycle.
duke@1 3286 */
duke@1 3287 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 3288 Map<Symbol,Symbol> callMap) {
duke@1 3289 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 3290 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 3291 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 3292 "recursive.ctor.invocation");
duke@1 3293 } else {
duke@1 3294 ctor.flags_field |= LOCKED;
duke@1 3295 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 3296 ctor.flags_field &= ~LOCKED;
duke@1 3297 }
duke@1 3298 ctor.flags_field |= ACYCLIC;
duke@1 3299 }
duke@1 3300 }
duke@1 3301
duke@1 3302 /* *************************************************************************
duke@1 3303 * Miscellaneous
duke@1 3304 **************************************************************************/
duke@1 3305
duke@1 3306 /**
duke@1 3307 * Return the opcode of the operator but emit an error if it is an
duke@1 3308 * error.
duke@1 3309 * @param pos position for error reporting.
duke@1 3310 * @param operator an operator
duke@1 3311 * @param tag a tree tag
duke@1 3312 * @param left type of left hand side
duke@1 3313 * @param right type of right hand side
duke@1 3314 */
duke@1 3315 int checkOperator(DiagnosticPosition pos,
duke@1 3316 OperatorSymbol operator,
jjg@1127 3317 JCTree.Tag tag,
duke@1 3318 Type left,
duke@1 3319 Type right) {
duke@1 3320 if (operator.opcode == ByteCodes.error) {
duke@1 3321 log.error(pos,
mcimadamore@853 3322 "operator.cant.be.applied.1",
duke@1 3323 treeinfo.operatorName(tag),
mcimadamore@853 3324 left, right);
duke@1 3325 }
duke@1 3326 return operator.opcode;
duke@1 3327 }
duke@1 3328
duke@1 3329
duke@1 3330 /**
duke@1 3331 * Check for division by integer constant zero
duke@1 3332 * @param pos Position for error reporting.
duke@1 3333 * @param operator The operator for the expression
duke@1 3334 * @param operand The right hand operand for the expression
duke@1 3335 */
duke@1 3336 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3337 if (operand.constValue() != null
mcimadamore@795 3338 && lint.isEnabled(LintCategory.DIVZERO)
vromero@1826 3339 && operand.getTag().isSubRangeOf(LONG)
duke@1 3340 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3341 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3342 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3343 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3344 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3345 }
duke@1 3346 }
duke@1 3347 }
duke@1 3348
duke@1 3349 /**
duke@1 3350 * Check for empty statements after if
duke@1 3351 */
duke@1 3352 void checkEmptyIf(JCIf tree) {
jjg@1127 3353 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3354 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3355 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3356 }
duke@1 3357
duke@1 3358 /** Check that symbol is unique in given scope.
duke@1 3359 * @param pos Position for error reporting.
duke@1 3360 * @param sym The symbol.
duke@1 3361 * @param s The scope.
duke@1 3362 */
duke@1 3363 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3364 if (sym.type.isErroneous())
duke@1 3365 return true;
duke@1 3366 if (sym.owner.name == names.any) return false;
duke@1 3367 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3368 if (sym != e.sym &&
mcimadamore@858 3369 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3370 sym.kind == e.sym.kind &&
mcimadamore@858 3371 sym.name != names.error &&
emc@2024 3372 (sym.kind != MTH ||
emc@2024 3373 types.hasSameArgs(sym.type, e.sym.type) ||
emc@2024 3374 types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3375 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3376 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3377 return true;
mcimadamore@907 3378 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3379 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3380 sym.flags_field |= CLASH;
mcimadamore@844 3381 return true;
mcimadamore@844 3382 } else {
duke@1 3383 duplicateError(pos, e.sym);
mcimadamore@844 3384 return false;
mcimadamore@844 3385 }
duke@1 3386 }
duke@1 3387 }
duke@1 3388 return true;
duke@1 3389 }
mcimadamore@844 3390
mcimadamore@858 3391 /** Report duplicate declaration error.
mcimadamore@858 3392 */
mcimadamore@858 3393 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3394 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3395 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3396 }
mcimadamore@858 3397 }
duke@1 3398
duke@1 3399 /** Check that single-type import is not already imported or top-level defined,
duke@1 3400 * but make an exception for two single-type imports which denote the same type.
duke@1 3401 * @param pos Position for error reporting.
duke@1 3402 * @param sym The symbol.
duke@1 3403 * @param s The scope
duke@1 3404 */
duke@1 3405 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3406 return checkUniqueImport(pos, sym, s, false);
duke@1 3407 }
duke@1 3408
duke@1 3409 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3410 * but make an exception for two single-type imports which denote the same type.
duke@1 3411 * @param pos Position for error reporting.
duke@1 3412 * @param sym The symbol.
duke@1 3413 * @param s The scope
duke@1 3414 */
duke@1 3415 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3416 return checkUniqueImport(pos, sym, s, true);
duke@1 3417 }
duke@1 3418
duke@1 3419 /** Check that single-type import is not already imported or top-level defined,
duke@1 3420 * but make an exception for two single-type imports which denote the same type.
duke@1 3421 * @param pos Position for error reporting.
duke@1 3422 * @param sym The symbol.
duke@1 3423 * @param s The scope.
duke@1 3424 * @param staticImport Whether or not this was a static import
duke@1 3425 */
duke@1 3426 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3427 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3428 // is encountered class entered via a class declaration?
duke@1 3429 boolean isClassDecl = e.scope == s;
duke@1 3430 if ((isClassDecl || sym != e.sym) &&
duke@1 3431 sym.kind == e.sym.kind &&
mcimadamore@1945 3432 sym.name != names.error &&
mcimadamore@1945 3433 (!staticImport || !e.isStaticallyImported())) {
duke@1 3434 if (!e.sym.type.isErroneous()) {
duke@1 3435 if (!isClassDecl) {
duke@1 3436 if (staticImport)
emc@2102 3437 log.error(pos, "already.defined.static.single.import", e.sym);
duke@1 3438 else
emc@2102 3439 log.error(pos, "already.defined.single.import", e.sym);
duke@1 3440 }
duke@1 3441 else if (sym != e.sym)
emc@2102 3442 log.error(pos, "already.defined.this.unit", e.sym);
duke@1 3443 }
duke@1 3444 return false;
duke@1 3445 }
duke@1 3446 }
duke@1 3447 return true;
duke@1 3448 }
duke@1 3449
duke@1 3450 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3451 */
duke@1 3452 public void checkCanonical(JCTree tree) {
duke@1 3453 if (!isCanonical(tree))
duke@1 3454 log.error(tree.pos(), "import.requires.canonical",
duke@1 3455 TreeInfo.symbol(tree));
duke@1 3456 }
duke@1 3457 // where
duke@1 3458 private boolean isCanonical(JCTree tree) {
jjg@1127 3459 while (tree.hasTag(SELECT)) {
duke@1 3460 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3461 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3462 return false;
duke@1 3463 tree = s.selected;
duke@1 3464 }
duke@1 3465 return true;
duke@1 3466 }
duke@1 3467
ohrstrom@1384 3468 /** Check that an auxiliary class is not accessed from any other file than its own.
ohrstrom@1384 3469 */
ohrstrom@1384 3470 void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) {
ohrstrom@1384 3471 if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) &&
ohrstrom@1384 3472 (c.flags() & AUXILIARY) != 0 &&
ohrstrom@1384 3473 rs.isAccessible(env, c) &&
ohrstrom@1384 3474 !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile))
ohrstrom@1384 3475 {
ohrstrom@1384 3476 log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file",
ohrstrom@1384 3477 c, c.sourcefile);
ohrstrom@1384 3478 }
ohrstrom@1384 3479 }
ohrstrom@1384 3480
duke@1 3481 private class ConversionWarner extends Warner {
mcimadamore@795 3482 final String uncheckedKey;
duke@1 3483 final Type found;
duke@1 3484 final Type expected;
mcimadamore@795 3485 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3486 super(pos);
mcimadamore@795 3487 this.uncheckedKey = uncheckedKey;
duke@1 3488 this.found = found;
duke@1 3489 this.expected = expected;
duke@1 3490 }
duke@1 3491
jjg@398 3492 @Override
mcimadamore@795 3493 public void warn(LintCategory lint) {
duke@1 3494 boolean warned = this.warned;
mcimadamore@795 3495 super.warn(lint);
duke@1 3496 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3497 switch (lint) {
mcimadamore@795 3498 case UNCHECKED:
mcimadamore@795 3499 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3500 break;
mcimadamore@795 3501 case VARARGS:
mcimadamore@795 3502 if (method != null &&
mcimadamore@795 3503 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3504 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3505 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3506 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3507 }
mcimadamore@795 3508 break;
mcimadamore@795 3509 default:
mcimadamore@795 3510 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3511 }
duke@1 3512 }
duke@1 3513 }
duke@1 3514
duke@1 3515 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3516 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3517 }
duke@1 3518
duke@1 3519 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3520 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3521 }
jlahoda@2111 3522
jlahoda@2111 3523 public void checkFunctionalInterface(JCClassDecl tree, ClassSymbol cs) {
jlahoda@2111 3524 Compound functionalType = cs.attribute(syms.functionalInterfaceType.tsym);
jlahoda@2111 3525
jlahoda@2111 3526 if (functionalType != null) {
jlahoda@2111 3527 try {
jlahoda@2111 3528 types.findDescriptorSymbol((TypeSymbol)cs);
jlahoda@2111 3529 } catch (Types.FunctionDescriptorLookupError ex) {
jlahoda@2111 3530 DiagnosticPosition pos = tree.pos();
jlahoda@2111 3531 for (JCAnnotation a : tree.getModifiers().annotations) {
jlahoda@2111 3532 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
jlahoda@2111 3533 pos = a.pos();
jlahoda@2111 3534 break;
jlahoda@2111 3535 }
jlahoda@2111 3536 }
jlahoda@2111 3537 log.error(pos, "bad.functional.intf.anno.1", ex.getDiagnostic());
jlahoda@2111 3538 }
jlahoda@2111 3539 }
jlahoda@2111 3540 }
duke@1 3541 }

mercurial