src/share/classes/com/sun/tools/javac/comp/Check.java

Fri, 08 Feb 2013 09:12:37 +0000

author
vromero
date
Fri, 08 Feb 2013 09:12:37 +0000
changeset 1555
762d0af062f5
parent 1550
1df20330f6bd
child 1571
af8417e590f4
child 1579
0baaae675b19
permissions
-rw-r--r--

7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class
Reviewed-by: mcimadamore

duke@1 1 /*
jjg@1492 2 * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
jjg@1521 29
ohrstrom@1384 30 import javax.tools.JavaFileManager;
duke@1 31
duke@1 32 import com.sun.tools.javac.code.*;
duke@1 33 import com.sun.tools.javac.jvm.*;
duke@1 34 import com.sun.tools.javac.tree.*;
duke@1 35 import com.sun.tools.javac.util.*;
duke@1 36 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 37 import com.sun.tools.javac.util.List;
duke@1 38
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 43 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 44 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1550 45 import com.sun.tools.javac.comp.Infer.FreeTypeListener;
mcimadamore@1510 46 import com.sun.tools.javac.tree.JCTree.*;
mcimadamore@1510 47 import com.sun.tools.javac.tree.JCTree.JCPolyExpression.*;
duke@1 48
duke@1 49 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 50 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 51 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 52 import static com.sun.tools.javac.code.Kinds.*;
jjg@1374 53 import static com.sun.tools.javac.code.TypeTag.*;
jjg@1374 54 import static com.sun.tools.javac.code.TypeTag.WILDCARD;
duke@1 55
jjg@1127 56 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 57
duke@1 58 /** Type checking helper class for the attribution phase.
duke@1 59 *
jjg@581 60 * <p><b>This is NOT part of any supported API.
jjg@581 61 * If you write code that depends on this, you do so at your own risk.
duke@1 62 * This code and its internal interfaces are subject to change or
duke@1 63 * deletion without notice.</b>
duke@1 64 */
duke@1 65 public class Check {
duke@1 66 protected static final Context.Key<Check> checkKey =
duke@1 67 new Context.Key<Check>();
duke@1 68
jjg@113 69 private final Names names;
duke@1 70 private final Log log;
mcimadamore@1219 71 private final Resolve rs;
duke@1 72 private final Symtab syms;
mcimadamore@690 73 private final Enter enter;
mcimadamore@1347 74 private final DeferredAttr deferredAttr;
duke@1 75 private final Infer infer;
duke@1 76 private final Types types;
mcimadamore@89 77 private final JCDiagnostic.Factory diags;
mcimadamore@359 78 private boolean warnOnSyntheticConflicts;
jjg@576 79 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 80 private boolean enableSunApiLintControl;
duke@1 81 private final TreeInfo treeinfo;
ohrstrom@1384 82 private final JavaFileManager fileManager;
duke@1 83
duke@1 84 // The set of lint options currently in effect. It is initialized
duke@1 85 // from the context, and then is set/reset as needed by Attr as it
duke@1 86 // visits all the various parts of the trees during attribution.
duke@1 87 private Lint lint;
duke@1 88
mcimadamore@795 89 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 90 // Attr as it visits new method declarations.
mcimadamore@795 91 private MethodSymbol method;
mcimadamore@795 92
duke@1 93 public static Check instance(Context context) {
duke@1 94 Check instance = context.get(checkKey);
duke@1 95 if (instance == null)
duke@1 96 instance = new Check(context);
duke@1 97 return instance;
duke@1 98 }
duke@1 99
duke@1 100 protected Check(Context context) {
duke@1 101 context.put(checkKey, this);
duke@1 102
jjg@113 103 names = Names.instance(context);
jjg@1521 104 dfltTargetMeta = new Name[] { names.PACKAGE, names.TYPE,
jjg@1521 105 names.FIELD, names.METHOD, names.CONSTRUCTOR,
jjg@1521 106 names.ANNOTATION_TYPE, names.LOCAL_VARIABLE, names.PARAMETER};
duke@1 107 log = Log.instance(context);
mcimadamore@1219 108 rs = Resolve.instance(context);
duke@1 109 syms = Symtab.instance(context);
mcimadamore@690 110 enter = Enter.instance(context);
mcimadamore@1347 111 deferredAttr = DeferredAttr.instance(context);
duke@1 112 infer = Infer.instance(context);
duke@1 113 this.types = Types.instance(context);
mcimadamore@89 114 diags = JCDiagnostic.Factory.instance(context);
duke@1 115 Options options = Options.instance(context);
duke@1 116 lint = Lint.instance(context);
duke@1 117 treeinfo = TreeInfo.instance(context);
ohrstrom@1384 118 fileManager = context.get(JavaFileManager.class);
duke@1 119
duke@1 120 Source source = Source.instance(context);
duke@1 121 allowGenerics = source.allowGenerics();
mcimadamore@1219 122 allowVarargs = source.allowVarargs();
duke@1 123 allowAnnotations = source.allowAnnotations();
jjg@398 124 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 125 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
mcimadamore@1393 126 allowDefaultMethods = source.allowDefaultMethods();
mcimadamore@1415 127 allowStrictMethodClashCheck = source.allowStrictMethodClashCheck();
jjg@1157 128 complexInference = options.isSet("complexinference");
jjg@700 129 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 130 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 131 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 132
jjg@398 133 Target target = Target.instance(context);
jjg@398 134 syntheticNameChar = target.syntheticNameChar();
jjg@398 135
duke@1 136 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 137 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 138 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 139 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 140
jjg@60 141 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 142 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 143 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 144 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 145 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 146 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 147
mcimadamore@852 148 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 149 }
duke@1 150
duke@1 151 /** Switch: generics enabled?
duke@1 152 */
duke@1 153 boolean allowGenerics;
duke@1 154
mcimadamore@1219 155 /** Switch: varargs enabled?
mcimadamore@1219 156 */
mcimadamore@1219 157 boolean allowVarargs;
mcimadamore@1219 158
duke@1 159 /** Switch: annotations enabled?
duke@1 160 */
duke@1 161 boolean allowAnnotations;
duke@1 162
jjg@398 163 /** Switch: covariant returns enabled?
jjg@398 164 */
jjg@398 165 boolean allowCovariantReturns;
jjg@398 166
mcimadamore@795 167 /** Switch: simplified varargs enabled?
mcimadamore@795 168 */
mcimadamore@795 169 boolean allowSimplifiedVarargs;
mcimadamore@795 170
mcimadamore@1393 171 /** Switch: default methods enabled?
mcimadamore@1393 172 */
mcimadamore@1393 173 boolean allowDefaultMethods;
mcimadamore@1393 174
mcimadamore@1393 175 /** Switch: should unrelated return types trigger a method clash?
mcimadamore@1393 176 */
mcimadamore@1393 177 boolean allowStrictMethodClashCheck;
mcimadamore@1393 178
duke@1 179 /** Switch: -complexinference option set?
duke@1 180 */
duke@1 181 boolean complexInference;
duke@1 182
jjg@398 183 /** Character for synthetic names
jjg@398 184 */
jjg@398 185 char syntheticNameChar;
jjg@398 186
duke@1 187 /** A table mapping flat names of all compiled classes in this run to their
duke@1 188 * symbols; maintained from outside.
duke@1 189 */
duke@1 190 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 191
duke@1 192 /** A handler for messages about deprecated usage.
duke@1 193 */
duke@1 194 private MandatoryWarningHandler deprecationHandler;
duke@1 195
duke@1 196 /** A handler for messages about unchecked or unsafe usage.
duke@1 197 */
duke@1 198 private MandatoryWarningHandler uncheckedHandler;
duke@1 199
jjg@582 200 /** A handler for messages about using proprietary API.
jjg@377 201 */
jjg@377 202 private MandatoryWarningHandler sunApiHandler;
duke@1 203
mcimadamore@852 204 /** A handler for deferred lint warnings.
mcimadamore@852 205 */
mcimadamore@852 206 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 207
duke@1 208 /* *************************************************************************
duke@1 209 * Errors and Warnings
duke@1 210 **************************************************************************/
duke@1 211
duke@1 212 Lint setLint(Lint newLint) {
duke@1 213 Lint prev = lint;
duke@1 214 lint = newLint;
duke@1 215 return prev;
duke@1 216 }
duke@1 217
mcimadamore@852 218 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 219 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 220 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 221 return prev;
mcimadamore@852 222 }
mcimadamore@852 223
mcimadamore@795 224 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 225 MethodSymbol prev = method;
mcimadamore@795 226 method = newMethod;
mcimadamore@795 227 return prev;
mcimadamore@795 228 }
mcimadamore@795 229
duke@1 230 /** Warn about deprecated symbol.
duke@1 231 * @param pos Position to be used for error reporting.
duke@1 232 * @param sym The deprecated symbol.
duke@1 233 */
duke@1 234 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 235 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 236 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 237 }
duke@1 238
duke@1 239 /** Warn about unchecked operation.
duke@1 240 * @param pos Position to be used for error reporting.
duke@1 241 * @param msg A string describing the problem.
duke@1 242 */
duke@1 243 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 244 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 245 uncheckedHandler.report(pos, msg, args);
duke@1 246 }
duke@1 247
mcimadamore@580 248 /** Warn about unsafe vararg method decl.
mcimadamore@580 249 * @param pos Position to be used for error reporting.
mcimadamore@580 250 */
mcimadamore@795 251 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 252 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 253 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 254 }
mcimadamore@580 255
jjg@582 256 /** Warn about using proprietary API.
jjg@377 257 * @param pos Position to be used for error reporting.
jjg@377 258 * @param msg A string describing the problem.
jjg@377 259 */
jjg@377 260 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 261 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 262 sunApiHandler.report(pos, msg, args);
jjg@377 263 }
jjg@377 264
jjg@505 265 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 266 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 267 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 268 }
jjg@505 269
duke@1 270 /**
duke@1 271 * Report any deferred diagnostics.
duke@1 272 */
duke@1 273 public void reportDeferredDiagnostics() {
duke@1 274 deprecationHandler.reportDeferredDiagnostic();
duke@1 275 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 276 sunApiHandler.reportDeferredDiagnostic();
duke@1 277 }
duke@1 278
duke@1 279
duke@1 280 /** Report a failure to complete a class.
duke@1 281 * @param pos Position to be used for error reporting.
duke@1 282 * @param ex The failure to report.
duke@1 283 */
duke@1 284 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 285 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 286 if (ex instanceof ClassReader.BadClassFile
jjg@576 287 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 288 else return syms.errType;
duke@1 289 }
duke@1 290
duke@1 291 /** Report an error that wrong type tag was found.
duke@1 292 * @param pos Position to be used for error reporting.
duke@1 293 * @param required An internationalized string describing the type tag
duke@1 294 * required.
duke@1 295 * @param found The type that was found.
duke@1 296 */
duke@1 297 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 298 // this error used to be raised by the parser,
jrose@267 299 // but has been delayed to this point:
jjg@1374 300 if (found instanceof Type && ((Type)found).hasTag(VOID)) {
jrose@267 301 log.error(pos, "illegal.start.of.type");
jrose@267 302 return syms.errType;
jrose@267 303 }
duke@1 304 log.error(pos, "type.found.req", found, required);
jjg@110 305 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 306 }
duke@1 307
duke@1 308 /** Report an error that symbol cannot be referenced before super
duke@1 309 * has been called.
duke@1 310 * @param pos Position to be used for error reporting.
duke@1 311 * @param sym The referenced symbol.
duke@1 312 */
duke@1 313 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 314 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 315 }
duke@1 316
duke@1 317 /** Report duplicate declaration error.
duke@1 318 */
duke@1 319 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 320 if (!sym.type.isErroneous()) {
mcimadamore@1085 321 Symbol location = sym.location();
mcimadamore@1085 322 if (location.kind == MTH &&
mcimadamore@1085 323 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 324 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 325 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 326 sym.location().enclClass());
mcimadamore@1085 327 } else {
mcimadamore@1085 328 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 329 kindName(sym.location()), sym.location());
mcimadamore@1085 330 }
duke@1 331 }
duke@1 332 }
duke@1 333
duke@1 334 /** Report array/varargs duplicate declaration
duke@1 335 */
duke@1 336 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 337 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 338 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 339 }
duke@1 340 }
duke@1 341
duke@1 342 /* ************************************************************************
duke@1 343 * duplicate declaration checking
duke@1 344 *************************************************************************/
duke@1 345
duke@1 346 /** Check that variable does not hide variable with same name in
duke@1 347 * immediately enclosing local scope.
duke@1 348 * @param pos Position for error reporting.
duke@1 349 * @param v The symbol.
duke@1 350 * @param s The scope.
duke@1 351 */
duke@1 352 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 353 if (s.next != null) {
duke@1 354 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 355 e.scope != null && e.sym.owner == v.owner;
duke@1 356 e = e.next()) {
duke@1 357 if (e.sym.kind == VAR &&
duke@1 358 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 359 v.name != names.error) {
duke@1 360 duplicateError(pos, e.sym);
duke@1 361 return;
duke@1 362 }
duke@1 363 }
duke@1 364 }
duke@1 365 }
duke@1 366
duke@1 367 /** Check that a class or interface does not hide a class or
duke@1 368 * interface with same name in immediately enclosing local scope.
duke@1 369 * @param pos Position for error reporting.
duke@1 370 * @param c The symbol.
duke@1 371 * @param s The scope.
duke@1 372 */
duke@1 373 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 374 if (s.next != null) {
duke@1 375 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 376 e.scope != null && e.sym.owner == c.owner;
duke@1 377 e = e.next()) {
jjg@1374 378 if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) &&
duke@1 379 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 380 c.name != names.error) {
duke@1 381 duplicateError(pos, e.sym);
duke@1 382 return;
duke@1 383 }
duke@1 384 }
duke@1 385 }
duke@1 386 }
duke@1 387
duke@1 388 /** Check that class does not have the same name as one of
duke@1 389 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 390 * return true if class is unique in its enclosing scope.
duke@1 391 * @param pos Position for error reporting.
duke@1 392 * @param name The class name.
duke@1 393 * @param s The enclosing scope.
duke@1 394 */
duke@1 395 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 396 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 397 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 398 duplicateError(pos, e.sym);
duke@1 399 return false;
duke@1 400 }
duke@1 401 }
duke@1 402 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 403 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 404 duplicateError(pos, sym);
duke@1 405 return true;
duke@1 406 }
duke@1 407 }
duke@1 408 return true;
duke@1 409 }
duke@1 410
duke@1 411 /* *************************************************************************
duke@1 412 * Class name generation
duke@1 413 **************************************************************************/
duke@1 414
duke@1 415 /** Return name of local class.
jjg@1358 416 * This is of the form {@code <enclClass> $ n <classname> }
duke@1 417 * where
duke@1 418 * enclClass is the flat name of the enclosing class,
duke@1 419 * classname is the simple name of the local class
duke@1 420 */
duke@1 421 Name localClassName(ClassSymbol c) {
duke@1 422 for (int i=1; ; i++) {
duke@1 423 Name flatname = names.
duke@1 424 fromString("" + c.owner.enclClass().flatname +
jjg@398 425 syntheticNameChar + i +
duke@1 426 c.name);
duke@1 427 if (compiled.get(flatname) == null) return flatname;
duke@1 428 }
duke@1 429 }
duke@1 430
duke@1 431 /* *************************************************************************
duke@1 432 * Type Checking
duke@1 433 **************************************************************************/
duke@1 434
mcimadamore@1238 435 /**
mcimadamore@1238 436 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 437 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 438 * vary significantly.
mcimadamore@1238 439 */
mcimadamore@1348 440 public interface CheckContext {
mcimadamore@1238 441 /**
mcimadamore@1238 442 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 443 */
mcimadamore@1238 444 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 445 /**
mcimadamore@1238 446 * Report a check error
mcimadamore@1238 447 */
mcimadamore@1296 448 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 449 /**
mcimadamore@1238 450 * Obtain a warner for this check context
mcimadamore@1238 451 */
mcimadamore@1238 452 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 453
mcimadamore@1337 454 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 455
mcimadamore@1347 456 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1238 457 }
mcimadamore@1238 458
mcimadamore@1238 459 /**
mcimadamore@1238 460 * This class represent a check context that is nested within another check
mcimadamore@1238 461 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 462 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 463 * the forwarding pattern.
mcimadamore@1238 464 */
mcimadamore@1238 465 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 466 CheckContext enclosingContext;
mcimadamore@1238 467
mcimadamore@1238 468 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 469 this.enclosingContext = enclosingContext;
mcimadamore@1238 470 }
mcimadamore@1238 471
mcimadamore@1238 472 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 473 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 474 }
mcimadamore@1238 475
mcimadamore@1296 476 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 477 enclosingContext.report(pos, details);
mcimadamore@1238 478 }
mcimadamore@1238 479
mcimadamore@1238 480 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 481 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 482 }
mcimadamore@1337 483
mcimadamore@1337 484 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 485 return enclosingContext.inferenceContext();
mcimadamore@1337 486 }
mcimadamore@1347 487
mcimadamore@1347 488 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 489 return enclosingContext.deferredAttrContext();
mcimadamore@1347 490 }
mcimadamore@1238 491 }
mcimadamore@1238 492
mcimadamore@1238 493 /**
mcimadamore@1238 494 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 495 */
mcimadamore@1238 496 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 497 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 498 log.error(pos, "prob.found.req", details);
mcimadamore@1238 499 }
mcimadamore@1238 500 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 501 return types.isAssignable(found, req, warn);
mcimadamore@1238 502 }
mcimadamore@1238 503
mcimadamore@1238 504 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 505 return convertWarner(pos, found, req);
mcimadamore@1238 506 }
mcimadamore@1337 507
mcimadamore@1337 508 public InferenceContext inferenceContext() {
mcimadamore@1337 509 return infer.emptyContext;
mcimadamore@1337 510 }
mcimadamore@1347 511
mcimadamore@1347 512 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 513 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 514 }
mcimadamore@1238 515 };
mcimadamore@1238 516
duke@1 517 /** Check that a given type is assignable to a given proto-type.
duke@1 518 * If it is, return the type, otherwise return errType.
duke@1 519 * @param pos Position to be used for error reporting.
duke@1 520 * @param found The type that was found.
duke@1 521 * @param req The type that was required.
duke@1 522 */
duke@1 523 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 524 return checkType(pos, found, req, basicHandler);
darcy@609 525 }
darcy@609 526
mcimadamore@1337 527 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 528 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 529 if (inferenceContext.free(req)) {
mcimadamore@1337 530 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 531 @Override
mcimadamore@1337 532 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1550 533 checkType(pos, found, inferenceContext.asInstType(req), checkContext);
mcimadamore@1337 534 }
mcimadamore@1337 535 });
mcimadamore@1337 536 }
jjg@1374 537 if (req.hasTag(ERROR))
duke@1 538 return req;
jjg@1374 539 if (req.hasTag(NONE))
duke@1 540 return found;
mcimadamore@1238 541 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 542 return found;
mcimadamore@1238 543 } else {
jjg@1374 544 if (found.getTag().isSubRangeOf(DOUBLE) && req.getTag().isSubRangeOf(DOUBLE)) {
mcimadamore@1296 545 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 546 return types.createErrorType(found);
mcimadamore@1238 547 }
mcimadamore@1296 548 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 549 return types.createErrorType(found);
duke@1 550 }
duke@1 551 }
duke@1 552
duke@1 553 /** Check that a given type can be cast to a given target type.
duke@1 554 * Return the result of the cast.
duke@1 555 * @param pos Position to be used for error reporting.
duke@1 556 * @param found The type that is being cast.
duke@1 557 * @param req The target type of the cast.
duke@1 558 */
duke@1 559 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 560 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 561 }
mcimadamore@1238 562 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 563 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 564 return req;
duke@1 565 } else {
mcimadamore@1296 566 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 567 return types.createErrorType(found);
duke@1 568 }
duke@1 569 }
mcimadamore@1237 570
mcimadamore@1237 571 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 572 * The problem should only be reported for non-292 cast
mcimadamore@1237 573 */
mcimadamore@1237 574 public void checkRedundantCast(Env<AttrContext> env, JCTypeCast tree) {
mcimadamore@1237 575 if (!tree.type.isErroneous() &&
mcimadamore@1348 576 (env.info.lint == null || env.info.lint.isEnabled(Lint.LintCategory.CAST))
mcimadamore@1348 577 && types.isSameType(tree.expr.type, tree.clazz.type)
jjg@1521 578 && !(ignoreAnnotatedCasts && TreeInfo.containsTypeAnnotation(tree.clazz))
mcimadamore@1348 579 && !is292targetTypeCast(tree)) {
mcimadamore@1237 580 log.warning(Lint.LintCategory.CAST,
mcimadamore@1237 581 tree.pos(), "redundant.cast", tree.expr.type);
mcimadamore@1237 582 }
mcimadamore@1237 583 }
mcimadamore@1237 584 //where
jjg@1521 585 private boolean is292targetTypeCast(JCTypeCast tree) {
jjg@1521 586 boolean is292targetTypeCast = false;
jjg@1521 587 JCExpression expr = TreeInfo.skipParens(tree.expr);
jjg@1521 588 if (expr.hasTag(APPLY)) {
jjg@1521 589 JCMethodInvocation apply = (JCMethodInvocation)expr;
jjg@1521 590 Symbol sym = TreeInfo.symbol(apply.meth);
jjg@1521 591 is292targetTypeCast = sym != null &&
jjg@1521 592 sym.kind == MTH &&
jjg@1521 593 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 594 }
jjg@1521 595 return is292targetTypeCast;
jjg@1521 596 }
mcimadamore@1237 597
jjg@1521 598 private static final boolean ignoreAnnotatedCasts = true;
duke@1 599
duke@1 600 /** Check that a type is within some bounds.
duke@1 601 *
jjg@1358 602 * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
duke@1 603 * type argument.
duke@1 604 * @param a The type that should be bounded by bs.
jjg@1358 605 * @param bound The bound.
duke@1 606 */
mcimadamore@1216 607 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 608 if (a.isUnbound()) {
mcimadamore@821 609 return true;
jjg@1374 610 } else if (!a.hasTag(WILDCARD)) {
mcimadamore@154 611 a = types.upperBound(a);
mcimadamore@1216 612 return types.isSubtype(a, bound);
mcimadamore@154 613 } else if (a.isExtendsBound()) {
mcimadamore@1415 614 return types.isCastable(bound, types.upperBound(a), types.noWarnings);
mcimadamore@154 615 } else if (a.isSuperBound()) {
mcimadamore@1216 616 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 617 }
mcimadamore@821 618 return true;
mcimadamore@154 619 }
duke@1 620
duke@1 621 /** Check that type is different from 'void'.
duke@1 622 * @param pos Position to be used for error reporting.
duke@1 623 * @param t The type to be checked.
duke@1 624 */
duke@1 625 Type checkNonVoid(DiagnosticPosition pos, Type t) {
jjg@1374 626 if (t.hasTag(VOID)) {
duke@1 627 log.error(pos, "void.not.allowed.here");
jjg@110 628 return types.createErrorType(t);
duke@1 629 } else {
duke@1 630 return t;
duke@1 631 }
duke@1 632 }
duke@1 633
mcimadamore@1496 634 Type checkClassOrArrayType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 635 if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
mcimadamore@1496 636 return typeTagError(pos,
mcimadamore@1496 637 diags.fragment("type.req.class.array"),
mcimadamore@1496 638 asTypeParam(t));
mcimadamore@1496 639 } else {
mcimadamore@1496 640 return t;
mcimadamore@1496 641 }
mcimadamore@1496 642 }
mcimadamore@1496 643
duke@1 644 /** Check that type is a class or interface type.
duke@1 645 * @param pos Position to be used for error reporting.
duke@1 646 * @param t The type to be checked.
duke@1 647 */
duke@1 648 Type checkClassType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 649 if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) {
duke@1 650 return typeTagError(pos,
mcimadamore@89 651 diags.fragment("type.req.class"),
mcimadamore@1496 652 asTypeParam(t));
mcimadamore@1496 653 } else {
duke@1 654 return t;
mcimadamore@1496 655 }
duke@1 656 }
mcimadamore@1496 657 //where
mcimadamore@1496 658 private Object asTypeParam(Type t) {
mcimadamore@1496 659 return (t.hasTag(TYPEVAR))
mcimadamore@1496 660 ? diags.fragment("type.parameter", t)
mcimadamore@1496 661 : t;
mcimadamore@1496 662 }
duke@1 663
mcimadamore@1352 664 /** Check that type is a valid qualifier for a constructor reference expression
mcimadamore@1352 665 */
mcimadamore@1352 666 Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 667 t = checkClassOrArrayType(pos, t);
jjg@1374 668 if (t.hasTag(CLASS)) {
mcimadamore@1352 669 if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
mcimadamore@1352 670 log.error(pos, "abstract.cant.be.instantiated");
mcimadamore@1352 671 t = types.createErrorType(t);
mcimadamore@1352 672 } else if ((t.tsym.flags() & ENUM) != 0) {
mcimadamore@1352 673 log.error(pos, "enum.cant.be.instantiated");
mcimadamore@1352 674 t = types.createErrorType(t);
mcimadamore@1352 675 }
mcimadamore@1352 676 }
mcimadamore@1352 677 return t;
mcimadamore@1352 678 }
mcimadamore@1352 679
duke@1 680 /** Check that type is a class or interface type.
duke@1 681 * @param pos Position to be used for error reporting.
duke@1 682 * @param t The type to be checked.
duke@1 683 * @param noBounds True if type bounds are illegal here.
duke@1 684 */
duke@1 685 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 686 t = checkClassType(pos, t);
duke@1 687 if (noBounds && t.isParameterized()) {
duke@1 688 List<Type> args = t.getTypeArguments();
duke@1 689 while (args.nonEmpty()) {
jjg@1374 690 if (args.head.hasTag(WILDCARD))
duke@1 691 return typeTagError(pos,
jjg@598 692 diags.fragment("type.req.exact"),
duke@1 693 args.head);
duke@1 694 args = args.tail;
duke@1 695 }
duke@1 696 }
duke@1 697 return t;
duke@1 698 }
duke@1 699
duke@1 700 /** Check that type is a reifiable class, interface or array type.
duke@1 701 * @param pos Position to be used for error reporting.
duke@1 702 * @param t The type to be checked.
duke@1 703 */
duke@1 704 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 705 t = checkClassOrArrayType(pos, t);
mcimadamore@1496 706 if (!t.isErroneous() && !types.isReifiable(t)) {
duke@1 707 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 708 return types.createErrorType(t);
duke@1 709 } else {
duke@1 710 return t;
duke@1 711 }
duke@1 712 }
duke@1 713
duke@1 714 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 715 * or a type variable.
duke@1 716 * @param pos Position to be used for error reporting.
duke@1 717 * @param t The type to be checked.
duke@1 718 */
duke@1 719 Type checkRefType(DiagnosticPosition pos, Type t) {
jjg@1374 720 if (t.isReference())
duke@1 721 return t;
jjg@1374 722 else
duke@1 723 return typeTagError(pos,
mcimadamore@89 724 diags.fragment("type.req.ref"),
duke@1 725 t);
duke@1 726 }
duke@1 727
jrose@267 728 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 729 * or a type variable.
jrose@267 730 * @param trees Original trees, used for error reporting.
jrose@267 731 * @param types The types to be checked.
jrose@267 732 */
jrose@267 733 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 734 List<JCExpression> tl = trees;
jrose@267 735 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 736 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 737 tl = tl.tail;
jrose@267 738 }
jrose@267 739 return types;
jrose@267 740 }
jrose@267 741
duke@1 742 /** Check that type is a null or reference type.
duke@1 743 * @param pos Position to be used for error reporting.
duke@1 744 * @param t The type to be checked.
duke@1 745 */
duke@1 746 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
jjg@1374 747 if (t.isNullOrReference())
duke@1 748 return t;
jjg@1374 749 else
duke@1 750 return typeTagError(pos,
mcimadamore@89 751 diags.fragment("type.req.ref"),
duke@1 752 t);
duke@1 753 }
duke@1 754
duke@1 755 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 756 * Return true if it doesn't.
duke@1 757 * @param pos Position to be used for error reporting.
duke@1 758 * @param flags The set of flags to be checked.
duke@1 759 * @param set1 Conflicting flags set #1.
duke@1 760 * @param set2 Conflicting flags set #2.
duke@1 761 */
duke@1 762 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 763 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 764 log.error(pos,
duke@1 765 "illegal.combination.of.modifiers",
mcimadamore@80 766 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 767 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 768 return false;
duke@1 769 } else
duke@1 770 return true;
duke@1 771 }
duke@1 772
mcimadamore@914 773 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 774 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 775 */
mcimadamore@914 776 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 777 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 778 t.isErroneous()) {
mcimadamore@914 779 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 780 } else if (tree.def != null) {
mcimadamore@914 781 log.error(tree.clazz.pos(),
mcimadamore@914 782 "cant.apply.diamond.1",
mcimadamore@914 783 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 784 return types.createErrorType(t);
mcimadamore@948 785 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 786 log.error(tree.clazz.pos(),
mcimadamore@914 787 "cant.apply.diamond.1",
mcimadamore@914 788 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 789 return types.createErrorType(t);
mcimadamore@993 790 } else if (tree.typeargs != null &&
mcimadamore@993 791 tree.typeargs.nonEmpty()) {
mcimadamore@993 792 log.error(tree.clazz.pos(),
mcimadamore@993 793 "cant.apply.diamond.1",
mcimadamore@993 794 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 795 return types.createErrorType(t);
mcimadamore@914 796 } else {
mcimadamore@914 797 return t;
mcimadamore@537 798 }
mcimadamore@537 799 }
mcimadamore@537 800
mcimadamore@795 801 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 802 MethodSymbol m = tree.sym;
mcimadamore@795 803 if (!allowSimplifiedVarargs) return;
mcimadamore@795 804 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 805 Type varargElemType = null;
mcimadamore@580 806 if (m.isVarArgs()) {
mcimadamore@795 807 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 808 }
mcimadamore@795 809 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 810 if (varargElemType != null) {
mcimadamore@795 811 log.error(tree,
mcimadamore@795 812 "varargs.invalid.trustme.anno",
mcimadamore@795 813 syms.trustMeType.tsym,
mcimadamore@795 814 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 815 } else {
mcimadamore@795 816 log.error(tree,
mcimadamore@795 817 "varargs.invalid.trustme.anno",
mcimadamore@795 818 syms.trustMeType.tsym,
mcimadamore@795 819 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 820 }
mcimadamore@795 821 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 822 types.isReifiable(varargElemType)) {
mcimadamore@795 823 warnUnsafeVararg(tree,
mcimadamore@795 824 "varargs.redundant.trustme.anno",
mcimadamore@795 825 syms.trustMeType.tsym,
mcimadamore@795 826 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 827 }
mcimadamore@795 828 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 829 !types.isReifiable(varargElemType)) {
mcimadamore@795 830 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 831 }
mcimadamore@580 832 }
mcimadamore@795 833 //where
mcimadamore@795 834 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 835 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 836 (s.isConstructor() ||
mcimadamore@795 837 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 838 }
mcimadamore@580 839
mcimadamore@1219 840 Type checkMethod(Type owntype,
mcimadamore@1219 841 Symbol sym,
mcimadamore@1219 842 Env<AttrContext> env,
mcimadamore@1219 843 final List<JCExpression> argtrees,
mcimadamore@1219 844 List<Type> argtypes,
mcimadamore@1226 845 boolean useVarargs,
mcimadamore@1226 846 boolean unchecked) {
mcimadamore@1219 847 // System.out.println("call : " + env.tree);
mcimadamore@1219 848 // System.out.println("method : " + owntype);
mcimadamore@1219 849 // System.out.println("actuals: " + argtypes);
mcimadamore@1219 850 List<Type> formals = owntype.getParameterTypes();
mcimadamore@1219 851 Type last = useVarargs ? formals.last() : null;
jjg@1521 852 if (sym.name == names.init &&
mcimadamore@1219 853 sym.owner == syms.enumSym)
mcimadamore@1219 854 formals = formals.tail.tail;
mcimadamore@1219 855 List<JCExpression> args = argtrees;
mcimadamore@1347 856 DeferredAttr.DeferredTypeMap checkDeferredMap =
mcimadamore@1347 857 deferredAttr.new DeferredTypeMap(DeferredAttr.AttrMode.CHECK, sym, env.info.pendingResolutionPhase);
mcimadamore@1352 858 if (args != null) {
mcimadamore@1352 859 //this is null when type-checking a method reference
mcimadamore@1352 860 while (formals.head != last) {
mcimadamore@1219 861 JCTree arg = args.head;
mcimadamore@1352 862 Warner warn = convertWarner(arg.pos(), arg.type, formals.head);
mcimadamore@1352 863 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 864 args = args.tail;
mcimadamore@1352 865 formals = formals.tail;
mcimadamore@1219 866 }
mcimadamore@1352 867 if (useVarargs) {
mcimadamore@1352 868 Type varArg = types.elemtype(last);
mcimadamore@1352 869 while (args.tail != null) {
mcimadamore@1352 870 JCTree arg = args.head;
mcimadamore@1352 871 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1352 872 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1352 873 args = args.tail;
mcimadamore@1352 874 }
mcimadamore@1352 875 } else if ((sym.flags() & VARARGS) != 0 && allowVarargs) {
mcimadamore@1352 876 // non-varargs call to varargs method
mcimadamore@1352 877 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1352 878 Type lastArg = checkDeferredMap.apply(argtypes.last());
mcimadamore@1352 879 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
mcimadamore@1352 880 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1352 881 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
mcimadamore@1352 882 types.elemtype(varParam), varParam);
mcimadamore@1352 883 }
mcimadamore@1219 884 }
mcimadamore@1226 885 if (unchecked) {
mcimadamore@1219 886 warnUnchecked(env.tree.pos(),
mcimadamore@1219 887 "unchecked.meth.invocation.applied",
mcimadamore@1219 888 kindName(sym),
mcimadamore@1219 889 sym.name,
mcimadamore@1219 890 rs.methodArguments(sym.type.getParameterTypes()),
mcimadamore@1347 891 rs.methodArguments(Type.map(argtypes, checkDeferredMap)),
mcimadamore@1219 892 kindName(sym.location()),
mcimadamore@1219 893 sym.location());
mcimadamore@1219 894 owntype = new MethodType(owntype.getParameterTypes(),
mcimadamore@1219 895 types.erasure(owntype.getReturnType()),
mcimadamore@1219 896 types.erasure(owntype.getThrownTypes()),
mcimadamore@1219 897 syms.methodClass);
mcimadamore@1219 898 }
mcimadamore@1219 899 if (useVarargs) {
mcimadamore@1219 900 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 901 if (!types.isReifiable(argtype) &&
mcimadamore@1219 902 (!allowSimplifiedVarargs ||
mcimadamore@1219 903 sym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@1219 904 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 905 warnUnchecked(env.tree.pos(),
mcimadamore@1219 906 "unchecked.generic.array.creation",
mcimadamore@1219 907 argtype);
mcimadamore@1219 908 }
mcimadamore@1415 909 if (!((MethodSymbol)sym.baseSymbol()).isSignaturePolymorphic(types)) {
mcimadamore@1510 910 TreeInfo.setVarargsElement(env.tree, types.elemtype(argtype));
mcimadamore@1219 911 }
mcimadamore@1219 912 }
mcimadamore@1510 913 PolyKind pkind = (sym.type.hasTag(FORALL) &&
mcimadamore@1510 914 sym.type.getReturnType().containsAny(((ForAll)sym.type).tvars)) ?
mcimadamore@1510 915 PolyKind.POLY : PolyKind.STANDALONE;
mcimadamore@1510 916 TreeInfo.setPolyKind(env.tree, pkind);
mcimadamore@1219 917 return owntype;
mcimadamore@547 918 }
mcimadamore@1219 919 //where
mcimadamore@1219 920 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
mcimadamore@1219 921 if (types.isConvertible(actual, formal, warn))
mcimadamore@1219 922 return;
mcimadamore@1219 923
mcimadamore@1219 924 if (formal.isCompound()
mcimadamore@1219 925 && types.isSubtype(actual, types.supertype(formal))
mcimadamore@1219 926 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
mcimadamore@1219 927 return;
mcimadamore@1219 928 }
mcimadamore@547 929
mcimadamore@821 930 /**
mcimadamore@821 931 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 932 * (see JLS 4.5)
mcimadamore@821 933 *
mcimadamore@821 934 * @param t class type to be checked
mcimadamore@821 935 * @return true if 't' is well-formed
mcimadamore@821 936 */
mcimadamore@821 937 public boolean checkValidGenericType(Type t) {
mcimadamore@821 938 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 939 }
mcimadamore@821 940 //WHERE
mcimadamore@821 941 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 942 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 943 List<Type> actuals = type.allparams();
mcimadamore@821 944 List<Type> args = type.getTypeArguments();
mcimadamore@821 945 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 946 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 947
mcimadamore@821 948 // For matching pairs of actual argument types `a' and
mcimadamore@821 949 // formal type parameters with declared bound `b' ...
mcimadamore@821 950 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 951 // exact type arguments needs to know their
mcimadamore@821 952 // bounds (for upper and lower bound
mcimadamore@1216 953 // calculations). So we create new bounds where
mcimadamore@1216 954 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 955 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 956 args = args.tail;
mcimadamore@821 957 forms = forms.tail;
mcimadamore@821 958 }
mcimadamore@821 959
mcimadamore@821 960 args = type.getTypeArguments();
mcimadamore@821 961 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 962 formals,
mcimadamore@821 963 types.capture(type).allparams());
mcimadamore@821 964 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 965 // Let the actual arguments know their bound
mcimadamore@821 966 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 967 args = args.tail;
mcimadamore@821 968 tvars_cap = tvars_cap.tail;
mcimadamore@821 969 }
mcimadamore@821 970
mcimadamore@821 971 args = type.getTypeArguments();
mcimadamore@1216 972 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 973
mcimadamore@1216 974 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 975 Type actual = args.head;
mcimadamore@854 976 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 977 !bounds.head.isErroneous() &&
mcimadamore@1216 978 !checkExtends(actual, bounds.head)) {
mcimadamore@821 979 return args.head;
mcimadamore@821 980 }
mcimadamore@821 981 args = args.tail;
mcimadamore@1216 982 bounds = bounds.tail;
mcimadamore@821 983 }
mcimadamore@821 984
mcimadamore@821 985 args = type.getTypeArguments();
mcimadamore@1216 986 bounds = bounds_buf.toList();
mcimadamore@821 987
mcimadamore@821 988 for (Type arg : types.capture(type).getTypeArguments()) {
jjg@1374 989 if (arg.hasTag(TYPEVAR) &&
mcimadamore@828 990 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 991 !bounds.head.isErroneous() &&
mcimadamore@854 992 !isTypeArgErroneous(args.head)) {
mcimadamore@821 993 return args.head;
mcimadamore@821 994 }
mcimadamore@1216 995 bounds = bounds.tail;
mcimadamore@854 996 args = args.tail;
mcimadamore@821 997 }
mcimadamore@821 998
mcimadamore@821 999 return null;
mcimadamore@821 1000 }
mcimadamore@854 1001 //where
mcimadamore@854 1002 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 1003 return isTypeArgErroneous.visit(t);
mcimadamore@854 1004 }
mcimadamore@854 1005
mcimadamore@854 1006 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 1007 public Boolean visitType(Type t, Void s) {
mcimadamore@854 1008 return t.isErroneous();
mcimadamore@854 1009 }
mcimadamore@854 1010 @Override
mcimadamore@854 1011 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 1012 return visit(t.getUpperBound());
mcimadamore@854 1013 }
mcimadamore@854 1014 @Override
mcimadamore@854 1015 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 1016 return visit(t.getUpperBound()) ||
mcimadamore@854 1017 visit(t.getLowerBound());
mcimadamore@854 1018 }
mcimadamore@854 1019 @Override
mcimadamore@854 1020 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1021 return visit(t.type);
mcimadamore@854 1022 }
mcimadamore@854 1023 };
mcimadamore@821 1024
duke@1 1025 /** Check that given modifiers are legal for given symbol and
vromero@1555 1026 * return modifiers together with any implicit modifiers for that symbol.
duke@1 1027 * Warning: we can't use flags() here since this method
duke@1 1028 * is called during class enter, when flags() would cause a premature
duke@1 1029 * completion.
duke@1 1030 * @param pos Position to be used for error reporting.
duke@1 1031 * @param flags The set of modifiers given in a definition.
duke@1 1032 * @param sym The defined symbol.
duke@1 1033 */
duke@1 1034 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1035 long mask;
duke@1 1036 long implicit = 0;
duke@1 1037 switch (sym.kind) {
duke@1 1038 case VAR:
duke@1 1039 if (sym.owner.kind != TYP)
duke@1 1040 mask = LocalVarFlags;
duke@1 1041 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1042 mask = implicit = InterfaceVarFlags;
duke@1 1043 else
duke@1 1044 mask = VarFlags;
duke@1 1045 break;
duke@1 1046 case MTH:
duke@1 1047 if (sym.name == names.init) {
duke@1 1048 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1049 // enum constructors cannot be declared public or
duke@1 1050 // protected and must be implicitly or explicitly
duke@1 1051 // private
duke@1 1052 implicit = PRIVATE;
duke@1 1053 mask = PRIVATE;
duke@1 1054 } else
duke@1 1055 mask = ConstructorFlags;
mcimadamore@1366 1056 } else if ((sym.owner.flags_field & INTERFACE) != 0) {
mcimadamore@1513 1057 if ((flags & (DEFAULT | STATIC)) != 0) {
mcimadamore@1513 1058 mask = InterfaceMethodMask;
mcimadamore@1513 1059 implicit = PUBLIC;
mcimadamore@1513 1060 if ((flags & DEFAULT) != 0) {
mcimadamore@1513 1061 implicit |= ABSTRACT;
mcimadamore@1513 1062 }
mcimadamore@1366 1063 } else {
mcimadamore@1366 1064 mask = implicit = InterfaceMethodFlags;
mcimadamore@1366 1065 }
mcimadamore@1366 1066 }
duke@1 1067 else {
duke@1 1068 mask = MethodFlags;
duke@1 1069 }
duke@1 1070 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1071 if (((flags|implicit) & Flags.ABSTRACT) == 0)
vromero@1555 1072 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1073 break;
duke@1 1074 case TYP:
duke@1 1075 if (sym.isLocal()) {
duke@1 1076 mask = LocalClassFlags;
jjg@113 1077 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1078 // Anonymous classes in static methods are themselves static;
duke@1 1079 // that's why we admit STATIC here.
duke@1 1080 mask |= STATIC;
duke@1 1081 // JLS: Anonymous classes are final.
duke@1 1082 implicit |= FINAL;
duke@1 1083 }
duke@1 1084 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1085 (flags & ENUM) != 0)
duke@1 1086 log.error(pos, "enums.must.be.static");
duke@1 1087 } else if (sym.owner.kind == TYP) {
duke@1 1088 mask = MemberClassFlags;
duke@1 1089 if (sym.owner.owner.kind == PCK ||
duke@1 1090 (sym.owner.flags_field & STATIC) != 0)
duke@1 1091 mask |= STATIC;
duke@1 1092 else if ((flags & ENUM) != 0)
duke@1 1093 log.error(pos, "enums.must.be.static");
duke@1 1094 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1095 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1096 } else {
duke@1 1097 mask = ClassFlags;
duke@1 1098 }
duke@1 1099 // Interfaces are always ABSTRACT
duke@1 1100 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1101
duke@1 1102 if ((flags & ENUM) != 0) {
duke@1 1103 // enums can't be declared abstract or final
duke@1 1104 mask &= ~(ABSTRACT | FINAL);
duke@1 1105 implicit |= implicitEnumFinalFlag(tree);
duke@1 1106 }
duke@1 1107 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1108 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1109 break;
duke@1 1110 default:
duke@1 1111 throw new AssertionError();
duke@1 1112 }
mcimadamore@1366 1113 long illegal = flags & ExtendedStandardFlags & ~mask;
duke@1 1114 if (illegal != 0) {
duke@1 1115 if ((illegal & INTERFACE) != 0) {
duke@1 1116 log.error(pos, "intf.not.allowed.here");
duke@1 1117 mask |= INTERFACE;
duke@1 1118 }
duke@1 1119 else {
duke@1 1120 log.error(pos,
mcimadamore@80 1121 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1122 }
duke@1 1123 }
duke@1 1124 else if ((sym.kind == TYP ||
duke@1 1125 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1126 // in the presence of inner classes. Should it be deleted here?
duke@1 1127 checkDisjoint(pos, flags,
duke@1 1128 ABSTRACT,
mcimadamore@1366 1129 PRIVATE | STATIC | DEFAULT))
duke@1 1130 &&
duke@1 1131 checkDisjoint(pos, flags,
mcimadamore@1513 1132 STATIC,
mcimadamore@1513 1133 DEFAULT)
mcimadamore@1513 1134 &&
mcimadamore@1513 1135 checkDisjoint(pos, flags,
duke@1 1136 ABSTRACT | INTERFACE,
duke@1 1137 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1138 &&
duke@1 1139 checkDisjoint(pos, flags,
duke@1 1140 PUBLIC,
duke@1 1141 PRIVATE | PROTECTED)
duke@1 1142 &&
duke@1 1143 checkDisjoint(pos, flags,
duke@1 1144 PRIVATE,
duke@1 1145 PUBLIC | PROTECTED)
duke@1 1146 &&
duke@1 1147 checkDisjoint(pos, flags,
duke@1 1148 FINAL,
duke@1 1149 VOLATILE)
duke@1 1150 &&
duke@1 1151 (sym.kind == TYP ||
duke@1 1152 checkDisjoint(pos, flags,
duke@1 1153 ABSTRACT | NATIVE,
duke@1 1154 STRICTFP))) {
duke@1 1155 // skip
duke@1 1156 }
mcimadamore@1366 1157 return flags & (mask | ~ExtendedStandardFlags) | implicit;
duke@1 1158 }
duke@1 1159
duke@1 1160
duke@1 1161 /** Determine if this enum should be implicitly final.
duke@1 1162 *
duke@1 1163 * If the enum has no specialized enum contants, it is final.
duke@1 1164 *
duke@1 1165 * If the enum does have specialized enum contants, it is
duke@1 1166 * <i>not</i> final.
duke@1 1167 */
duke@1 1168 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1169 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1170 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1171 boolean specialized;
duke@1 1172 SpecialTreeVisitor() {
duke@1 1173 this.specialized = false;
duke@1 1174 };
duke@1 1175
jjg@398 1176 @Override
duke@1 1177 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1178
jjg@398 1179 @Override
duke@1 1180 public void visitVarDef(JCVariableDecl tree) {
duke@1 1181 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1182 if (tree.init instanceof JCNewClass &&
duke@1 1183 ((JCNewClass) tree.init).def != null) {
duke@1 1184 specialized = true;
duke@1 1185 }
duke@1 1186 }
duke@1 1187 }
duke@1 1188 }
duke@1 1189
duke@1 1190 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1191 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1192 for (JCTree defs: cdef.defs) {
duke@1 1193 defs.accept(sts);
duke@1 1194 if (sts.specialized) return 0;
duke@1 1195 }
duke@1 1196 return FINAL;
duke@1 1197 }
duke@1 1198
duke@1 1199 /* *************************************************************************
duke@1 1200 * Type Validation
duke@1 1201 **************************************************************************/
duke@1 1202
duke@1 1203 /** Validate a type expression. That is,
duke@1 1204 * check that all type arguments of a parametric type are within
duke@1 1205 * their bounds. This must be done in a second phase after type attributon
duke@1 1206 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1207 *
jjg@1358 1208 * <pre>{@code
duke@1 1209 * class B<A extends C> { ... }
duke@1 1210 * class C extends B<C> { ... }
jjg@1358 1211 * }</pre>
duke@1 1212 *
duke@1 1213 * and we can't make sure that the bound is already attributed because
duke@1 1214 * of possible cycles.
mcimadamore@638 1215 *
mcimadamore@638 1216 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1217 * and reporting any completion failures.
duke@1 1218 */
mcimadamore@122 1219 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1220 validate(tree, env, true);
duke@1 1221 }
mcimadamore@638 1222 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1223 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1224 }
duke@1 1225
duke@1 1226 /** Visitor method: Validate a list of type expressions.
duke@1 1227 */
mcimadamore@122 1228 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1229 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1230 validate(l.head, env);
duke@1 1231 }
duke@1 1232
duke@1 1233 /** A visitor class for type validation.
duke@1 1234 */
duke@1 1235 class Validator extends JCTree.Visitor {
duke@1 1236
mcimadamore@638 1237 boolean isOuter;
mcimadamore@638 1238 Env<AttrContext> env;
mcimadamore@638 1239
mcimadamore@638 1240 Validator(Env<AttrContext> env) {
mcimadamore@638 1241 this.env = env;
mcimadamore@638 1242 }
mcimadamore@638 1243
jjg@398 1244 @Override
duke@1 1245 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1246 tree.elemtype.accept(this);
duke@1 1247 }
duke@1 1248
jjg@398 1249 @Override
duke@1 1250 public void visitTypeApply(JCTypeApply tree) {
jjg@1374 1251 if (tree.type.hasTag(CLASS)) {
duke@1 1252 List<JCExpression> args = tree.arguments;
mcimadamore@158 1253 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1254
mcimadamore@821 1255 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1256 if (incompatibleArg != null) {
mcimadamore@821 1257 for (JCTree arg : tree.arguments) {
mcimadamore@821 1258 if (arg.type == incompatibleArg) {
mcimadamore@829 1259 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1260 }
mcimadamore@829 1261 forms = forms.tail;
mcimadamore@829 1262 }
mcimadamore@829 1263 }
mcimadamore@829 1264
mcimadamore@829 1265 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1266
mcimadamore@638 1267 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1268
duke@1 1269 // For matching pairs of actual argument types `a' and
duke@1 1270 // formal type parameters with declared bound `b' ...
duke@1 1271 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1272 validateTree(args.head,
mcimadamore@638 1273 !(isOuter && is_java_lang_Class),
mcimadamore@638 1274 false);
duke@1 1275 args = args.tail;
duke@1 1276 forms = forms.tail;
duke@1 1277 }
duke@1 1278
duke@1 1279 // Check that this type is either fully parameterized, or
duke@1 1280 // not parameterized at all.
duke@1 1281 if (tree.type.getEnclosingType().isRaw())
duke@1 1282 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1283 if (tree.clazz.hasTag(SELECT))
duke@1 1284 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1285 }
duke@1 1286 }
duke@1 1287
jjg@398 1288 @Override
duke@1 1289 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1290 validateTrees(tree.bounds, true, isOuter);
duke@1 1291 checkClassBounds(tree.pos(), tree.type);
duke@1 1292 }
duke@1 1293
duke@1 1294 @Override
duke@1 1295 public void visitWildcard(JCWildcard tree) {
duke@1 1296 if (tree.inner != null)
mcimadamore@638 1297 validateTree(tree.inner, true, isOuter);
duke@1 1298 }
duke@1 1299
jjg@398 1300 @Override
duke@1 1301 public void visitSelect(JCFieldAccess tree) {
jjg@1374 1302 if (tree.type.hasTag(CLASS)) {
duke@1 1303 visitSelectInternal(tree);
duke@1 1304
duke@1 1305 // Check that this type is either fully parameterized, or
duke@1 1306 // not parameterized at all.
duke@1 1307 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1308 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1309 }
duke@1 1310 }
mcimadamore@852 1311
duke@1 1312 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1313 if (tree.type.tsym.isStatic() &&
duke@1 1314 tree.selected.type.isParameterized()) {
duke@1 1315 // The enclosing type is not a class, so we are
duke@1 1316 // looking at a static member type. However, the
duke@1 1317 // qualifying expression is parameterized.
duke@1 1318 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1319 } else {
duke@1 1320 // otherwise validate the rest of the expression
mcimadamore@122 1321 tree.selected.accept(this);
duke@1 1322 }
duke@1 1323 }
duke@1 1324
jjg@1521 1325 @Override
jjg@1521 1326 public void visitAnnotatedType(JCAnnotatedType tree) {
jjg@1521 1327 tree.underlyingType.accept(this);
jjg@1521 1328 }
jjg@1521 1329
duke@1 1330 /** Default visitor method: do nothing.
duke@1 1331 */
jjg@398 1332 @Override
duke@1 1333 public void visitTree(JCTree tree) {
duke@1 1334 }
mcimadamore@122 1335
mcimadamore@638 1336 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1337 try {
mcimadamore@638 1338 if (tree != null) {
mcimadamore@638 1339 this.isOuter = isOuter;
mcimadamore@638 1340 tree.accept(this);
mcimadamore@638 1341 if (checkRaw)
mcimadamore@638 1342 checkRaw(tree, env);
mcimadamore@638 1343 }
mcimadamore@638 1344 } catch (CompletionFailure ex) {
mcimadamore@638 1345 completionError(tree.pos(), ex);
mcimadamore@638 1346 }
mcimadamore@638 1347 }
mcimadamore@638 1348
mcimadamore@638 1349 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1350 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1351 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1352 }
mcimadamore@638 1353
mcimadamore@638 1354 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1355 if (lint.isEnabled(LintCategory.RAW) &&
jjg@1374 1356 tree.type.hasTag(CLASS) &&
mcimadamore@638 1357 !TreeInfo.isDiamond(tree) &&
mcimadamore@1103 1358 !withinAnonConstr(env) &&
mcimadamore@638 1359 tree.type.isRaw()) {
mcimadamore@795 1360 log.warning(LintCategory.RAW,
mcimadamore@638 1361 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1362 }
mcimadamore@638 1363 }
mcimadamore@1103 1364
mcimadamore@1103 1365 boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1366 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1367 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1368 }
duke@1 1369 }
duke@1 1370
duke@1 1371 /* *************************************************************************
duke@1 1372 * Exception checking
duke@1 1373 **************************************************************************/
duke@1 1374
duke@1 1375 /* The following methods treat classes as sets that contain
duke@1 1376 * the class itself and all their subclasses
duke@1 1377 */
duke@1 1378
duke@1 1379 /** Is given type a subtype of some of the types in given list?
duke@1 1380 */
duke@1 1381 boolean subset(Type t, List<Type> ts) {
duke@1 1382 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1383 if (types.isSubtype(t, l.head)) return true;
duke@1 1384 return false;
duke@1 1385 }
duke@1 1386
duke@1 1387 /** Is given type a subtype or supertype of
duke@1 1388 * some of the types in given list?
duke@1 1389 */
duke@1 1390 boolean intersects(Type t, List<Type> ts) {
duke@1 1391 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1392 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1393 return false;
duke@1 1394 }
duke@1 1395
duke@1 1396 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1397 * in the list.
duke@1 1398 */
duke@1 1399 List<Type> incl(Type t, List<Type> ts) {
duke@1 1400 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1401 }
duke@1 1402
duke@1 1403 /** Remove type set from type set list.
duke@1 1404 */
duke@1 1405 List<Type> excl(Type t, List<Type> ts) {
duke@1 1406 if (ts.isEmpty()) {
duke@1 1407 return ts;
duke@1 1408 } else {
duke@1 1409 List<Type> ts1 = excl(t, ts.tail);
duke@1 1410 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1411 else if (ts1 == ts.tail) return ts;
duke@1 1412 else return ts1.prepend(ts.head);
duke@1 1413 }
duke@1 1414 }
duke@1 1415
duke@1 1416 /** Form the union of two type set lists.
duke@1 1417 */
duke@1 1418 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1419 List<Type> ts = ts1;
duke@1 1420 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1421 ts = incl(l.head, ts);
duke@1 1422 return ts;
duke@1 1423 }
duke@1 1424
duke@1 1425 /** Form the difference of two type lists.
duke@1 1426 */
duke@1 1427 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1428 List<Type> ts = ts1;
duke@1 1429 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1430 ts = excl(l.head, ts);
duke@1 1431 return ts;
duke@1 1432 }
duke@1 1433
duke@1 1434 /** Form the intersection of two type lists.
duke@1 1435 */
duke@1 1436 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1437 List<Type> ts = List.nil();
duke@1 1438 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1439 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1440 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1441 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1442 return ts;
duke@1 1443 }
duke@1 1444
duke@1 1445 /** Is exc an exception symbol that need not be declared?
duke@1 1446 */
duke@1 1447 boolean isUnchecked(ClassSymbol exc) {
duke@1 1448 return
duke@1 1449 exc.kind == ERR ||
duke@1 1450 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1451 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1452 }
duke@1 1453
duke@1 1454 /** Is exc an exception type that need not be declared?
duke@1 1455 */
duke@1 1456 boolean isUnchecked(Type exc) {
duke@1 1457 return
jjg@1374 1458 (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
jjg@1374 1459 (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
jjg@1374 1460 exc.hasTag(BOT);
duke@1 1461 }
duke@1 1462
duke@1 1463 /** Same, but handling completion failures.
duke@1 1464 */
duke@1 1465 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1466 try {
duke@1 1467 return isUnchecked(exc);
duke@1 1468 } catch (CompletionFailure ex) {
duke@1 1469 completionError(pos, ex);
duke@1 1470 return true;
duke@1 1471 }
duke@1 1472 }
duke@1 1473
duke@1 1474 /** Is exc handled by given exception list?
duke@1 1475 */
duke@1 1476 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1477 return isUnchecked(exc) || subset(exc, handled);
duke@1 1478 }
duke@1 1479
duke@1 1480 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1481 * @param thrown The list of thrown exceptions.
duke@1 1482 * @param handled The list of handled exceptions.
duke@1 1483 */
mcimadamore@362 1484 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1485 List<Type> unhandled = List.nil();
duke@1 1486 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1487 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1488 return unhandled;
duke@1 1489 }
duke@1 1490
duke@1 1491 /* *************************************************************************
duke@1 1492 * Overriding/Implementation checking
duke@1 1493 **************************************************************************/
duke@1 1494
duke@1 1495 /** The level of access protection given by a flag set,
duke@1 1496 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1497 */
duke@1 1498 static int protection(long flags) {
duke@1 1499 switch ((short)(flags & AccessFlags)) {
duke@1 1500 case PRIVATE: return 3;
duke@1 1501 case PROTECTED: return 1;
duke@1 1502 default:
duke@1 1503 case PUBLIC: return 0;
duke@1 1504 case 0: return 2;
duke@1 1505 }
duke@1 1506 }
duke@1 1507
duke@1 1508 /** A customized "cannot override" error message.
duke@1 1509 * @param m The overriding method.
duke@1 1510 * @param other The overridden method.
duke@1 1511 * @return An internationalized string.
duke@1 1512 */
mcimadamore@89 1513 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1514 String key;
duke@1 1515 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1516 key = "cant.override";
duke@1 1517 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1518 key = "cant.implement";
duke@1 1519 else
duke@1 1520 key = "clashes.with";
mcimadamore@89 1521 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1522 }
duke@1 1523
duke@1 1524 /** A customized "override" warning message.
duke@1 1525 * @param m The overriding method.
duke@1 1526 * @param other The overridden method.
duke@1 1527 * @return An internationalized string.
duke@1 1528 */
mcimadamore@89 1529 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1530 String key;
duke@1 1531 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1532 key = "unchecked.override";
duke@1 1533 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1534 key = "unchecked.implement";
duke@1 1535 else
duke@1 1536 key = "unchecked.clash.with";
mcimadamore@89 1537 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1538 }
duke@1 1539
duke@1 1540 /** A customized "override" warning message.
duke@1 1541 * @param m The overriding method.
duke@1 1542 * @param other The overridden method.
duke@1 1543 * @return An internationalized string.
duke@1 1544 */
mcimadamore@89 1545 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1546 String key;
duke@1 1547 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1548 key = "varargs.override";
duke@1 1549 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1550 key = "varargs.implement";
duke@1 1551 else
duke@1 1552 key = "varargs.clash.with";
mcimadamore@89 1553 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1554 }
duke@1 1555
duke@1 1556 /** Check that this method conforms with overridden method 'other'.
duke@1 1557 * where `origin' is the class where checking started.
duke@1 1558 * Complications:
duke@1 1559 * (1) Do not check overriding of synthetic methods
duke@1 1560 * (reason: they might be final).
duke@1 1561 * todo: check whether this is still necessary.
duke@1 1562 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1563 * than the method it implements. Augment the proxy methods with the
duke@1 1564 * undeclared exceptions in this case.
duke@1 1565 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1566 * has a result type
duke@1 1567 * extended by the result type of the method it implements.
duke@1 1568 * Change the proxies result type to the smaller type in this case.
duke@1 1569 *
duke@1 1570 * @param tree The tree from which positions
duke@1 1571 * are extracted for errors.
duke@1 1572 * @param m The overriding method.
duke@1 1573 * @param other The overridden method.
duke@1 1574 * @param origin The class of which the overriding method
duke@1 1575 * is a member.
duke@1 1576 */
duke@1 1577 void checkOverride(JCTree tree,
duke@1 1578 MethodSymbol m,
duke@1 1579 MethodSymbol other,
duke@1 1580 ClassSymbol origin) {
duke@1 1581 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1582 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1583 return;
duke@1 1584 }
duke@1 1585
duke@1 1586 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1587 if ((m.flags() & STATIC) != 0 &&
duke@1 1588 (other.flags() & STATIC) == 0) {
duke@1 1589 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1590 cannotOverride(m, other));
duke@1 1591 return;
duke@1 1592 }
duke@1 1593
duke@1 1594 // Error if instance method overrides static or final
duke@1 1595 // method (JLS 8.4.6.1).
duke@1 1596 if ((other.flags() & FINAL) != 0 ||
duke@1 1597 (m.flags() & STATIC) == 0 &&
duke@1 1598 (other.flags() & STATIC) != 0) {
duke@1 1599 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1600 cannotOverride(m, other),
mcimadamore@80 1601 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1602 return;
duke@1 1603 }
duke@1 1604
duke@1 1605 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1606 // handled in validateAnnotationMethod
duke@1 1607 return;
duke@1 1608 }
duke@1 1609
duke@1 1610 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1611 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1612 protection(m.flags()) > protection(other.flags())) {
duke@1 1613 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1614 cannotOverride(m, other),
mcimadamore@80 1615 other.flags() == 0 ?
mcimadamore@80 1616 Flag.PACKAGE :
mcimadamore@80 1617 asFlagSet(other.flags() & AccessFlags));
duke@1 1618 return;
duke@1 1619 }
duke@1 1620
duke@1 1621 Type mt = types.memberType(origin.type, m);
duke@1 1622 Type ot = types.memberType(origin.type, other);
duke@1 1623 // Error if overriding result type is different
duke@1 1624 // (or, in the case of generics mode, not a subtype) of
duke@1 1625 // overridden result type. We have to rename any type parameters
duke@1 1626 // before comparing types.
duke@1 1627 List<Type> mtvars = mt.getTypeArguments();
duke@1 1628 List<Type> otvars = ot.getTypeArguments();
duke@1 1629 Type mtres = mt.getReturnType();
duke@1 1630 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1631
mcimadamore@795 1632 overrideWarner.clear();
duke@1 1633 boolean resultTypesOK =
tbell@202 1634 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1635 if (!resultTypesOK) {
jjg@398 1636 if (!allowCovariantReturns &&
duke@1 1637 m.owner != origin &&
duke@1 1638 m.owner.isSubClass(other.owner, types)) {
duke@1 1639 // allow limited interoperability with covariant returns
duke@1 1640 } else {
mcimadamore@362 1641 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1642 "override.incompatible.ret",
mcimadamore@362 1643 cannotOverride(m, other),
duke@1 1644 mtres, otres);
duke@1 1645 return;
duke@1 1646 }
mcimadamore@795 1647 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1648 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1649 "override.unchecked.ret",
mcimadamore@362 1650 uncheckedOverrides(m, other),
mcimadamore@362 1651 mtres, otres);
duke@1 1652 }
duke@1 1653
duke@1 1654 // Error if overriding method throws an exception not reported
duke@1 1655 // by overridden method.
duke@1 1656 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1657 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1658 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1659 if (unhandledErased.nonEmpty()) {
duke@1 1660 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1661 "override.meth.doesnt.throw",
duke@1 1662 cannotOverride(m, other),
mcimadamore@362 1663 unhandledUnerased.head);
mcimadamore@362 1664 return;
mcimadamore@362 1665 }
mcimadamore@362 1666 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1667 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1668 "override.unchecked.thrown",
mcimadamore@362 1669 cannotOverride(m, other),
mcimadamore@362 1670 unhandledUnerased.head);
duke@1 1671 return;
duke@1 1672 }
duke@1 1673
duke@1 1674 // Optional warning if varargs don't agree
duke@1 1675 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1676 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1677 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1678 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1679 ? "override.varargs.missing"
duke@1 1680 : "override.varargs.extra",
duke@1 1681 varargsOverrides(m, other));
duke@1 1682 }
duke@1 1683
duke@1 1684 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1685 if ((other.flags() & BRIDGE) != 0) {
duke@1 1686 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1687 uncheckedOverrides(m, other));
duke@1 1688 }
duke@1 1689
duke@1 1690 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1691 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1692 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1693 }
duke@1 1694 }
duke@1 1695 // where
duke@1 1696 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1697 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1698 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1699 // because in that case, we will rediscover the issue when examining the method
duke@1 1700 // in the supertype.
duke@1 1701 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1702 // address the issue is when the method is the supertype implemementation: any other
duke@1 1703 // case, we will have dealt with when examining the supertype classes
duke@1 1704 ClassSymbol mc = m.enclClass();
duke@1 1705 Type st = types.supertype(origin.type);
jjg@1374 1706 if (!st.hasTag(CLASS))
duke@1 1707 return true;
duke@1 1708 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1709
duke@1 1710 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1711 List<Type> intfs = types.interfaces(origin.type);
duke@1 1712 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1713 }
duke@1 1714 else
duke@1 1715 return (stimpl != m);
duke@1 1716 }
duke@1 1717
duke@1 1718
duke@1 1719 // used to check if there were any unchecked conversions
duke@1 1720 Warner overrideWarner = new Warner();
duke@1 1721
duke@1 1722 /** Check that a class does not inherit two concrete methods
duke@1 1723 * with the same signature.
duke@1 1724 * @param pos Position to be used for error reporting.
duke@1 1725 * @param site The class type to be checked.
duke@1 1726 */
duke@1 1727 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1728 Type sup = types.supertype(site);
jjg@1374 1729 if (!sup.hasTag(CLASS)) return;
duke@1 1730
duke@1 1731 for (Type t1 = sup;
duke@1 1732 t1.tsym.type.isParameterized();
duke@1 1733 t1 = types.supertype(t1)) {
duke@1 1734 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1735 e1 != null;
duke@1 1736 e1 = e1.sibling) {
duke@1 1737 Symbol s1 = e1.sym;
duke@1 1738 if (s1.kind != MTH ||
duke@1 1739 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1740 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1741 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1742 types,
duke@1 1743 true) != s1)
duke@1 1744 continue;
duke@1 1745 Type st1 = types.memberType(t1, s1);
duke@1 1746 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1747 if (st1 == s1.type) continue;
duke@1 1748
duke@1 1749 for (Type t2 = sup;
jjg@1374 1750 t2.hasTag(CLASS);
duke@1 1751 t2 = types.supertype(t2)) {
mcimadamore@24 1752 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1753 e2.scope != null;
duke@1 1754 e2 = e2.next()) {
duke@1 1755 Symbol s2 = e2.sym;
duke@1 1756 if (s2 == s1 ||
duke@1 1757 s2.kind != MTH ||
duke@1 1758 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1759 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1760 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1761 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1762 types,
duke@1 1763 true) != s2)
duke@1 1764 continue;
duke@1 1765 Type st2 = types.memberType(t2, s2);
duke@1 1766 if (types.overrideEquivalent(st1, st2))
duke@1 1767 log.error(pos, "concrete.inheritance.conflict",
duke@1 1768 s1, t1, s2, t2, sup);
duke@1 1769 }
duke@1 1770 }
duke@1 1771 }
duke@1 1772 }
duke@1 1773 }
duke@1 1774
duke@1 1775 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1776 * method with same name and arguments but incompatible return types.
duke@1 1777 * @param pos Position to be used for error reporting.
duke@1 1778 * @param t1 The first argument type.
duke@1 1779 * @param t2 The second argument type.
duke@1 1780 */
duke@1 1781 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1782 Type t1,
duke@1 1783 Type t2) {
duke@1 1784 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1785 types.makeCompoundType(t1, t2));
duke@1 1786 }
duke@1 1787
duke@1 1788 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1789 Type t1,
duke@1 1790 Type t2,
duke@1 1791 Type site) {
mcimadamore@746 1792 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1793 }
duke@1 1794
duke@1 1795 /** Return the first method which is defined with same args
duke@1 1796 * but different return types in two given interfaces, or null if none
duke@1 1797 * exists.
duke@1 1798 * @param t1 The first type.
duke@1 1799 * @param t2 The second type.
duke@1 1800 * @param site The most derived type.
duke@1 1801 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1802 */
mcimadamore@746 1803 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1804 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1805 closure(t1, interfaces1);
duke@1 1806 Map<TypeSymbol,Type> interfaces2;
duke@1 1807 if (t1 == t2)
duke@1 1808 interfaces2 = interfaces1;
duke@1 1809 else
duke@1 1810 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1811
duke@1 1812 for (Type t3 : interfaces1.values()) {
duke@1 1813 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1814 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1815 if (s != null) return s;
duke@1 1816 }
duke@1 1817 }
duke@1 1818 return null;
duke@1 1819 }
duke@1 1820
duke@1 1821 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1822 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1823 if (!t.hasTag(CLASS)) return;
duke@1 1824 if (typeMap.put(t.tsym, t) == null) {
duke@1 1825 closure(types.supertype(t), typeMap);
duke@1 1826 for (Type i : types.interfaces(t))
duke@1 1827 closure(i, typeMap);
duke@1 1828 }
duke@1 1829 }
duke@1 1830
duke@1 1831 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1832 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1833 if (!t.hasTag(CLASS)) return;
duke@1 1834 if (typesSkip.get(t.tsym) != null) return;
duke@1 1835 if (typeMap.put(t.tsym, t) == null) {
duke@1 1836 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1837 for (Type i : types.interfaces(t))
duke@1 1838 closure(i, typesSkip, typeMap);
duke@1 1839 }
duke@1 1840 }
duke@1 1841
duke@1 1842 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1843 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1844 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1845 Symbol s1 = e1.sym;
duke@1 1846 Type st1 = null;
mcimadamore@1441 1847 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1848 (s1.flags() & SYNTHETIC) != 0) continue;
duke@1 1849 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1850 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1851 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1852 Symbol s2 = e2.sym;
duke@1 1853 if (s1 == s2) continue;
mcimadamore@1441 1854 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1855 (s2.flags() & SYNTHETIC) != 0) continue;
duke@1 1856 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1857 Type st2 = types.memberType(t2, s2);
duke@1 1858 if (types.overrideEquivalent(st1, st2)) {
duke@1 1859 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1860 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1861 Type rt1 = st1.getReturnType();
duke@1 1862 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1863 boolean compat =
duke@1 1864 types.isSameType(rt1, rt2) ||
jjg@1374 1865 !rt1.isPrimitiveOrVoid() &&
jjg@1374 1866 !rt2.isPrimitiveOrVoid() &&
mcimadamore@1415 1867 (types.covariantReturnType(rt1, rt2, types.noWarnings) ||
mcimadamore@1415 1868 types.covariantReturnType(rt2, rt1, types.noWarnings)) ||
mcimadamore@59 1869 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1870 if (!compat) {
mcimadamore@746 1871 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1872 t1, t2, s2.name +
mcimadamore@746 1873 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1874 return s2;
mcimadamore@746 1875 }
mcimadamore@889 1876 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1877 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1878 log.error(pos,
mcimadamore@746 1879 "name.clash.same.erasure.no.override",
mcimadamore@746 1880 s1, s1.location(),
mcimadamore@746 1881 s2, s2.location());
mcimadamore@746 1882 return s2;
duke@1 1883 }
duke@1 1884 }
duke@1 1885 }
duke@1 1886 return null;
duke@1 1887 }
mcimadamore@59 1888 //WHERE
mcimadamore@59 1889 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1890 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1891 Type st1 = types.memberType(site, s1);
mcimadamore@59 1892 Type st2 = types.memberType(site, s2);
mcimadamore@59 1893 closure(site, supertypes);
mcimadamore@59 1894 for (Type t : supertypes.values()) {
mcimadamore@59 1895 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1896 Symbol s3 = e.sym;
mcimadamore@59 1897 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1898 Type st3 = types.memberType(site,s3);
mcimadamore@59 1899 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1900 if (s3.owner == site.tsym) {
mcimadamore@59 1901 return true;
mcimadamore@59 1902 }
mcimadamore@59 1903 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1904 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1905 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1906 Type rt1 = st1.getReturnType();
mcimadamore@59 1907 Type rt2 = st2.getReturnType();
mcimadamore@59 1908 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1909 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1910 boolean compat =
jjg@1374 1911 !rt13.isPrimitiveOrVoid() &&
jjg@1374 1912 !rt23.isPrimitiveOrVoid() &&
mcimadamore@1415 1913 (types.covariantReturnType(rt13, rt1, types.noWarnings) &&
mcimadamore@1415 1914 types.covariantReturnType(rt23, rt2, types.noWarnings));
mcimadamore@59 1915 if (compat)
mcimadamore@59 1916 return true;
mcimadamore@59 1917 }
mcimadamore@59 1918 }
mcimadamore@59 1919 }
mcimadamore@59 1920 return false;
mcimadamore@59 1921 }
duke@1 1922
duke@1 1923 /** Check that a given method conforms with any method it overrides.
duke@1 1924 * @param tree The tree from which positions are extracted
duke@1 1925 * for errors.
duke@1 1926 * @param m The overriding method.
duke@1 1927 */
duke@1 1928 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1929 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1930 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1931 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1932 log.error(tree.pos(), "enum.no.finalize");
duke@1 1933 return;
duke@1 1934 }
jjg@1374 1935 for (Type t = origin.type; t.hasTag(CLASS);
duke@1 1936 t = types.supertype(t)) {
mcimadamore@746 1937 if (t != origin.type) {
mcimadamore@746 1938 checkOverride(tree, t, origin, m);
mcimadamore@746 1939 }
mcimadamore@746 1940 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1941 checkOverride(tree, t2, origin, m);
duke@1 1942 }
duke@1 1943 }
duke@1 1944 }
duke@1 1945
mcimadamore@746 1946 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1947 TypeSymbol c = site.tsym;
mcimadamore@746 1948 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1949 while (e.scope != null) {
mcimadamore@746 1950 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1951 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1952 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1953 }
mcimadamore@746 1954 }
mcimadamore@746 1955 e = e.next();
mcimadamore@746 1956 }
mcimadamore@746 1957 }
mcimadamore@746 1958
mcimadamore@746 1959 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 1960 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 1961 return (cf.accepts(s1) &&
mcimadamore@858 1962 cf.accepts(s2) &&
mcimadamore@858 1963 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 1964 }
mcimadamore@746 1965
mcimadamore@746 1966
duke@1 1967 /** Check that all abstract members of given class have definitions.
duke@1 1968 * @param pos Position to be used for error reporting.
duke@1 1969 * @param c The class.
duke@1 1970 */
duke@1 1971 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1972 try {
duke@1 1973 MethodSymbol undef = firstUndef(c, c);
duke@1 1974 if (undef != null) {
duke@1 1975 if ((c.flags() & ENUM) != 0 &&
duke@1 1976 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 1977 (c.flags() & FINAL) == 0) {
duke@1 1978 // add the ABSTRACT flag to an enum
duke@1 1979 c.flags_field |= ABSTRACT;
duke@1 1980 } else {
duke@1 1981 MethodSymbol undef1 =
duke@1 1982 new MethodSymbol(undef.flags(), undef.name,
duke@1 1983 types.memberType(c.type, undef), undef.owner);
duke@1 1984 log.error(pos, "does.not.override.abstract",
duke@1 1985 c, undef1, undef1.location());
duke@1 1986 }
duke@1 1987 }
duke@1 1988 } catch (CompletionFailure ex) {
duke@1 1989 completionError(pos, ex);
duke@1 1990 }
duke@1 1991 }
duke@1 1992 //where
duke@1 1993 /** Return first abstract member of class `c' that is not defined
duke@1 1994 * in `impl', null if there is none.
duke@1 1995 */
duke@1 1996 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 1997 MethodSymbol undef = null;
duke@1 1998 // Do not bother to search in classes that are not abstract,
duke@1 1999 // since they cannot have abstract members.
duke@1 2000 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 2001 Scope s = c.members();
duke@1 2002 for (Scope.Entry e = s.elems;
duke@1 2003 undef == null && e != null;
duke@1 2004 e = e.sibling) {
duke@1 2005 if (e.sym.kind == MTH &&
mcimadamore@1393 2006 (e.sym.flags() & (ABSTRACT|IPROXY|DEFAULT)) == ABSTRACT) {
duke@1 2007 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2008 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
mcimadamore@1393 2009 if (implmeth == null || implmeth == absmeth) {
mcimadamore@1393 2010 //look for default implementations
mcimadamore@1393 2011 if (allowDefaultMethods) {
mcimadamore@1393 2012 MethodSymbol prov = types.interfaceCandidates(impl.type, absmeth).head;
mcimadamore@1393 2013 if (prov != null && prov.overrides(absmeth, impl, types, true)) {
mcimadamore@1393 2014 implmeth = prov;
mcimadamore@1393 2015 }
mcimadamore@1393 2016 }
mcimadamore@1393 2017 }
mcimadamore@1393 2018 if (implmeth == null || implmeth == absmeth) {
duke@1 2019 undef = absmeth;
mcimadamore@1393 2020 }
duke@1 2021 }
duke@1 2022 }
duke@1 2023 if (undef == null) {
duke@1 2024 Type st = types.supertype(c.type);
jjg@1374 2025 if (st.hasTag(CLASS))
duke@1 2026 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 2027 }
duke@1 2028 for (List<Type> l = types.interfaces(c.type);
duke@1 2029 undef == null && l.nonEmpty();
duke@1 2030 l = l.tail) {
duke@1 2031 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 2032 }
duke@1 2033 }
duke@1 2034 return undef;
duke@1 2035 }
duke@1 2036
mcimadamore@690 2037 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 2038 CycleChecker cc = new CycleChecker();
mcimadamore@690 2039 cc.scan(tree);
mcimadamore@690 2040 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 2041 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 2042 }
mcimadamore@690 2043 }
mcimadamore@690 2044
mcimadamore@690 2045 class CycleChecker extends TreeScanner {
mcimadamore@690 2046
mcimadamore@690 2047 List<Symbol> seenClasses = List.nil();
mcimadamore@690 2048 boolean errorFound = false;
mcimadamore@690 2049 boolean partialCheck = false;
mcimadamore@690 2050
mcimadamore@690 2051 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 2052 if (sym != null && sym.kind == TYP) {
mcimadamore@690 2053 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 2054 if (classEnv != null) {
mcimadamore@690 2055 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2056 try {
mcimadamore@690 2057 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2058 scan(classEnv.tree);
mcimadamore@690 2059 }
mcimadamore@690 2060 finally {
mcimadamore@690 2061 log.useSource(prevSource.getFile());
mcimadamore@690 2062 }
mcimadamore@690 2063 } else if (sym.kind == TYP) {
mcimadamore@690 2064 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2065 }
mcimadamore@690 2066 } else {
mcimadamore@690 2067 //not completed yet
mcimadamore@690 2068 partialCheck = true;
mcimadamore@690 2069 }
mcimadamore@690 2070 }
mcimadamore@690 2071
mcimadamore@690 2072 @Override
mcimadamore@690 2073 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2074 super.visitSelect(tree);
mcimadamore@690 2075 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2076 }
mcimadamore@690 2077
mcimadamore@690 2078 @Override
mcimadamore@690 2079 public void visitIdent(JCIdent tree) {
mcimadamore@690 2080 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2081 }
mcimadamore@690 2082
mcimadamore@690 2083 @Override
mcimadamore@690 2084 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2085 scan(tree.clazz);
mcimadamore@690 2086 }
mcimadamore@690 2087
mcimadamore@690 2088 @Override
mcimadamore@690 2089 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2090 scan(tree.elemtype);
mcimadamore@690 2091 }
mcimadamore@690 2092
mcimadamore@690 2093 @Override
mcimadamore@690 2094 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2095 List<JCTree> supertypes = List.nil();
mcimadamore@690 2096 if (tree.getExtendsClause() != null) {
mcimadamore@690 2097 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2098 }
mcimadamore@690 2099 if (tree.getImplementsClause() != null) {
mcimadamore@690 2100 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2101 supertypes = supertypes.prepend(intf);
mcimadamore@690 2102 }
mcimadamore@690 2103 }
mcimadamore@690 2104 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2105 }
mcimadamore@690 2106
mcimadamore@690 2107 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2108 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2109 return;
mcimadamore@690 2110 if (seenClasses.contains(c)) {
mcimadamore@690 2111 errorFound = true;
mcimadamore@690 2112 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2113 } else if (!c.type.isErroneous()) {
mcimadamore@690 2114 try {
mcimadamore@690 2115 seenClasses = seenClasses.prepend(c);
jjg@1374 2116 if (c.type.hasTag(CLASS)) {
mcimadamore@690 2117 if (supertypes.nonEmpty()) {
mcimadamore@690 2118 scan(supertypes);
mcimadamore@690 2119 }
mcimadamore@690 2120 else {
mcimadamore@690 2121 ClassType ct = (ClassType)c.type;
mcimadamore@690 2122 if (ct.supertype_field == null ||
mcimadamore@690 2123 ct.interfaces_field == null) {
mcimadamore@690 2124 //not completed yet
mcimadamore@690 2125 partialCheck = true;
mcimadamore@690 2126 return;
mcimadamore@690 2127 }
mcimadamore@690 2128 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2129 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2130 checkSymbol(pos, intf.tsym);
mcimadamore@690 2131 }
mcimadamore@690 2132 }
mcimadamore@690 2133 if (c.owner.kind == TYP) {
mcimadamore@690 2134 checkSymbol(pos, c.owner);
mcimadamore@690 2135 }
mcimadamore@690 2136 }
mcimadamore@690 2137 } finally {
mcimadamore@690 2138 seenClasses = seenClasses.tail;
mcimadamore@690 2139 }
mcimadamore@690 2140 }
mcimadamore@690 2141 }
mcimadamore@690 2142 }
mcimadamore@690 2143
duke@1 2144 /** Check for cyclic references. Issue an error if the
duke@1 2145 * symbol of the type referred to has a LOCKED flag set.
duke@1 2146 *
duke@1 2147 * @param pos Position to be used for error reporting.
duke@1 2148 * @param t The type referred to.
duke@1 2149 */
duke@1 2150 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2151 checkNonCyclicInternal(pos, t);
duke@1 2152 }
duke@1 2153
duke@1 2154
duke@1 2155 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2156 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2157 }
duke@1 2158
mcimadamore@236 2159 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2160 final TypeVar tv;
jjg@1374 2161 if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2162 return;
duke@1 2163 if (seen.contains(t)) {
duke@1 2164 tv = (TypeVar)t;
jjg@110 2165 tv.bound = types.createErrorType(t);
duke@1 2166 log.error(pos, "cyclic.inheritance", t);
jjg@1374 2167 } else if (t.hasTag(TYPEVAR)) {
duke@1 2168 tv = (TypeVar)t;
mcimadamore@236 2169 seen = seen.prepend(tv);
duke@1 2170 for (Type b : types.getBounds(tv))
duke@1 2171 checkNonCyclic1(pos, b, seen);
duke@1 2172 }
duke@1 2173 }
duke@1 2174
duke@1 2175 /** Check for cyclic references. Issue an error if the
duke@1 2176 * symbol of the type referred to has a LOCKED flag set.
duke@1 2177 *
duke@1 2178 * @param pos Position to be used for error reporting.
duke@1 2179 * @param t The type referred to.
duke@1 2180 * @returns True if the check completed on all attributed classes
duke@1 2181 */
duke@1 2182 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2183 boolean complete = true; // was the check complete?
duke@1 2184 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2185 Symbol c = t.tsym;
duke@1 2186 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2187
duke@1 2188 if ((c.flags_field & LOCKED) != 0) {
duke@1 2189 noteCyclic(pos, (ClassSymbol)c);
duke@1 2190 } else if (!c.type.isErroneous()) {
duke@1 2191 try {
duke@1 2192 c.flags_field |= LOCKED;
jjg@1374 2193 if (c.type.hasTag(CLASS)) {
duke@1 2194 ClassType clazz = (ClassType)c.type;
duke@1 2195 if (clazz.interfaces_field != null)
duke@1 2196 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2197 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2198 if (clazz.supertype_field != null) {
duke@1 2199 Type st = clazz.supertype_field;
jjg@1374 2200 if (st != null && st.hasTag(CLASS))
duke@1 2201 complete &= checkNonCyclicInternal(pos, st);
duke@1 2202 }
duke@1 2203 if (c.owner.kind == TYP)
duke@1 2204 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2205 }
duke@1 2206 } finally {
duke@1 2207 c.flags_field &= ~LOCKED;
duke@1 2208 }
duke@1 2209 }
duke@1 2210 if (complete)
duke@1 2211 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2212 if (complete) c.flags_field |= ACYCLIC;
duke@1 2213 return complete;
duke@1 2214 }
duke@1 2215
duke@1 2216 /** Note that we found an inheritance cycle. */
duke@1 2217 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2218 log.error(pos, "cyclic.inheritance", c);
duke@1 2219 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2220 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2221 Type st = types.supertype(c.type);
jjg@1374 2222 if (st.hasTag(CLASS))
jjg@110 2223 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2224 c.type = types.createErrorType(c, c.type);
duke@1 2225 c.flags_field |= ACYCLIC;
duke@1 2226 }
duke@1 2227
mcimadamore@1415 2228 /**
mcimadamore@1415 2229 * Check that functional interface methods would make sense when seen
mcimadamore@1415 2230 * from the perspective of the implementing class
mcimadamore@1415 2231 */
mcimadamore@1415 2232 void checkFunctionalInterface(JCTree tree, Type funcInterface) {
mcimadamore@1415 2233 ClassType c = new ClassType(Type.noType, List.<Type>nil(), null);
mcimadamore@1415 2234 ClassSymbol csym = new ClassSymbol(0, names.empty, c, syms.noSymbol);
mcimadamore@1415 2235 c.interfaces_field = List.of(funcInterface);
mcimadamore@1415 2236 c.supertype_field = syms.objectType;
mcimadamore@1415 2237 c.tsym = csym;
mcimadamore@1415 2238 csym.members_field = new Scope(csym);
mcimadamore@1415 2239 csym.completer = null;
mcimadamore@1415 2240 checkImplementations(tree, csym, csym);
mcimadamore@1415 2241 }
mcimadamore@1415 2242
duke@1 2243 /** Check that all methods which implement some
duke@1 2244 * method conform to the method they implement.
duke@1 2245 * @param tree The class definition whose members are checked.
duke@1 2246 */
duke@1 2247 void checkImplementations(JCClassDecl tree) {
mcimadamore@1415 2248 checkImplementations(tree, tree.sym, tree.sym);
duke@1 2249 }
jjg@1521 2250 //where
duke@1 2251 /** Check that all methods which implement some
duke@1 2252 * method in `ic' conform to the method they implement.
duke@1 2253 */
mcimadamore@1415 2254 void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) {
duke@1 2255 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2256 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2257 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2258 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2259 if (e.sym.kind == MTH &&
duke@1 2260 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2261 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2262 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2263 if (implmeth != null && implmeth != absmeth &&
duke@1 2264 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2265 (origin.flags() & INTERFACE)) {
duke@1 2266 // don't check if implmeth is in a class, yet
duke@1 2267 // origin is an interface. This case arises only
duke@1 2268 // if implmeth is declared in Object. The reason is
duke@1 2269 // that interfaces really don't inherit from
duke@1 2270 // Object it's just that the compiler represents
duke@1 2271 // things that way.
duke@1 2272 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2273 }
duke@1 2274 }
duke@1 2275 }
duke@1 2276 }
duke@1 2277 }
duke@1 2278 }
duke@1 2279
duke@1 2280 /** Check that all abstract methods implemented by a class are
duke@1 2281 * mutually compatible.
duke@1 2282 * @param pos Position to be used for error reporting.
duke@1 2283 * @param c The class whose interfaces are checked.
duke@1 2284 */
duke@1 2285 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2286 List<Type> supertypes = types.interfaces(c);
duke@1 2287 Type supertype = types.supertype(c);
jjg@1374 2288 if (supertype.hasTag(CLASS) &&
duke@1 2289 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2290 supertypes = supertypes.prepend(supertype);
duke@1 2291 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2292 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2293 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2294 return;
duke@1 2295 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2296 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2297 return;
duke@1 2298 }
duke@1 2299 checkCompatibleConcretes(pos, c);
duke@1 2300 }
duke@1 2301
mcimadamore@359 2302 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2303 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2304 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2305 // VM allows methods and variables with differing types
mcimadamore@359 2306 if (sym.kind == e.sym.kind &&
mcimadamore@359 2307 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2308 sym != e.sym &&
mcimadamore@359 2309 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2310 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2311 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2312 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2313 return;
mcimadamore@359 2314 }
mcimadamore@359 2315 }
mcimadamore@359 2316 }
mcimadamore@359 2317 }
mcimadamore@359 2318
mcimadamore@780 2319 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2320 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2321 *
mcimadamore@780 2322 * @param pos Position to be used for error reporting.
mcimadamore@780 2323 * @param site The class whose methods are checked.
mcimadamore@780 2324 * @param sym The method symbol to be checked.
mcimadamore@780 2325 */
mcimadamore@858 2326 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2327 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2328 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2329 //by method 'sym' in 'site'...
mcimadamore@1198 2330 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2331 if (!sym.overrides(m1, site.tsym, types, false)) continue;
mcimadamore@1198 2332 //...check each method m2 that is a member of 'site'
mcimadamore@1198 2333 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2334 if (m2 == m1) continue;
mcimadamore@858 2335 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2336 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1393 2337 if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) &&
mcimadamore@1198 2338 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2339 sym.flags_field |= CLASH;
mcimadamore@1198 2340 String key = m1 == sym ?
mcimadamore@858 2341 "name.clash.same.erasure.no.override" :
mcimadamore@858 2342 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2343 log.error(pos,
mcimadamore@858 2344 key,
mcimadamore@858 2345 sym, sym.location(),
mcimadamore@1198 2346 m2, m2.location(),
mcimadamore@1198 2347 m1, m1.location());
mcimadamore@858 2348 return;
mcimadamore@858 2349 }
mcimadamore@780 2350 }
mcimadamore@780 2351 }
mcimadamore@780 2352 }
mcimadamore@780 2353
mcimadamore@877 2354
mcimadamore@877 2355
mcimadamore@858 2356 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2357 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2358 *
mcimadamore@858 2359 * @param pos Position to be used for error reporting.
mcimadamore@858 2360 * @param site The class whose methods are checked.
mcimadamore@858 2361 * @param sym The method symbol to be checked.
mcimadamore@780 2362 */
mcimadamore@858 2363 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2364 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2365 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2366 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2367 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2368 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@1393 2369 if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck) &&
mcimadamore@877 2370 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2371 log.error(pos,
mcimadamore@858 2372 "name.clash.same.erasure.no.hide",
mcimadamore@858 2373 sym, sym.location(),
mcimadamore@877 2374 s, s.location());
mcimadamore@858 2375 return;
mcimadamore@858 2376 }
mcimadamore@858 2377 }
mcimadamore@858 2378 }
mcimadamore@780 2379
mcimadamore@858 2380 //where
mcimadamore@858 2381 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2382
mcimadamore@858 2383 Type site;
mcimadamore@780 2384
mcimadamore@858 2385 ClashFilter(Type site) {
mcimadamore@858 2386 this.site = site;
mcimadamore@858 2387 }
mcimadamore@858 2388
mcimadamore@858 2389 boolean shouldSkip(Symbol s) {
mcimadamore@858 2390 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2391 s.owner == site.tsym;
mcimadamore@858 2392 }
mcimadamore@858 2393
mcimadamore@858 2394 public boolean accepts(Symbol s) {
mcimadamore@858 2395 return s.kind == MTH &&
mcimadamore@858 2396 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2397 !shouldSkip(s) &&
mcimadamore@858 2398 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2399 !s.isConstructor();
mcimadamore@858 2400 }
mcimadamore@858 2401 }
mcimadamore@780 2402
mcimadamore@1393 2403 void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) {
mcimadamore@1393 2404 DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site);
mcimadamore@1393 2405 for (Symbol m : types.membersClosure(site, false).getElements(dcf)) {
mcimadamore@1393 2406 Assert.check(m.kind == MTH);
mcimadamore@1393 2407 List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m);
mcimadamore@1393 2408 if (prov.size() > 1) {
mcimadamore@1393 2409 ListBuffer<Symbol> abstracts = ListBuffer.lb();
mcimadamore@1393 2410 ListBuffer<Symbol> defaults = ListBuffer.lb();
mcimadamore@1393 2411 for (MethodSymbol provSym : prov) {
mcimadamore@1393 2412 if ((provSym.flags() & DEFAULT) != 0) {
mcimadamore@1393 2413 defaults = defaults.append(provSym);
mcimadamore@1393 2414 } else if ((provSym.flags() & ABSTRACT) != 0) {
mcimadamore@1393 2415 abstracts = abstracts.append(provSym);
mcimadamore@1393 2416 }
mcimadamore@1393 2417 if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) {
mcimadamore@1393 2418 //strong semantics - issue an error if two sibling interfaces
mcimadamore@1393 2419 //have two override-equivalent defaults - or if one is abstract
mcimadamore@1393 2420 //and the other is default
mcimadamore@1393 2421 String errKey;
mcimadamore@1393 2422 Symbol s1 = defaults.first();
mcimadamore@1393 2423 Symbol s2;
mcimadamore@1393 2424 if (defaults.size() > 1) {
mcimadamore@1393 2425 errKey = "types.incompatible.unrelated.defaults";
mcimadamore@1393 2426 s2 = defaults.toList().tail.head;
mcimadamore@1393 2427 } else {
mcimadamore@1393 2428 errKey = "types.incompatible.abstract.default";
mcimadamore@1393 2429 s2 = abstracts.first();
mcimadamore@1393 2430 }
mcimadamore@1393 2431 log.error(pos, errKey,
mcimadamore@1393 2432 Kinds.kindName(site.tsym), site,
mcimadamore@1393 2433 m.name, types.memberType(site, m).getParameterTypes(),
mcimadamore@1393 2434 s1.location(), s2.location());
mcimadamore@1393 2435 break;
mcimadamore@1393 2436 }
mcimadamore@1393 2437 }
mcimadamore@1393 2438 }
mcimadamore@1393 2439 }
mcimadamore@1393 2440 }
mcimadamore@1393 2441
mcimadamore@1393 2442 //where
mcimadamore@1393 2443 private class DefaultMethodClashFilter implements Filter<Symbol> {
mcimadamore@1393 2444
mcimadamore@1393 2445 Type site;
mcimadamore@1393 2446
mcimadamore@1393 2447 DefaultMethodClashFilter(Type site) {
mcimadamore@1393 2448 this.site = site;
mcimadamore@1393 2449 }
mcimadamore@1393 2450
mcimadamore@1393 2451 public boolean accepts(Symbol s) {
mcimadamore@1393 2452 return s.kind == MTH &&
mcimadamore@1393 2453 (s.flags() & DEFAULT) != 0 &&
mcimadamore@1393 2454 s.isInheritedIn(site.tsym, types) &&
mcimadamore@1393 2455 !s.isConstructor();
mcimadamore@1393 2456 }
mcimadamore@1393 2457 }
mcimadamore@1393 2458
mcimadamore@359 2459 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2460 */
mcimadamore@359 2461 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2462 if (!sym.type.isErroneous()) {
mcimadamore@359 2463 if (warnOnSyntheticConflicts) {
mcimadamore@359 2464 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2465 }
mcimadamore@359 2466 else {
mcimadamore@359 2467 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2468 }
mcimadamore@359 2469 }
mcimadamore@359 2470 }
mcimadamore@359 2471
duke@1 2472 /** Check that class c does not implement directly or indirectly
duke@1 2473 * the same parameterized interface with two different argument lists.
duke@1 2474 * @param pos Position to be used for error reporting.
duke@1 2475 * @param type The type whose interfaces are checked.
duke@1 2476 */
duke@1 2477 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2478 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2479 }
duke@1 2480 //where
duke@1 2481 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2482 * with their class symbol as key and their type as value. Make
duke@1 2483 * sure no class is entered with two different types.
duke@1 2484 */
duke@1 2485 void checkClassBounds(DiagnosticPosition pos,
duke@1 2486 Map<TypeSymbol,Type> seensofar,
duke@1 2487 Type type) {
duke@1 2488 if (type.isErroneous()) return;
duke@1 2489 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2490 Type it = l.head;
duke@1 2491 Type oldit = seensofar.put(it.tsym, it);
duke@1 2492 if (oldit != null) {
duke@1 2493 List<Type> oldparams = oldit.allparams();
duke@1 2494 List<Type> newparams = it.allparams();
duke@1 2495 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2496 log.error(pos, "cant.inherit.diff.arg",
duke@1 2497 it.tsym, Type.toString(oldparams),
duke@1 2498 Type.toString(newparams));
duke@1 2499 }
duke@1 2500 checkClassBounds(pos, seensofar, it);
duke@1 2501 }
duke@1 2502 Type st = types.supertype(type);
duke@1 2503 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2504 }
duke@1 2505
duke@1 2506 /** Enter interface into into set.
duke@1 2507 * If it existed already, issue a "repeated interface" error.
duke@1 2508 */
duke@1 2509 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2510 if (its.contains(it))
duke@1 2511 log.error(pos, "repeated.interface");
duke@1 2512 else {
duke@1 2513 its.add(it);
duke@1 2514 }
duke@1 2515 }
duke@1 2516
duke@1 2517 /* *************************************************************************
duke@1 2518 * Check annotations
duke@1 2519 **************************************************************************/
duke@1 2520
mcimadamore@629 2521 /**
mcimadamore@634 2522 * Recursively validate annotations values
mcimadamore@629 2523 */
mcimadamore@634 2524 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2525 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2526 @Override
mcimadamore@629 2527 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2528 if (!tree.type.isErroneous()) {
jjg@1017 2529 super.visitAnnotation(tree);
jjg@1017 2530 validateAnnotation(tree);
jjg@1017 2531 }
mcimadamore@629 2532 }
mcimadamore@629 2533 }
mcimadamore@634 2534 tree.accept(new AnnotationValidator());
mcimadamore@629 2535 }
mcimadamore@629 2536
jjg@1326 2537 /**
jjg@1326 2538 * {@literal
jjg@1326 2539 * Annotation types are restricted to primitives, String, an
duke@1 2540 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2541 * Anything>, arrays of the preceding.
jjg@1326 2542 * }
duke@1 2543 */
duke@1 2544 void validateAnnotationType(JCTree restype) {
duke@1 2545 // restype may be null if an error occurred, so don't bother validating it
duke@1 2546 if (restype != null) {
duke@1 2547 validateAnnotationType(restype.pos(), restype.type);
duke@1 2548 }
duke@1 2549 }
duke@1 2550
duke@1 2551 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2552 if (type.isPrimitive()) return;
duke@1 2553 if (types.isSameType(type, syms.stringType)) return;
duke@1 2554 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2555 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2556 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2557 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2558 validateAnnotationType(pos, types.elemtype(type));
duke@1 2559 return;
duke@1 2560 }
duke@1 2561 log.error(pos, "invalid.annotation.member.type");
duke@1 2562 }
duke@1 2563
duke@1 2564 /**
duke@1 2565 * "It is also a compile-time error if any method declared in an
duke@1 2566 * annotation type has a signature that is override-equivalent to
duke@1 2567 * that of any public or protected method declared in class Object
duke@1 2568 * or in the interface annotation.Annotation."
duke@1 2569 *
jjh@972 2570 * @jls 9.6 Annotation Types
duke@1 2571 */
duke@1 2572 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
jjg@1374 2573 for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
duke@1 2574 Scope s = sup.tsym.members();
duke@1 2575 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2576 if (e.sym.kind == MTH &&
duke@1 2577 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2578 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2579 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2580 }
duke@1 2581 }
duke@1 2582 }
duke@1 2583
duke@1 2584 /** Check the annotations of a symbol.
duke@1 2585 */
duke@1 2586 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2587 for (JCAnnotation a : annotations)
duke@1 2588 validateAnnotation(a, s);
duke@1 2589 }
duke@1 2590
jjg@1521 2591 /** Check the type annotations.
jjg@1521 2592 */
jjg@1521 2593 public void validateTypeAnnotations(List<JCAnnotation> annotations, boolean isTypeParameter) {
jjg@1521 2594 for (JCAnnotation a : annotations)
jjg@1521 2595 validateTypeAnnotation(a, isTypeParameter);
jjg@1521 2596 }
jjg@1521 2597
duke@1 2598 /** Check an annotation of a symbol.
duke@1 2599 */
jfranck@1313 2600 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2601 validateAnnotationTree(a);
duke@1 2602
duke@1 2603 if (!annotationApplicable(a, s))
duke@1 2604 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2605
duke@1 2606 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2607 if (!isOverrider(s))
duke@1 2608 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2609 }
mcimadamore@1497 2610
mcimadamore@1497 2611 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
mcimadamore@1497 2612 if (s.kind != TYP) {
mcimadamore@1497 2613 log.error(a.pos(), "bad.functional.intf.anno");
mcimadamore@1497 2614 } else {
mcimadamore@1497 2615 try {
mcimadamore@1497 2616 types.findDescriptorSymbol((TypeSymbol)s);
mcimadamore@1497 2617 } catch (Types.FunctionDescriptorLookupError ex) {
mcimadamore@1497 2618 log.error(a.pos(), "bad.functional.intf.anno.1", ex.getDiagnostic());
mcimadamore@1497 2619 }
mcimadamore@1497 2620 }
mcimadamore@1497 2621 }
duke@1 2622 }
duke@1 2623
jjg@1521 2624 public void validateTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2625 Assert.checkNonNull(a.type, "annotation tree hasn't been attributed yet: " + a);
jjg@1521 2626 validateAnnotationTree(a);
jjg@1521 2627
jjg@1521 2628 if (!isTypeAnnotation(a, isTypeParameter))
jjg@1521 2629 log.error(a.pos(), "annotation.type.not.applicable");
jjg@1521 2630 }
jjg@1521 2631
jfranck@1313 2632 /**
jjg@1492 2633 * Validate the proposed container 'repeatable' on the
jfranck@1313 2634 * annotation type symbol 's'. Report errors at position
jfranck@1313 2635 * 'pos'.
jfranck@1313 2636 *
jjg@1492 2637 * @param s The (annotation)type declaration annotated with a @Repeatable
jjg@1492 2638 * @param repeatable the @Repeatable on 's'
jfranck@1313 2639 * @param pos where to report errors
jfranck@1313 2640 */
jjg@1492 2641 public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) {
jjg@1492 2642 Assert.check(types.isSameType(repeatable.type, syms.repeatableType));
jfranck@1313 2643
jfranck@1313 2644 Type t = null;
jjg@1492 2645 List<Pair<MethodSymbol,Attribute>> l = repeatable.values;
jfranck@1313 2646 if (!l.isEmpty()) {
jfranck@1313 2647 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2648 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2649 }
jfranck@1313 2650
jfranck@1313 2651 if (t == null) {
jjg@1492 2652 // errors should already have been reported during Annotate
jfranck@1313 2653 return;
jfranck@1313 2654 }
jfranck@1313 2655
jjg@1492 2656 validateValue(t.tsym, s, pos);
jfranck@1313 2657 validateRetention(t.tsym, s, pos);
jfranck@1313 2658 validateDocumented(t.tsym, s, pos);
jfranck@1313 2659 validateInherited(t.tsym, s, pos);
jfranck@1313 2660 validateTarget(t.tsym, s, pos);
jfranck@1344 2661 validateDefault(t.tsym, s, pos);
jfranck@1313 2662 }
jfranck@1313 2663
jjg@1492 2664 private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jjg@1492 2665 Scope.Entry e = container.members().lookup(names.value);
jjg@1492 2666 if (e.scope != null && e.sym.kind == MTH) {
jjg@1492 2667 MethodSymbol m = (MethodSymbol) e.sym;
jjg@1492 2668 Type ret = m.getReturnType();
jjg@1492 2669 if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) {
jjg@1492 2670 log.error(pos, "invalid.repeatable.annotation.value.return",
jjg@1492 2671 container, ret, types.makeArrayType(contained.type));
jjg@1492 2672 }
jjg@1492 2673 } else {
jjg@1492 2674 log.error(pos, "invalid.repeatable.annotation.no.value", container);
jfranck@1313 2675 }
jfranck@1313 2676 }
jfranck@1313 2677
jfranck@1313 2678 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2679 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2680 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2681
jfranck@1313 2682 boolean error = false;
jfranck@1313 2683 switch (containedRetention) {
jfranck@1313 2684 case RUNTIME:
jfranck@1313 2685 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2686 error = true;
jfranck@1313 2687 }
jfranck@1313 2688 break;
jfranck@1313 2689 case CLASS:
jfranck@1313 2690 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2691 error = true;
jfranck@1313 2692 }
jfranck@1313 2693 }
jfranck@1313 2694 if (error ) {
jjg@1492 2695 log.error(pos, "invalid.repeatable.annotation.retention",
jfranck@1313 2696 container, containerRetention,
jfranck@1313 2697 contained, containedRetention);
jfranck@1313 2698 }
jfranck@1313 2699 }
jfranck@1313 2700
jfranck@1313 2701 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2702 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2703 if (container.attribute(syms.documentedType.tsym) == null) {
jjg@1492 2704 log.error(pos, "invalid.repeatable.annotation.not.documented", container, contained);
jfranck@1313 2705 }
jfranck@1313 2706 }
jfranck@1313 2707 }
jfranck@1313 2708
jfranck@1313 2709 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2710 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2711 if (container.attribute(syms.inheritedType.tsym) == null) {
jjg@1492 2712 log.error(pos, "invalid.repeatable.annotation.not.inherited", container, contained);
jfranck@1313 2713 }
jfranck@1313 2714 }
jfranck@1313 2715 }
jfranck@1313 2716
jfranck@1313 2717 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2718 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1313 2719
jfranck@1313 2720 // If contained has no Target, we are done
jfranck@1313 2721 if (containedTarget == null) {
jfranck@1313 2722 return;
jfranck@1313 2723 }
jfranck@1313 2724
jfranck@1313 2725 // If contained has Target m1, container must have a Target
jfranck@1313 2726 // annotation, m2, and m2 must be a subset of m1. (This is
jfranck@1313 2727 // trivially true if contained has no target as per above).
jfranck@1313 2728
jfranck@1313 2729 // contained has target, but container has not, error
jfranck@1313 2730 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2731 if (containerTarget == null) {
jjg@1492 2732 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2733 return;
jfranck@1313 2734 }
jfranck@1313 2735
jfranck@1313 2736 Set<Name> containerTargets = new HashSet<Name>();
jfranck@1313 2737 for (Attribute app : containerTarget.values) {
jfranck@1313 2738 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2739 continue; // recovery
jfranck@1313 2740 }
jfranck@1313 2741 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2742 containerTargets.add(e.value.name);
jfranck@1313 2743 }
jfranck@1313 2744
jfranck@1313 2745 Set<Name> containedTargets = new HashSet<Name>();
jfranck@1313 2746 for (Attribute app : containedTarget.values) {
jfranck@1313 2747 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2748 continue; // recovery
jfranck@1313 2749 }
jfranck@1313 2750 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2751 containedTargets.add(e.value.name);
jfranck@1313 2752 }
jfranck@1313 2753
jfranck@1313 2754 if (!isTargetSubset(containedTargets, containerTargets)) {
jjg@1492 2755 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2756 }
jfranck@1313 2757 }
jfranck@1313 2758
jfranck@1313 2759 /** Checks that t is a subset of s, with respect to ElementType
jfranck@1313 2760 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE}
jfranck@1313 2761 */
jfranck@1313 2762 private boolean isTargetSubset(Set<Name> s, Set<Name> t) {
jfranck@1313 2763 // Check that all elements in t are present in s
jfranck@1313 2764 for (Name n2 : t) {
jfranck@1313 2765 boolean currentElementOk = false;
jfranck@1313 2766 for (Name n1 : s) {
jfranck@1313 2767 if (n1 == n2) {
jfranck@1313 2768 currentElementOk = true;
jfranck@1313 2769 break;
jfranck@1313 2770 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2771 currentElementOk = true;
jfranck@1313 2772 break;
jfranck@1313 2773 }
jfranck@1313 2774 }
jfranck@1313 2775 if (!currentElementOk)
jfranck@1313 2776 return false;
jfranck@1313 2777 }
jfranck@1313 2778 return true;
jfranck@1313 2779 }
jfranck@1313 2780
jfranck@1344 2781 private void validateDefault(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1344 2782 // validate that all other elements of containing type has defaults
jfranck@1344 2783 Scope scope = container.members();
jfranck@1344 2784 for(Symbol elm : scope.getElements()) {
jfranck@1344 2785 if (elm.name != names.value &&
jfranck@1344 2786 elm.kind == Kinds.MTH &&
jfranck@1344 2787 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2788 log.error(pos,
jjg@1492 2789 "invalid.repeatable.annotation.elem.nondefault",
jfranck@1344 2790 container,
jfranck@1344 2791 elm);
jfranck@1344 2792 }
jfranck@1344 2793 }
jfranck@1344 2794 }
jfranck@1344 2795
duke@1 2796 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2797 boolean isOverrider(Symbol s) {
duke@1 2798 if (s.kind != MTH || s.isStatic())
duke@1 2799 return false;
duke@1 2800 MethodSymbol m = (MethodSymbol)s;
duke@1 2801 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2802 for (Type sup : types.closure(owner.type)) {
duke@1 2803 if (sup == owner.type)
duke@1 2804 continue; // skip "this"
duke@1 2805 Scope scope = sup.tsym.members();
duke@1 2806 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2807 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2808 return true;
duke@1 2809 }
duke@1 2810 }
duke@1 2811 return false;
duke@1 2812 }
duke@1 2813
jjg@1521 2814 /** Is the annotation applicable to type annotations? */
jjg@1521 2815 protected boolean isTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2816 Attribute.Compound atTarget =
jjg@1521 2817 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
jjg@1521 2818 if (atTarget == null) {
jjg@1521 2819 // An annotation without @Target is not a type annotation.
jjg@1521 2820 return false;
jjg@1521 2821 }
jjg@1521 2822
jjg@1521 2823 Attribute atValue = atTarget.member(names.value);
jjg@1521 2824 if (!(atValue instanceof Attribute.Array)) {
jjg@1521 2825 return false; // error recovery
jjg@1521 2826 }
jjg@1521 2827
jjg@1521 2828 Attribute.Array arr = (Attribute.Array) atValue;
jjg@1521 2829 for (Attribute app : arr.values) {
jjg@1521 2830 if (!(app instanceof Attribute.Enum)) {
jjg@1521 2831 return false; // recovery
jjg@1521 2832 }
jjg@1521 2833 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 2834
jjg@1521 2835 if (e.value.name == names.TYPE_USE)
jjg@1521 2836 return true;
jjg@1521 2837 else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER)
jjg@1521 2838 return true;
jjg@1521 2839 }
jjg@1521 2840 return false;
jjg@1521 2841 }
jjg@1521 2842
duke@1 2843 /** Is the annotation applicable to the symbol? */
duke@1 2844 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 2845 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jjg@1521 2846 Name[] targets;
jjg@1521 2847
jfranck@1313 2848 if (arr == null) {
jjg@1521 2849 targets = defaultTargetMetaInfo(a, s);
jjg@1521 2850 } else {
jjg@1521 2851 // TODO: can we optimize this?
jjg@1521 2852 targets = new Name[arr.values.length];
jjg@1521 2853 for (int i=0; i<arr.values.length; ++i) {
jjg@1521 2854 Attribute app = arr.values[i];
jjg@1521 2855 if (!(app instanceof Attribute.Enum)) {
jjg@1521 2856 return true; // recovery
jjg@1521 2857 }
jjg@1521 2858 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 2859 targets[i] = e.value.name;
jjg@1521 2860 }
jfranck@1313 2861 }
jjg@1521 2862 for (Name target : targets) {
jjg@1521 2863 if (target == names.TYPE)
duke@1 2864 { if (s.kind == TYP) return true; }
jjg@1521 2865 else if (target == names.FIELD)
duke@1 2866 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
jjg@1521 2867 else if (target == names.METHOD)
duke@1 2868 { if (s.kind == MTH && !s.isConstructor()) return true; }
jjg@1521 2869 else if (target == names.PARAMETER)
duke@1 2870 { if (s.kind == VAR &&
duke@1 2871 s.owner.kind == MTH &&
duke@1 2872 (s.flags() & PARAMETER) != 0)
duke@1 2873 return true;
duke@1 2874 }
jjg@1521 2875 else if (target == names.CONSTRUCTOR)
duke@1 2876 { if (s.kind == MTH && s.isConstructor()) return true; }
jjg@1521 2877 else if (target == names.LOCAL_VARIABLE)
duke@1 2878 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2879 (s.flags() & PARAMETER) == 0)
duke@1 2880 return true;
duke@1 2881 }
jjg@1521 2882 else if (target == names.ANNOTATION_TYPE)
duke@1 2883 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2884 return true;
duke@1 2885 }
jjg@1521 2886 else if (target == names.PACKAGE)
duke@1 2887 { if (s.kind == PCK) return true; }
jjg@1521 2888 else if (target == names.TYPE_USE)
jjg@308 2889 { if (s.kind == TYP ||
jjg@308 2890 s.kind == VAR ||
jjg@308 2891 (s.kind == MTH && !s.isConstructor() &&
jjg@1521 2892 !s.type.getReturnType().hasTag(VOID)) ||
jjg@1521 2893 (s.kind == MTH && s.isConstructor()))
jjg@1521 2894 return true;
jjg@1521 2895 }
jjg@1521 2896 else if (target == names.TYPE_PARAMETER)
jjg@1521 2897 { if (s.kind == TYP && s.type.hasTag(TYPEVAR))
jjg@308 2898 return true;
jjg@308 2899 }
duke@1 2900 else
duke@1 2901 return true; // recovery
duke@1 2902 }
duke@1 2903 return false;
duke@1 2904 }
duke@1 2905
jfranck@1313 2906
jfranck@1313 2907 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 2908 Attribute.Compound atTarget =
jfranck@1313 2909 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 2910 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 2911 Attribute atValue = atTarget.member(names.value);
jfranck@1313 2912 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 2913 return (Attribute.Array) atValue;
jfranck@1313 2914 }
jfranck@1313 2915
jjg@1521 2916 private final Name[] dfltTargetMeta;
jjg@1521 2917 private Name[] defaultTargetMetaInfo(JCAnnotation a, Symbol s) {
jjg@1521 2918 return dfltTargetMeta;
jjg@1521 2919 }
jjg@1521 2920
duke@1 2921 /** Check an annotation value.
jfranck@1445 2922 *
jfranck@1445 2923 * @param a The annotation tree to check
jfranck@1445 2924 * @return true if this annotation tree is valid, otherwise false
duke@1 2925 */
jfranck@1445 2926 public boolean validateAnnotationDeferErrors(JCAnnotation a) {
jfranck@1445 2927 boolean res = false;
jfranck@1445 2928 final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log);
jfranck@1445 2929 try {
jfranck@1445 2930 res = validateAnnotation(a);
jfranck@1445 2931 } finally {
jfranck@1445 2932 log.popDiagnosticHandler(diagHandler);
jfranck@1445 2933 }
jfranck@1445 2934 return res;
jfranck@1445 2935 }
jfranck@1445 2936
jfranck@1445 2937 private boolean validateAnnotation(JCAnnotation a) {
jfranck@1445 2938 boolean isValid = true;
jfranck@1445 2939 // collect an inventory of the annotation elements
jfranck@1445 2940 Set<MethodSymbol> members = new LinkedHashSet<MethodSymbol>();
duke@1 2941 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2942 e != null;
duke@1 2943 e = e.sibling)
duke@1 2944 if (e.sym.kind == MTH)
duke@1 2945 members.add((MethodSymbol) e.sym);
duke@1 2946
jfranck@1445 2947 // remove the ones that are assigned values
duke@1 2948 for (JCTree arg : a.args) {
jjg@1127 2949 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 2950 JCAssign assign = (JCAssign) arg;
duke@1 2951 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2952 if (m == null || m.type.isErroneous()) continue;
jfranck@1445 2953 if (!members.remove(m)) {
jfranck@1445 2954 isValid = false;
jjg@479 2955 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2956 m.name, a.type);
jfranck@1445 2957 }
duke@1 2958 }
duke@1 2959
duke@1 2960 // all the remaining ones better have default values
jfranck@1445 2961 List<Name> missingDefaults = List.nil();
mcimadamore@632 2962 for (MethodSymbol m : members) {
mcimadamore@632 2963 if (m.defaultValue == null && !m.type.isErroneous()) {
jfranck@1445 2964 missingDefaults = missingDefaults.append(m.name);
mcimadamore@632 2965 }
mcimadamore@632 2966 }
jfranck@1445 2967 missingDefaults = missingDefaults.reverse();
mcimadamore@632 2968 if (missingDefaults.nonEmpty()) {
jfranck@1445 2969 isValid = false;
mcimadamore@632 2970 String key = (missingDefaults.size() > 1)
mcimadamore@632 2971 ? "annotation.missing.default.value.1"
mcimadamore@632 2972 : "annotation.missing.default.value";
mcimadamore@632 2973 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 2974 }
duke@1 2975
duke@1 2976 // special case: java.lang.annotation.Target must not have
duke@1 2977 // repeated values in its value member
duke@1 2978 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2979 a.args.tail == null)
jfranck@1445 2980 return isValid;
duke@1 2981
jfranck@1445 2982 if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery
duke@1 2983 JCAssign assign = (JCAssign) a.args.head;
duke@1 2984 Symbol m = TreeInfo.symbol(assign.lhs);
jfranck@1445 2985 if (m.name != names.value) return false;
duke@1 2986 JCTree rhs = assign.rhs;
jfranck@1445 2987 if (!rhs.hasTag(NEWARRAY)) return false;
duke@1 2988 JCNewArray na = (JCNewArray) rhs;
duke@1 2989 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2990 for (JCTree elem : na.elems) {
duke@1 2991 if (!targets.add(TreeInfo.symbol(elem))) {
jfranck@1445 2992 isValid = false;
duke@1 2993 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2994 }
duke@1 2995 }
jfranck@1445 2996 return isValid;
duke@1 2997 }
duke@1 2998
duke@1 2999 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 3000 if (allowAnnotations &&
mcimadamore@795 3001 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 3002 (s.flags() & DEPRECATED) != 0 &&
duke@1 3003 !syms.deprecatedType.isErroneous() &&
duke@1 3004 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 3005 log.warning(LintCategory.DEP_ANN,
jjg@612 3006 pos, "missing.deprecated.annotation");
duke@1 3007 }
duke@1 3008 }
duke@1 3009
mcimadamore@852 3010 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 3011 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 3012 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 3013 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 3014 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3015 @Override
mcimadamore@852 3016 public void report() {
mcimadamore@852 3017 warnDeprecated(pos, s);
mcimadamore@852 3018 }
mcimadamore@852 3019 });
jjg@1157 3020 }
mcimadamore@852 3021 }
mcimadamore@852 3022
mcimadamore@852 3023 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 3024 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 3025 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3026 public void report() {
mcimadamore@852 3027 if (enableSunApiLintControl)
mcimadamore@852 3028 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 3029 else
mcimadamore@1218 3030 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 3031 }
mcimadamore@852 3032 });
mcimadamore@852 3033 }
mcimadamore@852 3034 }
mcimadamore@852 3035
duke@1 3036 /* *************************************************************************
duke@1 3037 * Check for recursive annotation elements.
duke@1 3038 **************************************************************************/
duke@1 3039
duke@1 3040 /** Check for cycles in the graph of annotation elements.
duke@1 3041 */
duke@1 3042 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 3043 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 3044 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 3045 try {
duke@1 3046 tree.sym.flags_field |= LOCKED;
duke@1 3047 for (JCTree def : tree.defs) {
jjg@1127 3048 if (!def.hasTag(METHODDEF)) continue;
duke@1 3049 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 3050 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 3051 }
duke@1 3052 } finally {
duke@1 3053 tree.sym.flags_field &= ~LOCKED;
duke@1 3054 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 3055 }
duke@1 3056 }
duke@1 3057
duke@1 3058 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 3059 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 3060 return;
duke@1 3061 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 3062 log.error(pos, "cyclic.annotation.element");
duke@1 3063 return;
duke@1 3064 }
duke@1 3065 try {
duke@1 3066 tsym.flags_field |= LOCKED;
duke@1 3067 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 3068 Symbol s = e.sym;
duke@1 3069 if (s.kind != Kinds.MTH)
duke@1 3070 continue;
duke@1 3071 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 3072 }
duke@1 3073 } finally {
duke@1 3074 tsym.flags_field &= ~LOCKED;
duke@1 3075 tsym.flags_field |= ACYCLIC_ANN;
duke@1 3076 }
duke@1 3077 }
duke@1 3078
duke@1 3079 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
jjg@1374 3080 switch (type.getTag()) {
jjg@1374 3081 case CLASS:
duke@1 3082 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 3083 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 3084 break;
jjg@1374 3085 case ARRAY:
duke@1 3086 checkAnnotationResType(pos, types.elemtype(type));
duke@1 3087 break;
duke@1 3088 default:
duke@1 3089 break; // int etc
duke@1 3090 }
duke@1 3091 }
duke@1 3092
duke@1 3093 /* *************************************************************************
duke@1 3094 * Check for cycles in the constructor call graph.
duke@1 3095 **************************************************************************/
duke@1 3096
duke@1 3097 /** Check for cycles in the graph of constructors calling other
duke@1 3098 * constructors.
duke@1 3099 */
duke@1 3100 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 3101 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 3102
duke@1 3103 // enter each constructor this-call into the map
duke@1 3104 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 3105 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 3106 if (app == null) continue;
duke@1 3107 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 3108 if (TreeInfo.name(app.meth) == names._this) {
duke@1 3109 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 3110 } else {
duke@1 3111 meth.sym.flags_field |= ACYCLIC;
duke@1 3112 }
duke@1 3113 }
duke@1 3114
duke@1 3115 // Check for cycles in the map
duke@1 3116 Symbol[] ctors = new Symbol[0];
duke@1 3117 ctors = callMap.keySet().toArray(ctors);
duke@1 3118 for (Symbol caller : ctors) {
duke@1 3119 checkCyclicConstructor(tree, caller, callMap);
duke@1 3120 }
duke@1 3121 }
duke@1 3122
duke@1 3123 /** Look in the map to see if the given constructor is part of a
duke@1 3124 * call cycle.
duke@1 3125 */
duke@1 3126 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 3127 Map<Symbol,Symbol> callMap) {
duke@1 3128 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 3129 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 3130 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 3131 "recursive.ctor.invocation");
duke@1 3132 } else {
duke@1 3133 ctor.flags_field |= LOCKED;
duke@1 3134 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 3135 ctor.flags_field &= ~LOCKED;
duke@1 3136 }
duke@1 3137 ctor.flags_field |= ACYCLIC;
duke@1 3138 }
duke@1 3139 }
duke@1 3140
duke@1 3141 /* *************************************************************************
duke@1 3142 * Miscellaneous
duke@1 3143 **************************************************************************/
duke@1 3144
duke@1 3145 /**
duke@1 3146 * Return the opcode of the operator but emit an error if it is an
duke@1 3147 * error.
duke@1 3148 * @param pos position for error reporting.
duke@1 3149 * @param operator an operator
duke@1 3150 * @param tag a tree tag
duke@1 3151 * @param left type of left hand side
duke@1 3152 * @param right type of right hand side
duke@1 3153 */
duke@1 3154 int checkOperator(DiagnosticPosition pos,
duke@1 3155 OperatorSymbol operator,
jjg@1127 3156 JCTree.Tag tag,
duke@1 3157 Type left,
duke@1 3158 Type right) {
duke@1 3159 if (operator.opcode == ByteCodes.error) {
duke@1 3160 log.error(pos,
mcimadamore@853 3161 "operator.cant.be.applied.1",
duke@1 3162 treeinfo.operatorName(tag),
mcimadamore@853 3163 left, right);
duke@1 3164 }
duke@1 3165 return operator.opcode;
duke@1 3166 }
duke@1 3167
duke@1 3168
duke@1 3169 /**
duke@1 3170 * Check for division by integer constant zero
duke@1 3171 * @param pos Position for error reporting.
duke@1 3172 * @param operator The operator for the expression
duke@1 3173 * @param operand The right hand operand for the expression
duke@1 3174 */
duke@1 3175 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3176 if (operand.constValue() != null
mcimadamore@795 3177 && lint.isEnabled(LintCategory.DIVZERO)
jjg@1374 3178 && (operand.getTag().isSubRangeOf(LONG))
duke@1 3179 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3180 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3181 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3182 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3183 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3184 }
duke@1 3185 }
duke@1 3186 }
duke@1 3187
duke@1 3188 /**
duke@1 3189 * Check for empty statements after if
duke@1 3190 */
duke@1 3191 void checkEmptyIf(JCIf tree) {
jjg@1127 3192 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3193 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3194 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3195 }
duke@1 3196
duke@1 3197 /** Check that symbol is unique in given scope.
duke@1 3198 * @param pos Position for error reporting.
duke@1 3199 * @param sym The symbol.
duke@1 3200 * @param s The scope.
duke@1 3201 */
duke@1 3202 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3203 if (sym.type.isErroneous())
duke@1 3204 return true;
duke@1 3205 if (sym.owner.name == names.any) return false;
duke@1 3206 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3207 if (sym != e.sym &&
mcimadamore@858 3208 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3209 sym.kind == e.sym.kind &&
mcimadamore@858 3210 sym.name != names.error &&
mcimadamore@858 3211 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3212 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3213 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3214 return true;
mcimadamore@907 3215 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3216 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3217 sym.flags_field |= CLASH;
mcimadamore@844 3218 return true;
mcimadamore@844 3219 } else {
duke@1 3220 duplicateError(pos, e.sym);
mcimadamore@844 3221 return false;
mcimadamore@844 3222 }
duke@1 3223 }
duke@1 3224 }
duke@1 3225 return true;
duke@1 3226 }
mcimadamore@844 3227
mcimadamore@858 3228 /** Report duplicate declaration error.
mcimadamore@858 3229 */
mcimadamore@858 3230 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3231 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3232 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3233 }
mcimadamore@858 3234 }
duke@1 3235
duke@1 3236 /** Check that single-type import is not already imported or top-level defined,
duke@1 3237 * but make an exception for two single-type imports which denote the same type.
duke@1 3238 * @param pos Position for error reporting.
duke@1 3239 * @param sym The symbol.
duke@1 3240 * @param s The scope
duke@1 3241 */
duke@1 3242 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3243 return checkUniqueImport(pos, sym, s, false);
duke@1 3244 }
duke@1 3245
duke@1 3246 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3247 * but make an exception for two single-type imports which denote the same type.
duke@1 3248 * @param pos Position for error reporting.
duke@1 3249 * @param sym The symbol.
duke@1 3250 * @param s The scope
duke@1 3251 */
duke@1 3252 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3253 return checkUniqueImport(pos, sym, s, true);
duke@1 3254 }
duke@1 3255
duke@1 3256 /** Check that single-type import is not already imported or top-level defined,
duke@1 3257 * but make an exception for two single-type imports which denote the same type.
duke@1 3258 * @param pos Position for error reporting.
duke@1 3259 * @param sym The symbol.
duke@1 3260 * @param s The scope.
duke@1 3261 * @param staticImport Whether or not this was a static import
duke@1 3262 */
duke@1 3263 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3264 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3265 // is encountered class entered via a class declaration?
duke@1 3266 boolean isClassDecl = e.scope == s;
duke@1 3267 if ((isClassDecl || sym != e.sym) &&
duke@1 3268 sym.kind == e.sym.kind &&
duke@1 3269 sym.name != names.error) {
duke@1 3270 if (!e.sym.type.isErroneous()) {
duke@1 3271 String what = e.sym.toString();
duke@1 3272 if (!isClassDecl) {
duke@1 3273 if (staticImport)
duke@1 3274 log.error(pos, "already.defined.static.single.import", what);
duke@1 3275 else
duke@1 3276 log.error(pos, "already.defined.single.import", what);
duke@1 3277 }
duke@1 3278 else if (sym != e.sym)
duke@1 3279 log.error(pos, "already.defined.this.unit", what);
duke@1 3280 }
duke@1 3281 return false;
duke@1 3282 }
duke@1 3283 }
duke@1 3284 return true;
duke@1 3285 }
duke@1 3286
duke@1 3287 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3288 */
duke@1 3289 public void checkCanonical(JCTree tree) {
duke@1 3290 if (!isCanonical(tree))
duke@1 3291 log.error(tree.pos(), "import.requires.canonical",
duke@1 3292 TreeInfo.symbol(tree));
duke@1 3293 }
duke@1 3294 // where
duke@1 3295 private boolean isCanonical(JCTree tree) {
jjg@1127 3296 while (tree.hasTag(SELECT)) {
duke@1 3297 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3298 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3299 return false;
duke@1 3300 tree = s.selected;
duke@1 3301 }
duke@1 3302 return true;
duke@1 3303 }
duke@1 3304
ohrstrom@1384 3305 /** Check that an auxiliary class is not accessed from any other file than its own.
ohrstrom@1384 3306 */
ohrstrom@1384 3307 void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) {
ohrstrom@1384 3308 if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) &&
ohrstrom@1384 3309 (c.flags() & AUXILIARY) != 0 &&
ohrstrom@1384 3310 rs.isAccessible(env, c) &&
ohrstrom@1384 3311 !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile))
ohrstrom@1384 3312 {
ohrstrom@1384 3313 log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file",
ohrstrom@1384 3314 c, c.sourcefile);
ohrstrom@1384 3315 }
ohrstrom@1384 3316 }
ohrstrom@1384 3317
duke@1 3318 private class ConversionWarner extends Warner {
mcimadamore@795 3319 final String uncheckedKey;
duke@1 3320 final Type found;
duke@1 3321 final Type expected;
mcimadamore@795 3322 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3323 super(pos);
mcimadamore@795 3324 this.uncheckedKey = uncheckedKey;
duke@1 3325 this.found = found;
duke@1 3326 this.expected = expected;
duke@1 3327 }
duke@1 3328
jjg@398 3329 @Override
mcimadamore@795 3330 public void warn(LintCategory lint) {
duke@1 3331 boolean warned = this.warned;
mcimadamore@795 3332 super.warn(lint);
duke@1 3333 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3334 switch (lint) {
mcimadamore@795 3335 case UNCHECKED:
mcimadamore@795 3336 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3337 break;
mcimadamore@795 3338 case VARARGS:
mcimadamore@795 3339 if (method != null &&
mcimadamore@795 3340 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3341 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3342 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3343 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3344 }
mcimadamore@795 3345 break;
mcimadamore@795 3346 default:
mcimadamore@795 3347 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3348 }
duke@1 3349 }
duke@1 3350 }
duke@1 3351
duke@1 3352 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3353 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3354 }
duke@1 3355
duke@1 3356 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3357 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3358 }
duke@1 3359 }

mercurial