src/share/classes/com/sun/tools/javac/comp/Check.java

Wed, 16 Jan 2013 16:30:11 +0000

author
mcimadamore
date
Wed, 16 Jan 2013 16:30:11 +0000
changeset 1497
7aa2025bbb7b
parent 1496
f785dcac17b7
child 1510
7873d37f5b37
permissions
-rw-r--r--

8005299: Add FunctionalInterface checking to javac
Summary: Javac should check that types annotated with @FunctionalInterface are indeed functional interfaces
Reviewed-by: jjg

duke@1 1 /*
jjg@1492 2 * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
ohrstrom@1384 30 import javax.tools.JavaFileManager;
duke@1 31
duke@1 32 import com.sun.tools.javac.code.*;
duke@1 33 import com.sun.tools.javac.jvm.*;
duke@1 34 import com.sun.tools.javac.tree.*;
duke@1 35 import com.sun.tools.javac.util.*;
duke@1 36 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 37 import com.sun.tools.javac.util.List;
duke@1 38
duke@1 39 import com.sun.tools.javac.tree.JCTree.*;
duke@1 40 import com.sun.tools.javac.code.Lint;
duke@1 41 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 42 import com.sun.tools.javac.code.Type.*;
duke@1 43 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 44 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 45 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1337 46 import com.sun.tools.javac.comp.Infer.InferenceContext.FreeTypeListener;
duke@1 47
duke@1 48 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 49 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 50 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 51 import static com.sun.tools.javac.code.Kinds.*;
jjg@1374 52 import static com.sun.tools.javac.code.TypeTag.*;
jjg@1374 53 import static com.sun.tools.javac.code.TypeTag.WILDCARD;
duke@1 54
jjg@1127 55 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 56
duke@1 57 /** Type checking helper class for the attribution phase.
duke@1 58 *
jjg@581 59 * <p><b>This is NOT part of any supported API.
jjg@581 60 * If you write code that depends on this, you do so at your own risk.
duke@1 61 * This code and its internal interfaces are subject to change or
duke@1 62 * deletion without notice.</b>
duke@1 63 */
duke@1 64 public class Check {
duke@1 65 protected static final Context.Key<Check> checkKey =
duke@1 66 new Context.Key<Check>();
duke@1 67
jjg@113 68 private final Names names;
duke@1 69 private final Log log;
mcimadamore@1219 70 private final Resolve rs;
duke@1 71 private final Symtab syms;
mcimadamore@690 72 private final Enter enter;
mcimadamore@1347 73 private final DeferredAttr deferredAttr;
duke@1 74 private final Infer infer;
duke@1 75 private final Types types;
mcimadamore@89 76 private final JCDiagnostic.Factory diags;
mcimadamore@359 77 private boolean warnOnSyntheticConflicts;
jjg@576 78 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 79 private boolean enableSunApiLintControl;
duke@1 80 private final TreeInfo treeinfo;
ohrstrom@1384 81 private final JavaFileManager fileManager;
duke@1 82
duke@1 83 // The set of lint options currently in effect. It is initialized
duke@1 84 // from the context, and then is set/reset as needed by Attr as it
duke@1 85 // visits all the various parts of the trees during attribution.
duke@1 86 private Lint lint;
duke@1 87
mcimadamore@795 88 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 89 // Attr as it visits new method declarations.
mcimadamore@795 90 private MethodSymbol method;
mcimadamore@795 91
duke@1 92 public static Check instance(Context context) {
duke@1 93 Check instance = context.get(checkKey);
duke@1 94 if (instance == null)
duke@1 95 instance = new Check(context);
duke@1 96 return instance;
duke@1 97 }
duke@1 98
duke@1 99 protected Check(Context context) {
duke@1 100 context.put(checkKey, this);
duke@1 101
jjg@113 102 names = Names.instance(context);
duke@1 103 log = Log.instance(context);
mcimadamore@1219 104 rs = Resolve.instance(context);
duke@1 105 syms = Symtab.instance(context);
mcimadamore@690 106 enter = Enter.instance(context);
mcimadamore@1347 107 deferredAttr = DeferredAttr.instance(context);
duke@1 108 infer = Infer.instance(context);
duke@1 109 this.types = Types.instance(context);
mcimadamore@89 110 diags = JCDiagnostic.Factory.instance(context);
duke@1 111 Options options = Options.instance(context);
duke@1 112 lint = Lint.instance(context);
duke@1 113 treeinfo = TreeInfo.instance(context);
ohrstrom@1384 114 fileManager = context.get(JavaFileManager.class);
duke@1 115
duke@1 116 Source source = Source.instance(context);
duke@1 117 allowGenerics = source.allowGenerics();
mcimadamore@1219 118 allowVarargs = source.allowVarargs();
duke@1 119 allowAnnotations = source.allowAnnotations();
jjg@398 120 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 121 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
mcimadamore@1393 122 allowDefaultMethods = source.allowDefaultMethods();
mcimadamore@1415 123 allowStrictMethodClashCheck = source.allowStrictMethodClashCheck();
jjg@1157 124 complexInference = options.isSet("complexinference");
jjg@700 125 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 126 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 127 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 128
jjg@398 129 Target target = Target.instance(context);
jjg@398 130 syntheticNameChar = target.syntheticNameChar();
jjg@398 131
duke@1 132 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 133 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 134 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 135 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 136
jjg@60 137 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 138 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 139 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 140 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 141 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 142 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 143
mcimadamore@852 144 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 145 }
duke@1 146
duke@1 147 /** Switch: generics enabled?
duke@1 148 */
duke@1 149 boolean allowGenerics;
duke@1 150
mcimadamore@1219 151 /** Switch: varargs enabled?
mcimadamore@1219 152 */
mcimadamore@1219 153 boolean allowVarargs;
mcimadamore@1219 154
duke@1 155 /** Switch: annotations enabled?
duke@1 156 */
duke@1 157 boolean allowAnnotations;
duke@1 158
jjg@398 159 /** Switch: covariant returns enabled?
jjg@398 160 */
jjg@398 161 boolean allowCovariantReturns;
jjg@398 162
mcimadamore@795 163 /** Switch: simplified varargs enabled?
mcimadamore@795 164 */
mcimadamore@795 165 boolean allowSimplifiedVarargs;
mcimadamore@795 166
mcimadamore@1393 167 /** Switch: default methods enabled?
mcimadamore@1393 168 */
mcimadamore@1393 169 boolean allowDefaultMethods;
mcimadamore@1393 170
mcimadamore@1393 171 /** Switch: should unrelated return types trigger a method clash?
mcimadamore@1393 172 */
mcimadamore@1393 173 boolean allowStrictMethodClashCheck;
mcimadamore@1393 174
duke@1 175 /** Switch: -complexinference option set?
duke@1 176 */
duke@1 177 boolean complexInference;
duke@1 178
jjg@398 179 /** Character for synthetic names
jjg@398 180 */
jjg@398 181 char syntheticNameChar;
jjg@398 182
duke@1 183 /** A table mapping flat names of all compiled classes in this run to their
duke@1 184 * symbols; maintained from outside.
duke@1 185 */
duke@1 186 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 187
duke@1 188 /** A handler for messages about deprecated usage.
duke@1 189 */
duke@1 190 private MandatoryWarningHandler deprecationHandler;
duke@1 191
duke@1 192 /** A handler for messages about unchecked or unsafe usage.
duke@1 193 */
duke@1 194 private MandatoryWarningHandler uncheckedHandler;
duke@1 195
jjg@582 196 /** A handler for messages about using proprietary API.
jjg@377 197 */
jjg@377 198 private MandatoryWarningHandler sunApiHandler;
duke@1 199
mcimadamore@852 200 /** A handler for deferred lint warnings.
mcimadamore@852 201 */
mcimadamore@852 202 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 203
duke@1 204 /* *************************************************************************
duke@1 205 * Errors and Warnings
duke@1 206 **************************************************************************/
duke@1 207
duke@1 208 Lint setLint(Lint newLint) {
duke@1 209 Lint prev = lint;
duke@1 210 lint = newLint;
duke@1 211 return prev;
duke@1 212 }
duke@1 213
mcimadamore@852 214 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 215 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 216 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 217 return prev;
mcimadamore@852 218 }
mcimadamore@852 219
mcimadamore@795 220 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 221 MethodSymbol prev = method;
mcimadamore@795 222 method = newMethod;
mcimadamore@795 223 return prev;
mcimadamore@795 224 }
mcimadamore@795 225
duke@1 226 /** Warn about deprecated symbol.
duke@1 227 * @param pos Position to be used for error reporting.
duke@1 228 * @param sym The deprecated symbol.
duke@1 229 */
duke@1 230 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 231 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 232 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 233 }
duke@1 234
duke@1 235 /** Warn about unchecked operation.
duke@1 236 * @param pos Position to be used for error reporting.
duke@1 237 * @param msg A string describing the problem.
duke@1 238 */
duke@1 239 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 240 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 241 uncheckedHandler.report(pos, msg, args);
duke@1 242 }
duke@1 243
mcimadamore@580 244 /** Warn about unsafe vararg method decl.
mcimadamore@580 245 * @param pos Position to be used for error reporting.
mcimadamore@580 246 */
mcimadamore@795 247 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 248 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 249 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 250 }
mcimadamore@580 251
jjg@582 252 /** Warn about using proprietary API.
jjg@377 253 * @param pos Position to be used for error reporting.
jjg@377 254 * @param msg A string describing the problem.
jjg@377 255 */
jjg@377 256 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 257 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 258 sunApiHandler.report(pos, msg, args);
jjg@377 259 }
jjg@377 260
jjg@505 261 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 262 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 263 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 264 }
jjg@505 265
duke@1 266 /**
duke@1 267 * Report any deferred diagnostics.
duke@1 268 */
duke@1 269 public void reportDeferredDiagnostics() {
duke@1 270 deprecationHandler.reportDeferredDiagnostic();
duke@1 271 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 272 sunApiHandler.reportDeferredDiagnostic();
duke@1 273 }
duke@1 274
duke@1 275
duke@1 276 /** Report a failure to complete a class.
duke@1 277 * @param pos Position to be used for error reporting.
duke@1 278 * @param ex The failure to report.
duke@1 279 */
duke@1 280 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 281 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 282 if (ex instanceof ClassReader.BadClassFile
jjg@576 283 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 284 else return syms.errType;
duke@1 285 }
duke@1 286
duke@1 287 /** Report an error that wrong type tag was found.
duke@1 288 * @param pos Position to be used for error reporting.
duke@1 289 * @param required An internationalized string describing the type tag
duke@1 290 * required.
duke@1 291 * @param found The type that was found.
duke@1 292 */
duke@1 293 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 294 // this error used to be raised by the parser,
jrose@267 295 // but has been delayed to this point:
jjg@1374 296 if (found instanceof Type && ((Type)found).hasTag(VOID)) {
jrose@267 297 log.error(pos, "illegal.start.of.type");
jrose@267 298 return syms.errType;
jrose@267 299 }
duke@1 300 log.error(pos, "type.found.req", found, required);
jjg@110 301 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 302 }
duke@1 303
duke@1 304 /** Report an error that symbol cannot be referenced before super
duke@1 305 * has been called.
duke@1 306 * @param pos Position to be used for error reporting.
duke@1 307 * @param sym The referenced symbol.
duke@1 308 */
duke@1 309 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 310 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 311 }
duke@1 312
duke@1 313 /** Report duplicate declaration error.
duke@1 314 */
duke@1 315 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 316 if (!sym.type.isErroneous()) {
mcimadamore@1085 317 Symbol location = sym.location();
mcimadamore@1085 318 if (location.kind == MTH &&
mcimadamore@1085 319 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 320 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 321 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 322 sym.location().enclClass());
mcimadamore@1085 323 } else {
mcimadamore@1085 324 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 325 kindName(sym.location()), sym.location());
mcimadamore@1085 326 }
duke@1 327 }
duke@1 328 }
duke@1 329
duke@1 330 /** Report array/varargs duplicate declaration
duke@1 331 */
duke@1 332 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 333 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 334 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 335 }
duke@1 336 }
duke@1 337
duke@1 338 /* ************************************************************************
duke@1 339 * duplicate declaration checking
duke@1 340 *************************************************************************/
duke@1 341
duke@1 342 /** Check that variable does not hide variable with same name in
duke@1 343 * immediately enclosing local scope.
duke@1 344 * @param pos Position for error reporting.
duke@1 345 * @param v The symbol.
duke@1 346 * @param s The scope.
duke@1 347 */
duke@1 348 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 349 if (s.next != null) {
duke@1 350 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 351 e.scope != null && e.sym.owner == v.owner;
duke@1 352 e = e.next()) {
duke@1 353 if (e.sym.kind == VAR &&
duke@1 354 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 355 v.name != names.error) {
duke@1 356 duplicateError(pos, e.sym);
duke@1 357 return;
duke@1 358 }
duke@1 359 }
duke@1 360 }
duke@1 361 }
duke@1 362
duke@1 363 /** Check that a class or interface does not hide a class or
duke@1 364 * interface with same name in immediately enclosing local scope.
duke@1 365 * @param pos Position for error reporting.
duke@1 366 * @param c The symbol.
duke@1 367 * @param s The scope.
duke@1 368 */
duke@1 369 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 370 if (s.next != null) {
duke@1 371 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 372 e.scope != null && e.sym.owner == c.owner;
duke@1 373 e = e.next()) {
jjg@1374 374 if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) &&
duke@1 375 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 376 c.name != names.error) {
duke@1 377 duplicateError(pos, e.sym);
duke@1 378 return;
duke@1 379 }
duke@1 380 }
duke@1 381 }
duke@1 382 }
duke@1 383
duke@1 384 /** Check that class does not have the same name as one of
duke@1 385 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 386 * return true if class is unique in its enclosing scope.
duke@1 387 * @param pos Position for error reporting.
duke@1 388 * @param name The class name.
duke@1 389 * @param s The enclosing scope.
duke@1 390 */
duke@1 391 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 392 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 393 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 394 duplicateError(pos, e.sym);
duke@1 395 return false;
duke@1 396 }
duke@1 397 }
duke@1 398 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 399 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 400 duplicateError(pos, sym);
duke@1 401 return true;
duke@1 402 }
duke@1 403 }
duke@1 404 return true;
duke@1 405 }
duke@1 406
duke@1 407 /* *************************************************************************
duke@1 408 * Class name generation
duke@1 409 **************************************************************************/
duke@1 410
duke@1 411 /** Return name of local class.
jjg@1358 412 * This is of the form {@code <enclClass> $ n <classname> }
duke@1 413 * where
duke@1 414 * enclClass is the flat name of the enclosing class,
duke@1 415 * classname is the simple name of the local class
duke@1 416 */
duke@1 417 Name localClassName(ClassSymbol c) {
duke@1 418 for (int i=1; ; i++) {
duke@1 419 Name flatname = names.
duke@1 420 fromString("" + c.owner.enclClass().flatname +
jjg@398 421 syntheticNameChar + i +
duke@1 422 c.name);
duke@1 423 if (compiled.get(flatname) == null) return flatname;
duke@1 424 }
duke@1 425 }
duke@1 426
duke@1 427 /* *************************************************************************
duke@1 428 * Type Checking
duke@1 429 **************************************************************************/
duke@1 430
mcimadamore@1238 431 /**
mcimadamore@1238 432 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 433 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 434 * vary significantly.
mcimadamore@1238 435 */
mcimadamore@1348 436 public interface CheckContext {
mcimadamore@1238 437 /**
mcimadamore@1238 438 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 439 */
mcimadamore@1238 440 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 441 /**
mcimadamore@1238 442 * Report a check error
mcimadamore@1238 443 */
mcimadamore@1296 444 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 445 /**
mcimadamore@1238 446 * Obtain a warner for this check context
mcimadamore@1238 447 */
mcimadamore@1238 448 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 449
mcimadamore@1337 450 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 451
mcimadamore@1347 452 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1238 453 }
mcimadamore@1238 454
mcimadamore@1238 455 /**
mcimadamore@1238 456 * This class represent a check context that is nested within another check
mcimadamore@1238 457 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 458 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 459 * the forwarding pattern.
mcimadamore@1238 460 */
mcimadamore@1238 461 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 462 CheckContext enclosingContext;
mcimadamore@1238 463
mcimadamore@1238 464 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 465 this.enclosingContext = enclosingContext;
mcimadamore@1238 466 }
mcimadamore@1238 467
mcimadamore@1238 468 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 469 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 470 }
mcimadamore@1238 471
mcimadamore@1296 472 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 473 enclosingContext.report(pos, details);
mcimadamore@1238 474 }
mcimadamore@1238 475
mcimadamore@1238 476 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 477 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 478 }
mcimadamore@1337 479
mcimadamore@1337 480 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 481 return enclosingContext.inferenceContext();
mcimadamore@1337 482 }
mcimadamore@1347 483
mcimadamore@1347 484 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 485 return enclosingContext.deferredAttrContext();
mcimadamore@1347 486 }
mcimadamore@1238 487 }
mcimadamore@1238 488
mcimadamore@1238 489 /**
mcimadamore@1238 490 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 491 */
mcimadamore@1238 492 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 493 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 494 log.error(pos, "prob.found.req", details);
mcimadamore@1238 495 }
mcimadamore@1238 496 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 497 return types.isAssignable(found, req, warn);
mcimadamore@1238 498 }
mcimadamore@1238 499
mcimadamore@1238 500 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 501 return convertWarner(pos, found, req);
mcimadamore@1238 502 }
mcimadamore@1337 503
mcimadamore@1337 504 public InferenceContext inferenceContext() {
mcimadamore@1337 505 return infer.emptyContext;
mcimadamore@1337 506 }
mcimadamore@1347 507
mcimadamore@1347 508 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 509 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 510 }
mcimadamore@1238 511 };
mcimadamore@1238 512
duke@1 513 /** Check that a given type is assignable to a given proto-type.
duke@1 514 * If it is, return the type, otherwise return errType.
duke@1 515 * @param pos Position to be used for error reporting.
duke@1 516 * @param found The type that was found.
duke@1 517 * @param req The type that was required.
duke@1 518 */
duke@1 519 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 520 return checkType(pos, found, req, basicHandler);
darcy@609 521 }
darcy@609 522
mcimadamore@1337 523 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 524 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 525 if (inferenceContext.free(req)) {
mcimadamore@1337 526 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 527 @Override
mcimadamore@1337 528 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1337 529 checkType(pos, found, inferenceContext.asInstType(req, types), checkContext);
mcimadamore@1337 530 }
mcimadamore@1337 531 });
mcimadamore@1337 532 }
jjg@1374 533 if (req.hasTag(ERROR))
duke@1 534 return req;
jjg@1374 535 if (req.hasTag(NONE))
duke@1 536 return found;
mcimadamore@1238 537 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 538 return found;
mcimadamore@1238 539 } else {
jjg@1374 540 if (found.getTag().isSubRangeOf(DOUBLE) && req.getTag().isSubRangeOf(DOUBLE)) {
mcimadamore@1296 541 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 542 return types.createErrorType(found);
mcimadamore@1238 543 }
mcimadamore@1296 544 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 545 return types.createErrorType(found);
duke@1 546 }
duke@1 547 }
duke@1 548
duke@1 549 /** Check that a given type can be cast to a given target type.
duke@1 550 * Return the result of the cast.
duke@1 551 * @param pos Position to be used for error reporting.
duke@1 552 * @param found The type that is being cast.
duke@1 553 * @param req The target type of the cast.
duke@1 554 */
duke@1 555 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 556 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 557 }
mcimadamore@1238 558 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 559 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 560 return req;
duke@1 561 } else {
mcimadamore@1296 562 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 563 return types.createErrorType(found);
duke@1 564 }
duke@1 565 }
mcimadamore@1237 566
mcimadamore@1237 567 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 568 * The problem should only be reported for non-292 cast
mcimadamore@1237 569 */
mcimadamore@1237 570 public void checkRedundantCast(Env<AttrContext> env, JCTypeCast tree) {
mcimadamore@1237 571 if (!tree.type.isErroneous() &&
mcimadamore@1348 572 (env.info.lint == null || env.info.lint.isEnabled(Lint.LintCategory.CAST))
mcimadamore@1348 573 && types.isSameType(tree.expr.type, tree.clazz.type)
mcimadamore@1348 574 && !is292targetTypeCast(tree)) {
mcimadamore@1237 575 log.warning(Lint.LintCategory.CAST,
mcimadamore@1237 576 tree.pos(), "redundant.cast", tree.expr.type);
mcimadamore@1237 577 }
mcimadamore@1237 578 }
mcimadamore@1237 579 //where
mcimadamore@1237 580 private boolean is292targetTypeCast(JCTypeCast tree) {
mcimadamore@1237 581 boolean is292targetTypeCast = false;
mcimadamore@1237 582 JCExpression expr = TreeInfo.skipParens(tree.expr);
mcimadamore@1237 583 if (expr.hasTag(APPLY)) {
mcimadamore@1237 584 JCMethodInvocation apply = (JCMethodInvocation)expr;
mcimadamore@1237 585 Symbol sym = TreeInfo.symbol(apply.meth);
mcimadamore@1237 586 is292targetTypeCast = sym != null &&
mcimadamore@1237 587 sym.kind == MTH &&
mcimadamore@1239 588 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 589 }
mcimadamore@1237 590 return is292targetTypeCast;
mcimadamore@1237 591 }
mcimadamore@1237 592
mcimadamore@1237 593
mcimadamore@1237 594
duke@1 595 //where
duke@1 596 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 597 * type variables?
duke@1 598 */
duke@1 599 boolean isTypeVar(Type t) {
jjg@1374 600 return t.hasTag(TYPEVAR) || t.hasTag(ARRAY) && isTypeVar(types.elemtype(t));
duke@1 601 }
duke@1 602
duke@1 603 /** Check that a type is within some bounds.
duke@1 604 *
jjg@1358 605 * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
duke@1 606 * type argument.
duke@1 607 * @param a The type that should be bounded by bs.
jjg@1358 608 * @param bound The bound.
duke@1 609 */
mcimadamore@1216 610 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 611 if (a.isUnbound()) {
mcimadamore@821 612 return true;
jjg@1374 613 } else if (!a.hasTag(WILDCARD)) {
mcimadamore@154 614 a = types.upperBound(a);
mcimadamore@1216 615 return types.isSubtype(a, bound);
mcimadamore@154 616 } else if (a.isExtendsBound()) {
mcimadamore@1415 617 return types.isCastable(bound, types.upperBound(a), types.noWarnings);
mcimadamore@154 618 } else if (a.isSuperBound()) {
mcimadamore@1216 619 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 620 }
mcimadamore@821 621 return true;
mcimadamore@154 622 }
duke@1 623
duke@1 624 /** Check that type is different from 'void'.
duke@1 625 * @param pos Position to be used for error reporting.
duke@1 626 * @param t The type to be checked.
duke@1 627 */
duke@1 628 Type checkNonVoid(DiagnosticPosition pos, Type t) {
jjg@1374 629 if (t.hasTag(VOID)) {
duke@1 630 log.error(pos, "void.not.allowed.here");
jjg@110 631 return types.createErrorType(t);
duke@1 632 } else {
duke@1 633 return t;
duke@1 634 }
duke@1 635 }
duke@1 636
mcimadamore@1496 637 Type checkClassOrArrayType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 638 if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
mcimadamore@1496 639 return typeTagError(pos,
mcimadamore@1496 640 diags.fragment("type.req.class.array"),
mcimadamore@1496 641 asTypeParam(t));
mcimadamore@1496 642 } else {
mcimadamore@1496 643 return t;
mcimadamore@1496 644 }
mcimadamore@1496 645 }
mcimadamore@1496 646
duke@1 647 /** Check that type is a class or interface type.
duke@1 648 * @param pos Position to be used for error reporting.
duke@1 649 * @param t The type to be checked.
duke@1 650 */
duke@1 651 Type checkClassType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 652 if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) {
duke@1 653 return typeTagError(pos,
mcimadamore@89 654 diags.fragment("type.req.class"),
mcimadamore@1496 655 asTypeParam(t));
mcimadamore@1496 656 } else {
duke@1 657 return t;
mcimadamore@1496 658 }
duke@1 659 }
mcimadamore@1496 660 //where
mcimadamore@1496 661 private Object asTypeParam(Type t) {
mcimadamore@1496 662 return (t.hasTag(TYPEVAR))
mcimadamore@1496 663 ? diags.fragment("type.parameter", t)
mcimadamore@1496 664 : t;
mcimadamore@1496 665 }
duke@1 666
mcimadamore@1352 667 /** Check that type is a valid qualifier for a constructor reference expression
mcimadamore@1352 668 */
mcimadamore@1352 669 Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 670 t = checkClassOrArrayType(pos, t);
jjg@1374 671 if (t.hasTag(CLASS)) {
mcimadamore@1352 672 if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
mcimadamore@1352 673 log.error(pos, "abstract.cant.be.instantiated");
mcimadamore@1352 674 t = types.createErrorType(t);
mcimadamore@1352 675 } else if ((t.tsym.flags() & ENUM) != 0) {
mcimadamore@1352 676 log.error(pos, "enum.cant.be.instantiated");
mcimadamore@1352 677 t = types.createErrorType(t);
mcimadamore@1352 678 }
mcimadamore@1352 679 }
mcimadamore@1352 680 return t;
mcimadamore@1352 681 }
mcimadamore@1352 682
duke@1 683 /** Check that type is a class or interface type.
duke@1 684 * @param pos Position to be used for error reporting.
duke@1 685 * @param t The type to be checked.
duke@1 686 * @param noBounds True if type bounds are illegal here.
duke@1 687 */
duke@1 688 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 689 t = checkClassType(pos, t);
duke@1 690 if (noBounds && t.isParameterized()) {
duke@1 691 List<Type> args = t.getTypeArguments();
duke@1 692 while (args.nonEmpty()) {
jjg@1374 693 if (args.head.hasTag(WILDCARD))
duke@1 694 return typeTagError(pos,
jjg@598 695 diags.fragment("type.req.exact"),
duke@1 696 args.head);
duke@1 697 args = args.tail;
duke@1 698 }
duke@1 699 }
duke@1 700 return t;
duke@1 701 }
duke@1 702
duke@1 703 /** Check that type is a reifiable class, interface or array type.
duke@1 704 * @param pos Position to be used for error reporting.
duke@1 705 * @param t The type to be checked.
duke@1 706 */
duke@1 707 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 708 t = checkClassOrArrayType(pos, t);
mcimadamore@1496 709 if (!t.isErroneous() && !types.isReifiable(t)) {
duke@1 710 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 711 return types.createErrorType(t);
duke@1 712 } else {
duke@1 713 return t;
duke@1 714 }
duke@1 715 }
duke@1 716
duke@1 717 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 718 * or a type variable.
duke@1 719 * @param pos Position to be used for error reporting.
duke@1 720 * @param t The type to be checked.
duke@1 721 */
duke@1 722 Type checkRefType(DiagnosticPosition pos, Type t) {
jjg@1374 723 if (t.isReference())
duke@1 724 return t;
jjg@1374 725 else
duke@1 726 return typeTagError(pos,
mcimadamore@89 727 diags.fragment("type.req.ref"),
duke@1 728 t);
duke@1 729 }
duke@1 730
jrose@267 731 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 732 * or a type variable.
jrose@267 733 * @param trees Original trees, used for error reporting.
jrose@267 734 * @param types The types to be checked.
jrose@267 735 */
jrose@267 736 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 737 List<JCExpression> tl = trees;
jrose@267 738 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 739 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 740 tl = tl.tail;
jrose@267 741 }
jrose@267 742 return types;
jrose@267 743 }
jrose@267 744
duke@1 745 /** Check that type is a null or reference type.
duke@1 746 * @param pos Position to be used for error reporting.
duke@1 747 * @param t The type to be checked.
duke@1 748 */
duke@1 749 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
jjg@1374 750 if (t.isNullOrReference())
duke@1 751 return t;
jjg@1374 752 else
duke@1 753 return typeTagError(pos,
mcimadamore@89 754 diags.fragment("type.req.ref"),
duke@1 755 t);
duke@1 756 }
duke@1 757
duke@1 758 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 759 * Return true if it doesn't.
duke@1 760 * @param pos Position to be used for error reporting.
duke@1 761 * @param flags The set of flags to be checked.
duke@1 762 * @param set1 Conflicting flags set #1.
duke@1 763 * @param set2 Conflicting flags set #2.
duke@1 764 */
duke@1 765 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 766 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 767 log.error(pos,
duke@1 768 "illegal.combination.of.modifiers",
mcimadamore@80 769 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 770 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 771 return false;
duke@1 772 } else
duke@1 773 return true;
duke@1 774 }
duke@1 775
mcimadamore@914 776 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 777 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 778 */
mcimadamore@914 779 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 780 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 781 t.isErroneous()) {
mcimadamore@914 782 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 783 } else if (tree.def != null) {
mcimadamore@914 784 log.error(tree.clazz.pos(),
mcimadamore@914 785 "cant.apply.diamond.1",
mcimadamore@914 786 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 787 return types.createErrorType(t);
mcimadamore@948 788 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 789 log.error(tree.clazz.pos(),
mcimadamore@914 790 "cant.apply.diamond.1",
mcimadamore@914 791 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 792 return types.createErrorType(t);
mcimadamore@993 793 } else if (tree.typeargs != null &&
mcimadamore@993 794 tree.typeargs.nonEmpty()) {
mcimadamore@993 795 log.error(tree.clazz.pos(),
mcimadamore@993 796 "cant.apply.diamond.1",
mcimadamore@993 797 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 798 return types.createErrorType(t);
mcimadamore@914 799 } else {
mcimadamore@914 800 return t;
mcimadamore@537 801 }
mcimadamore@537 802 }
mcimadamore@537 803
mcimadamore@795 804 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 805 MethodSymbol m = tree.sym;
mcimadamore@795 806 if (!allowSimplifiedVarargs) return;
mcimadamore@795 807 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 808 Type varargElemType = null;
mcimadamore@580 809 if (m.isVarArgs()) {
mcimadamore@795 810 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 811 }
mcimadamore@795 812 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 813 if (varargElemType != null) {
mcimadamore@795 814 log.error(tree,
mcimadamore@795 815 "varargs.invalid.trustme.anno",
mcimadamore@795 816 syms.trustMeType.tsym,
mcimadamore@795 817 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 818 } else {
mcimadamore@795 819 log.error(tree,
mcimadamore@795 820 "varargs.invalid.trustme.anno",
mcimadamore@795 821 syms.trustMeType.tsym,
mcimadamore@795 822 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 823 }
mcimadamore@795 824 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 825 types.isReifiable(varargElemType)) {
mcimadamore@795 826 warnUnsafeVararg(tree,
mcimadamore@795 827 "varargs.redundant.trustme.anno",
mcimadamore@795 828 syms.trustMeType.tsym,
mcimadamore@795 829 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 830 }
mcimadamore@795 831 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 832 !types.isReifiable(varargElemType)) {
mcimadamore@795 833 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 834 }
mcimadamore@580 835 }
mcimadamore@795 836 //where
mcimadamore@795 837 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 838 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 839 (s.isConstructor() ||
mcimadamore@795 840 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 841 }
mcimadamore@580 842
mcimadamore@1219 843 Type checkMethod(Type owntype,
mcimadamore@1219 844 Symbol sym,
mcimadamore@1219 845 Env<AttrContext> env,
mcimadamore@1219 846 final List<JCExpression> argtrees,
mcimadamore@1219 847 List<Type> argtypes,
mcimadamore@1226 848 boolean useVarargs,
mcimadamore@1226 849 boolean unchecked) {
mcimadamore@1219 850 // System.out.println("call : " + env.tree);
mcimadamore@1219 851 // System.out.println("method : " + owntype);
mcimadamore@1219 852 // System.out.println("actuals: " + argtypes);
mcimadamore@1219 853 List<Type> formals = owntype.getParameterTypes();
mcimadamore@1219 854 Type last = useVarargs ? formals.last() : null;
mcimadamore@1219 855 if (sym.name==names.init &&
mcimadamore@1219 856 sym.owner == syms.enumSym)
mcimadamore@1219 857 formals = formals.tail.tail;
mcimadamore@1219 858 List<JCExpression> args = argtrees;
mcimadamore@1347 859 DeferredAttr.DeferredTypeMap checkDeferredMap =
mcimadamore@1347 860 deferredAttr.new DeferredTypeMap(DeferredAttr.AttrMode.CHECK, sym, env.info.pendingResolutionPhase);
mcimadamore@1352 861 if (args != null) {
mcimadamore@1352 862 //this is null when type-checking a method reference
mcimadamore@1352 863 while (formals.head != last) {
mcimadamore@1219 864 JCTree arg = args.head;
mcimadamore@1352 865 Warner warn = convertWarner(arg.pos(), arg.type, formals.head);
mcimadamore@1352 866 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 867 args = args.tail;
mcimadamore@1352 868 formals = formals.tail;
mcimadamore@1219 869 }
mcimadamore@1352 870 if (useVarargs) {
mcimadamore@1352 871 Type varArg = types.elemtype(last);
mcimadamore@1352 872 while (args.tail != null) {
mcimadamore@1352 873 JCTree arg = args.head;
mcimadamore@1352 874 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1352 875 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1352 876 args = args.tail;
mcimadamore@1352 877 }
mcimadamore@1352 878 } else if ((sym.flags() & VARARGS) != 0 && allowVarargs) {
mcimadamore@1352 879 // non-varargs call to varargs method
mcimadamore@1352 880 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1352 881 Type lastArg = checkDeferredMap.apply(argtypes.last());
mcimadamore@1352 882 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
mcimadamore@1352 883 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1352 884 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
mcimadamore@1352 885 types.elemtype(varParam), varParam);
mcimadamore@1352 886 }
mcimadamore@1219 887 }
mcimadamore@1226 888 if (unchecked) {
mcimadamore@1219 889 warnUnchecked(env.tree.pos(),
mcimadamore@1219 890 "unchecked.meth.invocation.applied",
mcimadamore@1219 891 kindName(sym),
mcimadamore@1219 892 sym.name,
mcimadamore@1219 893 rs.methodArguments(sym.type.getParameterTypes()),
mcimadamore@1347 894 rs.methodArguments(Type.map(argtypes, checkDeferredMap)),
mcimadamore@1219 895 kindName(sym.location()),
mcimadamore@1219 896 sym.location());
mcimadamore@1219 897 owntype = new MethodType(owntype.getParameterTypes(),
mcimadamore@1219 898 types.erasure(owntype.getReturnType()),
mcimadamore@1219 899 types.erasure(owntype.getThrownTypes()),
mcimadamore@1219 900 syms.methodClass);
mcimadamore@1219 901 }
mcimadamore@1219 902 if (useVarargs) {
mcimadamore@1219 903 JCTree tree = env.tree;
mcimadamore@1219 904 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 905 if (!types.isReifiable(argtype) &&
mcimadamore@1219 906 (!allowSimplifiedVarargs ||
mcimadamore@1219 907 sym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@1219 908 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 909 warnUnchecked(env.tree.pos(),
mcimadamore@1219 910 "unchecked.generic.array.creation",
mcimadamore@1219 911 argtype);
mcimadamore@1219 912 }
mcimadamore@1415 913 if (!((MethodSymbol)sym.baseSymbol()).isSignaturePolymorphic(types)) {
mcimadamore@1415 914 Type elemtype = types.elemtype(argtype);
mcimadamore@1415 915 switch (tree.getTag()) {
mcimadamore@1415 916 case APPLY:
mcimadamore@1415 917 ((JCMethodInvocation) tree).varargsElement = elemtype;
mcimadamore@1415 918 break;
mcimadamore@1415 919 case NEWCLASS:
mcimadamore@1415 920 ((JCNewClass) tree).varargsElement = elemtype;
mcimadamore@1415 921 break;
mcimadamore@1415 922 case REFERENCE:
mcimadamore@1415 923 ((JCMemberReference) tree).varargsElement = elemtype;
mcimadamore@1415 924 break;
mcimadamore@1415 925 default:
mcimadamore@1415 926 throw new AssertionError(""+tree);
mcimadamore@1415 927 }
mcimadamore@1219 928 }
mcimadamore@1219 929 }
mcimadamore@1219 930 return owntype;
mcimadamore@547 931 }
mcimadamore@1219 932 //where
mcimadamore@1219 933 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
mcimadamore@1219 934 if (types.isConvertible(actual, formal, warn))
mcimadamore@1219 935 return;
mcimadamore@1219 936
mcimadamore@1219 937 if (formal.isCompound()
mcimadamore@1219 938 && types.isSubtype(actual, types.supertype(formal))
mcimadamore@1219 939 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
mcimadamore@1219 940 return;
mcimadamore@1219 941 }
mcimadamore@547 942
mcimadamore@821 943 /**
mcimadamore@821 944 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 945 * (see JLS 4.5)
mcimadamore@821 946 *
mcimadamore@821 947 * @param t class type to be checked
mcimadamore@821 948 * @return true if 't' is well-formed
mcimadamore@821 949 */
mcimadamore@821 950 public boolean checkValidGenericType(Type t) {
mcimadamore@821 951 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 952 }
mcimadamore@821 953 //WHERE
mcimadamore@821 954 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 955 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 956 List<Type> actuals = type.allparams();
mcimadamore@821 957 List<Type> args = type.getTypeArguments();
mcimadamore@821 958 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 959 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 960
mcimadamore@821 961 // For matching pairs of actual argument types `a' and
mcimadamore@821 962 // formal type parameters with declared bound `b' ...
mcimadamore@821 963 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 964 // exact type arguments needs to know their
mcimadamore@821 965 // bounds (for upper and lower bound
mcimadamore@1216 966 // calculations). So we create new bounds where
mcimadamore@1216 967 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 968 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 969 args = args.tail;
mcimadamore@821 970 forms = forms.tail;
mcimadamore@821 971 }
mcimadamore@821 972
mcimadamore@821 973 args = type.getTypeArguments();
mcimadamore@821 974 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 975 formals,
mcimadamore@821 976 types.capture(type).allparams());
mcimadamore@821 977 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 978 // Let the actual arguments know their bound
mcimadamore@821 979 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 980 args = args.tail;
mcimadamore@821 981 tvars_cap = tvars_cap.tail;
mcimadamore@821 982 }
mcimadamore@821 983
mcimadamore@821 984 args = type.getTypeArguments();
mcimadamore@1216 985 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 986
mcimadamore@1216 987 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 988 Type actual = args.head;
mcimadamore@854 989 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 990 !bounds.head.isErroneous() &&
mcimadamore@1216 991 !checkExtends(actual, bounds.head)) {
mcimadamore@821 992 return args.head;
mcimadamore@821 993 }
mcimadamore@821 994 args = args.tail;
mcimadamore@1216 995 bounds = bounds.tail;
mcimadamore@821 996 }
mcimadamore@821 997
mcimadamore@821 998 args = type.getTypeArguments();
mcimadamore@1216 999 bounds = bounds_buf.toList();
mcimadamore@821 1000
mcimadamore@821 1001 for (Type arg : types.capture(type).getTypeArguments()) {
jjg@1374 1002 if (arg.hasTag(TYPEVAR) &&
mcimadamore@828 1003 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 1004 !bounds.head.isErroneous() &&
mcimadamore@854 1005 !isTypeArgErroneous(args.head)) {
mcimadamore@821 1006 return args.head;
mcimadamore@821 1007 }
mcimadamore@1216 1008 bounds = bounds.tail;
mcimadamore@854 1009 args = args.tail;
mcimadamore@821 1010 }
mcimadamore@821 1011
mcimadamore@821 1012 return null;
mcimadamore@821 1013 }
mcimadamore@854 1014 //where
mcimadamore@854 1015 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 1016 return isTypeArgErroneous.visit(t);
mcimadamore@854 1017 }
mcimadamore@854 1018
mcimadamore@854 1019 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 1020 public Boolean visitType(Type t, Void s) {
mcimadamore@854 1021 return t.isErroneous();
mcimadamore@854 1022 }
mcimadamore@854 1023 @Override
mcimadamore@854 1024 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 1025 return visit(t.getUpperBound());
mcimadamore@854 1026 }
mcimadamore@854 1027 @Override
mcimadamore@854 1028 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 1029 return visit(t.getUpperBound()) ||
mcimadamore@854 1030 visit(t.getLowerBound());
mcimadamore@854 1031 }
mcimadamore@854 1032 @Override
mcimadamore@854 1033 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1034 return visit(t.type);
mcimadamore@854 1035 }
mcimadamore@854 1036 };
mcimadamore@821 1037
duke@1 1038 /** Check that given modifiers are legal for given symbol and
duke@1 1039 * return modifiers together with any implicit modififiers for that symbol.
duke@1 1040 * Warning: we can't use flags() here since this method
duke@1 1041 * is called during class enter, when flags() would cause a premature
duke@1 1042 * completion.
duke@1 1043 * @param pos Position to be used for error reporting.
duke@1 1044 * @param flags The set of modifiers given in a definition.
duke@1 1045 * @param sym The defined symbol.
duke@1 1046 */
duke@1 1047 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1048 long mask;
duke@1 1049 long implicit = 0;
duke@1 1050 switch (sym.kind) {
duke@1 1051 case VAR:
duke@1 1052 if (sym.owner.kind != TYP)
duke@1 1053 mask = LocalVarFlags;
duke@1 1054 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1055 mask = implicit = InterfaceVarFlags;
duke@1 1056 else
duke@1 1057 mask = VarFlags;
duke@1 1058 break;
duke@1 1059 case MTH:
duke@1 1060 if (sym.name == names.init) {
duke@1 1061 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1062 // enum constructors cannot be declared public or
duke@1 1063 // protected and must be implicitly or explicitly
duke@1 1064 // private
duke@1 1065 implicit = PRIVATE;
duke@1 1066 mask = PRIVATE;
duke@1 1067 } else
duke@1 1068 mask = ConstructorFlags;
mcimadamore@1366 1069 } else if ((sym.owner.flags_field & INTERFACE) != 0) {
mcimadamore@1366 1070 if ((flags & DEFAULT) != 0) {
mcimadamore@1366 1071 mask = InterfaceDefaultMethodMask;
mcimadamore@1393 1072 implicit = PUBLIC | ABSTRACT;
mcimadamore@1366 1073 } else {
mcimadamore@1366 1074 mask = implicit = InterfaceMethodFlags;
mcimadamore@1366 1075 }
mcimadamore@1366 1076 }
duke@1 1077 else {
duke@1 1078 mask = MethodFlags;
duke@1 1079 }
duke@1 1080 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1081 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 1082 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1083 break;
duke@1 1084 case TYP:
duke@1 1085 if (sym.isLocal()) {
duke@1 1086 mask = LocalClassFlags;
jjg@113 1087 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1088 // Anonymous classes in static methods are themselves static;
duke@1 1089 // that's why we admit STATIC here.
duke@1 1090 mask |= STATIC;
duke@1 1091 // JLS: Anonymous classes are final.
duke@1 1092 implicit |= FINAL;
duke@1 1093 }
duke@1 1094 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1095 (flags & ENUM) != 0)
duke@1 1096 log.error(pos, "enums.must.be.static");
duke@1 1097 } else if (sym.owner.kind == TYP) {
duke@1 1098 mask = MemberClassFlags;
duke@1 1099 if (sym.owner.owner.kind == PCK ||
duke@1 1100 (sym.owner.flags_field & STATIC) != 0)
duke@1 1101 mask |= STATIC;
duke@1 1102 else if ((flags & ENUM) != 0)
duke@1 1103 log.error(pos, "enums.must.be.static");
duke@1 1104 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1105 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1106 } else {
duke@1 1107 mask = ClassFlags;
duke@1 1108 }
duke@1 1109 // Interfaces are always ABSTRACT
duke@1 1110 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1111
duke@1 1112 if ((flags & ENUM) != 0) {
duke@1 1113 // enums can't be declared abstract or final
duke@1 1114 mask &= ~(ABSTRACT | FINAL);
duke@1 1115 implicit |= implicitEnumFinalFlag(tree);
duke@1 1116 }
duke@1 1117 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1118 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1119 break;
duke@1 1120 default:
duke@1 1121 throw new AssertionError();
duke@1 1122 }
mcimadamore@1366 1123 long illegal = flags & ExtendedStandardFlags & ~mask;
duke@1 1124 if (illegal != 0) {
duke@1 1125 if ((illegal & INTERFACE) != 0) {
duke@1 1126 log.error(pos, "intf.not.allowed.here");
duke@1 1127 mask |= INTERFACE;
duke@1 1128 }
duke@1 1129 else {
duke@1 1130 log.error(pos,
mcimadamore@80 1131 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1132 }
duke@1 1133 }
duke@1 1134 else if ((sym.kind == TYP ||
duke@1 1135 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1136 // in the presence of inner classes. Should it be deleted here?
duke@1 1137 checkDisjoint(pos, flags,
duke@1 1138 ABSTRACT,
mcimadamore@1366 1139 PRIVATE | STATIC | DEFAULT))
duke@1 1140 &&
duke@1 1141 checkDisjoint(pos, flags,
duke@1 1142 ABSTRACT | INTERFACE,
duke@1 1143 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1144 &&
duke@1 1145 checkDisjoint(pos, flags,
duke@1 1146 PUBLIC,
duke@1 1147 PRIVATE | PROTECTED)
duke@1 1148 &&
duke@1 1149 checkDisjoint(pos, flags,
duke@1 1150 PRIVATE,
duke@1 1151 PUBLIC | PROTECTED)
duke@1 1152 &&
duke@1 1153 checkDisjoint(pos, flags,
duke@1 1154 FINAL,
duke@1 1155 VOLATILE)
duke@1 1156 &&
duke@1 1157 (sym.kind == TYP ||
duke@1 1158 checkDisjoint(pos, flags,
duke@1 1159 ABSTRACT | NATIVE,
duke@1 1160 STRICTFP))) {
duke@1 1161 // skip
duke@1 1162 }
mcimadamore@1366 1163 return flags & (mask | ~ExtendedStandardFlags) | implicit;
duke@1 1164 }
duke@1 1165
duke@1 1166
duke@1 1167 /** Determine if this enum should be implicitly final.
duke@1 1168 *
duke@1 1169 * If the enum has no specialized enum contants, it is final.
duke@1 1170 *
duke@1 1171 * If the enum does have specialized enum contants, it is
duke@1 1172 * <i>not</i> final.
duke@1 1173 */
duke@1 1174 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1175 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1176 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1177 boolean specialized;
duke@1 1178 SpecialTreeVisitor() {
duke@1 1179 this.specialized = false;
duke@1 1180 };
duke@1 1181
jjg@398 1182 @Override
duke@1 1183 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1184
jjg@398 1185 @Override
duke@1 1186 public void visitVarDef(JCVariableDecl tree) {
duke@1 1187 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1188 if (tree.init instanceof JCNewClass &&
duke@1 1189 ((JCNewClass) tree.init).def != null) {
duke@1 1190 specialized = true;
duke@1 1191 }
duke@1 1192 }
duke@1 1193 }
duke@1 1194 }
duke@1 1195
duke@1 1196 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1197 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1198 for (JCTree defs: cdef.defs) {
duke@1 1199 defs.accept(sts);
duke@1 1200 if (sts.specialized) return 0;
duke@1 1201 }
duke@1 1202 return FINAL;
duke@1 1203 }
duke@1 1204
duke@1 1205 /* *************************************************************************
duke@1 1206 * Type Validation
duke@1 1207 **************************************************************************/
duke@1 1208
duke@1 1209 /** Validate a type expression. That is,
duke@1 1210 * check that all type arguments of a parametric type are within
duke@1 1211 * their bounds. This must be done in a second phase after type attributon
duke@1 1212 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1213 *
jjg@1358 1214 * <pre>{@code
duke@1 1215 * class B<A extends C> { ... }
duke@1 1216 * class C extends B<C> { ... }
jjg@1358 1217 * }</pre>
duke@1 1218 *
duke@1 1219 * and we can't make sure that the bound is already attributed because
duke@1 1220 * of possible cycles.
mcimadamore@638 1221 *
mcimadamore@638 1222 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1223 * and reporting any completion failures.
duke@1 1224 */
mcimadamore@122 1225 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1226 validate(tree, env, true);
duke@1 1227 }
mcimadamore@638 1228 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1229 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1230 }
duke@1 1231
duke@1 1232 /** Visitor method: Validate a list of type expressions.
duke@1 1233 */
mcimadamore@122 1234 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1235 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1236 validate(l.head, env);
duke@1 1237 }
duke@1 1238
duke@1 1239 /** A visitor class for type validation.
duke@1 1240 */
duke@1 1241 class Validator extends JCTree.Visitor {
duke@1 1242
mcimadamore@638 1243 boolean isOuter;
mcimadamore@638 1244 Env<AttrContext> env;
mcimadamore@638 1245
mcimadamore@638 1246 Validator(Env<AttrContext> env) {
mcimadamore@638 1247 this.env = env;
mcimadamore@638 1248 }
mcimadamore@638 1249
jjg@398 1250 @Override
duke@1 1251 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1252 tree.elemtype.accept(this);
duke@1 1253 }
duke@1 1254
jjg@398 1255 @Override
duke@1 1256 public void visitTypeApply(JCTypeApply tree) {
jjg@1374 1257 if (tree.type.hasTag(CLASS)) {
duke@1 1258 List<JCExpression> args = tree.arguments;
mcimadamore@158 1259 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1260
mcimadamore@821 1261 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1262 if (incompatibleArg != null) {
mcimadamore@821 1263 for (JCTree arg : tree.arguments) {
mcimadamore@821 1264 if (arg.type == incompatibleArg) {
mcimadamore@829 1265 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1266 }
mcimadamore@829 1267 forms = forms.tail;
mcimadamore@829 1268 }
mcimadamore@829 1269 }
mcimadamore@829 1270
mcimadamore@829 1271 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1272
mcimadamore@638 1273 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1274
duke@1 1275 // For matching pairs of actual argument types `a' and
duke@1 1276 // formal type parameters with declared bound `b' ...
duke@1 1277 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1278 validateTree(args.head,
mcimadamore@638 1279 !(isOuter && is_java_lang_Class),
mcimadamore@638 1280 false);
duke@1 1281 args = args.tail;
duke@1 1282 forms = forms.tail;
duke@1 1283 }
duke@1 1284
duke@1 1285 // Check that this type is either fully parameterized, or
duke@1 1286 // not parameterized at all.
duke@1 1287 if (tree.type.getEnclosingType().isRaw())
duke@1 1288 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1289 if (tree.clazz.hasTag(SELECT))
duke@1 1290 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1291 }
duke@1 1292 }
duke@1 1293
jjg@398 1294 @Override
duke@1 1295 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1296 validateTrees(tree.bounds, true, isOuter);
duke@1 1297 checkClassBounds(tree.pos(), tree.type);
duke@1 1298 }
duke@1 1299
duke@1 1300 @Override
duke@1 1301 public void visitWildcard(JCWildcard tree) {
duke@1 1302 if (tree.inner != null)
mcimadamore@638 1303 validateTree(tree.inner, true, isOuter);
duke@1 1304 }
duke@1 1305
jjg@398 1306 @Override
duke@1 1307 public void visitSelect(JCFieldAccess tree) {
jjg@1374 1308 if (tree.type.hasTag(CLASS)) {
duke@1 1309 visitSelectInternal(tree);
duke@1 1310
duke@1 1311 // Check that this type is either fully parameterized, or
duke@1 1312 // not parameterized at all.
duke@1 1313 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1314 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1315 }
duke@1 1316 }
mcimadamore@852 1317
duke@1 1318 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1319 if (tree.type.tsym.isStatic() &&
duke@1 1320 tree.selected.type.isParameterized()) {
duke@1 1321 // The enclosing type is not a class, so we are
duke@1 1322 // looking at a static member type. However, the
duke@1 1323 // qualifying expression is parameterized.
duke@1 1324 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1325 } else {
duke@1 1326 // otherwise validate the rest of the expression
mcimadamore@122 1327 tree.selected.accept(this);
duke@1 1328 }
duke@1 1329 }
duke@1 1330
duke@1 1331 /** Default visitor method: do nothing.
duke@1 1332 */
jjg@398 1333 @Override
duke@1 1334 public void visitTree(JCTree tree) {
duke@1 1335 }
mcimadamore@122 1336
mcimadamore@638 1337 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1338 try {
mcimadamore@638 1339 if (tree != null) {
mcimadamore@638 1340 this.isOuter = isOuter;
mcimadamore@638 1341 tree.accept(this);
mcimadamore@638 1342 if (checkRaw)
mcimadamore@638 1343 checkRaw(tree, env);
mcimadamore@638 1344 }
mcimadamore@638 1345 } catch (CompletionFailure ex) {
mcimadamore@638 1346 completionError(tree.pos(), ex);
mcimadamore@638 1347 }
mcimadamore@638 1348 }
mcimadamore@638 1349
mcimadamore@638 1350 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1351 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1352 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1353 }
mcimadamore@638 1354
mcimadamore@638 1355 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1356 if (lint.isEnabled(LintCategory.RAW) &&
jjg@1374 1357 tree.type.hasTag(CLASS) &&
mcimadamore@638 1358 !TreeInfo.isDiamond(tree) &&
mcimadamore@1103 1359 !withinAnonConstr(env) &&
mcimadamore@638 1360 tree.type.isRaw()) {
mcimadamore@795 1361 log.warning(LintCategory.RAW,
mcimadamore@638 1362 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1363 }
mcimadamore@638 1364 }
mcimadamore@1103 1365
mcimadamore@1103 1366 boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1367 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1368 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1369 }
duke@1 1370 }
duke@1 1371
duke@1 1372 /* *************************************************************************
duke@1 1373 * Exception checking
duke@1 1374 **************************************************************************/
duke@1 1375
duke@1 1376 /* The following methods treat classes as sets that contain
duke@1 1377 * the class itself and all their subclasses
duke@1 1378 */
duke@1 1379
duke@1 1380 /** Is given type a subtype of some of the types in given list?
duke@1 1381 */
duke@1 1382 boolean subset(Type t, List<Type> ts) {
duke@1 1383 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1384 if (types.isSubtype(t, l.head)) return true;
duke@1 1385 return false;
duke@1 1386 }
duke@1 1387
duke@1 1388 /** Is given type a subtype or supertype of
duke@1 1389 * some of the types in given list?
duke@1 1390 */
duke@1 1391 boolean intersects(Type t, List<Type> ts) {
duke@1 1392 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1393 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1394 return false;
duke@1 1395 }
duke@1 1396
duke@1 1397 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1398 * in the list.
duke@1 1399 */
duke@1 1400 List<Type> incl(Type t, List<Type> ts) {
duke@1 1401 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1402 }
duke@1 1403
duke@1 1404 /** Remove type set from type set list.
duke@1 1405 */
duke@1 1406 List<Type> excl(Type t, List<Type> ts) {
duke@1 1407 if (ts.isEmpty()) {
duke@1 1408 return ts;
duke@1 1409 } else {
duke@1 1410 List<Type> ts1 = excl(t, ts.tail);
duke@1 1411 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1412 else if (ts1 == ts.tail) return ts;
duke@1 1413 else return ts1.prepend(ts.head);
duke@1 1414 }
duke@1 1415 }
duke@1 1416
duke@1 1417 /** Form the union of two type set lists.
duke@1 1418 */
duke@1 1419 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1420 List<Type> ts = ts1;
duke@1 1421 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1422 ts = incl(l.head, ts);
duke@1 1423 return ts;
duke@1 1424 }
duke@1 1425
duke@1 1426 /** Form the difference of two type lists.
duke@1 1427 */
duke@1 1428 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1429 List<Type> ts = ts1;
duke@1 1430 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1431 ts = excl(l.head, ts);
duke@1 1432 return ts;
duke@1 1433 }
duke@1 1434
duke@1 1435 /** Form the intersection of two type lists.
duke@1 1436 */
duke@1 1437 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1438 List<Type> ts = List.nil();
duke@1 1439 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1440 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1441 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1442 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1443 return ts;
duke@1 1444 }
duke@1 1445
duke@1 1446 /** Is exc an exception symbol that need not be declared?
duke@1 1447 */
duke@1 1448 boolean isUnchecked(ClassSymbol exc) {
duke@1 1449 return
duke@1 1450 exc.kind == ERR ||
duke@1 1451 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1452 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1453 }
duke@1 1454
duke@1 1455 /** Is exc an exception type that need not be declared?
duke@1 1456 */
duke@1 1457 boolean isUnchecked(Type exc) {
duke@1 1458 return
jjg@1374 1459 (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
jjg@1374 1460 (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
jjg@1374 1461 exc.hasTag(BOT);
duke@1 1462 }
duke@1 1463
duke@1 1464 /** Same, but handling completion failures.
duke@1 1465 */
duke@1 1466 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1467 try {
duke@1 1468 return isUnchecked(exc);
duke@1 1469 } catch (CompletionFailure ex) {
duke@1 1470 completionError(pos, ex);
duke@1 1471 return true;
duke@1 1472 }
duke@1 1473 }
duke@1 1474
duke@1 1475 /** Is exc handled by given exception list?
duke@1 1476 */
duke@1 1477 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1478 return isUnchecked(exc) || subset(exc, handled);
duke@1 1479 }
duke@1 1480
duke@1 1481 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1482 * @param thrown The list of thrown exceptions.
duke@1 1483 * @param handled The list of handled exceptions.
duke@1 1484 */
mcimadamore@362 1485 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1486 List<Type> unhandled = List.nil();
duke@1 1487 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1488 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1489 return unhandled;
duke@1 1490 }
duke@1 1491
duke@1 1492 /* *************************************************************************
duke@1 1493 * Overriding/Implementation checking
duke@1 1494 **************************************************************************/
duke@1 1495
duke@1 1496 /** The level of access protection given by a flag set,
duke@1 1497 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1498 */
duke@1 1499 static int protection(long flags) {
duke@1 1500 switch ((short)(flags & AccessFlags)) {
duke@1 1501 case PRIVATE: return 3;
duke@1 1502 case PROTECTED: return 1;
duke@1 1503 default:
duke@1 1504 case PUBLIC: return 0;
duke@1 1505 case 0: return 2;
duke@1 1506 }
duke@1 1507 }
duke@1 1508
duke@1 1509 /** A customized "cannot override" error message.
duke@1 1510 * @param m The overriding method.
duke@1 1511 * @param other The overridden method.
duke@1 1512 * @return An internationalized string.
duke@1 1513 */
mcimadamore@89 1514 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1515 String key;
duke@1 1516 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1517 key = "cant.override";
duke@1 1518 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1519 key = "cant.implement";
duke@1 1520 else
duke@1 1521 key = "clashes.with";
mcimadamore@89 1522 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1523 }
duke@1 1524
duke@1 1525 /** A customized "override" warning message.
duke@1 1526 * @param m The overriding method.
duke@1 1527 * @param other The overridden method.
duke@1 1528 * @return An internationalized string.
duke@1 1529 */
mcimadamore@89 1530 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1531 String key;
duke@1 1532 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1533 key = "unchecked.override";
duke@1 1534 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1535 key = "unchecked.implement";
duke@1 1536 else
duke@1 1537 key = "unchecked.clash.with";
mcimadamore@89 1538 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1539 }
duke@1 1540
duke@1 1541 /** A customized "override" warning message.
duke@1 1542 * @param m The overriding method.
duke@1 1543 * @param other The overridden method.
duke@1 1544 * @return An internationalized string.
duke@1 1545 */
mcimadamore@89 1546 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1547 String key;
duke@1 1548 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1549 key = "varargs.override";
duke@1 1550 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1551 key = "varargs.implement";
duke@1 1552 else
duke@1 1553 key = "varargs.clash.with";
mcimadamore@89 1554 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1555 }
duke@1 1556
duke@1 1557 /** Check that this method conforms with overridden method 'other'.
duke@1 1558 * where `origin' is the class where checking started.
duke@1 1559 * Complications:
duke@1 1560 * (1) Do not check overriding of synthetic methods
duke@1 1561 * (reason: they might be final).
duke@1 1562 * todo: check whether this is still necessary.
duke@1 1563 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1564 * than the method it implements. Augment the proxy methods with the
duke@1 1565 * undeclared exceptions in this case.
duke@1 1566 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1567 * has a result type
duke@1 1568 * extended by the result type of the method it implements.
duke@1 1569 * Change the proxies result type to the smaller type in this case.
duke@1 1570 *
duke@1 1571 * @param tree The tree from which positions
duke@1 1572 * are extracted for errors.
duke@1 1573 * @param m The overriding method.
duke@1 1574 * @param other The overridden method.
duke@1 1575 * @param origin The class of which the overriding method
duke@1 1576 * is a member.
duke@1 1577 */
duke@1 1578 void checkOverride(JCTree tree,
duke@1 1579 MethodSymbol m,
duke@1 1580 MethodSymbol other,
duke@1 1581 ClassSymbol origin) {
duke@1 1582 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1583 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1584 return;
duke@1 1585 }
duke@1 1586
duke@1 1587 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1588 if ((m.flags() & STATIC) != 0 &&
duke@1 1589 (other.flags() & STATIC) == 0) {
duke@1 1590 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1591 cannotOverride(m, other));
duke@1 1592 return;
duke@1 1593 }
duke@1 1594
duke@1 1595 // Error if instance method overrides static or final
duke@1 1596 // method (JLS 8.4.6.1).
duke@1 1597 if ((other.flags() & FINAL) != 0 ||
duke@1 1598 (m.flags() & STATIC) == 0 &&
duke@1 1599 (other.flags() & STATIC) != 0) {
duke@1 1600 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1601 cannotOverride(m, other),
mcimadamore@80 1602 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1603 return;
duke@1 1604 }
duke@1 1605
duke@1 1606 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1607 // handled in validateAnnotationMethod
duke@1 1608 return;
duke@1 1609 }
duke@1 1610
duke@1 1611 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1612 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1613 protection(m.flags()) > protection(other.flags())) {
duke@1 1614 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1615 cannotOverride(m, other),
mcimadamore@80 1616 other.flags() == 0 ?
mcimadamore@80 1617 Flag.PACKAGE :
mcimadamore@80 1618 asFlagSet(other.flags() & AccessFlags));
duke@1 1619 return;
duke@1 1620 }
duke@1 1621
duke@1 1622 Type mt = types.memberType(origin.type, m);
duke@1 1623 Type ot = types.memberType(origin.type, other);
duke@1 1624 // Error if overriding result type is different
duke@1 1625 // (or, in the case of generics mode, not a subtype) of
duke@1 1626 // overridden result type. We have to rename any type parameters
duke@1 1627 // before comparing types.
duke@1 1628 List<Type> mtvars = mt.getTypeArguments();
duke@1 1629 List<Type> otvars = ot.getTypeArguments();
duke@1 1630 Type mtres = mt.getReturnType();
duke@1 1631 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1632
mcimadamore@795 1633 overrideWarner.clear();
duke@1 1634 boolean resultTypesOK =
tbell@202 1635 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1636 if (!resultTypesOK) {
jjg@398 1637 if (!allowCovariantReturns &&
duke@1 1638 m.owner != origin &&
duke@1 1639 m.owner.isSubClass(other.owner, types)) {
duke@1 1640 // allow limited interoperability with covariant returns
duke@1 1641 } else {
mcimadamore@362 1642 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1643 "override.incompatible.ret",
mcimadamore@362 1644 cannotOverride(m, other),
duke@1 1645 mtres, otres);
duke@1 1646 return;
duke@1 1647 }
mcimadamore@795 1648 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1649 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1650 "override.unchecked.ret",
mcimadamore@362 1651 uncheckedOverrides(m, other),
mcimadamore@362 1652 mtres, otres);
duke@1 1653 }
duke@1 1654
duke@1 1655 // Error if overriding method throws an exception not reported
duke@1 1656 // by overridden method.
duke@1 1657 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1658 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1659 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1660 if (unhandledErased.nonEmpty()) {
duke@1 1661 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1662 "override.meth.doesnt.throw",
duke@1 1663 cannotOverride(m, other),
mcimadamore@362 1664 unhandledUnerased.head);
mcimadamore@362 1665 return;
mcimadamore@362 1666 }
mcimadamore@362 1667 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1668 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1669 "override.unchecked.thrown",
mcimadamore@362 1670 cannotOverride(m, other),
mcimadamore@362 1671 unhandledUnerased.head);
duke@1 1672 return;
duke@1 1673 }
duke@1 1674
duke@1 1675 // Optional warning if varargs don't agree
duke@1 1676 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1677 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1678 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1679 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1680 ? "override.varargs.missing"
duke@1 1681 : "override.varargs.extra",
duke@1 1682 varargsOverrides(m, other));
duke@1 1683 }
duke@1 1684
duke@1 1685 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1686 if ((other.flags() & BRIDGE) != 0) {
duke@1 1687 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1688 uncheckedOverrides(m, other));
duke@1 1689 }
duke@1 1690
duke@1 1691 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1692 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1693 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1694 }
duke@1 1695 }
duke@1 1696 // where
duke@1 1697 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1698 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1699 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1700 // because in that case, we will rediscover the issue when examining the method
duke@1 1701 // in the supertype.
duke@1 1702 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1703 // address the issue is when the method is the supertype implemementation: any other
duke@1 1704 // case, we will have dealt with when examining the supertype classes
duke@1 1705 ClassSymbol mc = m.enclClass();
duke@1 1706 Type st = types.supertype(origin.type);
jjg@1374 1707 if (!st.hasTag(CLASS))
duke@1 1708 return true;
duke@1 1709 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1710
duke@1 1711 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1712 List<Type> intfs = types.interfaces(origin.type);
duke@1 1713 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1714 }
duke@1 1715 else
duke@1 1716 return (stimpl != m);
duke@1 1717 }
duke@1 1718
duke@1 1719
duke@1 1720 // used to check if there were any unchecked conversions
duke@1 1721 Warner overrideWarner = new Warner();
duke@1 1722
duke@1 1723 /** Check that a class does not inherit two concrete methods
duke@1 1724 * with the same signature.
duke@1 1725 * @param pos Position to be used for error reporting.
duke@1 1726 * @param site The class type to be checked.
duke@1 1727 */
duke@1 1728 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1729 Type sup = types.supertype(site);
jjg@1374 1730 if (!sup.hasTag(CLASS)) return;
duke@1 1731
duke@1 1732 for (Type t1 = sup;
duke@1 1733 t1.tsym.type.isParameterized();
duke@1 1734 t1 = types.supertype(t1)) {
duke@1 1735 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1736 e1 != null;
duke@1 1737 e1 = e1.sibling) {
duke@1 1738 Symbol s1 = e1.sym;
duke@1 1739 if (s1.kind != MTH ||
duke@1 1740 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1741 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1742 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1743 types,
duke@1 1744 true) != s1)
duke@1 1745 continue;
duke@1 1746 Type st1 = types.memberType(t1, s1);
duke@1 1747 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1748 if (st1 == s1.type) continue;
duke@1 1749
duke@1 1750 for (Type t2 = sup;
jjg@1374 1751 t2.hasTag(CLASS);
duke@1 1752 t2 = types.supertype(t2)) {
mcimadamore@24 1753 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1754 e2.scope != null;
duke@1 1755 e2 = e2.next()) {
duke@1 1756 Symbol s2 = e2.sym;
duke@1 1757 if (s2 == s1 ||
duke@1 1758 s2.kind != MTH ||
duke@1 1759 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1760 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1761 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1762 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1763 types,
duke@1 1764 true) != s2)
duke@1 1765 continue;
duke@1 1766 Type st2 = types.memberType(t2, s2);
duke@1 1767 if (types.overrideEquivalent(st1, st2))
duke@1 1768 log.error(pos, "concrete.inheritance.conflict",
duke@1 1769 s1, t1, s2, t2, sup);
duke@1 1770 }
duke@1 1771 }
duke@1 1772 }
duke@1 1773 }
duke@1 1774 }
duke@1 1775
duke@1 1776 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1777 * method with same name and arguments but incompatible return types.
duke@1 1778 * @param pos Position to be used for error reporting.
duke@1 1779 * @param t1 The first argument type.
duke@1 1780 * @param t2 The second argument type.
duke@1 1781 */
duke@1 1782 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1783 Type t1,
duke@1 1784 Type t2) {
duke@1 1785 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1786 types.makeCompoundType(t1, t2));
duke@1 1787 }
duke@1 1788
duke@1 1789 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1790 Type t1,
duke@1 1791 Type t2,
duke@1 1792 Type site) {
mcimadamore@746 1793 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1794 }
duke@1 1795
duke@1 1796 /** Return the first method which is defined with same args
duke@1 1797 * but different return types in two given interfaces, or null if none
duke@1 1798 * exists.
duke@1 1799 * @param t1 The first type.
duke@1 1800 * @param t2 The second type.
duke@1 1801 * @param site The most derived type.
duke@1 1802 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1803 */
mcimadamore@746 1804 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1805 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1806 closure(t1, interfaces1);
duke@1 1807 Map<TypeSymbol,Type> interfaces2;
duke@1 1808 if (t1 == t2)
duke@1 1809 interfaces2 = interfaces1;
duke@1 1810 else
duke@1 1811 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1812
duke@1 1813 for (Type t3 : interfaces1.values()) {
duke@1 1814 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1815 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1816 if (s != null) return s;
duke@1 1817 }
duke@1 1818 }
duke@1 1819 return null;
duke@1 1820 }
duke@1 1821
duke@1 1822 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1823 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1824 if (!t.hasTag(CLASS)) return;
duke@1 1825 if (typeMap.put(t.tsym, t) == null) {
duke@1 1826 closure(types.supertype(t), typeMap);
duke@1 1827 for (Type i : types.interfaces(t))
duke@1 1828 closure(i, typeMap);
duke@1 1829 }
duke@1 1830 }
duke@1 1831
duke@1 1832 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1833 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1834 if (!t.hasTag(CLASS)) return;
duke@1 1835 if (typesSkip.get(t.tsym) != null) return;
duke@1 1836 if (typeMap.put(t.tsym, t) == null) {
duke@1 1837 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1838 for (Type i : types.interfaces(t))
duke@1 1839 closure(i, typesSkip, typeMap);
duke@1 1840 }
duke@1 1841 }
duke@1 1842
duke@1 1843 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1844 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1845 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1846 Symbol s1 = e1.sym;
duke@1 1847 Type st1 = null;
mcimadamore@1441 1848 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1849 (s1.flags() & SYNTHETIC) != 0) continue;
duke@1 1850 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1851 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1852 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1853 Symbol s2 = e2.sym;
duke@1 1854 if (s1 == s2) continue;
mcimadamore@1441 1855 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1856 (s2.flags() & SYNTHETIC) != 0) continue;
duke@1 1857 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1858 Type st2 = types.memberType(t2, s2);
duke@1 1859 if (types.overrideEquivalent(st1, st2)) {
duke@1 1860 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1861 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1862 Type rt1 = st1.getReturnType();
duke@1 1863 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1864 boolean compat =
duke@1 1865 types.isSameType(rt1, rt2) ||
jjg@1374 1866 !rt1.isPrimitiveOrVoid() &&
jjg@1374 1867 !rt2.isPrimitiveOrVoid() &&
mcimadamore@1415 1868 (types.covariantReturnType(rt1, rt2, types.noWarnings) ||
mcimadamore@1415 1869 types.covariantReturnType(rt2, rt1, types.noWarnings)) ||
mcimadamore@59 1870 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1871 if (!compat) {
mcimadamore@746 1872 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1873 t1, t2, s2.name +
mcimadamore@746 1874 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1875 return s2;
mcimadamore@746 1876 }
mcimadamore@889 1877 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1878 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1879 log.error(pos,
mcimadamore@746 1880 "name.clash.same.erasure.no.override",
mcimadamore@746 1881 s1, s1.location(),
mcimadamore@746 1882 s2, s2.location());
mcimadamore@746 1883 return s2;
duke@1 1884 }
duke@1 1885 }
duke@1 1886 }
duke@1 1887 return null;
duke@1 1888 }
mcimadamore@59 1889 //WHERE
mcimadamore@59 1890 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1891 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1892 Type st1 = types.memberType(site, s1);
mcimadamore@59 1893 Type st2 = types.memberType(site, s2);
mcimadamore@59 1894 closure(site, supertypes);
mcimadamore@59 1895 for (Type t : supertypes.values()) {
mcimadamore@59 1896 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1897 Symbol s3 = e.sym;
mcimadamore@59 1898 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1899 Type st3 = types.memberType(site,s3);
mcimadamore@59 1900 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1901 if (s3.owner == site.tsym) {
mcimadamore@59 1902 return true;
mcimadamore@59 1903 }
mcimadamore@59 1904 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1905 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1906 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1907 Type rt1 = st1.getReturnType();
mcimadamore@59 1908 Type rt2 = st2.getReturnType();
mcimadamore@59 1909 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1910 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1911 boolean compat =
jjg@1374 1912 !rt13.isPrimitiveOrVoid() &&
jjg@1374 1913 !rt23.isPrimitiveOrVoid() &&
mcimadamore@1415 1914 (types.covariantReturnType(rt13, rt1, types.noWarnings) &&
mcimadamore@1415 1915 types.covariantReturnType(rt23, rt2, types.noWarnings));
mcimadamore@59 1916 if (compat)
mcimadamore@59 1917 return true;
mcimadamore@59 1918 }
mcimadamore@59 1919 }
mcimadamore@59 1920 }
mcimadamore@59 1921 return false;
mcimadamore@59 1922 }
duke@1 1923
duke@1 1924 /** Check that a given method conforms with any method it overrides.
duke@1 1925 * @param tree The tree from which positions are extracted
duke@1 1926 * for errors.
duke@1 1927 * @param m The overriding method.
duke@1 1928 */
duke@1 1929 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1930 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1931 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1932 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1933 log.error(tree.pos(), "enum.no.finalize");
duke@1 1934 return;
duke@1 1935 }
jjg@1374 1936 for (Type t = origin.type; t.hasTag(CLASS);
duke@1 1937 t = types.supertype(t)) {
mcimadamore@746 1938 if (t != origin.type) {
mcimadamore@746 1939 checkOverride(tree, t, origin, m);
mcimadamore@746 1940 }
mcimadamore@746 1941 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1942 checkOverride(tree, t2, origin, m);
duke@1 1943 }
duke@1 1944 }
duke@1 1945 }
duke@1 1946
mcimadamore@746 1947 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1948 TypeSymbol c = site.tsym;
mcimadamore@746 1949 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1950 while (e.scope != null) {
mcimadamore@746 1951 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1952 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1953 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1954 }
mcimadamore@746 1955 }
mcimadamore@746 1956 e = e.next();
mcimadamore@746 1957 }
mcimadamore@746 1958 }
mcimadamore@746 1959
mcimadamore@746 1960 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 1961 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 1962 return (cf.accepts(s1) &&
mcimadamore@858 1963 cf.accepts(s2) &&
mcimadamore@858 1964 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 1965 }
mcimadamore@746 1966
mcimadamore@746 1967
duke@1 1968 /** Check that all abstract members of given class have definitions.
duke@1 1969 * @param pos Position to be used for error reporting.
duke@1 1970 * @param c The class.
duke@1 1971 */
duke@1 1972 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1973 try {
duke@1 1974 MethodSymbol undef = firstUndef(c, c);
duke@1 1975 if (undef != null) {
duke@1 1976 if ((c.flags() & ENUM) != 0 &&
duke@1 1977 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 1978 (c.flags() & FINAL) == 0) {
duke@1 1979 // add the ABSTRACT flag to an enum
duke@1 1980 c.flags_field |= ABSTRACT;
duke@1 1981 } else {
duke@1 1982 MethodSymbol undef1 =
duke@1 1983 new MethodSymbol(undef.flags(), undef.name,
duke@1 1984 types.memberType(c.type, undef), undef.owner);
duke@1 1985 log.error(pos, "does.not.override.abstract",
duke@1 1986 c, undef1, undef1.location());
duke@1 1987 }
duke@1 1988 }
duke@1 1989 } catch (CompletionFailure ex) {
duke@1 1990 completionError(pos, ex);
duke@1 1991 }
duke@1 1992 }
duke@1 1993 //where
duke@1 1994 /** Return first abstract member of class `c' that is not defined
duke@1 1995 * in `impl', null if there is none.
duke@1 1996 */
duke@1 1997 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 1998 MethodSymbol undef = null;
duke@1 1999 // Do not bother to search in classes that are not abstract,
duke@1 2000 // since they cannot have abstract members.
duke@1 2001 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 2002 Scope s = c.members();
duke@1 2003 for (Scope.Entry e = s.elems;
duke@1 2004 undef == null && e != null;
duke@1 2005 e = e.sibling) {
duke@1 2006 if (e.sym.kind == MTH &&
mcimadamore@1393 2007 (e.sym.flags() & (ABSTRACT|IPROXY|DEFAULT)) == ABSTRACT) {
duke@1 2008 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2009 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
mcimadamore@1393 2010 if (implmeth == null || implmeth == absmeth) {
mcimadamore@1393 2011 //look for default implementations
mcimadamore@1393 2012 if (allowDefaultMethods) {
mcimadamore@1393 2013 MethodSymbol prov = types.interfaceCandidates(impl.type, absmeth).head;
mcimadamore@1393 2014 if (prov != null && prov.overrides(absmeth, impl, types, true)) {
mcimadamore@1393 2015 implmeth = prov;
mcimadamore@1393 2016 }
mcimadamore@1393 2017 }
mcimadamore@1393 2018 }
mcimadamore@1393 2019 if (implmeth == null || implmeth == absmeth) {
duke@1 2020 undef = absmeth;
mcimadamore@1393 2021 }
duke@1 2022 }
duke@1 2023 }
duke@1 2024 if (undef == null) {
duke@1 2025 Type st = types.supertype(c.type);
jjg@1374 2026 if (st.hasTag(CLASS))
duke@1 2027 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 2028 }
duke@1 2029 for (List<Type> l = types.interfaces(c.type);
duke@1 2030 undef == null && l.nonEmpty();
duke@1 2031 l = l.tail) {
duke@1 2032 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 2033 }
duke@1 2034 }
duke@1 2035 return undef;
duke@1 2036 }
duke@1 2037
mcimadamore@690 2038 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 2039 CycleChecker cc = new CycleChecker();
mcimadamore@690 2040 cc.scan(tree);
mcimadamore@690 2041 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 2042 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 2043 }
mcimadamore@690 2044 }
mcimadamore@690 2045
mcimadamore@690 2046 class CycleChecker extends TreeScanner {
mcimadamore@690 2047
mcimadamore@690 2048 List<Symbol> seenClasses = List.nil();
mcimadamore@690 2049 boolean errorFound = false;
mcimadamore@690 2050 boolean partialCheck = false;
mcimadamore@690 2051
mcimadamore@690 2052 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 2053 if (sym != null && sym.kind == TYP) {
mcimadamore@690 2054 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 2055 if (classEnv != null) {
mcimadamore@690 2056 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2057 try {
mcimadamore@690 2058 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2059 scan(classEnv.tree);
mcimadamore@690 2060 }
mcimadamore@690 2061 finally {
mcimadamore@690 2062 log.useSource(prevSource.getFile());
mcimadamore@690 2063 }
mcimadamore@690 2064 } else if (sym.kind == TYP) {
mcimadamore@690 2065 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2066 }
mcimadamore@690 2067 } else {
mcimadamore@690 2068 //not completed yet
mcimadamore@690 2069 partialCheck = true;
mcimadamore@690 2070 }
mcimadamore@690 2071 }
mcimadamore@690 2072
mcimadamore@690 2073 @Override
mcimadamore@690 2074 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2075 super.visitSelect(tree);
mcimadamore@690 2076 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2077 }
mcimadamore@690 2078
mcimadamore@690 2079 @Override
mcimadamore@690 2080 public void visitIdent(JCIdent tree) {
mcimadamore@690 2081 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2082 }
mcimadamore@690 2083
mcimadamore@690 2084 @Override
mcimadamore@690 2085 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2086 scan(tree.clazz);
mcimadamore@690 2087 }
mcimadamore@690 2088
mcimadamore@690 2089 @Override
mcimadamore@690 2090 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2091 scan(tree.elemtype);
mcimadamore@690 2092 }
mcimadamore@690 2093
mcimadamore@690 2094 @Override
mcimadamore@690 2095 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2096 List<JCTree> supertypes = List.nil();
mcimadamore@690 2097 if (tree.getExtendsClause() != null) {
mcimadamore@690 2098 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2099 }
mcimadamore@690 2100 if (tree.getImplementsClause() != null) {
mcimadamore@690 2101 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2102 supertypes = supertypes.prepend(intf);
mcimadamore@690 2103 }
mcimadamore@690 2104 }
mcimadamore@690 2105 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2106 }
mcimadamore@690 2107
mcimadamore@690 2108 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2109 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2110 return;
mcimadamore@690 2111 if (seenClasses.contains(c)) {
mcimadamore@690 2112 errorFound = true;
mcimadamore@690 2113 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2114 } else if (!c.type.isErroneous()) {
mcimadamore@690 2115 try {
mcimadamore@690 2116 seenClasses = seenClasses.prepend(c);
jjg@1374 2117 if (c.type.hasTag(CLASS)) {
mcimadamore@690 2118 if (supertypes.nonEmpty()) {
mcimadamore@690 2119 scan(supertypes);
mcimadamore@690 2120 }
mcimadamore@690 2121 else {
mcimadamore@690 2122 ClassType ct = (ClassType)c.type;
mcimadamore@690 2123 if (ct.supertype_field == null ||
mcimadamore@690 2124 ct.interfaces_field == null) {
mcimadamore@690 2125 //not completed yet
mcimadamore@690 2126 partialCheck = true;
mcimadamore@690 2127 return;
mcimadamore@690 2128 }
mcimadamore@690 2129 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2130 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2131 checkSymbol(pos, intf.tsym);
mcimadamore@690 2132 }
mcimadamore@690 2133 }
mcimadamore@690 2134 if (c.owner.kind == TYP) {
mcimadamore@690 2135 checkSymbol(pos, c.owner);
mcimadamore@690 2136 }
mcimadamore@690 2137 }
mcimadamore@690 2138 } finally {
mcimadamore@690 2139 seenClasses = seenClasses.tail;
mcimadamore@690 2140 }
mcimadamore@690 2141 }
mcimadamore@690 2142 }
mcimadamore@690 2143 }
mcimadamore@690 2144
duke@1 2145 /** Check for cyclic references. Issue an error if the
duke@1 2146 * symbol of the type referred to has a LOCKED flag set.
duke@1 2147 *
duke@1 2148 * @param pos Position to be used for error reporting.
duke@1 2149 * @param t The type referred to.
duke@1 2150 */
duke@1 2151 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2152 checkNonCyclicInternal(pos, t);
duke@1 2153 }
duke@1 2154
duke@1 2155
duke@1 2156 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2157 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2158 }
duke@1 2159
mcimadamore@236 2160 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2161 final TypeVar tv;
jjg@1374 2162 if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2163 return;
duke@1 2164 if (seen.contains(t)) {
duke@1 2165 tv = (TypeVar)t;
jjg@110 2166 tv.bound = types.createErrorType(t);
duke@1 2167 log.error(pos, "cyclic.inheritance", t);
jjg@1374 2168 } else if (t.hasTag(TYPEVAR)) {
duke@1 2169 tv = (TypeVar)t;
mcimadamore@236 2170 seen = seen.prepend(tv);
duke@1 2171 for (Type b : types.getBounds(tv))
duke@1 2172 checkNonCyclic1(pos, b, seen);
duke@1 2173 }
duke@1 2174 }
duke@1 2175
duke@1 2176 /** Check for cyclic references. Issue an error if the
duke@1 2177 * symbol of the type referred to has a LOCKED flag set.
duke@1 2178 *
duke@1 2179 * @param pos Position to be used for error reporting.
duke@1 2180 * @param t The type referred to.
duke@1 2181 * @returns True if the check completed on all attributed classes
duke@1 2182 */
duke@1 2183 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2184 boolean complete = true; // was the check complete?
duke@1 2185 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2186 Symbol c = t.tsym;
duke@1 2187 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2188
duke@1 2189 if ((c.flags_field & LOCKED) != 0) {
duke@1 2190 noteCyclic(pos, (ClassSymbol)c);
duke@1 2191 } else if (!c.type.isErroneous()) {
duke@1 2192 try {
duke@1 2193 c.flags_field |= LOCKED;
jjg@1374 2194 if (c.type.hasTag(CLASS)) {
duke@1 2195 ClassType clazz = (ClassType)c.type;
duke@1 2196 if (clazz.interfaces_field != null)
duke@1 2197 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2198 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2199 if (clazz.supertype_field != null) {
duke@1 2200 Type st = clazz.supertype_field;
jjg@1374 2201 if (st != null && st.hasTag(CLASS))
duke@1 2202 complete &= checkNonCyclicInternal(pos, st);
duke@1 2203 }
duke@1 2204 if (c.owner.kind == TYP)
duke@1 2205 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2206 }
duke@1 2207 } finally {
duke@1 2208 c.flags_field &= ~LOCKED;
duke@1 2209 }
duke@1 2210 }
duke@1 2211 if (complete)
duke@1 2212 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2213 if (complete) c.flags_field |= ACYCLIC;
duke@1 2214 return complete;
duke@1 2215 }
duke@1 2216
duke@1 2217 /** Note that we found an inheritance cycle. */
duke@1 2218 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2219 log.error(pos, "cyclic.inheritance", c);
duke@1 2220 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2221 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2222 Type st = types.supertype(c.type);
jjg@1374 2223 if (st.hasTag(CLASS))
jjg@110 2224 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2225 c.type = types.createErrorType(c, c.type);
duke@1 2226 c.flags_field |= ACYCLIC;
duke@1 2227 }
duke@1 2228
mcimadamore@1415 2229 /**
mcimadamore@1415 2230 * Check that functional interface methods would make sense when seen
mcimadamore@1415 2231 * from the perspective of the implementing class
mcimadamore@1415 2232 */
mcimadamore@1415 2233 void checkFunctionalInterface(JCTree tree, Type funcInterface) {
mcimadamore@1415 2234 ClassType c = new ClassType(Type.noType, List.<Type>nil(), null);
mcimadamore@1415 2235 ClassSymbol csym = new ClassSymbol(0, names.empty, c, syms.noSymbol);
mcimadamore@1415 2236 c.interfaces_field = List.of(funcInterface);
mcimadamore@1415 2237 c.supertype_field = syms.objectType;
mcimadamore@1415 2238 c.tsym = csym;
mcimadamore@1415 2239 csym.members_field = new Scope(csym);
mcimadamore@1415 2240 csym.completer = null;
mcimadamore@1415 2241 checkImplementations(tree, csym, csym);
mcimadamore@1415 2242 }
mcimadamore@1415 2243
duke@1 2244 /** Check that all methods which implement some
duke@1 2245 * method conform to the method they implement.
duke@1 2246 * @param tree The class definition whose members are checked.
duke@1 2247 */
duke@1 2248 void checkImplementations(JCClassDecl tree) {
mcimadamore@1415 2249 checkImplementations(tree, tree.sym, tree.sym);
duke@1 2250 }
duke@1 2251 //where
duke@1 2252 /** Check that all methods which implement some
duke@1 2253 * method in `ic' conform to the method they implement.
duke@1 2254 */
mcimadamore@1415 2255 void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) {
duke@1 2256 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2257 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2258 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2259 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2260 if (e.sym.kind == MTH &&
duke@1 2261 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2262 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2263 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2264 if (implmeth != null && implmeth != absmeth &&
duke@1 2265 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2266 (origin.flags() & INTERFACE)) {
duke@1 2267 // don't check if implmeth is in a class, yet
duke@1 2268 // origin is an interface. This case arises only
duke@1 2269 // if implmeth is declared in Object. The reason is
duke@1 2270 // that interfaces really don't inherit from
duke@1 2271 // Object it's just that the compiler represents
duke@1 2272 // things that way.
duke@1 2273 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2274 }
duke@1 2275 }
duke@1 2276 }
duke@1 2277 }
duke@1 2278 }
duke@1 2279 }
duke@1 2280
duke@1 2281 /** Check that all abstract methods implemented by a class are
duke@1 2282 * mutually compatible.
duke@1 2283 * @param pos Position to be used for error reporting.
duke@1 2284 * @param c The class whose interfaces are checked.
duke@1 2285 */
duke@1 2286 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2287 List<Type> supertypes = types.interfaces(c);
duke@1 2288 Type supertype = types.supertype(c);
jjg@1374 2289 if (supertype.hasTag(CLASS) &&
duke@1 2290 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2291 supertypes = supertypes.prepend(supertype);
duke@1 2292 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2293 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2294 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2295 return;
duke@1 2296 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2297 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2298 return;
duke@1 2299 }
duke@1 2300 checkCompatibleConcretes(pos, c);
duke@1 2301 }
duke@1 2302
mcimadamore@359 2303 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2304 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2305 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2306 // VM allows methods and variables with differing types
mcimadamore@359 2307 if (sym.kind == e.sym.kind &&
mcimadamore@359 2308 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2309 sym != e.sym &&
mcimadamore@359 2310 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2311 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2312 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2313 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2314 return;
mcimadamore@359 2315 }
mcimadamore@359 2316 }
mcimadamore@359 2317 }
mcimadamore@359 2318 }
mcimadamore@359 2319
mcimadamore@780 2320 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2321 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2322 *
mcimadamore@780 2323 * @param pos Position to be used for error reporting.
mcimadamore@780 2324 * @param site The class whose methods are checked.
mcimadamore@780 2325 * @param sym The method symbol to be checked.
mcimadamore@780 2326 */
mcimadamore@858 2327 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2328 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2329 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2330 //by method 'sym' in 'site'...
mcimadamore@1198 2331 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2332 if (!sym.overrides(m1, site.tsym, types, false)) continue;
mcimadamore@1198 2333 //...check each method m2 that is a member of 'site'
mcimadamore@1198 2334 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2335 if (m2 == m1) continue;
mcimadamore@858 2336 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2337 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1393 2338 if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) &&
mcimadamore@1198 2339 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2340 sym.flags_field |= CLASH;
mcimadamore@1198 2341 String key = m1 == sym ?
mcimadamore@858 2342 "name.clash.same.erasure.no.override" :
mcimadamore@858 2343 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2344 log.error(pos,
mcimadamore@858 2345 key,
mcimadamore@858 2346 sym, sym.location(),
mcimadamore@1198 2347 m2, m2.location(),
mcimadamore@1198 2348 m1, m1.location());
mcimadamore@858 2349 return;
mcimadamore@858 2350 }
mcimadamore@780 2351 }
mcimadamore@780 2352 }
mcimadamore@780 2353 }
mcimadamore@780 2354
mcimadamore@877 2355
mcimadamore@877 2356
mcimadamore@858 2357 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2358 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2359 *
mcimadamore@858 2360 * @param pos Position to be used for error reporting.
mcimadamore@858 2361 * @param site The class whose methods are checked.
mcimadamore@858 2362 * @param sym The method symbol to be checked.
mcimadamore@780 2363 */
mcimadamore@858 2364 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2365 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2366 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2367 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2368 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2369 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@1393 2370 if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck) &&
mcimadamore@877 2371 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2372 log.error(pos,
mcimadamore@858 2373 "name.clash.same.erasure.no.hide",
mcimadamore@858 2374 sym, sym.location(),
mcimadamore@877 2375 s, s.location());
mcimadamore@858 2376 return;
mcimadamore@858 2377 }
mcimadamore@858 2378 }
mcimadamore@858 2379 }
mcimadamore@780 2380
mcimadamore@858 2381 //where
mcimadamore@858 2382 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2383
mcimadamore@858 2384 Type site;
mcimadamore@780 2385
mcimadamore@858 2386 ClashFilter(Type site) {
mcimadamore@858 2387 this.site = site;
mcimadamore@858 2388 }
mcimadamore@858 2389
mcimadamore@858 2390 boolean shouldSkip(Symbol s) {
mcimadamore@858 2391 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2392 s.owner == site.tsym;
mcimadamore@858 2393 }
mcimadamore@858 2394
mcimadamore@858 2395 public boolean accepts(Symbol s) {
mcimadamore@858 2396 return s.kind == MTH &&
mcimadamore@858 2397 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2398 !shouldSkip(s) &&
mcimadamore@858 2399 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2400 !s.isConstructor();
mcimadamore@858 2401 }
mcimadamore@858 2402 }
mcimadamore@780 2403
mcimadamore@1393 2404 void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) {
mcimadamore@1393 2405 DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site);
mcimadamore@1393 2406 for (Symbol m : types.membersClosure(site, false).getElements(dcf)) {
mcimadamore@1393 2407 Assert.check(m.kind == MTH);
mcimadamore@1393 2408 List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m);
mcimadamore@1393 2409 if (prov.size() > 1) {
mcimadamore@1393 2410 ListBuffer<Symbol> abstracts = ListBuffer.lb();
mcimadamore@1393 2411 ListBuffer<Symbol> defaults = ListBuffer.lb();
mcimadamore@1393 2412 for (MethodSymbol provSym : prov) {
mcimadamore@1393 2413 if ((provSym.flags() & DEFAULT) != 0) {
mcimadamore@1393 2414 defaults = defaults.append(provSym);
mcimadamore@1393 2415 } else if ((provSym.flags() & ABSTRACT) != 0) {
mcimadamore@1393 2416 abstracts = abstracts.append(provSym);
mcimadamore@1393 2417 }
mcimadamore@1393 2418 if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) {
mcimadamore@1393 2419 //strong semantics - issue an error if two sibling interfaces
mcimadamore@1393 2420 //have two override-equivalent defaults - or if one is abstract
mcimadamore@1393 2421 //and the other is default
mcimadamore@1393 2422 String errKey;
mcimadamore@1393 2423 Symbol s1 = defaults.first();
mcimadamore@1393 2424 Symbol s2;
mcimadamore@1393 2425 if (defaults.size() > 1) {
mcimadamore@1393 2426 errKey = "types.incompatible.unrelated.defaults";
mcimadamore@1393 2427 s2 = defaults.toList().tail.head;
mcimadamore@1393 2428 } else {
mcimadamore@1393 2429 errKey = "types.incompatible.abstract.default";
mcimadamore@1393 2430 s2 = abstracts.first();
mcimadamore@1393 2431 }
mcimadamore@1393 2432 log.error(pos, errKey,
mcimadamore@1393 2433 Kinds.kindName(site.tsym), site,
mcimadamore@1393 2434 m.name, types.memberType(site, m).getParameterTypes(),
mcimadamore@1393 2435 s1.location(), s2.location());
mcimadamore@1393 2436 break;
mcimadamore@1393 2437 }
mcimadamore@1393 2438 }
mcimadamore@1393 2439 }
mcimadamore@1393 2440 }
mcimadamore@1393 2441 }
mcimadamore@1393 2442
mcimadamore@1393 2443 //where
mcimadamore@1393 2444 private class DefaultMethodClashFilter implements Filter<Symbol> {
mcimadamore@1393 2445
mcimadamore@1393 2446 Type site;
mcimadamore@1393 2447
mcimadamore@1393 2448 DefaultMethodClashFilter(Type site) {
mcimadamore@1393 2449 this.site = site;
mcimadamore@1393 2450 }
mcimadamore@1393 2451
mcimadamore@1393 2452 public boolean accepts(Symbol s) {
mcimadamore@1393 2453 return s.kind == MTH &&
mcimadamore@1393 2454 (s.flags() & DEFAULT) != 0 &&
mcimadamore@1393 2455 s.isInheritedIn(site.tsym, types) &&
mcimadamore@1393 2456 !s.isConstructor();
mcimadamore@1393 2457 }
mcimadamore@1393 2458 }
mcimadamore@1393 2459
mcimadamore@359 2460 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2461 */
mcimadamore@359 2462 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2463 if (!sym.type.isErroneous()) {
mcimadamore@359 2464 if (warnOnSyntheticConflicts) {
mcimadamore@359 2465 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2466 }
mcimadamore@359 2467 else {
mcimadamore@359 2468 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2469 }
mcimadamore@359 2470 }
mcimadamore@359 2471 }
mcimadamore@359 2472
duke@1 2473 /** Check that class c does not implement directly or indirectly
duke@1 2474 * the same parameterized interface with two different argument lists.
duke@1 2475 * @param pos Position to be used for error reporting.
duke@1 2476 * @param type The type whose interfaces are checked.
duke@1 2477 */
duke@1 2478 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2479 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2480 }
duke@1 2481 //where
duke@1 2482 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2483 * with their class symbol as key and their type as value. Make
duke@1 2484 * sure no class is entered with two different types.
duke@1 2485 */
duke@1 2486 void checkClassBounds(DiagnosticPosition pos,
duke@1 2487 Map<TypeSymbol,Type> seensofar,
duke@1 2488 Type type) {
duke@1 2489 if (type.isErroneous()) return;
duke@1 2490 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2491 Type it = l.head;
duke@1 2492 Type oldit = seensofar.put(it.tsym, it);
duke@1 2493 if (oldit != null) {
duke@1 2494 List<Type> oldparams = oldit.allparams();
duke@1 2495 List<Type> newparams = it.allparams();
duke@1 2496 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2497 log.error(pos, "cant.inherit.diff.arg",
duke@1 2498 it.tsym, Type.toString(oldparams),
duke@1 2499 Type.toString(newparams));
duke@1 2500 }
duke@1 2501 checkClassBounds(pos, seensofar, it);
duke@1 2502 }
duke@1 2503 Type st = types.supertype(type);
duke@1 2504 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2505 }
duke@1 2506
duke@1 2507 /** Enter interface into into set.
duke@1 2508 * If it existed already, issue a "repeated interface" error.
duke@1 2509 */
duke@1 2510 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2511 if (its.contains(it))
duke@1 2512 log.error(pos, "repeated.interface");
duke@1 2513 else {
duke@1 2514 its.add(it);
duke@1 2515 }
duke@1 2516 }
duke@1 2517
duke@1 2518 /* *************************************************************************
duke@1 2519 * Check annotations
duke@1 2520 **************************************************************************/
duke@1 2521
mcimadamore@629 2522 /**
mcimadamore@634 2523 * Recursively validate annotations values
mcimadamore@629 2524 */
mcimadamore@634 2525 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2526 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2527 @Override
mcimadamore@629 2528 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2529 if (!tree.type.isErroneous()) {
jjg@1017 2530 super.visitAnnotation(tree);
jjg@1017 2531 validateAnnotation(tree);
jjg@1017 2532 }
mcimadamore@629 2533 }
mcimadamore@629 2534 }
mcimadamore@634 2535 tree.accept(new AnnotationValidator());
mcimadamore@629 2536 }
mcimadamore@629 2537
jjg@1326 2538 /**
jjg@1326 2539 * {@literal
jjg@1326 2540 * Annotation types are restricted to primitives, String, an
duke@1 2541 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2542 * Anything>, arrays of the preceding.
jjg@1326 2543 * }
duke@1 2544 */
duke@1 2545 void validateAnnotationType(JCTree restype) {
duke@1 2546 // restype may be null if an error occurred, so don't bother validating it
duke@1 2547 if (restype != null) {
duke@1 2548 validateAnnotationType(restype.pos(), restype.type);
duke@1 2549 }
duke@1 2550 }
duke@1 2551
duke@1 2552 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2553 if (type.isPrimitive()) return;
duke@1 2554 if (types.isSameType(type, syms.stringType)) return;
duke@1 2555 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2556 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2557 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2558 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2559 validateAnnotationType(pos, types.elemtype(type));
duke@1 2560 return;
duke@1 2561 }
duke@1 2562 log.error(pos, "invalid.annotation.member.type");
duke@1 2563 }
duke@1 2564
duke@1 2565 /**
duke@1 2566 * "It is also a compile-time error if any method declared in an
duke@1 2567 * annotation type has a signature that is override-equivalent to
duke@1 2568 * that of any public or protected method declared in class Object
duke@1 2569 * or in the interface annotation.Annotation."
duke@1 2570 *
jjh@972 2571 * @jls 9.6 Annotation Types
duke@1 2572 */
duke@1 2573 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
jjg@1374 2574 for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
duke@1 2575 Scope s = sup.tsym.members();
duke@1 2576 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2577 if (e.sym.kind == MTH &&
duke@1 2578 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2579 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2580 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2581 }
duke@1 2582 }
duke@1 2583 }
duke@1 2584
duke@1 2585 /** Check the annotations of a symbol.
duke@1 2586 */
duke@1 2587 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2588 for (JCAnnotation a : annotations)
duke@1 2589 validateAnnotation(a, s);
duke@1 2590 }
duke@1 2591
duke@1 2592 /** Check an annotation of a symbol.
duke@1 2593 */
jfranck@1313 2594 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2595 validateAnnotationTree(a);
duke@1 2596
duke@1 2597 if (!annotationApplicable(a, s))
duke@1 2598 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2599
duke@1 2600 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2601 if (!isOverrider(s))
duke@1 2602 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2603 }
mcimadamore@1497 2604
mcimadamore@1497 2605 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
mcimadamore@1497 2606 if (s.kind != TYP) {
mcimadamore@1497 2607 log.error(a.pos(), "bad.functional.intf.anno");
mcimadamore@1497 2608 } else {
mcimadamore@1497 2609 try {
mcimadamore@1497 2610 types.findDescriptorSymbol((TypeSymbol)s);
mcimadamore@1497 2611 } catch (Types.FunctionDescriptorLookupError ex) {
mcimadamore@1497 2612 log.error(a.pos(), "bad.functional.intf.anno.1", ex.getDiagnostic());
mcimadamore@1497 2613 }
mcimadamore@1497 2614 }
mcimadamore@1497 2615 }
duke@1 2616 }
duke@1 2617
jfranck@1313 2618 /**
jjg@1492 2619 * Validate the proposed container 'repeatable' on the
jfranck@1313 2620 * annotation type symbol 's'. Report errors at position
jfranck@1313 2621 * 'pos'.
jfranck@1313 2622 *
jjg@1492 2623 * @param s The (annotation)type declaration annotated with a @Repeatable
jjg@1492 2624 * @param repeatable the @Repeatable on 's'
jfranck@1313 2625 * @param pos where to report errors
jfranck@1313 2626 */
jjg@1492 2627 public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) {
jjg@1492 2628 Assert.check(types.isSameType(repeatable.type, syms.repeatableType));
jfranck@1313 2629
jfranck@1313 2630 Type t = null;
jjg@1492 2631 List<Pair<MethodSymbol,Attribute>> l = repeatable.values;
jfranck@1313 2632 if (!l.isEmpty()) {
jfranck@1313 2633 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2634 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2635 }
jfranck@1313 2636
jfranck@1313 2637 if (t == null) {
jjg@1492 2638 // errors should already have been reported during Annotate
jfranck@1313 2639 return;
jfranck@1313 2640 }
jfranck@1313 2641
jjg@1492 2642 validateValue(t.tsym, s, pos);
jfranck@1313 2643 validateRetention(t.tsym, s, pos);
jfranck@1313 2644 validateDocumented(t.tsym, s, pos);
jfranck@1313 2645 validateInherited(t.tsym, s, pos);
jfranck@1313 2646 validateTarget(t.tsym, s, pos);
jfranck@1344 2647 validateDefault(t.tsym, s, pos);
jfranck@1313 2648 }
jfranck@1313 2649
jjg@1492 2650 private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jjg@1492 2651 Scope.Entry e = container.members().lookup(names.value);
jjg@1492 2652 if (e.scope != null && e.sym.kind == MTH) {
jjg@1492 2653 MethodSymbol m = (MethodSymbol) e.sym;
jjg@1492 2654 Type ret = m.getReturnType();
jjg@1492 2655 if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) {
jjg@1492 2656 log.error(pos, "invalid.repeatable.annotation.value.return",
jjg@1492 2657 container, ret, types.makeArrayType(contained.type));
jjg@1492 2658 }
jjg@1492 2659 } else {
jjg@1492 2660 log.error(pos, "invalid.repeatable.annotation.no.value", container);
jfranck@1313 2661 }
jfranck@1313 2662 }
jfranck@1313 2663
jfranck@1313 2664 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2665 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2666 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2667
jfranck@1313 2668 boolean error = false;
jfranck@1313 2669 switch (containedRetention) {
jfranck@1313 2670 case RUNTIME:
jfranck@1313 2671 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2672 error = true;
jfranck@1313 2673 }
jfranck@1313 2674 break;
jfranck@1313 2675 case CLASS:
jfranck@1313 2676 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2677 error = true;
jfranck@1313 2678 }
jfranck@1313 2679 }
jfranck@1313 2680 if (error ) {
jjg@1492 2681 log.error(pos, "invalid.repeatable.annotation.retention",
jfranck@1313 2682 container, containerRetention,
jfranck@1313 2683 contained, containedRetention);
jfranck@1313 2684 }
jfranck@1313 2685 }
jfranck@1313 2686
jfranck@1313 2687 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2688 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2689 if (container.attribute(syms.documentedType.tsym) == null) {
jjg@1492 2690 log.error(pos, "invalid.repeatable.annotation.not.documented", container, contained);
jfranck@1313 2691 }
jfranck@1313 2692 }
jfranck@1313 2693 }
jfranck@1313 2694
jfranck@1313 2695 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2696 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2697 if (container.attribute(syms.inheritedType.tsym) == null) {
jjg@1492 2698 log.error(pos, "invalid.repeatable.annotation.not.inherited", container, contained);
jfranck@1313 2699 }
jfranck@1313 2700 }
jfranck@1313 2701 }
jfranck@1313 2702
jfranck@1313 2703 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2704 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1313 2705
jfranck@1313 2706 // If contained has no Target, we are done
jfranck@1313 2707 if (containedTarget == null) {
jfranck@1313 2708 return;
jfranck@1313 2709 }
jfranck@1313 2710
jfranck@1313 2711 // If contained has Target m1, container must have a Target
jfranck@1313 2712 // annotation, m2, and m2 must be a subset of m1. (This is
jfranck@1313 2713 // trivially true if contained has no target as per above).
jfranck@1313 2714
jfranck@1313 2715 // contained has target, but container has not, error
jfranck@1313 2716 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2717 if (containerTarget == null) {
jjg@1492 2718 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2719 return;
jfranck@1313 2720 }
jfranck@1313 2721
jfranck@1313 2722 Set<Name> containerTargets = new HashSet<Name>();
jfranck@1313 2723 for (Attribute app : containerTarget.values) {
jfranck@1313 2724 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2725 continue; // recovery
jfranck@1313 2726 }
jfranck@1313 2727 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2728 containerTargets.add(e.value.name);
jfranck@1313 2729 }
jfranck@1313 2730
jfranck@1313 2731 Set<Name> containedTargets = new HashSet<Name>();
jfranck@1313 2732 for (Attribute app : containedTarget.values) {
jfranck@1313 2733 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2734 continue; // recovery
jfranck@1313 2735 }
jfranck@1313 2736 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2737 containedTargets.add(e.value.name);
jfranck@1313 2738 }
jfranck@1313 2739
jfranck@1313 2740 if (!isTargetSubset(containedTargets, containerTargets)) {
jjg@1492 2741 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2742 }
jfranck@1313 2743 }
jfranck@1313 2744
jfranck@1313 2745 /** Checks that t is a subset of s, with respect to ElementType
jfranck@1313 2746 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE}
jfranck@1313 2747 */
jfranck@1313 2748 private boolean isTargetSubset(Set<Name> s, Set<Name> t) {
jfranck@1313 2749 // Check that all elements in t are present in s
jfranck@1313 2750 for (Name n2 : t) {
jfranck@1313 2751 boolean currentElementOk = false;
jfranck@1313 2752 for (Name n1 : s) {
jfranck@1313 2753 if (n1 == n2) {
jfranck@1313 2754 currentElementOk = true;
jfranck@1313 2755 break;
jfranck@1313 2756 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2757 currentElementOk = true;
jfranck@1313 2758 break;
jfranck@1313 2759 }
jfranck@1313 2760 }
jfranck@1313 2761 if (!currentElementOk)
jfranck@1313 2762 return false;
jfranck@1313 2763 }
jfranck@1313 2764 return true;
jfranck@1313 2765 }
jfranck@1313 2766
jfranck@1344 2767 private void validateDefault(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1344 2768 // validate that all other elements of containing type has defaults
jfranck@1344 2769 Scope scope = container.members();
jfranck@1344 2770 for(Symbol elm : scope.getElements()) {
jfranck@1344 2771 if (elm.name != names.value &&
jfranck@1344 2772 elm.kind == Kinds.MTH &&
jfranck@1344 2773 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2774 log.error(pos,
jjg@1492 2775 "invalid.repeatable.annotation.elem.nondefault",
jfranck@1344 2776 container,
jfranck@1344 2777 elm);
jfranck@1344 2778 }
jfranck@1344 2779 }
jfranck@1344 2780 }
jfranck@1344 2781
duke@1 2782 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2783 boolean isOverrider(Symbol s) {
duke@1 2784 if (s.kind != MTH || s.isStatic())
duke@1 2785 return false;
duke@1 2786 MethodSymbol m = (MethodSymbol)s;
duke@1 2787 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2788 for (Type sup : types.closure(owner.type)) {
duke@1 2789 if (sup == owner.type)
duke@1 2790 continue; // skip "this"
duke@1 2791 Scope scope = sup.tsym.members();
duke@1 2792 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2793 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2794 return true;
duke@1 2795 }
duke@1 2796 }
duke@1 2797 return false;
duke@1 2798 }
duke@1 2799
duke@1 2800 /** Is the annotation applicable to the symbol? */
duke@1 2801 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 2802 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jfranck@1313 2803 if (arr == null) {
jfranck@1313 2804 return true;
jfranck@1313 2805 }
duke@1 2806 for (Attribute app : arr.values) {
duke@1 2807 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2808 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2809 if (e.value.name == names.TYPE)
duke@1 2810 { if (s.kind == TYP) return true; }
duke@1 2811 else if (e.value.name == names.FIELD)
duke@1 2812 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2813 else if (e.value.name == names.METHOD)
duke@1 2814 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2815 else if (e.value.name == names.PARAMETER)
duke@1 2816 { if (s.kind == VAR &&
duke@1 2817 s.owner.kind == MTH &&
duke@1 2818 (s.flags() & PARAMETER) != 0)
duke@1 2819 return true;
duke@1 2820 }
duke@1 2821 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2822 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2823 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2824 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2825 (s.flags() & PARAMETER) == 0)
duke@1 2826 return true;
duke@1 2827 }
duke@1 2828 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2829 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2830 return true;
duke@1 2831 }
duke@1 2832 else if (e.value.name == names.PACKAGE)
duke@1 2833 { if (s.kind == PCK) return true; }
jjg@308 2834 else if (e.value.name == names.TYPE_USE)
jjg@308 2835 { if (s.kind == TYP ||
jjg@308 2836 s.kind == VAR ||
jjg@308 2837 (s.kind == MTH && !s.isConstructor() &&
jjg@1374 2838 !s.type.getReturnType().hasTag(VOID)))
jjg@308 2839 return true;
jjg@308 2840 }
duke@1 2841 else
duke@1 2842 return true; // recovery
duke@1 2843 }
duke@1 2844 return false;
duke@1 2845 }
duke@1 2846
jfranck@1313 2847
jfranck@1313 2848 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 2849 Attribute.Compound atTarget =
jfranck@1313 2850 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 2851 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 2852 Attribute atValue = atTarget.member(names.value);
jfranck@1313 2853 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 2854 return (Attribute.Array) atValue;
jfranck@1313 2855 }
jfranck@1313 2856
duke@1 2857 /** Check an annotation value.
jfranck@1445 2858 *
jfranck@1445 2859 * @param a The annotation tree to check
jfranck@1445 2860 * @return true if this annotation tree is valid, otherwise false
duke@1 2861 */
jfranck@1445 2862 public boolean validateAnnotationDeferErrors(JCAnnotation a) {
jfranck@1445 2863 boolean res = false;
jfranck@1445 2864 final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log);
jfranck@1445 2865 try {
jfranck@1445 2866 res = validateAnnotation(a);
jfranck@1445 2867 } finally {
jfranck@1445 2868 log.popDiagnosticHandler(diagHandler);
jfranck@1445 2869 }
jfranck@1445 2870 return res;
jfranck@1445 2871 }
jfranck@1445 2872
jfranck@1445 2873 private boolean validateAnnotation(JCAnnotation a) {
jfranck@1445 2874 boolean isValid = true;
jfranck@1445 2875 // collect an inventory of the annotation elements
jfranck@1445 2876 Set<MethodSymbol> members = new LinkedHashSet<MethodSymbol>();
duke@1 2877 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2878 e != null;
duke@1 2879 e = e.sibling)
duke@1 2880 if (e.sym.kind == MTH)
duke@1 2881 members.add((MethodSymbol) e.sym);
duke@1 2882
jfranck@1445 2883 // remove the ones that are assigned values
duke@1 2884 for (JCTree arg : a.args) {
jjg@1127 2885 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 2886 JCAssign assign = (JCAssign) arg;
duke@1 2887 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2888 if (m == null || m.type.isErroneous()) continue;
jfranck@1445 2889 if (!members.remove(m)) {
jfranck@1445 2890 isValid = false;
jjg@479 2891 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2892 m.name, a.type);
jfranck@1445 2893 }
duke@1 2894 }
duke@1 2895
duke@1 2896 // all the remaining ones better have default values
jfranck@1445 2897 List<Name> missingDefaults = List.nil();
mcimadamore@632 2898 for (MethodSymbol m : members) {
mcimadamore@632 2899 if (m.defaultValue == null && !m.type.isErroneous()) {
jfranck@1445 2900 missingDefaults = missingDefaults.append(m.name);
mcimadamore@632 2901 }
mcimadamore@632 2902 }
jfranck@1445 2903 missingDefaults = missingDefaults.reverse();
mcimadamore@632 2904 if (missingDefaults.nonEmpty()) {
jfranck@1445 2905 isValid = false;
mcimadamore@632 2906 String key = (missingDefaults.size() > 1)
mcimadamore@632 2907 ? "annotation.missing.default.value.1"
mcimadamore@632 2908 : "annotation.missing.default.value";
mcimadamore@632 2909 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 2910 }
duke@1 2911
duke@1 2912 // special case: java.lang.annotation.Target must not have
duke@1 2913 // repeated values in its value member
duke@1 2914 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2915 a.args.tail == null)
jfranck@1445 2916 return isValid;
duke@1 2917
jfranck@1445 2918 if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery
duke@1 2919 JCAssign assign = (JCAssign) a.args.head;
duke@1 2920 Symbol m = TreeInfo.symbol(assign.lhs);
jfranck@1445 2921 if (m.name != names.value) return false;
duke@1 2922 JCTree rhs = assign.rhs;
jfranck@1445 2923 if (!rhs.hasTag(NEWARRAY)) return false;
duke@1 2924 JCNewArray na = (JCNewArray) rhs;
duke@1 2925 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2926 for (JCTree elem : na.elems) {
duke@1 2927 if (!targets.add(TreeInfo.symbol(elem))) {
jfranck@1445 2928 isValid = false;
duke@1 2929 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2930 }
duke@1 2931 }
jfranck@1445 2932 return isValid;
duke@1 2933 }
duke@1 2934
duke@1 2935 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 2936 if (allowAnnotations &&
mcimadamore@795 2937 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 2938 (s.flags() & DEPRECATED) != 0 &&
duke@1 2939 !syms.deprecatedType.isErroneous() &&
duke@1 2940 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 2941 log.warning(LintCategory.DEP_ANN,
jjg@612 2942 pos, "missing.deprecated.annotation");
duke@1 2943 }
duke@1 2944 }
duke@1 2945
mcimadamore@852 2946 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 2947 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 2948 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 2949 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 2950 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2951 @Override
mcimadamore@852 2952 public void report() {
mcimadamore@852 2953 warnDeprecated(pos, s);
mcimadamore@852 2954 }
mcimadamore@852 2955 });
jjg@1157 2956 }
mcimadamore@852 2957 }
mcimadamore@852 2958
mcimadamore@852 2959 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 2960 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 2961 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2962 public void report() {
mcimadamore@852 2963 if (enableSunApiLintControl)
mcimadamore@852 2964 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 2965 else
mcimadamore@1218 2966 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 2967 }
mcimadamore@852 2968 });
mcimadamore@852 2969 }
mcimadamore@852 2970 }
mcimadamore@852 2971
duke@1 2972 /* *************************************************************************
duke@1 2973 * Check for recursive annotation elements.
duke@1 2974 **************************************************************************/
duke@1 2975
duke@1 2976 /** Check for cycles in the graph of annotation elements.
duke@1 2977 */
duke@1 2978 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 2979 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 2980 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 2981 try {
duke@1 2982 tree.sym.flags_field |= LOCKED;
duke@1 2983 for (JCTree def : tree.defs) {
jjg@1127 2984 if (!def.hasTag(METHODDEF)) continue;
duke@1 2985 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 2986 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 2987 }
duke@1 2988 } finally {
duke@1 2989 tree.sym.flags_field &= ~LOCKED;
duke@1 2990 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 2991 }
duke@1 2992 }
duke@1 2993
duke@1 2994 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 2995 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 2996 return;
duke@1 2997 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 2998 log.error(pos, "cyclic.annotation.element");
duke@1 2999 return;
duke@1 3000 }
duke@1 3001 try {
duke@1 3002 tsym.flags_field |= LOCKED;
duke@1 3003 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 3004 Symbol s = e.sym;
duke@1 3005 if (s.kind != Kinds.MTH)
duke@1 3006 continue;
duke@1 3007 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 3008 }
duke@1 3009 } finally {
duke@1 3010 tsym.flags_field &= ~LOCKED;
duke@1 3011 tsym.flags_field |= ACYCLIC_ANN;
duke@1 3012 }
duke@1 3013 }
duke@1 3014
duke@1 3015 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
jjg@1374 3016 switch (type.getTag()) {
jjg@1374 3017 case CLASS:
duke@1 3018 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 3019 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 3020 break;
jjg@1374 3021 case ARRAY:
duke@1 3022 checkAnnotationResType(pos, types.elemtype(type));
duke@1 3023 break;
duke@1 3024 default:
duke@1 3025 break; // int etc
duke@1 3026 }
duke@1 3027 }
duke@1 3028
duke@1 3029 /* *************************************************************************
duke@1 3030 * Check for cycles in the constructor call graph.
duke@1 3031 **************************************************************************/
duke@1 3032
duke@1 3033 /** Check for cycles in the graph of constructors calling other
duke@1 3034 * constructors.
duke@1 3035 */
duke@1 3036 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 3037 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 3038
duke@1 3039 // enter each constructor this-call into the map
duke@1 3040 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 3041 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 3042 if (app == null) continue;
duke@1 3043 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 3044 if (TreeInfo.name(app.meth) == names._this) {
duke@1 3045 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 3046 } else {
duke@1 3047 meth.sym.flags_field |= ACYCLIC;
duke@1 3048 }
duke@1 3049 }
duke@1 3050
duke@1 3051 // Check for cycles in the map
duke@1 3052 Symbol[] ctors = new Symbol[0];
duke@1 3053 ctors = callMap.keySet().toArray(ctors);
duke@1 3054 for (Symbol caller : ctors) {
duke@1 3055 checkCyclicConstructor(tree, caller, callMap);
duke@1 3056 }
duke@1 3057 }
duke@1 3058
duke@1 3059 /** Look in the map to see if the given constructor is part of a
duke@1 3060 * call cycle.
duke@1 3061 */
duke@1 3062 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 3063 Map<Symbol,Symbol> callMap) {
duke@1 3064 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 3065 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 3066 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 3067 "recursive.ctor.invocation");
duke@1 3068 } else {
duke@1 3069 ctor.flags_field |= LOCKED;
duke@1 3070 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 3071 ctor.flags_field &= ~LOCKED;
duke@1 3072 }
duke@1 3073 ctor.flags_field |= ACYCLIC;
duke@1 3074 }
duke@1 3075 }
duke@1 3076
duke@1 3077 /* *************************************************************************
duke@1 3078 * Miscellaneous
duke@1 3079 **************************************************************************/
duke@1 3080
duke@1 3081 /**
duke@1 3082 * Return the opcode of the operator but emit an error if it is an
duke@1 3083 * error.
duke@1 3084 * @param pos position for error reporting.
duke@1 3085 * @param operator an operator
duke@1 3086 * @param tag a tree tag
duke@1 3087 * @param left type of left hand side
duke@1 3088 * @param right type of right hand side
duke@1 3089 */
duke@1 3090 int checkOperator(DiagnosticPosition pos,
duke@1 3091 OperatorSymbol operator,
jjg@1127 3092 JCTree.Tag tag,
duke@1 3093 Type left,
duke@1 3094 Type right) {
duke@1 3095 if (operator.opcode == ByteCodes.error) {
duke@1 3096 log.error(pos,
mcimadamore@853 3097 "operator.cant.be.applied.1",
duke@1 3098 treeinfo.operatorName(tag),
mcimadamore@853 3099 left, right);
duke@1 3100 }
duke@1 3101 return operator.opcode;
duke@1 3102 }
duke@1 3103
duke@1 3104
duke@1 3105 /**
duke@1 3106 * Check for division by integer constant zero
duke@1 3107 * @param pos Position for error reporting.
duke@1 3108 * @param operator The operator for the expression
duke@1 3109 * @param operand The right hand operand for the expression
duke@1 3110 */
duke@1 3111 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3112 if (operand.constValue() != null
mcimadamore@795 3113 && lint.isEnabled(LintCategory.DIVZERO)
jjg@1374 3114 && (operand.getTag().isSubRangeOf(LONG))
duke@1 3115 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3116 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3117 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3118 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3119 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3120 }
duke@1 3121 }
duke@1 3122 }
duke@1 3123
duke@1 3124 /**
duke@1 3125 * Check for empty statements after if
duke@1 3126 */
duke@1 3127 void checkEmptyIf(JCIf tree) {
jjg@1127 3128 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3129 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3130 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3131 }
duke@1 3132
duke@1 3133 /** Check that symbol is unique in given scope.
duke@1 3134 * @param pos Position for error reporting.
duke@1 3135 * @param sym The symbol.
duke@1 3136 * @param s The scope.
duke@1 3137 */
duke@1 3138 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3139 if (sym.type.isErroneous())
duke@1 3140 return true;
duke@1 3141 if (sym.owner.name == names.any) return false;
duke@1 3142 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3143 if (sym != e.sym &&
mcimadamore@858 3144 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3145 sym.kind == e.sym.kind &&
mcimadamore@858 3146 sym.name != names.error &&
mcimadamore@858 3147 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3148 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3149 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3150 return true;
mcimadamore@907 3151 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3152 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3153 sym.flags_field |= CLASH;
mcimadamore@844 3154 return true;
mcimadamore@844 3155 } else {
duke@1 3156 duplicateError(pos, e.sym);
mcimadamore@844 3157 return false;
mcimadamore@844 3158 }
duke@1 3159 }
duke@1 3160 }
duke@1 3161 return true;
duke@1 3162 }
mcimadamore@844 3163
mcimadamore@858 3164 /** Report duplicate declaration error.
mcimadamore@858 3165 */
mcimadamore@858 3166 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3167 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3168 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3169 }
mcimadamore@858 3170 }
duke@1 3171
duke@1 3172 /** Check that single-type import is not already imported or top-level defined,
duke@1 3173 * but make an exception for two single-type imports which denote the same type.
duke@1 3174 * @param pos Position for error reporting.
duke@1 3175 * @param sym The symbol.
duke@1 3176 * @param s The scope
duke@1 3177 */
duke@1 3178 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3179 return checkUniqueImport(pos, sym, s, false);
duke@1 3180 }
duke@1 3181
duke@1 3182 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3183 * but make an exception for two single-type imports which denote the same type.
duke@1 3184 * @param pos Position for error reporting.
duke@1 3185 * @param sym The symbol.
duke@1 3186 * @param s The scope
duke@1 3187 */
duke@1 3188 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3189 return checkUniqueImport(pos, sym, s, true);
duke@1 3190 }
duke@1 3191
duke@1 3192 /** Check that single-type import is not already imported or top-level defined,
duke@1 3193 * but make an exception for two single-type imports which denote the same type.
duke@1 3194 * @param pos Position for error reporting.
duke@1 3195 * @param sym The symbol.
duke@1 3196 * @param s The scope.
duke@1 3197 * @param staticImport Whether or not this was a static import
duke@1 3198 */
duke@1 3199 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3200 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3201 // is encountered class entered via a class declaration?
duke@1 3202 boolean isClassDecl = e.scope == s;
duke@1 3203 if ((isClassDecl || sym != e.sym) &&
duke@1 3204 sym.kind == e.sym.kind &&
duke@1 3205 sym.name != names.error) {
duke@1 3206 if (!e.sym.type.isErroneous()) {
duke@1 3207 String what = e.sym.toString();
duke@1 3208 if (!isClassDecl) {
duke@1 3209 if (staticImport)
duke@1 3210 log.error(pos, "already.defined.static.single.import", what);
duke@1 3211 else
duke@1 3212 log.error(pos, "already.defined.single.import", what);
duke@1 3213 }
duke@1 3214 else if (sym != e.sym)
duke@1 3215 log.error(pos, "already.defined.this.unit", what);
duke@1 3216 }
duke@1 3217 return false;
duke@1 3218 }
duke@1 3219 }
duke@1 3220 return true;
duke@1 3221 }
duke@1 3222
duke@1 3223 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3224 */
duke@1 3225 public void checkCanonical(JCTree tree) {
duke@1 3226 if (!isCanonical(tree))
duke@1 3227 log.error(tree.pos(), "import.requires.canonical",
duke@1 3228 TreeInfo.symbol(tree));
duke@1 3229 }
duke@1 3230 // where
duke@1 3231 private boolean isCanonical(JCTree tree) {
jjg@1127 3232 while (tree.hasTag(SELECT)) {
duke@1 3233 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3234 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3235 return false;
duke@1 3236 tree = s.selected;
duke@1 3237 }
duke@1 3238 return true;
duke@1 3239 }
duke@1 3240
ohrstrom@1384 3241 /** Check that an auxiliary class is not accessed from any other file than its own.
ohrstrom@1384 3242 */
ohrstrom@1384 3243 void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) {
ohrstrom@1384 3244 if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) &&
ohrstrom@1384 3245 (c.flags() & AUXILIARY) != 0 &&
ohrstrom@1384 3246 rs.isAccessible(env, c) &&
ohrstrom@1384 3247 !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile))
ohrstrom@1384 3248 {
ohrstrom@1384 3249 log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file",
ohrstrom@1384 3250 c, c.sourcefile);
ohrstrom@1384 3251 }
ohrstrom@1384 3252 }
ohrstrom@1384 3253
duke@1 3254 private class ConversionWarner extends Warner {
mcimadamore@795 3255 final String uncheckedKey;
duke@1 3256 final Type found;
duke@1 3257 final Type expected;
mcimadamore@795 3258 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3259 super(pos);
mcimadamore@795 3260 this.uncheckedKey = uncheckedKey;
duke@1 3261 this.found = found;
duke@1 3262 this.expected = expected;
duke@1 3263 }
duke@1 3264
jjg@398 3265 @Override
mcimadamore@795 3266 public void warn(LintCategory lint) {
duke@1 3267 boolean warned = this.warned;
mcimadamore@795 3268 super.warn(lint);
duke@1 3269 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3270 switch (lint) {
mcimadamore@795 3271 case UNCHECKED:
mcimadamore@795 3272 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3273 break;
mcimadamore@795 3274 case VARARGS:
mcimadamore@795 3275 if (method != null &&
mcimadamore@795 3276 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3277 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3278 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3279 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3280 }
mcimadamore@795 3281 break;
mcimadamore@795 3282 default:
mcimadamore@795 3283 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3284 }
duke@1 3285 }
duke@1 3286 }
duke@1 3287
duke@1 3288 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3289 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3290 }
duke@1 3291
duke@1 3292 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3293 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3294 }
duke@1 3295 }

mercurial