src/share/classes/com/sun/tools/javac/comp/Check.java

Tue, 08 Nov 2011 11:51:05 -0800

author
jjg
date
Tue, 08 Nov 2011 11:51:05 -0800
changeset 1127
ca49d50318dc
parent 1103
47147081d5b4
child 1157
3809292620c9
permissions
-rw-r--r--

6921494: provide way to print javac tree tag values
Reviewed-by: jjg, mcimadamore
Contributed-by: vicenterz@yahoo.es

duke@1 1 /*
jjg@815 2 * Copyright (c) 1999, 2011, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
duke@1 30
duke@1 31 import com.sun.tools.javac.code.*;
duke@1 32 import com.sun.tools.javac.jvm.*;
duke@1 33 import com.sun.tools.javac.tree.*;
duke@1 34 import com.sun.tools.javac.util.*;
duke@1 35 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 36 import com.sun.tools.javac.util.List;
duke@1 37
duke@1 38 import com.sun.tools.javac.tree.JCTree.*;
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
duke@1 43
duke@1 44 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 45 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 46 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 47 import static com.sun.tools.javac.code.Kinds.*;
duke@1 48 import static com.sun.tools.javac.code.TypeTags.*;
jjg@1127 49 import static com.sun.tools.javac.code.TypeTags.WILDCARD;
duke@1 50
jjg@700 51 import static com.sun.tools.javac.main.OptionName.*;
jjg@1127 52 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 53
duke@1 54 /** Type checking helper class for the attribution phase.
duke@1 55 *
jjg@581 56 * <p><b>This is NOT part of any supported API.
jjg@581 57 * If you write code that depends on this, you do so at your own risk.
duke@1 58 * This code and its internal interfaces are subject to change or
duke@1 59 * deletion without notice.</b>
duke@1 60 */
duke@1 61 public class Check {
duke@1 62 protected static final Context.Key<Check> checkKey =
duke@1 63 new Context.Key<Check>();
duke@1 64
jjg@113 65 private final Names names;
duke@1 66 private final Log log;
duke@1 67 private final Symtab syms;
mcimadamore@690 68 private final Enter enter;
duke@1 69 private final Infer infer;
duke@1 70 private final Types types;
mcimadamore@89 71 private final JCDiagnostic.Factory diags;
duke@1 72 private final boolean skipAnnotations;
mcimadamore@359 73 private boolean warnOnSyntheticConflicts;
jjg@576 74 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 75 private boolean enableSunApiLintControl;
duke@1 76 private final TreeInfo treeinfo;
duke@1 77
duke@1 78 // The set of lint options currently in effect. It is initialized
duke@1 79 // from the context, and then is set/reset as needed by Attr as it
duke@1 80 // visits all the various parts of the trees during attribution.
duke@1 81 private Lint lint;
duke@1 82
mcimadamore@795 83 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 84 // Attr as it visits new method declarations.
mcimadamore@795 85 private MethodSymbol method;
mcimadamore@795 86
duke@1 87 public static Check instance(Context context) {
duke@1 88 Check instance = context.get(checkKey);
duke@1 89 if (instance == null)
duke@1 90 instance = new Check(context);
duke@1 91 return instance;
duke@1 92 }
duke@1 93
duke@1 94 protected Check(Context context) {
duke@1 95 context.put(checkKey, this);
duke@1 96
jjg@113 97 names = Names.instance(context);
duke@1 98 log = Log.instance(context);
duke@1 99 syms = Symtab.instance(context);
mcimadamore@690 100 enter = Enter.instance(context);
duke@1 101 infer = Infer.instance(context);
duke@1 102 this.types = Types.instance(context);
mcimadamore@89 103 diags = JCDiagnostic.Factory.instance(context);
duke@1 104 Options options = Options.instance(context);
duke@1 105 lint = Lint.instance(context);
duke@1 106 treeinfo = TreeInfo.instance(context);
duke@1 107
duke@1 108 Source source = Source.instance(context);
duke@1 109 allowGenerics = source.allowGenerics();
duke@1 110 allowAnnotations = source.allowAnnotations();
jjg@398 111 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 112 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
jjg@700 113 complexInference = options.isSet(COMPLEXINFERENCE);
jjg@700 114 skipAnnotations = options.isSet("skipAnnotations");
jjg@700 115 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 116 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 117 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 118
jjg@398 119 Target target = Target.instance(context);
jjg@398 120 syntheticNameChar = target.syntheticNameChar();
jjg@398 121
duke@1 122 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 123 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 124 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 125 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 126
jjg@60 127 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 128 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 129 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 130 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 131 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 132 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 133
mcimadamore@852 134 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 135 }
duke@1 136
duke@1 137 /** Switch: generics enabled?
duke@1 138 */
duke@1 139 boolean allowGenerics;
duke@1 140
duke@1 141 /** Switch: annotations enabled?
duke@1 142 */
duke@1 143 boolean allowAnnotations;
duke@1 144
jjg@398 145 /** Switch: covariant returns enabled?
jjg@398 146 */
jjg@398 147 boolean allowCovariantReturns;
jjg@398 148
mcimadamore@795 149 /** Switch: simplified varargs enabled?
mcimadamore@795 150 */
mcimadamore@795 151 boolean allowSimplifiedVarargs;
mcimadamore@795 152
duke@1 153 /** Switch: -complexinference option set?
duke@1 154 */
duke@1 155 boolean complexInference;
duke@1 156
jjg@398 157 /** Character for synthetic names
jjg@398 158 */
jjg@398 159 char syntheticNameChar;
jjg@398 160
duke@1 161 /** A table mapping flat names of all compiled classes in this run to their
duke@1 162 * symbols; maintained from outside.
duke@1 163 */
duke@1 164 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 165
duke@1 166 /** A handler for messages about deprecated usage.
duke@1 167 */
duke@1 168 private MandatoryWarningHandler deprecationHandler;
duke@1 169
duke@1 170 /** A handler for messages about unchecked or unsafe usage.
duke@1 171 */
duke@1 172 private MandatoryWarningHandler uncheckedHandler;
duke@1 173
jjg@582 174 /** A handler for messages about using proprietary API.
jjg@377 175 */
jjg@377 176 private MandatoryWarningHandler sunApiHandler;
duke@1 177
mcimadamore@852 178 /** A handler for deferred lint warnings.
mcimadamore@852 179 */
mcimadamore@852 180 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 181
duke@1 182 /* *************************************************************************
duke@1 183 * Errors and Warnings
duke@1 184 **************************************************************************/
duke@1 185
duke@1 186 Lint setLint(Lint newLint) {
duke@1 187 Lint prev = lint;
duke@1 188 lint = newLint;
duke@1 189 return prev;
duke@1 190 }
duke@1 191
mcimadamore@852 192 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 193 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 194 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 195 return prev;
mcimadamore@852 196 }
mcimadamore@852 197
mcimadamore@795 198 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 199 MethodSymbol prev = method;
mcimadamore@795 200 method = newMethod;
mcimadamore@795 201 return prev;
mcimadamore@795 202 }
mcimadamore@795 203
duke@1 204 /** Warn about deprecated symbol.
duke@1 205 * @param pos Position to be used for error reporting.
duke@1 206 * @param sym The deprecated symbol.
duke@1 207 */
duke@1 208 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 209 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 210 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 211 }
duke@1 212
duke@1 213 /** Warn about unchecked operation.
duke@1 214 * @param pos Position to be used for error reporting.
duke@1 215 * @param msg A string describing the problem.
duke@1 216 */
duke@1 217 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 218 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 219 uncheckedHandler.report(pos, msg, args);
duke@1 220 }
duke@1 221
mcimadamore@580 222 /** Warn about unsafe vararg method decl.
mcimadamore@580 223 * @param pos Position to be used for error reporting.
mcimadamore@580 224 * @param sym The deprecated symbol.
mcimadamore@580 225 */
mcimadamore@795 226 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 227 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 228 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 229 }
mcimadamore@580 230
jjg@582 231 /** Warn about using proprietary API.
jjg@377 232 * @param pos Position to be used for error reporting.
jjg@377 233 * @param msg A string describing the problem.
jjg@377 234 */
jjg@377 235 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 236 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 237 sunApiHandler.report(pos, msg, args);
jjg@377 238 }
jjg@377 239
jjg@505 240 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 241 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 242 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 243 }
jjg@505 244
duke@1 245 /**
duke@1 246 * Report any deferred diagnostics.
duke@1 247 */
duke@1 248 public void reportDeferredDiagnostics() {
duke@1 249 deprecationHandler.reportDeferredDiagnostic();
duke@1 250 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 251 sunApiHandler.reportDeferredDiagnostic();
duke@1 252 }
duke@1 253
duke@1 254
duke@1 255 /** Report a failure to complete a class.
duke@1 256 * @param pos Position to be used for error reporting.
duke@1 257 * @param ex The failure to report.
duke@1 258 */
duke@1 259 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 260 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 261 if (ex instanceof ClassReader.BadClassFile
jjg@576 262 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 263 else return syms.errType;
duke@1 264 }
duke@1 265
duke@1 266 /** Report a type error.
duke@1 267 * @param pos Position to be used for error reporting.
duke@1 268 * @param problem A string describing the error.
duke@1 269 * @param found The type that was found.
duke@1 270 * @param req The type that was required.
duke@1 271 */
duke@1 272 Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
duke@1 273 log.error(pos, "prob.found.req",
duke@1 274 problem, found, req);
jjg@110 275 return types.createErrorType(found);
duke@1 276 }
duke@1 277
duke@1 278 Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
duke@1 279 log.error(pos, "prob.found.req.1", problem, found, req, explanation);
jjg@110 280 return types.createErrorType(found);
duke@1 281 }
duke@1 282
duke@1 283 /** Report an error that wrong type tag was found.
duke@1 284 * @param pos Position to be used for error reporting.
duke@1 285 * @param required An internationalized string describing the type tag
duke@1 286 * required.
duke@1 287 * @param found The type that was found.
duke@1 288 */
duke@1 289 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 290 // this error used to be raised by the parser,
jrose@267 291 // but has been delayed to this point:
jrose@267 292 if (found instanceof Type && ((Type)found).tag == VOID) {
jrose@267 293 log.error(pos, "illegal.start.of.type");
jrose@267 294 return syms.errType;
jrose@267 295 }
duke@1 296 log.error(pos, "type.found.req", found, required);
jjg@110 297 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 298 }
duke@1 299
duke@1 300 /** Report an error that symbol cannot be referenced before super
duke@1 301 * has been called.
duke@1 302 * @param pos Position to be used for error reporting.
duke@1 303 * @param sym The referenced symbol.
duke@1 304 */
duke@1 305 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 306 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 307 }
duke@1 308
duke@1 309 /** Report duplicate declaration error.
duke@1 310 */
duke@1 311 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 312 if (!sym.type.isErroneous()) {
mcimadamore@1085 313 Symbol location = sym.location();
mcimadamore@1085 314 if (location.kind == MTH &&
mcimadamore@1085 315 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 316 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 317 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 318 sym.location().enclClass());
mcimadamore@1085 319 } else {
mcimadamore@1085 320 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 321 kindName(sym.location()), sym.location());
mcimadamore@1085 322 }
duke@1 323 }
duke@1 324 }
duke@1 325
duke@1 326 /** Report array/varargs duplicate declaration
duke@1 327 */
duke@1 328 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 329 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 330 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 331 }
duke@1 332 }
duke@1 333
duke@1 334 /* ************************************************************************
duke@1 335 * duplicate declaration checking
duke@1 336 *************************************************************************/
duke@1 337
duke@1 338 /** Check that variable does not hide variable with same name in
duke@1 339 * immediately enclosing local scope.
duke@1 340 * @param pos Position for error reporting.
duke@1 341 * @param v The symbol.
duke@1 342 * @param s The scope.
duke@1 343 */
duke@1 344 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 345 if (s.next != null) {
duke@1 346 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 347 e.scope != null && e.sym.owner == v.owner;
duke@1 348 e = e.next()) {
duke@1 349 if (e.sym.kind == VAR &&
duke@1 350 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 351 v.name != names.error) {
duke@1 352 duplicateError(pos, e.sym);
duke@1 353 return;
duke@1 354 }
duke@1 355 }
duke@1 356 }
duke@1 357 }
duke@1 358
duke@1 359 /** Check that a class or interface does not hide a class or
duke@1 360 * interface with same name in immediately enclosing local scope.
duke@1 361 * @param pos Position for error reporting.
duke@1 362 * @param c The symbol.
duke@1 363 * @param s The scope.
duke@1 364 */
duke@1 365 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 366 if (s.next != null) {
duke@1 367 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 368 e.scope != null && e.sym.owner == c.owner;
duke@1 369 e = e.next()) {
mcimadamore@639 370 if (e.sym.kind == TYP && e.sym.type.tag != TYPEVAR &&
duke@1 371 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 372 c.name != names.error) {
duke@1 373 duplicateError(pos, e.sym);
duke@1 374 return;
duke@1 375 }
duke@1 376 }
duke@1 377 }
duke@1 378 }
duke@1 379
duke@1 380 /** Check that class does not have the same name as one of
duke@1 381 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 382 * return true if class is unique in its enclosing scope.
duke@1 383 * @param pos Position for error reporting.
duke@1 384 * @param name The class name.
duke@1 385 * @param s The enclosing scope.
duke@1 386 */
duke@1 387 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 388 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 389 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 390 duplicateError(pos, e.sym);
duke@1 391 return false;
duke@1 392 }
duke@1 393 }
duke@1 394 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 395 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 396 duplicateError(pos, sym);
duke@1 397 return true;
duke@1 398 }
duke@1 399 }
duke@1 400 return true;
duke@1 401 }
duke@1 402
duke@1 403 /* *************************************************************************
duke@1 404 * Class name generation
duke@1 405 **************************************************************************/
duke@1 406
duke@1 407 /** Return name of local class.
duke@1 408 * This is of the form <enclClass> $ n <classname>
duke@1 409 * where
duke@1 410 * enclClass is the flat name of the enclosing class,
duke@1 411 * classname is the simple name of the local class
duke@1 412 */
duke@1 413 Name localClassName(ClassSymbol c) {
duke@1 414 for (int i=1; ; i++) {
duke@1 415 Name flatname = names.
duke@1 416 fromString("" + c.owner.enclClass().flatname +
jjg@398 417 syntheticNameChar + i +
duke@1 418 c.name);
duke@1 419 if (compiled.get(flatname) == null) return flatname;
duke@1 420 }
duke@1 421 }
duke@1 422
duke@1 423 /* *************************************************************************
duke@1 424 * Type Checking
duke@1 425 **************************************************************************/
duke@1 426
duke@1 427 /** Check that a given type is assignable to a given proto-type.
duke@1 428 * If it is, return the type, otherwise return errType.
duke@1 429 * @param pos Position to be used for error reporting.
duke@1 430 * @param found The type that was found.
duke@1 431 * @param req The type that was required.
duke@1 432 */
duke@1 433 Type checkType(DiagnosticPosition pos, Type found, Type req) {
darcy@609 434 return checkType(pos, found, req, "incompatible.types");
darcy@609 435 }
darcy@609 436
darcy@609 437 Type checkType(DiagnosticPosition pos, Type found, Type req, String errKey) {
duke@1 438 if (req.tag == ERROR)
duke@1 439 return req;
mcimadamore@536 440 if (found.tag == FORALL)
mcimadamore@536 441 return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req));
duke@1 442 if (req.tag == NONE)
duke@1 443 return found;
duke@1 444 if (types.isAssignable(found, req, convertWarner(pos, found, req)))
duke@1 445 return found;
duke@1 446 if (found.tag <= DOUBLE && req.tag <= DOUBLE)
mcimadamore@89 447 return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req);
duke@1 448 if (found.isSuperBound()) {
duke@1 449 log.error(pos, "assignment.from.super-bound", found);
jjg@110 450 return types.createErrorType(found);
duke@1 451 }
duke@1 452 if (req.isExtendsBound()) {
duke@1 453 log.error(pos, "assignment.to.extends-bound", req);
jjg@110 454 return types.createErrorType(found);
duke@1 455 }
darcy@609 456 return typeError(pos, diags.fragment(errKey), found, req);
duke@1 457 }
duke@1 458
duke@1 459 /** Instantiate polymorphic type to some prototype, unless
duke@1 460 * prototype is `anyPoly' in which case polymorphic type
duke@1 461 * is returned unchanged.
duke@1 462 */
mcimadamore@383 463 Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException {
duke@1 464 if (pt == Infer.anyPoly && complexInference) {
duke@1 465 return t;
duke@1 466 } else if (pt == Infer.anyPoly || pt.tag == NONE) {
duke@1 467 Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
duke@1 468 return instantiatePoly(pos, t, newpt, warn);
duke@1 469 } else if (pt.tag == ERROR) {
duke@1 470 return pt;
duke@1 471 } else {
mcimadamore@536 472 try {
mcimadamore@536 473 return infer.instantiateExpr(t, pt, warn);
mcimadamore@536 474 } catch (Infer.NoInstanceException ex) {
mcimadamore@536 475 if (ex.isAmbiguous) {
mcimadamore@536 476 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 477 log.error(pos,
mcimadamore@536 478 "undetermined.type" + (d!=null ? ".1" : ""),
mcimadamore@536 479 t, d);
mcimadamore@536 480 return types.createErrorType(pt);
mcimadamore@536 481 } else {
mcimadamore@536 482 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 483 return typeError(pos,
mcimadamore@536 484 diags.fragment("incompatible.types" + (d!=null ? ".1" : ""), d),
mcimadamore@536 485 t, pt);
mcimadamore@536 486 }
mcimadamore@536 487 } catch (Infer.InvalidInstanceException ex) {
mcimadamore@536 488 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 489 log.error(pos, "invalid.inferred.types", t.tvars, d);
mcimadamore@536 490 return types.createErrorType(pt);
mcimadamore@536 491 }
duke@1 492 }
mcimadamore@536 493 }
duke@1 494
duke@1 495 /** Check that a given type can be cast to a given target type.
duke@1 496 * Return the result of the cast.
duke@1 497 * @param pos Position to be used for error reporting.
duke@1 498 * @param found The type that is being cast.
duke@1 499 * @param req The target type of the cast.
duke@1 500 */
duke@1 501 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
duke@1 502 if (found.tag == FORALL) {
duke@1 503 instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
duke@1 504 return req;
duke@1 505 } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 506 return req;
duke@1 507 } else {
duke@1 508 return typeError(pos,
mcimadamore@89 509 diags.fragment("inconvertible.types"),
duke@1 510 found, req);
duke@1 511 }
duke@1 512 }
duke@1 513 //where
duke@1 514 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 515 * type variables?
duke@1 516 */
duke@1 517 boolean isTypeVar(Type t) {
duke@1 518 return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
duke@1 519 }
duke@1 520
duke@1 521 /** Check that a type is within some bounds.
duke@1 522 *
duke@1 523 * Used in TypeApply to verify that, e.g., X in V<X> is a valid
duke@1 524 * type argument.
duke@1 525 * @param pos Position to be used for error reporting.
duke@1 526 * @param a The type that should be bounded by bs.
duke@1 527 * @param bs The bound.
duke@1 528 */
mcimadamore@821 529 private boolean checkExtends(Type a, TypeVar bs) {
mcimadamore@154 530 if (a.isUnbound()) {
mcimadamore@821 531 return true;
mcimadamore@154 532 } else if (a.tag != WILDCARD) {
mcimadamore@154 533 a = types.upperBound(a);
mcimadamore@821 534 return types.isSubtype(a, bs.bound);
mcimadamore@154 535 } else if (a.isExtendsBound()) {
mcimadamore@821 536 return types.isCastable(bs.getUpperBound(), types.upperBound(a), Warner.noWarnings);
mcimadamore@154 537 } else if (a.isSuperBound()) {
mcimadamore@821 538 return !types.notSoftSubtype(types.lowerBound(a), bs.getUpperBound());
mcimadamore@154 539 }
mcimadamore@821 540 return true;
mcimadamore@154 541 }
duke@1 542
duke@1 543 /** Check that type is different from 'void'.
duke@1 544 * @param pos Position to be used for error reporting.
duke@1 545 * @param t The type to be checked.
duke@1 546 */
duke@1 547 Type checkNonVoid(DiagnosticPosition pos, Type t) {
duke@1 548 if (t.tag == VOID) {
duke@1 549 log.error(pos, "void.not.allowed.here");
jjg@110 550 return types.createErrorType(t);
duke@1 551 } else {
duke@1 552 return t;
duke@1 553 }
duke@1 554 }
duke@1 555
duke@1 556 /** Check that type is a class or interface type.
duke@1 557 * @param pos Position to be used for error reporting.
duke@1 558 * @param t The type to be checked.
duke@1 559 */
duke@1 560 Type checkClassType(DiagnosticPosition pos, Type t) {
duke@1 561 if (t.tag != CLASS && t.tag != ERROR)
duke@1 562 return typeTagError(pos,
mcimadamore@89 563 diags.fragment("type.req.class"),
duke@1 564 (t.tag == TYPEVAR)
mcimadamore@89 565 ? diags.fragment("type.parameter", t)
duke@1 566 : t);
duke@1 567 else
duke@1 568 return t;
duke@1 569 }
duke@1 570
duke@1 571 /** Check that type is a class or interface type.
duke@1 572 * @param pos Position to be used for error reporting.
duke@1 573 * @param t The type to be checked.
duke@1 574 * @param noBounds True if type bounds are illegal here.
duke@1 575 */
duke@1 576 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 577 t = checkClassType(pos, t);
duke@1 578 if (noBounds && t.isParameterized()) {
duke@1 579 List<Type> args = t.getTypeArguments();
duke@1 580 while (args.nonEmpty()) {
duke@1 581 if (args.head.tag == WILDCARD)
duke@1 582 return typeTagError(pos,
jjg@598 583 diags.fragment("type.req.exact"),
duke@1 584 args.head);
duke@1 585 args = args.tail;
duke@1 586 }
duke@1 587 }
duke@1 588 return t;
duke@1 589 }
duke@1 590
duke@1 591 /** Check that type is a reifiable class, interface or array type.
duke@1 592 * @param pos Position to be used for error reporting.
duke@1 593 * @param t The type to be checked.
duke@1 594 */
duke@1 595 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
duke@1 596 if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
duke@1 597 return typeTagError(pos,
mcimadamore@89 598 diags.fragment("type.req.class.array"),
duke@1 599 t);
duke@1 600 } else if (!types.isReifiable(t)) {
duke@1 601 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 602 return types.createErrorType(t);
duke@1 603 } else {
duke@1 604 return t;
duke@1 605 }
duke@1 606 }
duke@1 607
duke@1 608 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 609 * or a type variable.
duke@1 610 * @param pos Position to be used for error reporting.
duke@1 611 * @param t The type to be checked.
duke@1 612 */
duke@1 613 Type checkRefType(DiagnosticPosition pos, Type t) {
duke@1 614 switch (t.tag) {
duke@1 615 case CLASS:
duke@1 616 case ARRAY:
duke@1 617 case TYPEVAR:
duke@1 618 case WILDCARD:
duke@1 619 case ERROR:
duke@1 620 return t;
duke@1 621 default:
duke@1 622 return typeTagError(pos,
mcimadamore@89 623 diags.fragment("type.req.ref"),
duke@1 624 t);
duke@1 625 }
duke@1 626 }
duke@1 627
jrose@267 628 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 629 * or a type variable.
jrose@267 630 * @param trees Original trees, used for error reporting.
jrose@267 631 * @param types The types to be checked.
jrose@267 632 */
jrose@267 633 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 634 List<JCExpression> tl = trees;
jrose@267 635 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 636 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 637 tl = tl.tail;
jrose@267 638 }
jrose@267 639 return types;
jrose@267 640 }
jrose@267 641
duke@1 642 /** Check that type is a null or reference type.
duke@1 643 * @param pos Position to be used for error reporting.
duke@1 644 * @param t The type to be checked.
duke@1 645 */
duke@1 646 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
duke@1 647 switch (t.tag) {
duke@1 648 case CLASS:
duke@1 649 case ARRAY:
duke@1 650 case TYPEVAR:
duke@1 651 case WILDCARD:
duke@1 652 case BOT:
duke@1 653 case ERROR:
duke@1 654 return t;
duke@1 655 default:
duke@1 656 return typeTagError(pos,
mcimadamore@89 657 diags.fragment("type.req.ref"),
duke@1 658 t);
duke@1 659 }
duke@1 660 }
duke@1 661
duke@1 662 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 663 * Return true if it doesn't.
duke@1 664 * @param pos Position to be used for error reporting.
duke@1 665 * @param flags The set of flags to be checked.
duke@1 666 * @param set1 Conflicting flags set #1.
duke@1 667 * @param set2 Conflicting flags set #2.
duke@1 668 */
duke@1 669 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 670 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 671 log.error(pos,
duke@1 672 "illegal.combination.of.modifiers",
mcimadamore@80 673 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 674 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 675 return false;
duke@1 676 } else
duke@1 677 return true;
duke@1 678 }
duke@1 679
mcimadamore@914 680 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 681 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 682 */
mcimadamore@914 683 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 684 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 685 t.isErroneous()) {
mcimadamore@914 686 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 687 } else if (tree.def != null) {
mcimadamore@914 688 log.error(tree.clazz.pos(),
mcimadamore@914 689 "cant.apply.diamond.1",
mcimadamore@914 690 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 691 return types.createErrorType(t);
mcimadamore@948 692 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 693 log.error(tree.clazz.pos(),
mcimadamore@914 694 "cant.apply.diamond.1",
mcimadamore@914 695 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 696 return types.createErrorType(t);
mcimadamore@993 697 } else if (tree.typeargs != null &&
mcimadamore@993 698 tree.typeargs.nonEmpty()) {
mcimadamore@993 699 log.error(tree.clazz.pos(),
mcimadamore@993 700 "cant.apply.diamond.1",
mcimadamore@993 701 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 702 return types.createErrorType(t);
mcimadamore@914 703 } else {
mcimadamore@914 704 return t;
mcimadamore@537 705 }
mcimadamore@537 706 }
mcimadamore@537 707
mcimadamore@795 708 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 709 MethodSymbol m = tree.sym;
mcimadamore@795 710 if (!allowSimplifiedVarargs) return;
mcimadamore@795 711 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 712 Type varargElemType = null;
mcimadamore@580 713 if (m.isVarArgs()) {
mcimadamore@795 714 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 715 }
mcimadamore@795 716 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 717 if (varargElemType != null) {
mcimadamore@795 718 log.error(tree,
mcimadamore@795 719 "varargs.invalid.trustme.anno",
mcimadamore@795 720 syms.trustMeType.tsym,
mcimadamore@795 721 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 722 } else {
mcimadamore@795 723 log.error(tree,
mcimadamore@795 724 "varargs.invalid.trustme.anno",
mcimadamore@795 725 syms.trustMeType.tsym,
mcimadamore@795 726 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 727 }
mcimadamore@795 728 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 729 types.isReifiable(varargElemType)) {
mcimadamore@795 730 warnUnsafeVararg(tree,
mcimadamore@795 731 "varargs.redundant.trustme.anno",
mcimadamore@795 732 syms.trustMeType.tsym,
mcimadamore@795 733 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 734 }
mcimadamore@795 735 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 736 !types.isReifiable(varargElemType)) {
mcimadamore@795 737 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 738 }
mcimadamore@580 739 }
mcimadamore@795 740 //where
mcimadamore@795 741 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 742 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 743 (s.isConstructor() ||
mcimadamore@795 744 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 745 }
mcimadamore@580 746
mcimadamore@547 747 /**
mcimadamore@547 748 * Check that vararg method call is sound
mcimadamore@547 749 * @param pos Position to be used for error reporting.
mcimadamore@547 750 * @param argtypes Actual arguments supplied to vararg method.
mcimadamore@547 751 */
mcimadamore@795 752 void checkVararg(DiagnosticPosition pos, List<Type> argtypes, Symbol msym) {
mcimadamore@547 753 Type argtype = argtypes.last();
mcimadamore@795 754 if (!types.isReifiable(argtype) &&
mcimadamore@795 755 (!allowSimplifiedVarargs ||
mcimadamore@795 756 msym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@795 757 !isTrustMeAllowedOnMethod(msym))) {
mcimadamore@547 758 warnUnchecked(pos,
mcimadamore@547 759 "unchecked.generic.array.creation",
mcimadamore@547 760 argtype);
mcimadamore@580 761 }
mcimadamore@547 762 }
mcimadamore@547 763
mcimadamore@821 764 /**
mcimadamore@821 765 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 766 * (see JLS 4.5)
mcimadamore@821 767 *
mcimadamore@821 768 * @param t class type to be checked
mcimadamore@821 769 * @return true if 't' is well-formed
mcimadamore@821 770 */
mcimadamore@821 771 public boolean checkValidGenericType(Type t) {
mcimadamore@821 772 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 773 }
mcimadamore@821 774 //WHERE
mcimadamore@821 775 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 776 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 777 List<Type> actuals = type.allparams();
mcimadamore@821 778 List<Type> args = type.getTypeArguments();
mcimadamore@821 779 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@821 780 ListBuffer<Type> tvars_buf = new ListBuffer<Type>();
mcimadamore@821 781
mcimadamore@821 782 // For matching pairs of actual argument types `a' and
mcimadamore@821 783 // formal type parameters with declared bound `b' ...
mcimadamore@821 784 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 785 // exact type arguments needs to know their
mcimadamore@821 786 // bounds (for upper and lower bound
mcimadamore@821 787 // calculations). So we create new TypeVars with
mcimadamore@821 788 // bounds substed with actuals.
mcimadamore@821 789 tvars_buf.append(types.substBound(((TypeVar)forms.head),
mcimadamore@821 790 formals,
mcimadamore@821 791 actuals));
mcimadamore@821 792 args = args.tail;
mcimadamore@821 793 forms = forms.tail;
mcimadamore@821 794 }
mcimadamore@821 795
mcimadamore@821 796 args = type.getTypeArguments();
mcimadamore@821 797 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 798 formals,
mcimadamore@821 799 types.capture(type).allparams());
mcimadamore@821 800 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 801 // Let the actual arguments know their bound
mcimadamore@821 802 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 803 args = args.tail;
mcimadamore@821 804 tvars_cap = tvars_cap.tail;
mcimadamore@821 805 }
mcimadamore@821 806
mcimadamore@821 807 args = type.getTypeArguments();
mcimadamore@821 808 List<Type> tvars = tvars_buf.toList();
mcimadamore@821 809
mcimadamore@821 810 while (args.nonEmpty() && tvars.nonEmpty()) {
mcimadamore@821 811 Type actual = types.subst(args.head,
mcimadamore@821 812 type.tsym.type.getTypeArguments(),
mcimadamore@821 813 tvars_buf.toList());
mcimadamore@854 814 if (!isTypeArgErroneous(actual) &&
mcimadamore@854 815 !tvars.head.getUpperBound().isErroneous() &&
mcimadamore@854 816 !checkExtends(actual, (TypeVar)tvars.head)) {
mcimadamore@821 817 return args.head;
mcimadamore@821 818 }
mcimadamore@821 819 args = args.tail;
mcimadamore@821 820 tvars = tvars.tail;
mcimadamore@821 821 }
mcimadamore@821 822
mcimadamore@821 823 args = type.getTypeArguments();
mcimadamore@828 824 tvars = tvars_buf.toList();
mcimadamore@821 825
mcimadamore@821 826 for (Type arg : types.capture(type).getTypeArguments()) {
mcimadamore@828 827 if (arg.tag == TYPEVAR &&
mcimadamore@828 828 arg.getUpperBound().isErroneous() &&
mcimadamore@854 829 !tvars.head.getUpperBound().isErroneous() &&
mcimadamore@854 830 !isTypeArgErroneous(args.head)) {
mcimadamore@821 831 return args.head;
mcimadamore@821 832 }
mcimadamore@828 833 tvars = tvars.tail;
mcimadamore@854 834 args = args.tail;
mcimadamore@821 835 }
mcimadamore@821 836
mcimadamore@821 837 return null;
mcimadamore@821 838 }
mcimadamore@854 839 //where
mcimadamore@854 840 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 841 return isTypeArgErroneous.visit(t);
mcimadamore@854 842 }
mcimadamore@854 843
mcimadamore@854 844 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 845 public Boolean visitType(Type t, Void s) {
mcimadamore@854 846 return t.isErroneous();
mcimadamore@854 847 }
mcimadamore@854 848 @Override
mcimadamore@854 849 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 850 return visit(t.getUpperBound());
mcimadamore@854 851 }
mcimadamore@854 852 @Override
mcimadamore@854 853 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 854 return visit(t.getUpperBound()) ||
mcimadamore@854 855 visit(t.getLowerBound());
mcimadamore@854 856 }
mcimadamore@854 857 @Override
mcimadamore@854 858 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 859 return visit(t.type);
mcimadamore@854 860 }
mcimadamore@854 861 };
mcimadamore@821 862
duke@1 863 /** Check that given modifiers are legal for given symbol and
duke@1 864 * return modifiers together with any implicit modififiers for that symbol.
duke@1 865 * Warning: we can't use flags() here since this method
duke@1 866 * is called during class enter, when flags() would cause a premature
duke@1 867 * completion.
duke@1 868 * @param pos Position to be used for error reporting.
duke@1 869 * @param flags The set of modifiers given in a definition.
duke@1 870 * @param sym The defined symbol.
duke@1 871 */
duke@1 872 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 873 long mask;
duke@1 874 long implicit = 0;
duke@1 875 switch (sym.kind) {
duke@1 876 case VAR:
duke@1 877 if (sym.owner.kind != TYP)
duke@1 878 mask = LocalVarFlags;
duke@1 879 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 880 mask = implicit = InterfaceVarFlags;
duke@1 881 else
duke@1 882 mask = VarFlags;
duke@1 883 break;
duke@1 884 case MTH:
duke@1 885 if (sym.name == names.init) {
duke@1 886 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 887 // enum constructors cannot be declared public or
duke@1 888 // protected and must be implicitly or explicitly
duke@1 889 // private
duke@1 890 implicit = PRIVATE;
duke@1 891 mask = PRIVATE;
duke@1 892 } else
duke@1 893 mask = ConstructorFlags;
duke@1 894 } else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 895 mask = implicit = InterfaceMethodFlags;
duke@1 896 else {
duke@1 897 mask = MethodFlags;
duke@1 898 }
duke@1 899 // Imply STRICTFP if owner has STRICTFP set.
duke@1 900 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 901 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 902 break;
duke@1 903 case TYP:
duke@1 904 if (sym.isLocal()) {
duke@1 905 mask = LocalClassFlags;
jjg@113 906 if (sym.name.isEmpty()) { // Anonymous class
duke@1 907 // Anonymous classes in static methods are themselves static;
duke@1 908 // that's why we admit STATIC here.
duke@1 909 mask |= STATIC;
duke@1 910 // JLS: Anonymous classes are final.
duke@1 911 implicit |= FINAL;
duke@1 912 }
duke@1 913 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 914 (flags & ENUM) != 0)
duke@1 915 log.error(pos, "enums.must.be.static");
duke@1 916 } else if (sym.owner.kind == TYP) {
duke@1 917 mask = MemberClassFlags;
duke@1 918 if (sym.owner.owner.kind == PCK ||
duke@1 919 (sym.owner.flags_field & STATIC) != 0)
duke@1 920 mask |= STATIC;
duke@1 921 else if ((flags & ENUM) != 0)
duke@1 922 log.error(pos, "enums.must.be.static");
duke@1 923 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 924 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 925 } else {
duke@1 926 mask = ClassFlags;
duke@1 927 }
duke@1 928 // Interfaces are always ABSTRACT
duke@1 929 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 930
duke@1 931 if ((flags & ENUM) != 0) {
duke@1 932 // enums can't be declared abstract or final
duke@1 933 mask &= ~(ABSTRACT | FINAL);
duke@1 934 implicit |= implicitEnumFinalFlag(tree);
duke@1 935 }
duke@1 936 // Imply STRICTFP if owner has STRICTFP set.
duke@1 937 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 938 break;
duke@1 939 default:
duke@1 940 throw new AssertionError();
duke@1 941 }
duke@1 942 long illegal = flags & StandardFlags & ~mask;
duke@1 943 if (illegal != 0) {
duke@1 944 if ((illegal & INTERFACE) != 0) {
duke@1 945 log.error(pos, "intf.not.allowed.here");
duke@1 946 mask |= INTERFACE;
duke@1 947 }
duke@1 948 else {
duke@1 949 log.error(pos,
mcimadamore@80 950 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 951 }
duke@1 952 }
duke@1 953 else if ((sym.kind == TYP ||
duke@1 954 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 955 // in the presence of inner classes. Should it be deleted here?
duke@1 956 checkDisjoint(pos, flags,
duke@1 957 ABSTRACT,
duke@1 958 PRIVATE | STATIC))
duke@1 959 &&
duke@1 960 checkDisjoint(pos, flags,
duke@1 961 ABSTRACT | INTERFACE,
duke@1 962 FINAL | NATIVE | SYNCHRONIZED)
duke@1 963 &&
duke@1 964 checkDisjoint(pos, flags,
duke@1 965 PUBLIC,
duke@1 966 PRIVATE | PROTECTED)
duke@1 967 &&
duke@1 968 checkDisjoint(pos, flags,
duke@1 969 PRIVATE,
duke@1 970 PUBLIC | PROTECTED)
duke@1 971 &&
duke@1 972 checkDisjoint(pos, flags,
duke@1 973 FINAL,
duke@1 974 VOLATILE)
duke@1 975 &&
duke@1 976 (sym.kind == TYP ||
duke@1 977 checkDisjoint(pos, flags,
duke@1 978 ABSTRACT | NATIVE,
duke@1 979 STRICTFP))) {
duke@1 980 // skip
duke@1 981 }
duke@1 982 return flags & (mask | ~StandardFlags) | implicit;
duke@1 983 }
duke@1 984
duke@1 985
duke@1 986 /** Determine if this enum should be implicitly final.
duke@1 987 *
duke@1 988 * If the enum has no specialized enum contants, it is final.
duke@1 989 *
duke@1 990 * If the enum does have specialized enum contants, it is
duke@1 991 * <i>not</i> final.
duke@1 992 */
duke@1 993 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 994 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 995 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 996 boolean specialized;
duke@1 997 SpecialTreeVisitor() {
duke@1 998 this.specialized = false;
duke@1 999 };
duke@1 1000
jjg@398 1001 @Override
duke@1 1002 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1003
jjg@398 1004 @Override
duke@1 1005 public void visitVarDef(JCVariableDecl tree) {
duke@1 1006 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1007 if (tree.init instanceof JCNewClass &&
duke@1 1008 ((JCNewClass) tree.init).def != null) {
duke@1 1009 specialized = true;
duke@1 1010 }
duke@1 1011 }
duke@1 1012 }
duke@1 1013 }
duke@1 1014
duke@1 1015 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1016 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1017 for (JCTree defs: cdef.defs) {
duke@1 1018 defs.accept(sts);
duke@1 1019 if (sts.specialized) return 0;
duke@1 1020 }
duke@1 1021 return FINAL;
duke@1 1022 }
duke@1 1023
duke@1 1024 /* *************************************************************************
duke@1 1025 * Type Validation
duke@1 1026 **************************************************************************/
duke@1 1027
duke@1 1028 /** Validate a type expression. That is,
duke@1 1029 * check that all type arguments of a parametric type are within
duke@1 1030 * their bounds. This must be done in a second phase after type attributon
duke@1 1031 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1032 *
duke@1 1033 * class B<A extends C> { ... }
duke@1 1034 * class C extends B<C> { ... }
duke@1 1035 *
duke@1 1036 * and we can't make sure that the bound is already attributed because
duke@1 1037 * of possible cycles.
mcimadamore@638 1038 *
mcimadamore@638 1039 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1040 * and reporting any completion failures.
duke@1 1041 */
mcimadamore@122 1042 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1043 validate(tree, env, true);
duke@1 1044 }
mcimadamore@638 1045 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1046 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1047 }
duke@1 1048
duke@1 1049 /** Visitor method: Validate a list of type expressions.
duke@1 1050 */
mcimadamore@122 1051 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1052 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1053 validate(l.head, env);
duke@1 1054 }
duke@1 1055
duke@1 1056 /** A visitor class for type validation.
duke@1 1057 */
duke@1 1058 class Validator extends JCTree.Visitor {
duke@1 1059
mcimadamore@638 1060 boolean isOuter;
mcimadamore@638 1061 Env<AttrContext> env;
mcimadamore@638 1062
mcimadamore@638 1063 Validator(Env<AttrContext> env) {
mcimadamore@638 1064 this.env = env;
mcimadamore@638 1065 }
mcimadamore@638 1066
jjg@398 1067 @Override
duke@1 1068 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1069 tree.elemtype.accept(this);
duke@1 1070 }
duke@1 1071
jjg@398 1072 @Override
duke@1 1073 public void visitTypeApply(JCTypeApply tree) {
duke@1 1074 if (tree.type.tag == CLASS) {
duke@1 1075 List<JCExpression> args = tree.arguments;
mcimadamore@158 1076 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1077
mcimadamore@821 1078 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1079 if (incompatibleArg != null) {
mcimadamore@821 1080 for (JCTree arg : tree.arguments) {
mcimadamore@821 1081 if (arg.type == incompatibleArg) {
mcimadamore@829 1082 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1083 }
mcimadamore@829 1084 forms = forms.tail;
mcimadamore@829 1085 }
mcimadamore@829 1086 }
mcimadamore@829 1087
mcimadamore@829 1088 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1089
mcimadamore@638 1090 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1091
duke@1 1092 // For matching pairs of actual argument types `a' and
duke@1 1093 // formal type parameters with declared bound `b' ...
duke@1 1094 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1095 validateTree(args.head,
mcimadamore@638 1096 !(isOuter && is_java_lang_Class),
mcimadamore@638 1097 false);
duke@1 1098 args = args.tail;
duke@1 1099 forms = forms.tail;
duke@1 1100 }
duke@1 1101
duke@1 1102 // Check that this type is either fully parameterized, or
duke@1 1103 // not parameterized at all.
duke@1 1104 if (tree.type.getEnclosingType().isRaw())
duke@1 1105 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1106 if (tree.clazz.hasTag(SELECT))
duke@1 1107 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1108 }
duke@1 1109 }
duke@1 1110
jjg@398 1111 @Override
duke@1 1112 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1113 validateTrees(tree.bounds, true, isOuter);
duke@1 1114 checkClassBounds(tree.pos(), tree.type);
duke@1 1115 }
duke@1 1116
duke@1 1117 @Override
duke@1 1118 public void visitWildcard(JCWildcard tree) {
duke@1 1119 if (tree.inner != null)
mcimadamore@638 1120 validateTree(tree.inner, true, isOuter);
duke@1 1121 }
duke@1 1122
jjg@398 1123 @Override
duke@1 1124 public void visitSelect(JCFieldAccess tree) {
duke@1 1125 if (tree.type.tag == CLASS) {
duke@1 1126 visitSelectInternal(tree);
duke@1 1127
duke@1 1128 // Check that this type is either fully parameterized, or
duke@1 1129 // not parameterized at all.
duke@1 1130 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1131 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1132 }
duke@1 1133 }
mcimadamore@852 1134
duke@1 1135 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1136 if (tree.type.tsym.isStatic() &&
duke@1 1137 tree.selected.type.isParameterized()) {
duke@1 1138 // The enclosing type is not a class, so we are
duke@1 1139 // looking at a static member type. However, the
duke@1 1140 // qualifying expression is parameterized.
duke@1 1141 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1142 } else {
duke@1 1143 // otherwise validate the rest of the expression
mcimadamore@122 1144 tree.selected.accept(this);
duke@1 1145 }
duke@1 1146 }
duke@1 1147
duke@1 1148 /** Default visitor method: do nothing.
duke@1 1149 */
jjg@398 1150 @Override
duke@1 1151 public void visitTree(JCTree tree) {
duke@1 1152 }
mcimadamore@122 1153
mcimadamore@638 1154 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1155 try {
mcimadamore@638 1156 if (tree != null) {
mcimadamore@638 1157 this.isOuter = isOuter;
mcimadamore@638 1158 tree.accept(this);
mcimadamore@638 1159 if (checkRaw)
mcimadamore@638 1160 checkRaw(tree, env);
mcimadamore@638 1161 }
mcimadamore@638 1162 } catch (CompletionFailure ex) {
mcimadamore@638 1163 completionError(tree.pos(), ex);
mcimadamore@638 1164 }
mcimadamore@638 1165 }
mcimadamore@638 1166
mcimadamore@638 1167 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1168 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1169 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1170 }
mcimadamore@638 1171
mcimadamore@638 1172 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1173 if (lint.isEnabled(LintCategory.RAW) &&
mcimadamore@638 1174 tree.type.tag == CLASS &&
mcimadamore@638 1175 !TreeInfo.isDiamond(tree) &&
mcimadamore@1103 1176 !withinAnonConstr(env) &&
mcimadamore@638 1177 tree.type.isRaw()) {
mcimadamore@795 1178 log.warning(LintCategory.RAW,
mcimadamore@638 1179 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1180 }
mcimadamore@638 1181 }
mcimadamore@1103 1182
mcimadamore@1103 1183 boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1184 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1185 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1186 }
duke@1 1187 }
duke@1 1188
duke@1 1189 /* *************************************************************************
duke@1 1190 * Exception checking
duke@1 1191 **************************************************************************/
duke@1 1192
duke@1 1193 /* The following methods treat classes as sets that contain
duke@1 1194 * the class itself and all their subclasses
duke@1 1195 */
duke@1 1196
duke@1 1197 /** Is given type a subtype of some of the types in given list?
duke@1 1198 */
duke@1 1199 boolean subset(Type t, List<Type> ts) {
duke@1 1200 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1201 if (types.isSubtype(t, l.head)) return true;
duke@1 1202 return false;
duke@1 1203 }
duke@1 1204
duke@1 1205 /** Is given type a subtype or supertype of
duke@1 1206 * some of the types in given list?
duke@1 1207 */
duke@1 1208 boolean intersects(Type t, List<Type> ts) {
duke@1 1209 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1210 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1211 return false;
duke@1 1212 }
duke@1 1213
duke@1 1214 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1215 * in the list.
duke@1 1216 */
duke@1 1217 List<Type> incl(Type t, List<Type> ts) {
duke@1 1218 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1219 }
duke@1 1220
duke@1 1221 /** Remove type set from type set list.
duke@1 1222 */
duke@1 1223 List<Type> excl(Type t, List<Type> ts) {
duke@1 1224 if (ts.isEmpty()) {
duke@1 1225 return ts;
duke@1 1226 } else {
duke@1 1227 List<Type> ts1 = excl(t, ts.tail);
duke@1 1228 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1229 else if (ts1 == ts.tail) return ts;
duke@1 1230 else return ts1.prepend(ts.head);
duke@1 1231 }
duke@1 1232 }
duke@1 1233
duke@1 1234 /** Form the union of two type set lists.
duke@1 1235 */
duke@1 1236 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1237 List<Type> ts = ts1;
duke@1 1238 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1239 ts = incl(l.head, ts);
duke@1 1240 return ts;
duke@1 1241 }
duke@1 1242
duke@1 1243 /** Form the difference of two type lists.
duke@1 1244 */
duke@1 1245 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1246 List<Type> ts = ts1;
duke@1 1247 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1248 ts = excl(l.head, ts);
duke@1 1249 return ts;
duke@1 1250 }
duke@1 1251
duke@1 1252 /** Form the intersection of two type lists.
duke@1 1253 */
duke@1 1254 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1255 List<Type> ts = List.nil();
duke@1 1256 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1257 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1258 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1259 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1260 return ts;
duke@1 1261 }
duke@1 1262
duke@1 1263 /** Is exc an exception symbol that need not be declared?
duke@1 1264 */
duke@1 1265 boolean isUnchecked(ClassSymbol exc) {
duke@1 1266 return
duke@1 1267 exc.kind == ERR ||
duke@1 1268 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1269 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1270 }
duke@1 1271
duke@1 1272 /** Is exc an exception type that need not be declared?
duke@1 1273 */
duke@1 1274 boolean isUnchecked(Type exc) {
duke@1 1275 return
duke@1 1276 (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
duke@1 1277 (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
duke@1 1278 exc.tag == BOT;
duke@1 1279 }
duke@1 1280
duke@1 1281 /** Same, but handling completion failures.
duke@1 1282 */
duke@1 1283 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1284 try {
duke@1 1285 return isUnchecked(exc);
duke@1 1286 } catch (CompletionFailure ex) {
duke@1 1287 completionError(pos, ex);
duke@1 1288 return true;
duke@1 1289 }
duke@1 1290 }
duke@1 1291
duke@1 1292 /** Is exc handled by given exception list?
duke@1 1293 */
duke@1 1294 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1295 return isUnchecked(exc) || subset(exc, handled);
duke@1 1296 }
duke@1 1297
duke@1 1298 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1299 * @param thrown The list of thrown exceptions.
duke@1 1300 * @param handled The list of handled exceptions.
duke@1 1301 */
mcimadamore@362 1302 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1303 List<Type> unhandled = List.nil();
duke@1 1304 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1305 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1306 return unhandled;
duke@1 1307 }
duke@1 1308
duke@1 1309 /* *************************************************************************
duke@1 1310 * Overriding/Implementation checking
duke@1 1311 **************************************************************************/
duke@1 1312
duke@1 1313 /** The level of access protection given by a flag set,
duke@1 1314 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1315 */
duke@1 1316 static int protection(long flags) {
duke@1 1317 switch ((short)(flags & AccessFlags)) {
duke@1 1318 case PRIVATE: return 3;
duke@1 1319 case PROTECTED: return 1;
duke@1 1320 default:
duke@1 1321 case PUBLIC: return 0;
duke@1 1322 case 0: return 2;
duke@1 1323 }
duke@1 1324 }
duke@1 1325
duke@1 1326 /** A customized "cannot override" error message.
duke@1 1327 * @param m The overriding method.
duke@1 1328 * @param other The overridden method.
duke@1 1329 * @return An internationalized string.
duke@1 1330 */
mcimadamore@89 1331 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1332 String key;
duke@1 1333 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1334 key = "cant.override";
duke@1 1335 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1336 key = "cant.implement";
duke@1 1337 else
duke@1 1338 key = "clashes.with";
mcimadamore@89 1339 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1340 }
duke@1 1341
duke@1 1342 /** A customized "override" warning message.
duke@1 1343 * @param m The overriding method.
duke@1 1344 * @param other The overridden method.
duke@1 1345 * @return An internationalized string.
duke@1 1346 */
mcimadamore@89 1347 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1348 String key;
duke@1 1349 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1350 key = "unchecked.override";
duke@1 1351 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1352 key = "unchecked.implement";
duke@1 1353 else
duke@1 1354 key = "unchecked.clash.with";
mcimadamore@89 1355 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1356 }
duke@1 1357
duke@1 1358 /** A customized "override" warning message.
duke@1 1359 * @param m The overriding method.
duke@1 1360 * @param other The overridden method.
duke@1 1361 * @return An internationalized string.
duke@1 1362 */
mcimadamore@89 1363 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1364 String key;
duke@1 1365 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1366 key = "varargs.override";
duke@1 1367 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1368 key = "varargs.implement";
duke@1 1369 else
duke@1 1370 key = "varargs.clash.with";
mcimadamore@89 1371 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1372 }
duke@1 1373
duke@1 1374 /** Check that this method conforms with overridden method 'other'.
duke@1 1375 * where `origin' is the class where checking started.
duke@1 1376 * Complications:
duke@1 1377 * (1) Do not check overriding of synthetic methods
duke@1 1378 * (reason: they might be final).
duke@1 1379 * todo: check whether this is still necessary.
duke@1 1380 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1381 * than the method it implements. Augment the proxy methods with the
duke@1 1382 * undeclared exceptions in this case.
duke@1 1383 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1384 * has a result type
duke@1 1385 * extended by the result type of the method it implements.
duke@1 1386 * Change the proxies result type to the smaller type in this case.
duke@1 1387 *
duke@1 1388 * @param tree The tree from which positions
duke@1 1389 * are extracted for errors.
duke@1 1390 * @param m The overriding method.
duke@1 1391 * @param other The overridden method.
duke@1 1392 * @param origin The class of which the overriding method
duke@1 1393 * is a member.
duke@1 1394 */
duke@1 1395 void checkOverride(JCTree tree,
duke@1 1396 MethodSymbol m,
duke@1 1397 MethodSymbol other,
duke@1 1398 ClassSymbol origin) {
duke@1 1399 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1400 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1401 return;
duke@1 1402 }
duke@1 1403
duke@1 1404 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1405 if ((m.flags() & STATIC) != 0 &&
duke@1 1406 (other.flags() & STATIC) == 0) {
duke@1 1407 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1408 cannotOverride(m, other));
duke@1 1409 return;
duke@1 1410 }
duke@1 1411
duke@1 1412 // Error if instance method overrides static or final
duke@1 1413 // method (JLS 8.4.6.1).
duke@1 1414 if ((other.flags() & FINAL) != 0 ||
duke@1 1415 (m.flags() & STATIC) == 0 &&
duke@1 1416 (other.flags() & STATIC) != 0) {
duke@1 1417 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1418 cannotOverride(m, other),
mcimadamore@80 1419 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1420 return;
duke@1 1421 }
duke@1 1422
duke@1 1423 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1424 // handled in validateAnnotationMethod
duke@1 1425 return;
duke@1 1426 }
duke@1 1427
duke@1 1428 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1429 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1430 protection(m.flags()) > protection(other.flags())) {
duke@1 1431 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1432 cannotOverride(m, other),
mcimadamore@80 1433 other.flags() == 0 ?
mcimadamore@80 1434 Flag.PACKAGE :
mcimadamore@80 1435 asFlagSet(other.flags() & AccessFlags));
duke@1 1436 return;
duke@1 1437 }
duke@1 1438
duke@1 1439 Type mt = types.memberType(origin.type, m);
duke@1 1440 Type ot = types.memberType(origin.type, other);
duke@1 1441 // Error if overriding result type is different
duke@1 1442 // (or, in the case of generics mode, not a subtype) of
duke@1 1443 // overridden result type. We have to rename any type parameters
duke@1 1444 // before comparing types.
duke@1 1445 List<Type> mtvars = mt.getTypeArguments();
duke@1 1446 List<Type> otvars = ot.getTypeArguments();
duke@1 1447 Type mtres = mt.getReturnType();
duke@1 1448 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1449
mcimadamore@795 1450 overrideWarner.clear();
duke@1 1451 boolean resultTypesOK =
tbell@202 1452 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1453 if (!resultTypesOK) {
jjg@398 1454 if (!allowCovariantReturns &&
duke@1 1455 m.owner != origin &&
duke@1 1456 m.owner.isSubClass(other.owner, types)) {
duke@1 1457 // allow limited interoperability with covariant returns
duke@1 1458 } else {
mcimadamore@362 1459 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1460 "override.incompatible.ret",
mcimadamore@362 1461 cannotOverride(m, other),
duke@1 1462 mtres, otres);
duke@1 1463 return;
duke@1 1464 }
mcimadamore@795 1465 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1466 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1467 "override.unchecked.ret",
mcimadamore@362 1468 uncheckedOverrides(m, other),
mcimadamore@362 1469 mtres, otres);
duke@1 1470 }
duke@1 1471
duke@1 1472 // Error if overriding method throws an exception not reported
duke@1 1473 // by overridden method.
duke@1 1474 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1475 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1476 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1477 if (unhandledErased.nonEmpty()) {
duke@1 1478 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1479 "override.meth.doesnt.throw",
duke@1 1480 cannotOverride(m, other),
mcimadamore@362 1481 unhandledUnerased.head);
mcimadamore@362 1482 return;
mcimadamore@362 1483 }
mcimadamore@362 1484 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1485 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1486 "override.unchecked.thrown",
mcimadamore@362 1487 cannotOverride(m, other),
mcimadamore@362 1488 unhandledUnerased.head);
duke@1 1489 return;
duke@1 1490 }
duke@1 1491
duke@1 1492 // Optional warning if varargs don't agree
duke@1 1493 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1494 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1495 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1496 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1497 ? "override.varargs.missing"
duke@1 1498 : "override.varargs.extra",
duke@1 1499 varargsOverrides(m, other));
duke@1 1500 }
duke@1 1501
duke@1 1502 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1503 if ((other.flags() & BRIDGE) != 0) {
duke@1 1504 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1505 uncheckedOverrides(m, other));
duke@1 1506 }
duke@1 1507
duke@1 1508 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1509 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1510 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1511 }
duke@1 1512 }
duke@1 1513 // where
duke@1 1514 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1515 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1516 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1517 // because in that case, we will rediscover the issue when examining the method
duke@1 1518 // in the supertype.
duke@1 1519 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1520 // address the issue is when the method is the supertype implemementation: any other
duke@1 1521 // case, we will have dealt with when examining the supertype classes
duke@1 1522 ClassSymbol mc = m.enclClass();
duke@1 1523 Type st = types.supertype(origin.type);
duke@1 1524 if (st.tag != CLASS)
duke@1 1525 return true;
duke@1 1526 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1527
duke@1 1528 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1529 List<Type> intfs = types.interfaces(origin.type);
duke@1 1530 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1531 }
duke@1 1532 else
duke@1 1533 return (stimpl != m);
duke@1 1534 }
duke@1 1535
duke@1 1536
duke@1 1537 // used to check if there were any unchecked conversions
duke@1 1538 Warner overrideWarner = new Warner();
duke@1 1539
duke@1 1540 /** Check that a class does not inherit two concrete methods
duke@1 1541 * with the same signature.
duke@1 1542 * @param pos Position to be used for error reporting.
duke@1 1543 * @param site The class type to be checked.
duke@1 1544 */
duke@1 1545 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1546 Type sup = types.supertype(site);
duke@1 1547 if (sup.tag != CLASS) return;
duke@1 1548
duke@1 1549 for (Type t1 = sup;
duke@1 1550 t1.tsym.type.isParameterized();
duke@1 1551 t1 = types.supertype(t1)) {
duke@1 1552 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1553 e1 != null;
duke@1 1554 e1 = e1.sibling) {
duke@1 1555 Symbol s1 = e1.sym;
duke@1 1556 if (s1.kind != MTH ||
duke@1 1557 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1558 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1559 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1560 types,
duke@1 1561 true) != s1)
duke@1 1562 continue;
duke@1 1563 Type st1 = types.memberType(t1, s1);
duke@1 1564 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1565 if (st1 == s1.type) continue;
duke@1 1566
duke@1 1567 for (Type t2 = sup;
duke@1 1568 t2.tag == CLASS;
duke@1 1569 t2 = types.supertype(t2)) {
mcimadamore@24 1570 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1571 e2.scope != null;
duke@1 1572 e2 = e2.next()) {
duke@1 1573 Symbol s2 = e2.sym;
duke@1 1574 if (s2 == s1 ||
duke@1 1575 s2.kind != MTH ||
duke@1 1576 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1577 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1578 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1579 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1580 types,
duke@1 1581 true) != s2)
duke@1 1582 continue;
duke@1 1583 Type st2 = types.memberType(t2, s2);
duke@1 1584 if (types.overrideEquivalent(st1, st2))
duke@1 1585 log.error(pos, "concrete.inheritance.conflict",
duke@1 1586 s1, t1, s2, t2, sup);
duke@1 1587 }
duke@1 1588 }
duke@1 1589 }
duke@1 1590 }
duke@1 1591 }
duke@1 1592
duke@1 1593 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1594 * method with same name and arguments but incompatible return types.
duke@1 1595 * @param pos Position to be used for error reporting.
duke@1 1596 * @param t1 The first argument type.
duke@1 1597 * @param t2 The second argument type.
duke@1 1598 */
duke@1 1599 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1600 Type t1,
duke@1 1601 Type t2) {
duke@1 1602 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1603 types.makeCompoundType(t1, t2));
duke@1 1604 }
duke@1 1605
duke@1 1606 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1607 Type t1,
duke@1 1608 Type t2,
duke@1 1609 Type site) {
mcimadamore@746 1610 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1611 }
duke@1 1612
duke@1 1613 /** Return the first method which is defined with same args
duke@1 1614 * but different return types in two given interfaces, or null if none
duke@1 1615 * exists.
duke@1 1616 * @param t1 The first type.
duke@1 1617 * @param t2 The second type.
duke@1 1618 * @param site The most derived type.
duke@1 1619 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1620 */
mcimadamore@746 1621 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1622 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1623 closure(t1, interfaces1);
duke@1 1624 Map<TypeSymbol,Type> interfaces2;
duke@1 1625 if (t1 == t2)
duke@1 1626 interfaces2 = interfaces1;
duke@1 1627 else
duke@1 1628 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1629
duke@1 1630 for (Type t3 : interfaces1.values()) {
duke@1 1631 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1632 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1633 if (s != null) return s;
duke@1 1634 }
duke@1 1635 }
duke@1 1636 return null;
duke@1 1637 }
duke@1 1638
duke@1 1639 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1640 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
duke@1 1641 if (t.tag != CLASS) return;
duke@1 1642 if (typeMap.put(t.tsym, t) == null) {
duke@1 1643 closure(types.supertype(t), typeMap);
duke@1 1644 for (Type i : types.interfaces(t))
duke@1 1645 closure(i, typeMap);
duke@1 1646 }
duke@1 1647 }
duke@1 1648
duke@1 1649 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1650 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
duke@1 1651 if (t.tag != CLASS) return;
duke@1 1652 if (typesSkip.get(t.tsym) != null) return;
duke@1 1653 if (typeMap.put(t.tsym, t) == null) {
duke@1 1654 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1655 for (Type i : types.interfaces(t))
duke@1 1656 closure(i, typesSkip, typeMap);
duke@1 1657 }
duke@1 1658 }
duke@1 1659
duke@1 1660 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1661 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1662 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1663 Symbol s1 = e1.sym;
duke@1 1664 Type st1 = null;
duke@1 1665 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
duke@1 1666 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1667 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1668 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1669 Symbol s2 = e2.sym;
duke@1 1670 if (s1 == s2) continue;
duke@1 1671 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
duke@1 1672 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1673 Type st2 = types.memberType(t2, s2);
duke@1 1674 if (types.overrideEquivalent(st1, st2)) {
duke@1 1675 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1676 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1677 Type rt1 = st1.getReturnType();
duke@1 1678 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1679 boolean compat =
duke@1 1680 types.isSameType(rt1, rt2) ||
duke@1 1681 rt1.tag >= CLASS && rt2.tag >= CLASS &&
duke@1 1682 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
mcimadamore@59 1683 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
mcimadamore@59 1684 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1685 if (!compat) {
mcimadamore@746 1686 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1687 t1, t2, s2.name +
mcimadamore@746 1688 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1689 return s2;
mcimadamore@746 1690 }
mcimadamore@889 1691 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1692 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1693 log.error(pos,
mcimadamore@746 1694 "name.clash.same.erasure.no.override",
mcimadamore@746 1695 s1, s1.location(),
mcimadamore@746 1696 s2, s2.location());
mcimadamore@746 1697 return s2;
duke@1 1698 }
duke@1 1699 }
duke@1 1700 }
duke@1 1701 return null;
duke@1 1702 }
mcimadamore@59 1703 //WHERE
mcimadamore@59 1704 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1705 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1706 Type st1 = types.memberType(site, s1);
mcimadamore@59 1707 Type st2 = types.memberType(site, s2);
mcimadamore@59 1708 closure(site, supertypes);
mcimadamore@59 1709 for (Type t : supertypes.values()) {
mcimadamore@59 1710 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1711 Symbol s3 = e.sym;
mcimadamore@59 1712 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1713 Type st3 = types.memberType(site,s3);
mcimadamore@59 1714 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1715 if (s3.owner == site.tsym) {
mcimadamore@59 1716 return true;
mcimadamore@59 1717 }
mcimadamore@59 1718 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1719 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1720 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1721 Type rt1 = st1.getReturnType();
mcimadamore@59 1722 Type rt2 = st2.getReturnType();
mcimadamore@59 1723 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1724 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1725 boolean compat =
mcimadamore@59 1726 rt13.tag >= CLASS && rt23.tag >= CLASS &&
mcimadamore@59 1727 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
mcimadamore@59 1728 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
mcimadamore@59 1729 if (compat)
mcimadamore@59 1730 return true;
mcimadamore@59 1731 }
mcimadamore@59 1732 }
mcimadamore@59 1733 }
mcimadamore@59 1734 return false;
mcimadamore@59 1735 }
duke@1 1736
duke@1 1737 /** Check that a given method conforms with any method it overrides.
duke@1 1738 * @param tree The tree from which positions are extracted
duke@1 1739 * for errors.
duke@1 1740 * @param m The overriding method.
duke@1 1741 */
duke@1 1742 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1743 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1744 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1745 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1746 log.error(tree.pos(), "enum.no.finalize");
duke@1 1747 return;
duke@1 1748 }
mcimadamore@746 1749 for (Type t = origin.type; t.tag == CLASS;
duke@1 1750 t = types.supertype(t)) {
mcimadamore@746 1751 if (t != origin.type) {
mcimadamore@746 1752 checkOverride(tree, t, origin, m);
mcimadamore@746 1753 }
mcimadamore@746 1754 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1755 checkOverride(tree, t2, origin, m);
duke@1 1756 }
duke@1 1757 }
duke@1 1758 }
duke@1 1759
mcimadamore@746 1760 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1761 TypeSymbol c = site.tsym;
mcimadamore@746 1762 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1763 while (e.scope != null) {
mcimadamore@746 1764 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1765 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1766 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1767 }
mcimadamore@746 1768 }
mcimadamore@746 1769 e = e.next();
mcimadamore@746 1770 }
mcimadamore@746 1771 }
mcimadamore@746 1772
mcimadamore@746 1773 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 1774 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 1775 return (cf.accepts(s1) &&
mcimadamore@858 1776 cf.accepts(s2) &&
mcimadamore@858 1777 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 1778 }
mcimadamore@746 1779
mcimadamore@746 1780
duke@1 1781 /** Check that all abstract members of given class have definitions.
duke@1 1782 * @param pos Position to be used for error reporting.
duke@1 1783 * @param c The class.
duke@1 1784 */
duke@1 1785 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1786 try {
duke@1 1787 MethodSymbol undef = firstUndef(c, c);
duke@1 1788 if (undef != null) {
duke@1 1789 if ((c.flags() & ENUM) != 0 &&
duke@1 1790 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 1791 (c.flags() & FINAL) == 0) {
duke@1 1792 // add the ABSTRACT flag to an enum
duke@1 1793 c.flags_field |= ABSTRACT;
duke@1 1794 } else {
duke@1 1795 MethodSymbol undef1 =
duke@1 1796 new MethodSymbol(undef.flags(), undef.name,
duke@1 1797 types.memberType(c.type, undef), undef.owner);
duke@1 1798 log.error(pos, "does.not.override.abstract",
duke@1 1799 c, undef1, undef1.location());
duke@1 1800 }
duke@1 1801 }
duke@1 1802 } catch (CompletionFailure ex) {
duke@1 1803 completionError(pos, ex);
duke@1 1804 }
duke@1 1805 }
duke@1 1806 //where
duke@1 1807 /** Return first abstract member of class `c' that is not defined
duke@1 1808 * in `impl', null if there is none.
duke@1 1809 */
duke@1 1810 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 1811 MethodSymbol undef = null;
duke@1 1812 // Do not bother to search in classes that are not abstract,
duke@1 1813 // since they cannot have abstract members.
duke@1 1814 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 1815 Scope s = c.members();
duke@1 1816 for (Scope.Entry e = s.elems;
duke@1 1817 undef == null && e != null;
duke@1 1818 e = e.sibling) {
duke@1 1819 if (e.sym.kind == MTH &&
duke@1 1820 (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
duke@1 1821 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 1822 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
duke@1 1823 if (implmeth == null || implmeth == absmeth)
duke@1 1824 undef = absmeth;
duke@1 1825 }
duke@1 1826 }
duke@1 1827 if (undef == null) {
duke@1 1828 Type st = types.supertype(c.type);
duke@1 1829 if (st.tag == CLASS)
duke@1 1830 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 1831 }
duke@1 1832 for (List<Type> l = types.interfaces(c.type);
duke@1 1833 undef == null && l.nonEmpty();
duke@1 1834 l = l.tail) {
duke@1 1835 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 1836 }
duke@1 1837 }
duke@1 1838 return undef;
duke@1 1839 }
duke@1 1840
mcimadamore@690 1841 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 1842 CycleChecker cc = new CycleChecker();
mcimadamore@690 1843 cc.scan(tree);
mcimadamore@690 1844 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 1845 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 1846 }
mcimadamore@690 1847 }
mcimadamore@690 1848
mcimadamore@690 1849 class CycleChecker extends TreeScanner {
mcimadamore@690 1850
mcimadamore@690 1851 List<Symbol> seenClasses = List.nil();
mcimadamore@690 1852 boolean errorFound = false;
mcimadamore@690 1853 boolean partialCheck = false;
mcimadamore@690 1854
mcimadamore@690 1855 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 1856 if (sym != null && sym.kind == TYP) {
mcimadamore@690 1857 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 1858 if (classEnv != null) {
mcimadamore@690 1859 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 1860 try {
mcimadamore@690 1861 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 1862 scan(classEnv.tree);
mcimadamore@690 1863 }
mcimadamore@690 1864 finally {
mcimadamore@690 1865 log.useSource(prevSource.getFile());
mcimadamore@690 1866 }
mcimadamore@690 1867 } else if (sym.kind == TYP) {
mcimadamore@690 1868 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 1869 }
mcimadamore@690 1870 } else {
mcimadamore@690 1871 //not completed yet
mcimadamore@690 1872 partialCheck = true;
mcimadamore@690 1873 }
mcimadamore@690 1874 }
mcimadamore@690 1875
mcimadamore@690 1876 @Override
mcimadamore@690 1877 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 1878 super.visitSelect(tree);
mcimadamore@690 1879 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 1880 }
mcimadamore@690 1881
mcimadamore@690 1882 @Override
mcimadamore@690 1883 public void visitIdent(JCIdent tree) {
mcimadamore@690 1884 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 1885 }
mcimadamore@690 1886
mcimadamore@690 1887 @Override
mcimadamore@690 1888 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 1889 scan(tree.clazz);
mcimadamore@690 1890 }
mcimadamore@690 1891
mcimadamore@690 1892 @Override
mcimadamore@690 1893 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 1894 scan(tree.elemtype);
mcimadamore@690 1895 }
mcimadamore@690 1896
mcimadamore@690 1897 @Override
mcimadamore@690 1898 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 1899 List<JCTree> supertypes = List.nil();
mcimadamore@690 1900 if (tree.getExtendsClause() != null) {
mcimadamore@690 1901 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 1902 }
mcimadamore@690 1903 if (tree.getImplementsClause() != null) {
mcimadamore@690 1904 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 1905 supertypes = supertypes.prepend(intf);
mcimadamore@690 1906 }
mcimadamore@690 1907 }
mcimadamore@690 1908 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 1909 }
mcimadamore@690 1910
mcimadamore@690 1911 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 1912 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 1913 return;
mcimadamore@690 1914 if (seenClasses.contains(c)) {
mcimadamore@690 1915 errorFound = true;
mcimadamore@690 1916 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 1917 } else if (!c.type.isErroneous()) {
mcimadamore@690 1918 try {
mcimadamore@690 1919 seenClasses = seenClasses.prepend(c);
mcimadamore@690 1920 if (c.type.tag == CLASS) {
mcimadamore@690 1921 if (supertypes.nonEmpty()) {
mcimadamore@690 1922 scan(supertypes);
mcimadamore@690 1923 }
mcimadamore@690 1924 else {
mcimadamore@690 1925 ClassType ct = (ClassType)c.type;
mcimadamore@690 1926 if (ct.supertype_field == null ||
mcimadamore@690 1927 ct.interfaces_field == null) {
mcimadamore@690 1928 //not completed yet
mcimadamore@690 1929 partialCheck = true;
mcimadamore@690 1930 return;
mcimadamore@690 1931 }
mcimadamore@690 1932 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 1933 for (Type intf : ct.interfaces_field) {
mcimadamore@690 1934 checkSymbol(pos, intf.tsym);
mcimadamore@690 1935 }
mcimadamore@690 1936 }
mcimadamore@690 1937 if (c.owner.kind == TYP) {
mcimadamore@690 1938 checkSymbol(pos, c.owner);
mcimadamore@690 1939 }
mcimadamore@690 1940 }
mcimadamore@690 1941 } finally {
mcimadamore@690 1942 seenClasses = seenClasses.tail;
mcimadamore@690 1943 }
mcimadamore@690 1944 }
mcimadamore@690 1945 }
mcimadamore@690 1946 }
mcimadamore@690 1947
duke@1 1948 /** Check for cyclic references. Issue an error if the
duke@1 1949 * symbol of the type referred to has a LOCKED flag set.
duke@1 1950 *
duke@1 1951 * @param pos Position to be used for error reporting.
duke@1 1952 * @param t The type referred to.
duke@1 1953 */
duke@1 1954 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 1955 checkNonCyclicInternal(pos, t);
duke@1 1956 }
duke@1 1957
duke@1 1958
duke@1 1959 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 1960 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 1961 }
duke@1 1962
mcimadamore@236 1963 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 1964 final TypeVar tv;
mcimadamore@42 1965 if (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 1966 return;
duke@1 1967 if (seen.contains(t)) {
duke@1 1968 tv = (TypeVar)t;
jjg@110 1969 tv.bound = types.createErrorType(t);
duke@1 1970 log.error(pos, "cyclic.inheritance", t);
duke@1 1971 } else if (t.tag == TYPEVAR) {
duke@1 1972 tv = (TypeVar)t;
mcimadamore@236 1973 seen = seen.prepend(tv);
duke@1 1974 for (Type b : types.getBounds(tv))
duke@1 1975 checkNonCyclic1(pos, b, seen);
duke@1 1976 }
duke@1 1977 }
duke@1 1978
duke@1 1979 /** Check for cyclic references. Issue an error if the
duke@1 1980 * symbol of the type referred to has a LOCKED flag set.
duke@1 1981 *
duke@1 1982 * @param pos Position to be used for error reporting.
duke@1 1983 * @param t The type referred to.
duke@1 1984 * @returns True if the check completed on all attributed classes
duke@1 1985 */
duke@1 1986 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 1987 boolean complete = true; // was the check complete?
duke@1 1988 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 1989 Symbol c = t.tsym;
duke@1 1990 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 1991
duke@1 1992 if ((c.flags_field & LOCKED) != 0) {
duke@1 1993 noteCyclic(pos, (ClassSymbol)c);
duke@1 1994 } else if (!c.type.isErroneous()) {
duke@1 1995 try {
duke@1 1996 c.flags_field |= LOCKED;
duke@1 1997 if (c.type.tag == CLASS) {
duke@1 1998 ClassType clazz = (ClassType)c.type;
duke@1 1999 if (clazz.interfaces_field != null)
duke@1 2000 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2001 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2002 if (clazz.supertype_field != null) {
duke@1 2003 Type st = clazz.supertype_field;
duke@1 2004 if (st != null && st.tag == CLASS)
duke@1 2005 complete &= checkNonCyclicInternal(pos, st);
duke@1 2006 }
duke@1 2007 if (c.owner.kind == TYP)
duke@1 2008 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2009 }
duke@1 2010 } finally {
duke@1 2011 c.flags_field &= ~LOCKED;
duke@1 2012 }
duke@1 2013 }
duke@1 2014 if (complete)
duke@1 2015 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2016 if (complete) c.flags_field |= ACYCLIC;
duke@1 2017 return complete;
duke@1 2018 }
duke@1 2019
duke@1 2020 /** Note that we found an inheritance cycle. */
duke@1 2021 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2022 log.error(pos, "cyclic.inheritance", c);
duke@1 2023 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2024 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2025 Type st = types.supertype(c.type);
duke@1 2026 if (st.tag == CLASS)
jjg@110 2027 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2028 c.type = types.createErrorType(c, c.type);
duke@1 2029 c.flags_field |= ACYCLIC;
duke@1 2030 }
duke@1 2031
duke@1 2032 /** Check that all methods which implement some
duke@1 2033 * method conform to the method they implement.
duke@1 2034 * @param tree The class definition whose members are checked.
duke@1 2035 */
duke@1 2036 void checkImplementations(JCClassDecl tree) {
duke@1 2037 checkImplementations(tree, tree.sym);
duke@1 2038 }
duke@1 2039 //where
duke@1 2040 /** Check that all methods which implement some
duke@1 2041 * method in `ic' conform to the method they implement.
duke@1 2042 */
duke@1 2043 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
duke@1 2044 ClassSymbol origin = tree.sym;
duke@1 2045 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2046 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2047 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2048 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2049 if (e.sym.kind == MTH &&
duke@1 2050 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2051 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2052 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2053 if (implmeth != null && implmeth != absmeth &&
duke@1 2054 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2055 (origin.flags() & INTERFACE)) {
duke@1 2056 // don't check if implmeth is in a class, yet
duke@1 2057 // origin is an interface. This case arises only
duke@1 2058 // if implmeth is declared in Object. The reason is
duke@1 2059 // that interfaces really don't inherit from
duke@1 2060 // Object it's just that the compiler represents
duke@1 2061 // things that way.
duke@1 2062 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2063 }
duke@1 2064 }
duke@1 2065 }
duke@1 2066 }
duke@1 2067 }
duke@1 2068 }
duke@1 2069
duke@1 2070 /** Check that all abstract methods implemented by a class are
duke@1 2071 * mutually compatible.
duke@1 2072 * @param pos Position to be used for error reporting.
duke@1 2073 * @param c The class whose interfaces are checked.
duke@1 2074 */
duke@1 2075 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2076 List<Type> supertypes = types.interfaces(c);
duke@1 2077 Type supertype = types.supertype(c);
duke@1 2078 if (supertype.tag == CLASS &&
duke@1 2079 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2080 supertypes = supertypes.prepend(supertype);
duke@1 2081 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2082 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2083 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2084 return;
duke@1 2085 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2086 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2087 return;
duke@1 2088 }
duke@1 2089 checkCompatibleConcretes(pos, c);
duke@1 2090 }
duke@1 2091
mcimadamore@359 2092 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2093 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2094 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2095 // VM allows methods and variables with differing types
mcimadamore@359 2096 if (sym.kind == e.sym.kind &&
mcimadamore@359 2097 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2098 sym != e.sym &&
mcimadamore@359 2099 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2100 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2101 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2102 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2103 return;
mcimadamore@359 2104 }
mcimadamore@359 2105 }
mcimadamore@359 2106 }
mcimadamore@359 2107 }
mcimadamore@359 2108
mcimadamore@780 2109 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2110 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2111 *
mcimadamore@780 2112 * @param pos Position to be used for error reporting.
mcimadamore@780 2113 * @param site The class whose methods are checked.
mcimadamore@780 2114 * @param sym The method symbol to be checked.
mcimadamore@780 2115 */
mcimadamore@858 2116 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2117 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2118 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2119 for (Symbol s1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@858 2120 //...find another method m2 that is overridden (directly or indirectly)
mcimadamore@858 2121 //by method 'sym' in 'site'
mcimadamore@1015 2122 for (Symbol s2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@877 2123 if (s1 == s2 || !sym.overrides(s2, site.tsym, types, false)) continue;
mcimadamore@858 2124 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2125 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@907 2126 if (!types.isSubSignature(sym.type, types.memberType(site, s1), false) &&
mcimadamore@877 2127 types.hasSameArgs(s1.erasure(types), s2.erasure(types))) {
mcimadamore@858 2128 sym.flags_field |= CLASH;
mcimadamore@877 2129 String key = s2 == sym ?
mcimadamore@858 2130 "name.clash.same.erasure.no.override" :
mcimadamore@858 2131 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2132 log.error(pos,
mcimadamore@858 2133 key,
mcimadamore@858 2134 sym, sym.location(),
mcimadamore@877 2135 s1, s1.location(),
mcimadamore@877 2136 s2, s2.location());
mcimadamore@858 2137 return;
mcimadamore@858 2138 }
mcimadamore@780 2139 }
mcimadamore@780 2140 }
mcimadamore@780 2141 }
mcimadamore@780 2142
mcimadamore@877 2143
mcimadamore@877 2144
mcimadamore@858 2145 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2146 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2147 *
mcimadamore@858 2148 * @param pos Position to be used for error reporting.
mcimadamore@858 2149 * @param site The class whose methods are checked.
mcimadamore@858 2150 * @param sym The method symbol to be checked.
mcimadamore@780 2151 */
mcimadamore@858 2152 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2153 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2154 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2155 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2156 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2157 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@907 2158 if (!types.isSubSignature(sym.type, types.memberType(site, s), false) &&
mcimadamore@877 2159 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2160 log.error(pos,
mcimadamore@858 2161 "name.clash.same.erasure.no.hide",
mcimadamore@858 2162 sym, sym.location(),
mcimadamore@877 2163 s, s.location());
mcimadamore@858 2164 return;
mcimadamore@858 2165 }
mcimadamore@858 2166 }
mcimadamore@858 2167 }
mcimadamore@780 2168
mcimadamore@858 2169 //where
mcimadamore@858 2170 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2171
mcimadamore@858 2172 Type site;
mcimadamore@780 2173
mcimadamore@858 2174 ClashFilter(Type site) {
mcimadamore@858 2175 this.site = site;
mcimadamore@858 2176 }
mcimadamore@858 2177
mcimadamore@858 2178 boolean shouldSkip(Symbol s) {
mcimadamore@858 2179 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2180 s.owner == site.tsym;
mcimadamore@858 2181 }
mcimadamore@858 2182
mcimadamore@858 2183 public boolean accepts(Symbol s) {
mcimadamore@858 2184 return s.kind == MTH &&
mcimadamore@858 2185 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2186 !shouldSkip(s) &&
mcimadamore@858 2187 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2188 !s.isConstructor();
mcimadamore@858 2189 }
mcimadamore@858 2190 }
mcimadamore@780 2191
mcimadamore@359 2192 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2193 */
mcimadamore@359 2194 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2195 if (!sym.type.isErroneous()) {
mcimadamore@359 2196 if (warnOnSyntheticConflicts) {
mcimadamore@359 2197 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2198 }
mcimadamore@359 2199 else {
mcimadamore@359 2200 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2201 }
mcimadamore@359 2202 }
mcimadamore@359 2203 }
mcimadamore@359 2204
duke@1 2205 /** Check that class c does not implement directly or indirectly
duke@1 2206 * the same parameterized interface with two different argument lists.
duke@1 2207 * @param pos Position to be used for error reporting.
duke@1 2208 * @param type The type whose interfaces are checked.
duke@1 2209 */
duke@1 2210 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2211 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2212 }
duke@1 2213 //where
duke@1 2214 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2215 * with their class symbol as key and their type as value. Make
duke@1 2216 * sure no class is entered with two different types.
duke@1 2217 */
duke@1 2218 void checkClassBounds(DiagnosticPosition pos,
duke@1 2219 Map<TypeSymbol,Type> seensofar,
duke@1 2220 Type type) {
duke@1 2221 if (type.isErroneous()) return;
duke@1 2222 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2223 Type it = l.head;
duke@1 2224 Type oldit = seensofar.put(it.tsym, it);
duke@1 2225 if (oldit != null) {
duke@1 2226 List<Type> oldparams = oldit.allparams();
duke@1 2227 List<Type> newparams = it.allparams();
duke@1 2228 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2229 log.error(pos, "cant.inherit.diff.arg",
duke@1 2230 it.tsym, Type.toString(oldparams),
duke@1 2231 Type.toString(newparams));
duke@1 2232 }
duke@1 2233 checkClassBounds(pos, seensofar, it);
duke@1 2234 }
duke@1 2235 Type st = types.supertype(type);
duke@1 2236 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2237 }
duke@1 2238
duke@1 2239 /** Enter interface into into set.
duke@1 2240 * If it existed already, issue a "repeated interface" error.
duke@1 2241 */
duke@1 2242 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2243 if (its.contains(it))
duke@1 2244 log.error(pos, "repeated.interface");
duke@1 2245 else {
duke@1 2246 its.add(it);
duke@1 2247 }
duke@1 2248 }
duke@1 2249
duke@1 2250 /* *************************************************************************
duke@1 2251 * Check annotations
duke@1 2252 **************************************************************************/
duke@1 2253
mcimadamore@629 2254 /**
mcimadamore@634 2255 * Recursively validate annotations values
mcimadamore@629 2256 */
mcimadamore@634 2257 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2258 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2259 @Override
mcimadamore@629 2260 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2261 if (!tree.type.isErroneous()) {
jjg@1017 2262 super.visitAnnotation(tree);
jjg@1017 2263 validateAnnotation(tree);
jjg@1017 2264 }
mcimadamore@629 2265 }
mcimadamore@629 2266 }
mcimadamore@634 2267 tree.accept(new AnnotationValidator());
mcimadamore@629 2268 }
mcimadamore@629 2269
duke@1 2270 /** Annotation types are restricted to primitives, String, an
duke@1 2271 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2272 * Anything>, arrays of the preceding.
duke@1 2273 */
duke@1 2274 void validateAnnotationType(JCTree restype) {
duke@1 2275 // restype may be null if an error occurred, so don't bother validating it
duke@1 2276 if (restype != null) {
duke@1 2277 validateAnnotationType(restype.pos(), restype.type);
duke@1 2278 }
duke@1 2279 }
duke@1 2280
duke@1 2281 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2282 if (type.isPrimitive()) return;
duke@1 2283 if (types.isSameType(type, syms.stringType)) return;
duke@1 2284 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2285 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2286 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2287 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2288 validateAnnotationType(pos, types.elemtype(type));
duke@1 2289 return;
duke@1 2290 }
duke@1 2291 log.error(pos, "invalid.annotation.member.type");
duke@1 2292 }
duke@1 2293
duke@1 2294 /**
duke@1 2295 * "It is also a compile-time error if any method declared in an
duke@1 2296 * annotation type has a signature that is override-equivalent to
duke@1 2297 * that of any public or protected method declared in class Object
duke@1 2298 * or in the interface annotation.Annotation."
duke@1 2299 *
jjh@972 2300 * @jls 9.6 Annotation Types
duke@1 2301 */
duke@1 2302 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
duke@1 2303 for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
duke@1 2304 Scope s = sup.tsym.members();
duke@1 2305 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2306 if (e.sym.kind == MTH &&
duke@1 2307 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2308 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2309 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2310 }
duke@1 2311 }
duke@1 2312 }
duke@1 2313
duke@1 2314 /** Check the annotations of a symbol.
duke@1 2315 */
duke@1 2316 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2317 if (skipAnnotations) return;
duke@1 2318 for (JCAnnotation a : annotations)
duke@1 2319 validateAnnotation(a, s);
duke@1 2320 }
duke@1 2321
duke@1 2322 /** Check an annotation of a symbol.
duke@1 2323 */
duke@1 2324 public void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2325 validateAnnotationTree(a);
duke@1 2326
duke@1 2327 if (!annotationApplicable(a, s))
duke@1 2328 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2329
duke@1 2330 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2331 if (!isOverrider(s))
duke@1 2332 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2333 }
duke@1 2334 }
duke@1 2335
duke@1 2336 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2337 boolean isOverrider(Symbol s) {
duke@1 2338 if (s.kind != MTH || s.isStatic())
duke@1 2339 return false;
duke@1 2340 MethodSymbol m = (MethodSymbol)s;
duke@1 2341 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2342 for (Type sup : types.closure(owner.type)) {
duke@1 2343 if (sup == owner.type)
duke@1 2344 continue; // skip "this"
duke@1 2345 Scope scope = sup.tsym.members();
duke@1 2346 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2347 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2348 return true;
duke@1 2349 }
duke@1 2350 }
duke@1 2351 return false;
duke@1 2352 }
duke@1 2353
duke@1 2354 /** Is the annotation applicable to the symbol? */
duke@1 2355 boolean annotationApplicable(JCAnnotation a, Symbol s) {
duke@1 2356 Attribute.Compound atTarget =
duke@1 2357 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
duke@1 2358 if (atTarget == null) return true;
duke@1 2359 Attribute atValue = atTarget.member(names.value);
duke@1 2360 if (!(atValue instanceof Attribute.Array)) return true; // error recovery
duke@1 2361 Attribute.Array arr = (Attribute.Array) atValue;
duke@1 2362 for (Attribute app : arr.values) {
duke@1 2363 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2364 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2365 if (e.value.name == names.TYPE)
duke@1 2366 { if (s.kind == TYP) return true; }
duke@1 2367 else if (e.value.name == names.FIELD)
duke@1 2368 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2369 else if (e.value.name == names.METHOD)
duke@1 2370 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2371 else if (e.value.name == names.PARAMETER)
duke@1 2372 { if (s.kind == VAR &&
duke@1 2373 s.owner.kind == MTH &&
duke@1 2374 (s.flags() & PARAMETER) != 0)
duke@1 2375 return true;
duke@1 2376 }
duke@1 2377 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2378 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2379 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2380 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2381 (s.flags() & PARAMETER) == 0)
duke@1 2382 return true;
duke@1 2383 }
duke@1 2384 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2385 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2386 return true;
duke@1 2387 }
duke@1 2388 else if (e.value.name == names.PACKAGE)
duke@1 2389 { if (s.kind == PCK) return true; }
jjg@308 2390 else if (e.value.name == names.TYPE_USE)
jjg@308 2391 { if (s.kind == TYP ||
jjg@308 2392 s.kind == VAR ||
jjg@308 2393 (s.kind == MTH && !s.isConstructor() &&
jjg@308 2394 s.type.getReturnType().tag != VOID))
jjg@308 2395 return true;
jjg@308 2396 }
duke@1 2397 else
duke@1 2398 return true; // recovery
duke@1 2399 }
duke@1 2400 return false;
duke@1 2401 }
duke@1 2402
duke@1 2403 /** Check an annotation value.
duke@1 2404 */
duke@1 2405 public void validateAnnotation(JCAnnotation a) {
mcimadamore@632 2406 // collect an inventory of the members (sorted alphabetically)
mcimadamore@632 2407 Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
mcimadamore@632 2408 public int compare(Symbol t, Symbol t1) {
mcimadamore@632 2409 return t.name.compareTo(t1.name);
mcimadamore@632 2410 }
mcimadamore@632 2411 });
duke@1 2412 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2413 e != null;
duke@1 2414 e = e.sibling)
duke@1 2415 if (e.sym.kind == MTH)
duke@1 2416 members.add((MethodSymbol) e.sym);
duke@1 2417
duke@1 2418 // count them off as they're annotated
duke@1 2419 for (JCTree arg : a.args) {
jjg@1127 2420 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 2421 JCAssign assign = (JCAssign) arg;
duke@1 2422 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2423 if (m == null || m.type.isErroneous()) continue;
duke@1 2424 if (!members.remove(m))
jjg@479 2425 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2426 m.name, a.type);
duke@1 2427 }
duke@1 2428
duke@1 2429 // all the remaining ones better have default values
mcimadamore@632 2430 ListBuffer<Name> missingDefaults = ListBuffer.lb();
mcimadamore@632 2431 for (MethodSymbol m : members) {
mcimadamore@632 2432 if (m.defaultValue == null && !m.type.isErroneous()) {
mcimadamore@632 2433 missingDefaults.append(m.name);
mcimadamore@632 2434 }
mcimadamore@632 2435 }
mcimadamore@632 2436 if (missingDefaults.nonEmpty()) {
mcimadamore@632 2437 String key = (missingDefaults.size() > 1)
mcimadamore@632 2438 ? "annotation.missing.default.value.1"
mcimadamore@632 2439 : "annotation.missing.default.value";
mcimadamore@632 2440 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 2441 }
duke@1 2442
duke@1 2443 // special case: java.lang.annotation.Target must not have
duke@1 2444 // repeated values in its value member
duke@1 2445 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2446 a.args.tail == null)
duke@1 2447 return;
duke@1 2448
jjg@1127 2449 if (!a.args.head.hasTag(ASSIGN)) return; // error recovery
duke@1 2450 JCAssign assign = (JCAssign) a.args.head;
duke@1 2451 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2452 if (m.name != names.value) return;
duke@1 2453 JCTree rhs = assign.rhs;
jjg@1127 2454 if (!rhs.hasTag(NEWARRAY)) return;
duke@1 2455 JCNewArray na = (JCNewArray) rhs;
duke@1 2456 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2457 for (JCTree elem : na.elems) {
duke@1 2458 if (!targets.add(TreeInfo.symbol(elem))) {
duke@1 2459 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2460 }
duke@1 2461 }
duke@1 2462 }
duke@1 2463
duke@1 2464 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 2465 if (allowAnnotations &&
mcimadamore@795 2466 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 2467 (s.flags() & DEPRECATED) != 0 &&
duke@1 2468 !syms.deprecatedType.isErroneous() &&
duke@1 2469 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 2470 log.warning(LintCategory.DEP_ANN,
jjg@612 2471 pos, "missing.deprecated.annotation");
duke@1 2472 }
duke@1 2473 }
duke@1 2474
mcimadamore@852 2475 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 2476 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 2477 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 2478 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 2479 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2480 @Override
mcimadamore@852 2481 public void report() {
mcimadamore@852 2482 warnDeprecated(pos, s);
mcimadamore@852 2483 }
mcimadamore@852 2484 });
mcimadamore@852 2485 };
mcimadamore@852 2486 }
mcimadamore@852 2487
mcimadamore@852 2488 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 2489 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 2490 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2491 public void report() {
mcimadamore@852 2492 if (enableSunApiLintControl)
mcimadamore@852 2493 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 2494 else
mcimadamore@852 2495 log.strictWarning(pos, "sun.proprietary", s);
mcimadamore@852 2496 }
mcimadamore@852 2497 });
mcimadamore@852 2498 }
mcimadamore@852 2499 }
mcimadamore@852 2500
duke@1 2501 /* *************************************************************************
duke@1 2502 * Check for recursive annotation elements.
duke@1 2503 **************************************************************************/
duke@1 2504
duke@1 2505 /** Check for cycles in the graph of annotation elements.
duke@1 2506 */
duke@1 2507 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 2508 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 2509 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 2510 try {
duke@1 2511 tree.sym.flags_field |= LOCKED;
duke@1 2512 for (JCTree def : tree.defs) {
jjg@1127 2513 if (!def.hasTag(METHODDEF)) continue;
duke@1 2514 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 2515 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 2516 }
duke@1 2517 } finally {
duke@1 2518 tree.sym.flags_field &= ~LOCKED;
duke@1 2519 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 2520 }
duke@1 2521 }
duke@1 2522
duke@1 2523 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 2524 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 2525 return;
duke@1 2526 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 2527 log.error(pos, "cyclic.annotation.element");
duke@1 2528 return;
duke@1 2529 }
duke@1 2530 try {
duke@1 2531 tsym.flags_field |= LOCKED;
duke@1 2532 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 2533 Symbol s = e.sym;
duke@1 2534 if (s.kind != Kinds.MTH)
duke@1 2535 continue;
duke@1 2536 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 2537 }
duke@1 2538 } finally {
duke@1 2539 tsym.flags_field &= ~LOCKED;
duke@1 2540 tsym.flags_field |= ACYCLIC_ANN;
duke@1 2541 }
duke@1 2542 }
duke@1 2543
duke@1 2544 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
duke@1 2545 switch (type.tag) {
duke@1 2546 case TypeTags.CLASS:
duke@1 2547 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 2548 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 2549 break;
duke@1 2550 case TypeTags.ARRAY:
duke@1 2551 checkAnnotationResType(pos, types.elemtype(type));
duke@1 2552 break;
duke@1 2553 default:
duke@1 2554 break; // int etc
duke@1 2555 }
duke@1 2556 }
duke@1 2557
duke@1 2558 /* *************************************************************************
duke@1 2559 * Check for cycles in the constructor call graph.
duke@1 2560 **************************************************************************/
duke@1 2561
duke@1 2562 /** Check for cycles in the graph of constructors calling other
duke@1 2563 * constructors.
duke@1 2564 */
duke@1 2565 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 2566 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 2567
duke@1 2568 // enter each constructor this-call into the map
duke@1 2569 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 2570 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 2571 if (app == null) continue;
duke@1 2572 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 2573 if (TreeInfo.name(app.meth) == names._this) {
duke@1 2574 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 2575 } else {
duke@1 2576 meth.sym.flags_field |= ACYCLIC;
duke@1 2577 }
duke@1 2578 }
duke@1 2579
duke@1 2580 // Check for cycles in the map
duke@1 2581 Symbol[] ctors = new Symbol[0];
duke@1 2582 ctors = callMap.keySet().toArray(ctors);
duke@1 2583 for (Symbol caller : ctors) {
duke@1 2584 checkCyclicConstructor(tree, caller, callMap);
duke@1 2585 }
duke@1 2586 }
duke@1 2587
duke@1 2588 /** Look in the map to see if the given constructor is part of a
duke@1 2589 * call cycle.
duke@1 2590 */
duke@1 2591 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 2592 Map<Symbol,Symbol> callMap) {
duke@1 2593 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 2594 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 2595 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 2596 "recursive.ctor.invocation");
duke@1 2597 } else {
duke@1 2598 ctor.flags_field |= LOCKED;
duke@1 2599 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 2600 ctor.flags_field &= ~LOCKED;
duke@1 2601 }
duke@1 2602 ctor.flags_field |= ACYCLIC;
duke@1 2603 }
duke@1 2604 }
duke@1 2605
duke@1 2606 /* *************************************************************************
duke@1 2607 * Miscellaneous
duke@1 2608 **************************************************************************/
duke@1 2609
duke@1 2610 /**
duke@1 2611 * Return the opcode of the operator but emit an error if it is an
duke@1 2612 * error.
duke@1 2613 * @param pos position for error reporting.
duke@1 2614 * @param operator an operator
duke@1 2615 * @param tag a tree tag
duke@1 2616 * @param left type of left hand side
duke@1 2617 * @param right type of right hand side
duke@1 2618 */
duke@1 2619 int checkOperator(DiagnosticPosition pos,
duke@1 2620 OperatorSymbol operator,
jjg@1127 2621 JCTree.Tag tag,
duke@1 2622 Type left,
duke@1 2623 Type right) {
duke@1 2624 if (operator.opcode == ByteCodes.error) {
duke@1 2625 log.error(pos,
mcimadamore@853 2626 "operator.cant.be.applied.1",
duke@1 2627 treeinfo.operatorName(tag),
mcimadamore@853 2628 left, right);
duke@1 2629 }
duke@1 2630 return operator.opcode;
duke@1 2631 }
duke@1 2632
duke@1 2633
duke@1 2634 /**
duke@1 2635 * Check for division by integer constant zero
duke@1 2636 * @param pos Position for error reporting.
duke@1 2637 * @param operator The operator for the expression
duke@1 2638 * @param operand The right hand operand for the expression
duke@1 2639 */
duke@1 2640 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 2641 if (operand.constValue() != null
mcimadamore@795 2642 && lint.isEnabled(LintCategory.DIVZERO)
duke@1 2643 && operand.tag <= LONG
duke@1 2644 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 2645 int opc = ((OperatorSymbol)operator).opcode;
duke@1 2646 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 2647 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 2648 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 2649 }
duke@1 2650 }
duke@1 2651 }
duke@1 2652
duke@1 2653 /**
duke@1 2654 * Check for empty statements after if
duke@1 2655 */
duke@1 2656 void checkEmptyIf(JCIf tree) {
jjg@1127 2657 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 2658 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 2659 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 2660 }
duke@1 2661
duke@1 2662 /** Check that symbol is unique in given scope.
duke@1 2663 * @param pos Position for error reporting.
duke@1 2664 * @param sym The symbol.
duke@1 2665 * @param s The scope.
duke@1 2666 */
duke@1 2667 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2668 if (sym.type.isErroneous())
duke@1 2669 return true;
duke@1 2670 if (sym.owner.name == names.any) return false;
duke@1 2671 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 2672 if (sym != e.sym &&
mcimadamore@858 2673 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 2674 sym.kind == e.sym.kind &&
mcimadamore@858 2675 sym.name != names.error &&
mcimadamore@858 2676 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 2677 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 2678 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 2679 return true;
mcimadamore@907 2680 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 2681 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 2682 sym.flags_field |= CLASH;
mcimadamore@844 2683 return true;
mcimadamore@844 2684 } else {
duke@1 2685 duplicateError(pos, e.sym);
mcimadamore@844 2686 return false;
mcimadamore@844 2687 }
duke@1 2688 }
duke@1 2689 }
duke@1 2690 return true;
duke@1 2691 }
mcimadamore@844 2692
mcimadamore@858 2693 /** Report duplicate declaration error.
mcimadamore@858 2694 */
mcimadamore@858 2695 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 2696 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 2697 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 2698 }
mcimadamore@858 2699 }
duke@1 2700
duke@1 2701 /** Check that single-type import is not already imported or top-level defined,
duke@1 2702 * but make an exception for two single-type imports which denote the same type.
duke@1 2703 * @param pos Position for error reporting.
duke@1 2704 * @param sym The symbol.
duke@1 2705 * @param s The scope
duke@1 2706 */
duke@1 2707 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2708 return checkUniqueImport(pos, sym, s, false);
duke@1 2709 }
duke@1 2710
duke@1 2711 /** Check that static single-type import is not already imported or top-level defined,
duke@1 2712 * but make an exception for two single-type imports which denote the same type.
duke@1 2713 * @param pos Position for error reporting.
duke@1 2714 * @param sym The symbol.
duke@1 2715 * @param s The scope
duke@1 2716 * @param staticImport Whether or not this was a static import
duke@1 2717 */
duke@1 2718 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2719 return checkUniqueImport(pos, sym, s, true);
duke@1 2720 }
duke@1 2721
duke@1 2722 /** Check that single-type import is not already imported or top-level defined,
duke@1 2723 * but make an exception for two single-type imports which denote the same type.
duke@1 2724 * @param pos Position for error reporting.
duke@1 2725 * @param sym The symbol.
duke@1 2726 * @param s The scope.
duke@1 2727 * @param staticImport Whether or not this was a static import
duke@1 2728 */
duke@1 2729 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 2730 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 2731 // is encountered class entered via a class declaration?
duke@1 2732 boolean isClassDecl = e.scope == s;
duke@1 2733 if ((isClassDecl || sym != e.sym) &&
duke@1 2734 sym.kind == e.sym.kind &&
duke@1 2735 sym.name != names.error) {
duke@1 2736 if (!e.sym.type.isErroneous()) {
duke@1 2737 String what = e.sym.toString();
duke@1 2738 if (!isClassDecl) {
duke@1 2739 if (staticImport)
duke@1 2740 log.error(pos, "already.defined.static.single.import", what);
duke@1 2741 else
duke@1 2742 log.error(pos, "already.defined.single.import", what);
duke@1 2743 }
duke@1 2744 else if (sym != e.sym)
duke@1 2745 log.error(pos, "already.defined.this.unit", what);
duke@1 2746 }
duke@1 2747 return false;
duke@1 2748 }
duke@1 2749 }
duke@1 2750 return true;
duke@1 2751 }
duke@1 2752
duke@1 2753 /** Check that a qualified name is in canonical form (for import decls).
duke@1 2754 */
duke@1 2755 public void checkCanonical(JCTree tree) {
duke@1 2756 if (!isCanonical(tree))
duke@1 2757 log.error(tree.pos(), "import.requires.canonical",
duke@1 2758 TreeInfo.symbol(tree));
duke@1 2759 }
duke@1 2760 // where
duke@1 2761 private boolean isCanonical(JCTree tree) {
jjg@1127 2762 while (tree.hasTag(SELECT)) {
duke@1 2763 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 2764 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 2765 return false;
duke@1 2766 tree = s.selected;
duke@1 2767 }
duke@1 2768 return true;
duke@1 2769 }
duke@1 2770
duke@1 2771 private class ConversionWarner extends Warner {
mcimadamore@795 2772 final String uncheckedKey;
duke@1 2773 final Type found;
duke@1 2774 final Type expected;
mcimadamore@795 2775 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 2776 super(pos);
mcimadamore@795 2777 this.uncheckedKey = uncheckedKey;
duke@1 2778 this.found = found;
duke@1 2779 this.expected = expected;
duke@1 2780 }
duke@1 2781
jjg@398 2782 @Override
mcimadamore@795 2783 public void warn(LintCategory lint) {
duke@1 2784 boolean warned = this.warned;
mcimadamore@795 2785 super.warn(lint);
duke@1 2786 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 2787 switch (lint) {
mcimadamore@795 2788 case UNCHECKED:
mcimadamore@795 2789 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 2790 break;
mcimadamore@795 2791 case VARARGS:
mcimadamore@795 2792 if (method != null &&
mcimadamore@795 2793 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 2794 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 2795 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 2796 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 2797 }
mcimadamore@795 2798 break;
mcimadamore@795 2799 default:
mcimadamore@795 2800 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 2801 }
duke@1 2802 }
duke@1 2803 }
duke@1 2804
duke@1 2805 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2806 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 2807 }
duke@1 2808
duke@1 2809 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2810 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 2811 }
duke@1 2812 }

mercurial