src/share/classes/com/sun/tools/javac/comp/Check.java

Mon, 21 Jan 2013 20:19:53 +0000

author
mcimadamore
date
Mon, 21 Jan 2013 20:19:53 +0000
changeset 1513
cf84b07a82db
parent 1510
7873d37f5b37
child 1521
71f35e4b93a5
permissions
-rw-r--r--

8005166: Add support for static interface methods
Summary: Support public static interface methods
Reviewed-by: jjg

duke@1 1 /*
jjg@1492 2 * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
ohrstrom@1384 30 import javax.tools.JavaFileManager;
duke@1 31
duke@1 32 import com.sun.tools.javac.code.*;
duke@1 33 import com.sun.tools.javac.jvm.*;
duke@1 34 import com.sun.tools.javac.tree.*;
duke@1 35 import com.sun.tools.javac.util.*;
duke@1 36 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 37 import com.sun.tools.javac.util.List;
duke@1 38
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 43 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 44 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1337 45 import com.sun.tools.javac.comp.Infer.InferenceContext.FreeTypeListener;
mcimadamore@1510 46 import com.sun.tools.javac.tree.JCTree.*;
mcimadamore@1510 47 import com.sun.tools.javac.tree.JCTree.JCPolyExpression.*;
duke@1 48
duke@1 49 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 50 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 51 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 52 import static com.sun.tools.javac.code.Kinds.*;
jjg@1374 53 import static com.sun.tools.javac.code.TypeTag.*;
jjg@1374 54 import static com.sun.tools.javac.code.TypeTag.WILDCARD;
duke@1 55
jjg@1127 56 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 57
duke@1 58 /** Type checking helper class for the attribution phase.
duke@1 59 *
jjg@581 60 * <p><b>This is NOT part of any supported API.
jjg@581 61 * If you write code that depends on this, you do so at your own risk.
duke@1 62 * This code and its internal interfaces are subject to change or
duke@1 63 * deletion without notice.</b>
duke@1 64 */
duke@1 65 public class Check {
duke@1 66 protected static final Context.Key<Check> checkKey =
duke@1 67 new Context.Key<Check>();
duke@1 68
jjg@113 69 private final Names names;
duke@1 70 private final Log log;
mcimadamore@1219 71 private final Resolve rs;
duke@1 72 private final Symtab syms;
mcimadamore@690 73 private final Enter enter;
mcimadamore@1347 74 private final DeferredAttr deferredAttr;
duke@1 75 private final Infer infer;
duke@1 76 private final Types types;
mcimadamore@89 77 private final JCDiagnostic.Factory diags;
mcimadamore@359 78 private boolean warnOnSyntheticConflicts;
jjg@576 79 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 80 private boolean enableSunApiLintControl;
duke@1 81 private final TreeInfo treeinfo;
ohrstrom@1384 82 private final JavaFileManager fileManager;
duke@1 83
duke@1 84 // The set of lint options currently in effect. It is initialized
duke@1 85 // from the context, and then is set/reset as needed by Attr as it
duke@1 86 // visits all the various parts of the trees during attribution.
duke@1 87 private Lint lint;
duke@1 88
mcimadamore@795 89 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 90 // Attr as it visits new method declarations.
mcimadamore@795 91 private MethodSymbol method;
mcimadamore@795 92
duke@1 93 public static Check instance(Context context) {
duke@1 94 Check instance = context.get(checkKey);
duke@1 95 if (instance == null)
duke@1 96 instance = new Check(context);
duke@1 97 return instance;
duke@1 98 }
duke@1 99
duke@1 100 protected Check(Context context) {
duke@1 101 context.put(checkKey, this);
duke@1 102
jjg@113 103 names = Names.instance(context);
duke@1 104 log = Log.instance(context);
mcimadamore@1219 105 rs = Resolve.instance(context);
duke@1 106 syms = Symtab.instance(context);
mcimadamore@690 107 enter = Enter.instance(context);
mcimadamore@1347 108 deferredAttr = DeferredAttr.instance(context);
duke@1 109 infer = Infer.instance(context);
duke@1 110 this.types = Types.instance(context);
mcimadamore@89 111 diags = JCDiagnostic.Factory.instance(context);
duke@1 112 Options options = Options.instance(context);
duke@1 113 lint = Lint.instance(context);
duke@1 114 treeinfo = TreeInfo.instance(context);
ohrstrom@1384 115 fileManager = context.get(JavaFileManager.class);
duke@1 116
duke@1 117 Source source = Source.instance(context);
duke@1 118 allowGenerics = source.allowGenerics();
mcimadamore@1219 119 allowVarargs = source.allowVarargs();
duke@1 120 allowAnnotations = source.allowAnnotations();
jjg@398 121 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 122 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
mcimadamore@1393 123 allowDefaultMethods = source.allowDefaultMethods();
mcimadamore@1415 124 allowStrictMethodClashCheck = source.allowStrictMethodClashCheck();
jjg@1157 125 complexInference = options.isSet("complexinference");
jjg@700 126 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 127 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 128 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 129
jjg@398 130 Target target = Target.instance(context);
jjg@398 131 syntheticNameChar = target.syntheticNameChar();
jjg@398 132
duke@1 133 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 134 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 135 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 136 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 137
jjg@60 138 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 139 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 140 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 141 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 142 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 143 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 144
mcimadamore@852 145 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 146 }
duke@1 147
duke@1 148 /** Switch: generics enabled?
duke@1 149 */
duke@1 150 boolean allowGenerics;
duke@1 151
mcimadamore@1219 152 /** Switch: varargs enabled?
mcimadamore@1219 153 */
mcimadamore@1219 154 boolean allowVarargs;
mcimadamore@1219 155
duke@1 156 /** Switch: annotations enabled?
duke@1 157 */
duke@1 158 boolean allowAnnotations;
duke@1 159
jjg@398 160 /** Switch: covariant returns enabled?
jjg@398 161 */
jjg@398 162 boolean allowCovariantReturns;
jjg@398 163
mcimadamore@795 164 /** Switch: simplified varargs enabled?
mcimadamore@795 165 */
mcimadamore@795 166 boolean allowSimplifiedVarargs;
mcimadamore@795 167
mcimadamore@1393 168 /** Switch: default methods enabled?
mcimadamore@1393 169 */
mcimadamore@1393 170 boolean allowDefaultMethods;
mcimadamore@1393 171
mcimadamore@1393 172 /** Switch: should unrelated return types trigger a method clash?
mcimadamore@1393 173 */
mcimadamore@1393 174 boolean allowStrictMethodClashCheck;
mcimadamore@1393 175
duke@1 176 /** Switch: -complexinference option set?
duke@1 177 */
duke@1 178 boolean complexInference;
duke@1 179
jjg@398 180 /** Character for synthetic names
jjg@398 181 */
jjg@398 182 char syntheticNameChar;
jjg@398 183
duke@1 184 /** A table mapping flat names of all compiled classes in this run to their
duke@1 185 * symbols; maintained from outside.
duke@1 186 */
duke@1 187 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 188
duke@1 189 /** A handler for messages about deprecated usage.
duke@1 190 */
duke@1 191 private MandatoryWarningHandler deprecationHandler;
duke@1 192
duke@1 193 /** A handler for messages about unchecked or unsafe usage.
duke@1 194 */
duke@1 195 private MandatoryWarningHandler uncheckedHandler;
duke@1 196
jjg@582 197 /** A handler for messages about using proprietary API.
jjg@377 198 */
jjg@377 199 private MandatoryWarningHandler sunApiHandler;
duke@1 200
mcimadamore@852 201 /** A handler for deferred lint warnings.
mcimadamore@852 202 */
mcimadamore@852 203 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 204
duke@1 205 /* *************************************************************************
duke@1 206 * Errors and Warnings
duke@1 207 **************************************************************************/
duke@1 208
duke@1 209 Lint setLint(Lint newLint) {
duke@1 210 Lint prev = lint;
duke@1 211 lint = newLint;
duke@1 212 return prev;
duke@1 213 }
duke@1 214
mcimadamore@852 215 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 216 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 217 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 218 return prev;
mcimadamore@852 219 }
mcimadamore@852 220
mcimadamore@795 221 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 222 MethodSymbol prev = method;
mcimadamore@795 223 method = newMethod;
mcimadamore@795 224 return prev;
mcimadamore@795 225 }
mcimadamore@795 226
duke@1 227 /** Warn about deprecated symbol.
duke@1 228 * @param pos Position to be used for error reporting.
duke@1 229 * @param sym The deprecated symbol.
duke@1 230 */
duke@1 231 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 232 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 233 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 234 }
duke@1 235
duke@1 236 /** Warn about unchecked operation.
duke@1 237 * @param pos Position to be used for error reporting.
duke@1 238 * @param msg A string describing the problem.
duke@1 239 */
duke@1 240 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 241 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 242 uncheckedHandler.report(pos, msg, args);
duke@1 243 }
duke@1 244
mcimadamore@580 245 /** Warn about unsafe vararg method decl.
mcimadamore@580 246 * @param pos Position to be used for error reporting.
mcimadamore@580 247 */
mcimadamore@795 248 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 249 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 250 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 251 }
mcimadamore@580 252
jjg@582 253 /** Warn about using proprietary API.
jjg@377 254 * @param pos Position to be used for error reporting.
jjg@377 255 * @param msg A string describing the problem.
jjg@377 256 */
jjg@377 257 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 258 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 259 sunApiHandler.report(pos, msg, args);
jjg@377 260 }
jjg@377 261
jjg@505 262 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 263 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 264 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 265 }
jjg@505 266
duke@1 267 /**
duke@1 268 * Report any deferred diagnostics.
duke@1 269 */
duke@1 270 public void reportDeferredDiagnostics() {
duke@1 271 deprecationHandler.reportDeferredDiagnostic();
duke@1 272 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 273 sunApiHandler.reportDeferredDiagnostic();
duke@1 274 }
duke@1 275
duke@1 276
duke@1 277 /** Report a failure to complete a class.
duke@1 278 * @param pos Position to be used for error reporting.
duke@1 279 * @param ex The failure to report.
duke@1 280 */
duke@1 281 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 282 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 283 if (ex instanceof ClassReader.BadClassFile
jjg@576 284 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 285 else return syms.errType;
duke@1 286 }
duke@1 287
duke@1 288 /** Report an error that wrong type tag was found.
duke@1 289 * @param pos Position to be used for error reporting.
duke@1 290 * @param required An internationalized string describing the type tag
duke@1 291 * required.
duke@1 292 * @param found The type that was found.
duke@1 293 */
duke@1 294 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 295 // this error used to be raised by the parser,
jrose@267 296 // but has been delayed to this point:
jjg@1374 297 if (found instanceof Type && ((Type)found).hasTag(VOID)) {
jrose@267 298 log.error(pos, "illegal.start.of.type");
jrose@267 299 return syms.errType;
jrose@267 300 }
duke@1 301 log.error(pos, "type.found.req", found, required);
jjg@110 302 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 303 }
duke@1 304
duke@1 305 /** Report an error that symbol cannot be referenced before super
duke@1 306 * has been called.
duke@1 307 * @param pos Position to be used for error reporting.
duke@1 308 * @param sym The referenced symbol.
duke@1 309 */
duke@1 310 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 311 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 312 }
duke@1 313
duke@1 314 /** Report duplicate declaration error.
duke@1 315 */
duke@1 316 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 317 if (!sym.type.isErroneous()) {
mcimadamore@1085 318 Symbol location = sym.location();
mcimadamore@1085 319 if (location.kind == MTH &&
mcimadamore@1085 320 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 321 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 322 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 323 sym.location().enclClass());
mcimadamore@1085 324 } else {
mcimadamore@1085 325 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 326 kindName(sym.location()), sym.location());
mcimadamore@1085 327 }
duke@1 328 }
duke@1 329 }
duke@1 330
duke@1 331 /** Report array/varargs duplicate declaration
duke@1 332 */
duke@1 333 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 334 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 335 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 336 }
duke@1 337 }
duke@1 338
duke@1 339 /* ************************************************************************
duke@1 340 * duplicate declaration checking
duke@1 341 *************************************************************************/
duke@1 342
duke@1 343 /** Check that variable does not hide variable with same name in
duke@1 344 * immediately enclosing local scope.
duke@1 345 * @param pos Position for error reporting.
duke@1 346 * @param v The symbol.
duke@1 347 * @param s The scope.
duke@1 348 */
duke@1 349 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 350 if (s.next != null) {
duke@1 351 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 352 e.scope != null && e.sym.owner == v.owner;
duke@1 353 e = e.next()) {
duke@1 354 if (e.sym.kind == VAR &&
duke@1 355 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 356 v.name != names.error) {
duke@1 357 duplicateError(pos, e.sym);
duke@1 358 return;
duke@1 359 }
duke@1 360 }
duke@1 361 }
duke@1 362 }
duke@1 363
duke@1 364 /** Check that a class or interface does not hide a class or
duke@1 365 * interface with same name in immediately enclosing local scope.
duke@1 366 * @param pos Position for error reporting.
duke@1 367 * @param c The symbol.
duke@1 368 * @param s The scope.
duke@1 369 */
duke@1 370 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 371 if (s.next != null) {
duke@1 372 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 373 e.scope != null && e.sym.owner == c.owner;
duke@1 374 e = e.next()) {
jjg@1374 375 if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) &&
duke@1 376 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 377 c.name != names.error) {
duke@1 378 duplicateError(pos, e.sym);
duke@1 379 return;
duke@1 380 }
duke@1 381 }
duke@1 382 }
duke@1 383 }
duke@1 384
duke@1 385 /** Check that class does not have the same name as one of
duke@1 386 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 387 * return true if class is unique in its enclosing scope.
duke@1 388 * @param pos Position for error reporting.
duke@1 389 * @param name The class name.
duke@1 390 * @param s The enclosing scope.
duke@1 391 */
duke@1 392 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 393 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 394 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 395 duplicateError(pos, e.sym);
duke@1 396 return false;
duke@1 397 }
duke@1 398 }
duke@1 399 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 400 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 401 duplicateError(pos, sym);
duke@1 402 return true;
duke@1 403 }
duke@1 404 }
duke@1 405 return true;
duke@1 406 }
duke@1 407
duke@1 408 /* *************************************************************************
duke@1 409 * Class name generation
duke@1 410 **************************************************************************/
duke@1 411
duke@1 412 /** Return name of local class.
jjg@1358 413 * This is of the form {@code <enclClass> $ n <classname> }
duke@1 414 * where
duke@1 415 * enclClass is the flat name of the enclosing class,
duke@1 416 * classname is the simple name of the local class
duke@1 417 */
duke@1 418 Name localClassName(ClassSymbol c) {
duke@1 419 for (int i=1; ; i++) {
duke@1 420 Name flatname = names.
duke@1 421 fromString("" + c.owner.enclClass().flatname +
jjg@398 422 syntheticNameChar + i +
duke@1 423 c.name);
duke@1 424 if (compiled.get(flatname) == null) return flatname;
duke@1 425 }
duke@1 426 }
duke@1 427
duke@1 428 /* *************************************************************************
duke@1 429 * Type Checking
duke@1 430 **************************************************************************/
duke@1 431
mcimadamore@1238 432 /**
mcimadamore@1238 433 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 434 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 435 * vary significantly.
mcimadamore@1238 436 */
mcimadamore@1348 437 public interface CheckContext {
mcimadamore@1238 438 /**
mcimadamore@1238 439 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 440 */
mcimadamore@1238 441 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 442 /**
mcimadamore@1238 443 * Report a check error
mcimadamore@1238 444 */
mcimadamore@1296 445 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 446 /**
mcimadamore@1238 447 * Obtain a warner for this check context
mcimadamore@1238 448 */
mcimadamore@1238 449 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 450
mcimadamore@1337 451 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 452
mcimadamore@1347 453 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1238 454 }
mcimadamore@1238 455
mcimadamore@1238 456 /**
mcimadamore@1238 457 * This class represent a check context that is nested within another check
mcimadamore@1238 458 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 459 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 460 * the forwarding pattern.
mcimadamore@1238 461 */
mcimadamore@1238 462 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 463 CheckContext enclosingContext;
mcimadamore@1238 464
mcimadamore@1238 465 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 466 this.enclosingContext = enclosingContext;
mcimadamore@1238 467 }
mcimadamore@1238 468
mcimadamore@1238 469 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 470 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 471 }
mcimadamore@1238 472
mcimadamore@1296 473 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 474 enclosingContext.report(pos, details);
mcimadamore@1238 475 }
mcimadamore@1238 476
mcimadamore@1238 477 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 478 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 479 }
mcimadamore@1337 480
mcimadamore@1337 481 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 482 return enclosingContext.inferenceContext();
mcimadamore@1337 483 }
mcimadamore@1347 484
mcimadamore@1347 485 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 486 return enclosingContext.deferredAttrContext();
mcimadamore@1347 487 }
mcimadamore@1238 488 }
mcimadamore@1238 489
mcimadamore@1238 490 /**
mcimadamore@1238 491 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 492 */
mcimadamore@1238 493 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 494 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 495 log.error(pos, "prob.found.req", details);
mcimadamore@1238 496 }
mcimadamore@1238 497 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 498 return types.isAssignable(found, req, warn);
mcimadamore@1238 499 }
mcimadamore@1238 500
mcimadamore@1238 501 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 502 return convertWarner(pos, found, req);
mcimadamore@1238 503 }
mcimadamore@1337 504
mcimadamore@1337 505 public InferenceContext inferenceContext() {
mcimadamore@1337 506 return infer.emptyContext;
mcimadamore@1337 507 }
mcimadamore@1347 508
mcimadamore@1347 509 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 510 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 511 }
mcimadamore@1238 512 };
mcimadamore@1238 513
duke@1 514 /** Check that a given type is assignable to a given proto-type.
duke@1 515 * If it is, return the type, otherwise return errType.
duke@1 516 * @param pos Position to be used for error reporting.
duke@1 517 * @param found The type that was found.
duke@1 518 * @param req The type that was required.
duke@1 519 */
duke@1 520 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 521 return checkType(pos, found, req, basicHandler);
darcy@609 522 }
darcy@609 523
mcimadamore@1337 524 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 525 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 526 if (inferenceContext.free(req)) {
mcimadamore@1337 527 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 528 @Override
mcimadamore@1337 529 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1337 530 checkType(pos, found, inferenceContext.asInstType(req, types), checkContext);
mcimadamore@1337 531 }
mcimadamore@1337 532 });
mcimadamore@1337 533 }
jjg@1374 534 if (req.hasTag(ERROR))
duke@1 535 return req;
jjg@1374 536 if (req.hasTag(NONE))
duke@1 537 return found;
mcimadamore@1238 538 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 539 return found;
mcimadamore@1238 540 } else {
jjg@1374 541 if (found.getTag().isSubRangeOf(DOUBLE) && req.getTag().isSubRangeOf(DOUBLE)) {
mcimadamore@1296 542 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 543 return types.createErrorType(found);
mcimadamore@1238 544 }
mcimadamore@1296 545 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 546 return types.createErrorType(found);
duke@1 547 }
duke@1 548 }
duke@1 549
duke@1 550 /** Check that a given type can be cast to a given target type.
duke@1 551 * Return the result of the cast.
duke@1 552 * @param pos Position to be used for error reporting.
duke@1 553 * @param found The type that is being cast.
duke@1 554 * @param req The target type of the cast.
duke@1 555 */
duke@1 556 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 557 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 558 }
mcimadamore@1238 559 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 560 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 561 return req;
duke@1 562 } else {
mcimadamore@1296 563 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 564 return types.createErrorType(found);
duke@1 565 }
duke@1 566 }
mcimadamore@1237 567
mcimadamore@1237 568 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 569 * The problem should only be reported for non-292 cast
mcimadamore@1237 570 */
mcimadamore@1237 571 public void checkRedundantCast(Env<AttrContext> env, JCTypeCast tree) {
mcimadamore@1237 572 if (!tree.type.isErroneous() &&
mcimadamore@1348 573 (env.info.lint == null || env.info.lint.isEnabled(Lint.LintCategory.CAST))
mcimadamore@1348 574 && types.isSameType(tree.expr.type, tree.clazz.type)
mcimadamore@1348 575 && !is292targetTypeCast(tree)) {
mcimadamore@1237 576 log.warning(Lint.LintCategory.CAST,
mcimadamore@1237 577 tree.pos(), "redundant.cast", tree.expr.type);
mcimadamore@1237 578 }
mcimadamore@1237 579 }
mcimadamore@1237 580 //where
mcimadamore@1237 581 private boolean is292targetTypeCast(JCTypeCast tree) {
mcimadamore@1237 582 boolean is292targetTypeCast = false;
mcimadamore@1237 583 JCExpression expr = TreeInfo.skipParens(tree.expr);
mcimadamore@1237 584 if (expr.hasTag(APPLY)) {
mcimadamore@1237 585 JCMethodInvocation apply = (JCMethodInvocation)expr;
mcimadamore@1237 586 Symbol sym = TreeInfo.symbol(apply.meth);
mcimadamore@1237 587 is292targetTypeCast = sym != null &&
mcimadamore@1237 588 sym.kind == MTH &&
mcimadamore@1239 589 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 590 }
mcimadamore@1237 591 return is292targetTypeCast;
mcimadamore@1237 592 }
mcimadamore@1237 593
mcimadamore@1237 594
mcimadamore@1237 595
duke@1 596 //where
duke@1 597 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 598 * type variables?
duke@1 599 */
duke@1 600 boolean isTypeVar(Type t) {
jjg@1374 601 return t.hasTag(TYPEVAR) || t.hasTag(ARRAY) && isTypeVar(types.elemtype(t));
duke@1 602 }
duke@1 603
duke@1 604 /** Check that a type is within some bounds.
duke@1 605 *
jjg@1358 606 * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
duke@1 607 * type argument.
duke@1 608 * @param a The type that should be bounded by bs.
jjg@1358 609 * @param bound The bound.
duke@1 610 */
mcimadamore@1216 611 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 612 if (a.isUnbound()) {
mcimadamore@821 613 return true;
jjg@1374 614 } else if (!a.hasTag(WILDCARD)) {
mcimadamore@154 615 a = types.upperBound(a);
mcimadamore@1216 616 return types.isSubtype(a, bound);
mcimadamore@154 617 } else if (a.isExtendsBound()) {
mcimadamore@1415 618 return types.isCastable(bound, types.upperBound(a), types.noWarnings);
mcimadamore@154 619 } else if (a.isSuperBound()) {
mcimadamore@1216 620 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 621 }
mcimadamore@821 622 return true;
mcimadamore@154 623 }
duke@1 624
duke@1 625 /** Check that type is different from 'void'.
duke@1 626 * @param pos Position to be used for error reporting.
duke@1 627 * @param t The type to be checked.
duke@1 628 */
duke@1 629 Type checkNonVoid(DiagnosticPosition pos, Type t) {
jjg@1374 630 if (t.hasTag(VOID)) {
duke@1 631 log.error(pos, "void.not.allowed.here");
jjg@110 632 return types.createErrorType(t);
duke@1 633 } else {
duke@1 634 return t;
duke@1 635 }
duke@1 636 }
duke@1 637
mcimadamore@1496 638 Type checkClassOrArrayType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 639 if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
mcimadamore@1496 640 return typeTagError(pos,
mcimadamore@1496 641 diags.fragment("type.req.class.array"),
mcimadamore@1496 642 asTypeParam(t));
mcimadamore@1496 643 } else {
mcimadamore@1496 644 return t;
mcimadamore@1496 645 }
mcimadamore@1496 646 }
mcimadamore@1496 647
duke@1 648 /** Check that type is a class or interface type.
duke@1 649 * @param pos Position to be used for error reporting.
duke@1 650 * @param t The type to be checked.
duke@1 651 */
duke@1 652 Type checkClassType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 653 if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) {
duke@1 654 return typeTagError(pos,
mcimadamore@89 655 diags.fragment("type.req.class"),
mcimadamore@1496 656 asTypeParam(t));
mcimadamore@1496 657 } else {
duke@1 658 return t;
mcimadamore@1496 659 }
duke@1 660 }
mcimadamore@1496 661 //where
mcimadamore@1496 662 private Object asTypeParam(Type t) {
mcimadamore@1496 663 return (t.hasTag(TYPEVAR))
mcimadamore@1496 664 ? diags.fragment("type.parameter", t)
mcimadamore@1496 665 : t;
mcimadamore@1496 666 }
duke@1 667
mcimadamore@1352 668 /** Check that type is a valid qualifier for a constructor reference expression
mcimadamore@1352 669 */
mcimadamore@1352 670 Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 671 t = checkClassOrArrayType(pos, t);
jjg@1374 672 if (t.hasTag(CLASS)) {
mcimadamore@1352 673 if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
mcimadamore@1352 674 log.error(pos, "abstract.cant.be.instantiated");
mcimadamore@1352 675 t = types.createErrorType(t);
mcimadamore@1352 676 } else if ((t.tsym.flags() & ENUM) != 0) {
mcimadamore@1352 677 log.error(pos, "enum.cant.be.instantiated");
mcimadamore@1352 678 t = types.createErrorType(t);
mcimadamore@1352 679 }
mcimadamore@1352 680 }
mcimadamore@1352 681 return t;
mcimadamore@1352 682 }
mcimadamore@1352 683
duke@1 684 /** Check that type is a class or interface type.
duke@1 685 * @param pos Position to be used for error reporting.
duke@1 686 * @param t The type to be checked.
duke@1 687 * @param noBounds True if type bounds are illegal here.
duke@1 688 */
duke@1 689 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 690 t = checkClassType(pos, t);
duke@1 691 if (noBounds && t.isParameterized()) {
duke@1 692 List<Type> args = t.getTypeArguments();
duke@1 693 while (args.nonEmpty()) {
jjg@1374 694 if (args.head.hasTag(WILDCARD))
duke@1 695 return typeTagError(pos,
jjg@598 696 diags.fragment("type.req.exact"),
duke@1 697 args.head);
duke@1 698 args = args.tail;
duke@1 699 }
duke@1 700 }
duke@1 701 return t;
duke@1 702 }
duke@1 703
duke@1 704 /** Check that type is a reifiable class, interface or array type.
duke@1 705 * @param pos Position to be used for error reporting.
duke@1 706 * @param t The type to be checked.
duke@1 707 */
duke@1 708 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 709 t = checkClassOrArrayType(pos, t);
mcimadamore@1496 710 if (!t.isErroneous() && !types.isReifiable(t)) {
duke@1 711 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 712 return types.createErrorType(t);
duke@1 713 } else {
duke@1 714 return t;
duke@1 715 }
duke@1 716 }
duke@1 717
duke@1 718 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 719 * or a type variable.
duke@1 720 * @param pos Position to be used for error reporting.
duke@1 721 * @param t The type to be checked.
duke@1 722 */
duke@1 723 Type checkRefType(DiagnosticPosition pos, Type t) {
jjg@1374 724 if (t.isReference())
duke@1 725 return t;
jjg@1374 726 else
duke@1 727 return typeTagError(pos,
mcimadamore@89 728 diags.fragment("type.req.ref"),
duke@1 729 t);
duke@1 730 }
duke@1 731
jrose@267 732 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 733 * or a type variable.
jrose@267 734 * @param trees Original trees, used for error reporting.
jrose@267 735 * @param types The types to be checked.
jrose@267 736 */
jrose@267 737 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 738 List<JCExpression> tl = trees;
jrose@267 739 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 740 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 741 tl = tl.tail;
jrose@267 742 }
jrose@267 743 return types;
jrose@267 744 }
jrose@267 745
duke@1 746 /** Check that type is a null or reference type.
duke@1 747 * @param pos Position to be used for error reporting.
duke@1 748 * @param t The type to be checked.
duke@1 749 */
duke@1 750 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
jjg@1374 751 if (t.isNullOrReference())
duke@1 752 return t;
jjg@1374 753 else
duke@1 754 return typeTagError(pos,
mcimadamore@89 755 diags.fragment("type.req.ref"),
duke@1 756 t);
duke@1 757 }
duke@1 758
duke@1 759 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 760 * Return true if it doesn't.
duke@1 761 * @param pos Position to be used for error reporting.
duke@1 762 * @param flags The set of flags to be checked.
duke@1 763 * @param set1 Conflicting flags set #1.
duke@1 764 * @param set2 Conflicting flags set #2.
duke@1 765 */
duke@1 766 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 767 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 768 log.error(pos,
duke@1 769 "illegal.combination.of.modifiers",
mcimadamore@80 770 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 771 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 772 return false;
duke@1 773 } else
duke@1 774 return true;
duke@1 775 }
duke@1 776
mcimadamore@914 777 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 778 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 779 */
mcimadamore@914 780 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 781 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 782 t.isErroneous()) {
mcimadamore@914 783 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 784 } else if (tree.def != null) {
mcimadamore@914 785 log.error(tree.clazz.pos(),
mcimadamore@914 786 "cant.apply.diamond.1",
mcimadamore@914 787 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 788 return types.createErrorType(t);
mcimadamore@948 789 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 790 log.error(tree.clazz.pos(),
mcimadamore@914 791 "cant.apply.diamond.1",
mcimadamore@914 792 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 793 return types.createErrorType(t);
mcimadamore@993 794 } else if (tree.typeargs != null &&
mcimadamore@993 795 tree.typeargs.nonEmpty()) {
mcimadamore@993 796 log.error(tree.clazz.pos(),
mcimadamore@993 797 "cant.apply.diamond.1",
mcimadamore@993 798 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 799 return types.createErrorType(t);
mcimadamore@914 800 } else {
mcimadamore@914 801 return t;
mcimadamore@537 802 }
mcimadamore@537 803 }
mcimadamore@537 804
mcimadamore@795 805 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 806 MethodSymbol m = tree.sym;
mcimadamore@795 807 if (!allowSimplifiedVarargs) return;
mcimadamore@795 808 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 809 Type varargElemType = null;
mcimadamore@580 810 if (m.isVarArgs()) {
mcimadamore@795 811 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 812 }
mcimadamore@795 813 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 814 if (varargElemType != null) {
mcimadamore@795 815 log.error(tree,
mcimadamore@795 816 "varargs.invalid.trustme.anno",
mcimadamore@795 817 syms.trustMeType.tsym,
mcimadamore@795 818 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 819 } else {
mcimadamore@795 820 log.error(tree,
mcimadamore@795 821 "varargs.invalid.trustme.anno",
mcimadamore@795 822 syms.trustMeType.tsym,
mcimadamore@795 823 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 824 }
mcimadamore@795 825 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 826 types.isReifiable(varargElemType)) {
mcimadamore@795 827 warnUnsafeVararg(tree,
mcimadamore@795 828 "varargs.redundant.trustme.anno",
mcimadamore@795 829 syms.trustMeType.tsym,
mcimadamore@795 830 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 831 }
mcimadamore@795 832 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 833 !types.isReifiable(varargElemType)) {
mcimadamore@795 834 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 835 }
mcimadamore@580 836 }
mcimadamore@795 837 //where
mcimadamore@795 838 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 839 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 840 (s.isConstructor() ||
mcimadamore@795 841 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 842 }
mcimadamore@580 843
mcimadamore@1219 844 Type checkMethod(Type owntype,
mcimadamore@1219 845 Symbol sym,
mcimadamore@1219 846 Env<AttrContext> env,
mcimadamore@1219 847 final List<JCExpression> argtrees,
mcimadamore@1219 848 List<Type> argtypes,
mcimadamore@1226 849 boolean useVarargs,
mcimadamore@1226 850 boolean unchecked) {
mcimadamore@1219 851 // System.out.println("call : " + env.tree);
mcimadamore@1219 852 // System.out.println("method : " + owntype);
mcimadamore@1219 853 // System.out.println("actuals: " + argtypes);
mcimadamore@1219 854 List<Type> formals = owntype.getParameterTypes();
mcimadamore@1219 855 Type last = useVarargs ? formals.last() : null;
mcimadamore@1219 856 if (sym.name==names.init &&
mcimadamore@1219 857 sym.owner == syms.enumSym)
mcimadamore@1219 858 formals = formals.tail.tail;
mcimadamore@1219 859 List<JCExpression> args = argtrees;
mcimadamore@1347 860 DeferredAttr.DeferredTypeMap checkDeferredMap =
mcimadamore@1347 861 deferredAttr.new DeferredTypeMap(DeferredAttr.AttrMode.CHECK, sym, env.info.pendingResolutionPhase);
mcimadamore@1352 862 if (args != null) {
mcimadamore@1352 863 //this is null when type-checking a method reference
mcimadamore@1352 864 while (formals.head != last) {
mcimadamore@1219 865 JCTree arg = args.head;
mcimadamore@1352 866 Warner warn = convertWarner(arg.pos(), arg.type, formals.head);
mcimadamore@1352 867 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 868 args = args.tail;
mcimadamore@1352 869 formals = formals.tail;
mcimadamore@1219 870 }
mcimadamore@1352 871 if (useVarargs) {
mcimadamore@1352 872 Type varArg = types.elemtype(last);
mcimadamore@1352 873 while (args.tail != null) {
mcimadamore@1352 874 JCTree arg = args.head;
mcimadamore@1352 875 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1352 876 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1352 877 args = args.tail;
mcimadamore@1352 878 }
mcimadamore@1352 879 } else if ((sym.flags() & VARARGS) != 0 && allowVarargs) {
mcimadamore@1352 880 // non-varargs call to varargs method
mcimadamore@1352 881 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1352 882 Type lastArg = checkDeferredMap.apply(argtypes.last());
mcimadamore@1352 883 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
mcimadamore@1352 884 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1352 885 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
mcimadamore@1352 886 types.elemtype(varParam), varParam);
mcimadamore@1352 887 }
mcimadamore@1219 888 }
mcimadamore@1226 889 if (unchecked) {
mcimadamore@1219 890 warnUnchecked(env.tree.pos(),
mcimadamore@1219 891 "unchecked.meth.invocation.applied",
mcimadamore@1219 892 kindName(sym),
mcimadamore@1219 893 sym.name,
mcimadamore@1219 894 rs.methodArguments(sym.type.getParameterTypes()),
mcimadamore@1347 895 rs.methodArguments(Type.map(argtypes, checkDeferredMap)),
mcimadamore@1219 896 kindName(sym.location()),
mcimadamore@1219 897 sym.location());
mcimadamore@1219 898 owntype = new MethodType(owntype.getParameterTypes(),
mcimadamore@1219 899 types.erasure(owntype.getReturnType()),
mcimadamore@1219 900 types.erasure(owntype.getThrownTypes()),
mcimadamore@1219 901 syms.methodClass);
mcimadamore@1219 902 }
mcimadamore@1219 903 if (useVarargs) {
mcimadamore@1219 904 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 905 if (!types.isReifiable(argtype) &&
mcimadamore@1219 906 (!allowSimplifiedVarargs ||
mcimadamore@1219 907 sym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@1219 908 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 909 warnUnchecked(env.tree.pos(),
mcimadamore@1219 910 "unchecked.generic.array.creation",
mcimadamore@1219 911 argtype);
mcimadamore@1219 912 }
mcimadamore@1415 913 if (!((MethodSymbol)sym.baseSymbol()).isSignaturePolymorphic(types)) {
mcimadamore@1510 914 TreeInfo.setVarargsElement(env.tree, types.elemtype(argtype));
mcimadamore@1219 915 }
mcimadamore@1219 916 }
mcimadamore@1510 917 PolyKind pkind = (sym.type.hasTag(FORALL) &&
mcimadamore@1510 918 sym.type.getReturnType().containsAny(((ForAll)sym.type).tvars)) ?
mcimadamore@1510 919 PolyKind.POLY : PolyKind.STANDALONE;
mcimadamore@1510 920 TreeInfo.setPolyKind(env.tree, pkind);
mcimadamore@1219 921 return owntype;
mcimadamore@547 922 }
mcimadamore@1219 923 //where
mcimadamore@1219 924 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
mcimadamore@1219 925 if (types.isConvertible(actual, formal, warn))
mcimadamore@1219 926 return;
mcimadamore@1219 927
mcimadamore@1219 928 if (formal.isCompound()
mcimadamore@1219 929 && types.isSubtype(actual, types.supertype(formal))
mcimadamore@1219 930 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
mcimadamore@1219 931 return;
mcimadamore@1219 932 }
mcimadamore@547 933
mcimadamore@821 934 /**
mcimadamore@821 935 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 936 * (see JLS 4.5)
mcimadamore@821 937 *
mcimadamore@821 938 * @param t class type to be checked
mcimadamore@821 939 * @return true if 't' is well-formed
mcimadamore@821 940 */
mcimadamore@821 941 public boolean checkValidGenericType(Type t) {
mcimadamore@821 942 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 943 }
mcimadamore@821 944 //WHERE
mcimadamore@821 945 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 946 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 947 List<Type> actuals = type.allparams();
mcimadamore@821 948 List<Type> args = type.getTypeArguments();
mcimadamore@821 949 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 950 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 951
mcimadamore@821 952 // For matching pairs of actual argument types `a' and
mcimadamore@821 953 // formal type parameters with declared bound `b' ...
mcimadamore@821 954 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 955 // exact type arguments needs to know their
mcimadamore@821 956 // bounds (for upper and lower bound
mcimadamore@1216 957 // calculations). So we create new bounds where
mcimadamore@1216 958 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 959 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 960 args = args.tail;
mcimadamore@821 961 forms = forms.tail;
mcimadamore@821 962 }
mcimadamore@821 963
mcimadamore@821 964 args = type.getTypeArguments();
mcimadamore@821 965 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 966 formals,
mcimadamore@821 967 types.capture(type).allparams());
mcimadamore@821 968 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 969 // Let the actual arguments know their bound
mcimadamore@821 970 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 971 args = args.tail;
mcimadamore@821 972 tvars_cap = tvars_cap.tail;
mcimadamore@821 973 }
mcimadamore@821 974
mcimadamore@821 975 args = type.getTypeArguments();
mcimadamore@1216 976 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 977
mcimadamore@1216 978 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 979 Type actual = args.head;
mcimadamore@854 980 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 981 !bounds.head.isErroneous() &&
mcimadamore@1216 982 !checkExtends(actual, bounds.head)) {
mcimadamore@821 983 return args.head;
mcimadamore@821 984 }
mcimadamore@821 985 args = args.tail;
mcimadamore@1216 986 bounds = bounds.tail;
mcimadamore@821 987 }
mcimadamore@821 988
mcimadamore@821 989 args = type.getTypeArguments();
mcimadamore@1216 990 bounds = bounds_buf.toList();
mcimadamore@821 991
mcimadamore@821 992 for (Type arg : types.capture(type).getTypeArguments()) {
jjg@1374 993 if (arg.hasTag(TYPEVAR) &&
mcimadamore@828 994 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 995 !bounds.head.isErroneous() &&
mcimadamore@854 996 !isTypeArgErroneous(args.head)) {
mcimadamore@821 997 return args.head;
mcimadamore@821 998 }
mcimadamore@1216 999 bounds = bounds.tail;
mcimadamore@854 1000 args = args.tail;
mcimadamore@821 1001 }
mcimadamore@821 1002
mcimadamore@821 1003 return null;
mcimadamore@821 1004 }
mcimadamore@854 1005 //where
mcimadamore@854 1006 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 1007 return isTypeArgErroneous.visit(t);
mcimadamore@854 1008 }
mcimadamore@854 1009
mcimadamore@854 1010 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 1011 public Boolean visitType(Type t, Void s) {
mcimadamore@854 1012 return t.isErroneous();
mcimadamore@854 1013 }
mcimadamore@854 1014 @Override
mcimadamore@854 1015 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 1016 return visit(t.getUpperBound());
mcimadamore@854 1017 }
mcimadamore@854 1018 @Override
mcimadamore@854 1019 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 1020 return visit(t.getUpperBound()) ||
mcimadamore@854 1021 visit(t.getLowerBound());
mcimadamore@854 1022 }
mcimadamore@854 1023 @Override
mcimadamore@854 1024 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1025 return visit(t.type);
mcimadamore@854 1026 }
mcimadamore@854 1027 };
mcimadamore@821 1028
duke@1 1029 /** Check that given modifiers are legal for given symbol and
duke@1 1030 * return modifiers together with any implicit modififiers for that symbol.
duke@1 1031 * Warning: we can't use flags() here since this method
duke@1 1032 * is called during class enter, when flags() would cause a premature
duke@1 1033 * completion.
duke@1 1034 * @param pos Position to be used for error reporting.
duke@1 1035 * @param flags The set of modifiers given in a definition.
duke@1 1036 * @param sym The defined symbol.
duke@1 1037 */
duke@1 1038 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1039 long mask;
duke@1 1040 long implicit = 0;
duke@1 1041 switch (sym.kind) {
duke@1 1042 case VAR:
duke@1 1043 if (sym.owner.kind != TYP)
duke@1 1044 mask = LocalVarFlags;
duke@1 1045 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1046 mask = implicit = InterfaceVarFlags;
duke@1 1047 else
duke@1 1048 mask = VarFlags;
duke@1 1049 break;
duke@1 1050 case MTH:
duke@1 1051 if (sym.name == names.init) {
duke@1 1052 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1053 // enum constructors cannot be declared public or
duke@1 1054 // protected and must be implicitly or explicitly
duke@1 1055 // private
duke@1 1056 implicit = PRIVATE;
duke@1 1057 mask = PRIVATE;
duke@1 1058 } else
duke@1 1059 mask = ConstructorFlags;
mcimadamore@1366 1060 } else if ((sym.owner.flags_field & INTERFACE) != 0) {
mcimadamore@1513 1061 if ((flags & (DEFAULT | STATIC)) != 0) {
mcimadamore@1513 1062 mask = InterfaceMethodMask;
mcimadamore@1513 1063 implicit = PUBLIC;
mcimadamore@1513 1064 if ((flags & DEFAULT) != 0) {
mcimadamore@1513 1065 implicit |= ABSTRACT;
mcimadamore@1513 1066 }
mcimadamore@1366 1067 } else {
mcimadamore@1366 1068 mask = implicit = InterfaceMethodFlags;
mcimadamore@1366 1069 }
mcimadamore@1366 1070 }
duke@1 1071 else {
duke@1 1072 mask = MethodFlags;
duke@1 1073 }
duke@1 1074 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1075 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 1076 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1077 break;
duke@1 1078 case TYP:
duke@1 1079 if (sym.isLocal()) {
duke@1 1080 mask = LocalClassFlags;
jjg@113 1081 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1082 // Anonymous classes in static methods are themselves static;
duke@1 1083 // that's why we admit STATIC here.
duke@1 1084 mask |= STATIC;
duke@1 1085 // JLS: Anonymous classes are final.
duke@1 1086 implicit |= FINAL;
duke@1 1087 }
duke@1 1088 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1089 (flags & ENUM) != 0)
duke@1 1090 log.error(pos, "enums.must.be.static");
duke@1 1091 } else if (sym.owner.kind == TYP) {
duke@1 1092 mask = MemberClassFlags;
duke@1 1093 if (sym.owner.owner.kind == PCK ||
duke@1 1094 (sym.owner.flags_field & STATIC) != 0)
duke@1 1095 mask |= STATIC;
duke@1 1096 else if ((flags & ENUM) != 0)
duke@1 1097 log.error(pos, "enums.must.be.static");
duke@1 1098 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1099 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1100 } else {
duke@1 1101 mask = ClassFlags;
duke@1 1102 }
duke@1 1103 // Interfaces are always ABSTRACT
duke@1 1104 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1105
duke@1 1106 if ((flags & ENUM) != 0) {
duke@1 1107 // enums can't be declared abstract or final
duke@1 1108 mask &= ~(ABSTRACT | FINAL);
duke@1 1109 implicit |= implicitEnumFinalFlag(tree);
duke@1 1110 }
duke@1 1111 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1112 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1113 break;
duke@1 1114 default:
duke@1 1115 throw new AssertionError();
duke@1 1116 }
mcimadamore@1366 1117 long illegal = flags & ExtendedStandardFlags & ~mask;
duke@1 1118 if (illegal != 0) {
duke@1 1119 if ((illegal & INTERFACE) != 0) {
duke@1 1120 log.error(pos, "intf.not.allowed.here");
duke@1 1121 mask |= INTERFACE;
duke@1 1122 }
duke@1 1123 else {
duke@1 1124 log.error(pos,
mcimadamore@80 1125 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1126 }
duke@1 1127 }
duke@1 1128 else if ((sym.kind == TYP ||
duke@1 1129 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1130 // in the presence of inner classes. Should it be deleted here?
duke@1 1131 checkDisjoint(pos, flags,
duke@1 1132 ABSTRACT,
mcimadamore@1366 1133 PRIVATE | STATIC | DEFAULT))
duke@1 1134 &&
duke@1 1135 checkDisjoint(pos, flags,
mcimadamore@1513 1136 STATIC,
mcimadamore@1513 1137 DEFAULT)
mcimadamore@1513 1138 &&
mcimadamore@1513 1139 checkDisjoint(pos, flags,
duke@1 1140 ABSTRACT | INTERFACE,
duke@1 1141 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1142 &&
duke@1 1143 checkDisjoint(pos, flags,
duke@1 1144 PUBLIC,
duke@1 1145 PRIVATE | PROTECTED)
duke@1 1146 &&
duke@1 1147 checkDisjoint(pos, flags,
duke@1 1148 PRIVATE,
duke@1 1149 PUBLIC | PROTECTED)
duke@1 1150 &&
duke@1 1151 checkDisjoint(pos, flags,
duke@1 1152 FINAL,
duke@1 1153 VOLATILE)
duke@1 1154 &&
duke@1 1155 (sym.kind == TYP ||
duke@1 1156 checkDisjoint(pos, flags,
duke@1 1157 ABSTRACT | NATIVE,
duke@1 1158 STRICTFP))) {
duke@1 1159 // skip
duke@1 1160 }
mcimadamore@1366 1161 return flags & (mask | ~ExtendedStandardFlags) | implicit;
duke@1 1162 }
duke@1 1163
duke@1 1164
duke@1 1165 /** Determine if this enum should be implicitly final.
duke@1 1166 *
duke@1 1167 * If the enum has no specialized enum contants, it is final.
duke@1 1168 *
duke@1 1169 * If the enum does have specialized enum contants, it is
duke@1 1170 * <i>not</i> final.
duke@1 1171 */
duke@1 1172 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1173 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1174 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1175 boolean specialized;
duke@1 1176 SpecialTreeVisitor() {
duke@1 1177 this.specialized = false;
duke@1 1178 };
duke@1 1179
jjg@398 1180 @Override
duke@1 1181 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1182
jjg@398 1183 @Override
duke@1 1184 public void visitVarDef(JCVariableDecl tree) {
duke@1 1185 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1186 if (tree.init instanceof JCNewClass &&
duke@1 1187 ((JCNewClass) tree.init).def != null) {
duke@1 1188 specialized = true;
duke@1 1189 }
duke@1 1190 }
duke@1 1191 }
duke@1 1192 }
duke@1 1193
duke@1 1194 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1195 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1196 for (JCTree defs: cdef.defs) {
duke@1 1197 defs.accept(sts);
duke@1 1198 if (sts.specialized) return 0;
duke@1 1199 }
duke@1 1200 return FINAL;
duke@1 1201 }
duke@1 1202
duke@1 1203 /* *************************************************************************
duke@1 1204 * Type Validation
duke@1 1205 **************************************************************************/
duke@1 1206
duke@1 1207 /** Validate a type expression. That is,
duke@1 1208 * check that all type arguments of a parametric type are within
duke@1 1209 * their bounds. This must be done in a second phase after type attributon
duke@1 1210 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1211 *
jjg@1358 1212 * <pre>{@code
duke@1 1213 * class B<A extends C> { ... }
duke@1 1214 * class C extends B<C> { ... }
jjg@1358 1215 * }</pre>
duke@1 1216 *
duke@1 1217 * and we can't make sure that the bound is already attributed because
duke@1 1218 * of possible cycles.
mcimadamore@638 1219 *
mcimadamore@638 1220 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1221 * and reporting any completion failures.
duke@1 1222 */
mcimadamore@122 1223 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1224 validate(tree, env, true);
duke@1 1225 }
mcimadamore@638 1226 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1227 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1228 }
duke@1 1229
duke@1 1230 /** Visitor method: Validate a list of type expressions.
duke@1 1231 */
mcimadamore@122 1232 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1233 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1234 validate(l.head, env);
duke@1 1235 }
duke@1 1236
duke@1 1237 /** A visitor class for type validation.
duke@1 1238 */
duke@1 1239 class Validator extends JCTree.Visitor {
duke@1 1240
mcimadamore@638 1241 boolean isOuter;
mcimadamore@638 1242 Env<AttrContext> env;
mcimadamore@638 1243
mcimadamore@638 1244 Validator(Env<AttrContext> env) {
mcimadamore@638 1245 this.env = env;
mcimadamore@638 1246 }
mcimadamore@638 1247
jjg@398 1248 @Override
duke@1 1249 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1250 tree.elemtype.accept(this);
duke@1 1251 }
duke@1 1252
jjg@398 1253 @Override
duke@1 1254 public void visitTypeApply(JCTypeApply tree) {
jjg@1374 1255 if (tree.type.hasTag(CLASS)) {
duke@1 1256 List<JCExpression> args = tree.arguments;
mcimadamore@158 1257 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1258
mcimadamore@821 1259 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1260 if (incompatibleArg != null) {
mcimadamore@821 1261 for (JCTree arg : tree.arguments) {
mcimadamore@821 1262 if (arg.type == incompatibleArg) {
mcimadamore@829 1263 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1264 }
mcimadamore@829 1265 forms = forms.tail;
mcimadamore@829 1266 }
mcimadamore@829 1267 }
mcimadamore@829 1268
mcimadamore@829 1269 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1270
mcimadamore@638 1271 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1272
duke@1 1273 // For matching pairs of actual argument types `a' and
duke@1 1274 // formal type parameters with declared bound `b' ...
duke@1 1275 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1276 validateTree(args.head,
mcimadamore@638 1277 !(isOuter && is_java_lang_Class),
mcimadamore@638 1278 false);
duke@1 1279 args = args.tail;
duke@1 1280 forms = forms.tail;
duke@1 1281 }
duke@1 1282
duke@1 1283 // Check that this type is either fully parameterized, or
duke@1 1284 // not parameterized at all.
duke@1 1285 if (tree.type.getEnclosingType().isRaw())
duke@1 1286 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1287 if (tree.clazz.hasTag(SELECT))
duke@1 1288 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1289 }
duke@1 1290 }
duke@1 1291
jjg@398 1292 @Override
duke@1 1293 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1294 validateTrees(tree.bounds, true, isOuter);
duke@1 1295 checkClassBounds(tree.pos(), tree.type);
duke@1 1296 }
duke@1 1297
duke@1 1298 @Override
duke@1 1299 public void visitWildcard(JCWildcard tree) {
duke@1 1300 if (tree.inner != null)
mcimadamore@638 1301 validateTree(tree.inner, true, isOuter);
duke@1 1302 }
duke@1 1303
jjg@398 1304 @Override
duke@1 1305 public void visitSelect(JCFieldAccess tree) {
jjg@1374 1306 if (tree.type.hasTag(CLASS)) {
duke@1 1307 visitSelectInternal(tree);
duke@1 1308
duke@1 1309 // Check that this type is either fully parameterized, or
duke@1 1310 // not parameterized at all.
duke@1 1311 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1312 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1313 }
duke@1 1314 }
mcimadamore@852 1315
duke@1 1316 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1317 if (tree.type.tsym.isStatic() &&
duke@1 1318 tree.selected.type.isParameterized()) {
duke@1 1319 // The enclosing type is not a class, so we are
duke@1 1320 // looking at a static member type. However, the
duke@1 1321 // qualifying expression is parameterized.
duke@1 1322 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1323 } else {
duke@1 1324 // otherwise validate the rest of the expression
mcimadamore@122 1325 tree.selected.accept(this);
duke@1 1326 }
duke@1 1327 }
duke@1 1328
duke@1 1329 /** Default visitor method: do nothing.
duke@1 1330 */
jjg@398 1331 @Override
duke@1 1332 public void visitTree(JCTree tree) {
duke@1 1333 }
mcimadamore@122 1334
mcimadamore@638 1335 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1336 try {
mcimadamore@638 1337 if (tree != null) {
mcimadamore@638 1338 this.isOuter = isOuter;
mcimadamore@638 1339 tree.accept(this);
mcimadamore@638 1340 if (checkRaw)
mcimadamore@638 1341 checkRaw(tree, env);
mcimadamore@638 1342 }
mcimadamore@638 1343 } catch (CompletionFailure ex) {
mcimadamore@638 1344 completionError(tree.pos(), ex);
mcimadamore@638 1345 }
mcimadamore@638 1346 }
mcimadamore@638 1347
mcimadamore@638 1348 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1349 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1350 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1351 }
mcimadamore@638 1352
mcimadamore@638 1353 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1354 if (lint.isEnabled(LintCategory.RAW) &&
jjg@1374 1355 tree.type.hasTag(CLASS) &&
mcimadamore@638 1356 !TreeInfo.isDiamond(tree) &&
mcimadamore@1103 1357 !withinAnonConstr(env) &&
mcimadamore@638 1358 tree.type.isRaw()) {
mcimadamore@795 1359 log.warning(LintCategory.RAW,
mcimadamore@638 1360 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1361 }
mcimadamore@638 1362 }
mcimadamore@1103 1363
mcimadamore@1103 1364 boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1365 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1366 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1367 }
duke@1 1368 }
duke@1 1369
duke@1 1370 /* *************************************************************************
duke@1 1371 * Exception checking
duke@1 1372 **************************************************************************/
duke@1 1373
duke@1 1374 /* The following methods treat classes as sets that contain
duke@1 1375 * the class itself and all their subclasses
duke@1 1376 */
duke@1 1377
duke@1 1378 /** Is given type a subtype of some of the types in given list?
duke@1 1379 */
duke@1 1380 boolean subset(Type t, List<Type> ts) {
duke@1 1381 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1382 if (types.isSubtype(t, l.head)) return true;
duke@1 1383 return false;
duke@1 1384 }
duke@1 1385
duke@1 1386 /** Is given type a subtype or supertype of
duke@1 1387 * some of the types in given list?
duke@1 1388 */
duke@1 1389 boolean intersects(Type t, List<Type> ts) {
duke@1 1390 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1391 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1392 return false;
duke@1 1393 }
duke@1 1394
duke@1 1395 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1396 * in the list.
duke@1 1397 */
duke@1 1398 List<Type> incl(Type t, List<Type> ts) {
duke@1 1399 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1400 }
duke@1 1401
duke@1 1402 /** Remove type set from type set list.
duke@1 1403 */
duke@1 1404 List<Type> excl(Type t, List<Type> ts) {
duke@1 1405 if (ts.isEmpty()) {
duke@1 1406 return ts;
duke@1 1407 } else {
duke@1 1408 List<Type> ts1 = excl(t, ts.tail);
duke@1 1409 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1410 else if (ts1 == ts.tail) return ts;
duke@1 1411 else return ts1.prepend(ts.head);
duke@1 1412 }
duke@1 1413 }
duke@1 1414
duke@1 1415 /** Form the union of two type set lists.
duke@1 1416 */
duke@1 1417 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1418 List<Type> ts = ts1;
duke@1 1419 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1420 ts = incl(l.head, ts);
duke@1 1421 return ts;
duke@1 1422 }
duke@1 1423
duke@1 1424 /** Form the difference of two type lists.
duke@1 1425 */
duke@1 1426 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1427 List<Type> ts = ts1;
duke@1 1428 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1429 ts = excl(l.head, ts);
duke@1 1430 return ts;
duke@1 1431 }
duke@1 1432
duke@1 1433 /** Form the intersection of two type lists.
duke@1 1434 */
duke@1 1435 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1436 List<Type> ts = List.nil();
duke@1 1437 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1438 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1439 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1440 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1441 return ts;
duke@1 1442 }
duke@1 1443
duke@1 1444 /** Is exc an exception symbol that need not be declared?
duke@1 1445 */
duke@1 1446 boolean isUnchecked(ClassSymbol exc) {
duke@1 1447 return
duke@1 1448 exc.kind == ERR ||
duke@1 1449 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1450 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1451 }
duke@1 1452
duke@1 1453 /** Is exc an exception type that need not be declared?
duke@1 1454 */
duke@1 1455 boolean isUnchecked(Type exc) {
duke@1 1456 return
jjg@1374 1457 (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
jjg@1374 1458 (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
jjg@1374 1459 exc.hasTag(BOT);
duke@1 1460 }
duke@1 1461
duke@1 1462 /** Same, but handling completion failures.
duke@1 1463 */
duke@1 1464 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1465 try {
duke@1 1466 return isUnchecked(exc);
duke@1 1467 } catch (CompletionFailure ex) {
duke@1 1468 completionError(pos, ex);
duke@1 1469 return true;
duke@1 1470 }
duke@1 1471 }
duke@1 1472
duke@1 1473 /** Is exc handled by given exception list?
duke@1 1474 */
duke@1 1475 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1476 return isUnchecked(exc) || subset(exc, handled);
duke@1 1477 }
duke@1 1478
duke@1 1479 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1480 * @param thrown The list of thrown exceptions.
duke@1 1481 * @param handled The list of handled exceptions.
duke@1 1482 */
mcimadamore@362 1483 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1484 List<Type> unhandled = List.nil();
duke@1 1485 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1486 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1487 return unhandled;
duke@1 1488 }
duke@1 1489
duke@1 1490 /* *************************************************************************
duke@1 1491 * Overriding/Implementation checking
duke@1 1492 **************************************************************************/
duke@1 1493
duke@1 1494 /** The level of access protection given by a flag set,
duke@1 1495 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1496 */
duke@1 1497 static int protection(long flags) {
duke@1 1498 switch ((short)(flags & AccessFlags)) {
duke@1 1499 case PRIVATE: return 3;
duke@1 1500 case PROTECTED: return 1;
duke@1 1501 default:
duke@1 1502 case PUBLIC: return 0;
duke@1 1503 case 0: return 2;
duke@1 1504 }
duke@1 1505 }
duke@1 1506
duke@1 1507 /** A customized "cannot override" error message.
duke@1 1508 * @param m The overriding method.
duke@1 1509 * @param other The overridden method.
duke@1 1510 * @return An internationalized string.
duke@1 1511 */
mcimadamore@89 1512 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1513 String key;
duke@1 1514 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1515 key = "cant.override";
duke@1 1516 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1517 key = "cant.implement";
duke@1 1518 else
duke@1 1519 key = "clashes.with";
mcimadamore@89 1520 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1521 }
duke@1 1522
duke@1 1523 /** A customized "override" warning message.
duke@1 1524 * @param m The overriding method.
duke@1 1525 * @param other The overridden method.
duke@1 1526 * @return An internationalized string.
duke@1 1527 */
mcimadamore@89 1528 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1529 String key;
duke@1 1530 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1531 key = "unchecked.override";
duke@1 1532 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1533 key = "unchecked.implement";
duke@1 1534 else
duke@1 1535 key = "unchecked.clash.with";
mcimadamore@89 1536 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1537 }
duke@1 1538
duke@1 1539 /** A customized "override" warning message.
duke@1 1540 * @param m The overriding method.
duke@1 1541 * @param other The overridden method.
duke@1 1542 * @return An internationalized string.
duke@1 1543 */
mcimadamore@89 1544 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1545 String key;
duke@1 1546 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1547 key = "varargs.override";
duke@1 1548 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1549 key = "varargs.implement";
duke@1 1550 else
duke@1 1551 key = "varargs.clash.with";
mcimadamore@89 1552 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1553 }
duke@1 1554
duke@1 1555 /** Check that this method conforms with overridden method 'other'.
duke@1 1556 * where `origin' is the class where checking started.
duke@1 1557 * Complications:
duke@1 1558 * (1) Do not check overriding of synthetic methods
duke@1 1559 * (reason: they might be final).
duke@1 1560 * todo: check whether this is still necessary.
duke@1 1561 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1562 * than the method it implements. Augment the proxy methods with the
duke@1 1563 * undeclared exceptions in this case.
duke@1 1564 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1565 * has a result type
duke@1 1566 * extended by the result type of the method it implements.
duke@1 1567 * Change the proxies result type to the smaller type in this case.
duke@1 1568 *
duke@1 1569 * @param tree The tree from which positions
duke@1 1570 * are extracted for errors.
duke@1 1571 * @param m The overriding method.
duke@1 1572 * @param other The overridden method.
duke@1 1573 * @param origin The class of which the overriding method
duke@1 1574 * is a member.
duke@1 1575 */
duke@1 1576 void checkOverride(JCTree tree,
duke@1 1577 MethodSymbol m,
duke@1 1578 MethodSymbol other,
duke@1 1579 ClassSymbol origin) {
duke@1 1580 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1581 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1582 return;
duke@1 1583 }
duke@1 1584
duke@1 1585 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1586 if ((m.flags() & STATIC) != 0 &&
duke@1 1587 (other.flags() & STATIC) == 0) {
duke@1 1588 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1589 cannotOverride(m, other));
duke@1 1590 return;
duke@1 1591 }
duke@1 1592
duke@1 1593 // Error if instance method overrides static or final
duke@1 1594 // method (JLS 8.4.6.1).
duke@1 1595 if ((other.flags() & FINAL) != 0 ||
duke@1 1596 (m.flags() & STATIC) == 0 &&
duke@1 1597 (other.flags() & STATIC) != 0) {
duke@1 1598 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1599 cannotOverride(m, other),
mcimadamore@80 1600 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1601 return;
duke@1 1602 }
duke@1 1603
duke@1 1604 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1605 // handled in validateAnnotationMethod
duke@1 1606 return;
duke@1 1607 }
duke@1 1608
duke@1 1609 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1610 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1611 protection(m.flags()) > protection(other.flags())) {
duke@1 1612 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1613 cannotOverride(m, other),
mcimadamore@80 1614 other.flags() == 0 ?
mcimadamore@80 1615 Flag.PACKAGE :
mcimadamore@80 1616 asFlagSet(other.flags() & AccessFlags));
duke@1 1617 return;
duke@1 1618 }
duke@1 1619
duke@1 1620 Type mt = types.memberType(origin.type, m);
duke@1 1621 Type ot = types.memberType(origin.type, other);
duke@1 1622 // Error if overriding result type is different
duke@1 1623 // (or, in the case of generics mode, not a subtype) of
duke@1 1624 // overridden result type. We have to rename any type parameters
duke@1 1625 // before comparing types.
duke@1 1626 List<Type> mtvars = mt.getTypeArguments();
duke@1 1627 List<Type> otvars = ot.getTypeArguments();
duke@1 1628 Type mtres = mt.getReturnType();
duke@1 1629 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1630
mcimadamore@795 1631 overrideWarner.clear();
duke@1 1632 boolean resultTypesOK =
tbell@202 1633 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1634 if (!resultTypesOK) {
jjg@398 1635 if (!allowCovariantReturns &&
duke@1 1636 m.owner != origin &&
duke@1 1637 m.owner.isSubClass(other.owner, types)) {
duke@1 1638 // allow limited interoperability with covariant returns
duke@1 1639 } else {
mcimadamore@362 1640 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1641 "override.incompatible.ret",
mcimadamore@362 1642 cannotOverride(m, other),
duke@1 1643 mtres, otres);
duke@1 1644 return;
duke@1 1645 }
mcimadamore@795 1646 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1647 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1648 "override.unchecked.ret",
mcimadamore@362 1649 uncheckedOverrides(m, other),
mcimadamore@362 1650 mtres, otres);
duke@1 1651 }
duke@1 1652
duke@1 1653 // Error if overriding method throws an exception not reported
duke@1 1654 // by overridden method.
duke@1 1655 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1656 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1657 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1658 if (unhandledErased.nonEmpty()) {
duke@1 1659 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1660 "override.meth.doesnt.throw",
duke@1 1661 cannotOverride(m, other),
mcimadamore@362 1662 unhandledUnerased.head);
mcimadamore@362 1663 return;
mcimadamore@362 1664 }
mcimadamore@362 1665 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1666 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1667 "override.unchecked.thrown",
mcimadamore@362 1668 cannotOverride(m, other),
mcimadamore@362 1669 unhandledUnerased.head);
duke@1 1670 return;
duke@1 1671 }
duke@1 1672
duke@1 1673 // Optional warning if varargs don't agree
duke@1 1674 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1675 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1676 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1677 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1678 ? "override.varargs.missing"
duke@1 1679 : "override.varargs.extra",
duke@1 1680 varargsOverrides(m, other));
duke@1 1681 }
duke@1 1682
duke@1 1683 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1684 if ((other.flags() & BRIDGE) != 0) {
duke@1 1685 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1686 uncheckedOverrides(m, other));
duke@1 1687 }
duke@1 1688
duke@1 1689 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1690 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1691 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1692 }
duke@1 1693 }
duke@1 1694 // where
duke@1 1695 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1696 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1697 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1698 // because in that case, we will rediscover the issue when examining the method
duke@1 1699 // in the supertype.
duke@1 1700 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1701 // address the issue is when the method is the supertype implemementation: any other
duke@1 1702 // case, we will have dealt with when examining the supertype classes
duke@1 1703 ClassSymbol mc = m.enclClass();
duke@1 1704 Type st = types.supertype(origin.type);
jjg@1374 1705 if (!st.hasTag(CLASS))
duke@1 1706 return true;
duke@1 1707 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1708
duke@1 1709 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1710 List<Type> intfs = types.interfaces(origin.type);
duke@1 1711 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1712 }
duke@1 1713 else
duke@1 1714 return (stimpl != m);
duke@1 1715 }
duke@1 1716
duke@1 1717
duke@1 1718 // used to check if there were any unchecked conversions
duke@1 1719 Warner overrideWarner = new Warner();
duke@1 1720
duke@1 1721 /** Check that a class does not inherit two concrete methods
duke@1 1722 * with the same signature.
duke@1 1723 * @param pos Position to be used for error reporting.
duke@1 1724 * @param site The class type to be checked.
duke@1 1725 */
duke@1 1726 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1727 Type sup = types.supertype(site);
jjg@1374 1728 if (!sup.hasTag(CLASS)) return;
duke@1 1729
duke@1 1730 for (Type t1 = sup;
duke@1 1731 t1.tsym.type.isParameterized();
duke@1 1732 t1 = types.supertype(t1)) {
duke@1 1733 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1734 e1 != null;
duke@1 1735 e1 = e1.sibling) {
duke@1 1736 Symbol s1 = e1.sym;
duke@1 1737 if (s1.kind != MTH ||
duke@1 1738 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1739 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1740 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1741 types,
duke@1 1742 true) != s1)
duke@1 1743 continue;
duke@1 1744 Type st1 = types.memberType(t1, s1);
duke@1 1745 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1746 if (st1 == s1.type) continue;
duke@1 1747
duke@1 1748 for (Type t2 = sup;
jjg@1374 1749 t2.hasTag(CLASS);
duke@1 1750 t2 = types.supertype(t2)) {
mcimadamore@24 1751 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1752 e2.scope != null;
duke@1 1753 e2 = e2.next()) {
duke@1 1754 Symbol s2 = e2.sym;
duke@1 1755 if (s2 == s1 ||
duke@1 1756 s2.kind != MTH ||
duke@1 1757 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1758 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1759 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1760 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1761 types,
duke@1 1762 true) != s2)
duke@1 1763 continue;
duke@1 1764 Type st2 = types.memberType(t2, s2);
duke@1 1765 if (types.overrideEquivalent(st1, st2))
duke@1 1766 log.error(pos, "concrete.inheritance.conflict",
duke@1 1767 s1, t1, s2, t2, sup);
duke@1 1768 }
duke@1 1769 }
duke@1 1770 }
duke@1 1771 }
duke@1 1772 }
duke@1 1773
duke@1 1774 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1775 * method with same name and arguments but incompatible return types.
duke@1 1776 * @param pos Position to be used for error reporting.
duke@1 1777 * @param t1 The first argument type.
duke@1 1778 * @param t2 The second argument type.
duke@1 1779 */
duke@1 1780 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1781 Type t1,
duke@1 1782 Type t2) {
duke@1 1783 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1784 types.makeCompoundType(t1, t2));
duke@1 1785 }
duke@1 1786
duke@1 1787 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1788 Type t1,
duke@1 1789 Type t2,
duke@1 1790 Type site) {
mcimadamore@746 1791 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1792 }
duke@1 1793
duke@1 1794 /** Return the first method which is defined with same args
duke@1 1795 * but different return types in two given interfaces, or null if none
duke@1 1796 * exists.
duke@1 1797 * @param t1 The first type.
duke@1 1798 * @param t2 The second type.
duke@1 1799 * @param site The most derived type.
duke@1 1800 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1801 */
mcimadamore@746 1802 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1803 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1804 closure(t1, interfaces1);
duke@1 1805 Map<TypeSymbol,Type> interfaces2;
duke@1 1806 if (t1 == t2)
duke@1 1807 interfaces2 = interfaces1;
duke@1 1808 else
duke@1 1809 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1810
duke@1 1811 for (Type t3 : interfaces1.values()) {
duke@1 1812 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1813 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1814 if (s != null) return s;
duke@1 1815 }
duke@1 1816 }
duke@1 1817 return null;
duke@1 1818 }
duke@1 1819
duke@1 1820 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1821 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1822 if (!t.hasTag(CLASS)) return;
duke@1 1823 if (typeMap.put(t.tsym, t) == null) {
duke@1 1824 closure(types.supertype(t), typeMap);
duke@1 1825 for (Type i : types.interfaces(t))
duke@1 1826 closure(i, typeMap);
duke@1 1827 }
duke@1 1828 }
duke@1 1829
duke@1 1830 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1831 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1832 if (!t.hasTag(CLASS)) return;
duke@1 1833 if (typesSkip.get(t.tsym) != null) return;
duke@1 1834 if (typeMap.put(t.tsym, t) == null) {
duke@1 1835 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1836 for (Type i : types.interfaces(t))
duke@1 1837 closure(i, typesSkip, typeMap);
duke@1 1838 }
duke@1 1839 }
duke@1 1840
duke@1 1841 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1842 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1843 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1844 Symbol s1 = e1.sym;
duke@1 1845 Type st1 = null;
mcimadamore@1441 1846 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1847 (s1.flags() & SYNTHETIC) != 0) continue;
duke@1 1848 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1849 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1850 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1851 Symbol s2 = e2.sym;
duke@1 1852 if (s1 == s2) continue;
mcimadamore@1441 1853 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1854 (s2.flags() & SYNTHETIC) != 0) continue;
duke@1 1855 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1856 Type st2 = types.memberType(t2, s2);
duke@1 1857 if (types.overrideEquivalent(st1, st2)) {
duke@1 1858 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1859 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1860 Type rt1 = st1.getReturnType();
duke@1 1861 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1862 boolean compat =
duke@1 1863 types.isSameType(rt1, rt2) ||
jjg@1374 1864 !rt1.isPrimitiveOrVoid() &&
jjg@1374 1865 !rt2.isPrimitiveOrVoid() &&
mcimadamore@1415 1866 (types.covariantReturnType(rt1, rt2, types.noWarnings) ||
mcimadamore@1415 1867 types.covariantReturnType(rt2, rt1, types.noWarnings)) ||
mcimadamore@59 1868 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1869 if (!compat) {
mcimadamore@746 1870 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1871 t1, t2, s2.name +
mcimadamore@746 1872 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1873 return s2;
mcimadamore@746 1874 }
mcimadamore@889 1875 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1876 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1877 log.error(pos,
mcimadamore@746 1878 "name.clash.same.erasure.no.override",
mcimadamore@746 1879 s1, s1.location(),
mcimadamore@746 1880 s2, s2.location());
mcimadamore@746 1881 return s2;
duke@1 1882 }
duke@1 1883 }
duke@1 1884 }
duke@1 1885 return null;
duke@1 1886 }
mcimadamore@59 1887 //WHERE
mcimadamore@59 1888 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1889 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1890 Type st1 = types.memberType(site, s1);
mcimadamore@59 1891 Type st2 = types.memberType(site, s2);
mcimadamore@59 1892 closure(site, supertypes);
mcimadamore@59 1893 for (Type t : supertypes.values()) {
mcimadamore@59 1894 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1895 Symbol s3 = e.sym;
mcimadamore@59 1896 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1897 Type st3 = types.memberType(site,s3);
mcimadamore@59 1898 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1899 if (s3.owner == site.tsym) {
mcimadamore@59 1900 return true;
mcimadamore@59 1901 }
mcimadamore@59 1902 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1903 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1904 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1905 Type rt1 = st1.getReturnType();
mcimadamore@59 1906 Type rt2 = st2.getReturnType();
mcimadamore@59 1907 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1908 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1909 boolean compat =
jjg@1374 1910 !rt13.isPrimitiveOrVoid() &&
jjg@1374 1911 !rt23.isPrimitiveOrVoid() &&
mcimadamore@1415 1912 (types.covariantReturnType(rt13, rt1, types.noWarnings) &&
mcimadamore@1415 1913 types.covariantReturnType(rt23, rt2, types.noWarnings));
mcimadamore@59 1914 if (compat)
mcimadamore@59 1915 return true;
mcimadamore@59 1916 }
mcimadamore@59 1917 }
mcimadamore@59 1918 }
mcimadamore@59 1919 return false;
mcimadamore@59 1920 }
duke@1 1921
duke@1 1922 /** Check that a given method conforms with any method it overrides.
duke@1 1923 * @param tree The tree from which positions are extracted
duke@1 1924 * for errors.
duke@1 1925 * @param m The overriding method.
duke@1 1926 */
duke@1 1927 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1928 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1929 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1930 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1931 log.error(tree.pos(), "enum.no.finalize");
duke@1 1932 return;
duke@1 1933 }
jjg@1374 1934 for (Type t = origin.type; t.hasTag(CLASS);
duke@1 1935 t = types.supertype(t)) {
mcimadamore@746 1936 if (t != origin.type) {
mcimadamore@746 1937 checkOverride(tree, t, origin, m);
mcimadamore@746 1938 }
mcimadamore@746 1939 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1940 checkOverride(tree, t2, origin, m);
duke@1 1941 }
duke@1 1942 }
duke@1 1943 }
duke@1 1944
mcimadamore@746 1945 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1946 TypeSymbol c = site.tsym;
mcimadamore@746 1947 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1948 while (e.scope != null) {
mcimadamore@746 1949 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1950 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1951 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1952 }
mcimadamore@746 1953 }
mcimadamore@746 1954 e = e.next();
mcimadamore@746 1955 }
mcimadamore@746 1956 }
mcimadamore@746 1957
mcimadamore@746 1958 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 1959 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 1960 return (cf.accepts(s1) &&
mcimadamore@858 1961 cf.accepts(s2) &&
mcimadamore@858 1962 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 1963 }
mcimadamore@746 1964
mcimadamore@746 1965
duke@1 1966 /** Check that all abstract members of given class have definitions.
duke@1 1967 * @param pos Position to be used for error reporting.
duke@1 1968 * @param c The class.
duke@1 1969 */
duke@1 1970 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1971 try {
duke@1 1972 MethodSymbol undef = firstUndef(c, c);
duke@1 1973 if (undef != null) {
duke@1 1974 if ((c.flags() & ENUM) != 0 &&
duke@1 1975 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 1976 (c.flags() & FINAL) == 0) {
duke@1 1977 // add the ABSTRACT flag to an enum
duke@1 1978 c.flags_field |= ABSTRACT;
duke@1 1979 } else {
duke@1 1980 MethodSymbol undef1 =
duke@1 1981 new MethodSymbol(undef.flags(), undef.name,
duke@1 1982 types.memberType(c.type, undef), undef.owner);
duke@1 1983 log.error(pos, "does.not.override.abstract",
duke@1 1984 c, undef1, undef1.location());
duke@1 1985 }
duke@1 1986 }
duke@1 1987 } catch (CompletionFailure ex) {
duke@1 1988 completionError(pos, ex);
duke@1 1989 }
duke@1 1990 }
duke@1 1991 //where
duke@1 1992 /** Return first abstract member of class `c' that is not defined
duke@1 1993 * in `impl', null if there is none.
duke@1 1994 */
duke@1 1995 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 1996 MethodSymbol undef = null;
duke@1 1997 // Do not bother to search in classes that are not abstract,
duke@1 1998 // since they cannot have abstract members.
duke@1 1999 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 2000 Scope s = c.members();
duke@1 2001 for (Scope.Entry e = s.elems;
duke@1 2002 undef == null && e != null;
duke@1 2003 e = e.sibling) {
duke@1 2004 if (e.sym.kind == MTH &&
mcimadamore@1393 2005 (e.sym.flags() & (ABSTRACT|IPROXY|DEFAULT)) == ABSTRACT) {
duke@1 2006 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2007 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
mcimadamore@1393 2008 if (implmeth == null || implmeth == absmeth) {
mcimadamore@1393 2009 //look for default implementations
mcimadamore@1393 2010 if (allowDefaultMethods) {
mcimadamore@1393 2011 MethodSymbol prov = types.interfaceCandidates(impl.type, absmeth).head;
mcimadamore@1393 2012 if (prov != null && prov.overrides(absmeth, impl, types, true)) {
mcimadamore@1393 2013 implmeth = prov;
mcimadamore@1393 2014 }
mcimadamore@1393 2015 }
mcimadamore@1393 2016 }
mcimadamore@1393 2017 if (implmeth == null || implmeth == absmeth) {
duke@1 2018 undef = absmeth;
mcimadamore@1393 2019 }
duke@1 2020 }
duke@1 2021 }
duke@1 2022 if (undef == null) {
duke@1 2023 Type st = types.supertype(c.type);
jjg@1374 2024 if (st.hasTag(CLASS))
duke@1 2025 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 2026 }
duke@1 2027 for (List<Type> l = types.interfaces(c.type);
duke@1 2028 undef == null && l.nonEmpty();
duke@1 2029 l = l.tail) {
duke@1 2030 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 2031 }
duke@1 2032 }
duke@1 2033 return undef;
duke@1 2034 }
duke@1 2035
mcimadamore@690 2036 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 2037 CycleChecker cc = new CycleChecker();
mcimadamore@690 2038 cc.scan(tree);
mcimadamore@690 2039 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 2040 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 2041 }
mcimadamore@690 2042 }
mcimadamore@690 2043
mcimadamore@690 2044 class CycleChecker extends TreeScanner {
mcimadamore@690 2045
mcimadamore@690 2046 List<Symbol> seenClasses = List.nil();
mcimadamore@690 2047 boolean errorFound = false;
mcimadamore@690 2048 boolean partialCheck = false;
mcimadamore@690 2049
mcimadamore@690 2050 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 2051 if (sym != null && sym.kind == TYP) {
mcimadamore@690 2052 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 2053 if (classEnv != null) {
mcimadamore@690 2054 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2055 try {
mcimadamore@690 2056 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2057 scan(classEnv.tree);
mcimadamore@690 2058 }
mcimadamore@690 2059 finally {
mcimadamore@690 2060 log.useSource(prevSource.getFile());
mcimadamore@690 2061 }
mcimadamore@690 2062 } else if (sym.kind == TYP) {
mcimadamore@690 2063 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2064 }
mcimadamore@690 2065 } else {
mcimadamore@690 2066 //not completed yet
mcimadamore@690 2067 partialCheck = true;
mcimadamore@690 2068 }
mcimadamore@690 2069 }
mcimadamore@690 2070
mcimadamore@690 2071 @Override
mcimadamore@690 2072 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2073 super.visitSelect(tree);
mcimadamore@690 2074 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2075 }
mcimadamore@690 2076
mcimadamore@690 2077 @Override
mcimadamore@690 2078 public void visitIdent(JCIdent tree) {
mcimadamore@690 2079 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2080 }
mcimadamore@690 2081
mcimadamore@690 2082 @Override
mcimadamore@690 2083 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2084 scan(tree.clazz);
mcimadamore@690 2085 }
mcimadamore@690 2086
mcimadamore@690 2087 @Override
mcimadamore@690 2088 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2089 scan(tree.elemtype);
mcimadamore@690 2090 }
mcimadamore@690 2091
mcimadamore@690 2092 @Override
mcimadamore@690 2093 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2094 List<JCTree> supertypes = List.nil();
mcimadamore@690 2095 if (tree.getExtendsClause() != null) {
mcimadamore@690 2096 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2097 }
mcimadamore@690 2098 if (tree.getImplementsClause() != null) {
mcimadamore@690 2099 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2100 supertypes = supertypes.prepend(intf);
mcimadamore@690 2101 }
mcimadamore@690 2102 }
mcimadamore@690 2103 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2104 }
mcimadamore@690 2105
mcimadamore@690 2106 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2107 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2108 return;
mcimadamore@690 2109 if (seenClasses.contains(c)) {
mcimadamore@690 2110 errorFound = true;
mcimadamore@690 2111 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2112 } else if (!c.type.isErroneous()) {
mcimadamore@690 2113 try {
mcimadamore@690 2114 seenClasses = seenClasses.prepend(c);
jjg@1374 2115 if (c.type.hasTag(CLASS)) {
mcimadamore@690 2116 if (supertypes.nonEmpty()) {
mcimadamore@690 2117 scan(supertypes);
mcimadamore@690 2118 }
mcimadamore@690 2119 else {
mcimadamore@690 2120 ClassType ct = (ClassType)c.type;
mcimadamore@690 2121 if (ct.supertype_field == null ||
mcimadamore@690 2122 ct.interfaces_field == null) {
mcimadamore@690 2123 //not completed yet
mcimadamore@690 2124 partialCheck = true;
mcimadamore@690 2125 return;
mcimadamore@690 2126 }
mcimadamore@690 2127 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2128 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2129 checkSymbol(pos, intf.tsym);
mcimadamore@690 2130 }
mcimadamore@690 2131 }
mcimadamore@690 2132 if (c.owner.kind == TYP) {
mcimadamore@690 2133 checkSymbol(pos, c.owner);
mcimadamore@690 2134 }
mcimadamore@690 2135 }
mcimadamore@690 2136 } finally {
mcimadamore@690 2137 seenClasses = seenClasses.tail;
mcimadamore@690 2138 }
mcimadamore@690 2139 }
mcimadamore@690 2140 }
mcimadamore@690 2141 }
mcimadamore@690 2142
duke@1 2143 /** Check for cyclic references. Issue an error if the
duke@1 2144 * symbol of the type referred to has a LOCKED flag set.
duke@1 2145 *
duke@1 2146 * @param pos Position to be used for error reporting.
duke@1 2147 * @param t The type referred to.
duke@1 2148 */
duke@1 2149 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2150 checkNonCyclicInternal(pos, t);
duke@1 2151 }
duke@1 2152
duke@1 2153
duke@1 2154 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2155 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2156 }
duke@1 2157
mcimadamore@236 2158 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2159 final TypeVar tv;
jjg@1374 2160 if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2161 return;
duke@1 2162 if (seen.contains(t)) {
duke@1 2163 tv = (TypeVar)t;
jjg@110 2164 tv.bound = types.createErrorType(t);
duke@1 2165 log.error(pos, "cyclic.inheritance", t);
jjg@1374 2166 } else if (t.hasTag(TYPEVAR)) {
duke@1 2167 tv = (TypeVar)t;
mcimadamore@236 2168 seen = seen.prepend(tv);
duke@1 2169 for (Type b : types.getBounds(tv))
duke@1 2170 checkNonCyclic1(pos, b, seen);
duke@1 2171 }
duke@1 2172 }
duke@1 2173
duke@1 2174 /** Check for cyclic references. Issue an error if the
duke@1 2175 * symbol of the type referred to has a LOCKED flag set.
duke@1 2176 *
duke@1 2177 * @param pos Position to be used for error reporting.
duke@1 2178 * @param t The type referred to.
duke@1 2179 * @returns True if the check completed on all attributed classes
duke@1 2180 */
duke@1 2181 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2182 boolean complete = true; // was the check complete?
duke@1 2183 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2184 Symbol c = t.tsym;
duke@1 2185 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2186
duke@1 2187 if ((c.flags_field & LOCKED) != 0) {
duke@1 2188 noteCyclic(pos, (ClassSymbol)c);
duke@1 2189 } else if (!c.type.isErroneous()) {
duke@1 2190 try {
duke@1 2191 c.flags_field |= LOCKED;
jjg@1374 2192 if (c.type.hasTag(CLASS)) {
duke@1 2193 ClassType clazz = (ClassType)c.type;
duke@1 2194 if (clazz.interfaces_field != null)
duke@1 2195 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2196 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2197 if (clazz.supertype_field != null) {
duke@1 2198 Type st = clazz.supertype_field;
jjg@1374 2199 if (st != null && st.hasTag(CLASS))
duke@1 2200 complete &= checkNonCyclicInternal(pos, st);
duke@1 2201 }
duke@1 2202 if (c.owner.kind == TYP)
duke@1 2203 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2204 }
duke@1 2205 } finally {
duke@1 2206 c.flags_field &= ~LOCKED;
duke@1 2207 }
duke@1 2208 }
duke@1 2209 if (complete)
duke@1 2210 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2211 if (complete) c.flags_field |= ACYCLIC;
duke@1 2212 return complete;
duke@1 2213 }
duke@1 2214
duke@1 2215 /** Note that we found an inheritance cycle. */
duke@1 2216 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2217 log.error(pos, "cyclic.inheritance", c);
duke@1 2218 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2219 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2220 Type st = types.supertype(c.type);
jjg@1374 2221 if (st.hasTag(CLASS))
jjg@110 2222 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2223 c.type = types.createErrorType(c, c.type);
duke@1 2224 c.flags_field |= ACYCLIC;
duke@1 2225 }
duke@1 2226
mcimadamore@1415 2227 /**
mcimadamore@1415 2228 * Check that functional interface methods would make sense when seen
mcimadamore@1415 2229 * from the perspective of the implementing class
mcimadamore@1415 2230 */
mcimadamore@1415 2231 void checkFunctionalInterface(JCTree tree, Type funcInterface) {
mcimadamore@1415 2232 ClassType c = new ClassType(Type.noType, List.<Type>nil(), null);
mcimadamore@1415 2233 ClassSymbol csym = new ClassSymbol(0, names.empty, c, syms.noSymbol);
mcimadamore@1415 2234 c.interfaces_field = List.of(funcInterface);
mcimadamore@1415 2235 c.supertype_field = syms.objectType;
mcimadamore@1415 2236 c.tsym = csym;
mcimadamore@1415 2237 csym.members_field = new Scope(csym);
mcimadamore@1415 2238 csym.completer = null;
mcimadamore@1415 2239 checkImplementations(tree, csym, csym);
mcimadamore@1415 2240 }
mcimadamore@1415 2241
duke@1 2242 /** Check that all methods which implement some
duke@1 2243 * method conform to the method they implement.
duke@1 2244 * @param tree The class definition whose members are checked.
duke@1 2245 */
duke@1 2246 void checkImplementations(JCClassDecl tree) {
mcimadamore@1415 2247 checkImplementations(tree, tree.sym, tree.sym);
duke@1 2248 }
duke@1 2249 //where
duke@1 2250 /** Check that all methods which implement some
duke@1 2251 * method in `ic' conform to the method they implement.
duke@1 2252 */
mcimadamore@1415 2253 void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) {
duke@1 2254 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2255 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2256 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2257 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2258 if (e.sym.kind == MTH &&
duke@1 2259 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2260 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2261 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2262 if (implmeth != null && implmeth != absmeth &&
duke@1 2263 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2264 (origin.flags() & INTERFACE)) {
duke@1 2265 // don't check if implmeth is in a class, yet
duke@1 2266 // origin is an interface. This case arises only
duke@1 2267 // if implmeth is declared in Object. The reason is
duke@1 2268 // that interfaces really don't inherit from
duke@1 2269 // Object it's just that the compiler represents
duke@1 2270 // things that way.
duke@1 2271 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2272 }
duke@1 2273 }
duke@1 2274 }
duke@1 2275 }
duke@1 2276 }
duke@1 2277 }
duke@1 2278
duke@1 2279 /** Check that all abstract methods implemented by a class are
duke@1 2280 * mutually compatible.
duke@1 2281 * @param pos Position to be used for error reporting.
duke@1 2282 * @param c The class whose interfaces are checked.
duke@1 2283 */
duke@1 2284 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2285 List<Type> supertypes = types.interfaces(c);
duke@1 2286 Type supertype = types.supertype(c);
jjg@1374 2287 if (supertype.hasTag(CLASS) &&
duke@1 2288 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2289 supertypes = supertypes.prepend(supertype);
duke@1 2290 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2291 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2292 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2293 return;
duke@1 2294 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2295 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2296 return;
duke@1 2297 }
duke@1 2298 checkCompatibleConcretes(pos, c);
duke@1 2299 }
duke@1 2300
mcimadamore@359 2301 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2302 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2303 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2304 // VM allows methods and variables with differing types
mcimadamore@359 2305 if (sym.kind == e.sym.kind &&
mcimadamore@359 2306 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2307 sym != e.sym &&
mcimadamore@359 2308 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2309 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2310 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2311 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2312 return;
mcimadamore@359 2313 }
mcimadamore@359 2314 }
mcimadamore@359 2315 }
mcimadamore@359 2316 }
mcimadamore@359 2317
mcimadamore@780 2318 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2319 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2320 *
mcimadamore@780 2321 * @param pos Position to be used for error reporting.
mcimadamore@780 2322 * @param site The class whose methods are checked.
mcimadamore@780 2323 * @param sym The method symbol to be checked.
mcimadamore@780 2324 */
mcimadamore@858 2325 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2326 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2327 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2328 //by method 'sym' in 'site'...
mcimadamore@1198 2329 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2330 if (!sym.overrides(m1, site.tsym, types, false)) continue;
mcimadamore@1198 2331 //...check each method m2 that is a member of 'site'
mcimadamore@1198 2332 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2333 if (m2 == m1) continue;
mcimadamore@858 2334 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2335 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1393 2336 if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) &&
mcimadamore@1198 2337 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2338 sym.flags_field |= CLASH;
mcimadamore@1198 2339 String key = m1 == sym ?
mcimadamore@858 2340 "name.clash.same.erasure.no.override" :
mcimadamore@858 2341 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2342 log.error(pos,
mcimadamore@858 2343 key,
mcimadamore@858 2344 sym, sym.location(),
mcimadamore@1198 2345 m2, m2.location(),
mcimadamore@1198 2346 m1, m1.location());
mcimadamore@858 2347 return;
mcimadamore@858 2348 }
mcimadamore@780 2349 }
mcimadamore@780 2350 }
mcimadamore@780 2351 }
mcimadamore@780 2352
mcimadamore@877 2353
mcimadamore@877 2354
mcimadamore@858 2355 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2356 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2357 *
mcimadamore@858 2358 * @param pos Position to be used for error reporting.
mcimadamore@858 2359 * @param site The class whose methods are checked.
mcimadamore@858 2360 * @param sym The method symbol to be checked.
mcimadamore@780 2361 */
mcimadamore@858 2362 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2363 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2364 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2365 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2366 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2367 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@1393 2368 if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck) &&
mcimadamore@877 2369 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2370 log.error(pos,
mcimadamore@858 2371 "name.clash.same.erasure.no.hide",
mcimadamore@858 2372 sym, sym.location(),
mcimadamore@877 2373 s, s.location());
mcimadamore@858 2374 return;
mcimadamore@858 2375 }
mcimadamore@858 2376 }
mcimadamore@858 2377 }
mcimadamore@780 2378
mcimadamore@858 2379 //where
mcimadamore@858 2380 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2381
mcimadamore@858 2382 Type site;
mcimadamore@780 2383
mcimadamore@858 2384 ClashFilter(Type site) {
mcimadamore@858 2385 this.site = site;
mcimadamore@858 2386 }
mcimadamore@858 2387
mcimadamore@858 2388 boolean shouldSkip(Symbol s) {
mcimadamore@858 2389 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2390 s.owner == site.tsym;
mcimadamore@858 2391 }
mcimadamore@858 2392
mcimadamore@858 2393 public boolean accepts(Symbol s) {
mcimadamore@858 2394 return s.kind == MTH &&
mcimadamore@858 2395 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2396 !shouldSkip(s) &&
mcimadamore@858 2397 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2398 !s.isConstructor();
mcimadamore@858 2399 }
mcimadamore@858 2400 }
mcimadamore@780 2401
mcimadamore@1393 2402 void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) {
mcimadamore@1393 2403 DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site);
mcimadamore@1393 2404 for (Symbol m : types.membersClosure(site, false).getElements(dcf)) {
mcimadamore@1393 2405 Assert.check(m.kind == MTH);
mcimadamore@1393 2406 List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m);
mcimadamore@1393 2407 if (prov.size() > 1) {
mcimadamore@1393 2408 ListBuffer<Symbol> abstracts = ListBuffer.lb();
mcimadamore@1393 2409 ListBuffer<Symbol> defaults = ListBuffer.lb();
mcimadamore@1393 2410 for (MethodSymbol provSym : prov) {
mcimadamore@1393 2411 if ((provSym.flags() & DEFAULT) != 0) {
mcimadamore@1393 2412 defaults = defaults.append(provSym);
mcimadamore@1393 2413 } else if ((provSym.flags() & ABSTRACT) != 0) {
mcimadamore@1393 2414 abstracts = abstracts.append(provSym);
mcimadamore@1393 2415 }
mcimadamore@1393 2416 if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) {
mcimadamore@1393 2417 //strong semantics - issue an error if two sibling interfaces
mcimadamore@1393 2418 //have two override-equivalent defaults - or if one is abstract
mcimadamore@1393 2419 //and the other is default
mcimadamore@1393 2420 String errKey;
mcimadamore@1393 2421 Symbol s1 = defaults.first();
mcimadamore@1393 2422 Symbol s2;
mcimadamore@1393 2423 if (defaults.size() > 1) {
mcimadamore@1393 2424 errKey = "types.incompatible.unrelated.defaults";
mcimadamore@1393 2425 s2 = defaults.toList().tail.head;
mcimadamore@1393 2426 } else {
mcimadamore@1393 2427 errKey = "types.incompatible.abstract.default";
mcimadamore@1393 2428 s2 = abstracts.first();
mcimadamore@1393 2429 }
mcimadamore@1393 2430 log.error(pos, errKey,
mcimadamore@1393 2431 Kinds.kindName(site.tsym), site,
mcimadamore@1393 2432 m.name, types.memberType(site, m).getParameterTypes(),
mcimadamore@1393 2433 s1.location(), s2.location());
mcimadamore@1393 2434 break;
mcimadamore@1393 2435 }
mcimadamore@1393 2436 }
mcimadamore@1393 2437 }
mcimadamore@1393 2438 }
mcimadamore@1393 2439 }
mcimadamore@1393 2440
mcimadamore@1393 2441 //where
mcimadamore@1393 2442 private class DefaultMethodClashFilter implements Filter<Symbol> {
mcimadamore@1393 2443
mcimadamore@1393 2444 Type site;
mcimadamore@1393 2445
mcimadamore@1393 2446 DefaultMethodClashFilter(Type site) {
mcimadamore@1393 2447 this.site = site;
mcimadamore@1393 2448 }
mcimadamore@1393 2449
mcimadamore@1393 2450 public boolean accepts(Symbol s) {
mcimadamore@1393 2451 return s.kind == MTH &&
mcimadamore@1393 2452 (s.flags() & DEFAULT) != 0 &&
mcimadamore@1393 2453 s.isInheritedIn(site.tsym, types) &&
mcimadamore@1393 2454 !s.isConstructor();
mcimadamore@1393 2455 }
mcimadamore@1393 2456 }
mcimadamore@1393 2457
mcimadamore@359 2458 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2459 */
mcimadamore@359 2460 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2461 if (!sym.type.isErroneous()) {
mcimadamore@359 2462 if (warnOnSyntheticConflicts) {
mcimadamore@359 2463 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2464 }
mcimadamore@359 2465 else {
mcimadamore@359 2466 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2467 }
mcimadamore@359 2468 }
mcimadamore@359 2469 }
mcimadamore@359 2470
duke@1 2471 /** Check that class c does not implement directly or indirectly
duke@1 2472 * the same parameterized interface with two different argument lists.
duke@1 2473 * @param pos Position to be used for error reporting.
duke@1 2474 * @param type The type whose interfaces are checked.
duke@1 2475 */
duke@1 2476 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2477 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2478 }
duke@1 2479 //where
duke@1 2480 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2481 * with their class symbol as key and their type as value. Make
duke@1 2482 * sure no class is entered with two different types.
duke@1 2483 */
duke@1 2484 void checkClassBounds(DiagnosticPosition pos,
duke@1 2485 Map<TypeSymbol,Type> seensofar,
duke@1 2486 Type type) {
duke@1 2487 if (type.isErroneous()) return;
duke@1 2488 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2489 Type it = l.head;
duke@1 2490 Type oldit = seensofar.put(it.tsym, it);
duke@1 2491 if (oldit != null) {
duke@1 2492 List<Type> oldparams = oldit.allparams();
duke@1 2493 List<Type> newparams = it.allparams();
duke@1 2494 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2495 log.error(pos, "cant.inherit.diff.arg",
duke@1 2496 it.tsym, Type.toString(oldparams),
duke@1 2497 Type.toString(newparams));
duke@1 2498 }
duke@1 2499 checkClassBounds(pos, seensofar, it);
duke@1 2500 }
duke@1 2501 Type st = types.supertype(type);
duke@1 2502 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2503 }
duke@1 2504
duke@1 2505 /** Enter interface into into set.
duke@1 2506 * If it existed already, issue a "repeated interface" error.
duke@1 2507 */
duke@1 2508 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2509 if (its.contains(it))
duke@1 2510 log.error(pos, "repeated.interface");
duke@1 2511 else {
duke@1 2512 its.add(it);
duke@1 2513 }
duke@1 2514 }
duke@1 2515
duke@1 2516 /* *************************************************************************
duke@1 2517 * Check annotations
duke@1 2518 **************************************************************************/
duke@1 2519
mcimadamore@629 2520 /**
mcimadamore@634 2521 * Recursively validate annotations values
mcimadamore@629 2522 */
mcimadamore@634 2523 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2524 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2525 @Override
mcimadamore@629 2526 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2527 if (!tree.type.isErroneous()) {
jjg@1017 2528 super.visitAnnotation(tree);
jjg@1017 2529 validateAnnotation(tree);
jjg@1017 2530 }
mcimadamore@629 2531 }
mcimadamore@629 2532 }
mcimadamore@634 2533 tree.accept(new AnnotationValidator());
mcimadamore@629 2534 }
mcimadamore@629 2535
jjg@1326 2536 /**
jjg@1326 2537 * {@literal
jjg@1326 2538 * Annotation types are restricted to primitives, String, an
duke@1 2539 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2540 * Anything>, arrays of the preceding.
jjg@1326 2541 * }
duke@1 2542 */
duke@1 2543 void validateAnnotationType(JCTree restype) {
duke@1 2544 // restype may be null if an error occurred, so don't bother validating it
duke@1 2545 if (restype != null) {
duke@1 2546 validateAnnotationType(restype.pos(), restype.type);
duke@1 2547 }
duke@1 2548 }
duke@1 2549
duke@1 2550 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2551 if (type.isPrimitive()) return;
duke@1 2552 if (types.isSameType(type, syms.stringType)) return;
duke@1 2553 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2554 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2555 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2556 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2557 validateAnnotationType(pos, types.elemtype(type));
duke@1 2558 return;
duke@1 2559 }
duke@1 2560 log.error(pos, "invalid.annotation.member.type");
duke@1 2561 }
duke@1 2562
duke@1 2563 /**
duke@1 2564 * "It is also a compile-time error if any method declared in an
duke@1 2565 * annotation type has a signature that is override-equivalent to
duke@1 2566 * that of any public or protected method declared in class Object
duke@1 2567 * or in the interface annotation.Annotation."
duke@1 2568 *
jjh@972 2569 * @jls 9.6 Annotation Types
duke@1 2570 */
duke@1 2571 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
jjg@1374 2572 for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
duke@1 2573 Scope s = sup.tsym.members();
duke@1 2574 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2575 if (e.sym.kind == MTH &&
duke@1 2576 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2577 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2578 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2579 }
duke@1 2580 }
duke@1 2581 }
duke@1 2582
duke@1 2583 /** Check the annotations of a symbol.
duke@1 2584 */
duke@1 2585 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2586 for (JCAnnotation a : annotations)
duke@1 2587 validateAnnotation(a, s);
duke@1 2588 }
duke@1 2589
duke@1 2590 /** Check an annotation of a symbol.
duke@1 2591 */
jfranck@1313 2592 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2593 validateAnnotationTree(a);
duke@1 2594
duke@1 2595 if (!annotationApplicable(a, s))
duke@1 2596 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2597
duke@1 2598 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2599 if (!isOverrider(s))
duke@1 2600 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2601 }
mcimadamore@1497 2602
mcimadamore@1497 2603 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
mcimadamore@1497 2604 if (s.kind != TYP) {
mcimadamore@1497 2605 log.error(a.pos(), "bad.functional.intf.anno");
mcimadamore@1497 2606 } else {
mcimadamore@1497 2607 try {
mcimadamore@1497 2608 types.findDescriptorSymbol((TypeSymbol)s);
mcimadamore@1497 2609 } catch (Types.FunctionDescriptorLookupError ex) {
mcimadamore@1497 2610 log.error(a.pos(), "bad.functional.intf.anno.1", ex.getDiagnostic());
mcimadamore@1497 2611 }
mcimadamore@1497 2612 }
mcimadamore@1497 2613 }
duke@1 2614 }
duke@1 2615
jfranck@1313 2616 /**
jjg@1492 2617 * Validate the proposed container 'repeatable' on the
jfranck@1313 2618 * annotation type symbol 's'. Report errors at position
jfranck@1313 2619 * 'pos'.
jfranck@1313 2620 *
jjg@1492 2621 * @param s The (annotation)type declaration annotated with a @Repeatable
jjg@1492 2622 * @param repeatable the @Repeatable on 's'
jfranck@1313 2623 * @param pos where to report errors
jfranck@1313 2624 */
jjg@1492 2625 public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) {
jjg@1492 2626 Assert.check(types.isSameType(repeatable.type, syms.repeatableType));
jfranck@1313 2627
jfranck@1313 2628 Type t = null;
jjg@1492 2629 List<Pair<MethodSymbol,Attribute>> l = repeatable.values;
jfranck@1313 2630 if (!l.isEmpty()) {
jfranck@1313 2631 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2632 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2633 }
jfranck@1313 2634
jfranck@1313 2635 if (t == null) {
jjg@1492 2636 // errors should already have been reported during Annotate
jfranck@1313 2637 return;
jfranck@1313 2638 }
jfranck@1313 2639
jjg@1492 2640 validateValue(t.tsym, s, pos);
jfranck@1313 2641 validateRetention(t.tsym, s, pos);
jfranck@1313 2642 validateDocumented(t.tsym, s, pos);
jfranck@1313 2643 validateInherited(t.tsym, s, pos);
jfranck@1313 2644 validateTarget(t.tsym, s, pos);
jfranck@1344 2645 validateDefault(t.tsym, s, pos);
jfranck@1313 2646 }
jfranck@1313 2647
jjg@1492 2648 private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jjg@1492 2649 Scope.Entry e = container.members().lookup(names.value);
jjg@1492 2650 if (e.scope != null && e.sym.kind == MTH) {
jjg@1492 2651 MethodSymbol m = (MethodSymbol) e.sym;
jjg@1492 2652 Type ret = m.getReturnType();
jjg@1492 2653 if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) {
jjg@1492 2654 log.error(pos, "invalid.repeatable.annotation.value.return",
jjg@1492 2655 container, ret, types.makeArrayType(contained.type));
jjg@1492 2656 }
jjg@1492 2657 } else {
jjg@1492 2658 log.error(pos, "invalid.repeatable.annotation.no.value", container);
jfranck@1313 2659 }
jfranck@1313 2660 }
jfranck@1313 2661
jfranck@1313 2662 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2663 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2664 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2665
jfranck@1313 2666 boolean error = false;
jfranck@1313 2667 switch (containedRetention) {
jfranck@1313 2668 case RUNTIME:
jfranck@1313 2669 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2670 error = true;
jfranck@1313 2671 }
jfranck@1313 2672 break;
jfranck@1313 2673 case CLASS:
jfranck@1313 2674 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2675 error = true;
jfranck@1313 2676 }
jfranck@1313 2677 }
jfranck@1313 2678 if (error ) {
jjg@1492 2679 log.error(pos, "invalid.repeatable.annotation.retention",
jfranck@1313 2680 container, containerRetention,
jfranck@1313 2681 contained, containedRetention);
jfranck@1313 2682 }
jfranck@1313 2683 }
jfranck@1313 2684
jfranck@1313 2685 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2686 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2687 if (container.attribute(syms.documentedType.tsym) == null) {
jjg@1492 2688 log.error(pos, "invalid.repeatable.annotation.not.documented", container, contained);
jfranck@1313 2689 }
jfranck@1313 2690 }
jfranck@1313 2691 }
jfranck@1313 2692
jfranck@1313 2693 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2694 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2695 if (container.attribute(syms.inheritedType.tsym) == null) {
jjg@1492 2696 log.error(pos, "invalid.repeatable.annotation.not.inherited", container, contained);
jfranck@1313 2697 }
jfranck@1313 2698 }
jfranck@1313 2699 }
jfranck@1313 2700
jfranck@1313 2701 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2702 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1313 2703
jfranck@1313 2704 // If contained has no Target, we are done
jfranck@1313 2705 if (containedTarget == null) {
jfranck@1313 2706 return;
jfranck@1313 2707 }
jfranck@1313 2708
jfranck@1313 2709 // If contained has Target m1, container must have a Target
jfranck@1313 2710 // annotation, m2, and m2 must be a subset of m1. (This is
jfranck@1313 2711 // trivially true if contained has no target as per above).
jfranck@1313 2712
jfranck@1313 2713 // contained has target, but container has not, error
jfranck@1313 2714 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2715 if (containerTarget == null) {
jjg@1492 2716 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2717 return;
jfranck@1313 2718 }
jfranck@1313 2719
jfranck@1313 2720 Set<Name> containerTargets = new HashSet<Name>();
jfranck@1313 2721 for (Attribute app : containerTarget.values) {
jfranck@1313 2722 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2723 continue; // recovery
jfranck@1313 2724 }
jfranck@1313 2725 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2726 containerTargets.add(e.value.name);
jfranck@1313 2727 }
jfranck@1313 2728
jfranck@1313 2729 Set<Name> containedTargets = new HashSet<Name>();
jfranck@1313 2730 for (Attribute app : containedTarget.values) {
jfranck@1313 2731 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2732 continue; // recovery
jfranck@1313 2733 }
jfranck@1313 2734 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2735 containedTargets.add(e.value.name);
jfranck@1313 2736 }
jfranck@1313 2737
jfranck@1313 2738 if (!isTargetSubset(containedTargets, containerTargets)) {
jjg@1492 2739 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2740 }
jfranck@1313 2741 }
jfranck@1313 2742
jfranck@1313 2743 /** Checks that t is a subset of s, with respect to ElementType
jfranck@1313 2744 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE}
jfranck@1313 2745 */
jfranck@1313 2746 private boolean isTargetSubset(Set<Name> s, Set<Name> t) {
jfranck@1313 2747 // Check that all elements in t are present in s
jfranck@1313 2748 for (Name n2 : t) {
jfranck@1313 2749 boolean currentElementOk = false;
jfranck@1313 2750 for (Name n1 : s) {
jfranck@1313 2751 if (n1 == n2) {
jfranck@1313 2752 currentElementOk = true;
jfranck@1313 2753 break;
jfranck@1313 2754 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2755 currentElementOk = true;
jfranck@1313 2756 break;
jfranck@1313 2757 }
jfranck@1313 2758 }
jfranck@1313 2759 if (!currentElementOk)
jfranck@1313 2760 return false;
jfranck@1313 2761 }
jfranck@1313 2762 return true;
jfranck@1313 2763 }
jfranck@1313 2764
jfranck@1344 2765 private void validateDefault(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1344 2766 // validate that all other elements of containing type has defaults
jfranck@1344 2767 Scope scope = container.members();
jfranck@1344 2768 for(Symbol elm : scope.getElements()) {
jfranck@1344 2769 if (elm.name != names.value &&
jfranck@1344 2770 elm.kind == Kinds.MTH &&
jfranck@1344 2771 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2772 log.error(pos,
jjg@1492 2773 "invalid.repeatable.annotation.elem.nondefault",
jfranck@1344 2774 container,
jfranck@1344 2775 elm);
jfranck@1344 2776 }
jfranck@1344 2777 }
jfranck@1344 2778 }
jfranck@1344 2779
duke@1 2780 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2781 boolean isOverrider(Symbol s) {
duke@1 2782 if (s.kind != MTH || s.isStatic())
duke@1 2783 return false;
duke@1 2784 MethodSymbol m = (MethodSymbol)s;
duke@1 2785 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2786 for (Type sup : types.closure(owner.type)) {
duke@1 2787 if (sup == owner.type)
duke@1 2788 continue; // skip "this"
duke@1 2789 Scope scope = sup.tsym.members();
duke@1 2790 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2791 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2792 return true;
duke@1 2793 }
duke@1 2794 }
duke@1 2795 return false;
duke@1 2796 }
duke@1 2797
duke@1 2798 /** Is the annotation applicable to the symbol? */
duke@1 2799 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 2800 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jfranck@1313 2801 if (arr == null) {
jfranck@1313 2802 return true;
jfranck@1313 2803 }
duke@1 2804 for (Attribute app : arr.values) {
duke@1 2805 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2806 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2807 if (e.value.name == names.TYPE)
duke@1 2808 { if (s.kind == TYP) return true; }
duke@1 2809 else if (e.value.name == names.FIELD)
duke@1 2810 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2811 else if (e.value.name == names.METHOD)
duke@1 2812 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2813 else if (e.value.name == names.PARAMETER)
duke@1 2814 { if (s.kind == VAR &&
duke@1 2815 s.owner.kind == MTH &&
duke@1 2816 (s.flags() & PARAMETER) != 0)
duke@1 2817 return true;
duke@1 2818 }
duke@1 2819 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2820 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2821 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2822 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2823 (s.flags() & PARAMETER) == 0)
duke@1 2824 return true;
duke@1 2825 }
duke@1 2826 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2827 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2828 return true;
duke@1 2829 }
duke@1 2830 else if (e.value.name == names.PACKAGE)
duke@1 2831 { if (s.kind == PCK) return true; }
jjg@308 2832 else if (e.value.name == names.TYPE_USE)
jjg@308 2833 { if (s.kind == TYP ||
jjg@308 2834 s.kind == VAR ||
jjg@308 2835 (s.kind == MTH && !s.isConstructor() &&
jjg@1374 2836 !s.type.getReturnType().hasTag(VOID)))
jjg@308 2837 return true;
jjg@308 2838 }
duke@1 2839 else
duke@1 2840 return true; // recovery
duke@1 2841 }
duke@1 2842 return false;
duke@1 2843 }
duke@1 2844
jfranck@1313 2845
jfranck@1313 2846 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 2847 Attribute.Compound atTarget =
jfranck@1313 2848 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 2849 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 2850 Attribute atValue = atTarget.member(names.value);
jfranck@1313 2851 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 2852 return (Attribute.Array) atValue;
jfranck@1313 2853 }
jfranck@1313 2854
duke@1 2855 /** Check an annotation value.
jfranck@1445 2856 *
jfranck@1445 2857 * @param a The annotation tree to check
jfranck@1445 2858 * @return true if this annotation tree is valid, otherwise false
duke@1 2859 */
jfranck@1445 2860 public boolean validateAnnotationDeferErrors(JCAnnotation a) {
jfranck@1445 2861 boolean res = false;
jfranck@1445 2862 final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log);
jfranck@1445 2863 try {
jfranck@1445 2864 res = validateAnnotation(a);
jfranck@1445 2865 } finally {
jfranck@1445 2866 log.popDiagnosticHandler(diagHandler);
jfranck@1445 2867 }
jfranck@1445 2868 return res;
jfranck@1445 2869 }
jfranck@1445 2870
jfranck@1445 2871 private boolean validateAnnotation(JCAnnotation a) {
jfranck@1445 2872 boolean isValid = true;
jfranck@1445 2873 // collect an inventory of the annotation elements
jfranck@1445 2874 Set<MethodSymbol> members = new LinkedHashSet<MethodSymbol>();
duke@1 2875 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2876 e != null;
duke@1 2877 e = e.sibling)
duke@1 2878 if (e.sym.kind == MTH)
duke@1 2879 members.add((MethodSymbol) e.sym);
duke@1 2880
jfranck@1445 2881 // remove the ones that are assigned values
duke@1 2882 for (JCTree arg : a.args) {
jjg@1127 2883 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 2884 JCAssign assign = (JCAssign) arg;
duke@1 2885 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2886 if (m == null || m.type.isErroneous()) continue;
jfranck@1445 2887 if (!members.remove(m)) {
jfranck@1445 2888 isValid = false;
jjg@479 2889 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2890 m.name, a.type);
jfranck@1445 2891 }
duke@1 2892 }
duke@1 2893
duke@1 2894 // all the remaining ones better have default values
jfranck@1445 2895 List<Name> missingDefaults = List.nil();
mcimadamore@632 2896 for (MethodSymbol m : members) {
mcimadamore@632 2897 if (m.defaultValue == null && !m.type.isErroneous()) {
jfranck@1445 2898 missingDefaults = missingDefaults.append(m.name);
mcimadamore@632 2899 }
mcimadamore@632 2900 }
jfranck@1445 2901 missingDefaults = missingDefaults.reverse();
mcimadamore@632 2902 if (missingDefaults.nonEmpty()) {
jfranck@1445 2903 isValid = false;
mcimadamore@632 2904 String key = (missingDefaults.size() > 1)
mcimadamore@632 2905 ? "annotation.missing.default.value.1"
mcimadamore@632 2906 : "annotation.missing.default.value";
mcimadamore@632 2907 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 2908 }
duke@1 2909
duke@1 2910 // special case: java.lang.annotation.Target must not have
duke@1 2911 // repeated values in its value member
duke@1 2912 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2913 a.args.tail == null)
jfranck@1445 2914 return isValid;
duke@1 2915
jfranck@1445 2916 if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery
duke@1 2917 JCAssign assign = (JCAssign) a.args.head;
duke@1 2918 Symbol m = TreeInfo.symbol(assign.lhs);
jfranck@1445 2919 if (m.name != names.value) return false;
duke@1 2920 JCTree rhs = assign.rhs;
jfranck@1445 2921 if (!rhs.hasTag(NEWARRAY)) return false;
duke@1 2922 JCNewArray na = (JCNewArray) rhs;
duke@1 2923 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2924 for (JCTree elem : na.elems) {
duke@1 2925 if (!targets.add(TreeInfo.symbol(elem))) {
jfranck@1445 2926 isValid = false;
duke@1 2927 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2928 }
duke@1 2929 }
jfranck@1445 2930 return isValid;
duke@1 2931 }
duke@1 2932
duke@1 2933 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 2934 if (allowAnnotations &&
mcimadamore@795 2935 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 2936 (s.flags() & DEPRECATED) != 0 &&
duke@1 2937 !syms.deprecatedType.isErroneous() &&
duke@1 2938 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 2939 log.warning(LintCategory.DEP_ANN,
jjg@612 2940 pos, "missing.deprecated.annotation");
duke@1 2941 }
duke@1 2942 }
duke@1 2943
mcimadamore@852 2944 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 2945 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 2946 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 2947 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 2948 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2949 @Override
mcimadamore@852 2950 public void report() {
mcimadamore@852 2951 warnDeprecated(pos, s);
mcimadamore@852 2952 }
mcimadamore@852 2953 });
jjg@1157 2954 }
mcimadamore@852 2955 }
mcimadamore@852 2956
mcimadamore@852 2957 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 2958 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 2959 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2960 public void report() {
mcimadamore@852 2961 if (enableSunApiLintControl)
mcimadamore@852 2962 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 2963 else
mcimadamore@1218 2964 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 2965 }
mcimadamore@852 2966 });
mcimadamore@852 2967 }
mcimadamore@852 2968 }
mcimadamore@852 2969
duke@1 2970 /* *************************************************************************
duke@1 2971 * Check for recursive annotation elements.
duke@1 2972 **************************************************************************/
duke@1 2973
duke@1 2974 /** Check for cycles in the graph of annotation elements.
duke@1 2975 */
duke@1 2976 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 2977 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 2978 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 2979 try {
duke@1 2980 tree.sym.flags_field |= LOCKED;
duke@1 2981 for (JCTree def : tree.defs) {
jjg@1127 2982 if (!def.hasTag(METHODDEF)) continue;
duke@1 2983 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 2984 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 2985 }
duke@1 2986 } finally {
duke@1 2987 tree.sym.flags_field &= ~LOCKED;
duke@1 2988 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 2989 }
duke@1 2990 }
duke@1 2991
duke@1 2992 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 2993 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 2994 return;
duke@1 2995 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 2996 log.error(pos, "cyclic.annotation.element");
duke@1 2997 return;
duke@1 2998 }
duke@1 2999 try {
duke@1 3000 tsym.flags_field |= LOCKED;
duke@1 3001 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 3002 Symbol s = e.sym;
duke@1 3003 if (s.kind != Kinds.MTH)
duke@1 3004 continue;
duke@1 3005 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 3006 }
duke@1 3007 } finally {
duke@1 3008 tsym.flags_field &= ~LOCKED;
duke@1 3009 tsym.flags_field |= ACYCLIC_ANN;
duke@1 3010 }
duke@1 3011 }
duke@1 3012
duke@1 3013 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
jjg@1374 3014 switch (type.getTag()) {
jjg@1374 3015 case CLASS:
duke@1 3016 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 3017 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 3018 break;
jjg@1374 3019 case ARRAY:
duke@1 3020 checkAnnotationResType(pos, types.elemtype(type));
duke@1 3021 break;
duke@1 3022 default:
duke@1 3023 break; // int etc
duke@1 3024 }
duke@1 3025 }
duke@1 3026
duke@1 3027 /* *************************************************************************
duke@1 3028 * Check for cycles in the constructor call graph.
duke@1 3029 **************************************************************************/
duke@1 3030
duke@1 3031 /** Check for cycles in the graph of constructors calling other
duke@1 3032 * constructors.
duke@1 3033 */
duke@1 3034 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 3035 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 3036
duke@1 3037 // enter each constructor this-call into the map
duke@1 3038 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 3039 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 3040 if (app == null) continue;
duke@1 3041 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 3042 if (TreeInfo.name(app.meth) == names._this) {
duke@1 3043 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 3044 } else {
duke@1 3045 meth.sym.flags_field |= ACYCLIC;
duke@1 3046 }
duke@1 3047 }
duke@1 3048
duke@1 3049 // Check for cycles in the map
duke@1 3050 Symbol[] ctors = new Symbol[0];
duke@1 3051 ctors = callMap.keySet().toArray(ctors);
duke@1 3052 for (Symbol caller : ctors) {
duke@1 3053 checkCyclicConstructor(tree, caller, callMap);
duke@1 3054 }
duke@1 3055 }
duke@1 3056
duke@1 3057 /** Look in the map to see if the given constructor is part of a
duke@1 3058 * call cycle.
duke@1 3059 */
duke@1 3060 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 3061 Map<Symbol,Symbol> callMap) {
duke@1 3062 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 3063 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 3064 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 3065 "recursive.ctor.invocation");
duke@1 3066 } else {
duke@1 3067 ctor.flags_field |= LOCKED;
duke@1 3068 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 3069 ctor.flags_field &= ~LOCKED;
duke@1 3070 }
duke@1 3071 ctor.flags_field |= ACYCLIC;
duke@1 3072 }
duke@1 3073 }
duke@1 3074
duke@1 3075 /* *************************************************************************
duke@1 3076 * Miscellaneous
duke@1 3077 **************************************************************************/
duke@1 3078
duke@1 3079 /**
duke@1 3080 * Return the opcode of the operator but emit an error if it is an
duke@1 3081 * error.
duke@1 3082 * @param pos position for error reporting.
duke@1 3083 * @param operator an operator
duke@1 3084 * @param tag a tree tag
duke@1 3085 * @param left type of left hand side
duke@1 3086 * @param right type of right hand side
duke@1 3087 */
duke@1 3088 int checkOperator(DiagnosticPosition pos,
duke@1 3089 OperatorSymbol operator,
jjg@1127 3090 JCTree.Tag tag,
duke@1 3091 Type left,
duke@1 3092 Type right) {
duke@1 3093 if (operator.opcode == ByteCodes.error) {
duke@1 3094 log.error(pos,
mcimadamore@853 3095 "operator.cant.be.applied.1",
duke@1 3096 treeinfo.operatorName(tag),
mcimadamore@853 3097 left, right);
duke@1 3098 }
duke@1 3099 return operator.opcode;
duke@1 3100 }
duke@1 3101
duke@1 3102
duke@1 3103 /**
duke@1 3104 * Check for division by integer constant zero
duke@1 3105 * @param pos Position for error reporting.
duke@1 3106 * @param operator The operator for the expression
duke@1 3107 * @param operand The right hand operand for the expression
duke@1 3108 */
duke@1 3109 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3110 if (operand.constValue() != null
mcimadamore@795 3111 && lint.isEnabled(LintCategory.DIVZERO)
jjg@1374 3112 && (operand.getTag().isSubRangeOf(LONG))
duke@1 3113 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3114 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3115 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3116 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3117 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3118 }
duke@1 3119 }
duke@1 3120 }
duke@1 3121
duke@1 3122 /**
duke@1 3123 * Check for empty statements after if
duke@1 3124 */
duke@1 3125 void checkEmptyIf(JCIf tree) {
jjg@1127 3126 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3127 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3128 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3129 }
duke@1 3130
duke@1 3131 /** Check that symbol is unique in given scope.
duke@1 3132 * @param pos Position for error reporting.
duke@1 3133 * @param sym The symbol.
duke@1 3134 * @param s The scope.
duke@1 3135 */
duke@1 3136 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3137 if (sym.type.isErroneous())
duke@1 3138 return true;
duke@1 3139 if (sym.owner.name == names.any) return false;
duke@1 3140 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3141 if (sym != e.sym &&
mcimadamore@858 3142 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3143 sym.kind == e.sym.kind &&
mcimadamore@858 3144 sym.name != names.error &&
mcimadamore@858 3145 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3146 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3147 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3148 return true;
mcimadamore@907 3149 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3150 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3151 sym.flags_field |= CLASH;
mcimadamore@844 3152 return true;
mcimadamore@844 3153 } else {
duke@1 3154 duplicateError(pos, e.sym);
mcimadamore@844 3155 return false;
mcimadamore@844 3156 }
duke@1 3157 }
duke@1 3158 }
duke@1 3159 return true;
duke@1 3160 }
mcimadamore@844 3161
mcimadamore@858 3162 /** Report duplicate declaration error.
mcimadamore@858 3163 */
mcimadamore@858 3164 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3165 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3166 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3167 }
mcimadamore@858 3168 }
duke@1 3169
duke@1 3170 /** Check that single-type import is not already imported or top-level defined,
duke@1 3171 * but make an exception for two single-type imports which denote the same type.
duke@1 3172 * @param pos Position for error reporting.
duke@1 3173 * @param sym The symbol.
duke@1 3174 * @param s The scope
duke@1 3175 */
duke@1 3176 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3177 return checkUniqueImport(pos, sym, s, false);
duke@1 3178 }
duke@1 3179
duke@1 3180 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3181 * but make an exception for two single-type imports which denote the same type.
duke@1 3182 * @param pos Position for error reporting.
duke@1 3183 * @param sym The symbol.
duke@1 3184 * @param s The scope
duke@1 3185 */
duke@1 3186 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3187 return checkUniqueImport(pos, sym, s, true);
duke@1 3188 }
duke@1 3189
duke@1 3190 /** Check that single-type import is not already imported or top-level defined,
duke@1 3191 * but make an exception for two single-type imports which denote the same type.
duke@1 3192 * @param pos Position for error reporting.
duke@1 3193 * @param sym The symbol.
duke@1 3194 * @param s The scope.
duke@1 3195 * @param staticImport Whether or not this was a static import
duke@1 3196 */
duke@1 3197 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3198 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3199 // is encountered class entered via a class declaration?
duke@1 3200 boolean isClassDecl = e.scope == s;
duke@1 3201 if ((isClassDecl || sym != e.sym) &&
duke@1 3202 sym.kind == e.sym.kind &&
duke@1 3203 sym.name != names.error) {
duke@1 3204 if (!e.sym.type.isErroneous()) {
duke@1 3205 String what = e.sym.toString();
duke@1 3206 if (!isClassDecl) {
duke@1 3207 if (staticImport)
duke@1 3208 log.error(pos, "already.defined.static.single.import", what);
duke@1 3209 else
duke@1 3210 log.error(pos, "already.defined.single.import", what);
duke@1 3211 }
duke@1 3212 else if (sym != e.sym)
duke@1 3213 log.error(pos, "already.defined.this.unit", what);
duke@1 3214 }
duke@1 3215 return false;
duke@1 3216 }
duke@1 3217 }
duke@1 3218 return true;
duke@1 3219 }
duke@1 3220
duke@1 3221 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3222 */
duke@1 3223 public void checkCanonical(JCTree tree) {
duke@1 3224 if (!isCanonical(tree))
duke@1 3225 log.error(tree.pos(), "import.requires.canonical",
duke@1 3226 TreeInfo.symbol(tree));
duke@1 3227 }
duke@1 3228 // where
duke@1 3229 private boolean isCanonical(JCTree tree) {
jjg@1127 3230 while (tree.hasTag(SELECT)) {
duke@1 3231 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3232 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3233 return false;
duke@1 3234 tree = s.selected;
duke@1 3235 }
duke@1 3236 return true;
duke@1 3237 }
duke@1 3238
ohrstrom@1384 3239 /** Check that an auxiliary class is not accessed from any other file than its own.
ohrstrom@1384 3240 */
ohrstrom@1384 3241 void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) {
ohrstrom@1384 3242 if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) &&
ohrstrom@1384 3243 (c.flags() & AUXILIARY) != 0 &&
ohrstrom@1384 3244 rs.isAccessible(env, c) &&
ohrstrom@1384 3245 !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile))
ohrstrom@1384 3246 {
ohrstrom@1384 3247 log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file",
ohrstrom@1384 3248 c, c.sourcefile);
ohrstrom@1384 3249 }
ohrstrom@1384 3250 }
ohrstrom@1384 3251
duke@1 3252 private class ConversionWarner extends Warner {
mcimadamore@795 3253 final String uncheckedKey;
duke@1 3254 final Type found;
duke@1 3255 final Type expected;
mcimadamore@795 3256 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3257 super(pos);
mcimadamore@795 3258 this.uncheckedKey = uncheckedKey;
duke@1 3259 this.found = found;
duke@1 3260 this.expected = expected;
duke@1 3261 }
duke@1 3262
jjg@398 3263 @Override
mcimadamore@795 3264 public void warn(LintCategory lint) {
duke@1 3265 boolean warned = this.warned;
mcimadamore@795 3266 super.warn(lint);
duke@1 3267 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3268 switch (lint) {
mcimadamore@795 3269 case UNCHECKED:
mcimadamore@795 3270 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3271 break;
mcimadamore@795 3272 case VARARGS:
mcimadamore@795 3273 if (method != null &&
mcimadamore@795 3274 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3275 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3276 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3277 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3278 }
mcimadamore@795 3279 break;
mcimadamore@795 3280 default:
mcimadamore@795 3281 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3282 }
duke@1 3283 }
duke@1 3284 }
duke@1 3285
duke@1 3286 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3287 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3288 }
duke@1 3289
duke@1 3290 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3291 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3292 }
duke@1 3293 }

mercurial