src/share/classes/com/sun/tools/javac/comp/Check.java

Tue, 13 Dec 2011 11:21:28 -0800

author
jjg
date
Tue, 13 Dec 2011 11:21:28 -0800
changeset 1157
3809292620c9
parent 1127
ca49d50318dc
child 1198
84b61130cbed
permissions
-rw-r--r--

7120736: refactor javac option handling
Reviewed-by: mcimadamore

duke@1 1 /*
jjg@815 2 * Copyright (c) 1999, 2011, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
duke@1 30
duke@1 31 import com.sun.tools.javac.code.*;
duke@1 32 import com.sun.tools.javac.jvm.*;
duke@1 33 import com.sun.tools.javac.tree.*;
duke@1 34 import com.sun.tools.javac.util.*;
duke@1 35 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 36 import com.sun.tools.javac.util.List;
duke@1 37
duke@1 38 import com.sun.tools.javac.tree.JCTree.*;
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
duke@1 43
duke@1 44 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 45 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 46 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 47 import static com.sun.tools.javac.code.Kinds.*;
duke@1 48 import static com.sun.tools.javac.code.TypeTags.*;
jjg@1127 49 import static com.sun.tools.javac.code.TypeTags.WILDCARD;
duke@1 50
jjg@1127 51 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 52
duke@1 53 /** Type checking helper class for the attribution phase.
duke@1 54 *
jjg@581 55 * <p><b>This is NOT part of any supported API.
jjg@581 56 * If you write code that depends on this, you do so at your own risk.
duke@1 57 * This code and its internal interfaces are subject to change or
duke@1 58 * deletion without notice.</b>
duke@1 59 */
duke@1 60 public class Check {
duke@1 61 protected static final Context.Key<Check> checkKey =
duke@1 62 new Context.Key<Check>();
duke@1 63
jjg@113 64 private final Names names;
duke@1 65 private final Log log;
duke@1 66 private final Symtab syms;
mcimadamore@690 67 private final Enter enter;
duke@1 68 private final Infer infer;
duke@1 69 private final Types types;
mcimadamore@89 70 private final JCDiagnostic.Factory diags;
duke@1 71 private final boolean skipAnnotations;
mcimadamore@359 72 private boolean warnOnSyntheticConflicts;
jjg@576 73 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 74 private boolean enableSunApiLintControl;
duke@1 75 private final TreeInfo treeinfo;
duke@1 76
duke@1 77 // The set of lint options currently in effect. It is initialized
duke@1 78 // from the context, and then is set/reset as needed by Attr as it
duke@1 79 // visits all the various parts of the trees during attribution.
duke@1 80 private Lint lint;
duke@1 81
mcimadamore@795 82 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 83 // Attr as it visits new method declarations.
mcimadamore@795 84 private MethodSymbol method;
mcimadamore@795 85
duke@1 86 public static Check instance(Context context) {
duke@1 87 Check instance = context.get(checkKey);
duke@1 88 if (instance == null)
duke@1 89 instance = new Check(context);
duke@1 90 return instance;
duke@1 91 }
duke@1 92
duke@1 93 protected Check(Context context) {
duke@1 94 context.put(checkKey, this);
duke@1 95
jjg@113 96 names = Names.instance(context);
duke@1 97 log = Log.instance(context);
duke@1 98 syms = Symtab.instance(context);
mcimadamore@690 99 enter = Enter.instance(context);
duke@1 100 infer = Infer.instance(context);
duke@1 101 this.types = Types.instance(context);
mcimadamore@89 102 diags = JCDiagnostic.Factory.instance(context);
duke@1 103 Options options = Options.instance(context);
duke@1 104 lint = Lint.instance(context);
duke@1 105 treeinfo = TreeInfo.instance(context);
duke@1 106
duke@1 107 Source source = Source.instance(context);
duke@1 108 allowGenerics = source.allowGenerics();
duke@1 109 allowAnnotations = source.allowAnnotations();
jjg@398 110 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 111 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
jjg@1157 112 complexInference = options.isSet("complexinference");
jjg@700 113 skipAnnotations = options.isSet("skipAnnotations");
jjg@700 114 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 115 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 116 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 117
jjg@398 118 Target target = Target.instance(context);
jjg@398 119 syntheticNameChar = target.syntheticNameChar();
jjg@398 120
duke@1 121 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 122 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 123 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 124 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 125
jjg@60 126 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 127 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 128 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 129 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 130 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 131 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 132
mcimadamore@852 133 deferredLintHandler = DeferredLintHandler.immediateHandler;
duke@1 134 }
duke@1 135
duke@1 136 /** Switch: generics enabled?
duke@1 137 */
duke@1 138 boolean allowGenerics;
duke@1 139
duke@1 140 /** Switch: annotations enabled?
duke@1 141 */
duke@1 142 boolean allowAnnotations;
duke@1 143
jjg@398 144 /** Switch: covariant returns enabled?
jjg@398 145 */
jjg@398 146 boolean allowCovariantReturns;
jjg@398 147
mcimadamore@795 148 /** Switch: simplified varargs enabled?
mcimadamore@795 149 */
mcimadamore@795 150 boolean allowSimplifiedVarargs;
mcimadamore@795 151
duke@1 152 /** Switch: -complexinference option set?
duke@1 153 */
duke@1 154 boolean complexInference;
duke@1 155
jjg@398 156 /** Character for synthetic names
jjg@398 157 */
jjg@398 158 char syntheticNameChar;
jjg@398 159
duke@1 160 /** A table mapping flat names of all compiled classes in this run to their
duke@1 161 * symbols; maintained from outside.
duke@1 162 */
duke@1 163 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 164
duke@1 165 /** A handler for messages about deprecated usage.
duke@1 166 */
duke@1 167 private MandatoryWarningHandler deprecationHandler;
duke@1 168
duke@1 169 /** A handler for messages about unchecked or unsafe usage.
duke@1 170 */
duke@1 171 private MandatoryWarningHandler uncheckedHandler;
duke@1 172
jjg@582 173 /** A handler for messages about using proprietary API.
jjg@377 174 */
jjg@377 175 private MandatoryWarningHandler sunApiHandler;
duke@1 176
mcimadamore@852 177 /** A handler for deferred lint warnings.
mcimadamore@852 178 */
mcimadamore@852 179 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 180
duke@1 181 /* *************************************************************************
duke@1 182 * Errors and Warnings
duke@1 183 **************************************************************************/
duke@1 184
duke@1 185 Lint setLint(Lint newLint) {
duke@1 186 Lint prev = lint;
duke@1 187 lint = newLint;
duke@1 188 return prev;
duke@1 189 }
duke@1 190
mcimadamore@852 191 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
mcimadamore@852 192 DeferredLintHandler prev = deferredLintHandler;
mcimadamore@852 193 deferredLintHandler = newDeferredLintHandler;
mcimadamore@852 194 return prev;
mcimadamore@852 195 }
mcimadamore@852 196
mcimadamore@795 197 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 198 MethodSymbol prev = method;
mcimadamore@795 199 method = newMethod;
mcimadamore@795 200 return prev;
mcimadamore@795 201 }
mcimadamore@795 202
duke@1 203 /** Warn about deprecated symbol.
duke@1 204 * @param pos Position to be used for error reporting.
duke@1 205 * @param sym The deprecated symbol.
duke@1 206 */
duke@1 207 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 208 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 209 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 210 }
duke@1 211
duke@1 212 /** Warn about unchecked operation.
duke@1 213 * @param pos Position to be used for error reporting.
duke@1 214 * @param msg A string describing the problem.
duke@1 215 */
duke@1 216 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 217 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 218 uncheckedHandler.report(pos, msg, args);
duke@1 219 }
duke@1 220
mcimadamore@580 221 /** Warn about unsafe vararg method decl.
mcimadamore@580 222 * @param pos Position to be used for error reporting.
mcimadamore@580 223 * @param sym The deprecated symbol.
mcimadamore@580 224 */
mcimadamore@795 225 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 226 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 227 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 228 }
mcimadamore@580 229
jjg@582 230 /** Warn about using proprietary API.
jjg@377 231 * @param pos Position to be used for error reporting.
jjg@377 232 * @param msg A string describing the problem.
jjg@377 233 */
jjg@377 234 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 235 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 236 sunApiHandler.report(pos, msg, args);
jjg@377 237 }
jjg@377 238
jjg@505 239 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 240 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 241 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 242 }
jjg@505 243
duke@1 244 /**
duke@1 245 * Report any deferred diagnostics.
duke@1 246 */
duke@1 247 public void reportDeferredDiagnostics() {
duke@1 248 deprecationHandler.reportDeferredDiagnostic();
duke@1 249 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 250 sunApiHandler.reportDeferredDiagnostic();
duke@1 251 }
duke@1 252
duke@1 253
duke@1 254 /** Report a failure to complete a class.
duke@1 255 * @param pos Position to be used for error reporting.
duke@1 256 * @param ex The failure to report.
duke@1 257 */
duke@1 258 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 259 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 260 if (ex instanceof ClassReader.BadClassFile
jjg@576 261 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 262 else return syms.errType;
duke@1 263 }
duke@1 264
duke@1 265 /** Report a type error.
duke@1 266 * @param pos Position to be used for error reporting.
duke@1 267 * @param problem A string describing the error.
duke@1 268 * @param found The type that was found.
duke@1 269 * @param req The type that was required.
duke@1 270 */
duke@1 271 Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
duke@1 272 log.error(pos, "prob.found.req",
duke@1 273 problem, found, req);
jjg@110 274 return types.createErrorType(found);
duke@1 275 }
duke@1 276
duke@1 277 Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
duke@1 278 log.error(pos, "prob.found.req.1", problem, found, req, explanation);
jjg@110 279 return types.createErrorType(found);
duke@1 280 }
duke@1 281
duke@1 282 /** Report an error that wrong type tag was found.
duke@1 283 * @param pos Position to be used for error reporting.
duke@1 284 * @param required An internationalized string describing the type tag
duke@1 285 * required.
duke@1 286 * @param found The type that was found.
duke@1 287 */
duke@1 288 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 289 // this error used to be raised by the parser,
jrose@267 290 // but has been delayed to this point:
jrose@267 291 if (found instanceof Type && ((Type)found).tag == VOID) {
jrose@267 292 log.error(pos, "illegal.start.of.type");
jrose@267 293 return syms.errType;
jrose@267 294 }
duke@1 295 log.error(pos, "type.found.req", found, required);
jjg@110 296 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 297 }
duke@1 298
duke@1 299 /** Report an error that symbol cannot be referenced before super
duke@1 300 * has been called.
duke@1 301 * @param pos Position to be used for error reporting.
duke@1 302 * @param sym The referenced symbol.
duke@1 303 */
duke@1 304 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 305 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 306 }
duke@1 307
duke@1 308 /** Report duplicate declaration error.
duke@1 309 */
duke@1 310 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 311 if (!sym.type.isErroneous()) {
mcimadamore@1085 312 Symbol location = sym.location();
mcimadamore@1085 313 if (location.kind == MTH &&
mcimadamore@1085 314 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 315 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 316 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 317 sym.location().enclClass());
mcimadamore@1085 318 } else {
mcimadamore@1085 319 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 320 kindName(sym.location()), sym.location());
mcimadamore@1085 321 }
duke@1 322 }
duke@1 323 }
duke@1 324
duke@1 325 /** Report array/varargs duplicate declaration
duke@1 326 */
duke@1 327 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 328 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 329 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 330 }
duke@1 331 }
duke@1 332
duke@1 333 /* ************************************************************************
duke@1 334 * duplicate declaration checking
duke@1 335 *************************************************************************/
duke@1 336
duke@1 337 /** Check that variable does not hide variable with same name in
duke@1 338 * immediately enclosing local scope.
duke@1 339 * @param pos Position for error reporting.
duke@1 340 * @param v The symbol.
duke@1 341 * @param s The scope.
duke@1 342 */
duke@1 343 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 344 if (s.next != null) {
duke@1 345 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 346 e.scope != null && e.sym.owner == v.owner;
duke@1 347 e = e.next()) {
duke@1 348 if (e.sym.kind == VAR &&
duke@1 349 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 350 v.name != names.error) {
duke@1 351 duplicateError(pos, e.sym);
duke@1 352 return;
duke@1 353 }
duke@1 354 }
duke@1 355 }
duke@1 356 }
duke@1 357
duke@1 358 /** Check that a class or interface does not hide a class or
duke@1 359 * interface with same name in immediately enclosing local scope.
duke@1 360 * @param pos Position for error reporting.
duke@1 361 * @param c The symbol.
duke@1 362 * @param s The scope.
duke@1 363 */
duke@1 364 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 365 if (s.next != null) {
duke@1 366 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 367 e.scope != null && e.sym.owner == c.owner;
duke@1 368 e = e.next()) {
mcimadamore@639 369 if (e.sym.kind == TYP && e.sym.type.tag != TYPEVAR &&
duke@1 370 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 371 c.name != names.error) {
duke@1 372 duplicateError(pos, e.sym);
duke@1 373 return;
duke@1 374 }
duke@1 375 }
duke@1 376 }
duke@1 377 }
duke@1 378
duke@1 379 /** Check that class does not have the same name as one of
duke@1 380 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 381 * return true if class is unique in its enclosing scope.
duke@1 382 * @param pos Position for error reporting.
duke@1 383 * @param name The class name.
duke@1 384 * @param s The enclosing scope.
duke@1 385 */
duke@1 386 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 387 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 388 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 389 duplicateError(pos, e.sym);
duke@1 390 return false;
duke@1 391 }
duke@1 392 }
duke@1 393 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 394 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 395 duplicateError(pos, sym);
duke@1 396 return true;
duke@1 397 }
duke@1 398 }
duke@1 399 return true;
duke@1 400 }
duke@1 401
duke@1 402 /* *************************************************************************
duke@1 403 * Class name generation
duke@1 404 **************************************************************************/
duke@1 405
duke@1 406 /** Return name of local class.
duke@1 407 * This is of the form <enclClass> $ n <classname>
duke@1 408 * where
duke@1 409 * enclClass is the flat name of the enclosing class,
duke@1 410 * classname is the simple name of the local class
duke@1 411 */
duke@1 412 Name localClassName(ClassSymbol c) {
duke@1 413 for (int i=1; ; i++) {
duke@1 414 Name flatname = names.
duke@1 415 fromString("" + c.owner.enclClass().flatname +
jjg@398 416 syntheticNameChar + i +
duke@1 417 c.name);
duke@1 418 if (compiled.get(flatname) == null) return flatname;
duke@1 419 }
duke@1 420 }
duke@1 421
duke@1 422 /* *************************************************************************
duke@1 423 * Type Checking
duke@1 424 **************************************************************************/
duke@1 425
duke@1 426 /** Check that a given type is assignable to a given proto-type.
duke@1 427 * If it is, return the type, otherwise return errType.
duke@1 428 * @param pos Position to be used for error reporting.
duke@1 429 * @param found The type that was found.
duke@1 430 * @param req The type that was required.
duke@1 431 */
duke@1 432 Type checkType(DiagnosticPosition pos, Type found, Type req) {
darcy@609 433 return checkType(pos, found, req, "incompatible.types");
darcy@609 434 }
darcy@609 435
darcy@609 436 Type checkType(DiagnosticPosition pos, Type found, Type req, String errKey) {
duke@1 437 if (req.tag == ERROR)
duke@1 438 return req;
mcimadamore@536 439 if (found.tag == FORALL)
mcimadamore@536 440 return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req));
duke@1 441 if (req.tag == NONE)
duke@1 442 return found;
duke@1 443 if (types.isAssignable(found, req, convertWarner(pos, found, req)))
duke@1 444 return found;
duke@1 445 if (found.tag <= DOUBLE && req.tag <= DOUBLE)
mcimadamore@89 446 return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req);
duke@1 447 if (found.isSuperBound()) {
duke@1 448 log.error(pos, "assignment.from.super-bound", found);
jjg@110 449 return types.createErrorType(found);
duke@1 450 }
duke@1 451 if (req.isExtendsBound()) {
duke@1 452 log.error(pos, "assignment.to.extends-bound", req);
jjg@110 453 return types.createErrorType(found);
duke@1 454 }
darcy@609 455 return typeError(pos, diags.fragment(errKey), found, req);
duke@1 456 }
duke@1 457
duke@1 458 /** Instantiate polymorphic type to some prototype, unless
duke@1 459 * prototype is `anyPoly' in which case polymorphic type
duke@1 460 * is returned unchanged.
duke@1 461 */
mcimadamore@383 462 Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException {
duke@1 463 if (pt == Infer.anyPoly && complexInference) {
duke@1 464 return t;
duke@1 465 } else if (pt == Infer.anyPoly || pt.tag == NONE) {
duke@1 466 Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
duke@1 467 return instantiatePoly(pos, t, newpt, warn);
duke@1 468 } else if (pt.tag == ERROR) {
duke@1 469 return pt;
duke@1 470 } else {
mcimadamore@536 471 try {
mcimadamore@536 472 return infer.instantiateExpr(t, pt, warn);
mcimadamore@536 473 } catch (Infer.NoInstanceException ex) {
mcimadamore@536 474 if (ex.isAmbiguous) {
mcimadamore@536 475 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 476 log.error(pos,
mcimadamore@536 477 "undetermined.type" + (d!=null ? ".1" : ""),
mcimadamore@536 478 t, d);
mcimadamore@536 479 return types.createErrorType(pt);
mcimadamore@536 480 } else {
mcimadamore@536 481 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 482 return typeError(pos,
mcimadamore@536 483 diags.fragment("incompatible.types" + (d!=null ? ".1" : ""), d),
mcimadamore@536 484 t, pt);
mcimadamore@536 485 }
mcimadamore@536 486 } catch (Infer.InvalidInstanceException ex) {
mcimadamore@536 487 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 488 log.error(pos, "invalid.inferred.types", t.tvars, d);
mcimadamore@536 489 return types.createErrorType(pt);
mcimadamore@536 490 }
duke@1 491 }
mcimadamore@536 492 }
duke@1 493
duke@1 494 /** Check that a given type can be cast to a given target type.
duke@1 495 * Return the result of the cast.
duke@1 496 * @param pos Position to be used for error reporting.
duke@1 497 * @param found The type that is being cast.
duke@1 498 * @param req The target type of the cast.
duke@1 499 */
duke@1 500 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
duke@1 501 if (found.tag == FORALL) {
duke@1 502 instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
duke@1 503 return req;
duke@1 504 } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 505 return req;
duke@1 506 } else {
duke@1 507 return typeError(pos,
mcimadamore@89 508 diags.fragment("inconvertible.types"),
duke@1 509 found, req);
duke@1 510 }
duke@1 511 }
duke@1 512 //where
duke@1 513 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 514 * type variables?
duke@1 515 */
duke@1 516 boolean isTypeVar(Type t) {
duke@1 517 return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
duke@1 518 }
duke@1 519
duke@1 520 /** Check that a type is within some bounds.
duke@1 521 *
duke@1 522 * Used in TypeApply to verify that, e.g., X in V<X> is a valid
duke@1 523 * type argument.
duke@1 524 * @param pos Position to be used for error reporting.
duke@1 525 * @param a The type that should be bounded by bs.
duke@1 526 * @param bs The bound.
duke@1 527 */
mcimadamore@821 528 private boolean checkExtends(Type a, TypeVar bs) {
mcimadamore@154 529 if (a.isUnbound()) {
mcimadamore@821 530 return true;
mcimadamore@154 531 } else if (a.tag != WILDCARD) {
mcimadamore@154 532 a = types.upperBound(a);
mcimadamore@821 533 return types.isSubtype(a, bs.bound);
mcimadamore@154 534 } else if (a.isExtendsBound()) {
mcimadamore@821 535 return types.isCastable(bs.getUpperBound(), types.upperBound(a), Warner.noWarnings);
mcimadamore@154 536 } else if (a.isSuperBound()) {
mcimadamore@821 537 return !types.notSoftSubtype(types.lowerBound(a), bs.getUpperBound());
mcimadamore@154 538 }
mcimadamore@821 539 return true;
mcimadamore@154 540 }
duke@1 541
duke@1 542 /** Check that type is different from 'void'.
duke@1 543 * @param pos Position to be used for error reporting.
duke@1 544 * @param t The type to be checked.
duke@1 545 */
duke@1 546 Type checkNonVoid(DiagnosticPosition pos, Type t) {
duke@1 547 if (t.tag == VOID) {
duke@1 548 log.error(pos, "void.not.allowed.here");
jjg@110 549 return types.createErrorType(t);
duke@1 550 } else {
duke@1 551 return t;
duke@1 552 }
duke@1 553 }
duke@1 554
duke@1 555 /** Check that type is a class or interface type.
duke@1 556 * @param pos Position to be used for error reporting.
duke@1 557 * @param t The type to be checked.
duke@1 558 */
duke@1 559 Type checkClassType(DiagnosticPosition pos, Type t) {
duke@1 560 if (t.tag != CLASS && t.tag != ERROR)
duke@1 561 return typeTagError(pos,
mcimadamore@89 562 diags.fragment("type.req.class"),
duke@1 563 (t.tag == TYPEVAR)
mcimadamore@89 564 ? diags.fragment("type.parameter", t)
duke@1 565 : t);
duke@1 566 else
duke@1 567 return t;
duke@1 568 }
duke@1 569
duke@1 570 /** Check that type is a class or interface type.
duke@1 571 * @param pos Position to be used for error reporting.
duke@1 572 * @param t The type to be checked.
duke@1 573 * @param noBounds True if type bounds are illegal here.
duke@1 574 */
duke@1 575 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 576 t = checkClassType(pos, t);
duke@1 577 if (noBounds && t.isParameterized()) {
duke@1 578 List<Type> args = t.getTypeArguments();
duke@1 579 while (args.nonEmpty()) {
duke@1 580 if (args.head.tag == WILDCARD)
duke@1 581 return typeTagError(pos,
jjg@598 582 diags.fragment("type.req.exact"),
duke@1 583 args.head);
duke@1 584 args = args.tail;
duke@1 585 }
duke@1 586 }
duke@1 587 return t;
duke@1 588 }
duke@1 589
duke@1 590 /** Check that type is a reifiable class, interface or array type.
duke@1 591 * @param pos Position to be used for error reporting.
duke@1 592 * @param t The type to be checked.
duke@1 593 */
duke@1 594 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
duke@1 595 if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
duke@1 596 return typeTagError(pos,
mcimadamore@89 597 diags.fragment("type.req.class.array"),
duke@1 598 t);
duke@1 599 } else if (!types.isReifiable(t)) {
duke@1 600 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 601 return types.createErrorType(t);
duke@1 602 } else {
duke@1 603 return t;
duke@1 604 }
duke@1 605 }
duke@1 606
duke@1 607 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 608 * or a type variable.
duke@1 609 * @param pos Position to be used for error reporting.
duke@1 610 * @param t The type to be checked.
duke@1 611 */
duke@1 612 Type checkRefType(DiagnosticPosition pos, Type t) {
duke@1 613 switch (t.tag) {
duke@1 614 case CLASS:
duke@1 615 case ARRAY:
duke@1 616 case TYPEVAR:
duke@1 617 case WILDCARD:
duke@1 618 case ERROR:
duke@1 619 return t;
duke@1 620 default:
duke@1 621 return typeTagError(pos,
mcimadamore@89 622 diags.fragment("type.req.ref"),
duke@1 623 t);
duke@1 624 }
duke@1 625 }
duke@1 626
jrose@267 627 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 628 * or a type variable.
jrose@267 629 * @param trees Original trees, used for error reporting.
jrose@267 630 * @param types The types to be checked.
jrose@267 631 */
jrose@267 632 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 633 List<JCExpression> tl = trees;
jrose@267 634 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 635 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 636 tl = tl.tail;
jrose@267 637 }
jrose@267 638 return types;
jrose@267 639 }
jrose@267 640
duke@1 641 /** Check that type is a null or reference type.
duke@1 642 * @param pos Position to be used for error reporting.
duke@1 643 * @param t The type to be checked.
duke@1 644 */
duke@1 645 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
duke@1 646 switch (t.tag) {
duke@1 647 case CLASS:
duke@1 648 case ARRAY:
duke@1 649 case TYPEVAR:
duke@1 650 case WILDCARD:
duke@1 651 case BOT:
duke@1 652 case ERROR:
duke@1 653 return t;
duke@1 654 default:
duke@1 655 return typeTagError(pos,
mcimadamore@89 656 diags.fragment("type.req.ref"),
duke@1 657 t);
duke@1 658 }
duke@1 659 }
duke@1 660
duke@1 661 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 662 * Return true if it doesn't.
duke@1 663 * @param pos Position to be used for error reporting.
duke@1 664 * @param flags The set of flags to be checked.
duke@1 665 * @param set1 Conflicting flags set #1.
duke@1 666 * @param set2 Conflicting flags set #2.
duke@1 667 */
duke@1 668 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 669 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 670 log.error(pos,
duke@1 671 "illegal.combination.of.modifiers",
mcimadamore@80 672 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 673 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 674 return false;
duke@1 675 } else
duke@1 676 return true;
duke@1 677 }
duke@1 678
mcimadamore@914 679 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 680 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 681 */
mcimadamore@914 682 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 683 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 684 t.isErroneous()) {
mcimadamore@914 685 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 686 } else if (tree.def != null) {
mcimadamore@914 687 log.error(tree.clazz.pos(),
mcimadamore@914 688 "cant.apply.diamond.1",
mcimadamore@914 689 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 690 return types.createErrorType(t);
mcimadamore@948 691 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 692 log.error(tree.clazz.pos(),
mcimadamore@914 693 "cant.apply.diamond.1",
mcimadamore@914 694 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 695 return types.createErrorType(t);
mcimadamore@993 696 } else if (tree.typeargs != null &&
mcimadamore@993 697 tree.typeargs.nonEmpty()) {
mcimadamore@993 698 log.error(tree.clazz.pos(),
mcimadamore@993 699 "cant.apply.diamond.1",
mcimadamore@993 700 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 701 return types.createErrorType(t);
mcimadamore@914 702 } else {
mcimadamore@914 703 return t;
mcimadamore@537 704 }
mcimadamore@537 705 }
mcimadamore@537 706
mcimadamore@795 707 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 708 MethodSymbol m = tree.sym;
mcimadamore@795 709 if (!allowSimplifiedVarargs) return;
mcimadamore@795 710 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 711 Type varargElemType = null;
mcimadamore@580 712 if (m.isVarArgs()) {
mcimadamore@795 713 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 714 }
mcimadamore@795 715 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 716 if (varargElemType != null) {
mcimadamore@795 717 log.error(tree,
mcimadamore@795 718 "varargs.invalid.trustme.anno",
mcimadamore@795 719 syms.trustMeType.tsym,
mcimadamore@795 720 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 721 } else {
mcimadamore@795 722 log.error(tree,
mcimadamore@795 723 "varargs.invalid.trustme.anno",
mcimadamore@795 724 syms.trustMeType.tsym,
mcimadamore@795 725 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 726 }
mcimadamore@795 727 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 728 types.isReifiable(varargElemType)) {
mcimadamore@795 729 warnUnsafeVararg(tree,
mcimadamore@795 730 "varargs.redundant.trustme.anno",
mcimadamore@795 731 syms.trustMeType.tsym,
mcimadamore@795 732 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 733 }
mcimadamore@795 734 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 735 !types.isReifiable(varargElemType)) {
mcimadamore@795 736 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 737 }
mcimadamore@580 738 }
mcimadamore@795 739 //where
mcimadamore@795 740 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 741 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 742 (s.isConstructor() ||
mcimadamore@795 743 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 744 }
mcimadamore@580 745
mcimadamore@547 746 /**
mcimadamore@547 747 * Check that vararg method call is sound
mcimadamore@547 748 * @param pos Position to be used for error reporting.
mcimadamore@547 749 * @param argtypes Actual arguments supplied to vararg method.
mcimadamore@547 750 */
mcimadamore@795 751 void checkVararg(DiagnosticPosition pos, List<Type> argtypes, Symbol msym) {
mcimadamore@547 752 Type argtype = argtypes.last();
mcimadamore@795 753 if (!types.isReifiable(argtype) &&
mcimadamore@795 754 (!allowSimplifiedVarargs ||
mcimadamore@795 755 msym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@795 756 !isTrustMeAllowedOnMethod(msym))) {
mcimadamore@547 757 warnUnchecked(pos,
mcimadamore@547 758 "unchecked.generic.array.creation",
mcimadamore@547 759 argtype);
mcimadamore@580 760 }
mcimadamore@547 761 }
mcimadamore@547 762
mcimadamore@821 763 /**
mcimadamore@821 764 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 765 * (see JLS 4.5)
mcimadamore@821 766 *
mcimadamore@821 767 * @param t class type to be checked
mcimadamore@821 768 * @return true if 't' is well-formed
mcimadamore@821 769 */
mcimadamore@821 770 public boolean checkValidGenericType(Type t) {
mcimadamore@821 771 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 772 }
mcimadamore@821 773 //WHERE
mcimadamore@821 774 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 775 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 776 List<Type> actuals = type.allparams();
mcimadamore@821 777 List<Type> args = type.getTypeArguments();
mcimadamore@821 778 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@821 779 ListBuffer<Type> tvars_buf = new ListBuffer<Type>();
mcimadamore@821 780
mcimadamore@821 781 // For matching pairs of actual argument types `a' and
mcimadamore@821 782 // formal type parameters with declared bound `b' ...
mcimadamore@821 783 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 784 // exact type arguments needs to know their
mcimadamore@821 785 // bounds (for upper and lower bound
mcimadamore@821 786 // calculations). So we create new TypeVars with
mcimadamore@821 787 // bounds substed with actuals.
mcimadamore@821 788 tvars_buf.append(types.substBound(((TypeVar)forms.head),
mcimadamore@821 789 formals,
mcimadamore@821 790 actuals));
mcimadamore@821 791 args = args.tail;
mcimadamore@821 792 forms = forms.tail;
mcimadamore@821 793 }
mcimadamore@821 794
mcimadamore@821 795 args = type.getTypeArguments();
mcimadamore@821 796 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 797 formals,
mcimadamore@821 798 types.capture(type).allparams());
mcimadamore@821 799 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 800 // Let the actual arguments know their bound
mcimadamore@821 801 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 802 args = args.tail;
mcimadamore@821 803 tvars_cap = tvars_cap.tail;
mcimadamore@821 804 }
mcimadamore@821 805
mcimadamore@821 806 args = type.getTypeArguments();
mcimadamore@821 807 List<Type> tvars = tvars_buf.toList();
mcimadamore@821 808
mcimadamore@821 809 while (args.nonEmpty() && tvars.nonEmpty()) {
mcimadamore@821 810 Type actual = types.subst(args.head,
mcimadamore@821 811 type.tsym.type.getTypeArguments(),
mcimadamore@821 812 tvars_buf.toList());
mcimadamore@854 813 if (!isTypeArgErroneous(actual) &&
mcimadamore@854 814 !tvars.head.getUpperBound().isErroneous() &&
mcimadamore@854 815 !checkExtends(actual, (TypeVar)tvars.head)) {
mcimadamore@821 816 return args.head;
mcimadamore@821 817 }
mcimadamore@821 818 args = args.tail;
mcimadamore@821 819 tvars = tvars.tail;
mcimadamore@821 820 }
mcimadamore@821 821
mcimadamore@821 822 args = type.getTypeArguments();
mcimadamore@828 823 tvars = tvars_buf.toList();
mcimadamore@821 824
mcimadamore@821 825 for (Type arg : types.capture(type).getTypeArguments()) {
mcimadamore@828 826 if (arg.tag == TYPEVAR &&
mcimadamore@828 827 arg.getUpperBound().isErroneous() &&
mcimadamore@854 828 !tvars.head.getUpperBound().isErroneous() &&
mcimadamore@854 829 !isTypeArgErroneous(args.head)) {
mcimadamore@821 830 return args.head;
mcimadamore@821 831 }
mcimadamore@828 832 tvars = tvars.tail;
mcimadamore@854 833 args = args.tail;
mcimadamore@821 834 }
mcimadamore@821 835
mcimadamore@821 836 return null;
mcimadamore@821 837 }
mcimadamore@854 838 //where
mcimadamore@854 839 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 840 return isTypeArgErroneous.visit(t);
mcimadamore@854 841 }
mcimadamore@854 842
mcimadamore@854 843 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 844 public Boolean visitType(Type t, Void s) {
mcimadamore@854 845 return t.isErroneous();
mcimadamore@854 846 }
mcimadamore@854 847 @Override
mcimadamore@854 848 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 849 return visit(t.getUpperBound());
mcimadamore@854 850 }
mcimadamore@854 851 @Override
mcimadamore@854 852 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 853 return visit(t.getUpperBound()) ||
mcimadamore@854 854 visit(t.getLowerBound());
mcimadamore@854 855 }
mcimadamore@854 856 @Override
mcimadamore@854 857 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 858 return visit(t.type);
mcimadamore@854 859 }
mcimadamore@854 860 };
mcimadamore@821 861
duke@1 862 /** Check that given modifiers are legal for given symbol and
duke@1 863 * return modifiers together with any implicit modififiers for that symbol.
duke@1 864 * Warning: we can't use flags() here since this method
duke@1 865 * is called during class enter, when flags() would cause a premature
duke@1 866 * completion.
duke@1 867 * @param pos Position to be used for error reporting.
duke@1 868 * @param flags The set of modifiers given in a definition.
duke@1 869 * @param sym The defined symbol.
duke@1 870 */
duke@1 871 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 872 long mask;
duke@1 873 long implicit = 0;
duke@1 874 switch (sym.kind) {
duke@1 875 case VAR:
duke@1 876 if (sym.owner.kind != TYP)
duke@1 877 mask = LocalVarFlags;
duke@1 878 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 879 mask = implicit = InterfaceVarFlags;
duke@1 880 else
duke@1 881 mask = VarFlags;
duke@1 882 break;
duke@1 883 case MTH:
duke@1 884 if (sym.name == names.init) {
duke@1 885 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 886 // enum constructors cannot be declared public or
duke@1 887 // protected and must be implicitly or explicitly
duke@1 888 // private
duke@1 889 implicit = PRIVATE;
duke@1 890 mask = PRIVATE;
duke@1 891 } else
duke@1 892 mask = ConstructorFlags;
duke@1 893 } else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 894 mask = implicit = InterfaceMethodFlags;
duke@1 895 else {
duke@1 896 mask = MethodFlags;
duke@1 897 }
duke@1 898 // Imply STRICTFP if owner has STRICTFP set.
duke@1 899 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 900 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 901 break;
duke@1 902 case TYP:
duke@1 903 if (sym.isLocal()) {
duke@1 904 mask = LocalClassFlags;
jjg@113 905 if (sym.name.isEmpty()) { // Anonymous class
duke@1 906 // Anonymous classes in static methods are themselves static;
duke@1 907 // that's why we admit STATIC here.
duke@1 908 mask |= STATIC;
duke@1 909 // JLS: Anonymous classes are final.
duke@1 910 implicit |= FINAL;
duke@1 911 }
duke@1 912 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 913 (flags & ENUM) != 0)
duke@1 914 log.error(pos, "enums.must.be.static");
duke@1 915 } else if (sym.owner.kind == TYP) {
duke@1 916 mask = MemberClassFlags;
duke@1 917 if (sym.owner.owner.kind == PCK ||
duke@1 918 (sym.owner.flags_field & STATIC) != 0)
duke@1 919 mask |= STATIC;
duke@1 920 else if ((flags & ENUM) != 0)
duke@1 921 log.error(pos, "enums.must.be.static");
duke@1 922 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 923 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 924 } else {
duke@1 925 mask = ClassFlags;
duke@1 926 }
duke@1 927 // Interfaces are always ABSTRACT
duke@1 928 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 929
duke@1 930 if ((flags & ENUM) != 0) {
duke@1 931 // enums can't be declared abstract or final
duke@1 932 mask &= ~(ABSTRACT | FINAL);
duke@1 933 implicit |= implicitEnumFinalFlag(tree);
duke@1 934 }
duke@1 935 // Imply STRICTFP if owner has STRICTFP set.
duke@1 936 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 937 break;
duke@1 938 default:
duke@1 939 throw new AssertionError();
duke@1 940 }
duke@1 941 long illegal = flags & StandardFlags & ~mask;
duke@1 942 if (illegal != 0) {
duke@1 943 if ((illegal & INTERFACE) != 0) {
duke@1 944 log.error(pos, "intf.not.allowed.here");
duke@1 945 mask |= INTERFACE;
duke@1 946 }
duke@1 947 else {
duke@1 948 log.error(pos,
mcimadamore@80 949 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 950 }
duke@1 951 }
duke@1 952 else if ((sym.kind == TYP ||
duke@1 953 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 954 // in the presence of inner classes. Should it be deleted here?
duke@1 955 checkDisjoint(pos, flags,
duke@1 956 ABSTRACT,
duke@1 957 PRIVATE | STATIC))
duke@1 958 &&
duke@1 959 checkDisjoint(pos, flags,
duke@1 960 ABSTRACT | INTERFACE,
duke@1 961 FINAL | NATIVE | SYNCHRONIZED)
duke@1 962 &&
duke@1 963 checkDisjoint(pos, flags,
duke@1 964 PUBLIC,
duke@1 965 PRIVATE | PROTECTED)
duke@1 966 &&
duke@1 967 checkDisjoint(pos, flags,
duke@1 968 PRIVATE,
duke@1 969 PUBLIC | PROTECTED)
duke@1 970 &&
duke@1 971 checkDisjoint(pos, flags,
duke@1 972 FINAL,
duke@1 973 VOLATILE)
duke@1 974 &&
duke@1 975 (sym.kind == TYP ||
duke@1 976 checkDisjoint(pos, flags,
duke@1 977 ABSTRACT | NATIVE,
duke@1 978 STRICTFP))) {
duke@1 979 // skip
duke@1 980 }
duke@1 981 return flags & (mask | ~StandardFlags) | implicit;
duke@1 982 }
duke@1 983
duke@1 984
duke@1 985 /** Determine if this enum should be implicitly final.
duke@1 986 *
duke@1 987 * If the enum has no specialized enum contants, it is final.
duke@1 988 *
duke@1 989 * If the enum does have specialized enum contants, it is
duke@1 990 * <i>not</i> final.
duke@1 991 */
duke@1 992 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 993 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 994 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 995 boolean specialized;
duke@1 996 SpecialTreeVisitor() {
duke@1 997 this.specialized = false;
duke@1 998 };
duke@1 999
jjg@398 1000 @Override
duke@1 1001 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1002
jjg@398 1003 @Override
duke@1 1004 public void visitVarDef(JCVariableDecl tree) {
duke@1 1005 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1006 if (tree.init instanceof JCNewClass &&
duke@1 1007 ((JCNewClass) tree.init).def != null) {
duke@1 1008 specialized = true;
duke@1 1009 }
duke@1 1010 }
duke@1 1011 }
duke@1 1012 }
duke@1 1013
duke@1 1014 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1015 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1016 for (JCTree defs: cdef.defs) {
duke@1 1017 defs.accept(sts);
duke@1 1018 if (sts.specialized) return 0;
duke@1 1019 }
duke@1 1020 return FINAL;
duke@1 1021 }
duke@1 1022
duke@1 1023 /* *************************************************************************
duke@1 1024 * Type Validation
duke@1 1025 **************************************************************************/
duke@1 1026
duke@1 1027 /** Validate a type expression. That is,
duke@1 1028 * check that all type arguments of a parametric type are within
duke@1 1029 * their bounds. This must be done in a second phase after type attributon
duke@1 1030 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1031 *
duke@1 1032 * class B<A extends C> { ... }
duke@1 1033 * class C extends B<C> { ... }
duke@1 1034 *
duke@1 1035 * and we can't make sure that the bound is already attributed because
duke@1 1036 * of possible cycles.
mcimadamore@638 1037 *
mcimadamore@638 1038 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1039 * and reporting any completion failures.
duke@1 1040 */
mcimadamore@122 1041 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1042 validate(tree, env, true);
duke@1 1043 }
mcimadamore@638 1044 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1045 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1046 }
duke@1 1047
duke@1 1048 /** Visitor method: Validate a list of type expressions.
duke@1 1049 */
mcimadamore@122 1050 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1051 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1052 validate(l.head, env);
duke@1 1053 }
duke@1 1054
duke@1 1055 /** A visitor class for type validation.
duke@1 1056 */
duke@1 1057 class Validator extends JCTree.Visitor {
duke@1 1058
mcimadamore@638 1059 boolean isOuter;
mcimadamore@638 1060 Env<AttrContext> env;
mcimadamore@638 1061
mcimadamore@638 1062 Validator(Env<AttrContext> env) {
mcimadamore@638 1063 this.env = env;
mcimadamore@638 1064 }
mcimadamore@638 1065
jjg@398 1066 @Override
duke@1 1067 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1068 tree.elemtype.accept(this);
duke@1 1069 }
duke@1 1070
jjg@398 1071 @Override
duke@1 1072 public void visitTypeApply(JCTypeApply tree) {
duke@1 1073 if (tree.type.tag == CLASS) {
duke@1 1074 List<JCExpression> args = tree.arguments;
mcimadamore@158 1075 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1076
mcimadamore@821 1077 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1078 if (incompatibleArg != null) {
mcimadamore@821 1079 for (JCTree arg : tree.arguments) {
mcimadamore@821 1080 if (arg.type == incompatibleArg) {
mcimadamore@829 1081 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1082 }
mcimadamore@829 1083 forms = forms.tail;
mcimadamore@829 1084 }
mcimadamore@829 1085 }
mcimadamore@829 1086
mcimadamore@829 1087 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1088
mcimadamore@638 1089 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1090
duke@1 1091 // For matching pairs of actual argument types `a' and
duke@1 1092 // formal type parameters with declared bound `b' ...
duke@1 1093 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1094 validateTree(args.head,
mcimadamore@638 1095 !(isOuter && is_java_lang_Class),
mcimadamore@638 1096 false);
duke@1 1097 args = args.tail;
duke@1 1098 forms = forms.tail;
duke@1 1099 }
duke@1 1100
duke@1 1101 // Check that this type is either fully parameterized, or
duke@1 1102 // not parameterized at all.
duke@1 1103 if (tree.type.getEnclosingType().isRaw())
duke@1 1104 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1105 if (tree.clazz.hasTag(SELECT))
duke@1 1106 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1107 }
duke@1 1108 }
duke@1 1109
jjg@398 1110 @Override
duke@1 1111 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1112 validateTrees(tree.bounds, true, isOuter);
duke@1 1113 checkClassBounds(tree.pos(), tree.type);
duke@1 1114 }
duke@1 1115
duke@1 1116 @Override
duke@1 1117 public void visitWildcard(JCWildcard tree) {
duke@1 1118 if (tree.inner != null)
mcimadamore@638 1119 validateTree(tree.inner, true, isOuter);
duke@1 1120 }
duke@1 1121
jjg@398 1122 @Override
duke@1 1123 public void visitSelect(JCFieldAccess tree) {
duke@1 1124 if (tree.type.tag == CLASS) {
duke@1 1125 visitSelectInternal(tree);
duke@1 1126
duke@1 1127 // Check that this type is either fully parameterized, or
duke@1 1128 // not parameterized at all.
duke@1 1129 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1130 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1131 }
duke@1 1132 }
mcimadamore@852 1133
duke@1 1134 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1135 if (tree.type.tsym.isStatic() &&
duke@1 1136 tree.selected.type.isParameterized()) {
duke@1 1137 // The enclosing type is not a class, so we are
duke@1 1138 // looking at a static member type. However, the
duke@1 1139 // qualifying expression is parameterized.
duke@1 1140 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1141 } else {
duke@1 1142 // otherwise validate the rest of the expression
mcimadamore@122 1143 tree.selected.accept(this);
duke@1 1144 }
duke@1 1145 }
duke@1 1146
duke@1 1147 /** Default visitor method: do nothing.
duke@1 1148 */
jjg@398 1149 @Override
duke@1 1150 public void visitTree(JCTree tree) {
duke@1 1151 }
mcimadamore@122 1152
mcimadamore@638 1153 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1154 try {
mcimadamore@638 1155 if (tree != null) {
mcimadamore@638 1156 this.isOuter = isOuter;
mcimadamore@638 1157 tree.accept(this);
mcimadamore@638 1158 if (checkRaw)
mcimadamore@638 1159 checkRaw(tree, env);
mcimadamore@638 1160 }
mcimadamore@638 1161 } catch (CompletionFailure ex) {
mcimadamore@638 1162 completionError(tree.pos(), ex);
mcimadamore@638 1163 }
mcimadamore@638 1164 }
mcimadamore@638 1165
mcimadamore@638 1166 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1167 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1168 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1169 }
mcimadamore@638 1170
mcimadamore@638 1171 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1172 if (lint.isEnabled(LintCategory.RAW) &&
mcimadamore@638 1173 tree.type.tag == CLASS &&
mcimadamore@638 1174 !TreeInfo.isDiamond(tree) &&
mcimadamore@1103 1175 !withinAnonConstr(env) &&
mcimadamore@638 1176 tree.type.isRaw()) {
mcimadamore@795 1177 log.warning(LintCategory.RAW,
mcimadamore@638 1178 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1179 }
mcimadamore@638 1180 }
mcimadamore@1103 1181
mcimadamore@1103 1182 boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1183 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1184 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1185 }
duke@1 1186 }
duke@1 1187
duke@1 1188 /* *************************************************************************
duke@1 1189 * Exception checking
duke@1 1190 **************************************************************************/
duke@1 1191
duke@1 1192 /* The following methods treat classes as sets that contain
duke@1 1193 * the class itself and all their subclasses
duke@1 1194 */
duke@1 1195
duke@1 1196 /** Is given type a subtype of some of the types in given list?
duke@1 1197 */
duke@1 1198 boolean subset(Type t, List<Type> ts) {
duke@1 1199 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1200 if (types.isSubtype(t, l.head)) return true;
duke@1 1201 return false;
duke@1 1202 }
duke@1 1203
duke@1 1204 /** Is given type a subtype or supertype of
duke@1 1205 * some of the types in given list?
duke@1 1206 */
duke@1 1207 boolean intersects(Type t, List<Type> ts) {
duke@1 1208 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1209 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1210 return false;
duke@1 1211 }
duke@1 1212
duke@1 1213 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1214 * in the list.
duke@1 1215 */
duke@1 1216 List<Type> incl(Type t, List<Type> ts) {
duke@1 1217 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1218 }
duke@1 1219
duke@1 1220 /** Remove type set from type set list.
duke@1 1221 */
duke@1 1222 List<Type> excl(Type t, List<Type> ts) {
duke@1 1223 if (ts.isEmpty()) {
duke@1 1224 return ts;
duke@1 1225 } else {
duke@1 1226 List<Type> ts1 = excl(t, ts.tail);
duke@1 1227 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1228 else if (ts1 == ts.tail) return ts;
duke@1 1229 else return ts1.prepend(ts.head);
duke@1 1230 }
duke@1 1231 }
duke@1 1232
duke@1 1233 /** Form the union of two type set lists.
duke@1 1234 */
duke@1 1235 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1236 List<Type> ts = ts1;
duke@1 1237 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1238 ts = incl(l.head, ts);
duke@1 1239 return ts;
duke@1 1240 }
duke@1 1241
duke@1 1242 /** Form the difference of two type lists.
duke@1 1243 */
duke@1 1244 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1245 List<Type> ts = ts1;
duke@1 1246 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1247 ts = excl(l.head, ts);
duke@1 1248 return ts;
duke@1 1249 }
duke@1 1250
duke@1 1251 /** Form the intersection of two type lists.
duke@1 1252 */
duke@1 1253 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1254 List<Type> ts = List.nil();
duke@1 1255 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1256 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1257 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1258 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1259 return ts;
duke@1 1260 }
duke@1 1261
duke@1 1262 /** Is exc an exception symbol that need not be declared?
duke@1 1263 */
duke@1 1264 boolean isUnchecked(ClassSymbol exc) {
duke@1 1265 return
duke@1 1266 exc.kind == ERR ||
duke@1 1267 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1268 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1269 }
duke@1 1270
duke@1 1271 /** Is exc an exception type that need not be declared?
duke@1 1272 */
duke@1 1273 boolean isUnchecked(Type exc) {
duke@1 1274 return
duke@1 1275 (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
duke@1 1276 (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
duke@1 1277 exc.tag == BOT;
duke@1 1278 }
duke@1 1279
duke@1 1280 /** Same, but handling completion failures.
duke@1 1281 */
duke@1 1282 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1283 try {
duke@1 1284 return isUnchecked(exc);
duke@1 1285 } catch (CompletionFailure ex) {
duke@1 1286 completionError(pos, ex);
duke@1 1287 return true;
duke@1 1288 }
duke@1 1289 }
duke@1 1290
duke@1 1291 /** Is exc handled by given exception list?
duke@1 1292 */
duke@1 1293 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1294 return isUnchecked(exc) || subset(exc, handled);
duke@1 1295 }
duke@1 1296
duke@1 1297 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1298 * @param thrown The list of thrown exceptions.
duke@1 1299 * @param handled The list of handled exceptions.
duke@1 1300 */
mcimadamore@362 1301 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1302 List<Type> unhandled = List.nil();
duke@1 1303 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1304 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1305 return unhandled;
duke@1 1306 }
duke@1 1307
duke@1 1308 /* *************************************************************************
duke@1 1309 * Overriding/Implementation checking
duke@1 1310 **************************************************************************/
duke@1 1311
duke@1 1312 /** The level of access protection given by a flag set,
duke@1 1313 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1314 */
duke@1 1315 static int protection(long flags) {
duke@1 1316 switch ((short)(flags & AccessFlags)) {
duke@1 1317 case PRIVATE: return 3;
duke@1 1318 case PROTECTED: return 1;
duke@1 1319 default:
duke@1 1320 case PUBLIC: return 0;
duke@1 1321 case 0: return 2;
duke@1 1322 }
duke@1 1323 }
duke@1 1324
duke@1 1325 /** A customized "cannot override" error message.
duke@1 1326 * @param m The overriding method.
duke@1 1327 * @param other The overridden method.
duke@1 1328 * @return An internationalized string.
duke@1 1329 */
mcimadamore@89 1330 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1331 String key;
duke@1 1332 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1333 key = "cant.override";
duke@1 1334 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1335 key = "cant.implement";
duke@1 1336 else
duke@1 1337 key = "clashes.with";
mcimadamore@89 1338 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1339 }
duke@1 1340
duke@1 1341 /** A customized "override" warning message.
duke@1 1342 * @param m The overriding method.
duke@1 1343 * @param other The overridden method.
duke@1 1344 * @return An internationalized string.
duke@1 1345 */
mcimadamore@89 1346 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1347 String key;
duke@1 1348 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1349 key = "unchecked.override";
duke@1 1350 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1351 key = "unchecked.implement";
duke@1 1352 else
duke@1 1353 key = "unchecked.clash.with";
mcimadamore@89 1354 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1355 }
duke@1 1356
duke@1 1357 /** A customized "override" warning message.
duke@1 1358 * @param m The overriding method.
duke@1 1359 * @param other The overridden method.
duke@1 1360 * @return An internationalized string.
duke@1 1361 */
mcimadamore@89 1362 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1363 String key;
duke@1 1364 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1365 key = "varargs.override";
duke@1 1366 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1367 key = "varargs.implement";
duke@1 1368 else
duke@1 1369 key = "varargs.clash.with";
mcimadamore@89 1370 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1371 }
duke@1 1372
duke@1 1373 /** Check that this method conforms with overridden method 'other'.
duke@1 1374 * where `origin' is the class where checking started.
duke@1 1375 * Complications:
duke@1 1376 * (1) Do not check overriding of synthetic methods
duke@1 1377 * (reason: they might be final).
duke@1 1378 * todo: check whether this is still necessary.
duke@1 1379 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1380 * than the method it implements. Augment the proxy methods with the
duke@1 1381 * undeclared exceptions in this case.
duke@1 1382 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1383 * has a result type
duke@1 1384 * extended by the result type of the method it implements.
duke@1 1385 * Change the proxies result type to the smaller type in this case.
duke@1 1386 *
duke@1 1387 * @param tree The tree from which positions
duke@1 1388 * are extracted for errors.
duke@1 1389 * @param m The overriding method.
duke@1 1390 * @param other The overridden method.
duke@1 1391 * @param origin The class of which the overriding method
duke@1 1392 * is a member.
duke@1 1393 */
duke@1 1394 void checkOverride(JCTree tree,
duke@1 1395 MethodSymbol m,
duke@1 1396 MethodSymbol other,
duke@1 1397 ClassSymbol origin) {
duke@1 1398 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1399 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1400 return;
duke@1 1401 }
duke@1 1402
duke@1 1403 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1404 if ((m.flags() & STATIC) != 0 &&
duke@1 1405 (other.flags() & STATIC) == 0) {
duke@1 1406 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1407 cannotOverride(m, other));
duke@1 1408 return;
duke@1 1409 }
duke@1 1410
duke@1 1411 // Error if instance method overrides static or final
duke@1 1412 // method (JLS 8.4.6.1).
duke@1 1413 if ((other.flags() & FINAL) != 0 ||
duke@1 1414 (m.flags() & STATIC) == 0 &&
duke@1 1415 (other.flags() & STATIC) != 0) {
duke@1 1416 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1417 cannotOverride(m, other),
mcimadamore@80 1418 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1419 return;
duke@1 1420 }
duke@1 1421
duke@1 1422 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1423 // handled in validateAnnotationMethod
duke@1 1424 return;
duke@1 1425 }
duke@1 1426
duke@1 1427 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1428 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1429 protection(m.flags()) > protection(other.flags())) {
duke@1 1430 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1431 cannotOverride(m, other),
mcimadamore@80 1432 other.flags() == 0 ?
mcimadamore@80 1433 Flag.PACKAGE :
mcimadamore@80 1434 asFlagSet(other.flags() & AccessFlags));
duke@1 1435 return;
duke@1 1436 }
duke@1 1437
duke@1 1438 Type mt = types.memberType(origin.type, m);
duke@1 1439 Type ot = types.memberType(origin.type, other);
duke@1 1440 // Error if overriding result type is different
duke@1 1441 // (or, in the case of generics mode, not a subtype) of
duke@1 1442 // overridden result type. We have to rename any type parameters
duke@1 1443 // before comparing types.
duke@1 1444 List<Type> mtvars = mt.getTypeArguments();
duke@1 1445 List<Type> otvars = ot.getTypeArguments();
duke@1 1446 Type mtres = mt.getReturnType();
duke@1 1447 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1448
mcimadamore@795 1449 overrideWarner.clear();
duke@1 1450 boolean resultTypesOK =
tbell@202 1451 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1452 if (!resultTypesOK) {
jjg@398 1453 if (!allowCovariantReturns &&
duke@1 1454 m.owner != origin &&
duke@1 1455 m.owner.isSubClass(other.owner, types)) {
duke@1 1456 // allow limited interoperability with covariant returns
duke@1 1457 } else {
mcimadamore@362 1458 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1459 "override.incompatible.ret",
mcimadamore@362 1460 cannotOverride(m, other),
duke@1 1461 mtres, otres);
duke@1 1462 return;
duke@1 1463 }
mcimadamore@795 1464 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1465 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1466 "override.unchecked.ret",
mcimadamore@362 1467 uncheckedOverrides(m, other),
mcimadamore@362 1468 mtres, otres);
duke@1 1469 }
duke@1 1470
duke@1 1471 // Error if overriding method throws an exception not reported
duke@1 1472 // by overridden method.
duke@1 1473 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1474 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1475 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1476 if (unhandledErased.nonEmpty()) {
duke@1 1477 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1478 "override.meth.doesnt.throw",
duke@1 1479 cannotOverride(m, other),
mcimadamore@362 1480 unhandledUnerased.head);
mcimadamore@362 1481 return;
mcimadamore@362 1482 }
mcimadamore@362 1483 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1484 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1485 "override.unchecked.thrown",
mcimadamore@362 1486 cannotOverride(m, other),
mcimadamore@362 1487 unhandledUnerased.head);
duke@1 1488 return;
duke@1 1489 }
duke@1 1490
duke@1 1491 // Optional warning if varargs don't agree
duke@1 1492 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1493 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1494 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1495 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1496 ? "override.varargs.missing"
duke@1 1497 : "override.varargs.extra",
duke@1 1498 varargsOverrides(m, other));
duke@1 1499 }
duke@1 1500
duke@1 1501 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1502 if ((other.flags() & BRIDGE) != 0) {
duke@1 1503 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1504 uncheckedOverrides(m, other));
duke@1 1505 }
duke@1 1506
duke@1 1507 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1508 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1509 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1510 }
duke@1 1511 }
duke@1 1512 // where
duke@1 1513 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1514 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1515 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1516 // because in that case, we will rediscover the issue when examining the method
duke@1 1517 // in the supertype.
duke@1 1518 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1519 // address the issue is when the method is the supertype implemementation: any other
duke@1 1520 // case, we will have dealt with when examining the supertype classes
duke@1 1521 ClassSymbol mc = m.enclClass();
duke@1 1522 Type st = types.supertype(origin.type);
duke@1 1523 if (st.tag != CLASS)
duke@1 1524 return true;
duke@1 1525 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1526
duke@1 1527 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1528 List<Type> intfs = types.interfaces(origin.type);
duke@1 1529 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1530 }
duke@1 1531 else
duke@1 1532 return (stimpl != m);
duke@1 1533 }
duke@1 1534
duke@1 1535
duke@1 1536 // used to check if there were any unchecked conversions
duke@1 1537 Warner overrideWarner = new Warner();
duke@1 1538
duke@1 1539 /** Check that a class does not inherit two concrete methods
duke@1 1540 * with the same signature.
duke@1 1541 * @param pos Position to be used for error reporting.
duke@1 1542 * @param site The class type to be checked.
duke@1 1543 */
duke@1 1544 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1545 Type sup = types.supertype(site);
duke@1 1546 if (sup.tag != CLASS) return;
duke@1 1547
duke@1 1548 for (Type t1 = sup;
duke@1 1549 t1.tsym.type.isParameterized();
duke@1 1550 t1 = types.supertype(t1)) {
duke@1 1551 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1552 e1 != null;
duke@1 1553 e1 = e1.sibling) {
duke@1 1554 Symbol s1 = e1.sym;
duke@1 1555 if (s1.kind != MTH ||
duke@1 1556 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1557 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1558 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1559 types,
duke@1 1560 true) != s1)
duke@1 1561 continue;
duke@1 1562 Type st1 = types.memberType(t1, s1);
duke@1 1563 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1564 if (st1 == s1.type) continue;
duke@1 1565
duke@1 1566 for (Type t2 = sup;
duke@1 1567 t2.tag == CLASS;
duke@1 1568 t2 = types.supertype(t2)) {
mcimadamore@24 1569 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1570 e2.scope != null;
duke@1 1571 e2 = e2.next()) {
duke@1 1572 Symbol s2 = e2.sym;
duke@1 1573 if (s2 == s1 ||
duke@1 1574 s2.kind != MTH ||
duke@1 1575 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1576 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1577 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1578 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1579 types,
duke@1 1580 true) != s2)
duke@1 1581 continue;
duke@1 1582 Type st2 = types.memberType(t2, s2);
duke@1 1583 if (types.overrideEquivalent(st1, st2))
duke@1 1584 log.error(pos, "concrete.inheritance.conflict",
duke@1 1585 s1, t1, s2, t2, sup);
duke@1 1586 }
duke@1 1587 }
duke@1 1588 }
duke@1 1589 }
duke@1 1590 }
duke@1 1591
duke@1 1592 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1593 * method with same name and arguments but incompatible return types.
duke@1 1594 * @param pos Position to be used for error reporting.
duke@1 1595 * @param t1 The first argument type.
duke@1 1596 * @param t2 The second argument type.
duke@1 1597 */
duke@1 1598 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1599 Type t1,
duke@1 1600 Type t2) {
duke@1 1601 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1602 types.makeCompoundType(t1, t2));
duke@1 1603 }
duke@1 1604
duke@1 1605 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1606 Type t1,
duke@1 1607 Type t2,
duke@1 1608 Type site) {
mcimadamore@746 1609 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1610 }
duke@1 1611
duke@1 1612 /** Return the first method which is defined with same args
duke@1 1613 * but different return types in two given interfaces, or null if none
duke@1 1614 * exists.
duke@1 1615 * @param t1 The first type.
duke@1 1616 * @param t2 The second type.
duke@1 1617 * @param site The most derived type.
duke@1 1618 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1619 */
mcimadamore@746 1620 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1621 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1622 closure(t1, interfaces1);
duke@1 1623 Map<TypeSymbol,Type> interfaces2;
duke@1 1624 if (t1 == t2)
duke@1 1625 interfaces2 = interfaces1;
duke@1 1626 else
duke@1 1627 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1628
duke@1 1629 for (Type t3 : interfaces1.values()) {
duke@1 1630 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1631 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1632 if (s != null) return s;
duke@1 1633 }
duke@1 1634 }
duke@1 1635 return null;
duke@1 1636 }
duke@1 1637
duke@1 1638 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1639 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
duke@1 1640 if (t.tag != CLASS) return;
duke@1 1641 if (typeMap.put(t.tsym, t) == null) {
duke@1 1642 closure(types.supertype(t), typeMap);
duke@1 1643 for (Type i : types.interfaces(t))
duke@1 1644 closure(i, typeMap);
duke@1 1645 }
duke@1 1646 }
duke@1 1647
duke@1 1648 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1649 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
duke@1 1650 if (t.tag != CLASS) return;
duke@1 1651 if (typesSkip.get(t.tsym) != null) return;
duke@1 1652 if (typeMap.put(t.tsym, t) == null) {
duke@1 1653 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1654 for (Type i : types.interfaces(t))
duke@1 1655 closure(i, typesSkip, typeMap);
duke@1 1656 }
duke@1 1657 }
duke@1 1658
duke@1 1659 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1660 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1661 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1662 Symbol s1 = e1.sym;
duke@1 1663 Type st1 = null;
duke@1 1664 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
duke@1 1665 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1666 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1667 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1668 Symbol s2 = e2.sym;
duke@1 1669 if (s1 == s2) continue;
duke@1 1670 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
duke@1 1671 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1672 Type st2 = types.memberType(t2, s2);
duke@1 1673 if (types.overrideEquivalent(st1, st2)) {
duke@1 1674 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1675 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1676 Type rt1 = st1.getReturnType();
duke@1 1677 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1678 boolean compat =
duke@1 1679 types.isSameType(rt1, rt2) ||
duke@1 1680 rt1.tag >= CLASS && rt2.tag >= CLASS &&
duke@1 1681 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
mcimadamore@59 1682 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
mcimadamore@59 1683 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1684 if (!compat) {
mcimadamore@746 1685 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1686 t1, t2, s2.name +
mcimadamore@746 1687 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1688 return s2;
mcimadamore@746 1689 }
mcimadamore@889 1690 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1691 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1692 log.error(pos,
mcimadamore@746 1693 "name.clash.same.erasure.no.override",
mcimadamore@746 1694 s1, s1.location(),
mcimadamore@746 1695 s2, s2.location());
mcimadamore@746 1696 return s2;
duke@1 1697 }
duke@1 1698 }
duke@1 1699 }
duke@1 1700 return null;
duke@1 1701 }
mcimadamore@59 1702 //WHERE
mcimadamore@59 1703 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1704 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1705 Type st1 = types.memberType(site, s1);
mcimadamore@59 1706 Type st2 = types.memberType(site, s2);
mcimadamore@59 1707 closure(site, supertypes);
mcimadamore@59 1708 for (Type t : supertypes.values()) {
mcimadamore@59 1709 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1710 Symbol s3 = e.sym;
mcimadamore@59 1711 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1712 Type st3 = types.memberType(site,s3);
mcimadamore@59 1713 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1714 if (s3.owner == site.tsym) {
mcimadamore@59 1715 return true;
mcimadamore@59 1716 }
mcimadamore@59 1717 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1718 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1719 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1720 Type rt1 = st1.getReturnType();
mcimadamore@59 1721 Type rt2 = st2.getReturnType();
mcimadamore@59 1722 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1723 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1724 boolean compat =
mcimadamore@59 1725 rt13.tag >= CLASS && rt23.tag >= CLASS &&
mcimadamore@59 1726 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
mcimadamore@59 1727 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
mcimadamore@59 1728 if (compat)
mcimadamore@59 1729 return true;
mcimadamore@59 1730 }
mcimadamore@59 1731 }
mcimadamore@59 1732 }
mcimadamore@59 1733 return false;
mcimadamore@59 1734 }
duke@1 1735
duke@1 1736 /** Check that a given method conforms with any method it overrides.
duke@1 1737 * @param tree The tree from which positions are extracted
duke@1 1738 * for errors.
duke@1 1739 * @param m The overriding method.
duke@1 1740 */
duke@1 1741 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1742 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1743 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1744 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1745 log.error(tree.pos(), "enum.no.finalize");
duke@1 1746 return;
duke@1 1747 }
mcimadamore@746 1748 for (Type t = origin.type; t.tag == CLASS;
duke@1 1749 t = types.supertype(t)) {
mcimadamore@746 1750 if (t != origin.type) {
mcimadamore@746 1751 checkOverride(tree, t, origin, m);
mcimadamore@746 1752 }
mcimadamore@746 1753 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1754 checkOverride(tree, t2, origin, m);
duke@1 1755 }
duke@1 1756 }
duke@1 1757 }
duke@1 1758
mcimadamore@746 1759 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1760 TypeSymbol c = site.tsym;
mcimadamore@746 1761 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1762 while (e.scope != null) {
mcimadamore@746 1763 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1764 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1765 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1766 }
mcimadamore@746 1767 }
mcimadamore@746 1768 e = e.next();
mcimadamore@746 1769 }
mcimadamore@746 1770 }
mcimadamore@746 1771
mcimadamore@746 1772 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 1773 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 1774 return (cf.accepts(s1) &&
mcimadamore@858 1775 cf.accepts(s2) &&
mcimadamore@858 1776 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 1777 }
mcimadamore@746 1778
mcimadamore@746 1779
duke@1 1780 /** Check that all abstract members of given class have definitions.
duke@1 1781 * @param pos Position to be used for error reporting.
duke@1 1782 * @param c The class.
duke@1 1783 */
duke@1 1784 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1785 try {
duke@1 1786 MethodSymbol undef = firstUndef(c, c);
duke@1 1787 if (undef != null) {
duke@1 1788 if ((c.flags() & ENUM) != 0 &&
duke@1 1789 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 1790 (c.flags() & FINAL) == 0) {
duke@1 1791 // add the ABSTRACT flag to an enum
duke@1 1792 c.flags_field |= ABSTRACT;
duke@1 1793 } else {
duke@1 1794 MethodSymbol undef1 =
duke@1 1795 new MethodSymbol(undef.flags(), undef.name,
duke@1 1796 types.memberType(c.type, undef), undef.owner);
duke@1 1797 log.error(pos, "does.not.override.abstract",
duke@1 1798 c, undef1, undef1.location());
duke@1 1799 }
duke@1 1800 }
duke@1 1801 } catch (CompletionFailure ex) {
duke@1 1802 completionError(pos, ex);
duke@1 1803 }
duke@1 1804 }
duke@1 1805 //where
duke@1 1806 /** Return first abstract member of class `c' that is not defined
duke@1 1807 * in `impl', null if there is none.
duke@1 1808 */
duke@1 1809 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 1810 MethodSymbol undef = null;
duke@1 1811 // Do not bother to search in classes that are not abstract,
duke@1 1812 // since they cannot have abstract members.
duke@1 1813 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 1814 Scope s = c.members();
duke@1 1815 for (Scope.Entry e = s.elems;
duke@1 1816 undef == null && e != null;
duke@1 1817 e = e.sibling) {
duke@1 1818 if (e.sym.kind == MTH &&
duke@1 1819 (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
duke@1 1820 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 1821 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
duke@1 1822 if (implmeth == null || implmeth == absmeth)
duke@1 1823 undef = absmeth;
duke@1 1824 }
duke@1 1825 }
duke@1 1826 if (undef == null) {
duke@1 1827 Type st = types.supertype(c.type);
duke@1 1828 if (st.tag == CLASS)
duke@1 1829 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 1830 }
duke@1 1831 for (List<Type> l = types.interfaces(c.type);
duke@1 1832 undef == null && l.nonEmpty();
duke@1 1833 l = l.tail) {
duke@1 1834 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 1835 }
duke@1 1836 }
duke@1 1837 return undef;
duke@1 1838 }
duke@1 1839
mcimadamore@690 1840 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 1841 CycleChecker cc = new CycleChecker();
mcimadamore@690 1842 cc.scan(tree);
mcimadamore@690 1843 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 1844 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 1845 }
mcimadamore@690 1846 }
mcimadamore@690 1847
mcimadamore@690 1848 class CycleChecker extends TreeScanner {
mcimadamore@690 1849
mcimadamore@690 1850 List<Symbol> seenClasses = List.nil();
mcimadamore@690 1851 boolean errorFound = false;
mcimadamore@690 1852 boolean partialCheck = false;
mcimadamore@690 1853
mcimadamore@690 1854 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 1855 if (sym != null && sym.kind == TYP) {
mcimadamore@690 1856 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 1857 if (classEnv != null) {
mcimadamore@690 1858 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 1859 try {
mcimadamore@690 1860 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 1861 scan(classEnv.tree);
mcimadamore@690 1862 }
mcimadamore@690 1863 finally {
mcimadamore@690 1864 log.useSource(prevSource.getFile());
mcimadamore@690 1865 }
mcimadamore@690 1866 } else if (sym.kind == TYP) {
mcimadamore@690 1867 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 1868 }
mcimadamore@690 1869 } else {
mcimadamore@690 1870 //not completed yet
mcimadamore@690 1871 partialCheck = true;
mcimadamore@690 1872 }
mcimadamore@690 1873 }
mcimadamore@690 1874
mcimadamore@690 1875 @Override
mcimadamore@690 1876 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 1877 super.visitSelect(tree);
mcimadamore@690 1878 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 1879 }
mcimadamore@690 1880
mcimadamore@690 1881 @Override
mcimadamore@690 1882 public void visitIdent(JCIdent tree) {
mcimadamore@690 1883 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 1884 }
mcimadamore@690 1885
mcimadamore@690 1886 @Override
mcimadamore@690 1887 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 1888 scan(tree.clazz);
mcimadamore@690 1889 }
mcimadamore@690 1890
mcimadamore@690 1891 @Override
mcimadamore@690 1892 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 1893 scan(tree.elemtype);
mcimadamore@690 1894 }
mcimadamore@690 1895
mcimadamore@690 1896 @Override
mcimadamore@690 1897 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 1898 List<JCTree> supertypes = List.nil();
mcimadamore@690 1899 if (tree.getExtendsClause() != null) {
mcimadamore@690 1900 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 1901 }
mcimadamore@690 1902 if (tree.getImplementsClause() != null) {
mcimadamore@690 1903 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 1904 supertypes = supertypes.prepend(intf);
mcimadamore@690 1905 }
mcimadamore@690 1906 }
mcimadamore@690 1907 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 1908 }
mcimadamore@690 1909
mcimadamore@690 1910 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 1911 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 1912 return;
mcimadamore@690 1913 if (seenClasses.contains(c)) {
mcimadamore@690 1914 errorFound = true;
mcimadamore@690 1915 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 1916 } else if (!c.type.isErroneous()) {
mcimadamore@690 1917 try {
mcimadamore@690 1918 seenClasses = seenClasses.prepend(c);
mcimadamore@690 1919 if (c.type.tag == CLASS) {
mcimadamore@690 1920 if (supertypes.nonEmpty()) {
mcimadamore@690 1921 scan(supertypes);
mcimadamore@690 1922 }
mcimadamore@690 1923 else {
mcimadamore@690 1924 ClassType ct = (ClassType)c.type;
mcimadamore@690 1925 if (ct.supertype_field == null ||
mcimadamore@690 1926 ct.interfaces_field == null) {
mcimadamore@690 1927 //not completed yet
mcimadamore@690 1928 partialCheck = true;
mcimadamore@690 1929 return;
mcimadamore@690 1930 }
mcimadamore@690 1931 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 1932 for (Type intf : ct.interfaces_field) {
mcimadamore@690 1933 checkSymbol(pos, intf.tsym);
mcimadamore@690 1934 }
mcimadamore@690 1935 }
mcimadamore@690 1936 if (c.owner.kind == TYP) {
mcimadamore@690 1937 checkSymbol(pos, c.owner);
mcimadamore@690 1938 }
mcimadamore@690 1939 }
mcimadamore@690 1940 } finally {
mcimadamore@690 1941 seenClasses = seenClasses.tail;
mcimadamore@690 1942 }
mcimadamore@690 1943 }
mcimadamore@690 1944 }
mcimadamore@690 1945 }
mcimadamore@690 1946
duke@1 1947 /** Check for cyclic references. Issue an error if the
duke@1 1948 * symbol of the type referred to has a LOCKED flag set.
duke@1 1949 *
duke@1 1950 * @param pos Position to be used for error reporting.
duke@1 1951 * @param t The type referred to.
duke@1 1952 */
duke@1 1953 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 1954 checkNonCyclicInternal(pos, t);
duke@1 1955 }
duke@1 1956
duke@1 1957
duke@1 1958 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 1959 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 1960 }
duke@1 1961
mcimadamore@236 1962 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 1963 final TypeVar tv;
mcimadamore@42 1964 if (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 1965 return;
duke@1 1966 if (seen.contains(t)) {
duke@1 1967 tv = (TypeVar)t;
jjg@110 1968 tv.bound = types.createErrorType(t);
duke@1 1969 log.error(pos, "cyclic.inheritance", t);
duke@1 1970 } else if (t.tag == TYPEVAR) {
duke@1 1971 tv = (TypeVar)t;
mcimadamore@236 1972 seen = seen.prepend(tv);
duke@1 1973 for (Type b : types.getBounds(tv))
duke@1 1974 checkNonCyclic1(pos, b, seen);
duke@1 1975 }
duke@1 1976 }
duke@1 1977
duke@1 1978 /** Check for cyclic references. Issue an error if the
duke@1 1979 * symbol of the type referred to has a LOCKED flag set.
duke@1 1980 *
duke@1 1981 * @param pos Position to be used for error reporting.
duke@1 1982 * @param t The type referred to.
duke@1 1983 * @returns True if the check completed on all attributed classes
duke@1 1984 */
duke@1 1985 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 1986 boolean complete = true; // was the check complete?
duke@1 1987 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 1988 Symbol c = t.tsym;
duke@1 1989 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 1990
duke@1 1991 if ((c.flags_field & LOCKED) != 0) {
duke@1 1992 noteCyclic(pos, (ClassSymbol)c);
duke@1 1993 } else if (!c.type.isErroneous()) {
duke@1 1994 try {
duke@1 1995 c.flags_field |= LOCKED;
duke@1 1996 if (c.type.tag == CLASS) {
duke@1 1997 ClassType clazz = (ClassType)c.type;
duke@1 1998 if (clazz.interfaces_field != null)
duke@1 1999 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2000 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2001 if (clazz.supertype_field != null) {
duke@1 2002 Type st = clazz.supertype_field;
duke@1 2003 if (st != null && st.tag == CLASS)
duke@1 2004 complete &= checkNonCyclicInternal(pos, st);
duke@1 2005 }
duke@1 2006 if (c.owner.kind == TYP)
duke@1 2007 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2008 }
duke@1 2009 } finally {
duke@1 2010 c.flags_field &= ~LOCKED;
duke@1 2011 }
duke@1 2012 }
duke@1 2013 if (complete)
duke@1 2014 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2015 if (complete) c.flags_field |= ACYCLIC;
duke@1 2016 return complete;
duke@1 2017 }
duke@1 2018
duke@1 2019 /** Note that we found an inheritance cycle. */
duke@1 2020 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2021 log.error(pos, "cyclic.inheritance", c);
duke@1 2022 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2023 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2024 Type st = types.supertype(c.type);
duke@1 2025 if (st.tag == CLASS)
jjg@110 2026 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2027 c.type = types.createErrorType(c, c.type);
duke@1 2028 c.flags_field |= ACYCLIC;
duke@1 2029 }
duke@1 2030
duke@1 2031 /** Check that all methods which implement some
duke@1 2032 * method conform to the method they implement.
duke@1 2033 * @param tree The class definition whose members are checked.
duke@1 2034 */
duke@1 2035 void checkImplementations(JCClassDecl tree) {
duke@1 2036 checkImplementations(tree, tree.sym);
duke@1 2037 }
duke@1 2038 //where
duke@1 2039 /** Check that all methods which implement some
duke@1 2040 * method in `ic' conform to the method they implement.
duke@1 2041 */
duke@1 2042 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
duke@1 2043 ClassSymbol origin = tree.sym;
duke@1 2044 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2045 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2046 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2047 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2048 if (e.sym.kind == MTH &&
duke@1 2049 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2050 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2051 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2052 if (implmeth != null && implmeth != absmeth &&
duke@1 2053 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2054 (origin.flags() & INTERFACE)) {
duke@1 2055 // don't check if implmeth is in a class, yet
duke@1 2056 // origin is an interface. This case arises only
duke@1 2057 // if implmeth is declared in Object. The reason is
duke@1 2058 // that interfaces really don't inherit from
duke@1 2059 // Object it's just that the compiler represents
duke@1 2060 // things that way.
duke@1 2061 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2062 }
duke@1 2063 }
duke@1 2064 }
duke@1 2065 }
duke@1 2066 }
duke@1 2067 }
duke@1 2068
duke@1 2069 /** Check that all abstract methods implemented by a class are
duke@1 2070 * mutually compatible.
duke@1 2071 * @param pos Position to be used for error reporting.
duke@1 2072 * @param c The class whose interfaces are checked.
duke@1 2073 */
duke@1 2074 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2075 List<Type> supertypes = types.interfaces(c);
duke@1 2076 Type supertype = types.supertype(c);
duke@1 2077 if (supertype.tag == CLASS &&
duke@1 2078 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2079 supertypes = supertypes.prepend(supertype);
duke@1 2080 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2081 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2082 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2083 return;
duke@1 2084 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2085 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2086 return;
duke@1 2087 }
duke@1 2088 checkCompatibleConcretes(pos, c);
duke@1 2089 }
duke@1 2090
mcimadamore@359 2091 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2092 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2093 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2094 // VM allows methods and variables with differing types
mcimadamore@359 2095 if (sym.kind == e.sym.kind &&
mcimadamore@359 2096 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2097 sym != e.sym &&
mcimadamore@359 2098 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2099 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2100 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2101 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2102 return;
mcimadamore@359 2103 }
mcimadamore@359 2104 }
mcimadamore@359 2105 }
mcimadamore@359 2106 }
mcimadamore@359 2107
mcimadamore@780 2108 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2109 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2110 *
mcimadamore@780 2111 * @param pos Position to be used for error reporting.
mcimadamore@780 2112 * @param site The class whose methods are checked.
mcimadamore@780 2113 * @param sym The method symbol to be checked.
mcimadamore@780 2114 */
mcimadamore@858 2115 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2116 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2117 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2118 for (Symbol s1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@858 2119 //...find another method m2 that is overridden (directly or indirectly)
mcimadamore@858 2120 //by method 'sym' in 'site'
mcimadamore@1015 2121 for (Symbol s2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@877 2122 if (s1 == s2 || !sym.overrides(s2, site.tsym, types, false)) continue;
mcimadamore@858 2123 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2124 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@907 2125 if (!types.isSubSignature(sym.type, types.memberType(site, s1), false) &&
mcimadamore@877 2126 types.hasSameArgs(s1.erasure(types), s2.erasure(types))) {
mcimadamore@858 2127 sym.flags_field |= CLASH;
mcimadamore@877 2128 String key = s2 == sym ?
mcimadamore@858 2129 "name.clash.same.erasure.no.override" :
mcimadamore@858 2130 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2131 log.error(pos,
mcimadamore@858 2132 key,
mcimadamore@858 2133 sym, sym.location(),
mcimadamore@877 2134 s1, s1.location(),
mcimadamore@877 2135 s2, s2.location());
mcimadamore@858 2136 return;
mcimadamore@858 2137 }
mcimadamore@780 2138 }
mcimadamore@780 2139 }
mcimadamore@780 2140 }
mcimadamore@780 2141
mcimadamore@877 2142
mcimadamore@877 2143
mcimadamore@858 2144 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2145 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2146 *
mcimadamore@858 2147 * @param pos Position to be used for error reporting.
mcimadamore@858 2148 * @param site The class whose methods are checked.
mcimadamore@858 2149 * @param sym The method symbol to be checked.
mcimadamore@780 2150 */
mcimadamore@858 2151 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2152 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2153 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2154 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2155 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2156 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
mcimadamore@907 2157 if (!types.isSubSignature(sym.type, types.memberType(site, s), false) &&
mcimadamore@877 2158 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
mcimadamore@780 2159 log.error(pos,
mcimadamore@858 2160 "name.clash.same.erasure.no.hide",
mcimadamore@858 2161 sym, sym.location(),
mcimadamore@877 2162 s, s.location());
mcimadamore@858 2163 return;
mcimadamore@858 2164 }
mcimadamore@858 2165 }
mcimadamore@858 2166 }
mcimadamore@780 2167
mcimadamore@858 2168 //where
mcimadamore@858 2169 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2170
mcimadamore@858 2171 Type site;
mcimadamore@780 2172
mcimadamore@858 2173 ClashFilter(Type site) {
mcimadamore@858 2174 this.site = site;
mcimadamore@858 2175 }
mcimadamore@858 2176
mcimadamore@858 2177 boolean shouldSkip(Symbol s) {
mcimadamore@858 2178 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2179 s.owner == site.tsym;
mcimadamore@858 2180 }
mcimadamore@858 2181
mcimadamore@858 2182 public boolean accepts(Symbol s) {
mcimadamore@858 2183 return s.kind == MTH &&
mcimadamore@858 2184 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2185 !shouldSkip(s) &&
mcimadamore@858 2186 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2187 !s.isConstructor();
mcimadamore@858 2188 }
mcimadamore@858 2189 }
mcimadamore@780 2190
mcimadamore@359 2191 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2192 */
mcimadamore@359 2193 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2194 if (!sym.type.isErroneous()) {
mcimadamore@359 2195 if (warnOnSyntheticConflicts) {
mcimadamore@359 2196 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2197 }
mcimadamore@359 2198 else {
mcimadamore@359 2199 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2200 }
mcimadamore@359 2201 }
mcimadamore@359 2202 }
mcimadamore@359 2203
duke@1 2204 /** Check that class c does not implement directly or indirectly
duke@1 2205 * the same parameterized interface with two different argument lists.
duke@1 2206 * @param pos Position to be used for error reporting.
duke@1 2207 * @param type The type whose interfaces are checked.
duke@1 2208 */
duke@1 2209 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2210 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2211 }
duke@1 2212 //where
duke@1 2213 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2214 * with their class symbol as key and their type as value. Make
duke@1 2215 * sure no class is entered with two different types.
duke@1 2216 */
duke@1 2217 void checkClassBounds(DiagnosticPosition pos,
duke@1 2218 Map<TypeSymbol,Type> seensofar,
duke@1 2219 Type type) {
duke@1 2220 if (type.isErroneous()) return;
duke@1 2221 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2222 Type it = l.head;
duke@1 2223 Type oldit = seensofar.put(it.tsym, it);
duke@1 2224 if (oldit != null) {
duke@1 2225 List<Type> oldparams = oldit.allparams();
duke@1 2226 List<Type> newparams = it.allparams();
duke@1 2227 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2228 log.error(pos, "cant.inherit.diff.arg",
duke@1 2229 it.tsym, Type.toString(oldparams),
duke@1 2230 Type.toString(newparams));
duke@1 2231 }
duke@1 2232 checkClassBounds(pos, seensofar, it);
duke@1 2233 }
duke@1 2234 Type st = types.supertype(type);
duke@1 2235 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2236 }
duke@1 2237
duke@1 2238 /** Enter interface into into set.
duke@1 2239 * If it existed already, issue a "repeated interface" error.
duke@1 2240 */
duke@1 2241 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2242 if (its.contains(it))
duke@1 2243 log.error(pos, "repeated.interface");
duke@1 2244 else {
duke@1 2245 its.add(it);
duke@1 2246 }
duke@1 2247 }
duke@1 2248
duke@1 2249 /* *************************************************************************
duke@1 2250 * Check annotations
duke@1 2251 **************************************************************************/
duke@1 2252
mcimadamore@629 2253 /**
mcimadamore@634 2254 * Recursively validate annotations values
mcimadamore@629 2255 */
mcimadamore@634 2256 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2257 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2258 @Override
mcimadamore@629 2259 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2260 if (!tree.type.isErroneous()) {
jjg@1017 2261 super.visitAnnotation(tree);
jjg@1017 2262 validateAnnotation(tree);
jjg@1017 2263 }
mcimadamore@629 2264 }
mcimadamore@629 2265 }
mcimadamore@634 2266 tree.accept(new AnnotationValidator());
mcimadamore@629 2267 }
mcimadamore@629 2268
duke@1 2269 /** Annotation types are restricted to primitives, String, an
duke@1 2270 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2271 * Anything>, arrays of the preceding.
duke@1 2272 */
duke@1 2273 void validateAnnotationType(JCTree restype) {
duke@1 2274 // restype may be null if an error occurred, so don't bother validating it
duke@1 2275 if (restype != null) {
duke@1 2276 validateAnnotationType(restype.pos(), restype.type);
duke@1 2277 }
duke@1 2278 }
duke@1 2279
duke@1 2280 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2281 if (type.isPrimitive()) return;
duke@1 2282 if (types.isSameType(type, syms.stringType)) return;
duke@1 2283 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2284 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2285 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2286 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2287 validateAnnotationType(pos, types.elemtype(type));
duke@1 2288 return;
duke@1 2289 }
duke@1 2290 log.error(pos, "invalid.annotation.member.type");
duke@1 2291 }
duke@1 2292
duke@1 2293 /**
duke@1 2294 * "It is also a compile-time error if any method declared in an
duke@1 2295 * annotation type has a signature that is override-equivalent to
duke@1 2296 * that of any public or protected method declared in class Object
duke@1 2297 * or in the interface annotation.Annotation."
duke@1 2298 *
jjh@972 2299 * @jls 9.6 Annotation Types
duke@1 2300 */
duke@1 2301 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
duke@1 2302 for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
duke@1 2303 Scope s = sup.tsym.members();
duke@1 2304 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2305 if (e.sym.kind == MTH &&
duke@1 2306 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2307 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2308 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2309 }
duke@1 2310 }
duke@1 2311 }
duke@1 2312
duke@1 2313 /** Check the annotations of a symbol.
duke@1 2314 */
duke@1 2315 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2316 if (skipAnnotations) return;
duke@1 2317 for (JCAnnotation a : annotations)
duke@1 2318 validateAnnotation(a, s);
duke@1 2319 }
duke@1 2320
duke@1 2321 /** Check an annotation of a symbol.
duke@1 2322 */
duke@1 2323 public void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2324 validateAnnotationTree(a);
duke@1 2325
duke@1 2326 if (!annotationApplicable(a, s))
duke@1 2327 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2328
duke@1 2329 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2330 if (!isOverrider(s))
duke@1 2331 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2332 }
duke@1 2333 }
duke@1 2334
duke@1 2335 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2336 boolean isOverrider(Symbol s) {
duke@1 2337 if (s.kind != MTH || s.isStatic())
duke@1 2338 return false;
duke@1 2339 MethodSymbol m = (MethodSymbol)s;
duke@1 2340 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2341 for (Type sup : types.closure(owner.type)) {
duke@1 2342 if (sup == owner.type)
duke@1 2343 continue; // skip "this"
duke@1 2344 Scope scope = sup.tsym.members();
duke@1 2345 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2346 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2347 return true;
duke@1 2348 }
duke@1 2349 }
duke@1 2350 return false;
duke@1 2351 }
duke@1 2352
duke@1 2353 /** Is the annotation applicable to the symbol? */
duke@1 2354 boolean annotationApplicable(JCAnnotation a, Symbol s) {
duke@1 2355 Attribute.Compound atTarget =
duke@1 2356 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
duke@1 2357 if (atTarget == null) return true;
duke@1 2358 Attribute atValue = atTarget.member(names.value);
duke@1 2359 if (!(atValue instanceof Attribute.Array)) return true; // error recovery
duke@1 2360 Attribute.Array arr = (Attribute.Array) atValue;
duke@1 2361 for (Attribute app : arr.values) {
duke@1 2362 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2363 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2364 if (e.value.name == names.TYPE)
duke@1 2365 { if (s.kind == TYP) return true; }
duke@1 2366 else if (e.value.name == names.FIELD)
duke@1 2367 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2368 else if (e.value.name == names.METHOD)
duke@1 2369 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2370 else if (e.value.name == names.PARAMETER)
duke@1 2371 { if (s.kind == VAR &&
duke@1 2372 s.owner.kind == MTH &&
duke@1 2373 (s.flags() & PARAMETER) != 0)
duke@1 2374 return true;
duke@1 2375 }
duke@1 2376 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2377 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2378 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2379 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2380 (s.flags() & PARAMETER) == 0)
duke@1 2381 return true;
duke@1 2382 }
duke@1 2383 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2384 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2385 return true;
duke@1 2386 }
duke@1 2387 else if (e.value.name == names.PACKAGE)
duke@1 2388 { if (s.kind == PCK) return true; }
jjg@308 2389 else if (e.value.name == names.TYPE_USE)
jjg@308 2390 { if (s.kind == TYP ||
jjg@308 2391 s.kind == VAR ||
jjg@308 2392 (s.kind == MTH && !s.isConstructor() &&
jjg@308 2393 s.type.getReturnType().tag != VOID))
jjg@308 2394 return true;
jjg@308 2395 }
duke@1 2396 else
duke@1 2397 return true; // recovery
duke@1 2398 }
duke@1 2399 return false;
duke@1 2400 }
duke@1 2401
duke@1 2402 /** Check an annotation value.
duke@1 2403 */
duke@1 2404 public void validateAnnotation(JCAnnotation a) {
mcimadamore@632 2405 // collect an inventory of the members (sorted alphabetically)
mcimadamore@632 2406 Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
mcimadamore@632 2407 public int compare(Symbol t, Symbol t1) {
mcimadamore@632 2408 return t.name.compareTo(t1.name);
mcimadamore@632 2409 }
mcimadamore@632 2410 });
duke@1 2411 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2412 e != null;
duke@1 2413 e = e.sibling)
duke@1 2414 if (e.sym.kind == MTH)
duke@1 2415 members.add((MethodSymbol) e.sym);
duke@1 2416
duke@1 2417 // count them off as they're annotated
duke@1 2418 for (JCTree arg : a.args) {
jjg@1127 2419 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 2420 JCAssign assign = (JCAssign) arg;
duke@1 2421 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2422 if (m == null || m.type.isErroneous()) continue;
duke@1 2423 if (!members.remove(m))
jjg@479 2424 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2425 m.name, a.type);
duke@1 2426 }
duke@1 2427
duke@1 2428 // all the remaining ones better have default values
mcimadamore@632 2429 ListBuffer<Name> missingDefaults = ListBuffer.lb();
mcimadamore@632 2430 for (MethodSymbol m : members) {
mcimadamore@632 2431 if (m.defaultValue == null && !m.type.isErroneous()) {
mcimadamore@632 2432 missingDefaults.append(m.name);
mcimadamore@632 2433 }
mcimadamore@632 2434 }
mcimadamore@632 2435 if (missingDefaults.nonEmpty()) {
mcimadamore@632 2436 String key = (missingDefaults.size() > 1)
mcimadamore@632 2437 ? "annotation.missing.default.value.1"
mcimadamore@632 2438 : "annotation.missing.default.value";
mcimadamore@632 2439 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 2440 }
duke@1 2441
duke@1 2442 // special case: java.lang.annotation.Target must not have
duke@1 2443 // repeated values in its value member
duke@1 2444 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2445 a.args.tail == null)
duke@1 2446 return;
duke@1 2447
jjg@1127 2448 if (!a.args.head.hasTag(ASSIGN)) return; // error recovery
duke@1 2449 JCAssign assign = (JCAssign) a.args.head;
duke@1 2450 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2451 if (m.name != names.value) return;
duke@1 2452 JCTree rhs = assign.rhs;
jjg@1127 2453 if (!rhs.hasTag(NEWARRAY)) return;
duke@1 2454 JCNewArray na = (JCNewArray) rhs;
duke@1 2455 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2456 for (JCTree elem : na.elems) {
duke@1 2457 if (!targets.add(TreeInfo.symbol(elem))) {
duke@1 2458 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2459 }
duke@1 2460 }
duke@1 2461 }
duke@1 2462
duke@1 2463 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 2464 if (allowAnnotations &&
mcimadamore@795 2465 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 2466 (s.flags() & DEPRECATED) != 0 &&
duke@1 2467 !syms.deprecatedType.isErroneous() &&
duke@1 2468 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 2469 log.warning(LintCategory.DEP_ANN,
jjg@612 2470 pos, "missing.deprecated.annotation");
duke@1 2471 }
duke@1 2472 }
duke@1 2473
mcimadamore@852 2474 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 2475 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 2476 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 2477 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 2478 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2479 @Override
mcimadamore@852 2480 public void report() {
mcimadamore@852 2481 warnDeprecated(pos, s);
mcimadamore@852 2482 }
mcimadamore@852 2483 });
jjg@1157 2484 }
mcimadamore@852 2485 }
mcimadamore@852 2486
mcimadamore@852 2487 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 2488 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 2489 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 2490 public void report() {
mcimadamore@852 2491 if (enableSunApiLintControl)
mcimadamore@852 2492 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 2493 else
mcimadamore@852 2494 log.strictWarning(pos, "sun.proprietary", s);
mcimadamore@852 2495 }
mcimadamore@852 2496 });
mcimadamore@852 2497 }
mcimadamore@852 2498 }
mcimadamore@852 2499
duke@1 2500 /* *************************************************************************
duke@1 2501 * Check for recursive annotation elements.
duke@1 2502 **************************************************************************/
duke@1 2503
duke@1 2504 /** Check for cycles in the graph of annotation elements.
duke@1 2505 */
duke@1 2506 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 2507 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 2508 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 2509 try {
duke@1 2510 tree.sym.flags_field |= LOCKED;
duke@1 2511 for (JCTree def : tree.defs) {
jjg@1127 2512 if (!def.hasTag(METHODDEF)) continue;
duke@1 2513 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 2514 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 2515 }
duke@1 2516 } finally {
duke@1 2517 tree.sym.flags_field &= ~LOCKED;
duke@1 2518 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 2519 }
duke@1 2520 }
duke@1 2521
duke@1 2522 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 2523 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 2524 return;
duke@1 2525 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 2526 log.error(pos, "cyclic.annotation.element");
duke@1 2527 return;
duke@1 2528 }
duke@1 2529 try {
duke@1 2530 tsym.flags_field |= LOCKED;
duke@1 2531 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 2532 Symbol s = e.sym;
duke@1 2533 if (s.kind != Kinds.MTH)
duke@1 2534 continue;
duke@1 2535 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 2536 }
duke@1 2537 } finally {
duke@1 2538 tsym.flags_field &= ~LOCKED;
duke@1 2539 tsym.flags_field |= ACYCLIC_ANN;
duke@1 2540 }
duke@1 2541 }
duke@1 2542
duke@1 2543 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
duke@1 2544 switch (type.tag) {
duke@1 2545 case TypeTags.CLASS:
duke@1 2546 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 2547 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 2548 break;
duke@1 2549 case TypeTags.ARRAY:
duke@1 2550 checkAnnotationResType(pos, types.elemtype(type));
duke@1 2551 break;
duke@1 2552 default:
duke@1 2553 break; // int etc
duke@1 2554 }
duke@1 2555 }
duke@1 2556
duke@1 2557 /* *************************************************************************
duke@1 2558 * Check for cycles in the constructor call graph.
duke@1 2559 **************************************************************************/
duke@1 2560
duke@1 2561 /** Check for cycles in the graph of constructors calling other
duke@1 2562 * constructors.
duke@1 2563 */
duke@1 2564 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 2565 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 2566
duke@1 2567 // enter each constructor this-call into the map
duke@1 2568 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 2569 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 2570 if (app == null) continue;
duke@1 2571 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 2572 if (TreeInfo.name(app.meth) == names._this) {
duke@1 2573 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 2574 } else {
duke@1 2575 meth.sym.flags_field |= ACYCLIC;
duke@1 2576 }
duke@1 2577 }
duke@1 2578
duke@1 2579 // Check for cycles in the map
duke@1 2580 Symbol[] ctors = new Symbol[0];
duke@1 2581 ctors = callMap.keySet().toArray(ctors);
duke@1 2582 for (Symbol caller : ctors) {
duke@1 2583 checkCyclicConstructor(tree, caller, callMap);
duke@1 2584 }
duke@1 2585 }
duke@1 2586
duke@1 2587 /** Look in the map to see if the given constructor is part of a
duke@1 2588 * call cycle.
duke@1 2589 */
duke@1 2590 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 2591 Map<Symbol,Symbol> callMap) {
duke@1 2592 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 2593 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 2594 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 2595 "recursive.ctor.invocation");
duke@1 2596 } else {
duke@1 2597 ctor.flags_field |= LOCKED;
duke@1 2598 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 2599 ctor.flags_field &= ~LOCKED;
duke@1 2600 }
duke@1 2601 ctor.flags_field |= ACYCLIC;
duke@1 2602 }
duke@1 2603 }
duke@1 2604
duke@1 2605 /* *************************************************************************
duke@1 2606 * Miscellaneous
duke@1 2607 **************************************************************************/
duke@1 2608
duke@1 2609 /**
duke@1 2610 * Return the opcode of the operator but emit an error if it is an
duke@1 2611 * error.
duke@1 2612 * @param pos position for error reporting.
duke@1 2613 * @param operator an operator
duke@1 2614 * @param tag a tree tag
duke@1 2615 * @param left type of left hand side
duke@1 2616 * @param right type of right hand side
duke@1 2617 */
duke@1 2618 int checkOperator(DiagnosticPosition pos,
duke@1 2619 OperatorSymbol operator,
jjg@1127 2620 JCTree.Tag tag,
duke@1 2621 Type left,
duke@1 2622 Type right) {
duke@1 2623 if (operator.opcode == ByteCodes.error) {
duke@1 2624 log.error(pos,
mcimadamore@853 2625 "operator.cant.be.applied.1",
duke@1 2626 treeinfo.operatorName(tag),
mcimadamore@853 2627 left, right);
duke@1 2628 }
duke@1 2629 return operator.opcode;
duke@1 2630 }
duke@1 2631
duke@1 2632
duke@1 2633 /**
duke@1 2634 * Check for division by integer constant zero
duke@1 2635 * @param pos Position for error reporting.
duke@1 2636 * @param operator The operator for the expression
duke@1 2637 * @param operand The right hand operand for the expression
duke@1 2638 */
duke@1 2639 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 2640 if (operand.constValue() != null
mcimadamore@795 2641 && lint.isEnabled(LintCategory.DIVZERO)
duke@1 2642 && operand.tag <= LONG
duke@1 2643 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 2644 int opc = ((OperatorSymbol)operator).opcode;
duke@1 2645 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 2646 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 2647 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 2648 }
duke@1 2649 }
duke@1 2650 }
duke@1 2651
duke@1 2652 /**
duke@1 2653 * Check for empty statements after if
duke@1 2654 */
duke@1 2655 void checkEmptyIf(JCIf tree) {
jjg@1127 2656 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 2657 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 2658 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 2659 }
duke@1 2660
duke@1 2661 /** Check that symbol is unique in given scope.
duke@1 2662 * @param pos Position for error reporting.
duke@1 2663 * @param sym The symbol.
duke@1 2664 * @param s The scope.
duke@1 2665 */
duke@1 2666 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2667 if (sym.type.isErroneous())
duke@1 2668 return true;
duke@1 2669 if (sym.owner.name == names.any) return false;
duke@1 2670 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 2671 if (sym != e.sym &&
mcimadamore@858 2672 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 2673 sym.kind == e.sym.kind &&
mcimadamore@858 2674 sym.name != names.error &&
mcimadamore@858 2675 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 2676 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 2677 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 2678 return true;
mcimadamore@907 2679 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 2680 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 2681 sym.flags_field |= CLASH;
mcimadamore@844 2682 return true;
mcimadamore@844 2683 } else {
duke@1 2684 duplicateError(pos, e.sym);
mcimadamore@844 2685 return false;
mcimadamore@844 2686 }
duke@1 2687 }
duke@1 2688 }
duke@1 2689 return true;
duke@1 2690 }
mcimadamore@844 2691
mcimadamore@858 2692 /** Report duplicate declaration error.
mcimadamore@858 2693 */
mcimadamore@858 2694 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 2695 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 2696 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 2697 }
mcimadamore@858 2698 }
duke@1 2699
duke@1 2700 /** Check that single-type import is not already imported or top-level defined,
duke@1 2701 * but make an exception for two single-type imports which denote the same type.
duke@1 2702 * @param pos Position for error reporting.
duke@1 2703 * @param sym The symbol.
duke@1 2704 * @param s The scope
duke@1 2705 */
duke@1 2706 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2707 return checkUniqueImport(pos, sym, s, false);
duke@1 2708 }
duke@1 2709
duke@1 2710 /** Check that static single-type import is not already imported or top-level defined,
duke@1 2711 * but make an exception for two single-type imports which denote the same type.
duke@1 2712 * @param pos Position for error reporting.
duke@1 2713 * @param sym The symbol.
duke@1 2714 * @param s The scope
duke@1 2715 * @param staticImport Whether or not this was a static import
duke@1 2716 */
duke@1 2717 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2718 return checkUniqueImport(pos, sym, s, true);
duke@1 2719 }
duke@1 2720
duke@1 2721 /** Check that single-type import is not already imported or top-level defined,
duke@1 2722 * but make an exception for two single-type imports which denote the same type.
duke@1 2723 * @param pos Position for error reporting.
duke@1 2724 * @param sym The symbol.
duke@1 2725 * @param s The scope.
duke@1 2726 * @param staticImport Whether or not this was a static import
duke@1 2727 */
duke@1 2728 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 2729 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 2730 // is encountered class entered via a class declaration?
duke@1 2731 boolean isClassDecl = e.scope == s;
duke@1 2732 if ((isClassDecl || sym != e.sym) &&
duke@1 2733 sym.kind == e.sym.kind &&
duke@1 2734 sym.name != names.error) {
duke@1 2735 if (!e.sym.type.isErroneous()) {
duke@1 2736 String what = e.sym.toString();
duke@1 2737 if (!isClassDecl) {
duke@1 2738 if (staticImport)
duke@1 2739 log.error(pos, "already.defined.static.single.import", what);
duke@1 2740 else
duke@1 2741 log.error(pos, "already.defined.single.import", what);
duke@1 2742 }
duke@1 2743 else if (sym != e.sym)
duke@1 2744 log.error(pos, "already.defined.this.unit", what);
duke@1 2745 }
duke@1 2746 return false;
duke@1 2747 }
duke@1 2748 }
duke@1 2749 return true;
duke@1 2750 }
duke@1 2751
duke@1 2752 /** Check that a qualified name is in canonical form (for import decls).
duke@1 2753 */
duke@1 2754 public void checkCanonical(JCTree tree) {
duke@1 2755 if (!isCanonical(tree))
duke@1 2756 log.error(tree.pos(), "import.requires.canonical",
duke@1 2757 TreeInfo.symbol(tree));
duke@1 2758 }
duke@1 2759 // where
duke@1 2760 private boolean isCanonical(JCTree tree) {
jjg@1127 2761 while (tree.hasTag(SELECT)) {
duke@1 2762 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 2763 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 2764 return false;
duke@1 2765 tree = s.selected;
duke@1 2766 }
duke@1 2767 return true;
duke@1 2768 }
duke@1 2769
duke@1 2770 private class ConversionWarner extends Warner {
mcimadamore@795 2771 final String uncheckedKey;
duke@1 2772 final Type found;
duke@1 2773 final Type expected;
mcimadamore@795 2774 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 2775 super(pos);
mcimadamore@795 2776 this.uncheckedKey = uncheckedKey;
duke@1 2777 this.found = found;
duke@1 2778 this.expected = expected;
duke@1 2779 }
duke@1 2780
jjg@398 2781 @Override
mcimadamore@795 2782 public void warn(LintCategory lint) {
duke@1 2783 boolean warned = this.warned;
mcimadamore@795 2784 super.warn(lint);
duke@1 2785 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 2786 switch (lint) {
mcimadamore@795 2787 case UNCHECKED:
mcimadamore@795 2788 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 2789 break;
mcimadamore@795 2790 case VARARGS:
mcimadamore@795 2791 if (method != null &&
mcimadamore@795 2792 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 2793 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 2794 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 2795 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 2796 }
mcimadamore@795 2797 break;
mcimadamore@795 2798 default:
mcimadamore@795 2799 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 2800 }
duke@1 2801 }
duke@1 2802 }
duke@1 2803
duke@1 2804 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2805 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 2806 }
duke@1 2807
duke@1 2808 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2809 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 2810 }
duke@1 2811 }

mercurial