src/share/classes/com/sun/tools/javac/comp/Check.java

Fri, 04 Apr 2014 12:23:37 +0100

author
pgovereau
date
Fri, 04 Apr 2014 12:23:37 +0100
changeset 2352
33c9946d2875
parent 2250
66570bfdbdd7
child 2382
14979dd5e034
permissions
-rw-r--r--

8034048: javac crash with method references plus lambda plus var args
Reviewed-by: jjg, vromero

duke@1 1 /*
jfranck@2250 2 * Copyright (c) 1999, 2014, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
jjg@1521 29
ohrstrom@1384 30 import javax.tools.JavaFileManager;
duke@1 31
duke@1 32 import com.sun.tools.javac.code.*;
jlahoda@2111 33 import com.sun.tools.javac.code.Attribute.Compound;
duke@1 34 import com.sun.tools.javac.jvm.*;
duke@1 35 import com.sun.tools.javac.tree.*;
duke@1 36 import com.sun.tools.javac.util.*;
duke@1 37 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 38 import com.sun.tools.javac.util.List;
duke@1 39
duke@1 40 import com.sun.tools.javac.code.Lint;
duke@1 41 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 42 import com.sun.tools.javac.code.Type.*;
duke@1 43 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 44 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 45 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1550 46 import com.sun.tools.javac.comp.Infer.FreeTypeListener;
mcimadamore@1510 47 import com.sun.tools.javac.tree.JCTree.*;
mcimadamore@1510 48 import com.sun.tools.javac.tree.JCTree.JCPolyExpression.*;
duke@1 49
duke@1 50 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 51 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 52 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 53 import static com.sun.tools.javac.code.Kinds.*;
jjg@1374 54 import static com.sun.tools.javac.code.TypeTag.*;
jjg@1374 55 import static com.sun.tools.javac.code.TypeTag.WILDCARD;
duke@1 56
jjg@1127 57 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 58
duke@1 59 /** Type checking helper class for the attribution phase.
duke@1 60 *
jjg@581 61 * <p><b>This is NOT part of any supported API.
jjg@581 62 * If you write code that depends on this, you do so at your own risk.
duke@1 63 * This code and its internal interfaces are subject to change or
duke@1 64 * deletion without notice.</b>
duke@1 65 */
duke@1 66 public class Check {
duke@1 67 protected static final Context.Key<Check> checkKey =
duke@1 68 new Context.Key<Check>();
duke@1 69
jjg@113 70 private final Names names;
duke@1 71 private final Log log;
mcimadamore@1219 72 private final Resolve rs;
duke@1 73 private final Symtab syms;
mcimadamore@690 74 private final Enter enter;
mcimadamore@1347 75 private final DeferredAttr deferredAttr;
duke@1 76 private final Infer infer;
duke@1 77 private final Types types;
mcimadamore@89 78 private final JCDiagnostic.Factory diags;
mcimadamore@359 79 private boolean warnOnSyntheticConflicts;
jjg@576 80 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 81 private boolean enableSunApiLintControl;
duke@1 82 private final TreeInfo treeinfo;
ohrstrom@1384 83 private final JavaFileManager fileManager;
jjg@1569 84 private final Profile profile;
duke@1 85
duke@1 86 // The set of lint options currently in effect. It is initialized
duke@1 87 // from the context, and then is set/reset as needed by Attr as it
duke@1 88 // visits all the various parts of the trees during attribution.
duke@1 89 private Lint lint;
duke@1 90
mcimadamore@795 91 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 92 // Attr as it visits new method declarations.
mcimadamore@795 93 private MethodSymbol method;
mcimadamore@795 94
duke@1 95 public static Check instance(Context context) {
duke@1 96 Check instance = context.get(checkKey);
duke@1 97 if (instance == null)
duke@1 98 instance = new Check(context);
duke@1 99 return instance;
duke@1 100 }
duke@1 101
duke@1 102 protected Check(Context context) {
duke@1 103 context.put(checkKey, this);
duke@1 104
jjg@113 105 names = Names.instance(context);
jjg@1521 106 dfltTargetMeta = new Name[] { names.PACKAGE, names.TYPE,
jjg@1521 107 names.FIELD, names.METHOD, names.CONSTRUCTOR,
jjg@1521 108 names.ANNOTATION_TYPE, names.LOCAL_VARIABLE, names.PARAMETER};
duke@1 109 log = Log.instance(context);
mcimadamore@1219 110 rs = Resolve.instance(context);
duke@1 111 syms = Symtab.instance(context);
mcimadamore@690 112 enter = Enter.instance(context);
mcimadamore@1347 113 deferredAttr = DeferredAttr.instance(context);
duke@1 114 infer = Infer.instance(context);
jjg@1569 115 types = Types.instance(context);
mcimadamore@89 116 diags = JCDiagnostic.Factory.instance(context);
duke@1 117 Options options = Options.instance(context);
duke@1 118 lint = Lint.instance(context);
duke@1 119 treeinfo = TreeInfo.instance(context);
ohrstrom@1384 120 fileManager = context.get(JavaFileManager.class);
duke@1 121
duke@1 122 Source source = Source.instance(context);
duke@1 123 allowGenerics = source.allowGenerics();
mcimadamore@1219 124 allowVarargs = source.allowVarargs();
duke@1 125 allowAnnotations = source.allowAnnotations();
jjg@398 126 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 127 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
mcimadamore@1393 128 allowDefaultMethods = source.allowDefaultMethods();
mcimadamore@1415 129 allowStrictMethodClashCheck = source.allowStrictMethodClashCheck();
jjg@1157 130 complexInference = options.isSet("complexinference");
jjg@700 131 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 132 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 133 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 134
jjg@398 135 Target target = Target.instance(context);
jjg@398 136 syntheticNameChar = target.syntheticNameChar();
jjg@398 137
jjg@1569 138 profile = Profile.instance(context);
jjg@1569 139
duke@1 140 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 141 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 142 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 143 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 144
jjg@60 145 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 146 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 147 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 148 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 149 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 150 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 151
jlahoda@2028 152 deferredLintHandler = DeferredLintHandler.instance(context);
duke@1 153 }
duke@1 154
duke@1 155 /** Switch: generics enabled?
duke@1 156 */
duke@1 157 boolean allowGenerics;
duke@1 158
mcimadamore@1219 159 /** Switch: varargs enabled?
mcimadamore@1219 160 */
mcimadamore@1219 161 boolean allowVarargs;
mcimadamore@1219 162
duke@1 163 /** Switch: annotations enabled?
duke@1 164 */
duke@1 165 boolean allowAnnotations;
duke@1 166
jjg@398 167 /** Switch: covariant returns enabled?
jjg@398 168 */
jjg@398 169 boolean allowCovariantReturns;
jjg@398 170
mcimadamore@795 171 /** Switch: simplified varargs enabled?
mcimadamore@795 172 */
mcimadamore@795 173 boolean allowSimplifiedVarargs;
mcimadamore@795 174
mcimadamore@1393 175 /** Switch: default methods enabled?
mcimadamore@1393 176 */
mcimadamore@1393 177 boolean allowDefaultMethods;
mcimadamore@1393 178
mcimadamore@1393 179 /** Switch: should unrelated return types trigger a method clash?
mcimadamore@1393 180 */
mcimadamore@1393 181 boolean allowStrictMethodClashCheck;
mcimadamore@1393 182
duke@1 183 /** Switch: -complexinference option set?
duke@1 184 */
duke@1 185 boolean complexInference;
duke@1 186
jjg@398 187 /** Character for synthetic names
jjg@398 188 */
jjg@398 189 char syntheticNameChar;
jjg@398 190
duke@1 191 /** A table mapping flat names of all compiled classes in this run to their
duke@1 192 * symbols; maintained from outside.
duke@1 193 */
duke@1 194 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 195
duke@1 196 /** A handler for messages about deprecated usage.
duke@1 197 */
duke@1 198 private MandatoryWarningHandler deprecationHandler;
duke@1 199
duke@1 200 /** A handler for messages about unchecked or unsafe usage.
duke@1 201 */
duke@1 202 private MandatoryWarningHandler uncheckedHandler;
duke@1 203
jjg@582 204 /** A handler for messages about using proprietary API.
jjg@377 205 */
jjg@377 206 private MandatoryWarningHandler sunApiHandler;
duke@1 207
mcimadamore@852 208 /** A handler for deferred lint warnings.
mcimadamore@852 209 */
mcimadamore@852 210 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 211
duke@1 212 /* *************************************************************************
duke@1 213 * Errors and Warnings
duke@1 214 **************************************************************************/
duke@1 215
duke@1 216 Lint setLint(Lint newLint) {
duke@1 217 Lint prev = lint;
duke@1 218 lint = newLint;
duke@1 219 return prev;
duke@1 220 }
duke@1 221
mcimadamore@795 222 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 223 MethodSymbol prev = method;
mcimadamore@795 224 method = newMethod;
mcimadamore@795 225 return prev;
mcimadamore@795 226 }
mcimadamore@795 227
duke@1 228 /** Warn about deprecated symbol.
duke@1 229 * @param pos Position to be used for error reporting.
duke@1 230 * @param sym The deprecated symbol.
duke@1 231 */
duke@1 232 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 233 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 234 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 235 }
duke@1 236
duke@1 237 /** Warn about unchecked operation.
duke@1 238 * @param pos Position to be used for error reporting.
duke@1 239 * @param msg A string describing the problem.
duke@1 240 */
duke@1 241 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 242 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 243 uncheckedHandler.report(pos, msg, args);
duke@1 244 }
duke@1 245
mcimadamore@580 246 /** Warn about unsafe vararg method decl.
mcimadamore@580 247 * @param pos Position to be used for error reporting.
mcimadamore@580 248 */
mcimadamore@795 249 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 250 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 251 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 252 }
mcimadamore@580 253
jjg@582 254 /** Warn about using proprietary API.
jjg@377 255 * @param pos Position to be used for error reporting.
jjg@377 256 * @param msg A string describing the problem.
jjg@377 257 */
jjg@377 258 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 259 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 260 sunApiHandler.report(pos, msg, args);
jjg@377 261 }
jjg@377 262
jjg@505 263 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 264 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 265 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 266 }
jjg@505 267
duke@1 268 /**
duke@1 269 * Report any deferred diagnostics.
duke@1 270 */
duke@1 271 public void reportDeferredDiagnostics() {
duke@1 272 deprecationHandler.reportDeferredDiagnostic();
duke@1 273 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 274 sunApiHandler.reportDeferredDiagnostic();
duke@1 275 }
duke@1 276
duke@1 277
duke@1 278 /** Report a failure to complete a class.
duke@1 279 * @param pos Position to be used for error reporting.
duke@1 280 * @param ex The failure to report.
duke@1 281 */
duke@1 282 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
mcimadamore@1613 283 log.error(JCDiagnostic.DiagnosticFlag.NON_DEFERRABLE, pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 284 if (ex instanceof ClassReader.BadClassFile
jjg@576 285 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 286 else return syms.errType;
duke@1 287 }
duke@1 288
duke@1 289 /** Report an error that wrong type tag was found.
duke@1 290 * @param pos Position to be used for error reporting.
duke@1 291 * @param required An internationalized string describing the type tag
duke@1 292 * required.
duke@1 293 * @param found The type that was found.
duke@1 294 */
duke@1 295 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 296 // this error used to be raised by the parser,
jrose@267 297 // but has been delayed to this point:
jjg@1374 298 if (found instanceof Type && ((Type)found).hasTag(VOID)) {
jrose@267 299 log.error(pos, "illegal.start.of.type");
jrose@267 300 return syms.errType;
jrose@267 301 }
duke@1 302 log.error(pos, "type.found.req", found, required);
jjg@110 303 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 304 }
duke@1 305
duke@1 306 /** Report an error that symbol cannot be referenced before super
duke@1 307 * has been called.
duke@1 308 * @param pos Position to be used for error reporting.
duke@1 309 * @param sym The referenced symbol.
duke@1 310 */
duke@1 311 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 312 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 313 }
duke@1 314
duke@1 315 /** Report duplicate declaration error.
duke@1 316 */
duke@1 317 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 318 if (!sym.type.isErroneous()) {
mcimadamore@1085 319 Symbol location = sym.location();
mcimadamore@1085 320 if (location.kind == MTH &&
mcimadamore@1085 321 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 322 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 323 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 324 sym.location().enclClass());
mcimadamore@1085 325 } else {
mcimadamore@1085 326 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 327 kindName(sym.location()), sym.location());
mcimadamore@1085 328 }
duke@1 329 }
duke@1 330 }
duke@1 331
duke@1 332 /** Report array/varargs duplicate declaration
duke@1 333 */
duke@1 334 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 335 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 336 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 337 }
duke@1 338 }
duke@1 339
duke@1 340 /* ************************************************************************
duke@1 341 * duplicate declaration checking
duke@1 342 *************************************************************************/
duke@1 343
duke@1 344 /** Check that variable does not hide variable with same name in
duke@1 345 * immediately enclosing local scope.
duke@1 346 * @param pos Position for error reporting.
duke@1 347 * @param v The symbol.
duke@1 348 * @param s The scope.
duke@1 349 */
duke@1 350 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 351 if (s.next != null) {
duke@1 352 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 353 e.scope != null && e.sym.owner == v.owner;
duke@1 354 e = e.next()) {
duke@1 355 if (e.sym.kind == VAR &&
duke@1 356 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 357 v.name != names.error) {
duke@1 358 duplicateError(pos, e.sym);
duke@1 359 return;
duke@1 360 }
duke@1 361 }
duke@1 362 }
duke@1 363 }
duke@1 364
duke@1 365 /** Check that a class or interface does not hide a class or
duke@1 366 * interface with same name in immediately enclosing local scope.
duke@1 367 * @param pos Position for error reporting.
duke@1 368 * @param c The symbol.
duke@1 369 * @param s The scope.
duke@1 370 */
duke@1 371 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 372 if (s.next != null) {
duke@1 373 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 374 e.scope != null && e.sym.owner == c.owner;
duke@1 375 e = e.next()) {
jjg@1374 376 if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) &&
duke@1 377 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 378 c.name != names.error) {
duke@1 379 duplicateError(pos, e.sym);
duke@1 380 return;
duke@1 381 }
duke@1 382 }
duke@1 383 }
duke@1 384 }
duke@1 385
duke@1 386 /** Check that class does not have the same name as one of
duke@1 387 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 388 * return true if class is unique in its enclosing scope.
duke@1 389 * @param pos Position for error reporting.
duke@1 390 * @param name The class name.
duke@1 391 * @param s The enclosing scope.
duke@1 392 */
duke@1 393 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 394 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 395 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 396 duplicateError(pos, e.sym);
duke@1 397 return false;
duke@1 398 }
duke@1 399 }
duke@1 400 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 401 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 402 duplicateError(pos, sym);
duke@1 403 return true;
duke@1 404 }
duke@1 405 }
duke@1 406 return true;
duke@1 407 }
duke@1 408
duke@1 409 /* *************************************************************************
duke@1 410 * Class name generation
duke@1 411 **************************************************************************/
duke@1 412
duke@1 413 /** Return name of local class.
jjg@1358 414 * This is of the form {@code <enclClass> $ n <classname> }
duke@1 415 * where
duke@1 416 * enclClass is the flat name of the enclosing class,
duke@1 417 * classname is the simple name of the local class
duke@1 418 */
duke@1 419 Name localClassName(ClassSymbol c) {
duke@1 420 for (int i=1; ; i++) {
duke@1 421 Name flatname = names.
duke@1 422 fromString("" + c.owner.enclClass().flatname +
jjg@398 423 syntheticNameChar + i +
duke@1 424 c.name);
duke@1 425 if (compiled.get(flatname) == null) return flatname;
duke@1 426 }
duke@1 427 }
duke@1 428
duke@1 429 /* *************************************************************************
duke@1 430 * Type Checking
duke@1 431 **************************************************************************/
duke@1 432
mcimadamore@1238 433 /**
mcimadamore@1238 434 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 435 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 436 * vary significantly.
mcimadamore@1238 437 */
mcimadamore@1348 438 public interface CheckContext {
mcimadamore@1238 439 /**
mcimadamore@1238 440 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 441 */
mcimadamore@1238 442 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 443 /**
mcimadamore@1238 444 * Report a check error
mcimadamore@1238 445 */
mcimadamore@1296 446 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 447 /**
mcimadamore@1238 448 * Obtain a warner for this check context
mcimadamore@1238 449 */
mcimadamore@1238 450 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 451
mcimadamore@1337 452 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 453
mcimadamore@1347 454 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1238 455 }
mcimadamore@1238 456
mcimadamore@1238 457 /**
mcimadamore@1238 458 * This class represent a check context that is nested within another check
mcimadamore@1238 459 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 460 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 461 * the forwarding pattern.
mcimadamore@1238 462 */
mcimadamore@1238 463 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 464 CheckContext enclosingContext;
mcimadamore@1238 465
mcimadamore@1238 466 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 467 this.enclosingContext = enclosingContext;
mcimadamore@1238 468 }
mcimadamore@1238 469
mcimadamore@1238 470 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 471 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 472 }
mcimadamore@1238 473
mcimadamore@1296 474 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 475 enclosingContext.report(pos, details);
mcimadamore@1238 476 }
mcimadamore@1238 477
mcimadamore@1238 478 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 479 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 480 }
mcimadamore@1337 481
mcimadamore@1337 482 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 483 return enclosingContext.inferenceContext();
mcimadamore@1337 484 }
mcimadamore@1347 485
mcimadamore@1347 486 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 487 return enclosingContext.deferredAttrContext();
mcimadamore@1347 488 }
mcimadamore@1238 489 }
mcimadamore@1238 490
mcimadamore@1238 491 /**
mcimadamore@1238 492 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 493 */
mcimadamore@1238 494 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 495 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 496 log.error(pos, "prob.found.req", details);
mcimadamore@1238 497 }
mcimadamore@1238 498 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 499 return types.isAssignable(found, req, warn);
mcimadamore@1238 500 }
mcimadamore@1238 501
mcimadamore@1238 502 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 503 return convertWarner(pos, found, req);
mcimadamore@1238 504 }
mcimadamore@1337 505
mcimadamore@1337 506 public InferenceContext inferenceContext() {
mcimadamore@1337 507 return infer.emptyContext;
mcimadamore@1337 508 }
mcimadamore@1347 509
mcimadamore@1347 510 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 511 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 512 }
mcimadamore@1238 513 };
mcimadamore@1238 514
duke@1 515 /** Check that a given type is assignable to a given proto-type.
duke@1 516 * If it is, return the type, otherwise return errType.
duke@1 517 * @param pos Position to be used for error reporting.
duke@1 518 * @param found The type that was found.
duke@1 519 * @param req The type that was required.
duke@1 520 */
duke@1 521 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 522 return checkType(pos, found, req, basicHandler);
darcy@609 523 }
darcy@609 524
mcimadamore@1337 525 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 526 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 527 if (inferenceContext.free(req)) {
mcimadamore@1337 528 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 529 @Override
mcimadamore@1337 530 public void typesInferred(InferenceContext inferenceContext) {
vromero@2157 531 checkType(pos, inferenceContext.asInstType(found), inferenceContext.asInstType(req), checkContext);
mcimadamore@1337 532 }
mcimadamore@1337 533 });
mcimadamore@1337 534 }
jjg@1374 535 if (req.hasTag(ERROR))
duke@1 536 return req;
jjg@1374 537 if (req.hasTag(NONE))
duke@1 538 return found;
mcimadamore@1238 539 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 540 return found;
mcimadamore@1238 541 } else {
vromero@1826 542 if (found.isNumeric() && req.isNumeric()) {
mcimadamore@1296 543 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 544 return types.createErrorType(found);
mcimadamore@1238 545 }
mcimadamore@1296 546 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 547 return types.createErrorType(found);
duke@1 548 }
duke@1 549 }
duke@1 550
duke@1 551 /** Check that a given type can be cast to a given target type.
duke@1 552 * Return the result of the cast.
duke@1 553 * @param pos Position to be used for error reporting.
duke@1 554 * @param found The type that is being cast.
duke@1 555 * @param req The target type of the cast.
duke@1 556 */
duke@1 557 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 558 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 559 }
mcimadamore@1238 560 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 561 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 562 return req;
duke@1 563 } else {
mcimadamore@1296 564 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 565 return types.createErrorType(found);
duke@1 566 }
duke@1 567 }
mcimadamore@1237 568
mcimadamore@1237 569 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 570 * The problem should only be reported for non-292 cast
mcimadamore@1237 571 */
jlahoda@2028 572 public void checkRedundantCast(Env<AttrContext> env, final JCTypeCast tree) {
jlahoda@2028 573 if (!tree.type.isErroneous()
mcimadamore@1348 574 && types.isSameType(tree.expr.type, tree.clazz.type)
jjg@1521 575 && !(ignoreAnnotatedCasts && TreeInfo.containsTypeAnnotation(tree.clazz))
mcimadamore@1348 576 && !is292targetTypeCast(tree)) {
jlahoda@2028 577 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
jlahoda@2028 578 @Override
jlahoda@2028 579 public void report() {
jlahoda@2028 580 if (lint.isEnabled(Lint.LintCategory.CAST))
jlahoda@2028 581 log.warning(Lint.LintCategory.CAST,
jlahoda@2028 582 tree.pos(), "redundant.cast", tree.expr.type);
jlahoda@2028 583 }
jlahoda@2028 584 });
mcimadamore@1237 585 }
mcimadamore@1237 586 }
mcimadamore@1237 587 //where
jjg@1521 588 private boolean is292targetTypeCast(JCTypeCast tree) {
jjg@1521 589 boolean is292targetTypeCast = false;
jjg@1521 590 JCExpression expr = TreeInfo.skipParens(tree.expr);
jjg@1521 591 if (expr.hasTag(APPLY)) {
jjg@1521 592 JCMethodInvocation apply = (JCMethodInvocation)expr;
jjg@1521 593 Symbol sym = TreeInfo.symbol(apply.meth);
jjg@1521 594 is292targetTypeCast = sym != null &&
jjg@1521 595 sym.kind == MTH &&
jjg@1521 596 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 597 }
jjg@1521 598 return is292targetTypeCast;
jjg@1521 599 }
mcimadamore@1237 600
jjg@1521 601 private static final boolean ignoreAnnotatedCasts = true;
duke@1 602
duke@1 603 /** Check that a type is within some bounds.
duke@1 604 *
jjg@1358 605 * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
duke@1 606 * type argument.
duke@1 607 * @param a The type that should be bounded by bs.
jjg@1358 608 * @param bound The bound.
duke@1 609 */
mcimadamore@1216 610 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 611 if (a.isUnbound()) {
mcimadamore@821 612 return true;
jjg@1374 613 } else if (!a.hasTag(WILDCARD)) {
mcimadamore@154 614 a = types.upperBound(a);
mcimadamore@1216 615 return types.isSubtype(a, bound);
mcimadamore@154 616 } else if (a.isExtendsBound()) {
mcimadamore@1415 617 return types.isCastable(bound, types.upperBound(a), types.noWarnings);
mcimadamore@154 618 } else if (a.isSuperBound()) {
mcimadamore@1216 619 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 620 }
mcimadamore@821 621 return true;
mcimadamore@154 622 }
duke@1 623
duke@1 624 /** Check that type is different from 'void'.
duke@1 625 * @param pos Position to be used for error reporting.
duke@1 626 * @param t The type to be checked.
duke@1 627 */
duke@1 628 Type checkNonVoid(DiagnosticPosition pos, Type t) {
jjg@1374 629 if (t.hasTag(VOID)) {
duke@1 630 log.error(pos, "void.not.allowed.here");
jjg@110 631 return types.createErrorType(t);
duke@1 632 } else {
duke@1 633 return t;
duke@1 634 }
duke@1 635 }
duke@1 636
mcimadamore@1496 637 Type checkClassOrArrayType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 638 if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
mcimadamore@1496 639 return typeTagError(pos,
mcimadamore@1496 640 diags.fragment("type.req.class.array"),
mcimadamore@1496 641 asTypeParam(t));
mcimadamore@1496 642 } else {
mcimadamore@1496 643 return t;
mcimadamore@1496 644 }
mcimadamore@1496 645 }
mcimadamore@1496 646
duke@1 647 /** Check that type is a class or interface type.
duke@1 648 * @param pos Position to be used for error reporting.
duke@1 649 * @param t The type to be checked.
duke@1 650 */
duke@1 651 Type checkClassType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 652 if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) {
duke@1 653 return typeTagError(pos,
mcimadamore@89 654 diags.fragment("type.req.class"),
mcimadamore@1496 655 asTypeParam(t));
mcimadamore@1496 656 } else {
duke@1 657 return t;
mcimadamore@1496 658 }
duke@1 659 }
mcimadamore@1496 660 //where
mcimadamore@1496 661 private Object asTypeParam(Type t) {
mcimadamore@1496 662 return (t.hasTag(TYPEVAR))
mcimadamore@1496 663 ? diags.fragment("type.parameter", t)
mcimadamore@1496 664 : t;
mcimadamore@1496 665 }
duke@1 666
mcimadamore@1352 667 /** Check that type is a valid qualifier for a constructor reference expression
mcimadamore@1352 668 */
mcimadamore@1352 669 Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 670 t = checkClassOrArrayType(pos, t);
jjg@1374 671 if (t.hasTag(CLASS)) {
mcimadamore@1352 672 if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
mcimadamore@1627 673 log.error(pos, "abstract.cant.be.instantiated", t.tsym);
mcimadamore@1352 674 t = types.createErrorType(t);
mcimadamore@1352 675 } else if ((t.tsym.flags() & ENUM) != 0) {
mcimadamore@1352 676 log.error(pos, "enum.cant.be.instantiated");
mcimadamore@1352 677 t = types.createErrorType(t);
mcimadamore@1627 678 } else {
mcimadamore@1627 679 t = checkClassType(pos, t, true);
mcimadamore@1627 680 }
mcimadamore@1627 681 } else if (t.hasTag(ARRAY)) {
mcimadamore@1627 682 if (!types.isReifiable(((ArrayType)t).elemtype)) {
mcimadamore@1627 683 log.error(pos, "generic.array.creation");
mcimadamore@1627 684 t = types.createErrorType(t);
mcimadamore@1352 685 }
mcimadamore@1352 686 }
mcimadamore@1352 687 return t;
mcimadamore@1352 688 }
mcimadamore@1352 689
duke@1 690 /** Check that type is a class or interface type.
duke@1 691 * @param pos Position to be used for error reporting.
duke@1 692 * @param t The type to be checked.
duke@1 693 * @param noBounds True if type bounds are illegal here.
duke@1 694 */
duke@1 695 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 696 t = checkClassType(pos, t);
duke@1 697 if (noBounds && t.isParameterized()) {
duke@1 698 List<Type> args = t.getTypeArguments();
duke@1 699 while (args.nonEmpty()) {
jjg@1374 700 if (args.head.hasTag(WILDCARD))
duke@1 701 return typeTagError(pos,
jjg@598 702 diags.fragment("type.req.exact"),
duke@1 703 args.head);
duke@1 704 args = args.tail;
duke@1 705 }
duke@1 706 }
duke@1 707 return t;
duke@1 708 }
duke@1 709
duke@1 710 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 711 * or a type variable.
duke@1 712 * @param pos Position to be used for error reporting.
duke@1 713 * @param t The type to be checked.
duke@1 714 */
duke@1 715 Type checkRefType(DiagnosticPosition pos, Type t) {
jjg@1374 716 if (t.isReference())
duke@1 717 return t;
jjg@1374 718 else
duke@1 719 return typeTagError(pos,
mcimadamore@89 720 diags.fragment("type.req.ref"),
duke@1 721 t);
duke@1 722 }
duke@1 723
jrose@267 724 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 725 * or a type variable.
jrose@267 726 * @param trees Original trees, used for error reporting.
jrose@267 727 * @param types The types to be checked.
jrose@267 728 */
jrose@267 729 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 730 List<JCExpression> tl = trees;
jrose@267 731 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 732 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 733 tl = tl.tail;
jrose@267 734 }
jrose@267 735 return types;
jrose@267 736 }
jrose@267 737
duke@1 738 /** Check that type is a null or reference type.
duke@1 739 * @param pos Position to be used for error reporting.
duke@1 740 * @param t The type to be checked.
duke@1 741 */
duke@1 742 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
vromero@1826 743 if (t.isReference() || t.hasTag(BOT))
duke@1 744 return t;
jjg@1374 745 else
duke@1 746 return typeTagError(pos,
mcimadamore@89 747 diags.fragment("type.req.ref"),
duke@1 748 t);
duke@1 749 }
duke@1 750
duke@1 751 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 752 * Return true if it doesn't.
duke@1 753 * @param pos Position to be used for error reporting.
duke@1 754 * @param flags The set of flags to be checked.
duke@1 755 * @param set1 Conflicting flags set #1.
duke@1 756 * @param set2 Conflicting flags set #2.
duke@1 757 */
duke@1 758 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 759 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 760 log.error(pos,
duke@1 761 "illegal.combination.of.modifiers",
mcimadamore@80 762 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 763 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 764 return false;
duke@1 765 } else
duke@1 766 return true;
duke@1 767 }
duke@1 768
mcimadamore@914 769 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 770 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 771 */
mcimadamore@914 772 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 773 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 774 t.isErroneous()) {
mcimadamore@914 775 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 776 } else if (tree.def != null) {
mcimadamore@914 777 log.error(tree.clazz.pos(),
mcimadamore@914 778 "cant.apply.diamond.1",
mcimadamore@914 779 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 780 return types.createErrorType(t);
mcimadamore@948 781 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 782 log.error(tree.clazz.pos(),
mcimadamore@914 783 "cant.apply.diamond.1",
mcimadamore@914 784 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 785 return types.createErrorType(t);
mcimadamore@993 786 } else if (tree.typeargs != null &&
mcimadamore@993 787 tree.typeargs.nonEmpty()) {
mcimadamore@993 788 log.error(tree.clazz.pos(),
mcimadamore@993 789 "cant.apply.diamond.1",
mcimadamore@993 790 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 791 return types.createErrorType(t);
mcimadamore@914 792 } else {
mcimadamore@914 793 return t;
mcimadamore@537 794 }
mcimadamore@537 795 }
mcimadamore@537 796
mcimadamore@795 797 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 798 MethodSymbol m = tree.sym;
mcimadamore@795 799 if (!allowSimplifiedVarargs) return;
mcimadamore@795 800 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 801 Type varargElemType = null;
mcimadamore@580 802 if (m.isVarArgs()) {
mcimadamore@795 803 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 804 }
mcimadamore@795 805 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 806 if (varargElemType != null) {
mcimadamore@795 807 log.error(tree,
mcimadamore@795 808 "varargs.invalid.trustme.anno",
mcimadamore@795 809 syms.trustMeType.tsym,
mcimadamore@795 810 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 811 } else {
mcimadamore@795 812 log.error(tree,
mcimadamore@795 813 "varargs.invalid.trustme.anno",
mcimadamore@795 814 syms.trustMeType.tsym,
mcimadamore@795 815 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 816 }
mcimadamore@795 817 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 818 types.isReifiable(varargElemType)) {
mcimadamore@795 819 warnUnsafeVararg(tree,
mcimadamore@795 820 "varargs.redundant.trustme.anno",
mcimadamore@795 821 syms.trustMeType.tsym,
mcimadamore@795 822 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 823 }
mcimadamore@795 824 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 825 !types.isReifiable(varargElemType)) {
mcimadamore@795 826 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 827 }
mcimadamore@580 828 }
mcimadamore@795 829 //where
mcimadamore@795 830 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 831 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 832 (s.isConstructor() ||
mcimadamore@795 833 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 834 }
mcimadamore@580 835
mcimadamore@1812 836 Type checkMethod(final Type mtype,
mcimadamore@1812 837 final Symbol sym,
mcimadamore@1812 838 final Env<AttrContext> env,
mcimadamore@1812 839 final List<JCExpression> argtrees,
mcimadamore@1812 840 final List<Type> argtypes,
mcimadamore@1812 841 final boolean useVarargs,
mcimadamore@1812 842 InferenceContext inferenceContext) {
mcimadamore@1219 843 // System.out.println("call : " + env.tree);
mcimadamore@1219 844 // System.out.println("method : " + owntype);
mcimadamore@1219 845 // System.out.println("actuals: " + argtypes);
mcimadamore@1812 846 if (inferenceContext.free(mtype)) {
mcimadamore@1812 847 inferenceContext.addFreeTypeListener(List.of(mtype), new FreeTypeListener() {
mcimadamore@1812 848 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1812 849 checkMethod(inferenceContext.asInstType(mtype), sym, env, argtrees, argtypes, useVarargs, inferenceContext);
mcimadamore@1812 850 }
mcimadamore@1812 851 });
mcimadamore@1812 852 return mtype;
mcimadamore@1812 853 }
mcimadamore@1812 854 Type owntype = mtype;
mcimadamore@1219 855 List<Type> formals = owntype.getParameterTypes();
kizune@1959 856 List<Type> nonInferred = sym.type.getParameterTypes();
kizune@1959 857 if (nonInferred.length() != formals.length()) nonInferred = formals;
mcimadamore@1219 858 Type last = useVarargs ? formals.last() : null;
kizune@1959 859 if (sym.name == names.init && sym.owner == syms.enumSym) {
kizune@1959 860 formals = formals.tail.tail;
kizune@1959 861 nonInferred = nonInferred.tail.tail;
kizune@1959 862 }
mcimadamore@1219 863 List<JCExpression> args = argtrees;
mcimadamore@1352 864 if (args != null) {
mcimadamore@1352 865 //this is null when type-checking a method reference
mcimadamore@1352 866 while (formals.head != last) {
mcimadamore@1219 867 JCTree arg = args.head;
kizune@1959 868 Warner warn = convertWarner(arg.pos(), arg.type, nonInferred.head);
mcimadamore@1352 869 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 870 args = args.tail;
mcimadamore@1352 871 formals = formals.tail;
kizune@1959 872 nonInferred = nonInferred.tail;
mcimadamore@1219 873 }
mcimadamore@1352 874 if (useVarargs) {
mcimadamore@1352 875 Type varArg = types.elemtype(last);
mcimadamore@1352 876 while (args.tail != null) {
mcimadamore@1352 877 JCTree arg = args.head;
mcimadamore@1352 878 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1352 879 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1352 880 args = args.tail;
mcimadamore@1352 881 }
mcimadamore@1904 882 } else if ((sym.flags() & (VARARGS | SIGNATURE_POLYMORPHIC)) == VARARGS &&
mcimadamore@1904 883 allowVarargs) {
mcimadamore@1352 884 // non-varargs call to varargs method
mcimadamore@1352 885 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1812 886 Type lastArg = argtypes.last();
mcimadamore@1352 887 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
kizune@1959 888 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1352 889 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
kizune@1959 890 types.elemtype(varParam), varParam);
mcimadamore@1352 891 }
mcimadamore@1219 892 }
mcimadamore@1219 893 if (useVarargs) {
mcimadamore@1219 894 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 895 if (!types.isReifiable(argtype) &&
kizune@1959 896 (!allowSimplifiedVarargs ||
kizune@1959 897 sym.attribute(syms.trustMeType.tsym) == null ||
kizune@1959 898 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 899 warnUnchecked(env.tree.pos(),
mcimadamore@1219 900 "unchecked.generic.array.creation",
mcimadamore@1219 901 argtype);
mcimadamore@1219 902 }
vromero@1820 903 if ((sym.baseSymbol().flags() & SIGNATURE_POLYMORPHIC) == 0) {
mcimadamore@1812 904 TreeInfo.setVarargsElement(env.tree, types.elemtype(argtype));
mcimadamore@1219 905 }
mcimadamore@1219 906 }
mcimadamore@1510 907 PolyKind pkind = (sym.type.hasTag(FORALL) &&
mcimadamore@1510 908 sym.type.getReturnType().containsAny(((ForAll)sym.type).tvars)) ?
mcimadamore@1510 909 PolyKind.POLY : PolyKind.STANDALONE;
mcimadamore@1510 910 TreeInfo.setPolyKind(env.tree, pkind);
mcimadamore@1219 911 return owntype;
mcimadamore@547 912 }
mcimadamore@1219 913 //where
kizune@1959 914 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
kizune@1959 915 if (types.isConvertible(actual, formal, warn))
kizune@1959 916 return;
kizune@1959 917
kizune@1959 918 if (formal.isCompound()
kizune@1959 919 && types.isSubtype(actual, types.supertype(formal))
kizune@1959 920 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
kizune@1959 921 return;
kizune@1959 922 }
mcimadamore@547 923
mcimadamore@821 924 /**
mcimadamore@821 925 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 926 * (see JLS 4.5)
mcimadamore@821 927 *
mcimadamore@821 928 * @param t class type to be checked
mcimadamore@821 929 * @return true if 't' is well-formed
mcimadamore@821 930 */
mcimadamore@821 931 public boolean checkValidGenericType(Type t) {
mcimadamore@821 932 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 933 }
mcimadamore@821 934 //WHERE
mcimadamore@821 935 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 936 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 937 List<Type> actuals = type.allparams();
mcimadamore@821 938 List<Type> args = type.getTypeArguments();
mcimadamore@821 939 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 940 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 941
mcimadamore@821 942 // For matching pairs of actual argument types `a' and
mcimadamore@821 943 // formal type parameters with declared bound `b' ...
mcimadamore@821 944 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 945 // exact type arguments needs to know their
mcimadamore@821 946 // bounds (for upper and lower bound
mcimadamore@1216 947 // calculations). So we create new bounds where
mcimadamore@1216 948 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 949 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 950 args = args.tail;
mcimadamore@821 951 forms = forms.tail;
mcimadamore@821 952 }
mcimadamore@821 953
mcimadamore@821 954 args = type.getTypeArguments();
mcimadamore@821 955 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 956 formals,
mcimadamore@821 957 types.capture(type).allparams());
mcimadamore@821 958 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 959 // Let the actual arguments know their bound
mcimadamore@821 960 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 961 args = args.tail;
mcimadamore@821 962 tvars_cap = tvars_cap.tail;
mcimadamore@821 963 }
mcimadamore@821 964
mcimadamore@821 965 args = type.getTypeArguments();
mcimadamore@1216 966 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 967
mcimadamore@1216 968 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 969 Type actual = args.head;
mcimadamore@854 970 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 971 !bounds.head.isErroneous() &&
mcimadamore@1216 972 !checkExtends(actual, bounds.head)) {
mcimadamore@821 973 return args.head;
mcimadamore@821 974 }
mcimadamore@821 975 args = args.tail;
mcimadamore@1216 976 bounds = bounds.tail;
mcimadamore@821 977 }
mcimadamore@821 978
mcimadamore@821 979 args = type.getTypeArguments();
mcimadamore@1216 980 bounds = bounds_buf.toList();
mcimadamore@821 981
mcimadamore@821 982 for (Type arg : types.capture(type).getTypeArguments()) {
jjg@1374 983 if (arg.hasTag(TYPEVAR) &&
mcimadamore@828 984 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 985 !bounds.head.isErroneous() &&
mcimadamore@854 986 !isTypeArgErroneous(args.head)) {
mcimadamore@821 987 return args.head;
mcimadamore@821 988 }
mcimadamore@1216 989 bounds = bounds.tail;
mcimadamore@854 990 args = args.tail;
mcimadamore@821 991 }
mcimadamore@821 992
mcimadamore@821 993 return null;
mcimadamore@821 994 }
mcimadamore@854 995 //where
mcimadamore@854 996 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 997 return isTypeArgErroneous.visit(t);
mcimadamore@854 998 }
mcimadamore@854 999
mcimadamore@854 1000 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 1001 public Boolean visitType(Type t, Void s) {
mcimadamore@854 1002 return t.isErroneous();
mcimadamore@854 1003 }
mcimadamore@854 1004 @Override
mcimadamore@854 1005 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 1006 return visit(t.getUpperBound());
mcimadamore@854 1007 }
mcimadamore@854 1008 @Override
mcimadamore@854 1009 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 1010 return visit(t.getUpperBound()) ||
mcimadamore@854 1011 visit(t.getLowerBound());
mcimadamore@854 1012 }
mcimadamore@854 1013 @Override
mcimadamore@854 1014 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1015 return visit(t.type);
mcimadamore@854 1016 }
mcimadamore@854 1017 };
mcimadamore@821 1018
duke@1 1019 /** Check that given modifiers are legal for given symbol and
vromero@1555 1020 * return modifiers together with any implicit modifiers for that symbol.
duke@1 1021 * Warning: we can't use flags() here since this method
duke@1 1022 * is called during class enter, when flags() would cause a premature
duke@1 1023 * completion.
duke@1 1024 * @param pos Position to be used for error reporting.
duke@1 1025 * @param flags The set of modifiers given in a definition.
duke@1 1026 * @param sym The defined symbol.
duke@1 1027 */
duke@1 1028 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1029 long mask;
duke@1 1030 long implicit = 0;
emc@2016 1031
duke@1 1032 switch (sym.kind) {
duke@1 1033 case VAR:
duke@1 1034 if (sym.owner.kind != TYP)
duke@1 1035 mask = LocalVarFlags;
duke@1 1036 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1037 mask = implicit = InterfaceVarFlags;
duke@1 1038 else
duke@1 1039 mask = VarFlags;
duke@1 1040 break;
duke@1 1041 case MTH:
duke@1 1042 if (sym.name == names.init) {
duke@1 1043 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1044 // enum constructors cannot be declared public or
duke@1 1045 // protected and must be implicitly or explicitly
duke@1 1046 // private
duke@1 1047 implicit = PRIVATE;
duke@1 1048 mask = PRIVATE;
duke@1 1049 } else
duke@1 1050 mask = ConstructorFlags;
mcimadamore@1366 1051 } else if ((sym.owner.flags_field & INTERFACE) != 0) {
emc@2016 1052 if ((sym.owner.flags_field & ANNOTATION) != 0) {
emc@2016 1053 mask = AnnotationTypeElementMask;
emc@2016 1054 implicit = PUBLIC | ABSTRACT;
emc@2016 1055 } else if ((flags & (DEFAULT | STATIC)) != 0) {
mcimadamore@1513 1056 mask = InterfaceMethodMask;
mcimadamore@1513 1057 implicit = PUBLIC;
mcimadamore@1513 1058 if ((flags & DEFAULT) != 0) {
mcimadamore@1513 1059 implicit |= ABSTRACT;
mcimadamore@1513 1060 }
mcimadamore@1366 1061 } else {
mcimadamore@1366 1062 mask = implicit = InterfaceMethodFlags;
mcimadamore@1366 1063 }
emc@2016 1064 } else {
duke@1 1065 mask = MethodFlags;
duke@1 1066 }
duke@1 1067 // Imply STRICTFP if owner has STRICTFP set.
vromero@1712 1068 if (((flags|implicit) & Flags.ABSTRACT) == 0 ||
vromero@1712 1069 ((flags) & Flags.DEFAULT) != 0)
vromero@1555 1070 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1071 break;
duke@1 1072 case TYP:
duke@1 1073 if (sym.isLocal()) {
duke@1 1074 mask = LocalClassFlags;
jjg@113 1075 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1076 // Anonymous classes in static methods are themselves static;
duke@1 1077 // that's why we admit STATIC here.
duke@1 1078 mask |= STATIC;
duke@1 1079 // JLS: Anonymous classes are final.
duke@1 1080 implicit |= FINAL;
duke@1 1081 }
duke@1 1082 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1083 (flags & ENUM) != 0)
duke@1 1084 log.error(pos, "enums.must.be.static");
duke@1 1085 } else if (sym.owner.kind == TYP) {
duke@1 1086 mask = MemberClassFlags;
duke@1 1087 if (sym.owner.owner.kind == PCK ||
duke@1 1088 (sym.owner.flags_field & STATIC) != 0)
duke@1 1089 mask |= STATIC;
duke@1 1090 else if ((flags & ENUM) != 0)
duke@1 1091 log.error(pos, "enums.must.be.static");
duke@1 1092 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1093 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1094 } else {
duke@1 1095 mask = ClassFlags;
duke@1 1096 }
duke@1 1097 // Interfaces are always ABSTRACT
duke@1 1098 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1099
duke@1 1100 if ((flags & ENUM) != 0) {
duke@1 1101 // enums can't be declared abstract or final
duke@1 1102 mask &= ~(ABSTRACT | FINAL);
duke@1 1103 implicit |= implicitEnumFinalFlag(tree);
duke@1 1104 }
duke@1 1105 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1106 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1107 break;
duke@1 1108 default:
duke@1 1109 throw new AssertionError();
duke@1 1110 }
mcimadamore@1366 1111 long illegal = flags & ExtendedStandardFlags & ~mask;
duke@1 1112 if (illegal != 0) {
duke@1 1113 if ((illegal & INTERFACE) != 0) {
duke@1 1114 log.error(pos, "intf.not.allowed.here");
duke@1 1115 mask |= INTERFACE;
duke@1 1116 }
duke@1 1117 else {
duke@1 1118 log.error(pos,
mcimadamore@80 1119 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1120 }
duke@1 1121 }
duke@1 1122 else if ((sym.kind == TYP ||
duke@1 1123 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1124 // in the presence of inner classes. Should it be deleted here?
duke@1 1125 checkDisjoint(pos, flags,
duke@1 1126 ABSTRACT,
mcimadamore@1366 1127 PRIVATE | STATIC | DEFAULT))
duke@1 1128 &&
duke@1 1129 checkDisjoint(pos, flags,
mcimadamore@1513 1130 STATIC,
mcimadamore@1513 1131 DEFAULT)
mcimadamore@1513 1132 &&
mcimadamore@1513 1133 checkDisjoint(pos, flags,
duke@1 1134 ABSTRACT | INTERFACE,
duke@1 1135 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1136 &&
duke@1 1137 checkDisjoint(pos, flags,
duke@1 1138 PUBLIC,
duke@1 1139 PRIVATE | PROTECTED)
duke@1 1140 &&
duke@1 1141 checkDisjoint(pos, flags,
duke@1 1142 PRIVATE,
duke@1 1143 PUBLIC | PROTECTED)
duke@1 1144 &&
duke@1 1145 checkDisjoint(pos, flags,
duke@1 1146 FINAL,
duke@1 1147 VOLATILE)
duke@1 1148 &&
duke@1 1149 (sym.kind == TYP ||
duke@1 1150 checkDisjoint(pos, flags,
duke@1 1151 ABSTRACT | NATIVE,
duke@1 1152 STRICTFP))) {
duke@1 1153 // skip
duke@1 1154 }
mcimadamore@1366 1155 return flags & (mask | ~ExtendedStandardFlags) | implicit;
duke@1 1156 }
duke@1 1157
duke@1 1158
duke@1 1159 /** Determine if this enum should be implicitly final.
duke@1 1160 *
duke@1 1161 * If the enum has no specialized enum contants, it is final.
duke@1 1162 *
duke@1 1163 * If the enum does have specialized enum contants, it is
duke@1 1164 * <i>not</i> final.
duke@1 1165 */
duke@1 1166 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1167 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1168 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1169 boolean specialized;
duke@1 1170 SpecialTreeVisitor() {
duke@1 1171 this.specialized = false;
duke@1 1172 };
duke@1 1173
jjg@398 1174 @Override
duke@1 1175 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1176
jjg@398 1177 @Override
duke@1 1178 public void visitVarDef(JCVariableDecl tree) {
duke@1 1179 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1180 if (tree.init instanceof JCNewClass &&
duke@1 1181 ((JCNewClass) tree.init).def != null) {
duke@1 1182 specialized = true;
duke@1 1183 }
duke@1 1184 }
duke@1 1185 }
duke@1 1186 }
duke@1 1187
duke@1 1188 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1189 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1190 for (JCTree defs: cdef.defs) {
duke@1 1191 defs.accept(sts);
duke@1 1192 if (sts.specialized) return 0;
duke@1 1193 }
duke@1 1194 return FINAL;
duke@1 1195 }
duke@1 1196
duke@1 1197 /* *************************************************************************
duke@1 1198 * Type Validation
duke@1 1199 **************************************************************************/
duke@1 1200
duke@1 1201 /** Validate a type expression. That is,
duke@1 1202 * check that all type arguments of a parametric type are within
jjg@1755 1203 * their bounds. This must be done in a second phase after type attribution
duke@1 1204 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1205 *
jjg@1358 1206 * <pre>{@code
duke@1 1207 * class B<A extends C> { ... }
duke@1 1208 * class C extends B<C> { ... }
jjg@1358 1209 * }</pre>
duke@1 1210 *
duke@1 1211 * and we can't make sure that the bound is already attributed because
duke@1 1212 * of possible cycles.
mcimadamore@638 1213 *
mcimadamore@638 1214 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1215 * and reporting any completion failures.
duke@1 1216 */
mcimadamore@122 1217 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1218 validate(tree, env, true);
duke@1 1219 }
mcimadamore@638 1220 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1221 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1222 }
duke@1 1223
duke@1 1224 /** Visitor method: Validate a list of type expressions.
duke@1 1225 */
mcimadamore@122 1226 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1227 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1228 validate(l.head, env);
duke@1 1229 }
duke@1 1230
duke@1 1231 /** A visitor class for type validation.
duke@1 1232 */
duke@1 1233 class Validator extends JCTree.Visitor {
duke@1 1234
jlahoda@2038 1235 boolean checkRaw;
mcimadamore@638 1236 boolean isOuter;
mcimadamore@638 1237 Env<AttrContext> env;
mcimadamore@638 1238
mcimadamore@638 1239 Validator(Env<AttrContext> env) {
mcimadamore@638 1240 this.env = env;
mcimadamore@638 1241 }
mcimadamore@638 1242
jjg@398 1243 @Override
duke@1 1244 public void visitTypeArray(JCArrayTypeTree tree) {
jlahoda@2038 1245 validateTree(tree.elemtype, checkRaw, isOuter);
duke@1 1246 }
duke@1 1247
jjg@398 1248 @Override
duke@1 1249 public void visitTypeApply(JCTypeApply tree) {
jjg@1374 1250 if (tree.type.hasTag(CLASS)) {
duke@1 1251 List<JCExpression> args = tree.arguments;
mcimadamore@158 1252 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1253
mcimadamore@821 1254 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1255 if (incompatibleArg != null) {
mcimadamore@821 1256 for (JCTree arg : tree.arguments) {
mcimadamore@821 1257 if (arg.type == incompatibleArg) {
mcimadamore@829 1258 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1259 }
mcimadamore@829 1260 forms = forms.tail;
mcimadamore@829 1261 }
mcimadamore@829 1262 }
mcimadamore@829 1263
mcimadamore@829 1264 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1265
mcimadamore@638 1266 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1267
duke@1 1268 // For matching pairs of actual argument types `a' and
duke@1 1269 // formal type parameters with declared bound `b' ...
duke@1 1270 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1271 validateTree(args.head,
mcimadamore@638 1272 !(isOuter && is_java_lang_Class),
mcimadamore@638 1273 false);
duke@1 1274 args = args.tail;
duke@1 1275 forms = forms.tail;
duke@1 1276 }
duke@1 1277
duke@1 1278 // Check that this type is either fully parameterized, or
duke@1 1279 // not parameterized at all.
duke@1 1280 if (tree.type.getEnclosingType().isRaw())
duke@1 1281 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1282 if (tree.clazz.hasTag(SELECT))
duke@1 1283 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1284 }
duke@1 1285 }
duke@1 1286
jjg@398 1287 @Override
duke@1 1288 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1289 validateTrees(tree.bounds, true, isOuter);
duke@1 1290 checkClassBounds(tree.pos(), tree.type);
duke@1 1291 }
duke@1 1292
duke@1 1293 @Override
duke@1 1294 public void visitWildcard(JCWildcard tree) {
duke@1 1295 if (tree.inner != null)
mcimadamore@638 1296 validateTree(tree.inner, true, isOuter);
duke@1 1297 }
duke@1 1298
jjg@398 1299 @Override
duke@1 1300 public void visitSelect(JCFieldAccess tree) {
jjg@1374 1301 if (tree.type.hasTag(CLASS)) {
duke@1 1302 visitSelectInternal(tree);
duke@1 1303
duke@1 1304 // Check that this type is either fully parameterized, or
duke@1 1305 // not parameterized at all.
duke@1 1306 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1307 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1308 }
duke@1 1309 }
mcimadamore@852 1310
duke@1 1311 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1312 if (tree.type.tsym.isStatic() &&
duke@1 1313 tree.selected.type.isParameterized()) {
duke@1 1314 // The enclosing type is not a class, so we are
duke@1 1315 // looking at a static member type. However, the
duke@1 1316 // qualifying expression is parameterized.
duke@1 1317 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1318 } else {
duke@1 1319 // otherwise validate the rest of the expression
mcimadamore@122 1320 tree.selected.accept(this);
duke@1 1321 }
duke@1 1322 }
duke@1 1323
jjg@1521 1324 @Override
jjg@1521 1325 public void visitAnnotatedType(JCAnnotatedType tree) {
jjg@1521 1326 tree.underlyingType.accept(this);
jjg@1521 1327 }
jjg@1521 1328
jlahoda@2206 1329 @Override
jlahoda@2206 1330 public void visitTypeIdent(JCPrimitiveTypeTree that) {
jlahoda@2206 1331 if (that.type.hasTag(TypeTag.VOID)) {
jlahoda@2206 1332 log.error(that.pos(), "void.not.allowed.here");
jlahoda@2206 1333 }
jlahoda@2206 1334 super.visitTypeIdent(that);
jlahoda@2206 1335 }
jlahoda@2206 1336
duke@1 1337 /** Default visitor method: do nothing.
duke@1 1338 */
jjg@398 1339 @Override
duke@1 1340 public void visitTree(JCTree tree) {
duke@1 1341 }
mcimadamore@122 1342
mcimadamore@638 1343 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
jlahoda@2038 1344 if (tree != null) {
jlahoda@2038 1345 boolean prevCheckRaw = this.checkRaw;
jlahoda@2038 1346 this.checkRaw = checkRaw;
jlahoda@2038 1347 this.isOuter = isOuter;
jlahoda@2038 1348
jlahoda@2038 1349 try {
mcimadamore@638 1350 tree.accept(this);
mcimadamore@638 1351 if (checkRaw)
mcimadamore@638 1352 checkRaw(tree, env);
jlahoda@2038 1353 } catch (CompletionFailure ex) {
jlahoda@2038 1354 completionError(tree.pos(), ex);
jlahoda@2038 1355 } finally {
jlahoda@2038 1356 this.checkRaw = prevCheckRaw;
mcimadamore@638 1357 }
mcimadamore@638 1358 }
mcimadamore@638 1359 }
mcimadamore@638 1360
mcimadamore@638 1361 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1362 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1363 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1364 }
mcimadamore@1760 1365 }
mcimadamore@1760 1366
mcimadamore@1760 1367 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@1760 1368 if (lint.isEnabled(LintCategory.RAW) &&
mcimadamore@1760 1369 tree.type.hasTag(CLASS) &&
mcimadamore@1760 1370 !TreeInfo.isDiamond(tree) &&
mcimadamore@1760 1371 !withinAnonConstr(env) &&
mcimadamore@1760 1372 tree.type.isRaw()) {
mcimadamore@1760 1373 log.warning(LintCategory.RAW,
mcimadamore@1760 1374 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1375 }
mcimadamore@1760 1376 }
mcimadamore@1760 1377 //where
mcimadamore@1760 1378 private boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1379 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1380 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1381 }
duke@1 1382
duke@1 1383 /* *************************************************************************
duke@1 1384 * Exception checking
duke@1 1385 **************************************************************************/
duke@1 1386
duke@1 1387 /* The following methods treat classes as sets that contain
duke@1 1388 * the class itself and all their subclasses
duke@1 1389 */
duke@1 1390
duke@1 1391 /** Is given type a subtype of some of the types in given list?
duke@1 1392 */
duke@1 1393 boolean subset(Type t, List<Type> ts) {
duke@1 1394 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1395 if (types.isSubtype(t, l.head)) return true;
duke@1 1396 return false;
duke@1 1397 }
duke@1 1398
duke@1 1399 /** Is given type a subtype or supertype of
duke@1 1400 * some of the types in given list?
duke@1 1401 */
duke@1 1402 boolean intersects(Type t, List<Type> ts) {
duke@1 1403 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1404 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1405 return false;
duke@1 1406 }
duke@1 1407
duke@1 1408 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1409 * in the list.
duke@1 1410 */
duke@1 1411 List<Type> incl(Type t, List<Type> ts) {
duke@1 1412 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1413 }
duke@1 1414
duke@1 1415 /** Remove type set from type set list.
duke@1 1416 */
duke@1 1417 List<Type> excl(Type t, List<Type> ts) {
duke@1 1418 if (ts.isEmpty()) {
duke@1 1419 return ts;
duke@1 1420 } else {
duke@1 1421 List<Type> ts1 = excl(t, ts.tail);
duke@1 1422 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1423 else if (ts1 == ts.tail) return ts;
duke@1 1424 else return ts1.prepend(ts.head);
duke@1 1425 }
duke@1 1426 }
duke@1 1427
duke@1 1428 /** Form the union of two type set lists.
duke@1 1429 */
duke@1 1430 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1431 List<Type> ts = ts1;
duke@1 1432 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1433 ts = incl(l.head, ts);
duke@1 1434 return ts;
duke@1 1435 }
duke@1 1436
duke@1 1437 /** Form the difference of two type lists.
duke@1 1438 */
duke@1 1439 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1440 List<Type> ts = ts1;
duke@1 1441 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1442 ts = excl(l.head, ts);
duke@1 1443 return ts;
duke@1 1444 }
duke@1 1445
duke@1 1446 /** Form the intersection of two type lists.
duke@1 1447 */
duke@1 1448 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1449 List<Type> ts = List.nil();
duke@1 1450 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1451 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1452 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1453 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1454 return ts;
duke@1 1455 }
duke@1 1456
duke@1 1457 /** Is exc an exception symbol that need not be declared?
duke@1 1458 */
duke@1 1459 boolean isUnchecked(ClassSymbol exc) {
duke@1 1460 return
duke@1 1461 exc.kind == ERR ||
duke@1 1462 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1463 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1464 }
duke@1 1465
duke@1 1466 /** Is exc an exception type that need not be declared?
duke@1 1467 */
duke@1 1468 boolean isUnchecked(Type exc) {
duke@1 1469 return
jjg@1374 1470 (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
jjg@1374 1471 (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
jjg@1374 1472 exc.hasTag(BOT);
duke@1 1473 }
duke@1 1474
duke@1 1475 /** Same, but handling completion failures.
duke@1 1476 */
duke@1 1477 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1478 try {
duke@1 1479 return isUnchecked(exc);
duke@1 1480 } catch (CompletionFailure ex) {
duke@1 1481 completionError(pos, ex);
duke@1 1482 return true;
duke@1 1483 }
duke@1 1484 }
duke@1 1485
duke@1 1486 /** Is exc handled by given exception list?
duke@1 1487 */
duke@1 1488 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1489 return isUnchecked(exc) || subset(exc, handled);
duke@1 1490 }
duke@1 1491
duke@1 1492 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1493 * @param thrown The list of thrown exceptions.
duke@1 1494 * @param handled The list of handled exceptions.
duke@1 1495 */
mcimadamore@362 1496 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1497 List<Type> unhandled = List.nil();
duke@1 1498 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1499 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1500 return unhandled;
duke@1 1501 }
duke@1 1502
duke@1 1503 /* *************************************************************************
duke@1 1504 * Overriding/Implementation checking
duke@1 1505 **************************************************************************/
duke@1 1506
duke@1 1507 /** The level of access protection given by a flag set,
duke@1 1508 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1509 */
duke@1 1510 static int protection(long flags) {
duke@1 1511 switch ((short)(flags & AccessFlags)) {
duke@1 1512 case PRIVATE: return 3;
duke@1 1513 case PROTECTED: return 1;
duke@1 1514 default:
duke@1 1515 case PUBLIC: return 0;
duke@1 1516 case 0: return 2;
duke@1 1517 }
duke@1 1518 }
duke@1 1519
duke@1 1520 /** A customized "cannot override" error message.
duke@1 1521 * @param m The overriding method.
duke@1 1522 * @param other The overridden method.
duke@1 1523 * @return An internationalized string.
duke@1 1524 */
mcimadamore@89 1525 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1526 String key;
duke@1 1527 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1528 key = "cant.override";
duke@1 1529 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1530 key = "cant.implement";
duke@1 1531 else
duke@1 1532 key = "clashes.with";
mcimadamore@89 1533 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1534 }
duke@1 1535
duke@1 1536 /** A customized "override" warning message.
duke@1 1537 * @param m The overriding method.
duke@1 1538 * @param other The overridden method.
duke@1 1539 * @return An internationalized string.
duke@1 1540 */
mcimadamore@89 1541 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1542 String key;
duke@1 1543 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1544 key = "unchecked.override";
duke@1 1545 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1546 key = "unchecked.implement";
duke@1 1547 else
duke@1 1548 key = "unchecked.clash.with";
mcimadamore@89 1549 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1550 }
duke@1 1551
duke@1 1552 /** A customized "override" warning message.
duke@1 1553 * @param m The overriding method.
duke@1 1554 * @param other The overridden method.
duke@1 1555 * @return An internationalized string.
duke@1 1556 */
mcimadamore@89 1557 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1558 String key;
duke@1 1559 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1560 key = "varargs.override";
duke@1 1561 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1562 key = "varargs.implement";
duke@1 1563 else
duke@1 1564 key = "varargs.clash.with";
mcimadamore@89 1565 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1566 }
duke@1 1567
duke@1 1568 /** Check that this method conforms with overridden method 'other'.
duke@1 1569 * where `origin' is the class where checking started.
duke@1 1570 * Complications:
duke@1 1571 * (1) Do not check overriding of synthetic methods
duke@1 1572 * (reason: they might be final).
duke@1 1573 * todo: check whether this is still necessary.
duke@1 1574 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1575 * than the method it implements. Augment the proxy methods with the
duke@1 1576 * undeclared exceptions in this case.
duke@1 1577 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1578 * has a result type
duke@1 1579 * extended by the result type of the method it implements.
duke@1 1580 * Change the proxies result type to the smaller type in this case.
duke@1 1581 *
duke@1 1582 * @param tree The tree from which positions
duke@1 1583 * are extracted for errors.
duke@1 1584 * @param m The overriding method.
duke@1 1585 * @param other The overridden method.
duke@1 1586 * @param origin The class of which the overriding method
duke@1 1587 * is a member.
duke@1 1588 */
duke@1 1589 void checkOverride(JCTree tree,
duke@1 1590 MethodSymbol m,
duke@1 1591 MethodSymbol other,
duke@1 1592 ClassSymbol origin) {
duke@1 1593 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1594 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1595 return;
duke@1 1596 }
duke@1 1597
duke@1 1598 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1599 if ((m.flags() & STATIC) != 0 &&
duke@1 1600 (other.flags() & STATIC) == 0) {
duke@1 1601 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1602 cannotOverride(m, other));
vromero@1588 1603 m.flags_field |= BAD_OVERRIDE;
duke@1 1604 return;
duke@1 1605 }
duke@1 1606
duke@1 1607 // Error if instance method overrides static or final
duke@1 1608 // method (JLS 8.4.6.1).
duke@1 1609 if ((other.flags() & FINAL) != 0 ||
duke@1 1610 (m.flags() & STATIC) == 0 &&
duke@1 1611 (other.flags() & STATIC) != 0) {
duke@1 1612 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1613 cannotOverride(m, other),
mcimadamore@80 1614 asFlagSet(other.flags() & (FINAL | STATIC)));
vromero@1588 1615 m.flags_field |= BAD_OVERRIDE;
duke@1 1616 return;
duke@1 1617 }
duke@1 1618
duke@1 1619 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1620 // handled in validateAnnotationMethod
duke@1 1621 return;
duke@1 1622 }
duke@1 1623
duke@1 1624 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1625 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1626 protection(m.flags()) > protection(other.flags())) {
duke@1 1627 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1628 cannotOverride(m, other),
mcimadamore@80 1629 other.flags() == 0 ?
vromero@1842 1630 "package" :
mcimadamore@80 1631 asFlagSet(other.flags() & AccessFlags));
vromero@1588 1632 m.flags_field |= BAD_OVERRIDE;
duke@1 1633 return;
duke@1 1634 }
duke@1 1635
duke@1 1636 Type mt = types.memberType(origin.type, m);
duke@1 1637 Type ot = types.memberType(origin.type, other);
duke@1 1638 // Error if overriding result type is different
duke@1 1639 // (or, in the case of generics mode, not a subtype) of
duke@1 1640 // overridden result type. We have to rename any type parameters
duke@1 1641 // before comparing types.
duke@1 1642 List<Type> mtvars = mt.getTypeArguments();
duke@1 1643 List<Type> otvars = ot.getTypeArguments();
duke@1 1644 Type mtres = mt.getReturnType();
duke@1 1645 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1646
mcimadamore@795 1647 overrideWarner.clear();
duke@1 1648 boolean resultTypesOK =
tbell@202 1649 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1650 if (!resultTypesOK) {
jjg@398 1651 if (!allowCovariantReturns &&
duke@1 1652 m.owner != origin &&
duke@1 1653 m.owner.isSubClass(other.owner, types)) {
duke@1 1654 // allow limited interoperability with covariant returns
duke@1 1655 } else {
mcimadamore@362 1656 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1657 "override.incompatible.ret",
mcimadamore@362 1658 cannotOverride(m, other),
duke@1 1659 mtres, otres);
vromero@1588 1660 m.flags_field |= BAD_OVERRIDE;
duke@1 1661 return;
duke@1 1662 }
mcimadamore@795 1663 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1664 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1665 "override.unchecked.ret",
mcimadamore@362 1666 uncheckedOverrides(m, other),
mcimadamore@362 1667 mtres, otres);
duke@1 1668 }
duke@1 1669
duke@1 1670 // Error if overriding method throws an exception not reported
duke@1 1671 // by overridden method.
duke@1 1672 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1673 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1674 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1675 if (unhandledErased.nonEmpty()) {
duke@1 1676 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1677 "override.meth.doesnt.throw",
duke@1 1678 cannotOverride(m, other),
mcimadamore@362 1679 unhandledUnerased.head);
vromero@1588 1680 m.flags_field |= BAD_OVERRIDE;
mcimadamore@362 1681 return;
mcimadamore@362 1682 }
mcimadamore@362 1683 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1684 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1685 "override.unchecked.thrown",
mcimadamore@362 1686 cannotOverride(m, other),
mcimadamore@362 1687 unhandledUnerased.head);
duke@1 1688 return;
duke@1 1689 }
duke@1 1690
duke@1 1691 // Optional warning if varargs don't agree
duke@1 1692 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1693 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1694 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1695 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1696 ? "override.varargs.missing"
duke@1 1697 : "override.varargs.extra",
duke@1 1698 varargsOverrides(m, other));
duke@1 1699 }
duke@1 1700
duke@1 1701 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1702 if ((other.flags() & BRIDGE) != 0) {
duke@1 1703 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1704 uncheckedOverrides(m, other));
duke@1 1705 }
duke@1 1706
duke@1 1707 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1708 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1709 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1710 }
duke@1 1711 }
duke@1 1712 // where
duke@1 1713 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1714 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1715 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1716 // because in that case, we will rediscover the issue when examining the method
duke@1 1717 // in the supertype.
duke@1 1718 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1719 // address the issue is when the method is the supertype implemementation: any other
duke@1 1720 // case, we will have dealt with when examining the supertype classes
duke@1 1721 ClassSymbol mc = m.enclClass();
duke@1 1722 Type st = types.supertype(origin.type);
jjg@1374 1723 if (!st.hasTag(CLASS))
duke@1 1724 return true;
duke@1 1725 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1726
duke@1 1727 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1728 List<Type> intfs = types.interfaces(origin.type);
duke@1 1729 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1730 }
duke@1 1731 else
duke@1 1732 return (stimpl != m);
duke@1 1733 }
duke@1 1734
duke@1 1735
duke@1 1736 // used to check if there were any unchecked conversions
duke@1 1737 Warner overrideWarner = new Warner();
duke@1 1738
duke@1 1739 /** Check that a class does not inherit two concrete methods
duke@1 1740 * with the same signature.
duke@1 1741 * @param pos Position to be used for error reporting.
duke@1 1742 * @param site The class type to be checked.
duke@1 1743 */
duke@1 1744 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1745 Type sup = types.supertype(site);
jjg@1374 1746 if (!sup.hasTag(CLASS)) return;
duke@1 1747
duke@1 1748 for (Type t1 = sup;
jlahoda@1956 1749 t1.hasTag(CLASS) && t1.tsym.type.isParameterized();
duke@1 1750 t1 = types.supertype(t1)) {
duke@1 1751 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1752 e1 != null;
duke@1 1753 e1 = e1.sibling) {
duke@1 1754 Symbol s1 = e1.sym;
duke@1 1755 if (s1.kind != MTH ||
duke@1 1756 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1757 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1758 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1759 types,
duke@1 1760 true) != s1)
duke@1 1761 continue;
duke@1 1762 Type st1 = types.memberType(t1, s1);
duke@1 1763 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1764 if (st1 == s1.type) continue;
duke@1 1765
duke@1 1766 for (Type t2 = sup;
jjg@1374 1767 t2.hasTag(CLASS);
duke@1 1768 t2 = types.supertype(t2)) {
mcimadamore@24 1769 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1770 e2.scope != null;
duke@1 1771 e2 = e2.next()) {
duke@1 1772 Symbol s2 = e2.sym;
duke@1 1773 if (s2 == s1 ||
duke@1 1774 s2.kind != MTH ||
duke@1 1775 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1776 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1777 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1778 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1779 types,
duke@1 1780 true) != s2)
duke@1 1781 continue;
duke@1 1782 Type st2 = types.memberType(t2, s2);
duke@1 1783 if (types.overrideEquivalent(st1, st2))
duke@1 1784 log.error(pos, "concrete.inheritance.conflict",
duke@1 1785 s1, t1, s2, t2, sup);
duke@1 1786 }
duke@1 1787 }
duke@1 1788 }
duke@1 1789 }
duke@1 1790 }
duke@1 1791
duke@1 1792 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1793 * method with same name and arguments but incompatible return types.
duke@1 1794 * @param pos Position to be used for error reporting.
duke@1 1795 * @param t1 The first argument type.
duke@1 1796 * @param t2 The second argument type.
duke@1 1797 */
duke@1 1798 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1799 Type t1,
duke@1 1800 Type t2) {
duke@1 1801 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1802 types.makeCompoundType(t1, t2));
duke@1 1803 }
duke@1 1804
duke@1 1805 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1806 Type t1,
duke@1 1807 Type t2,
duke@1 1808 Type site) {
mcimadamore@746 1809 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1810 }
duke@1 1811
duke@1 1812 /** Return the first method which is defined with same args
duke@1 1813 * but different return types in two given interfaces, or null if none
duke@1 1814 * exists.
duke@1 1815 * @param t1 The first type.
duke@1 1816 * @param t2 The second type.
duke@1 1817 * @param site The most derived type.
duke@1 1818 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1819 */
mcimadamore@746 1820 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1821 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1822 closure(t1, interfaces1);
duke@1 1823 Map<TypeSymbol,Type> interfaces2;
duke@1 1824 if (t1 == t2)
duke@1 1825 interfaces2 = interfaces1;
duke@1 1826 else
duke@1 1827 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1828
duke@1 1829 for (Type t3 : interfaces1.values()) {
duke@1 1830 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1831 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1832 if (s != null) return s;
duke@1 1833 }
duke@1 1834 }
duke@1 1835 return null;
duke@1 1836 }
duke@1 1837
duke@1 1838 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1839 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1840 if (!t.hasTag(CLASS)) return;
duke@1 1841 if (typeMap.put(t.tsym, t) == null) {
duke@1 1842 closure(types.supertype(t), typeMap);
duke@1 1843 for (Type i : types.interfaces(t))
duke@1 1844 closure(i, typeMap);
duke@1 1845 }
duke@1 1846 }
duke@1 1847
duke@1 1848 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1849 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1850 if (!t.hasTag(CLASS)) return;
duke@1 1851 if (typesSkip.get(t.tsym) != null) return;
duke@1 1852 if (typeMap.put(t.tsym, t) == null) {
duke@1 1853 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1854 for (Type i : types.interfaces(t))
duke@1 1855 closure(i, typesSkip, typeMap);
duke@1 1856 }
duke@1 1857 }
duke@1 1858
duke@1 1859 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1860 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1861 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1862 Symbol s1 = e1.sym;
duke@1 1863 Type st1 = null;
mcimadamore@1441 1864 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1865 (s1.flags() & SYNTHETIC) != 0) continue;
duke@1 1866 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1867 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1868 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1869 Symbol s2 = e2.sym;
duke@1 1870 if (s1 == s2) continue;
mcimadamore@1441 1871 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1872 (s2.flags() & SYNTHETIC) != 0) continue;
duke@1 1873 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1874 Type st2 = types.memberType(t2, s2);
duke@1 1875 if (types.overrideEquivalent(st1, st2)) {
duke@1 1876 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1877 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1878 Type rt1 = st1.getReturnType();
duke@1 1879 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1880 boolean compat =
duke@1 1881 types.isSameType(rt1, rt2) ||
jjg@1374 1882 !rt1.isPrimitiveOrVoid() &&
jjg@1374 1883 !rt2.isPrimitiveOrVoid() &&
mcimadamore@1415 1884 (types.covariantReturnType(rt1, rt2, types.noWarnings) ||
mcimadamore@1415 1885 types.covariantReturnType(rt2, rt1, types.noWarnings)) ||
mcimadamore@59 1886 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1887 if (!compat) {
mcimadamore@746 1888 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1889 t1, t2, s2.name +
mcimadamore@746 1890 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1891 return s2;
mcimadamore@746 1892 }
mcimadamore@889 1893 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1894 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1895 log.error(pos,
mcimadamore@746 1896 "name.clash.same.erasure.no.override",
mcimadamore@746 1897 s1, s1.location(),
mcimadamore@746 1898 s2, s2.location());
mcimadamore@746 1899 return s2;
duke@1 1900 }
duke@1 1901 }
duke@1 1902 }
duke@1 1903 return null;
duke@1 1904 }
mcimadamore@59 1905 //WHERE
mcimadamore@59 1906 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1907 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1908 Type st1 = types.memberType(site, s1);
mcimadamore@59 1909 Type st2 = types.memberType(site, s2);
mcimadamore@59 1910 closure(site, supertypes);
mcimadamore@59 1911 for (Type t : supertypes.values()) {
mcimadamore@59 1912 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1913 Symbol s3 = e.sym;
mcimadamore@59 1914 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1915 Type st3 = types.memberType(site,s3);
mcimadamore@1811 1916 if (types.overrideEquivalent(st3, st1) &&
mcimadamore@1811 1917 types.overrideEquivalent(st3, st2) &&
mcimadamore@1811 1918 types.returnTypeSubstitutable(st3, st1) &&
mcimadamore@1811 1919 types.returnTypeSubstitutable(st3, st2)) {
mcimadamore@1811 1920 return true;
mcimadamore@59 1921 }
mcimadamore@59 1922 }
mcimadamore@59 1923 }
mcimadamore@59 1924 return false;
mcimadamore@59 1925 }
duke@1 1926
duke@1 1927 /** Check that a given method conforms with any method it overrides.
duke@1 1928 * @param tree The tree from which positions are extracted
duke@1 1929 * for errors.
duke@1 1930 * @param m The overriding method.
duke@1 1931 */
jlahoda@2111 1932 void checkOverride(JCMethodDecl tree, MethodSymbol m) {
duke@1 1933 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1934 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1935 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1936 log.error(tree.pos(), "enum.no.finalize");
duke@1 1937 return;
duke@1 1938 }
jjg@1374 1939 for (Type t = origin.type; t.hasTag(CLASS);
duke@1 1940 t = types.supertype(t)) {
mcimadamore@746 1941 if (t != origin.type) {
mcimadamore@746 1942 checkOverride(tree, t, origin, m);
mcimadamore@746 1943 }
mcimadamore@746 1944 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1945 checkOverride(tree, t2, origin, m);
duke@1 1946 }
duke@1 1947 }
jlahoda@2111 1948
jlahoda@2111 1949 if (m.attribute(syms.overrideType.tsym) != null && !isOverrider(m)) {
jlahoda@2111 1950 DiagnosticPosition pos = tree.pos();
jlahoda@2111 1951 for (JCAnnotation a : tree.getModifiers().annotations) {
jlahoda@2111 1952 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
jlahoda@2111 1953 pos = a.pos();
jlahoda@2111 1954 break;
jlahoda@2111 1955 }
jlahoda@2111 1956 }
jlahoda@2111 1957 log.error(pos, "method.does.not.override.superclass");
jlahoda@2111 1958 }
duke@1 1959 }
duke@1 1960
mcimadamore@746 1961 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1962 TypeSymbol c = site.tsym;
mcimadamore@746 1963 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1964 while (e.scope != null) {
mcimadamore@746 1965 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1966 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1967 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1968 }
mcimadamore@746 1969 }
mcimadamore@746 1970 e = e.next();
mcimadamore@746 1971 }
mcimadamore@746 1972 }
mcimadamore@746 1973
vromero@1607 1974 private Filter<Symbol> equalsHasCodeFilter = new Filter<Symbol>() {
vromero@1607 1975 public boolean accepts(Symbol s) {
vromero@1607 1976 return MethodSymbol.implementation_filter.accepts(s) &&
vromero@1607 1977 (s.flags() & BAD_OVERRIDE) == 0;
vromero@1607 1978
vromero@1607 1979 }
vromero@1607 1980 };
vromero@1607 1981
vromero@1620 1982 public void checkClassOverrideEqualsAndHashIfNeeded(DiagnosticPosition pos,
vromero@1620 1983 ClassSymbol someClass) {
vromero@1620 1984 /* At present, annotations cannot possibly have a method that is override
vromero@1620 1985 * equivalent with Object.equals(Object) but in any case the condition is
vromero@1620 1986 * fine for completeness.
vromero@1620 1987 */
vromero@1620 1988 if (someClass == (ClassSymbol)syms.objectType.tsym ||
vromero@1620 1989 someClass.isInterface() || someClass.isEnum() ||
vromero@1620 1990 (someClass.flags() & ANNOTATION) != 0 ||
vromero@1620 1991 (someClass.flags() & ABSTRACT) != 0) return;
vromero@1620 1992 //anonymous inner classes implementing interfaces need especial treatment
vromero@1620 1993 if (someClass.isAnonymous()) {
vromero@1620 1994 List<Type> interfaces = types.interfaces(someClass.type);
vromero@1620 1995 if (interfaces != null && !interfaces.isEmpty() &&
vromero@1620 1996 interfaces.head.tsym == syms.comparatorType.tsym) return;
vromero@1620 1997 }
vromero@1620 1998 checkClassOverrideEqualsAndHash(pos, someClass);
vromero@1620 1999 }
vromero@1620 2000
vromero@1620 2001 private void checkClassOverrideEqualsAndHash(DiagnosticPosition pos,
vromero@1607 2002 ClassSymbol someClass) {
vromero@1588 2003 if (lint.isEnabled(LintCategory.OVERRIDES)) {
vromero@1607 2004 MethodSymbol equalsAtObject = (MethodSymbol)syms.objectType
vromero@1607 2005 .tsym.members().lookup(names.equals).sym;
vromero@1607 2006 MethodSymbol hashCodeAtObject = (MethodSymbol)syms.objectType
vromero@1607 2007 .tsym.members().lookup(names.hashCode).sym;
vromero@1607 2008 boolean overridesEquals = types.implementation(equalsAtObject,
vromero@1607 2009 someClass, false, equalsHasCodeFilter).owner == someClass;
vromero@1607 2010 boolean overridesHashCode = types.implementation(hashCodeAtObject,
vromero@1607 2011 someClass, false, equalsHasCodeFilter) != hashCodeAtObject;
vromero@1607 2012
vromero@1607 2013 if (overridesEquals && !overridesHashCode) {
vromero@1607 2014 log.warning(LintCategory.OVERRIDES, pos,
vromero@1620 2015 "override.equals.but.not.hashcode", someClass);
vromero@1588 2016 }
vromero@1588 2017 }
vromero@1588 2018 }
vromero@1588 2019
mcimadamore@746 2020 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 2021 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 2022 return (cf.accepts(s1) &&
mcimadamore@858 2023 cf.accepts(s2) &&
mcimadamore@858 2024 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 2025 }
mcimadamore@746 2026
mcimadamore@746 2027
duke@1 2028 /** Check that all abstract members of given class have definitions.
duke@1 2029 * @param pos Position to be used for error reporting.
duke@1 2030 * @param c The class.
duke@1 2031 */
duke@1 2032 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2033 try {
duke@1 2034 MethodSymbol undef = firstUndef(c, c);
duke@1 2035 if (undef != null) {
duke@1 2036 if ((c.flags() & ENUM) != 0 &&
duke@1 2037 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 2038 (c.flags() & FINAL) == 0) {
duke@1 2039 // add the ABSTRACT flag to an enum
duke@1 2040 c.flags_field |= ABSTRACT;
duke@1 2041 } else {
duke@1 2042 MethodSymbol undef1 =
duke@1 2043 new MethodSymbol(undef.flags(), undef.name,
duke@1 2044 types.memberType(c.type, undef), undef.owner);
duke@1 2045 log.error(pos, "does.not.override.abstract",
duke@1 2046 c, undef1, undef1.location());
duke@1 2047 }
duke@1 2048 }
duke@1 2049 } catch (CompletionFailure ex) {
duke@1 2050 completionError(pos, ex);
duke@1 2051 }
duke@1 2052 }
duke@1 2053 //where
duke@1 2054 /** Return first abstract member of class `c' that is not defined
duke@1 2055 * in `impl', null if there is none.
duke@1 2056 */
duke@1 2057 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 2058 MethodSymbol undef = null;
duke@1 2059 // Do not bother to search in classes that are not abstract,
duke@1 2060 // since they cannot have abstract members.
duke@1 2061 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 2062 Scope s = c.members();
duke@1 2063 for (Scope.Entry e = s.elems;
duke@1 2064 undef == null && e != null;
duke@1 2065 e = e.sibling) {
duke@1 2066 if (e.sym.kind == MTH &&
mcimadamore@1393 2067 (e.sym.flags() & (ABSTRACT|IPROXY|DEFAULT)) == ABSTRACT) {
duke@1 2068 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2069 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
mcimadamore@1393 2070 if (implmeth == null || implmeth == absmeth) {
mcimadamore@1393 2071 //look for default implementations
mcimadamore@1393 2072 if (allowDefaultMethods) {
mcimadamore@1393 2073 MethodSymbol prov = types.interfaceCandidates(impl.type, absmeth).head;
mcimadamore@1393 2074 if (prov != null && prov.overrides(absmeth, impl, types, true)) {
mcimadamore@1393 2075 implmeth = prov;
mcimadamore@1393 2076 }
mcimadamore@1393 2077 }
mcimadamore@1393 2078 }
mcimadamore@1393 2079 if (implmeth == null || implmeth == absmeth) {
duke@1 2080 undef = absmeth;
mcimadamore@1393 2081 }
duke@1 2082 }
duke@1 2083 }
duke@1 2084 if (undef == null) {
duke@1 2085 Type st = types.supertype(c.type);
jjg@1374 2086 if (st.hasTag(CLASS))
duke@1 2087 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 2088 }
duke@1 2089 for (List<Type> l = types.interfaces(c.type);
duke@1 2090 undef == null && l.nonEmpty();
duke@1 2091 l = l.tail) {
duke@1 2092 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 2093 }
duke@1 2094 }
duke@1 2095 return undef;
duke@1 2096 }
duke@1 2097
mcimadamore@690 2098 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 2099 CycleChecker cc = new CycleChecker();
mcimadamore@690 2100 cc.scan(tree);
mcimadamore@690 2101 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 2102 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 2103 }
mcimadamore@690 2104 }
mcimadamore@690 2105
mcimadamore@690 2106 class CycleChecker extends TreeScanner {
mcimadamore@690 2107
mcimadamore@690 2108 List<Symbol> seenClasses = List.nil();
mcimadamore@690 2109 boolean errorFound = false;
mcimadamore@690 2110 boolean partialCheck = false;
mcimadamore@690 2111
mcimadamore@690 2112 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 2113 if (sym != null && sym.kind == TYP) {
mcimadamore@690 2114 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 2115 if (classEnv != null) {
mcimadamore@690 2116 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2117 try {
mcimadamore@690 2118 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2119 scan(classEnv.tree);
mcimadamore@690 2120 }
mcimadamore@690 2121 finally {
mcimadamore@690 2122 log.useSource(prevSource.getFile());
mcimadamore@690 2123 }
mcimadamore@690 2124 } else if (sym.kind == TYP) {
mcimadamore@690 2125 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2126 }
mcimadamore@690 2127 } else {
mcimadamore@690 2128 //not completed yet
mcimadamore@690 2129 partialCheck = true;
mcimadamore@690 2130 }
mcimadamore@690 2131 }
mcimadamore@690 2132
mcimadamore@690 2133 @Override
mcimadamore@690 2134 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2135 super.visitSelect(tree);
mcimadamore@690 2136 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2137 }
mcimadamore@690 2138
mcimadamore@690 2139 @Override
mcimadamore@690 2140 public void visitIdent(JCIdent tree) {
mcimadamore@690 2141 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2142 }
mcimadamore@690 2143
mcimadamore@690 2144 @Override
mcimadamore@690 2145 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2146 scan(tree.clazz);
mcimadamore@690 2147 }
mcimadamore@690 2148
mcimadamore@690 2149 @Override
mcimadamore@690 2150 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2151 scan(tree.elemtype);
mcimadamore@690 2152 }
mcimadamore@690 2153
mcimadamore@690 2154 @Override
mcimadamore@690 2155 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2156 List<JCTree> supertypes = List.nil();
mcimadamore@690 2157 if (tree.getExtendsClause() != null) {
mcimadamore@690 2158 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2159 }
mcimadamore@690 2160 if (tree.getImplementsClause() != null) {
mcimadamore@690 2161 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2162 supertypes = supertypes.prepend(intf);
mcimadamore@690 2163 }
mcimadamore@690 2164 }
mcimadamore@690 2165 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2166 }
mcimadamore@690 2167
mcimadamore@690 2168 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2169 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2170 return;
mcimadamore@690 2171 if (seenClasses.contains(c)) {
mcimadamore@690 2172 errorFound = true;
mcimadamore@690 2173 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2174 } else if (!c.type.isErroneous()) {
mcimadamore@690 2175 try {
mcimadamore@690 2176 seenClasses = seenClasses.prepend(c);
jjg@1374 2177 if (c.type.hasTag(CLASS)) {
mcimadamore@690 2178 if (supertypes.nonEmpty()) {
mcimadamore@690 2179 scan(supertypes);
mcimadamore@690 2180 }
mcimadamore@690 2181 else {
mcimadamore@690 2182 ClassType ct = (ClassType)c.type;
mcimadamore@690 2183 if (ct.supertype_field == null ||
mcimadamore@690 2184 ct.interfaces_field == null) {
mcimadamore@690 2185 //not completed yet
mcimadamore@690 2186 partialCheck = true;
mcimadamore@690 2187 return;
mcimadamore@690 2188 }
mcimadamore@690 2189 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2190 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2191 checkSymbol(pos, intf.tsym);
mcimadamore@690 2192 }
mcimadamore@690 2193 }
mcimadamore@690 2194 if (c.owner.kind == TYP) {
mcimadamore@690 2195 checkSymbol(pos, c.owner);
mcimadamore@690 2196 }
mcimadamore@690 2197 }
mcimadamore@690 2198 } finally {
mcimadamore@690 2199 seenClasses = seenClasses.tail;
mcimadamore@690 2200 }
mcimadamore@690 2201 }
mcimadamore@690 2202 }
mcimadamore@690 2203 }
mcimadamore@690 2204
duke@1 2205 /** Check for cyclic references. Issue an error if the
duke@1 2206 * symbol of the type referred to has a LOCKED flag set.
duke@1 2207 *
duke@1 2208 * @param pos Position to be used for error reporting.
duke@1 2209 * @param t The type referred to.
duke@1 2210 */
duke@1 2211 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2212 checkNonCyclicInternal(pos, t);
duke@1 2213 }
duke@1 2214
duke@1 2215
duke@1 2216 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2217 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2218 }
duke@1 2219
mcimadamore@236 2220 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2221 final TypeVar tv;
jjg@1374 2222 if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2223 return;
duke@1 2224 if (seen.contains(t)) {
jjg@1978 2225 tv = (TypeVar)t.unannotatedType();
jjg@110 2226 tv.bound = types.createErrorType(t);
duke@1 2227 log.error(pos, "cyclic.inheritance", t);
jjg@1374 2228 } else if (t.hasTag(TYPEVAR)) {
jjg@1978 2229 tv = (TypeVar)t.unannotatedType();
mcimadamore@236 2230 seen = seen.prepend(tv);
duke@1 2231 for (Type b : types.getBounds(tv))
duke@1 2232 checkNonCyclic1(pos, b, seen);
duke@1 2233 }
duke@1 2234 }
duke@1 2235
duke@1 2236 /** Check for cyclic references. Issue an error if the
duke@1 2237 * symbol of the type referred to has a LOCKED flag set.
duke@1 2238 *
duke@1 2239 * @param pos Position to be used for error reporting.
duke@1 2240 * @param t The type referred to.
duke@1 2241 * @returns True if the check completed on all attributed classes
duke@1 2242 */
duke@1 2243 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2244 boolean complete = true; // was the check complete?
duke@1 2245 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2246 Symbol c = t.tsym;
duke@1 2247 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2248
duke@1 2249 if ((c.flags_field & LOCKED) != 0) {
duke@1 2250 noteCyclic(pos, (ClassSymbol)c);
duke@1 2251 } else if (!c.type.isErroneous()) {
duke@1 2252 try {
duke@1 2253 c.flags_field |= LOCKED;
jjg@1374 2254 if (c.type.hasTag(CLASS)) {
duke@1 2255 ClassType clazz = (ClassType)c.type;
duke@1 2256 if (clazz.interfaces_field != null)
duke@1 2257 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2258 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2259 if (clazz.supertype_field != null) {
duke@1 2260 Type st = clazz.supertype_field;
jjg@1374 2261 if (st != null && st.hasTag(CLASS))
duke@1 2262 complete &= checkNonCyclicInternal(pos, st);
duke@1 2263 }
duke@1 2264 if (c.owner.kind == TYP)
duke@1 2265 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2266 }
duke@1 2267 } finally {
duke@1 2268 c.flags_field &= ~LOCKED;
duke@1 2269 }
duke@1 2270 }
duke@1 2271 if (complete)
duke@1 2272 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2273 if (complete) c.flags_field |= ACYCLIC;
duke@1 2274 return complete;
duke@1 2275 }
duke@1 2276
duke@1 2277 /** Note that we found an inheritance cycle. */
duke@1 2278 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2279 log.error(pos, "cyclic.inheritance", c);
duke@1 2280 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2281 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2282 Type st = types.supertype(c.type);
jjg@1374 2283 if (st.hasTag(CLASS))
jjg@110 2284 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2285 c.type = types.createErrorType(c, c.type);
duke@1 2286 c.flags_field |= ACYCLIC;
duke@1 2287 }
duke@1 2288
duke@1 2289 /** Check that all methods which implement some
duke@1 2290 * method conform to the method they implement.
duke@1 2291 * @param tree The class definition whose members are checked.
duke@1 2292 */
duke@1 2293 void checkImplementations(JCClassDecl tree) {
mcimadamore@1415 2294 checkImplementations(tree, tree.sym, tree.sym);
duke@1 2295 }
jjg@1521 2296 //where
duke@1 2297 /** Check that all methods which implement some
duke@1 2298 * method in `ic' conform to the method they implement.
duke@1 2299 */
mcimadamore@1415 2300 void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) {
duke@1 2301 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2302 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2303 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2304 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2305 if (e.sym.kind == MTH &&
duke@1 2306 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2307 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2308 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2309 if (implmeth != null && implmeth != absmeth &&
duke@1 2310 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2311 (origin.flags() & INTERFACE)) {
duke@1 2312 // don't check if implmeth is in a class, yet
duke@1 2313 // origin is an interface. This case arises only
duke@1 2314 // if implmeth is declared in Object. The reason is
duke@1 2315 // that interfaces really don't inherit from
duke@1 2316 // Object it's just that the compiler represents
duke@1 2317 // things that way.
duke@1 2318 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2319 }
duke@1 2320 }
duke@1 2321 }
duke@1 2322 }
duke@1 2323 }
duke@1 2324 }
duke@1 2325
duke@1 2326 /** Check that all abstract methods implemented by a class are
duke@1 2327 * mutually compatible.
duke@1 2328 * @param pos Position to be used for error reporting.
duke@1 2329 * @param c The class whose interfaces are checked.
duke@1 2330 */
duke@1 2331 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2332 List<Type> supertypes = types.interfaces(c);
duke@1 2333 Type supertype = types.supertype(c);
jjg@1374 2334 if (supertype.hasTag(CLASS) &&
duke@1 2335 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2336 supertypes = supertypes.prepend(supertype);
duke@1 2337 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2338 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2339 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2340 return;
duke@1 2341 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2342 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2343 return;
duke@1 2344 }
duke@1 2345 checkCompatibleConcretes(pos, c);
duke@1 2346 }
duke@1 2347
mcimadamore@359 2348 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2349 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2350 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2351 // VM allows methods and variables with differing types
mcimadamore@359 2352 if (sym.kind == e.sym.kind &&
mcimadamore@359 2353 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2354 sym != e.sym &&
mcimadamore@359 2355 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2356 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2357 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2358 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2359 return;
mcimadamore@359 2360 }
mcimadamore@359 2361 }
mcimadamore@359 2362 }
mcimadamore@359 2363 }
mcimadamore@359 2364
mcimadamore@780 2365 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2366 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2367 *
mcimadamore@780 2368 * @param pos Position to be used for error reporting.
mcimadamore@780 2369 * @param site The class whose methods are checked.
mcimadamore@780 2370 * @param sym The method symbol to be checked.
mcimadamore@780 2371 */
mcimadamore@858 2372 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2373 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2374 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2375 //by method 'sym' in 'site'...
vromero@2118 2376
vromero@2118 2377 List<MethodSymbol> potentiallyAmbiguousList = List.nil();
vromero@2118 2378 boolean overridesAny = false;
mcimadamore@1198 2379 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
vromero@2118 2380 if (!sym.overrides(m1, site.tsym, types, false)) {
vromero@2118 2381 if (m1 == sym) {
vromero@2118 2382 continue;
vromero@2118 2383 }
vromero@2118 2384
vromero@2118 2385 if (!overridesAny) {
vromero@2118 2386 potentiallyAmbiguousList = potentiallyAmbiguousList.prepend((MethodSymbol)m1);
vromero@2118 2387 }
vromero@2118 2388 continue;
vromero@2118 2389 }
vromero@2118 2390
vromero@2118 2391 if (m1 != sym) {
vromero@2118 2392 overridesAny = true;
vromero@2118 2393 potentiallyAmbiguousList = List.nil();
vromero@2118 2394 }
vromero@2118 2395
vromero@2118 2396 //...check each method m2 that is a member of 'site'
vromero@2118 2397 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2398 if (m2 == m1) continue;
mcimadamore@858 2399 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2400 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1393 2401 if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) &&
mcimadamore@1198 2402 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2403 sym.flags_field |= CLASH;
mcimadamore@1198 2404 String key = m1 == sym ?
mcimadamore@858 2405 "name.clash.same.erasure.no.override" :
mcimadamore@858 2406 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2407 log.error(pos,
mcimadamore@858 2408 key,
mcimadamore@858 2409 sym, sym.location(),
mcimadamore@1198 2410 m2, m2.location(),
mcimadamore@1198 2411 m1, m1.location());
mcimadamore@858 2412 return;
mcimadamore@858 2413 }
mcimadamore@780 2414 }
mcimadamore@780 2415 }
vromero@2118 2416
vromero@2118 2417 if (!overridesAny) {
vromero@2118 2418 for (MethodSymbol m: potentiallyAmbiguousList) {
vromero@2118 2419 checkPotentiallyAmbiguousOverloads(pos, site, sym, m);
vromero@2118 2420 }
vromero@2118 2421 }
mcimadamore@780 2422 }
mcimadamore@780 2423
mcimadamore@858 2424 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2425 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2426 *
mcimadamore@858 2427 * @param pos Position to be used for error reporting.
mcimadamore@858 2428 * @param site The class whose methods are checked.
mcimadamore@858 2429 * @param sym The method symbol to be checked.
mcimadamore@780 2430 */
mcimadamore@858 2431 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2432 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2433 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2434 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2435 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2436 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
vromero@2000 2437 if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck)) {
vromero@2000 2438 if (types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
vromero@2000 2439 log.error(pos,
vromero@2000 2440 "name.clash.same.erasure.no.hide",
vromero@2000 2441 sym, sym.location(),
vromero@2000 2442 s, s.location());
vromero@2000 2443 return;
vromero@2000 2444 } else {
vromero@2000 2445 checkPotentiallyAmbiguousOverloads(pos, site, sym, (MethodSymbol)s);
vromero@2000 2446 }
vromero@2000 2447 }
mcimadamore@858 2448 }
mcimadamore@858 2449 }
mcimadamore@780 2450
mcimadamore@858 2451 //where
mcimadamore@858 2452 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2453
mcimadamore@858 2454 Type site;
mcimadamore@780 2455
mcimadamore@858 2456 ClashFilter(Type site) {
mcimadamore@858 2457 this.site = site;
mcimadamore@858 2458 }
mcimadamore@858 2459
mcimadamore@858 2460 boolean shouldSkip(Symbol s) {
mcimadamore@858 2461 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2462 s.owner == site.tsym;
mcimadamore@858 2463 }
mcimadamore@858 2464
mcimadamore@858 2465 public boolean accepts(Symbol s) {
mcimadamore@858 2466 return s.kind == MTH &&
mcimadamore@858 2467 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2468 !shouldSkip(s) &&
mcimadamore@858 2469 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2470 !s.isConstructor();
mcimadamore@858 2471 }
mcimadamore@858 2472 }
mcimadamore@780 2473
mcimadamore@1393 2474 void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) {
mcimadamore@1393 2475 DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site);
mcimadamore@1393 2476 for (Symbol m : types.membersClosure(site, false).getElements(dcf)) {
mcimadamore@1393 2477 Assert.check(m.kind == MTH);
mcimadamore@1393 2478 List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m);
mcimadamore@1393 2479 if (prov.size() > 1) {
alundblad@2047 2480 ListBuffer<Symbol> abstracts = new ListBuffer<>();
alundblad@2047 2481 ListBuffer<Symbol> defaults = new ListBuffer<>();
mcimadamore@1393 2482 for (MethodSymbol provSym : prov) {
mcimadamore@1393 2483 if ((provSym.flags() & DEFAULT) != 0) {
mcimadamore@1393 2484 defaults = defaults.append(provSym);
mcimadamore@1393 2485 } else if ((provSym.flags() & ABSTRACT) != 0) {
mcimadamore@1393 2486 abstracts = abstracts.append(provSym);
mcimadamore@1393 2487 }
mcimadamore@1393 2488 if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) {
mcimadamore@1393 2489 //strong semantics - issue an error if two sibling interfaces
mcimadamore@1393 2490 //have two override-equivalent defaults - or if one is abstract
mcimadamore@1393 2491 //and the other is default
mcimadamore@1393 2492 String errKey;
mcimadamore@1393 2493 Symbol s1 = defaults.first();
mcimadamore@1393 2494 Symbol s2;
mcimadamore@1393 2495 if (defaults.size() > 1) {
mcimadamore@1393 2496 errKey = "types.incompatible.unrelated.defaults";
mcimadamore@1393 2497 s2 = defaults.toList().tail.head;
mcimadamore@1393 2498 } else {
mcimadamore@1393 2499 errKey = "types.incompatible.abstract.default";
mcimadamore@1393 2500 s2 = abstracts.first();
mcimadamore@1393 2501 }
mcimadamore@1393 2502 log.error(pos, errKey,
mcimadamore@1393 2503 Kinds.kindName(site.tsym), site,
mcimadamore@1393 2504 m.name, types.memberType(site, m).getParameterTypes(),
mcimadamore@1393 2505 s1.location(), s2.location());
mcimadamore@1393 2506 break;
mcimadamore@1393 2507 }
mcimadamore@1393 2508 }
mcimadamore@1393 2509 }
mcimadamore@1393 2510 }
mcimadamore@1393 2511 }
mcimadamore@1393 2512
mcimadamore@1393 2513 //where
mcimadamore@1393 2514 private class DefaultMethodClashFilter implements Filter<Symbol> {
mcimadamore@1393 2515
mcimadamore@1393 2516 Type site;
mcimadamore@1393 2517
mcimadamore@1393 2518 DefaultMethodClashFilter(Type site) {
mcimadamore@1393 2519 this.site = site;
mcimadamore@1393 2520 }
mcimadamore@1393 2521
mcimadamore@1393 2522 public boolean accepts(Symbol s) {
mcimadamore@1393 2523 return s.kind == MTH &&
mcimadamore@1393 2524 (s.flags() & DEFAULT) != 0 &&
mcimadamore@1393 2525 s.isInheritedIn(site.tsym, types) &&
mcimadamore@1393 2526 !s.isConstructor();
mcimadamore@1393 2527 }
mcimadamore@1393 2528 }
mcimadamore@1393 2529
vromero@2000 2530 /**
vromero@2000 2531 * Report warnings for potentially ambiguous method declarations. Two declarations
vromero@2000 2532 * are potentially ambiguous if they feature two unrelated functional interface
vromero@2000 2533 * in same argument position (in which case, a call site passing an implicit
vromero@2000 2534 * lambda would be ambiguous).
vromero@2000 2535 */
vromero@2000 2536 void checkPotentiallyAmbiguousOverloads(DiagnosticPosition pos, Type site,
vromero@2000 2537 MethodSymbol msym1, MethodSymbol msym2) {
vromero@2000 2538 if (msym1 != msym2 &&
vromero@2000 2539 allowDefaultMethods &&
vromero@2000 2540 lint.isEnabled(LintCategory.OVERLOADS) &&
vromero@2000 2541 (msym1.flags() & POTENTIALLY_AMBIGUOUS) == 0 &&
vromero@2000 2542 (msym2.flags() & POTENTIALLY_AMBIGUOUS) == 0) {
vromero@2000 2543 Type mt1 = types.memberType(site, msym1);
vromero@2000 2544 Type mt2 = types.memberType(site, msym2);
vromero@2000 2545 //if both generic methods, adjust type variables
vromero@2000 2546 if (mt1.hasTag(FORALL) && mt2.hasTag(FORALL) &&
vromero@2000 2547 types.hasSameBounds((ForAll)mt1, (ForAll)mt2)) {
vromero@2000 2548 mt2 = types.subst(mt2, ((ForAll)mt2).tvars, ((ForAll)mt1).tvars);
vromero@2000 2549 }
vromero@2000 2550 //expand varargs methods if needed
vromero@2000 2551 int maxLength = Math.max(mt1.getParameterTypes().length(), mt2.getParameterTypes().length());
vromero@2000 2552 List<Type> args1 = rs.adjustArgs(mt1.getParameterTypes(), msym1, maxLength, true);
vromero@2000 2553 List<Type> args2 = rs.adjustArgs(mt2.getParameterTypes(), msym2, maxLength, true);
vromero@2000 2554 //if arities don't match, exit
vromero@2000 2555 if (args1.length() != args2.length()) return;
vromero@2000 2556 boolean potentiallyAmbiguous = false;
vromero@2000 2557 while (args1.nonEmpty() && args2.nonEmpty()) {
vromero@2000 2558 Type s = args1.head;
vromero@2000 2559 Type t = args2.head;
vromero@2000 2560 if (!types.isSubtype(t, s) && !types.isSubtype(s, t)) {
vromero@2000 2561 if (types.isFunctionalInterface(s) && types.isFunctionalInterface(t) &&
vromero@2000 2562 types.findDescriptorType(s).getParameterTypes().length() > 0 &&
vromero@2000 2563 types.findDescriptorType(s).getParameterTypes().length() ==
vromero@2000 2564 types.findDescriptorType(t).getParameterTypes().length()) {
vromero@2000 2565 potentiallyAmbiguous = true;
vromero@2000 2566 } else {
vromero@2000 2567 break;
vromero@2000 2568 }
vromero@2000 2569 }
vromero@2000 2570 args1 = args1.tail;
vromero@2000 2571 args2 = args2.tail;
vromero@2000 2572 }
vromero@2000 2573 if (potentiallyAmbiguous) {
vromero@2000 2574 //we found two incompatible functional interfaces with same arity
vromero@2000 2575 //this means a call site passing an implicit lambda would be ambigiuous
vromero@2000 2576 msym1.flags_field |= POTENTIALLY_AMBIGUOUS;
vromero@2000 2577 msym2.flags_field |= POTENTIALLY_AMBIGUOUS;
vromero@2000 2578 log.warning(LintCategory.OVERLOADS, pos, "potentially.ambiguous.overload",
vromero@2000 2579 msym1, msym1.location(),
vromero@2000 2580 msym2, msym2.location());
vromero@2000 2581 return;
vromero@2000 2582 }
vromero@2000 2583 }
vromero@2000 2584 }
vromero@2000 2585
mcimadamore@359 2586 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2587 */
mcimadamore@359 2588 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2589 if (!sym.type.isErroneous()) {
mcimadamore@359 2590 if (warnOnSyntheticConflicts) {
mcimadamore@359 2591 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2592 }
mcimadamore@359 2593 else {
mcimadamore@359 2594 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2595 }
mcimadamore@359 2596 }
mcimadamore@359 2597 }
mcimadamore@359 2598
duke@1 2599 /** Check that class c does not implement directly or indirectly
duke@1 2600 * the same parameterized interface with two different argument lists.
duke@1 2601 * @param pos Position to be used for error reporting.
duke@1 2602 * @param type The type whose interfaces are checked.
duke@1 2603 */
duke@1 2604 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2605 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2606 }
duke@1 2607 //where
duke@1 2608 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2609 * with their class symbol as key and their type as value. Make
duke@1 2610 * sure no class is entered with two different types.
duke@1 2611 */
duke@1 2612 void checkClassBounds(DiagnosticPosition pos,
duke@1 2613 Map<TypeSymbol,Type> seensofar,
duke@1 2614 Type type) {
duke@1 2615 if (type.isErroneous()) return;
duke@1 2616 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2617 Type it = l.head;
duke@1 2618 Type oldit = seensofar.put(it.tsym, it);
duke@1 2619 if (oldit != null) {
duke@1 2620 List<Type> oldparams = oldit.allparams();
duke@1 2621 List<Type> newparams = it.allparams();
duke@1 2622 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2623 log.error(pos, "cant.inherit.diff.arg",
duke@1 2624 it.tsym, Type.toString(oldparams),
duke@1 2625 Type.toString(newparams));
duke@1 2626 }
duke@1 2627 checkClassBounds(pos, seensofar, it);
duke@1 2628 }
duke@1 2629 Type st = types.supertype(type);
duke@1 2630 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2631 }
duke@1 2632
duke@1 2633 /** Enter interface into into set.
duke@1 2634 * If it existed already, issue a "repeated interface" error.
duke@1 2635 */
duke@1 2636 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2637 if (its.contains(it))
duke@1 2638 log.error(pos, "repeated.interface");
duke@1 2639 else {
duke@1 2640 its.add(it);
duke@1 2641 }
duke@1 2642 }
duke@1 2643
duke@1 2644 /* *************************************************************************
duke@1 2645 * Check annotations
duke@1 2646 **************************************************************************/
duke@1 2647
mcimadamore@629 2648 /**
mcimadamore@634 2649 * Recursively validate annotations values
mcimadamore@629 2650 */
mcimadamore@634 2651 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2652 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2653 @Override
mcimadamore@629 2654 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2655 if (!tree.type.isErroneous()) {
jjg@1017 2656 super.visitAnnotation(tree);
jjg@1017 2657 validateAnnotation(tree);
jjg@1017 2658 }
mcimadamore@629 2659 }
mcimadamore@629 2660 }
mcimadamore@634 2661 tree.accept(new AnnotationValidator());
mcimadamore@629 2662 }
mcimadamore@629 2663
jjg@1326 2664 /**
jjg@1326 2665 * {@literal
jjg@1326 2666 * Annotation types are restricted to primitives, String, an
duke@1 2667 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2668 * Anything>, arrays of the preceding.
jjg@1326 2669 * }
duke@1 2670 */
duke@1 2671 void validateAnnotationType(JCTree restype) {
duke@1 2672 // restype may be null if an error occurred, so don't bother validating it
duke@1 2673 if (restype != null) {
duke@1 2674 validateAnnotationType(restype.pos(), restype.type);
duke@1 2675 }
duke@1 2676 }
duke@1 2677
duke@1 2678 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2679 if (type.isPrimitive()) return;
duke@1 2680 if (types.isSameType(type, syms.stringType)) return;
duke@1 2681 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2682 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2683 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2684 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2685 validateAnnotationType(pos, types.elemtype(type));
duke@1 2686 return;
duke@1 2687 }
duke@1 2688 log.error(pos, "invalid.annotation.member.type");
duke@1 2689 }
duke@1 2690
duke@1 2691 /**
duke@1 2692 * "It is also a compile-time error if any method declared in an
duke@1 2693 * annotation type has a signature that is override-equivalent to
duke@1 2694 * that of any public or protected method declared in class Object
duke@1 2695 * or in the interface annotation.Annotation."
duke@1 2696 *
jjh@972 2697 * @jls 9.6 Annotation Types
duke@1 2698 */
duke@1 2699 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
jjg@1374 2700 for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
duke@1 2701 Scope s = sup.tsym.members();
duke@1 2702 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2703 if (e.sym.kind == MTH &&
duke@1 2704 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2705 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2706 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2707 }
duke@1 2708 }
duke@1 2709 }
duke@1 2710
duke@1 2711 /** Check the annotations of a symbol.
duke@1 2712 */
duke@1 2713 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2714 for (JCAnnotation a : annotations)
duke@1 2715 validateAnnotation(a, s);
duke@1 2716 }
duke@1 2717
jjg@1521 2718 /** Check the type annotations.
jjg@1521 2719 */
jjg@1521 2720 public void validateTypeAnnotations(List<JCAnnotation> annotations, boolean isTypeParameter) {
jjg@1521 2721 for (JCAnnotation a : annotations)
jjg@1521 2722 validateTypeAnnotation(a, isTypeParameter);
jjg@1521 2723 }
jjg@1521 2724
duke@1 2725 /** Check an annotation of a symbol.
duke@1 2726 */
jfranck@1313 2727 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2728 validateAnnotationTree(a);
duke@1 2729
duke@1 2730 if (!annotationApplicable(a, s))
duke@1 2731 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2732
mcimadamore@1497 2733 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
mcimadamore@1497 2734 if (s.kind != TYP) {
mcimadamore@1497 2735 log.error(a.pos(), "bad.functional.intf.anno");
jlahoda@2111 2736 } else if (!s.isInterface() || (s.flags() & ANNOTATION) != 0) {
jlahoda@2111 2737 log.error(a.pos(), "bad.functional.intf.anno.1", diags.fragment("not.a.functional.intf", s));
mcimadamore@1497 2738 }
mcimadamore@1497 2739 }
duke@1 2740 }
duke@1 2741
jjg@1521 2742 public void validateTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2743 Assert.checkNonNull(a.type, "annotation tree hasn't been attributed yet: " + a);
jjg@1521 2744 validateAnnotationTree(a);
jjg@1521 2745
jjg@2134 2746 if (a.hasTag(TYPE_ANNOTATION) &&
jjg@2134 2747 !a.annotationType.type.isErroneous() &&
jjg@2134 2748 !isTypeAnnotation(a, isTypeParameter)) {
jjg@1521 2749 log.error(a.pos(), "annotation.type.not.applicable");
jjg@2134 2750 }
jjg@1521 2751 }
jjg@1521 2752
jfranck@1313 2753 /**
jjg@1492 2754 * Validate the proposed container 'repeatable' on the
jfranck@1313 2755 * annotation type symbol 's'. Report errors at position
jfranck@1313 2756 * 'pos'.
jfranck@1313 2757 *
jjg@1492 2758 * @param s The (annotation)type declaration annotated with a @Repeatable
jjg@1492 2759 * @param repeatable the @Repeatable on 's'
jfranck@1313 2760 * @param pos where to report errors
jfranck@1313 2761 */
jjg@1492 2762 public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) {
jjg@1492 2763 Assert.check(types.isSameType(repeatable.type, syms.repeatableType));
jfranck@1313 2764
jfranck@1313 2765 Type t = null;
jjg@1492 2766 List<Pair<MethodSymbol,Attribute>> l = repeatable.values;
jfranck@1313 2767 if (!l.isEmpty()) {
jfranck@1313 2768 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2769 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2770 }
jfranck@1313 2771
jfranck@1313 2772 if (t == null) {
jjg@1492 2773 // errors should already have been reported during Annotate
jfranck@1313 2774 return;
jfranck@1313 2775 }
jfranck@1313 2776
jjg@1492 2777 validateValue(t.tsym, s, pos);
jfranck@1313 2778 validateRetention(t.tsym, s, pos);
jfranck@1313 2779 validateDocumented(t.tsym, s, pos);
jfranck@1313 2780 validateInherited(t.tsym, s, pos);
jfranck@1313 2781 validateTarget(t.tsym, s, pos);
jfranck@2250 2782 validateDefault(t.tsym, pos);
jfranck@1313 2783 }
jfranck@1313 2784
jjg@1492 2785 private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jjg@1492 2786 Scope.Entry e = container.members().lookup(names.value);
jjg@1492 2787 if (e.scope != null && e.sym.kind == MTH) {
jjg@1492 2788 MethodSymbol m = (MethodSymbol) e.sym;
jjg@1492 2789 Type ret = m.getReturnType();
jjg@1492 2790 if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) {
jjg@1492 2791 log.error(pos, "invalid.repeatable.annotation.value.return",
jjg@1492 2792 container, ret, types.makeArrayType(contained.type));
jjg@1492 2793 }
jjg@1492 2794 } else {
jjg@1492 2795 log.error(pos, "invalid.repeatable.annotation.no.value", container);
jfranck@1313 2796 }
jfranck@1313 2797 }
jfranck@1313 2798
jfranck@1313 2799 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2800 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2801 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2802
jfranck@1313 2803 boolean error = false;
jfranck@1313 2804 switch (containedRetention) {
jfranck@1313 2805 case RUNTIME:
jfranck@1313 2806 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2807 error = true;
jfranck@1313 2808 }
jfranck@1313 2809 break;
jfranck@1313 2810 case CLASS:
jfranck@1313 2811 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2812 error = true;
jfranck@1313 2813 }
jfranck@1313 2814 }
jfranck@1313 2815 if (error ) {
jjg@1492 2816 log.error(pos, "invalid.repeatable.annotation.retention",
jfranck@1313 2817 container, containerRetention,
jfranck@1313 2818 contained, containedRetention);
jfranck@1313 2819 }
jfranck@1313 2820 }
jfranck@1313 2821
jfranck@1313 2822 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2823 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2824 if (container.attribute(syms.documentedType.tsym) == null) {
jjg@1492 2825 log.error(pos, "invalid.repeatable.annotation.not.documented", container, contained);
jfranck@1313 2826 }
jfranck@1313 2827 }
jfranck@1313 2828 }
jfranck@1313 2829
jfranck@1313 2830 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2831 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2832 if (container.attribute(syms.inheritedType.tsym) == null) {
jjg@1492 2833 log.error(pos, "invalid.repeatable.annotation.not.inherited", container, contained);
jfranck@1313 2834 }
jfranck@1313 2835 }
jfranck@1313 2836 }
jfranck@1313 2837
jfranck@1313 2838 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1634 2839 // The set of targets the container is applicable to must be a subset
jfranck@1634 2840 // (with respect to annotation target semantics) of the set of targets
jfranck@1634 2841 // the contained is applicable to. The target sets may be implicit or
jfranck@1634 2842 // explicit.
jfranck@1634 2843
jfranck@1634 2844 Set<Name> containerTargets;
jfranck@1313 2845 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2846 if (containerTarget == null) {
jfranck@1634 2847 containerTargets = getDefaultTargetSet();
jfranck@1634 2848 } else {
jfranck@1634 2849 containerTargets = new HashSet<Name>();
jfranck@1313 2850 for (Attribute app : containerTarget.values) {
jfranck@1313 2851 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2852 continue; // recovery
jfranck@1313 2853 }
jfranck@1313 2854 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2855 containerTargets.add(e.value.name);
jfranck@1313 2856 }
jfranck@1634 2857 }
jfranck@1634 2858
jfranck@1634 2859 Set<Name> containedTargets;
jfranck@1634 2860 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1634 2861 if (containedTarget == null) {
jfranck@1634 2862 containedTargets = getDefaultTargetSet();
jfranck@1634 2863 } else {
jfranck@1634 2864 containedTargets = new HashSet<Name>();
jfranck@1313 2865 for (Attribute app : containedTarget.values) {
jfranck@1313 2866 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2867 continue; // recovery
jfranck@1313 2868 }
jfranck@1313 2869 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2870 containedTargets.add(e.value.name);
jfranck@1313 2871 }
jfranck@1634 2872 }
jfranck@1634 2873
jfranck@1634 2874 if (!isTargetSubsetOf(containerTargets, containedTargets)) {
jjg@1492 2875 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2876 }
jfranck@1313 2877 }
jfranck@1313 2878
jfranck@1634 2879 /* get a set of names for the default target */
jfranck@1634 2880 private Set<Name> getDefaultTargetSet() {
jfranck@1634 2881 if (defaultTargets == null) {
jfranck@1634 2882 Set<Name> targets = new HashSet<Name>();
jfranck@1634 2883 targets.add(names.ANNOTATION_TYPE);
jfranck@1634 2884 targets.add(names.CONSTRUCTOR);
jfranck@1634 2885 targets.add(names.FIELD);
jfranck@1634 2886 targets.add(names.LOCAL_VARIABLE);
jfranck@1634 2887 targets.add(names.METHOD);
jfranck@1634 2888 targets.add(names.PACKAGE);
jfranck@1634 2889 targets.add(names.PARAMETER);
jfranck@1634 2890 targets.add(names.TYPE);
jfranck@1634 2891
jfranck@1634 2892 defaultTargets = java.util.Collections.unmodifiableSet(targets);
jfranck@1634 2893 }
jfranck@1634 2894
jfranck@1634 2895 return defaultTargets;
jfranck@1634 2896 }
jfranck@1634 2897 private Set<Name> defaultTargets;
jfranck@1634 2898
jfranck@1634 2899
jfranck@1634 2900 /** Checks that s is a subset of t, with respect to ElementType
jfranck@2250 2901 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE},
jfranck@2250 2902 * and {TYPE_USE} covers the set {ANNOTATION_TYPE, TYPE, TYPE_USE,
jfranck@2250 2903 * TYPE_PARAMETER}.
jfranck@1313 2904 */
jfranck@1634 2905 private boolean isTargetSubsetOf(Set<Name> s, Set<Name> t) {
jfranck@1634 2906 // Check that all elements in s are present in t
jfranck@1634 2907 for (Name n2 : s) {
jfranck@1313 2908 boolean currentElementOk = false;
jfranck@1634 2909 for (Name n1 : t) {
jfranck@1313 2910 if (n1 == n2) {
jfranck@1313 2911 currentElementOk = true;
jfranck@1313 2912 break;
jfranck@1313 2913 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2914 currentElementOk = true;
jfranck@1313 2915 break;
jfranck@2250 2916 } else if (n1 == names.TYPE_USE &&
jfranck@2250 2917 (n2 == names.TYPE ||
jfranck@2250 2918 n2 == names.ANNOTATION_TYPE ||
jfranck@2250 2919 n2 == names.TYPE_PARAMETER)) {
jfranck@2250 2920 currentElementOk = true;
jfranck@2250 2921 break;
jfranck@1313 2922 }
jfranck@1313 2923 }
jfranck@1313 2924 if (!currentElementOk)
jfranck@1313 2925 return false;
jfranck@1313 2926 }
jfranck@1313 2927 return true;
jfranck@1313 2928 }
jfranck@1313 2929
jfranck@2250 2930 private void validateDefault(Symbol container, DiagnosticPosition pos) {
jfranck@1344 2931 // validate that all other elements of containing type has defaults
jfranck@1344 2932 Scope scope = container.members();
jfranck@1344 2933 for(Symbol elm : scope.getElements()) {
jfranck@1344 2934 if (elm.name != names.value &&
jfranck@1344 2935 elm.kind == Kinds.MTH &&
jfranck@1344 2936 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2937 log.error(pos,
jjg@1492 2938 "invalid.repeatable.annotation.elem.nondefault",
jfranck@1344 2939 container,
jfranck@1344 2940 elm);
jfranck@1344 2941 }
jfranck@1344 2942 }
jfranck@1344 2943 }
jfranck@1344 2944
duke@1 2945 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2946 boolean isOverrider(Symbol s) {
duke@1 2947 if (s.kind != MTH || s.isStatic())
duke@1 2948 return false;
duke@1 2949 MethodSymbol m = (MethodSymbol)s;
duke@1 2950 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2951 for (Type sup : types.closure(owner.type)) {
duke@1 2952 if (sup == owner.type)
duke@1 2953 continue; // skip "this"
duke@1 2954 Scope scope = sup.tsym.members();
duke@1 2955 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2956 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2957 return true;
duke@1 2958 }
duke@1 2959 }
duke@1 2960 return false;
duke@1 2961 }
duke@1 2962
jlahoda@2111 2963 /** Is the annotation applicable to types? */
jjg@1521 2964 protected boolean isTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2965 Attribute.Compound atTarget =
jjg@1521 2966 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
jjg@1521 2967 if (atTarget == null) {
jjg@1521 2968 // An annotation without @Target is not a type annotation.
jjg@1521 2969 return false;
jjg@1521 2970 }
jjg@1521 2971
jjg@1521 2972 Attribute atValue = atTarget.member(names.value);
jjg@1521 2973 if (!(atValue instanceof Attribute.Array)) {
jjg@1521 2974 return false; // error recovery
jjg@1521 2975 }
jjg@1521 2976
jjg@1521 2977 Attribute.Array arr = (Attribute.Array) atValue;
jjg@1521 2978 for (Attribute app : arr.values) {
jjg@1521 2979 if (!(app instanceof Attribute.Enum)) {
jjg@1521 2980 return false; // recovery
jjg@1521 2981 }
jjg@1521 2982 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 2983
jjg@1521 2984 if (e.value.name == names.TYPE_USE)
jjg@1521 2985 return true;
jjg@1521 2986 else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER)
jjg@1521 2987 return true;
jjg@1521 2988 }
jjg@1521 2989 return false;
jjg@1521 2990 }
jjg@1521 2991
duke@1 2992 /** Is the annotation applicable to the symbol? */
duke@1 2993 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 2994 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jjg@1521 2995 Name[] targets;
jlahoda@2210 2996
jfranck@1313 2997 if (arr == null) {
jjg@1521 2998 targets = defaultTargetMetaInfo(a, s);
jjg@1521 2999 } else {
jjg@1521 3000 // TODO: can we optimize this?
jjg@1521 3001 targets = new Name[arr.values.length];
jjg@1521 3002 for (int i=0; i<arr.values.length; ++i) {
jjg@1521 3003 Attribute app = arr.values[i];
jjg@1521 3004 if (!(app instanceof Attribute.Enum)) {
jjg@1521 3005 return true; // recovery
jjg@1521 3006 }
jjg@1521 3007 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 3008 targets[i] = e.value.name;
jjg@1521 3009 }
jfranck@1313 3010 }
jjg@1521 3011 for (Name target : targets) {
jjg@1521 3012 if (target == names.TYPE)
jlahoda@2210 3013 { if (s.kind == TYP) return true; }
jjg@1521 3014 else if (target == names.FIELD)
duke@1 3015 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
jjg@1521 3016 else if (target == names.METHOD)
duke@1 3017 { if (s.kind == MTH && !s.isConstructor()) return true; }
jjg@1521 3018 else if (target == names.PARAMETER)
duke@1 3019 { if (s.kind == VAR &&
duke@1 3020 s.owner.kind == MTH &&
duke@1 3021 (s.flags() & PARAMETER) != 0)
duke@1 3022 return true;
duke@1 3023 }
jjg@1521 3024 else if (target == names.CONSTRUCTOR)
duke@1 3025 { if (s.kind == MTH && s.isConstructor()) return true; }
jjg@1521 3026 else if (target == names.LOCAL_VARIABLE)
duke@1 3027 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 3028 (s.flags() & PARAMETER) == 0)
duke@1 3029 return true;
duke@1 3030 }
jjg@1521 3031 else if (target == names.ANNOTATION_TYPE)
duke@1 3032 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 3033 return true;
duke@1 3034 }
jjg@1521 3035 else if (target == names.PACKAGE)
duke@1 3036 { if (s.kind == PCK) return true; }
jjg@1521 3037 else if (target == names.TYPE_USE)
jjg@308 3038 { if (s.kind == TYP ||
jjg@308 3039 s.kind == VAR ||
jjg@308 3040 (s.kind == MTH && !s.isConstructor() &&
jjg@1521 3041 !s.type.getReturnType().hasTag(VOID)) ||
jjg@1521 3042 (s.kind == MTH && s.isConstructor()))
jjg@1521 3043 return true;
jjg@1521 3044 }
jjg@1521 3045 else if (target == names.TYPE_PARAMETER)
jjg@1521 3046 { if (s.kind == TYP && s.type.hasTag(TYPEVAR))
jjg@308 3047 return true;
jjg@308 3048 }
duke@1 3049 else
duke@1 3050 return true; // recovery
duke@1 3051 }
duke@1 3052 return false;
duke@1 3053 }
duke@1 3054
jfranck@1313 3055
jfranck@1313 3056 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 3057 Attribute.Compound atTarget =
jfranck@1313 3058 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 3059 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 3060 Attribute atValue = atTarget.member(names.value);
jfranck@1313 3061 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 3062 return (Attribute.Array) atValue;
jfranck@1313 3063 }
jfranck@1313 3064
jjg@1521 3065 private final Name[] dfltTargetMeta;
jjg@1521 3066 private Name[] defaultTargetMetaInfo(JCAnnotation a, Symbol s) {
jjg@1521 3067 return dfltTargetMeta;
jjg@1521 3068 }
jjg@1521 3069
duke@1 3070 /** Check an annotation value.
jfranck@1445 3071 *
jfranck@1445 3072 * @param a The annotation tree to check
jfranck@1445 3073 * @return true if this annotation tree is valid, otherwise false
duke@1 3074 */
jfranck@1445 3075 public boolean validateAnnotationDeferErrors(JCAnnotation a) {
jfranck@1445 3076 boolean res = false;
jfranck@1445 3077 final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log);
jfranck@1445 3078 try {
jfranck@1445 3079 res = validateAnnotation(a);
jfranck@1445 3080 } finally {
jfranck@1445 3081 log.popDiagnosticHandler(diagHandler);
jfranck@1445 3082 }
jfranck@1445 3083 return res;
jfranck@1445 3084 }
jfranck@1445 3085
jfranck@1445 3086 private boolean validateAnnotation(JCAnnotation a) {
jfranck@1445 3087 boolean isValid = true;
jfranck@1445 3088 // collect an inventory of the annotation elements
jfranck@1445 3089 Set<MethodSymbol> members = new LinkedHashSet<MethodSymbol>();
duke@1 3090 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
jfranck@1729 3091 e != null;
jfranck@1729 3092 e = e.sibling)
mcimadamore@1920 3093 if (e.sym.kind == MTH && e.sym.name != names.clinit &&
mcimadamore@1920 3094 (e.sym.flags() & SYNTHETIC) == 0)
duke@1 3095 members.add((MethodSymbol) e.sym);
duke@1 3096
jfranck@1445 3097 // remove the ones that are assigned values
duke@1 3098 for (JCTree arg : a.args) {
jjg@1127 3099 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 3100 JCAssign assign = (JCAssign) arg;
duke@1 3101 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 3102 if (m == null || m.type.isErroneous()) continue;
jfranck@1445 3103 if (!members.remove(m)) {
jfranck@1445 3104 isValid = false;
jjg@479 3105 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 3106 m.name, a.type);
jfranck@1445 3107 }
duke@1 3108 }
duke@1 3109
duke@1 3110 // all the remaining ones better have default values
jfranck@1445 3111 List<Name> missingDefaults = List.nil();
mcimadamore@632 3112 for (MethodSymbol m : members) {
mcimadamore@632 3113 if (m.defaultValue == null && !m.type.isErroneous()) {
jfranck@1445 3114 missingDefaults = missingDefaults.append(m.name);
mcimadamore@632 3115 }
mcimadamore@632 3116 }
jfranck@1445 3117 missingDefaults = missingDefaults.reverse();
mcimadamore@632 3118 if (missingDefaults.nonEmpty()) {
jfranck@1445 3119 isValid = false;
mcimadamore@632 3120 String key = (missingDefaults.size() > 1)
mcimadamore@632 3121 ? "annotation.missing.default.value.1"
mcimadamore@632 3122 : "annotation.missing.default.value";
mcimadamore@632 3123 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 3124 }
duke@1 3125
duke@1 3126 // special case: java.lang.annotation.Target must not have
duke@1 3127 // repeated values in its value member
duke@1 3128 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 3129 a.args.tail == null)
jfranck@1445 3130 return isValid;
duke@1 3131
jfranck@1445 3132 if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery
duke@1 3133 JCAssign assign = (JCAssign) a.args.head;
duke@1 3134 Symbol m = TreeInfo.symbol(assign.lhs);
jfranck@1445 3135 if (m.name != names.value) return false;
duke@1 3136 JCTree rhs = assign.rhs;
jfranck@1445 3137 if (!rhs.hasTag(NEWARRAY)) return false;
duke@1 3138 JCNewArray na = (JCNewArray) rhs;
duke@1 3139 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 3140 for (JCTree elem : na.elems) {
duke@1 3141 if (!targets.add(TreeInfo.symbol(elem))) {
jfranck@1445 3142 isValid = false;
duke@1 3143 log.error(elem.pos(), "repeated.annotation.target");
duke@1 3144 }
duke@1 3145 }
jfranck@1445 3146 return isValid;
duke@1 3147 }
duke@1 3148
duke@1 3149 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 3150 if (allowAnnotations &&
mcimadamore@795 3151 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 3152 (s.flags() & DEPRECATED) != 0 &&
duke@1 3153 !syms.deprecatedType.isErroneous() &&
duke@1 3154 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 3155 log.warning(LintCategory.DEP_ANN,
jjg@612 3156 pos, "missing.deprecated.annotation");
duke@1 3157 }
duke@1 3158 }
duke@1 3159
mcimadamore@852 3160 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 3161 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 3162 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 3163 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 3164 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3165 @Override
mcimadamore@852 3166 public void report() {
mcimadamore@852 3167 warnDeprecated(pos, s);
mcimadamore@852 3168 }
mcimadamore@852 3169 });
jjg@1157 3170 }
mcimadamore@852 3171 }
mcimadamore@852 3172
mcimadamore@852 3173 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 3174 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 3175 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3176 public void report() {
mcimadamore@852 3177 if (enableSunApiLintControl)
mcimadamore@852 3178 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 3179 else
mcimadamore@1218 3180 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 3181 }
mcimadamore@852 3182 });
mcimadamore@852 3183 }
mcimadamore@852 3184 }
mcimadamore@852 3185
jjg@1569 3186 void checkProfile(final DiagnosticPosition pos, final Symbol s) {
jjg@1569 3187 if (profile != Profile.DEFAULT && (s.flags() & NOT_IN_PROFILE) != 0) {
jjg@1569 3188 log.error(pos, "not.in.profile", s, profile);
jjg@1569 3189 }
jjg@1569 3190 }
jjg@1569 3191
duke@1 3192 /* *************************************************************************
duke@1 3193 * Check for recursive annotation elements.
duke@1 3194 **************************************************************************/
duke@1 3195
duke@1 3196 /** Check for cycles in the graph of annotation elements.
duke@1 3197 */
duke@1 3198 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 3199 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 3200 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 3201 try {
duke@1 3202 tree.sym.flags_field |= LOCKED;
duke@1 3203 for (JCTree def : tree.defs) {
jjg@1127 3204 if (!def.hasTag(METHODDEF)) continue;
duke@1 3205 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 3206 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 3207 }
duke@1 3208 } finally {
duke@1 3209 tree.sym.flags_field &= ~LOCKED;
duke@1 3210 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 3211 }
duke@1 3212 }
duke@1 3213
duke@1 3214 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 3215 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 3216 return;
duke@1 3217 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 3218 log.error(pos, "cyclic.annotation.element");
duke@1 3219 return;
duke@1 3220 }
duke@1 3221 try {
duke@1 3222 tsym.flags_field |= LOCKED;
duke@1 3223 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 3224 Symbol s = e.sym;
duke@1 3225 if (s.kind != Kinds.MTH)
duke@1 3226 continue;
duke@1 3227 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 3228 }
duke@1 3229 } finally {
duke@1 3230 tsym.flags_field &= ~LOCKED;
duke@1 3231 tsym.flags_field |= ACYCLIC_ANN;
duke@1 3232 }
duke@1 3233 }
duke@1 3234
duke@1 3235 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
jjg@1374 3236 switch (type.getTag()) {
jjg@1374 3237 case CLASS:
duke@1 3238 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 3239 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 3240 break;
jjg@1374 3241 case ARRAY:
duke@1 3242 checkAnnotationResType(pos, types.elemtype(type));
duke@1 3243 break;
duke@1 3244 default:
duke@1 3245 break; // int etc
duke@1 3246 }
duke@1 3247 }
duke@1 3248
duke@1 3249 /* *************************************************************************
duke@1 3250 * Check for cycles in the constructor call graph.
duke@1 3251 **************************************************************************/
duke@1 3252
duke@1 3253 /** Check for cycles in the graph of constructors calling other
duke@1 3254 * constructors.
duke@1 3255 */
duke@1 3256 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 3257 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 3258
duke@1 3259 // enter each constructor this-call into the map
duke@1 3260 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 3261 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 3262 if (app == null) continue;
duke@1 3263 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 3264 if (TreeInfo.name(app.meth) == names._this) {
duke@1 3265 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 3266 } else {
duke@1 3267 meth.sym.flags_field |= ACYCLIC;
duke@1 3268 }
duke@1 3269 }
duke@1 3270
duke@1 3271 // Check for cycles in the map
duke@1 3272 Symbol[] ctors = new Symbol[0];
duke@1 3273 ctors = callMap.keySet().toArray(ctors);
duke@1 3274 for (Symbol caller : ctors) {
duke@1 3275 checkCyclicConstructor(tree, caller, callMap);
duke@1 3276 }
duke@1 3277 }
duke@1 3278
duke@1 3279 /** Look in the map to see if the given constructor is part of a
duke@1 3280 * call cycle.
duke@1 3281 */
duke@1 3282 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 3283 Map<Symbol,Symbol> callMap) {
duke@1 3284 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 3285 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 3286 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 3287 "recursive.ctor.invocation");
duke@1 3288 } else {
duke@1 3289 ctor.flags_field |= LOCKED;
duke@1 3290 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 3291 ctor.flags_field &= ~LOCKED;
duke@1 3292 }
duke@1 3293 ctor.flags_field |= ACYCLIC;
duke@1 3294 }
duke@1 3295 }
duke@1 3296
duke@1 3297 /* *************************************************************************
duke@1 3298 * Miscellaneous
duke@1 3299 **************************************************************************/
duke@1 3300
duke@1 3301 /**
duke@1 3302 * Return the opcode of the operator but emit an error if it is an
duke@1 3303 * error.
duke@1 3304 * @param pos position for error reporting.
duke@1 3305 * @param operator an operator
duke@1 3306 * @param tag a tree tag
duke@1 3307 * @param left type of left hand side
duke@1 3308 * @param right type of right hand side
duke@1 3309 */
duke@1 3310 int checkOperator(DiagnosticPosition pos,
duke@1 3311 OperatorSymbol operator,
jjg@1127 3312 JCTree.Tag tag,
duke@1 3313 Type left,
duke@1 3314 Type right) {
duke@1 3315 if (operator.opcode == ByteCodes.error) {
duke@1 3316 log.error(pos,
mcimadamore@853 3317 "operator.cant.be.applied.1",
duke@1 3318 treeinfo.operatorName(tag),
mcimadamore@853 3319 left, right);
duke@1 3320 }
duke@1 3321 return operator.opcode;
duke@1 3322 }
duke@1 3323
duke@1 3324
duke@1 3325 /**
duke@1 3326 * Check for division by integer constant zero
duke@1 3327 * @param pos Position for error reporting.
duke@1 3328 * @param operator The operator for the expression
duke@1 3329 * @param operand The right hand operand for the expression
duke@1 3330 */
duke@1 3331 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3332 if (operand.constValue() != null
mcimadamore@795 3333 && lint.isEnabled(LintCategory.DIVZERO)
vromero@1826 3334 && operand.getTag().isSubRangeOf(LONG)
duke@1 3335 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3336 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3337 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3338 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3339 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3340 }
duke@1 3341 }
duke@1 3342 }
duke@1 3343
duke@1 3344 /**
duke@1 3345 * Check for empty statements after if
duke@1 3346 */
duke@1 3347 void checkEmptyIf(JCIf tree) {
jjg@1127 3348 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3349 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3350 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3351 }
duke@1 3352
duke@1 3353 /** Check that symbol is unique in given scope.
duke@1 3354 * @param pos Position for error reporting.
duke@1 3355 * @param sym The symbol.
duke@1 3356 * @param s The scope.
duke@1 3357 */
duke@1 3358 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3359 if (sym.type.isErroneous())
duke@1 3360 return true;
duke@1 3361 if (sym.owner.name == names.any) return false;
duke@1 3362 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3363 if (sym != e.sym &&
mcimadamore@858 3364 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3365 sym.kind == e.sym.kind &&
mcimadamore@858 3366 sym.name != names.error &&
emc@2024 3367 (sym.kind != MTH ||
emc@2024 3368 types.hasSameArgs(sym.type, e.sym.type) ||
emc@2024 3369 types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3370 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3371 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3372 return true;
mcimadamore@907 3373 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3374 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3375 sym.flags_field |= CLASH;
mcimadamore@844 3376 return true;
mcimadamore@844 3377 } else {
duke@1 3378 duplicateError(pos, e.sym);
mcimadamore@844 3379 return false;
mcimadamore@844 3380 }
duke@1 3381 }
duke@1 3382 }
duke@1 3383 return true;
duke@1 3384 }
mcimadamore@844 3385
mcimadamore@858 3386 /** Report duplicate declaration error.
mcimadamore@858 3387 */
mcimadamore@858 3388 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3389 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3390 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3391 }
mcimadamore@858 3392 }
duke@1 3393
duke@1 3394 /** Check that single-type import is not already imported or top-level defined,
duke@1 3395 * but make an exception for two single-type imports which denote the same type.
duke@1 3396 * @param pos Position for error reporting.
duke@1 3397 * @param sym The symbol.
duke@1 3398 * @param s The scope
duke@1 3399 */
duke@1 3400 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3401 return checkUniqueImport(pos, sym, s, false);
duke@1 3402 }
duke@1 3403
duke@1 3404 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3405 * but make an exception for two single-type imports which denote the same type.
duke@1 3406 * @param pos Position for error reporting.
duke@1 3407 * @param sym The symbol.
duke@1 3408 * @param s The scope
duke@1 3409 */
duke@1 3410 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3411 return checkUniqueImport(pos, sym, s, true);
duke@1 3412 }
duke@1 3413
duke@1 3414 /** Check that single-type import is not already imported or top-level defined,
duke@1 3415 * but make an exception for two single-type imports which denote the same type.
duke@1 3416 * @param pos Position for error reporting.
duke@1 3417 * @param sym The symbol.
duke@1 3418 * @param s The scope.
duke@1 3419 * @param staticImport Whether or not this was a static import
duke@1 3420 */
duke@1 3421 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3422 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3423 // is encountered class entered via a class declaration?
duke@1 3424 boolean isClassDecl = e.scope == s;
duke@1 3425 if ((isClassDecl || sym != e.sym) &&
duke@1 3426 sym.kind == e.sym.kind &&
mcimadamore@1945 3427 sym.name != names.error &&
mcimadamore@1945 3428 (!staticImport || !e.isStaticallyImported())) {
duke@1 3429 if (!e.sym.type.isErroneous()) {
duke@1 3430 if (!isClassDecl) {
duke@1 3431 if (staticImport)
emc@2102 3432 log.error(pos, "already.defined.static.single.import", e.sym);
duke@1 3433 else
emc@2102 3434 log.error(pos, "already.defined.single.import", e.sym);
duke@1 3435 }
duke@1 3436 else if (sym != e.sym)
emc@2102 3437 log.error(pos, "already.defined.this.unit", e.sym);
duke@1 3438 }
duke@1 3439 return false;
duke@1 3440 }
duke@1 3441 }
duke@1 3442 return true;
duke@1 3443 }
duke@1 3444
duke@1 3445 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3446 */
duke@1 3447 public void checkCanonical(JCTree tree) {
duke@1 3448 if (!isCanonical(tree))
duke@1 3449 log.error(tree.pos(), "import.requires.canonical",
duke@1 3450 TreeInfo.symbol(tree));
duke@1 3451 }
duke@1 3452 // where
duke@1 3453 private boolean isCanonical(JCTree tree) {
jjg@1127 3454 while (tree.hasTag(SELECT)) {
duke@1 3455 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3456 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3457 return false;
duke@1 3458 tree = s.selected;
duke@1 3459 }
duke@1 3460 return true;
duke@1 3461 }
duke@1 3462
ohrstrom@1384 3463 /** Check that an auxiliary class is not accessed from any other file than its own.
ohrstrom@1384 3464 */
ohrstrom@1384 3465 void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) {
ohrstrom@1384 3466 if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) &&
ohrstrom@1384 3467 (c.flags() & AUXILIARY) != 0 &&
ohrstrom@1384 3468 rs.isAccessible(env, c) &&
ohrstrom@1384 3469 !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile))
ohrstrom@1384 3470 {
ohrstrom@1384 3471 log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file",
ohrstrom@1384 3472 c, c.sourcefile);
ohrstrom@1384 3473 }
ohrstrom@1384 3474 }
ohrstrom@1384 3475
duke@1 3476 private class ConversionWarner extends Warner {
mcimadamore@795 3477 final String uncheckedKey;
duke@1 3478 final Type found;
duke@1 3479 final Type expected;
mcimadamore@795 3480 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3481 super(pos);
mcimadamore@795 3482 this.uncheckedKey = uncheckedKey;
duke@1 3483 this.found = found;
duke@1 3484 this.expected = expected;
duke@1 3485 }
duke@1 3486
jjg@398 3487 @Override
mcimadamore@795 3488 public void warn(LintCategory lint) {
duke@1 3489 boolean warned = this.warned;
mcimadamore@795 3490 super.warn(lint);
duke@1 3491 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3492 switch (lint) {
mcimadamore@795 3493 case UNCHECKED:
mcimadamore@795 3494 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3495 break;
mcimadamore@795 3496 case VARARGS:
mcimadamore@795 3497 if (method != null &&
mcimadamore@795 3498 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3499 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3500 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3501 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3502 }
mcimadamore@795 3503 break;
mcimadamore@795 3504 default:
mcimadamore@795 3505 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3506 }
duke@1 3507 }
duke@1 3508 }
duke@1 3509
duke@1 3510 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3511 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3512 }
duke@1 3513
duke@1 3514 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3515 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3516 }
jlahoda@2111 3517
jlahoda@2111 3518 public void checkFunctionalInterface(JCClassDecl tree, ClassSymbol cs) {
jlahoda@2111 3519 Compound functionalType = cs.attribute(syms.functionalInterfaceType.tsym);
jlahoda@2111 3520
jlahoda@2111 3521 if (functionalType != null) {
jlahoda@2111 3522 try {
jlahoda@2111 3523 types.findDescriptorSymbol((TypeSymbol)cs);
jlahoda@2111 3524 } catch (Types.FunctionDescriptorLookupError ex) {
jlahoda@2111 3525 DiagnosticPosition pos = tree.pos();
jlahoda@2111 3526 for (JCAnnotation a : tree.getModifiers().annotations) {
jlahoda@2111 3527 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
jlahoda@2111 3528 pos = a.pos();
jlahoda@2111 3529 break;
jlahoda@2111 3530 }
jlahoda@2111 3531 }
jlahoda@2111 3532 log.error(pos, "bad.functional.intf.anno.1", ex.getDiagnostic());
jlahoda@2111 3533 }
jlahoda@2111 3534 }
jlahoda@2111 3535 }
duke@1 3536 }

mercurial