src/share/classes/com/sun/tools/javac/comp/Check.java

Mon, 11 Nov 2013 09:47:46 -0500

author
emc
date
Mon, 11 Nov 2013 09:47:46 -0500
changeset 2187
4788eb38cac5
parent 2168
119747cd9f25
child 2206
8acb838c9b79
permissions
-rw-r--r--

8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
8027253: javac illegally accepts array as bound
Summary: backing out change allowing arrays in intersection types
Reviewed-by: vromero

duke@1 1 /*
jjg@1492 2 * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
jjg@1521 29
ohrstrom@1384 30 import javax.tools.JavaFileManager;
duke@1 31
duke@1 32 import com.sun.tools.javac.code.*;
jlahoda@2111 33 import com.sun.tools.javac.code.Attribute.Compound;
duke@1 34 import com.sun.tools.javac.jvm.*;
duke@1 35 import com.sun.tools.javac.tree.*;
duke@1 36 import com.sun.tools.javac.util.*;
duke@1 37 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 38 import com.sun.tools.javac.util.List;
duke@1 39
duke@1 40 import com.sun.tools.javac.code.Lint;
duke@1 41 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 42 import com.sun.tools.javac.code.Type.*;
duke@1 43 import com.sun.tools.javac.code.Symbol.*;
mcimadamore@1347 44 import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
mcimadamore@1337 45 import com.sun.tools.javac.comp.Infer.InferenceContext;
mcimadamore@1550 46 import com.sun.tools.javac.comp.Infer.FreeTypeListener;
mcimadamore@1510 47 import com.sun.tools.javac.tree.JCTree.*;
mcimadamore@1510 48 import com.sun.tools.javac.tree.JCTree.JCPolyExpression.*;
duke@1 49
duke@1 50 import static com.sun.tools.javac.code.Flags.*;
jjg@1127 51 import static com.sun.tools.javac.code.Flags.ANNOTATION;
jjg@1127 52 import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
duke@1 53 import static com.sun.tools.javac.code.Kinds.*;
jjg@1374 54 import static com.sun.tools.javac.code.TypeTag.*;
jjg@1374 55 import static com.sun.tools.javac.code.TypeTag.WILDCARD;
duke@1 56
jjg@1127 57 import static com.sun.tools.javac.tree.JCTree.Tag.*;
jjg@700 58
duke@1 59 /** Type checking helper class for the attribution phase.
duke@1 60 *
jjg@581 61 * <p><b>This is NOT part of any supported API.
jjg@581 62 * If you write code that depends on this, you do so at your own risk.
duke@1 63 * This code and its internal interfaces are subject to change or
duke@1 64 * deletion without notice.</b>
duke@1 65 */
duke@1 66 public class Check {
duke@1 67 protected static final Context.Key<Check> checkKey =
duke@1 68 new Context.Key<Check>();
duke@1 69
jjg@113 70 private final Names names;
duke@1 71 private final Log log;
mcimadamore@1219 72 private final Resolve rs;
duke@1 73 private final Symtab syms;
mcimadamore@690 74 private final Enter enter;
mcimadamore@1347 75 private final DeferredAttr deferredAttr;
duke@1 76 private final Infer infer;
duke@1 77 private final Types types;
mcimadamore@89 78 private final JCDiagnostic.Factory diags;
mcimadamore@359 79 private boolean warnOnSyntheticConflicts;
jjg@576 80 private boolean suppressAbortOnBadClassFile;
mcimadamore@852 81 private boolean enableSunApiLintControl;
duke@1 82 private final TreeInfo treeinfo;
ohrstrom@1384 83 private final JavaFileManager fileManager;
jjg@1569 84 private final Profile profile;
duke@1 85
duke@1 86 // The set of lint options currently in effect. It is initialized
duke@1 87 // from the context, and then is set/reset as needed by Attr as it
duke@1 88 // visits all the various parts of the trees during attribution.
duke@1 89 private Lint lint;
duke@1 90
mcimadamore@795 91 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 92 // Attr as it visits new method declarations.
mcimadamore@795 93 private MethodSymbol method;
mcimadamore@795 94
duke@1 95 public static Check instance(Context context) {
duke@1 96 Check instance = context.get(checkKey);
duke@1 97 if (instance == null)
duke@1 98 instance = new Check(context);
duke@1 99 return instance;
duke@1 100 }
duke@1 101
duke@1 102 protected Check(Context context) {
duke@1 103 context.put(checkKey, this);
duke@1 104
jjg@113 105 names = Names.instance(context);
jjg@1521 106 dfltTargetMeta = new Name[] { names.PACKAGE, names.TYPE,
jjg@1521 107 names.FIELD, names.METHOD, names.CONSTRUCTOR,
jjg@1521 108 names.ANNOTATION_TYPE, names.LOCAL_VARIABLE, names.PARAMETER};
duke@1 109 log = Log.instance(context);
mcimadamore@1219 110 rs = Resolve.instance(context);
duke@1 111 syms = Symtab.instance(context);
mcimadamore@690 112 enter = Enter.instance(context);
mcimadamore@1347 113 deferredAttr = DeferredAttr.instance(context);
duke@1 114 infer = Infer.instance(context);
jjg@1569 115 types = Types.instance(context);
mcimadamore@89 116 diags = JCDiagnostic.Factory.instance(context);
duke@1 117 Options options = Options.instance(context);
duke@1 118 lint = Lint.instance(context);
duke@1 119 treeinfo = TreeInfo.instance(context);
ohrstrom@1384 120 fileManager = context.get(JavaFileManager.class);
duke@1 121
duke@1 122 Source source = Source.instance(context);
duke@1 123 allowGenerics = source.allowGenerics();
mcimadamore@1219 124 allowVarargs = source.allowVarargs();
duke@1 125 allowAnnotations = source.allowAnnotations();
jjg@398 126 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 127 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
mcimadamore@1393 128 allowDefaultMethods = source.allowDefaultMethods();
mcimadamore@1415 129 allowStrictMethodClashCheck = source.allowStrictMethodClashCheck();
jjg@1157 130 complexInference = options.isSet("complexinference");
jjg@700 131 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 132 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
mcimadamore@852 133 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
duke@1 134
jjg@398 135 Target target = Target.instance(context);
jjg@398 136 syntheticNameChar = target.syntheticNameChar();
jjg@398 137
jjg@1569 138 profile = Profile.instance(context);
jjg@1569 139
duke@1 140 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 141 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
jjg@377 142 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 143 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 144
jjg@60 145 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 146 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 147 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 148 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
jjg@377 149 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 150 enforceMandatoryWarnings, "sunapi", null);
mcimadamore@852 151
jlahoda@2028 152 deferredLintHandler = DeferredLintHandler.instance(context);
duke@1 153 }
duke@1 154
duke@1 155 /** Switch: generics enabled?
duke@1 156 */
duke@1 157 boolean allowGenerics;
duke@1 158
mcimadamore@1219 159 /** Switch: varargs enabled?
mcimadamore@1219 160 */
mcimadamore@1219 161 boolean allowVarargs;
mcimadamore@1219 162
duke@1 163 /** Switch: annotations enabled?
duke@1 164 */
duke@1 165 boolean allowAnnotations;
duke@1 166
jjg@398 167 /** Switch: covariant returns enabled?
jjg@398 168 */
jjg@398 169 boolean allowCovariantReturns;
jjg@398 170
mcimadamore@795 171 /** Switch: simplified varargs enabled?
mcimadamore@795 172 */
mcimadamore@795 173 boolean allowSimplifiedVarargs;
mcimadamore@795 174
mcimadamore@1393 175 /** Switch: default methods enabled?
mcimadamore@1393 176 */
mcimadamore@1393 177 boolean allowDefaultMethods;
mcimadamore@1393 178
mcimadamore@1393 179 /** Switch: should unrelated return types trigger a method clash?
mcimadamore@1393 180 */
mcimadamore@1393 181 boolean allowStrictMethodClashCheck;
mcimadamore@1393 182
duke@1 183 /** Switch: -complexinference option set?
duke@1 184 */
duke@1 185 boolean complexInference;
duke@1 186
jjg@398 187 /** Character for synthetic names
jjg@398 188 */
jjg@398 189 char syntheticNameChar;
jjg@398 190
duke@1 191 /** A table mapping flat names of all compiled classes in this run to their
duke@1 192 * symbols; maintained from outside.
duke@1 193 */
duke@1 194 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 195
duke@1 196 /** A handler for messages about deprecated usage.
duke@1 197 */
duke@1 198 private MandatoryWarningHandler deprecationHandler;
duke@1 199
duke@1 200 /** A handler for messages about unchecked or unsafe usage.
duke@1 201 */
duke@1 202 private MandatoryWarningHandler uncheckedHandler;
duke@1 203
jjg@582 204 /** A handler for messages about using proprietary API.
jjg@377 205 */
jjg@377 206 private MandatoryWarningHandler sunApiHandler;
duke@1 207
mcimadamore@852 208 /** A handler for deferred lint warnings.
mcimadamore@852 209 */
mcimadamore@852 210 private DeferredLintHandler deferredLintHandler;
mcimadamore@852 211
duke@1 212 /* *************************************************************************
duke@1 213 * Errors and Warnings
duke@1 214 **************************************************************************/
duke@1 215
duke@1 216 Lint setLint(Lint newLint) {
duke@1 217 Lint prev = lint;
duke@1 218 lint = newLint;
duke@1 219 return prev;
duke@1 220 }
duke@1 221
mcimadamore@795 222 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 223 MethodSymbol prev = method;
mcimadamore@795 224 method = newMethod;
mcimadamore@795 225 return prev;
mcimadamore@795 226 }
mcimadamore@795 227
duke@1 228 /** Warn about deprecated symbol.
duke@1 229 * @param pos Position to be used for error reporting.
duke@1 230 * @param sym The deprecated symbol.
duke@1 231 */
duke@1 232 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 233 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 234 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 235 }
duke@1 236
duke@1 237 /** Warn about unchecked operation.
duke@1 238 * @param pos Position to be used for error reporting.
duke@1 239 * @param msg A string describing the problem.
duke@1 240 */
duke@1 241 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 242 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 243 uncheckedHandler.report(pos, msg, args);
duke@1 244 }
duke@1 245
mcimadamore@580 246 /** Warn about unsafe vararg method decl.
mcimadamore@580 247 * @param pos Position to be used for error reporting.
mcimadamore@580 248 */
mcimadamore@795 249 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 250 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 251 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 252 }
mcimadamore@580 253
jjg@582 254 /** Warn about using proprietary API.
jjg@377 255 * @param pos Position to be used for error reporting.
jjg@377 256 * @param msg A string describing the problem.
jjg@377 257 */
jjg@377 258 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 259 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 260 sunApiHandler.report(pos, msg, args);
jjg@377 261 }
jjg@377 262
jjg@505 263 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 264 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 265 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 266 }
jjg@505 267
duke@1 268 /**
duke@1 269 * Report any deferred diagnostics.
duke@1 270 */
duke@1 271 public void reportDeferredDiagnostics() {
duke@1 272 deprecationHandler.reportDeferredDiagnostic();
duke@1 273 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 274 sunApiHandler.reportDeferredDiagnostic();
duke@1 275 }
duke@1 276
duke@1 277
duke@1 278 /** Report a failure to complete a class.
duke@1 279 * @param pos Position to be used for error reporting.
duke@1 280 * @param ex The failure to report.
duke@1 281 */
duke@1 282 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
mcimadamore@1613 283 log.error(JCDiagnostic.DiagnosticFlag.NON_DEFERRABLE, pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 284 if (ex instanceof ClassReader.BadClassFile
jjg@576 285 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 286 else return syms.errType;
duke@1 287 }
duke@1 288
duke@1 289 /** Report an error that wrong type tag was found.
duke@1 290 * @param pos Position to be used for error reporting.
duke@1 291 * @param required An internationalized string describing the type tag
duke@1 292 * required.
duke@1 293 * @param found The type that was found.
duke@1 294 */
duke@1 295 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 296 // this error used to be raised by the parser,
jrose@267 297 // but has been delayed to this point:
jjg@1374 298 if (found instanceof Type && ((Type)found).hasTag(VOID)) {
jrose@267 299 log.error(pos, "illegal.start.of.type");
jrose@267 300 return syms.errType;
jrose@267 301 }
duke@1 302 log.error(pos, "type.found.req", found, required);
jjg@110 303 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 304 }
duke@1 305
duke@1 306 /** Report an error that symbol cannot be referenced before super
duke@1 307 * has been called.
duke@1 308 * @param pos Position to be used for error reporting.
duke@1 309 * @param sym The referenced symbol.
duke@1 310 */
duke@1 311 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 312 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 313 }
duke@1 314
duke@1 315 /** Report duplicate declaration error.
duke@1 316 */
duke@1 317 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 318 if (!sym.type.isErroneous()) {
mcimadamore@1085 319 Symbol location = sym.location();
mcimadamore@1085 320 if (location.kind == MTH &&
mcimadamore@1085 321 ((MethodSymbol)location).isStaticOrInstanceInit()) {
mcimadamore@1085 322 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
mcimadamore@1085 323 kindName(sym.location()), kindName(sym.location().enclClass()),
mcimadamore@1085 324 sym.location().enclClass());
mcimadamore@1085 325 } else {
mcimadamore@1085 326 log.error(pos, "already.defined", kindName(sym), sym,
mcimadamore@1085 327 kindName(sym.location()), sym.location());
mcimadamore@1085 328 }
duke@1 329 }
duke@1 330 }
duke@1 331
duke@1 332 /** Report array/varargs duplicate declaration
duke@1 333 */
duke@1 334 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 335 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 336 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 337 }
duke@1 338 }
duke@1 339
duke@1 340 /* ************************************************************************
duke@1 341 * duplicate declaration checking
duke@1 342 *************************************************************************/
duke@1 343
duke@1 344 /** Check that variable does not hide variable with same name in
duke@1 345 * immediately enclosing local scope.
duke@1 346 * @param pos Position for error reporting.
duke@1 347 * @param v The symbol.
duke@1 348 * @param s The scope.
duke@1 349 */
duke@1 350 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 351 if (s.next != null) {
duke@1 352 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 353 e.scope != null && e.sym.owner == v.owner;
duke@1 354 e = e.next()) {
duke@1 355 if (e.sym.kind == VAR &&
duke@1 356 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 357 v.name != names.error) {
duke@1 358 duplicateError(pos, e.sym);
duke@1 359 return;
duke@1 360 }
duke@1 361 }
duke@1 362 }
duke@1 363 }
duke@1 364
duke@1 365 /** Check that a class or interface does not hide a class or
duke@1 366 * interface with same name in immediately enclosing local scope.
duke@1 367 * @param pos Position for error reporting.
duke@1 368 * @param c The symbol.
duke@1 369 * @param s The scope.
duke@1 370 */
duke@1 371 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 372 if (s.next != null) {
duke@1 373 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 374 e.scope != null && e.sym.owner == c.owner;
duke@1 375 e = e.next()) {
jjg@1374 376 if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) &&
duke@1 377 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 378 c.name != names.error) {
duke@1 379 duplicateError(pos, e.sym);
duke@1 380 return;
duke@1 381 }
duke@1 382 }
duke@1 383 }
duke@1 384 }
duke@1 385
duke@1 386 /** Check that class does not have the same name as one of
duke@1 387 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 388 * return true if class is unique in its enclosing scope.
duke@1 389 * @param pos Position for error reporting.
duke@1 390 * @param name The class name.
duke@1 391 * @param s The enclosing scope.
duke@1 392 */
duke@1 393 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 394 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 395 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 396 duplicateError(pos, e.sym);
duke@1 397 return false;
duke@1 398 }
duke@1 399 }
duke@1 400 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 401 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 402 duplicateError(pos, sym);
duke@1 403 return true;
duke@1 404 }
duke@1 405 }
duke@1 406 return true;
duke@1 407 }
duke@1 408
duke@1 409 /* *************************************************************************
duke@1 410 * Class name generation
duke@1 411 **************************************************************************/
duke@1 412
duke@1 413 /** Return name of local class.
jjg@1358 414 * This is of the form {@code <enclClass> $ n <classname> }
duke@1 415 * where
duke@1 416 * enclClass is the flat name of the enclosing class,
duke@1 417 * classname is the simple name of the local class
duke@1 418 */
duke@1 419 Name localClassName(ClassSymbol c) {
duke@1 420 for (int i=1; ; i++) {
duke@1 421 Name flatname = names.
duke@1 422 fromString("" + c.owner.enclClass().flatname +
jjg@398 423 syntheticNameChar + i +
duke@1 424 c.name);
duke@1 425 if (compiled.get(flatname) == null) return flatname;
duke@1 426 }
duke@1 427 }
duke@1 428
duke@1 429 /* *************************************************************************
duke@1 430 * Type Checking
duke@1 431 **************************************************************************/
duke@1 432
mcimadamore@1238 433 /**
mcimadamore@1238 434 * A check context is an object that can be used to perform compatibility
mcimadamore@1238 435 * checks - depending on the check context, meaning of 'compatibility' might
mcimadamore@1238 436 * vary significantly.
mcimadamore@1238 437 */
mcimadamore@1348 438 public interface CheckContext {
mcimadamore@1238 439 /**
mcimadamore@1238 440 * Is type 'found' compatible with type 'req' in given context
mcimadamore@1238 441 */
mcimadamore@1238 442 boolean compatible(Type found, Type req, Warner warn);
mcimadamore@1238 443 /**
mcimadamore@1238 444 * Report a check error
mcimadamore@1238 445 */
mcimadamore@1296 446 void report(DiagnosticPosition pos, JCDiagnostic details);
mcimadamore@1238 447 /**
mcimadamore@1238 448 * Obtain a warner for this check context
mcimadamore@1238 449 */
mcimadamore@1238 450 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
mcimadamore@1337 451
mcimadamore@1337 452 public Infer.InferenceContext inferenceContext();
mcimadamore@1347 453
mcimadamore@1347 454 public DeferredAttr.DeferredAttrContext deferredAttrContext();
mcimadamore@1238 455 }
mcimadamore@1238 456
mcimadamore@1238 457 /**
mcimadamore@1238 458 * This class represent a check context that is nested within another check
mcimadamore@1238 459 * context - useful to check sub-expressions. The default behavior simply
mcimadamore@1238 460 * redirects all method calls to the enclosing check context leveraging
mcimadamore@1238 461 * the forwarding pattern.
mcimadamore@1238 462 */
mcimadamore@1238 463 static class NestedCheckContext implements CheckContext {
mcimadamore@1238 464 CheckContext enclosingContext;
mcimadamore@1238 465
mcimadamore@1238 466 NestedCheckContext(CheckContext enclosingContext) {
mcimadamore@1238 467 this.enclosingContext = enclosingContext;
mcimadamore@1238 468 }
mcimadamore@1238 469
mcimadamore@1238 470 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 471 return enclosingContext.compatible(found, req, warn);
mcimadamore@1238 472 }
mcimadamore@1238 473
mcimadamore@1296 474 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 475 enclosingContext.report(pos, details);
mcimadamore@1238 476 }
mcimadamore@1238 477
mcimadamore@1238 478 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 479 return enclosingContext.checkWarner(pos, found, req);
mcimadamore@1238 480 }
mcimadamore@1337 481
mcimadamore@1337 482 public Infer.InferenceContext inferenceContext() {
mcimadamore@1337 483 return enclosingContext.inferenceContext();
mcimadamore@1337 484 }
mcimadamore@1347 485
mcimadamore@1347 486 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 487 return enclosingContext.deferredAttrContext();
mcimadamore@1347 488 }
mcimadamore@1238 489 }
mcimadamore@1238 490
mcimadamore@1238 491 /**
mcimadamore@1238 492 * Check context to be used when evaluating assignment/return statements
mcimadamore@1238 493 */
mcimadamore@1238 494 CheckContext basicHandler = new CheckContext() {
mcimadamore@1296 495 public void report(DiagnosticPosition pos, JCDiagnostic details) {
mcimadamore@1296 496 log.error(pos, "prob.found.req", details);
mcimadamore@1238 497 }
mcimadamore@1238 498 public boolean compatible(Type found, Type req, Warner warn) {
mcimadamore@1238 499 return types.isAssignable(found, req, warn);
mcimadamore@1238 500 }
mcimadamore@1238 501
mcimadamore@1238 502 public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 503 return convertWarner(pos, found, req);
mcimadamore@1238 504 }
mcimadamore@1337 505
mcimadamore@1337 506 public InferenceContext inferenceContext() {
mcimadamore@1337 507 return infer.emptyContext;
mcimadamore@1337 508 }
mcimadamore@1347 509
mcimadamore@1347 510 public DeferredAttrContext deferredAttrContext() {
mcimadamore@1347 511 return deferredAttr.emptyDeferredAttrContext;
mcimadamore@1347 512 }
mcimadamore@1238 513 };
mcimadamore@1238 514
duke@1 515 /** Check that a given type is assignable to a given proto-type.
duke@1 516 * If it is, return the type, otherwise return errType.
duke@1 517 * @param pos Position to be used for error reporting.
duke@1 518 * @param found The type that was found.
duke@1 519 * @param req The type that was required.
duke@1 520 */
duke@1 521 Type checkType(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 522 return checkType(pos, found, req, basicHandler);
darcy@609 523 }
darcy@609 524
mcimadamore@1337 525 Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
mcimadamore@1337 526 final Infer.InferenceContext inferenceContext = checkContext.inferenceContext();
mcimadamore@1337 527 if (inferenceContext.free(req)) {
mcimadamore@1337 528 inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() {
mcimadamore@1337 529 @Override
mcimadamore@1337 530 public void typesInferred(InferenceContext inferenceContext) {
vromero@2157 531 checkType(pos, inferenceContext.asInstType(found), inferenceContext.asInstType(req), checkContext);
mcimadamore@1337 532 }
mcimadamore@1337 533 });
mcimadamore@1337 534 }
jjg@1374 535 if (req.hasTag(ERROR))
duke@1 536 return req;
jjg@1374 537 if (req.hasTag(NONE))
duke@1 538 return found;
mcimadamore@1238 539 if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
duke@1 540 return found;
mcimadamore@1238 541 } else {
vromero@1826 542 if (found.isNumeric() && req.isNumeric()) {
mcimadamore@1296 543 checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
mcimadamore@1238 544 return types.createErrorType(found);
mcimadamore@1238 545 }
mcimadamore@1296 546 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
jjg@110 547 return types.createErrorType(found);
duke@1 548 }
duke@1 549 }
duke@1 550
duke@1 551 /** Check that a given type can be cast to a given target type.
duke@1 552 * Return the result of the cast.
duke@1 553 * @param pos Position to be used for error reporting.
duke@1 554 * @param found The type that is being cast.
duke@1 555 * @param req The target type of the cast.
duke@1 556 */
duke@1 557 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
mcimadamore@1238 558 return checkCastable(pos, found, req, basicHandler);
mcimadamore@1238 559 }
mcimadamore@1238 560 Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
mcimadamore@1268 561 if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 562 return req;
duke@1 563 } else {
mcimadamore@1296 564 checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
mcimadamore@1238 565 return types.createErrorType(found);
duke@1 566 }
duke@1 567 }
mcimadamore@1237 568
mcimadamore@1237 569 /** Check for redundant casts (i.e. where source type is a subtype of target type)
mcimadamore@1237 570 * The problem should only be reported for non-292 cast
mcimadamore@1237 571 */
jlahoda@2028 572 public void checkRedundantCast(Env<AttrContext> env, final JCTypeCast tree) {
jlahoda@2028 573 if (!tree.type.isErroneous()
mcimadamore@1348 574 && types.isSameType(tree.expr.type, tree.clazz.type)
jjg@1521 575 && !(ignoreAnnotatedCasts && TreeInfo.containsTypeAnnotation(tree.clazz))
mcimadamore@1348 576 && !is292targetTypeCast(tree)) {
jlahoda@2028 577 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
jlahoda@2028 578 @Override
jlahoda@2028 579 public void report() {
jlahoda@2028 580 if (lint.isEnabled(Lint.LintCategory.CAST))
jlahoda@2028 581 log.warning(Lint.LintCategory.CAST,
jlahoda@2028 582 tree.pos(), "redundant.cast", tree.expr.type);
jlahoda@2028 583 }
jlahoda@2028 584 });
mcimadamore@1237 585 }
mcimadamore@1237 586 }
mcimadamore@1237 587 //where
jjg@1521 588 private boolean is292targetTypeCast(JCTypeCast tree) {
jjg@1521 589 boolean is292targetTypeCast = false;
jjg@1521 590 JCExpression expr = TreeInfo.skipParens(tree.expr);
jjg@1521 591 if (expr.hasTag(APPLY)) {
jjg@1521 592 JCMethodInvocation apply = (JCMethodInvocation)expr;
jjg@1521 593 Symbol sym = TreeInfo.symbol(apply.meth);
jjg@1521 594 is292targetTypeCast = sym != null &&
jjg@1521 595 sym.kind == MTH &&
jjg@1521 596 (sym.flags() & HYPOTHETICAL) != 0;
mcimadamore@1237 597 }
jjg@1521 598 return is292targetTypeCast;
jjg@1521 599 }
mcimadamore@1237 600
jjg@1521 601 private static final boolean ignoreAnnotatedCasts = true;
duke@1 602
duke@1 603 /** Check that a type is within some bounds.
duke@1 604 *
jjg@1358 605 * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
duke@1 606 * type argument.
duke@1 607 * @param a The type that should be bounded by bs.
jjg@1358 608 * @param bound The bound.
duke@1 609 */
mcimadamore@1216 610 private boolean checkExtends(Type a, Type bound) {
mcimadamore@154 611 if (a.isUnbound()) {
mcimadamore@821 612 return true;
jjg@1374 613 } else if (!a.hasTag(WILDCARD)) {
mcimadamore@154 614 a = types.upperBound(a);
mcimadamore@1216 615 return types.isSubtype(a, bound);
mcimadamore@154 616 } else if (a.isExtendsBound()) {
mcimadamore@1415 617 return types.isCastable(bound, types.upperBound(a), types.noWarnings);
mcimadamore@154 618 } else if (a.isSuperBound()) {
mcimadamore@1216 619 return !types.notSoftSubtype(types.lowerBound(a), bound);
mcimadamore@154 620 }
mcimadamore@821 621 return true;
mcimadamore@154 622 }
duke@1 623
duke@1 624 /** Check that type is different from 'void'.
duke@1 625 * @param pos Position to be used for error reporting.
duke@1 626 * @param t The type to be checked.
duke@1 627 */
duke@1 628 Type checkNonVoid(DiagnosticPosition pos, Type t) {
jjg@1374 629 if (t.hasTag(VOID)) {
duke@1 630 log.error(pos, "void.not.allowed.here");
jjg@110 631 return types.createErrorType(t);
duke@1 632 } else {
duke@1 633 return t;
duke@1 634 }
duke@1 635 }
duke@1 636
mcimadamore@1496 637 Type checkClassOrArrayType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 638 if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
mcimadamore@1496 639 return typeTagError(pos,
mcimadamore@1496 640 diags.fragment("type.req.class.array"),
mcimadamore@1496 641 asTypeParam(t));
mcimadamore@1496 642 } else {
mcimadamore@1496 643 return t;
mcimadamore@1496 644 }
mcimadamore@1496 645 }
mcimadamore@1496 646
duke@1 647 /** Check that type is a class or interface type.
duke@1 648 * @param pos Position to be used for error reporting.
duke@1 649 * @param t The type to be checked.
duke@1 650 */
duke@1 651 Type checkClassType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 652 if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) {
duke@1 653 return typeTagError(pos,
mcimadamore@89 654 diags.fragment("type.req.class"),
mcimadamore@1496 655 asTypeParam(t));
mcimadamore@1496 656 } else {
duke@1 657 return t;
mcimadamore@1496 658 }
duke@1 659 }
mcimadamore@1496 660 //where
mcimadamore@1496 661 private Object asTypeParam(Type t) {
mcimadamore@1496 662 return (t.hasTag(TYPEVAR))
mcimadamore@1496 663 ? diags.fragment("type.parameter", t)
mcimadamore@1496 664 : t;
mcimadamore@1496 665 }
duke@1 666
mcimadamore@1352 667 /** Check that type is a valid qualifier for a constructor reference expression
mcimadamore@1352 668 */
mcimadamore@1352 669 Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
mcimadamore@1496 670 t = checkClassOrArrayType(pos, t);
jjg@1374 671 if (t.hasTag(CLASS)) {
mcimadamore@1352 672 if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
mcimadamore@1627 673 log.error(pos, "abstract.cant.be.instantiated", t.tsym);
mcimadamore@1352 674 t = types.createErrorType(t);
mcimadamore@1352 675 } else if ((t.tsym.flags() & ENUM) != 0) {
mcimadamore@1352 676 log.error(pos, "enum.cant.be.instantiated");
mcimadamore@1352 677 t = types.createErrorType(t);
mcimadamore@1627 678 } else {
mcimadamore@1627 679 t = checkClassType(pos, t, true);
mcimadamore@1627 680 }
mcimadamore@1627 681 } else if (t.hasTag(ARRAY)) {
mcimadamore@1627 682 if (!types.isReifiable(((ArrayType)t).elemtype)) {
mcimadamore@1627 683 log.error(pos, "generic.array.creation");
mcimadamore@1627 684 t = types.createErrorType(t);
mcimadamore@1352 685 }
mcimadamore@1352 686 }
mcimadamore@1352 687 return t;
mcimadamore@1352 688 }
mcimadamore@1352 689
duke@1 690 /** Check that type is a class or interface type.
duke@1 691 * @param pos Position to be used for error reporting.
duke@1 692 * @param t The type to be checked.
duke@1 693 * @param noBounds True if type bounds are illegal here.
duke@1 694 */
duke@1 695 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 696 t = checkClassType(pos, t);
duke@1 697 if (noBounds && t.isParameterized()) {
duke@1 698 List<Type> args = t.getTypeArguments();
duke@1 699 while (args.nonEmpty()) {
jjg@1374 700 if (args.head.hasTag(WILDCARD))
duke@1 701 return typeTagError(pos,
jjg@598 702 diags.fragment("type.req.exact"),
duke@1 703 args.head);
duke@1 704 args = args.tail;
duke@1 705 }
duke@1 706 }
duke@1 707 return t;
duke@1 708 }
duke@1 709
duke@1 710 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 711 * or a type variable.
duke@1 712 * @param pos Position to be used for error reporting.
duke@1 713 * @param t The type to be checked.
duke@1 714 */
duke@1 715 Type checkRefType(DiagnosticPosition pos, Type t) {
jjg@1374 716 if (t.isReference())
duke@1 717 return t;
jjg@1374 718 else
duke@1 719 return typeTagError(pos,
mcimadamore@89 720 diags.fragment("type.req.ref"),
duke@1 721 t);
duke@1 722 }
duke@1 723
jrose@267 724 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 725 * or a type variable.
jrose@267 726 * @param trees Original trees, used for error reporting.
jrose@267 727 * @param types The types to be checked.
jrose@267 728 */
jrose@267 729 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 730 List<JCExpression> tl = trees;
jrose@267 731 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 732 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 733 tl = tl.tail;
jrose@267 734 }
jrose@267 735 return types;
jrose@267 736 }
jrose@267 737
duke@1 738 /** Check that type is a null or reference type.
duke@1 739 * @param pos Position to be used for error reporting.
duke@1 740 * @param t The type to be checked.
duke@1 741 */
duke@1 742 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
vromero@1826 743 if (t.isReference() || t.hasTag(BOT))
duke@1 744 return t;
jjg@1374 745 else
duke@1 746 return typeTagError(pos,
mcimadamore@89 747 diags.fragment("type.req.ref"),
duke@1 748 t);
duke@1 749 }
duke@1 750
duke@1 751 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 752 * Return true if it doesn't.
duke@1 753 * @param pos Position to be used for error reporting.
duke@1 754 * @param flags The set of flags to be checked.
duke@1 755 * @param set1 Conflicting flags set #1.
duke@1 756 * @param set2 Conflicting flags set #2.
duke@1 757 */
duke@1 758 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 759 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 760 log.error(pos,
duke@1 761 "illegal.combination.of.modifiers",
mcimadamore@80 762 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 763 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 764 return false;
duke@1 765 } else
duke@1 766 return true;
duke@1 767 }
duke@1 768
mcimadamore@914 769 /** Check that usage of diamond operator is correct (i.e. diamond should not
mcimadamore@914 770 * be used with non-generic classes or in anonymous class creation expressions)
mcimadamore@537 771 */
mcimadamore@914 772 Type checkDiamond(JCNewClass tree, Type t) {
mcimadamore@914 773 if (!TreeInfo.isDiamond(tree) ||
mcimadamore@914 774 t.isErroneous()) {
mcimadamore@914 775 return checkClassType(tree.clazz.pos(), t, true);
mcimadamore@914 776 } else if (tree.def != null) {
mcimadamore@914 777 log.error(tree.clazz.pos(),
mcimadamore@914 778 "cant.apply.diamond.1",
mcimadamore@914 779 t, diags.fragment("diamond.and.anon.class", t));
mcimadamore@914 780 return types.createErrorType(t);
mcimadamore@948 781 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
mcimadamore@914 782 log.error(tree.clazz.pos(),
mcimadamore@914 783 "cant.apply.diamond.1",
mcimadamore@914 784 t, diags.fragment("diamond.non.generic", t));
mcimadamore@914 785 return types.createErrorType(t);
mcimadamore@993 786 } else if (tree.typeargs != null &&
mcimadamore@993 787 tree.typeargs.nonEmpty()) {
mcimadamore@993 788 log.error(tree.clazz.pos(),
mcimadamore@993 789 "cant.apply.diamond.1",
mcimadamore@993 790 t, diags.fragment("diamond.and.explicit.params", t));
mcimadamore@993 791 return types.createErrorType(t);
mcimadamore@914 792 } else {
mcimadamore@914 793 return t;
mcimadamore@537 794 }
mcimadamore@537 795 }
mcimadamore@537 796
mcimadamore@795 797 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 798 MethodSymbol m = tree.sym;
mcimadamore@795 799 if (!allowSimplifiedVarargs) return;
mcimadamore@795 800 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 801 Type varargElemType = null;
mcimadamore@580 802 if (m.isVarArgs()) {
mcimadamore@795 803 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 804 }
mcimadamore@795 805 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 806 if (varargElemType != null) {
mcimadamore@795 807 log.error(tree,
mcimadamore@795 808 "varargs.invalid.trustme.anno",
mcimadamore@795 809 syms.trustMeType.tsym,
mcimadamore@795 810 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 811 } else {
mcimadamore@795 812 log.error(tree,
mcimadamore@795 813 "varargs.invalid.trustme.anno",
mcimadamore@795 814 syms.trustMeType.tsym,
mcimadamore@795 815 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 816 }
mcimadamore@795 817 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 818 types.isReifiable(varargElemType)) {
mcimadamore@795 819 warnUnsafeVararg(tree,
mcimadamore@795 820 "varargs.redundant.trustme.anno",
mcimadamore@795 821 syms.trustMeType.tsym,
mcimadamore@795 822 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 823 }
mcimadamore@795 824 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 825 !types.isReifiable(varargElemType)) {
mcimadamore@795 826 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 827 }
mcimadamore@580 828 }
mcimadamore@795 829 //where
mcimadamore@795 830 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 831 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 832 (s.isConstructor() ||
mcimadamore@795 833 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 834 }
mcimadamore@580 835
mcimadamore@1812 836 Type checkMethod(final Type mtype,
mcimadamore@1812 837 final Symbol sym,
mcimadamore@1812 838 final Env<AttrContext> env,
mcimadamore@1812 839 final List<JCExpression> argtrees,
mcimadamore@1812 840 final List<Type> argtypes,
mcimadamore@1812 841 final boolean useVarargs,
mcimadamore@1812 842 InferenceContext inferenceContext) {
mcimadamore@1219 843 // System.out.println("call : " + env.tree);
mcimadamore@1219 844 // System.out.println("method : " + owntype);
mcimadamore@1219 845 // System.out.println("actuals: " + argtypes);
mcimadamore@1812 846 if (inferenceContext.free(mtype)) {
mcimadamore@1812 847 inferenceContext.addFreeTypeListener(List.of(mtype), new FreeTypeListener() {
mcimadamore@1812 848 public void typesInferred(InferenceContext inferenceContext) {
mcimadamore@1812 849 checkMethod(inferenceContext.asInstType(mtype), sym, env, argtrees, argtypes, useVarargs, inferenceContext);
mcimadamore@1812 850 }
mcimadamore@1812 851 });
mcimadamore@1812 852 return mtype;
mcimadamore@1812 853 }
mcimadamore@1812 854 Type owntype = mtype;
mcimadamore@1219 855 List<Type> formals = owntype.getParameterTypes();
kizune@1959 856 List<Type> nonInferred = sym.type.getParameterTypes();
kizune@1959 857 if (nonInferred.length() != formals.length()) nonInferred = formals;
mcimadamore@1219 858 Type last = useVarargs ? formals.last() : null;
kizune@1959 859 if (sym.name == names.init && sym.owner == syms.enumSym) {
kizune@1959 860 formals = formals.tail.tail;
kizune@1959 861 nonInferred = nonInferred.tail.tail;
kizune@1959 862 }
mcimadamore@1219 863 List<JCExpression> args = argtrees;
mcimadamore@1352 864 if (args != null) {
mcimadamore@1352 865 //this is null when type-checking a method reference
mcimadamore@1352 866 while (formals.head != last) {
mcimadamore@1219 867 JCTree arg = args.head;
kizune@1959 868 Warner warn = convertWarner(arg.pos(), arg.type, nonInferred.head);
mcimadamore@1352 869 assertConvertible(arg, arg.type, formals.head, warn);
mcimadamore@1219 870 args = args.tail;
mcimadamore@1352 871 formals = formals.tail;
kizune@1959 872 nonInferred = nonInferred.tail;
mcimadamore@1219 873 }
mcimadamore@1352 874 if (useVarargs) {
mcimadamore@1352 875 Type varArg = types.elemtype(last);
mcimadamore@1352 876 while (args.tail != null) {
mcimadamore@1352 877 JCTree arg = args.head;
mcimadamore@1352 878 Warner warn = convertWarner(arg.pos(), arg.type, varArg);
mcimadamore@1352 879 assertConvertible(arg, arg.type, varArg, warn);
mcimadamore@1352 880 args = args.tail;
mcimadamore@1352 881 }
mcimadamore@1904 882 } else if ((sym.flags() & (VARARGS | SIGNATURE_POLYMORPHIC)) == VARARGS &&
mcimadamore@1904 883 allowVarargs) {
mcimadamore@1352 884 // non-varargs call to varargs method
mcimadamore@1352 885 Type varParam = owntype.getParameterTypes().last();
mcimadamore@1812 886 Type lastArg = argtypes.last();
mcimadamore@1352 887 if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
kizune@1959 888 !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
mcimadamore@1352 889 log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
kizune@1959 890 types.elemtype(varParam), varParam);
mcimadamore@1352 891 }
mcimadamore@1219 892 }
mcimadamore@1219 893 if (useVarargs) {
mcimadamore@1219 894 Type argtype = owntype.getParameterTypes().last();
mcimadamore@1219 895 if (!types.isReifiable(argtype) &&
kizune@1959 896 (!allowSimplifiedVarargs ||
kizune@1959 897 sym.attribute(syms.trustMeType.tsym) == null ||
kizune@1959 898 !isTrustMeAllowedOnMethod(sym))) {
mcimadamore@1219 899 warnUnchecked(env.tree.pos(),
mcimadamore@1219 900 "unchecked.generic.array.creation",
mcimadamore@1219 901 argtype);
mcimadamore@1219 902 }
vromero@1820 903 if ((sym.baseSymbol().flags() & SIGNATURE_POLYMORPHIC) == 0) {
mcimadamore@1812 904 TreeInfo.setVarargsElement(env.tree, types.elemtype(argtype));
mcimadamore@1219 905 }
mcimadamore@1219 906 }
mcimadamore@1510 907 PolyKind pkind = (sym.type.hasTag(FORALL) &&
mcimadamore@1510 908 sym.type.getReturnType().containsAny(((ForAll)sym.type).tvars)) ?
mcimadamore@1510 909 PolyKind.POLY : PolyKind.STANDALONE;
mcimadamore@1510 910 TreeInfo.setPolyKind(env.tree, pkind);
mcimadamore@1219 911 return owntype;
mcimadamore@547 912 }
mcimadamore@1219 913 //where
kizune@1959 914 private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
kizune@1959 915 if (types.isConvertible(actual, formal, warn))
kizune@1959 916 return;
kizune@1959 917
kizune@1959 918 if (formal.isCompound()
kizune@1959 919 && types.isSubtype(actual, types.supertype(formal))
kizune@1959 920 && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
kizune@1959 921 return;
kizune@1959 922 }
mcimadamore@547 923
mcimadamore@821 924 /**
mcimadamore@821 925 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 926 * (see JLS 4.5)
mcimadamore@821 927 *
mcimadamore@821 928 * @param t class type to be checked
mcimadamore@821 929 * @return true if 't' is well-formed
mcimadamore@821 930 */
mcimadamore@821 931 public boolean checkValidGenericType(Type t) {
mcimadamore@821 932 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 933 }
mcimadamore@821 934 //WHERE
mcimadamore@821 935 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 936 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 937 List<Type> actuals = type.allparams();
mcimadamore@821 938 List<Type> args = type.getTypeArguments();
mcimadamore@821 939 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@1216 940 ListBuffer<Type> bounds_buf = new ListBuffer<Type>();
mcimadamore@821 941
mcimadamore@821 942 // For matching pairs of actual argument types `a' and
mcimadamore@821 943 // formal type parameters with declared bound `b' ...
mcimadamore@821 944 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 945 // exact type arguments needs to know their
mcimadamore@821 946 // bounds (for upper and lower bound
mcimadamore@1216 947 // calculations). So we create new bounds where
mcimadamore@1216 948 // type-parameters are replaced with actuals argument types.
mcimadamore@1216 949 bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
mcimadamore@821 950 args = args.tail;
mcimadamore@821 951 forms = forms.tail;
mcimadamore@821 952 }
mcimadamore@821 953
mcimadamore@821 954 args = type.getTypeArguments();
mcimadamore@821 955 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 956 formals,
mcimadamore@821 957 types.capture(type).allparams());
mcimadamore@821 958 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 959 // Let the actual arguments know their bound
mcimadamore@821 960 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 961 args = args.tail;
mcimadamore@821 962 tvars_cap = tvars_cap.tail;
mcimadamore@821 963 }
mcimadamore@821 964
mcimadamore@821 965 args = type.getTypeArguments();
mcimadamore@1216 966 List<Type> bounds = bounds_buf.toList();
mcimadamore@821 967
mcimadamore@1216 968 while (args.nonEmpty() && bounds.nonEmpty()) {
mcimadamore@1216 969 Type actual = args.head;
mcimadamore@854 970 if (!isTypeArgErroneous(actual) &&
mcimadamore@1216 971 !bounds.head.isErroneous() &&
mcimadamore@1216 972 !checkExtends(actual, bounds.head)) {
mcimadamore@821 973 return args.head;
mcimadamore@821 974 }
mcimadamore@821 975 args = args.tail;
mcimadamore@1216 976 bounds = bounds.tail;
mcimadamore@821 977 }
mcimadamore@821 978
mcimadamore@821 979 args = type.getTypeArguments();
mcimadamore@1216 980 bounds = bounds_buf.toList();
mcimadamore@821 981
mcimadamore@821 982 for (Type arg : types.capture(type).getTypeArguments()) {
jjg@1374 983 if (arg.hasTag(TYPEVAR) &&
mcimadamore@828 984 arg.getUpperBound().isErroneous() &&
mcimadamore@1216 985 !bounds.head.isErroneous() &&
mcimadamore@854 986 !isTypeArgErroneous(args.head)) {
mcimadamore@821 987 return args.head;
mcimadamore@821 988 }
mcimadamore@1216 989 bounds = bounds.tail;
mcimadamore@854 990 args = args.tail;
mcimadamore@821 991 }
mcimadamore@821 992
mcimadamore@821 993 return null;
mcimadamore@821 994 }
mcimadamore@854 995 //where
mcimadamore@854 996 boolean isTypeArgErroneous(Type t) {
mcimadamore@854 997 return isTypeArgErroneous.visit(t);
mcimadamore@854 998 }
mcimadamore@854 999
mcimadamore@854 1000 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
mcimadamore@854 1001 public Boolean visitType(Type t, Void s) {
mcimadamore@854 1002 return t.isErroneous();
mcimadamore@854 1003 }
mcimadamore@854 1004 @Override
mcimadamore@854 1005 public Boolean visitTypeVar(TypeVar t, Void s) {
mcimadamore@854 1006 return visit(t.getUpperBound());
mcimadamore@854 1007 }
mcimadamore@854 1008 @Override
mcimadamore@854 1009 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@854 1010 return visit(t.getUpperBound()) ||
mcimadamore@854 1011 visit(t.getLowerBound());
mcimadamore@854 1012 }
mcimadamore@854 1013 @Override
mcimadamore@854 1014 public Boolean visitWildcardType(WildcardType t, Void s) {
mcimadamore@854 1015 return visit(t.type);
mcimadamore@854 1016 }
mcimadamore@854 1017 };
mcimadamore@821 1018
duke@1 1019 /** Check that given modifiers are legal for given symbol and
vromero@1555 1020 * return modifiers together with any implicit modifiers for that symbol.
duke@1 1021 * Warning: we can't use flags() here since this method
duke@1 1022 * is called during class enter, when flags() would cause a premature
duke@1 1023 * completion.
duke@1 1024 * @param pos Position to be used for error reporting.
duke@1 1025 * @param flags The set of modifiers given in a definition.
duke@1 1026 * @param sym The defined symbol.
duke@1 1027 */
duke@1 1028 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 1029 long mask;
duke@1 1030 long implicit = 0;
emc@2016 1031
duke@1 1032 switch (sym.kind) {
duke@1 1033 case VAR:
duke@1 1034 if (sym.owner.kind != TYP)
duke@1 1035 mask = LocalVarFlags;
duke@1 1036 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 1037 mask = implicit = InterfaceVarFlags;
duke@1 1038 else
duke@1 1039 mask = VarFlags;
duke@1 1040 break;
duke@1 1041 case MTH:
duke@1 1042 if (sym.name == names.init) {
duke@1 1043 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 1044 // enum constructors cannot be declared public or
duke@1 1045 // protected and must be implicitly or explicitly
duke@1 1046 // private
duke@1 1047 implicit = PRIVATE;
duke@1 1048 mask = PRIVATE;
duke@1 1049 } else
duke@1 1050 mask = ConstructorFlags;
mcimadamore@1366 1051 } else if ((sym.owner.flags_field & INTERFACE) != 0) {
emc@2016 1052 if ((sym.owner.flags_field & ANNOTATION) != 0) {
emc@2016 1053 mask = AnnotationTypeElementMask;
emc@2016 1054 implicit = PUBLIC | ABSTRACT;
emc@2016 1055 } else if ((flags & (DEFAULT | STATIC)) != 0) {
mcimadamore@1513 1056 mask = InterfaceMethodMask;
mcimadamore@1513 1057 implicit = PUBLIC;
mcimadamore@1513 1058 if ((flags & DEFAULT) != 0) {
mcimadamore@1513 1059 implicit |= ABSTRACT;
mcimadamore@1513 1060 }
mcimadamore@1366 1061 } else {
mcimadamore@1366 1062 mask = implicit = InterfaceMethodFlags;
mcimadamore@1366 1063 }
emc@2016 1064 } else {
duke@1 1065 mask = MethodFlags;
duke@1 1066 }
duke@1 1067 // Imply STRICTFP if owner has STRICTFP set.
vromero@1712 1068 if (((flags|implicit) & Flags.ABSTRACT) == 0 ||
vromero@1712 1069 ((flags) & Flags.DEFAULT) != 0)
vromero@1555 1070 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1071 break;
duke@1 1072 case TYP:
duke@1 1073 if (sym.isLocal()) {
duke@1 1074 mask = LocalClassFlags;
jjg@113 1075 if (sym.name.isEmpty()) { // Anonymous class
duke@1 1076 // Anonymous classes in static methods are themselves static;
duke@1 1077 // that's why we admit STATIC here.
duke@1 1078 mask |= STATIC;
duke@1 1079 // JLS: Anonymous classes are final.
duke@1 1080 implicit |= FINAL;
duke@1 1081 }
duke@1 1082 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 1083 (flags & ENUM) != 0)
duke@1 1084 log.error(pos, "enums.must.be.static");
duke@1 1085 } else if (sym.owner.kind == TYP) {
duke@1 1086 mask = MemberClassFlags;
duke@1 1087 if (sym.owner.owner.kind == PCK ||
duke@1 1088 (sym.owner.flags_field & STATIC) != 0)
duke@1 1089 mask |= STATIC;
duke@1 1090 else if ((flags & ENUM) != 0)
duke@1 1091 log.error(pos, "enums.must.be.static");
duke@1 1092 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 1093 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 1094 } else {
duke@1 1095 mask = ClassFlags;
duke@1 1096 }
duke@1 1097 // Interfaces are always ABSTRACT
duke@1 1098 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 1099
duke@1 1100 if ((flags & ENUM) != 0) {
duke@1 1101 // enums can't be declared abstract or final
duke@1 1102 mask &= ~(ABSTRACT | FINAL);
duke@1 1103 implicit |= implicitEnumFinalFlag(tree);
duke@1 1104 }
duke@1 1105 // Imply STRICTFP if owner has STRICTFP set.
duke@1 1106 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 1107 break;
duke@1 1108 default:
duke@1 1109 throw new AssertionError();
duke@1 1110 }
mcimadamore@1366 1111 long illegal = flags & ExtendedStandardFlags & ~mask;
duke@1 1112 if (illegal != 0) {
duke@1 1113 if ((illegal & INTERFACE) != 0) {
duke@1 1114 log.error(pos, "intf.not.allowed.here");
duke@1 1115 mask |= INTERFACE;
duke@1 1116 }
duke@1 1117 else {
duke@1 1118 log.error(pos,
mcimadamore@80 1119 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 1120 }
duke@1 1121 }
duke@1 1122 else if ((sym.kind == TYP ||
duke@1 1123 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 1124 // in the presence of inner classes. Should it be deleted here?
duke@1 1125 checkDisjoint(pos, flags,
duke@1 1126 ABSTRACT,
mcimadamore@1366 1127 PRIVATE | STATIC | DEFAULT))
duke@1 1128 &&
duke@1 1129 checkDisjoint(pos, flags,
mcimadamore@1513 1130 STATIC,
mcimadamore@1513 1131 DEFAULT)
mcimadamore@1513 1132 &&
mcimadamore@1513 1133 checkDisjoint(pos, flags,
duke@1 1134 ABSTRACT | INTERFACE,
duke@1 1135 FINAL | NATIVE | SYNCHRONIZED)
duke@1 1136 &&
duke@1 1137 checkDisjoint(pos, flags,
duke@1 1138 PUBLIC,
duke@1 1139 PRIVATE | PROTECTED)
duke@1 1140 &&
duke@1 1141 checkDisjoint(pos, flags,
duke@1 1142 PRIVATE,
duke@1 1143 PUBLIC | PROTECTED)
duke@1 1144 &&
duke@1 1145 checkDisjoint(pos, flags,
duke@1 1146 FINAL,
duke@1 1147 VOLATILE)
duke@1 1148 &&
duke@1 1149 (sym.kind == TYP ||
duke@1 1150 checkDisjoint(pos, flags,
duke@1 1151 ABSTRACT | NATIVE,
duke@1 1152 STRICTFP))) {
duke@1 1153 // skip
duke@1 1154 }
mcimadamore@1366 1155 return flags & (mask | ~ExtendedStandardFlags) | implicit;
duke@1 1156 }
duke@1 1157
duke@1 1158
duke@1 1159 /** Determine if this enum should be implicitly final.
duke@1 1160 *
duke@1 1161 * If the enum has no specialized enum contants, it is final.
duke@1 1162 *
duke@1 1163 * If the enum does have specialized enum contants, it is
duke@1 1164 * <i>not</i> final.
duke@1 1165 */
duke@1 1166 private long implicitEnumFinalFlag(JCTree tree) {
jjg@1127 1167 if (!tree.hasTag(CLASSDEF)) return 0;
duke@1 1168 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 1169 boolean specialized;
duke@1 1170 SpecialTreeVisitor() {
duke@1 1171 this.specialized = false;
duke@1 1172 };
duke@1 1173
jjg@398 1174 @Override
duke@1 1175 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 1176
jjg@398 1177 @Override
duke@1 1178 public void visitVarDef(JCVariableDecl tree) {
duke@1 1179 if ((tree.mods.flags & ENUM) != 0) {
duke@1 1180 if (tree.init instanceof JCNewClass &&
duke@1 1181 ((JCNewClass) tree.init).def != null) {
duke@1 1182 specialized = true;
duke@1 1183 }
duke@1 1184 }
duke@1 1185 }
duke@1 1186 }
duke@1 1187
duke@1 1188 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 1189 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 1190 for (JCTree defs: cdef.defs) {
duke@1 1191 defs.accept(sts);
duke@1 1192 if (sts.specialized) return 0;
duke@1 1193 }
duke@1 1194 return FINAL;
duke@1 1195 }
duke@1 1196
duke@1 1197 /* *************************************************************************
duke@1 1198 * Type Validation
duke@1 1199 **************************************************************************/
duke@1 1200
duke@1 1201 /** Validate a type expression. That is,
duke@1 1202 * check that all type arguments of a parametric type are within
jjg@1755 1203 * their bounds. This must be done in a second phase after type attribution
duke@1 1204 * since a class might have a subclass as type parameter bound. E.g:
duke@1 1205 *
jjg@1358 1206 * <pre>{@code
duke@1 1207 * class B<A extends C> { ... }
duke@1 1208 * class C extends B<C> { ... }
jjg@1358 1209 * }</pre>
duke@1 1210 *
duke@1 1211 * and we can't make sure that the bound is already attributed because
duke@1 1212 * of possible cycles.
mcimadamore@638 1213 *
mcimadamore@638 1214 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1215 * and reporting any completion failures.
duke@1 1216 */
mcimadamore@122 1217 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1218 validate(tree, env, true);
duke@1 1219 }
mcimadamore@638 1220 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1221 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1222 }
duke@1 1223
duke@1 1224 /** Visitor method: Validate a list of type expressions.
duke@1 1225 */
mcimadamore@122 1226 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1227 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1228 validate(l.head, env);
duke@1 1229 }
duke@1 1230
duke@1 1231 /** A visitor class for type validation.
duke@1 1232 */
duke@1 1233 class Validator extends JCTree.Visitor {
duke@1 1234
jlahoda@2038 1235 boolean checkRaw;
mcimadamore@638 1236 boolean isOuter;
mcimadamore@638 1237 Env<AttrContext> env;
mcimadamore@638 1238
mcimadamore@638 1239 Validator(Env<AttrContext> env) {
mcimadamore@638 1240 this.env = env;
mcimadamore@638 1241 }
mcimadamore@638 1242
jjg@398 1243 @Override
duke@1 1244 public void visitTypeArray(JCArrayTypeTree tree) {
jlahoda@2038 1245 validateTree(tree.elemtype, checkRaw, isOuter);
duke@1 1246 }
duke@1 1247
jjg@398 1248 @Override
duke@1 1249 public void visitTypeApply(JCTypeApply tree) {
jjg@1374 1250 if (tree.type.hasTag(CLASS)) {
duke@1 1251 List<JCExpression> args = tree.arguments;
mcimadamore@158 1252 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1253
mcimadamore@821 1254 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1255 if (incompatibleArg != null) {
mcimadamore@821 1256 for (JCTree arg : tree.arguments) {
mcimadamore@821 1257 if (arg.type == incompatibleArg) {
mcimadamore@829 1258 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1259 }
mcimadamore@829 1260 forms = forms.tail;
mcimadamore@829 1261 }
mcimadamore@829 1262 }
mcimadamore@829 1263
mcimadamore@829 1264 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1265
mcimadamore@638 1266 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1267
duke@1 1268 // For matching pairs of actual argument types `a' and
duke@1 1269 // formal type parameters with declared bound `b' ...
duke@1 1270 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1271 validateTree(args.head,
mcimadamore@638 1272 !(isOuter && is_java_lang_Class),
mcimadamore@638 1273 false);
duke@1 1274 args = args.tail;
duke@1 1275 forms = forms.tail;
duke@1 1276 }
duke@1 1277
duke@1 1278 // Check that this type is either fully parameterized, or
duke@1 1279 // not parameterized at all.
duke@1 1280 if (tree.type.getEnclosingType().isRaw())
duke@1 1281 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
jjg@1127 1282 if (tree.clazz.hasTag(SELECT))
duke@1 1283 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1284 }
duke@1 1285 }
duke@1 1286
jjg@398 1287 @Override
duke@1 1288 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1289 validateTrees(tree.bounds, true, isOuter);
duke@1 1290 checkClassBounds(tree.pos(), tree.type);
duke@1 1291 }
duke@1 1292
duke@1 1293 @Override
duke@1 1294 public void visitWildcard(JCWildcard tree) {
duke@1 1295 if (tree.inner != null)
mcimadamore@638 1296 validateTree(tree.inner, true, isOuter);
duke@1 1297 }
duke@1 1298
jjg@398 1299 @Override
duke@1 1300 public void visitSelect(JCFieldAccess tree) {
jjg@1374 1301 if (tree.type.hasTag(CLASS)) {
duke@1 1302 visitSelectInternal(tree);
duke@1 1303
duke@1 1304 // Check that this type is either fully parameterized, or
duke@1 1305 // not parameterized at all.
duke@1 1306 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1307 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1308 }
duke@1 1309 }
mcimadamore@852 1310
duke@1 1311 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1312 if (tree.type.tsym.isStatic() &&
duke@1 1313 tree.selected.type.isParameterized()) {
duke@1 1314 // The enclosing type is not a class, so we are
duke@1 1315 // looking at a static member type. However, the
duke@1 1316 // qualifying expression is parameterized.
duke@1 1317 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1318 } else {
duke@1 1319 // otherwise validate the rest of the expression
mcimadamore@122 1320 tree.selected.accept(this);
duke@1 1321 }
duke@1 1322 }
duke@1 1323
jjg@1521 1324 @Override
jjg@1521 1325 public void visitAnnotatedType(JCAnnotatedType tree) {
jjg@1521 1326 tree.underlyingType.accept(this);
jjg@1521 1327 }
jjg@1521 1328
duke@1 1329 /** Default visitor method: do nothing.
duke@1 1330 */
jjg@398 1331 @Override
duke@1 1332 public void visitTree(JCTree tree) {
duke@1 1333 }
mcimadamore@122 1334
mcimadamore@638 1335 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
jlahoda@2038 1336 if (tree != null) {
jlahoda@2038 1337 boolean prevCheckRaw = this.checkRaw;
jlahoda@2038 1338 this.checkRaw = checkRaw;
jlahoda@2038 1339 this.isOuter = isOuter;
jlahoda@2038 1340
jlahoda@2038 1341 try {
mcimadamore@638 1342 tree.accept(this);
mcimadamore@638 1343 if (checkRaw)
mcimadamore@638 1344 checkRaw(tree, env);
jlahoda@2038 1345 } catch (CompletionFailure ex) {
jlahoda@2038 1346 completionError(tree.pos(), ex);
jlahoda@2038 1347 } finally {
jlahoda@2038 1348 this.checkRaw = prevCheckRaw;
mcimadamore@638 1349 }
mcimadamore@638 1350 }
mcimadamore@638 1351 }
mcimadamore@638 1352
mcimadamore@638 1353 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1354 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1355 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1356 }
mcimadamore@1760 1357 }
mcimadamore@1760 1358
mcimadamore@1760 1359 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@1760 1360 if (lint.isEnabled(LintCategory.RAW) &&
mcimadamore@1760 1361 tree.type.hasTag(CLASS) &&
mcimadamore@1760 1362 !TreeInfo.isDiamond(tree) &&
mcimadamore@1760 1363 !withinAnonConstr(env) &&
mcimadamore@1760 1364 tree.type.isRaw()) {
mcimadamore@1760 1365 log.warning(LintCategory.RAW,
mcimadamore@1760 1366 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1367 }
mcimadamore@1760 1368 }
mcimadamore@1760 1369 //where
mcimadamore@1760 1370 private boolean withinAnonConstr(Env<AttrContext> env) {
mcimadamore@1103 1371 return env.enclClass.name.isEmpty() &&
mcimadamore@1103 1372 env.enclMethod != null && env.enclMethod.name == names.init;
mcimadamore@1103 1373 }
duke@1 1374
duke@1 1375 /* *************************************************************************
duke@1 1376 * Exception checking
duke@1 1377 **************************************************************************/
duke@1 1378
duke@1 1379 /* The following methods treat classes as sets that contain
duke@1 1380 * the class itself and all their subclasses
duke@1 1381 */
duke@1 1382
duke@1 1383 /** Is given type a subtype of some of the types in given list?
duke@1 1384 */
duke@1 1385 boolean subset(Type t, List<Type> ts) {
duke@1 1386 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1387 if (types.isSubtype(t, l.head)) return true;
duke@1 1388 return false;
duke@1 1389 }
duke@1 1390
duke@1 1391 /** Is given type a subtype or supertype of
duke@1 1392 * some of the types in given list?
duke@1 1393 */
duke@1 1394 boolean intersects(Type t, List<Type> ts) {
duke@1 1395 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1396 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1397 return false;
duke@1 1398 }
duke@1 1399
duke@1 1400 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1401 * in the list.
duke@1 1402 */
duke@1 1403 List<Type> incl(Type t, List<Type> ts) {
duke@1 1404 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1405 }
duke@1 1406
duke@1 1407 /** Remove type set from type set list.
duke@1 1408 */
duke@1 1409 List<Type> excl(Type t, List<Type> ts) {
duke@1 1410 if (ts.isEmpty()) {
duke@1 1411 return ts;
duke@1 1412 } else {
duke@1 1413 List<Type> ts1 = excl(t, ts.tail);
duke@1 1414 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1415 else if (ts1 == ts.tail) return ts;
duke@1 1416 else return ts1.prepend(ts.head);
duke@1 1417 }
duke@1 1418 }
duke@1 1419
duke@1 1420 /** Form the union of two type set lists.
duke@1 1421 */
duke@1 1422 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1423 List<Type> ts = ts1;
duke@1 1424 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1425 ts = incl(l.head, ts);
duke@1 1426 return ts;
duke@1 1427 }
duke@1 1428
duke@1 1429 /** Form the difference of two type lists.
duke@1 1430 */
duke@1 1431 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1432 List<Type> ts = ts1;
duke@1 1433 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1434 ts = excl(l.head, ts);
duke@1 1435 return ts;
duke@1 1436 }
duke@1 1437
duke@1 1438 /** Form the intersection of two type lists.
duke@1 1439 */
duke@1 1440 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1441 List<Type> ts = List.nil();
duke@1 1442 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1443 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1444 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1445 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1446 return ts;
duke@1 1447 }
duke@1 1448
duke@1 1449 /** Is exc an exception symbol that need not be declared?
duke@1 1450 */
duke@1 1451 boolean isUnchecked(ClassSymbol exc) {
duke@1 1452 return
duke@1 1453 exc.kind == ERR ||
duke@1 1454 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1455 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1456 }
duke@1 1457
duke@1 1458 /** Is exc an exception type that need not be declared?
duke@1 1459 */
duke@1 1460 boolean isUnchecked(Type exc) {
duke@1 1461 return
jjg@1374 1462 (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
jjg@1374 1463 (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
jjg@1374 1464 exc.hasTag(BOT);
duke@1 1465 }
duke@1 1466
duke@1 1467 /** Same, but handling completion failures.
duke@1 1468 */
duke@1 1469 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1470 try {
duke@1 1471 return isUnchecked(exc);
duke@1 1472 } catch (CompletionFailure ex) {
duke@1 1473 completionError(pos, ex);
duke@1 1474 return true;
duke@1 1475 }
duke@1 1476 }
duke@1 1477
duke@1 1478 /** Is exc handled by given exception list?
duke@1 1479 */
duke@1 1480 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1481 return isUnchecked(exc) || subset(exc, handled);
duke@1 1482 }
duke@1 1483
duke@1 1484 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1485 * @param thrown The list of thrown exceptions.
duke@1 1486 * @param handled The list of handled exceptions.
duke@1 1487 */
mcimadamore@362 1488 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1489 List<Type> unhandled = List.nil();
duke@1 1490 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1491 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1492 return unhandled;
duke@1 1493 }
duke@1 1494
duke@1 1495 /* *************************************************************************
duke@1 1496 * Overriding/Implementation checking
duke@1 1497 **************************************************************************/
duke@1 1498
duke@1 1499 /** The level of access protection given by a flag set,
duke@1 1500 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1501 */
duke@1 1502 static int protection(long flags) {
duke@1 1503 switch ((short)(flags & AccessFlags)) {
duke@1 1504 case PRIVATE: return 3;
duke@1 1505 case PROTECTED: return 1;
duke@1 1506 default:
duke@1 1507 case PUBLIC: return 0;
duke@1 1508 case 0: return 2;
duke@1 1509 }
duke@1 1510 }
duke@1 1511
duke@1 1512 /** A customized "cannot override" error message.
duke@1 1513 * @param m The overriding method.
duke@1 1514 * @param other The overridden method.
duke@1 1515 * @return An internationalized string.
duke@1 1516 */
mcimadamore@89 1517 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1518 String key;
duke@1 1519 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1520 key = "cant.override";
duke@1 1521 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1522 key = "cant.implement";
duke@1 1523 else
duke@1 1524 key = "clashes.with";
mcimadamore@89 1525 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1526 }
duke@1 1527
duke@1 1528 /** A customized "override" warning message.
duke@1 1529 * @param m The overriding method.
duke@1 1530 * @param other The overridden method.
duke@1 1531 * @return An internationalized string.
duke@1 1532 */
mcimadamore@89 1533 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1534 String key;
duke@1 1535 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1536 key = "unchecked.override";
duke@1 1537 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1538 key = "unchecked.implement";
duke@1 1539 else
duke@1 1540 key = "unchecked.clash.with";
mcimadamore@89 1541 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1542 }
duke@1 1543
duke@1 1544 /** A customized "override" warning message.
duke@1 1545 * @param m The overriding method.
duke@1 1546 * @param other The overridden method.
duke@1 1547 * @return An internationalized string.
duke@1 1548 */
mcimadamore@89 1549 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1550 String key;
duke@1 1551 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1552 key = "varargs.override";
duke@1 1553 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1554 key = "varargs.implement";
duke@1 1555 else
duke@1 1556 key = "varargs.clash.with";
mcimadamore@89 1557 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1558 }
duke@1 1559
duke@1 1560 /** Check that this method conforms with overridden method 'other'.
duke@1 1561 * where `origin' is the class where checking started.
duke@1 1562 * Complications:
duke@1 1563 * (1) Do not check overriding of synthetic methods
duke@1 1564 * (reason: they might be final).
duke@1 1565 * todo: check whether this is still necessary.
duke@1 1566 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1567 * than the method it implements. Augment the proxy methods with the
duke@1 1568 * undeclared exceptions in this case.
duke@1 1569 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1570 * has a result type
duke@1 1571 * extended by the result type of the method it implements.
duke@1 1572 * Change the proxies result type to the smaller type in this case.
duke@1 1573 *
duke@1 1574 * @param tree The tree from which positions
duke@1 1575 * are extracted for errors.
duke@1 1576 * @param m The overriding method.
duke@1 1577 * @param other The overridden method.
duke@1 1578 * @param origin The class of which the overriding method
duke@1 1579 * is a member.
duke@1 1580 */
duke@1 1581 void checkOverride(JCTree tree,
duke@1 1582 MethodSymbol m,
duke@1 1583 MethodSymbol other,
duke@1 1584 ClassSymbol origin) {
duke@1 1585 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1586 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1587 return;
duke@1 1588 }
duke@1 1589
duke@1 1590 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1591 if ((m.flags() & STATIC) != 0 &&
duke@1 1592 (other.flags() & STATIC) == 0) {
duke@1 1593 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1594 cannotOverride(m, other));
vromero@1588 1595 m.flags_field |= BAD_OVERRIDE;
duke@1 1596 return;
duke@1 1597 }
duke@1 1598
duke@1 1599 // Error if instance method overrides static or final
duke@1 1600 // method (JLS 8.4.6.1).
duke@1 1601 if ((other.flags() & FINAL) != 0 ||
duke@1 1602 (m.flags() & STATIC) == 0 &&
duke@1 1603 (other.flags() & STATIC) != 0) {
duke@1 1604 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1605 cannotOverride(m, other),
mcimadamore@80 1606 asFlagSet(other.flags() & (FINAL | STATIC)));
vromero@1588 1607 m.flags_field |= BAD_OVERRIDE;
duke@1 1608 return;
duke@1 1609 }
duke@1 1610
duke@1 1611 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1612 // handled in validateAnnotationMethod
duke@1 1613 return;
duke@1 1614 }
duke@1 1615
duke@1 1616 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1617 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1618 protection(m.flags()) > protection(other.flags())) {
duke@1 1619 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1620 cannotOverride(m, other),
mcimadamore@80 1621 other.flags() == 0 ?
vromero@1842 1622 "package" :
mcimadamore@80 1623 asFlagSet(other.flags() & AccessFlags));
vromero@1588 1624 m.flags_field |= BAD_OVERRIDE;
duke@1 1625 return;
duke@1 1626 }
duke@1 1627
duke@1 1628 Type mt = types.memberType(origin.type, m);
duke@1 1629 Type ot = types.memberType(origin.type, other);
duke@1 1630 // Error if overriding result type is different
duke@1 1631 // (or, in the case of generics mode, not a subtype) of
duke@1 1632 // overridden result type. We have to rename any type parameters
duke@1 1633 // before comparing types.
duke@1 1634 List<Type> mtvars = mt.getTypeArguments();
duke@1 1635 List<Type> otvars = ot.getTypeArguments();
duke@1 1636 Type mtres = mt.getReturnType();
duke@1 1637 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1638
mcimadamore@795 1639 overrideWarner.clear();
duke@1 1640 boolean resultTypesOK =
tbell@202 1641 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1642 if (!resultTypesOK) {
jjg@398 1643 if (!allowCovariantReturns &&
duke@1 1644 m.owner != origin &&
duke@1 1645 m.owner.isSubClass(other.owner, types)) {
duke@1 1646 // allow limited interoperability with covariant returns
duke@1 1647 } else {
mcimadamore@362 1648 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1649 "override.incompatible.ret",
mcimadamore@362 1650 cannotOverride(m, other),
duke@1 1651 mtres, otres);
vromero@1588 1652 m.flags_field |= BAD_OVERRIDE;
duke@1 1653 return;
duke@1 1654 }
mcimadamore@795 1655 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1656 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1657 "override.unchecked.ret",
mcimadamore@362 1658 uncheckedOverrides(m, other),
mcimadamore@362 1659 mtres, otres);
duke@1 1660 }
duke@1 1661
duke@1 1662 // Error if overriding method throws an exception not reported
duke@1 1663 // by overridden method.
duke@1 1664 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1665 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1666 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1667 if (unhandledErased.nonEmpty()) {
duke@1 1668 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1669 "override.meth.doesnt.throw",
duke@1 1670 cannotOverride(m, other),
mcimadamore@362 1671 unhandledUnerased.head);
vromero@1588 1672 m.flags_field |= BAD_OVERRIDE;
mcimadamore@362 1673 return;
mcimadamore@362 1674 }
mcimadamore@362 1675 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1676 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1677 "override.unchecked.thrown",
mcimadamore@362 1678 cannotOverride(m, other),
mcimadamore@362 1679 unhandledUnerased.head);
duke@1 1680 return;
duke@1 1681 }
duke@1 1682
duke@1 1683 // Optional warning if varargs don't agree
duke@1 1684 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1685 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1686 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1687 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1688 ? "override.varargs.missing"
duke@1 1689 : "override.varargs.extra",
duke@1 1690 varargsOverrides(m, other));
duke@1 1691 }
duke@1 1692
duke@1 1693 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1694 if ((other.flags() & BRIDGE) != 0) {
duke@1 1695 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1696 uncheckedOverrides(m, other));
duke@1 1697 }
duke@1 1698
duke@1 1699 // Warn if a deprecated method overridden by a non-deprecated one.
mcimadamore@852 1700 if (!isDeprecatedOverrideIgnorable(other, origin)) {
mcimadamore@852 1701 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
duke@1 1702 }
duke@1 1703 }
duke@1 1704 // where
duke@1 1705 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1706 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1707 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1708 // because in that case, we will rediscover the issue when examining the method
duke@1 1709 // in the supertype.
duke@1 1710 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1711 // address the issue is when the method is the supertype implemementation: any other
duke@1 1712 // case, we will have dealt with when examining the supertype classes
duke@1 1713 ClassSymbol mc = m.enclClass();
duke@1 1714 Type st = types.supertype(origin.type);
jjg@1374 1715 if (!st.hasTag(CLASS))
duke@1 1716 return true;
duke@1 1717 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1718
duke@1 1719 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1720 List<Type> intfs = types.interfaces(origin.type);
duke@1 1721 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1722 }
duke@1 1723 else
duke@1 1724 return (stimpl != m);
duke@1 1725 }
duke@1 1726
duke@1 1727
duke@1 1728 // used to check if there were any unchecked conversions
duke@1 1729 Warner overrideWarner = new Warner();
duke@1 1730
duke@1 1731 /** Check that a class does not inherit two concrete methods
duke@1 1732 * with the same signature.
duke@1 1733 * @param pos Position to be used for error reporting.
duke@1 1734 * @param site The class type to be checked.
duke@1 1735 */
duke@1 1736 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1737 Type sup = types.supertype(site);
jjg@1374 1738 if (!sup.hasTag(CLASS)) return;
duke@1 1739
duke@1 1740 for (Type t1 = sup;
jlahoda@1956 1741 t1.hasTag(CLASS) && t1.tsym.type.isParameterized();
duke@1 1742 t1 = types.supertype(t1)) {
duke@1 1743 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1744 e1 != null;
duke@1 1745 e1 = e1.sibling) {
duke@1 1746 Symbol s1 = e1.sym;
duke@1 1747 if (s1.kind != MTH ||
duke@1 1748 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1749 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1750 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1751 types,
duke@1 1752 true) != s1)
duke@1 1753 continue;
duke@1 1754 Type st1 = types.memberType(t1, s1);
duke@1 1755 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1756 if (st1 == s1.type) continue;
duke@1 1757
duke@1 1758 for (Type t2 = sup;
jjg@1374 1759 t2.hasTag(CLASS);
duke@1 1760 t2 = types.supertype(t2)) {
mcimadamore@24 1761 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1762 e2.scope != null;
duke@1 1763 e2 = e2.next()) {
duke@1 1764 Symbol s2 = e2.sym;
duke@1 1765 if (s2 == s1 ||
duke@1 1766 s2.kind != MTH ||
duke@1 1767 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1768 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1769 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1770 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1771 types,
duke@1 1772 true) != s2)
duke@1 1773 continue;
duke@1 1774 Type st2 = types.memberType(t2, s2);
duke@1 1775 if (types.overrideEquivalent(st1, st2))
duke@1 1776 log.error(pos, "concrete.inheritance.conflict",
duke@1 1777 s1, t1, s2, t2, sup);
duke@1 1778 }
duke@1 1779 }
duke@1 1780 }
duke@1 1781 }
duke@1 1782 }
duke@1 1783
duke@1 1784 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1785 * method with same name and arguments but incompatible return types.
duke@1 1786 * @param pos Position to be used for error reporting.
duke@1 1787 * @param t1 The first argument type.
duke@1 1788 * @param t2 The second argument type.
duke@1 1789 */
duke@1 1790 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1791 Type t1,
duke@1 1792 Type t2) {
duke@1 1793 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1794 types.makeCompoundType(t1, t2));
duke@1 1795 }
duke@1 1796
duke@1 1797 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1798 Type t1,
duke@1 1799 Type t2,
duke@1 1800 Type site) {
mcimadamore@746 1801 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1802 }
duke@1 1803
duke@1 1804 /** Return the first method which is defined with same args
duke@1 1805 * but different return types in two given interfaces, or null if none
duke@1 1806 * exists.
duke@1 1807 * @param t1 The first type.
duke@1 1808 * @param t2 The second type.
duke@1 1809 * @param site The most derived type.
duke@1 1810 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1811 */
mcimadamore@746 1812 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1813 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1814 closure(t1, interfaces1);
duke@1 1815 Map<TypeSymbol,Type> interfaces2;
duke@1 1816 if (t1 == t2)
duke@1 1817 interfaces2 = interfaces1;
duke@1 1818 else
duke@1 1819 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1820
duke@1 1821 for (Type t3 : interfaces1.values()) {
duke@1 1822 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1823 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1824 if (s != null) return s;
duke@1 1825 }
duke@1 1826 }
duke@1 1827 return null;
duke@1 1828 }
duke@1 1829
duke@1 1830 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1831 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1832 if (!t.hasTag(CLASS)) return;
duke@1 1833 if (typeMap.put(t.tsym, t) == null) {
duke@1 1834 closure(types.supertype(t), typeMap);
duke@1 1835 for (Type i : types.interfaces(t))
duke@1 1836 closure(i, typeMap);
duke@1 1837 }
duke@1 1838 }
duke@1 1839
duke@1 1840 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1841 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
jjg@1374 1842 if (!t.hasTag(CLASS)) return;
duke@1 1843 if (typesSkip.get(t.tsym) != null) return;
duke@1 1844 if (typeMap.put(t.tsym, t) == null) {
duke@1 1845 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1846 for (Type i : types.interfaces(t))
duke@1 1847 closure(i, typesSkip, typeMap);
duke@1 1848 }
duke@1 1849 }
duke@1 1850
duke@1 1851 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1852 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1853 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1854 Symbol s1 = e1.sym;
duke@1 1855 Type st1 = null;
mcimadamore@1441 1856 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1857 (s1.flags() & SYNTHETIC) != 0) continue;
duke@1 1858 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1859 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1860 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1861 Symbol s2 = e2.sym;
duke@1 1862 if (s1 == s2) continue;
mcimadamore@1441 1863 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) ||
mcimadamore@1441 1864 (s2.flags() & SYNTHETIC) != 0) continue;
duke@1 1865 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1866 Type st2 = types.memberType(t2, s2);
duke@1 1867 if (types.overrideEquivalent(st1, st2)) {
duke@1 1868 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1869 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1870 Type rt1 = st1.getReturnType();
duke@1 1871 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1872 boolean compat =
duke@1 1873 types.isSameType(rt1, rt2) ||
jjg@1374 1874 !rt1.isPrimitiveOrVoid() &&
jjg@1374 1875 !rt2.isPrimitiveOrVoid() &&
mcimadamore@1415 1876 (types.covariantReturnType(rt1, rt2, types.noWarnings) ||
mcimadamore@1415 1877 types.covariantReturnType(rt2, rt1, types.noWarnings)) ||
mcimadamore@59 1878 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1879 if (!compat) {
mcimadamore@746 1880 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1881 t1, t2, s2.name +
mcimadamore@746 1882 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1883 return s2;
mcimadamore@746 1884 }
mcimadamore@889 1885 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
mcimadamore@889 1886 !checkCommonOverriderIn(s1, s2, site)) {
mcimadamore@746 1887 log.error(pos,
mcimadamore@746 1888 "name.clash.same.erasure.no.override",
mcimadamore@746 1889 s1, s1.location(),
mcimadamore@746 1890 s2, s2.location());
mcimadamore@746 1891 return s2;
duke@1 1892 }
duke@1 1893 }
duke@1 1894 }
duke@1 1895 return null;
duke@1 1896 }
mcimadamore@59 1897 //WHERE
mcimadamore@59 1898 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1899 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1900 Type st1 = types.memberType(site, s1);
mcimadamore@59 1901 Type st2 = types.memberType(site, s2);
mcimadamore@59 1902 closure(site, supertypes);
mcimadamore@59 1903 for (Type t : supertypes.values()) {
mcimadamore@59 1904 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1905 Symbol s3 = e.sym;
mcimadamore@59 1906 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1907 Type st3 = types.memberType(site,s3);
mcimadamore@1811 1908 if (types.overrideEquivalent(st3, st1) &&
mcimadamore@1811 1909 types.overrideEquivalent(st3, st2) &&
mcimadamore@1811 1910 types.returnTypeSubstitutable(st3, st1) &&
mcimadamore@1811 1911 types.returnTypeSubstitutable(st3, st2)) {
mcimadamore@1811 1912 return true;
mcimadamore@59 1913 }
mcimadamore@59 1914 }
mcimadamore@59 1915 }
mcimadamore@59 1916 return false;
mcimadamore@59 1917 }
duke@1 1918
duke@1 1919 /** Check that a given method conforms with any method it overrides.
duke@1 1920 * @param tree The tree from which positions are extracted
duke@1 1921 * for errors.
duke@1 1922 * @param m The overriding method.
duke@1 1923 */
jlahoda@2111 1924 void checkOverride(JCMethodDecl tree, MethodSymbol m) {
duke@1 1925 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1926 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1927 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1928 log.error(tree.pos(), "enum.no.finalize");
duke@1 1929 return;
duke@1 1930 }
jjg@1374 1931 for (Type t = origin.type; t.hasTag(CLASS);
duke@1 1932 t = types.supertype(t)) {
mcimadamore@746 1933 if (t != origin.type) {
mcimadamore@746 1934 checkOverride(tree, t, origin, m);
mcimadamore@746 1935 }
mcimadamore@746 1936 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1937 checkOverride(tree, t2, origin, m);
duke@1 1938 }
duke@1 1939 }
jlahoda@2111 1940
jlahoda@2111 1941 if (m.attribute(syms.overrideType.tsym) != null && !isOverrider(m)) {
jlahoda@2111 1942 DiagnosticPosition pos = tree.pos();
jlahoda@2111 1943 for (JCAnnotation a : tree.getModifiers().annotations) {
jlahoda@2111 1944 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
jlahoda@2111 1945 pos = a.pos();
jlahoda@2111 1946 break;
jlahoda@2111 1947 }
jlahoda@2111 1948 }
jlahoda@2111 1949 log.error(pos, "method.does.not.override.superclass");
jlahoda@2111 1950 }
duke@1 1951 }
duke@1 1952
mcimadamore@746 1953 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1954 TypeSymbol c = site.tsym;
mcimadamore@746 1955 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1956 while (e.scope != null) {
mcimadamore@746 1957 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1958 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1959 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1960 }
mcimadamore@746 1961 }
mcimadamore@746 1962 e = e.next();
mcimadamore@746 1963 }
mcimadamore@746 1964 }
mcimadamore@746 1965
vromero@1607 1966 private Filter<Symbol> equalsHasCodeFilter = new Filter<Symbol>() {
vromero@1607 1967 public boolean accepts(Symbol s) {
vromero@1607 1968 return MethodSymbol.implementation_filter.accepts(s) &&
vromero@1607 1969 (s.flags() & BAD_OVERRIDE) == 0;
vromero@1607 1970
vromero@1607 1971 }
vromero@1607 1972 };
vromero@1607 1973
vromero@1620 1974 public void checkClassOverrideEqualsAndHashIfNeeded(DiagnosticPosition pos,
vromero@1620 1975 ClassSymbol someClass) {
vromero@1620 1976 /* At present, annotations cannot possibly have a method that is override
vromero@1620 1977 * equivalent with Object.equals(Object) but in any case the condition is
vromero@1620 1978 * fine for completeness.
vromero@1620 1979 */
vromero@1620 1980 if (someClass == (ClassSymbol)syms.objectType.tsym ||
vromero@1620 1981 someClass.isInterface() || someClass.isEnum() ||
vromero@1620 1982 (someClass.flags() & ANNOTATION) != 0 ||
vromero@1620 1983 (someClass.flags() & ABSTRACT) != 0) return;
vromero@1620 1984 //anonymous inner classes implementing interfaces need especial treatment
vromero@1620 1985 if (someClass.isAnonymous()) {
vromero@1620 1986 List<Type> interfaces = types.interfaces(someClass.type);
vromero@1620 1987 if (interfaces != null && !interfaces.isEmpty() &&
vromero@1620 1988 interfaces.head.tsym == syms.comparatorType.tsym) return;
vromero@1620 1989 }
vromero@1620 1990 checkClassOverrideEqualsAndHash(pos, someClass);
vromero@1620 1991 }
vromero@1620 1992
vromero@1620 1993 private void checkClassOverrideEqualsAndHash(DiagnosticPosition pos,
vromero@1607 1994 ClassSymbol someClass) {
vromero@1588 1995 if (lint.isEnabled(LintCategory.OVERRIDES)) {
vromero@1607 1996 MethodSymbol equalsAtObject = (MethodSymbol)syms.objectType
vromero@1607 1997 .tsym.members().lookup(names.equals).sym;
vromero@1607 1998 MethodSymbol hashCodeAtObject = (MethodSymbol)syms.objectType
vromero@1607 1999 .tsym.members().lookup(names.hashCode).sym;
vromero@1607 2000 boolean overridesEquals = types.implementation(equalsAtObject,
vromero@1607 2001 someClass, false, equalsHasCodeFilter).owner == someClass;
vromero@1607 2002 boolean overridesHashCode = types.implementation(hashCodeAtObject,
vromero@1607 2003 someClass, false, equalsHasCodeFilter) != hashCodeAtObject;
vromero@1607 2004
vromero@1607 2005 if (overridesEquals && !overridesHashCode) {
vromero@1607 2006 log.warning(LintCategory.OVERRIDES, pos,
vromero@1620 2007 "override.equals.but.not.hashcode", someClass);
vromero@1588 2008 }
vromero@1588 2009 }
vromero@1588 2010 }
vromero@1588 2011
mcimadamore@746 2012 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@858 2013 ClashFilter cf = new ClashFilter(origin.type);
mcimadamore@858 2014 return (cf.accepts(s1) &&
mcimadamore@858 2015 cf.accepts(s2) &&
mcimadamore@858 2016 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
mcimadamore@746 2017 }
mcimadamore@746 2018
mcimadamore@746 2019
duke@1 2020 /** Check that all abstract members of given class have definitions.
duke@1 2021 * @param pos Position to be used for error reporting.
duke@1 2022 * @param c The class.
duke@1 2023 */
duke@1 2024 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2025 try {
duke@1 2026 MethodSymbol undef = firstUndef(c, c);
duke@1 2027 if (undef != null) {
duke@1 2028 if ((c.flags() & ENUM) != 0 &&
duke@1 2029 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 2030 (c.flags() & FINAL) == 0) {
duke@1 2031 // add the ABSTRACT flag to an enum
duke@1 2032 c.flags_field |= ABSTRACT;
duke@1 2033 } else {
duke@1 2034 MethodSymbol undef1 =
duke@1 2035 new MethodSymbol(undef.flags(), undef.name,
duke@1 2036 types.memberType(c.type, undef), undef.owner);
duke@1 2037 log.error(pos, "does.not.override.abstract",
duke@1 2038 c, undef1, undef1.location());
duke@1 2039 }
duke@1 2040 }
duke@1 2041 } catch (CompletionFailure ex) {
duke@1 2042 completionError(pos, ex);
duke@1 2043 }
duke@1 2044 }
duke@1 2045 //where
duke@1 2046 /** Return first abstract member of class `c' that is not defined
duke@1 2047 * in `impl', null if there is none.
duke@1 2048 */
duke@1 2049 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 2050 MethodSymbol undef = null;
duke@1 2051 // Do not bother to search in classes that are not abstract,
duke@1 2052 // since they cannot have abstract members.
duke@1 2053 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 2054 Scope s = c.members();
duke@1 2055 for (Scope.Entry e = s.elems;
duke@1 2056 undef == null && e != null;
duke@1 2057 e = e.sibling) {
duke@1 2058 if (e.sym.kind == MTH &&
mcimadamore@1393 2059 (e.sym.flags() & (ABSTRACT|IPROXY|DEFAULT)) == ABSTRACT) {
duke@1 2060 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2061 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
mcimadamore@1393 2062 if (implmeth == null || implmeth == absmeth) {
mcimadamore@1393 2063 //look for default implementations
mcimadamore@1393 2064 if (allowDefaultMethods) {
mcimadamore@1393 2065 MethodSymbol prov = types.interfaceCandidates(impl.type, absmeth).head;
mcimadamore@1393 2066 if (prov != null && prov.overrides(absmeth, impl, types, true)) {
mcimadamore@1393 2067 implmeth = prov;
mcimadamore@1393 2068 }
mcimadamore@1393 2069 }
mcimadamore@1393 2070 }
mcimadamore@1393 2071 if (implmeth == null || implmeth == absmeth) {
duke@1 2072 undef = absmeth;
mcimadamore@1393 2073 }
duke@1 2074 }
duke@1 2075 }
duke@1 2076 if (undef == null) {
duke@1 2077 Type st = types.supertype(c.type);
jjg@1374 2078 if (st.hasTag(CLASS))
duke@1 2079 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 2080 }
duke@1 2081 for (List<Type> l = types.interfaces(c.type);
duke@1 2082 undef == null && l.nonEmpty();
duke@1 2083 l = l.tail) {
duke@1 2084 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 2085 }
duke@1 2086 }
duke@1 2087 return undef;
duke@1 2088 }
duke@1 2089
mcimadamore@690 2090 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 2091 CycleChecker cc = new CycleChecker();
mcimadamore@690 2092 cc.scan(tree);
mcimadamore@690 2093 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 2094 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 2095 }
mcimadamore@690 2096 }
mcimadamore@690 2097
mcimadamore@690 2098 class CycleChecker extends TreeScanner {
mcimadamore@690 2099
mcimadamore@690 2100 List<Symbol> seenClasses = List.nil();
mcimadamore@690 2101 boolean errorFound = false;
mcimadamore@690 2102 boolean partialCheck = false;
mcimadamore@690 2103
mcimadamore@690 2104 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 2105 if (sym != null && sym.kind == TYP) {
mcimadamore@690 2106 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 2107 if (classEnv != null) {
mcimadamore@690 2108 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 2109 try {
mcimadamore@690 2110 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 2111 scan(classEnv.tree);
mcimadamore@690 2112 }
mcimadamore@690 2113 finally {
mcimadamore@690 2114 log.useSource(prevSource.getFile());
mcimadamore@690 2115 }
mcimadamore@690 2116 } else if (sym.kind == TYP) {
mcimadamore@690 2117 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 2118 }
mcimadamore@690 2119 } else {
mcimadamore@690 2120 //not completed yet
mcimadamore@690 2121 partialCheck = true;
mcimadamore@690 2122 }
mcimadamore@690 2123 }
mcimadamore@690 2124
mcimadamore@690 2125 @Override
mcimadamore@690 2126 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 2127 super.visitSelect(tree);
mcimadamore@690 2128 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2129 }
mcimadamore@690 2130
mcimadamore@690 2131 @Override
mcimadamore@690 2132 public void visitIdent(JCIdent tree) {
mcimadamore@690 2133 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 2134 }
mcimadamore@690 2135
mcimadamore@690 2136 @Override
mcimadamore@690 2137 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 2138 scan(tree.clazz);
mcimadamore@690 2139 }
mcimadamore@690 2140
mcimadamore@690 2141 @Override
mcimadamore@690 2142 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 2143 scan(tree.elemtype);
mcimadamore@690 2144 }
mcimadamore@690 2145
mcimadamore@690 2146 @Override
mcimadamore@690 2147 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 2148 List<JCTree> supertypes = List.nil();
mcimadamore@690 2149 if (tree.getExtendsClause() != null) {
mcimadamore@690 2150 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 2151 }
mcimadamore@690 2152 if (tree.getImplementsClause() != null) {
mcimadamore@690 2153 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 2154 supertypes = supertypes.prepend(intf);
mcimadamore@690 2155 }
mcimadamore@690 2156 }
mcimadamore@690 2157 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 2158 }
mcimadamore@690 2159
mcimadamore@690 2160 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 2161 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 2162 return;
mcimadamore@690 2163 if (seenClasses.contains(c)) {
mcimadamore@690 2164 errorFound = true;
mcimadamore@690 2165 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 2166 } else if (!c.type.isErroneous()) {
mcimadamore@690 2167 try {
mcimadamore@690 2168 seenClasses = seenClasses.prepend(c);
jjg@1374 2169 if (c.type.hasTag(CLASS)) {
mcimadamore@690 2170 if (supertypes.nonEmpty()) {
mcimadamore@690 2171 scan(supertypes);
mcimadamore@690 2172 }
mcimadamore@690 2173 else {
mcimadamore@690 2174 ClassType ct = (ClassType)c.type;
mcimadamore@690 2175 if (ct.supertype_field == null ||
mcimadamore@690 2176 ct.interfaces_field == null) {
mcimadamore@690 2177 //not completed yet
mcimadamore@690 2178 partialCheck = true;
mcimadamore@690 2179 return;
mcimadamore@690 2180 }
mcimadamore@690 2181 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 2182 for (Type intf : ct.interfaces_field) {
mcimadamore@690 2183 checkSymbol(pos, intf.tsym);
mcimadamore@690 2184 }
mcimadamore@690 2185 }
mcimadamore@690 2186 if (c.owner.kind == TYP) {
mcimadamore@690 2187 checkSymbol(pos, c.owner);
mcimadamore@690 2188 }
mcimadamore@690 2189 }
mcimadamore@690 2190 } finally {
mcimadamore@690 2191 seenClasses = seenClasses.tail;
mcimadamore@690 2192 }
mcimadamore@690 2193 }
mcimadamore@690 2194 }
mcimadamore@690 2195 }
mcimadamore@690 2196
duke@1 2197 /** Check for cyclic references. Issue an error if the
duke@1 2198 * symbol of the type referred to has a LOCKED flag set.
duke@1 2199 *
duke@1 2200 * @param pos Position to be used for error reporting.
duke@1 2201 * @param t The type referred to.
duke@1 2202 */
duke@1 2203 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 2204 checkNonCyclicInternal(pos, t);
duke@1 2205 }
duke@1 2206
duke@1 2207
duke@1 2208 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 2209 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 2210 }
duke@1 2211
mcimadamore@236 2212 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 2213 final TypeVar tv;
jjg@1374 2214 if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 2215 return;
duke@1 2216 if (seen.contains(t)) {
jjg@1978 2217 tv = (TypeVar)t.unannotatedType();
jjg@110 2218 tv.bound = types.createErrorType(t);
duke@1 2219 log.error(pos, "cyclic.inheritance", t);
jjg@1374 2220 } else if (t.hasTag(TYPEVAR)) {
jjg@1978 2221 tv = (TypeVar)t.unannotatedType();
mcimadamore@236 2222 seen = seen.prepend(tv);
duke@1 2223 for (Type b : types.getBounds(tv))
duke@1 2224 checkNonCyclic1(pos, b, seen);
duke@1 2225 }
duke@1 2226 }
duke@1 2227
duke@1 2228 /** Check for cyclic references. Issue an error if the
duke@1 2229 * symbol of the type referred to has a LOCKED flag set.
duke@1 2230 *
duke@1 2231 * @param pos Position to be used for error reporting.
duke@1 2232 * @param t The type referred to.
duke@1 2233 * @returns True if the check completed on all attributed classes
duke@1 2234 */
duke@1 2235 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 2236 boolean complete = true; // was the check complete?
duke@1 2237 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 2238 Symbol c = t.tsym;
duke@1 2239 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 2240
duke@1 2241 if ((c.flags_field & LOCKED) != 0) {
duke@1 2242 noteCyclic(pos, (ClassSymbol)c);
duke@1 2243 } else if (!c.type.isErroneous()) {
duke@1 2244 try {
duke@1 2245 c.flags_field |= LOCKED;
jjg@1374 2246 if (c.type.hasTag(CLASS)) {
duke@1 2247 ClassType clazz = (ClassType)c.type;
duke@1 2248 if (clazz.interfaces_field != null)
duke@1 2249 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 2250 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 2251 if (clazz.supertype_field != null) {
duke@1 2252 Type st = clazz.supertype_field;
jjg@1374 2253 if (st != null && st.hasTag(CLASS))
duke@1 2254 complete &= checkNonCyclicInternal(pos, st);
duke@1 2255 }
duke@1 2256 if (c.owner.kind == TYP)
duke@1 2257 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 2258 }
duke@1 2259 } finally {
duke@1 2260 c.flags_field &= ~LOCKED;
duke@1 2261 }
duke@1 2262 }
duke@1 2263 if (complete)
duke@1 2264 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 2265 if (complete) c.flags_field |= ACYCLIC;
duke@1 2266 return complete;
duke@1 2267 }
duke@1 2268
duke@1 2269 /** Note that we found an inheritance cycle. */
duke@1 2270 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 2271 log.error(pos, "cyclic.inheritance", c);
duke@1 2272 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 2273 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 2274 Type st = types.supertype(c.type);
jjg@1374 2275 if (st.hasTag(CLASS))
jjg@110 2276 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 2277 c.type = types.createErrorType(c, c.type);
duke@1 2278 c.flags_field |= ACYCLIC;
duke@1 2279 }
duke@1 2280
duke@1 2281 /** Check that all methods which implement some
duke@1 2282 * method conform to the method they implement.
duke@1 2283 * @param tree The class definition whose members are checked.
duke@1 2284 */
duke@1 2285 void checkImplementations(JCClassDecl tree) {
mcimadamore@1415 2286 checkImplementations(tree, tree.sym, tree.sym);
duke@1 2287 }
jjg@1521 2288 //where
duke@1 2289 /** Check that all methods which implement some
duke@1 2290 * method in `ic' conform to the method they implement.
duke@1 2291 */
mcimadamore@1415 2292 void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) {
duke@1 2293 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2294 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2295 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2296 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2297 if (e.sym.kind == MTH &&
duke@1 2298 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2299 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2300 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2301 if (implmeth != null && implmeth != absmeth &&
duke@1 2302 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2303 (origin.flags() & INTERFACE)) {
duke@1 2304 // don't check if implmeth is in a class, yet
duke@1 2305 // origin is an interface. This case arises only
duke@1 2306 // if implmeth is declared in Object. The reason is
duke@1 2307 // that interfaces really don't inherit from
duke@1 2308 // Object it's just that the compiler represents
duke@1 2309 // things that way.
duke@1 2310 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2311 }
duke@1 2312 }
duke@1 2313 }
duke@1 2314 }
duke@1 2315 }
duke@1 2316 }
duke@1 2317
duke@1 2318 /** Check that all abstract methods implemented by a class are
duke@1 2319 * mutually compatible.
duke@1 2320 * @param pos Position to be used for error reporting.
duke@1 2321 * @param c The class whose interfaces are checked.
duke@1 2322 */
duke@1 2323 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2324 List<Type> supertypes = types.interfaces(c);
duke@1 2325 Type supertype = types.supertype(c);
jjg@1374 2326 if (supertype.hasTag(CLASS) &&
duke@1 2327 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2328 supertypes = supertypes.prepend(supertype);
duke@1 2329 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2330 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2331 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2332 return;
duke@1 2333 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2334 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2335 return;
duke@1 2336 }
duke@1 2337 checkCompatibleConcretes(pos, c);
duke@1 2338 }
duke@1 2339
mcimadamore@359 2340 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2341 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2342 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2343 // VM allows methods and variables with differing types
mcimadamore@359 2344 if (sym.kind == e.sym.kind &&
mcimadamore@359 2345 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2346 sym != e.sym &&
mcimadamore@359 2347 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2348 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2349 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2350 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2351 return;
mcimadamore@359 2352 }
mcimadamore@359 2353 }
mcimadamore@359 2354 }
mcimadamore@359 2355 }
mcimadamore@359 2356
mcimadamore@780 2357 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2358 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2359 *
mcimadamore@780 2360 * @param pos Position to be used for error reporting.
mcimadamore@780 2361 * @param site The class whose methods are checked.
mcimadamore@780 2362 * @param sym The method symbol to be checked.
mcimadamore@780 2363 */
mcimadamore@858 2364 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@858 2365 ClashFilter cf = new ClashFilter(site);
mcimadamore@1198 2366 //for each method m1 that is overridden (directly or indirectly)
mcimadamore@1198 2367 //by method 'sym' in 'site'...
vromero@2118 2368
vromero@2118 2369 List<MethodSymbol> potentiallyAmbiguousList = List.nil();
vromero@2118 2370 boolean overridesAny = false;
mcimadamore@1198 2371 for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
vromero@2118 2372 if (!sym.overrides(m1, site.tsym, types, false)) {
vromero@2118 2373 if (m1 == sym) {
vromero@2118 2374 continue;
vromero@2118 2375 }
vromero@2118 2376
vromero@2118 2377 if (!overridesAny) {
vromero@2118 2378 potentiallyAmbiguousList = potentiallyAmbiguousList.prepend((MethodSymbol)m1);
vromero@2118 2379 }
vromero@2118 2380 continue;
vromero@2118 2381 }
vromero@2118 2382
vromero@2118 2383 if (m1 != sym) {
vromero@2118 2384 overridesAny = true;
vromero@2118 2385 potentiallyAmbiguousList = List.nil();
vromero@2118 2386 }
vromero@2118 2387
vromero@2118 2388 //...check each method m2 that is a member of 'site'
vromero@2118 2389 for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
mcimadamore@1198 2390 if (m2 == m1) continue;
mcimadamore@858 2391 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2392 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
mcimadamore@1393 2393 if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) &&
mcimadamore@1198 2394 types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
mcimadamore@858 2395 sym.flags_field |= CLASH;
mcimadamore@1198 2396 String key = m1 == sym ?
mcimadamore@858 2397 "name.clash.same.erasure.no.override" :
mcimadamore@858 2398 "name.clash.same.erasure.no.override.1";
mcimadamore@858 2399 log.error(pos,
mcimadamore@858 2400 key,
mcimadamore@858 2401 sym, sym.location(),
mcimadamore@1198 2402 m2, m2.location(),
mcimadamore@1198 2403 m1, m1.location());
mcimadamore@858 2404 return;
mcimadamore@858 2405 }
mcimadamore@780 2406 }
mcimadamore@780 2407 }
vromero@2118 2408
vromero@2118 2409 if (!overridesAny) {
vromero@2118 2410 for (MethodSymbol m: potentiallyAmbiguousList) {
vromero@2118 2411 checkPotentiallyAmbiguousOverloads(pos, site, sym, m);
vromero@2118 2412 }
vromero@2118 2413 }
mcimadamore@780 2414 }
mcimadamore@780 2415
mcimadamore@858 2416 /** Check that all static methods accessible from 'site' are
mcimadamore@858 2417 * mutually compatible (JLS 8.4.8).
mcimadamore@858 2418 *
mcimadamore@858 2419 * @param pos Position to be used for error reporting.
mcimadamore@858 2420 * @param site The class whose methods are checked.
mcimadamore@858 2421 * @param sym The method symbol to be checked.
mcimadamore@780 2422 */
mcimadamore@858 2423 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
mcimadamore@780 2424 ClashFilter cf = new ClashFilter(site);
mcimadamore@858 2425 //for each method m1 that is a member of 'site'...
mcimadamore@1015 2426 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
mcimadamore@858 2427 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
mcimadamore@858 2428 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
vromero@2000 2429 if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck)) {
vromero@2000 2430 if (types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
vromero@2000 2431 log.error(pos,
vromero@2000 2432 "name.clash.same.erasure.no.hide",
vromero@2000 2433 sym, sym.location(),
vromero@2000 2434 s, s.location());
vromero@2000 2435 return;
vromero@2000 2436 } else {
vromero@2000 2437 checkPotentiallyAmbiguousOverloads(pos, site, sym, (MethodSymbol)s);
vromero@2000 2438 }
vromero@2000 2439 }
mcimadamore@858 2440 }
mcimadamore@858 2441 }
mcimadamore@780 2442
mcimadamore@858 2443 //where
mcimadamore@858 2444 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2445
mcimadamore@858 2446 Type site;
mcimadamore@780 2447
mcimadamore@858 2448 ClashFilter(Type site) {
mcimadamore@858 2449 this.site = site;
mcimadamore@858 2450 }
mcimadamore@858 2451
mcimadamore@858 2452 boolean shouldSkip(Symbol s) {
mcimadamore@858 2453 return (s.flags() & CLASH) != 0 &&
mcimadamore@858 2454 s.owner == site.tsym;
mcimadamore@858 2455 }
mcimadamore@858 2456
mcimadamore@858 2457 public boolean accepts(Symbol s) {
mcimadamore@858 2458 return s.kind == MTH &&
mcimadamore@858 2459 (s.flags() & SYNTHETIC) == 0 &&
mcimadamore@858 2460 !shouldSkip(s) &&
mcimadamore@858 2461 s.isInheritedIn(site.tsym, types) &&
mcimadamore@858 2462 !s.isConstructor();
mcimadamore@858 2463 }
mcimadamore@858 2464 }
mcimadamore@780 2465
mcimadamore@1393 2466 void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) {
mcimadamore@1393 2467 DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site);
mcimadamore@1393 2468 for (Symbol m : types.membersClosure(site, false).getElements(dcf)) {
mcimadamore@1393 2469 Assert.check(m.kind == MTH);
mcimadamore@1393 2470 List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m);
mcimadamore@1393 2471 if (prov.size() > 1) {
alundblad@2047 2472 ListBuffer<Symbol> abstracts = new ListBuffer<>();
alundblad@2047 2473 ListBuffer<Symbol> defaults = new ListBuffer<>();
mcimadamore@1393 2474 for (MethodSymbol provSym : prov) {
mcimadamore@1393 2475 if ((provSym.flags() & DEFAULT) != 0) {
mcimadamore@1393 2476 defaults = defaults.append(provSym);
mcimadamore@1393 2477 } else if ((provSym.flags() & ABSTRACT) != 0) {
mcimadamore@1393 2478 abstracts = abstracts.append(provSym);
mcimadamore@1393 2479 }
mcimadamore@1393 2480 if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) {
mcimadamore@1393 2481 //strong semantics - issue an error if two sibling interfaces
mcimadamore@1393 2482 //have two override-equivalent defaults - or if one is abstract
mcimadamore@1393 2483 //and the other is default
mcimadamore@1393 2484 String errKey;
mcimadamore@1393 2485 Symbol s1 = defaults.first();
mcimadamore@1393 2486 Symbol s2;
mcimadamore@1393 2487 if (defaults.size() > 1) {
mcimadamore@1393 2488 errKey = "types.incompatible.unrelated.defaults";
mcimadamore@1393 2489 s2 = defaults.toList().tail.head;
mcimadamore@1393 2490 } else {
mcimadamore@1393 2491 errKey = "types.incompatible.abstract.default";
mcimadamore@1393 2492 s2 = abstracts.first();
mcimadamore@1393 2493 }
mcimadamore@1393 2494 log.error(pos, errKey,
mcimadamore@1393 2495 Kinds.kindName(site.tsym), site,
mcimadamore@1393 2496 m.name, types.memberType(site, m).getParameterTypes(),
mcimadamore@1393 2497 s1.location(), s2.location());
mcimadamore@1393 2498 break;
mcimadamore@1393 2499 }
mcimadamore@1393 2500 }
mcimadamore@1393 2501 }
mcimadamore@1393 2502 }
mcimadamore@1393 2503 }
mcimadamore@1393 2504
mcimadamore@1393 2505 //where
mcimadamore@1393 2506 private class DefaultMethodClashFilter implements Filter<Symbol> {
mcimadamore@1393 2507
mcimadamore@1393 2508 Type site;
mcimadamore@1393 2509
mcimadamore@1393 2510 DefaultMethodClashFilter(Type site) {
mcimadamore@1393 2511 this.site = site;
mcimadamore@1393 2512 }
mcimadamore@1393 2513
mcimadamore@1393 2514 public boolean accepts(Symbol s) {
mcimadamore@1393 2515 return s.kind == MTH &&
mcimadamore@1393 2516 (s.flags() & DEFAULT) != 0 &&
mcimadamore@1393 2517 s.isInheritedIn(site.tsym, types) &&
mcimadamore@1393 2518 !s.isConstructor();
mcimadamore@1393 2519 }
mcimadamore@1393 2520 }
mcimadamore@1393 2521
vromero@2000 2522 /**
vromero@2000 2523 * Report warnings for potentially ambiguous method declarations. Two declarations
vromero@2000 2524 * are potentially ambiguous if they feature two unrelated functional interface
vromero@2000 2525 * in same argument position (in which case, a call site passing an implicit
vromero@2000 2526 * lambda would be ambiguous).
vromero@2000 2527 */
vromero@2000 2528 void checkPotentiallyAmbiguousOverloads(DiagnosticPosition pos, Type site,
vromero@2000 2529 MethodSymbol msym1, MethodSymbol msym2) {
vromero@2000 2530 if (msym1 != msym2 &&
vromero@2000 2531 allowDefaultMethods &&
vromero@2000 2532 lint.isEnabled(LintCategory.OVERLOADS) &&
vromero@2000 2533 (msym1.flags() & POTENTIALLY_AMBIGUOUS) == 0 &&
vromero@2000 2534 (msym2.flags() & POTENTIALLY_AMBIGUOUS) == 0) {
vromero@2000 2535 Type mt1 = types.memberType(site, msym1);
vromero@2000 2536 Type mt2 = types.memberType(site, msym2);
vromero@2000 2537 //if both generic methods, adjust type variables
vromero@2000 2538 if (mt1.hasTag(FORALL) && mt2.hasTag(FORALL) &&
vromero@2000 2539 types.hasSameBounds((ForAll)mt1, (ForAll)mt2)) {
vromero@2000 2540 mt2 = types.subst(mt2, ((ForAll)mt2).tvars, ((ForAll)mt1).tvars);
vromero@2000 2541 }
vromero@2000 2542 //expand varargs methods if needed
vromero@2000 2543 int maxLength = Math.max(mt1.getParameterTypes().length(), mt2.getParameterTypes().length());
vromero@2000 2544 List<Type> args1 = rs.adjustArgs(mt1.getParameterTypes(), msym1, maxLength, true);
vromero@2000 2545 List<Type> args2 = rs.adjustArgs(mt2.getParameterTypes(), msym2, maxLength, true);
vromero@2000 2546 //if arities don't match, exit
vromero@2000 2547 if (args1.length() != args2.length()) return;
vromero@2000 2548 boolean potentiallyAmbiguous = false;
vromero@2000 2549 while (args1.nonEmpty() && args2.nonEmpty()) {
vromero@2000 2550 Type s = args1.head;
vromero@2000 2551 Type t = args2.head;
vromero@2000 2552 if (!types.isSubtype(t, s) && !types.isSubtype(s, t)) {
vromero@2000 2553 if (types.isFunctionalInterface(s) && types.isFunctionalInterface(t) &&
vromero@2000 2554 types.findDescriptorType(s).getParameterTypes().length() > 0 &&
vromero@2000 2555 types.findDescriptorType(s).getParameterTypes().length() ==
vromero@2000 2556 types.findDescriptorType(t).getParameterTypes().length()) {
vromero@2000 2557 potentiallyAmbiguous = true;
vromero@2000 2558 } else {
vromero@2000 2559 break;
vromero@2000 2560 }
vromero@2000 2561 }
vromero@2000 2562 args1 = args1.tail;
vromero@2000 2563 args2 = args2.tail;
vromero@2000 2564 }
vromero@2000 2565 if (potentiallyAmbiguous) {
vromero@2000 2566 //we found two incompatible functional interfaces with same arity
vromero@2000 2567 //this means a call site passing an implicit lambda would be ambigiuous
vromero@2000 2568 msym1.flags_field |= POTENTIALLY_AMBIGUOUS;
vromero@2000 2569 msym2.flags_field |= POTENTIALLY_AMBIGUOUS;
vromero@2000 2570 log.warning(LintCategory.OVERLOADS, pos, "potentially.ambiguous.overload",
vromero@2000 2571 msym1, msym1.location(),
vromero@2000 2572 msym2, msym2.location());
vromero@2000 2573 return;
vromero@2000 2574 }
vromero@2000 2575 }
vromero@2000 2576 }
vromero@2000 2577
mcimadamore@359 2578 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2579 */
mcimadamore@359 2580 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2581 if (!sym.type.isErroneous()) {
mcimadamore@359 2582 if (warnOnSyntheticConflicts) {
mcimadamore@359 2583 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2584 }
mcimadamore@359 2585 else {
mcimadamore@359 2586 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2587 }
mcimadamore@359 2588 }
mcimadamore@359 2589 }
mcimadamore@359 2590
duke@1 2591 /** Check that class c does not implement directly or indirectly
duke@1 2592 * the same parameterized interface with two different argument lists.
duke@1 2593 * @param pos Position to be used for error reporting.
duke@1 2594 * @param type The type whose interfaces are checked.
duke@1 2595 */
duke@1 2596 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2597 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2598 }
duke@1 2599 //where
duke@1 2600 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2601 * with their class symbol as key and their type as value. Make
duke@1 2602 * sure no class is entered with two different types.
duke@1 2603 */
duke@1 2604 void checkClassBounds(DiagnosticPosition pos,
duke@1 2605 Map<TypeSymbol,Type> seensofar,
duke@1 2606 Type type) {
duke@1 2607 if (type.isErroneous()) return;
duke@1 2608 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2609 Type it = l.head;
duke@1 2610 Type oldit = seensofar.put(it.tsym, it);
duke@1 2611 if (oldit != null) {
duke@1 2612 List<Type> oldparams = oldit.allparams();
duke@1 2613 List<Type> newparams = it.allparams();
duke@1 2614 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2615 log.error(pos, "cant.inherit.diff.arg",
duke@1 2616 it.tsym, Type.toString(oldparams),
duke@1 2617 Type.toString(newparams));
duke@1 2618 }
duke@1 2619 checkClassBounds(pos, seensofar, it);
duke@1 2620 }
duke@1 2621 Type st = types.supertype(type);
duke@1 2622 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2623 }
duke@1 2624
duke@1 2625 /** Enter interface into into set.
duke@1 2626 * If it existed already, issue a "repeated interface" error.
duke@1 2627 */
duke@1 2628 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2629 if (its.contains(it))
duke@1 2630 log.error(pos, "repeated.interface");
duke@1 2631 else {
duke@1 2632 its.add(it);
duke@1 2633 }
duke@1 2634 }
duke@1 2635
duke@1 2636 /* *************************************************************************
duke@1 2637 * Check annotations
duke@1 2638 **************************************************************************/
duke@1 2639
mcimadamore@629 2640 /**
mcimadamore@634 2641 * Recursively validate annotations values
mcimadamore@629 2642 */
mcimadamore@634 2643 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2644 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2645 @Override
mcimadamore@629 2646 public void visitAnnotation(JCAnnotation tree) {
jjg@1017 2647 if (!tree.type.isErroneous()) {
jjg@1017 2648 super.visitAnnotation(tree);
jjg@1017 2649 validateAnnotation(tree);
jjg@1017 2650 }
mcimadamore@629 2651 }
mcimadamore@629 2652 }
mcimadamore@634 2653 tree.accept(new AnnotationValidator());
mcimadamore@629 2654 }
mcimadamore@629 2655
jjg@1326 2656 /**
jjg@1326 2657 * {@literal
jjg@1326 2658 * Annotation types are restricted to primitives, String, an
duke@1 2659 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2660 * Anything>, arrays of the preceding.
jjg@1326 2661 * }
duke@1 2662 */
duke@1 2663 void validateAnnotationType(JCTree restype) {
duke@1 2664 // restype may be null if an error occurred, so don't bother validating it
duke@1 2665 if (restype != null) {
duke@1 2666 validateAnnotationType(restype.pos(), restype.type);
duke@1 2667 }
duke@1 2668 }
duke@1 2669
duke@1 2670 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2671 if (type.isPrimitive()) return;
duke@1 2672 if (types.isSameType(type, syms.stringType)) return;
duke@1 2673 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2674 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2675 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2676 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2677 validateAnnotationType(pos, types.elemtype(type));
duke@1 2678 return;
duke@1 2679 }
duke@1 2680 log.error(pos, "invalid.annotation.member.type");
duke@1 2681 }
duke@1 2682
duke@1 2683 /**
duke@1 2684 * "It is also a compile-time error if any method declared in an
duke@1 2685 * annotation type has a signature that is override-equivalent to
duke@1 2686 * that of any public or protected method declared in class Object
duke@1 2687 * or in the interface annotation.Annotation."
duke@1 2688 *
jjh@972 2689 * @jls 9.6 Annotation Types
duke@1 2690 */
duke@1 2691 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
jjg@1374 2692 for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
duke@1 2693 Scope s = sup.tsym.members();
duke@1 2694 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2695 if (e.sym.kind == MTH &&
duke@1 2696 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2697 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2698 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2699 }
duke@1 2700 }
duke@1 2701 }
duke@1 2702
duke@1 2703 /** Check the annotations of a symbol.
duke@1 2704 */
duke@1 2705 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2706 for (JCAnnotation a : annotations)
duke@1 2707 validateAnnotation(a, s);
duke@1 2708 }
duke@1 2709
jjg@1521 2710 /** Check the type annotations.
jjg@1521 2711 */
jjg@1521 2712 public void validateTypeAnnotations(List<JCAnnotation> annotations, boolean isTypeParameter) {
jjg@1521 2713 for (JCAnnotation a : annotations)
jjg@1521 2714 validateTypeAnnotation(a, isTypeParameter);
jjg@1521 2715 }
jjg@1521 2716
duke@1 2717 /** Check an annotation of a symbol.
duke@1 2718 */
jfranck@1313 2719 private void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2720 validateAnnotationTree(a);
duke@1 2721
duke@1 2722 if (!annotationApplicable(a, s))
duke@1 2723 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2724
mcimadamore@1497 2725 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
mcimadamore@1497 2726 if (s.kind != TYP) {
mcimadamore@1497 2727 log.error(a.pos(), "bad.functional.intf.anno");
jlahoda@2111 2728 } else if (!s.isInterface() || (s.flags() & ANNOTATION) != 0) {
jlahoda@2111 2729 log.error(a.pos(), "bad.functional.intf.anno.1", diags.fragment("not.a.functional.intf", s));
mcimadamore@1497 2730 }
mcimadamore@1497 2731 }
duke@1 2732 }
duke@1 2733
jjg@1521 2734 public void validateTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2735 Assert.checkNonNull(a.type, "annotation tree hasn't been attributed yet: " + a);
jjg@1521 2736 validateAnnotationTree(a);
jjg@1521 2737
jjg@2134 2738 if (a.hasTag(TYPE_ANNOTATION) &&
jjg@2134 2739 !a.annotationType.type.isErroneous() &&
jjg@2134 2740 !isTypeAnnotation(a, isTypeParameter)) {
jjg@1521 2741 log.error(a.pos(), "annotation.type.not.applicable");
jjg@2134 2742 }
jjg@1521 2743 }
jjg@1521 2744
jfranck@1313 2745 /**
jjg@1492 2746 * Validate the proposed container 'repeatable' on the
jfranck@1313 2747 * annotation type symbol 's'. Report errors at position
jfranck@1313 2748 * 'pos'.
jfranck@1313 2749 *
jjg@1492 2750 * @param s The (annotation)type declaration annotated with a @Repeatable
jjg@1492 2751 * @param repeatable the @Repeatable on 's'
jfranck@1313 2752 * @param pos where to report errors
jfranck@1313 2753 */
jjg@1492 2754 public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) {
jjg@1492 2755 Assert.check(types.isSameType(repeatable.type, syms.repeatableType));
jfranck@1313 2756
jfranck@1313 2757 Type t = null;
jjg@1492 2758 List<Pair<MethodSymbol,Attribute>> l = repeatable.values;
jfranck@1313 2759 if (!l.isEmpty()) {
jfranck@1313 2760 Assert.check(l.head.fst.name == names.value);
jfranck@1313 2761 t = ((Attribute.Class)l.head.snd).getValue();
jfranck@1313 2762 }
jfranck@1313 2763
jfranck@1313 2764 if (t == null) {
jjg@1492 2765 // errors should already have been reported during Annotate
jfranck@1313 2766 return;
jfranck@1313 2767 }
jfranck@1313 2768
jjg@1492 2769 validateValue(t.tsym, s, pos);
jfranck@1313 2770 validateRetention(t.tsym, s, pos);
jfranck@1313 2771 validateDocumented(t.tsym, s, pos);
jfranck@1313 2772 validateInherited(t.tsym, s, pos);
jfranck@1313 2773 validateTarget(t.tsym, s, pos);
jfranck@1344 2774 validateDefault(t.tsym, s, pos);
jfranck@1313 2775 }
jfranck@1313 2776
jjg@1492 2777 private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
jjg@1492 2778 Scope.Entry e = container.members().lookup(names.value);
jjg@1492 2779 if (e.scope != null && e.sym.kind == MTH) {
jjg@1492 2780 MethodSymbol m = (MethodSymbol) e.sym;
jjg@1492 2781 Type ret = m.getReturnType();
jjg@1492 2782 if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) {
jjg@1492 2783 log.error(pos, "invalid.repeatable.annotation.value.return",
jjg@1492 2784 container, ret, types.makeArrayType(contained.type));
jjg@1492 2785 }
jjg@1492 2786 } else {
jjg@1492 2787 log.error(pos, "invalid.repeatable.annotation.no.value", container);
jfranck@1313 2788 }
jfranck@1313 2789 }
jfranck@1313 2790
jfranck@1313 2791 private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2792 Attribute.RetentionPolicy containerRetention = types.getRetention(container);
jfranck@1313 2793 Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
jfranck@1313 2794
jfranck@1313 2795 boolean error = false;
jfranck@1313 2796 switch (containedRetention) {
jfranck@1313 2797 case RUNTIME:
jfranck@1313 2798 if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
jfranck@1313 2799 error = true;
jfranck@1313 2800 }
jfranck@1313 2801 break;
jfranck@1313 2802 case CLASS:
jfranck@1313 2803 if (containerRetention == Attribute.RetentionPolicy.SOURCE) {
jfranck@1313 2804 error = true;
jfranck@1313 2805 }
jfranck@1313 2806 }
jfranck@1313 2807 if (error ) {
jjg@1492 2808 log.error(pos, "invalid.repeatable.annotation.retention",
jfranck@1313 2809 container, containerRetention,
jfranck@1313 2810 contained, containedRetention);
jfranck@1313 2811 }
jfranck@1313 2812 }
jfranck@1313 2813
jfranck@1313 2814 private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2815 if (contained.attribute(syms.documentedType.tsym) != null) {
jfranck@1313 2816 if (container.attribute(syms.documentedType.tsym) == null) {
jjg@1492 2817 log.error(pos, "invalid.repeatable.annotation.not.documented", container, contained);
jfranck@1313 2818 }
jfranck@1313 2819 }
jfranck@1313 2820 }
jfranck@1313 2821
jfranck@1313 2822 private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1313 2823 if (contained.attribute(syms.inheritedType.tsym) != null) {
jfranck@1313 2824 if (container.attribute(syms.inheritedType.tsym) == null) {
jjg@1492 2825 log.error(pos, "invalid.repeatable.annotation.not.inherited", container, contained);
jfranck@1313 2826 }
jfranck@1313 2827 }
jfranck@1313 2828 }
jfranck@1313 2829
jfranck@1313 2830 private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1634 2831 // The set of targets the container is applicable to must be a subset
jfranck@1634 2832 // (with respect to annotation target semantics) of the set of targets
jfranck@1634 2833 // the contained is applicable to. The target sets may be implicit or
jfranck@1634 2834 // explicit.
jfranck@1634 2835
jfranck@1634 2836 Set<Name> containerTargets;
jfranck@1313 2837 Attribute.Array containerTarget = getAttributeTargetAttribute(container);
jfranck@1313 2838 if (containerTarget == null) {
jfranck@1634 2839 containerTargets = getDefaultTargetSet();
jfranck@1634 2840 } else {
jfranck@1634 2841 containerTargets = new HashSet<Name>();
jfranck@1313 2842 for (Attribute app : containerTarget.values) {
jfranck@1313 2843 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2844 continue; // recovery
jfranck@1313 2845 }
jfranck@1313 2846 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2847 containerTargets.add(e.value.name);
jfranck@1313 2848 }
jfranck@1634 2849 }
jfranck@1634 2850
jfranck@1634 2851 Set<Name> containedTargets;
jfranck@1634 2852 Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
jfranck@1634 2853 if (containedTarget == null) {
jfranck@1634 2854 containedTargets = getDefaultTargetSet();
jfranck@1634 2855 } else {
jfranck@1634 2856 containedTargets = new HashSet<Name>();
jfranck@1313 2857 for (Attribute app : containedTarget.values) {
jfranck@1313 2858 if (!(app instanceof Attribute.Enum)) {
jfranck@1313 2859 continue; // recovery
jfranck@1313 2860 }
jfranck@1313 2861 Attribute.Enum e = (Attribute.Enum)app;
jfranck@1313 2862 containedTargets.add(e.value.name);
jfranck@1313 2863 }
jfranck@1634 2864 }
jfranck@1634 2865
jfranck@1634 2866 if (!isTargetSubsetOf(containerTargets, containedTargets)) {
jjg@1492 2867 log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
jfranck@1313 2868 }
jfranck@1313 2869 }
jfranck@1313 2870
jfranck@1634 2871 /* get a set of names for the default target */
jfranck@1634 2872 private Set<Name> getDefaultTargetSet() {
jfranck@1634 2873 if (defaultTargets == null) {
jfranck@1634 2874 Set<Name> targets = new HashSet<Name>();
jfranck@1634 2875 targets.add(names.ANNOTATION_TYPE);
jfranck@1634 2876 targets.add(names.CONSTRUCTOR);
jfranck@1634 2877 targets.add(names.FIELD);
jfranck@1634 2878 targets.add(names.LOCAL_VARIABLE);
jfranck@1634 2879 targets.add(names.METHOD);
jfranck@1634 2880 targets.add(names.PACKAGE);
jfranck@1634 2881 targets.add(names.PARAMETER);
jfranck@1634 2882 targets.add(names.TYPE);
jfranck@1634 2883
jfranck@1634 2884 defaultTargets = java.util.Collections.unmodifiableSet(targets);
jfranck@1634 2885 }
jfranck@1634 2886
jfranck@1634 2887 return defaultTargets;
jfranck@1634 2888 }
jfranck@1634 2889 private Set<Name> defaultTargets;
jfranck@1634 2890
jfranck@1634 2891
jfranck@1634 2892 /** Checks that s is a subset of t, with respect to ElementType
jfranck@1313 2893 * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE}
jfranck@1313 2894 */
jfranck@1634 2895 private boolean isTargetSubsetOf(Set<Name> s, Set<Name> t) {
jfranck@1634 2896 // Check that all elements in s are present in t
jfranck@1634 2897 for (Name n2 : s) {
jfranck@1313 2898 boolean currentElementOk = false;
jfranck@1634 2899 for (Name n1 : t) {
jfranck@1313 2900 if (n1 == n2) {
jfranck@1313 2901 currentElementOk = true;
jfranck@1313 2902 break;
jfranck@1313 2903 } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
jfranck@1313 2904 currentElementOk = true;
jfranck@1313 2905 break;
jfranck@1313 2906 }
jfranck@1313 2907 }
jfranck@1313 2908 if (!currentElementOk)
jfranck@1313 2909 return false;
jfranck@1313 2910 }
jfranck@1313 2911 return true;
jfranck@1313 2912 }
jfranck@1313 2913
jfranck@1344 2914 private void validateDefault(Symbol container, Symbol contained, DiagnosticPosition pos) {
jfranck@1344 2915 // validate that all other elements of containing type has defaults
jfranck@1344 2916 Scope scope = container.members();
jfranck@1344 2917 for(Symbol elm : scope.getElements()) {
jfranck@1344 2918 if (elm.name != names.value &&
jfranck@1344 2919 elm.kind == Kinds.MTH &&
jfranck@1344 2920 ((MethodSymbol)elm).defaultValue == null) {
jfranck@1344 2921 log.error(pos,
jjg@1492 2922 "invalid.repeatable.annotation.elem.nondefault",
jfranck@1344 2923 container,
jfranck@1344 2924 elm);
jfranck@1344 2925 }
jfranck@1344 2926 }
jfranck@1344 2927 }
jfranck@1344 2928
duke@1 2929 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2930 boolean isOverrider(Symbol s) {
duke@1 2931 if (s.kind != MTH || s.isStatic())
duke@1 2932 return false;
duke@1 2933 MethodSymbol m = (MethodSymbol)s;
duke@1 2934 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2935 for (Type sup : types.closure(owner.type)) {
duke@1 2936 if (sup == owner.type)
duke@1 2937 continue; // skip "this"
duke@1 2938 Scope scope = sup.tsym.members();
duke@1 2939 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2940 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2941 return true;
duke@1 2942 }
duke@1 2943 }
duke@1 2944 return false;
duke@1 2945 }
duke@1 2946
jlahoda@2111 2947 /** Is the annotation applicable to types? */
jjg@1521 2948 protected boolean isTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
jjg@1521 2949 Attribute.Compound atTarget =
jjg@1521 2950 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
jjg@1521 2951 if (atTarget == null) {
jjg@1521 2952 // An annotation without @Target is not a type annotation.
jjg@1521 2953 return false;
jjg@1521 2954 }
jjg@1521 2955
jjg@1521 2956 Attribute atValue = atTarget.member(names.value);
jjg@1521 2957 if (!(atValue instanceof Attribute.Array)) {
jjg@1521 2958 return false; // error recovery
jjg@1521 2959 }
jjg@1521 2960
jjg@1521 2961 Attribute.Array arr = (Attribute.Array) atValue;
jjg@1521 2962 for (Attribute app : arr.values) {
jjg@1521 2963 if (!(app instanceof Attribute.Enum)) {
jjg@1521 2964 return false; // recovery
jjg@1521 2965 }
jjg@1521 2966 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 2967
jjg@1521 2968 if (e.value.name == names.TYPE_USE)
jjg@1521 2969 return true;
jjg@1521 2970 else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER)
jjg@1521 2971 return true;
jjg@1521 2972 }
jjg@1521 2973 return false;
jjg@1521 2974 }
jjg@1521 2975
duke@1 2976 /** Is the annotation applicable to the symbol? */
duke@1 2977 boolean annotationApplicable(JCAnnotation a, Symbol s) {
jfranck@1313 2978 Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
jjg@1521 2979 Name[] targets;
jfranck@1313 2980 if (arr == null) {
jjg@1521 2981 targets = defaultTargetMetaInfo(a, s);
jjg@1521 2982 } else {
jjg@1521 2983 // TODO: can we optimize this?
jjg@1521 2984 targets = new Name[arr.values.length];
jjg@1521 2985 for (int i=0; i<arr.values.length; ++i) {
jjg@1521 2986 Attribute app = arr.values[i];
jjg@1521 2987 if (!(app instanceof Attribute.Enum)) {
jjg@1521 2988 return true; // recovery
jjg@1521 2989 }
jjg@1521 2990 Attribute.Enum e = (Attribute.Enum) app;
jjg@1521 2991 targets[i] = e.value.name;
jjg@1521 2992 }
jfranck@1313 2993 }
jjg@1521 2994 for (Name target : targets) {
jjg@1521 2995 if (target == names.TYPE)
emc@2168 2996 { if (s.kind == TYP && !s.isAnonymous()) return true; }
jjg@1521 2997 else if (target == names.FIELD)
duke@1 2998 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
jjg@1521 2999 else if (target == names.METHOD)
duke@1 3000 { if (s.kind == MTH && !s.isConstructor()) return true; }
jjg@1521 3001 else if (target == names.PARAMETER)
duke@1 3002 { if (s.kind == VAR &&
duke@1 3003 s.owner.kind == MTH &&
duke@1 3004 (s.flags() & PARAMETER) != 0)
duke@1 3005 return true;
duke@1 3006 }
jjg@1521 3007 else if (target == names.CONSTRUCTOR)
duke@1 3008 { if (s.kind == MTH && s.isConstructor()) return true; }
jjg@1521 3009 else if (target == names.LOCAL_VARIABLE)
duke@1 3010 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 3011 (s.flags() & PARAMETER) == 0)
duke@1 3012 return true;
duke@1 3013 }
jjg@1521 3014 else if (target == names.ANNOTATION_TYPE)
duke@1 3015 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 3016 return true;
duke@1 3017 }
jjg@1521 3018 else if (target == names.PACKAGE)
duke@1 3019 { if (s.kind == PCK) return true; }
jjg@1521 3020 else if (target == names.TYPE_USE)
jjg@308 3021 { if (s.kind == TYP ||
jjg@308 3022 s.kind == VAR ||
jjg@308 3023 (s.kind == MTH && !s.isConstructor() &&
jjg@1521 3024 !s.type.getReturnType().hasTag(VOID)) ||
jjg@1521 3025 (s.kind == MTH && s.isConstructor()))
jjg@1521 3026 return true;
jjg@1521 3027 }
jjg@1521 3028 else if (target == names.TYPE_PARAMETER)
jjg@1521 3029 { if (s.kind == TYP && s.type.hasTag(TYPEVAR))
jjg@308 3030 return true;
jjg@308 3031 }
duke@1 3032 else
duke@1 3033 return true; // recovery
duke@1 3034 }
duke@1 3035 return false;
duke@1 3036 }
duke@1 3037
jfranck@1313 3038
jfranck@1313 3039 Attribute.Array getAttributeTargetAttribute(Symbol s) {
jfranck@1313 3040 Attribute.Compound atTarget =
jfranck@1313 3041 s.attribute(syms.annotationTargetType.tsym);
jfranck@1313 3042 if (atTarget == null) return null; // ok, is applicable
jfranck@1313 3043 Attribute atValue = atTarget.member(names.value);
jfranck@1313 3044 if (!(atValue instanceof Attribute.Array)) return null; // error recovery
jfranck@1313 3045 return (Attribute.Array) atValue;
jfranck@1313 3046 }
jfranck@1313 3047
jjg@1521 3048 private final Name[] dfltTargetMeta;
jjg@1521 3049 private Name[] defaultTargetMetaInfo(JCAnnotation a, Symbol s) {
jjg@1521 3050 return dfltTargetMeta;
jjg@1521 3051 }
jjg@1521 3052
duke@1 3053 /** Check an annotation value.
jfranck@1445 3054 *
jfranck@1445 3055 * @param a The annotation tree to check
jfranck@1445 3056 * @return true if this annotation tree is valid, otherwise false
duke@1 3057 */
jfranck@1445 3058 public boolean validateAnnotationDeferErrors(JCAnnotation a) {
jfranck@1445 3059 boolean res = false;
jfranck@1445 3060 final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log);
jfranck@1445 3061 try {
jfranck@1445 3062 res = validateAnnotation(a);
jfranck@1445 3063 } finally {
jfranck@1445 3064 log.popDiagnosticHandler(diagHandler);
jfranck@1445 3065 }
jfranck@1445 3066 return res;
jfranck@1445 3067 }
jfranck@1445 3068
jfranck@1445 3069 private boolean validateAnnotation(JCAnnotation a) {
jfranck@1445 3070 boolean isValid = true;
jfranck@1445 3071 // collect an inventory of the annotation elements
jfranck@1445 3072 Set<MethodSymbol> members = new LinkedHashSet<MethodSymbol>();
duke@1 3073 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
jfranck@1729 3074 e != null;
jfranck@1729 3075 e = e.sibling)
mcimadamore@1920 3076 if (e.sym.kind == MTH && e.sym.name != names.clinit &&
mcimadamore@1920 3077 (e.sym.flags() & SYNTHETIC) == 0)
duke@1 3078 members.add((MethodSymbol) e.sym);
duke@1 3079
jfranck@1445 3080 // remove the ones that are assigned values
duke@1 3081 for (JCTree arg : a.args) {
jjg@1127 3082 if (!arg.hasTag(ASSIGN)) continue; // recovery
duke@1 3083 JCAssign assign = (JCAssign) arg;
duke@1 3084 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 3085 if (m == null || m.type.isErroneous()) continue;
jfranck@1445 3086 if (!members.remove(m)) {
jfranck@1445 3087 isValid = false;
jjg@479 3088 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 3089 m.name, a.type);
jfranck@1445 3090 }
duke@1 3091 }
duke@1 3092
duke@1 3093 // all the remaining ones better have default values
jfranck@1445 3094 List<Name> missingDefaults = List.nil();
mcimadamore@632 3095 for (MethodSymbol m : members) {
mcimadamore@632 3096 if (m.defaultValue == null && !m.type.isErroneous()) {
jfranck@1445 3097 missingDefaults = missingDefaults.append(m.name);
mcimadamore@632 3098 }
mcimadamore@632 3099 }
jfranck@1445 3100 missingDefaults = missingDefaults.reverse();
mcimadamore@632 3101 if (missingDefaults.nonEmpty()) {
jfranck@1445 3102 isValid = false;
mcimadamore@632 3103 String key = (missingDefaults.size() > 1)
mcimadamore@632 3104 ? "annotation.missing.default.value.1"
mcimadamore@632 3105 : "annotation.missing.default.value";
mcimadamore@632 3106 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 3107 }
duke@1 3108
duke@1 3109 // special case: java.lang.annotation.Target must not have
duke@1 3110 // repeated values in its value member
duke@1 3111 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 3112 a.args.tail == null)
jfranck@1445 3113 return isValid;
duke@1 3114
jfranck@1445 3115 if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery
duke@1 3116 JCAssign assign = (JCAssign) a.args.head;
duke@1 3117 Symbol m = TreeInfo.symbol(assign.lhs);
jfranck@1445 3118 if (m.name != names.value) return false;
duke@1 3119 JCTree rhs = assign.rhs;
jfranck@1445 3120 if (!rhs.hasTag(NEWARRAY)) return false;
duke@1 3121 JCNewArray na = (JCNewArray) rhs;
duke@1 3122 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 3123 for (JCTree elem : na.elems) {
duke@1 3124 if (!targets.add(TreeInfo.symbol(elem))) {
jfranck@1445 3125 isValid = false;
duke@1 3126 log.error(elem.pos(), "repeated.annotation.target");
duke@1 3127 }
duke@1 3128 }
jfranck@1445 3129 return isValid;
duke@1 3130 }
duke@1 3131
duke@1 3132 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 3133 if (allowAnnotations &&
mcimadamore@795 3134 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 3135 (s.flags() & DEPRECATED) != 0 &&
duke@1 3136 !syms.deprecatedType.isErroneous() &&
duke@1 3137 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 3138 log.warning(LintCategory.DEP_ANN,
jjg@612 3139 pos, "missing.deprecated.annotation");
duke@1 3140 }
duke@1 3141 }
duke@1 3142
mcimadamore@852 3143 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
mcimadamore@852 3144 if ((s.flags() & DEPRECATED) != 0 &&
mcimadamore@852 3145 (other.flags() & DEPRECATED) == 0 &&
mcimadamore@852 3146 s.outermostClass() != other.outermostClass()) {
mcimadamore@852 3147 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3148 @Override
mcimadamore@852 3149 public void report() {
mcimadamore@852 3150 warnDeprecated(pos, s);
mcimadamore@852 3151 }
mcimadamore@852 3152 });
jjg@1157 3153 }
mcimadamore@852 3154 }
mcimadamore@852 3155
mcimadamore@852 3156 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
mcimadamore@852 3157 if ((s.flags() & PROPRIETARY) != 0) {
mcimadamore@852 3158 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
mcimadamore@852 3159 public void report() {
mcimadamore@852 3160 if (enableSunApiLintControl)
mcimadamore@852 3161 warnSunApi(pos, "sun.proprietary", s);
mcimadamore@852 3162 else
mcimadamore@1218 3163 log.mandatoryWarning(pos, "sun.proprietary", s);
mcimadamore@852 3164 }
mcimadamore@852 3165 });
mcimadamore@852 3166 }
mcimadamore@852 3167 }
mcimadamore@852 3168
jjg@1569 3169 void checkProfile(final DiagnosticPosition pos, final Symbol s) {
jjg@1569 3170 if (profile != Profile.DEFAULT && (s.flags() & NOT_IN_PROFILE) != 0) {
jjg@1569 3171 log.error(pos, "not.in.profile", s, profile);
jjg@1569 3172 }
jjg@1569 3173 }
jjg@1569 3174
duke@1 3175 /* *************************************************************************
duke@1 3176 * Check for recursive annotation elements.
duke@1 3177 **************************************************************************/
duke@1 3178
duke@1 3179 /** Check for cycles in the graph of annotation elements.
duke@1 3180 */
duke@1 3181 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 3182 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 3183 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 3184 try {
duke@1 3185 tree.sym.flags_field |= LOCKED;
duke@1 3186 for (JCTree def : tree.defs) {
jjg@1127 3187 if (!def.hasTag(METHODDEF)) continue;
duke@1 3188 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 3189 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 3190 }
duke@1 3191 } finally {
duke@1 3192 tree.sym.flags_field &= ~LOCKED;
duke@1 3193 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 3194 }
duke@1 3195 }
duke@1 3196
duke@1 3197 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 3198 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 3199 return;
duke@1 3200 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 3201 log.error(pos, "cyclic.annotation.element");
duke@1 3202 return;
duke@1 3203 }
duke@1 3204 try {
duke@1 3205 tsym.flags_field |= LOCKED;
duke@1 3206 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 3207 Symbol s = e.sym;
duke@1 3208 if (s.kind != Kinds.MTH)
duke@1 3209 continue;
duke@1 3210 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 3211 }
duke@1 3212 } finally {
duke@1 3213 tsym.flags_field &= ~LOCKED;
duke@1 3214 tsym.flags_field |= ACYCLIC_ANN;
duke@1 3215 }
duke@1 3216 }
duke@1 3217
duke@1 3218 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
jjg@1374 3219 switch (type.getTag()) {
jjg@1374 3220 case CLASS:
duke@1 3221 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 3222 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 3223 break;
jjg@1374 3224 case ARRAY:
duke@1 3225 checkAnnotationResType(pos, types.elemtype(type));
duke@1 3226 break;
duke@1 3227 default:
duke@1 3228 break; // int etc
duke@1 3229 }
duke@1 3230 }
duke@1 3231
duke@1 3232 /* *************************************************************************
duke@1 3233 * Check for cycles in the constructor call graph.
duke@1 3234 **************************************************************************/
duke@1 3235
duke@1 3236 /** Check for cycles in the graph of constructors calling other
duke@1 3237 * constructors.
duke@1 3238 */
duke@1 3239 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 3240 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 3241
duke@1 3242 // enter each constructor this-call into the map
duke@1 3243 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 3244 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 3245 if (app == null) continue;
duke@1 3246 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 3247 if (TreeInfo.name(app.meth) == names._this) {
duke@1 3248 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 3249 } else {
duke@1 3250 meth.sym.flags_field |= ACYCLIC;
duke@1 3251 }
duke@1 3252 }
duke@1 3253
duke@1 3254 // Check for cycles in the map
duke@1 3255 Symbol[] ctors = new Symbol[0];
duke@1 3256 ctors = callMap.keySet().toArray(ctors);
duke@1 3257 for (Symbol caller : ctors) {
duke@1 3258 checkCyclicConstructor(tree, caller, callMap);
duke@1 3259 }
duke@1 3260 }
duke@1 3261
duke@1 3262 /** Look in the map to see if the given constructor is part of a
duke@1 3263 * call cycle.
duke@1 3264 */
duke@1 3265 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 3266 Map<Symbol,Symbol> callMap) {
duke@1 3267 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 3268 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 3269 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 3270 "recursive.ctor.invocation");
duke@1 3271 } else {
duke@1 3272 ctor.flags_field |= LOCKED;
duke@1 3273 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 3274 ctor.flags_field &= ~LOCKED;
duke@1 3275 }
duke@1 3276 ctor.flags_field |= ACYCLIC;
duke@1 3277 }
duke@1 3278 }
duke@1 3279
duke@1 3280 /* *************************************************************************
duke@1 3281 * Miscellaneous
duke@1 3282 **************************************************************************/
duke@1 3283
duke@1 3284 /**
duke@1 3285 * Return the opcode of the operator but emit an error if it is an
duke@1 3286 * error.
duke@1 3287 * @param pos position for error reporting.
duke@1 3288 * @param operator an operator
duke@1 3289 * @param tag a tree tag
duke@1 3290 * @param left type of left hand side
duke@1 3291 * @param right type of right hand side
duke@1 3292 */
duke@1 3293 int checkOperator(DiagnosticPosition pos,
duke@1 3294 OperatorSymbol operator,
jjg@1127 3295 JCTree.Tag tag,
duke@1 3296 Type left,
duke@1 3297 Type right) {
duke@1 3298 if (operator.opcode == ByteCodes.error) {
duke@1 3299 log.error(pos,
mcimadamore@853 3300 "operator.cant.be.applied.1",
duke@1 3301 treeinfo.operatorName(tag),
mcimadamore@853 3302 left, right);
duke@1 3303 }
duke@1 3304 return operator.opcode;
duke@1 3305 }
duke@1 3306
duke@1 3307
duke@1 3308 /**
duke@1 3309 * Check for division by integer constant zero
duke@1 3310 * @param pos Position for error reporting.
duke@1 3311 * @param operator The operator for the expression
duke@1 3312 * @param operand The right hand operand for the expression
duke@1 3313 */
duke@1 3314 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 3315 if (operand.constValue() != null
mcimadamore@795 3316 && lint.isEnabled(LintCategory.DIVZERO)
vromero@1826 3317 && operand.getTag().isSubRangeOf(LONG)
duke@1 3318 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 3319 int opc = ((OperatorSymbol)operator).opcode;
duke@1 3320 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 3321 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 3322 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 3323 }
duke@1 3324 }
duke@1 3325 }
duke@1 3326
duke@1 3327 /**
duke@1 3328 * Check for empty statements after if
duke@1 3329 */
duke@1 3330 void checkEmptyIf(JCIf tree) {
jjg@1127 3331 if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
jjg@1127 3332 lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 3333 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 3334 }
duke@1 3335
duke@1 3336 /** Check that symbol is unique in given scope.
duke@1 3337 * @param pos Position for error reporting.
duke@1 3338 * @param sym The symbol.
duke@1 3339 * @param s The scope.
duke@1 3340 */
duke@1 3341 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3342 if (sym.type.isErroneous())
duke@1 3343 return true;
duke@1 3344 if (sym.owner.name == names.any) return false;
duke@1 3345 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 3346 if (sym != e.sym &&
mcimadamore@858 3347 (e.sym.flags() & CLASH) == 0 &&
mcimadamore@858 3348 sym.kind == e.sym.kind &&
mcimadamore@858 3349 sym.name != names.error &&
emc@2024 3350 (sym.kind != MTH ||
emc@2024 3351 types.hasSameArgs(sym.type, e.sym.type) ||
emc@2024 3352 types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 3353 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 3354 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 3355 return true;
mcimadamore@907 3356 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
mcimadamore@252 3357 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 3358 sym.flags_field |= CLASH;
mcimadamore@844 3359 return true;
mcimadamore@844 3360 } else {
duke@1 3361 duplicateError(pos, e.sym);
mcimadamore@844 3362 return false;
mcimadamore@844 3363 }
duke@1 3364 }
duke@1 3365 }
duke@1 3366 return true;
duke@1 3367 }
mcimadamore@844 3368
mcimadamore@858 3369 /** Report duplicate declaration error.
mcimadamore@858 3370 */
mcimadamore@858 3371 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@858 3372 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@858 3373 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 3374 }
mcimadamore@858 3375 }
duke@1 3376
duke@1 3377 /** Check that single-type import is not already imported or top-level defined,
duke@1 3378 * but make an exception for two single-type imports which denote the same type.
duke@1 3379 * @param pos Position for error reporting.
duke@1 3380 * @param sym The symbol.
duke@1 3381 * @param s The scope
duke@1 3382 */
duke@1 3383 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3384 return checkUniqueImport(pos, sym, s, false);
duke@1 3385 }
duke@1 3386
duke@1 3387 /** Check that static single-type import is not already imported or top-level defined,
duke@1 3388 * but make an exception for two single-type imports which denote the same type.
duke@1 3389 * @param pos Position for error reporting.
duke@1 3390 * @param sym The symbol.
duke@1 3391 * @param s The scope
duke@1 3392 */
duke@1 3393 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 3394 return checkUniqueImport(pos, sym, s, true);
duke@1 3395 }
duke@1 3396
duke@1 3397 /** Check that single-type import is not already imported or top-level defined,
duke@1 3398 * but make an exception for two single-type imports which denote the same type.
duke@1 3399 * @param pos Position for error reporting.
duke@1 3400 * @param sym The symbol.
duke@1 3401 * @param s The scope.
duke@1 3402 * @param staticImport Whether or not this was a static import
duke@1 3403 */
duke@1 3404 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 3405 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 3406 // is encountered class entered via a class declaration?
duke@1 3407 boolean isClassDecl = e.scope == s;
duke@1 3408 if ((isClassDecl || sym != e.sym) &&
duke@1 3409 sym.kind == e.sym.kind &&
mcimadamore@1945 3410 sym.name != names.error &&
mcimadamore@1945 3411 (!staticImport || !e.isStaticallyImported())) {
duke@1 3412 if (!e.sym.type.isErroneous()) {
duke@1 3413 if (!isClassDecl) {
duke@1 3414 if (staticImport)
emc@2102 3415 log.error(pos, "already.defined.static.single.import", e.sym);
duke@1 3416 else
emc@2102 3417 log.error(pos, "already.defined.single.import", e.sym);
duke@1 3418 }
duke@1 3419 else if (sym != e.sym)
emc@2102 3420 log.error(pos, "already.defined.this.unit", e.sym);
duke@1 3421 }
duke@1 3422 return false;
duke@1 3423 }
duke@1 3424 }
duke@1 3425 return true;
duke@1 3426 }
duke@1 3427
duke@1 3428 /** Check that a qualified name is in canonical form (for import decls).
duke@1 3429 */
duke@1 3430 public void checkCanonical(JCTree tree) {
duke@1 3431 if (!isCanonical(tree))
duke@1 3432 log.error(tree.pos(), "import.requires.canonical",
duke@1 3433 TreeInfo.symbol(tree));
duke@1 3434 }
duke@1 3435 // where
duke@1 3436 private boolean isCanonical(JCTree tree) {
jjg@1127 3437 while (tree.hasTag(SELECT)) {
duke@1 3438 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 3439 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 3440 return false;
duke@1 3441 tree = s.selected;
duke@1 3442 }
duke@1 3443 return true;
duke@1 3444 }
duke@1 3445
ohrstrom@1384 3446 /** Check that an auxiliary class is not accessed from any other file than its own.
ohrstrom@1384 3447 */
ohrstrom@1384 3448 void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) {
ohrstrom@1384 3449 if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) &&
ohrstrom@1384 3450 (c.flags() & AUXILIARY) != 0 &&
ohrstrom@1384 3451 rs.isAccessible(env, c) &&
ohrstrom@1384 3452 !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile))
ohrstrom@1384 3453 {
ohrstrom@1384 3454 log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file",
ohrstrom@1384 3455 c, c.sourcefile);
ohrstrom@1384 3456 }
ohrstrom@1384 3457 }
ohrstrom@1384 3458
duke@1 3459 private class ConversionWarner extends Warner {
mcimadamore@795 3460 final String uncheckedKey;
duke@1 3461 final Type found;
duke@1 3462 final Type expected;
mcimadamore@795 3463 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 3464 super(pos);
mcimadamore@795 3465 this.uncheckedKey = uncheckedKey;
duke@1 3466 this.found = found;
duke@1 3467 this.expected = expected;
duke@1 3468 }
duke@1 3469
jjg@398 3470 @Override
mcimadamore@795 3471 public void warn(LintCategory lint) {
duke@1 3472 boolean warned = this.warned;
mcimadamore@795 3473 super.warn(lint);
duke@1 3474 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 3475 switch (lint) {
mcimadamore@795 3476 case UNCHECKED:
mcimadamore@795 3477 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 3478 break;
mcimadamore@795 3479 case VARARGS:
mcimadamore@795 3480 if (method != null &&
mcimadamore@795 3481 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 3482 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 3483 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 3484 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 3485 }
mcimadamore@795 3486 break;
mcimadamore@795 3487 default:
mcimadamore@795 3488 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 3489 }
duke@1 3490 }
duke@1 3491 }
duke@1 3492
duke@1 3493 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3494 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 3495 }
duke@1 3496
duke@1 3497 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 3498 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 3499 }
jlahoda@2111 3500
jlahoda@2111 3501 public void checkFunctionalInterface(JCClassDecl tree, ClassSymbol cs) {
jlahoda@2111 3502 Compound functionalType = cs.attribute(syms.functionalInterfaceType.tsym);
jlahoda@2111 3503
jlahoda@2111 3504 if (functionalType != null) {
jlahoda@2111 3505 try {
jlahoda@2111 3506 types.findDescriptorSymbol((TypeSymbol)cs);
jlahoda@2111 3507 } catch (Types.FunctionDescriptorLookupError ex) {
jlahoda@2111 3508 DiagnosticPosition pos = tree.pos();
jlahoda@2111 3509 for (JCAnnotation a : tree.getModifiers().annotations) {
jlahoda@2111 3510 if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
jlahoda@2111 3511 pos = a.pos();
jlahoda@2111 3512 break;
jlahoda@2111 3513 }
jlahoda@2111 3514 }
jlahoda@2111 3515 log.error(pos, "bad.functional.intf.anno.1", ex.getDiagnostic());
jlahoda@2111 3516 }
jlahoda@2111 3517 }
jlahoda@2111 3518 }
duke@1 3519 }

mercurial