Mon, 03 Jun 2013 17:09:26 -0700
8006615: [doclint] move remaining messages into resource bundle
Reviewed-by: mcimadamore, vromero
duke@1 | 1 | /* |
jjg@1492 | 2 | * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved. |
duke@1 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@1 | 4 | * |
duke@1 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@1 | 6 | * under the terms of the GNU General Public License version 2 only, as |
ohair@554 | 7 | * published by the Free Software Foundation. Oracle designates this |
duke@1 | 8 | * particular file as subject to the "Classpath" exception as provided |
ohair@554 | 9 | * by Oracle in the LICENSE file that accompanied this code. |
duke@1 | 10 | * |
duke@1 | 11 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@1 | 12 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@1 | 13 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@1 | 14 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@1 | 15 | * accompanied this code). |
duke@1 | 16 | * |
duke@1 | 17 | * You should have received a copy of the GNU General Public License version |
duke@1 | 18 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@1 | 19 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@1 | 20 | * |
ohair@554 | 21 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
ohair@554 | 22 | * or visit www.oracle.com if you need additional information or have any |
ohair@554 | 23 | * questions. |
duke@1 | 24 | */ |
duke@1 | 25 | |
duke@1 | 26 | package com.sun.tools.javac.comp; |
duke@1 | 27 | |
duke@1 | 28 | import java.util.*; |
jjg@1521 | 29 | |
ohrstrom@1384 | 30 | import javax.tools.JavaFileManager; |
duke@1 | 31 | |
duke@1 | 32 | import com.sun.tools.javac.code.*; |
duke@1 | 33 | import com.sun.tools.javac.jvm.*; |
duke@1 | 34 | import com.sun.tools.javac.tree.*; |
duke@1 | 35 | import com.sun.tools.javac.util.*; |
duke@1 | 36 | import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition; |
duke@1 | 37 | import com.sun.tools.javac.util.List; |
duke@1 | 38 | |
duke@1 | 39 | import com.sun.tools.javac.code.Lint; |
duke@1 | 40 | import com.sun.tools.javac.code.Lint.LintCategory; |
duke@1 | 41 | import com.sun.tools.javac.code.Type.*; |
duke@1 | 42 | import com.sun.tools.javac.code.Symbol.*; |
mcimadamore@1347 | 43 | import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext; |
mcimadamore@1337 | 44 | import com.sun.tools.javac.comp.Infer.InferenceContext; |
mcimadamore@1550 | 45 | import com.sun.tools.javac.comp.Infer.FreeTypeListener; |
mcimadamore@1510 | 46 | import com.sun.tools.javac.tree.JCTree.*; |
mcimadamore@1510 | 47 | import com.sun.tools.javac.tree.JCTree.JCPolyExpression.*; |
duke@1 | 48 | |
duke@1 | 49 | import static com.sun.tools.javac.code.Flags.*; |
jjg@1127 | 50 | import static com.sun.tools.javac.code.Flags.ANNOTATION; |
jjg@1127 | 51 | import static com.sun.tools.javac.code.Flags.SYNCHRONIZED; |
duke@1 | 52 | import static com.sun.tools.javac.code.Kinds.*; |
jjg@1374 | 53 | import static com.sun.tools.javac.code.TypeTag.*; |
jjg@1374 | 54 | import static com.sun.tools.javac.code.TypeTag.WILDCARD; |
duke@1 | 55 | |
jjg@1127 | 56 | import static com.sun.tools.javac.tree.JCTree.Tag.*; |
jjg@700 | 57 | |
duke@1 | 58 | /** Type checking helper class for the attribution phase. |
duke@1 | 59 | * |
jjg@581 | 60 | * <p><b>This is NOT part of any supported API. |
jjg@581 | 61 | * If you write code that depends on this, you do so at your own risk. |
duke@1 | 62 | * This code and its internal interfaces are subject to change or |
duke@1 | 63 | * deletion without notice.</b> |
duke@1 | 64 | */ |
duke@1 | 65 | public class Check { |
duke@1 | 66 | protected static final Context.Key<Check> checkKey = |
duke@1 | 67 | new Context.Key<Check>(); |
duke@1 | 68 | |
jjg@113 | 69 | private final Names names; |
duke@1 | 70 | private final Log log; |
mcimadamore@1219 | 71 | private final Resolve rs; |
duke@1 | 72 | private final Symtab syms; |
mcimadamore@690 | 73 | private final Enter enter; |
mcimadamore@1347 | 74 | private final DeferredAttr deferredAttr; |
duke@1 | 75 | private final Infer infer; |
duke@1 | 76 | private final Types types; |
mcimadamore@89 | 77 | private final JCDiagnostic.Factory diags; |
mcimadamore@359 | 78 | private boolean warnOnSyntheticConflicts; |
jjg@576 | 79 | private boolean suppressAbortOnBadClassFile; |
mcimadamore@852 | 80 | private boolean enableSunApiLintControl; |
duke@1 | 81 | private final TreeInfo treeinfo; |
ohrstrom@1384 | 82 | private final JavaFileManager fileManager; |
jjg@1569 | 83 | private final Profile profile; |
duke@1 | 84 | |
duke@1 | 85 | // The set of lint options currently in effect. It is initialized |
duke@1 | 86 | // from the context, and then is set/reset as needed by Attr as it |
duke@1 | 87 | // visits all the various parts of the trees during attribution. |
duke@1 | 88 | private Lint lint; |
duke@1 | 89 | |
mcimadamore@795 | 90 | // The method being analyzed in Attr - it is set/reset as needed by |
mcimadamore@795 | 91 | // Attr as it visits new method declarations. |
mcimadamore@795 | 92 | private MethodSymbol method; |
mcimadamore@795 | 93 | |
duke@1 | 94 | public static Check instance(Context context) { |
duke@1 | 95 | Check instance = context.get(checkKey); |
duke@1 | 96 | if (instance == null) |
duke@1 | 97 | instance = new Check(context); |
duke@1 | 98 | return instance; |
duke@1 | 99 | } |
duke@1 | 100 | |
duke@1 | 101 | protected Check(Context context) { |
duke@1 | 102 | context.put(checkKey, this); |
duke@1 | 103 | |
jjg@113 | 104 | names = Names.instance(context); |
jjg@1521 | 105 | dfltTargetMeta = new Name[] { names.PACKAGE, names.TYPE, |
jjg@1521 | 106 | names.FIELD, names.METHOD, names.CONSTRUCTOR, |
jjg@1521 | 107 | names.ANNOTATION_TYPE, names.LOCAL_VARIABLE, names.PARAMETER}; |
duke@1 | 108 | log = Log.instance(context); |
mcimadamore@1219 | 109 | rs = Resolve.instance(context); |
duke@1 | 110 | syms = Symtab.instance(context); |
mcimadamore@690 | 111 | enter = Enter.instance(context); |
mcimadamore@1347 | 112 | deferredAttr = DeferredAttr.instance(context); |
duke@1 | 113 | infer = Infer.instance(context); |
jjg@1569 | 114 | types = Types.instance(context); |
mcimadamore@89 | 115 | diags = JCDiagnostic.Factory.instance(context); |
duke@1 | 116 | Options options = Options.instance(context); |
duke@1 | 117 | lint = Lint.instance(context); |
duke@1 | 118 | treeinfo = TreeInfo.instance(context); |
ohrstrom@1384 | 119 | fileManager = context.get(JavaFileManager.class); |
duke@1 | 120 | |
duke@1 | 121 | Source source = Source.instance(context); |
duke@1 | 122 | allowGenerics = source.allowGenerics(); |
mcimadamore@1219 | 123 | allowVarargs = source.allowVarargs(); |
duke@1 | 124 | allowAnnotations = source.allowAnnotations(); |
jjg@398 | 125 | allowCovariantReturns = source.allowCovariantReturns(); |
mcimadamore@795 | 126 | allowSimplifiedVarargs = source.allowSimplifiedVarargs(); |
mcimadamore@1393 | 127 | allowDefaultMethods = source.allowDefaultMethods(); |
mcimadamore@1415 | 128 | allowStrictMethodClashCheck = source.allowStrictMethodClashCheck(); |
jjg@1157 | 129 | complexInference = options.isSet("complexinference"); |
jjg@700 | 130 | warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts"); |
jjg@700 | 131 | suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile"); |
mcimadamore@852 | 132 | enableSunApiLintControl = options.isSet("enableSunApiLintControl"); |
duke@1 | 133 | |
jjg@398 | 134 | Target target = Target.instance(context); |
jjg@398 | 135 | syntheticNameChar = target.syntheticNameChar(); |
jjg@398 | 136 | |
jjg@1569 | 137 | profile = Profile.instance(context); |
jjg@1569 | 138 | |
duke@1 | 139 | boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION); |
duke@1 | 140 | boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED); |
jjg@377 | 141 | boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI); |
jjg@60 | 142 | boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings(); |
duke@1 | 143 | |
jjg@60 | 144 | deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated, |
jjg@612 | 145 | enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION); |
jjg@60 | 146 | uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked, |
jjg@612 | 147 | enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED); |
jjg@377 | 148 | sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi, |
jjg@612 | 149 | enforceMandatoryWarnings, "sunapi", null); |
mcimadamore@852 | 150 | |
mcimadamore@852 | 151 | deferredLintHandler = DeferredLintHandler.immediateHandler; |
duke@1 | 152 | } |
duke@1 | 153 | |
duke@1 | 154 | /** Switch: generics enabled? |
duke@1 | 155 | */ |
duke@1 | 156 | boolean allowGenerics; |
duke@1 | 157 | |
mcimadamore@1219 | 158 | /** Switch: varargs enabled? |
mcimadamore@1219 | 159 | */ |
mcimadamore@1219 | 160 | boolean allowVarargs; |
mcimadamore@1219 | 161 | |
duke@1 | 162 | /** Switch: annotations enabled? |
duke@1 | 163 | */ |
duke@1 | 164 | boolean allowAnnotations; |
duke@1 | 165 | |
jjg@398 | 166 | /** Switch: covariant returns enabled? |
jjg@398 | 167 | */ |
jjg@398 | 168 | boolean allowCovariantReturns; |
jjg@398 | 169 | |
mcimadamore@795 | 170 | /** Switch: simplified varargs enabled? |
mcimadamore@795 | 171 | */ |
mcimadamore@795 | 172 | boolean allowSimplifiedVarargs; |
mcimadamore@795 | 173 | |
mcimadamore@1393 | 174 | /** Switch: default methods enabled? |
mcimadamore@1393 | 175 | */ |
mcimadamore@1393 | 176 | boolean allowDefaultMethods; |
mcimadamore@1393 | 177 | |
mcimadamore@1393 | 178 | /** Switch: should unrelated return types trigger a method clash? |
mcimadamore@1393 | 179 | */ |
mcimadamore@1393 | 180 | boolean allowStrictMethodClashCheck; |
mcimadamore@1393 | 181 | |
duke@1 | 182 | /** Switch: -complexinference option set? |
duke@1 | 183 | */ |
duke@1 | 184 | boolean complexInference; |
duke@1 | 185 | |
jjg@398 | 186 | /** Character for synthetic names |
jjg@398 | 187 | */ |
jjg@398 | 188 | char syntheticNameChar; |
jjg@398 | 189 | |
duke@1 | 190 | /** A table mapping flat names of all compiled classes in this run to their |
duke@1 | 191 | * symbols; maintained from outside. |
duke@1 | 192 | */ |
duke@1 | 193 | public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>(); |
duke@1 | 194 | |
duke@1 | 195 | /** A handler for messages about deprecated usage. |
duke@1 | 196 | */ |
duke@1 | 197 | private MandatoryWarningHandler deprecationHandler; |
duke@1 | 198 | |
duke@1 | 199 | /** A handler for messages about unchecked or unsafe usage. |
duke@1 | 200 | */ |
duke@1 | 201 | private MandatoryWarningHandler uncheckedHandler; |
duke@1 | 202 | |
jjg@582 | 203 | /** A handler for messages about using proprietary API. |
jjg@377 | 204 | */ |
jjg@377 | 205 | private MandatoryWarningHandler sunApiHandler; |
duke@1 | 206 | |
mcimadamore@852 | 207 | /** A handler for deferred lint warnings. |
mcimadamore@852 | 208 | */ |
mcimadamore@852 | 209 | private DeferredLintHandler deferredLintHandler; |
mcimadamore@852 | 210 | |
duke@1 | 211 | /* ************************************************************************* |
duke@1 | 212 | * Errors and Warnings |
duke@1 | 213 | **************************************************************************/ |
duke@1 | 214 | |
duke@1 | 215 | Lint setLint(Lint newLint) { |
duke@1 | 216 | Lint prev = lint; |
duke@1 | 217 | lint = newLint; |
duke@1 | 218 | return prev; |
duke@1 | 219 | } |
duke@1 | 220 | |
mcimadamore@852 | 221 | DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) { |
mcimadamore@852 | 222 | DeferredLintHandler prev = deferredLintHandler; |
mcimadamore@852 | 223 | deferredLintHandler = newDeferredLintHandler; |
mcimadamore@852 | 224 | return prev; |
mcimadamore@852 | 225 | } |
mcimadamore@852 | 226 | |
mcimadamore@795 | 227 | MethodSymbol setMethod(MethodSymbol newMethod) { |
mcimadamore@795 | 228 | MethodSymbol prev = method; |
mcimadamore@795 | 229 | method = newMethod; |
mcimadamore@795 | 230 | return prev; |
mcimadamore@795 | 231 | } |
mcimadamore@795 | 232 | |
duke@1 | 233 | /** Warn about deprecated symbol. |
duke@1 | 234 | * @param pos Position to be used for error reporting. |
duke@1 | 235 | * @param sym The deprecated symbol. |
duke@1 | 236 | */ |
duke@1 | 237 | void warnDeprecated(DiagnosticPosition pos, Symbol sym) { |
duke@1 | 238 | if (!lint.isSuppressed(LintCategory.DEPRECATION)) |
duke@1 | 239 | deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location()); |
duke@1 | 240 | } |
duke@1 | 241 | |
duke@1 | 242 | /** Warn about unchecked operation. |
duke@1 | 243 | * @param pos Position to be used for error reporting. |
duke@1 | 244 | * @param msg A string describing the problem. |
duke@1 | 245 | */ |
duke@1 | 246 | public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) { |
duke@1 | 247 | if (!lint.isSuppressed(LintCategory.UNCHECKED)) |
duke@1 | 248 | uncheckedHandler.report(pos, msg, args); |
duke@1 | 249 | } |
duke@1 | 250 | |
mcimadamore@580 | 251 | /** Warn about unsafe vararg method decl. |
mcimadamore@580 | 252 | * @param pos Position to be used for error reporting. |
mcimadamore@580 | 253 | */ |
mcimadamore@795 | 254 | void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) { |
mcimadamore@795 | 255 | if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs) |
mcimadamore@795 | 256 | log.warning(LintCategory.VARARGS, pos, key, args); |
mcimadamore@580 | 257 | } |
mcimadamore@580 | 258 | |
jjg@582 | 259 | /** Warn about using proprietary API. |
jjg@377 | 260 | * @param pos Position to be used for error reporting. |
jjg@377 | 261 | * @param msg A string describing the problem. |
jjg@377 | 262 | */ |
jjg@377 | 263 | public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) { |
jjg@377 | 264 | if (!lint.isSuppressed(LintCategory.SUNAPI)) |
jjg@377 | 265 | sunApiHandler.report(pos, msg, args); |
jjg@377 | 266 | } |
jjg@377 | 267 | |
jjg@505 | 268 | public void warnStatic(DiagnosticPosition pos, String msg, Object... args) { |
jjg@505 | 269 | if (lint.isEnabled(LintCategory.STATIC)) |
jjg@612 | 270 | log.warning(LintCategory.STATIC, pos, msg, args); |
jjg@505 | 271 | } |
jjg@505 | 272 | |
duke@1 | 273 | /** |
duke@1 | 274 | * Report any deferred diagnostics. |
duke@1 | 275 | */ |
duke@1 | 276 | public void reportDeferredDiagnostics() { |
duke@1 | 277 | deprecationHandler.reportDeferredDiagnostic(); |
duke@1 | 278 | uncheckedHandler.reportDeferredDiagnostic(); |
jjg@377 | 279 | sunApiHandler.reportDeferredDiagnostic(); |
duke@1 | 280 | } |
duke@1 | 281 | |
duke@1 | 282 | |
duke@1 | 283 | /** Report a failure to complete a class. |
duke@1 | 284 | * @param pos Position to be used for error reporting. |
duke@1 | 285 | * @param ex The failure to report. |
duke@1 | 286 | */ |
duke@1 | 287 | public Type completionError(DiagnosticPosition pos, CompletionFailure ex) { |
mcimadamore@1613 | 288 | log.error(JCDiagnostic.DiagnosticFlag.NON_DEFERRABLE, pos, "cant.access", ex.sym, ex.getDetailValue()); |
jjg@576 | 289 | if (ex instanceof ClassReader.BadClassFile |
jjg@576 | 290 | && !suppressAbortOnBadClassFile) throw new Abort(); |
duke@1 | 291 | else return syms.errType; |
duke@1 | 292 | } |
duke@1 | 293 | |
duke@1 | 294 | /** Report an error that wrong type tag was found. |
duke@1 | 295 | * @param pos Position to be used for error reporting. |
duke@1 | 296 | * @param required An internationalized string describing the type tag |
duke@1 | 297 | * required. |
duke@1 | 298 | * @param found The type that was found. |
duke@1 | 299 | */ |
duke@1 | 300 | Type typeTagError(DiagnosticPosition pos, Object required, Object found) { |
jrose@267 | 301 | // this error used to be raised by the parser, |
jrose@267 | 302 | // but has been delayed to this point: |
jjg@1374 | 303 | if (found instanceof Type && ((Type)found).hasTag(VOID)) { |
jrose@267 | 304 | log.error(pos, "illegal.start.of.type"); |
jrose@267 | 305 | return syms.errType; |
jrose@267 | 306 | } |
duke@1 | 307 | log.error(pos, "type.found.req", found, required); |
jjg@110 | 308 | return types.createErrorType(found instanceof Type ? (Type)found : syms.errType); |
duke@1 | 309 | } |
duke@1 | 310 | |
duke@1 | 311 | /** Report an error that symbol cannot be referenced before super |
duke@1 | 312 | * has been called. |
duke@1 | 313 | * @param pos Position to be used for error reporting. |
duke@1 | 314 | * @param sym The referenced symbol. |
duke@1 | 315 | */ |
duke@1 | 316 | void earlyRefError(DiagnosticPosition pos, Symbol sym) { |
duke@1 | 317 | log.error(pos, "cant.ref.before.ctor.called", sym); |
duke@1 | 318 | } |
duke@1 | 319 | |
duke@1 | 320 | /** Report duplicate declaration error. |
duke@1 | 321 | */ |
duke@1 | 322 | void duplicateError(DiagnosticPosition pos, Symbol sym) { |
duke@1 | 323 | if (!sym.type.isErroneous()) { |
mcimadamore@1085 | 324 | Symbol location = sym.location(); |
mcimadamore@1085 | 325 | if (location.kind == MTH && |
mcimadamore@1085 | 326 | ((MethodSymbol)location).isStaticOrInstanceInit()) { |
mcimadamore@1085 | 327 | log.error(pos, "already.defined.in.clinit", kindName(sym), sym, |
mcimadamore@1085 | 328 | kindName(sym.location()), kindName(sym.location().enclClass()), |
mcimadamore@1085 | 329 | sym.location().enclClass()); |
mcimadamore@1085 | 330 | } else { |
mcimadamore@1085 | 331 | log.error(pos, "already.defined", kindName(sym), sym, |
mcimadamore@1085 | 332 | kindName(sym.location()), sym.location()); |
mcimadamore@1085 | 333 | } |
duke@1 | 334 | } |
duke@1 | 335 | } |
duke@1 | 336 | |
duke@1 | 337 | /** Report array/varargs duplicate declaration |
duke@1 | 338 | */ |
duke@1 | 339 | void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) { |
duke@1 | 340 | if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) { |
duke@1 | 341 | log.error(pos, "array.and.varargs", sym1, sym2, sym2.location()); |
duke@1 | 342 | } |
duke@1 | 343 | } |
duke@1 | 344 | |
duke@1 | 345 | /* ************************************************************************ |
duke@1 | 346 | * duplicate declaration checking |
duke@1 | 347 | *************************************************************************/ |
duke@1 | 348 | |
duke@1 | 349 | /** Check that variable does not hide variable with same name in |
duke@1 | 350 | * immediately enclosing local scope. |
duke@1 | 351 | * @param pos Position for error reporting. |
duke@1 | 352 | * @param v The symbol. |
duke@1 | 353 | * @param s The scope. |
duke@1 | 354 | */ |
duke@1 | 355 | void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) { |
duke@1 | 356 | if (s.next != null) { |
duke@1 | 357 | for (Scope.Entry e = s.next.lookup(v.name); |
duke@1 | 358 | e.scope != null && e.sym.owner == v.owner; |
duke@1 | 359 | e = e.next()) { |
duke@1 | 360 | if (e.sym.kind == VAR && |
duke@1 | 361 | (e.sym.owner.kind & (VAR | MTH)) != 0 && |
duke@1 | 362 | v.name != names.error) { |
duke@1 | 363 | duplicateError(pos, e.sym); |
duke@1 | 364 | return; |
duke@1 | 365 | } |
duke@1 | 366 | } |
duke@1 | 367 | } |
duke@1 | 368 | } |
duke@1 | 369 | |
duke@1 | 370 | /** Check that a class or interface does not hide a class or |
duke@1 | 371 | * interface with same name in immediately enclosing local scope. |
duke@1 | 372 | * @param pos Position for error reporting. |
duke@1 | 373 | * @param c The symbol. |
duke@1 | 374 | * @param s The scope. |
duke@1 | 375 | */ |
duke@1 | 376 | void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) { |
duke@1 | 377 | if (s.next != null) { |
duke@1 | 378 | for (Scope.Entry e = s.next.lookup(c.name); |
duke@1 | 379 | e.scope != null && e.sym.owner == c.owner; |
duke@1 | 380 | e = e.next()) { |
jjg@1374 | 381 | if (e.sym.kind == TYP && !e.sym.type.hasTag(TYPEVAR) && |
duke@1 | 382 | (e.sym.owner.kind & (VAR | MTH)) != 0 && |
duke@1 | 383 | c.name != names.error) { |
duke@1 | 384 | duplicateError(pos, e.sym); |
duke@1 | 385 | return; |
duke@1 | 386 | } |
duke@1 | 387 | } |
duke@1 | 388 | } |
duke@1 | 389 | } |
duke@1 | 390 | |
duke@1 | 391 | /** Check that class does not have the same name as one of |
duke@1 | 392 | * its enclosing classes, or as a class defined in its enclosing scope. |
duke@1 | 393 | * return true if class is unique in its enclosing scope. |
duke@1 | 394 | * @param pos Position for error reporting. |
duke@1 | 395 | * @param name The class name. |
duke@1 | 396 | * @param s The enclosing scope. |
duke@1 | 397 | */ |
duke@1 | 398 | boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) { |
duke@1 | 399 | for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) { |
duke@1 | 400 | if (e.sym.kind == TYP && e.sym.name != names.error) { |
duke@1 | 401 | duplicateError(pos, e.sym); |
duke@1 | 402 | return false; |
duke@1 | 403 | } |
duke@1 | 404 | } |
duke@1 | 405 | for (Symbol sym = s.owner; sym != null; sym = sym.owner) { |
duke@1 | 406 | if (sym.kind == TYP && sym.name == name && sym.name != names.error) { |
duke@1 | 407 | duplicateError(pos, sym); |
duke@1 | 408 | return true; |
duke@1 | 409 | } |
duke@1 | 410 | } |
duke@1 | 411 | return true; |
duke@1 | 412 | } |
duke@1 | 413 | |
duke@1 | 414 | /* ************************************************************************* |
duke@1 | 415 | * Class name generation |
duke@1 | 416 | **************************************************************************/ |
duke@1 | 417 | |
duke@1 | 418 | /** Return name of local class. |
jjg@1358 | 419 | * This is of the form {@code <enclClass> $ n <classname> } |
duke@1 | 420 | * where |
duke@1 | 421 | * enclClass is the flat name of the enclosing class, |
duke@1 | 422 | * classname is the simple name of the local class |
duke@1 | 423 | */ |
duke@1 | 424 | Name localClassName(ClassSymbol c) { |
duke@1 | 425 | for (int i=1; ; i++) { |
duke@1 | 426 | Name flatname = names. |
duke@1 | 427 | fromString("" + c.owner.enclClass().flatname + |
jjg@398 | 428 | syntheticNameChar + i + |
duke@1 | 429 | c.name); |
duke@1 | 430 | if (compiled.get(flatname) == null) return flatname; |
duke@1 | 431 | } |
duke@1 | 432 | } |
duke@1 | 433 | |
duke@1 | 434 | /* ************************************************************************* |
duke@1 | 435 | * Type Checking |
duke@1 | 436 | **************************************************************************/ |
duke@1 | 437 | |
mcimadamore@1238 | 438 | /** |
mcimadamore@1238 | 439 | * A check context is an object that can be used to perform compatibility |
mcimadamore@1238 | 440 | * checks - depending on the check context, meaning of 'compatibility' might |
mcimadamore@1238 | 441 | * vary significantly. |
mcimadamore@1238 | 442 | */ |
mcimadamore@1348 | 443 | public interface CheckContext { |
mcimadamore@1238 | 444 | /** |
mcimadamore@1238 | 445 | * Is type 'found' compatible with type 'req' in given context |
mcimadamore@1238 | 446 | */ |
mcimadamore@1238 | 447 | boolean compatible(Type found, Type req, Warner warn); |
mcimadamore@1238 | 448 | /** |
mcimadamore@1238 | 449 | * Report a check error |
mcimadamore@1238 | 450 | */ |
mcimadamore@1296 | 451 | void report(DiagnosticPosition pos, JCDiagnostic details); |
mcimadamore@1238 | 452 | /** |
mcimadamore@1238 | 453 | * Obtain a warner for this check context |
mcimadamore@1238 | 454 | */ |
mcimadamore@1238 | 455 | public Warner checkWarner(DiagnosticPosition pos, Type found, Type req); |
mcimadamore@1337 | 456 | |
mcimadamore@1337 | 457 | public Infer.InferenceContext inferenceContext(); |
mcimadamore@1347 | 458 | |
mcimadamore@1347 | 459 | public DeferredAttr.DeferredAttrContext deferredAttrContext(); |
mcimadamore@1238 | 460 | } |
mcimadamore@1238 | 461 | |
mcimadamore@1238 | 462 | /** |
mcimadamore@1238 | 463 | * This class represent a check context that is nested within another check |
mcimadamore@1238 | 464 | * context - useful to check sub-expressions. The default behavior simply |
mcimadamore@1238 | 465 | * redirects all method calls to the enclosing check context leveraging |
mcimadamore@1238 | 466 | * the forwarding pattern. |
mcimadamore@1238 | 467 | */ |
mcimadamore@1238 | 468 | static class NestedCheckContext implements CheckContext { |
mcimadamore@1238 | 469 | CheckContext enclosingContext; |
mcimadamore@1238 | 470 | |
mcimadamore@1238 | 471 | NestedCheckContext(CheckContext enclosingContext) { |
mcimadamore@1238 | 472 | this.enclosingContext = enclosingContext; |
mcimadamore@1238 | 473 | } |
mcimadamore@1238 | 474 | |
mcimadamore@1238 | 475 | public boolean compatible(Type found, Type req, Warner warn) { |
mcimadamore@1238 | 476 | return enclosingContext.compatible(found, req, warn); |
mcimadamore@1238 | 477 | } |
mcimadamore@1238 | 478 | |
mcimadamore@1296 | 479 | public void report(DiagnosticPosition pos, JCDiagnostic details) { |
mcimadamore@1296 | 480 | enclosingContext.report(pos, details); |
mcimadamore@1238 | 481 | } |
mcimadamore@1238 | 482 | |
mcimadamore@1238 | 483 | public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) { |
mcimadamore@1238 | 484 | return enclosingContext.checkWarner(pos, found, req); |
mcimadamore@1238 | 485 | } |
mcimadamore@1337 | 486 | |
mcimadamore@1337 | 487 | public Infer.InferenceContext inferenceContext() { |
mcimadamore@1337 | 488 | return enclosingContext.inferenceContext(); |
mcimadamore@1337 | 489 | } |
mcimadamore@1347 | 490 | |
mcimadamore@1347 | 491 | public DeferredAttrContext deferredAttrContext() { |
mcimadamore@1347 | 492 | return enclosingContext.deferredAttrContext(); |
mcimadamore@1347 | 493 | } |
mcimadamore@1238 | 494 | } |
mcimadamore@1238 | 495 | |
mcimadamore@1238 | 496 | /** |
mcimadamore@1238 | 497 | * Check context to be used when evaluating assignment/return statements |
mcimadamore@1238 | 498 | */ |
mcimadamore@1238 | 499 | CheckContext basicHandler = new CheckContext() { |
mcimadamore@1296 | 500 | public void report(DiagnosticPosition pos, JCDiagnostic details) { |
mcimadamore@1296 | 501 | log.error(pos, "prob.found.req", details); |
mcimadamore@1238 | 502 | } |
mcimadamore@1238 | 503 | public boolean compatible(Type found, Type req, Warner warn) { |
mcimadamore@1238 | 504 | return types.isAssignable(found, req, warn); |
mcimadamore@1238 | 505 | } |
mcimadamore@1238 | 506 | |
mcimadamore@1238 | 507 | public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) { |
mcimadamore@1238 | 508 | return convertWarner(pos, found, req); |
mcimadamore@1238 | 509 | } |
mcimadamore@1337 | 510 | |
mcimadamore@1337 | 511 | public InferenceContext inferenceContext() { |
mcimadamore@1337 | 512 | return infer.emptyContext; |
mcimadamore@1337 | 513 | } |
mcimadamore@1347 | 514 | |
mcimadamore@1347 | 515 | public DeferredAttrContext deferredAttrContext() { |
mcimadamore@1347 | 516 | return deferredAttr.emptyDeferredAttrContext; |
mcimadamore@1347 | 517 | } |
mcimadamore@1238 | 518 | }; |
mcimadamore@1238 | 519 | |
duke@1 | 520 | /** Check that a given type is assignable to a given proto-type. |
duke@1 | 521 | * If it is, return the type, otherwise return errType. |
duke@1 | 522 | * @param pos Position to be used for error reporting. |
duke@1 | 523 | * @param found The type that was found. |
duke@1 | 524 | * @param req The type that was required. |
duke@1 | 525 | */ |
duke@1 | 526 | Type checkType(DiagnosticPosition pos, Type found, Type req) { |
mcimadamore@1238 | 527 | return checkType(pos, found, req, basicHandler); |
darcy@609 | 528 | } |
darcy@609 | 529 | |
mcimadamore@1337 | 530 | Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) { |
mcimadamore@1337 | 531 | final Infer.InferenceContext inferenceContext = checkContext.inferenceContext(); |
mcimadamore@1337 | 532 | if (inferenceContext.free(req)) { |
mcimadamore@1337 | 533 | inferenceContext.addFreeTypeListener(List.of(req), new FreeTypeListener() { |
mcimadamore@1337 | 534 | @Override |
mcimadamore@1337 | 535 | public void typesInferred(InferenceContext inferenceContext) { |
mcimadamore@1550 | 536 | checkType(pos, found, inferenceContext.asInstType(req), checkContext); |
mcimadamore@1337 | 537 | } |
mcimadamore@1337 | 538 | }); |
mcimadamore@1337 | 539 | } |
jjg@1374 | 540 | if (req.hasTag(ERROR)) |
duke@1 | 541 | return req; |
jjg@1374 | 542 | if (req.hasTag(NONE)) |
duke@1 | 543 | return found; |
mcimadamore@1238 | 544 | if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) { |
duke@1 | 545 | return found; |
mcimadamore@1238 | 546 | } else { |
jjg@1374 | 547 | if (found.getTag().isSubRangeOf(DOUBLE) && req.getTag().isSubRangeOf(DOUBLE)) { |
mcimadamore@1296 | 548 | checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req)); |
mcimadamore@1238 | 549 | return types.createErrorType(found); |
mcimadamore@1238 | 550 | } |
mcimadamore@1296 | 551 | checkContext.report(pos, diags.fragment("inconvertible.types", found, req)); |
jjg@110 | 552 | return types.createErrorType(found); |
duke@1 | 553 | } |
duke@1 | 554 | } |
duke@1 | 555 | |
duke@1 | 556 | /** Check that a given type can be cast to a given target type. |
duke@1 | 557 | * Return the result of the cast. |
duke@1 | 558 | * @param pos Position to be used for error reporting. |
duke@1 | 559 | * @param found The type that is being cast. |
duke@1 | 560 | * @param req The target type of the cast. |
duke@1 | 561 | */ |
duke@1 | 562 | Type checkCastable(DiagnosticPosition pos, Type found, Type req) { |
mcimadamore@1238 | 563 | return checkCastable(pos, found, req, basicHandler); |
mcimadamore@1238 | 564 | } |
mcimadamore@1238 | 565 | Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) { |
mcimadamore@1268 | 566 | if (types.isCastable(found, req, castWarner(pos, found, req))) { |
duke@1 | 567 | return req; |
duke@1 | 568 | } else { |
mcimadamore@1296 | 569 | checkContext.report(pos, diags.fragment("inconvertible.types", found, req)); |
mcimadamore@1238 | 570 | return types.createErrorType(found); |
duke@1 | 571 | } |
duke@1 | 572 | } |
mcimadamore@1237 | 573 | |
mcimadamore@1237 | 574 | /** Check for redundant casts (i.e. where source type is a subtype of target type) |
mcimadamore@1237 | 575 | * The problem should only be reported for non-292 cast |
mcimadamore@1237 | 576 | */ |
mcimadamore@1237 | 577 | public void checkRedundantCast(Env<AttrContext> env, JCTypeCast tree) { |
mcimadamore@1237 | 578 | if (!tree.type.isErroneous() && |
mcimadamore@1348 | 579 | (env.info.lint == null || env.info.lint.isEnabled(Lint.LintCategory.CAST)) |
mcimadamore@1348 | 580 | && types.isSameType(tree.expr.type, tree.clazz.type) |
jjg@1521 | 581 | && !(ignoreAnnotatedCasts && TreeInfo.containsTypeAnnotation(tree.clazz)) |
mcimadamore@1348 | 582 | && !is292targetTypeCast(tree)) { |
mcimadamore@1237 | 583 | log.warning(Lint.LintCategory.CAST, |
mcimadamore@1237 | 584 | tree.pos(), "redundant.cast", tree.expr.type); |
mcimadamore@1237 | 585 | } |
mcimadamore@1237 | 586 | } |
mcimadamore@1237 | 587 | //where |
jjg@1521 | 588 | private boolean is292targetTypeCast(JCTypeCast tree) { |
jjg@1521 | 589 | boolean is292targetTypeCast = false; |
jjg@1521 | 590 | JCExpression expr = TreeInfo.skipParens(tree.expr); |
jjg@1521 | 591 | if (expr.hasTag(APPLY)) { |
jjg@1521 | 592 | JCMethodInvocation apply = (JCMethodInvocation)expr; |
jjg@1521 | 593 | Symbol sym = TreeInfo.symbol(apply.meth); |
jjg@1521 | 594 | is292targetTypeCast = sym != null && |
jjg@1521 | 595 | sym.kind == MTH && |
jjg@1521 | 596 | (sym.flags() & HYPOTHETICAL) != 0; |
mcimadamore@1237 | 597 | } |
jjg@1521 | 598 | return is292targetTypeCast; |
jjg@1521 | 599 | } |
mcimadamore@1237 | 600 | |
jjg@1521 | 601 | private static final boolean ignoreAnnotatedCasts = true; |
duke@1 | 602 | |
duke@1 | 603 | /** Check that a type is within some bounds. |
duke@1 | 604 | * |
jjg@1358 | 605 | * Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid |
duke@1 | 606 | * type argument. |
duke@1 | 607 | * @param a The type that should be bounded by bs. |
jjg@1358 | 608 | * @param bound The bound. |
duke@1 | 609 | */ |
mcimadamore@1216 | 610 | private boolean checkExtends(Type a, Type bound) { |
mcimadamore@154 | 611 | if (a.isUnbound()) { |
mcimadamore@821 | 612 | return true; |
jjg@1374 | 613 | } else if (!a.hasTag(WILDCARD)) { |
mcimadamore@154 | 614 | a = types.upperBound(a); |
mcimadamore@1216 | 615 | return types.isSubtype(a, bound); |
mcimadamore@154 | 616 | } else if (a.isExtendsBound()) { |
mcimadamore@1415 | 617 | return types.isCastable(bound, types.upperBound(a), types.noWarnings); |
mcimadamore@154 | 618 | } else if (a.isSuperBound()) { |
mcimadamore@1216 | 619 | return !types.notSoftSubtype(types.lowerBound(a), bound); |
mcimadamore@154 | 620 | } |
mcimadamore@821 | 621 | return true; |
mcimadamore@154 | 622 | } |
duke@1 | 623 | |
duke@1 | 624 | /** Check that type is different from 'void'. |
duke@1 | 625 | * @param pos Position to be used for error reporting. |
duke@1 | 626 | * @param t The type to be checked. |
duke@1 | 627 | */ |
duke@1 | 628 | Type checkNonVoid(DiagnosticPosition pos, Type t) { |
jjg@1374 | 629 | if (t.hasTag(VOID)) { |
duke@1 | 630 | log.error(pos, "void.not.allowed.here"); |
jjg@110 | 631 | return types.createErrorType(t); |
duke@1 | 632 | } else { |
duke@1 | 633 | return t; |
duke@1 | 634 | } |
duke@1 | 635 | } |
duke@1 | 636 | |
mcimadamore@1496 | 637 | Type checkClassOrArrayType(DiagnosticPosition pos, Type t) { |
mcimadamore@1496 | 638 | if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) { |
mcimadamore@1496 | 639 | return typeTagError(pos, |
mcimadamore@1496 | 640 | diags.fragment("type.req.class.array"), |
mcimadamore@1496 | 641 | asTypeParam(t)); |
mcimadamore@1496 | 642 | } else { |
mcimadamore@1496 | 643 | return t; |
mcimadamore@1496 | 644 | } |
mcimadamore@1496 | 645 | } |
mcimadamore@1496 | 646 | |
duke@1 | 647 | /** Check that type is a class or interface type. |
duke@1 | 648 | * @param pos Position to be used for error reporting. |
duke@1 | 649 | * @param t The type to be checked. |
duke@1 | 650 | */ |
duke@1 | 651 | Type checkClassType(DiagnosticPosition pos, Type t) { |
mcimadamore@1496 | 652 | if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) { |
duke@1 | 653 | return typeTagError(pos, |
mcimadamore@89 | 654 | diags.fragment("type.req.class"), |
mcimadamore@1496 | 655 | asTypeParam(t)); |
mcimadamore@1496 | 656 | } else { |
duke@1 | 657 | return t; |
mcimadamore@1496 | 658 | } |
duke@1 | 659 | } |
mcimadamore@1496 | 660 | //where |
mcimadamore@1496 | 661 | private Object asTypeParam(Type t) { |
mcimadamore@1496 | 662 | return (t.hasTag(TYPEVAR)) |
mcimadamore@1496 | 663 | ? diags.fragment("type.parameter", t) |
mcimadamore@1496 | 664 | : t; |
mcimadamore@1496 | 665 | } |
duke@1 | 666 | |
mcimadamore@1352 | 667 | /** Check that type is a valid qualifier for a constructor reference expression |
mcimadamore@1352 | 668 | */ |
mcimadamore@1352 | 669 | Type checkConstructorRefType(DiagnosticPosition pos, Type t) { |
mcimadamore@1496 | 670 | t = checkClassOrArrayType(pos, t); |
jjg@1374 | 671 | if (t.hasTag(CLASS)) { |
mcimadamore@1352 | 672 | if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) { |
mcimadamore@1627 | 673 | log.error(pos, "abstract.cant.be.instantiated", t.tsym); |
mcimadamore@1352 | 674 | t = types.createErrorType(t); |
mcimadamore@1352 | 675 | } else if ((t.tsym.flags() & ENUM) != 0) { |
mcimadamore@1352 | 676 | log.error(pos, "enum.cant.be.instantiated"); |
mcimadamore@1352 | 677 | t = types.createErrorType(t); |
mcimadamore@1627 | 678 | } else { |
mcimadamore@1627 | 679 | t = checkClassType(pos, t, true); |
mcimadamore@1627 | 680 | } |
mcimadamore@1627 | 681 | } else if (t.hasTag(ARRAY)) { |
mcimadamore@1627 | 682 | if (!types.isReifiable(((ArrayType)t).elemtype)) { |
mcimadamore@1627 | 683 | log.error(pos, "generic.array.creation"); |
mcimadamore@1627 | 684 | t = types.createErrorType(t); |
mcimadamore@1352 | 685 | } |
mcimadamore@1352 | 686 | } |
mcimadamore@1352 | 687 | return t; |
mcimadamore@1352 | 688 | } |
mcimadamore@1352 | 689 | |
duke@1 | 690 | /** Check that type is a class or interface type. |
duke@1 | 691 | * @param pos Position to be used for error reporting. |
duke@1 | 692 | * @param t The type to be checked. |
duke@1 | 693 | * @param noBounds True if type bounds are illegal here. |
duke@1 | 694 | */ |
duke@1 | 695 | Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) { |
duke@1 | 696 | t = checkClassType(pos, t); |
duke@1 | 697 | if (noBounds && t.isParameterized()) { |
duke@1 | 698 | List<Type> args = t.getTypeArguments(); |
duke@1 | 699 | while (args.nonEmpty()) { |
jjg@1374 | 700 | if (args.head.hasTag(WILDCARD)) |
duke@1 | 701 | return typeTagError(pos, |
jjg@598 | 702 | diags.fragment("type.req.exact"), |
duke@1 | 703 | args.head); |
duke@1 | 704 | args = args.tail; |
duke@1 | 705 | } |
duke@1 | 706 | } |
duke@1 | 707 | return t; |
duke@1 | 708 | } |
duke@1 | 709 | |
duke@1 | 710 | /** Check that type is a reifiable class, interface or array type. |
duke@1 | 711 | * @param pos Position to be used for error reporting. |
duke@1 | 712 | * @param t The type to be checked. |
duke@1 | 713 | */ |
duke@1 | 714 | Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) { |
mcimadamore@1496 | 715 | t = checkClassOrArrayType(pos, t); |
mcimadamore@1496 | 716 | if (!t.isErroneous() && !types.isReifiable(t)) { |
duke@1 | 717 | log.error(pos, "illegal.generic.type.for.instof"); |
jjg@110 | 718 | return types.createErrorType(t); |
duke@1 | 719 | } else { |
duke@1 | 720 | return t; |
duke@1 | 721 | } |
duke@1 | 722 | } |
duke@1 | 723 | |
duke@1 | 724 | /** Check that type is a reference type, i.e. a class, interface or array type |
duke@1 | 725 | * or a type variable. |
duke@1 | 726 | * @param pos Position to be used for error reporting. |
duke@1 | 727 | * @param t The type to be checked. |
duke@1 | 728 | */ |
duke@1 | 729 | Type checkRefType(DiagnosticPosition pos, Type t) { |
jjg@1374 | 730 | if (t.isReference()) |
duke@1 | 731 | return t; |
jjg@1374 | 732 | else |
duke@1 | 733 | return typeTagError(pos, |
mcimadamore@89 | 734 | diags.fragment("type.req.ref"), |
duke@1 | 735 | t); |
duke@1 | 736 | } |
duke@1 | 737 | |
jrose@267 | 738 | /** Check that each type is a reference type, i.e. a class, interface or array type |
jrose@267 | 739 | * or a type variable. |
jrose@267 | 740 | * @param trees Original trees, used for error reporting. |
jrose@267 | 741 | * @param types The types to be checked. |
jrose@267 | 742 | */ |
jrose@267 | 743 | List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) { |
jrose@267 | 744 | List<JCExpression> tl = trees; |
jrose@267 | 745 | for (List<Type> l = types; l.nonEmpty(); l = l.tail) { |
jrose@267 | 746 | l.head = checkRefType(tl.head.pos(), l.head); |
jrose@267 | 747 | tl = tl.tail; |
jrose@267 | 748 | } |
jrose@267 | 749 | return types; |
jrose@267 | 750 | } |
jrose@267 | 751 | |
duke@1 | 752 | /** Check that type is a null or reference type. |
duke@1 | 753 | * @param pos Position to be used for error reporting. |
duke@1 | 754 | * @param t The type to be checked. |
duke@1 | 755 | */ |
duke@1 | 756 | Type checkNullOrRefType(DiagnosticPosition pos, Type t) { |
jjg@1374 | 757 | if (t.isNullOrReference()) |
duke@1 | 758 | return t; |
jjg@1374 | 759 | else |
duke@1 | 760 | return typeTagError(pos, |
mcimadamore@89 | 761 | diags.fragment("type.req.ref"), |
duke@1 | 762 | t); |
duke@1 | 763 | } |
duke@1 | 764 | |
duke@1 | 765 | /** Check that flag set does not contain elements of two conflicting sets. s |
duke@1 | 766 | * Return true if it doesn't. |
duke@1 | 767 | * @param pos Position to be used for error reporting. |
duke@1 | 768 | * @param flags The set of flags to be checked. |
duke@1 | 769 | * @param set1 Conflicting flags set #1. |
duke@1 | 770 | * @param set2 Conflicting flags set #2. |
duke@1 | 771 | */ |
duke@1 | 772 | boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) { |
duke@1 | 773 | if ((flags & set1) != 0 && (flags & set2) != 0) { |
duke@1 | 774 | log.error(pos, |
duke@1 | 775 | "illegal.combination.of.modifiers", |
mcimadamore@80 | 776 | asFlagSet(TreeInfo.firstFlag(flags & set1)), |
mcimadamore@80 | 777 | asFlagSet(TreeInfo.firstFlag(flags & set2))); |
duke@1 | 778 | return false; |
duke@1 | 779 | } else |
duke@1 | 780 | return true; |
duke@1 | 781 | } |
duke@1 | 782 | |
mcimadamore@914 | 783 | /** Check that usage of diamond operator is correct (i.e. diamond should not |
mcimadamore@914 | 784 | * be used with non-generic classes or in anonymous class creation expressions) |
mcimadamore@537 | 785 | */ |
mcimadamore@914 | 786 | Type checkDiamond(JCNewClass tree, Type t) { |
mcimadamore@914 | 787 | if (!TreeInfo.isDiamond(tree) || |
mcimadamore@914 | 788 | t.isErroneous()) { |
mcimadamore@914 | 789 | return checkClassType(tree.clazz.pos(), t, true); |
mcimadamore@914 | 790 | } else if (tree.def != null) { |
mcimadamore@914 | 791 | log.error(tree.clazz.pos(), |
mcimadamore@914 | 792 | "cant.apply.diamond.1", |
mcimadamore@914 | 793 | t, diags.fragment("diamond.and.anon.class", t)); |
mcimadamore@914 | 794 | return types.createErrorType(t); |
mcimadamore@948 | 795 | } else if (t.tsym.type.getTypeArguments().isEmpty()) { |
mcimadamore@914 | 796 | log.error(tree.clazz.pos(), |
mcimadamore@914 | 797 | "cant.apply.diamond.1", |
mcimadamore@914 | 798 | t, diags.fragment("diamond.non.generic", t)); |
mcimadamore@914 | 799 | return types.createErrorType(t); |
mcimadamore@993 | 800 | } else if (tree.typeargs != null && |
mcimadamore@993 | 801 | tree.typeargs.nonEmpty()) { |
mcimadamore@993 | 802 | log.error(tree.clazz.pos(), |
mcimadamore@993 | 803 | "cant.apply.diamond.1", |
mcimadamore@993 | 804 | t, diags.fragment("diamond.and.explicit.params", t)); |
mcimadamore@993 | 805 | return types.createErrorType(t); |
mcimadamore@914 | 806 | } else { |
mcimadamore@914 | 807 | return t; |
mcimadamore@537 | 808 | } |
mcimadamore@537 | 809 | } |
mcimadamore@537 | 810 | |
mcimadamore@795 | 811 | void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) { |
mcimadamore@580 | 812 | MethodSymbol m = tree.sym; |
mcimadamore@795 | 813 | if (!allowSimplifiedVarargs) return; |
mcimadamore@795 | 814 | boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null; |
mcimadamore@795 | 815 | Type varargElemType = null; |
mcimadamore@580 | 816 | if (m.isVarArgs()) { |
mcimadamore@795 | 817 | varargElemType = types.elemtype(tree.params.last().type); |
mcimadamore@795 | 818 | } |
mcimadamore@795 | 819 | if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) { |
mcimadamore@795 | 820 | if (varargElemType != null) { |
mcimadamore@795 | 821 | log.error(tree, |
mcimadamore@795 | 822 | "varargs.invalid.trustme.anno", |
mcimadamore@795 | 823 | syms.trustMeType.tsym, |
mcimadamore@795 | 824 | diags.fragment("varargs.trustme.on.virtual.varargs", m)); |
mcimadamore@795 | 825 | } else { |
mcimadamore@795 | 826 | log.error(tree, |
mcimadamore@795 | 827 | "varargs.invalid.trustme.anno", |
mcimadamore@795 | 828 | syms.trustMeType.tsym, |
mcimadamore@795 | 829 | diags.fragment("varargs.trustme.on.non.varargs.meth", m)); |
mcimadamore@580 | 830 | } |
mcimadamore@795 | 831 | } else if (hasTrustMeAnno && varargElemType != null && |
mcimadamore@795 | 832 | types.isReifiable(varargElemType)) { |
mcimadamore@795 | 833 | warnUnsafeVararg(tree, |
mcimadamore@795 | 834 | "varargs.redundant.trustme.anno", |
mcimadamore@795 | 835 | syms.trustMeType.tsym, |
mcimadamore@795 | 836 | diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType)); |
mcimadamore@795 | 837 | } |
mcimadamore@795 | 838 | else if (!hasTrustMeAnno && varargElemType != null && |
mcimadamore@795 | 839 | !types.isReifiable(varargElemType)) { |
mcimadamore@795 | 840 | warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType); |
mcimadamore@580 | 841 | } |
mcimadamore@580 | 842 | } |
mcimadamore@795 | 843 | //where |
mcimadamore@795 | 844 | private boolean isTrustMeAllowedOnMethod(Symbol s) { |
mcimadamore@795 | 845 | return (s.flags() & VARARGS) != 0 && |
mcimadamore@795 | 846 | (s.isConstructor() || |
mcimadamore@795 | 847 | (s.flags() & (STATIC | FINAL)) != 0); |
mcimadamore@795 | 848 | } |
mcimadamore@580 | 849 | |
mcimadamore@1219 | 850 | Type checkMethod(Type owntype, |
mcimadamore@1219 | 851 | Symbol sym, |
mcimadamore@1219 | 852 | Env<AttrContext> env, |
mcimadamore@1219 | 853 | final List<JCExpression> argtrees, |
mcimadamore@1219 | 854 | List<Type> argtypes, |
mcimadamore@1226 | 855 | boolean useVarargs, |
mcimadamore@1780 | 856 | boolean unchecked, |
mcimadamore@1780 | 857 | InferenceContext inferenceContext) { |
mcimadamore@1219 | 858 | // System.out.println("call : " + env.tree); |
mcimadamore@1219 | 859 | // System.out.println("method : " + owntype); |
mcimadamore@1219 | 860 | // System.out.println("actuals: " + argtypes); |
mcimadamore@1219 | 861 | List<Type> formals = owntype.getParameterTypes(); |
mcimadamore@1219 | 862 | Type last = useVarargs ? formals.last() : null; |
jjg@1521 | 863 | if (sym.name == names.init && |
mcimadamore@1219 | 864 | sym.owner == syms.enumSym) |
mcimadamore@1219 | 865 | formals = formals.tail.tail; |
mcimadamore@1219 | 866 | List<JCExpression> args = argtrees; |
mcimadamore@1347 | 867 | DeferredAttr.DeferredTypeMap checkDeferredMap = |
mcimadamore@1347 | 868 | deferredAttr.new DeferredTypeMap(DeferredAttr.AttrMode.CHECK, sym, env.info.pendingResolutionPhase); |
mcimadamore@1352 | 869 | if (args != null) { |
mcimadamore@1352 | 870 | //this is null when type-checking a method reference |
mcimadamore@1352 | 871 | while (formals.head != last) { |
mcimadamore@1219 | 872 | JCTree arg = args.head; |
mcimadamore@1352 | 873 | Warner warn = convertWarner(arg.pos(), arg.type, formals.head); |
mcimadamore@1352 | 874 | assertConvertible(arg, arg.type, formals.head, warn); |
mcimadamore@1219 | 875 | args = args.tail; |
mcimadamore@1352 | 876 | formals = formals.tail; |
mcimadamore@1219 | 877 | } |
mcimadamore@1352 | 878 | if (useVarargs) { |
mcimadamore@1352 | 879 | Type varArg = types.elemtype(last); |
mcimadamore@1352 | 880 | while (args.tail != null) { |
mcimadamore@1352 | 881 | JCTree arg = args.head; |
mcimadamore@1352 | 882 | Warner warn = convertWarner(arg.pos(), arg.type, varArg); |
mcimadamore@1352 | 883 | assertConvertible(arg, arg.type, varArg, warn); |
mcimadamore@1352 | 884 | args = args.tail; |
mcimadamore@1352 | 885 | } |
mcimadamore@1352 | 886 | } else if ((sym.flags() & VARARGS) != 0 && allowVarargs) { |
mcimadamore@1352 | 887 | // non-varargs call to varargs method |
mcimadamore@1352 | 888 | Type varParam = owntype.getParameterTypes().last(); |
mcimadamore@1352 | 889 | Type lastArg = checkDeferredMap.apply(argtypes.last()); |
mcimadamore@1352 | 890 | if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) && |
mcimadamore@1352 | 891 | !types.isSameType(types.erasure(varParam), types.erasure(lastArg))) |
mcimadamore@1352 | 892 | log.warning(argtrees.last().pos(), "inexact.non-varargs.call", |
mcimadamore@1352 | 893 | types.elemtype(varParam), varParam); |
mcimadamore@1352 | 894 | } |
mcimadamore@1219 | 895 | } |
mcimadamore@1226 | 896 | if (unchecked) { |
mcimadamore@1219 | 897 | warnUnchecked(env.tree.pos(), |
mcimadamore@1219 | 898 | "unchecked.meth.invocation.applied", |
mcimadamore@1219 | 899 | kindName(sym), |
mcimadamore@1219 | 900 | sym.name, |
mcimadamore@1219 | 901 | rs.methodArguments(sym.type.getParameterTypes()), |
mcimadamore@1347 | 902 | rs.methodArguments(Type.map(argtypes, checkDeferredMap)), |
mcimadamore@1219 | 903 | kindName(sym.location()), |
mcimadamore@1219 | 904 | sym.location()); |
mcimadamore@1219 | 905 | owntype = new MethodType(owntype.getParameterTypes(), |
mcimadamore@1219 | 906 | types.erasure(owntype.getReturnType()), |
mcimadamore@1219 | 907 | types.erasure(owntype.getThrownTypes()), |
mcimadamore@1219 | 908 | syms.methodClass); |
mcimadamore@1219 | 909 | } |
mcimadamore@1219 | 910 | if (useVarargs) { |
mcimadamore@1219 | 911 | Type argtype = owntype.getParameterTypes().last(); |
mcimadamore@1219 | 912 | if (!types.isReifiable(argtype) && |
mcimadamore@1219 | 913 | (!allowSimplifiedVarargs || |
mcimadamore@1219 | 914 | sym.attribute(syms.trustMeType.tsym) == null || |
mcimadamore@1219 | 915 | !isTrustMeAllowedOnMethod(sym))) { |
mcimadamore@1219 | 916 | warnUnchecked(env.tree.pos(), |
mcimadamore@1219 | 917 | "unchecked.generic.array.creation", |
mcimadamore@1219 | 918 | argtype); |
mcimadamore@1219 | 919 | } |
mcimadamore@1415 | 920 | if (!((MethodSymbol)sym.baseSymbol()).isSignaturePolymorphic(types)) { |
mcimadamore@1780 | 921 | setVarargsElement(env, types.elemtype(argtype), inferenceContext); |
mcimadamore@1219 | 922 | } |
mcimadamore@1219 | 923 | } |
mcimadamore@1510 | 924 | PolyKind pkind = (sym.type.hasTag(FORALL) && |
mcimadamore@1510 | 925 | sym.type.getReturnType().containsAny(((ForAll)sym.type).tvars)) ? |
mcimadamore@1510 | 926 | PolyKind.POLY : PolyKind.STANDALONE; |
mcimadamore@1510 | 927 | TreeInfo.setPolyKind(env.tree, pkind); |
mcimadamore@1219 | 928 | return owntype; |
mcimadamore@547 | 929 | } |
mcimadamore@1219 | 930 | //where |
mcimadamore@1780 | 931 | private void setVarargsElement(final Env<AttrContext> env, final Type elemtype, InferenceContext inferenceContext) { |
mcimadamore@1780 | 932 | if (inferenceContext.free(elemtype)) { |
mcimadamore@1780 | 933 | inferenceContext.addFreeTypeListener(List.of(elemtype), new FreeTypeListener() { |
mcimadamore@1780 | 934 | public void typesInferred(InferenceContext inferenceContext) { |
mcimadamore@1780 | 935 | setVarargsElement(env, inferenceContext.asInstType(elemtype), inferenceContext); |
mcimadamore@1780 | 936 | } |
mcimadamore@1780 | 937 | }); |
mcimadamore@1780 | 938 | } |
mcimadamore@1780 | 939 | TreeInfo.setVarargsElement(env.tree, elemtype); |
mcimadamore@1780 | 940 | } |
mcimadamore@1780 | 941 | |
mcimadamore@1219 | 942 | private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) { |
mcimadamore@1219 | 943 | if (types.isConvertible(actual, formal, warn)) |
mcimadamore@1219 | 944 | return; |
mcimadamore@1219 | 945 | |
mcimadamore@1219 | 946 | if (formal.isCompound() |
mcimadamore@1219 | 947 | && types.isSubtype(actual, types.supertype(formal)) |
mcimadamore@1219 | 948 | && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn)) |
mcimadamore@1219 | 949 | return; |
mcimadamore@1219 | 950 | } |
mcimadamore@547 | 951 | |
mcimadamore@821 | 952 | /** |
mcimadamore@821 | 953 | * Check that type 't' is a valid instantiation of a generic class |
mcimadamore@821 | 954 | * (see JLS 4.5) |
mcimadamore@821 | 955 | * |
mcimadamore@821 | 956 | * @param t class type to be checked |
mcimadamore@821 | 957 | * @return true if 't' is well-formed |
mcimadamore@821 | 958 | */ |
mcimadamore@821 | 959 | public boolean checkValidGenericType(Type t) { |
mcimadamore@821 | 960 | return firstIncompatibleTypeArg(t) == null; |
mcimadamore@821 | 961 | } |
mcimadamore@821 | 962 | //WHERE |
mcimadamore@821 | 963 | private Type firstIncompatibleTypeArg(Type type) { |
mcimadamore@821 | 964 | List<Type> formals = type.tsym.type.allparams(); |
mcimadamore@821 | 965 | List<Type> actuals = type.allparams(); |
mcimadamore@821 | 966 | List<Type> args = type.getTypeArguments(); |
mcimadamore@821 | 967 | List<Type> forms = type.tsym.type.getTypeArguments(); |
mcimadamore@1216 | 968 | ListBuffer<Type> bounds_buf = new ListBuffer<Type>(); |
mcimadamore@821 | 969 | |
mcimadamore@821 | 970 | // For matching pairs of actual argument types `a' and |
mcimadamore@821 | 971 | // formal type parameters with declared bound `b' ... |
mcimadamore@821 | 972 | while (args.nonEmpty() && forms.nonEmpty()) { |
mcimadamore@821 | 973 | // exact type arguments needs to know their |
mcimadamore@821 | 974 | // bounds (for upper and lower bound |
mcimadamore@1216 | 975 | // calculations). So we create new bounds where |
mcimadamore@1216 | 976 | // type-parameters are replaced with actuals argument types. |
mcimadamore@1216 | 977 | bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals)); |
mcimadamore@821 | 978 | args = args.tail; |
mcimadamore@821 | 979 | forms = forms.tail; |
mcimadamore@821 | 980 | } |
mcimadamore@821 | 981 | |
mcimadamore@821 | 982 | args = type.getTypeArguments(); |
mcimadamore@821 | 983 | List<Type> tvars_cap = types.substBounds(formals, |
mcimadamore@821 | 984 | formals, |
mcimadamore@821 | 985 | types.capture(type).allparams()); |
mcimadamore@821 | 986 | while (args.nonEmpty() && tvars_cap.nonEmpty()) { |
mcimadamore@821 | 987 | // Let the actual arguments know their bound |
mcimadamore@821 | 988 | args.head.withTypeVar((TypeVar)tvars_cap.head); |
mcimadamore@821 | 989 | args = args.tail; |
mcimadamore@821 | 990 | tvars_cap = tvars_cap.tail; |
mcimadamore@821 | 991 | } |
mcimadamore@821 | 992 | |
mcimadamore@821 | 993 | args = type.getTypeArguments(); |
mcimadamore@1216 | 994 | List<Type> bounds = bounds_buf.toList(); |
mcimadamore@821 | 995 | |
mcimadamore@1216 | 996 | while (args.nonEmpty() && bounds.nonEmpty()) { |
mcimadamore@1216 | 997 | Type actual = args.head; |
mcimadamore@854 | 998 | if (!isTypeArgErroneous(actual) && |
mcimadamore@1216 | 999 | !bounds.head.isErroneous() && |
mcimadamore@1216 | 1000 | !checkExtends(actual, bounds.head)) { |
mcimadamore@821 | 1001 | return args.head; |
mcimadamore@821 | 1002 | } |
mcimadamore@821 | 1003 | args = args.tail; |
mcimadamore@1216 | 1004 | bounds = bounds.tail; |
mcimadamore@821 | 1005 | } |
mcimadamore@821 | 1006 | |
mcimadamore@821 | 1007 | args = type.getTypeArguments(); |
mcimadamore@1216 | 1008 | bounds = bounds_buf.toList(); |
mcimadamore@821 | 1009 | |
mcimadamore@821 | 1010 | for (Type arg : types.capture(type).getTypeArguments()) { |
jjg@1374 | 1011 | if (arg.hasTag(TYPEVAR) && |
mcimadamore@828 | 1012 | arg.getUpperBound().isErroneous() && |
mcimadamore@1216 | 1013 | !bounds.head.isErroneous() && |
mcimadamore@854 | 1014 | !isTypeArgErroneous(args.head)) { |
mcimadamore@821 | 1015 | return args.head; |
mcimadamore@821 | 1016 | } |
mcimadamore@1216 | 1017 | bounds = bounds.tail; |
mcimadamore@854 | 1018 | args = args.tail; |
mcimadamore@821 | 1019 | } |
mcimadamore@821 | 1020 | |
mcimadamore@821 | 1021 | return null; |
mcimadamore@821 | 1022 | } |
mcimadamore@854 | 1023 | //where |
mcimadamore@854 | 1024 | boolean isTypeArgErroneous(Type t) { |
mcimadamore@854 | 1025 | return isTypeArgErroneous.visit(t); |
mcimadamore@854 | 1026 | } |
mcimadamore@854 | 1027 | |
mcimadamore@854 | 1028 | Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() { |
mcimadamore@854 | 1029 | public Boolean visitType(Type t, Void s) { |
mcimadamore@854 | 1030 | return t.isErroneous(); |
mcimadamore@854 | 1031 | } |
mcimadamore@854 | 1032 | @Override |
mcimadamore@854 | 1033 | public Boolean visitTypeVar(TypeVar t, Void s) { |
mcimadamore@854 | 1034 | return visit(t.getUpperBound()); |
mcimadamore@854 | 1035 | } |
mcimadamore@854 | 1036 | @Override |
mcimadamore@854 | 1037 | public Boolean visitCapturedType(CapturedType t, Void s) { |
mcimadamore@854 | 1038 | return visit(t.getUpperBound()) || |
mcimadamore@854 | 1039 | visit(t.getLowerBound()); |
mcimadamore@854 | 1040 | } |
mcimadamore@854 | 1041 | @Override |
mcimadamore@854 | 1042 | public Boolean visitWildcardType(WildcardType t, Void s) { |
mcimadamore@854 | 1043 | return visit(t.type); |
mcimadamore@854 | 1044 | } |
mcimadamore@854 | 1045 | }; |
mcimadamore@821 | 1046 | |
duke@1 | 1047 | /** Check that given modifiers are legal for given symbol and |
vromero@1555 | 1048 | * return modifiers together with any implicit modifiers for that symbol. |
duke@1 | 1049 | * Warning: we can't use flags() here since this method |
duke@1 | 1050 | * is called during class enter, when flags() would cause a premature |
duke@1 | 1051 | * completion. |
duke@1 | 1052 | * @param pos Position to be used for error reporting. |
duke@1 | 1053 | * @param flags The set of modifiers given in a definition. |
duke@1 | 1054 | * @param sym The defined symbol. |
duke@1 | 1055 | */ |
duke@1 | 1056 | long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) { |
duke@1 | 1057 | long mask; |
duke@1 | 1058 | long implicit = 0; |
duke@1 | 1059 | switch (sym.kind) { |
duke@1 | 1060 | case VAR: |
duke@1 | 1061 | if (sym.owner.kind != TYP) |
duke@1 | 1062 | mask = LocalVarFlags; |
duke@1 | 1063 | else if ((sym.owner.flags_field & INTERFACE) != 0) |
duke@1 | 1064 | mask = implicit = InterfaceVarFlags; |
duke@1 | 1065 | else |
duke@1 | 1066 | mask = VarFlags; |
duke@1 | 1067 | break; |
duke@1 | 1068 | case MTH: |
duke@1 | 1069 | if (sym.name == names.init) { |
duke@1 | 1070 | if ((sym.owner.flags_field & ENUM) != 0) { |
duke@1 | 1071 | // enum constructors cannot be declared public or |
duke@1 | 1072 | // protected and must be implicitly or explicitly |
duke@1 | 1073 | // private |
duke@1 | 1074 | implicit = PRIVATE; |
duke@1 | 1075 | mask = PRIVATE; |
duke@1 | 1076 | } else |
duke@1 | 1077 | mask = ConstructorFlags; |
mcimadamore@1366 | 1078 | } else if ((sym.owner.flags_field & INTERFACE) != 0) { |
mcimadamore@1513 | 1079 | if ((flags & (DEFAULT | STATIC)) != 0) { |
mcimadamore@1513 | 1080 | mask = InterfaceMethodMask; |
mcimadamore@1513 | 1081 | implicit = PUBLIC; |
mcimadamore@1513 | 1082 | if ((flags & DEFAULT) != 0) { |
mcimadamore@1513 | 1083 | implicit |= ABSTRACT; |
mcimadamore@1513 | 1084 | } |
mcimadamore@1366 | 1085 | } else { |
mcimadamore@1366 | 1086 | mask = implicit = InterfaceMethodFlags; |
mcimadamore@1366 | 1087 | } |
mcimadamore@1366 | 1088 | } |
duke@1 | 1089 | else { |
duke@1 | 1090 | mask = MethodFlags; |
duke@1 | 1091 | } |
duke@1 | 1092 | // Imply STRICTFP if owner has STRICTFP set. |
vromero@1712 | 1093 | if (((flags|implicit) & Flags.ABSTRACT) == 0 || |
vromero@1712 | 1094 | ((flags) & Flags.DEFAULT) != 0) |
vromero@1555 | 1095 | implicit |= sym.owner.flags_field & STRICTFP; |
duke@1 | 1096 | break; |
duke@1 | 1097 | case TYP: |
duke@1 | 1098 | if (sym.isLocal()) { |
duke@1 | 1099 | mask = LocalClassFlags; |
jjg@113 | 1100 | if (sym.name.isEmpty()) { // Anonymous class |
duke@1 | 1101 | // Anonymous classes in static methods are themselves static; |
duke@1 | 1102 | // that's why we admit STATIC here. |
duke@1 | 1103 | mask |= STATIC; |
duke@1 | 1104 | // JLS: Anonymous classes are final. |
duke@1 | 1105 | implicit |= FINAL; |
duke@1 | 1106 | } |
duke@1 | 1107 | if ((sym.owner.flags_field & STATIC) == 0 && |
duke@1 | 1108 | (flags & ENUM) != 0) |
duke@1 | 1109 | log.error(pos, "enums.must.be.static"); |
duke@1 | 1110 | } else if (sym.owner.kind == TYP) { |
duke@1 | 1111 | mask = MemberClassFlags; |
duke@1 | 1112 | if (sym.owner.owner.kind == PCK || |
duke@1 | 1113 | (sym.owner.flags_field & STATIC) != 0) |
duke@1 | 1114 | mask |= STATIC; |
duke@1 | 1115 | else if ((flags & ENUM) != 0) |
duke@1 | 1116 | log.error(pos, "enums.must.be.static"); |
duke@1 | 1117 | // Nested interfaces and enums are always STATIC (Spec ???) |
duke@1 | 1118 | if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC; |
duke@1 | 1119 | } else { |
duke@1 | 1120 | mask = ClassFlags; |
duke@1 | 1121 | } |
duke@1 | 1122 | // Interfaces are always ABSTRACT |
duke@1 | 1123 | if ((flags & INTERFACE) != 0) implicit |= ABSTRACT; |
duke@1 | 1124 | |
duke@1 | 1125 | if ((flags & ENUM) != 0) { |
duke@1 | 1126 | // enums can't be declared abstract or final |
duke@1 | 1127 | mask &= ~(ABSTRACT | FINAL); |
duke@1 | 1128 | implicit |= implicitEnumFinalFlag(tree); |
duke@1 | 1129 | } |
duke@1 | 1130 | // Imply STRICTFP if owner has STRICTFP set. |
duke@1 | 1131 | implicit |= sym.owner.flags_field & STRICTFP; |
duke@1 | 1132 | break; |
duke@1 | 1133 | default: |
duke@1 | 1134 | throw new AssertionError(); |
duke@1 | 1135 | } |
mcimadamore@1366 | 1136 | long illegal = flags & ExtendedStandardFlags & ~mask; |
duke@1 | 1137 | if (illegal != 0) { |
duke@1 | 1138 | if ((illegal & INTERFACE) != 0) { |
duke@1 | 1139 | log.error(pos, "intf.not.allowed.here"); |
duke@1 | 1140 | mask |= INTERFACE; |
duke@1 | 1141 | } |
duke@1 | 1142 | else { |
duke@1 | 1143 | log.error(pos, |
mcimadamore@80 | 1144 | "mod.not.allowed.here", asFlagSet(illegal)); |
duke@1 | 1145 | } |
duke@1 | 1146 | } |
duke@1 | 1147 | else if ((sym.kind == TYP || |
duke@1 | 1148 | // ISSUE: Disallowing abstract&private is no longer appropriate |
duke@1 | 1149 | // in the presence of inner classes. Should it be deleted here? |
duke@1 | 1150 | checkDisjoint(pos, flags, |
duke@1 | 1151 | ABSTRACT, |
mcimadamore@1366 | 1152 | PRIVATE | STATIC | DEFAULT)) |
duke@1 | 1153 | && |
duke@1 | 1154 | checkDisjoint(pos, flags, |
mcimadamore@1513 | 1155 | STATIC, |
mcimadamore@1513 | 1156 | DEFAULT) |
mcimadamore@1513 | 1157 | && |
mcimadamore@1513 | 1158 | checkDisjoint(pos, flags, |
duke@1 | 1159 | ABSTRACT | INTERFACE, |
duke@1 | 1160 | FINAL | NATIVE | SYNCHRONIZED) |
duke@1 | 1161 | && |
duke@1 | 1162 | checkDisjoint(pos, flags, |
duke@1 | 1163 | PUBLIC, |
duke@1 | 1164 | PRIVATE | PROTECTED) |
duke@1 | 1165 | && |
duke@1 | 1166 | checkDisjoint(pos, flags, |
duke@1 | 1167 | PRIVATE, |
duke@1 | 1168 | PUBLIC | PROTECTED) |
duke@1 | 1169 | && |
duke@1 | 1170 | checkDisjoint(pos, flags, |
duke@1 | 1171 | FINAL, |
duke@1 | 1172 | VOLATILE) |
duke@1 | 1173 | && |
duke@1 | 1174 | (sym.kind == TYP || |
duke@1 | 1175 | checkDisjoint(pos, flags, |
duke@1 | 1176 | ABSTRACT | NATIVE, |
duke@1 | 1177 | STRICTFP))) { |
duke@1 | 1178 | // skip |
duke@1 | 1179 | } |
mcimadamore@1366 | 1180 | return flags & (mask | ~ExtendedStandardFlags) | implicit; |
duke@1 | 1181 | } |
duke@1 | 1182 | |
duke@1 | 1183 | |
duke@1 | 1184 | /** Determine if this enum should be implicitly final. |
duke@1 | 1185 | * |
duke@1 | 1186 | * If the enum has no specialized enum contants, it is final. |
duke@1 | 1187 | * |
duke@1 | 1188 | * If the enum does have specialized enum contants, it is |
duke@1 | 1189 | * <i>not</i> final. |
duke@1 | 1190 | */ |
duke@1 | 1191 | private long implicitEnumFinalFlag(JCTree tree) { |
jjg@1127 | 1192 | if (!tree.hasTag(CLASSDEF)) return 0; |
duke@1 | 1193 | class SpecialTreeVisitor extends JCTree.Visitor { |
duke@1 | 1194 | boolean specialized; |
duke@1 | 1195 | SpecialTreeVisitor() { |
duke@1 | 1196 | this.specialized = false; |
duke@1 | 1197 | }; |
duke@1 | 1198 | |
jjg@398 | 1199 | @Override |
duke@1 | 1200 | public void visitTree(JCTree tree) { /* no-op */ } |
duke@1 | 1201 | |
jjg@398 | 1202 | @Override |
duke@1 | 1203 | public void visitVarDef(JCVariableDecl tree) { |
duke@1 | 1204 | if ((tree.mods.flags & ENUM) != 0) { |
duke@1 | 1205 | if (tree.init instanceof JCNewClass && |
duke@1 | 1206 | ((JCNewClass) tree.init).def != null) { |
duke@1 | 1207 | specialized = true; |
duke@1 | 1208 | } |
duke@1 | 1209 | } |
duke@1 | 1210 | } |
duke@1 | 1211 | } |
duke@1 | 1212 | |
duke@1 | 1213 | SpecialTreeVisitor sts = new SpecialTreeVisitor(); |
duke@1 | 1214 | JCClassDecl cdef = (JCClassDecl) tree; |
duke@1 | 1215 | for (JCTree defs: cdef.defs) { |
duke@1 | 1216 | defs.accept(sts); |
duke@1 | 1217 | if (sts.specialized) return 0; |
duke@1 | 1218 | } |
duke@1 | 1219 | return FINAL; |
duke@1 | 1220 | } |
duke@1 | 1221 | |
duke@1 | 1222 | /* ************************************************************************* |
duke@1 | 1223 | * Type Validation |
duke@1 | 1224 | **************************************************************************/ |
duke@1 | 1225 | |
duke@1 | 1226 | /** Validate a type expression. That is, |
duke@1 | 1227 | * check that all type arguments of a parametric type are within |
jjg@1755 | 1228 | * their bounds. This must be done in a second phase after type attribution |
duke@1 | 1229 | * since a class might have a subclass as type parameter bound. E.g: |
duke@1 | 1230 | * |
jjg@1358 | 1231 | * <pre>{@code |
duke@1 | 1232 | * class B<A extends C> { ... } |
duke@1 | 1233 | * class C extends B<C> { ... } |
jjg@1358 | 1234 | * }</pre> |
duke@1 | 1235 | * |
duke@1 | 1236 | * and we can't make sure that the bound is already attributed because |
duke@1 | 1237 | * of possible cycles. |
mcimadamore@638 | 1238 | * |
mcimadamore@638 | 1239 | * Visitor method: Validate a type expression, if it is not null, catching |
duke@1 | 1240 | * and reporting any completion failures. |
duke@1 | 1241 | */ |
mcimadamore@122 | 1242 | void validate(JCTree tree, Env<AttrContext> env) { |
mcimadamore@638 | 1243 | validate(tree, env, true); |
duke@1 | 1244 | } |
mcimadamore@638 | 1245 | void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) { |
mcimadamore@638 | 1246 | new Validator(env).validateTree(tree, checkRaw, true); |
mcimadamore@122 | 1247 | } |
duke@1 | 1248 | |
duke@1 | 1249 | /** Visitor method: Validate a list of type expressions. |
duke@1 | 1250 | */ |
mcimadamore@122 | 1251 | void validate(List<? extends JCTree> trees, Env<AttrContext> env) { |
duke@1 | 1252 | for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail) |
mcimadamore@122 | 1253 | validate(l.head, env); |
duke@1 | 1254 | } |
duke@1 | 1255 | |
duke@1 | 1256 | /** A visitor class for type validation. |
duke@1 | 1257 | */ |
duke@1 | 1258 | class Validator extends JCTree.Visitor { |
duke@1 | 1259 | |
mcimadamore@638 | 1260 | boolean isOuter; |
mcimadamore@638 | 1261 | Env<AttrContext> env; |
mcimadamore@638 | 1262 | |
mcimadamore@638 | 1263 | Validator(Env<AttrContext> env) { |
mcimadamore@638 | 1264 | this.env = env; |
mcimadamore@638 | 1265 | } |
mcimadamore@638 | 1266 | |
jjg@398 | 1267 | @Override |
duke@1 | 1268 | public void visitTypeArray(JCArrayTypeTree tree) { |
mcimadamore@638 | 1269 | tree.elemtype.accept(this); |
duke@1 | 1270 | } |
duke@1 | 1271 | |
jjg@398 | 1272 | @Override |
duke@1 | 1273 | public void visitTypeApply(JCTypeApply tree) { |
jjg@1374 | 1274 | if (tree.type.hasTag(CLASS)) { |
duke@1 | 1275 | List<JCExpression> args = tree.arguments; |
mcimadamore@158 | 1276 | List<Type> forms = tree.type.tsym.type.getTypeArguments(); |
mcimadamore@821 | 1277 | |
mcimadamore@821 | 1278 | Type incompatibleArg = firstIncompatibleTypeArg(tree.type); |
mcimadamore@821 | 1279 | if (incompatibleArg != null) { |
mcimadamore@821 | 1280 | for (JCTree arg : tree.arguments) { |
mcimadamore@821 | 1281 | if (arg.type == incompatibleArg) { |
mcimadamore@829 | 1282 | log.error(arg, "not.within.bounds", incompatibleArg, forms.head); |
mcimadamore@821 | 1283 | } |
mcimadamore@829 | 1284 | forms = forms.tail; |
mcimadamore@829 | 1285 | } |
mcimadamore@829 | 1286 | } |
mcimadamore@829 | 1287 | |
mcimadamore@829 | 1288 | forms = tree.type.tsym.type.getTypeArguments(); |
duke@1 | 1289 | |
mcimadamore@638 | 1290 | boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class; |
mcimadamore@638 | 1291 | |
duke@1 | 1292 | // For matching pairs of actual argument types `a' and |
duke@1 | 1293 | // formal type parameters with declared bound `b' ... |
duke@1 | 1294 | while (args.nonEmpty() && forms.nonEmpty()) { |
mcimadamore@638 | 1295 | validateTree(args.head, |
mcimadamore@638 | 1296 | !(isOuter && is_java_lang_Class), |
mcimadamore@638 | 1297 | false); |
duke@1 | 1298 | args = args.tail; |
duke@1 | 1299 | forms = forms.tail; |
duke@1 | 1300 | } |
duke@1 | 1301 | |
duke@1 | 1302 | // Check that this type is either fully parameterized, or |
duke@1 | 1303 | // not parameterized at all. |
duke@1 | 1304 | if (tree.type.getEnclosingType().isRaw()) |
duke@1 | 1305 | log.error(tree.pos(), "improperly.formed.type.inner.raw.param"); |
jjg@1127 | 1306 | if (tree.clazz.hasTag(SELECT)) |
duke@1 | 1307 | visitSelectInternal((JCFieldAccess)tree.clazz); |
duke@1 | 1308 | } |
duke@1 | 1309 | } |
duke@1 | 1310 | |
jjg@398 | 1311 | @Override |
duke@1 | 1312 | public void visitTypeParameter(JCTypeParameter tree) { |
mcimadamore@638 | 1313 | validateTrees(tree.bounds, true, isOuter); |
duke@1 | 1314 | checkClassBounds(tree.pos(), tree.type); |
duke@1 | 1315 | } |
duke@1 | 1316 | |
duke@1 | 1317 | @Override |
duke@1 | 1318 | public void visitWildcard(JCWildcard tree) { |
duke@1 | 1319 | if (tree.inner != null) |
mcimadamore@638 | 1320 | validateTree(tree.inner, true, isOuter); |
duke@1 | 1321 | } |
duke@1 | 1322 | |
jjg@398 | 1323 | @Override |
duke@1 | 1324 | public void visitSelect(JCFieldAccess tree) { |
jjg@1374 | 1325 | if (tree.type.hasTag(CLASS)) { |
duke@1 | 1326 | visitSelectInternal(tree); |
duke@1 | 1327 | |
duke@1 | 1328 | // Check that this type is either fully parameterized, or |
duke@1 | 1329 | // not parameterized at all. |
duke@1 | 1330 | if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty()) |
duke@1 | 1331 | log.error(tree.pos(), "improperly.formed.type.param.missing"); |
duke@1 | 1332 | } |
duke@1 | 1333 | } |
mcimadamore@852 | 1334 | |
duke@1 | 1335 | public void visitSelectInternal(JCFieldAccess tree) { |
mcimadamore@122 | 1336 | if (tree.type.tsym.isStatic() && |
duke@1 | 1337 | tree.selected.type.isParameterized()) { |
duke@1 | 1338 | // The enclosing type is not a class, so we are |
duke@1 | 1339 | // looking at a static member type. However, the |
duke@1 | 1340 | // qualifying expression is parameterized. |
duke@1 | 1341 | log.error(tree.pos(), "cant.select.static.class.from.param.type"); |
duke@1 | 1342 | } else { |
duke@1 | 1343 | // otherwise validate the rest of the expression |
mcimadamore@122 | 1344 | tree.selected.accept(this); |
duke@1 | 1345 | } |
duke@1 | 1346 | } |
duke@1 | 1347 | |
jjg@1521 | 1348 | @Override |
jjg@1521 | 1349 | public void visitAnnotatedType(JCAnnotatedType tree) { |
jjg@1521 | 1350 | tree.underlyingType.accept(this); |
jjg@1521 | 1351 | } |
jjg@1521 | 1352 | |
duke@1 | 1353 | /** Default visitor method: do nothing. |
duke@1 | 1354 | */ |
jjg@398 | 1355 | @Override |
duke@1 | 1356 | public void visitTree(JCTree tree) { |
duke@1 | 1357 | } |
mcimadamore@122 | 1358 | |
mcimadamore@638 | 1359 | public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) { |
mcimadamore@638 | 1360 | try { |
mcimadamore@638 | 1361 | if (tree != null) { |
mcimadamore@638 | 1362 | this.isOuter = isOuter; |
mcimadamore@638 | 1363 | tree.accept(this); |
mcimadamore@638 | 1364 | if (checkRaw) |
mcimadamore@638 | 1365 | checkRaw(tree, env); |
mcimadamore@638 | 1366 | } |
mcimadamore@638 | 1367 | } catch (CompletionFailure ex) { |
mcimadamore@638 | 1368 | completionError(tree.pos(), ex); |
mcimadamore@638 | 1369 | } |
mcimadamore@638 | 1370 | } |
mcimadamore@638 | 1371 | |
mcimadamore@638 | 1372 | public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) { |
mcimadamore@638 | 1373 | for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail) |
mcimadamore@638 | 1374 | validateTree(l.head, checkRaw, isOuter); |
mcimadamore@638 | 1375 | } |
mcimadamore@1760 | 1376 | } |
mcimadamore@1760 | 1377 | |
mcimadamore@1760 | 1378 | void checkRaw(JCTree tree, Env<AttrContext> env) { |
mcimadamore@1760 | 1379 | if (lint.isEnabled(LintCategory.RAW) && |
mcimadamore@1760 | 1380 | tree.type.hasTag(CLASS) && |
mcimadamore@1760 | 1381 | !TreeInfo.isDiamond(tree) && |
mcimadamore@1760 | 1382 | !withinAnonConstr(env) && |
mcimadamore@1760 | 1383 | tree.type.isRaw()) { |
mcimadamore@1760 | 1384 | log.warning(LintCategory.RAW, |
mcimadamore@1760 | 1385 | tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type); |
mcimadamore@638 | 1386 | } |
mcimadamore@1760 | 1387 | } |
mcimadamore@1760 | 1388 | //where |
mcimadamore@1760 | 1389 | private boolean withinAnonConstr(Env<AttrContext> env) { |
mcimadamore@1103 | 1390 | return env.enclClass.name.isEmpty() && |
mcimadamore@1103 | 1391 | env.enclMethod != null && env.enclMethod.name == names.init; |
mcimadamore@1103 | 1392 | } |
duke@1 | 1393 | |
duke@1 | 1394 | /* ************************************************************************* |
duke@1 | 1395 | * Exception checking |
duke@1 | 1396 | **************************************************************************/ |
duke@1 | 1397 | |
duke@1 | 1398 | /* The following methods treat classes as sets that contain |
duke@1 | 1399 | * the class itself and all their subclasses |
duke@1 | 1400 | */ |
duke@1 | 1401 | |
duke@1 | 1402 | /** Is given type a subtype of some of the types in given list? |
duke@1 | 1403 | */ |
duke@1 | 1404 | boolean subset(Type t, List<Type> ts) { |
duke@1 | 1405 | for (List<Type> l = ts; l.nonEmpty(); l = l.tail) |
duke@1 | 1406 | if (types.isSubtype(t, l.head)) return true; |
duke@1 | 1407 | return false; |
duke@1 | 1408 | } |
duke@1 | 1409 | |
duke@1 | 1410 | /** Is given type a subtype or supertype of |
duke@1 | 1411 | * some of the types in given list? |
duke@1 | 1412 | */ |
duke@1 | 1413 | boolean intersects(Type t, List<Type> ts) { |
duke@1 | 1414 | for (List<Type> l = ts; l.nonEmpty(); l = l.tail) |
duke@1 | 1415 | if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true; |
duke@1 | 1416 | return false; |
duke@1 | 1417 | } |
duke@1 | 1418 | |
duke@1 | 1419 | /** Add type set to given type list, unless it is a subclass of some class |
duke@1 | 1420 | * in the list. |
duke@1 | 1421 | */ |
duke@1 | 1422 | List<Type> incl(Type t, List<Type> ts) { |
duke@1 | 1423 | return subset(t, ts) ? ts : excl(t, ts).prepend(t); |
duke@1 | 1424 | } |
duke@1 | 1425 | |
duke@1 | 1426 | /** Remove type set from type set list. |
duke@1 | 1427 | */ |
duke@1 | 1428 | List<Type> excl(Type t, List<Type> ts) { |
duke@1 | 1429 | if (ts.isEmpty()) { |
duke@1 | 1430 | return ts; |
duke@1 | 1431 | } else { |
duke@1 | 1432 | List<Type> ts1 = excl(t, ts.tail); |
duke@1 | 1433 | if (types.isSubtype(ts.head, t)) return ts1; |
duke@1 | 1434 | else if (ts1 == ts.tail) return ts; |
duke@1 | 1435 | else return ts1.prepend(ts.head); |
duke@1 | 1436 | } |
duke@1 | 1437 | } |
duke@1 | 1438 | |
duke@1 | 1439 | /** Form the union of two type set lists. |
duke@1 | 1440 | */ |
duke@1 | 1441 | List<Type> union(List<Type> ts1, List<Type> ts2) { |
duke@1 | 1442 | List<Type> ts = ts1; |
duke@1 | 1443 | for (List<Type> l = ts2; l.nonEmpty(); l = l.tail) |
duke@1 | 1444 | ts = incl(l.head, ts); |
duke@1 | 1445 | return ts; |
duke@1 | 1446 | } |
duke@1 | 1447 | |
duke@1 | 1448 | /** Form the difference of two type lists. |
duke@1 | 1449 | */ |
duke@1 | 1450 | List<Type> diff(List<Type> ts1, List<Type> ts2) { |
duke@1 | 1451 | List<Type> ts = ts1; |
duke@1 | 1452 | for (List<Type> l = ts2; l.nonEmpty(); l = l.tail) |
duke@1 | 1453 | ts = excl(l.head, ts); |
duke@1 | 1454 | return ts; |
duke@1 | 1455 | } |
duke@1 | 1456 | |
duke@1 | 1457 | /** Form the intersection of two type lists. |
duke@1 | 1458 | */ |
duke@1 | 1459 | public List<Type> intersect(List<Type> ts1, List<Type> ts2) { |
duke@1 | 1460 | List<Type> ts = List.nil(); |
duke@1 | 1461 | for (List<Type> l = ts1; l.nonEmpty(); l = l.tail) |
duke@1 | 1462 | if (subset(l.head, ts2)) ts = incl(l.head, ts); |
duke@1 | 1463 | for (List<Type> l = ts2; l.nonEmpty(); l = l.tail) |
duke@1 | 1464 | if (subset(l.head, ts1)) ts = incl(l.head, ts); |
duke@1 | 1465 | return ts; |
duke@1 | 1466 | } |
duke@1 | 1467 | |
duke@1 | 1468 | /** Is exc an exception symbol that need not be declared? |
duke@1 | 1469 | */ |
duke@1 | 1470 | boolean isUnchecked(ClassSymbol exc) { |
duke@1 | 1471 | return |
duke@1 | 1472 | exc.kind == ERR || |
duke@1 | 1473 | exc.isSubClass(syms.errorType.tsym, types) || |
duke@1 | 1474 | exc.isSubClass(syms.runtimeExceptionType.tsym, types); |
duke@1 | 1475 | } |
duke@1 | 1476 | |
duke@1 | 1477 | /** Is exc an exception type that need not be declared? |
duke@1 | 1478 | */ |
duke@1 | 1479 | boolean isUnchecked(Type exc) { |
duke@1 | 1480 | return |
jjg@1374 | 1481 | (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) : |
jjg@1374 | 1482 | (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) : |
jjg@1374 | 1483 | exc.hasTag(BOT); |
duke@1 | 1484 | } |
duke@1 | 1485 | |
duke@1 | 1486 | /** Same, but handling completion failures. |
duke@1 | 1487 | */ |
duke@1 | 1488 | boolean isUnchecked(DiagnosticPosition pos, Type exc) { |
duke@1 | 1489 | try { |
duke@1 | 1490 | return isUnchecked(exc); |
duke@1 | 1491 | } catch (CompletionFailure ex) { |
duke@1 | 1492 | completionError(pos, ex); |
duke@1 | 1493 | return true; |
duke@1 | 1494 | } |
duke@1 | 1495 | } |
duke@1 | 1496 | |
duke@1 | 1497 | /** Is exc handled by given exception list? |
duke@1 | 1498 | */ |
duke@1 | 1499 | boolean isHandled(Type exc, List<Type> handled) { |
duke@1 | 1500 | return isUnchecked(exc) || subset(exc, handled); |
duke@1 | 1501 | } |
duke@1 | 1502 | |
duke@1 | 1503 | /** Return all exceptions in thrown list that are not in handled list. |
duke@1 | 1504 | * @param thrown The list of thrown exceptions. |
duke@1 | 1505 | * @param handled The list of handled exceptions. |
duke@1 | 1506 | */ |
mcimadamore@362 | 1507 | List<Type> unhandled(List<Type> thrown, List<Type> handled) { |
duke@1 | 1508 | List<Type> unhandled = List.nil(); |
duke@1 | 1509 | for (List<Type> l = thrown; l.nonEmpty(); l = l.tail) |
duke@1 | 1510 | if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head); |
duke@1 | 1511 | return unhandled; |
duke@1 | 1512 | } |
duke@1 | 1513 | |
duke@1 | 1514 | /* ************************************************************************* |
duke@1 | 1515 | * Overriding/Implementation checking |
duke@1 | 1516 | **************************************************************************/ |
duke@1 | 1517 | |
duke@1 | 1518 | /** The level of access protection given by a flag set, |
duke@1 | 1519 | * where PRIVATE is highest and PUBLIC is lowest. |
duke@1 | 1520 | */ |
duke@1 | 1521 | static int protection(long flags) { |
duke@1 | 1522 | switch ((short)(flags & AccessFlags)) { |
duke@1 | 1523 | case PRIVATE: return 3; |
duke@1 | 1524 | case PROTECTED: return 1; |
duke@1 | 1525 | default: |
duke@1 | 1526 | case PUBLIC: return 0; |
duke@1 | 1527 | case 0: return 2; |
duke@1 | 1528 | } |
duke@1 | 1529 | } |
duke@1 | 1530 | |
duke@1 | 1531 | /** A customized "cannot override" error message. |
duke@1 | 1532 | * @param m The overriding method. |
duke@1 | 1533 | * @param other The overridden method. |
duke@1 | 1534 | * @return An internationalized string. |
duke@1 | 1535 | */ |
mcimadamore@89 | 1536 | Object cannotOverride(MethodSymbol m, MethodSymbol other) { |
duke@1 | 1537 | String key; |
duke@1 | 1538 | if ((other.owner.flags() & INTERFACE) == 0) |
duke@1 | 1539 | key = "cant.override"; |
duke@1 | 1540 | else if ((m.owner.flags() & INTERFACE) == 0) |
duke@1 | 1541 | key = "cant.implement"; |
duke@1 | 1542 | else |
duke@1 | 1543 | key = "clashes.with"; |
mcimadamore@89 | 1544 | return diags.fragment(key, m, m.location(), other, other.location()); |
duke@1 | 1545 | } |
duke@1 | 1546 | |
duke@1 | 1547 | /** A customized "override" warning message. |
duke@1 | 1548 | * @param m The overriding method. |
duke@1 | 1549 | * @param other The overridden method. |
duke@1 | 1550 | * @return An internationalized string. |
duke@1 | 1551 | */ |
mcimadamore@89 | 1552 | Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) { |
duke@1 | 1553 | String key; |
duke@1 | 1554 | if ((other.owner.flags() & INTERFACE) == 0) |
duke@1 | 1555 | key = "unchecked.override"; |
duke@1 | 1556 | else if ((m.owner.flags() & INTERFACE) == 0) |
duke@1 | 1557 | key = "unchecked.implement"; |
duke@1 | 1558 | else |
duke@1 | 1559 | key = "unchecked.clash.with"; |
mcimadamore@89 | 1560 | return diags.fragment(key, m, m.location(), other, other.location()); |
duke@1 | 1561 | } |
duke@1 | 1562 | |
duke@1 | 1563 | /** A customized "override" warning message. |
duke@1 | 1564 | * @param m The overriding method. |
duke@1 | 1565 | * @param other The overridden method. |
duke@1 | 1566 | * @return An internationalized string. |
duke@1 | 1567 | */ |
mcimadamore@89 | 1568 | Object varargsOverrides(MethodSymbol m, MethodSymbol other) { |
duke@1 | 1569 | String key; |
duke@1 | 1570 | if ((other.owner.flags() & INTERFACE) == 0) |
duke@1 | 1571 | key = "varargs.override"; |
duke@1 | 1572 | else if ((m.owner.flags() & INTERFACE) == 0) |
duke@1 | 1573 | key = "varargs.implement"; |
duke@1 | 1574 | else |
duke@1 | 1575 | key = "varargs.clash.with"; |
mcimadamore@89 | 1576 | return diags.fragment(key, m, m.location(), other, other.location()); |
duke@1 | 1577 | } |
duke@1 | 1578 | |
duke@1 | 1579 | /** Check that this method conforms with overridden method 'other'. |
duke@1 | 1580 | * where `origin' is the class where checking started. |
duke@1 | 1581 | * Complications: |
duke@1 | 1582 | * (1) Do not check overriding of synthetic methods |
duke@1 | 1583 | * (reason: they might be final). |
duke@1 | 1584 | * todo: check whether this is still necessary. |
duke@1 | 1585 | * (2) Admit the case where an interface proxy throws fewer exceptions |
duke@1 | 1586 | * than the method it implements. Augment the proxy methods with the |
duke@1 | 1587 | * undeclared exceptions in this case. |
duke@1 | 1588 | * (3) When generics are enabled, admit the case where an interface proxy |
duke@1 | 1589 | * has a result type |
duke@1 | 1590 | * extended by the result type of the method it implements. |
duke@1 | 1591 | * Change the proxies result type to the smaller type in this case. |
duke@1 | 1592 | * |
duke@1 | 1593 | * @param tree The tree from which positions |
duke@1 | 1594 | * are extracted for errors. |
duke@1 | 1595 | * @param m The overriding method. |
duke@1 | 1596 | * @param other The overridden method. |
duke@1 | 1597 | * @param origin The class of which the overriding method |
duke@1 | 1598 | * is a member. |
duke@1 | 1599 | */ |
duke@1 | 1600 | void checkOverride(JCTree tree, |
duke@1 | 1601 | MethodSymbol m, |
duke@1 | 1602 | MethodSymbol other, |
duke@1 | 1603 | ClassSymbol origin) { |
duke@1 | 1604 | // Don't check overriding of synthetic methods or by bridge methods. |
duke@1 | 1605 | if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) { |
duke@1 | 1606 | return; |
duke@1 | 1607 | } |
duke@1 | 1608 | |
duke@1 | 1609 | // Error if static method overrides instance method (JLS 8.4.6.2). |
duke@1 | 1610 | if ((m.flags() & STATIC) != 0 && |
duke@1 | 1611 | (other.flags() & STATIC) == 0) { |
duke@1 | 1612 | log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static", |
duke@1 | 1613 | cannotOverride(m, other)); |
vromero@1588 | 1614 | m.flags_field |= BAD_OVERRIDE; |
duke@1 | 1615 | return; |
duke@1 | 1616 | } |
duke@1 | 1617 | |
duke@1 | 1618 | // Error if instance method overrides static or final |
duke@1 | 1619 | // method (JLS 8.4.6.1). |
duke@1 | 1620 | if ((other.flags() & FINAL) != 0 || |
duke@1 | 1621 | (m.flags() & STATIC) == 0 && |
duke@1 | 1622 | (other.flags() & STATIC) != 0) { |
duke@1 | 1623 | log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth", |
duke@1 | 1624 | cannotOverride(m, other), |
mcimadamore@80 | 1625 | asFlagSet(other.flags() & (FINAL | STATIC))); |
vromero@1588 | 1626 | m.flags_field |= BAD_OVERRIDE; |
duke@1 | 1627 | return; |
duke@1 | 1628 | } |
duke@1 | 1629 | |
duke@1 | 1630 | if ((m.owner.flags() & ANNOTATION) != 0) { |
duke@1 | 1631 | // handled in validateAnnotationMethod |
duke@1 | 1632 | return; |
duke@1 | 1633 | } |
duke@1 | 1634 | |
duke@1 | 1635 | // Error if overriding method has weaker access (JLS 8.4.6.3). |
duke@1 | 1636 | if ((origin.flags() & INTERFACE) == 0 && |
duke@1 | 1637 | protection(m.flags()) > protection(other.flags())) { |
duke@1 | 1638 | log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access", |
duke@1 | 1639 | cannotOverride(m, other), |
mcimadamore@80 | 1640 | other.flags() == 0 ? |
mcimadamore@80 | 1641 | Flag.PACKAGE : |
mcimadamore@80 | 1642 | asFlagSet(other.flags() & AccessFlags)); |
vromero@1588 | 1643 | m.flags_field |= BAD_OVERRIDE; |
duke@1 | 1644 | return; |
duke@1 | 1645 | } |
duke@1 | 1646 | |
duke@1 | 1647 | Type mt = types.memberType(origin.type, m); |
duke@1 | 1648 | Type ot = types.memberType(origin.type, other); |
duke@1 | 1649 | // Error if overriding result type is different |
duke@1 | 1650 | // (or, in the case of generics mode, not a subtype) of |
duke@1 | 1651 | // overridden result type. We have to rename any type parameters |
duke@1 | 1652 | // before comparing types. |
duke@1 | 1653 | List<Type> mtvars = mt.getTypeArguments(); |
duke@1 | 1654 | List<Type> otvars = ot.getTypeArguments(); |
duke@1 | 1655 | Type mtres = mt.getReturnType(); |
duke@1 | 1656 | Type otres = types.subst(ot.getReturnType(), otvars, mtvars); |
duke@1 | 1657 | |
mcimadamore@795 | 1658 | overrideWarner.clear(); |
duke@1 | 1659 | boolean resultTypesOK = |
tbell@202 | 1660 | types.returnTypeSubstitutable(mt, ot, otres, overrideWarner); |
duke@1 | 1661 | if (!resultTypesOK) { |
jjg@398 | 1662 | if (!allowCovariantReturns && |
duke@1 | 1663 | m.owner != origin && |
duke@1 | 1664 | m.owner.isSubClass(other.owner, types)) { |
duke@1 | 1665 | // allow limited interoperability with covariant returns |
duke@1 | 1666 | } else { |
mcimadamore@362 | 1667 | log.error(TreeInfo.diagnosticPositionFor(m, tree), |
mcimadamore@362 | 1668 | "override.incompatible.ret", |
mcimadamore@362 | 1669 | cannotOverride(m, other), |
duke@1 | 1670 | mtres, otres); |
vromero@1588 | 1671 | m.flags_field |= BAD_OVERRIDE; |
duke@1 | 1672 | return; |
duke@1 | 1673 | } |
mcimadamore@795 | 1674 | } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) { |
duke@1 | 1675 | warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree), |
mcimadamore@362 | 1676 | "override.unchecked.ret", |
mcimadamore@362 | 1677 | uncheckedOverrides(m, other), |
mcimadamore@362 | 1678 | mtres, otres); |
duke@1 | 1679 | } |
duke@1 | 1680 | |
duke@1 | 1681 | // Error if overriding method throws an exception not reported |
duke@1 | 1682 | // by overridden method. |
duke@1 | 1683 | List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars); |
mcimadamore@362 | 1684 | List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown)); |
mcimadamore@362 | 1685 | List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown); |
mcimadamore@362 | 1686 | if (unhandledErased.nonEmpty()) { |
duke@1 | 1687 | log.error(TreeInfo.diagnosticPositionFor(m, tree), |
duke@1 | 1688 | "override.meth.doesnt.throw", |
duke@1 | 1689 | cannotOverride(m, other), |
mcimadamore@362 | 1690 | unhandledUnerased.head); |
vromero@1588 | 1691 | m.flags_field |= BAD_OVERRIDE; |
mcimadamore@362 | 1692 | return; |
mcimadamore@362 | 1693 | } |
mcimadamore@362 | 1694 | else if (unhandledUnerased.nonEmpty()) { |
mcimadamore@362 | 1695 | warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree), |
mcimadamore@362 | 1696 | "override.unchecked.thrown", |
mcimadamore@362 | 1697 | cannotOverride(m, other), |
mcimadamore@362 | 1698 | unhandledUnerased.head); |
duke@1 | 1699 | return; |
duke@1 | 1700 | } |
duke@1 | 1701 | |
duke@1 | 1702 | // Optional warning if varargs don't agree |
duke@1 | 1703 | if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0) |
mcimadamore@795 | 1704 | && lint.isEnabled(LintCategory.OVERRIDES)) { |
duke@1 | 1705 | log.warning(TreeInfo.diagnosticPositionFor(m, tree), |
duke@1 | 1706 | ((m.flags() & Flags.VARARGS) != 0) |
duke@1 | 1707 | ? "override.varargs.missing" |
duke@1 | 1708 | : "override.varargs.extra", |
duke@1 | 1709 | varargsOverrides(m, other)); |
duke@1 | 1710 | } |
duke@1 | 1711 | |
duke@1 | 1712 | // Warn if instance method overrides bridge method (compiler spec ??) |
duke@1 | 1713 | if ((other.flags() & BRIDGE) != 0) { |
duke@1 | 1714 | log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge", |
duke@1 | 1715 | uncheckedOverrides(m, other)); |
duke@1 | 1716 | } |
duke@1 | 1717 | |
duke@1 | 1718 | // Warn if a deprecated method overridden by a non-deprecated one. |
mcimadamore@852 | 1719 | if (!isDeprecatedOverrideIgnorable(other, origin)) { |
mcimadamore@852 | 1720 | checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other); |
duke@1 | 1721 | } |
duke@1 | 1722 | } |
duke@1 | 1723 | // where |
duke@1 | 1724 | private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) { |
duke@1 | 1725 | // If the method, m, is defined in an interface, then ignore the issue if the method |
duke@1 | 1726 | // is only inherited via a supertype and also implemented in the supertype, |
duke@1 | 1727 | // because in that case, we will rediscover the issue when examining the method |
duke@1 | 1728 | // in the supertype. |
duke@1 | 1729 | // If the method, m, is not defined in an interface, then the only time we need to |
duke@1 | 1730 | // address the issue is when the method is the supertype implemementation: any other |
duke@1 | 1731 | // case, we will have dealt with when examining the supertype classes |
duke@1 | 1732 | ClassSymbol mc = m.enclClass(); |
duke@1 | 1733 | Type st = types.supertype(origin.type); |
jjg@1374 | 1734 | if (!st.hasTag(CLASS)) |
duke@1 | 1735 | return true; |
duke@1 | 1736 | MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false); |
duke@1 | 1737 | |
duke@1 | 1738 | if (mc != null && ((mc.flags() & INTERFACE) != 0)) { |
duke@1 | 1739 | List<Type> intfs = types.interfaces(origin.type); |
duke@1 | 1740 | return (intfs.contains(mc.type) ? false : (stimpl != null)); |
duke@1 | 1741 | } |
duke@1 | 1742 | else |
duke@1 | 1743 | return (stimpl != m); |
duke@1 | 1744 | } |
duke@1 | 1745 | |
duke@1 | 1746 | |
duke@1 | 1747 | // used to check if there were any unchecked conversions |
duke@1 | 1748 | Warner overrideWarner = new Warner(); |
duke@1 | 1749 | |
duke@1 | 1750 | /** Check that a class does not inherit two concrete methods |
duke@1 | 1751 | * with the same signature. |
duke@1 | 1752 | * @param pos Position to be used for error reporting. |
duke@1 | 1753 | * @param site The class type to be checked. |
duke@1 | 1754 | */ |
duke@1 | 1755 | public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) { |
duke@1 | 1756 | Type sup = types.supertype(site); |
jjg@1374 | 1757 | if (!sup.hasTag(CLASS)) return; |
duke@1 | 1758 | |
duke@1 | 1759 | for (Type t1 = sup; |
duke@1 | 1760 | t1.tsym.type.isParameterized(); |
duke@1 | 1761 | t1 = types.supertype(t1)) { |
duke@1 | 1762 | for (Scope.Entry e1 = t1.tsym.members().elems; |
duke@1 | 1763 | e1 != null; |
duke@1 | 1764 | e1 = e1.sibling) { |
duke@1 | 1765 | Symbol s1 = e1.sym; |
duke@1 | 1766 | if (s1.kind != MTH || |
duke@1 | 1767 | (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 || |
duke@1 | 1768 | !s1.isInheritedIn(site.tsym, types) || |
duke@1 | 1769 | ((MethodSymbol)s1).implementation(site.tsym, |
duke@1 | 1770 | types, |
duke@1 | 1771 | true) != s1) |
duke@1 | 1772 | continue; |
duke@1 | 1773 | Type st1 = types.memberType(t1, s1); |
duke@1 | 1774 | int s1ArgsLength = st1.getParameterTypes().length(); |
duke@1 | 1775 | if (st1 == s1.type) continue; |
duke@1 | 1776 | |
duke@1 | 1777 | for (Type t2 = sup; |
jjg@1374 | 1778 | t2.hasTag(CLASS); |
duke@1 | 1779 | t2 = types.supertype(t2)) { |
mcimadamore@24 | 1780 | for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); |
duke@1 | 1781 | e2.scope != null; |
duke@1 | 1782 | e2 = e2.next()) { |
duke@1 | 1783 | Symbol s2 = e2.sym; |
duke@1 | 1784 | if (s2 == s1 || |
duke@1 | 1785 | s2.kind != MTH || |
duke@1 | 1786 | (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 || |
duke@1 | 1787 | s2.type.getParameterTypes().length() != s1ArgsLength || |
duke@1 | 1788 | !s2.isInheritedIn(site.tsym, types) || |
duke@1 | 1789 | ((MethodSymbol)s2).implementation(site.tsym, |
duke@1 | 1790 | types, |
duke@1 | 1791 | true) != s2) |
duke@1 | 1792 | continue; |
duke@1 | 1793 | Type st2 = types.memberType(t2, s2); |
duke@1 | 1794 | if (types.overrideEquivalent(st1, st2)) |
duke@1 | 1795 | log.error(pos, "concrete.inheritance.conflict", |
duke@1 | 1796 | s1, t1, s2, t2, sup); |
duke@1 | 1797 | } |
duke@1 | 1798 | } |
duke@1 | 1799 | } |
duke@1 | 1800 | } |
duke@1 | 1801 | } |
duke@1 | 1802 | |
duke@1 | 1803 | /** Check that classes (or interfaces) do not each define an abstract |
duke@1 | 1804 | * method with same name and arguments but incompatible return types. |
duke@1 | 1805 | * @param pos Position to be used for error reporting. |
duke@1 | 1806 | * @param t1 The first argument type. |
duke@1 | 1807 | * @param t2 The second argument type. |
duke@1 | 1808 | */ |
duke@1 | 1809 | public boolean checkCompatibleAbstracts(DiagnosticPosition pos, |
duke@1 | 1810 | Type t1, |
duke@1 | 1811 | Type t2) { |
duke@1 | 1812 | return checkCompatibleAbstracts(pos, t1, t2, |
duke@1 | 1813 | types.makeCompoundType(t1, t2)); |
duke@1 | 1814 | } |
duke@1 | 1815 | |
duke@1 | 1816 | public boolean checkCompatibleAbstracts(DiagnosticPosition pos, |
duke@1 | 1817 | Type t1, |
duke@1 | 1818 | Type t2, |
duke@1 | 1819 | Type site) { |
mcimadamore@746 | 1820 | return firstIncompatibility(pos, t1, t2, site) == null; |
duke@1 | 1821 | } |
duke@1 | 1822 | |
duke@1 | 1823 | /** Return the first method which is defined with same args |
duke@1 | 1824 | * but different return types in two given interfaces, or null if none |
duke@1 | 1825 | * exists. |
duke@1 | 1826 | * @param t1 The first type. |
duke@1 | 1827 | * @param t2 The second type. |
duke@1 | 1828 | * @param site The most derived type. |
duke@1 | 1829 | * @returns symbol from t2 that conflicts with one in t1. |
duke@1 | 1830 | */ |
mcimadamore@746 | 1831 | private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) { |
duke@1 | 1832 | Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>(); |
duke@1 | 1833 | closure(t1, interfaces1); |
duke@1 | 1834 | Map<TypeSymbol,Type> interfaces2; |
duke@1 | 1835 | if (t1 == t2) |
duke@1 | 1836 | interfaces2 = interfaces1; |
duke@1 | 1837 | else |
duke@1 | 1838 | closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>()); |
duke@1 | 1839 | |
duke@1 | 1840 | for (Type t3 : interfaces1.values()) { |
duke@1 | 1841 | for (Type t4 : interfaces2.values()) { |
mcimadamore@746 | 1842 | Symbol s = firstDirectIncompatibility(pos, t3, t4, site); |
duke@1 | 1843 | if (s != null) return s; |
duke@1 | 1844 | } |
duke@1 | 1845 | } |
duke@1 | 1846 | return null; |
duke@1 | 1847 | } |
duke@1 | 1848 | |
duke@1 | 1849 | /** Compute all the supertypes of t, indexed by type symbol. */ |
duke@1 | 1850 | private void closure(Type t, Map<TypeSymbol,Type> typeMap) { |
jjg@1374 | 1851 | if (!t.hasTag(CLASS)) return; |
duke@1 | 1852 | if (typeMap.put(t.tsym, t) == null) { |
duke@1 | 1853 | closure(types.supertype(t), typeMap); |
duke@1 | 1854 | for (Type i : types.interfaces(t)) |
duke@1 | 1855 | closure(i, typeMap); |
duke@1 | 1856 | } |
duke@1 | 1857 | } |
duke@1 | 1858 | |
duke@1 | 1859 | /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */ |
duke@1 | 1860 | private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) { |
jjg@1374 | 1861 | if (!t.hasTag(CLASS)) return; |
duke@1 | 1862 | if (typesSkip.get(t.tsym) != null) return; |
duke@1 | 1863 | if (typeMap.put(t.tsym, t) == null) { |
duke@1 | 1864 | closure(types.supertype(t), typesSkip, typeMap); |
duke@1 | 1865 | for (Type i : types.interfaces(t)) |
duke@1 | 1866 | closure(i, typesSkip, typeMap); |
duke@1 | 1867 | } |
duke@1 | 1868 | } |
duke@1 | 1869 | |
duke@1 | 1870 | /** Return the first method in t2 that conflicts with a method from t1. */ |
mcimadamore@746 | 1871 | private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) { |
duke@1 | 1872 | for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) { |
duke@1 | 1873 | Symbol s1 = e1.sym; |
duke@1 | 1874 | Type st1 = null; |
mcimadamore@1441 | 1875 | if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) || |
mcimadamore@1441 | 1876 | (s1.flags() & SYNTHETIC) != 0) continue; |
duke@1 | 1877 | Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false); |
duke@1 | 1878 | if (impl != null && (impl.flags() & ABSTRACT) == 0) continue; |
duke@1 | 1879 | for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) { |
duke@1 | 1880 | Symbol s2 = e2.sym; |
duke@1 | 1881 | if (s1 == s2) continue; |
mcimadamore@1441 | 1882 | if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) || |
mcimadamore@1441 | 1883 | (s2.flags() & SYNTHETIC) != 0) continue; |
duke@1 | 1884 | if (st1 == null) st1 = types.memberType(t1, s1); |
duke@1 | 1885 | Type st2 = types.memberType(t2, s2); |
duke@1 | 1886 | if (types.overrideEquivalent(st1, st2)) { |
duke@1 | 1887 | List<Type> tvars1 = st1.getTypeArguments(); |
duke@1 | 1888 | List<Type> tvars2 = st2.getTypeArguments(); |
duke@1 | 1889 | Type rt1 = st1.getReturnType(); |
duke@1 | 1890 | Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1); |
duke@1 | 1891 | boolean compat = |
duke@1 | 1892 | types.isSameType(rt1, rt2) || |
jjg@1374 | 1893 | !rt1.isPrimitiveOrVoid() && |
jjg@1374 | 1894 | !rt2.isPrimitiveOrVoid() && |
mcimadamore@1415 | 1895 | (types.covariantReturnType(rt1, rt2, types.noWarnings) || |
mcimadamore@1415 | 1896 | types.covariantReturnType(rt2, rt1, types.noWarnings)) || |
mcimadamore@59 | 1897 | checkCommonOverriderIn(s1,s2,site); |
mcimadamore@746 | 1898 | if (!compat) { |
mcimadamore@746 | 1899 | log.error(pos, "types.incompatible.diff.ret", |
mcimadamore@746 | 1900 | t1, t2, s2.name + |
mcimadamore@746 | 1901 | "(" + types.memberType(t2, s2).getParameterTypes() + ")"); |
mcimadamore@746 | 1902 | return s2; |
mcimadamore@746 | 1903 | } |
mcimadamore@889 | 1904 | } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) && |
mcimadamore@889 | 1905 | !checkCommonOverriderIn(s1, s2, site)) { |
mcimadamore@746 | 1906 | log.error(pos, |
mcimadamore@746 | 1907 | "name.clash.same.erasure.no.override", |
mcimadamore@746 | 1908 | s1, s1.location(), |
mcimadamore@746 | 1909 | s2, s2.location()); |
mcimadamore@746 | 1910 | return s2; |
duke@1 | 1911 | } |
duke@1 | 1912 | } |
duke@1 | 1913 | } |
duke@1 | 1914 | return null; |
duke@1 | 1915 | } |
mcimadamore@59 | 1916 | //WHERE |
mcimadamore@59 | 1917 | boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) { |
mcimadamore@59 | 1918 | Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>(); |
mcimadamore@59 | 1919 | Type st1 = types.memberType(site, s1); |
mcimadamore@59 | 1920 | Type st2 = types.memberType(site, s2); |
mcimadamore@59 | 1921 | closure(site, supertypes); |
mcimadamore@59 | 1922 | for (Type t : supertypes.values()) { |
mcimadamore@59 | 1923 | for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) { |
mcimadamore@59 | 1924 | Symbol s3 = e.sym; |
mcimadamore@59 | 1925 | if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue; |
mcimadamore@59 | 1926 | Type st3 = types.memberType(site,s3); |
mcimadamore@59 | 1927 | if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) { |
mcimadamore@59 | 1928 | if (s3.owner == site.tsym) { |
mcimadamore@59 | 1929 | return true; |
mcimadamore@59 | 1930 | } |
mcimadamore@59 | 1931 | List<Type> tvars1 = st1.getTypeArguments(); |
mcimadamore@59 | 1932 | List<Type> tvars2 = st2.getTypeArguments(); |
mcimadamore@59 | 1933 | List<Type> tvars3 = st3.getTypeArguments(); |
mcimadamore@59 | 1934 | Type rt1 = st1.getReturnType(); |
mcimadamore@59 | 1935 | Type rt2 = st2.getReturnType(); |
mcimadamore@59 | 1936 | Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1); |
mcimadamore@59 | 1937 | Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2); |
mcimadamore@59 | 1938 | boolean compat = |
jjg@1374 | 1939 | !rt13.isPrimitiveOrVoid() && |
jjg@1374 | 1940 | !rt23.isPrimitiveOrVoid() && |
mcimadamore@1415 | 1941 | (types.covariantReturnType(rt13, rt1, types.noWarnings) && |
mcimadamore@1415 | 1942 | types.covariantReturnType(rt23, rt2, types.noWarnings)); |
mcimadamore@59 | 1943 | if (compat) |
mcimadamore@59 | 1944 | return true; |
mcimadamore@59 | 1945 | } |
mcimadamore@59 | 1946 | } |
mcimadamore@59 | 1947 | } |
mcimadamore@59 | 1948 | return false; |
mcimadamore@59 | 1949 | } |
duke@1 | 1950 | |
duke@1 | 1951 | /** Check that a given method conforms with any method it overrides. |
duke@1 | 1952 | * @param tree The tree from which positions are extracted |
duke@1 | 1953 | * for errors. |
duke@1 | 1954 | * @param m The overriding method. |
duke@1 | 1955 | */ |
duke@1 | 1956 | void checkOverride(JCTree tree, MethodSymbol m) { |
duke@1 | 1957 | ClassSymbol origin = (ClassSymbol)m.owner; |
duke@1 | 1958 | if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name)) |
duke@1 | 1959 | if (m.overrides(syms.enumFinalFinalize, origin, types, false)) { |
duke@1 | 1960 | log.error(tree.pos(), "enum.no.finalize"); |
duke@1 | 1961 | return; |
duke@1 | 1962 | } |
jjg@1374 | 1963 | for (Type t = origin.type; t.hasTag(CLASS); |
duke@1 | 1964 | t = types.supertype(t)) { |
mcimadamore@746 | 1965 | if (t != origin.type) { |
mcimadamore@746 | 1966 | checkOverride(tree, t, origin, m); |
mcimadamore@746 | 1967 | } |
mcimadamore@746 | 1968 | for (Type t2 : types.interfaces(t)) { |
mcimadamore@746 | 1969 | checkOverride(tree, t2, origin, m); |
duke@1 | 1970 | } |
duke@1 | 1971 | } |
duke@1 | 1972 | } |
duke@1 | 1973 | |
mcimadamore@746 | 1974 | void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) { |
mcimadamore@746 | 1975 | TypeSymbol c = site.tsym; |
mcimadamore@746 | 1976 | Scope.Entry e = c.members().lookup(m.name); |
mcimadamore@746 | 1977 | while (e.scope != null) { |
mcimadamore@746 | 1978 | if (m.overrides(e.sym, origin, types, false)) { |
mcimadamore@746 | 1979 | if ((e.sym.flags() & ABSTRACT) == 0) { |
mcimadamore@746 | 1980 | checkOverride(tree, m, (MethodSymbol)e.sym, origin); |
mcimadamore@746 | 1981 | } |
mcimadamore@746 | 1982 | } |
mcimadamore@746 | 1983 | e = e.next(); |
mcimadamore@746 | 1984 | } |
mcimadamore@746 | 1985 | } |
mcimadamore@746 | 1986 | |
vromero@1607 | 1987 | private Filter<Symbol> equalsHasCodeFilter = new Filter<Symbol>() { |
vromero@1607 | 1988 | public boolean accepts(Symbol s) { |
vromero@1607 | 1989 | return MethodSymbol.implementation_filter.accepts(s) && |
vromero@1607 | 1990 | (s.flags() & BAD_OVERRIDE) == 0; |
vromero@1607 | 1991 | |
vromero@1607 | 1992 | } |
vromero@1607 | 1993 | }; |
vromero@1607 | 1994 | |
vromero@1620 | 1995 | public void checkClassOverrideEqualsAndHashIfNeeded(DiagnosticPosition pos, |
vromero@1620 | 1996 | ClassSymbol someClass) { |
vromero@1620 | 1997 | /* At present, annotations cannot possibly have a method that is override |
vromero@1620 | 1998 | * equivalent with Object.equals(Object) but in any case the condition is |
vromero@1620 | 1999 | * fine for completeness. |
vromero@1620 | 2000 | */ |
vromero@1620 | 2001 | if (someClass == (ClassSymbol)syms.objectType.tsym || |
vromero@1620 | 2002 | someClass.isInterface() || someClass.isEnum() || |
vromero@1620 | 2003 | (someClass.flags() & ANNOTATION) != 0 || |
vromero@1620 | 2004 | (someClass.flags() & ABSTRACT) != 0) return; |
vromero@1620 | 2005 | //anonymous inner classes implementing interfaces need especial treatment |
vromero@1620 | 2006 | if (someClass.isAnonymous()) { |
vromero@1620 | 2007 | List<Type> interfaces = types.interfaces(someClass.type); |
vromero@1620 | 2008 | if (interfaces != null && !interfaces.isEmpty() && |
vromero@1620 | 2009 | interfaces.head.tsym == syms.comparatorType.tsym) return; |
vromero@1620 | 2010 | } |
vromero@1620 | 2011 | checkClassOverrideEqualsAndHash(pos, someClass); |
vromero@1620 | 2012 | } |
vromero@1620 | 2013 | |
vromero@1620 | 2014 | private void checkClassOverrideEqualsAndHash(DiagnosticPosition pos, |
vromero@1607 | 2015 | ClassSymbol someClass) { |
vromero@1588 | 2016 | if (lint.isEnabled(LintCategory.OVERRIDES)) { |
vromero@1607 | 2017 | MethodSymbol equalsAtObject = (MethodSymbol)syms.objectType |
vromero@1607 | 2018 | .tsym.members().lookup(names.equals).sym; |
vromero@1607 | 2019 | MethodSymbol hashCodeAtObject = (MethodSymbol)syms.objectType |
vromero@1607 | 2020 | .tsym.members().lookup(names.hashCode).sym; |
vromero@1607 | 2021 | boolean overridesEquals = types.implementation(equalsAtObject, |
vromero@1607 | 2022 | someClass, false, equalsHasCodeFilter).owner == someClass; |
vromero@1607 | 2023 | boolean overridesHashCode = types.implementation(hashCodeAtObject, |
vromero@1607 | 2024 | someClass, false, equalsHasCodeFilter) != hashCodeAtObject; |
vromero@1607 | 2025 | |
vromero@1607 | 2026 | if (overridesEquals && !overridesHashCode) { |
vromero@1607 | 2027 | log.warning(LintCategory.OVERRIDES, pos, |
vromero@1620 | 2028 | "override.equals.but.not.hashcode", someClass); |
vromero@1588 | 2029 | } |
vromero@1588 | 2030 | } |
vromero@1588 | 2031 | } |
vromero@1588 | 2032 | |
mcimadamore@746 | 2033 | private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) { |
mcimadamore@858 | 2034 | ClashFilter cf = new ClashFilter(origin.type); |
mcimadamore@858 | 2035 | return (cf.accepts(s1) && |
mcimadamore@858 | 2036 | cf.accepts(s2) && |
mcimadamore@858 | 2037 | types.hasSameArgs(s1.erasure(types), s2.erasure(types))); |
mcimadamore@746 | 2038 | } |
mcimadamore@746 | 2039 | |
mcimadamore@746 | 2040 | |
duke@1 | 2041 | /** Check that all abstract members of given class have definitions. |
duke@1 | 2042 | * @param pos Position to be used for error reporting. |
duke@1 | 2043 | * @param c The class. |
duke@1 | 2044 | */ |
duke@1 | 2045 | void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) { |
duke@1 | 2046 | try { |
duke@1 | 2047 | MethodSymbol undef = firstUndef(c, c); |
duke@1 | 2048 | if (undef != null) { |
duke@1 | 2049 | if ((c.flags() & ENUM) != 0 && |
duke@1 | 2050 | types.supertype(c.type).tsym == syms.enumSym && |
duke@1 | 2051 | (c.flags() & FINAL) == 0) { |
duke@1 | 2052 | // add the ABSTRACT flag to an enum |
duke@1 | 2053 | c.flags_field |= ABSTRACT; |
duke@1 | 2054 | } else { |
duke@1 | 2055 | MethodSymbol undef1 = |
duke@1 | 2056 | new MethodSymbol(undef.flags(), undef.name, |
duke@1 | 2057 | types.memberType(c.type, undef), undef.owner); |
duke@1 | 2058 | log.error(pos, "does.not.override.abstract", |
duke@1 | 2059 | c, undef1, undef1.location()); |
duke@1 | 2060 | } |
duke@1 | 2061 | } |
duke@1 | 2062 | } catch (CompletionFailure ex) { |
duke@1 | 2063 | completionError(pos, ex); |
duke@1 | 2064 | } |
duke@1 | 2065 | } |
duke@1 | 2066 | //where |
duke@1 | 2067 | /** Return first abstract member of class `c' that is not defined |
duke@1 | 2068 | * in `impl', null if there is none. |
duke@1 | 2069 | */ |
duke@1 | 2070 | private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) { |
duke@1 | 2071 | MethodSymbol undef = null; |
duke@1 | 2072 | // Do not bother to search in classes that are not abstract, |
duke@1 | 2073 | // since they cannot have abstract members. |
duke@1 | 2074 | if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) { |
duke@1 | 2075 | Scope s = c.members(); |
duke@1 | 2076 | for (Scope.Entry e = s.elems; |
duke@1 | 2077 | undef == null && e != null; |
duke@1 | 2078 | e = e.sibling) { |
duke@1 | 2079 | if (e.sym.kind == MTH && |
mcimadamore@1393 | 2080 | (e.sym.flags() & (ABSTRACT|IPROXY|DEFAULT)) == ABSTRACT) { |
duke@1 | 2081 | MethodSymbol absmeth = (MethodSymbol)e.sym; |
duke@1 | 2082 | MethodSymbol implmeth = absmeth.implementation(impl, types, true); |
mcimadamore@1393 | 2083 | if (implmeth == null || implmeth == absmeth) { |
mcimadamore@1393 | 2084 | //look for default implementations |
mcimadamore@1393 | 2085 | if (allowDefaultMethods) { |
mcimadamore@1393 | 2086 | MethodSymbol prov = types.interfaceCandidates(impl.type, absmeth).head; |
mcimadamore@1393 | 2087 | if (prov != null && prov.overrides(absmeth, impl, types, true)) { |
mcimadamore@1393 | 2088 | implmeth = prov; |
mcimadamore@1393 | 2089 | } |
mcimadamore@1393 | 2090 | } |
mcimadamore@1393 | 2091 | } |
mcimadamore@1393 | 2092 | if (implmeth == null || implmeth == absmeth) { |
duke@1 | 2093 | undef = absmeth; |
mcimadamore@1393 | 2094 | } |
duke@1 | 2095 | } |
duke@1 | 2096 | } |
duke@1 | 2097 | if (undef == null) { |
duke@1 | 2098 | Type st = types.supertype(c.type); |
jjg@1374 | 2099 | if (st.hasTag(CLASS)) |
duke@1 | 2100 | undef = firstUndef(impl, (ClassSymbol)st.tsym); |
duke@1 | 2101 | } |
duke@1 | 2102 | for (List<Type> l = types.interfaces(c.type); |
duke@1 | 2103 | undef == null && l.nonEmpty(); |
duke@1 | 2104 | l = l.tail) { |
duke@1 | 2105 | undef = firstUndef(impl, (ClassSymbol)l.head.tsym); |
duke@1 | 2106 | } |
duke@1 | 2107 | } |
duke@1 | 2108 | return undef; |
duke@1 | 2109 | } |
duke@1 | 2110 | |
mcimadamore@690 | 2111 | void checkNonCyclicDecl(JCClassDecl tree) { |
mcimadamore@690 | 2112 | CycleChecker cc = new CycleChecker(); |
mcimadamore@690 | 2113 | cc.scan(tree); |
mcimadamore@690 | 2114 | if (!cc.errorFound && !cc.partialCheck) { |
mcimadamore@690 | 2115 | tree.sym.flags_field |= ACYCLIC; |
mcimadamore@690 | 2116 | } |
mcimadamore@690 | 2117 | } |
mcimadamore@690 | 2118 | |
mcimadamore@690 | 2119 | class CycleChecker extends TreeScanner { |
mcimadamore@690 | 2120 | |
mcimadamore@690 | 2121 | List<Symbol> seenClasses = List.nil(); |
mcimadamore@690 | 2122 | boolean errorFound = false; |
mcimadamore@690 | 2123 | boolean partialCheck = false; |
mcimadamore@690 | 2124 | |
mcimadamore@690 | 2125 | private void checkSymbol(DiagnosticPosition pos, Symbol sym) { |
mcimadamore@690 | 2126 | if (sym != null && sym.kind == TYP) { |
mcimadamore@690 | 2127 | Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym); |
mcimadamore@690 | 2128 | if (classEnv != null) { |
mcimadamore@690 | 2129 | DiagnosticSource prevSource = log.currentSource(); |
mcimadamore@690 | 2130 | try { |
mcimadamore@690 | 2131 | log.useSource(classEnv.toplevel.sourcefile); |
mcimadamore@690 | 2132 | scan(classEnv.tree); |
mcimadamore@690 | 2133 | } |
mcimadamore@690 | 2134 | finally { |
mcimadamore@690 | 2135 | log.useSource(prevSource.getFile()); |
mcimadamore@690 | 2136 | } |
mcimadamore@690 | 2137 | } else if (sym.kind == TYP) { |
mcimadamore@690 | 2138 | checkClass(pos, sym, List.<JCTree>nil()); |
mcimadamore@690 | 2139 | } |
mcimadamore@690 | 2140 | } else { |
mcimadamore@690 | 2141 | //not completed yet |
mcimadamore@690 | 2142 | partialCheck = true; |
mcimadamore@690 | 2143 | } |
mcimadamore@690 | 2144 | } |
mcimadamore@690 | 2145 | |
mcimadamore@690 | 2146 | @Override |
mcimadamore@690 | 2147 | public void visitSelect(JCFieldAccess tree) { |
mcimadamore@690 | 2148 | super.visitSelect(tree); |
mcimadamore@690 | 2149 | checkSymbol(tree.pos(), tree.sym); |
mcimadamore@690 | 2150 | } |
mcimadamore@690 | 2151 | |
mcimadamore@690 | 2152 | @Override |
mcimadamore@690 | 2153 | public void visitIdent(JCIdent tree) { |
mcimadamore@690 | 2154 | checkSymbol(tree.pos(), tree.sym); |
mcimadamore@690 | 2155 | } |
mcimadamore@690 | 2156 | |
mcimadamore@690 | 2157 | @Override |
mcimadamore@690 | 2158 | public void visitTypeApply(JCTypeApply tree) { |
mcimadamore@690 | 2159 | scan(tree.clazz); |
mcimadamore@690 | 2160 | } |
mcimadamore@690 | 2161 | |
mcimadamore@690 | 2162 | @Override |
mcimadamore@690 | 2163 | public void visitTypeArray(JCArrayTypeTree tree) { |
mcimadamore@690 | 2164 | scan(tree.elemtype); |
mcimadamore@690 | 2165 | } |
mcimadamore@690 | 2166 | |
mcimadamore@690 | 2167 | @Override |
mcimadamore@690 | 2168 | public void visitClassDef(JCClassDecl tree) { |
mcimadamore@690 | 2169 | List<JCTree> supertypes = List.nil(); |
mcimadamore@690 | 2170 | if (tree.getExtendsClause() != null) { |
mcimadamore@690 | 2171 | supertypes = supertypes.prepend(tree.getExtendsClause()); |
mcimadamore@690 | 2172 | } |
mcimadamore@690 | 2173 | if (tree.getImplementsClause() != null) { |
mcimadamore@690 | 2174 | for (JCTree intf : tree.getImplementsClause()) { |
mcimadamore@690 | 2175 | supertypes = supertypes.prepend(intf); |
mcimadamore@690 | 2176 | } |
mcimadamore@690 | 2177 | } |
mcimadamore@690 | 2178 | checkClass(tree.pos(), tree.sym, supertypes); |
mcimadamore@690 | 2179 | } |
mcimadamore@690 | 2180 | |
mcimadamore@690 | 2181 | void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) { |
mcimadamore@690 | 2182 | if ((c.flags_field & ACYCLIC) != 0) |
mcimadamore@690 | 2183 | return; |
mcimadamore@690 | 2184 | if (seenClasses.contains(c)) { |
mcimadamore@690 | 2185 | errorFound = true; |
mcimadamore@690 | 2186 | noteCyclic(pos, (ClassSymbol)c); |
mcimadamore@690 | 2187 | } else if (!c.type.isErroneous()) { |
mcimadamore@690 | 2188 | try { |
mcimadamore@690 | 2189 | seenClasses = seenClasses.prepend(c); |
jjg@1374 | 2190 | if (c.type.hasTag(CLASS)) { |
mcimadamore@690 | 2191 | if (supertypes.nonEmpty()) { |
mcimadamore@690 | 2192 | scan(supertypes); |
mcimadamore@690 | 2193 | } |
mcimadamore@690 | 2194 | else { |
mcimadamore@690 | 2195 | ClassType ct = (ClassType)c.type; |
mcimadamore@690 | 2196 | if (ct.supertype_field == null || |
mcimadamore@690 | 2197 | ct.interfaces_field == null) { |
mcimadamore@690 | 2198 | //not completed yet |
mcimadamore@690 | 2199 | partialCheck = true; |
mcimadamore@690 | 2200 | return; |
mcimadamore@690 | 2201 | } |
mcimadamore@690 | 2202 | checkSymbol(pos, ct.supertype_field.tsym); |
mcimadamore@690 | 2203 | for (Type intf : ct.interfaces_field) { |
mcimadamore@690 | 2204 | checkSymbol(pos, intf.tsym); |
mcimadamore@690 | 2205 | } |
mcimadamore@690 | 2206 | } |
mcimadamore@690 | 2207 | if (c.owner.kind == TYP) { |
mcimadamore@690 | 2208 | checkSymbol(pos, c.owner); |
mcimadamore@690 | 2209 | } |
mcimadamore@690 | 2210 | } |
mcimadamore@690 | 2211 | } finally { |
mcimadamore@690 | 2212 | seenClasses = seenClasses.tail; |
mcimadamore@690 | 2213 | } |
mcimadamore@690 | 2214 | } |
mcimadamore@690 | 2215 | } |
mcimadamore@690 | 2216 | } |
mcimadamore@690 | 2217 | |
duke@1 | 2218 | /** Check for cyclic references. Issue an error if the |
duke@1 | 2219 | * symbol of the type referred to has a LOCKED flag set. |
duke@1 | 2220 | * |
duke@1 | 2221 | * @param pos Position to be used for error reporting. |
duke@1 | 2222 | * @param t The type referred to. |
duke@1 | 2223 | */ |
duke@1 | 2224 | void checkNonCyclic(DiagnosticPosition pos, Type t) { |
duke@1 | 2225 | checkNonCyclicInternal(pos, t); |
duke@1 | 2226 | } |
duke@1 | 2227 | |
duke@1 | 2228 | |
duke@1 | 2229 | void checkNonCyclic(DiagnosticPosition pos, TypeVar t) { |
mcimadamore@236 | 2230 | checkNonCyclic1(pos, t, List.<TypeVar>nil()); |
duke@1 | 2231 | } |
duke@1 | 2232 | |
mcimadamore@236 | 2233 | private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) { |
duke@1 | 2234 | final TypeVar tv; |
jjg@1374 | 2235 | if (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0) |
mcimadamore@42 | 2236 | return; |
duke@1 | 2237 | if (seen.contains(t)) { |
duke@1 | 2238 | tv = (TypeVar)t; |
jjg@110 | 2239 | tv.bound = types.createErrorType(t); |
duke@1 | 2240 | log.error(pos, "cyclic.inheritance", t); |
jjg@1374 | 2241 | } else if (t.hasTag(TYPEVAR)) { |
duke@1 | 2242 | tv = (TypeVar)t; |
mcimadamore@236 | 2243 | seen = seen.prepend(tv); |
duke@1 | 2244 | for (Type b : types.getBounds(tv)) |
duke@1 | 2245 | checkNonCyclic1(pos, b, seen); |
duke@1 | 2246 | } |
duke@1 | 2247 | } |
duke@1 | 2248 | |
duke@1 | 2249 | /** Check for cyclic references. Issue an error if the |
duke@1 | 2250 | * symbol of the type referred to has a LOCKED flag set. |
duke@1 | 2251 | * |
duke@1 | 2252 | * @param pos Position to be used for error reporting. |
duke@1 | 2253 | * @param t The type referred to. |
duke@1 | 2254 | * @returns True if the check completed on all attributed classes |
duke@1 | 2255 | */ |
duke@1 | 2256 | private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) { |
duke@1 | 2257 | boolean complete = true; // was the check complete? |
duke@1 | 2258 | //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG |
duke@1 | 2259 | Symbol c = t.tsym; |
duke@1 | 2260 | if ((c.flags_field & ACYCLIC) != 0) return true; |
duke@1 | 2261 | |
duke@1 | 2262 | if ((c.flags_field & LOCKED) != 0) { |
duke@1 | 2263 | noteCyclic(pos, (ClassSymbol)c); |
duke@1 | 2264 | } else if (!c.type.isErroneous()) { |
duke@1 | 2265 | try { |
duke@1 | 2266 | c.flags_field |= LOCKED; |
jjg@1374 | 2267 | if (c.type.hasTag(CLASS)) { |
duke@1 | 2268 | ClassType clazz = (ClassType)c.type; |
duke@1 | 2269 | if (clazz.interfaces_field != null) |
duke@1 | 2270 | for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail) |
duke@1 | 2271 | complete &= checkNonCyclicInternal(pos, l.head); |
duke@1 | 2272 | if (clazz.supertype_field != null) { |
duke@1 | 2273 | Type st = clazz.supertype_field; |
jjg@1374 | 2274 | if (st != null && st.hasTag(CLASS)) |
duke@1 | 2275 | complete &= checkNonCyclicInternal(pos, st); |
duke@1 | 2276 | } |
duke@1 | 2277 | if (c.owner.kind == TYP) |
duke@1 | 2278 | complete &= checkNonCyclicInternal(pos, c.owner.type); |
duke@1 | 2279 | } |
duke@1 | 2280 | } finally { |
duke@1 | 2281 | c.flags_field &= ~LOCKED; |
duke@1 | 2282 | } |
duke@1 | 2283 | } |
duke@1 | 2284 | if (complete) |
duke@1 | 2285 | complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null; |
duke@1 | 2286 | if (complete) c.flags_field |= ACYCLIC; |
duke@1 | 2287 | return complete; |
duke@1 | 2288 | } |
duke@1 | 2289 | |
duke@1 | 2290 | /** Note that we found an inheritance cycle. */ |
duke@1 | 2291 | private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) { |
duke@1 | 2292 | log.error(pos, "cyclic.inheritance", c); |
duke@1 | 2293 | for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail) |
jjg@110 | 2294 | l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType); |
duke@1 | 2295 | Type st = types.supertype(c.type); |
jjg@1374 | 2296 | if (st.hasTag(CLASS)) |
jjg@110 | 2297 | ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType); |
jjg@110 | 2298 | c.type = types.createErrorType(c, c.type); |
duke@1 | 2299 | c.flags_field |= ACYCLIC; |
duke@1 | 2300 | } |
duke@1 | 2301 | |
mcimadamore@1415 | 2302 | /** |
mcimadamore@1415 | 2303 | * Check that functional interface methods would make sense when seen |
mcimadamore@1415 | 2304 | * from the perspective of the implementing class |
mcimadamore@1415 | 2305 | */ |
mcimadamore@1415 | 2306 | void checkFunctionalInterface(JCTree tree, Type funcInterface) { |
mcimadamore@1415 | 2307 | ClassType c = new ClassType(Type.noType, List.<Type>nil(), null); |
mcimadamore@1415 | 2308 | ClassSymbol csym = new ClassSymbol(0, names.empty, c, syms.noSymbol); |
mcimadamore@1579 | 2309 | c.interfaces_field = List.of(types.removeWildcards(funcInterface)); |
mcimadamore@1415 | 2310 | c.supertype_field = syms.objectType; |
mcimadamore@1415 | 2311 | c.tsym = csym; |
mcimadamore@1415 | 2312 | csym.members_field = new Scope(csym); |
mcimadamore@1579 | 2313 | Symbol descSym = types.findDescriptorSymbol(funcInterface.tsym); |
mcimadamore@1579 | 2314 | Type descType = types.findDescriptorType(funcInterface); |
mcimadamore@1579 | 2315 | csym.members_field.enter(new MethodSymbol(PUBLIC, descSym.name, descType, csym)); |
mcimadamore@1415 | 2316 | csym.completer = null; |
mcimadamore@1415 | 2317 | checkImplementations(tree, csym, csym); |
mcimadamore@1415 | 2318 | } |
mcimadamore@1415 | 2319 | |
duke@1 | 2320 | /** Check that all methods which implement some |
duke@1 | 2321 | * method conform to the method they implement. |
duke@1 | 2322 | * @param tree The class definition whose members are checked. |
duke@1 | 2323 | */ |
duke@1 | 2324 | void checkImplementations(JCClassDecl tree) { |
mcimadamore@1415 | 2325 | checkImplementations(tree, tree.sym, tree.sym); |
duke@1 | 2326 | } |
jjg@1521 | 2327 | //where |
duke@1 | 2328 | /** Check that all methods which implement some |
duke@1 | 2329 | * method in `ic' conform to the method they implement. |
duke@1 | 2330 | */ |
mcimadamore@1415 | 2331 | void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) { |
duke@1 | 2332 | for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) { |
duke@1 | 2333 | ClassSymbol lc = (ClassSymbol)l.head.tsym; |
duke@1 | 2334 | if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) { |
duke@1 | 2335 | for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) { |
duke@1 | 2336 | if (e.sym.kind == MTH && |
duke@1 | 2337 | (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) { |
duke@1 | 2338 | MethodSymbol absmeth = (MethodSymbol)e.sym; |
duke@1 | 2339 | MethodSymbol implmeth = absmeth.implementation(origin, types, false); |
duke@1 | 2340 | if (implmeth != null && implmeth != absmeth && |
duke@1 | 2341 | (implmeth.owner.flags() & INTERFACE) == |
duke@1 | 2342 | (origin.flags() & INTERFACE)) { |
duke@1 | 2343 | // don't check if implmeth is in a class, yet |
duke@1 | 2344 | // origin is an interface. This case arises only |
duke@1 | 2345 | // if implmeth is declared in Object. The reason is |
duke@1 | 2346 | // that interfaces really don't inherit from |
duke@1 | 2347 | // Object it's just that the compiler represents |
duke@1 | 2348 | // things that way. |
duke@1 | 2349 | checkOverride(tree, implmeth, absmeth, origin); |
duke@1 | 2350 | } |
duke@1 | 2351 | } |
duke@1 | 2352 | } |
duke@1 | 2353 | } |
duke@1 | 2354 | } |
duke@1 | 2355 | } |
duke@1 | 2356 | |
duke@1 | 2357 | /** Check that all abstract methods implemented by a class are |
duke@1 | 2358 | * mutually compatible. |
duke@1 | 2359 | * @param pos Position to be used for error reporting. |
duke@1 | 2360 | * @param c The class whose interfaces are checked. |
duke@1 | 2361 | */ |
duke@1 | 2362 | void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) { |
duke@1 | 2363 | List<Type> supertypes = types.interfaces(c); |
duke@1 | 2364 | Type supertype = types.supertype(c); |
jjg@1374 | 2365 | if (supertype.hasTag(CLASS) && |
duke@1 | 2366 | (supertype.tsym.flags() & ABSTRACT) != 0) |
duke@1 | 2367 | supertypes = supertypes.prepend(supertype); |
duke@1 | 2368 | for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) { |
duke@1 | 2369 | if (allowGenerics && !l.head.getTypeArguments().isEmpty() && |
duke@1 | 2370 | !checkCompatibleAbstracts(pos, l.head, l.head, c)) |
duke@1 | 2371 | return; |
duke@1 | 2372 | for (List<Type> m = supertypes; m != l; m = m.tail) |
duke@1 | 2373 | if (!checkCompatibleAbstracts(pos, l.head, m.head, c)) |
duke@1 | 2374 | return; |
duke@1 | 2375 | } |
duke@1 | 2376 | checkCompatibleConcretes(pos, c); |
duke@1 | 2377 | } |
duke@1 | 2378 | |
mcimadamore@359 | 2379 | void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) { |
mcimadamore@359 | 2380 | for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) { |
mcimadamore@359 | 2381 | for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) { |
mcimadamore@359 | 2382 | // VM allows methods and variables with differing types |
mcimadamore@359 | 2383 | if (sym.kind == e.sym.kind && |
mcimadamore@359 | 2384 | types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) && |
mcimadamore@359 | 2385 | sym != e.sym && |
mcimadamore@359 | 2386 | (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) && |
mcimadamore@608 | 2387 | (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 && |
mcimadamore@359 | 2388 | (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) { |
mcimadamore@359 | 2389 | syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym); |
mcimadamore@359 | 2390 | return; |
mcimadamore@359 | 2391 | } |
mcimadamore@359 | 2392 | } |
mcimadamore@359 | 2393 | } |
mcimadamore@359 | 2394 | } |
mcimadamore@359 | 2395 | |
mcimadamore@780 | 2396 | /** Check that all non-override equivalent methods accessible from 'site' |
mcimadamore@780 | 2397 | * are mutually compatible (JLS 8.4.8/9.4.1). |
mcimadamore@780 | 2398 | * |
mcimadamore@780 | 2399 | * @param pos Position to be used for error reporting. |
mcimadamore@780 | 2400 | * @param site The class whose methods are checked. |
mcimadamore@780 | 2401 | * @param sym The method symbol to be checked. |
mcimadamore@780 | 2402 | */ |
mcimadamore@858 | 2403 | void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) { |
mcimadamore@858 | 2404 | ClashFilter cf = new ClashFilter(site); |
mcimadamore@1198 | 2405 | //for each method m1 that is overridden (directly or indirectly) |
mcimadamore@1198 | 2406 | //by method 'sym' in 'site'... |
mcimadamore@1198 | 2407 | for (Symbol m1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) { |
mcimadamore@1198 | 2408 | if (!sym.overrides(m1, site.tsym, types, false)) continue; |
mcimadamore@1198 | 2409 | //...check each method m2 that is a member of 'site' |
mcimadamore@1198 | 2410 | for (Symbol m2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) { |
mcimadamore@1198 | 2411 | if (m2 == m1) continue; |
mcimadamore@858 | 2412 | //if (i) the signature of 'sym' is not a subsignature of m1 (seen as |
mcimadamore@858 | 2413 | //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error |
mcimadamore@1393 | 2414 | if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) && |
mcimadamore@1198 | 2415 | types.hasSameArgs(m2.erasure(types), m1.erasure(types))) { |
mcimadamore@858 | 2416 | sym.flags_field |= CLASH; |
mcimadamore@1198 | 2417 | String key = m1 == sym ? |
mcimadamore@858 | 2418 | "name.clash.same.erasure.no.override" : |
mcimadamore@858 | 2419 | "name.clash.same.erasure.no.override.1"; |
mcimadamore@858 | 2420 | log.error(pos, |
mcimadamore@858 | 2421 | key, |
mcimadamore@858 | 2422 | sym, sym.location(), |
mcimadamore@1198 | 2423 | m2, m2.location(), |
mcimadamore@1198 | 2424 | m1, m1.location()); |
mcimadamore@858 | 2425 | return; |
mcimadamore@858 | 2426 | } |
mcimadamore@780 | 2427 | } |
mcimadamore@780 | 2428 | } |
mcimadamore@780 | 2429 | } |
mcimadamore@780 | 2430 | |
mcimadamore@877 | 2431 | |
mcimadamore@877 | 2432 | |
mcimadamore@858 | 2433 | /** Check that all static methods accessible from 'site' are |
mcimadamore@858 | 2434 | * mutually compatible (JLS 8.4.8). |
mcimadamore@858 | 2435 | * |
mcimadamore@858 | 2436 | * @param pos Position to be used for error reporting. |
mcimadamore@858 | 2437 | * @param site The class whose methods are checked. |
mcimadamore@858 | 2438 | * @param sym The method symbol to be checked. |
mcimadamore@780 | 2439 | */ |
mcimadamore@858 | 2440 | void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) { |
mcimadamore@780 | 2441 | ClashFilter cf = new ClashFilter(site); |
mcimadamore@858 | 2442 | //for each method m1 that is a member of 'site'... |
mcimadamore@1015 | 2443 | for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) { |
mcimadamore@858 | 2444 | //if (i) the signature of 'sym' is not a subsignature of m1 (seen as |
mcimadamore@858 | 2445 | //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error |
mcimadamore@1393 | 2446 | if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck) && |
mcimadamore@877 | 2447 | types.hasSameArgs(s.erasure(types), sym.erasure(types))) { |
mcimadamore@780 | 2448 | log.error(pos, |
mcimadamore@858 | 2449 | "name.clash.same.erasure.no.hide", |
mcimadamore@858 | 2450 | sym, sym.location(), |
mcimadamore@877 | 2451 | s, s.location()); |
mcimadamore@858 | 2452 | return; |
mcimadamore@858 | 2453 | } |
mcimadamore@858 | 2454 | } |
mcimadamore@858 | 2455 | } |
mcimadamore@780 | 2456 | |
mcimadamore@858 | 2457 | //where |
mcimadamore@858 | 2458 | private class ClashFilter implements Filter<Symbol> { |
mcimadamore@780 | 2459 | |
mcimadamore@858 | 2460 | Type site; |
mcimadamore@780 | 2461 | |
mcimadamore@858 | 2462 | ClashFilter(Type site) { |
mcimadamore@858 | 2463 | this.site = site; |
mcimadamore@858 | 2464 | } |
mcimadamore@858 | 2465 | |
mcimadamore@858 | 2466 | boolean shouldSkip(Symbol s) { |
mcimadamore@858 | 2467 | return (s.flags() & CLASH) != 0 && |
mcimadamore@858 | 2468 | s.owner == site.tsym; |
mcimadamore@858 | 2469 | } |
mcimadamore@858 | 2470 | |
mcimadamore@858 | 2471 | public boolean accepts(Symbol s) { |
mcimadamore@858 | 2472 | return s.kind == MTH && |
mcimadamore@858 | 2473 | (s.flags() & SYNTHETIC) == 0 && |
mcimadamore@858 | 2474 | !shouldSkip(s) && |
mcimadamore@858 | 2475 | s.isInheritedIn(site.tsym, types) && |
mcimadamore@858 | 2476 | !s.isConstructor(); |
mcimadamore@858 | 2477 | } |
mcimadamore@858 | 2478 | } |
mcimadamore@780 | 2479 | |
mcimadamore@1393 | 2480 | void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) { |
mcimadamore@1393 | 2481 | DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site); |
mcimadamore@1393 | 2482 | for (Symbol m : types.membersClosure(site, false).getElements(dcf)) { |
mcimadamore@1393 | 2483 | Assert.check(m.kind == MTH); |
mcimadamore@1393 | 2484 | List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m); |
mcimadamore@1393 | 2485 | if (prov.size() > 1) { |
mcimadamore@1393 | 2486 | ListBuffer<Symbol> abstracts = ListBuffer.lb(); |
mcimadamore@1393 | 2487 | ListBuffer<Symbol> defaults = ListBuffer.lb(); |
mcimadamore@1393 | 2488 | for (MethodSymbol provSym : prov) { |
mcimadamore@1393 | 2489 | if ((provSym.flags() & DEFAULT) != 0) { |
mcimadamore@1393 | 2490 | defaults = defaults.append(provSym); |
mcimadamore@1393 | 2491 | } else if ((provSym.flags() & ABSTRACT) != 0) { |
mcimadamore@1393 | 2492 | abstracts = abstracts.append(provSym); |
mcimadamore@1393 | 2493 | } |
mcimadamore@1393 | 2494 | if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) { |
mcimadamore@1393 | 2495 | //strong semantics - issue an error if two sibling interfaces |
mcimadamore@1393 | 2496 | //have two override-equivalent defaults - or if one is abstract |
mcimadamore@1393 | 2497 | //and the other is default |
mcimadamore@1393 | 2498 | String errKey; |
mcimadamore@1393 | 2499 | Symbol s1 = defaults.first(); |
mcimadamore@1393 | 2500 | Symbol s2; |
mcimadamore@1393 | 2501 | if (defaults.size() > 1) { |
mcimadamore@1393 | 2502 | errKey = "types.incompatible.unrelated.defaults"; |
mcimadamore@1393 | 2503 | s2 = defaults.toList().tail.head; |
mcimadamore@1393 | 2504 | } else { |
mcimadamore@1393 | 2505 | errKey = "types.incompatible.abstract.default"; |
mcimadamore@1393 | 2506 | s2 = abstracts.first(); |
mcimadamore@1393 | 2507 | } |
mcimadamore@1393 | 2508 | log.error(pos, errKey, |
mcimadamore@1393 | 2509 | Kinds.kindName(site.tsym), site, |
mcimadamore@1393 | 2510 | m.name, types.memberType(site, m).getParameterTypes(), |
mcimadamore@1393 | 2511 | s1.location(), s2.location()); |
mcimadamore@1393 | 2512 | break; |
mcimadamore@1393 | 2513 | } |
mcimadamore@1393 | 2514 | } |
mcimadamore@1393 | 2515 | } |
mcimadamore@1393 | 2516 | } |
mcimadamore@1393 | 2517 | } |
mcimadamore@1393 | 2518 | |
mcimadamore@1393 | 2519 | //where |
mcimadamore@1393 | 2520 | private class DefaultMethodClashFilter implements Filter<Symbol> { |
mcimadamore@1393 | 2521 | |
mcimadamore@1393 | 2522 | Type site; |
mcimadamore@1393 | 2523 | |
mcimadamore@1393 | 2524 | DefaultMethodClashFilter(Type site) { |
mcimadamore@1393 | 2525 | this.site = site; |
mcimadamore@1393 | 2526 | } |
mcimadamore@1393 | 2527 | |
mcimadamore@1393 | 2528 | public boolean accepts(Symbol s) { |
mcimadamore@1393 | 2529 | return s.kind == MTH && |
mcimadamore@1393 | 2530 | (s.flags() & DEFAULT) != 0 && |
mcimadamore@1393 | 2531 | s.isInheritedIn(site.tsym, types) && |
mcimadamore@1393 | 2532 | !s.isConstructor(); |
mcimadamore@1393 | 2533 | } |
mcimadamore@1393 | 2534 | } |
mcimadamore@1393 | 2535 | |
mcimadamore@359 | 2536 | /** Report a conflict between a user symbol and a synthetic symbol. |
mcimadamore@359 | 2537 | */ |
mcimadamore@359 | 2538 | private void syntheticError(DiagnosticPosition pos, Symbol sym) { |
mcimadamore@359 | 2539 | if (!sym.type.isErroneous()) { |
mcimadamore@359 | 2540 | if (warnOnSyntheticConflicts) { |
mcimadamore@359 | 2541 | log.warning(pos, "synthetic.name.conflict", sym, sym.location()); |
mcimadamore@359 | 2542 | } |
mcimadamore@359 | 2543 | else { |
mcimadamore@359 | 2544 | log.error(pos, "synthetic.name.conflict", sym, sym.location()); |
mcimadamore@359 | 2545 | } |
mcimadamore@359 | 2546 | } |
mcimadamore@359 | 2547 | } |
mcimadamore@359 | 2548 | |
duke@1 | 2549 | /** Check that class c does not implement directly or indirectly |
duke@1 | 2550 | * the same parameterized interface with two different argument lists. |
duke@1 | 2551 | * @param pos Position to be used for error reporting. |
duke@1 | 2552 | * @param type The type whose interfaces are checked. |
duke@1 | 2553 | */ |
duke@1 | 2554 | void checkClassBounds(DiagnosticPosition pos, Type type) { |
duke@1 | 2555 | checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type); |
duke@1 | 2556 | } |
duke@1 | 2557 | //where |
duke@1 | 2558 | /** Enter all interfaces of type `type' into the hash table `seensofar' |
duke@1 | 2559 | * with their class symbol as key and their type as value. Make |
duke@1 | 2560 | * sure no class is entered with two different types. |
duke@1 | 2561 | */ |
duke@1 | 2562 | void checkClassBounds(DiagnosticPosition pos, |
duke@1 | 2563 | Map<TypeSymbol,Type> seensofar, |
duke@1 | 2564 | Type type) { |
duke@1 | 2565 | if (type.isErroneous()) return; |
duke@1 | 2566 | for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) { |
duke@1 | 2567 | Type it = l.head; |
duke@1 | 2568 | Type oldit = seensofar.put(it.tsym, it); |
duke@1 | 2569 | if (oldit != null) { |
duke@1 | 2570 | List<Type> oldparams = oldit.allparams(); |
duke@1 | 2571 | List<Type> newparams = it.allparams(); |
duke@1 | 2572 | if (!types.containsTypeEquivalent(oldparams, newparams)) |
duke@1 | 2573 | log.error(pos, "cant.inherit.diff.arg", |
duke@1 | 2574 | it.tsym, Type.toString(oldparams), |
duke@1 | 2575 | Type.toString(newparams)); |
duke@1 | 2576 | } |
duke@1 | 2577 | checkClassBounds(pos, seensofar, it); |
duke@1 | 2578 | } |
duke@1 | 2579 | Type st = types.supertype(type); |
duke@1 | 2580 | if (st != null) checkClassBounds(pos, seensofar, st); |
duke@1 | 2581 | } |
duke@1 | 2582 | |
duke@1 | 2583 | /** Enter interface into into set. |
duke@1 | 2584 | * If it existed already, issue a "repeated interface" error. |
duke@1 | 2585 | */ |
duke@1 | 2586 | void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) { |
duke@1 | 2587 | if (its.contains(it)) |
duke@1 | 2588 | log.error(pos, "repeated.interface"); |
duke@1 | 2589 | else { |
duke@1 | 2590 | its.add(it); |
duke@1 | 2591 | } |
duke@1 | 2592 | } |
duke@1 | 2593 | |
duke@1 | 2594 | /* ************************************************************************* |
duke@1 | 2595 | * Check annotations |
duke@1 | 2596 | **************************************************************************/ |
duke@1 | 2597 | |
mcimadamore@629 | 2598 | /** |
mcimadamore@634 | 2599 | * Recursively validate annotations values |
mcimadamore@629 | 2600 | */ |
mcimadamore@634 | 2601 | void validateAnnotationTree(JCTree tree) { |
mcimadamore@634 | 2602 | class AnnotationValidator extends TreeScanner { |
mcimadamore@629 | 2603 | @Override |
mcimadamore@629 | 2604 | public void visitAnnotation(JCAnnotation tree) { |
jjg@1017 | 2605 | if (!tree.type.isErroneous()) { |
jjg@1017 | 2606 | super.visitAnnotation(tree); |
jjg@1017 | 2607 | validateAnnotation(tree); |
jjg@1017 | 2608 | } |
mcimadamore@629 | 2609 | } |
mcimadamore@629 | 2610 | } |
mcimadamore@634 | 2611 | tree.accept(new AnnotationValidator()); |
mcimadamore@629 | 2612 | } |
mcimadamore@629 | 2613 | |
jjg@1326 | 2614 | /** |
jjg@1326 | 2615 | * {@literal |
jjg@1326 | 2616 | * Annotation types are restricted to primitives, String, an |
duke@1 | 2617 | * enum, an annotation, Class, Class<?>, Class<? extends |
duke@1 | 2618 | * Anything>, arrays of the preceding. |
jjg@1326 | 2619 | * } |
duke@1 | 2620 | */ |
duke@1 | 2621 | void validateAnnotationType(JCTree restype) { |
duke@1 | 2622 | // restype may be null if an error occurred, so don't bother validating it |
duke@1 | 2623 | if (restype != null) { |
duke@1 | 2624 | validateAnnotationType(restype.pos(), restype.type); |
duke@1 | 2625 | } |
duke@1 | 2626 | } |
duke@1 | 2627 | |
duke@1 | 2628 | void validateAnnotationType(DiagnosticPosition pos, Type type) { |
duke@1 | 2629 | if (type.isPrimitive()) return; |
duke@1 | 2630 | if (types.isSameType(type, syms.stringType)) return; |
duke@1 | 2631 | if ((type.tsym.flags() & Flags.ENUM) != 0) return; |
duke@1 | 2632 | if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return; |
duke@1 | 2633 | if (types.lowerBound(type).tsym == syms.classType.tsym) return; |
duke@1 | 2634 | if (types.isArray(type) && !types.isArray(types.elemtype(type))) { |
duke@1 | 2635 | validateAnnotationType(pos, types.elemtype(type)); |
duke@1 | 2636 | return; |
duke@1 | 2637 | } |
duke@1 | 2638 | log.error(pos, "invalid.annotation.member.type"); |
duke@1 | 2639 | } |
duke@1 | 2640 | |
duke@1 | 2641 | /** |
duke@1 | 2642 | * "It is also a compile-time error if any method declared in an |
duke@1 | 2643 | * annotation type has a signature that is override-equivalent to |
duke@1 | 2644 | * that of any public or protected method declared in class Object |
duke@1 | 2645 | * or in the interface annotation.Annotation." |
duke@1 | 2646 | * |
jjh@972 | 2647 | * @jls 9.6 Annotation Types |
duke@1 | 2648 | */ |
duke@1 | 2649 | void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) { |
jjg@1374 | 2650 | for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) { |
duke@1 | 2651 | Scope s = sup.tsym.members(); |
duke@1 | 2652 | for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) { |
duke@1 | 2653 | if (e.sym.kind == MTH && |
duke@1 | 2654 | (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 && |
duke@1 | 2655 | types.overrideEquivalent(m.type, e.sym.type)) |
duke@1 | 2656 | log.error(pos, "intf.annotation.member.clash", e.sym, sup); |
duke@1 | 2657 | } |
duke@1 | 2658 | } |
duke@1 | 2659 | } |
duke@1 | 2660 | |
duke@1 | 2661 | /** Check the annotations of a symbol. |
duke@1 | 2662 | */ |
duke@1 | 2663 | public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) { |
duke@1 | 2664 | for (JCAnnotation a : annotations) |
duke@1 | 2665 | validateAnnotation(a, s); |
duke@1 | 2666 | } |
duke@1 | 2667 | |
jjg@1521 | 2668 | /** Check the type annotations. |
jjg@1521 | 2669 | */ |
jjg@1521 | 2670 | public void validateTypeAnnotations(List<JCAnnotation> annotations, boolean isTypeParameter) { |
jjg@1521 | 2671 | for (JCAnnotation a : annotations) |
jjg@1521 | 2672 | validateTypeAnnotation(a, isTypeParameter); |
jjg@1521 | 2673 | } |
jjg@1521 | 2674 | |
duke@1 | 2675 | /** Check an annotation of a symbol. |
duke@1 | 2676 | */ |
jfranck@1313 | 2677 | private void validateAnnotation(JCAnnotation a, Symbol s) { |
mcimadamore@634 | 2678 | validateAnnotationTree(a); |
duke@1 | 2679 | |
duke@1 | 2680 | if (!annotationApplicable(a, s)) |
duke@1 | 2681 | log.error(a.pos(), "annotation.type.not.applicable"); |
duke@1 | 2682 | |
duke@1 | 2683 | if (a.annotationType.type.tsym == syms.overrideType.tsym) { |
duke@1 | 2684 | if (!isOverrider(s)) |
duke@1 | 2685 | log.error(a.pos(), "method.does.not.override.superclass"); |
duke@1 | 2686 | } |
mcimadamore@1497 | 2687 | |
mcimadamore@1497 | 2688 | if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) { |
mcimadamore@1497 | 2689 | if (s.kind != TYP) { |
mcimadamore@1497 | 2690 | log.error(a.pos(), "bad.functional.intf.anno"); |
mcimadamore@1497 | 2691 | } else { |
mcimadamore@1497 | 2692 | try { |
mcimadamore@1497 | 2693 | types.findDescriptorSymbol((TypeSymbol)s); |
mcimadamore@1497 | 2694 | } catch (Types.FunctionDescriptorLookupError ex) { |
mcimadamore@1497 | 2695 | log.error(a.pos(), "bad.functional.intf.anno.1", ex.getDiagnostic()); |
mcimadamore@1497 | 2696 | } |
mcimadamore@1497 | 2697 | } |
mcimadamore@1497 | 2698 | } |
duke@1 | 2699 | } |
duke@1 | 2700 | |
jjg@1521 | 2701 | public void validateTypeAnnotation(JCAnnotation a, boolean isTypeParameter) { |
jjg@1521 | 2702 | Assert.checkNonNull(a.type, "annotation tree hasn't been attributed yet: " + a); |
jjg@1521 | 2703 | validateAnnotationTree(a); |
jjg@1521 | 2704 | |
jjg@1521 | 2705 | if (!isTypeAnnotation(a, isTypeParameter)) |
jjg@1521 | 2706 | log.error(a.pos(), "annotation.type.not.applicable"); |
jjg@1521 | 2707 | } |
jjg@1521 | 2708 | |
jfranck@1313 | 2709 | /** |
jjg@1492 | 2710 | * Validate the proposed container 'repeatable' on the |
jfranck@1313 | 2711 | * annotation type symbol 's'. Report errors at position |
jfranck@1313 | 2712 | * 'pos'. |
jfranck@1313 | 2713 | * |
jjg@1492 | 2714 | * @param s The (annotation)type declaration annotated with a @Repeatable |
jjg@1492 | 2715 | * @param repeatable the @Repeatable on 's' |
jfranck@1313 | 2716 | * @param pos where to report errors |
jfranck@1313 | 2717 | */ |
jjg@1492 | 2718 | public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) { |
jjg@1492 | 2719 | Assert.check(types.isSameType(repeatable.type, syms.repeatableType)); |
jfranck@1313 | 2720 | |
jfranck@1313 | 2721 | Type t = null; |
jjg@1492 | 2722 | List<Pair<MethodSymbol,Attribute>> l = repeatable.values; |
jfranck@1313 | 2723 | if (!l.isEmpty()) { |
jfranck@1313 | 2724 | Assert.check(l.head.fst.name == names.value); |
jfranck@1313 | 2725 | t = ((Attribute.Class)l.head.snd).getValue(); |
jfranck@1313 | 2726 | } |
jfranck@1313 | 2727 | |
jfranck@1313 | 2728 | if (t == null) { |
jjg@1492 | 2729 | // errors should already have been reported during Annotate |
jfranck@1313 | 2730 | return; |
jfranck@1313 | 2731 | } |
jfranck@1313 | 2732 | |
jjg@1492 | 2733 | validateValue(t.tsym, s, pos); |
jfranck@1313 | 2734 | validateRetention(t.tsym, s, pos); |
jfranck@1313 | 2735 | validateDocumented(t.tsym, s, pos); |
jfranck@1313 | 2736 | validateInherited(t.tsym, s, pos); |
jfranck@1313 | 2737 | validateTarget(t.tsym, s, pos); |
jfranck@1344 | 2738 | validateDefault(t.tsym, s, pos); |
jfranck@1313 | 2739 | } |
jfranck@1313 | 2740 | |
jjg@1492 | 2741 | private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) { |
jjg@1492 | 2742 | Scope.Entry e = container.members().lookup(names.value); |
jjg@1492 | 2743 | if (e.scope != null && e.sym.kind == MTH) { |
jjg@1492 | 2744 | MethodSymbol m = (MethodSymbol) e.sym; |
jjg@1492 | 2745 | Type ret = m.getReturnType(); |
jjg@1492 | 2746 | if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) { |
jjg@1492 | 2747 | log.error(pos, "invalid.repeatable.annotation.value.return", |
jjg@1492 | 2748 | container, ret, types.makeArrayType(contained.type)); |
jjg@1492 | 2749 | } |
jjg@1492 | 2750 | } else { |
jjg@1492 | 2751 | log.error(pos, "invalid.repeatable.annotation.no.value", container); |
jfranck@1313 | 2752 | } |
jfranck@1313 | 2753 | } |
jfranck@1313 | 2754 | |
jfranck@1313 | 2755 | private void validateRetention(Symbol container, Symbol contained, DiagnosticPosition pos) { |
jfranck@1313 | 2756 | Attribute.RetentionPolicy containerRetention = types.getRetention(container); |
jfranck@1313 | 2757 | Attribute.RetentionPolicy containedRetention = types.getRetention(contained); |
jfranck@1313 | 2758 | |
jfranck@1313 | 2759 | boolean error = false; |
jfranck@1313 | 2760 | switch (containedRetention) { |
jfranck@1313 | 2761 | case RUNTIME: |
jfranck@1313 | 2762 | if (containerRetention != Attribute.RetentionPolicy.RUNTIME) { |
jfranck@1313 | 2763 | error = true; |
jfranck@1313 | 2764 | } |
jfranck@1313 | 2765 | break; |
jfranck@1313 | 2766 | case CLASS: |
jfranck@1313 | 2767 | if (containerRetention == Attribute.RetentionPolicy.SOURCE) { |
jfranck@1313 | 2768 | error = true; |
jfranck@1313 | 2769 | } |
jfranck@1313 | 2770 | } |
jfranck@1313 | 2771 | if (error ) { |
jjg@1492 | 2772 | log.error(pos, "invalid.repeatable.annotation.retention", |
jfranck@1313 | 2773 | container, containerRetention, |
jfranck@1313 | 2774 | contained, containedRetention); |
jfranck@1313 | 2775 | } |
jfranck@1313 | 2776 | } |
jfranck@1313 | 2777 | |
jfranck@1313 | 2778 | private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) { |
jfranck@1313 | 2779 | if (contained.attribute(syms.documentedType.tsym) != null) { |
jfranck@1313 | 2780 | if (container.attribute(syms.documentedType.tsym) == null) { |
jjg@1492 | 2781 | log.error(pos, "invalid.repeatable.annotation.not.documented", container, contained); |
jfranck@1313 | 2782 | } |
jfranck@1313 | 2783 | } |
jfranck@1313 | 2784 | } |
jfranck@1313 | 2785 | |
jfranck@1313 | 2786 | private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) { |
jfranck@1313 | 2787 | if (contained.attribute(syms.inheritedType.tsym) != null) { |
jfranck@1313 | 2788 | if (container.attribute(syms.inheritedType.tsym) == null) { |
jjg@1492 | 2789 | log.error(pos, "invalid.repeatable.annotation.not.inherited", container, contained); |
jfranck@1313 | 2790 | } |
jfranck@1313 | 2791 | } |
jfranck@1313 | 2792 | } |
jfranck@1313 | 2793 | |
jfranck@1313 | 2794 | private void validateTarget(Symbol container, Symbol contained, DiagnosticPosition pos) { |
jfranck@1634 | 2795 | // The set of targets the container is applicable to must be a subset |
jfranck@1634 | 2796 | // (with respect to annotation target semantics) of the set of targets |
jfranck@1634 | 2797 | // the contained is applicable to. The target sets may be implicit or |
jfranck@1634 | 2798 | // explicit. |
jfranck@1634 | 2799 | |
jfranck@1634 | 2800 | Set<Name> containerTargets; |
jfranck@1313 | 2801 | Attribute.Array containerTarget = getAttributeTargetAttribute(container); |
jfranck@1313 | 2802 | if (containerTarget == null) { |
jfranck@1634 | 2803 | containerTargets = getDefaultTargetSet(); |
jfranck@1634 | 2804 | } else { |
jfranck@1634 | 2805 | containerTargets = new HashSet<Name>(); |
jfranck@1313 | 2806 | for (Attribute app : containerTarget.values) { |
jfranck@1313 | 2807 | if (!(app instanceof Attribute.Enum)) { |
jfranck@1313 | 2808 | continue; // recovery |
jfranck@1313 | 2809 | } |
jfranck@1313 | 2810 | Attribute.Enum e = (Attribute.Enum)app; |
jfranck@1313 | 2811 | containerTargets.add(e.value.name); |
jfranck@1313 | 2812 | } |
jfranck@1634 | 2813 | } |
jfranck@1634 | 2814 | |
jfranck@1634 | 2815 | Set<Name> containedTargets; |
jfranck@1634 | 2816 | Attribute.Array containedTarget = getAttributeTargetAttribute(contained); |
jfranck@1634 | 2817 | if (containedTarget == null) { |
jfranck@1634 | 2818 | containedTargets = getDefaultTargetSet(); |
jfranck@1634 | 2819 | } else { |
jfranck@1634 | 2820 | containedTargets = new HashSet<Name>(); |
jfranck@1313 | 2821 | for (Attribute app : containedTarget.values) { |
jfranck@1313 | 2822 | if (!(app instanceof Attribute.Enum)) { |
jfranck@1313 | 2823 | continue; // recovery |
jfranck@1313 | 2824 | } |
jfranck@1313 | 2825 | Attribute.Enum e = (Attribute.Enum)app; |
jfranck@1313 | 2826 | containedTargets.add(e.value.name); |
jfranck@1313 | 2827 | } |
jfranck@1634 | 2828 | } |
jfranck@1634 | 2829 | |
jfranck@1634 | 2830 | if (!isTargetSubsetOf(containerTargets, containedTargets)) { |
jjg@1492 | 2831 | log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained); |
jfranck@1313 | 2832 | } |
jfranck@1313 | 2833 | } |
jfranck@1313 | 2834 | |
jfranck@1634 | 2835 | /* get a set of names for the default target */ |
jfranck@1634 | 2836 | private Set<Name> getDefaultTargetSet() { |
jfranck@1634 | 2837 | if (defaultTargets == null) { |
jfranck@1634 | 2838 | Set<Name> targets = new HashSet<Name>(); |
jfranck@1634 | 2839 | targets.add(names.ANNOTATION_TYPE); |
jfranck@1634 | 2840 | targets.add(names.CONSTRUCTOR); |
jfranck@1634 | 2841 | targets.add(names.FIELD); |
jfranck@1634 | 2842 | targets.add(names.LOCAL_VARIABLE); |
jfranck@1634 | 2843 | targets.add(names.METHOD); |
jfranck@1634 | 2844 | targets.add(names.PACKAGE); |
jfranck@1634 | 2845 | targets.add(names.PARAMETER); |
jfranck@1634 | 2846 | targets.add(names.TYPE); |
jfranck@1634 | 2847 | |
jfranck@1634 | 2848 | defaultTargets = java.util.Collections.unmodifiableSet(targets); |
jfranck@1634 | 2849 | } |
jfranck@1634 | 2850 | |
jfranck@1634 | 2851 | return defaultTargets; |
jfranck@1634 | 2852 | } |
jfranck@1634 | 2853 | private Set<Name> defaultTargets; |
jfranck@1634 | 2854 | |
jfranck@1634 | 2855 | |
jfranck@1634 | 2856 | /** Checks that s is a subset of t, with respect to ElementType |
jfranck@1313 | 2857 | * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE} |
jfranck@1313 | 2858 | */ |
jfranck@1634 | 2859 | private boolean isTargetSubsetOf(Set<Name> s, Set<Name> t) { |
jfranck@1634 | 2860 | // Check that all elements in s are present in t |
jfranck@1634 | 2861 | for (Name n2 : s) { |
jfranck@1313 | 2862 | boolean currentElementOk = false; |
jfranck@1634 | 2863 | for (Name n1 : t) { |
jfranck@1313 | 2864 | if (n1 == n2) { |
jfranck@1313 | 2865 | currentElementOk = true; |
jfranck@1313 | 2866 | break; |
jfranck@1313 | 2867 | } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) { |
jfranck@1313 | 2868 | currentElementOk = true; |
jfranck@1313 | 2869 | break; |
jfranck@1313 | 2870 | } |
jfranck@1313 | 2871 | } |
jfranck@1313 | 2872 | if (!currentElementOk) |
jfranck@1313 | 2873 | return false; |
jfranck@1313 | 2874 | } |
jfranck@1313 | 2875 | return true; |
jfranck@1313 | 2876 | } |
jfranck@1313 | 2877 | |
jfranck@1344 | 2878 | private void validateDefault(Symbol container, Symbol contained, DiagnosticPosition pos) { |
jfranck@1344 | 2879 | // validate that all other elements of containing type has defaults |
jfranck@1344 | 2880 | Scope scope = container.members(); |
jfranck@1344 | 2881 | for(Symbol elm : scope.getElements()) { |
jfranck@1344 | 2882 | if (elm.name != names.value && |
jfranck@1344 | 2883 | elm.kind == Kinds.MTH && |
jfranck@1344 | 2884 | ((MethodSymbol)elm).defaultValue == null) { |
jfranck@1344 | 2885 | log.error(pos, |
jjg@1492 | 2886 | "invalid.repeatable.annotation.elem.nondefault", |
jfranck@1344 | 2887 | container, |
jfranck@1344 | 2888 | elm); |
jfranck@1344 | 2889 | } |
jfranck@1344 | 2890 | } |
jfranck@1344 | 2891 | } |
jfranck@1344 | 2892 | |
duke@1 | 2893 | /** Is s a method symbol that overrides a method in a superclass? */ |
duke@1 | 2894 | boolean isOverrider(Symbol s) { |
duke@1 | 2895 | if (s.kind != MTH || s.isStatic()) |
duke@1 | 2896 | return false; |
duke@1 | 2897 | MethodSymbol m = (MethodSymbol)s; |
duke@1 | 2898 | TypeSymbol owner = (TypeSymbol)m.owner; |
duke@1 | 2899 | for (Type sup : types.closure(owner.type)) { |
duke@1 | 2900 | if (sup == owner.type) |
duke@1 | 2901 | continue; // skip "this" |
duke@1 | 2902 | Scope scope = sup.tsym.members(); |
duke@1 | 2903 | for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) { |
duke@1 | 2904 | if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true)) |
duke@1 | 2905 | return true; |
duke@1 | 2906 | } |
duke@1 | 2907 | } |
duke@1 | 2908 | return false; |
duke@1 | 2909 | } |
duke@1 | 2910 | |
jjg@1521 | 2911 | /** Is the annotation applicable to type annotations? */ |
jjg@1521 | 2912 | protected boolean isTypeAnnotation(JCAnnotation a, boolean isTypeParameter) { |
jjg@1521 | 2913 | Attribute.Compound atTarget = |
jjg@1521 | 2914 | a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym); |
jjg@1521 | 2915 | if (atTarget == null) { |
jjg@1521 | 2916 | // An annotation without @Target is not a type annotation. |
jjg@1521 | 2917 | return false; |
jjg@1521 | 2918 | } |
jjg@1521 | 2919 | |
jjg@1521 | 2920 | Attribute atValue = atTarget.member(names.value); |
jjg@1521 | 2921 | if (!(atValue instanceof Attribute.Array)) { |
jjg@1521 | 2922 | return false; // error recovery |
jjg@1521 | 2923 | } |
jjg@1521 | 2924 | |
jjg@1521 | 2925 | Attribute.Array arr = (Attribute.Array) atValue; |
jjg@1521 | 2926 | for (Attribute app : arr.values) { |
jjg@1521 | 2927 | if (!(app instanceof Attribute.Enum)) { |
jjg@1521 | 2928 | return false; // recovery |
jjg@1521 | 2929 | } |
jjg@1521 | 2930 | Attribute.Enum e = (Attribute.Enum) app; |
jjg@1521 | 2931 | |
jjg@1521 | 2932 | if (e.value.name == names.TYPE_USE) |
jjg@1521 | 2933 | return true; |
jjg@1521 | 2934 | else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER) |
jjg@1521 | 2935 | return true; |
jjg@1521 | 2936 | } |
jjg@1521 | 2937 | return false; |
jjg@1521 | 2938 | } |
jjg@1521 | 2939 | |
duke@1 | 2940 | /** Is the annotation applicable to the symbol? */ |
duke@1 | 2941 | boolean annotationApplicable(JCAnnotation a, Symbol s) { |
jfranck@1313 | 2942 | Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym); |
jjg@1521 | 2943 | Name[] targets; |
jjg@1521 | 2944 | |
jfranck@1313 | 2945 | if (arr == null) { |
jjg@1521 | 2946 | targets = defaultTargetMetaInfo(a, s); |
jjg@1521 | 2947 | } else { |
jjg@1521 | 2948 | // TODO: can we optimize this? |
jjg@1521 | 2949 | targets = new Name[arr.values.length]; |
jjg@1521 | 2950 | for (int i=0; i<arr.values.length; ++i) { |
jjg@1521 | 2951 | Attribute app = arr.values[i]; |
jjg@1521 | 2952 | if (!(app instanceof Attribute.Enum)) { |
jjg@1521 | 2953 | return true; // recovery |
jjg@1521 | 2954 | } |
jjg@1521 | 2955 | Attribute.Enum e = (Attribute.Enum) app; |
jjg@1521 | 2956 | targets[i] = e.value.name; |
jjg@1521 | 2957 | } |
jfranck@1313 | 2958 | } |
jjg@1521 | 2959 | for (Name target : targets) { |
jjg@1521 | 2960 | if (target == names.TYPE) |
duke@1 | 2961 | { if (s.kind == TYP) return true; } |
jjg@1521 | 2962 | else if (target == names.FIELD) |
duke@1 | 2963 | { if (s.kind == VAR && s.owner.kind != MTH) return true; } |
jjg@1521 | 2964 | else if (target == names.METHOD) |
duke@1 | 2965 | { if (s.kind == MTH && !s.isConstructor()) return true; } |
jjg@1521 | 2966 | else if (target == names.PARAMETER) |
duke@1 | 2967 | { if (s.kind == VAR && |
duke@1 | 2968 | s.owner.kind == MTH && |
duke@1 | 2969 | (s.flags() & PARAMETER) != 0) |
duke@1 | 2970 | return true; |
duke@1 | 2971 | } |
jjg@1521 | 2972 | else if (target == names.CONSTRUCTOR) |
duke@1 | 2973 | { if (s.kind == MTH && s.isConstructor()) return true; } |
jjg@1521 | 2974 | else if (target == names.LOCAL_VARIABLE) |
duke@1 | 2975 | { if (s.kind == VAR && s.owner.kind == MTH && |
duke@1 | 2976 | (s.flags() & PARAMETER) == 0) |
duke@1 | 2977 | return true; |
duke@1 | 2978 | } |
jjg@1521 | 2979 | else if (target == names.ANNOTATION_TYPE) |
duke@1 | 2980 | { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0) |
duke@1 | 2981 | return true; |
duke@1 | 2982 | } |
jjg@1521 | 2983 | else if (target == names.PACKAGE) |
duke@1 | 2984 | { if (s.kind == PCK) return true; } |
jjg@1521 | 2985 | else if (target == names.TYPE_USE) |
jjg@308 | 2986 | { if (s.kind == TYP || |
jjg@308 | 2987 | s.kind == VAR || |
jjg@308 | 2988 | (s.kind == MTH && !s.isConstructor() && |
jjg@1521 | 2989 | !s.type.getReturnType().hasTag(VOID)) || |
jjg@1521 | 2990 | (s.kind == MTH && s.isConstructor())) |
jjg@1521 | 2991 | return true; |
jjg@1521 | 2992 | } |
jjg@1521 | 2993 | else if (target == names.TYPE_PARAMETER) |
jjg@1521 | 2994 | { if (s.kind == TYP && s.type.hasTag(TYPEVAR)) |
jjg@308 | 2995 | return true; |
jjg@308 | 2996 | } |
duke@1 | 2997 | else |
duke@1 | 2998 | return true; // recovery |
duke@1 | 2999 | } |
duke@1 | 3000 | return false; |
duke@1 | 3001 | } |
duke@1 | 3002 | |
jfranck@1313 | 3003 | |
jfranck@1313 | 3004 | Attribute.Array getAttributeTargetAttribute(Symbol s) { |
jfranck@1313 | 3005 | Attribute.Compound atTarget = |
jfranck@1313 | 3006 | s.attribute(syms.annotationTargetType.tsym); |
jfranck@1313 | 3007 | if (atTarget == null) return null; // ok, is applicable |
jfranck@1313 | 3008 | Attribute atValue = atTarget.member(names.value); |
jfranck@1313 | 3009 | if (!(atValue instanceof Attribute.Array)) return null; // error recovery |
jfranck@1313 | 3010 | return (Attribute.Array) atValue; |
jfranck@1313 | 3011 | } |
jfranck@1313 | 3012 | |
jjg@1521 | 3013 | private final Name[] dfltTargetMeta; |
jjg@1521 | 3014 | private Name[] defaultTargetMetaInfo(JCAnnotation a, Symbol s) { |
jjg@1521 | 3015 | return dfltTargetMeta; |
jjg@1521 | 3016 | } |
jjg@1521 | 3017 | |
duke@1 | 3018 | /** Check an annotation value. |
jfranck@1445 | 3019 | * |
jfranck@1445 | 3020 | * @param a The annotation tree to check |
jfranck@1445 | 3021 | * @return true if this annotation tree is valid, otherwise false |
duke@1 | 3022 | */ |
jfranck@1445 | 3023 | public boolean validateAnnotationDeferErrors(JCAnnotation a) { |
jfranck@1445 | 3024 | boolean res = false; |
jfranck@1445 | 3025 | final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log); |
jfranck@1445 | 3026 | try { |
jfranck@1445 | 3027 | res = validateAnnotation(a); |
jfranck@1445 | 3028 | } finally { |
jfranck@1445 | 3029 | log.popDiagnosticHandler(diagHandler); |
jfranck@1445 | 3030 | } |
jfranck@1445 | 3031 | return res; |
jfranck@1445 | 3032 | } |
jfranck@1445 | 3033 | |
jfranck@1445 | 3034 | private boolean validateAnnotation(JCAnnotation a) { |
jfranck@1445 | 3035 | boolean isValid = true; |
jfranck@1445 | 3036 | // collect an inventory of the annotation elements |
jfranck@1445 | 3037 | Set<MethodSymbol> members = new LinkedHashSet<MethodSymbol>(); |
duke@1 | 3038 | for (Scope.Entry e = a.annotationType.type.tsym.members().elems; |
jfranck@1729 | 3039 | e != null; |
jfranck@1729 | 3040 | e = e.sibling) |
jfranck@1729 | 3041 | if (e.sym.kind == MTH && e.sym.name != names.clinit) |
duke@1 | 3042 | members.add((MethodSymbol) e.sym); |
duke@1 | 3043 | |
jfranck@1445 | 3044 | // remove the ones that are assigned values |
duke@1 | 3045 | for (JCTree arg : a.args) { |
jjg@1127 | 3046 | if (!arg.hasTag(ASSIGN)) continue; // recovery |
duke@1 | 3047 | JCAssign assign = (JCAssign) arg; |
duke@1 | 3048 | Symbol m = TreeInfo.symbol(assign.lhs); |
duke@1 | 3049 | if (m == null || m.type.isErroneous()) continue; |
jfranck@1445 | 3050 | if (!members.remove(m)) { |
jfranck@1445 | 3051 | isValid = false; |
jjg@479 | 3052 | log.error(assign.lhs.pos(), "duplicate.annotation.member.value", |
duke@1 | 3053 | m.name, a.type); |
jfranck@1445 | 3054 | } |
duke@1 | 3055 | } |
duke@1 | 3056 | |
duke@1 | 3057 | // all the remaining ones better have default values |
jfranck@1445 | 3058 | List<Name> missingDefaults = List.nil(); |
mcimadamore@632 | 3059 | for (MethodSymbol m : members) { |
mcimadamore@632 | 3060 | if (m.defaultValue == null && !m.type.isErroneous()) { |
jfranck@1445 | 3061 | missingDefaults = missingDefaults.append(m.name); |
mcimadamore@632 | 3062 | } |
mcimadamore@632 | 3063 | } |
jfranck@1445 | 3064 | missingDefaults = missingDefaults.reverse(); |
mcimadamore@632 | 3065 | if (missingDefaults.nonEmpty()) { |
jfranck@1445 | 3066 | isValid = false; |
mcimadamore@632 | 3067 | String key = (missingDefaults.size() > 1) |
mcimadamore@632 | 3068 | ? "annotation.missing.default.value.1" |
mcimadamore@632 | 3069 | : "annotation.missing.default.value"; |
mcimadamore@632 | 3070 | log.error(a.pos(), key, a.type, missingDefaults); |
mcimadamore@632 | 3071 | } |
duke@1 | 3072 | |
duke@1 | 3073 | // special case: java.lang.annotation.Target must not have |
duke@1 | 3074 | // repeated values in its value member |
duke@1 | 3075 | if (a.annotationType.type.tsym != syms.annotationTargetType.tsym || |
duke@1 | 3076 | a.args.tail == null) |
jfranck@1445 | 3077 | return isValid; |
duke@1 | 3078 | |
jfranck@1445 | 3079 | if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery |
duke@1 | 3080 | JCAssign assign = (JCAssign) a.args.head; |
duke@1 | 3081 | Symbol m = TreeInfo.symbol(assign.lhs); |
jfranck@1445 | 3082 | if (m.name != names.value) return false; |
duke@1 | 3083 | JCTree rhs = assign.rhs; |
jfranck@1445 | 3084 | if (!rhs.hasTag(NEWARRAY)) return false; |
duke@1 | 3085 | JCNewArray na = (JCNewArray) rhs; |
duke@1 | 3086 | Set<Symbol> targets = new HashSet<Symbol>(); |
duke@1 | 3087 | for (JCTree elem : na.elems) { |
duke@1 | 3088 | if (!targets.add(TreeInfo.symbol(elem))) { |
jfranck@1445 | 3089 | isValid = false; |
duke@1 | 3090 | log.error(elem.pos(), "repeated.annotation.target"); |
duke@1 | 3091 | } |
duke@1 | 3092 | } |
jfranck@1445 | 3093 | return isValid; |
duke@1 | 3094 | } |
duke@1 | 3095 | |
duke@1 | 3096 | void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) { |
duke@1 | 3097 | if (allowAnnotations && |
mcimadamore@795 | 3098 | lint.isEnabled(LintCategory.DEP_ANN) && |
duke@1 | 3099 | (s.flags() & DEPRECATED) != 0 && |
duke@1 | 3100 | !syms.deprecatedType.isErroneous() && |
duke@1 | 3101 | s.attribute(syms.deprecatedType.tsym) == null) { |
mcimadamore@795 | 3102 | log.warning(LintCategory.DEP_ANN, |
jjg@612 | 3103 | pos, "missing.deprecated.annotation"); |
duke@1 | 3104 | } |
duke@1 | 3105 | } |
duke@1 | 3106 | |
mcimadamore@852 | 3107 | void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) { |
mcimadamore@852 | 3108 | if ((s.flags() & DEPRECATED) != 0 && |
mcimadamore@852 | 3109 | (other.flags() & DEPRECATED) == 0 && |
mcimadamore@852 | 3110 | s.outermostClass() != other.outermostClass()) { |
mcimadamore@852 | 3111 | deferredLintHandler.report(new DeferredLintHandler.LintLogger() { |
mcimadamore@852 | 3112 | @Override |
mcimadamore@852 | 3113 | public void report() { |
mcimadamore@852 | 3114 | warnDeprecated(pos, s); |
mcimadamore@852 | 3115 | } |
mcimadamore@852 | 3116 | }); |
jjg@1157 | 3117 | } |
mcimadamore@852 | 3118 | } |
mcimadamore@852 | 3119 | |
mcimadamore@852 | 3120 | void checkSunAPI(final DiagnosticPosition pos, final Symbol s) { |
mcimadamore@852 | 3121 | if ((s.flags() & PROPRIETARY) != 0) { |
mcimadamore@852 | 3122 | deferredLintHandler.report(new DeferredLintHandler.LintLogger() { |
mcimadamore@852 | 3123 | public void report() { |
mcimadamore@852 | 3124 | if (enableSunApiLintControl) |
mcimadamore@852 | 3125 | warnSunApi(pos, "sun.proprietary", s); |
mcimadamore@852 | 3126 | else |
mcimadamore@1218 | 3127 | log.mandatoryWarning(pos, "sun.proprietary", s); |
mcimadamore@852 | 3128 | } |
mcimadamore@852 | 3129 | }); |
mcimadamore@852 | 3130 | } |
mcimadamore@852 | 3131 | } |
mcimadamore@852 | 3132 | |
jjg@1569 | 3133 | void checkProfile(final DiagnosticPosition pos, final Symbol s) { |
jjg@1569 | 3134 | if (profile != Profile.DEFAULT && (s.flags() & NOT_IN_PROFILE) != 0) { |
jjg@1569 | 3135 | log.error(pos, "not.in.profile", s, profile); |
jjg@1569 | 3136 | } |
jjg@1569 | 3137 | } |
jjg@1569 | 3138 | |
duke@1 | 3139 | /* ************************************************************************* |
duke@1 | 3140 | * Check for recursive annotation elements. |
duke@1 | 3141 | **************************************************************************/ |
duke@1 | 3142 | |
duke@1 | 3143 | /** Check for cycles in the graph of annotation elements. |
duke@1 | 3144 | */ |
duke@1 | 3145 | void checkNonCyclicElements(JCClassDecl tree) { |
duke@1 | 3146 | if ((tree.sym.flags_field & ANNOTATION) == 0) return; |
jjg@816 | 3147 | Assert.check((tree.sym.flags_field & LOCKED) == 0); |
duke@1 | 3148 | try { |
duke@1 | 3149 | tree.sym.flags_field |= LOCKED; |
duke@1 | 3150 | for (JCTree def : tree.defs) { |
jjg@1127 | 3151 | if (!def.hasTag(METHODDEF)) continue; |
duke@1 | 3152 | JCMethodDecl meth = (JCMethodDecl)def; |
duke@1 | 3153 | checkAnnotationResType(meth.pos(), meth.restype.type); |
duke@1 | 3154 | } |
duke@1 | 3155 | } finally { |
duke@1 | 3156 | tree.sym.flags_field &= ~LOCKED; |
duke@1 | 3157 | tree.sym.flags_field |= ACYCLIC_ANN; |
duke@1 | 3158 | } |
duke@1 | 3159 | } |
duke@1 | 3160 | |
duke@1 | 3161 | void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) { |
duke@1 | 3162 | if ((tsym.flags_field & ACYCLIC_ANN) != 0) |
duke@1 | 3163 | return; |
duke@1 | 3164 | if ((tsym.flags_field & LOCKED) != 0) { |
duke@1 | 3165 | log.error(pos, "cyclic.annotation.element"); |
duke@1 | 3166 | return; |
duke@1 | 3167 | } |
duke@1 | 3168 | try { |
duke@1 | 3169 | tsym.flags_field |= LOCKED; |
duke@1 | 3170 | for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) { |
duke@1 | 3171 | Symbol s = e.sym; |
duke@1 | 3172 | if (s.kind != Kinds.MTH) |
duke@1 | 3173 | continue; |
duke@1 | 3174 | checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType()); |
duke@1 | 3175 | } |
duke@1 | 3176 | } finally { |
duke@1 | 3177 | tsym.flags_field &= ~LOCKED; |
duke@1 | 3178 | tsym.flags_field |= ACYCLIC_ANN; |
duke@1 | 3179 | } |
duke@1 | 3180 | } |
duke@1 | 3181 | |
duke@1 | 3182 | void checkAnnotationResType(DiagnosticPosition pos, Type type) { |
jjg@1374 | 3183 | switch (type.getTag()) { |
jjg@1374 | 3184 | case CLASS: |
duke@1 | 3185 | if ((type.tsym.flags() & ANNOTATION) != 0) |
duke@1 | 3186 | checkNonCyclicElementsInternal(pos, type.tsym); |
duke@1 | 3187 | break; |
jjg@1374 | 3188 | case ARRAY: |
duke@1 | 3189 | checkAnnotationResType(pos, types.elemtype(type)); |
duke@1 | 3190 | break; |
duke@1 | 3191 | default: |
duke@1 | 3192 | break; // int etc |
duke@1 | 3193 | } |
duke@1 | 3194 | } |
duke@1 | 3195 | |
duke@1 | 3196 | /* ************************************************************************* |
duke@1 | 3197 | * Check for cycles in the constructor call graph. |
duke@1 | 3198 | **************************************************************************/ |
duke@1 | 3199 | |
duke@1 | 3200 | /** Check for cycles in the graph of constructors calling other |
duke@1 | 3201 | * constructors. |
duke@1 | 3202 | */ |
duke@1 | 3203 | void checkCyclicConstructors(JCClassDecl tree) { |
duke@1 | 3204 | Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>(); |
duke@1 | 3205 | |
duke@1 | 3206 | // enter each constructor this-call into the map |
duke@1 | 3207 | for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) { |
duke@1 | 3208 | JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head); |
duke@1 | 3209 | if (app == null) continue; |
duke@1 | 3210 | JCMethodDecl meth = (JCMethodDecl) l.head; |
duke@1 | 3211 | if (TreeInfo.name(app.meth) == names._this) { |
duke@1 | 3212 | callMap.put(meth.sym, TreeInfo.symbol(app.meth)); |
duke@1 | 3213 | } else { |
duke@1 | 3214 | meth.sym.flags_field |= ACYCLIC; |
duke@1 | 3215 | } |
duke@1 | 3216 | } |
duke@1 | 3217 | |
duke@1 | 3218 | // Check for cycles in the map |
duke@1 | 3219 | Symbol[] ctors = new Symbol[0]; |
duke@1 | 3220 | ctors = callMap.keySet().toArray(ctors); |
duke@1 | 3221 | for (Symbol caller : ctors) { |
duke@1 | 3222 | checkCyclicConstructor(tree, caller, callMap); |
duke@1 | 3223 | } |
duke@1 | 3224 | } |
duke@1 | 3225 | |
duke@1 | 3226 | /** Look in the map to see if the given constructor is part of a |
duke@1 | 3227 | * call cycle. |
duke@1 | 3228 | */ |
duke@1 | 3229 | private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor, |
duke@1 | 3230 | Map<Symbol,Symbol> callMap) { |
duke@1 | 3231 | if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) { |
duke@1 | 3232 | if ((ctor.flags_field & LOCKED) != 0) { |
duke@1 | 3233 | log.error(TreeInfo.diagnosticPositionFor(ctor, tree), |
duke@1 | 3234 | "recursive.ctor.invocation"); |
duke@1 | 3235 | } else { |
duke@1 | 3236 | ctor.flags_field |= LOCKED; |
duke@1 | 3237 | checkCyclicConstructor(tree, callMap.remove(ctor), callMap); |
duke@1 | 3238 | ctor.flags_field &= ~LOCKED; |
duke@1 | 3239 | } |
duke@1 | 3240 | ctor.flags_field |= ACYCLIC; |
duke@1 | 3241 | } |
duke@1 | 3242 | } |
duke@1 | 3243 | |
duke@1 | 3244 | /* ************************************************************************* |
duke@1 | 3245 | * Miscellaneous |
duke@1 | 3246 | **************************************************************************/ |
duke@1 | 3247 | |
duke@1 | 3248 | /** |
duke@1 | 3249 | * Return the opcode of the operator but emit an error if it is an |
duke@1 | 3250 | * error. |
duke@1 | 3251 | * @param pos position for error reporting. |
duke@1 | 3252 | * @param operator an operator |
duke@1 | 3253 | * @param tag a tree tag |
duke@1 | 3254 | * @param left type of left hand side |
duke@1 | 3255 | * @param right type of right hand side |
duke@1 | 3256 | */ |
duke@1 | 3257 | int checkOperator(DiagnosticPosition pos, |
duke@1 | 3258 | OperatorSymbol operator, |
jjg@1127 | 3259 | JCTree.Tag tag, |
duke@1 | 3260 | Type left, |
duke@1 | 3261 | Type right) { |
duke@1 | 3262 | if (operator.opcode == ByteCodes.error) { |
duke@1 | 3263 | log.error(pos, |
mcimadamore@853 | 3264 | "operator.cant.be.applied.1", |
duke@1 | 3265 | treeinfo.operatorName(tag), |
mcimadamore@853 | 3266 | left, right); |
duke@1 | 3267 | } |
duke@1 | 3268 | return operator.opcode; |
duke@1 | 3269 | } |
duke@1 | 3270 | |
duke@1 | 3271 | |
duke@1 | 3272 | /** |
duke@1 | 3273 | * Check for division by integer constant zero |
duke@1 | 3274 | * @param pos Position for error reporting. |
duke@1 | 3275 | * @param operator The operator for the expression |
duke@1 | 3276 | * @param operand The right hand operand for the expression |
duke@1 | 3277 | */ |
duke@1 | 3278 | void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) { |
duke@1 | 3279 | if (operand.constValue() != null |
mcimadamore@795 | 3280 | && lint.isEnabled(LintCategory.DIVZERO) |
jjg@1374 | 3281 | && (operand.getTag().isSubRangeOf(LONG)) |
duke@1 | 3282 | && ((Number) (operand.constValue())).longValue() == 0) { |
duke@1 | 3283 | int opc = ((OperatorSymbol)operator).opcode; |
duke@1 | 3284 | if (opc == ByteCodes.idiv || opc == ByteCodes.imod |
duke@1 | 3285 | || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) { |
mcimadamore@795 | 3286 | log.warning(LintCategory.DIVZERO, pos, "div.zero"); |
duke@1 | 3287 | } |
duke@1 | 3288 | } |
duke@1 | 3289 | } |
duke@1 | 3290 | |
duke@1 | 3291 | /** |
duke@1 | 3292 | * Check for empty statements after if |
duke@1 | 3293 | */ |
duke@1 | 3294 | void checkEmptyIf(JCIf tree) { |
jjg@1127 | 3295 | if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null && |
jjg@1127 | 3296 | lint.isEnabled(LintCategory.EMPTY)) |
mcimadamore@795 | 3297 | log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if"); |
duke@1 | 3298 | } |
duke@1 | 3299 | |
duke@1 | 3300 | /** Check that symbol is unique in given scope. |
duke@1 | 3301 | * @param pos Position for error reporting. |
duke@1 | 3302 | * @param sym The symbol. |
duke@1 | 3303 | * @param s The scope. |
duke@1 | 3304 | */ |
duke@1 | 3305 | boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) { |
duke@1 | 3306 | if (sym.type.isErroneous()) |
duke@1 | 3307 | return true; |
duke@1 | 3308 | if (sym.owner.name == names.any) return false; |
duke@1 | 3309 | for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) { |
duke@1 | 3310 | if (sym != e.sym && |
mcimadamore@858 | 3311 | (e.sym.flags() & CLASH) == 0 && |
mcimadamore@858 | 3312 | sym.kind == e.sym.kind && |
mcimadamore@858 | 3313 | sym.name != names.error && |
mcimadamore@858 | 3314 | (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) { |
mcimadamore@844 | 3315 | if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) { |
duke@1 | 3316 | varargsDuplicateError(pos, sym, e.sym); |
mcimadamore@844 | 3317 | return true; |
mcimadamore@907 | 3318 | } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) { |
mcimadamore@252 | 3319 | duplicateErasureError(pos, sym, e.sym); |
mcimadamore@844 | 3320 | sym.flags_field |= CLASH; |
mcimadamore@844 | 3321 | return true; |
mcimadamore@844 | 3322 | } else { |
duke@1 | 3323 | duplicateError(pos, e.sym); |
mcimadamore@844 | 3324 | return false; |
mcimadamore@844 | 3325 | } |
duke@1 | 3326 | } |
duke@1 | 3327 | } |
duke@1 | 3328 | return true; |
duke@1 | 3329 | } |
mcimadamore@844 | 3330 | |
mcimadamore@858 | 3331 | /** Report duplicate declaration error. |
mcimadamore@858 | 3332 | */ |
mcimadamore@858 | 3333 | void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) { |
mcimadamore@858 | 3334 | if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) { |
mcimadamore@858 | 3335 | log.error(pos, "name.clash.same.erasure", sym1, sym2); |
mcimadamore@844 | 3336 | } |
mcimadamore@858 | 3337 | } |
duke@1 | 3338 | |
duke@1 | 3339 | /** Check that single-type import is not already imported or top-level defined, |
duke@1 | 3340 | * but make an exception for two single-type imports which denote the same type. |
duke@1 | 3341 | * @param pos Position for error reporting. |
duke@1 | 3342 | * @param sym The symbol. |
duke@1 | 3343 | * @param s The scope |
duke@1 | 3344 | */ |
duke@1 | 3345 | boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) { |
duke@1 | 3346 | return checkUniqueImport(pos, sym, s, false); |
duke@1 | 3347 | } |
duke@1 | 3348 | |
duke@1 | 3349 | /** Check that static single-type import is not already imported or top-level defined, |
duke@1 | 3350 | * but make an exception for two single-type imports which denote the same type. |
duke@1 | 3351 | * @param pos Position for error reporting. |
duke@1 | 3352 | * @param sym The symbol. |
duke@1 | 3353 | * @param s The scope |
duke@1 | 3354 | */ |
duke@1 | 3355 | boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) { |
duke@1 | 3356 | return checkUniqueImport(pos, sym, s, true); |
duke@1 | 3357 | } |
duke@1 | 3358 | |
duke@1 | 3359 | /** Check that single-type import is not already imported or top-level defined, |
duke@1 | 3360 | * but make an exception for two single-type imports which denote the same type. |
duke@1 | 3361 | * @param pos Position for error reporting. |
duke@1 | 3362 | * @param sym The symbol. |
duke@1 | 3363 | * @param s The scope. |
duke@1 | 3364 | * @param staticImport Whether or not this was a static import |
duke@1 | 3365 | */ |
duke@1 | 3366 | private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) { |
duke@1 | 3367 | for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) { |
duke@1 | 3368 | // is encountered class entered via a class declaration? |
duke@1 | 3369 | boolean isClassDecl = e.scope == s; |
duke@1 | 3370 | if ((isClassDecl || sym != e.sym) && |
duke@1 | 3371 | sym.kind == e.sym.kind && |
duke@1 | 3372 | sym.name != names.error) { |
duke@1 | 3373 | if (!e.sym.type.isErroneous()) { |
duke@1 | 3374 | String what = e.sym.toString(); |
duke@1 | 3375 | if (!isClassDecl) { |
duke@1 | 3376 | if (staticImport) |
duke@1 | 3377 | log.error(pos, "already.defined.static.single.import", what); |
duke@1 | 3378 | else |
duke@1 | 3379 | log.error(pos, "already.defined.single.import", what); |
duke@1 | 3380 | } |
duke@1 | 3381 | else if (sym != e.sym) |
duke@1 | 3382 | log.error(pos, "already.defined.this.unit", what); |
duke@1 | 3383 | } |
duke@1 | 3384 | return false; |
duke@1 | 3385 | } |
duke@1 | 3386 | } |
duke@1 | 3387 | return true; |
duke@1 | 3388 | } |
duke@1 | 3389 | |
duke@1 | 3390 | /** Check that a qualified name is in canonical form (for import decls). |
duke@1 | 3391 | */ |
duke@1 | 3392 | public void checkCanonical(JCTree tree) { |
duke@1 | 3393 | if (!isCanonical(tree)) |
duke@1 | 3394 | log.error(tree.pos(), "import.requires.canonical", |
duke@1 | 3395 | TreeInfo.symbol(tree)); |
duke@1 | 3396 | } |
duke@1 | 3397 | // where |
duke@1 | 3398 | private boolean isCanonical(JCTree tree) { |
jjg@1127 | 3399 | while (tree.hasTag(SELECT)) { |
duke@1 | 3400 | JCFieldAccess s = (JCFieldAccess) tree; |
duke@1 | 3401 | if (s.sym.owner != TreeInfo.symbol(s.selected)) |
duke@1 | 3402 | return false; |
duke@1 | 3403 | tree = s.selected; |
duke@1 | 3404 | } |
duke@1 | 3405 | return true; |
duke@1 | 3406 | } |
duke@1 | 3407 | |
ohrstrom@1384 | 3408 | /** Check that an auxiliary class is not accessed from any other file than its own. |
ohrstrom@1384 | 3409 | */ |
ohrstrom@1384 | 3410 | void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) { |
ohrstrom@1384 | 3411 | if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) && |
ohrstrom@1384 | 3412 | (c.flags() & AUXILIARY) != 0 && |
ohrstrom@1384 | 3413 | rs.isAccessible(env, c) && |
ohrstrom@1384 | 3414 | !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile)) |
ohrstrom@1384 | 3415 | { |
ohrstrom@1384 | 3416 | log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file", |
ohrstrom@1384 | 3417 | c, c.sourcefile); |
ohrstrom@1384 | 3418 | } |
ohrstrom@1384 | 3419 | } |
ohrstrom@1384 | 3420 | |
duke@1 | 3421 | private class ConversionWarner extends Warner { |
mcimadamore@795 | 3422 | final String uncheckedKey; |
duke@1 | 3423 | final Type found; |
duke@1 | 3424 | final Type expected; |
mcimadamore@795 | 3425 | public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) { |
duke@1 | 3426 | super(pos); |
mcimadamore@795 | 3427 | this.uncheckedKey = uncheckedKey; |
duke@1 | 3428 | this.found = found; |
duke@1 | 3429 | this.expected = expected; |
duke@1 | 3430 | } |
duke@1 | 3431 | |
jjg@398 | 3432 | @Override |
mcimadamore@795 | 3433 | public void warn(LintCategory lint) { |
duke@1 | 3434 | boolean warned = this.warned; |
mcimadamore@795 | 3435 | super.warn(lint); |
duke@1 | 3436 | if (warned) return; // suppress redundant diagnostics |
mcimadamore@795 | 3437 | switch (lint) { |
mcimadamore@795 | 3438 | case UNCHECKED: |
mcimadamore@795 | 3439 | Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected); |
mcimadamore@795 | 3440 | break; |
mcimadamore@795 | 3441 | case VARARGS: |
mcimadamore@795 | 3442 | if (method != null && |
mcimadamore@795 | 3443 | method.attribute(syms.trustMeType.tsym) != null && |
mcimadamore@795 | 3444 | isTrustMeAllowedOnMethod(method) && |
mcimadamore@795 | 3445 | !types.isReifiable(method.type.getParameterTypes().last())) { |
mcimadamore@795 | 3446 | Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last()); |
mcimadamore@795 | 3447 | } |
mcimadamore@795 | 3448 | break; |
mcimadamore@795 | 3449 | default: |
mcimadamore@795 | 3450 | throw new AssertionError("Unexpected lint: " + lint); |
mcimadamore@795 | 3451 | } |
duke@1 | 3452 | } |
duke@1 | 3453 | } |
duke@1 | 3454 | |
duke@1 | 3455 | public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) { |
duke@1 | 3456 | return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected); |
duke@1 | 3457 | } |
duke@1 | 3458 | |
duke@1 | 3459 | public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) { |
duke@1 | 3460 | return new ConversionWarner(pos, "unchecked.assign", found, expected); |
duke@1 | 3461 | } |
duke@1 | 3462 | } |