src/share/classes/com/sun/tools/javac/comp/Check.java

Fri, 28 Jan 2011 12:03:49 +0000

author
mcimadamore
date
Fri, 28 Jan 2011 12:03:49 +0000
changeset 845
5a43b245aed1
parent 844
2088e674f0e0
child 852
899f7c3d9426
permissions
-rw-r--r--

6313164: javac generates code that fails byte code verification for the varargs feature
Summary: method applicability check should fail if formal varargs element type is not accessible
Reviewed-by: jjg

duke@1 1 /*
jjg@815 2 * Copyright (c) 1999, 2011, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.comp;
duke@1 27
duke@1 28 import java.util.*;
duke@1 29 import java.util.Set;
duke@1 30
duke@1 31 import com.sun.tools.javac.code.*;
duke@1 32 import com.sun.tools.javac.jvm.*;
duke@1 33 import com.sun.tools.javac.tree.*;
duke@1 34 import com.sun.tools.javac.util.*;
duke@1 35 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
duke@1 36 import com.sun.tools.javac.util.List;
duke@1 37
duke@1 38 import com.sun.tools.javac.tree.JCTree.*;
duke@1 39 import com.sun.tools.javac.code.Lint;
duke@1 40 import com.sun.tools.javac.code.Lint.LintCategory;
duke@1 41 import com.sun.tools.javac.code.Type.*;
duke@1 42 import com.sun.tools.javac.code.Symbol.*;
duke@1 43
duke@1 44 import static com.sun.tools.javac.code.Flags.*;
duke@1 45 import static com.sun.tools.javac.code.Kinds.*;
duke@1 46 import static com.sun.tools.javac.code.TypeTags.*;
duke@1 47
jjg@700 48 import static com.sun.tools.javac.main.OptionName.*;
jjg@700 49
duke@1 50 /** Type checking helper class for the attribution phase.
duke@1 51 *
jjg@581 52 * <p><b>This is NOT part of any supported API.
jjg@581 53 * If you write code that depends on this, you do so at your own risk.
duke@1 54 * This code and its internal interfaces are subject to change or
duke@1 55 * deletion without notice.</b>
duke@1 56 */
duke@1 57 public class Check {
duke@1 58 protected static final Context.Key<Check> checkKey =
duke@1 59 new Context.Key<Check>();
duke@1 60
jjg@113 61 private final Names names;
duke@1 62 private final Log log;
mcimadamore@845 63 private final Resolve rs;
duke@1 64 private final Symtab syms;
mcimadamore@690 65 private final Enter enter;
duke@1 66 private final Infer infer;
duke@1 67 private final Types types;
mcimadamore@89 68 private final JCDiagnostic.Factory diags;
duke@1 69 private final boolean skipAnnotations;
mcimadamore@359 70 private boolean warnOnSyntheticConflicts;
jjg@576 71 private boolean suppressAbortOnBadClassFile;
duke@1 72 private final TreeInfo treeinfo;
duke@1 73
duke@1 74 // The set of lint options currently in effect. It is initialized
duke@1 75 // from the context, and then is set/reset as needed by Attr as it
duke@1 76 // visits all the various parts of the trees during attribution.
duke@1 77 private Lint lint;
duke@1 78
mcimadamore@795 79 // The method being analyzed in Attr - it is set/reset as needed by
mcimadamore@795 80 // Attr as it visits new method declarations.
mcimadamore@795 81 private MethodSymbol method;
mcimadamore@795 82
duke@1 83 public static Check instance(Context context) {
duke@1 84 Check instance = context.get(checkKey);
duke@1 85 if (instance == null)
duke@1 86 instance = new Check(context);
duke@1 87 return instance;
duke@1 88 }
duke@1 89
duke@1 90 protected Check(Context context) {
duke@1 91 context.put(checkKey, this);
duke@1 92
jjg@113 93 names = Names.instance(context);
duke@1 94 log = Log.instance(context);
mcimadamore@845 95 rs = Resolve.instance(context);
duke@1 96 syms = Symtab.instance(context);
mcimadamore@690 97 enter = Enter.instance(context);
duke@1 98 infer = Infer.instance(context);
duke@1 99 this.types = Types.instance(context);
mcimadamore@89 100 diags = JCDiagnostic.Factory.instance(context);
duke@1 101 Options options = Options.instance(context);
duke@1 102 lint = Lint.instance(context);
duke@1 103 treeinfo = TreeInfo.instance(context);
duke@1 104
duke@1 105 Source source = Source.instance(context);
duke@1 106 allowGenerics = source.allowGenerics();
duke@1 107 allowAnnotations = source.allowAnnotations();
jjg@398 108 allowCovariantReturns = source.allowCovariantReturns();
mcimadamore@795 109 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
jjg@700 110 complexInference = options.isSet(COMPLEXINFERENCE);
jjg@700 111 skipAnnotations = options.isSet("skipAnnotations");
jjg@700 112 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
jjg@700 113 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
duke@1 114
jjg@398 115 Target target = Target.instance(context);
jjg@398 116 syntheticNameChar = target.syntheticNameChar();
jjg@398 117
duke@1 118 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
duke@1 119 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
mcimadamore@580 120 boolean verboseVarargs = lint.isEnabled(LintCategory.VARARGS);
jjg@377 121 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
jjg@60 122 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
duke@1 123
jjg@60 124 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
jjg@612 125 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
jjg@60 126 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
jjg@612 127 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
mcimadamore@580 128 unsafeVarargsHandler = new MandatoryWarningHandler(log, verboseVarargs,
jjg@612 129 enforceMandatoryWarnings, "varargs", LintCategory.VARARGS);
jjg@377 130 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
jjg@612 131 enforceMandatoryWarnings, "sunapi", null);
duke@1 132 }
duke@1 133
duke@1 134 /** Switch: generics enabled?
duke@1 135 */
duke@1 136 boolean allowGenerics;
duke@1 137
duke@1 138 /** Switch: annotations enabled?
duke@1 139 */
duke@1 140 boolean allowAnnotations;
duke@1 141
jjg@398 142 /** Switch: covariant returns enabled?
jjg@398 143 */
jjg@398 144 boolean allowCovariantReturns;
jjg@398 145
mcimadamore@795 146 /** Switch: simplified varargs enabled?
mcimadamore@795 147 */
mcimadamore@795 148 boolean allowSimplifiedVarargs;
mcimadamore@795 149
duke@1 150 /** Switch: -complexinference option set?
duke@1 151 */
duke@1 152 boolean complexInference;
duke@1 153
jjg@398 154 /** Character for synthetic names
jjg@398 155 */
jjg@398 156 char syntheticNameChar;
jjg@398 157
duke@1 158 /** A table mapping flat names of all compiled classes in this run to their
duke@1 159 * symbols; maintained from outside.
duke@1 160 */
duke@1 161 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
duke@1 162
duke@1 163 /** A handler for messages about deprecated usage.
duke@1 164 */
duke@1 165 private MandatoryWarningHandler deprecationHandler;
duke@1 166
duke@1 167 /** A handler for messages about unchecked or unsafe usage.
duke@1 168 */
duke@1 169 private MandatoryWarningHandler uncheckedHandler;
duke@1 170
mcimadamore@580 171 /** A handler for messages about unchecked or unsafe vararg method decl.
mcimadamore@580 172 */
mcimadamore@580 173 private MandatoryWarningHandler unsafeVarargsHandler;
mcimadamore@580 174
jjg@582 175 /** A handler for messages about using proprietary API.
jjg@377 176 */
jjg@377 177 private MandatoryWarningHandler sunApiHandler;
duke@1 178
duke@1 179 /* *************************************************************************
duke@1 180 * Errors and Warnings
duke@1 181 **************************************************************************/
duke@1 182
duke@1 183 Lint setLint(Lint newLint) {
duke@1 184 Lint prev = lint;
duke@1 185 lint = newLint;
duke@1 186 return prev;
duke@1 187 }
duke@1 188
mcimadamore@795 189 MethodSymbol setMethod(MethodSymbol newMethod) {
mcimadamore@795 190 MethodSymbol prev = method;
mcimadamore@795 191 method = newMethod;
mcimadamore@795 192 return prev;
mcimadamore@795 193 }
mcimadamore@795 194
duke@1 195 /** Warn about deprecated symbol.
duke@1 196 * @param pos Position to be used for error reporting.
duke@1 197 * @param sym The deprecated symbol.
duke@1 198 */
duke@1 199 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
duke@1 200 if (!lint.isSuppressed(LintCategory.DEPRECATION))
duke@1 201 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
duke@1 202 }
duke@1 203
duke@1 204 /** Warn about unchecked operation.
duke@1 205 * @param pos Position to be used for error reporting.
duke@1 206 * @param msg A string describing the problem.
duke@1 207 */
duke@1 208 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
duke@1 209 if (!lint.isSuppressed(LintCategory.UNCHECKED))
duke@1 210 uncheckedHandler.report(pos, msg, args);
duke@1 211 }
duke@1 212
mcimadamore@580 213 /** Warn about unsafe vararg method decl.
mcimadamore@580 214 * @param pos Position to be used for error reporting.
mcimadamore@580 215 * @param sym The deprecated symbol.
mcimadamore@580 216 */
mcimadamore@795 217 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
mcimadamore@795 218 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
mcimadamore@795 219 log.warning(LintCategory.VARARGS, pos, key, args);
mcimadamore@580 220 }
mcimadamore@580 221
jjg@582 222 /** Warn about using proprietary API.
jjg@377 223 * @param pos Position to be used for error reporting.
jjg@377 224 * @param msg A string describing the problem.
jjg@377 225 */
jjg@377 226 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
jjg@377 227 if (!lint.isSuppressed(LintCategory.SUNAPI))
jjg@377 228 sunApiHandler.report(pos, msg, args);
jjg@377 229 }
jjg@377 230
jjg@505 231 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
jjg@505 232 if (lint.isEnabled(LintCategory.STATIC))
jjg@612 233 log.warning(LintCategory.STATIC, pos, msg, args);
jjg@505 234 }
jjg@505 235
duke@1 236 /**
duke@1 237 * Report any deferred diagnostics.
duke@1 238 */
duke@1 239 public void reportDeferredDiagnostics() {
duke@1 240 deprecationHandler.reportDeferredDiagnostic();
duke@1 241 uncheckedHandler.reportDeferredDiagnostic();
jjg@377 242 sunApiHandler.reportDeferredDiagnostic();
duke@1 243 }
duke@1 244
duke@1 245
duke@1 246 /** Report a failure to complete a class.
duke@1 247 * @param pos Position to be used for error reporting.
duke@1 248 * @param ex The failure to report.
duke@1 249 */
duke@1 250 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
jjg@12 251 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
jjg@576 252 if (ex instanceof ClassReader.BadClassFile
jjg@576 253 && !suppressAbortOnBadClassFile) throw new Abort();
duke@1 254 else return syms.errType;
duke@1 255 }
duke@1 256
duke@1 257 /** Report a type error.
duke@1 258 * @param pos Position to be used for error reporting.
duke@1 259 * @param problem A string describing the error.
duke@1 260 * @param found The type that was found.
duke@1 261 * @param req The type that was required.
duke@1 262 */
duke@1 263 Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
duke@1 264 log.error(pos, "prob.found.req",
duke@1 265 problem, found, req);
jjg@110 266 return types.createErrorType(found);
duke@1 267 }
duke@1 268
duke@1 269 Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
duke@1 270 log.error(pos, "prob.found.req.1", problem, found, req, explanation);
jjg@110 271 return types.createErrorType(found);
duke@1 272 }
duke@1 273
duke@1 274 /** Report an error that wrong type tag was found.
duke@1 275 * @param pos Position to be used for error reporting.
duke@1 276 * @param required An internationalized string describing the type tag
duke@1 277 * required.
duke@1 278 * @param found The type that was found.
duke@1 279 */
duke@1 280 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
jrose@267 281 // this error used to be raised by the parser,
jrose@267 282 // but has been delayed to this point:
jrose@267 283 if (found instanceof Type && ((Type)found).tag == VOID) {
jrose@267 284 log.error(pos, "illegal.start.of.type");
jrose@267 285 return syms.errType;
jrose@267 286 }
duke@1 287 log.error(pos, "type.found.req", found, required);
jjg@110 288 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
duke@1 289 }
duke@1 290
duke@1 291 /** Report an error that symbol cannot be referenced before super
duke@1 292 * has been called.
duke@1 293 * @param pos Position to be used for error reporting.
duke@1 294 * @param sym The referenced symbol.
duke@1 295 */
duke@1 296 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
duke@1 297 log.error(pos, "cant.ref.before.ctor.called", sym);
duke@1 298 }
duke@1 299
duke@1 300 /** Report duplicate declaration error.
duke@1 301 */
duke@1 302 void duplicateError(DiagnosticPosition pos, Symbol sym) {
duke@1 303 if (!sym.type.isErroneous()) {
duke@1 304 log.error(pos, "already.defined", sym, sym.location());
duke@1 305 }
duke@1 306 }
duke@1 307
duke@1 308 /** Report array/varargs duplicate declaration
duke@1 309 */
duke@1 310 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
duke@1 311 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
duke@1 312 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
duke@1 313 }
duke@1 314 }
duke@1 315
duke@1 316 /* ************************************************************************
duke@1 317 * duplicate declaration checking
duke@1 318 *************************************************************************/
duke@1 319
duke@1 320 /** Check that variable does not hide variable with same name in
duke@1 321 * immediately enclosing local scope.
duke@1 322 * @param pos Position for error reporting.
duke@1 323 * @param v The symbol.
duke@1 324 * @param s The scope.
duke@1 325 */
duke@1 326 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
duke@1 327 if (s.next != null) {
duke@1 328 for (Scope.Entry e = s.next.lookup(v.name);
duke@1 329 e.scope != null && e.sym.owner == v.owner;
duke@1 330 e = e.next()) {
duke@1 331 if (e.sym.kind == VAR &&
duke@1 332 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 333 v.name != names.error) {
duke@1 334 duplicateError(pos, e.sym);
duke@1 335 return;
duke@1 336 }
duke@1 337 }
duke@1 338 }
duke@1 339 }
duke@1 340
duke@1 341 /** Check that a class or interface does not hide a class or
duke@1 342 * interface with same name in immediately enclosing local scope.
duke@1 343 * @param pos Position for error reporting.
duke@1 344 * @param c The symbol.
duke@1 345 * @param s The scope.
duke@1 346 */
duke@1 347 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
duke@1 348 if (s.next != null) {
duke@1 349 for (Scope.Entry e = s.next.lookup(c.name);
duke@1 350 e.scope != null && e.sym.owner == c.owner;
duke@1 351 e = e.next()) {
mcimadamore@639 352 if (e.sym.kind == TYP && e.sym.type.tag != TYPEVAR &&
duke@1 353 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
duke@1 354 c.name != names.error) {
duke@1 355 duplicateError(pos, e.sym);
duke@1 356 return;
duke@1 357 }
duke@1 358 }
duke@1 359 }
duke@1 360 }
duke@1 361
duke@1 362 /** Check that class does not have the same name as one of
duke@1 363 * its enclosing classes, or as a class defined in its enclosing scope.
duke@1 364 * return true if class is unique in its enclosing scope.
duke@1 365 * @param pos Position for error reporting.
duke@1 366 * @param name The class name.
duke@1 367 * @param s The enclosing scope.
duke@1 368 */
duke@1 369 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
duke@1 370 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
duke@1 371 if (e.sym.kind == TYP && e.sym.name != names.error) {
duke@1 372 duplicateError(pos, e.sym);
duke@1 373 return false;
duke@1 374 }
duke@1 375 }
duke@1 376 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
duke@1 377 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
duke@1 378 duplicateError(pos, sym);
duke@1 379 return true;
duke@1 380 }
duke@1 381 }
duke@1 382 return true;
duke@1 383 }
duke@1 384
duke@1 385 /* *************************************************************************
duke@1 386 * Class name generation
duke@1 387 **************************************************************************/
duke@1 388
duke@1 389 /** Return name of local class.
duke@1 390 * This is of the form <enclClass> $ n <classname>
duke@1 391 * where
duke@1 392 * enclClass is the flat name of the enclosing class,
duke@1 393 * classname is the simple name of the local class
duke@1 394 */
duke@1 395 Name localClassName(ClassSymbol c) {
duke@1 396 for (int i=1; ; i++) {
duke@1 397 Name flatname = names.
duke@1 398 fromString("" + c.owner.enclClass().flatname +
jjg@398 399 syntheticNameChar + i +
duke@1 400 c.name);
duke@1 401 if (compiled.get(flatname) == null) return flatname;
duke@1 402 }
duke@1 403 }
duke@1 404
duke@1 405 /* *************************************************************************
duke@1 406 * Type Checking
duke@1 407 **************************************************************************/
duke@1 408
duke@1 409 /** Check that a given type is assignable to a given proto-type.
duke@1 410 * If it is, return the type, otherwise return errType.
duke@1 411 * @param pos Position to be used for error reporting.
duke@1 412 * @param found The type that was found.
duke@1 413 * @param req The type that was required.
duke@1 414 */
duke@1 415 Type checkType(DiagnosticPosition pos, Type found, Type req) {
darcy@609 416 return checkType(pos, found, req, "incompatible.types");
darcy@609 417 }
darcy@609 418
darcy@609 419 Type checkType(DiagnosticPosition pos, Type found, Type req, String errKey) {
duke@1 420 if (req.tag == ERROR)
duke@1 421 return req;
mcimadamore@536 422 if (found.tag == FORALL)
mcimadamore@536 423 return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req));
duke@1 424 if (req.tag == NONE)
duke@1 425 return found;
duke@1 426 if (types.isAssignable(found, req, convertWarner(pos, found, req)))
duke@1 427 return found;
duke@1 428 if (found.tag <= DOUBLE && req.tag <= DOUBLE)
mcimadamore@89 429 return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req);
duke@1 430 if (found.isSuperBound()) {
duke@1 431 log.error(pos, "assignment.from.super-bound", found);
jjg@110 432 return types.createErrorType(found);
duke@1 433 }
duke@1 434 if (req.isExtendsBound()) {
duke@1 435 log.error(pos, "assignment.to.extends-bound", req);
jjg@110 436 return types.createErrorType(found);
duke@1 437 }
darcy@609 438 return typeError(pos, diags.fragment(errKey), found, req);
duke@1 439 }
duke@1 440
duke@1 441 /** Instantiate polymorphic type to some prototype, unless
duke@1 442 * prototype is `anyPoly' in which case polymorphic type
duke@1 443 * is returned unchanged.
duke@1 444 */
mcimadamore@383 445 Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException {
duke@1 446 if (pt == Infer.anyPoly && complexInference) {
duke@1 447 return t;
duke@1 448 } else if (pt == Infer.anyPoly || pt.tag == NONE) {
duke@1 449 Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
duke@1 450 return instantiatePoly(pos, t, newpt, warn);
duke@1 451 } else if (pt.tag == ERROR) {
duke@1 452 return pt;
duke@1 453 } else {
mcimadamore@536 454 try {
mcimadamore@536 455 return infer.instantiateExpr(t, pt, warn);
mcimadamore@536 456 } catch (Infer.NoInstanceException ex) {
mcimadamore@536 457 if (ex.isAmbiguous) {
mcimadamore@536 458 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 459 log.error(pos,
mcimadamore@536 460 "undetermined.type" + (d!=null ? ".1" : ""),
mcimadamore@536 461 t, d);
mcimadamore@536 462 return types.createErrorType(pt);
mcimadamore@536 463 } else {
mcimadamore@536 464 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 465 return typeError(pos,
mcimadamore@536 466 diags.fragment("incompatible.types" + (d!=null ? ".1" : ""), d),
mcimadamore@536 467 t, pt);
mcimadamore@536 468 }
mcimadamore@536 469 } catch (Infer.InvalidInstanceException ex) {
mcimadamore@536 470 JCDiagnostic d = ex.getDiagnostic();
mcimadamore@536 471 log.error(pos, "invalid.inferred.types", t.tvars, d);
mcimadamore@536 472 return types.createErrorType(pt);
mcimadamore@536 473 }
duke@1 474 }
mcimadamore@536 475 }
duke@1 476
duke@1 477 /** Check that a given type can be cast to a given target type.
duke@1 478 * Return the result of the cast.
duke@1 479 * @param pos Position to be used for error reporting.
duke@1 480 * @param found The type that is being cast.
duke@1 481 * @param req The target type of the cast.
duke@1 482 */
duke@1 483 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
duke@1 484 if (found.tag == FORALL) {
duke@1 485 instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
duke@1 486 return req;
duke@1 487 } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
duke@1 488 return req;
duke@1 489 } else {
duke@1 490 return typeError(pos,
mcimadamore@89 491 diags.fragment("inconvertible.types"),
duke@1 492 found, req);
duke@1 493 }
duke@1 494 }
duke@1 495 //where
duke@1 496 /** Is type a type variable, or a (possibly multi-dimensional) array of
duke@1 497 * type variables?
duke@1 498 */
duke@1 499 boolean isTypeVar(Type t) {
duke@1 500 return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
duke@1 501 }
duke@1 502
duke@1 503 /** Check that a type is within some bounds.
duke@1 504 *
duke@1 505 * Used in TypeApply to verify that, e.g., X in V<X> is a valid
duke@1 506 * type argument.
duke@1 507 * @param pos Position to be used for error reporting.
duke@1 508 * @param a The type that should be bounded by bs.
duke@1 509 * @param bs The bound.
duke@1 510 */
mcimadamore@821 511 private boolean checkExtends(Type a, TypeVar bs) {
mcimadamore@154 512 if (a.isUnbound()) {
mcimadamore@821 513 return true;
mcimadamore@154 514 } else if (a.tag != WILDCARD) {
mcimadamore@154 515 a = types.upperBound(a);
mcimadamore@821 516 return types.isSubtype(a, bs.bound);
mcimadamore@154 517 } else if (a.isExtendsBound()) {
mcimadamore@821 518 return types.isCastable(bs.getUpperBound(), types.upperBound(a), Warner.noWarnings);
mcimadamore@154 519 } else if (a.isSuperBound()) {
mcimadamore@821 520 return !types.notSoftSubtype(types.lowerBound(a), bs.getUpperBound());
mcimadamore@154 521 }
mcimadamore@821 522 return true;
mcimadamore@154 523 }
duke@1 524
duke@1 525 /** Check that type is different from 'void'.
duke@1 526 * @param pos Position to be used for error reporting.
duke@1 527 * @param t The type to be checked.
duke@1 528 */
duke@1 529 Type checkNonVoid(DiagnosticPosition pos, Type t) {
duke@1 530 if (t.tag == VOID) {
duke@1 531 log.error(pos, "void.not.allowed.here");
jjg@110 532 return types.createErrorType(t);
duke@1 533 } else {
duke@1 534 return t;
duke@1 535 }
duke@1 536 }
duke@1 537
duke@1 538 /** Check that type is a class or interface type.
duke@1 539 * @param pos Position to be used for error reporting.
duke@1 540 * @param t The type to be checked.
duke@1 541 */
duke@1 542 Type checkClassType(DiagnosticPosition pos, Type t) {
duke@1 543 if (t.tag != CLASS && t.tag != ERROR)
duke@1 544 return typeTagError(pos,
mcimadamore@89 545 diags.fragment("type.req.class"),
duke@1 546 (t.tag == TYPEVAR)
mcimadamore@89 547 ? diags.fragment("type.parameter", t)
duke@1 548 : t);
duke@1 549 else
duke@1 550 return t;
duke@1 551 }
duke@1 552
duke@1 553 /** Check that type is a class or interface type.
duke@1 554 * @param pos Position to be used for error reporting.
duke@1 555 * @param t The type to be checked.
duke@1 556 * @param noBounds True if type bounds are illegal here.
duke@1 557 */
duke@1 558 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
duke@1 559 t = checkClassType(pos, t);
duke@1 560 if (noBounds && t.isParameterized()) {
duke@1 561 List<Type> args = t.getTypeArguments();
duke@1 562 while (args.nonEmpty()) {
duke@1 563 if (args.head.tag == WILDCARD)
duke@1 564 return typeTagError(pos,
jjg@598 565 diags.fragment("type.req.exact"),
duke@1 566 args.head);
duke@1 567 args = args.tail;
duke@1 568 }
duke@1 569 }
duke@1 570 return t;
duke@1 571 }
duke@1 572
duke@1 573 /** Check that type is a reifiable class, interface or array type.
duke@1 574 * @param pos Position to be used for error reporting.
duke@1 575 * @param t The type to be checked.
duke@1 576 */
duke@1 577 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
duke@1 578 if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
duke@1 579 return typeTagError(pos,
mcimadamore@89 580 diags.fragment("type.req.class.array"),
duke@1 581 t);
duke@1 582 } else if (!types.isReifiable(t)) {
duke@1 583 log.error(pos, "illegal.generic.type.for.instof");
jjg@110 584 return types.createErrorType(t);
duke@1 585 } else {
duke@1 586 return t;
duke@1 587 }
duke@1 588 }
duke@1 589
duke@1 590 /** Check that type is a reference type, i.e. a class, interface or array type
duke@1 591 * or a type variable.
duke@1 592 * @param pos Position to be used for error reporting.
duke@1 593 * @param t The type to be checked.
duke@1 594 */
duke@1 595 Type checkRefType(DiagnosticPosition pos, Type t) {
duke@1 596 switch (t.tag) {
duke@1 597 case CLASS:
duke@1 598 case ARRAY:
duke@1 599 case TYPEVAR:
duke@1 600 case WILDCARD:
duke@1 601 case ERROR:
duke@1 602 return t;
duke@1 603 default:
duke@1 604 return typeTagError(pos,
mcimadamore@89 605 diags.fragment("type.req.ref"),
duke@1 606 t);
duke@1 607 }
duke@1 608 }
duke@1 609
jrose@267 610 /** Check that each type is a reference type, i.e. a class, interface or array type
jrose@267 611 * or a type variable.
jrose@267 612 * @param trees Original trees, used for error reporting.
jrose@267 613 * @param types The types to be checked.
jrose@267 614 */
jrose@267 615 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
jrose@267 616 List<JCExpression> tl = trees;
jrose@267 617 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
jrose@267 618 l.head = checkRefType(tl.head.pos(), l.head);
jrose@267 619 tl = tl.tail;
jrose@267 620 }
jrose@267 621 return types;
jrose@267 622 }
jrose@267 623
duke@1 624 /** Check that type is a null or reference type.
duke@1 625 * @param pos Position to be used for error reporting.
duke@1 626 * @param t The type to be checked.
duke@1 627 */
duke@1 628 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
duke@1 629 switch (t.tag) {
duke@1 630 case CLASS:
duke@1 631 case ARRAY:
duke@1 632 case TYPEVAR:
duke@1 633 case WILDCARD:
duke@1 634 case BOT:
duke@1 635 case ERROR:
duke@1 636 return t;
duke@1 637 default:
duke@1 638 return typeTagError(pos,
mcimadamore@89 639 diags.fragment("type.req.ref"),
duke@1 640 t);
duke@1 641 }
duke@1 642 }
duke@1 643
duke@1 644 /** Check that flag set does not contain elements of two conflicting sets. s
duke@1 645 * Return true if it doesn't.
duke@1 646 * @param pos Position to be used for error reporting.
duke@1 647 * @param flags The set of flags to be checked.
duke@1 648 * @param set1 Conflicting flags set #1.
duke@1 649 * @param set2 Conflicting flags set #2.
duke@1 650 */
duke@1 651 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
duke@1 652 if ((flags & set1) != 0 && (flags & set2) != 0) {
duke@1 653 log.error(pos,
duke@1 654 "illegal.combination.of.modifiers",
mcimadamore@80 655 asFlagSet(TreeInfo.firstFlag(flags & set1)),
mcimadamore@80 656 asFlagSet(TreeInfo.firstFlag(flags & set2)));
duke@1 657 return false;
duke@1 658 } else
duke@1 659 return true;
duke@1 660 }
duke@1 661
mcimadamore@537 662 /** Check that the type inferred using the diamond operator does not contain
mcimadamore@537 663 * non-denotable types such as captured types or intersection types.
mcimadamore@537 664 * @param t the type inferred using the diamond operator
mcimadamore@537 665 */
mcimadamore@537 666 List<Type> checkDiamond(ClassType t) {
mcimadamore@537 667 DiamondTypeChecker dtc = new DiamondTypeChecker();
mcimadamore@537 668 ListBuffer<Type> buf = ListBuffer.lb();
mcimadamore@537 669 for (Type arg : t.getTypeArguments()) {
mcimadamore@537 670 if (!dtc.visit(arg, null)) {
mcimadamore@537 671 buf.append(arg);
mcimadamore@537 672 }
mcimadamore@537 673 }
mcimadamore@537 674 return buf.toList();
mcimadamore@537 675 }
mcimadamore@537 676
mcimadamore@537 677 static class DiamondTypeChecker extends Types.SimpleVisitor<Boolean, Void> {
mcimadamore@537 678 public Boolean visitType(Type t, Void s) {
mcimadamore@537 679 return true;
mcimadamore@537 680 }
mcimadamore@537 681 @Override
mcimadamore@537 682 public Boolean visitClassType(ClassType t, Void s) {
mcimadamore@537 683 if (t.isCompound()) {
mcimadamore@537 684 return false;
mcimadamore@537 685 }
mcimadamore@537 686 for (Type targ : t.getTypeArguments()) {
mcimadamore@537 687 if (!visit(targ, s)) {
mcimadamore@537 688 return false;
mcimadamore@537 689 }
mcimadamore@537 690 }
mcimadamore@537 691 return true;
mcimadamore@537 692 }
mcimadamore@537 693 @Override
mcimadamore@537 694 public Boolean visitCapturedType(CapturedType t, Void s) {
mcimadamore@537 695 return false;
mcimadamore@537 696 }
mcimadamore@537 697 }
mcimadamore@537 698
mcimadamore@795 699 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
mcimadamore@580 700 MethodSymbol m = tree.sym;
mcimadamore@795 701 if (!allowSimplifiedVarargs) return;
mcimadamore@795 702 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
mcimadamore@795 703 Type varargElemType = null;
mcimadamore@580 704 if (m.isVarArgs()) {
mcimadamore@795 705 varargElemType = types.elemtype(tree.params.last().type);
mcimadamore@795 706 }
mcimadamore@795 707 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
mcimadamore@795 708 if (varargElemType != null) {
mcimadamore@795 709 log.error(tree,
mcimadamore@795 710 "varargs.invalid.trustme.anno",
mcimadamore@795 711 syms.trustMeType.tsym,
mcimadamore@795 712 diags.fragment("varargs.trustme.on.virtual.varargs", m));
mcimadamore@795 713 } else {
mcimadamore@795 714 log.error(tree,
mcimadamore@795 715 "varargs.invalid.trustme.anno",
mcimadamore@795 716 syms.trustMeType.tsym,
mcimadamore@795 717 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
mcimadamore@580 718 }
mcimadamore@795 719 } else if (hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 720 types.isReifiable(varargElemType)) {
mcimadamore@795 721 warnUnsafeVararg(tree,
mcimadamore@795 722 "varargs.redundant.trustme.anno",
mcimadamore@795 723 syms.trustMeType.tsym,
mcimadamore@795 724 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
mcimadamore@795 725 }
mcimadamore@795 726 else if (!hasTrustMeAnno && varargElemType != null &&
mcimadamore@795 727 !types.isReifiable(varargElemType)) {
mcimadamore@795 728 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
mcimadamore@580 729 }
mcimadamore@580 730 }
mcimadamore@795 731 //where
mcimadamore@795 732 private boolean isTrustMeAllowedOnMethod(Symbol s) {
mcimadamore@795 733 return (s.flags() & VARARGS) != 0 &&
mcimadamore@795 734 (s.isConstructor() ||
mcimadamore@795 735 (s.flags() & (STATIC | FINAL)) != 0);
mcimadamore@795 736 }
mcimadamore@580 737
mcimadamore@547 738 /**
mcimadamore@547 739 * Check that vararg method call is sound
mcimadamore@547 740 * @param pos Position to be used for error reporting.
mcimadamore@547 741 * @param argtypes Actual arguments supplied to vararg method.
mcimadamore@547 742 */
mcimadamore@795 743 void checkVararg(DiagnosticPosition pos, List<Type> argtypes, Symbol msym) {
mcimadamore@547 744 Type argtype = argtypes.last();
mcimadamore@795 745 if (!types.isReifiable(argtype) &&
mcimadamore@795 746 (!allowSimplifiedVarargs ||
mcimadamore@795 747 msym.attribute(syms.trustMeType.tsym) == null ||
mcimadamore@795 748 !isTrustMeAllowedOnMethod(msym))) {
mcimadamore@547 749 warnUnchecked(pos,
mcimadamore@547 750 "unchecked.generic.array.creation",
mcimadamore@547 751 argtype);
mcimadamore@580 752 }
mcimadamore@547 753 }
mcimadamore@547 754
mcimadamore@821 755 /**
mcimadamore@821 756 * Check that type 't' is a valid instantiation of a generic class
mcimadamore@821 757 * (see JLS 4.5)
mcimadamore@821 758 *
mcimadamore@821 759 * @param t class type to be checked
mcimadamore@821 760 * @return true if 't' is well-formed
mcimadamore@821 761 */
mcimadamore@821 762 public boolean checkValidGenericType(Type t) {
mcimadamore@821 763 return firstIncompatibleTypeArg(t) == null;
mcimadamore@821 764 }
mcimadamore@821 765 //WHERE
mcimadamore@821 766 private Type firstIncompatibleTypeArg(Type type) {
mcimadamore@821 767 List<Type> formals = type.tsym.type.allparams();
mcimadamore@821 768 List<Type> actuals = type.allparams();
mcimadamore@821 769 List<Type> args = type.getTypeArguments();
mcimadamore@821 770 List<Type> forms = type.tsym.type.getTypeArguments();
mcimadamore@821 771 ListBuffer<Type> tvars_buf = new ListBuffer<Type>();
mcimadamore@821 772
mcimadamore@821 773 // For matching pairs of actual argument types `a' and
mcimadamore@821 774 // formal type parameters with declared bound `b' ...
mcimadamore@821 775 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@821 776 // exact type arguments needs to know their
mcimadamore@821 777 // bounds (for upper and lower bound
mcimadamore@821 778 // calculations). So we create new TypeVars with
mcimadamore@821 779 // bounds substed with actuals.
mcimadamore@821 780 tvars_buf.append(types.substBound(((TypeVar)forms.head),
mcimadamore@821 781 formals,
mcimadamore@821 782 actuals));
mcimadamore@821 783 args = args.tail;
mcimadamore@821 784 forms = forms.tail;
mcimadamore@821 785 }
mcimadamore@821 786
mcimadamore@821 787 args = type.getTypeArguments();
mcimadamore@821 788 List<Type> tvars_cap = types.substBounds(formals,
mcimadamore@821 789 formals,
mcimadamore@821 790 types.capture(type).allparams());
mcimadamore@821 791 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
mcimadamore@821 792 // Let the actual arguments know their bound
mcimadamore@821 793 args.head.withTypeVar((TypeVar)tvars_cap.head);
mcimadamore@821 794 args = args.tail;
mcimadamore@821 795 tvars_cap = tvars_cap.tail;
mcimadamore@821 796 }
mcimadamore@821 797
mcimadamore@821 798 args = type.getTypeArguments();
mcimadamore@821 799 List<Type> tvars = tvars_buf.toList();
mcimadamore@821 800
mcimadamore@821 801 while (args.nonEmpty() && tvars.nonEmpty()) {
mcimadamore@821 802 Type actual = types.subst(args.head,
mcimadamore@821 803 type.tsym.type.getTypeArguments(),
mcimadamore@821 804 tvars_buf.toList());
mcimadamore@828 805 if (!checkExtends(actual, (TypeVar)tvars.head) &&
mcimadamore@828 806 !tvars.head.getUpperBound().isErroneous()) {
mcimadamore@821 807 return args.head;
mcimadamore@821 808 }
mcimadamore@821 809 args = args.tail;
mcimadamore@821 810 tvars = tvars.tail;
mcimadamore@821 811 }
mcimadamore@821 812
mcimadamore@821 813 args = type.getTypeArguments();
mcimadamore@828 814 tvars = tvars_buf.toList();
mcimadamore@821 815
mcimadamore@821 816 for (Type arg : types.capture(type).getTypeArguments()) {
mcimadamore@828 817 if (arg.tag == TYPEVAR &&
mcimadamore@828 818 arg.getUpperBound().isErroneous() &&
mcimadamore@828 819 !tvars.head.getUpperBound().isErroneous()) {
mcimadamore@821 820 return args.head;
mcimadamore@821 821 }
mcimadamore@828 822 tvars = tvars.tail;
mcimadamore@821 823 }
mcimadamore@821 824
mcimadamore@821 825 return null;
mcimadamore@821 826 }
mcimadamore@821 827
duke@1 828 /** Check that given modifiers are legal for given symbol and
duke@1 829 * return modifiers together with any implicit modififiers for that symbol.
duke@1 830 * Warning: we can't use flags() here since this method
duke@1 831 * is called during class enter, when flags() would cause a premature
duke@1 832 * completion.
duke@1 833 * @param pos Position to be used for error reporting.
duke@1 834 * @param flags The set of modifiers given in a definition.
duke@1 835 * @param sym The defined symbol.
duke@1 836 */
duke@1 837 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
duke@1 838 long mask;
duke@1 839 long implicit = 0;
duke@1 840 switch (sym.kind) {
duke@1 841 case VAR:
duke@1 842 if (sym.owner.kind != TYP)
duke@1 843 mask = LocalVarFlags;
duke@1 844 else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 845 mask = implicit = InterfaceVarFlags;
duke@1 846 else
duke@1 847 mask = VarFlags;
duke@1 848 break;
duke@1 849 case MTH:
duke@1 850 if (sym.name == names.init) {
duke@1 851 if ((sym.owner.flags_field & ENUM) != 0) {
duke@1 852 // enum constructors cannot be declared public or
duke@1 853 // protected and must be implicitly or explicitly
duke@1 854 // private
duke@1 855 implicit = PRIVATE;
duke@1 856 mask = PRIVATE;
duke@1 857 } else
duke@1 858 mask = ConstructorFlags;
duke@1 859 } else if ((sym.owner.flags_field & INTERFACE) != 0)
duke@1 860 mask = implicit = InterfaceMethodFlags;
duke@1 861 else {
duke@1 862 mask = MethodFlags;
duke@1 863 }
duke@1 864 // Imply STRICTFP if owner has STRICTFP set.
duke@1 865 if (((flags|implicit) & Flags.ABSTRACT) == 0)
duke@1 866 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 867 break;
duke@1 868 case TYP:
duke@1 869 if (sym.isLocal()) {
duke@1 870 mask = LocalClassFlags;
jjg@113 871 if (sym.name.isEmpty()) { // Anonymous class
duke@1 872 // Anonymous classes in static methods are themselves static;
duke@1 873 // that's why we admit STATIC here.
duke@1 874 mask |= STATIC;
duke@1 875 // JLS: Anonymous classes are final.
duke@1 876 implicit |= FINAL;
duke@1 877 }
duke@1 878 if ((sym.owner.flags_field & STATIC) == 0 &&
duke@1 879 (flags & ENUM) != 0)
duke@1 880 log.error(pos, "enums.must.be.static");
duke@1 881 } else if (sym.owner.kind == TYP) {
duke@1 882 mask = MemberClassFlags;
duke@1 883 if (sym.owner.owner.kind == PCK ||
duke@1 884 (sym.owner.flags_field & STATIC) != 0)
duke@1 885 mask |= STATIC;
duke@1 886 else if ((flags & ENUM) != 0)
duke@1 887 log.error(pos, "enums.must.be.static");
duke@1 888 // Nested interfaces and enums are always STATIC (Spec ???)
duke@1 889 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
duke@1 890 } else {
duke@1 891 mask = ClassFlags;
duke@1 892 }
duke@1 893 // Interfaces are always ABSTRACT
duke@1 894 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
duke@1 895
duke@1 896 if ((flags & ENUM) != 0) {
duke@1 897 // enums can't be declared abstract or final
duke@1 898 mask &= ~(ABSTRACT | FINAL);
duke@1 899 implicit |= implicitEnumFinalFlag(tree);
duke@1 900 }
duke@1 901 // Imply STRICTFP if owner has STRICTFP set.
duke@1 902 implicit |= sym.owner.flags_field & STRICTFP;
duke@1 903 break;
duke@1 904 default:
duke@1 905 throw new AssertionError();
duke@1 906 }
duke@1 907 long illegal = flags & StandardFlags & ~mask;
duke@1 908 if (illegal != 0) {
duke@1 909 if ((illegal & INTERFACE) != 0) {
duke@1 910 log.error(pos, "intf.not.allowed.here");
duke@1 911 mask |= INTERFACE;
duke@1 912 }
duke@1 913 else {
duke@1 914 log.error(pos,
mcimadamore@80 915 "mod.not.allowed.here", asFlagSet(illegal));
duke@1 916 }
duke@1 917 }
duke@1 918 else if ((sym.kind == TYP ||
duke@1 919 // ISSUE: Disallowing abstract&private is no longer appropriate
duke@1 920 // in the presence of inner classes. Should it be deleted here?
duke@1 921 checkDisjoint(pos, flags,
duke@1 922 ABSTRACT,
duke@1 923 PRIVATE | STATIC))
duke@1 924 &&
duke@1 925 checkDisjoint(pos, flags,
duke@1 926 ABSTRACT | INTERFACE,
duke@1 927 FINAL | NATIVE | SYNCHRONIZED)
duke@1 928 &&
duke@1 929 checkDisjoint(pos, flags,
duke@1 930 PUBLIC,
duke@1 931 PRIVATE | PROTECTED)
duke@1 932 &&
duke@1 933 checkDisjoint(pos, flags,
duke@1 934 PRIVATE,
duke@1 935 PUBLIC | PROTECTED)
duke@1 936 &&
duke@1 937 checkDisjoint(pos, flags,
duke@1 938 FINAL,
duke@1 939 VOLATILE)
duke@1 940 &&
duke@1 941 (sym.kind == TYP ||
duke@1 942 checkDisjoint(pos, flags,
duke@1 943 ABSTRACT | NATIVE,
duke@1 944 STRICTFP))) {
duke@1 945 // skip
duke@1 946 }
duke@1 947 return flags & (mask | ~StandardFlags) | implicit;
duke@1 948 }
duke@1 949
duke@1 950
duke@1 951 /** Determine if this enum should be implicitly final.
duke@1 952 *
duke@1 953 * If the enum has no specialized enum contants, it is final.
duke@1 954 *
duke@1 955 * If the enum does have specialized enum contants, it is
duke@1 956 * <i>not</i> final.
duke@1 957 */
duke@1 958 private long implicitEnumFinalFlag(JCTree tree) {
duke@1 959 if (tree.getTag() != JCTree.CLASSDEF) return 0;
duke@1 960 class SpecialTreeVisitor extends JCTree.Visitor {
duke@1 961 boolean specialized;
duke@1 962 SpecialTreeVisitor() {
duke@1 963 this.specialized = false;
duke@1 964 };
duke@1 965
jjg@398 966 @Override
duke@1 967 public void visitTree(JCTree tree) { /* no-op */ }
duke@1 968
jjg@398 969 @Override
duke@1 970 public void visitVarDef(JCVariableDecl tree) {
duke@1 971 if ((tree.mods.flags & ENUM) != 0) {
duke@1 972 if (tree.init instanceof JCNewClass &&
duke@1 973 ((JCNewClass) tree.init).def != null) {
duke@1 974 specialized = true;
duke@1 975 }
duke@1 976 }
duke@1 977 }
duke@1 978 }
duke@1 979
duke@1 980 SpecialTreeVisitor sts = new SpecialTreeVisitor();
duke@1 981 JCClassDecl cdef = (JCClassDecl) tree;
duke@1 982 for (JCTree defs: cdef.defs) {
duke@1 983 defs.accept(sts);
duke@1 984 if (sts.specialized) return 0;
duke@1 985 }
duke@1 986 return FINAL;
duke@1 987 }
duke@1 988
duke@1 989 /* *************************************************************************
duke@1 990 * Type Validation
duke@1 991 **************************************************************************/
duke@1 992
duke@1 993 /** Validate a type expression. That is,
duke@1 994 * check that all type arguments of a parametric type are within
duke@1 995 * their bounds. This must be done in a second phase after type attributon
duke@1 996 * since a class might have a subclass as type parameter bound. E.g:
duke@1 997 *
duke@1 998 * class B<A extends C> { ... }
duke@1 999 * class C extends B<C> { ... }
duke@1 1000 *
duke@1 1001 * and we can't make sure that the bound is already attributed because
duke@1 1002 * of possible cycles.
mcimadamore@638 1003 *
mcimadamore@638 1004 * Visitor method: Validate a type expression, if it is not null, catching
duke@1 1005 * and reporting any completion failures.
duke@1 1006 */
mcimadamore@122 1007 void validate(JCTree tree, Env<AttrContext> env) {
mcimadamore@638 1008 validate(tree, env, true);
duke@1 1009 }
mcimadamore@638 1010 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
mcimadamore@638 1011 new Validator(env).validateTree(tree, checkRaw, true);
mcimadamore@122 1012 }
duke@1 1013
duke@1 1014 /** Visitor method: Validate a list of type expressions.
duke@1 1015 */
mcimadamore@122 1016 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
duke@1 1017 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@122 1018 validate(l.head, env);
duke@1 1019 }
duke@1 1020
duke@1 1021 /** A visitor class for type validation.
duke@1 1022 */
duke@1 1023 class Validator extends JCTree.Visitor {
duke@1 1024
mcimadamore@638 1025 boolean isOuter;
mcimadamore@638 1026 Env<AttrContext> env;
mcimadamore@638 1027
mcimadamore@638 1028 Validator(Env<AttrContext> env) {
mcimadamore@638 1029 this.env = env;
mcimadamore@638 1030 }
mcimadamore@638 1031
jjg@398 1032 @Override
duke@1 1033 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@638 1034 tree.elemtype.accept(this);
duke@1 1035 }
duke@1 1036
jjg@398 1037 @Override
duke@1 1038 public void visitTypeApply(JCTypeApply tree) {
duke@1 1039 if (tree.type.tag == CLASS) {
duke@1 1040 List<JCExpression> args = tree.arguments;
mcimadamore@158 1041 List<Type> forms = tree.type.tsym.type.getTypeArguments();
mcimadamore@821 1042
mcimadamore@821 1043 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
mcimadamore@821 1044 if (incompatibleArg != null) {
mcimadamore@821 1045 for (JCTree arg : tree.arguments) {
mcimadamore@821 1046 if (arg.type == incompatibleArg) {
mcimadamore@829 1047 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
mcimadamore@821 1048 }
mcimadamore@829 1049 forms = forms.tail;
mcimadamore@829 1050 }
mcimadamore@829 1051 }
mcimadamore@829 1052
mcimadamore@829 1053 forms = tree.type.tsym.type.getTypeArguments();
duke@1 1054
mcimadamore@638 1055 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
mcimadamore@638 1056
duke@1 1057 // For matching pairs of actual argument types `a' and
duke@1 1058 // formal type parameters with declared bound `b' ...
duke@1 1059 while (args.nonEmpty() && forms.nonEmpty()) {
mcimadamore@638 1060 validateTree(args.head,
mcimadamore@638 1061 !(isOuter && is_java_lang_Class),
mcimadamore@638 1062 false);
duke@1 1063 args = args.tail;
duke@1 1064 forms = forms.tail;
duke@1 1065 }
duke@1 1066
duke@1 1067 // Check that this type is either fully parameterized, or
duke@1 1068 // not parameterized at all.
duke@1 1069 if (tree.type.getEnclosingType().isRaw())
duke@1 1070 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
duke@1 1071 if (tree.clazz.getTag() == JCTree.SELECT)
duke@1 1072 visitSelectInternal((JCFieldAccess)tree.clazz);
duke@1 1073 }
duke@1 1074 }
duke@1 1075
jjg@398 1076 @Override
duke@1 1077 public void visitTypeParameter(JCTypeParameter tree) {
mcimadamore@638 1078 validateTrees(tree.bounds, true, isOuter);
duke@1 1079 checkClassBounds(tree.pos(), tree.type);
duke@1 1080 }
duke@1 1081
duke@1 1082 @Override
duke@1 1083 public void visitWildcard(JCWildcard tree) {
duke@1 1084 if (tree.inner != null)
mcimadamore@638 1085 validateTree(tree.inner, true, isOuter);
duke@1 1086 }
duke@1 1087
jjg@398 1088 @Override
duke@1 1089 public void visitSelect(JCFieldAccess tree) {
duke@1 1090 if (tree.type.tag == CLASS) {
duke@1 1091 visitSelectInternal(tree);
duke@1 1092
duke@1 1093 // Check that this type is either fully parameterized, or
duke@1 1094 // not parameterized at all.
duke@1 1095 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
duke@1 1096 log.error(tree.pos(), "improperly.formed.type.param.missing");
duke@1 1097 }
duke@1 1098 }
duke@1 1099 public void visitSelectInternal(JCFieldAccess tree) {
mcimadamore@122 1100 if (tree.type.tsym.isStatic() &&
duke@1 1101 tree.selected.type.isParameterized()) {
duke@1 1102 // The enclosing type is not a class, so we are
duke@1 1103 // looking at a static member type. However, the
duke@1 1104 // qualifying expression is parameterized.
duke@1 1105 log.error(tree.pos(), "cant.select.static.class.from.param.type");
duke@1 1106 } else {
duke@1 1107 // otherwise validate the rest of the expression
mcimadamore@122 1108 tree.selected.accept(this);
duke@1 1109 }
duke@1 1110 }
duke@1 1111
duke@1 1112 /** Default visitor method: do nothing.
duke@1 1113 */
jjg@398 1114 @Override
duke@1 1115 public void visitTree(JCTree tree) {
duke@1 1116 }
mcimadamore@122 1117
mcimadamore@638 1118 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1119 try {
mcimadamore@638 1120 if (tree != null) {
mcimadamore@638 1121 this.isOuter = isOuter;
mcimadamore@638 1122 tree.accept(this);
mcimadamore@638 1123 if (checkRaw)
mcimadamore@638 1124 checkRaw(tree, env);
mcimadamore@638 1125 }
mcimadamore@638 1126 } catch (CompletionFailure ex) {
mcimadamore@638 1127 completionError(tree.pos(), ex);
mcimadamore@638 1128 }
mcimadamore@638 1129 }
mcimadamore@638 1130
mcimadamore@638 1131 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
mcimadamore@638 1132 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
mcimadamore@638 1133 validateTree(l.head, checkRaw, isOuter);
mcimadamore@638 1134 }
mcimadamore@638 1135
mcimadamore@638 1136 void checkRaw(JCTree tree, Env<AttrContext> env) {
mcimadamore@795 1137 if (lint.isEnabled(LintCategory.RAW) &&
mcimadamore@638 1138 tree.type.tag == CLASS &&
mcimadamore@638 1139 !TreeInfo.isDiamond(tree) &&
mcimadamore@638 1140 !env.enclClass.name.isEmpty() && //anonymous or intersection
mcimadamore@638 1141 tree.type.isRaw()) {
mcimadamore@795 1142 log.warning(LintCategory.RAW,
mcimadamore@638 1143 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
mcimadamore@638 1144 }
mcimadamore@638 1145 }
duke@1 1146 }
duke@1 1147
duke@1 1148 /* *************************************************************************
duke@1 1149 * Exception checking
duke@1 1150 **************************************************************************/
duke@1 1151
duke@1 1152 /* The following methods treat classes as sets that contain
duke@1 1153 * the class itself and all their subclasses
duke@1 1154 */
duke@1 1155
duke@1 1156 /** Is given type a subtype of some of the types in given list?
duke@1 1157 */
duke@1 1158 boolean subset(Type t, List<Type> ts) {
duke@1 1159 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1160 if (types.isSubtype(t, l.head)) return true;
duke@1 1161 return false;
duke@1 1162 }
duke@1 1163
duke@1 1164 /** Is given type a subtype or supertype of
duke@1 1165 * some of the types in given list?
duke@1 1166 */
duke@1 1167 boolean intersects(Type t, List<Type> ts) {
duke@1 1168 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
duke@1 1169 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
duke@1 1170 return false;
duke@1 1171 }
duke@1 1172
duke@1 1173 /** Add type set to given type list, unless it is a subclass of some class
duke@1 1174 * in the list.
duke@1 1175 */
duke@1 1176 List<Type> incl(Type t, List<Type> ts) {
duke@1 1177 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
duke@1 1178 }
duke@1 1179
duke@1 1180 /** Remove type set from type set list.
duke@1 1181 */
duke@1 1182 List<Type> excl(Type t, List<Type> ts) {
duke@1 1183 if (ts.isEmpty()) {
duke@1 1184 return ts;
duke@1 1185 } else {
duke@1 1186 List<Type> ts1 = excl(t, ts.tail);
duke@1 1187 if (types.isSubtype(ts.head, t)) return ts1;
duke@1 1188 else if (ts1 == ts.tail) return ts;
duke@1 1189 else return ts1.prepend(ts.head);
duke@1 1190 }
duke@1 1191 }
duke@1 1192
duke@1 1193 /** Form the union of two type set lists.
duke@1 1194 */
duke@1 1195 List<Type> union(List<Type> ts1, List<Type> ts2) {
duke@1 1196 List<Type> ts = ts1;
duke@1 1197 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1198 ts = incl(l.head, ts);
duke@1 1199 return ts;
duke@1 1200 }
duke@1 1201
duke@1 1202 /** Form the difference of two type lists.
duke@1 1203 */
duke@1 1204 List<Type> diff(List<Type> ts1, List<Type> ts2) {
duke@1 1205 List<Type> ts = ts1;
duke@1 1206 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1207 ts = excl(l.head, ts);
duke@1 1208 return ts;
duke@1 1209 }
duke@1 1210
duke@1 1211 /** Form the intersection of two type lists.
duke@1 1212 */
duke@1 1213 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
duke@1 1214 List<Type> ts = List.nil();
duke@1 1215 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
duke@1 1216 if (subset(l.head, ts2)) ts = incl(l.head, ts);
duke@1 1217 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
duke@1 1218 if (subset(l.head, ts1)) ts = incl(l.head, ts);
duke@1 1219 return ts;
duke@1 1220 }
duke@1 1221
duke@1 1222 /** Is exc an exception symbol that need not be declared?
duke@1 1223 */
duke@1 1224 boolean isUnchecked(ClassSymbol exc) {
duke@1 1225 return
duke@1 1226 exc.kind == ERR ||
duke@1 1227 exc.isSubClass(syms.errorType.tsym, types) ||
duke@1 1228 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
duke@1 1229 }
duke@1 1230
duke@1 1231 /** Is exc an exception type that need not be declared?
duke@1 1232 */
duke@1 1233 boolean isUnchecked(Type exc) {
duke@1 1234 return
duke@1 1235 (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
duke@1 1236 (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
duke@1 1237 exc.tag == BOT;
duke@1 1238 }
duke@1 1239
duke@1 1240 /** Same, but handling completion failures.
duke@1 1241 */
duke@1 1242 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
duke@1 1243 try {
duke@1 1244 return isUnchecked(exc);
duke@1 1245 } catch (CompletionFailure ex) {
duke@1 1246 completionError(pos, ex);
duke@1 1247 return true;
duke@1 1248 }
duke@1 1249 }
duke@1 1250
duke@1 1251 /** Is exc handled by given exception list?
duke@1 1252 */
duke@1 1253 boolean isHandled(Type exc, List<Type> handled) {
duke@1 1254 return isUnchecked(exc) || subset(exc, handled);
duke@1 1255 }
duke@1 1256
duke@1 1257 /** Return all exceptions in thrown list that are not in handled list.
duke@1 1258 * @param thrown The list of thrown exceptions.
duke@1 1259 * @param handled The list of handled exceptions.
duke@1 1260 */
mcimadamore@362 1261 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
duke@1 1262 List<Type> unhandled = List.nil();
duke@1 1263 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
duke@1 1264 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
duke@1 1265 return unhandled;
duke@1 1266 }
duke@1 1267
duke@1 1268 /* *************************************************************************
duke@1 1269 * Overriding/Implementation checking
duke@1 1270 **************************************************************************/
duke@1 1271
duke@1 1272 /** The level of access protection given by a flag set,
duke@1 1273 * where PRIVATE is highest and PUBLIC is lowest.
duke@1 1274 */
duke@1 1275 static int protection(long flags) {
duke@1 1276 switch ((short)(flags & AccessFlags)) {
duke@1 1277 case PRIVATE: return 3;
duke@1 1278 case PROTECTED: return 1;
duke@1 1279 default:
duke@1 1280 case PUBLIC: return 0;
duke@1 1281 case 0: return 2;
duke@1 1282 }
duke@1 1283 }
duke@1 1284
duke@1 1285 /** A customized "cannot override" error message.
duke@1 1286 * @param m The overriding method.
duke@1 1287 * @param other The overridden method.
duke@1 1288 * @return An internationalized string.
duke@1 1289 */
mcimadamore@89 1290 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
duke@1 1291 String key;
duke@1 1292 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1293 key = "cant.override";
duke@1 1294 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1295 key = "cant.implement";
duke@1 1296 else
duke@1 1297 key = "clashes.with";
mcimadamore@89 1298 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1299 }
duke@1 1300
duke@1 1301 /** A customized "override" warning message.
duke@1 1302 * @param m The overriding method.
duke@1 1303 * @param other The overridden method.
duke@1 1304 * @return An internationalized string.
duke@1 1305 */
mcimadamore@89 1306 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1307 String key;
duke@1 1308 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1309 key = "unchecked.override";
duke@1 1310 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1311 key = "unchecked.implement";
duke@1 1312 else
duke@1 1313 key = "unchecked.clash.with";
mcimadamore@89 1314 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1315 }
duke@1 1316
duke@1 1317 /** A customized "override" warning message.
duke@1 1318 * @param m The overriding method.
duke@1 1319 * @param other The overridden method.
duke@1 1320 * @return An internationalized string.
duke@1 1321 */
mcimadamore@89 1322 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
duke@1 1323 String key;
duke@1 1324 if ((other.owner.flags() & INTERFACE) == 0)
duke@1 1325 key = "varargs.override";
duke@1 1326 else if ((m.owner.flags() & INTERFACE) == 0)
duke@1 1327 key = "varargs.implement";
duke@1 1328 else
duke@1 1329 key = "varargs.clash.with";
mcimadamore@89 1330 return diags.fragment(key, m, m.location(), other, other.location());
duke@1 1331 }
duke@1 1332
duke@1 1333 /** Check that this method conforms with overridden method 'other'.
duke@1 1334 * where `origin' is the class where checking started.
duke@1 1335 * Complications:
duke@1 1336 * (1) Do not check overriding of synthetic methods
duke@1 1337 * (reason: they might be final).
duke@1 1338 * todo: check whether this is still necessary.
duke@1 1339 * (2) Admit the case where an interface proxy throws fewer exceptions
duke@1 1340 * than the method it implements. Augment the proxy methods with the
duke@1 1341 * undeclared exceptions in this case.
duke@1 1342 * (3) When generics are enabled, admit the case where an interface proxy
duke@1 1343 * has a result type
duke@1 1344 * extended by the result type of the method it implements.
duke@1 1345 * Change the proxies result type to the smaller type in this case.
duke@1 1346 *
duke@1 1347 * @param tree The tree from which positions
duke@1 1348 * are extracted for errors.
duke@1 1349 * @param m The overriding method.
duke@1 1350 * @param other The overridden method.
duke@1 1351 * @param origin The class of which the overriding method
duke@1 1352 * is a member.
duke@1 1353 */
duke@1 1354 void checkOverride(JCTree tree,
duke@1 1355 MethodSymbol m,
duke@1 1356 MethodSymbol other,
duke@1 1357 ClassSymbol origin) {
duke@1 1358 // Don't check overriding of synthetic methods or by bridge methods.
duke@1 1359 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
duke@1 1360 return;
duke@1 1361 }
duke@1 1362
duke@1 1363 // Error if static method overrides instance method (JLS 8.4.6.2).
duke@1 1364 if ((m.flags() & STATIC) != 0 &&
duke@1 1365 (other.flags() & STATIC) == 0) {
duke@1 1366 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
duke@1 1367 cannotOverride(m, other));
duke@1 1368 return;
duke@1 1369 }
duke@1 1370
duke@1 1371 // Error if instance method overrides static or final
duke@1 1372 // method (JLS 8.4.6.1).
duke@1 1373 if ((other.flags() & FINAL) != 0 ||
duke@1 1374 (m.flags() & STATIC) == 0 &&
duke@1 1375 (other.flags() & STATIC) != 0) {
duke@1 1376 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
duke@1 1377 cannotOverride(m, other),
mcimadamore@80 1378 asFlagSet(other.flags() & (FINAL | STATIC)));
duke@1 1379 return;
duke@1 1380 }
duke@1 1381
duke@1 1382 if ((m.owner.flags() & ANNOTATION) != 0) {
duke@1 1383 // handled in validateAnnotationMethod
duke@1 1384 return;
duke@1 1385 }
duke@1 1386
duke@1 1387 // Error if overriding method has weaker access (JLS 8.4.6.3).
duke@1 1388 if ((origin.flags() & INTERFACE) == 0 &&
duke@1 1389 protection(m.flags()) > protection(other.flags())) {
duke@1 1390 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
duke@1 1391 cannotOverride(m, other),
mcimadamore@80 1392 other.flags() == 0 ?
mcimadamore@80 1393 Flag.PACKAGE :
mcimadamore@80 1394 asFlagSet(other.flags() & AccessFlags));
duke@1 1395 return;
duke@1 1396 }
duke@1 1397
duke@1 1398 Type mt = types.memberType(origin.type, m);
duke@1 1399 Type ot = types.memberType(origin.type, other);
duke@1 1400 // Error if overriding result type is different
duke@1 1401 // (or, in the case of generics mode, not a subtype) of
duke@1 1402 // overridden result type. We have to rename any type parameters
duke@1 1403 // before comparing types.
duke@1 1404 List<Type> mtvars = mt.getTypeArguments();
duke@1 1405 List<Type> otvars = ot.getTypeArguments();
duke@1 1406 Type mtres = mt.getReturnType();
duke@1 1407 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
duke@1 1408
mcimadamore@795 1409 overrideWarner.clear();
duke@1 1410 boolean resultTypesOK =
tbell@202 1411 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
duke@1 1412 if (!resultTypesOK) {
jjg@398 1413 if (!allowCovariantReturns &&
duke@1 1414 m.owner != origin &&
duke@1 1415 m.owner.isSubClass(other.owner, types)) {
duke@1 1416 // allow limited interoperability with covariant returns
duke@1 1417 } else {
mcimadamore@362 1418 log.error(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1419 "override.incompatible.ret",
mcimadamore@362 1420 cannotOverride(m, other),
duke@1 1421 mtres, otres);
duke@1 1422 return;
duke@1 1423 }
mcimadamore@795 1424 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
duke@1 1425 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1426 "override.unchecked.ret",
mcimadamore@362 1427 uncheckedOverrides(m, other),
mcimadamore@362 1428 mtres, otres);
duke@1 1429 }
duke@1 1430
duke@1 1431 // Error if overriding method throws an exception not reported
duke@1 1432 // by overridden method.
duke@1 1433 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
mcimadamore@362 1434 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
mcimadamore@362 1435 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
mcimadamore@362 1436 if (unhandledErased.nonEmpty()) {
duke@1 1437 log.error(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1438 "override.meth.doesnt.throw",
duke@1 1439 cannotOverride(m, other),
mcimadamore@362 1440 unhandledUnerased.head);
mcimadamore@362 1441 return;
mcimadamore@362 1442 }
mcimadamore@362 1443 else if (unhandledUnerased.nonEmpty()) {
mcimadamore@362 1444 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
mcimadamore@362 1445 "override.unchecked.thrown",
mcimadamore@362 1446 cannotOverride(m, other),
mcimadamore@362 1447 unhandledUnerased.head);
duke@1 1448 return;
duke@1 1449 }
duke@1 1450
duke@1 1451 // Optional warning if varargs don't agree
duke@1 1452 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
mcimadamore@795 1453 && lint.isEnabled(LintCategory.OVERRIDES)) {
duke@1 1454 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
duke@1 1455 ((m.flags() & Flags.VARARGS) != 0)
duke@1 1456 ? "override.varargs.missing"
duke@1 1457 : "override.varargs.extra",
duke@1 1458 varargsOverrides(m, other));
duke@1 1459 }
duke@1 1460
duke@1 1461 // Warn if instance method overrides bridge method (compiler spec ??)
duke@1 1462 if ((other.flags() & BRIDGE) != 0) {
duke@1 1463 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
duke@1 1464 uncheckedOverrides(m, other));
duke@1 1465 }
duke@1 1466
duke@1 1467 // Warn if a deprecated method overridden by a non-deprecated one.
duke@1 1468 if ((other.flags() & DEPRECATED) != 0
duke@1 1469 && (m.flags() & DEPRECATED) == 0
duke@1 1470 && m.outermostClass() != other.outermostClass()
duke@1 1471 && !isDeprecatedOverrideIgnorable(other, origin)) {
duke@1 1472 warnDeprecated(TreeInfo.diagnosticPositionFor(m, tree), other);
duke@1 1473 }
duke@1 1474 }
duke@1 1475 // where
duke@1 1476 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
duke@1 1477 // If the method, m, is defined in an interface, then ignore the issue if the method
duke@1 1478 // is only inherited via a supertype and also implemented in the supertype,
duke@1 1479 // because in that case, we will rediscover the issue when examining the method
duke@1 1480 // in the supertype.
duke@1 1481 // If the method, m, is not defined in an interface, then the only time we need to
duke@1 1482 // address the issue is when the method is the supertype implemementation: any other
duke@1 1483 // case, we will have dealt with when examining the supertype classes
duke@1 1484 ClassSymbol mc = m.enclClass();
duke@1 1485 Type st = types.supertype(origin.type);
duke@1 1486 if (st.tag != CLASS)
duke@1 1487 return true;
duke@1 1488 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
duke@1 1489
duke@1 1490 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
duke@1 1491 List<Type> intfs = types.interfaces(origin.type);
duke@1 1492 return (intfs.contains(mc.type) ? false : (stimpl != null));
duke@1 1493 }
duke@1 1494 else
duke@1 1495 return (stimpl != m);
duke@1 1496 }
duke@1 1497
duke@1 1498
duke@1 1499 // used to check if there were any unchecked conversions
duke@1 1500 Warner overrideWarner = new Warner();
duke@1 1501
duke@1 1502 /** Check that a class does not inherit two concrete methods
duke@1 1503 * with the same signature.
duke@1 1504 * @param pos Position to be used for error reporting.
duke@1 1505 * @param site The class type to be checked.
duke@1 1506 */
duke@1 1507 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
duke@1 1508 Type sup = types.supertype(site);
duke@1 1509 if (sup.tag != CLASS) return;
duke@1 1510
duke@1 1511 for (Type t1 = sup;
duke@1 1512 t1.tsym.type.isParameterized();
duke@1 1513 t1 = types.supertype(t1)) {
duke@1 1514 for (Scope.Entry e1 = t1.tsym.members().elems;
duke@1 1515 e1 != null;
duke@1 1516 e1 = e1.sibling) {
duke@1 1517 Symbol s1 = e1.sym;
duke@1 1518 if (s1.kind != MTH ||
duke@1 1519 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1520 !s1.isInheritedIn(site.tsym, types) ||
duke@1 1521 ((MethodSymbol)s1).implementation(site.tsym,
duke@1 1522 types,
duke@1 1523 true) != s1)
duke@1 1524 continue;
duke@1 1525 Type st1 = types.memberType(t1, s1);
duke@1 1526 int s1ArgsLength = st1.getParameterTypes().length();
duke@1 1527 if (st1 == s1.type) continue;
duke@1 1528
duke@1 1529 for (Type t2 = sup;
duke@1 1530 t2.tag == CLASS;
duke@1 1531 t2 = types.supertype(t2)) {
mcimadamore@24 1532 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
duke@1 1533 e2.scope != null;
duke@1 1534 e2 = e2.next()) {
duke@1 1535 Symbol s2 = e2.sym;
duke@1 1536 if (s2 == s1 ||
duke@1 1537 s2.kind != MTH ||
duke@1 1538 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
duke@1 1539 s2.type.getParameterTypes().length() != s1ArgsLength ||
duke@1 1540 !s2.isInheritedIn(site.tsym, types) ||
duke@1 1541 ((MethodSymbol)s2).implementation(site.tsym,
duke@1 1542 types,
duke@1 1543 true) != s2)
duke@1 1544 continue;
duke@1 1545 Type st2 = types.memberType(t2, s2);
duke@1 1546 if (types.overrideEquivalent(st1, st2))
duke@1 1547 log.error(pos, "concrete.inheritance.conflict",
duke@1 1548 s1, t1, s2, t2, sup);
duke@1 1549 }
duke@1 1550 }
duke@1 1551 }
duke@1 1552 }
duke@1 1553 }
duke@1 1554
duke@1 1555 /** Check that classes (or interfaces) do not each define an abstract
duke@1 1556 * method with same name and arguments but incompatible return types.
duke@1 1557 * @param pos Position to be used for error reporting.
duke@1 1558 * @param t1 The first argument type.
duke@1 1559 * @param t2 The second argument type.
duke@1 1560 */
duke@1 1561 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1562 Type t1,
duke@1 1563 Type t2) {
duke@1 1564 return checkCompatibleAbstracts(pos, t1, t2,
duke@1 1565 types.makeCompoundType(t1, t2));
duke@1 1566 }
duke@1 1567
duke@1 1568 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
duke@1 1569 Type t1,
duke@1 1570 Type t2,
duke@1 1571 Type site) {
mcimadamore@746 1572 return firstIncompatibility(pos, t1, t2, site) == null;
duke@1 1573 }
duke@1 1574
duke@1 1575 /** Return the first method which is defined with same args
duke@1 1576 * but different return types in two given interfaces, or null if none
duke@1 1577 * exists.
duke@1 1578 * @param t1 The first type.
duke@1 1579 * @param t2 The second type.
duke@1 1580 * @param site The most derived type.
duke@1 1581 * @returns symbol from t2 that conflicts with one in t1.
duke@1 1582 */
mcimadamore@746 1583 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1584 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
duke@1 1585 closure(t1, interfaces1);
duke@1 1586 Map<TypeSymbol,Type> interfaces2;
duke@1 1587 if (t1 == t2)
duke@1 1588 interfaces2 = interfaces1;
duke@1 1589 else
duke@1 1590 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
duke@1 1591
duke@1 1592 for (Type t3 : interfaces1.values()) {
duke@1 1593 for (Type t4 : interfaces2.values()) {
mcimadamore@746 1594 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
duke@1 1595 if (s != null) return s;
duke@1 1596 }
duke@1 1597 }
duke@1 1598 return null;
duke@1 1599 }
duke@1 1600
duke@1 1601 /** Compute all the supertypes of t, indexed by type symbol. */
duke@1 1602 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
duke@1 1603 if (t.tag != CLASS) return;
duke@1 1604 if (typeMap.put(t.tsym, t) == null) {
duke@1 1605 closure(types.supertype(t), typeMap);
duke@1 1606 for (Type i : types.interfaces(t))
duke@1 1607 closure(i, typeMap);
duke@1 1608 }
duke@1 1609 }
duke@1 1610
duke@1 1611 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
duke@1 1612 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
duke@1 1613 if (t.tag != CLASS) return;
duke@1 1614 if (typesSkip.get(t.tsym) != null) return;
duke@1 1615 if (typeMap.put(t.tsym, t) == null) {
duke@1 1616 closure(types.supertype(t), typesSkip, typeMap);
duke@1 1617 for (Type i : types.interfaces(t))
duke@1 1618 closure(i, typesSkip, typeMap);
duke@1 1619 }
duke@1 1620 }
duke@1 1621
duke@1 1622 /** Return the first method in t2 that conflicts with a method from t1. */
mcimadamore@746 1623 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
duke@1 1624 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
duke@1 1625 Symbol s1 = e1.sym;
duke@1 1626 Type st1 = null;
duke@1 1627 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
duke@1 1628 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
duke@1 1629 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
duke@1 1630 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
duke@1 1631 Symbol s2 = e2.sym;
duke@1 1632 if (s1 == s2) continue;
duke@1 1633 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
duke@1 1634 if (st1 == null) st1 = types.memberType(t1, s1);
duke@1 1635 Type st2 = types.memberType(t2, s2);
duke@1 1636 if (types.overrideEquivalent(st1, st2)) {
duke@1 1637 List<Type> tvars1 = st1.getTypeArguments();
duke@1 1638 List<Type> tvars2 = st2.getTypeArguments();
duke@1 1639 Type rt1 = st1.getReturnType();
duke@1 1640 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
duke@1 1641 boolean compat =
duke@1 1642 types.isSameType(rt1, rt2) ||
duke@1 1643 rt1.tag >= CLASS && rt2.tag >= CLASS &&
duke@1 1644 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
mcimadamore@59 1645 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
mcimadamore@59 1646 checkCommonOverriderIn(s1,s2,site);
mcimadamore@746 1647 if (!compat) {
mcimadamore@746 1648 log.error(pos, "types.incompatible.diff.ret",
mcimadamore@746 1649 t1, t2, s2.name +
mcimadamore@746 1650 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
mcimadamore@746 1651 return s2;
mcimadamore@746 1652 }
mcimadamore@746 1653 } else if (!checkNameClash((ClassSymbol)site.tsym, s1, s2)) {
mcimadamore@746 1654 log.error(pos,
mcimadamore@746 1655 "name.clash.same.erasure.no.override",
mcimadamore@746 1656 s1, s1.location(),
mcimadamore@746 1657 s2, s2.location());
mcimadamore@746 1658 return s2;
duke@1 1659 }
duke@1 1660 }
duke@1 1661 }
duke@1 1662 return null;
duke@1 1663 }
mcimadamore@59 1664 //WHERE
mcimadamore@59 1665 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
mcimadamore@59 1666 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
mcimadamore@59 1667 Type st1 = types.memberType(site, s1);
mcimadamore@59 1668 Type st2 = types.memberType(site, s2);
mcimadamore@59 1669 closure(site, supertypes);
mcimadamore@59 1670 for (Type t : supertypes.values()) {
mcimadamore@59 1671 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
mcimadamore@59 1672 Symbol s3 = e.sym;
mcimadamore@59 1673 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
mcimadamore@59 1674 Type st3 = types.memberType(site,s3);
mcimadamore@59 1675 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
mcimadamore@59 1676 if (s3.owner == site.tsym) {
mcimadamore@59 1677 return true;
mcimadamore@59 1678 }
mcimadamore@59 1679 List<Type> tvars1 = st1.getTypeArguments();
mcimadamore@59 1680 List<Type> tvars2 = st2.getTypeArguments();
mcimadamore@59 1681 List<Type> tvars3 = st3.getTypeArguments();
mcimadamore@59 1682 Type rt1 = st1.getReturnType();
mcimadamore@59 1683 Type rt2 = st2.getReturnType();
mcimadamore@59 1684 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
mcimadamore@59 1685 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
mcimadamore@59 1686 boolean compat =
mcimadamore@59 1687 rt13.tag >= CLASS && rt23.tag >= CLASS &&
mcimadamore@59 1688 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
mcimadamore@59 1689 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
mcimadamore@59 1690 if (compat)
mcimadamore@59 1691 return true;
mcimadamore@59 1692 }
mcimadamore@59 1693 }
mcimadamore@59 1694 }
mcimadamore@59 1695 return false;
mcimadamore@59 1696 }
duke@1 1697
duke@1 1698 /** Check that a given method conforms with any method it overrides.
duke@1 1699 * @param tree The tree from which positions are extracted
duke@1 1700 * for errors.
duke@1 1701 * @param m The overriding method.
duke@1 1702 */
duke@1 1703 void checkOverride(JCTree tree, MethodSymbol m) {
duke@1 1704 ClassSymbol origin = (ClassSymbol)m.owner;
duke@1 1705 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
duke@1 1706 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
duke@1 1707 log.error(tree.pos(), "enum.no.finalize");
duke@1 1708 return;
duke@1 1709 }
mcimadamore@746 1710 for (Type t = origin.type; t.tag == CLASS;
duke@1 1711 t = types.supertype(t)) {
mcimadamore@746 1712 if (t != origin.type) {
mcimadamore@746 1713 checkOverride(tree, t, origin, m);
mcimadamore@746 1714 }
mcimadamore@746 1715 for (Type t2 : types.interfaces(t)) {
mcimadamore@746 1716 checkOverride(tree, t2, origin, m);
duke@1 1717 }
duke@1 1718 }
duke@1 1719 }
duke@1 1720
mcimadamore@746 1721 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
mcimadamore@746 1722 TypeSymbol c = site.tsym;
mcimadamore@746 1723 Scope.Entry e = c.members().lookup(m.name);
mcimadamore@746 1724 while (e.scope != null) {
mcimadamore@746 1725 if (m.overrides(e.sym, origin, types, false)) {
mcimadamore@746 1726 if ((e.sym.flags() & ABSTRACT) == 0) {
mcimadamore@746 1727 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
mcimadamore@746 1728 }
mcimadamore@746 1729 }
mcimadamore@746 1730 e = e.next();
mcimadamore@746 1731 }
mcimadamore@746 1732 }
mcimadamore@746 1733
mcimadamore@746 1734 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
mcimadamore@746 1735 if (s1.kind == MTH &&
mcimadamore@746 1736 s1.isInheritedIn(origin, types) &&
mcimadamore@746 1737 (s1.flags() & SYNTHETIC) == 0 &&
mcimadamore@746 1738 !s2.isConstructor()) {
mcimadamore@746 1739 Type er1 = s2.erasure(types);
mcimadamore@746 1740 Type er2 = s1.erasure(types);
mcimadamore@746 1741 if (types.isSameTypes(er1.getParameterTypes(),
mcimadamore@746 1742 er2.getParameterTypes())) {
mcimadamore@746 1743 return false;
mcimadamore@746 1744 }
mcimadamore@746 1745 }
mcimadamore@746 1746 return true;
mcimadamore@746 1747 }
mcimadamore@746 1748
mcimadamore@746 1749
duke@1 1750 /** Check that all abstract members of given class have definitions.
duke@1 1751 * @param pos Position to be used for error reporting.
duke@1 1752 * @param c The class.
duke@1 1753 */
duke@1 1754 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1755 try {
duke@1 1756 MethodSymbol undef = firstUndef(c, c);
duke@1 1757 if (undef != null) {
duke@1 1758 if ((c.flags() & ENUM) != 0 &&
duke@1 1759 types.supertype(c.type).tsym == syms.enumSym &&
duke@1 1760 (c.flags() & FINAL) == 0) {
duke@1 1761 // add the ABSTRACT flag to an enum
duke@1 1762 c.flags_field |= ABSTRACT;
duke@1 1763 } else {
duke@1 1764 MethodSymbol undef1 =
duke@1 1765 new MethodSymbol(undef.flags(), undef.name,
duke@1 1766 types.memberType(c.type, undef), undef.owner);
duke@1 1767 log.error(pos, "does.not.override.abstract",
duke@1 1768 c, undef1, undef1.location());
duke@1 1769 }
duke@1 1770 }
duke@1 1771 } catch (CompletionFailure ex) {
duke@1 1772 completionError(pos, ex);
duke@1 1773 }
duke@1 1774 }
duke@1 1775 //where
duke@1 1776 /** Return first abstract member of class `c' that is not defined
duke@1 1777 * in `impl', null if there is none.
duke@1 1778 */
duke@1 1779 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
duke@1 1780 MethodSymbol undef = null;
duke@1 1781 // Do not bother to search in classes that are not abstract,
duke@1 1782 // since they cannot have abstract members.
duke@1 1783 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
duke@1 1784 Scope s = c.members();
duke@1 1785 for (Scope.Entry e = s.elems;
duke@1 1786 undef == null && e != null;
duke@1 1787 e = e.sibling) {
duke@1 1788 if (e.sym.kind == MTH &&
duke@1 1789 (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
duke@1 1790 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 1791 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
duke@1 1792 if (implmeth == null || implmeth == absmeth)
duke@1 1793 undef = absmeth;
duke@1 1794 }
duke@1 1795 }
duke@1 1796 if (undef == null) {
duke@1 1797 Type st = types.supertype(c.type);
duke@1 1798 if (st.tag == CLASS)
duke@1 1799 undef = firstUndef(impl, (ClassSymbol)st.tsym);
duke@1 1800 }
duke@1 1801 for (List<Type> l = types.interfaces(c.type);
duke@1 1802 undef == null && l.nonEmpty();
duke@1 1803 l = l.tail) {
duke@1 1804 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
duke@1 1805 }
duke@1 1806 }
duke@1 1807 return undef;
duke@1 1808 }
duke@1 1809
mcimadamore@690 1810 void checkNonCyclicDecl(JCClassDecl tree) {
mcimadamore@690 1811 CycleChecker cc = new CycleChecker();
mcimadamore@690 1812 cc.scan(tree);
mcimadamore@690 1813 if (!cc.errorFound && !cc.partialCheck) {
mcimadamore@690 1814 tree.sym.flags_field |= ACYCLIC;
mcimadamore@690 1815 }
mcimadamore@690 1816 }
mcimadamore@690 1817
mcimadamore@690 1818 class CycleChecker extends TreeScanner {
mcimadamore@690 1819
mcimadamore@690 1820 List<Symbol> seenClasses = List.nil();
mcimadamore@690 1821 boolean errorFound = false;
mcimadamore@690 1822 boolean partialCheck = false;
mcimadamore@690 1823
mcimadamore@690 1824 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
mcimadamore@690 1825 if (sym != null && sym.kind == TYP) {
mcimadamore@690 1826 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
mcimadamore@690 1827 if (classEnv != null) {
mcimadamore@690 1828 DiagnosticSource prevSource = log.currentSource();
mcimadamore@690 1829 try {
mcimadamore@690 1830 log.useSource(classEnv.toplevel.sourcefile);
mcimadamore@690 1831 scan(classEnv.tree);
mcimadamore@690 1832 }
mcimadamore@690 1833 finally {
mcimadamore@690 1834 log.useSource(prevSource.getFile());
mcimadamore@690 1835 }
mcimadamore@690 1836 } else if (sym.kind == TYP) {
mcimadamore@690 1837 checkClass(pos, sym, List.<JCTree>nil());
mcimadamore@690 1838 }
mcimadamore@690 1839 } else {
mcimadamore@690 1840 //not completed yet
mcimadamore@690 1841 partialCheck = true;
mcimadamore@690 1842 }
mcimadamore@690 1843 }
mcimadamore@690 1844
mcimadamore@690 1845 @Override
mcimadamore@690 1846 public void visitSelect(JCFieldAccess tree) {
mcimadamore@690 1847 super.visitSelect(tree);
mcimadamore@690 1848 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 1849 }
mcimadamore@690 1850
mcimadamore@690 1851 @Override
mcimadamore@690 1852 public void visitIdent(JCIdent tree) {
mcimadamore@690 1853 checkSymbol(tree.pos(), tree.sym);
mcimadamore@690 1854 }
mcimadamore@690 1855
mcimadamore@690 1856 @Override
mcimadamore@690 1857 public void visitTypeApply(JCTypeApply tree) {
mcimadamore@690 1858 scan(tree.clazz);
mcimadamore@690 1859 }
mcimadamore@690 1860
mcimadamore@690 1861 @Override
mcimadamore@690 1862 public void visitTypeArray(JCArrayTypeTree tree) {
mcimadamore@690 1863 scan(tree.elemtype);
mcimadamore@690 1864 }
mcimadamore@690 1865
mcimadamore@690 1866 @Override
mcimadamore@690 1867 public void visitClassDef(JCClassDecl tree) {
mcimadamore@690 1868 List<JCTree> supertypes = List.nil();
mcimadamore@690 1869 if (tree.getExtendsClause() != null) {
mcimadamore@690 1870 supertypes = supertypes.prepend(tree.getExtendsClause());
mcimadamore@690 1871 }
mcimadamore@690 1872 if (tree.getImplementsClause() != null) {
mcimadamore@690 1873 for (JCTree intf : tree.getImplementsClause()) {
mcimadamore@690 1874 supertypes = supertypes.prepend(intf);
mcimadamore@690 1875 }
mcimadamore@690 1876 }
mcimadamore@690 1877 checkClass(tree.pos(), tree.sym, supertypes);
mcimadamore@690 1878 }
mcimadamore@690 1879
mcimadamore@690 1880 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
mcimadamore@690 1881 if ((c.flags_field & ACYCLIC) != 0)
mcimadamore@690 1882 return;
mcimadamore@690 1883 if (seenClasses.contains(c)) {
mcimadamore@690 1884 errorFound = true;
mcimadamore@690 1885 noteCyclic(pos, (ClassSymbol)c);
mcimadamore@690 1886 } else if (!c.type.isErroneous()) {
mcimadamore@690 1887 try {
mcimadamore@690 1888 seenClasses = seenClasses.prepend(c);
mcimadamore@690 1889 if (c.type.tag == CLASS) {
mcimadamore@690 1890 if (supertypes.nonEmpty()) {
mcimadamore@690 1891 scan(supertypes);
mcimadamore@690 1892 }
mcimadamore@690 1893 else {
mcimadamore@690 1894 ClassType ct = (ClassType)c.type;
mcimadamore@690 1895 if (ct.supertype_field == null ||
mcimadamore@690 1896 ct.interfaces_field == null) {
mcimadamore@690 1897 //not completed yet
mcimadamore@690 1898 partialCheck = true;
mcimadamore@690 1899 return;
mcimadamore@690 1900 }
mcimadamore@690 1901 checkSymbol(pos, ct.supertype_field.tsym);
mcimadamore@690 1902 for (Type intf : ct.interfaces_field) {
mcimadamore@690 1903 checkSymbol(pos, intf.tsym);
mcimadamore@690 1904 }
mcimadamore@690 1905 }
mcimadamore@690 1906 if (c.owner.kind == TYP) {
mcimadamore@690 1907 checkSymbol(pos, c.owner);
mcimadamore@690 1908 }
mcimadamore@690 1909 }
mcimadamore@690 1910 } finally {
mcimadamore@690 1911 seenClasses = seenClasses.tail;
mcimadamore@690 1912 }
mcimadamore@690 1913 }
mcimadamore@690 1914 }
mcimadamore@690 1915 }
mcimadamore@690 1916
duke@1 1917 /** Check for cyclic references. Issue an error if the
duke@1 1918 * symbol of the type referred to has a LOCKED flag set.
duke@1 1919 *
duke@1 1920 * @param pos Position to be used for error reporting.
duke@1 1921 * @param t The type referred to.
duke@1 1922 */
duke@1 1923 void checkNonCyclic(DiagnosticPosition pos, Type t) {
duke@1 1924 checkNonCyclicInternal(pos, t);
duke@1 1925 }
duke@1 1926
duke@1 1927
duke@1 1928 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
mcimadamore@236 1929 checkNonCyclic1(pos, t, List.<TypeVar>nil());
duke@1 1930 }
duke@1 1931
mcimadamore@236 1932 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
duke@1 1933 final TypeVar tv;
mcimadamore@42 1934 if (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
mcimadamore@42 1935 return;
duke@1 1936 if (seen.contains(t)) {
duke@1 1937 tv = (TypeVar)t;
jjg@110 1938 tv.bound = types.createErrorType(t);
duke@1 1939 log.error(pos, "cyclic.inheritance", t);
duke@1 1940 } else if (t.tag == TYPEVAR) {
duke@1 1941 tv = (TypeVar)t;
mcimadamore@236 1942 seen = seen.prepend(tv);
duke@1 1943 for (Type b : types.getBounds(tv))
duke@1 1944 checkNonCyclic1(pos, b, seen);
duke@1 1945 }
duke@1 1946 }
duke@1 1947
duke@1 1948 /** Check for cyclic references. Issue an error if the
duke@1 1949 * symbol of the type referred to has a LOCKED flag set.
duke@1 1950 *
duke@1 1951 * @param pos Position to be used for error reporting.
duke@1 1952 * @param t The type referred to.
duke@1 1953 * @returns True if the check completed on all attributed classes
duke@1 1954 */
duke@1 1955 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
duke@1 1956 boolean complete = true; // was the check complete?
duke@1 1957 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
duke@1 1958 Symbol c = t.tsym;
duke@1 1959 if ((c.flags_field & ACYCLIC) != 0) return true;
duke@1 1960
duke@1 1961 if ((c.flags_field & LOCKED) != 0) {
duke@1 1962 noteCyclic(pos, (ClassSymbol)c);
duke@1 1963 } else if (!c.type.isErroneous()) {
duke@1 1964 try {
duke@1 1965 c.flags_field |= LOCKED;
duke@1 1966 if (c.type.tag == CLASS) {
duke@1 1967 ClassType clazz = (ClassType)c.type;
duke@1 1968 if (clazz.interfaces_field != null)
duke@1 1969 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
duke@1 1970 complete &= checkNonCyclicInternal(pos, l.head);
duke@1 1971 if (clazz.supertype_field != null) {
duke@1 1972 Type st = clazz.supertype_field;
duke@1 1973 if (st != null && st.tag == CLASS)
duke@1 1974 complete &= checkNonCyclicInternal(pos, st);
duke@1 1975 }
duke@1 1976 if (c.owner.kind == TYP)
duke@1 1977 complete &= checkNonCyclicInternal(pos, c.owner.type);
duke@1 1978 }
duke@1 1979 } finally {
duke@1 1980 c.flags_field &= ~LOCKED;
duke@1 1981 }
duke@1 1982 }
duke@1 1983 if (complete)
duke@1 1984 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
duke@1 1985 if (complete) c.flags_field |= ACYCLIC;
duke@1 1986 return complete;
duke@1 1987 }
duke@1 1988
duke@1 1989 /** Note that we found an inheritance cycle. */
duke@1 1990 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
duke@1 1991 log.error(pos, "cyclic.inheritance", c);
duke@1 1992 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
jjg@110 1993 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
duke@1 1994 Type st = types.supertype(c.type);
duke@1 1995 if (st.tag == CLASS)
jjg@110 1996 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
jjg@110 1997 c.type = types.createErrorType(c, c.type);
duke@1 1998 c.flags_field |= ACYCLIC;
duke@1 1999 }
duke@1 2000
duke@1 2001 /** Check that all methods which implement some
duke@1 2002 * method conform to the method they implement.
duke@1 2003 * @param tree The class definition whose members are checked.
duke@1 2004 */
duke@1 2005 void checkImplementations(JCClassDecl tree) {
duke@1 2006 checkImplementations(tree, tree.sym);
duke@1 2007 }
duke@1 2008 //where
duke@1 2009 /** Check that all methods which implement some
duke@1 2010 * method in `ic' conform to the method they implement.
duke@1 2011 */
duke@1 2012 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
duke@1 2013 ClassSymbol origin = tree.sym;
duke@1 2014 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
duke@1 2015 ClassSymbol lc = (ClassSymbol)l.head.tsym;
duke@1 2016 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
duke@1 2017 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
duke@1 2018 if (e.sym.kind == MTH &&
duke@1 2019 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
duke@1 2020 MethodSymbol absmeth = (MethodSymbol)e.sym;
duke@1 2021 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
duke@1 2022 if (implmeth != null && implmeth != absmeth &&
duke@1 2023 (implmeth.owner.flags() & INTERFACE) ==
duke@1 2024 (origin.flags() & INTERFACE)) {
duke@1 2025 // don't check if implmeth is in a class, yet
duke@1 2026 // origin is an interface. This case arises only
duke@1 2027 // if implmeth is declared in Object. The reason is
duke@1 2028 // that interfaces really don't inherit from
duke@1 2029 // Object it's just that the compiler represents
duke@1 2030 // things that way.
duke@1 2031 checkOverride(tree, implmeth, absmeth, origin);
duke@1 2032 }
duke@1 2033 }
duke@1 2034 }
duke@1 2035 }
duke@1 2036 }
duke@1 2037 }
duke@1 2038
duke@1 2039 /** Check that all abstract methods implemented by a class are
duke@1 2040 * mutually compatible.
duke@1 2041 * @param pos Position to be used for error reporting.
duke@1 2042 * @param c The class whose interfaces are checked.
duke@1 2043 */
duke@1 2044 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
duke@1 2045 List<Type> supertypes = types.interfaces(c);
duke@1 2046 Type supertype = types.supertype(c);
duke@1 2047 if (supertype.tag == CLASS &&
duke@1 2048 (supertype.tsym.flags() & ABSTRACT) != 0)
duke@1 2049 supertypes = supertypes.prepend(supertype);
duke@1 2050 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
duke@1 2051 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
duke@1 2052 !checkCompatibleAbstracts(pos, l.head, l.head, c))
duke@1 2053 return;
duke@1 2054 for (List<Type> m = supertypes; m != l; m = m.tail)
duke@1 2055 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
duke@1 2056 return;
duke@1 2057 }
duke@1 2058 checkCompatibleConcretes(pos, c);
duke@1 2059 }
duke@1 2060
mcimadamore@359 2061 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
mcimadamore@359 2062 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
mcimadamore@359 2063 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
mcimadamore@359 2064 // VM allows methods and variables with differing types
mcimadamore@359 2065 if (sym.kind == e.sym.kind &&
mcimadamore@359 2066 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
mcimadamore@359 2067 sym != e.sym &&
mcimadamore@359 2068 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
mcimadamore@608 2069 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
mcimadamore@359 2070 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
mcimadamore@359 2071 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
mcimadamore@359 2072 return;
mcimadamore@359 2073 }
mcimadamore@359 2074 }
mcimadamore@359 2075 }
mcimadamore@359 2076 }
mcimadamore@359 2077
mcimadamore@780 2078 /** Check that all non-override equivalent methods accessible from 'site'
mcimadamore@780 2079 * are mutually compatible (JLS 8.4.8/9.4.1).
mcimadamore@780 2080 *
mcimadamore@780 2081 * @param pos Position to be used for error reporting.
mcimadamore@780 2082 * @param site The class whose methods are checked.
mcimadamore@780 2083 * @param sym The method symbol to be checked.
mcimadamore@780 2084 */
mcimadamore@780 2085 void checkClashes(DiagnosticPosition pos, Type site, Symbol sym) {
mcimadamore@780 2086 List<Type> supertypes = types.closure(site);
mcimadamore@780 2087 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
mcimadamore@780 2088 for (List<Type> m = supertypes; m.nonEmpty(); m = m.tail) {
mcimadamore@780 2089 checkClashes(pos, l.head, m.head, site, sym);
mcimadamore@780 2090 }
mcimadamore@780 2091 }
mcimadamore@780 2092 }
mcimadamore@780 2093
mcimadamore@780 2094 /** Reports an error whenever 'sym' seen as a member of type 't1' clashes with
mcimadamore@780 2095 * some unrelated method defined in 't2'.
mcimadamore@780 2096 */
mcimadamore@780 2097 private void checkClashes(DiagnosticPosition pos, Type t1, Type t2, Type site, Symbol s1) {
mcimadamore@780 2098 ClashFilter cf = new ClashFilter(site);
mcimadamore@780 2099 s1 = ((MethodSymbol)s1).implementedIn(t1.tsym, types);
mcimadamore@780 2100 if (s1 == null) return;
mcimadamore@780 2101 Type st1 = types.memberType(site, s1);
mcimadamore@780 2102 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name, cf); e2.scope != null; e2 = e2.next(cf)) {
mcimadamore@780 2103 Symbol s2 = e2.sym;
mcimadamore@780 2104 if (s1 == s2) continue;
mcimadamore@780 2105 Type st2 = types.memberType(site, s2);
mcimadamore@780 2106 if (!types.overrideEquivalent(st1, st2) &&
mcimadamore@780 2107 !checkNameClash((ClassSymbol)site.tsym, s1, s2)) {
mcimadamore@780 2108 log.error(pos,
mcimadamore@780 2109 "name.clash.same.erasure.no.override",
mcimadamore@780 2110 s1, s1.location(),
mcimadamore@780 2111 s2, s2.location());
mcimadamore@780 2112 }
mcimadamore@780 2113 }
mcimadamore@780 2114 }
mcimadamore@780 2115 //where
mcimadamore@780 2116 private class ClashFilter implements Filter<Symbol> {
mcimadamore@780 2117
mcimadamore@780 2118 Type site;
mcimadamore@780 2119
mcimadamore@780 2120 ClashFilter(Type site) {
mcimadamore@780 2121 this.site = site;
mcimadamore@780 2122 }
mcimadamore@780 2123
mcimadamore@780 2124 public boolean accepts(Symbol s) {
mcimadamore@780 2125 return s.kind == MTH &&
mcimadamore@844 2126 (s.flags() & (SYNTHETIC | CLASH)) == 0 &&
mcimadamore@780 2127 s.isInheritedIn(site.tsym, types) &&
mcimadamore@780 2128 !s.isConstructor();
mcimadamore@780 2129 }
mcimadamore@780 2130 }
mcimadamore@780 2131
mcimadamore@359 2132 /** Report a conflict between a user symbol and a synthetic symbol.
mcimadamore@359 2133 */
mcimadamore@359 2134 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
mcimadamore@359 2135 if (!sym.type.isErroneous()) {
mcimadamore@359 2136 if (warnOnSyntheticConflicts) {
mcimadamore@359 2137 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2138 }
mcimadamore@359 2139 else {
mcimadamore@359 2140 log.error(pos, "synthetic.name.conflict", sym, sym.location());
mcimadamore@359 2141 }
mcimadamore@359 2142 }
mcimadamore@359 2143 }
mcimadamore@359 2144
duke@1 2145 /** Check that class c does not implement directly or indirectly
duke@1 2146 * the same parameterized interface with two different argument lists.
duke@1 2147 * @param pos Position to be used for error reporting.
duke@1 2148 * @param type The type whose interfaces are checked.
duke@1 2149 */
duke@1 2150 void checkClassBounds(DiagnosticPosition pos, Type type) {
duke@1 2151 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
duke@1 2152 }
duke@1 2153 //where
duke@1 2154 /** Enter all interfaces of type `type' into the hash table `seensofar'
duke@1 2155 * with their class symbol as key and their type as value. Make
duke@1 2156 * sure no class is entered with two different types.
duke@1 2157 */
duke@1 2158 void checkClassBounds(DiagnosticPosition pos,
duke@1 2159 Map<TypeSymbol,Type> seensofar,
duke@1 2160 Type type) {
duke@1 2161 if (type.isErroneous()) return;
duke@1 2162 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
duke@1 2163 Type it = l.head;
duke@1 2164 Type oldit = seensofar.put(it.tsym, it);
duke@1 2165 if (oldit != null) {
duke@1 2166 List<Type> oldparams = oldit.allparams();
duke@1 2167 List<Type> newparams = it.allparams();
duke@1 2168 if (!types.containsTypeEquivalent(oldparams, newparams))
duke@1 2169 log.error(pos, "cant.inherit.diff.arg",
duke@1 2170 it.tsym, Type.toString(oldparams),
duke@1 2171 Type.toString(newparams));
duke@1 2172 }
duke@1 2173 checkClassBounds(pos, seensofar, it);
duke@1 2174 }
duke@1 2175 Type st = types.supertype(type);
duke@1 2176 if (st != null) checkClassBounds(pos, seensofar, st);
duke@1 2177 }
duke@1 2178
duke@1 2179 /** Enter interface into into set.
duke@1 2180 * If it existed already, issue a "repeated interface" error.
duke@1 2181 */
duke@1 2182 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
duke@1 2183 if (its.contains(it))
duke@1 2184 log.error(pos, "repeated.interface");
duke@1 2185 else {
duke@1 2186 its.add(it);
duke@1 2187 }
duke@1 2188 }
duke@1 2189
duke@1 2190 /* *************************************************************************
duke@1 2191 * Check annotations
duke@1 2192 **************************************************************************/
duke@1 2193
mcimadamore@629 2194 /**
mcimadamore@634 2195 * Recursively validate annotations values
mcimadamore@629 2196 */
mcimadamore@634 2197 void validateAnnotationTree(JCTree tree) {
mcimadamore@634 2198 class AnnotationValidator extends TreeScanner {
mcimadamore@629 2199 @Override
mcimadamore@629 2200 public void visitAnnotation(JCAnnotation tree) {
mcimadamore@629 2201 super.visitAnnotation(tree);
mcimadamore@629 2202 validateAnnotation(tree);
mcimadamore@629 2203 }
mcimadamore@629 2204 }
mcimadamore@634 2205 tree.accept(new AnnotationValidator());
mcimadamore@629 2206 }
mcimadamore@629 2207
duke@1 2208 /** Annotation types are restricted to primitives, String, an
duke@1 2209 * enum, an annotation, Class, Class<?>, Class<? extends
duke@1 2210 * Anything>, arrays of the preceding.
duke@1 2211 */
duke@1 2212 void validateAnnotationType(JCTree restype) {
duke@1 2213 // restype may be null if an error occurred, so don't bother validating it
duke@1 2214 if (restype != null) {
duke@1 2215 validateAnnotationType(restype.pos(), restype.type);
duke@1 2216 }
duke@1 2217 }
duke@1 2218
duke@1 2219 void validateAnnotationType(DiagnosticPosition pos, Type type) {
duke@1 2220 if (type.isPrimitive()) return;
duke@1 2221 if (types.isSameType(type, syms.stringType)) return;
duke@1 2222 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
duke@1 2223 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
duke@1 2224 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
duke@1 2225 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
duke@1 2226 validateAnnotationType(pos, types.elemtype(type));
duke@1 2227 return;
duke@1 2228 }
duke@1 2229 log.error(pos, "invalid.annotation.member.type");
duke@1 2230 }
duke@1 2231
duke@1 2232 /**
duke@1 2233 * "It is also a compile-time error if any method declared in an
duke@1 2234 * annotation type has a signature that is override-equivalent to
duke@1 2235 * that of any public or protected method declared in class Object
duke@1 2236 * or in the interface annotation.Annotation."
duke@1 2237 *
duke@1 2238 * @jls3 9.6 Annotation Types
duke@1 2239 */
duke@1 2240 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
duke@1 2241 for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
duke@1 2242 Scope s = sup.tsym.members();
duke@1 2243 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2244 if (e.sym.kind == MTH &&
duke@1 2245 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
duke@1 2246 types.overrideEquivalent(m.type, e.sym.type))
duke@1 2247 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
duke@1 2248 }
duke@1 2249 }
duke@1 2250 }
duke@1 2251
duke@1 2252 /** Check the annotations of a symbol.
duke@1 2253 */
duke@1 2254 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
duke@1 2255 if (skipAnnotations) return;
duke@1 2256 for (JCAnnotation a : annotations)
duke@1 2257 validateAnnotation(a, s);
duke@1 2258 }
duke@1 2259
duke@1 2260 /** Check an annotation of a symbol.
duke@1 2261 */
duke@1 2262 public void validateAnnotation(JCAnnotation a, Symbol s) {
mcimadamore@634 2263 validateAnnotationTree(a);
duke@1 2264
duke@1 2265 if (!annotationApplicable(a, s))
duke@1 2266 log.error(a.pos(), "annotation.type.not.applicable");
duke@1 2267
duke@1 2268 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
duke@1 2269 if (!isOverrider(s))
duke@1 2270 log.error(a.pos(), "method.does.not.override.superclass");
duke@1 2271 }
duke@1 2272 }
duke@1 2273
duke@1 2274 /** Is s a method symbol that overrides a method in a superclass? */
duke@1 2275 boolean isOverrider(Symbol s) {
duke@1 2276 if (s.kind != MTH || s.isStatic())
duke@1 2277 return false;
duke@1 2278 MethodSymbol m = (MethodSymbol)s;
duke@1 2279 TypeSymbol owner = (TypeSymbol)m.owner;
duke@1 2280 for (Type sup : types.closure(owner.type)) {
duke@1 2281 if (sup == owner.type)
duke@1 2282 continue; // skip "this"
duke@1 2283 Scope scope = sup.tsym.members();
duke@1 2284 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
duke@1 2285 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
duke@1 2286 return true;
duke@1 2287 }
duke@1 2288 }
duke@1 2289 return false;
duke@1 2290 }
duke@1 2291
duke@1 2292 /** Is the annotation applicable to the symbol? */
duke@1 2293 boolean annotationApplicable(JCAnnotation a, Symbol s) {
duke@1 2294 Attribute.Compound atTarget =
duke@1 2295 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
duke@1 2296 if (atTarget == null) return true;
duke@1 2297 Attribute atValue = atTarget.member(names.value);
duke@1 2298 if (!(atValue instanceof Attribute.Array)) return true; // error recovery
duke@1 2299 Attribute.Array arr = (Attribute.Array) atValue;
duke@1 2300 for (Attribute app : arr.values) {
duke@1 2301 if (!(app instanceof Attribute.Enum)) return true; // recovery
duke@1 2302 Attribute.Enum e = (Attribute.Enum) app;
duke@1 2303 if (e.value.name == names.TYPE)
duke@1 2304 { if (s.kind == TYP) return true; }
duke@1 2305 else if (e.value.name == names.FIELD)
duke@1 2306 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
duke@1 2307 else if (e.value.name == names.METHOD)
duke@1 2308 { if (s.kind == MTH && !s.isConstructor()) return true; }
duke@1 2309 else if (e.value.name == names.PARAMETER)
duke@1 2310 { if (s.kind == VAR &&
duke@1 2311 s.owner.kind == MTH &&
duke@1 2312 (s.flags() & PARAMETER) != 0)
duke@1 2313 return true;
duke@1 2314 }
duke@1 2315 else if (e.value.name == names.CONSTRUCTOR)
duke@1 2316 { if (s.kind == MTH && s.isConstructor()) return true; }
duke@1 2317 else if (e.value.name == names.LOCAL_VARIABLE)
duke@1 2318 { if (s.kind == VAR && s.owner.kind == MTH &&
duke@1 2319 (s.flags() & PARAMETER) == 0)
duke@1 2320 return true;
duke@1 2321 }
duke@1 2322 else if (e.value.name == names.ANNOTATION_TYPE)
duke@1 2323 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
duke@1 2324 return true;
duke@1 2325 }
duke@1 2326 else if (e.value.name == names.PACKAGE)
duke@1 2327 { if (s.kind == PCK) return true; }
jjg@308 2328 else if (e.value.name == names.TYPE_USE)
jjg@308 2329 { if (s.kind == TYP ||
jjg@308 2330 s.kind == VAR ||
jjg@308 2331 (s.kind == MTH && !s.isConstructor() &&
jjg@308 2332 s.type.getReturnType().tag != VOID))
jjg@308 2333 return true;
jjg@308 2334 }
duke@1 2335 else
duke@1 2336 return true; // recovery
duke@1 2337 }
duke@1 2338 return false;
duke@1 2339 }
duke@1 2340
duke@1 2341 /** Check an annotation value.
duke@1 2342 */
duke@1 2343 public void validateAnnotation(JCAnnotation a) {
duke@1 2344 if (a.type.isErroneous()) return;
duke@1 2345
mcimadamore@632 2346 // collect an inventory of the members (sorted alphabetically)
mcimadamore@632 2347 Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
mcimadamore@632 2348 public int compare(Symbol t, Symbol t1) {
mcimadamore@632 2349 return t.name.compareTo(t1.name);
mcimadamore@632 2350 }
mcimadamore@632 2351 });
duke@1 2352 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
duke@1 2353 e != null;
duke@1 2354 e = e.sibling)
duke@1 2355 if (e.sym.kind == MTH)
duke@1 2356 members.add((MethodSymbol) e.sym);
duke@1 2357
duke@1 2358 // count them off as they're annotated
duke@1 2359 for (JCTree arg : a.args) {
duke@1 2360 if (arg.getTag() != JCTree.ASSIGN) continue; // recovery
duke@1 2361 JCAssign assign = (JCAssign) arg;
duke@1 2362 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2363 if (m == null || m.type.isErroneous()) continue;
duke@1 2364 if (!members.remove(m))
jjg@479 2365 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
duke@1 2366 m.name, a.type);
duke@1 2367 }
duke@1 2368
duke@1 2369 // all the remaining ones better have default values
mcimadamore@632 2370 ListBuffer<Name> missingDefaults = ListBuffer.lb();
mcimadamore@632 2371 for (MethodSymbol m : members) {
mcimadamore@632 2372 if (m.defaultValue == null && !m.type.isErroneous()) {
mcimadamore@632 2373 missingDefaults.append(m.name);
mcimadamore@632 2374 }
mcimadamore@632 2375 }
mcimadamore@632 2376 if (missingDefaults.nonEmpty()) {
mcimadamore@632 2377 String key = (missingDefaults.size() > 1)
mcimadamore@632 2378 ? "annotation.missing.default.value.1"
mcimadamore@632 2379 : "annotation.missing.default.value";
mcimadamore@632 2380 log.error(a.pos(), key, a.type, missingDefaults);
mcimadamore@632 2381 }
duke@1 2382
duke@1 2383 // special case: java.lang.annotation.Target must not have
duke@1 2384 // repeated values in its value member
duke@1 2385 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
duke@1 2386 a.args.tail == null)
duke@1 2387 return;
duke@1 2388
duke@1 2389 if (a.args.head.getTag() != JCTree.ASSIGN) return; // error recovery
duke@1 2390 JCAssign assign = (JCAssign) a.args.head;
duke@1 2391 Symbol m = TreeInfo.symbol(assign.lhs);
duke@1 2392 if (m.name != names.value) return;
duke@1 2393 JCTree rhs = assign.rhs;
duke@1 2394 if (rhs.getTag() != JCTree.NEWARRAY) return;
duke@1 2395 JCNewArray na = (JCNewArray) rhs;
duke@1 2396 Set<Symbol> targets = new HashSet<Symbol>();
duke@1 2397 for (JCTree elem : na.elems) {
duke@1 2398 if (!targets.add(TreeInfo.symbol(elem))) {
duke@1 2399 log.error(elem.pos(), "repeated.annotation.target");
duke@1 2400 }
duke@1 2401 }
duke@1 2402 }
duke@1 2403
duke@1 2404 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
duke@1 2405 if (allowAnnotations &&
mcimadamore@795 2406 lint.isEnabled(LintCategory.DEP_ANN) &&
duke@1 2407 (s.flags() & DEPRECATED) != 0 &&
duke@1 2408 !syms.deprecatedType.isErroneous() &&
duke@1 2409 s.attribute(syms.deprecatedType.tsym) == null) {
mcimadamore@795 2410 log.warning(LintCategory.DEP_ANN,
jjg@612 2411 pos, "missing.deprecated.annotation");
duke@1 2412 }
duke@1 2413 }
duke@1 2414
duke@1 2415 /* *************************************************************************
duke@1 2416 * Check for recursive annotation elements.
duke@1 2417 **************************************************************************/
duke@1 2418
duke@1 2419 /** Check for cycles in the graph of annotation elements.
duke@1 2420 */
duke@1 2421 void checkNonCyclicElements(JCClassDecl tree) {
duke@1 2422 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
jjg@816 2423 Assert.check((tree.sym.flags_field & LOCKED) == 0);
duke@1 2424 try {
duke@1 2425 tree.sym.flags_field |= LOCKED;
duke@1 2426 for (JCTree def : tree.defs) {
duke@1 2427 if (def.getTag() != JCTree.METHODDEF) continue;
duke@1 2428 JCMethodDecl meth = (JCMethodDecl)def;
duke@1 2429 checkAnnotationResType(meth.pos(), meth.restype.type);
duke@1 2430 }
duke@1 2431 } finally {
duke@1 2432 tree.sym.flags_field &= ~LOCKED;
duke@1 2433 tree.sym.flags_field |= ACYCLIC_ANN;
duke@1 2434 }
duke@1 2435 }
duke@1 2436
duke@1 2437 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
duke@1 2438 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
duke@1 2439 return;
duke@1 2440 if ((tsym.flags_field & LOCKED) != 0) {
duke@1 2441 log.error(pos, "cyclic.annotation.element");
duke@1 2442 return;
duke@1 2443 }
duke@1 2444 try {
duke@1 2445 tsym.flags_field |= LOCKED;
duke@1 2446 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
duke@1 2447 Symbol s = e.sym;
duke@1 2448 if (s.kind != Kinds.MTH)
duke@1 2449 continue;
duke@1 2450 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
duke@1 2451 }
duke@1 2452 } finally {
duke@1 2453 tsym.flags_field &= ~LOCKED;
duke@1 2454 tsym.flags_field |= ACYCLIC_ANN;
duke@1 2455 }
duke@1 2456 }
duke@1 2457
duke@1 2458 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
duke@1 2459 switch (type.tag) {
duke@1 2460 case TypeTags.CLASS:
duke@1 2461 if ((type.tsym.flags() & ANNOTATION) != 0)
duke@1 2462 checkNonCyclicElementsInternal(pos, type.tsym);
duke@1 2463 break;
duke@1 2464 case TypeTags.ARRAY:
duke@1 2465 checkAnnotationResType(pos, types.elemtype(type));
duke@1 2466 break;
duke@1 2467 default:
duke@1 2468 break; // int etc
duke@1 2469 }
duke@1 2470 }
duke@1 2471
duke@1 2472 /* *************************************************************************
duke@1 2473 * Check for cycles in the constructor call graph.
duke@1 2474 **************************************************************************/
duke@1 2475
duke@1 2476 /** Check for cycles in the graph of constructors calling other
duke@1 2477 * constructors.
duke@1 2478 */
duke@1 2479 void checkCyclicConstructors(JCClassDecl tree) {
duke@1 2480 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
duke@1 2481
duke@1 2482 // enter each constructor this-call into the map
duke@1 2483 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
duke@1 2484 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
duke@1 2485 if (app == null) continue;
duke@1 2486 JCMethodDecl meth = (JCMethodDecl) l.head;
duke@1 2487 if (TreeInfo.name(app.meth) == names._this) {
duke@1 2488 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
duke@1 2489 } else {
duke@1 2490 meth.sym.flags_field |= ACYCLIC;
duke@1 2491 }
duke@1 2492 }
duke@1 2493
duke@1 2494 // Check for cycles in the map
duke@1 2495 Symbol[] ctors = new Symbol[0];
duke@1 2496 ctors = callMap.keySet().toArray(ctors);
duke@1 2497 for (Symbol caller : ctors) {
duke@1 2498 checkCyclicConstructor(tree, caller, callMap);
duke@1 2499 }
duke@1 2500 }
duke@1 2501
duke@1 2502 /** Look in the map to see if the given constructor is part of a
duke@1 2503 * call cycle.
duke@1 2504 */
duke@1 2505 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
duke@1 2506 Map<Symbol,Symbol> callMap) {
duke@1 2507 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
duke@1 2508 if ((ctor.flags_field & LOCKED) != 0) {
duke@1 2509 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
duke@1 2510 "recursive.ctor.invocation");
duke@1 2511 } else {
duke@1 2512 ctor.flags_field |= LOCKED;
duke@1 2513 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
duke@1 2514 ctor.flags_field &= ~LOCKED;
duke@1 2515 }
duke@1 2516 ctor.flags_field |= ACYCLIC;
duke@1 2517 }
duke@1 2518 }
duke@1 2519
duke@1 2520 /* *************************************************************************
duke@1 2521 * Miscellaneous
duke@1 2522 **************************************************************************/
duke@1 2523
duke@1 2524 /**
duke@1 2525 * Return the opcode of the operator but emit an error if it is an
duke@1 2526 * error.
duke@1 2527 * @param pos position for error reporting.
duke@1 2528 * @param operator an operator
duke@1 2529 * @param tag a tree tag
duke@1 2530 * @param left type of left hand side
duke@1 2531 * @param right type of right hand side
duke@1 2532 */
duke@1 2533 int checkOperator(DiagnosticPosition pos,
duke@1 2534 OperatorSymbol operator,
duke@1 2535 int tag,
duke@1 2536 Type left,
duke@1 2537 Type right) {
duke@1 2538 if (operator.opcode == ByteCodes.error) {
duke@1 2539 log.error(pos,
duke@1 2540 "operator.cant.be.applied",
duke@1 2541 treeinfo.operatorName(tag),
mcimadamore@80 2542 List.of(left, right));
duke@1 2543 }
duke@1 2544 return operator.opcode;
duke@1 2545 }
duke@1 2546
duke@1 2547
duke@1 2548 /**
duke@1 2549 * Check for division by integer constant zero
duke@1 2550 * @param pos Position for error reporting.
duke@1 2551 * @param operator The operator for the expression
duke@1 2552 * @param operand The right hand operand for the expression
duke@1 2553 */
duke@1 2554 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
duke@1 2555 if (operand.constValue() != null
mcimadamore@795 2556 && lint.isEnabled(LintCategory.DIVZERO)
duke@1 2557 && operand.tag <= LONG
duke@1 2558 && ((Number) (operand.constValue())).longValue() == 0) {
duke@1 2559 int opc = ((OperatorSymbol)operator).opcode;
duke@1 2560 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
duke@1 2561 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
mcimadamore@795 2562 log.warning(LintCategory.DIVZERO, pos, "div.zero");
duke@1 2563 }
duke@1 2564 }
duke@1 2565 }
duke@1 2566
duke@1 2567 /**
duke@1 2568 * Check for empty statements after if
duke@1 2569 */
duke@1 2570 void checkEmptyIf(JCIf tree) {
mcimadamore@795 2571 if (tree.thenpart.getTag() == JCTree.SKIP && tree.elsepart == null && lint.isEnabled(LintCategory.EMPTY))
mcimadamore@795 2572 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
duke@1 2573 }
duke@1 2574
duke@1 2575 /** Check that symbol is unique in given scope.
duke@1 2576 * @param pos Position for error reporting.
duke@1 2577 * @param sym The symbol.
duke@1 2578 * @param s The scope.
duke@1 2579 */
duke@1 2580 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2581 if (sym.type.isErroneous())
duke@1 2582 return true;
duke@1 2583 if (sym.owner.name == names.any) return false;
duke@1 2584 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
duke@1 2585 if (sym != e.sym &&
mcimadamore@844 2586 (e.sym.flags() & CLASH) == 0 &&
duke@1 2587 sym.kind == e.sym.kind &&
duke@1 2588 sym.name != names.error &&
mcimadamore@252 2589 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
mcimadamore@844 2590 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
duke@1 2591 varargsDuplicateError(pos, sym, e.sym);
mcimadamore@844 2592 return true;
mcimadamore@844 2593 } else if (sym.kind == MTH && !hasSameSignature(sym.type, e.sym.type)) {
mcimadamore@252 2594 duplicateErasureError(pos, sym, e.sym);
mcimadamore@844 2595 sym.flags_field |= CLASH;
mcimadamore@844 2596 return true;
mcimadamore@844 2597 } else {
duke@1 2598 duplicateError(pos, e.sym);
mcimadamore@844 2599 return false;
mcimadamore@844 2600 }
duke@1 2601 }
duke@1 2602 }
duke@1 2603 return true;
duke@1 2604 }
mcimadamore@252 2605 //where
mcimadamore@844 2606 boolean hasSameSignature(Type mt1, Type mt2) {
mcimadamore@844 2607 if (mt1.tag == FORALL && mt2.tag == FORALL) {
mcimadamore@844 2608 ForAll fa1 = (ForAll)mt1;
mcimadamore@844 2609 ForAll fa2 = (ForAll)mt2;
mcimadamore@844 2610 mt2 = types.subst(fa2, fa2.tvars, fa1.tvars);
mcimadamore@844 2611 }
mcimadamore@844 2612 return types.hasSameArgs(mt1.asMethodType(), mt2.asMethodType());
mcimadamore@252 2613 }
mcimadamore@844 2614
mcimadamore@844 2615 /** Report duplicate declaration error.
mcimadamore@844 2616 */
mcimadamore@844 2617 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
mcimadamore@844 2618 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
mcimadamore@844 2619 log.error(pos, "name.clash.same.erasure", sym1, sym2);
mcimadamore@844 2620 }
mcimadamore@844 2621 }
duke@1 2622
duke@1 2623 /** Check that single-type import is not already imported or top-level defined,
duke@1 2624 * but make an exception for two single-type imports which denote the same type.
duke@1 2625 * @param pos Position for error reporting.
duke@1 2626 * @param sym The symbol.
duke@1 2627 * @param s The scope
duke@1 2628 */
duke@1 2629 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2630 return checkUniqueImport(pos, sym, s, false);
duke@1 2631 }
duke@1 2632
duke@1 2633 /** Check that static single-type import is not already imported or top-level defined,
duke@1 2634 * but make an exception for two single-type imports which denote the same type.
duke@1 2635 * @param pos Position for error reporting.
duke@1 2636 * @param sym The symbol.
duke@1 2637 * @param s The scope
duke@1 2638 * @param staticImport Whether or not this was a static import
duke@1 2639 */
duke@1 2640 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
duke@1 2641 return checkUniqueImport(pos, sym, s, true);
duke@1 2642 }
duke@1 2643
duke@1 2644 /** Check that single-type import is not already imported or top-level defined,
duke@1 2645 * but make an exception for two single-type imports which denote the same type.
duke@1 2646 * @param pos Position for error reporting.
duke@1 2647 * @param sym The symbol.
duke@1 2648 * @param s The scope.
duke@1 2649 * @param staticImport Whether or not this was a static import
duke@1 2650 */
duke@1 2651 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
duke@1 2652 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
duke@1 2653 // is encountered class entered via a class declaration?
duke@1 2654 boolean isClassDecl = e.scope == s;
duke@1 2655 if ((isClassDecl || sym != e.sym) &&
duke@1 2656 sym.kind == e.sym.kind &&
duke@1 2657 sym.name != names.error) {
duke@1 2658 if (!e.sym.type.isErroneous()) {
duke@1 2659 String what = e.sym.toString();
duke@1 2660 if (!isClassDecl) {
duke@1 2661 if (staticImport)
duke@1 2662 log.error(pos, "already.defined.static.single.import", what);
duke@1 2663 else
duke@1 2664 log.error(pos, "already.defined.single.import", what);
duke@1 2665 }
duke@1 2666 else if (sym != e.sym)
duke@1 2667 log.error(pos, "already.defined.this.unit", what);
duke@1 2668 }
duke@1 2669 return false;
duke@1 2670 }
duke@1 2671 }
duke@1 2672 return true;
duke@1 2673 }
duke@1 2674
duke@1 2675 /** Check that a qualified name is in canonical form (for import decls).
duke@1 2676 */
duke@1 2677 public void checkCanonical(JCTree tree) {
duke@1 2678 if (!isCanonical(tree))
duke@1 2679 log.error(tree.pos(), "import.requires.canonical",
duke@1 2680 TreeInfo.symbol(tree));
duke@1 2681 }
duke@1 2682 // where
duke@1 2683 private boolean isCanonical(JCTree tree) {
duke@1 2684 while (tree.getTag() == JCTree.SELECT) {
duke@1 2685 JCFieldAccess s = (JCFieldAccess) tree;
duke@1 2686 if (s.sym.owner != TreeInfo.symbol(s.selected))
duke@1 2687 return false;
duke@1 2688 tree = s.selected;
duke@1 2689 }
duke@1 2690 return true;
duke@1 2691 }
duke@1 2692
duke@1 2693 private class ConversionWarner extends Warner {
mcimadamore@795 2694 final String uncheckedKey;
duke@1 2695 final Type found;
duke@1 2696 final Type expected;
mcimadamore@795 2697 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
duke@1 2698 super(pos);
mcimadamore@795 2699 this.uncheckedKey = uncheckedKey;
duke@1 2700 this.found = found;
duke@1 2701 this.expected = expected;
duke@1 2702 }
duke@1 2703
jjg@398 2704 @Override
mcimadamore@795 2705 public void warn(LintCategory lint) {
duke@1 2706 boolean warned = this.warned;
mcimadamore@795 2707 super.warn(lint);
duke@1 2708 if (warned) return; // suppress redundant diagnostics
mcimadamore@795 2709 switch (lint) {
mcimadamore@795 2710 case UNCHECKED:
mcimadamore@795 2711 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
mcimadamore@795 2712 break;
mcimadamore@795 2713 case VARARGS:
mcimadamore@795 2714 if (method != null &&
mcimadamore@795 2715 method.attribute(syms.trustMeType.tsym) != null &&
mcimadamore@795 2716 isTrustMeAllowedOnMethod(method) &&
mcimadamore@795 2717 !types.isReifiable(method.type.getParameterTypes().last())) {
mcimadamore@795 2718 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
mcimadamore@795 2719 }
mcimadamore@795 2720 break;
mcimadamore@795 2721 default:
mcimadamore@795 2722 throw new AssertionError("Unexpected lint: " + lint);
mcimadamore@795 2723 }
duke@1 2724 }
duke@1 2725 }
duke@1 2726
duke@1 2727 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2728 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
duke@1 2729 }
duke@1 2730
duke@1 2731 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
duke@1 2732 return new ConversionWarner(pos, "unchecked.assign", found, expected);
duke@1 2733 }
duke@1 2734 }

mercurial