src/share/classes/com/sun/tools/doclint/Checker.java

Tue, 17 Sep 2013 14:17:13 -0700

author
jjg
date
Tue, 17 Sep 2013 14:17:13 -0700
changeset 2033
fdfbc5f0c4ed
parent 1917
2fbe77c38802
child 2052
503338f16d2b
permissions
-rw-r--r--

8024538: -Xdoclint + -Xprefer:source + incremental compilation == FAIL
Reviewed-by: darcy

jjg@1455 1 /*
jjg@1495 2 * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
jjg@1455 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
jjg@1455 4 *
jjg@1455 5 * This code is free software; you can redistribute it and/or modify it
jjg@1455 6 * under the terms of the GNU General Public License version 2 only, as
jjg@1455 7 * published by the Free Software Foundation. Oracle designates this
jjg@1455 8 * particular file as subject to the "Classpath" exception as provided
jjg@1455 9 * by Oracle in the LICENSE file that accompanied this code.
jjg@1455 10 *
jjg@1455 11 * This code is distributed in the hope that it will be useful, but WITHOUT
jjg@1455 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
jjg@1455 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
jjg@1455 14 * version 2 for more details (a copy is included in the LICENSE file that
jjg@1455 15 * accompanied this code).
jjg@1455 16 *
jjg@1455 17 * You should have received a copy of the GNU General Public License version
jjg@1455 18 * 2 along with this work; if not, write to the Free Software Foundation,
jjg@1455 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
jjg@1455 20 *
jjg@1455 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
jjg@1455 22 * or visit www.oracle.com if you need additional information or have any
jjg@1455 23 * questions.
jjg@1455 24 */
jjg@1455 25
jjg@1455 26 package com.sun.tools.doclint;
jjg@1455 27
jjg@1650 28 import java.io.IOException;
jjg@1650 29 import java.io.StringWriter;
jjg@1455 30 import java.net.URI;
jjg@1650 31 import java.net.URISyntaxException;
jjg@1455 32 import java.util.Deque;
jjg@1455 33 import java.util.EnumSet;
jjg@1912 34 import java.util.HashMap;
jjg@1455 35 import java.util.HashSet;
jjg@1455 36 import java.util.LinkedList;
jjg@1455 37 import java.util.List;
jjg@1912 38 import java.util.Map;
jjg@1455 39 import java.util.Set;
jjg@1650 40 import java.util.regex.Matcher;
jjg@1650 41 import java.util.regex.Pattern;
jjg@1455 42
jjg@1455 43 import javax.lang.model.element.Element;
jjg@1455 44 import javax.lang.model.element.ElementKind;
jjg@1455 45 import javax.lang.model.element.ExecutableElement;
jjg@1455 46 import javax.lang.model.element.Name;
jjg@1455 47 import javax.lang.model.type.TypeKind;
jjg@1455 48 import javax.lang.model.type.TypeMirror;
jjg@1455 49 import javax.tools.Diagnostic.Kind;
jjg@1912 50 import javax.tools.JavaFileObject;
jjg@1455 51
jjg@1455 52 import com.sun.source.doctree.AttributeTree;
jjg@1455 53 import com.sun.source.doctree.AuthorTree;
jjg@1455 54 import com.sun.source.doctree.DocCommentTree;
jjg@1650 55 import com.sun.source.doctree.DocRootTree;
jjg@1455 56 import com.sun.source.doctree.DocTree;
jjg@1455 57 import com.sun.source.doctree.EndElementTree;
jjg@1455 58 import com.sun.source.doctree.EntityTree;
jjg@1455 59 import com.sun.source.doctree.ErroneousTree;
jjg@1455 60 import com.sun.source.doctree.IdentifierTree;
jjg@1455 61 import com.sun.source.doctree.InheritDocTree;
jjg@1650 62 import com.sun.source.doctree.LinkTree;
jjg@1650 63 import com.sun.source.doctree.LiteralTree;
jjg@1455 64 import com.sun.source.doctree.ParamTree;
jjg@1455 65 import com.sun.source.doctree.ReferenceTree;
jjg@1455 66 import com.sun.source.doctree.ReturnTree;
jjg@1455 67 import com.sun.source.doctree.SerialDataTree;
jjg@1455 68 import com.sun.source.doctree.SerialFieldTree;
jjg@1455 69 import com.sun.source.doctree.SinceTree;
jjg@1455 70 import com.sun.source.doctree.StartElementTree;
jjg@1455 71 import com.sun.source.doctree.TextTree;
jjg@1455 72 import com.sun.source.doctree.ThrowsTree;
jjg@1650 73 import com.sun.source.doctree.ValueTree;
jjg@1455 74 import com.sun.source.doctree.VersionTree;
jlahoda@1726 75 import com.sun.source.util.DocTreePath;
jlahoda@1726 76 import com.sun.source.util.DocTreePathScanner;
jjg@1455 77 import com.sun.source.util.TreePath;
jjg@1455 78 import com.sun.tools.doclint.HtmlTag.AttrKind;
jjg@1650 79 import com.sun.tools.javac.tree.DocPretty;
jjg@1455 80 import static com.sun.tools.doclint.Messages.Group.*;
jjg@1455 81
jjg@1455 82
jjg@1455 83 /**
jjg@1455 84 * Validate a doc comment.
jjg@1455 85 *
jjg@1455 86 * <p><b>This is NOT part of any supported API.
jjg@1455 87 * If you write code that depends on this, you do so at your own
jjg@1455 88 * risk. This code and its internal interfaces are subject to change
jjg@1455 89 * or deletion without notice.</b></p>
jjg@1455 90 */
jlahoda@1726 91 public class Checker extends DocTreePathScanner<Void, Void> {
jjg@1455 92 final Env env;
jjg@1455 93
jjg@1912 94 Set<Element> foundParams = new HashSet<>();
jjg@1912 95 Set<TypeMirror> foundThrows = new HashSet<>();
jjg@1912 96 Map<JavaFileObject, Set<String>> foundAnchors = new HashMap<>();
jjg@1455 97 boolean foundInheritDoc = false;
jjg@1455 98 boolean foundReturn = false;
jjg@1455 99
jjg@1506 100 public enum Flag {
jjg@1455 101 TABLE_HAS_CAPTION,
jjg@1455 102 HAS_ELEMENT,
jjg@1650 103 HAS_INLINE_TAG,
jjg@1507 104 HAS_TEXT,
jjg@1507 105 REPORTED_BAD_INLINE
jjg@1455 106 }
jjg@1455 107
jjg@1455 108 static class TagStackItem {
jjg@1455 109 final DocTree tree; // typically, but not always, StartElementTree
jjg@1455 110 final HtmlTag tag;
jjg@1455 111 final Set<HtmlTag.Attr> attrs;
jjg@1455 112 final Set<Flag> flags;
jjg@1455 113 TagStackItem(DocTree tree, HtmlTag tag) {
jjg@1455 114 this.tree = tree;
jjg@1455 115 this.tag = tag;
jjg@1455 116 attrs = EnumSet.noneOf(HtmlTag.Attr.class);
jjg@1455 117 flags = EnumSet.noneOf(Flag.class);
jjg@1455 118 }
jjg@1455 119 @Override
jjg@1455 120 public String toString() {
jjg@1455 121 return String.valueOf(tag);
jjg@1455 122 }
jjg@1455 123 }
jjg@1455 124
jjg@1455 125 private Deque<TagStackItem> tagStack; // TODO: maybe want to record starting tree as well
jjg@1455 126 private HtmlTag currHeaderTag;
jjg@1455 127
jjg@1668 128 private final int implicitHeaderLevel;
jjg@1668 129
jjg@1455 130 // <editor-fold defaultstate="collapsed" desc="Top level">
jjg@1455 131
jjg@1455 132 Checker(Env env) {
jjg@1455 133 env.getClass();
jjg@1455 134 this.env = env;
jjg@1912 135 tagStack = new LinkedList<>();
jjg@1668 136 implicitHeaderLevel = env.implicitHeaderLevel;
jjg@1455 137 }
jjg@1455 138
jjg@1455 139 public Void scan(DocCommentTree tree, TreePath p) {
jjg@1455 140 env.setCurrent(p, tree);
jjg@1455 141
jjg@1455 142 boolean isOverridingMethod = !env.currOverriddenMethods.isEmpty();
jjg@1455 143
jjg@1915 144 if (p.getLeaf() == p.getCompilationUnit()) {
jjg@1915 145 // If p points to a compilation unit, the implied declaration is the
jjg@1915 146 // package declaration (if any) for the compilation unit.
jjg@1915 147 // Handle this case specially, because doc comments are only
jjg@1915 148 // expected in package-info files.
jjg@1915 149 JavaFileObject fo = p.getCompilationUnit().getSourceFile();
jjg@1915 150 boolean isPkgInfo = fo.isNameCompatible("package-info", JavaFileObject.Kind.SOURCE);
jjg@1915 151 if (tree == null) {
jjg@1915 152 if (isPkgInfo)
jjg@1915 153 reportMissing("dc.missing.comment");
jjg@1915 154 return null;
jjg@1915 155 } else {
jjg@1915 156 if (!isPkgInfo)
jjg@1915 157 reportReference("dc.unexpected.comment");
jjg@1915 158 }
jjg@1915 159 } else {
jjg@1915 160 if (tree == null) {
jjg@1915 161 if (!isSynthetic() && !isOverridingMethod)
jjg@1915 162 reportMissing("dc.missing.comment");
jjg@1915 163 return null;
jjg@1915 164 }
jjg@1455 165 }
jjg@1455 166
jjg@1455 167 tagStack.clear();
jjg@1455 168 currHeaderTag = null;
jjg@1455 169
jjg@1455 170 foundParams.clear();
jjg@1455 171 foundThrows.clear();
jjg@1455 172 foundInheritDoc = false;
jjg@1455 173 foundReturn = false;
jjg@1455 174
jlahoda@1726 175 scan(new DocTreePath(p, tree), null);
jjg@1455 176
jjg@1455 177 if (!isOverridingMethod) {
jjg@1455 178 switch (env.currElement.getKind()) {
jjg@1455 179 case METHOD:
jjg@1455 180 case CONSTRUCTOR: {
jjg@1455 181 ExecutableElement ee = (ExecutableElement) env.currElement;
jjg@1455 182 checkParamsDocumented(ee.getTypeParameters());
jjg@1455 183 checkParamsDocumented(ee.getParameters());
jjg@1455 184 switch (ee.getReturnType().getKind()) {
jjg@1455 185 case VOID:
jjg@1455 186 case NONE:
jjg@1455 187 break;
jjg@1455 188 default:
jjg@1455 189 if (!foundReturn
jjg@1455 190 && !foundInheritDoc
jjg@1455 191 && !env.types.isSameType(ee.getReturnType(), env.java_lang_Void)) {
jjg@1455 192 reportMissing("dc.missing.return");
jjg@1455 193 }
jjg@1455 194 }
jjg@1455 195 checkThrowsDocumented(ee.getThrownTypes());
jjg@1455 196 }
jjg@1455 197 }
jjg@1455 198 }
jjg@1455 199
jjg@1455 200 return null;
jjg@1455 201 }
jjg@1455 202
jjg@1455 203 private void reportMissing(String code, Object... args) {
jjg@1455 204 env.messages.report(MISSING, Kind.WARNING, env.currPath.getLeaf(), code, args);
jjg@1455 205 }
jjg@1455 206
jjg@1915 207 private void reportReference(String code, Object... args) {
jjg@1915 208 env.messages.report(REFERENCE, Kind.WARNING, env.currPath.getLeaf(), code, args);
jjg@1915 209 }
jjg@1915 210
jjg@1455 211 @Override
jjg@1455 212 public Void visitDocComment(DocCommentTree tree, Void ignore) {
jjg@1455 213 super.visitDocComment(tree, ignore);
jjg@1455 214 for (TagStackItem tsi: tagStack) {
jjg@1455 215 if (tsi.tree.getKind() == DocTree.Kind.START_ELEMENT
jjg@1455 216 && tsi.tag.endKind == HtmlTag.EndKind.REQUIRED) {
jjg@1455 217 StartElementTree t = (StartElementTree) tsi.tree;
jjg@1455 218 env.messages.error(HTML, t, "dc.tag.not.closed", t.getName());
jjg@1455 219 }
jjg@1455 220 }
jjg@1455 221 return null;
jjg@1455 222 }
jjg@1455 223 // </editor-fold>
jjg@1455 224
jjg@1455 225 // <editor-fold defaultstate="collapsed" desc="Text and entities.">
jjg@1455 226
jjg@1455 227 @Override
jjg@1455 228 public Void visitText(TextTree tree, Void ignore) {
jjg@1507 229 if (hasNonWhitespace(tree)) {
jjg@1507 230 checkAllowsText(tree);
jjg@1455 231 markEnclosingTag(Flag.HAS_TEXT);
jjg@1455 232 }
jjg@1455 233 return null;
jjg@1455 234 }
jjg@1455 235
jjg@1455 236 @Override
jjg@1455 237 public Void visitEntity(EntityTree tree, Void ignore) {
jjg@1507 238 checkAllowsText(tree);
jjg@1455 239 markEnclosingTag(Flag.HAS_TEXT);
jjg@1455 240 String name = tree.getName().toString();
jjg@1455 241 if (name.startsWith("#")) {
jjg@1455 242 int v = name.toLowerCase().startsWith("#x")
jjg@1455 243 ? Integer.parseInt(name.substring(2), 16)
jjg@1455 244 : Integer.parseInt(name.substring(1), 10);
jjg@1455 245 if (!Entity.isValid(v)) {
jjg@1455 246 env.messages.error(HTML, tree, "dc.entity.invalid", name);
jjg@1455 247 }
jjg@1455 248 } else if (!Entity.isValid(name)) {
jjg@1455 249 env.messages.error(HTML, tree, "dc.entity.invalid", name);
jjg@1455 250 }
jjg@1455 251 return null;
jjg@1455 252 }
jjg@1455 253
jjg@1507 254 void checkAllowsText(DocTree tree) {
jjg@1507 255 TagStackItem top = tagStack.peek();
jjg@1507 256 if (top != null
jjg@1507 257 && top.tree.getKind() == DocTree.Kind.START_ELEMENT
jjg@1507 258 && !top.tag.acceptsText()) {
jjg@1507 259 if (top.flags.add(Flag.REPORTED_BAD_INLINE)) {
jjg@1507 260 env.messages.error(HTML, tree, "dc.text.not.allowed",
jjg@1507 261 ((StartElementTree) top.tree).getName());
jjg@1507 262 }
jjg@1507 263 }
jjg@1507 264 }
jjg@1507 265
jjg@1455 266 // </editor-fold>
jjg@1455 267
jjg@1455 268 // <editor-fold defaultstate="collapsed" desc="HTML elements">
jjg@1455 269
jjg@1455 270 @Override
jjg@1455 271 public Void visitStartElement(StartElementTree tree, Void ignore) {
jjg@1455 272 markEnclosingTag(Flag.HAS_ELEMENT);
jjg@1455 273 final Name treeName = tree.getName();
jjg@1455 274 final HtmlTag t = HtmlTag.get(treeName);
jjg@1455 275 if (t == null) {
jjg@1455 276 env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
jjg@1455 277 } else {
jjg@1552 278 boolean done = false;
jjg@1507 279 for (TagStackItem tsi: tagStack) {
jjg@1507 280 if (tsi.tag.accepts(t)) {
jjg@1507 281 while (tagStack.peek() != tsi) tagStack.pop();
jjg@1552 282 done = true;
jjg@1507 283 break;
jjg@1552 284 } else if (tsi.tag.endKind != HtmlTag.EndKind.OPTIONAL) {
jjg@1552 285 done = true;
jjg@1507 286 break;
jjg@1552 287 }
jjg@1552 288 }
jjg@1552 289 if (!done && HtmlTag.BODY.accepts(t)) {
jjg@1552 290 tagStack.clear();
jjg@1507 291 }
jjg@1507 292
jjg@1507 293 checkStructure(tree, t);
jjg@1507 294
jjg@1455 295 // tag specific checks
jjg@1455 296 switch (t) {
jjg@1455 297 // check for out of sequence headers, such as <h1>...</h1> <h3>...</h3>
jjg@1455 298 case H1: case H2: case H3: case H4: case H5: case H6:
jjg@1455 299 checkHeader(tree, t);
jjg@1455 300 break;
jjg@1455 301 }
jjg@1455 302
jjg@1455 303 if (t.flags.contains(HtmlTag.Flag.NO_NEST)) {
jjg@1455 304 for (TagStackItem i: tagStack) {
jjg@1455 305 if (t == i.tag) {
jjg@1455 306 env.messages.warning(HTML, tree, "dc.tag.nested.not.allowed", treeName);
jjg@1455 307 break;
jjg@1455 308 }
jjg@1455 309 }
jjg@1455 310 }
jjg@1455 311 }
jjg@1455 312
jjg@1455 313 // check for self closing tags, such as <a id="name"/>
jjg@1455 314 if (tree.isSelfClosing()) {
jjg@1455 315 env.messages.error(HTML, tree, "dc.tag.self.closing", treeName);
jjg@1455 316 }
jjg@1455 317
jjg@1455 318 try {
jjg@1455 319 TagStackItem parent = tagStack.peek();
jjg@1455 320 TagStackItem top = new TagStackItem(tree, t);
jjg@1455 321 tagStack.push(top);
jjg@1455 322
jjg@1455 323 super.visitStartElement(tree, ignore);
jjg@1455 324
jjg@1455 325 // handle attributes that may or may not have been found in start element
jjg@1455 326 if (t != null) {
jjg@1455 327 switch (t) {
jjg@1455 328 case CAPTION:
jjg@1455 329 if (parent != null && parent.tag == HtmlTag.TABLE)
jjg@1455 330 parent.flags.add(Flag.TABLE_HAS_CAPTION);
jjg@1455 331 break;
jjg@1455 332
jjg@1455 333 case IMG:
jjg@1455 334 if (!top.attrs.contains(HtmlTag.Attr.ALT))
jjg@1455 335 env.messages.error(ACCESSIBILITY, tree, "dc.no.alt.attr.for.image");
jjg@1455 336 break;
jjg@1455 337 }
jjg@1455 338 }
jjg@1455 339
jjg@1455 340 return null;
jjg@1455 341 } finally {
jjg@1455 342
jjg@1455 343 if (t == null || t.endKind == HtmlTag.EndKind.NONE)
jjg@1455 344 tagStack.pop();
jjg@1455 345 }
jjg@1455 346 }
jjg@1455 347
jjg@1507 348 private void checkStructure(StartElementTree tree, HtmlTag t) {
jjg@1507 349 Name treeName = tree.getName();
jjg@1507 350 TagStackItem top = tagStack.peek();
jjg@1507 351 switch (t.blockType) {
jjg@1507 352 case BLOCK:
jjg@1507 353 if (top == null || top.tag.accepts(t))
jjg@1507 354 return;
jjg@1507 355
jjg@1507 356 switch (top.tree.getKind()) {
jjg@1507 357 case START_ELEMENT: {
jjg@1507 358 if (top.tag.blockType == HtmlTag.BlockType.INLINE) {
jjg@1507 359 Name name = ((StartElementTree) top.tree).getName();
jjg@1507 360 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.element",
jjg@1507 361 treeName, name);
jjg@1507 362 return;
jjg@1507 363 }
jjg@1507 364 }
jjg@1507 365 break;
jjg@1507 366
jjg@1507 367 case LINK:
jjg@1507 368 case LINK_PLAIN: {
jjg@1507 369 String name = top.tree.getKind().tagName;
jjg@1507 370 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.tag",
jjg@1507 371 treeName, name);
jjg@1507 372 return;
jjg@1507 373 }
jjg@1507 374 }
jjg@1507 375 break;
jjg@1507 376
jjg@1507 377 case INLINE:
jjg@1507 378 if (top == null || top.tag.accepts(t))
jjg@1507 379 return;
jjg@1507 380 break;
jjg@1507 381
jjg@1507 382 case LIST_ITEM:
jjg@1507 383 case TABLE_ITEM:
jjg@1507 384 if (top != null) {
jjg@1507 385 // reset this flag so subsequent bad inline content gets reported
jjg@1507 386 top.flags.remove(Flag.REPORTED_BAD_INLINE);
jjg@1507 387 if (top.tag.accepts(t))
jjg@1507 388 return;
jjg@1507 389 }
jjg@1507 390 break;
jjg@1507 391
jjg@1507 392 case OTHER:
jjg@1507 393 env.messages.error(HTML, tree, "dc.tag.not.allowed", treeName);
jjg@1507 394 return;
jjg@1507 395 }
jjg@1507 396
jjg@1507 397 env.messages.error(HTML, tree, "dc.tag.not.allowed.here", treeName);
jjg@1507 398 }
jjg@1507 399
jjg@1455 400 private void checkHeader(StartElementTree tree, HtmlTag tag) {
jjg@1455 401 // verify the new tag
jjg@1455 402 if (getHeaderLevel(tag) > getHeaderLevel(currHeaderTag) + 1) {
jjg@1455 403 if (currHeaderTag == null) {
jjg@1455 404 env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.1", tag);
jjg@1455 405 } else {
jjg@1455 406 env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.2",
jjg@1455 407 tag, currHeaderTag);
jjg@1455 408 }
jjg@1455 409 }
jjg@1455 410
jjg@1455 411 currHeaderTag = tag;
jjg@1455 412 }
jjg@1455 413
jjg@1455 414 private int getHeaderLevel(HtmlTag tag) {
jjg@1455 415 if (tag == null)
jjg@1668 416 return implicitHeaderLevel;
jjg@1455 417 switch (tag) {
jjg@1455 418 case H1: return 1;
jjg@1455 419 case H2: return 2;
jjg@1455 420 case H3: return 3;
jjg@1455 421 case H4: return 4;
jjg@1455 422 case H5: return 5;
jjg@1455 423 case H6: return 6;
jjg@1455 424 default: throw new IllegalArgumentException();
jjg@1455 425 }
jjg@1455 426 }
jjg@1455 427
jjg@1455 428 @Override
jjg@1455 429 public Void visitEndElement(EndElementTree tree, Void ignore) {
jjg@1455 430 final Name treeName = tree.getName();
jjg@1455 431 final HtmlTag t = HtmlTag.get(treeName);
jjg@1455 432 if (t == null) {
jjg@1455 433 env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
jjg@1455 434 } else if (t.endKind == HtmlTag.EndKind.NONE) {
jjg@1455 435 env.messages.error(HTML, tree, "dc.tag.end.not.permitted", treeName);
jjg@1455 436 } else {
jjg@1499 437 boolean done = false;
jjg@1455 438 while (!tagStack.isEmpty()) {
jjg@1455 439 TagStackItem top = tagStack.peek();
jjg@1455 440 if (t == top.tag) {
jjg@1455 441 switch (t) {
jjg@1455 442 case TABLE:
jjg@1455 443 if (!top.attrs.contains(HtmlTag.Attr.SUMMARY)
jjg@1455 444 && !top.flags.contains(Flag.TABLE_HAS_CAPTION)) {
jjg@1455 445 env.messages.error(ACCESSIBILITY, tree,
jjg@1455 446 "dc.no.summary.or.caption.for.table");
jjg@1455 447 }
jjg@1455 448 }
jjg@1455 449 if (t.flags.contains(HtmlTag.Flag.EXPECT_CONTENT)
jjg@1455 450 && !top.flags.contains(Flag.HAS_TEXT)
jjg@1650 451 && !top.flags.contains(Flag.HAS_ELEMENT)
jjg@1650 452 && !top.flags.contains(Flag.HAS_INLINE_TAG)) {
jjg@1455 453 env.messages.warning(HTML, tree, "dc.tag.empty", treeName);
jjg@1455 454 }
jjg@1455 455 tagStack.pop();
jjg@1499 456 done = true;
jjg@1455 457 break;
jjg@1455 458 } else if (top.tag == null || top.tag.endKind != HtmlTag.EndKind.REQUIRED) {
jjg@1455 459 tagStack.pop();
jjg@1455 460 } else {
jjg@1455 461 boolean found = false;
jjg@1455 462 for (TagStackItem si: tagStack) {
jjg@1455 463 if (si.tag == t) {
jjg@1455 464 found = true;
jjg@1455 465 break;
jjg@1455 466 }
jjg@1455 467 }
jjg@1455 468 if (found && top.tree.getKind() == DocTree.Kind.START_ELEMENT) {
jjg@1455 469 env.messages.error(HTML, top.tree, "dc.tag.start.unmatched",
jjg@1455 470 ((StartElementTree) top.tree).getName());
jjg@1455 471 tagStack.pop();
jjg@1455 472 } else {
jjg@1455 473 env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
jjg@1499 474 done = true;
jjg@1455 475 break;
jjg@1455 476 }
jjg@1455 477 }
jjg@1455 478 }
jjg@1499 479
jjg@1499 480 if (!done && tagStack.isEmpty()) {
jjg@1499 481 env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
jjg@1499 482 }
jjg@1455 483 }
jjg@1455 484
jjg@1455 485 return super.visitEndElement(tree, ignore);
jjg@1455 486 }
jjg@1455 487 // </editor-fold>
jjg@1455 488
jjg@1455 489 // <editor-fold defaultstate="collapsed" desc="HTML attributes">
jjg@1455 490
jjg@1455 491 @Override @SuppressWarnings("fallthrough")
jjg@1455 492 public Void visitAttribute(AttributeTree tree, Void ignore) {
jjg@1455 493 HtmlTag currTag = tagStack.peek().tag;
jjg@1455 494 if (currTag != null) {
jjg@1455 495 Name name = tree.getName();
jjg@1455 496 HtmlTag.Attr attr = currTag.getAttr(name);
jjg@1455 497 if (attr != null) {
jjg@1455 498 boolean first = tagStack.peek().attrs.add(attr);
jjg@1455 499 if (!first)
jjg@1455 500 env.messages.error(HTML, tree, "dc.attr.repeated", name);
jjg@1455 501 }
jjg@1455 502 AttrKind k = currTag.getAttrKind(name);
jjg@1455 503 switch (k) {
jjg@1455 504 case OK:
jjg@1455 505 break;
jjg@1455 506
jjg@1455 507 case INVALID:
jjg@1455 508 env.messages.error(HTML, tree, "dc.attr.unknown", name);
jjg@1455 509 break;
jjg@1455 510
jjg@1455 511 case OBSOLETE:
jjg@1455 512 env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete", name);
jjg@1455 513 break;
jjg@1455 514
jjg@1455 515 case USE_CSS:
jjg@1455 516 env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete.use.css", name);
jjg@1455 517 break;
jjg@1455 518 }
jjg@1455 519
jjg@1455 520 if (attr != null) {
jjg@1455 521 switch (attr) {
jjg@1455 522 case NAME:
jjg@1455 523 if (currTag != HtmlTag.A) {
jjg@1455 524 break;
jjg@1455 525 }
jjg@1495 526 // fallthrough
jjg@1455 527 case ID:
jjg@1455 528 String value = getAttrValue(tree);
jjg@1495 529 if (value == null) {
jjg@1495 530 env.messages.error(HTML, tree, "dc.anchor.value.missing");
jjg@1495 531 } else {
jjg@1495 532 if (!validName.matcher(value).matches()) {
jjg@1495 533 env.messages.error(HTML, tree, "dc.invalid.anchor", value);
jjg@1495 534 }
jjg@1912 535 if (!checkAnchor(value)) {
jjg@1495 536 env.messages.error(HTML, tree, "dc.anchor.already.defined", value);
jjg@1495 537 }
jjg@1455 538 }
jjg@1455 539 break;
jjg@1455 540
jjg@1455 541 case HREF:
jjg@1455 542 if (currTag == HtmlTag.A) {
jjg@1455 543 String v = getAttrValue(tree);
jjg@1455 544 if (v == null || v.isEmpty()) {
jjg@1455 545 env.messages.error(HTML, tree, "dc.attr.lacks.value");
jjg@1455 546 } else {
jjg@1455 547 Matcher m = docRoot.matcher(v);
jjg@1455 548 if (m.matches()) {
jjg@1455 549 String rest = m.group(2);
jjg@1455 550 if (!rest.isEmpty())
jjg@1455 551 checkURI(tree, rest);
jjg@1455 552 } else {
jjg@1455 553 checkURI(tree, v);
jjg@1455 554 }
jjg@1455 555 }
jjg@1455 556 }
jjg@1455 557 break;
jjg@1793 558
jjg@1793 559 case VALUE:
jjg@1793 560 if (currTag == HtmlTag.LI) {
jjg@1793 561 String v = getAttrValue(tree);
jjg@1793 562 if (v == null || v.isEmpty()) {
jjg@1793 563 env.messages.error(HTML, tree, "dc.attr.lacks.value");
jjg@1793 564 } else if (!validNumber.matcher(v).matches()) {
jjg@1793 565 env.messages.error(HTML, tree, "dc.attr.not.number");
jjg@1793 566 }
jjg@1793 567 }
jjg@1793 568 break;
jjg@1455 569 }
jjg@1455 570 }
jjg@1455 571 }
jjg@1455 572
jjg@1455 573 // TODO: basic check on value
jjg@1455 574
jjg@1455 575 return super.visitAttribute(tree, ignore);
jjg@1455 576 }
jjg@1455 577
jjg@1912 578 private boolean checkAnchor(String name) {
jjg@1912 579 JavaFileObject fo = env.currPath.getCompilationUnit().getSourceFile();
jjg@1912 580 Set<String> set = foundAnchors.get(fo);
jjg@1912 581 if (set == null)
jjg@1912 582 foundAnchors.put(fo, set = new HashSet<>());
jjg@1912 583 return set.add(name);
jjg@1912 584 }
jjg@1912 585
jjg@1455 586 // http://www.w3.org/TR/html401/types.html#type-name
jjg@1455 587 private static final Pattern validName = Pattern.compile("[A-Za-z][A-Za-z0-9-_:.]*");
jjg@1455 588
jjg@1793 589 private static final Pattern validNumber = Pattern.compile("-?[0-9]+");
jjg@1793 590
jjg@1455 591 // pattern to remove leading {@docRoot}/?
jjg@1455 592 private static final Pattern docRoot = Pattern.compile("(?i)(\\{@docRoot *\\}/?)?(.*)");
jjg@1455 593
jjg@1455 594 private String getAttrValue(AttributeTree tree) {
jjg@1455 595 if (tree.getValue() == null)
jjg@1455 596 return null;
jjg@1455 597
jjg@1455 598 StringWriter sw = new StringWriter();
jjg@1455 599 try {
jjg@1455 600 new DocPretty(sw).print(tree.getValue());
jjg@1455 601 } catch (IOException e) {
jjg@1455 602 // cannot happen
jjg@1455 603 }
jjg@1455 604 // ignore potential use of entities for now
jjg@1455 605 return sw.toString();
jjg@1455 606 }
jjg@1455 607
jjg@1455 608 private void checkURI(AttributeTree tree, String uri) {
jjg@1455 609 try {
jjg@1455 610 URI u = new URI(uri);
jjg@1455 611 } catch (URISyntaxException e) {
jjg@1455 612 env.messages.error(HTML, tree, "dc.invalid.uri", uri);
jjg@1455 613 }
jjg@1455 614 }
jjg@1455 615 // </editor-fold>
jjg@1455 616
jjg@1455 617 // <editor-fold defaultstate="collapsed" desc="javadoc tags">
jjg@1455 618
jjg@1455 619 @Override
jjg@1455 620 public Void visitAuthor(AuthorTree tree, Void ignore) {
jjg@1455 621 warnIfEmpty(tree, tree.getName());
jjg@1455 622 return super.visitAuthor(tree, ignore);
jjg@1455 623 }
jjg@1455 624
jjg@1455 625 @Override
jjg@1650 626 public Void visitDocRoot(DocRootTree tree, Void ignore) {
jjg@1650 627 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1650 628 return super.visitDocRoot(tree, ignore);
jjg@1650 629 }
jjg@1650 630
jjg@1650 631 @Override
jjg@1455 632 public Void visitInheritDoc(InheritDocTree tree, Void ignore) {
jjg@1650 633 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1455 634 // TODO: verify on overridden method
jjg@1455 635 foundInheritDoc = true;
jjg@1455 636 return super.visitInheritDoc(tree, ignore);
jjg@1455 637 }
jjg@1455 638
jjg@1455 639 @Override
jjg@1455 640 public Void visitLink(LinkTree tree, Void ignore) {
jjg@1650 641 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1455 642 // simulate inline context on tag stack
jjg@1455 643 HtmlTag t = (tree.getKind() == DocTree.Kind.LINK)
jjg@1455 644 ? HtmlTag.CODE : HtmlTag.SPAN;
jjg@1455 645 tagStack.push(new TagStackItem(tree, t));
jjg@1455 646 try {
jjg@1455 647 return super.visitLink(tree, ignore);
jjg@1455 648 } finally {
jjg@1455 649 tagStack.pop();
jjg@1455 650 }
jjg@1455 651 }
jjg@1455 652
jjg@1455 653 @Override
jjg@1499 654 public Void visitLiteral(LiteralTree tree, Void ignore) {
jjg@1650 655 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1499 656 if (tree.getKind() == DocTree.Kind.CODE) {
jjg@1499 657 for (TagStackItem tsi: tagStack) {
jjg@1499 658 if (tsi.tag == HtmlTag.CODE) {
jjg@1502 659 env.messages.warning(HTML, tree, "dc.tag.code.within.code");
jjg@1499 660 break;
jjg@1499 661 }
jjg@1499 662 }
jjg@1499 663 }
jjg@1499 664 return super.visitLiteral(tree, ignore);
jjg@1499 665 }
jjg@1499 666
jjg@1499 667 @Override
jlahoda@1726 668 @SuppressWarnings("fallthrough")
jjg@1455 669 public Void visitParam(ParamTree tree, Void ignore) {
jjg@1455 670 boolean typaram = tree.isTypeParameter();
jjg@1455 671 IdentifierTree nameTree = tree.getName();
jlahoda@1726 672 Element paramElement = nameTree != null ? env.trees.getElement(new DocTreePath(getCurrentPath(), nameTree)) : null;
jlahoda@1726 673
jlahoda@1726 674 if (paramElement == null) {
jlahoda@1726 675 switch (env.currElement.getKind()) {
jlahoda@1726 676 case CLASS: case INTERFACE: {
jlahoda@1726 677 if (!typaram) {
jlahoda@1726 678 env.messages.error(REFERENCE, tree, "dc.invalid.param");
jlahoda@1726 679 break;
jlahoda@1726 680 }
jlahoda@1726 681 }
jlahoda@1726 682 case METHOD: case CONSTRUCTOR: {
jlahoda@1726 683 env.messages.error(REFERENCE, nameTree, "dc.param.name.not.found");
jlahoda@1726 684 break;
jlahoda@1726 685 }
jlahoda@1726 686
jlahoda@1726 687 default:
jlahoda@1726 688 env.messages.error(REFERENCE, tree, "dc.invalid.param");
jlahoda@1726 689 break;
jjg@1455 690 }
jlahoda@1726 691 } else {
jlahoda@1726 692 foundParams.add(paramElement);
jlahoda@1726 693 }
jjg@1455 694
jjg@1455 695 warnIfEmpty(tree, tree.getDescription());
jjg@1455 696 return super.visitParam(tree, ignore);
jjg@1455 697 }
jjg@1455 698
jjg@1455 699 private void checkParamsDocumented(List<? extends Element> list) {
jjg@1455 700 if (foundInheritDoc)
jjg@1455 701 return;
jjg@1455 702
jjg@1455 703 for (Element e: list) {
jjg@1455 704 if (!foundParams.contains(e)) {
jjg@1455 705 CharSequence paramName = (e.getKind() == ElementKind.TYPE_PARAMETER)
jjg@1455 706 ? "<" + e.getSimpleName() + ">"
jjg@1455 707 : e.getSimpleName();
jjg@1455 708 reportMissing("dc.missing.param", paramName);
jjg@1455 709 }
jjg@1455 710 }
jjg@1455 711 }
jjg@1455 712
jjg@1455 713 @Override
jjg@1455 714 public Void visitReference(ReferenceTree tree, Void ignore) {
jlahoda@1726 715 Element e = env.trees.getElement(getCurrentPath());
jjg@1455 716 if (e == null)
jjg@1455 717 env.messages.error(REFERENCE, tree, "dc.ref.not.found");
jjg@1455 718 return super.visitReference(tree, ignore);
jjg@1455 719 }
jjg@1455 720
jjg@1455 721 @Override
jjg@1455 722 public Void visitReturn(ReturnTree tree, Void ignore) {
jjg@1455 723 Element e = env.trees.getElement(env.currPath);
jjg@1455 724 if (e.getKind() != ElementKind.METHOD
jjg@1455 725 || ((ExecutableElement) e).getReturnType().getKind() == TypeKind.VOID)
jjg@1455 726 env.messages.error(REFERENCE, tree, "dc.invalid.return");
jjg@1455 727 foundReturn = true;
jjg@1455 728 warnIfEmpty(tree, tree.getDescription());
jjg@1455 729 return super.visitReturn(tree, ignore);
jjg@1455 730 }
jjg@1455 731
jjg@1455 732 @Override
jjg@1455 733 public Void visitSerialData(SerialDataTree tree, Void ignore) {
jjg@1455 734 warnIfEmpty(tree, tree.getDescription());
jjg@1455 735 return super.visitSerialData(tree, ignore);
jjg@1455 736 }
jjg@1455 737
jjg@1455 738 @Override
jjg@1455 739 public Void visitSerialField(SerialFieldTree tree, Void ignore) {
jjg@1455 740 warnIfEmpty(tree, tree.getDescription());
jjg@1455 741 return super.visitSerialField(tree, ignore);
jjg@1455 742 }
jjg@1455 743
jjg@1455 744 @Override
jjg@1455 745 public Void visitSince(SinceTree tree, Void ignore) {
jjg@1455 746 warnIfEmpty(tree, tree.getBody());
jjg@1455 747 return super.visitSince(tree, ignore);
jjg@1455 748 }
jjg@1455 749
jjg@1455 750 @Override
jjg@1455 751 public Void visitThrows(ThrowsTree tree, Void ignore) {
jjg@1455 752 ReferenceTree exName = tree.getExceptionName();
jlahoda@1726 753 Element ex = env.trees.getElement(new DocTreePath(getCurrentPath(), exName));
jjg@1455 754 if (ex == null) {
jjg@1455 755 env.messages.error(REFERENCE, tree, "dc.ref.not.found");
jjg@1917 756 } else if (isThrowable(ex.asType())) {
jjg@1455 757 switch (env.currElement.getKind()) {
jjg@1455 758 case CONSTRUCTOR:
jjg@1455 759 case METHOD:
jjg@1455 760 if (isCheckedException(ex.asType())) {
jjg@1455 761 ExecutableElement ee = (ExecutableElement) env.currElement;
jjg@1455 762 checkThrowsDeclared(exName, ex.asType(), ee.getThrownTypes());
jjg@1455 763 }
jjg@1455 764 break;
jjg@1455 765 default:
jjg@1455 766 env.messages.error(REFERENCE, tree, "dc.invalid.throws");
jjg@1455 767 }
jjg@1455 768 } else {
jjg@1455 769 env.messages.error(REFERENCE, tree, "dc.invalid.throws");
jjg@1455 770 }
jjg@1455 771 warnIfEmpty(tree, tree.getDescription());
jjg@1455 772 return scan(tree.getDescription(), ignore);
jjg@1455 773 }
jjg@1455 774
jjg@1917 775 private boolean isThrowable(TypeMirror tm) {
jjg@1917 776 switch (tm.getKind()) {
jjg@1917 777 case DECLARED:
jjg@1917 778 case TYPEVAR:
jjg@1917 779 return env.types.isAssignable(tm, env.java_lang_Throwable);
jjg@1917 780 }
jjg@1917 781 return false;
jjg@1917 782 }
jjg@1917 783
jjg@1455 784 private void checkThrowsDeclared(ReferenceTree tree, TypeMirror t, List<? extends TypeMirror> list) {
jjg@1455 785 boolean found = false;
jjg@1455 786 for (TypeMirror tl : list) {
jjg@1455 787 if (env.types.isAssignable(t, tl)) {
jjg@1455 788 foundThrows.add(tl);
jjg@1455 789 found = true;
jjg@1455 790 }
jjg@1455 791 }
jjg@1455 792 if (!found)
jjg@1455 793 env.messages.error(REFERENCE, tree, "dc.exception.not.thrown", t);
jjg@1455 794 }
jjg@1455 795
jjg@1455 796 private void checkThrowsDocumented(List<? extends TypeMirror> list) {
jjg@1455 797 if (foundInheritDoc)
jjg@1455 798 return;
jjg@1455 799
jjg@1455 800 for (TypeMirror tl: list) {
jjg@1455 801 if (isCheckedException(tl) && !foundThrows.contains(tl))
jjg@1455 802 reportMissing("dc.missing.throws", tl);
jjg@1455 803 }
jjg@1455 804 }
jjg@1455 805
jjg@1455 806 @Override
jjg@1650 807 public Void visitValue(ValueTree tree, Void ignore) {
jjg@1650 808 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1650 809 return super.visitValue(tree, ignore);
jjg@1650 810 }
jjg@1650 811
jjg@1650 812 @Override
jjg@1455 813 public Void visitVersion(VersionTree tree, Void ignore) {
jjg@1455 814 warnIfEmpty(tree, tree.getBody());
jjg@1455 815 return super.visitVersion(tree, ignore);
jjg@1455 816 }
jjg@1455 817
jjg@1455 818 @Override
jjg@1455 819 public Void visitErroneous(ErroneousTree tree, Void ignore) {
jjg@1455 820 env.messages.error(SYNTAX, tree, null, tree.getDiagnostic().getMessage(null));
jjg@1455 821 return null;
jjg@1455 822 }
jjg@1455 823 // </editor-fold>
jjg@1455 824
jjg@1455 825 // <editor-fold defaultstate="collapsed" desc="Utility methods">
jjg@1455 826
jjg@1455 827 private boolean isCheckedException(TypeMirror t) {
jjg@1455 828 return !(env.types.isAssignable(t, env.java_lang_Error)
jjg@1455 829 || env.types.isAssignable(t, env.java_lang_RuntimeException));
jjg@1455 830 }
jjg@1455 831
jjg@1455 832 private boolean isSynthetic() {
jjg@1455 833 switch (env.currElement.getKind()) {
jjg@1455 834 case CONSTRUCTOR:
jjg@1455 835 // A synthetic default constructor has the same pos as the
jjg@1455 836 // enclosing class
jjg@1455 837 TreePath p = env.currPath;
jjg@1455 838 return env.getPos(p) == env.getPos(p.getParentPath());
jjg@1455 839 }
jjg@1455 840 return false;
jjg@1455 841 }
jjg@1455 842
jjg@1455 843 void markEnclosingTag(Flag flag) {
jjg@1455 844 TagStackItem top = tagStack.peek();
jjg@1455 845 if (top != null)
jjg@1455 846 top.flags.add(flag);
jjg@1455 847 }
jjg@1455 848
jjg@1455 849 String toString(TreePath p) {
jjg@1455 850 StringBuilder sb = new StringBuilder("TreePath[");
jjg@1455 851 toString(p, sb);
jjg@1455 852 sb.append("]");
jjg@1455 853 return sb.toString();
jjg@1455 854 }
jjg@1455 855
jjg@1455 856 void toString(TreePath p, StringBuilder sb) {
jjg@1455 857 TreePath parent = p.getParentPath();
jjg@1455 858 if (parent != null) {
jjg@1455 859 toString(parent, sb);
jjg@1455 860 sb.append(",");
jjg@1455 861 }
jjg@1455 862 sb.append(p.getLeaf().getKind()).append(":").append(env.getPos(p)).append(":S").append(env.getStartPos(p));
jjg@1455 863 }
jjg@1455 864
jjg@1455 865 void warnIfEmpty(DocTree tree, List<? extends DocTree> list) {
jjg@1455 866 for (DocTree d: list) {
jjg@1455 867 switch (d.getKind()) {
jjg@1455 868 case TEXT:
jjg@1507 869 if (hasNonWhitespace((TextTree) d))
jjg@1455 870 return;
jjg@1455 871 break;
jjg@1455 872 default:
jjg@1455 873 return;
jjg@1455 874 }
jjg@1455 875 }
jjg@1455 876 env.messages.warning(SYNTAX, tree, "dc.empty", tree.getKind().tagName);
jjg@1455 877 }
jjg@1507 878
jjg@1507 879 boolean hasNonWhitespace(TextTree tree) {
jjg@1507 880 String s = tree.getBody();
jjg@1507 881 for (int i = 0; i < s.length(); i++) {
jjg@1507 882 if (!Character.isWhitespace(s.charAt(i)))
jjg@1507 883 return true;
jjg@1507 884 }
jjg@1507 885 return false;
jjg@1507 886 }
jjg@1507 887
jjg@1455 888 // </editor-fold>
jjg@1455 889
jjg@1455 890 }

mercurial