src/share/classes/com/sun/tools/doclint/Checker.java

Wed, 17 Jul 2013 19:12:03 -0700

author
jjg
date
Wed, 17 Jul 2013 19:12:03 -0700
changeset 1912
1e533c1bfb01
parent 1793
391f97e270c2
child 1915
129751018061
permissions
-rw-r--r--

8020313: doclint doesn't reset HTML anchors correctly
Reviewed-by: mcimadamore

jjg@1455 1 /*
jjg@1495 2 * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
jjg@1455 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
jjg@1455 4 *
jjg@1455 5 * This code is free software; you can redistribute it and/or modify it
jjg@1455 6 * under the terms of the GNU General Public License version 2 only, as
jjg@1455 7 * published by the Free Software Foundation. Oracle designates this
jjg@1455 8 * particular file as subject to the "Classpath" exception as provided
jjg@1455 9 * by Oracle in the LICENSE file that accompanied this code.
jjg@1455 10 *
jjg@1455 11 * This code is distributed in the hope that it will be useful, but WITHOUT
jjg@1455 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
jjg@1455 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
jjg@1455 14 * version 2 for more details (a copy is included in the LICENSE file that
jjg@1455 15 * accompanied this code).
jjg@1455 16 *
jjg@1455 17 * You should have received a copy of the GNU General Public License version
jjg@1455 18 * 2 along with this work; if not, write to the Free Software Foundation,
jjg@1455 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
jjg@1455 20 *
jjg@1455 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
jjg@1455 22 * or visit www.oracle.com if you need additional information or have any
jjg@1455 23 * questions.
jjg@1455 24 */
jjg@1455 25
jjg@1455 26 package com.sun.tools.doclint;
jjg@1455 27
jjg@1650 28 import java.io.IOException;
jjg@1650 29 import java.io.StringWriter;
jjg@1455 30 import java.net.URI;
jjg@1650 31 import java.net.URISyntaxException;
jjg@1455 32 import java.util.Deque;
jjg@1455 33 import java.util.EnumSet;
jjg@1912 34 import java.util.HashMap;
jjg@1455 35 import java.util.HashSet;
jjg@1455 36 import java.util.LinkedList;
jjg@1455 37 import java.util.List;
jjg@1912 38 import java.util.Map;
jjg@1455 39 import java.util.Set;
jjg@1650 40 import java.util.regex.Matcher;
jjg@1650 41 import java.util.regex.Pattern;
jjg@1455 42
jjg@1455 43 import javax.lang.model.element.Element;
jjg@1455 44 import javax.lang.model.element.ElementKind;
jjg@1455 45 import javax.lang.model.element.ExecutableElement;
jjg@1455 46 import javax.lang.model.element.Name;
jjg@1455 47 import javax.lang.model.type.TypeKind;
jjg@1455 48 import javax.lang.model.type.TypeMirror;
jjg@1455 49 import javax.tools.Diagnostic.Kind;
jjg@1912 50 import javax.tools.JavaFileObject;
jjg@1455 51
jjg@1455 52 import com.sun.source.doctree.AttributeTree;
jjg@1455 53 import com.sun.source.doctree.AuthorTree;
jjg@1455 54 import com.sun.source.doctree.DocCommentTree;
jjg@1650 55 import com.sun.source.doctree.DocRootTree;
jjg@1455 56 import com.sun.source.doctree.DocTree;
jjg@1455 57 import com.sun.source.doctree.EndElementTree;
jjg@1455 58 import com.sun.source.doctree.EntityTree;
jjg@1455 59 import com.sun.source.doctree.ErroneousTree;
jjg@1455 60 import com.sun.source.doctree.IdentifierTree;
jjg@1455 61 import com.sun.source.doctree.InheritDocTree;
jjg@1650 62 import com.sun.source.doctree.LinkTree;
jjg@1650 63 import com.sun.source.doctree.LiteralTree;
jjg@1455 64 import com.sun.source.doctree.ParamTree;
jjg@1455 65 import com.sun.source.doctree.ReferenceTree;
jjg@1455 66 import com.sun.source.doctree.ReturnTree;
jjg@1455 67 import com.sun.source.doctree.SerialDataTree;
jjg@1455 68 import com.sun.source.doctree.SerialFieldTree;
jjg@1455 69 import com.sun.source.doctree.SinceTree;
jjg@1455 70 import com.sun.source.doctree.StartElementTree;
jjg@1455 71 import com.sun.source.doctree.TextTree;
jjg@1455 72 import com.sun.source.doctree.ThrowsTree;
jjg@1650 73 import com.sun.source.doctree.ValueTree;
jjg@1455 74 import com.sun.source.doctree.VersionTree;
jlahoda@1726 75 import com.sun.source.util.DocTreePath;
jlahoda@1726 76 import com.sun.source.util.DocTreePathScanner;
jjg@1455 77 import com.sun.source.util.TreePath;
jjg@1455 78 import com.sun.tools.doclint.HtmlTag.AttrKind;
jjg@1650 79 import com.sun.tools.javac.tree.DocPretty;
jjg@1455 80 import static com.sun.tools.doclint.Messages.Group.*;
jjg@1455 81
jjg@1455 82
jjg@1455 83 /**
jjg@1455 84 * Validate a doc comment.
jjg@1455 85 *
jjg@1455 86 * <p><b>This is NOT part of any supported API.
jjg@1455 87 * If you write code that depends on this, you do so at your own
jjg@1455 88 * risk. This code and its internal interfaces are subject to change
jjg@1455 89 * or deletion without notice.</b></p>
jjg@1455 90 */
jlahoda@1726 91 public class Checker extends DocTreePathScanner<Void, Void> {
jjg@1455 92 final Env env;
jjg@1455 93
jjg@1912 94 Set<Element> foundParams = new HashSet<>();
jjg@1912 95 Set<TypeMirror> foundThrows = new HashSet<>();
jjg@1912 96 Map<JavaFileObject, Set<String>> foundAnchors = new HashMap<>();
jjg@1455 97 boolean foundInheritDoc = false;
jjg@1455 98 boolean foundReturn = false;
jjg@1455 99
jjg@1506 100 public enum Flag {
jjg@1455 101 TABLE_HAS_CAPTION,
jjg@1455 102 HAS_ELEMENT,
jjg@1650 103 HAS_INLINE_TAG,
jjg@1507 104 HAS_TEXT,
jjg@1507 105 REPORTED_BAD_INLINE
jjg@1455 106 }
jjg@1455 107
jjg@1455 108 static class TagStackItem {
jjg@1455 109 final DocTree tree; // typically, but not always, StartElementTree
jjg@1455 110 final HtmlTag tag;
jjg@1455 111 final Set<HtmlTag.Attr> attrs;
jjg@1455 112 final Set<Flag> flags;
jjg@1455 113 TagStackItem(DocTree tree, HtmlTag tag) {
jjg@1455 114 this.tree = tree;
jjg@1455 115 this.tag = tag;
jjg@1455 116 attrs = EnumSet.noneOf(HtmlTag.Attr.class);
jjg@1455 117 flags = EnumSet.noneOf(Flag.class);
jjg@1455 118 }
jjg@1455 119 @Override
jjg@1455 120 public String toString() {
jjg@1455 121 return String.valueOf(tag);
jjg@1455 122 }
jjg@1455 123 }
jjg@1455 124
jjg@1455 125 private Deque<TagStackItem> tagStack; // TODO: maybe want to record starting tree as well
jjg@1455 126 private HtmlTag currHeaderTag;
jjg@1455 127
jjg@1668 128 private final int implicitHeaderLevel;
jjg@1668 129
jjg@1455 130 // <editor-fold defaultstate="collapsed" desc="Top level">
jjg@1455 131
jjg@1455 132 Checker(Env env) {
jjg@1455 133 env.getClass();
jjg@1455 134 this.env = env;
jjg@1912 135 tagStack = new LinkedList<>();
jjg@1668 136 implicitHeaderLevel = env.implicitHeaderLevel;
jjg@1455 137 }
jjg@1455 138
jjg@1455 139 public Void scan(DocCommentTree tree, TreePath p) {
jjg@1455 140 env.setCurrent(p, tree);
jjg@1455 141
jjg@1455 142 boolean isOverridingMethod = !env.currOverriddenMethods.isEmpty();
jjg@1455 143
jjg@1455 144 if (tree == null) {
jjg@1455 145 if (!isSynthetic() && !isOverridingMethod)
jjg@1455 146 reportMissing("dc.missing.comment");
jjg@1455 147 return null;
jjg@1455 148 }
jjg@1455 149
jjg@1455 150 tagStack.clear();
jjg@1455 151 currHeaderTag = null;
jjg@1455 152
jjg@1455 153 foundParams.clear();
jjg@1455 154 foundThrows.clear();
jjg@1455 155 foundInheritDoc = false;
jjg@1455 156 foundReturn = false;
jjg@1455 157
jlahoda@1726 158 scan(new DocTreePath(p, tree), null);
jjg@1455 159
jjg@1455 160 if (!isOverridingMethod) {
jjg@1455 161 switch (env.currElement.getKind()) {
jjg@1455 162 case METHOD:
jjg@1455 163 case CONSTRUCTOR: {
jjg@1455 164 ExecutableElement ee = (ExecutableElement) env.currElement;
jjg@1455 165 checkParamsDocumented(ee.getTypeParameters());
jjg@1455 166 checkParamsDocumented(ee.getParameters());
jjg@1455 167 switch (ee.getReturnType().getKind()) {
jjg@1455 168 case VOID:
jjg@1455 169 case NONE:
jjg@1455 170 break;
jjg@1455 171 default:
jjg@1455 172 if (!foundReturn
jjg@1455 173 && !foundInheritDoc
jjg@1455 174 && !env.types.isSameType(ee.getReturnType(), env.java_lang_Void)) {
jjg@1455 175 reportMissing("dc.missing.return");
jjg@1455 176 }
jjg@1455 177 }
jjg@1455 178 checkThrowsDocumented(ee.getThrownTypes());
jjg@1455 179 }
jjg@1455 180 }
jjg@1455 181 }
jjg@1455 182
jjg@1455 183 return null;
jjg@1455 184 }
jjg@1455 185
jjg@1455 186 private void reportMissing(String code, Object... args) {
jjg@1455 187 env.messages.report(MISSING, Kind.WARNING, env.currPath.getLeaf(), code, args);
jjg@1455 188 }
jjg@1455 189
jjg@1455 190 @Override
jjg@1455 191 public Void visitDocComment(DocCommentTree tree, Void ignore) {
jjg@1455 192 super.visitDocComment(tree, ignore);
jjg@1455 193 for (TagStackItem tsi: tagStack) {
jjg@1455 194 if (tsi.tree.getKind() == DocTree.Kind.START_ELEMENT
jjg@1455 195 && tsi.tag.endKind == HtmlTag.EndKind.REQUIRED) {
jjg@1455 196 StartElementTree t = (StartElementTree) tsi.tree;
jjg@1455 197 env.messages.error(HTML, t, "dc.tag.not.closed", t.getName());
jjg@1455 198 }
jjg@1455 199 }
jjg@1455 200 return null;
jjg@1455 201 }
jjg@1455 202 // </editor-fold>
jjg@1455 203
jjg@1455 204 // <editor-fold defaultstate="collapsed" desc="Text and entities.">
jjg@1455 205
jjg@1455 206 @Override
jjg@1455 207 public Void visitText(TextTree tree, Void ignore) {
jjg@1507 208 if (hasNonWhitespace(tree)) {
jjg@1507 209 checkAllowsText(tree);
jjg@1455 210 markEnclosingTag(Flag.HAS_TEXT);
jjg@1455 211 }
jjg@1455 212 return null;
jjg@1455 213 }
jjg@1455 214
jjg@1455 215 @Override
jjg@1455 216 public Void visitEntity(EntityTree tree, Void ignore) {
jjg@1507 217 checkAllowsText(tree);
jjg@1455 218 markEnclosingTag(Flag.HAS_TEXT);
jjg@1455 219 String name = tree.getName().toString();
jjg@1455 220 if (name.startsWith("#")) {
jjg@1455 221 int v = name.toLowerCase().startsWith("#x")
jjg@1455 222 ? Integer.parseInt(name.substring(2), 16)
jjg@1455 223 : Integer.parseInt(name.substring(1), 10);
jjg@1455 224 if (!Entity.isValid(v)) {
jjg@1455 225 env.messages.error(HTML, tree, "dc.entity.invalid", name);
jjg@1455 226 }
jjg@1455 227 } else if (!Entity.isValid(name)) {
jjg@1455 228 env.messages.error(HTML, tree, "dc.entity.invalid", name);
jjg@1455 229 }
jjg@1455 230 return null;
jjg@1455 231 }
jjg@1455 232
jjg@1507 233 void checkAllowsText(DocTree tree) {
jjg@1507 234 TagStackItem top = tagStack.peek();
jjg@1507 235 if (top != null
jjg@1507 236 && top.tree.getKind() == DocTree.Kind.START_ELEMENT
jjg@1507 237 && !top.tag.acceptsText()) {
jjg@1507 238 if (top.flags.add(Flag.REPORTED_BAD_INLINE)) {
jjg@1507 239 env.messages.error(HTML, tree, "dc.text.not.allowed",
jjg@1507 240 ((StartElementTree) top.tree).getName());
jjg@1507 241 }
jjg@1507 242 }
jjg@1507 243 }
jjg@1507 244
jjg@1455 245 // </editor-fold>
jjg@1455 246
jjg@1455 247 // <editor-fold defaultstate="collapsed" desc="HTML elements">
jjg@1455 248
jjg@1455 249 @Override
jjg@1455 250 public Void visitStartElement(StartElementTree tree, Void ignore) {
jjg@1455 251 markEnclosingTag(Flag.HAS_ELEMENT);
jjg@1455 252 final Name treeName = tree.getName();
jjg@1455 253 final HtmlTag t = HtmlTag.get(treeName);
jjg@1455 254 if (t == null) {
jjg@1455 255 env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
jjg@1455 256 } else {
jjg@1552 257 boolean done = false;
jjg@1507 258 for (TagStackItem tsi: tagStack) {
jjg@1507 259 if (tsi.tag.accepts(t)) {
jjg@1507 260 while (tagStack.peek() != tsi) tagStack.pop();
jjg@1552 261 done = true;
jjg@1507 262 break;
jjg@1552 263 } else if (tsi.tag.endKind != HtmlTag.EndKind.OPTIONAL) {
jjg@1552 264 done = true;
jjg@1507 265 break;
jjg@1552 266 }
jjg@1552 267 }
jjg@1552 268 if (!done && HtmlTag.BODY.accepts(t)) {
jjg@1552 269 tagStack.clear();
jjg@1507 270 }
jjg@1507 271
jjg@1507 272 checkStructure(tree, t);
jjg@1507 273
jjg@1455 274 // tag specific checks
jjg@1455 275 switch (t) {
jjg@1455 276 // check for out of sequence headers, such as <h1>...</h1> <h3>...</h3>
jjg@1455 277 case H1: case H2: case H3: case H4: case H5: case H6:
jjg@1455 278 checkHeader(tree, t);
jjg@1455 279 break;
jjg@1455 280 }
jjg@1455 281
jjg@1455 282 if (t.flags.contains(HtmlTag.Flag.NO_NEST)) {
jjg@1455 283 for (TagStackItem i: tagStack) {
jjg@1455 284 if (t == i.tag) {
jjg@1455 285 env.messages.warning(HTML, tree, "dc.tag.nested.not.allowed", treeName);
jjg@1455 286 break;
jjg@1455 287 }
jjg@1455 288 }
jjg@1455 289 }
jjg@1455 290 }
jjg@1455 291
jjg@1455 292 // check for self closing tags, such as <a id="name"/>
jjg@1455 293 if (tree.isSelfClosing()) {
jjg@1455 294 env.messages.error(HTML, tree, "dc.tag.self.closing", treeName);
jjg@1455 295 }
jjg@1455 296
jjg@1455 297 try {
jjg@1455 298 TagStackItem parent = tagStack.peek();
jjg@1455 299 TagStackItem top = new TagStackItem(tree, t);
jjg@1455 300 tagStack.push(top);
jjg@1455 301
jjg@1455 302 super.visitStartElement(tree, ignore);
jjg@1455 303
jjg@1455 304 // handle attributes that may or may not have been found in start element
jjg@1455 305 if (t != null) {
jjg@1455 306 switch (t) {
jjg@1455 307 case CAPTION:
jjg@1455 308 if (parent != null && parent.tag == HtmlTag.TABLE)
jjg@1455 309 parent.flags.add(Flag.TABLE_HAS_CAPTION);
jjg@1455 310 break;
jjg@1455 311
jjg@1455 312 case IMG:
jjg@1455 313 if (!top.attrs.contains(HtmlTag.Attr.ALT))
jjg@1455 314 env.messages.error(ACCESSIBILITY, tree, "dc.no.alt.attr.for.image");
jjg@1455 315 break;
jjg@1455 316 }
jjg@1455 317 }
jjg@1455 318
jjg@1455 319 return null;
jjg@1455 320 } finally {
jjg@1455 321
jjg@1455 322 if (t == null || t.endKind == HtmlTag.EndKind.NONE)
jjg@1455 323 tagStack.pop();
jjg@1455 324 }
jjg@1455 325 }
jjg@1455 326
jjg@1507 327 private void checkStructure(StartElementTree tree, HtmlTag t) {
jjg@1507 328 Name treeName = tree.getName();
jjg@1507 329 TagStackItem top = tagStack.peek();
jjg@1507 330 switch (t.blockType) {
jjg@1507 331 case BLOCK:
jjg@1507 332 if (top == null || top.tag.accepts(t))
jjg@1507 333 return;
jjg@1507 334
jjg@1507 335 switch (top.tree.getKind()) {
jjg@1507 336 case START_ELEMENT: {
jjg@1507 337 if (top.tag.blockType == HtmlTag.BlockType.INLINE) {
jjg@1507 338 Name name = ((StartElementTree) top.tree).getName();
jjg@1507 339 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.element",
jjg@1507 340 treeName, name);
jjg@1507 341 return;
jjg@1507 342 }
jjg@1507 343 }
jjg@1507 344 break;
jjg@1507 345
jjg@1507 346 case LINK:
jjg@1507 347 case LINK_PLAIN: {
jjg@1507 348 String name = top.tree.getKind().tagName;
jjg@1507 349 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.tag",
jjg@1507 350 treeName, name);
jjg@1507 351 return;
jjg@1507 352 }
jjg@1507 353 }
jjg@1507 354 break;
jjg@1507 355
jjg@1507 356 case INLINE:
jjg@1507 357 if (top == null || top.tag.accepts(t))
jjg@1507 358 return;
jjg@1507 359 break;
jjg@1507 360
jjg@1507 361 case LIST_ITEM:
jjg@1507 362 case TABLE_ITEM:
jjg@1507 363 if (top != null) {
jjg@1507 364 // reset this flag so subsequent bad inline content gets reported
jjg@1507 365 top.flags.remove(Flag.REPORTED_BAD_INLINE);
jjg@1507 366 if (top.tag.accepts(t))
jjg@1507 367 return;
jjg@1507 368 }
jjg@1507 369 break;
jjg@1507 370
jjg@1507 371 case OTHER:
jjg@1507 372 env.messages.error(HTML, tree, "dc.tag.not.allowed", treeName);
jjg@1507 373 return;
jjg@1507 374 }
jjg@1507 375
jjg@1507 376 env.messages.error(HTML, tree, "dc.tag.not.allowed.here", treeName);
jjg@1507 377 }
jjg@1507 378
jjg@1455 379 private void checkHeader(StartElementTree tree, HtmlTag tag) {
jjg@1455 380 // verify the new tag
jjg@1455 381 if (getHeaderLevel(tag) > getHeaderLevel(currHeaderTag) + 1) {
jjg@1455 382 if (currHeaderTag == null) {
jjg@1455 383 env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.1", tag);
jjg@1455 384 } else {
jjg@1455 385 env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.2",
jjg@1455 386 tag, currHeaderTag);
jjg@1455 387 }
jjg@1455 388 }
jjg@1455 389
jjg@1455 390 currHeaderTag = tag;
jjg@1455 391 }
jjg@1455 392
jjg@1455 393 private int getHeaderLevel(HtmlTag tag) {
jjg@1455 394 if (tag == null)
jjg@1668 395 return implicitHeaderLevel;
jjg@1455 396 switch (tag) {
jjg@1455 397 case H1: return 1;
jjg@1455 398 case H2: return 2;
jjg@1455 399 case H3: return 3;
jjg@1455 400 case H4: return 4;
jjg@1455 401 case H5: return 5;
jjg@1455 402 case H6: return 6;
jjg@1455 403 default: throw new IllegalArgumentException();
jjg@1455 404 }
jjg@1455 405 }
jjg@1455 406
jjg@1455 407 @Override
jjg@1455 408 public Void visitEndElement(EndElementTree tree, Void ignore) {
jjg@1455 409 final Name treeName = tree.getName();
jjg@1455 410 final HtmlTag t = HtmlTag.get(treeName);
jjg@1455 411 if (t == null) {
jjg@1455 412 env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
jjg@1455 413 } else if (t.endKind == HtmlTag.EndKind.NONE) {
jjg@1455 414 env.messages.error(HTML, tree, "dc.tag.end.not.permitted", treeName);
jjg@1455 415 } else {
jjg@1499 416 boolean done = false;
jjg@1455 417 while (!tagStack.isEmpty()) {
jjg@1455 418 TagStackItem top = tagStack.peek();
jjg@1455 419 if (t == top.tag) {
jjg@1455 420 switch (t) {
jjg@1455 421 case TABLE:
jjg@1455 422 if (!top.attrs.contains(HtmlTag.Attr.SUMMARY)
jjg@1455 423 && !top.flags.contains(Flag.TABLE_HAS_CAPTION)) {
jjg@1455 424 env.messages.error(ACCESSIBILITY, tree,
jjg@1455 425 "dc.no.summary.or.caption.for.table");
jjg@1455 426 }
jjg@1455 427 }
jjg@1455 428 if (t.flags.contains(HtmlTag.Flag.EXPECT_CONTENT)
jjg@1455 429 && !top.flags.contains(Flag.HAS_TEXT)
jjg@1650 430 && !top.flags.contains(Flag.HAS_ELEMENT)
jjg@1650 431 && !top.flags.contains(Flag.HAS_INLINE_TAG)) {
jjg@1455 432 env.messages.warning(HTML, tree, "dc.tag.empty", treeName);
jjg@1455 433 }
jjg@1455 434 tagStack.pop();
jjg@1499 435 done = true;
jjg@1455 436 break;
jjg@1455 437 } else if (top.tag == null || top.tag.endKind != HtmlTag.EndKind.REQUIRED) {
jjg@1455 438 tagStack.pop();
jjg@1455 439 } else {
jjg@1455 440 boolean found = false;
jjg@1455 441 for (TagStackItem si: tagStack) {
jjg@1455 442 if (si.tag == t) {
jjg@1455 443 found = true;
jjg@1455 444 break;
jjg@1455 445 }
jjg@1455 446 }
jjg@1455 447 if (found && top.tree.getKind() == DocTree.Kind.START_ELEMENT) {
jjg@1455 448 env.messages.error(HTML, top.tree, "dc.tag.start.unmatched",
jjg@1455 449 ((StartElementTree) top.tree).getName());
jjg@1455 450 tagStack.pop();
jjg@1455 451 } else {
jjg@1455 452 env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
jjg@1499 453 done = true;
jjg@1455 454 break;
jjg@1455 455 }
jjg@1455 456 }
jjg@1455 457 }
jjg@1499 458
jjg@1499 459 if (!done && tagStack.isEmpty()) {
jjg@1499 460 env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
jjg@1499 461 }
jjg@1455 462 }
jjg@1455 463
jjg@1455 464 return super.visitEndElement(tree, ignore);
jjg@1455 465 }
jjg@1455 466 // </editor-fold>
jjg@1455 467
jjg@1455 468 // <editor-fold defaultstate="collapsed" desc="HTML attributes">
jjg@1455 469
jjg@1455 470 @Override @SuppressWarnings("fallthrough")
jjg@1455 471 public Void visitAttribute(AttributeTree tree, Void ignore) {
jjg@1455 472 HtmlTag currTag = tagStack.peek().tag;
jjg@1455 473 if (currTag != null) {
jjg@1455 474 Name name = tree.getName();
jjg@1455 475 HtmlTag.Attr attr = currTag.getAttr(name);
jjg@1455 476 if (attr != null) {
jjg@1455 477 boolean first = tagStack.peek().attrs.add(attr);
jjg@1455 478 if (!first)
jjg@1455 479 env.messages.error(HTML, tree, "dc.attr.repeated", name);
jjg@1455 480 }
jjg@1455 481 AttrKind k = currTag.getAttrKind(name);
jjg@1455 482 switch (k) {
jjg@1455 483 case OK:
jjg@1455 484 break;
jjg@1455 485
jjg@1455 486 case INVALID:
jjg@1455 487 env.messages.error(HTML, tree, "dc.attr.unknown", name);
jjg@1455 488 break;
jjg@1455 489
jjg@1455 490 case OBSOLETE:
jjg@1455 491 env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete", name);
jjg@1455 492 break;
jjg@1455 493
jjg@1455 494 case USE_CSS:
jjg@1455 495 env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete.use.css", name);
jjg@1455 496 break;
jjg@1455 497 }
jjg@1455 498
jjg@1455 499 if (attr != null) {
jjg@1455 500 switch (attr) {
jjg@1455 501 case NAME:
jjg@1455 502 if (currTag != HtmlTag.A) {
jjg@1455 503 break;
jjg@1455 504 }
jjg@1495 505 // fallthrough
jjg@1455 506 case ID:
jjg@1455 507 String value = getAttrValue(tree);
jjg@1495 508 if (value == null) {
jjg@1495 509 env.messages.error(HTML, tree, "dc.anchor.value.missing");
jjg@1495 510 } else {
jjg@1495 511 if (!validName.matcher(value).matches()) {
jjg@1495 512 env.messages.error(HTML, tree, "dc.invalid.anchor", value);
jjg@1495 513 }
jjg@1912 514 if (!checkAnchor(value)) {
jjg@1495 515 env.messages.error(HTML, tree, "dc.anchor.already.defined", value);
jjg@1495 516 }
jjg@1455 517 }
jjg@1455 518 break;
jjg@1455 519
jjg@1455 520 case HREF:
jjg@1455 521 if (currTag == HtmlTag.A) {
jjg@1455 522 String v = getAttrValue(tree);
jjg@1455 523 if (v == null || v.isEmpty()) {
jjg@1455 524 env.messages.error(HTML, tree, "dc.attr.lacks.value");
jjg@1455 525 } else {
jjg@1455 526 Matcher m = docRoot.matcher(v);
jjg@1455 527 if (m.matches()) {
jjg@1455 528 String rest = m.group(2);
jjg@1455 529 if (!rest.isEmpty())
jjg@1455 530 checkURI(tree, rest);
jjg@1455 531 } else {
jjg@1455 532 checkURI(tree, v);
jjg@1455 533 }
jjg@1455 534 }
jjg@1455 535 }
jjg@1455 536 break;
jjg@1793 537
jjg@1793 538 case VALUE:
jjg@1793 539 if (currTag == HtmlTag.LI) {
jjg@1793 540 String v = getAttrValue(tree);
jjg@1793 541 if (v == null || v.isEmpty()) {
jjg@1793 542 env.messages.error(HTML, tree, "dc.attr.lacks.value");
jjg@1793 543 } else if (!validNumber.matcher(v).matches()) {
jjg@1793 544 env.messages.error(HTML, tree, "dc.attr.not.number");
jjg@1793 545 }
jjg@1793 546 }
jjg@1793 547 break;
jjg@1455 548 }
jjg@1455 549 }
jjg@1455 550 }
jjg@1455 551
jjg@1455 552 // TODO: basic check on value
jjg@1455 553
jjg@1455 554 return super.visitAttribute(tree, ignore);
jjg@1455 555 }
jjg@1455 556
jjg@1912 557 private boolean checkAnchor(String name) {
jjg@1912 558 JavaFileObject fo = env.currPath.getCompilationUnit().getSourceFile();
jjg@1912 559 Set<String> set = foundAnchors.get(fo);
jjg@1912 560 if (set == null)
jjg@1912 561 foundAnchors.put(fo, set = new HashSet<>());
jjg@1912 562 return set.add(name);
jjg@1912 563 }
jjg@1912 564
jjg@1455 565 // http://www.w3.org/TR/html401/types.html#type-name
jjg@1455 566 private static final Pattern validName = Pattern.compile("[A-Za-z][A-Za-z0-9-_:.]*");
jjg@1455 567
jjg@1793 568 private static final Pattern validNumber = Pattern.compile("-?[0-9]+");
jjg@1793 569
jjg@1455 570 // pattern to remove leading {@docRoot}/?
jjg@1455 571 private static final Pattern docRoot = Pattern.compile("(?i)(\\{@docRoot *\\}/?)?(.*)");
jjg@1455 572
jjg@1455 573 private String getAttrValue(AttributeTree tree) {
jjg@1455 574 if (tree.getValue() == null)
jjg@1455 575 return null;
jjg@1455 576
jjg@1455 577 StringWriter sw = new StringWriter();
jjg@1455 578 try {
jjg@1455 579 new DocPretty(sw).print(tree.getValue());
jjg@1455 580 } catch (IOException e) {
jjg@1455 581 // cannot happen
jjg@1455 582 }
jjg@1455 583 // ignore potential use of entities for now
jjg@1455 584 return sw.toString();
jjg@1455 585 }
jjg@1455 586
jjg@1455 587 private void checkURI(AttributeTree tree, String uri) {
jjg@1455 588 try {
jjg@1455 589 URI u = new URI(uri);
jjg@1455 590 } catch (URISyntaxException e) {
jjg@1455 591 env.messages.error(HTML, tree, "dc.invalid.uri", uri);
jjg@1455 592 }
jjg@1455 593 }
jjg@1455 594 // </editor-fold>
jjg@1455 595
jjg@1455 596 // <editor-fold defaultstate="collapsed" desc="javadoc tags">
jjg@1455 597
jjg@1455 598 @Override
jjg@1455 599 public Void visitAuthor(AuthorTree tree, Void ignore) {
jjg@1455 600 warnIfEmpty(tree, tree.getName());
jjg@1455 601 return super.visitAuthor(tree, ignore);
jjg@1455 602 }
jjg@1455 603
jjg@1455 604 @Override
jjg@1650 605 public Void visitDocRoot(DocRootTree tree, Void ignore) {
jjg@1650 606 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1650 607 return super.visitDocRoot(tree, ignore);
jjg@1650 608 }
jjg@1650 609
jjg@1650 610 @Override
jjg@1455 611 public Void visitInheritDoc(InheritDocTree tree, Void ignore) {
jjg@1650 612 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1455 613 // TODO: verify on overridden method
jjg@1455 614 foundInheritDoc = true;
jjg@1455 615 return super.visitInheritDoc(tree, ignore);
jjg@1455 616 }
jjg@1455 617
jjg@1455 618 @Override
jjg@1455 619 public Void visitLink(LinkTree tree, Void ignore) {
jjg@1650 620 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1455 621 // simulate inline context on tag stack
jjg@1455 622 HtmlTag t = (tree.getKind() == DocTree.Kind.LINK)
jjg@1455 623 ? HtmlTag.CODE : HtmlTag.SPAN;
jjg@1455 624 tagStack.push(new TagStackItem(tree, t));
jjg@1455 625 try {
jjg@1455 626 return super.visitLink(tree, ignore);
jjg@1455 627 } finally {
jjg@1455 628 tagStack.pop();
jjg@1455 629 }
jjg@1455 630 }
jjg@1455 631
jjg@1455 632 @Override
jjg@1499 633 public Void visitLiteral(LiteralTree tree, Void ignore) {
jjg@1650 634 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1499 635 if (tree.getKind() == DocTree.Kind.CODE) {
jjg@1499 636 for (TagStackItem tsi: tagStack) {
jjg@1499 637 if (tsi.tag == HtmlTag.CODE) {
jjg@1502 638 env.messages.warning(HTML, tree, "dc.tag.code.within.code");
jjg@1499 639 break;
jjg@1499 640 }
jjg@1499 641 }
jjg@1499 642 }
jjg@1499 643 return super.visitLiteral(tree, ignore);
jjg@1499 644 }
jjg@1499 645
jjg@1499 646 @Override
jlahoda@1726 647 @SuppressWarnings("fallthrough")
jjg@1455 648 public Void visitParam(ParamTree tree, Void ignore) {
jjg@1455 649 boolean typaram = tree.isTypeParameter();
jjg@1455 650 IdentifierTree nameTree = tree.getName();
jlahoda@1726 651 Element paramElement = nameTree != null ? env.trees.getElement(new DocTreePath(getCurrentPath(), nameTree)) : null;
jlahoda@1726 652
jlahoda@1726 653 if (paramElement == null) {
jlahoda@1726 654 switch (env.currElement.getKind()) {
jlahoda@1726 655 case CLASS: case INTERFACE: {
jlahoda@1726 656 if (!typaram) {
jlahoda@1726 657 env.messages.error(REFERENCE, tree, "dc.invalid.param");
jlahoda@1726 658 break;
jlahoda@1726 659 }
jlahoda@1726 660 }
jlahoda@1726 661 case METHOD: case CONSTRUCTOR: {
jlahoda@1726 662 env.messages.error(REFERENCE, nameTree, "dc.param.name.not.found");
jlahoda@1726 663 break;
jlahoda@1726 664 }
jlahoda@1726 665
jlahoda@1726 666 default:
jlahoda@1726 667 env.messages.error(REFERENCE, tree, "dc.invalid.param");
jlahoda@1726 668 break;
jjg@1455 669 }
jlahoda@1726 670 } else {
jlahoda@1726 671 foundParams.add(paramElement);
jlahoda@1726 672 }
jjg@1455 673
jjg@1455 674 warnIfEmpty(tree, tree.getDescription());
jjg@1455 675 return super.visitParam(tree, ignore);
jjg@1455 676 }
jjg@1455 677
jjg@1455 678 private void checkParamsDocumented(List<? extends Element> list) {
jjg@1455 679 if (foundInheritDoc)
jjg@1455 680 return;
jjg@1455 681
jjg@1455 682 for (Element e: list) {
jjg@1455 683 if (!foundParams.contains(e)) {
jjg@1455 684 CharSequence paramName = (e.getKind() == ElementKind.TYPE_PARAMETER)
jjg@1455 685 ? "<" + e.getSimpleName() + ">"
jjg@1455 686 : e.getSimpleName();
jjg@1455 687 reportMissing("dc.missing.param", paramName);
jjg@1455 688 }
jjg@1455 689 }
jjg@1455 690 }
jjg@1455 691
jjg@1455 692 @Override
jjg@1455 693 public Void visitReference(ReferenceTree tree, Void ignore) {
jlahoda@1726 694 Element e = env.trees.getElement(getCurrentPath());
jjg@1455 695 if (e == null)
jjg@1455 696 env.messages.error(REFERENCE, tree, "dc.ref.not.found");
jjg@1455 697 return super.visitReference(tree, ignore);
jjg@1455 698 }
jjg@1455 699
jjg@1455 700 @Override
jjg@1455 701 public Void visitReturn(ReturnTree tree, Void ignore) {
jjg@1455 702 Element e = env.trees.getElement(env.currPath);
jjg@1455 703 if (e.getKind() != ElementKind.METHOD
jjg@1455 704 || ((ExecutableElement) e).getReturnType().getKind() == TypeKind.VOID)
jjg@1455 705 env.messages.error(REFERENCE, tree, "dc.invalid.return");
jjg@1455 706 foundReturn = true;
jjg@1455 707 warnIfEmpty(tree, tree.getDescription());
jjg@1455 708 return super.visitReturn(tree, ignore);
jjg@1455 709 }
jjg@1455 710
jjg@1455 711 @Override
jjg@1455 712 public Void visitSerialData(SerialDataTree tree, Void ignore) {
jjg@1455 713 warnIfEmpty(tree, tree.getDescription());
jjg@1455 714 return super.visitSerialData(tree, ignore);
jjg@1455 715 }
jjg@1455 716
jjg@1455 717 @Override
jjg@1455 718 public Void visitSerialField(SerialFieldTree tree, Void ignore) {
jjg@1455 719 warnIfEmpty(tree, tree.getDescription());
jjg@1455 720 return super.visitSerialField(tree, ignore);
jjg@1455 721 }
jjg@1455 722
jjg@1455 723 @Override
jjg@1455 724 public Void visitSince(SinceTree tree, Void ignore) {
jjg@1455 725 warnIfEmpty(tree, tree.getBody());
jjg@1455 726 return super.visitSince(tree, ignore);
jjg@1455 727 }
jjg@1455 728
jjg@1455 729 @Override
jjg@1455 730 public Void visitThrows(ThrowsTree tree, Void ignore) {
jjg@1455 731 ReferenceTree exName = tree.getExceptionName();
jlahoda@1726 732 Element ex = env.trees.getElement(new DocTreePath(getCurrentPath(), exName));
jjg@1455 733 if (ex == null) {
jjg@1455 734 env.messages.error(REFERENCE, tree, "dc.ref.not.found");
jjg@1455 735 } else if (ex.asType().getKind() == TypeKind.DECLARED
jjg@1455 736 && env.types.isAssignable(ex.asType(), env.java_lang_Throwable)) {
jjg@1455 737 switch (env.currElement.getKind()) {
jjg@1455 738 case CONSTRUCTOR:
jjg@1455 739 case METHOD:
jjg@1455 740 if (isCheckedException(ex.asType())) {
jjg@1455 741 ExecutableElement ee = (ExecutableElement) env.currElement;
jjg@1455 742 checkThrowsDeclared(exName, ex.asType(), ee.getThrownTypes());
jjg@1455 743 }
jjg@1455 744 break;
jjg@1455 745 default:
jjg@1455 746 env.messages.error(REFERENCE, tree, "dc.invalid.throws");
jjg@1455 747 }
jjg@1455 748 } else {
jjg@1455 749 env.messages.error(REFERENCE, tree, "dc.invalid.throws");
jjg@1455 750 }
jjg@1455 751 warnIfEmpty(tree, tree.getDescription());
jjg@1455 752 return scan(tree.getDescription(), ignore);
jjg@1455 753 }
jjg@1455 754
jjg@1455 755 private void checkThrowsDeclared(ReferenceTree tree, TypeMirror t, List<? extends TypeMirror> list) {
jjg@1455 756 boolean found = false;
jjg@1455 757 for (TypeMirror tl : list) {
jjg@1455 758 if (env.types.isAssignable(t, tl)) {
jjg@1455 759 foundThrows.add(tl);
jjg@1455 760 found = true;
jjg@1455 761 }
jjg@1455 762 }
jjg@1455 763 if (!found)
jjg@1455 764 env.messages.error(REFERENCE, tree, "dc.exception.not.thrown", t);
jjg@1455 765 }
jjg@1455 766
jjg@1455 767 private void checkThrowsDocumented(List<? extends TypeMirror> list) {
jjg@1455 768 if (foundInheritDoc)
jjg@1455 769 return;
jjg@1455 770
jjg@1455 771 for (TypeMirror tl: list) {
jjg@1455 772 if (isCheckedException(tl) && !foundThrows.contains(tl))
jjg@1455 773 reportMissing("dc.missing.throws", tl);
jjg@1455 774 }
jjg@1455 775 }
jjg@1455 776
jjg@1455 777 @Override
jjg@1650 778 public Void visitValue(ValueTree tree, Void ignore) {
jjg@1650 779 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1650 780 return super.visitValue(tree, ignore);
jjg@1650 781 }
jjg@1650 782
jjg@1650 783 @Override
jjg@1455 784 public Void visitVersion(VersionTree tree, Void ignore) {
jjg@1455 785 warnIfEmpty(tree, tree.getBody());
jjg@1455 786 return super.visitVersion(tree, ignore);
jjg@1455 787 }
jjg@1455 788
jjg@1455 789 @Override
jjg@1455 790 public Void visitErroneous(ErroneousTree tree, Void ignore) {
jjg@1455 791 env.messages.error(SYNTAX, tree, null, tree.getDiagnostic().getMessage(null));
jjg@1455 792 return null;
jjg@1455 793 }
jjg@1455 794 // </editor-fold>
jjg@1455 795
jjg@1455 796 // <editor-fold defaultstate="collapsed" desc="Utility methods">
jjg@1455 797
jjg@1455 798 private boolean isCheckedException(TypeMirror t) {
jjg@1455 799 return !(env.types.isAssignable(t, env.java_lang_Error)
jjg@1455 800 || env.types.isAssignable(t, env.java_lang_RuntimeException));
jjg@1455 801 }
jjg@1455 802
jjg@1455 803 private boolean isSynthetic() {
jjg@1455 804 switch (env.currElement.getKind()) {
jjg@1455 805 case CONSTRUCTOR:
jjg@1455 806 // A synthetic default constructor has the same pos as the
jjg@1455 807 // enclosing class
jjg@1455 808 TreePath p = env.currPath;
jjg@1455 809 return env.getPos(p) == env.getPos(p.getParentPath());
jjg@1455 810 }
jjg@1455 811 return false;
jjg@1455 812 }
jjg@1455 813
jjg@1455 814 void markEnclosingTag(Flag flag) {
jjg@1455 815 TagStackItem top = tagStack.peek();
jjg@1455 816 if (top != null)
jjg@1455 817 top.flags.add(flag);
jjg@1455 818 }
jjg@1455 819
jjg@1455 820 String toString(TreePath p) {
jjg@1455 821 StringBuilder sb = new StringBuilder("TreePath[");
jjg@1455 822 toString(p, sb);
jjg@1455 823 sb.append("]");
jjg@1455 824 return sb.toString();
jjg@1455 825 }
jjg@1455 826
jjg@1455 827 void toString(TreePath p, StringBuilder sb) {
jjg@1455 828 TreePath parent = p.getParentPath();
jjg@1455 829 if (parent != null) {
jjg@1455 830 toString(parent, sb);
jjg@1455 831 sb.append(",");
jjg@1455 832 }
jjg@1455 833 sb.append(p.getLeaf().getKind()).append(":").append(env.getPos(p)).append(":S").append(env.getStartPos(p));
jjg@1455 834 }
jjg@1455 835
jjg@1455 836 void warnIfEmpty(DocTree tree, List<? extends DocTree> list) {
jjg@1455 837 for (DocTree d: list) {
jjg@1455 838 switch (d.getKind()) {
jjg@1455 839 case TEXT:
jjg@1507 840 if (hasNonWhitespace((TextTree) d))
jjg@1455 841 return;
jjg@1455 842 break;
jjg@1455 843 default:
jjg@1455 844 return;
jjg@1455 845 }
jjg@1455 846 }
jjg@1455 847 env.messages.warning(SYNTAX, tree, "dc.empty", tree.getKind().tagName);
jjg@1455 848 }
jjg@1507 849
jjg@1507 850 boolean hasNonWhitespace(TextTree tree) {
jjg@1507 851 String s = tree.getBody();
jjg@1507 852 for (int i = 0; i < s.length(); i++) {
jjg@1507 853 if (!Character.isWhitespace(s.charAt(i)))
jjg@1507 854 return true;
jjg@1507 855 }
jjg@1507 856 return false;
jjg@1507 857 }
jjg@1507 858
jjg@1455 859 // </editor-fold>
jjg@1455 860
jjg@1455 861 }

mercurial