src/share/classes/com/sun/tools/doclint/Checker.java

Mon, 03 Jun 2013 16:22:27 -0700

author
jjg
date
Mon, 03 Jun 2013 16:22:27 -0700
changeset 1793
391f97e270c2
parent 1726
a7ff36d06fa2
child 1912
1e533c1bfb01
permissions
-rw-r--r--

8013405: DocLint should support <LI value="value">
Reviewed-by: ksrini

jjg@1455 1 /*
jjg@1495 2 * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
jjg@1455 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
jjg@1455 4 *
jjg@1455 5 * This code is free software; you can redistribute it and/or modify it
jjg@1455 6 * under the terms of the GNU General Public License version 2 only, as
jjg@1455 7 * published by the Free Software Foundation. Oracle designates this
jjg@1455 8 * particular file as subject to the "Classpath" exception as provided
jjg@1455 9 * by Oracle in the LICENSE file that accompanied this code.
jjg@1455 10 *
jjg@1455 11 * This code is distributed in the hope that it will be useful, but WITHOUT
jjg@1455 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
jjg@1455 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
jjg@1455 14 * version 2 for more details (a copy is included in the LICENSE file that
jjg@1455 15 * accompanied this code).
jjg@1455 16 *
jjg@1455 17 * You should have received a copy of the GNU General Public License version
jjg@1455 18 * 2 along with this work; if not, write to the Free Software Foundation,
jjg@1455 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
jjg@1455 20 *
jjg@1455 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
jjg@1455 22 * or visit www.oracle.com if you need additional information or have any
jjg@1455 23 * questions.
jjg@1455 24 */
jjg@1455 25
jjg@1455 26 package com.sun.tools.doclint;
jjg@1455 27
jjg@1650 28 import java.io.IOException;
jjg@1650 29 import java.io.StringWriter;
jjg@1455 30 import java.net.URI;
jjg@1650 31 import java.net.URISyntaxException;
jjg@1455 32 import java.util.Deque;
jjg@1455 33 import java.util.EnumSet;
jjg@1455 34 import java.util.HashSet;
jjg@1455 35 import java.util.LinkedList;
jjg@1455 36 import java.util.List;
jjg@1455 37 import java.util.Set;
jjg@1650 38 import java.util.regex.Matcher;
jjg@1650 39 import java.util.regex.Pattern;
jjg@1455 40
jjg@1455 41 import javax.lang.model.element.Element;
jjg@1455 42 import javax.lang.model.element.ElementKind;
jjg@1455 43 import javax.lang.model.element.ExecutableElement;
jjg@1455 44 import javax.lang.model.element.Name;
jjg@1455 45 import javax.lang.model.type.TypeKind;
jjg@1455 46 import javax.lang.model.type.TypeMirror;
jjg@1455 47 import javax.tools.Diagnostic.Kind;
jjg@1455 48
jjg@1455 49 import com.sun.source.doctree.AttributeTree;
jjg@1455 50 import com.sun.source.doctree.AuthorTree;
jjg@1455 51 import com.sun.source.doctree.DocCommentTree;
jjg@1650 52 import com.sun.source.doctree.DocRootTree;
jjg@1455 53 import com.sun.source.doctree.DocTree;
jjg@1455 54 import com.sun.source.doctree.EndElementTree;
jjg@1455 55 import com.sun.source.doctree.EntityTree;
jjg@1455 56 import com.sun.source.doctree.ErroneousTree;
jjg@1455 57 import com.sun.source.doctree.IdentifierTree;
jjg@1455 58 import com.sun.source.doctree.InheritDocTree;
jjg@1650 59 import com.sun.source.doctree.LinkTree;
jjg@1650 60 import com.sun.source.doctree.LiteralTree;
jjg@1455 61 import com.sun.source.doctree.ParamTree;
jjg@1455 62 import com.sun.source.doctree.ReferenceTree;
jjg@1455 63 import com.sun.source.doctree.ReturnTree;
jjg@1455 64 import com.sun.source.doctree.SerialDataTree;
jjg@1455 65 import com.sun.source.doctree.SerialFieldTree;
jjg@1455 66 import com.sun.source.doctree.SinceTree;
jjg@1455 67 import com.sun.source.doctree.StartElementTree;
jjg@1455 68 import com.sun.source.doctree.TextTree;
jjg@1455 69 import com.sun.source.doctree.ThrowsTree;
jjg@1650 70 import com.sun.source.doctree.ValueTree;
jjg@1455 71 import com.sun.source.doctree.VersionTree;
jlahoda@1726 72 import com.sun.source.util.DocTreePath;
jlahoda@1726 73 import com.sun.source.util.DocTreePathScanner;
jjg@1455 74 import com.sun.source.util.TreePath;
jjg@1455 75 import com.sun.tools.doclint.HtmlTag.AttrKind;
jjg@1650 76 import com.sun.tools.javac.tree.DocPretty;
jjg@1455 77 import static com.sun.tools.doclint.Messages.Group.*;
jjg@1455 78
jjg@1455 79
jjg@1455 80 /**
jjg@1455 81 * Validate a doc comment.
jjg@1455 82 *
jjg@1455 83 * <p><b>This is NOT part of any supported API.
jjg@1455 84 * If you write code that depends on this, you do so at your own
jjg@1455 85 * risk. This code and its internal interfaces are subject to change
jjg@1455 86 * or deletion without notice.</b></p>
jjg@1455 87 */
jlahoda@1726 88 public class Checker extends DocTreePathScanner<Void, Void> {
jjg@1455 89 final Env env;
jjg@1455 90
jjg@1455 91 Set<Element> foundParams = new HashSet<Element>();
jjg@1455 92 Set<TypeMirror> foundThrows = new HashSet<TypeMirror>();
jjg@1455 93 Set<String> foundAnchors = new HashSet<String>();
jjg@1455 94 boolean foundInheritDoc = false;
jjg@1455 95 boolean foundReturn = false;
jjg@1455 96
jjg@1506 97 public enum Flag {
jjg@1455 98 TABLE_HAS_CAPTION,
jjg@1455 99 HAS_ELEMENT,
jjg@1650 100 HAS_INLINE_TAG,
jjg@1507 101 HAS_TEXT,
jjg@1507 102 REPORTED_BAD_INLINE
jjg@1455 103 }
jjg@1455 104
jjg@1455 105 static class TagStackItem {
jjg@1455 106 final DocTree tree; // typically, but not always, StartElementTree
jjg@1455 107 final HtmlTag tag;
jjg@1455 108 final Set<HtmlTag.Attr> attrs;
jjg@1455 109 final Set<Flag> flags;
jjg@1455 110 TagStackItem(DocTree tree, HtmlTag tag) {
jjg@1455 111 this.tree = tree;
jjg@1455 112 this.tag = tag;
jjg@1455 113 attrs = EnumSet.noneOf(HtmlTag.Attr.class);
jjg@1455 114 flags = EnumSet.noneOf(Flag.class);
jjg@1455 115 }
jjg@1455 116 @Override
jjg@1455 117 public String toString() {
jjg@1455 118 return String.valueOf(tag);
jjg@1455 119 }
jjg@1455 120 }
jjg@1455 121
jjg@1455 122 private Deque<TagStackItem> tagStack; // TODO: maybe want to record starting tree as well
jjg@1455 123 private HtmlTag currHeaderTag;
jjg@1455 124
jjg@1668 125 private final int implicitHeaderLevel;
jjg@1668 126
jjg@1455 127 // <editor-fold defaultstate="collapsed" desc="Top level">
jjg@1455 128
jjg@1455 129 Checker(Env env) {
jjg@1455 130 env.getClass();
jjg@1455 131 this.env = env;
jjg@1455 132 tagStack = new LinkedList<TagStackItem>();
jjg@1668 133 implicitHeaderLevel = env.implicitHeaderLevel;
jjg@1455 134 }
jjg@1455 135
jjg@1455 136 public Void scan(DocCommentTree tree, TreePath p) {
jjg@1455 137 env.setCurrent(p, tree);
jjg@1455 138
jjg@1455 139 boolean isOverridingMethod = !env.currOverriddenMethods.isEmpty();
jjg@1455 140
jjg@1455 141 if (tree == null) {
jjg@1455 142 if (!isSynthetic() && !isOverridingMethod)
jjg@1455 143 reportMissing("dc.missing.comment");
jjg@1455 144 return null;
jjg@1455 145 }
jjg@1455 146
jjg@1455 147 tagStack.clear();
jjg@1455 148 currHeaderTag = null;
jjg@1455 149
jjg@1455 150 foundParams.clear();
jjg@1455 151 foundThrows.clear();
jjg@1455 152 foundInheritDoc = false;
jjg@1455 153 foundReturn = false;
jjg@1455 154
jlahoda@1726 155 scan(new DocTreePath(p, tree), null);
jjg@1455 156
jjg@1455 157 if (!isOverridingMethod) {
jjg@1455 158 switch (env.currElement.getKind()) {
jjg@1455 159 case METHOD:
jjg@1455 160 case CONSTRUCTOR: {
jjg@1455 161 ExecutableElement ee = (ExecutableElement) env.currElement;
jjg@1455 162 checkParamsDocumented(ee.getTypeParameters());
jjg@1455 163 checkParamsDocumented(ee.getParameters());
jjg@1455 164 switch (ee.getReturnType().getKind()) {
jjg@1455 165 case VOID:
jjg@1455 166 case NONE:
jjg@1455 167 break;
jjg@1455 168 default:
jjg@1455 169 if (!foundReturn
jjg@1455 170 && !foundInheritDoc
jjg@1455 171 && !env.types.isSameType(ee.getReturnType(), env.java_lang_Void)) {
jjg@1455 172 reportMissing("dc.missing.return");
jjg@1455 173 }
jjg@1455 174 }
jjg@1455 175 checkThrowsDocumented(ee.getThrownTypes());
jjg@1455 176 }
jjg@1455 177 }
jjg@1455 178 }
jjg@1455 179
jjg@1455 180 return null;
jjg@1455 181 }
jjg@1455 182
jjg@1455 183 private void reportMissing(String code, Object... args) {
jjg@1455 184 env.messages.report(MISSING, Kind.WARNING, env.currPath.getLeaf(), code, args);
jjg@1455 185 }
jjg@1455 186
jjg@1455 187 @Override
jjg@1455 188 public Void visitDocComment(DocCommentTree tree, Void ignore) {
jjg@1455 189 super.visitDocComment(tree, ignore);
jjg@1455 190 for (TagStackItem tsi: tagStack) {
jjg@1455 191 if (tsi.tree.getKind() == DocTree.Kind.START_ELEMENT
jjg@1455 192 && tsi.tag.endKind == HtmlTag.EndKind.REQUIRED) {
jjg@1455 193 StartElementTree t = (StartElementTree) tsi.tree;
jjg@1455 194 env.messages.error(HTML, t, "dc.tag.not.closed", t.getName());
jjg@1455 195 }
jjg@1455 196 }
jjg@1455 197 return null;
jjg@1455 198 }
jjg@1455 199 // </editor-fold>
jjg@1455 200
jjg@1455 201 // <editor-fold defaultstate="collapsed" desc="Text and entities.">
jjg@1455 202
jjg@1455 203 @Override
jjg@1455 204 public Void visitText(TextTree tree, Void ignore) {
jjg@1507 205 if (hasNonWhitespace(tree)) {
jjg@1507 206 checkAllowsText(tree);
jjg@1455 207 markEnclosingTag(Flag.HAS_TEXT);
jjg@1455 208 }
jjg@1455 209 return null;
jjg@1455 210 }
jjg@1455 211
jjg@1455 212 @Override
jjg@1455 213 public Void visitEntity(EntityTree tree, Void ignore) {
jjg@1507 214 checkAllowsText(tree);
jjg@1455 215 markEnclosingTag(Flag.HAS_TEXT);
jjg@1455 216 String name = tree.getName().toString();
jjg@1455 217 if (name.startsWith("#")) {
jjg@1455 218 int v = name.toLowerCase().startsWith("#x")
jjg@1455 219 ? Integer.parseInt(name.substring(2), 16)
jjg@1455 220 : Integer.parseInt(name.substring(1), 10);
jjg@1455 221 if (!Entity.isValid(v)) {
jjg@1455 222 env.messages.error(HTML, tree, "dc.entity.invalid", name);
jjg@1455 223 }
jjg@1455 224 } else if (!Entity.isValid(name)) {
jjg@1455 225 env.messages.error(HTML, tree, "dc.entity.invalid", name);
jjg@1455 226 }
jjg@1455 227 return null;
jjg@1455 228 }
jjg@1455 229
jjg@1507 230 void checkAllowsText(DocTree tree) {
jjg@1507 231 TagStackItem top = tagStack.peek();
jjg@1507 232 if (top != null
jjg@1507 233 && top.tree.getKind() == DocTree.Kind.START_ELEMENT
jjg@1507 234 && !top.tag.acceptsText()) {
jjg@1507 235 if (top.flags.add(Flag.REPORTED_BAD_INLINE)) {
jjg@1507 236 env.messages.error(HTML, tree, "dc.text.not.allowed",
jjg@1507 237 ((StartElementTree) top.tree).getName());
jjg@1507 238 }
jjg@1507 239 }
jjg@1507 240 }
jjg@1507 241
jjg@1455 242 // </editor-fold>
jjg@1455 243
jjg@1455 244 // <editor-fold defaultstate="collapsed" desc="HTML elements">
jjg@1455 245
jjg@1455 246 @Override
jjg@1455 247 public Void visitStartElement(StartElementTree tree, Void ignore) {
jjg@1455 248 markEnclosingTag(Flag.HAS_ELEMENT);
jjg@1455 249 final Name treeName = tree.getName();
jjg@1455 250 final HtmlTag t = HtmlTag.get(treeName);
jjg@1455 251 if (t == null) {
jjg@1455 252 env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
jjg@1455 253 } else {
jjg@1552 254 boolean done = false;
jjg@1507 255 for (TagStackItem tsi: tagStack) {
jjg@1507 256 if (tsi.tag.accepts(t)) {
jjg@1507 257 while (tagStack.peek() != tsi) tagStack.pop();
jjg@1552 258 done = true;
jjg@1507 259 break;
jjg@1552 260 } else if (tsi.tag.endKind != HtmlTag.EndKind.OPTIONAL) {
jjg@1552 261 done = true;
jjg@1507 262 break;
jjg@1552 263 }
jjg@1552 264 }
jjg@1552 265 if (!done && HtmlTag.BODY.accepts(t)) {
jjg@1552 266 tagStack.clear();
jjg@1507 267 }
jjg@1507 268
jjg@1507 269 checkStructure(tree, t);
jjg@1507 270
jjg@1455 271 // tag specific checks
jjg@1455 272 switch (t) {
jjg@1455 273 // check for out of sequence headers, such as <h1>...</h1> <h3>...</h3>
jjg@1455 274 case H1: case H2: case H3: case H4: case H5: case H6:
jjg@1455 275 checkHeader(tree, t);
jjg@1455 276 break;
jjg@1455 277 }
jjg@1455 278
jjg@1455 279 if (t.flags.contains(HtmlTag.Flag.NO_NEST)) {
jjg@1455 280 for (TagStackItem i: tagStack) {
jjg@1455 281 if (t == i.tag) {
jjg@1455 282 env.messages.warning(HTML, tree, "dc.tag.nested.not.allowed", treeName);
jjg@1455 283 break;
jjg@1455 284 }
jjg@1455 285 }
jjg@1455 286 }
jjg@1455 287 }
jjg@1455 288
jjg@1455 289 // check for self closing tags, such as <a id="name"/>
jjg@1455 290 if (tree.isSelfClosing()) {
jjg@1455 291 env.messages.error(HTML, tree, "dc.tag.self.closing", treeName);
jjg@1455 292 }
jjg@1455 293
jjg@1455 294 try {
jjg@1455 295 TagStackItem parent = tagStack.peek();
jjg@1455 296 TagStackItem top = new TagStackItem(tree, t);
jjg@1455 297 tagStack.push(top);
jjg@1455 298
jjg@1455 299 super.visitStartElement(tree, ignore);
jjg@1455 300
jjg@1455 301 // handle attributes that may or may not have been found in start element
jjg@1455 302 if (t != null) {
jjg@1455 303 switch (t) {
jjg@1455 304 case CAPTION:
jjg@1455 305 if (parent != null && parent.tag == HtmlTag.TABLE)
jjg@1455 306 parent.flags.add(Flag.TABLE_HAS_CAPTION);
jjg@1455 307 break;
jjg@1455 308
jjg@1455 309 case IMG:
jjg@1455 310 if (!top.attrs.contains(HtmlTag.Attr.ALT))
jjg@1455 311 env.messages.error(ACCESSIBILITY, tree, "dc.no.alt.attr.for.image");
jjg@1455 312 break;
jjg@1455 313 }
jjg@1455 314 }
jjg@1455 315
jjg@1455 316 return null;
jjg@1455 317 } finally {
jjg@1455 318
jjg@1455 319 if (t == null || t.endKind == HtmlTag.EndKind.NONE)
jjg@1455 320 tagStack.pop();
jjg@1455 321 }
jjg@1455 322 }
jjg@1455 323
jjg@1507 324 private void checkStructure(StartElementTree tree, HtmlTag t) {
jjg@1507 325 Name treeName = tree.getName();
jjg@1507 326 TagStackItem top = tagStack.peek();
jjg@1507 327 switch (t.blockType) {
jjg@1507 328 case BLOCK:
jjg@1507 329 if (top == null || top.tag.accepts(t))
jjg@1507 330 return;
jjg@1507 331
jjg@1507 332 switch (top.tree.getKind()) {
jjg@1507 333 case START_ELEMENT: {
jjg@1507 334 if (top.tag.blockType == HtmlTag.BlockType.INLINE) {
jjg@1507 335 Name name = ((StartElementTree) top.tree).getName();
jjg@1507 336 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.element",
jjg@1507 337 treeName, name);
jjg@1507 338 return;
jjg@1507 339 }
jjg@1507 340 }
jjg@1507 341 break;
jjg@1507 342
jjg@1507 343 case LINK:
jjg@1507 344 case LINK_PLAIN: {
jjg@1507 345 String name = top.tree.getKind().tagName;
jjg@1507 346 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.tag",
jjg@1507 347 treeName, name);
jjg@1507 348 return;
jjg@1507 349 }
jjg@1507 350 }
jjg@1507 351 break;
jjg@1507 352
jjg@1507 353 case INLINE:
jjg@1507 354 if (top == null || top.tag.accepts(t))
jjg@1507 355 return;
jjg@1507 356 break;
jjg@1507 357
jjg@1507 358 case LIST_ITEM:
jjg@1507 359 case TABLE_ITEM:
jjg@1507 360 if (top != null) {
jjg@1507 361 // reset this flag so subsequent bad inline content gets reported
jjg@1507 362 top.flags.remove(Flag.REPORTED_BAD_INLINE);
jjg@1507 363 if (top.tag.accepts(t))
jjg@1507 364 return;
jjg@1507 365 }
jjg@1507 366 break;
jjg@1507 367
jjg@1507 368 case OTHER:
jjg@1507 369 env.messages.error(HTML, tree, "dc.tag.not.allowed", treeName);
jjg@1507 370 return;
jjg@1507 371 }
jjg@1507 372
jjg@1507 373 env.messages.error(HTML, tree, "dc.tag.not.allowed.here", treeName);
jjg@1507 374 }
jjg@1507 375
jjg@1455 376 private void checkHeader(StartElementTree tree, HtmlTag tag) {
jjg@1455 377 // verify the new tag
jjg@1455 378 if (getHeaderLevel(tag) > getHeaderLevel(currHeaderTag) + 1) {
jjg@1455 379 if (currHeaderTag == null) {
jjg@1455 380 env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.1", tag);
jjg@1455 381 } else {
jjg@1455 382 env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.2",
jjg@1455 383 tag, currHeaderTag);
jjg@1455 384 }
jjg@1455 385 }
jjg@1455 386
jjg@1455 387 currHeaderTag = tag;
jjg@1455 388 }
jjg@1455 389
jjg@1455 390 private int getHeaderLevel(HtmlTag tag) {
jjg@1455 391 if (tag == null)
jjg@1668 392 return implicitHeaderLevel;
jjg@1455 393 switch (tag) {
jjg@1455 394 case H1: return 1;
jjg@1455 395 case H2: return 2;
jjg@1455 396 case H3: return 3;
jjg@1455 397 case H4: return 4;
jjg@1455 398 case H5: return 5;
jjg@1455 399 case H6: return 6;
jjg@1455 400 default: throw new IllegalArgumentException();
jjg@1455 401 }
jjg@1455 402 }
jjg@1455 403
jjg@1455 404 @Override
jjg@1455 405 public Void visitEndElement(EndElementTree tree, Void ignore) {
jjg@1455 406 final Name treeName = tree.getName();
jjg@1455 407 final HtmlTag t = HtmlTag.get(treeName);
jjg@1455 408 if (t == null) {
jjg@1455 409 env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
jjg@1455 410 } else if (t.endKind == HtmlTag.EndKind.NONE) {
jjg@1455 411 env.messages.error(HTML, tree, "dc.tag.end.not.permitted", treeName);
jjg@1455 412 } else {
jjg@1499 413 boolean done = false;
jjg@1455 414 while (!tagStack.isEmpty()) {
jjg@1455 415 TagStackItem top = tagStack.peek();
jjg@1455 416 if (t == top.tag) {
jjg@1455 417 switch (t) {
jjg@1455 418 case TABLE:
jjg@1455 419 if (!top.attrs.contains(HtmlTag.Attr.SUMMARY)
jjg@1455 420 && !top.flags.contains(Flag.TABLE_HAS_CAPTION)) {
jjg@1455 421 env.messages.error(ACCESSIBILITY, tree,
jjg@1455 422 "dc.no.summary.or.caption.for.table");
jjg@1455 423 }
jjg@1455 424 }
jjg@1455 425 if (t.flags.contains(HtmlTag.Flag.EXPECT_CONTENT)
jjg@1455 426 && !top.flags.contains(Flag.HAS_TEXT)
jjg@1650 427 && !top.flags.contains(Flag.HAS_ELEMENT)
jjg@1650 428 && !top.flags.contains(Flag.HAS_INLINE_TAG)) {
jjg@1455 429 env.messages.warning(HTML, tree, "dc.tag.empty", treeName);
jjg@1455 430 }
jjg@1455 431 tagStack.pop();
jjg@1499 432 done = true;
jjg@1455 433 break;
jjg@1455 434 } else if (top.tag == null || top.tag.endKind != HtmlTag.EndKind.REQUIRED) {
jjg@1455 435 tagStack.pop();
jjg@1455 436 } else {
jjg@1455 437 boolean found = false;
jjg@1455 438 for (TagStackItem si: tagStack) {
jjg@1455 439 if (si.tag == t) {
jjg@1455 440 found = true;
jjg@1455 441 break;
jjg@1455 442 }
jjg@1455 443 }
jjg@1455 444 if (found && top.tree.getKind() == DocTree.Kind.START_ELEMENT) {
jjg@1455 445 env.messages.error(HTML, top.tree, "dc.tag.start.unmatched",
jjg@1455 446 ((StartElementTree) top.tree).getName());
jjg@1455 447 tagStack.pop();
jjg@1455 448 } else {
jjg@1455 449 env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
jjg@1499 450 done = true;
jjg@1455 451 break;
jjg@1455 452 }
jjg@1455 453 }
jjg@1455 454 }
jjg@1499 455
jjg@1499 456 if (!done && tagStack.isEmpty()) {
jjg@1499 457 env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
jjg@1499 458 }
jjg@1455 459 }
jjg@1455 460
jjg@1455 461 return super.visitEndElement(tree, ignore);
jjg@1455 462 }
jjg@1455 463 // </editor-fold>
jjg@1455 464
jjg@1455 465 // <editor-fold defaultstate="collapsed" desc="HTML attributes">
jjg@1455 466
jjg@1455 467 @Override @SuppressWarnings("fallthrough")
jjg@1455 468 public Void visitAttribute(AttributeTree tree, Void ignore) {
jjg@1455 469 HtmlTag currTag = tagStack.peek().tag;
jjg@1455 470 if (currTag != null) {
jjg@1455 471 Name name = tree.getName();
jjg@1455 472 HtmlTag.Attr attr = currTag.getAttr(name);
jjg@1455 473 if (attr != null) {
jjg@1455 474 boolean first = tagStack.peek().attrs.add(attr);
jjg@1455 475 if (!first)
jjg@1455 476 env.messages.error(HTML, tree, "dc.attr.repeated", name);
jjg@1455 477 }
jjg@1455 478 AttrKind k = currTag.getAttrKind(name);
jjg@1455 479 switch (k) {
jjg@1455 480 case OK:
jjg@1455 481 break;
jjg@1455 482
jjg@1455 483 case INVALID:
jjg@1455 484 env.messages.error(HTML, tree, "dc.attr.unknown", name);
jjg@1455 485 break;
jjg@1455 486
jjg@1455 487 case OBSOLETE:
jjg@1455 488 env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete", name);
jjg@1455 489 break;
jjg@1455 490
jjg@1455 491 case USE_CSS:
jjg@1455 492 env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete.use.css", name);
jjg@1455 493 break;
jjg@1455 494 }
jjg@1455 495
jjg@1455 496 if (attr != null) {
jjg@1455 497 switch (attr) {
jjg@1455 498 case NAME:
jjg@1455 499 if (currTag != HtmlTag.A) {
jjg@1455 500 break;
jjg@1455 501 }
jjg@1495 502 // fallthrough
jjg@1455 503 case ID:
jjg@1455 504 String value = getAttrValue(tree);
jjg@1495 505 if (value == null) {
jjg@1495 506 env.messages.error(HTML, tree, "dc.anchor.value.missing");
jjg@1495 507 } else {
jjg@1495 508 if (!validName.matcher(value).matches()) {
jjg@1495 509 env.messages.error(HTML, tree, "dc.invalid.anchor", value);
jjg@1495 510 }
jjg@1495 511 if (!foundAnchors.add(value)) {
jjg@1495 512 env.messages.error(HTML, tree, "dc.anchor.already.defined", value);
jjg@1495 513 }
jjg@1455 514 }
jjg@1455 515 break;
jjg@1455 516
jjg@1455 517 case HREF:
jjg@1455 518 if (currTag == HtmlTag.A) {
jjg@1455 519 String v = getAttrValue(tree);
jjg@1455 520 if (v == null || v.isEmpty()) {
jjg@1455 521 env.messages.error(HTML, tree, "dc.attr.lacks.value");
jjg@1455 522 } else {
jjg@1455 523 Matcher m = docRoot.matcher(v);
jjg@1455 524 if (m.matches()) {
jjg@1455 525 String rest = m.group(2);
jjg@1455 526 if (!rest.isEmpty())
jjg@1455 527 checkURI(tree, rest);
jjg@1455 528 } else {
jjg@1455 529 checkURI(tree, v);
jjg@1455 530 }
jjg@1455 531 }
jjg@1455 532 }
jjg@1455 533 break;
jjg@1793 534
jjg@1793 535 case VALUE:
jjg@1793 536 if (currTag == HtmlTag.LI) {
jjg@1793 537 String v = getAttrValue(tree);
jjg@1793 538 if (v == null || v.isEmpty()) {
jjg@1793 539 env.messages.error(HTML, tree, "dc.attr.lacks.value");
jjg@1793 540 } else if (!validNumber.matcher(v).matches()) {
jjg@1793 541 env.messages.error(HTML, tree, "dc.attr.not.number");
jjg@1793 542 }
jjg@1793 543 }
jjg@1793 544 break;
jjg@1455 545 }
jjg@1455 546 }
jjg@1455 547 }
jjg@1455 548
jjg@1455 549 // TODO: basic check on value
jjg@1455 550
jjg@1455 551 return super.visitAttribute(tree, ignore);
jjg@1455 552 }
jjg@1455 553
jjg@1455 554 // http://www.w3.org/TR/html401/types.html#type-name
jjg@1455 555 private static final Pattern validName = Pattern.compile("[A-Za-z][A-Za-z0-9-_:.]*");
jjg@1455 556
jjg@1793 557 private static final Pattern validNumber = Pattern.compile("-?[0-9]+");
jjg@1793 558
jjg@1455 559 // pattern to remove leading {@docRoot}/?
jjg@1455 560 private static final Pattern docRoot = Pattern.compile("(?i)(\\{@docRoot *\\}/?)?(.*)");
jjg@1455 561
jjg@1455 562 private String getAttrValue(AttributeTree tree) {
jjg@1455 563 if (tree.getValue() == null)
jjg@1455 564 return null;
jjg@1455 565
jjg@1455 566 StringWriter sw = new StringWriter();
jjg@1455 567 try {
jjg@1455 568 new DocPretty(sw).print(tree.getValue());
jjg@1455 569 } catch (IOException e) {
jjg@1455 570 // cannot happen
jjg@1455 571 }
jjg@1455 572 // ignore potential use of entities for now
jjg@1455 573 return sw.toString();
jjg@1455 574 }
jjg@1455 575
jjg@1455 576 private void checkURI(AttributeTree tree, String uri) {
jjg@1455 577 try {
jjg@1455 578 URI u = new URI(uri);
jjg@1455 579 } catch (URISyntaxException e) {
jjg@1455 580 env.messages.error(HTML, tree, "dc.invalid.uri", uri);
jjg@1455 581 }
jjg@1455 582 }
jjg@1455 583 // </editor-fold>
jjg@1455 584
jjg@1455 585 // <editor-fold defaultstate="collapsed" desc="javadoc tags">
jjg@1455 586
jjg@1455 587 @Override
jjg@1455 588 public Void visitAuthor(AuthorTree tree, Void ignore) {
jjg@1455 589 warnIfEmpty(tree, tree.getName());
jjg@1455 590 return super.visitAuthor(tree, ignore);
jjg@1455 591 }
jjg@1455 592
jjg@1455 593 @Override
jjg@1650 594 public Void visitDocRoot(DocRootTree tree, Void ignore) {
jjg@1650 595 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1650 596 return super.visitDocRoot(tree, ignore);
jjg@1650 597 }
jjg@1650 598
jjg@1650 599 @Override
jjg@1455 600 public Void visitInheritDoc(InheritDocTree tree, Void ignore) {
jjg@1650 601 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1455 602 // TODO: verify on overridden method
jjg@1455 603 foundInheritDoc = true;
jjg@1455 604 return super.visitInheritDoc(tree, ignore);
jjg@1455 605 }
jjg@1455 606
jjg@1455 607 @Override
jjg@1455 608 public Void visitLink(LinkTree tree, Void ignore) {
jjg@1650 609 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1455 610 // simulate inline context on tag stack
jjg@1455 611 HtmlTag t = (tree.getKind() == DocTree.Kind.LINK)
jjg@1455 612 ? HtmlTag.CODE : HtmlTag.SPAN;
jjg@1455 613 tagStack.push(new TagStackItem(tree, t));
jjg@1455 614 try {
jjg@1455 615 return super.visitLink(tree, ignore);
jjg@1455 616 } finally {
jjg@1455 617 tagStack.pop();
jjg@1455 618 }
jjg@1455 619 }
jjg@1455 620
jjg@1455 621 @Override
jjg@1499 622 public Void visitLiteral(LiteralTree tree, Void ignore) {
jjg@1650 623 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1499 624 if (tree.getKind() == DocTree.Kind.CODE) {
jjg@1499 625 for (TagStackItem tsi: tagStack) {
jjg@1499 626 if (tsi.tag == HtmlTag.CODE) {
jjg@1502 627 env.messages.warning(HTML, tree, "dc.tag.code.within.code");
jjg@1499 628 break;
jjg@1499 629 }
jjg@1499 630 }
jjg@1499 631 }
jjg@1499 632 return super.visitLiteral(tree, ignore);
jjg@1499 633 }
jjg@1499 634
jjg@1499 635 @Override
jlahoda@1726 636 @SuppressWarnings("fallthrough")
jjg@1455 637 public Void visitParam(ParamTree tree, Void ignore) {
jjg@1455 638 boolean typaram = tree.isTypeParameter();
jjg@1455 639 IdentifierTree nameTree = tree.getName();
jlahoda@1726 640 Element paramElement = nameTree != null ? env.trees.getElement(new DocTreePath(getCurrentPath(), nameTree)) : null;
jlahoda@1726 641
jlahoda@1726 642 if (paramElement == null) {
jlahoda@1726 643 switch (env.currElement.getKind()) {
jlahoda@1726 644 case CLASS: case INTERFACE: {
jlahoda@1726 645 if (!typaram) {
jlahoda@1726 646 env.messages.error(REFERENCE, tree, "dc.invalid.param");
jlahoda@1726 647 break;
jlahoda@1726 648 }
jlahoda@1726 649 }
jlahoda@1726 650 case METHOD: case CONSTRUCTOR: {
jlahoda@1726 651 env.messages.error(REFERENCE, nameTree, "dc.param.name.not.found");
jlahoda@1726 652 break;
jlahoda@1726 653 }
jlahoda@1726 654
jlahoda@1726 655 default:
jlahoda@1726 656 env.messages.error(REFERENCE, tree, "dc.invalid.param");
jlahoda@1726 657 break;
jjg@1455 658 }
jlahoda@1726 659 } else {
jlahoda@1726 660 foundParams.add(paramElement);
jlahoda@1726 661 }
jjg@1455 662
jjg@1455 663 warnIfEmpty(tree, tree.getDescription());
jjg@1455 664 return super.visitParam(tree, ignore);
jjg@1455 665 }
jjg@1455 666
jjg@1455 667 private void checkParamsDocumented(List<? extends Element> list) {
jjg@1455 668 if (foundInheritDoc)
jjg@1455 669 return;
jjg@1455 670
jjg@1455 671 for (Element e: list) {
jjg@1455 672 if (!foundParams.contains(e)) {
jjg@1455 673 CharSequence paramName = (e.getKind() == ElementKind.TYPE_PARAMETER)
jjg@1455 674 ? "<" + e.getSimpleName() + ">"
jjg@1455 675 : e.getSimpleName();
jjg@1455 676 reportMissing("dc.missing.param", paramName);
jjg@1455 677 }
jjg@1455 678 }
jjg@1455 679 }
jjg@1455 680
jjg@1455 681 @Override
jjg@1455 682 public Void visitReference(ReferenceTree tree, Void ignore) {
jlahoda@1726 683 Element e = env.trees.getElement(getCurrentPath());
jjg@1455 684 if (e == null)
jjg@1455 685 env.messages.error(REFERENCE, tree, "dc.ref.not.found");
jjg@1455 686 return super.visitReference(tree, ignore);
jjg@1455 687 }
jjg@1455 688
jjg@1455 689 @Override
jjg@1455 690 public Void visitReturn(ReturnTree tree, Void ignore) {
jjg@1455 691 Element e = env.trees.getElement(env.currPath);
jjg@1455 692 if (e.getKind() != ElementKind.METHOD
jjg@1455 693 || ((ExecutableElement) e).getReturnType().getKind() == TypeKind.VOID)
jjg@1455 694 env.messages.error(REFERENCE, tree, "dc.invalid.return");
jjg@1455 695 foundReturn = true;
jjg@1455 696 warnIfEmpty(tree, tree.getDescription());
jjg@1455 697 return super.visitReturn(tree, ignore);
jjg@1455 698 }
jjg@1455 699
jjg@1455 700 @Override
jjg@1455 701 public Void visitSerialData(SerialDataTree tree, Void ignore) {
jjg@1455 702 warnIfEmpty(tree, tree.getDescription());
jjg@1455 703 return super.visitSerialData(tree, ignore);
jjg@1455 704 }
jjg@1455 705
jjg@1455 706 @Override
jjg@1455 707 public Void visitSerialField(SerialFieldTree tree, Void ignore) {
jjg@1455 708 warnIfEmpty(tree, tree.getDescription());
jjg@1455 709 return super.visitSerialField(tree, ignore);
jjg@1455 710 }
jjg@1455 711
jjg@1455 712 @Override
jjg@1455 713 public Void visitSince(SinceTree tree, Void ignore) {
jjg@1455 714 warnIfEmpty(tree, tree.getBody());
jjg@1455 715 return super.visitSince(tree, ignore);
jjg@1455 716 }
jjg@1455 717
jjg@1455 718 @Override
jjg@1455 719 public Void visitThrows(ThrowsTree tree, Void ignore) {
jjg@1455 720 ReferenceTree exName = tree.getExceptionName();
jlahoda@1726 721 Element ex = env.trees.getElement(new DocTreePath(getCurrentPath(), exName));
jjg@1455 722 if (ex == null) {
jjg@1455 723 env.messages.error(REFERENCE, tree, "dc.ref.not.found");
jjg@1455 724 } else if (ex.asType().getKind() == TypeKind.DECLARED
jjg@1455 725 && env.types.isAssignable(ex.asType(), env.java_lang_Throwable)) {
jjg@1455 726 switch (env.currElement.getKind()) {
jjg@1455 727 case CONSTRUCTOR:
jjg@1455 728 case METHOD:
jjg@1455 729 if (isCheckedException(ex.asType())) {
jjg@1455 730 ExecutableElement ee = (ExecutableElement) env.currElement;
jjg@1455 731 checkThrowsDeclared(exName, ex.asType(), ee.getThrownTypes());
jjg@1455 732 }
jjg@1455 733 break;
jjg@1455 734 default:
jjg@1455 735 env.messages.error(REFERENCE, tree, "dc.invalid.throws");
jjg@1455 736 }
jjg@1455 737 } else {
jjg@1455 738 env.messages.error(REFERENCE, tree, "dc.invalid.throws");
jjg@1455 739 }
jjg@1455 740 warnIfEmpty(tree, tree.getDescription());
jjg@1455 741 return scan(tree.getDescription(), ignore);
jjg@1455 742 }
jjg@1455 743
jjg@1455 744 private void checkThrowsDeclared(ReferenceTree tree, TypeMirror t, List<? extends TypeMirror> list) {
jjg@1455 745 boolean found = false;
jjg@1455 746 for (TypeMirror tl : list) {
jjg@1455 747 if (env.types.isAssignable(t, tl)) {
jjg@1455 748 foundThrows.add(tl);
jjg@1455 749 found = true;
jjg@1455 750 }
jjg@1455 751 }
jjg@1455 752 if (!found)
jjg@1455 753 env.messages.error(REFERENCE, tree, "dc.exception.not.thrown", t);
jjg@1455 754 }
jjg@1455 755
jjg@1455 756 private void checkThrowsDocumented(List<? extends TypeMirror> list) {
jjg@1455 757 if (foundInheritDoc)
jjg@1455 758 return;
jjg@1455 759
jjg@1455 760 for (TypeMirror tl: list) {
jjg@1455 761 if (isCheckedException(tl) && !foundThrows.contains(tl))
jjg@1455 762 reportMissing("dc.missing.throws", tl);
jjg@1455 763 }
jjg@1455 764 }
jjg@1455 765
jjg@1455 766 @Override
jjg@1650 767 public Void visitValue(ValueTree tree, Void ignore) {
jjg@1650 768 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1650 769 return super.visitValue(tree, ignore);
jjg@1650 770 }
jjg@1650 771
jjg@1650 772 @Override
jjg@1455 773 public Void visitVersion(VersionTree tree, Void ignore) {
jjg@1455 774 warnIfEmpty(tree, tree.getBody());
jjg@1455 775 return super.visitVersion(tree, ignore);
jjg@1455 776 }
jjg@1455 777
jjg@1455 778 @Override
jjg@1455 779 public Void visitErroneous(ErroneousTree tree, Void ignore) {
jjg@1455 780 env.messages.error(SYNTAX, tree, null, tree.getDiagnostic().getMessage(null));
jjg@1455 781 return null;
jjg@1455 782 }
jjg@1455 783 // </editor-fold>
jjg@1455 784
jjg@1455 785 // <editor-fold defaultstate="collapsed" desc="Utility methods">
jjg@1455 786
jjg@1455 787 private boolean isCheckedException(TypeMirror t) {
jjg@1455 788 return !(env.types.isAssignable(t, env.java_lang_Error)
jjg@1455 789 || env.types.isAssignable(t, env.java_lang_RuntimeException));
jjg@1455 790 }
jjg@1455 791
jjg@1455 792 private boolean isSynthetic() {
jjg@1455 793 switch (env.currElement.getKind()) {
jjg@1455 794 case CONSTRUCTOR:
jjg@1455 795 // A synthetic default constructor has the same pos as the
jjg@1455 796 // enclosing class
jjg@1455 797 TreePath p = env.currPath;
jjg@1455 798 return env.getPos(p) == env.getPos(p.getParentPath());
jjg@1455 799 }
jjg@1455 800 return false;
jjg@1455 801 }
jjg@1455 802
jjg@1455 803 void markEnclosingTag(Flag flag) {
jjg@1455 804 TagStackItem top = tagStack.peek();
jjg@1455 805 if (top != null)
jjg@1455 806 top.flags.add(flag);
jjg@1455 807 }
jjg@1455 808
jjg@1455 809 String toString(TreePath p) {
jjg@1455 810 StringBuilder sb = new StringBuilder("TreePath[");
jjg@1455 811 toString(p, sb);
jjg@1455 812 sb.append("]");
jjg@1455 813 return sb.toString();
jjg@1455 814 }
jjg@1455 815
jjg@1455 816 void toString(TreePath p, StringBuilder sb) {
jjg@1455 817 TreePath parent = p.getParentPath();
jjg@1455 818 if (parent != null) {
jjg@1455 819 toString(parent, sb);
jjg@1455 820 sb.append(",");
jjg@1455 821 }
jjg@1455 822 sb.append(p.getLeaf().getKind()).append(":").append(env.getPos(p)).append(":S").append(env.getStartPos(p));
jjg@1455 823 }
jjg@1455 824
jjg@1455 825 void warnIfEmpty(DocTree tree, List<? extends DocTree> list) {
jjg@1455 826 for (DocTree d: list) {
jjg@1455 827 switch (d.getKind()) {
jjg@1455 828 case TEXT:
jjg@1507 829 if (hasNonWhitespace((TextTree) d))
jjg@1455 830 return;
jjg@1455 831 break;
jjg@1455 832 default:
jjg@1455 833 return;
jjg@1455 834 }
jjg@1455 835 }
jjg@1455 836 env.messages.warning(SYNTAX, tree, "dc.empty", tree.getKind().tagName);
jjg@1455 837 }
jjg@1507 838
jjg@1507 839 boolean hasNonWhitespace(TextTree tree) {
jjg@1507 840 String s = tree.getBody();
jjg@1507 841 for (int i = 0; i < s.length(); i++) {
jjg@1507 842 if (!Character.isWhitespace(s.charAt(i)))
jjg@1507 843 return true;
jjg@1507 844 }
jjg@1507 845 return false;
jjg@1507 846 }
jjg@1507 847
jjg@1455 848 // </editor-fold>
jjg@1455 849
jjg@1455 850 }

mercurial