src/share/classes/com/sun/tools/doclint/Checker.java

Mon, 21 Jan 2013 10:07:37 -0800

author
jjg
date
Mon, 21 Jan 2013 10:07:37 -0800
changeset 1507
967052c425a1
parent 1506
4a3cfc970c6f
child 1552
153d20d0cac5
permissions
-rw-r--r--

8006251: doclint: incorrect position for diagnostic for illegal text in tags
Reviewed-by: mcimadamore

jjg@1455 1 /*
jjg@1495 2 * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
jjg@1455 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
jjg@1455 4 *
jjg@1455 5 * This code is free software; you can redistribute it and/or modify it
jjg@1455 6 * under the terms of the GNU General Public License version 2 only, as
jjg@1455 7 * published by the Free Software Foundation. Oracle designates this
jjg@1455 8 * particular file as subject to the "Classpath" exception as provided
jjg@1455 9 * by Oracle in the LICENSE file that accompanied this code.
jjg@1455 10 *
jjg@1455 11 * This code is distributed in the hope that it will be useful, but WITHOUT
jjg@1455 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
jjg@1455 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
jjg@1455 14 * version 2 for more details (a copy is included in the LICENSE file that
jjg@1455 15 * accompanied this code).
jjg@1455 16 *
jjg@1455 17 * You should have received a copy of the GNU General Public License version
jjg@1455 18 * 2 along with this work; if not, write to the Free Software Foundation,
jjg@1455 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
jjg@1455 20 *
jjg@1455 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
jjg@1455 22 * or visit www.oracle.com if you need additional information or have any
jjg@1455 23 * questions.
jjg@1455 24 */
jjg@1455 25
jjg@1455 26 package com.sun.tools.doclint;
jjg@1455 27
jjg@1499 28 import com.sun.source.doctree.LiteralTree;
jjg@1455 29 import java.util.regex.Matcher;
jjg@1455 30 import com.sun.source.doctree.LinkTree;
jjg@1455 31 import java.net.URI;
jjg@1455 32 import java.util.regex.Pattern;
jjg@1455 33 import java.io.IOException;
jjg@1455 34 import com.sun.tools.javac.tree.DocPretty;
jjg@1455 35 import java.io.StringWriter;
jjg@1455 36 import java.util.Deque;
jjg@1455 37 import java.util.EnumSet;
jjg@1455 38 import java.util.HashSet;
jjg@1455 39 import java.util.LinkedList;
jjg@1455 40 import java.util.List;
jjg@1455 41 import java.util.Set;
jjg@1455 42
jjg@1455 43 import javax.lang.model.element.Element;
jjg@1455 44 import javax.lang.model.element.ElementKind;
jjg@1455 45 import javax.lang.model.element.ExecutableElement;
jjg@1455 46 import javax.lang.model.element.Name;
jjg@1455 47 import javax.lang.model.element.TypeElement;
jjg@1455 48 import javax.lang.model.type.TypeKind;
jjg@1455 49 import javax.lang.model.type.TypeMirror;
jjg@1455 50 import javax.tools.Diagnostic.Kind;
jjg@1455 51
jjg@1455 52 import com.sun.source.doctree.AttributeTree;
jjg@1455 53 import com.sun.source.doctree.AuthorTree;
jjg@1455 54 import com.sun.source.doctree.DocCommentTree;
jjg@1455 55 import com.sun.source.doctree.DocTree;
jjg@1455 56 import com.sun.source.doctree.EndElementTree;
jjg@1455 57 import com.sun.source.doctree.EntityTree;
jjg@1455 58 import com.sun.source.doctree.ErroneousTree;
jjg@1455 59 import com.sun.source.doctree.IdentifierTree;
jjg@1455 60 import com.sun.source.doctree.InheritDocTree;
jjg@1455 61 import com.sun.source.doctree.ParamTree;
jjg@1455 62 import com.sun.source.doctree.ReferenceTree;
jjg@1455 63 import com.sun.source.doctree.ReturnTree;
jjg@1455 64 import com.sun.source.doctree.SerialDataTree;
jjg@1455 65 import com.sun.source.doctree.SerialFieldTree;
jjg@1455 66 import com.sun.source.doctree.SinceTree;
jjg@1455 67 import com.sun.source.doctree.StartElementTree;
jjg@1455 68 import com.sun.source.doctree.TextTree;
jjg@1455 69 import com.sun.source.doctree.ThrowsTree;
jjg@1455 70 import com.sun.source.doctree.VersionTree;
jjg@1455 71 import com.sun.source.util.DocTreeScanner;
jjg@1455 72 import com.sun.source.util.TreePath;
jjg@1455 73 import com.sun.tools.doclint.HtmlTag.AttrKind;
jjg@1455 74 import java.net.URISyntaxException;
jjg@1455 75 import static com.sun.tools.doclint.Messages.Group.*;
jjg@1455 76
jjg@1455 77
jjg@1455 78 /**
jjg@1455 79 * Validate a doc comment.
jjg@1455 80 *
jjg@1455 81 * <p><b>This is NOT part of any supported API.
jjg@1455 82 * If you write code that depends on this, you do so at your own
jjg@1455 83 * risk. This code and its internal interfaces are subject to change
jjg@1455 84 * or deletion without notice.</b></p>
jjg@1455 85 */
jjg@1455 86 public class Checker extends DocTreeScanner<Void, Void> {
jjg@1455 87 final Env env;
jjg@1455 88
jjg@1455 89 Set<Element> foundParams = new HashSet<Element>();
jjg@1455 90 Set<TypeMirror> foundThrows = new HashSet<TypeMirror>();
jjg@1455 91 Set<String> foundAnchors = new HashSet<String>();
jjg@1455 92 boolean foundInheritDoc = false;
jjg@1455 93 boolean foundReturn = false;
jjg@1455 94
jjg@1506 95 public enum Flag {
jjg@1455 96 TABLE_HAS_CAPTION,
jjg@1455 97 HAS_ELEMENT,
jjg@1507 98 HAS_TEXT,
jjg@1507 99 REPORTED_BAD_INLINE
jjg@1455 100 }
jjg@1455 101
jjg@1455 102 static class TagStackItem {
jjg@1455 103 final DocTree tree; // typically, but not always, StartElementTree
jjg@1455 104 final HtmlTag tag;
jjg@1455 105 final Set<HtmlTag.Attr> attrs;
jjg@1455 106 final Set<Flag> flags;
jjg@1455 107 TagStackItem(DocTree tree, HtmlTag tag) {
jjg@1455 108 this.tree = tree;
jjg@1455 109 this.tag = tag;
jjg@1455 110 attrs = EnumSet.noneOf(HtmlTag.Attr.class);
jjg@1455 111 flags = EnumSet.noneOf(Flag.class);
jjg@1455 112 }
jjg@1455 113 @Override
jjg@1455 114 public String toString() {
jjg@1455 115 return String.valueOf(tag);
jjg@1455 116 }
jjg@1455 117 }
jjg@1455 118
jjg@1455 119 private Deque<TagStackItem> tagStack; // TODO: maybe want to record starting tree as well
jjg@1455 120 private HtmlTag currHeaderTag;
jjg@1455 121
jjg@1455 122 // <editor-fold defaultstate="collapsed" desc="Top level">
jjg@1455 123
jjg@1455 124 Checker(Env env) {
jjg@1455 125 env.getClass();
jjg@1455 126 this.env = env;
jjg@1455 127 tagStack = new LinkedList<TagStackItem>();
jjg@1455 128 }
jjg@1455 129
jjg@1455 130 public Void scan(DocCommentTree tree, TreePath p) {
jjg@1455 131 env.setCurrent(p, tree);
jjg@1455 132
jjg@1455 133 boolean isOverridingMethod = !env.currOverriddenMethods.isEmpty();
jjg@1455 134
jjg@1455 135 if (tree == null) {
jjg@1455 136 if (!isSynthetic() && !isOverridingMethod)
jjg@1455 137 reportMissing("dc.missing.comment");
jjg@1455 138 return null;
jjg@1455 139 }
jjg@1455 140
jjg@1455 141 tagStack.clear();
jjg@1455 142 currHeaderTag = null;
jjg@1455 143
jjg@1455 144 foundParams.clear();
jjg@1455 145 foundThrows.clear();
jjg@1455 146 foundInheritDoc = false;
jjg@1455 147 foundReturn = false;
jjg@1455 148
jjg@1455 149 scan(tree, (Void) null);
jjg@1455 150
jjg@1455 151 if (!isOverridingMethod) {
jjg@1455 152 switch (env.currElement.getKind()) {
jjg@1455 153 case METHOD:
jjg@1455 154 case CONSTRUCTOR: {
jjg@1455 155 ExecutableElement ee = (ExecutableElement) env.currElement;
jjg@1455 156 checkParamsDocumented(ee.getTypeParameters());
jjg@1455 157 checkParamsDocumented(ee.getParameters());
jjg@1455 158 switch (ee.getReturnType().getKind()) {
jjg@1455 159 case VOID:
jjg@1455 160 case NONE:
jjg@1455 161 break;
jjg@1455 162 default:
jjg@1455 163 if (!foundReturn
jjg@1455 164 && !foundInheritDoc
jjg@1455 165 && !env.types.isSameType(ee.getReturnType(), env.java_lang_Void)) {
jjg@1455 166 reportMissing("dc.missing.return");
jjg@1455 167 }
jjg@1455 168 }
jjg@1455 169 checkThrowsDocumented(ee.getThrownTypes());
jjg@1455 170 }
jjg@1455 171 }
jjg@1455 172 }
jjg@1455 173
jjg@1455 174 return null;
jjg@1455 175 }
jjg@1455 176
jjg@1455 177 private void reportMissing(String code, Object... args) {
jjg@1455 178 env.messages.report(MISSING, Kind.WARNING, env.currPath.getLeaf(), code, args);
jjg@1455 179 }
jjg@1455 180
jjg@1455 181 @Override
jjg@1455 182 public Void visitDocComment(DocCommentTree tree, Void ignore) {
jjg@1455 183 super.visitDocComment(tree, ignore);
jjg@1455 184 for (TagStackItem tsi: tagStack) {
jjg@1455 185 if (tsi.tree.getKind() == DocTree.Kind.START_ELEMENT
jjg@1455 186 && tsi.tag.endKind == HtmlTag.EndKind.REQUIRED) {
jjg@1455 187 StartElementTree t = (StartElementTree) tsi.tree;
jjg@1455 188 env.messages.error(HTML, t, "dc.tag.not.closed", t.getName());
jjg@1455 189 }
jjg@1455 190 }
jjg@1455 191 return null;
jjg@1455 192 }
jjg@1455 193 // </editor-fold>
jjg@1455 194
jjg@1455 195 // <editor-fold defaultstate="collapsed" desc="Text and entities.">
jjg@1455 196
jjg@1455 197 @Override
jjg@1455 198 public Void visitText(TextTree tree, Void ignore) {
jjg@1507 199 if (hasNonWhitespace(tree)) {
jjg@1507 200 checkAllowsText(tree);
jjg@1455 201 markEnclosingTag(Flag.HAS_TEXT);
jjg@1455 202 }
jjg@1455 203 return null;
jjg@1455 204 }
jjg@1455 205
jjg@1455 206 @Override
jjg@1455 207 public Void visitEntity(EntityTree tree, Void ignore) {
jjg@1507 208 checkAllowsText(tree);
jjg@1455 209 markEnclosingTag(Flag.HAS_TEXT);
jjg@1455 210 String name = tree.getName().toString();
jjg@1455 211 if (name.startsWith("#")) {
jjg@1455 212 int v = name.toLowerCase().startsWith("#x")
jjg@1455 213 ? Integer.parseInt(name.substring(2), 16)
jjg@1455 214 : Integer.parseInt(name.substring(1), 10);
jjg@1455 215 if (!Entity.isValid(v)) {
jjg@1455 216 env.messages.error(HTML, tree, "dc.entity.invalid", name);
jjg@1455 217 }
jjg@1455 218 } else if (!Entity.isValid(name)) {
jjg@1455 219 env.messages.error(HTML, tree, "dc.entity.invalid", name);
jjg@1455 220 }
jjg@1455 221 return null;
jjg@1455 222 }
jjg@1455 223
jjg@1507 224 void checkAllowsText(DocTree tree) {
jjg@1507 225 TagStackItem top = tagStack.peek();
jjg@1507 226 if (top != null
jjg@1507 227 && top.tree.getKind() == DocTree.Kind.START_ELEMENT
jjg@1507 228 && !top.tag.acceptsText()) {
jjg@1507 229 if (top.flags.add(Flag.REPORTED_BAD_INLINE)) {
jjg@1507 230 env.messages.error(HTML, tree, "dc.text.not.allowed",
jjg@1507 231 ((StartElementTree) top.tree).getName());
jjg@1507 232 }
jjg@1507 233 }
jjg@1507 234 }
jjg@1507 235
jjg@1455 236 // </editor-fold>
jjg@1455 237
jjg@1455 238 // <editor-fold defaultstate="collapsed" desc="HTML elements">
jjg@1455 239
jjg@1455 240 @Override
jjg@1455 241 public Void visitStartElement(StartElementTree tree, Void ignore) {
jjg@1455 242 markEnclosingTag(Flag.HAS_ELEMENT);
jjg@1455 243 final Name treeName = tree.getName();
jjg@1455 244 final HtmlTag t = HtmlTag.get(treeName);
jjg@1455 245 if (t == null) {
jjg@1455 246 env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
jjg@1455 247 } else {
jjg@1507 248 for (TagStackItem tsi: tagStack) {
jjg@1507 249 if (tsi.tag.accepts(t)) {
jjg@1507 250 while (tagStack.peek() != tsi) tagStack.pop();
jjg@1507 251 break;
jjg@1507 252 } else if (tsi.tag.endKind != HtmlTag.EndKind.OPTIONAL)
jjg@1507 253 break;
jjg@1507 254 }
jjg@1507 255
jjg@1507 256 checkStructure(tree, t);
jjg@1507 257
jjg@1455 258 // tag specific checks
jjg@1455 259 switch (t) {
jjg@1455 260 // check for out of sequence headers, such as <h1>...</h1> <h3>...</h3>
jjg@1455 261 case H1: case H2: case H3: case H4: case H5: case H6:
jjg@1455 262 checkHeader(tree, t);
jjg@1455 263 break;
jjg@1455 264 }
jjg@1455 265
jjg@1455 266 if (t.flags.contains(HtmlTag.Flag.NO_NEST)) {
jjg@1455 267 for (TagStackItem i: tagStack) {
jjg@1455 268 if (t == i.tag) {
jjg@1455 269 env.messages.warning(HTML, tree, "dc.tag.nested.not.allowed", treeName);
jjg@1455 270 break;
jjg@1455 271 }
jjg@1455 272 }
jjg@1455 273 }
jjg@1455 274 }
jjg@1455 275
jjg@1455 276 // check for self closing tags, such as <a id="name"/>
jjg@1455 277 if (tree.isSelfClosing()) {
jjg@1455 278 env.messages.error(HTML, tree, "dc.tag.self.closing", treeName);
jjg@1455 279 }
jjg@1455 280
jjg@1455 281 try {
jjg@1455 282 TagStackItem parent = tagStack.peek();
jjg@1455 283 TagStackItem top = new TagStackItem(tree, t);
jjg@1455 284 tagStack.push(top);
jjg@1455 285
jjg@1455 286 super.visitStartElement(tree, ignore);
jjg@1455 287
jjg@1455 288 // handle attributes that may or may not have been found in start element
jjg@1455 289 if (t != null) {
jjg@1455 290 switch (t) {
jjg@1455 291 case CAPTION:
jjg@1455 292 if (parent != null && parent.tag == HtmlTag.TABLE)
jjg@1455 293 parent.flags.add(Flag.TABLE_HAS_CAPTION);
jjg@1455 294 break;
jjg@1455 295
jjg@1455 296 case IMG:
jjg@1455 297 if (!top.attrs.contains(HtmlTag.Attr.ALT))
jjg@1455 298 env.messages.error(ACCESSIBILITY, tree, "dc.no.alt.attr.for.image");
jjg@1455 299 break;
jjg@1455 300 }
jjg@1455 301 }
jjg@1455 302
jjg@1455 303 return null;
jjg@1455 304 } finally {
jjg@1455 305
jjg@1455 306 if (t == null || t.endKind == HtmlTag.EndKind.NONE)
jjg@1455 307 tagStack.pop();
jjg@1455 308 }
jjg@1455 309 }
jjg@1455 310
jjg@1507 311 private void checkStructure(StartElementTree tree, HtmlTag t) {
jjg@1507 312 Name treeName = tree.getName();
jjg@1507 313 TagStackItem top = tagStack.peek();
jjg@1507 314 switch (t.blockType) {
jjg@1507 315 case BLOCK:
jjg@1507 316 if (top == null || top.tag.accepts(t))
jjg@1507 317 return;
jjg@1507 318
jjg@1507 319 switch (top.tree.getKind()) {
jjg@1507 320 case START_ELEMENT: {
jjg@1507 321 if (top.tag.blockType == HtmlTag.BlockType.INLINE) {
jjg@1507 322 Name name = ((StartElementTree) top.tree).getName();
jjg@1507 323 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.element",
jjg@1507 324 treeName, name);
jjg@1507 325 return;
jjg@1507 326 }
jjg@1507 327 }
jjg@1507 328 break;
jjg@1507 329
jjg@1507 330 case LINK:
jjg@1507 331 case LINK_PLAIN: {
jjg@1507 332 String name = top.tree.getKind().tagName;
jjg@1507 333 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.tag",
jjg@1507 334 treeName, name);
jjg@1507 335 return;
jjg@1507 336 }
jjg@1507 337 }
jjg@1507 338 break;
jjg@1507 339
jjg@1507 340 case INLINE:
jjg@1507 341 if (top == null || top.tag.accepts(t))
jjg@1507 342 return;
jjg@1507 343 break;
jjg@1507 344
jjg@1507 345 case LIST_ITEM:
jjg@1507 346 case TABLE_ITEM:
jjg@1507 347 if (top != null) {
jjg@1507 348 // reset this flag so subsequent bad inline content gets reported
jjg@1507 349 top.flags.remove(Flag.REPORTED_BAD_INLINE);
jjg@1507 350 if (top.tag.accepts(t))
jjg@1507 351 return;
jjg@1507 352 }
jjg@1507 353 break;
jjg@1507 354
jjg@1507 355 case OTHER:
jjg@1507 356 env.messages.error(HTML, tree, "dc.tag.not.allowed", treeName);
jjg@1507 357 return;
jjg@1507 358 }
jjg@1507 359
jjg@1507 360 env.messages.error(HTML, tree, "dc.tag.not.allowed.here", treeName);
jjg@1507 361 }
jjg@1507 362
jjg@1455 363 private void checkHeader(StartElementTree tree, HtmlTag tag) {
jjg@1455 364 // verify the new tag
jjg@1455 365 if (getHeaderLevel(tag) > getHeaderLevel(currHeaderTag) + 1) {
jjg@1455 366 if (currHeaderTag == null) {
jjg@1455 367 env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.1", tag);
jjg@1455 368 } else {
jjg@1455 369 env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.2",
jjg@1455 370 tag, currHeaderTag);
jjg@1455 371 }
jjg@1455 372 }
jjg@1455 373
jjg@1455 374 currHeaderTag = tag;
jjg@1455 375 }
jjg@1455 376
jjg@1455 377 private int getHeaderLevel(HtmlTag tag) {
jjg@1455 378 if (tag == null)
jjg@1455 379 return 0;
jjg@1455 380 switch (tag) {
jjg@1455 381 case H1: return 1;
jjg@1455 382 case H2: return 2;
jjg@1455 383 case H3: return 3;
jjg@1455 384 case H4: return 4;
jjg@1455 385 case H5: return 5;
jjg@1455 386 case H6: return 6;
jjg@1455 387 default: throw new IllegalArgumentException();
jjg@1455 388 }
jjg@1455 389 }
jjg@1455 390
jjg@1455 391 @Override
jjg@1455 392 public Void visitEndElement(EndElementTree tree, Void ignore) {
jjg@1455 393 final Name treeName = tree.getName();
jjg@1455 394 final HtmlTag t = HtmlTag.get(treeName);
jjg@1455 395 if (t == null) {
jjg@1455 396 env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
jjg@1455 397 } else if (t.endKind == HtmlTag.EndKind.NONE) {
jjg@1455 398 env.messages.error(HTML, tree, "dc.tag.end.not.permitted", treeName);
jjg@1455 399 } else {
jjg@1499 400 boolean done = false;
jjg@1455 401 while (!tagStack.isEmpty()) {
jjg@1455 402 TagStackItem top = tagStack.peek();
jjg@1455 403 if (t == top.tag) {
jjg@1455 404 switch (t) {
jjg@1455 405 case TABLE:
jjg@1455 406 if (!top.attrs.contains(HtmlTag.Attr.SUMMARY)
jjg@1455 407 && !top.flags.contains(Flag.TABLE_HAS_CAPTION)) {
jjg@1455 408 env.messages.error(ACCESSIBILITY, tree,
jjg@1455 409 "dc.no.summary.or.caption.for.table");
jjg@1455 410 }
jjg@1455 411 }
jjg@1455 412 if (t.flags.contains(HtmlTag.Flag.EXPECT_CONTENT)
jjg@1455 413 && !top.flags.contains(Flag.HAS_TEXT)
jjg@1455 414 && !top.flags.contains(Flag.HAS_ELEMENT)) {
jjg@1455 415 env.messages.warning(HTML, tree, "dc.tag.empty", treeName);
jjg@1455 416 }
jjg@1455 417 tagStack.pop();
jjg@1499 418 done = true;
jjg@1455 419 break;
jjg@1455 420 } else if (top.tag == null || top.tag.endKind != HtmlTag.EndKind.REQUIRED) {
jjg@1455 421 tagStack.pop();
jjg@1455 422 } else {
jjg@1455 423 boolean found = false;
jjg@1455 424 for (TagStackItem si: tagStack) {
jjg@1455 425 if (si.tag == t) {
jjg@1455 426 found = true;
jjg@1455 427 break;
jjg@1455 428 }
jjg@1455 429 }
jjg@1455 430 if (found && top.tree.getKind() == DocTree.Kind.START_ELEMENT) {
jjg@1455 431 env.messages.error(HTML, top.tree, "dc.tag.start.unmatched",
jjg@1455 432 ((StartElementTree) top.tree).getName());
jjg@1455 433 tagStack.pop();
jjg@1455 434 } else {
jjg@1455 435 env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
jjg@1499 436 done = true;
jjg@1455 437 break;
jjg@1455 438 }
jjg@1455 439 }
jjg@1455 440 }
jjg@1499 441
jjg@1499 442 if (!done && tagStack.isEmpty()) {
jjg@1499 443 env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
jjg@1499 444 }
jjg@1455 445 }
jjg@1455 446
jjg@1455 447 return super.visitEndElement(tree, ignore);
jjg@1455 448 }
jjg@1455 449 // </editor-fold>
jjg@1455 450
jjg@1455 451 // <editor-fold defaultstate="collapsed" desc="HTML attributes">
jjg@1455 452
jjg@1455 453 @Override @SuppressWarnings("fallthrough")
jjg@1455 454 public Void visitAttribute(AttributeTree tree, Void ignore) {
jjg@1455 455 HtmlTag currTag = tagStack.peek().tag;
jjg@1455 456 if (currTag != null) {
jjg@1455 457 Name name = tree.getName();
jjg@1455 458 HtmlTag.Attr attr = currTag.getAttr(name);
jjg@1455 459 if (attr != null) {
jjg@1455 460 boolean first = tagStack.peek().attrs.add(attr);
jjg@1455 461 if (!first)
jjg@1455 462 env.messages.error(HTML, tree, "dc.attr.repeated", name);
jjg@1455 463 }
jjg@1455 464 AttrKind k = currTag.getAttrKind(name);
jjg@1455 465 switch (k) {
jjg@1455 466 case OK:
jjg@1455 467 break;
jjg@1455 468
jjg@1455 469 case INVALID:
jjg@1455 470 env.messages.error(HTML, tree, "dc.attr.unknown", name);
jjg@1455 471 break;
jjg@1455 472
jjg@1455 473 case OBSOLETE:
jjg@1455 474 env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete", name);
jjg@1455 475 break;
jjg@1455 476
jjg@1455 477 case USE_CSS:
jjg@1455 478 env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete.use.css", name);
jjg@1455 479 break;
jjg@1455 480 }
jjg@1455 481
jjg@1455 482 if (attr != null) {
jjg@1455 483 switch (attr) {
jjg@1455 484 case NAME:
jjg@1455 485 if (currTag != HtmlTag.A) {
jjg@1455 486 break;
jjg@1455 487 }
jjg@1495 488 // fallthrough
jjg@1455 489 case ID:
jjg@1455 490 String value = getAttrValue(tree);
jjg@1495 491 if (value == null) {
jjg@1495 492 env.messages.error(HTML, tree, "dc.anchor.value.missing");
jjg@1495 493 } else {
jjg@1495 494 if (!validName.matcher(value).matches()) {
jjg@1495 495 env.messages.error(HTML, tree, "dc.invalid.anchor", value);
jjg@1495 496 }
jjg@1495 497 if (!foundAnchors.add(value)) {
jjg@1495 498 env.messages.error(HTML, tree, "dc.anchor.already.defined", value);
jjg@1495 499 }
jjg@1455 500 }
jjg@1455 501 break;
jjg@1455 502
jjg@1455 503 case HREF:
jjg@1455 504 if (currTag == HtmlTag.A) {
jjg@1455 505 String v = getAttrValue(tree);
jjg@1455 506 if (v == null || v.isEmpty()) {
jjg@1455 507 env.messages.error(HTML, tree, "dc.attr.lacks.value");
jjg@1455 508 } else {
jjg@1455 509 Matcher m = docRoot.matcher(v);
jjg@1455 510 if (m.matches()) {
jjg@1455 511 String rest = m.group(2);
jjg@1455 512 if (!rest.isEmpty())
jjg@1455 513 checkURI(tree, rest);
jjg@1455 514 } else {
jjg@1455 515 checkURI(tree, v);
jjg@1455 516 }
jjg@1455 517 }
jjg@1455 518 }
jjg@1455 519 break;
jjg@1455 520 }
jjg@1455 521 }
jjg@1455 522 }
jjg@1455 523
jjg@1455 524 // TODO: basic check on value
jjg@1455 525
jjg@1455 526 return super.visitAttribute(tree, ignore);
jjg@1455 527 }
jjg@1455 528
jjg@1455 529 // http://www.w3.org/TR/html401/types.html#type-name
jjg@1455 530 private static final Pattern validName = Pattern.compile("[A-Za-z][A-Za-z0-9-_:.]*");
jjg@1455 531
jjg@1455 532 // pattern to remove leading {@docRoot}/?
jjg@1455 533 private static final Pattern docRoot = Pattern.compile("(?i)(\\{@docRoot *\\}/?)?(.*)");
jjg@1455 534
jjg@1455 535 private String getAttrValue(AttributeTree tree) {
jjg@1455 536 if (tree.getValue() == null)
jjg@1455 537 return null;
jjg@1455 538
jjg@1455 539 StringWriter sw = new StringWriter();
jjg@1455 540 try {
jjg@1455 541 new DocPretty(sw).print(tree.getValue());
jjg@1455 542 } catch (IOException e) {
jjg@1455 543 // cannot happen
jjg@1455 544 }
jjg@1455 545 // ignore potential use of entities for now
jjg@1455 546 return sw.toString();
jjg@1455 547 }
jjg@1455 548
jjg@1455 549 private void checkURI(AttributeTree tree, String uri) {
jjg@1455 550 try {
jjg@1455 551 URI u = new URI(uri);
jjg@1455 552 } catch (URISyntaxException e) {
jjg@1455 553 env.messages.error(HTML, tree, "dc.invalid.uri", uri);
jjg@1455 554 }
jjg@1455 555 }
jjg@1455 556 // </editor-fold>
jjg@1455 557
jjg@1455 558 // <editor-fold defaultstate="collapsed" desc="javadoc tags">
jjg@1455 559
jjg@1455 560 @Override
jjg@1455 561 public Void visitAuthor(AuthorTree tree, Void ignore) {
jjg@1455 562 warnIfEmpty(tree, tree.getName());
jjg@1455 563 return super.visitAuthor(tree, ignore);
jjg@1455 564 }
jjg@1455 565
jjg@1455 566 @Override
jjg@1455 567 public Void visitInheritDoc(InheritDocTree tree, Void ignore) {
jjg@1455 568 // TODO: verify on overridden method
jjg@1455 569 foundInheritDoc = true;
jjg@1455 570 return super.visitInheritDoc(tree, ignore);
jjg@1455 571 }
jjg@1455 572
jjg@1455 573 @Override
jjg@1455 574 public Void visitLink(LinkTree tree, Void ignore) {
jjg@1455 575 // simulate inline context on tag stack
jjg@1455 576 HtmlTag t = (tree.getKind() == DocTree.Kind.LINK)
jjg@1455 577 ? HtmlTag.CODE : HtmlTag.SPAN;
jjg@1455 578 tagStack.push(new TagStackItem(tree, t));
jjg@1455 579 try {
jjg@1455 580 return super.visitLink(tree, ignore);
jjg@1455 581 } finally {
jjg@1455 582 tagStack.pop();
jjg@1455 583 }
jjg@1455 584 }
jjg@1455 585
jjg@1455 586 @Override
jjg@1499 587 public Void visitLiteral(LiteralTree tree, Void ignore) {
jjg@1499 588 if (tree.getKind() == DocTree.Kind.CODE) {
jjg@1499 589 for (TagStackItem tsi: tagStack) {
jjg@1499 590 if (tsi.tag == HtmlTag.CODE) {
jjg@1502 591 env.messages.warning(HTML, tree, "dc.tag.code.within.code");
jjg@1499 592 break;
jjg@1499 593 }
jjg@1499 594 }
jjg@1499 595 }
jjg@1499 596 return super.visitLiteral(tree, ignore);
jjg@1499 597 }
jjg@1499 598
jjg@1499 599 @Override
jjg@1455 600 public Void visitParam(ParamTree tree, Void ignore) {
jjg@1455 601 boolean typaram = tree.isTypeParameter();
jjg@1455 602 IdentifierTree nameTree = tree.getName();
jjg@1455 603 Element e = env.currElement;
jjg@1455 604 switch (e.getKind()) {
jjg@1455 605 case METHOD: case CONSTRUCTOR: {
jjg@1455 606 ExecutableElement ee = (ExecutableElement) e;
jjg@1455 607 checkParamDeclared(nameTree, typaram ? ee.getTypeParameters() : ee.getParameters());
jjg@1455 608 break;
jjg@1455 609 }
jjg@1455 610
jjg@1455 611 case CLASS: case INTERFACE: {
jjg@1455 612 TypeElement te = (TypeElement) e;
jjg@1455 613 if (typaram) {
jjg@1455 614 checkParamDeclared(nameTree, te.getTypeParameters());
jjg@1455 615 } else {
jjg@1455 616 env.messages.error(REFERENCE, tree, "dc.invalid.param");
jjg@1455 617 }
jjg@1455 618 break;
jjg@1455 619 }
jjg@1455 620
jjg@1455 621 default:
jjg@1455 622 env.messages.error(REFERENCE, tree, "dc.invalid.param");
jjg@1455 623 break;
jjg@1455 624 }
jjg@1455 625 warnIfEmpty(tree, tree.getDescription());
jjg@1455 626 return super.visitParam(tree, ignore);
jjg@1455 627 }
jjg@1455 628 // where
jjg@1455 629 private void checkParamDeclared(IdentifierTree nameTree, List<? extends Element> list) {
jjg@1455 630 Name name = nameTree.getName();
jjg@1455 631 boolean found = false;
jjg@1455 632 for (Element e: list) {
jjg@1455 633 if (name.equals(e.getSimpleName())) {
jjg@1455 634 foundParams.add(e);
jjg@1455 635 found = true;
jjg@1455 636 }
jjg@1455 637 }
jjg@1455 638 if (!found)
jjg@1455 639 env.messages.error(REFERENCE, nameTree, "dc.param.name.not.found");
jjg@1455 640 }
jjg@1455 641
jjg@1455 642 private void checkParamsDocumented(List<? extends Element> list) {
jjg@1455 643 if (foundInheritDoc)
jjg@1455 644 return;
jjg@1455 645
jjg@1455 646 for (Element e: list) {
jjg@1455 647 if (!foundParams.contains(e)) {
jjg@1455 648 CharSequence paramName = (e.getKind() == ElementKind.TYPE_PARAMETER)
jjg@1455 649 ? "<" + e.getSimpleName() + ">"
jjg@1455 650 : e.getSimpleName();
jjg@1455 651 reportMissing("dc.missing.param", paramName);
jjg@1455 652 }
jjg@1455 653 }
jjg@1455 654 }
jjg@1455 655
jjg@1455 656 @Override
jjg@1455 657 public Void visitReference(ReferenceTree tree, Void ignore) {
jjg@1455 658 Element e = env.trees.getElement(env.currPath, tree);
jjg@1455 659 if (e == null)
jjg@1455 660 env.messages.error(REFERENCE, tree, "dc.ref.not.found");
jjg@1455 661 return super.visitReference(tree, ignore);
jjg@1455 662 }
jjg@1455 663
jjg@1455 664 @Override
jjg@1455 665 public Void visitReturn(ReturnTree tree, Void ignore) {
jjg@1455 666 Element e = env.trees.getElement(env.currPath);
jjg@1455 667 if (e.getKind() != ElementKind.METHOD
jjg@1455 668 || ((ExecutableElement) e).getReturnType().getKind() == TypeKind.VOID)
jjg@1455 669 env.messages.error(REFERENCE, tree, "dc.invalid.return");
jjg@1455 670 foundReturn = true;
jjg@1455 671 warnIfEmpty(tree, tree.getDescription());
jjg@1455 672 return super.visitReturn(tree, ignore);
jjg@1455 673 }
jjg@1455 674
jjg@1455 675 @Override
jjg@1455 676 public Void visitSerialData(SerialDataTree tree, Void ignore) {
jjg@1455 677 warnIfEmpty(tree, tree.getDescription());
jjg@1455 678 return super.visitSerialData(tree, ignore);
jjg@1455 679 }
jjg@1455 680
jjg@1455 681 @Override
jjg@1455 682 public Void visitSerialField(SerialFieldTree tree, Void ignore) {
jjg@1455 683 warnIfEmpty(tree, tree.getDescription());
jjg@1455 684 return super.visitSerialField(tree, ignore);
jjg@1455 685 }
jjg@1455 686
jjg@1455 687 @Override
jjg@1455 688 public Void visitSince(SinceTree tree, Void ignore) {
jjg@1455 689 warnIfEmpty(tree, tree.getBody());
jjg@1455 690 return super.visitSince(tree, ignore);
jjg@1455 691 }
jjg@1455 692
jjg@1455 693 @Override
jjg@1455 694 public Void visitThrows(ThrowsTree tree, Void ignore) {
jjg@1455 695 ReferenceTree exName = tree.getExceptionName();
jjg@1455 696 Element ex = env.trees.getElement(env.currPath, exName);
jjg@1455 697 if (ex == null) {
jjg@1455 698 env.messages.error(REFERENCE, tree, "dc.ref.not.found");
jjg@1455 699 } else if (ex.asType().getKind() == TypeKind.DECLARED
jjg@1455 700 && env.types.isAssignable(ex.asType(), env.java_lang_Throwable)) {
jjg@1455 701 switch (env.currElement.getKind()) {
jjg@1455 702 case CONSTRUCTOR:
jjg@1455 703 case METHOD:
jjg@1455 704 if (isCheckedException(ex.asType())) {
jjg@1455 705 ExecutableElement ee = (ExecutableElement) env.currElement;
jjg@1455 706 checkThrowsDeclared(exName, ex.asType(), ee.getThrownTypes());
jjg@1455 707 }
jjg@1455 708 break;
jjg@1455 709 default:
jjg@1455 710 env.messages.error(REFERENCE, tree, "dc.invalid.throws");
jjg@1455 711 }
jjg@1455 712 } else {
jjg@1455 713 env.messages.error(REFERENCE, tree, "dc.invalid.throws");
jjg@1455 714 }
jjg@1455 715 warnIfEmpty(tree, tree.getDescription());
jjg@1455 716 return scan(tree.getDescription(), ignore);
jjg@1455 717 }
jjg@1455 718
jjg@1455 719 private void checkThrowsDeclared(ReferenceTree tree, TypeMirror t, List<? extends TypeMirror> list) {
jjg@1455 720 boolean found = false;
jjg@1455 721 for (TypeMirror tl : list) {
jjg@1455 722 if (env.types.isAssignable(t, tl)) {
jjg@1455 723 foundThrows.add(tl);
jjg@1455 724 found = true;
jjg@1455 725 }
jjg@1455 726 }
jjg@1455 727 if (!found)
jjg@1455 728 env.messages.error(REFERENCE, tree, "dc.exception.not.thrown", t);
jjg@1455 729 }
jjg@1455 730
jjg@1455 731 private void checkThrowsDocumented(List<? extends TypeMirror> list) {
jjg@1455 732 if (foundInheritDoc)
jjg@1455 733 return;
jjg@1455 734
jjg@1455 735 for (TypeMirror tl: list) {
jjg@1455 736 if (isCheckedException(tl) && !foundThrows.contains(tl))
jjg@1455 737 reportMissing("dc.missing.throws", tl);
jjg@1455 738 }
jjg@1455 739 }
jjg@1455 740
jjg@1455 741 @Override
jjg@1455 742 public Void visitVersion(VersionTree tree, Void ignore) {
jjg@1455 743 warnIfEmpty(tree, tree.getBody());
jjg@1455 744 return super.visitVersion(tree, ignore);
jjg@1455 745 }
jjg@1455 746
jjg@1455 747 @Override
jjg@1455 748 public Void visitErroneous(ErroneousTree tree, Void ignore) {
jjg@1455 749 env.messages.error(SYNTAX, tree, null, tree.getDiagnostic().getMessage(null));
jjg@1455 750 return null;
jjg@1455 751 }
jjg@1455 752 // </editor-fold>
jjg@1455 753
jjg@1455 754 // <editor-fold defaultstate="collapsed" desc="Utility methods">
jjg@1455 755
jjg@1455 756 private boolean isCheckedException(TypeMirror t) {
jjg@1455 757 return !(env.types.isAssignable(t, env.java_lang_Error)
jjg@1455 758 || env.types.isAssignable(t, env.java_lang_RuntimeException));
jjg@1455 759 }
jjg@1455 760
jjg@1455 761 private boolean isSynthetic() {
jjg@1455 762 switch (env.currElement.getKind()) {
jjg@1455 763 case CONSTRUCTOR:
jjg@1455 764 // A synthetic default constructor has the same pos as the
jjg@1455 765 // enclosing class
jjg@1455 766 TreePath p = env.currPath;
jjg@1455 767 return env.getPos(p) == env.getPos(p.getParentPath());
jjg@1455 768 }
jjg@1455 769 return false;
jjg@1455 770 }
jjg@1455 771
jjg@1455 772 void markEnclosingTag(Flag flag) {
jjg@1455 773 TagStackItem top = tagStack.peek();
jjg@1455 774 if (top != null)
jjg@1455 775 top.flags.add(flag);
jjg@1455 776 }
jjg@1455 777
jjg@1455 778 String toString(TreePath p) {
jjg@1455 779 StringBuilder sb = new StringBuilder("TreePath[");
jjg@1455 780 toString(p, sb);
jjg@1455 781 sb.append("]");
jjg@1455 782 return sb.toString();
jjg@1455 783 }
jjg@1455 784
jjg@1455 785 void toString(TreePath p, StringBuilder sb) {
jjg@1455 786 TreePath parent = p.getParentPath();
jjg@1455 787 if (parent != null) {
jjg@1455 788 toString(parent, sb);
jjg@1455 789 sb.append(",");
jjg@1455 790 }
jjg@1455 791 sb.append(p.getLeaf().getKind()).append(":").append(env.getPos(p)).append(":S").append(env.getStartPos(p));
jjg@1455 792 }
jjg@1455 793
jjg@1455 794 void warnIfEmpty(DocTree tree, List<? extends DocTree> list) {
jjg@1455 795 for (DocTree d: list) {
jjg@1455 796 switch (d.getKind()) {
jjg@1455 797 case TEXT:
jjg@1507 798 if (hasNonWhitespace((TextTree) d))
jjg@1455 799 return;
jjg@1455 800 break;
jjg@1455 801 default:
jjg@1455 802 return;
jjg@1455 803 }
jjg@1455 804 }
jjg@1455 805 env.messages.warning(SYNTAX, tree, "dc.empty", tree.getKind().tagName);
jjg@1455 806 }
jjg@1507 807
jjg@1507 808 boolean hasNonWhitespace(TextTree tree) {
jjg@1507 809 String s = tree.getBody();
jjg@1507 810 for (int i = 0; i < s.length(); i++) {
jjg@1507 811 if (!Character.isWhitespace(s.charAt(i)))
jjg@1507 812 return true;
jjg@1507 813 }
jjg@1507 814 return false;
jjg@1507 815 }
jjg@1507 816
jjg@1455 817 // </editor-fold>
jjg@1455 818
jjg@1455 819 }

mercurial