src/share/classes/com/sun/tools/doclint/Checker.java

Wed, 16 Jan 2013 10:29:52 -0800

author
jjg
date
Wed, 16 Jan 2013 10:29:52 -0800
changeset 1499
6b6311a8c9cc
parent 1495
bc1023e0e533
child 1502
916143318f10
permissions
-rw-r--r--

8006236: doclint: structural issue hidden
Reviewed-by: darcy

jjg@1455 1 /*
jjg@1495 2 * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
jjg@1455 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
jjg@1455 4 *
jjg@1455 5 * This code is free software; you can redistribute it and/or modify it
jjg@1455 6 * under the terms of the GNU General Public License version 2 only, as
jjg@1455 7 * published by the Free Software Foundation. Oracle designates this
jjg@1455 8 * particular file as subject to the "Classpath" exception as provided
jjg@1455 9 * by Oracle in the LICENSE file that accompanied this code.
jjg@1455 10 *
jjg@1455 11 * This code is distributed in the hope that it will be useful, but WITHOUT
jjg@1455 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
jjg@1455 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
jjg@1455 14 * version 2 for more details (a copy is included in the LICENSE file that
jjg@1455 15 * accompanied this code).
jjg@1455 16 *
jjg@1455 17 * You should have received a copy of the GNU General Public License version
jjg@1455 18 * 2 along with this work; if not, write to the Free Software Foundation,
jjg@1455 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
jjg@1455 20 *
jjg@1455 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
jjg@1455 22 * or visit www.oracle.com if you need additional information or have any
jjg@1455 23 * questions.
jjg@1455 24 */
jjg@1455 25
jjg@1455 26 package com.sun.tools.doclint;
jjg@1455 27
jjg@1499 28 import com.sun.source.doctree.LiteralTree;
jjg@1455 29 import java.util.regex.Matcher;
jjg@1455 30 import com.sun.source.doctree.LinkTree;
jjg@1455 31 import java.net.URI;
jjg@1455 32 import java.util.regex.Pattern;
jjg@1455 33 import java.io.IOException;
jjg@1455 34 import com.sun.tools.javac.tree.DocPretty;
jjg@1455 35 import java.io.StringWriter;
jjg@1455 36 import java.util.Deque;
jjg@1455 37 import java.util.EnumSet;
jjg@1455 38 import java.util.HashSet;
jjg@1455 39 import java.util.LinkedList;
jjg@1455 40 import java.util.List;
jjg@1455 41 import java.util.Set;
jjg@1455 42
jjg@1455 43 import javax.lang.model.element.Element;
jjg@1455 44 import javax.lang.model.element.ElementKind;
jjg@1455 45 import javax.lang.model.element.ExecutableElement;
jjg@1455 46 import javax.lang.model.element.Name;
jjg@1455 47 import javax.lang.model.element.TypeElement;
jjg@1455 48 import javax.lang.model.type.TypeKind;
jjg@1455 49 import javax.lang.model.type.TypeMirror;
jjg@1455 50 import javax.tools.Diagnostic.Kind;
jjg@1455 51
jjg@1455 52 import com.sun.source.doctree.AttributeTree;
jjg@1455 53 import com.sun.source.doctree.AuthorTree;
jjg@1455 54 import com.sun.source.doctree.DocCommentTree;
jjg@1455 55 import com.sun.source.doctree.DocTree;
jjg@1455 56 import com.sun.source.doctree.EndElementTree;
jjg@1455 57 import com.sun.source.doctree.EntityTree;
jjg@1455 58 import com.sun.source.doctree.ErroneousTree;
jjg@1455 59 import com.sun.source.doctree.IdentifierTree;
jjg@1455 60 import com.sun.source.doctree.InheritDocTree;
jjg@1455 61 import com.sun.source.doctree.ParamTree;
jjg@1455 62 import com.sun.source.doctree.ReferenceTree;
jjg@1455 63 import com.sun.source.doctree.ReturnTree;
jjg@1455 64 import com.sun.source.doctree.SerialDataTree;
jjg@1455 65 import com.sun.source.doctree.SerialFieldTree;
jjg@1455 66 import com.sun.source.doctree.SinceTree;
jjg@1455 67 import com.sun.source.doctree.StartElementTree;
jjg@1455 68 import com.sun.source.doctree.TextTree;
jjg@1455 69 import com.sun.source.doctree.ThrowsTree;
jjg@1455 70 import com.sun.source.doctree.VersionTree;
jjg@1455 71 import com.sun.source.util.DocTreeScanner;
jjg@1455 72 import com.sun.source.util.TreePath;
jjg@1455 73 import com.sun.tools.doclint.HtmlTag.AttrKind;
jjg@1455 74 import java.net.URISyntaxException;
jjg@1455 75 import static com.sun.tools.doclint.Messages.Group.*;
jjg@1455 76
jjg@1455 77
jjg@1455 78 /**
jjg@1455 79 * Validate a doc comment.
jjg@1455 80 *
jjg@1455 81 * <p><b>This is NOT part of any supported API.
jjg@1455 82 * If you write code that depends on this, you do so at your own
jjg@1455 83 * risk. This code and its internal interfaces are subject to change
jjg@1455 84 * or deletion without notice.</b></p>
jjg@1455 85 */
jjg@1455 86 public class Checker extends DocTreeScanner<Void, Void> {
jjg@1455 87 final Env env;
jjg@1455 88
jjg@1455 89 Set<Element> foundParams = new HashSet<Element>();
jjg@1455 90 Set<TypeMirror> foundThrows = new HashSet<TypeMirror>();
jjg@1455 91 Set<String> foundAnchors = new HashSet<String>();
jjg@1455 92 boolean foundInheritDoc = false;
jjg@1455 93 boolean foundReturn = false;
jjg@1455 94
jjg@1455 95 enum Flag {
jjg@1455 96 TABLE_HAS_CAPTION,
jjg@1455 97 HAS_ELEMENT,
jjg@1455 98 HAS_TEXT
jjg@1455 99 }
jjg@1455 100
jjg@1455 101 static class TagStackItem {
jjg@1455 102 final DocTree tree; // typically, but not always, StartElementTree
jjg@1455 103 final HtmlTag tag;
jjg@1455 104 final Set<HtmlTag.Attr> attrs;
jjg@1455 105 final Set<Flag> flags;
jjg@1455 106 TagStackItem(DocTree tree, HtmlTag tag) {
jjg@1455 107 this.tree = tree;
jjg@1455 108 this.tag = tag;
jjg@1455 109 attrs = EnumSet.noneOf(HtmlTag.Attr.class);
jjg@1455 110 flags = EnumSet.noneOf(Flag.class);
jjg@1455 111 }
jjg@1455 112 @Override
jjg@1455 113 public String toString() {
jjg@1455 114 return String.valueOf(tag);
jjg@1455 115 }
jjg@1455 116 }
jjg@1455 117
jjg@1455 118 private Deque<TagStackItem> tagStack; // TODO: maybe want to record starting tree as well
jjg@1455 119 private HtmlTag currHeaderTag;
jjg@1455 120
jjg@1455 121 // <editor-fold defaultstate="collapsed" desc="Top level">
jjg@1455 122
jjg@1455 123 Checker(Env env) {
jjg@1455 124 env.getClass();
jjg@1455 125 this.env = env;
jjg@1455 126 tagStack = new LinkedList<TagStackItem>();
jjg@1455 127 }
jjg@1455 128
jjg@1455 129 public Void scan(DocCommentTree tree, TreePath p) {
jjg@1455 130 env.setCurrent(p, tree);
jjg@1455 131
jjg@1455 132 boolean isOverridingMethod = !env.currOverriddenMethods.isEmpty();
jjg@1455 133
jjg@1455 134 if (tree == null) {
jjg@1455 135 if (!isSynthetic() && !isOverridingMethod)
jjg@1455 136 reportMissing("dc.missing.comment");
jjg@1455 137 return null;
jjg@1455 138 }
jjg@1455 139
jjg@1455 140 tagStack.clear();
jjg@1455 141 currHeaderTag = null;
jjg@1455 142
jjg@1455 143 foundParams.clear();
jjg@1455 144 foundThrows.clear();
jjg@1455 145 foundInheritDoc = false;
jjg@1455 146 foundReturn = false;
jjg@1455 147
jjg@1455 148 scan(tree, (Void) null);
jjg@1455 149
jjg@1455 150 if (!isOverridingMethod) {
jjg@1455 151 switch (env.currElement.getKind()) {
jjg@1455 152 case METHOD:
jjg@1455 153 case CONSTRUCTOR: {
jjg@1455 154 ExecutableElement ee = (ExecutableElement) env.currElement;
jjg@1455 155 checkParamsDocumented(ee.getTypeParameters());
jjg@1455 156 checkParamsDocumented(ee.getParameters());
jjg@1455 157 switch (ee.getReturnType().getKind()) {
jjg@1455 158 case VOID:
jjg@1455 159 case NONE:
jjg@1455 160 break;
jjg@1455 161 default:
jjg@1455 162 if (!foundReturn
jjg@1455 163 && !foundInheritDoc
jjg@1455 164 && !env.types.isSameType(ee.getReturnType(), env.java_lang_Void)) {
jjg@1455 165 reportMissing("dc.missing.return");
jjg@1455 166 }
jjg@1455 167 }
jjg@1455 168 checkThrowsDocumented(ee.getThrownTypes());
jjg@1455 169 }
jjg@1455 170 }
jjg@1455 171 }
jjg@1455 172
jjg@1455 173 return null;
jjg@1455 174 }
jjg@1455 175
jjg@1455 176 private void reportMissing(String code, Object... args) {
jjg@1455 177 env.messages.report(MISSING, Kind.WARNING, env.currPath.getLeaf(), code, args);
jjg@1455 178 }
jjg@1455 179
jjg@1455 180 @Override
jjg@1455 181 public Void visitDocComment(DocCommentTree tree, Void ignore) {
jjg@1455 182 super.visitDocComment(tree, ignore);
jjg@1455 183 for (TagStackItem tsi: tagStack) {
jjg@1455 184 if (tsi.tree.getKind() == DocTree.Kind.START_ELEMENT
jjg@1455 185 && tsi.tag.endKind == HtmlTag.EndKind.REQUIRED) {
jjg@1455 186 StartElementTree t = (StartElementTree) tsi.tree;
jjg@1455 187 env.messages.error(HTML, t, "dc.tag.not.closed", t.getName());
jjg@1455 188 }
jjg@1455 189 }
jjg@1455 190 return null;
jjg@1455 191 }
jjg@1455 192 // </editor-fold>
jjg@1455 193
jjg@1455 194 // <editor-fold defaultstate="collapsed" desc="Text and entities.">
jjg@1455 195
jjg@1455 196 @Override
jjg@1455 197 public Void visitText(TextTree tree, Void ignore) {
jjg@1455 198 if (!tree.getBody().trim().isEmpty()) {
jjg@1455 199 markEnclosingTag(Flag.HAS_TEXT);
jjg@1455 200 }
jjg@1455 201 return null;
jjg@1455 202 }
jjg@1455 203
jjg@1455 204 @Override
jjg@1455 205 public Void visitEntity(EntityTree tree, Void ignore) {
jjg@1455 206 markEnclosingTag(Flag.HAS_TEXT);
jjg@1455 207 String name = tree.getName().toString();
jjg@1455 208 if (name.startsWith("#")) {
jjg@1455 209 int v = name.toLowerCase().startsWith("#x")
jjg@1455 210 ? Integer.parseInt(name.substring(2), 16)
jjg@1455 211 : Integer.parseInt(name.substring(1), 10);
jjg@1455 212 if (!Entity.isValid(v)) {
jjg@1455 213 env.messages.error(HTML, tree, "dc.entity.invalid", name);
jjg@1455 214 }
jjg@1455 215 } else if (!Entity.isValid(name)) {
jjg@1455 216 env.messages.error(HTML, tree, "dc.entity.invalid", name);
jjg@1455 217 }
jjg@1455 218 return null;
jjg@1455 219 }
jjg@1455 220
jjg@1455 221 // </editor-fold>
jjg@1455 222
jjg@1455 223 // <editor-fold defaultstate="collapsed" desc="HTML elements">
jjg@1455 224
jjg@1455 225 @Override
jjg@1455 226 public Void visitStartElement(StartElementTree tree, Void ignore) {
jjg@1455 227 markEnclosingTag(Flag.HAS_ELEMENT);
jjg@1455 228 final Name treeName = tree.getName();
jjg@1455 229 final HtmlTag t = HtmlTag.get(treeName);
jjg@1455 230 if (t == null) {
jjg@1455 231 env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
jjg@1455 232 } else {
jjg@1455 233 // tag specific checks
jjg@1455 234 switch (t) {
jjg@1455 235 // check for out of sequence headers, such as <h1>...</h1> <h3>...</h3>
jjg@1455 236 case H1: case H2: case H3: case H4: case H5: case H6:
jjg@1455 237 checkHeader(tree, t);
jjg@1455 238 break;
jjg@1455 239 // <p> inside <pre>
jjg@1455 240 case P:
jjg@1455 241 TagStackItem top = tagStack.peek();
jjg@1455 242 if (top != null && top.tag == HtmlTag.PRE)
jjg@1455 243 env.messages.warning(HTML, tree, "dc.tag.p.in.pre");
jjg@1455 244 break;
jjg@1455 245 }
jjg@1455 246
jjg@1455 247 // check that only block tags and inline tags are used,
jjg@1455 248 // and that blocks tags are not used within inline tags
jjg@1455 249 switch (t.blockType) {
jjg@1455 250 case INLINE:
jjg@1455 251 break;
jjg@1455 252 case BLOCK:
jjg@1455 253 TagStackItem top = tagStack.peek();
jjg@1455 254 if (top != null && top.tag != null && top.tag.blockType == HtmlTag.BlockType.INLINE) {
jjg@1455 255 switch (top.tree.getKind()) {
jjg@1455 256 case START_ELEMENT: {
jjg@1455 257 Name name = ((StartElementTree) top.tree).getName();
jjg@1455 258 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.element",
jjg@1455 259 treeName, name);
jjg@1455 260 break;
jjg@1455 261 }
jjg@1455 262 case LINK:
jjg@1455 263 case LINK_PLAIN: {
jjg@1455 264 String name = top.tree.getKind().tagName;
jjg@1455 265 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.tag",
jjg@1455 266 treeName, name);
jjg@1455 267 break;
jjg@1455 268 }
jjg@1455 269 default:
jjg@1455 270 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.other",
jjg@1455 271 treeName);
jjg@1455 272 }
jjg@1455 273 }
jjg@1455 274 break;
jjg@1455 275 case OTHER:
jjg@1455 276 env.messages.error(HTML, tree, "dc.tag.not.allowed", treeName);
jjg@1455 277 break;
jjg@1455 278 default:
jjg@1455 279 throw new AssertionError();
jjg@1455 280 }
jjg@1455 281
jjg@1455 282 if (t.flags.contains(HtmlTag.Flag.NO_NEST)) {
jjg@1455 283 for (TagStackItem i: tagStack) {
jjg@1455 284 if (t == i.tag) {
jjg@1455 285 env.messages.warning(HTML, tree, "dc.tag.nested.not.allowed", treeName);
jjg@1455 286 break;
jjg@1455 287 }
jjg@1455 288 }
jjg@1455 289 }
jjg@1455 290 }
jjg@1455 291
jjg@1455 292 // check for self closing tags, such as <a id="name"/>
jjg@1455 293 if (tree.isSelfClosing()) {
jjg@1455 294 env.messages.error(HTML, tree, "dc.tag.self.closing", treeName);
jjg@1455 295 }
jjg@1455 296
jjg@1455 297 try {
jjg@1455 298 TagStackItem parent = tagStack.peek();
jjg@1455 299 TagStackItem top = new TagStackItem(tree, t);
jjg@1455 300 tagStack.push(top);
jjg@1455 301
jjg@1455 302 super.visitStartElement(tree, ignore);
jjg@1455 303
jjg@1455 304 // handle attributes that may or may not have been found in start element
jjg@1455 305 if (t != null) {
jjg@1455 306 switch (t) {
jjg@1455 307 case CAPTION:
jjg@1455 308 if (parent != null && parent.tag == HtmlTag.TABLE)
jjg@1455 309 parent.flags.add(Flag.TABLE_HAS_CAPTION);
jjg@1455 310 break;
jjg@1455 311
jjg@1455 312 case IMG:
jjg@1455 313 if (!top.attrs.contains(HtmlTag.Attr.ALT))
jjg@1455 314 env.messages.error(ACCESSIBILITY, tree, "dc.no.alt.attr.for.image");
jjg@1455 315 break;
jjg@1455 316 }
jjg@1455 317 }
jjg@1455 318
jjg@1455 319 return null;
jjg@1455 320 } finally {
jjg@1455 321
jjg@1455 322 if (t == null || t.endKind == HtmlTag.EndKind.NONE)
jjg@1455 323 tagStack.pop();
jjg@1455 324 }
jjg@1455 325 }
jjg@1455 326
jjg@1455 327 private void checkHeader(StartElementTree tree, HtmlTag tag) {
jjg@1455 328 // verify the new tag
jjg@1455 329 if (getHeaderLevel(tag) > getHeaderLevel(currHeaderTag) + 1) {
jjg@1455 330 if (currHeaderTag == null) {
jjg@1455 331 env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.1", tag);
jjg@1455 332 } else {
jjg@1455 333 env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.2",
jjg@1455 334 tag, currHeaderTag);
jjg@1455 335 }
jjg@1455 336 }
jjg@1455 337
jjg@1455 338 currHeaderTag = tag;
jjg@1455 339 }
jjg@1455 340
jjg@1455 341 private int getHeaderLevel(HtmlTag tag) {
jjg@1455 342 if (tag == null)
jjg@1455 343 return 0;
jjg@1455 344 switch (tag) {
jjg@1455 345 case H1: return 1;
jjg@1455 346 case H2: return 2;
jjg@1455 347 case H3: return 3;
jjg@1455 348 case H4: return 4;
jjg@1455 349 case H5: return 5;
jjg@1455 350 case H6: return 6;
jjg@1455 351 default: throw new IllegalArgumentException();
jjg@1455 352 }
jjg@1455 353 }
jjg@1455 354
jjg@1455 355 @Override
jjg@1455 356 public Void visitEndElement(EndElementTree tree, Void ignore) {
jjg@1455 357 final Name treeName = tree.getName();
jjg@1455 358 final HtmlTag t = HtmlTag.get(treeName);
jjg@1455 359 if (t == null) {
jjg@1455 360 env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
jjg@1455 361 } else if (t.endKind == HtmlTag.EndKind.NONE) {
jjg@1455 362 env.messages.error(HTML, tree, "dc.tag.end.not.permitted", treeName);
jjg@1455 363 } else {
jjg@1499 364 boolean done = false;
jjg@1455 365 while (!tagStack.isEmpty()) {
jjg@1455 366 TagStackItem top = tagStack.peek();
jjg@1455 367 if (t == top.tag) {
jjg@1455 368 switch (t) {
jjg@1455 369 case TABLE:
jjg@1455 370 if (!top.attrs.contains(HtmlTag.Attr.SUMMARY)
jjg@1455 371 && !top.flags.contains(Flag.TABLE_HAS_CAPTION)) {
jjg@1455 372 env.messages.error(ACCESSIBILITY, tree,
jjg@1455 373 "dc.no.summary.or.caption.for.table");
jjg@1455 374 }
jjg@1455 375 }
jjg@1455 376 if (t.flags.contains(HtmlTag.Flag.EXPECT_CONTENT)
jjg@1455 377 && !top.flags.contains(Flag.HAS_TEXT)
jjg@1455 378 && !top.flags.contains(Flag.HAS_ELEMENT)) {
jjg@1455 379 env.messages.warning(HTML, tree, "dc.tag.empty", treeName);
jjg@1455 380 }
jjg@1455 381 if (t.flags.contains(HtmlTag.Flag.NO_TEXT)
jjg@1455 382 && top.flags.contains(Flag.HAS_TEXT)) {
jjg@1455 383 env.messages.error(HTML, tree, "dc.text.not.allowed", treeName);
jjg@1455 384 }
jjg@1455 385 tagStack.pop();
jjg@1499 386 done = true;
jjg@1455 387 break;
jjg@1455 388 } else if (top.tag == null || top.tag.endKind != HtmlTag.EndKind.REQUIRED) {
jjg@1455 389 tagStack.pop();
jjg@1455 390 } else {
jjg@1455 391 boolean found = false;
jjg@1455 392 for (TagStackItem si: tagStack) {
jjg@1455 393 if (si.tag == t) {
jjg@1455 394 found = true;
jjg@1455 395 break;
jjg@1455 396 }
jjg@1455 397 }
jjg@1455 398 if (found && top.tree.getKind() == DocTree.Kind.START_ELEMENT) {
jjg@1455 399 env.messages.error(HTML, top.tree, "dc.tag.start.unmatched",
jjg@1455 400 ((StartElementTree) top.tree).getName());
jjg@1455 401 tagStack.pop();
jjg@1455 402 } else {
jjg@1455 403 env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
jjg@1499 404 done = true;
jjg@1455 405 break;
jjg@1455 406 }
jjg@1455 407 }
jjg@1455 408 }
jjg@1499 409
jjg@1499 410 if (!done && tagStack.isEmpty()) {
jjg@1499 411 env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
jjg@1499 412 }
jjg@1455 413 }
jjg@1455 414
jjg@1455 415 return super.visitEndElement(tree, ignore);
jjg@1455 416 }
jjg@1455 417 // </editor-fold>
jjg@1455 418
jjg@1455 419 // <editor-fold defaultstate="collapsed" desc="HTML attributes">
jjg@1455 420
jjg@1455 421 @Override @SuppressWarnings("fallthrough")
jjg@1455 422 public Void visitAttribute(AttributeTree tree, Void ignore) {
jjg@1455 423 HtmlTag currTag = tagStack.peek().tag;
jjg@1455 424 if (currTag != null) {
jjg@1455 425 Name name = tree.getName();
jjg@1455 426 HtmlTag.Attr attr = currTag.getAttr(name);
jjg@1455 427 if (attr != null) {
jjg@1455 428 boolean first = tagStack.peek().attrs.add(attr);
jjg@1455 429 if (!first)
jjg@1455 430 env.messages.error(HTML, tree, "dc.attr.repeated", name);
jjg@1455 431 }
jjg@1455 432 AttrKind k = currTag.getAttrKind(name);
jjg@1455 433 switch (k) {
jjg@1455 434 case OK:
jjg@1455 435 break;
jjg@1455 436
jjg@1455 437 case INVALID:
jjg@1455 438 env.messages.error(HTML, tree, "dc.attr.unknown", name);
jjg@1455 439 break;
jjg@1455 440
jjg@1455 441 case OBSOLETE:
jjg@1455 442 env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete", name);
jjg@1455 443 break;
jjg@1455 444
jjg@1455 445 case USE_CSS:
jjg@1455 446 env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete.use.css", name);
jjg@1455 447 break;
jjg@1455 448 }
jjg@1455 449
jjg@1455 450 if (attr != null) {
jjg@1455 451 switch (attr) {
jjg@1455 452 case NAME:
jjg@1455 453 if (currTag != HtmlTag.A) {
jjg@1455 454 break;
jjg@1455 455 }
jjg@1495 456 // fallthrough
jjg@1455 457 case ID:
jjg@1455 458 String value = getAttrValue(tree);
jjg@1495 459 if (value == null) {
jjg@1495 460 env.messages.error(HTML, tree, "dc.anchor.value.missing");
jjg@1495 461 } else {
jjg@1495 462 if (!validName.matcher(value).matches()) {
jjg@1495 463 env.messages.error(HTML, tree, "dc.invalid.anchor", value);
jjg@1495 464 }
jjg@1495 465 if (!foundAnchors.add(value)) {
jjg@1495 466 env.messages.error(HTML, tree, "dc.anchor.already.defined", value);
jjg@1495 467 }
jjg@1455 468 }
jjg@1455 469 break;
jjg@1455 470
jjg@1455 471 case HREF:
jjg@1455 472 if (currTag == HtmlTag.A) {
jjg@1455 473 String v = getAttrValue(tree);
jjg@1455 474 if (v == null || v.isEmpty()) {
jjg@1455 475 env.messages.error(HTML, tree, "dc.attr.lacks.value");
jjg@1455 476 } else {
jjg@1455 477 Matcher m = docRoot.matcher(v);
jjg@1455 478 if (m.matches()) {
jjg@1455 479 String rest = m.group(2);
jjg@1455 480 if (!rest.isEmpty())
jjg@1455 481 checkURI(tree, rest);
jjg@1455 482 } else {
jjg@1455 483 checkURI(tree, v);
jjg@1455 484 }
jjg@1455 485 }
jjg@1455 486 }
jjg@1455 487 break;
jjg@1455 488 }
jjg@1455 489 }
jjg@1455 490 }
jjg@1455 491
jjg@1455 492 // TODO: basic check on value
jjg@1455 493
jjg@1455 494 return super.visitAttribute(tree, ignore);
jjg@1455 495 }
jjg@1455 496
jjg@1455 497 // http://www.w3.org/TR/html401/types.html#type-name
jjg@1455 498 private static final Pattern validName = Pattern.compile("[A-Za-z][A-Za-z0-9-_:.]*");
jjg@1455 499
jjg@1455 500 // pattern to remove leading {@docRoot}/?
jjg@1455 501 private static final Pattern docRoot = Pattern.compile("(?i)(\\{@docRoot *\\}/?)?(.*)");
jjg@1455 502
jjg@1455 503 private String getAttrValue(AttributeTree tree) {
jjg@1455 504 if (tree.getValue() == null)
jjg@1455 505 return null;
jjg@1455 506
jjg@1455 507 StringWriter sw = new StringWriter();
jjg@1455 508 try {
jjg@1455 509 new DocPretty(sw).print(tree.getValue());
jjg@1455 510 } catch (IOException e) {
jjg@1455 511 // cannot happen
jjg@1455 512 }
jjg@1455 513 // ignore potential use of entities for now
jjg@1455 514 return sw.toString();
jjg@1455 515 }
jjg@1455 516
jjg@1455 517 private void checkURI(AttributeTree tree, String uri) {
jjg@1455 518 try {
jjg@1455 519 URI u = new URI(uri);
jjg@1455 520 } catch (URISyntaxException e) {
jjg@1455 521 env.messages.error(HTML, tree, "dc.invalid.uri", uri);
jjg@1455 522 }
jjg@1455 523 }
jjg@1455 524 // </editor-fold>
jjg@1455 525
jjg@1455 526 // <editor-fold defaultstate="collapsed" desc="javadoc tags">
jjg@1455 527
jjg@1455 528 @Override
jjg@1455 529 public Void visitAuthor(AuthorTree tree, Void ignore) {
jjg@1455 530 warnIfEmpty(tree, tree.getName());
jjg@1455 531 return super.visitAuthor(tree, ignore);
jjg@1455 532 }
jjg@1455 533
jjg@1455 534 @Override
jjg@1455 535 public Void visitInheritDoc(InheritDocTree tree, Void ignore) {
jjg@1455 536 // TODO: verify on overridden method
jjg@1455 537 foundInheritDoc = true;
jjg@1455 538 return super.visitInheritDoc(tree, ignore);
jjg@1455 539 }
jjg@1455 540
jjg@1455 541 @Override
jjg@1455 542 public Void visitLink(LinkTree tree, Void ignore) {
jjg@1455 543 // simulate inline context on tag stack
jjg@1455 544 HtmlTag t = (tree.getKind() == DocTree.Kind.LINK)
jjg@1455 545 ? HtmlTag.CODE : HtmlTag.SPAN;
jjg@1455 546 tagStack.push(new TagStackItem(tree, t));
jjg@1455 547 try {
jjg@1455 548 return super.visitLink(tree, ignore);
jjg@1455 549 } finally {
jjg@1455 550 tagStack.pop();
jjg@1455 551 }
jjg@1455 552 }
jjg@1455 553
jjg@1455 554 @Override
jjg@1499 555 public Void visitLiteral(LiteralTree tree, Void ignore) {
jjg@1499 556 if (tree.getKind() == DocTree.Kind.CODE) {
jjg@1499 557 for (TagStackItem tsi: tagStack) {
jjg@1499 558 if (tsi.tag == HtmlTag.CODE) {
jjg@1499 559 env.messages.warning(HTML, tree, "dc.tag.nested.not.allowed", "code");
jjg@1499 560 break;
jjg@1499 561 }
jjg@1499 562 }
jjg@1499 563 }
jjg@1499 564 return super.visitLiteral(tree, ignore);
jjg@1499 565 }
jjg@1499 566
jjg@1499 567 @Override
jjg@1455 568 public Void visitParam(ParamTree tree, Void ignore) {
jjg@1455 569 boolean typaram = tree.isTypeParameter();
jjg@1455 570 IdentifierTree nameTree = tree.getName();
jjg@1455 571 Element e = env.currElement;
jjg@1455 572 switch (e.getKind()) {
jjg@1455 573 case METHOD: case CONSTRUCTOR: {
jjg@1455 574 ExecutableElement ee = (ExecutableElement) e;
jjg@1455 575 checkParamDeclared(nameTree, typaram ? ee.getTypeParameters() : ee.getParameters());
jjg@1455 576 break;
jjg@1455 577 }
jjg@1455 578
jjg@1455 579 case CLASS: case INTERFACE: {
jjg@1455 580 TypeElement te = (TypeElement) e;
jjg@1455 581 if (typaram) {
jjg@1455 582 checkParamDeclared(nameTree, te.getTypeParameters());
jjg@1455 583 } else {
jjg@1455 584 env.messages.error(REFERENCE, tree, "dc.invalid.param");
jjg@1455 585 }
jjg@1455 586 break;
jjg@1455 587 }
jjg@1455 588
jjg@1455 589 default:
jjg@1455 590 env.messages.error(REFERENCE, tree, "dc.invalid.param");
jjg@1455 591 break;
jjg@1455 592 }
jjg@1455 593 warnIfEmpty(tree, tree.getDescription());
jjg@1455 594 return super.visitParam(tree, ignore);
jjg@1455 595 }
jjg@1455 596 // where
jjg@1455 597 private void checkParamDeclared(IdentifierTree nameTree, List<? extends Element> list) {
jjg@1455 598 Name name = nameTree.getName();
jjg@1455 599 boolean found = false;
jjg@1455 600 for (Element e: list) {
jjg@1455 601 if (name.equals(e.getSimpleName())) {
jjg@1455 602 foundParams.add(e);
jjg@1455 603 found = true;
jjg@1455 604 }
jjg@1455 605 }
jjg@1455 606 if (!found)
jjg@1455 607 env.messages.error(REFERENCE, nameTree, "dc.param.name.not.found");
jjg@1455 608 }
jjg@1455 609
jjg@1455 610 private void checkParamsDocumented(List<? extends Element> list) {
jjg@1455 611 if (foundInheritDoc)
jjg@1455 612 return;
jjg@1455 613
jjg@1455 614 for (Element e: list) {
jjg@1455 615 if (!foundParams.contains(e)) {
jjg@1455 616 CharSequence paramName = (e.getKind() == ElementKind.TYPE_PARAMETER)
jjg@1455 617 ? "<" + e.getSimpleName() + ">"
jjg@1455 618 : e.getSimpleName();
jjg@1455 619 reportMissing("dc.missing.param", paramName);
jjg@1455 620 }
jjg@1455 621 }
jjg@1455 622 }
jjg@1455 623
jjg@1455 624 @Override
jjg@1455 625 public Void visitReference(ReferenceTree tree, Void ignore) {
jjg@1455 626 Element e = env.trees.getElement(env.currPath, tree);
jjg@1455 627 if (e == null)
jjg@1455 628 env.messages.error(REFERENCE, tree, "dc.ref.not.found");
jjg@1455 629 return super.visitReference(tree, ignore);
jjg@1455 630 }
jjg@1455 631
jjg@1455 632 @Override
jjg@1455 633 public Void visitReturn(ReturnTree tree, Void ignore) {
jjg@1455 634 Element e = env.trees.getElement(env.currPath);
jjg@1455 635 if (e.getKind() != ElementKind.METHOD
jjg@1455 636 || ((ExecutableElement) e).getReturnType().getKind() == TypeKind.VOID)
jjg@1455 637 env.messages.error(REFERENCE, tree, "dc.invalid.return");
jjg@1455 638 foundReturn = true;
jjg@1455 639 warnIfEmpty(tree, tree.getDescription());
jjg@1455 640 return super.visitReturn(tree, ignore);
jjg@1455 641 }
jjg@1455 642
jjg@1455 643 @Override
jjg@1455 644 public Void visitSerialData(SerialDataTree tree, Void ignore) {
jjg@1455 645 warnIfEmpty(tree, tree.getDescription());
jjg@1455 646 return super.visitSerialData(tree, ignore);
jjg@1455 647 }
jjg@1455 648
jjg@1455 649 @Override
jjg@1455 650 public Void visitSerialField(SerialFieldTree tree, Void ignore) {
jjg@1455 651 warnIfEmpty(tree, tree.getDescription());
jjg@1455 652 return super.visitSerialField(tree, ignore);
jjg@1455 653 }
jjg@1455 654
jjg@1455 655 @Override
jjg@1455 656 public Void visitSince(SinceTree tree, Void ignore) {
jjg@1455 657 warnIfEmpty(tree, tree.getBody());
jjg@1455 658 return super.visitSince(tree, ignore);
jjg@1455 659 }
jjg@1455 660
jjg@1455 661 @Override
jjg@1455 662 public Void visitThrows(ThrowsTree tree, Void ignore) {
jjg@1455 663 ReferenceTree exName = tree.getExceptionName();
jjg@1455 664 Element ex = env.trees.getElement(env.currPath, exName);
jjg@1455 665 if (ex == null) {
jjg@1455 666 env.messages.error(REFERENCE, tree, "dc.ref.not.found");
jjg@1455 667 } else if (ex.asType().getKind() == TypeKind.DECLARED
jjg@1455 668 && env.types.isAssignable(ex.asType(), env.java_lang_Throwable)) {
jjg@1455 669 switch (env.currElement.getKind()) {
jjg@1455 670 case CONSTRUCTOR:
jjg@1455 671 case METHOD:
jjg@1455 672 if (isCheckedException(ex.asType())) {
jjg@1455 673 ExecutableElement ee = (ExecutableElement) env.currElement;
jjg@1455 674 checkThrowsDeclared(exName, ex.asType(), ee.getThrownTypes());
jjg@1455 675 }
jjg@1455 676 break;
jjg@1455 677 default:
jjg@1455 678 env.messages.error(REFERENCE, tree, "dc.invalid.throws");
jjg@1455 679 }
jjg@1455 680 } else {
jjg@1455 681 env.messages.error(REFERENCE, tree, "dc.invalid.throws");
jjg@1455 682 }
jjg@1455 683 warnIfEmpty(tree, tree.getDescription());
jjg@1455 684 return scan(tree.getDescription(), ignore);
jjg@1455 685 }
jjg@1455 686
jjg@1455 687 private void checkThrowsDeclared(ReferenceTree tree, TypeMirror t, List<? extends TypeMirror> list) {
jjg@1455 688 boolean found = false;
jjg@1455 689 for (TypeMirror tl : list) {
jjg@1455 690 if (env.types.isAssignable(t, tl)) {
jjg@1455 691 foundThrows.add(tl);
jjg@1455 692 found = true;
jjg@1455 693 }
jjg@1455 694 }
jjg@1455 695 if (!found)
jjg@1455 696 env.messages.error(REFERENCE, tree, "dc.exception.not.thrown", t);
jjg@1455 697 }
jjg@1455 698
jjg@1455 699 private void checkThrowsDocumented(List<? extends TypeMirror> list) {
jjg@1455 700 if (foundInheritDoc)
jjg@1455 701 return;
jjg@1455 702
jjg@1455 703 for (TypeMirror tl: list) {
jjg@1455 704 if (isCheckedException(tl) && !foundThrows.contains(tl))
jjg@1455 705 reportMissing("dc.missing.throws", tl);
jjg@1455 706 }
jjg@1455 707 }
jjg@1455 708
jjg@1455 709 @Override
jjg@1455 710 public Void visitVersion(VersionTree tree, Void ignore) {
jjg@1455 711 warnIfEmpty(tree, tree.getBody());
jjg@1455 712 return super.visitVersion(tree, ignore);
jjg@1455 713 }
jjg@1455 714
jjg@1455 715 @Override
jjg@1455 716 public Void visitErroneous(ErroneousTree tree, Void ignore) {
jjg@1455 717 env.messages.error(SYNTAX, tree, null, tree.getDiagnostic().getMessage(null));
jjg@1455 718 return null;
jjg@1455 719 }
jjg@1455 720 // </editor-fold>
jjg@1455 721
jjg@1455 722 // <editor-fold defaultstate="collapsed" desc="Utility methods">
jjg@1455 723
jjg@1455 724 private boolean isCheckedException(TypeMirror t) {
jjg@1455 725 return !(env.types.isAssignable(t, env.java_lang_Error)
jjg@1455 726 || env.types.isAssignable(t, env.java_lang_RuntimeException));
jjg@1455 727 }
jjg@1455 728
jjg@1455 729 private boolean isSynthetic() {
jjg@1455 730 switch (env.currElement.getKind()) {
jjg@1455 731 case CONSTRUCTOR:
jjg@1455 732 // A synthetic default constructor has the same pos as the
jjg@1455 733 // enclosing class
jjg@1455 734 TreePath p = env.currPath;
jjg@1455 735 return env.getPos(p) == env.getPos(p.getParentPath());
jjg@1455 736 }
jjg@1455 737 return false;
jjg@1455 738 }
jjg@1455 739
jjg@1455 740 void markEnclosingTag(Flag flag) {
jjg@1455 741 TagStackItem top = tagStack.peek();
jjg@1455 742 if (top != null)
jjg@1455 743 top.flags.add(flag);
jjg@1455 744 }
jjg@1455 745
jjg@1455 746 String toString(TreePath p) {
jjg@1455 747 StringBuilder sb = new StringBuilder("TreePath[");
jjg@1455 748 toString(p, sb);
jjg@1455 749 sb.append("]");
jjg@1455 750 return sb.toString();
jjg@1455 751 }
jjg@1455 752
jjg@1455 753 void toString(TreePath p, StringBuilder sb) {
jjg@1455 754 TreePath parent = p.getParentPath();
jjg@1455 755 if (parent != null) {
jjg@1455 756 toString(parent, sb);
jjg@1455 757 sb.append(",");
jjg@1455 758 }
jjg@1455 759 sb.append(p.getLeaf().getKind()).append(":").append(env.getPos(p)).append(":S").append(env.getStartPos(p));
jjg@1455 760 }
jjg@1455 761
jjg@1455 762 void warnIfEmpty(DocTree tree, List<? extends DocTree> list) {
jjg@1455 763 for (DocTree d: list) {
jjg@1455 764 switch (d.getKind()) {
jjg@1455 765 case TEXT:
jjg@1455 766 if (!((TextTree) d).getBody().trim().isEmpty())
jjg@1455 767 return;
jjg@1455 768 break;
jjg@1455 769 default:
jjg@1455 770 return;
jjg@1455 771 }
jjg@1455 772 }
jjg@1455 773 env.messages.warning(SYNTAX, tree, "dc.empty", tree.getKind().tagName);
jjg@1455 774 }
jjg@1455 775 // </editor-fold>
jjg@1455 776
jjg@1455 777 }

mercurial