src/share/classes/com/sun/tools/doclint/Checker.java

Tue, 24 Dec 2013 09:17:37 -0800

author
ksrini
date
Tue, 24 Dec 2013 09:17:37 -0800
changeset 2227
998b10c43157
parent 2169
667843bd2193
child 2413
fe033d997ddf
permissions
-rw-r--r--

8029230: Update copyright year to match last edit in jdk8 langtools repository for 2013
Reviewed-by: ksrini
Contributed-by: steve.sides@oracle.com

jjg@1455 1 /*
jjg@1495 2 * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
jjg@1455 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
jjg@1455 4 *
jjg@1455 5 * This code is free software; you can redistribute it and/or modify it
jjg@1455 6 * under the terms of the GNU General Public License version 2 only, as
jjg@1455 7 * published by the Free Software Foundation. Oracle designates this
jjg@1455 8 * particular file as subject to the "Classpath" exception as provided
jjg@1455 9 * by Oracle in the LICENSE file that accompanied this code.
jjg@1455 10 *
jjg@1455 11 * This code is distributed in the hope that it will be useful, but WITHOUT
jjg@1455 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
jjg@1455 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
jjg@1455 14 * version 2 for more details (a copy is included in the LICENSE file that
jjg@1455 15 * accompanied this code).
jjg@1455 16 *
jjg@1455 17 * You should have received a copy of the GNU General Public License version
jjg@1455 18 * 2 along with this work; if not, write to the Free Software Foundation,
jjg@1455 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
jjg@1455 20 *
jjg@1455 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
jjg@1455 22 * or visit www.oracle.com if you need additional information or have any
jjg@1455 23 * questions.
jjg@1455 24 */
jjg@1455 25
jjg@1455 26 package com.sun.tools.doclint;
jjg@1455 27
jjg@1650 28 import java.io.IOException;
jjg@1650 29 import java.io.StringWriter;
jjg@1455 30 import java.net.URI;
jjg@1650 31 import java.net.URISyntaxException;
jjg@1455 32 import java.util.Deque;
jjg@1455 33 import java.util.EnumSet;
jjg@1912 34 import java.util.HashMap;
jjg@1455 35 import java.util.HashSet;
jjg@1455 36 import java.util.LinkedList;
jjg@1455 37 import java.util.List;
jjg@1912 38 import java.util.Map;
jjg@1455 39 import java.util.Set;
jjg@1650 40 import java.util.regex.Matcher;
jjg@1650 41 import java.util.regex.Pattern;
jjg@1455 42
jjg@1455 43 import javax.lang.model.element.Element;
jjg@1455 44 import javax.lang.model.element.ElementKind;
jjg@1455 45 import javax.lang.model.element.ExecutableElement;
jjg@1455 46 import javax.lang.model.element.Name;
jjg@2053 47 import javax.lang.model.element.VariableElement;
jjg@1455 48 import javax.lang.model.type.TypeKind;
jjg@1455 49 import javax.lang.model.type.TypeMirror;
jjg@1455 50 import javax.tools.Diagnostic.Kind;
jjg@1912 51 import javax.tools.JavaFileObject;
jjg@1455 52
jjg@1455 53 import com.sun.source.doctree.AttributeTree;
jjg@1455 54 import com.sun.source.doctree.AuthorTree;
jjg@1455 55 import com.sun.source.doctree.DocCommentTree;
jjg@1650 56 import com.sun.source.doctree.DocRootTree;
jjg@1455 57 import com.sun.source.doctree.DocTree;
jjg@1455 58 import com.sun.source.doctree.EndElementTree;
jjg@1455 59 import com.sun.source.doctree.EntityTree;
jjg@1455 60 import com.sun.source.doctree.ErroneousTree;
jjg@1455 61 import com.sun.source.doctree.IdentifierTree;
jjg@1455 62 import com.sun.source.doctree.InheritDocTree;
jjg@1650 63 import com.sun.source.doctree.LinkTree;
jjg@1650 64 import com.sun.source.doctree.LiteralTree;
jjg@1455 65 import com.sun.source.doctree.ParamTree;
jjg@1455 66 import com.sun.source.doctree.ReferenceTree;
jjg@1455 67 import com.sun.source.doctree.ReturnTree;
jjg@1455 68 import com.sun.source.doctree.SerialDataTree;
jjg@1455 69 import com.sun.source.doctree.SerialFieldTree;
jjg@1455 70 import com.sun.source.doctree.SinceTree;
jjg@1455 71 import com.sun.source.doctree.StartElementTree;
jjg@1455 72 import com.sun.source.doctree.TextTree;
jjg@1455 73 import com.sun.source.doctree.ThrowsTree;
bpatel@2169 74 import com.sun.source.doctree.UnknownBlockTagTree;
bpatel@2169 75 import com.sun.source.doctree.UnknownInlineTagTree;
jjg@1650 76 import com.sun.source.doctree.ValueTree;
jjg@1455 77 import com.sun.source.doctree.VersionTree;
jlahoda@1726 78 import com.sun.source.util.DocTreePath;
jlahoda@1726 79 import com.sun.source.util.DocTreePathScanner;
jjg@1455 80 import com.sun.source.util.TreePath;
jjg@1455 81 import com.sun.tools.doclint.HtmlTag.AttrKind;
jjg@1650 82 import com.sun.tools.javac.tree.DocPretty;
jjg@1455 83 import static com.sun.tools.doclint.Messages.Group.*;
jjg@1455 84
jjg@1455 85
jjg@1455 86 /**
jjg@1455 87 * Validate a doc comment.
jjg@1455 88 *
jjg@1455 89 * <p><b>This is NOT part of any supported API.
jjg@1455 90 * If you write code that depends on this, you do so at your own
jjg@1455 91 * risk. This code and its internal interfaces are subject to change
jjg@1455 92 * or deletion without notice.</b></p>
jjg@1455 93 */
jlahoda@1726 94 public class Checker extends DocTreePathScanner<Void, Void> {
jjg@1455 95 final Env env;
jjg@1455 96
jjg@1912 97 Set<Element> foundParams = new HashSet<>();
jjg@1912 98 Set<TypeMirror> foundThrows = new HashSet<>();
jjg@2052 99 Map<Element, Set<String>> foundAnchors = new HashMap<>();
jjg@1455 100 boolean foundInheritDoc = false;
jjg@1455 101 boolean foundReturn = false;
jjg@1455 102
jjg@1506 103 public enum Flag {
jjg@1455 104 TABLE_HAS_CAPTION,
jjg@1455 105 HAS_ELEMENT,
jjg@1650 106 HAS_INLINE_TAG,
jjg@1507 107 HAS_TEXT,
jjg@1507 108 REPORTED_BAD_INLINE
jjg@1455 109 }
jjg@1455 110
jjg@1455 111 static class TagStackItem {
jjg@1455 112 final DocTree tree; // typically, but not always, StartElementTree
jjg@1455 113 final HtmlTag tag;
jjg@1455 114 final Set<HtmlTag.Attr> attrs;
jjg@1455 115 final Set<Flag> flags;
jjg@1455 116 TagStackItem(DocTree tree, HtmlTag tag) {
jjg@1455 117 this.tree = tree;
jjg@1455 118 this.tag = tag;
jjg@1455 119 attrs = EnumSet.noneOf(HtmlTag.Attr.class);
jjg@1455 120 flags = EnumSet.noneOf(Flag.class);
jjg@1455 121 }
jjg@1455 122 @Override
jjg@1455 123 public String toString() {
jjg@1455 124 return String.valueOf(tag);
jjg@1455 125 }
jjg@1455 126 }
jjg@1455 127
jjg@1455 128 private Deque<TagStackItem> tagStack; // TODO: maybe want to record starting tree as well
jjg@1455 129 private HtmlTag currHeaderTag;
jjg@1455 130
jjg@1668 131 private final int implicitHeaderLevel;
jjg@1668 132
jjg@1455 133 // <editor-fold defaultstate="collapsed" desc="Top level">
jjg@1455 134
jjg@1455 135 Checker(Env env) {
jjg@1455 136 env.getClass();
jjg@1455 137 this.env = env;
jjg@1912 138 tagStack = new LinkedList<>();
jjg@1668 139 implicitHeaderLevel = env.implicitHeaderLevel;
jjg@1455 140 }
jjg@1455 141
jjg@1455 142 public Void scan(DocCommentTree tree, TreePath p) {
jjg@1455 143 env.setCurrent(p, tree);
jjg@1455 144
jjg@1455 145 boolean isOverridingMethod = !env.currOverriddenMethods.isEmpty();
jjg@1455 146
jjg@1915 147 if (p.getLeaf() == p.getCompilationUnit()) {
jjg@1915 148 // If p points to a compilation unit, the implied declaration is the
jjg@1915 149 // package declaration (if any) for the compilation unit.
jjg@1915 150 // Handle this case specially, because doc comments are only
jjg@1915 151 // expected in package-info files.
jjg@1915 152 JavaFileObject fo = p.getCompilationUnit().getSourceFile();
jjg@1915 153 boolean isPkgInfo = fo.isNameCompatible("package-info", JavaFileObject.Kind.SOURCE);
jjg@1915 154 if (tree == null) {
jjg@1915 155 if (isPkgInfo)
jjg@1915 156 reportMissing("dc.missing.comment");
jjg@1915 157 return null;
jjg@1915 158 } else {
jjg@1915 159 if (!isPkgInfo)
jjg@1915 160 reportReference("dc.unexpected.comment");
jjg@1915 161 }
jjg@1915 162 } else {
jjg@1915 163 if (tree == null) {
jjg@1915 164 if (!isSynthetic() && !isOverridingMethod)
jjg@1915 165 reportMissing("dc.missing.comment");
jjg@1915 166 return null;
jjg@1915 167 }
jjg@1455 168 }
jjg@1455 169
jjg@1455 170 tagStack.clear();
jjg@1455 171 currHeaderTag = null;
jjg@1455 172
jjg@1455 173 foundParams.clear();
jjg@1455 174 foundThrows.clear();
jjg@1455 175 foundInheritDoc = false;
jjg@1455 176 foundReturn = false;
jjg@1455 177
jlahoda@1726 178 scan(new DocTreePath(p, tree), null);
jjg@1455 179
jjg@1455 180 if (!isOverridingMethod) {
jjg@1455 181 switch (env.currElement.getKind()) {
jjg@1455 182 case METHOD:
jjg@1455 183 case CONSTRUCTOR: {
jjg@1455 184 ExecutableElement ee = (ExecutableElement) env.currElement;
jjg@1455 185 checkParamsDocumented(ee.getTypeParameters());
jjg@1455 186 checkParamsDocumented(ee.getParameters());
jjg@1455 187 switch (ee.getReturnType().getKind()) {
jjg@1455 188 case VOID:
jjg@1455 189 case NONE:
jjg@1455 190 break;
jjg@1455 191 default:
jjg@1455 192 if (!foundReturn
jjg@1455 193 && !foundInheritDoc
jjg@1455 194 && !env.types.isSameType(ee.getReturnType(), env.java_lang_Void)) {
jjg@1455 195 reportMissing("dc.missing.return");
jjg@1455 196 }
jjg@1455 197 }
jjg@1455 198 checkThrowsDocumented(ee.getThrownTypes());
jjg@1455 199 }
jjg@1455 200 }
jjg@1455 201 }
jjg@1455 202
jjg@1455 203 return null;
jjg@1455 204 }
jjg@1455 205
jjg@1455 206 private void reportMissing(String code, Object... args) {
jjg@1455 207 env.messages.report(MISSING, Kind.WARNING, env.currPath.getLeaf(), code, args);
jjg@1455 208 }
jjg@1455 209
jjg@1915 210 private void reportReference(String code, Object... args) {
jjg@1915 211 env.messages.report(REFERENCE, Kind.WARNING, env.currPath.getLeaf(), code, args);
jjg@1915 212 }
jjg@1915 213
jjg@1455 214 @Override
jjg@1455 215 public Void visitDocComment(DocCommentTree tree, Void ignore) {
jjg@1455 216 super.visitDocComment(tree, ignore);
jjg@1455 217 for (TagStackItem tsi: tagStack) {
jjg@2110 218 warnIfEmpty(tsi, null);
jjg@1455 219 if (tsi.tree.getKind() == DocTree.Kind.START_ELEMENT
jjg@1455 220 && tsi.tag.endKind == HtmlTag.EndKind.REQUIRED) {
jjg@1455 221 StartElementTree t = (StartElementTree) tsi.tree;
jjg@1455 222 env.messages.error(HTML, t, "dc.tag.not.closed", t.getName());
jjg@1455 223 }
jjg@1455 224 }
jjg@1455 225 return null;
jjg@1455 226 }
jjg@1455 227 // </editor-fold>
jjg@1455 228
jjg@1455 229 // <editor-fold defaultstate="collapsed" desc="Text and entities.">
jjg@1455 230
jjg@1455 231 @Override
jjg@1455 232 public Void visitText(TextTree tree, Void ignore) {
jjg@1507 233 if (hasNonWhitespace(tree)) {
jjg@1507 234 checkAllowsText(tree);
jjg@1455 235 markEnclosingTag(Flag.HAS_TEXT);
jjg@1455 236 }
jjg@1455 237 return null;
jjg@1455 238 }
jjg@1455 239
jjg@1455 240 @Override
jjg@1455 241 public Void visitEntity(EntityTree tree, Void ignore) {
jjg@1507 242 checkAllowsText(tree);
jjg@1455 243 markEnclosingTag(Flag.HAS_TEXT);
jjg@1455 244 String name = tree.getName().toString();
jjg@1455 245 if (name.startsWith("#")) {
jjg@1455 246 int v = name.toLowerCase().startsWith("#x")
jjg@1455 247 ? Integer.parseInt(name.substring(2), 16)
jjg@1455 248 : Integer.parseInt(name.substring(1), 10);
jjg@1455 249 if (!Entity.isValid(v)) {
jjg@1455 250 env.messages.error(HTML, tree, "dc.entity.invalid", name);
jjg@1455 251 }
jjg@1455 252 } else if (!Entity.isValid(name)) {
jjg@1455 253 env.messages.error(HTML, tree, "dc.entity.invalid", name);
jjg@1455 254 }
jjg@1455 255 return null;
jjg@1455 256 }
jjg@1455 257
jjg@1507 258 void checkAllowsText(DocTree tree) {
jjg@1507 259 TagStackItem top = tagStack.peek();
jjg@1507 260 if (top != null
jjg@1507 261 && top.tree.getKind() == DocTree.Kind.START_ELEMENT
jjg@1507 262 && !top.tag.acceptsText()) {
jjg@1507 263 if (top.flags.add(Flag.REPORTED_BAD_INLINE)) {
jjg@1507 264 env.messages.error(HTML, tree, "dc.text.not.allowed",
jjg@1507 265 ((StartElementTree) top.tree).getName());
jjg@1507 266 }
jjg@1507 267 }
jjg@1507 268 }
jjg@1507 269
jjg@1455 270 // </editor-fold>
jjg@1455 271
jjg@1455 272 // <editor-fold defaultstate="collapsed" desc="HTML elements">
jjg@1455 273
jjg@1455 274 @Override
jjg@1455 275 public Void visitStartElement(StartElementTree tree, Void ignore) {
jjg@1455 276 final Name treeName = tree.getName();
jjg@1455 277 final HtmlTag t = HtmlTag.get(treeName);
jjg@1455 278 if (t == null) {
jjg@1455 279 env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
jjg@1455 280 } else {
jjg@1552 281 boolean done = false;
jjg@1507 282 for (TagStackItem tsi: tagStack) {
jjg@1507 283 if (tsi.tag.accepts(t)) {
jjg@2110 284 while (tagStack.peek() != tsi) {
jjg@2110 285 warnIfEmpty(tagStack.peek(), null);
jjg@2110 286 tagStack.pop();
jjg@2110 287 }
jjg@1552 288 done = true;
jjg@1507 289 break;
jjg@1552 290 } else if (tsi.tag.endKind != HtmlTag.EndKind.OPTIONAL) {
jjg@1552 291 done = true;
jjg@1507 292 break;
jjg@1552 293 }
jjg@1552 294 }
jjg@1552 295 if (!done && HtmlTag.BODY.accepts(t)) {
jjg@2110 296 while (!tagStack.isEmpty()) {
jjg@2110 297 warnIfEmpty(tagStack.peek(), null);
jjg@2110 298 tagStack.pop();
jjg@2110 299 }
jjg@1507 300 }
jjg@1507 301
jjg@2110 302 markEnclosingTag(Flag.HAS_ELEMENT);
jjg@1507 303 checkStructure(tree, t);
jjg@1507 304
jjg@1455 305 // tag specific checks
jjg@1455 306 switch (t) {
jjg@1455 307 // check for out of sequence headers, such as <h1>...</h1> <h3>...</h3>
jjg@1455 308 case H1: case H2: case H3: case H4: case H5: case H6:
jjg@1455 309 checkHeader(tree, t);
jjg@1455 310 break;
jjg@1455 311 }
jjg@1455 312
jjg@1455 313 if (t.flags.contains(HtmlTag.Flag.NO_NEST)) {
jjg@1455 314 for (TagStackItem i: tagStack) {
jjg@1455 315 if (t == i.tag) {
jjg@1455 316 env.messages.warning(HTML, tree, "dc.tag.nested.not.allowed", treeName);
jjg@1455 317 break;
jjg@1455 318 }
jjg@1455 319 }
jjg@1455 320 }
jjg@1455 321 }
jjg@1455 322
jjg@1455 323 // check for self closing tags, such as <a id="name"/>
jjg@1455 324 if (tree.isSelfClosing()) {
jjg@1455 325 env.messages.error(HTML, tree, "dc.tag.self.closing", treeName);
jjg@1455 326 }
jjg@1455 327
jjg@1455 328 try {
jjg@1455 329 TagStackItem parent = tagStack.peek();
jjg@1455 330 TagStackItem top = new TagStackItem(tree, t);
jjg@1455 331 tagStack.push(top);
jjg@1455 332
jjg@1455 333 super.visitStartElement(tree, ignore);
jjg@1455 334
jjg@1455 335 // handle attributes that may or may not have been found in start element
jjg@1455 336 if (t != null) {
jjg@1455 337 switch (t) {
jjg@1455 338 case CAPTION:
jjg@1455 339 if (parent != null && parent.tag == HtmlTag.TABLE)
jjg@1455 340 parent.flags.add(Flag.TABLE_HAS_CAPTION);
jjg@1455 341 break;
jjg@1455 342
jjg@1455 343 case IMG:
jjg@1455 344 if (!top.attrs.contains(HtmlTag.Attr.ALT))
jjg@1455 345 env.messages.error(ACCESSIBILITY, tree, "dc.no.alt.attr.for.image");
jjg@1455 346 break;
jjg@1455 347 }
jjg@1455 348 }
jjg@1455 349
jjg@1455 350 return null;
jjg@1455 351 } finally {
jjg@1455 352
jjg@1455 353 if (t == null || t.endKind == HtmlTag.EndKind.NONE)
jjg@1455 354 tagStack.pop();
jjg@1455 355 }
jjg@1455 356 }
jjg@1455 357
jjg@1507 358 private void checkStructure(StartElementTree tree, HtmlTag t) {
jjg@1507 359 Name treeName = tree.getName();
jjg@1507 360 TagStackItem top = tagStack.peek();
jjg@1507 361 switch (t.blockType) {
jjg@1507 362 case BLOCK:
jjg@1507 363 if (top == null || top.tag.accepts(t))
jjg@1507 364 return;
jjg@1507 365
jjg@1507 366 switch (top.tree.getKind()) {
jjg@1507 367 case START_ELEMENT: {
jjg@1507 368 if (top.tag.blockType == HtmlTag.BlockType.INLINE) {
jjg@1507 369 Name name = ((StartElementTree) top.tree).getName();
jjg@1507 370 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.element",
jjg@1507 371 treeName, name);
jjg@1507 372 return;
jjg@1507 373 }
jjg@1507 374 }
jjg@1507 375 break;
jjg@1507 376
jjg@1507 377 case LINK:
jjg@1507 378 case LINK_PLAIN: {
jjg@1507 379 String name = top.tree.getKind().tagName;
jjg@1507 380 env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.tag",
jjg@1507 381 treeName, name);
jjg@1507 382 return;
jjg@1507 383 }
jjg@1507 384 }
jjg@1507 385 break;
jjg@1507 386
jjg@1507 387 case INLINE:
jjg@1507 388 if (top == null || top.tag.accepts(t))
jjg@1507 389 return;
jjg@1507 390 break;
jjg@1507 391
jjg@1507 392 case LIST_ITEM:
jjg@1507 393 case TABLE_ITEM:
jjg@1507 394 if (top != null) {
jjg@1507 395 // reset this flag so subsequent bad inline content gets reported
jjg@1507 396 top.flags.remove(Flag.REPORTED_BAD_INLINE);
jjg@1507 397 if (top.tag.accepts(t))
jjg@1507 398 return;
jjg@1507 399 }
jjg@1507 400 break;
jjg@1507 401
jjg@1507 402 case OTHER:
jjg@1507 403 env.messages.error(HTML, tree, "dc.tag.not.allowed", treeName);
jjg@1507 404 return;
jjg@1507 405 }
jjg@1507 406
jjg@1507 407 env.messages.error(HTML, tree, "dc.tag.not.allowed.here", treeName);
jjg@1507 408 }
jjg@1507 409
jjg@1455 410 private void checkHeader(StartElementTree tree, HtmlTag tag) {
jjg@1455 411 // verify the new tag
jjg@1455 412 if (getHeaderLevel(tag) > getHeaderLevel(currHeaderTag) + 1) {
jjg@1455 413 if (currHeaderTag == null) {
jjg@1455 414 env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.1", tag);
jjg@1455 415 } else {
jjg@1455 416 env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.2",
jjg@1455 417 tag, currHeaderTag);
jjg@1455 418 }
jjg@1455 419 }
jjg@1455 420
jjg@1455 421 currHeaderTag = tag;
jjg@1455 422 }
jjg@1455 423
jjg@1455 424 private int getHeaderLevel(HtmlTag tag) {
jjg@1455 425 if (tag == null)
jjg@1668 426 return implicitHeaderLevel;
jjg@1455 427 switch (tag) {
jjg@1455 428 case H1: return 1;
jjg@1455 429 case H2: return 2;
jjg@1455 430 case H3: return 3;
jjg@1455 431 case H4: return 4;
jjg@1455 432 case H5: return 5;
jjg@1455 433 case H6: return 6;
jjg@1455 434 default: throw new IllegalArgumentException();
jjg@1455 435 }
jjg@1455 436 }
jjg@1455 437
jjg@1455 438 @Override
jjg@1455 439 public Void visitEndElement(EndElementTree tree, Void ignore) {
jjg@1455 440 final Name treeName = tree.getName();
jjg@1455 441 final HtmlTag t = HtmlTag.get(treeName);
jjg@1455 442 if (t == null) {
jjg@1455 443 env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
jjg@1455 444 } else if (t.endKind == HtmlTag.EndKind.NONE) {
jjg@1455 445 env.messages.error(HTML, tree, "dc.tag.end.not.permitted", treeName);
jjg@1455 446 } else {
jjg@1499 447 boolean done = false;
jjg@1455 448 while (!tagStack.isEmpty()) {
jjg@1455 449 TagStackItem top = tagStack.peek();
jjg@1455 450 if (t == top.tag) {
jjg@1455 451 switch (t) {
jjg@1455 452 case TABLE:
jjg@1455 453 if (!top.attrs.contains(HtmlTag.Attr.SUMMARY)
jjg@1455 454 && !top.flags.contains(Flag.TABLE_HAS_CAPTION)) {
jjg@1455 455 env.messages.error(ACCESSIBILITY, tree,
jjg@1455 456 "dc.no.summary.or.caption.for.table");
jjg@1455 457 }
jjg@1455 458 }
jjg@2110 459 warnIfEmpty(top, tree);
jjg@1455 460 tagStack.pop();
jjg@1499 461 done = true;
jjg@1455 462 break;
jjg@1455 463 } else if (top.tag == null || top.tag.endKind != HtmlTag.EndKind.REQUIRED) {
jjg@1455 464 tagStack.pop();
jjg@1455 465 } else {
jjg@1455 466 boolean found = false;
jjg@1455 467 for (TagStackItem si: tagStack) {
jjg@1455 468 if (si.tag == t) {
jjg@1455 469 found = true;
jjg@1455 470 break;
jjg@1455 471 }
jjg@1455 472 }
jjg@1455 473 if (found && top.tree.getKind() == DocTree.Kind.START_ELEMENT) {
jjg@1455 474 env.messages.error(HTML, top.tree, "dc.tag.start.unmatched",
jjg@1455 475 ((StartElementTree) top.tree).getName());
jjg@1455 476 tagStack.pop();
jjg@1455 477 } else {
jjg@1455 478 env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
jjg@1499 479 done = true;
jjg@1455 480 break;
jjg@1455 481 }
jjg@1455 482 }
jjg@1455 483 }
jjg@1499 484
jjg@1499 485 if (!done && tagStack.isEmpty()) {
jjg@1499 486 env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
jjg@1499 487 }
jjg@1455 488 }
jjg@1455 489
jjg@1455 490 return super.visitEndElement(tree, ignore);
jjg@1455 491 }
jjg@2110 492
jjg@2110 493 void warnIfEmpty(TagStackItem tsi, DocTree endTree) {
jjg@2110 494 if (tsi.tag != null && tsi.tree instanceof StartElementTree) {
jjg@2110 495 if (tsi.tag.flags.contains(HtmlTag.Flag.EXPECT_CONTENT)
jjg@2110 496 && !tsi.flags.contains(Flag.HAS_TEXT)
jjg@2110 497 && !tsi.flags.contains(Flag.HAS_ELEMENT)
jjg@2110 498 && !tsi.flags.contains(Flag.HAS_INLINE_TAG)) {
jjg@2110 499 DocTree tree = (endTree != null) ? endTree : tsi.tree;
jjg@2110 500 Name treeName = ((StartElementTree) tsi.tree).getName();
jjg@2110 501 env.messages.warning(HTML, tree, "dc.tag.empty", treeName);
jjg@2110 502 }
jjg@2110 503 }
jjg@2110 504 }
jjg@2110 505
jjg@1455 506 // </editor-fold>
jjg@1455 507
jjg@1455 508 // <editor-fold defaultstate="collapsed" desc="HTML attributes">
jjg@1455 509
jjg@1455 510 @Override @SuppressWarnings("fallthrough")
jjg@1455 511 public Void visitAttribute(AttributeTree tree, Void ignore) {
jjg@1455 512 HtmlTag currTag = tagStack.peek().tag;
jjg@1455 513 if (currTag != null) {
jjg@1455 514 Name name = tree.getName();
jjg@1455 515 HtmlTag.Attr attr = currTag.getAttr(name);
jjg@1455 516 if (attr != null) {
jjg@1455 517 boolean first = tagStack.peek().attrs.add(attr);
jjg@1455 518 if (!first)
jjg@1455 519 env.messages.error(HTML, tree, "dc.attr.repeated", name);
jjg@1455 520 }
jjg@1455 521 AttrKind k = currTag.getAttrKind(name);
jjg@1455 522 switch (k) {
jjg@1455 523 case OK:
jjg@1455 524 break;
jjg@1455 525
jjg@1455 526 case INVALID:
jjg@1455 527 env.messages.error(HTML, tree, "dc.attr.unknown", name);
jjg@1455 528 break;
jjg@1455 529
jjg@1455 530 case OBSOLETE:
jjg@1455 531 env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete", name);
jjg@1455 532 break;
jjg@1455 533
jjg@1455 534 case USE_CSS:
jjg@1455 535 env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete.use.css", name);
jjg@1455 536 break;
jjg@1455 537 }
jjg@1455 538
jjg@1455 539 if (attr != null) {
jjg@1455 540 switch (attr) {
jjg@1455 541 case NAME:
jjg@1455 542 if (currTag != HtmlTag.A) {
jjg@1455 543 break;
jjg@1455 544 }
jjg@1495 545 // fallthrough
jjg@1455 546 case ID:
jjg@1455 547 String value = getAttrValue(tree);
jjg@1495 548 if (value == null) {
jjg@1495 549 env.messages.error(HTML, tree, "dc.anchor.value.missing");
jjg@1495 550 } else {
jjg@1495 551 if (!validName.matcher(value).matches()) {
jjg@1495 552 env.messages.error(HTML, tree, "dc.invalid.anchor", value);
jjg@1495 553 }
jjg@1912 554 if (!checkAnchor(value)) {
jjg@1495 555 env.messages.error(HTML, tree, "dc.anchor.already.defined", value);
jjg@1495 556 }
jjg@1455 557 }
jjg@1455 558 break;
jjg@1455 559
jjg@1455 560 case HREF:
jjg@1455 561 if (currTag == HtmlTag.A) {
jjg@1455 562 String v = getAttrValue(tree);
jjg@1455 563 if (v == null || v.isEmpty()) {
jjg@1455 564 env.messages.error(HTML, tree, "dc.attr.lacks.value");
jjg@1455 565 } else {
jjg@1455 566 Matcher m = docRoot.matcher(v);
jjg@1455 567 if (m.matches()) {
jjg@1455 568 String rest = m.group(2);
jjg@1455 569 if (!rest.isEmpty())
jjg@1455 570 checkURI(tree, rest);
jjg@1455 571 } else {
jjg@1455 572 checkURI(tree, v);
jjg@1455 573 }
jjg@1455 574 }
jjg@1455 575 }
jjg@1455 576 break;
jjg@1793 577
jjg@1793 578 case VALUE:
jjg@1793 579 if (currTag == HtmlTag.LI) {
jjg@1793 580 String v = getAttrValue(tree);
jjg@1793 581 if (v == null || v.isEmpty()) {
jjg@1793 582 env.messages.error(HTML, tree, "dc.attr.lacks.value");
jjg@1793 583 } else if (!validNumber.matcher(v).matches()) {
jjg@1793 584 env.messages.error(HTML, tree, "dc.attr.not.number");
jjg@1793 585 }
jjg@1793 586 }
jjg@1793 587 break;
jjg@1455 588 }
jjg@1455 589 }
jjg@1455 590 }
jjg@1455 591
jjg@1455 592 // TODO: basic check on value
jjg@1455 593
jjg@1455 594 return super.visitAttribute(tree, ignore);
jjg@1455 595 }
jjg@1455 596
jjg@1912 597 private boolean checkAnchor(String name) {
jjg@2052 598 Element e = getEnclosingPackageOrClass(env.currElement);
jjg@2052 599 if (e == null)
jjg@2052 600 return true;
jjg@2052 601 Set<String> set = foundAnchors.get(e);
jjg@1912 602 if (set == null)
jjg@2052 603 foundAnchors.put(e, set = new HashSet<>());
jjg@1912 604 return set.add(name);
jjg@1912 605 }
jjg@1912 606
jjg@2052 607 private Element getEnclosingPackageOrClass(Element e) {
jjg@2052 608 while (e != null) {
jjg@2052 609 switch (e.getKind()) {
jjg@2052 610 case CLASS:
jjg@2052 611 case ENUM:
jjg@2052 612 case INTERFACE:
jjg@2052 613 case PACKAGE:
jjg@2052 614 return e;
jjg@2052 615 default:
jjg@2052 616 e = e.getEnclosingElement();
jjg@2052 617 }
jjg@2052 618 }
jjg@2052 619 return e;
jjg@2052 620 }
jjg@2052 621
jjg@1455 622 // http://www.w3.org/TR/html401/types.html#type-name
jjg@1455 623 private static final Pattern validName = Pattern.compile("[A-Za-z][A-Za-z0-9-_:.]*");
jjg@1455 624
jjg@1793 625 private static final Pattern validNumber = Pattern.compile("-?[0-9]+");
jjg@1793 626
jjg@1455 627 // pattern to remove leading {@docRoot}/?
jjg@1455 628 private static final Pattern docRoot = Pattern.compile("(?i)(\\{@docRoot *\\}/?)?(.*)");
jjg@1455 629
jjg@1455 630 private String getAttrValue(AttributeTree tree) {
jjg@1455 631 if (tree.getValue() == null)
jjg@1455 632 return null;
jjg@1455 633
jjg@1455 634 StringWriter sw = new StringWriter();
jjg@1455 635 try {
jjg@1455 636 new DocPretty(sw).print(tree.getValue());
jjg@1455 637 } catch (IOException e) {
jjg@1455 638 // cannot happen
jjg@1455 639 }
jjg@1455 640 // ignore potential use of entities for now
jjg@1455 641 return sw.toString();
jjg@1455 642 }
jjg@1455 643
jjg@1455 644 private void checkURI(AttributeTree tree, String uri) {
jjg@1455 645 try {
jjg@1455 646 URI u = new URI(uri);
jjg@1455 647 } catch (URISyntaxException e) {
jjg@1455 648 env.messages.error(HTML, tree, "dc.invalid.uri", uri);
jjg@1455 649 }
jjg@1455 650 }
jjg@1455 651 // </editor-fold>
jjg@1455 652
jjg@1455 653 // <editor-fold defaultstate="collapsed" desc="javadoc tags">
jjg@1455 654
jjg@1455 655 @Override
jjg@1455 656 public Void visitAuthor(AuthorTree tree, Void ignore) {
jjg@1455 657 warnIfEmpty(tree, tree.getName());
jjg@1455 658 return super.visitAuthor(tree, ignore);
jjg@1455 659 }
jjg@1455 660
jjg@1455 661 @Override
jjg@1650 662 public Void visitDocRoot(DocRootTree tree, Void ignore) {
jjg@1650 663 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1650 664 return super.visitDocRoot(tree, ignore);
jjg@1650 665 }
jjg@1650 666
jjg@1650 667 @Override
jjg@1455 668 public Void visitInheritDoc(InheritDocTree tree, Void ignore) {
jjg@1650 669 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1455 670 // TODO: verify on overridden method
jjg@1455 671 foundInheritDoc = true;
jjg@1455 672 return super.visitInheritDoc(tree, ignore);
jjg@1455 673 }
jjg@1455 674
jjg@1455 675 @Override
jjg@1455 676 public Void visitLink(LinkTree tree, Void ignore) {
jjg@1650 677 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1455 678 // simulate inline context on tag stack
jjg@1455 679 HtmlTag t = (tree.getKind() == DocTree.Kind.LINK)
jjg@1455 680 ? HtmlTag.CODE : HtmlTag.SPAN;
jjg@1455 681 tagStack.push(new TagStackItem(tree, t));
jjg@1455 682 try {
jjg@1455 683 return super.visitLink(tree, ignore);
jjg@1455 684 } finally {
jjg@1455 685 tagStack.pop();
jjg@1455 686 }
jjg@1455 687 }
jjg@1455 688
jjg@1455 689 @Override
jjg@1499 690 public Void visitLiteral(LiteralTree tree, Void ignore) {
jjg@1650 691 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1499 692 if (tree.getKind() == DocTree.Kind.CODE) {
jjg@1499 693 for (TagStackItem tsi: tagStack) {
jjg@1499 694 if (tsi.tag == HtmlTag.CODE) {
jjg@1502 695 env.messages.warning(HTML, tree, "dc.tag.code.within.code");
jjg@1499 696 break;
jjg@1499 697 }
jjg@1499 698 }
jjg@1499 699 }
jjg@1499 700 return super.visitLiteral(tree, ignore);
jjg@1499 701 }
jjg@1499 702
jjg@1499 703 @Override
jlahoda@1726 704 @SuppressWarnings("fallthrough")
jjg@1455 705 public Void visitParam(ParamTree tree, Void ignore) {
jjg@1455 706 boolean typaram = tree.isTypeParameter();
jjg@1455 707 IdentifierTree nameTree = tree.getName();
jlahoda@1726 708 Element paramElement = nameTree != null ? env.trees.getElement(new DocTreePath(getCurrentPath(), nameTree)) : null;
jlahoda@1726 709
jlahoda@1726 710 if (paramElement == null) {
jlahoda@1726 711 switch (env.currElement.getKind()) {
jlahoda@1726 712 case CLASS: case INTERFACE: {
jlahoda@1726 713 if (!typaram) {
jlahoda@1726 714 env.messages.error(REFERENCE, tree, "dc.invalid.param");
jlahoda@1726 715 break;
jlahoda@1726 716 }
jlahoda@1726 717 }
jlahoda@1726 718 case METHOD: case CONSTRUCTOR: {
jlahoda@1726 719 env.messages.error(REFERENCE, nameTree, "dc.param.name.not.found");
jlahoda@1726 720 break;
jlahoda@1726 721 }
jlahoda@1726 722
jlahoda@1726 723 default:
jlahoda@1726 724 env.messages.error(REFERENCE, tree, "dc.invalid.param");
jlahoda@1726 725 break;
jjg@1455 726 }
jlahoda@1726 727 } else {
jlahoda@1726 728 foundParams.add(paramElement);
jlahoda@1726 729 }
jjg@1455 730
jjg@1455 731 warnIfEmpty(tree, tree.getDescription());
jjg@1455 732 return super.visitParam(tree, ignore);
jjg@1455 733 }
jjg@1455 734
jjg@1455 735 private void checkParamsDocumented(List<? extends Element> list) {
jjg@1455 736 if (foundInheritDoc)
jjg@1455 737 return;
jjg@1455 738
jjg@1455 739 for (Element e: list) {
jjg@1455 740 if (!foundParams.contains(e)) {
jjg@1455 741 CharSequence paramName = (e.getKind() == ElementKind.TYPE_PARAMETER)
jjg@1455 742 ? "<" + e.getSimpleName() + ">"
jjg@1455 743 : e.getSimpleName();
jjg@1455 744 reportMissing("dc.missing.param", paramName);
jjg@1455 745 }
jjg@1455 746 }
jjg@1455 747 }
jjg@1455 748
jjg@1455 749 @Override
jjg@1455 750 public Void visitReference(ReferenceTree tree, Void ignore) {
jjg@2054 751 String sig = tree.getSignature();
jjg@2054 752 if (sig.contains("<") || sig.contains(">"))
jjg@2054 753 env.messages.error(REFERENCE, tree, "dc.type.arg.not.allowed");
jjg@2054 754
jlahoda@1726 755 Element e = env.trees.getElement(getCurrentPath());
jjg@1455 756 if (e == null)
jjg@1455 757 env.messages.error(REFERENCE, tree, "dc.ref.not.found");
jjg@1455 758 return super.visitReference(tree, ignore);
jjg@1455 759 }
jjg@1455 760
jjg@1455 761 @Override
jjg@1455 762 public Void visitReturn(ReturnTree tree, Void ignore) {
jjg@1455 763 Element e = env.trees.getElement(env.currPath);
jjg@1455 764 if (e.getKind() != ElementKind.METHOD
jjg@1455 765 || ((ExecutableElement) e).getReturnType().getKind() == TypeKind.VOID)
jjg@1455 766 env.messages.error(REFERENCE, tree, "dc.invalid.return");
jjg@1455 767 foundReturn = true;
jjg@1455 768 warnIfEmpty(tree, tree.getDescription());
jjg@1455 769 return super.visitReturn(tree, ignore);
jjg@1455 770 }
jjg@1455 771
jjg@1455 772 @Override
jjg@1455 773 public Void visitSerialData(SerialDataTree tree, Void ignore) {
jjg@1455 774 warnIfEmpty(tree, tree.getDescription());
jjg@1455 775 return super.visitSerialData(tree, ignore);
jjg@1455 776 }
jjg@1455 777
jjg@1455 778 @Override
jjg@1455 779 public Void visitSerialField(SerialFieldTree tree, Void ignore) {
jjg@1455 780 warnIfEmpty(tree, tree.getDescription());
jjg@1455 781 return super.visitSerialField(tree, ignore);
jjg@1455 782 }
jjg@1455 783
jjg@1455 784 @Override
jjg@1455 785 public Void visitSince(SinceTree tree, Void ignore) {
jjg@1455 786 warnIfEmpty(tree, tree.getBody());
jjg@1455 787 return super.visitSince(tree, ignore);
jjg@1455 788 }
jjg@1455 789
jjg@1455 790 @Override
jjg@1455 791 public Void visitThrows(ThrowsTree tree, Void ignore) {
jjg@1455 792 ReferenceTree exName = tree.getExceptionName();
jlahoda@1726 793 Element ex = env.trees.getElement(new DocTreePath(getCurrentPath(), exName));
jjg@1455 794 if (ex == null) {
jjg@1455 795 env.messages.error(REFERENCE, tree, "dc.ref.not.found");
jjg@1917 796 } else if (isThrowable(ex.asType())) {
jjg@1455 797 switch (env.currElement.getKind()) {
jjg@1455 798 case CONSTRUCTOR:
jjg@1455 799 case METHOD:
jjg@1455 800 if (isCheckedException(ex.asType())) {
jjg@1455 801 ExecutableElement ee = (ExecutableElement) env.currElement;
jjg@1455 802 checkThrowsDeclared(exName, ex.asType(), ee.getThrownTypes());
jjg@1455 803 }
jjg@1455 804 break;
jjg@1455 805 default:
jjg@1455 806 env.messages.error(REFERENCE, tree, "dc.invalid.throws");
jjg@1455 807 }
jjg@1455 808 } else {
jjg@1455 809 env.messages.error(REFERENCE, tree, "dc.invalid.throws");
jjg@1455 810 }
jjg@1455 811 warnIfEmpty(tree, tree.getDescription());
jjg@1455 812 return scan(tree.getDescription(), ignore);
jjg@1455 813 }
jjg@1455 814
jjg@1917 815 private boolean isThrowable(TypeMirror tm) {
jjg@1917 816 switch (tm.getKind()) {
jjg@1917 817 case DECLARED:
jjg@1917 818 case TYPEVAR:
jjg@1917 819 return env.types.isAssignable(tm, env.java_lang_Throwable);
jjg@1917 820 }
jjg@1917 821 return false;
jjg@1917 822 }
jjg@1917 823
jjg@1455 824 private void checkThrowsDeclared(ReferenceTree tree, TypeMirror t, List<? extends TypeMirror> list) {
jjg@1455 825 boolean found = false;
jjg@1455 826 for (TypeMirror tl : list) {
jjg@1455 827 if (env.types.isAssignable(t, tl)) {
jjg@1455 828 foundThrows.add(tl);
jjg@1455 829 found = true;
jjg@1455 830 }
jjg@1455 831 }
jjg@1455 832 if (!found)
jjg@1455 833 env.messages.error(REFERENCE, tree, "dc.exception.not.thrown", t);
jjg@1455 834 }
jjg@1455 835
jjg@1455 836 private void checkThrowsDocumented(List<? extends TypeMirror> list) {
jjg@1455 837 if (foundInheritDoc)
jjg@1455 838 return;
jjg@1455 839
jjg@1455 840 for (TypeMirror tl: list) {
jjg@1455 841 if (isCheckedException(tl) && !foundThrows.contains(tl))
jjg@1455 842 reportMissing("dc.missing.throws", tl);
jjg@1455 843 }
jjg@1455 844 }
jjg@1455 845
jjg@1455 846 @Override
bpatel@2169 847 public Void visitUnknownBlockTag(UnknownBlockTagTree tree, Void ignore) {
bpatel@2169 848 checkUnknownTag(tree, tree.getTagName());
bpatel@2169 849 return super.visitUnknownBlockTag(tree, ignore);
bpatel@2169 850 }
bpatel@2169 851
bpatel@2169 852 @Override
bpatel@2169 853 public Void visitUnknownInlineTag(UnknownInlineTagTree tree, Void ignore) {
bpatel@2169 854 checkUnknownTag(tree, tree.getTagName());
bpatel@2169 855 return super.visitUnknownInlineTag(tree, ignore);
bpatel@2169 856 }
bpatel@2169 857
bpatel@2169 858 private void checkUnknownTag(DocTree tree, String tagName) {
bpatel@2169 859 if (env.customTags != null && !env.customTags.contains(tagName))
bpatel@2169 860 env.messages.error(SYNTAX, tree, "dc.tag.unknown", tagName);
bpatel@2169 861 }
bpatel@2169 862
bpatel@2169 863 @Override
jjg@1650 864 public Void visitValue(ValueTree tree, Void ignore) {
jjg@2053 865 ReferenceTree ref = tree.getReference();
jjg@2053 866 if (ref == null || ref.getSignature().isEmpty()) {
jjg@2053 867 if (!isConstant(env.currElement))
jjg@2053 868 env.messages.error(REFERENCE, tree, "dc.value.not.allowed.here");
jjg@2053 869 } else {
jjg@2053 870 Element e = env.trees.getElement(new DocTreePath(getCurrentPath(), ref));
jjg@2053 871 if (!isConstant(e))
jjg@2053 872 env.messages.error(REFERENCE, tree, "dc.value.not.a.constant");
jjg@2053 873 }
jjg@2053 874
jjg@1650 875 markEnclosingTag(Flag.HAS_INLINE_TAG);
jjg@1650 876 return super.visitValue(tree, ignore);
jjg@1650 877 }
jjg@1650 878
jjg@2053 879 private boolean isConstant(Element e) {
jjg@2053 880 if (e == null)
jjg@2053 881 return false;
jjg@2053 882
jjg@2053 883 switch (e.getKind()) {
jjg@2053 884 case FIELD:
jjg@2053 885 Object value = ((VariableElement) e).getConstantValue();
jjg@2053 886 return (value != null); // can't distinguish "not a constant" from "constant is null"
jjg@2053 887 default:
jjg@2053 888 return false;
jjg@2053 889 }
jjg@2053 890 }
jjg@2053 891
jjg@1650 892 @Override
jjg@1455 893 public Void visitVersion(VersionTree tree, Void ignore) {
jjg@1455 894 warnIfEmpty(tree, tree.getBody());
jjg@1455 895 return super.visitVersion(tree, ignore);
jjg@1455 896 }
jjg@1455 897
jjg@1455 898 @Override
jjg@1455 899 public Void visitErroneous(ErroneousTree tree, Void ignore) {
jjg@1455 900 env.messages.error(SYNTAX, tree, null, tree.getDiagnostic().getMessage(null));
jjg@1455 901 return null;
jjg@1455 902 }
jjg@1455 903 // </editor-fold>
jjg@1455 904
jjg@1455 905 // <editor-fold defaultstate="collapsed" desc="Utility methods">
jjg@1455 906
jjg@1455 907 private boolean isCheckedException(TypeMirror t) {
jjg@1455 908 return !(env.types.isAssignable(t, env.java_lang_Error)
jjg@1455 909 || env.types.isAssignable(t, env.java_lang_RuntimeException));
jjg@1455 910 }
jjg@1455 911
jjg@1455 912 private boolean isSynthetic() {
jjg@1455 913 switch (env.currElement.getKind()) {
jjg@1455 914 case CONSTRUCTOR:
jjg@1455 915 // A synthetic default constructor has the same pos as the
jjg@1455 916 // enclosing class
jjg@1455 917 TreePath p = env.currPath;
jjg@1455 918 return env.getPos(p) == env.getPos(p.getParentPath());
jjg@1455 919 }
jjg@1455 920 return false;
jjg@1455 921 }
jjg@1455 922
jjg@1455 923 void markEnclosingTag(Flag flag) {
jjg@1455 924 TagStackItem top = tagStack.peek();
jjg@1455 925 if (top != null)
jjg@1455 926 top.flags.add(flag);
jjg@1455 927 }
jjg@1455 928
jjg@1455 929 String toString(TreePath p) {
jjg@1455 930 StringBuilder sb = new StringBuilder("TreePath[");
jjg@1455 931 toString(p, sb);
jjg@1455 932 sb.append("]");
jjg@1455 933 return sb.toString();
jjg@1455 934 }
jjg@1455 935
jjg@1455 936 void toString(TreePath p, StringBuilder sb) {
jjg@1455 937 TreePath parent = p.getParentPath();
jjg@1455 938 if (parent != null) {
jjg@1455 939 toString(parent, sb);
jjg@1455 940 sb.append(",");
jjg@1455 941 }
jjg@1455 942 sb.append(p.getLeaf().getKind()).append(":").append(env.getPos(p)).append(":S").append(env.getStartPos(p));
jjg@1455 943 }
jjg@1455 944
jjg@1455 945 void warnIfEmpty(DocTree tree, List<? extends DocTree> list) {
jjg@1455 946 for (DocTree d: list) {
jjg@1455 947 switch (d.getKind()) {
jjg@1455 948 case TEXT:
jjg@1507 949 if (hasNonWhitespace((TextTree) d))
jjg@1455 950 return;
jjg@1455 951 break;
jjg@1455 952 default:
jjg@1455 953 return;
jjg@1455 954 }
jjg@1455 955 }
jjg@1455 956 env.messages.warning(SYNTAX, tree, "dc.empty", tree.getKind().tagName);
jjg@1455 957 }
jjg@1507 958
jjg@1507 959 boolean hasNonWhitespace(TextTree tree) {
jjg@1507 960 String s = tree.getBody();
jjg@1507 961 for (int i = 0; i < s.length(); i++) {
jjg@1507 962 if (!Character.isWhitespace(s.charAt(i)))
jjg@1507 963 return true;
jjg@1507 964 }
jjg@1507 965 return false;
jjg@1507 966 }
jjg@1507 967
jjg@1455 968 // </editor-fold>
jjg@1455 969
jjg@1455 970 }

mercurial