Wed, 21 Sep 2011 21:56:53 -0700
7092965: javac should not close processorClassLoader before end of compilation
Reviewed-by: darcy
duke@1 | 1 | /* |
jjg@815 | 2 | * Copyright (c) 1999, 2011, Oracle and/or its affiliates. All rights reserved. |
duke@1 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@1 | 4 | * |
duke@1 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@1 | 6 | * under the terms of the GNU General Public License version 2 only, as |
ohair@554 | 7 | * published by the Free Software Foundation. Oracle designates this |
duke@1 | 8 | * particular file as subject to the "Classpath" exception as provided |
ohair@554 | 9 | * by Oracle in the LICENSE file that accompanied this code. |
duke@1 | 10 | * |
duke@1 | 11 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@1 | 12 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@1 | 13 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@1 | 14 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@1 | 15 | * accompanied this code). |
duke@1 | 16 | * |
duke@1 | 17 | * You should have received a copy of the GNU General Public License version |
duke@1 | 18 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@1 | 19 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@1 | 20 | * |
ohair@554 | 21 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
ohair@554 | 22 | * or visit www.oracle.com if you need additional information or have any |
ohair@554 | 23 | * questions. |
duke@1 | 24 | */ |
duke@1 | 25 | |
duke@1 | 26 | //todo: one might eliminate uninits.andSets when monotonic |
duke@1 | 27 | |
duke@1 | 28 | package com.sun.tools.javac.comp; |
duke@1 | 29 | |
mcimadamore@550 | 30 | import java.util.HashMap; |
darcy@609 | 31 | import java.util.Map; |
darcy@609 | 32 | import java.util.LinkedHashMap; |
mcimadamore@550 | 33 | |
duke@1 | 34 | import com.sun.tools.javac.code.*; |
duke@1 | 35 | import com.sun.tools.javac.tree.*; |
duke@1 | 36 | import com.sun.tools.javac.util.*; |
duke@1 | 37 | import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition; |
duke@1 | 38 | |
duke@1 | 39 | import com.sun.tools.javac.code.Symbol.*; |
duke@1 | 40 | import com.sun.tools.javac.tree.JCTree.*; |
duke@1 | 41 | |
duke@1 | 42 | import static com.sun.tools.javac.code.Flags.*; |
duke@1 | 43 | import static com.sun.tools.javac.code.Kinds.*; |
duke@1 | 44 | import static com.sun.tools.javac.code.TypeTags.*; |
duke@1 | 45 | |
duke@1 | 46 | /** This pass implements dataflow analysis for Java programs. |
duke@1 | 47 | * Liveness analysis checks that every statement is reachable. |
duke@1 | 48 | * Exception analysis ensures that every checked exception that is |
duke@1 | 49 | * thrown is declared or caught. Definite assignment analysis |
duke@1 | 50 | * ensures that each variable is assigned when used. Definite |
duke@1 | 51 | * unassignment analysis ensures that no final variable is assigned |
duke@1 | 52 | * more than once. |
duke@1 | 53 | * |
jjh@972 | 54 | * <p>The JLS has a number of problems in the |
duke@1 | 55 | * specification of these flow analysis problems. This implementation |
duke@1 | 56 | * attempts to address those issues. |
duke@1 | 57 | * |
duke@1 | 58 | * <p>First, there is no accommodation for a finally clause that cannot |
duke@1 | 59 | * complete normally. For liveness analysis, an intervening finally |
duke@1 | 60 | * clause can cause a break, continue, or return not to reach its |
duke@1 | 61 | * target. For exception analysis, an intervening finally clause can |
duke@1 | 62 | * cause any exception to be "caught". For DA/DU analysis, the finally |
duke@1 | 63 | * clause can prevent a transfer of control from propagating DA/DU |
duke@1 | 64 | * state to the target. In addition, code in the finally clause can |
duke@1 | 65 | * affect the DA/DU status of variables. |
duke@1 | 66 | * |
duke@1 | 67 | * <p>For try statements, we introduce the idea of a variable being |
duke@1 | 68 | * definitely unassigned "everywhere" in a block. A variable V is |
duke@1 | 69 | * "unassigned everywhere" in a block iff it is unassigned at the |
duke@1 | 70 | * beginning of the block and there is no reachable assignment to V |
duke@1 | 71 | * in the block. An assignment V=e is reachable iff V is not DA |
duke@1 | 72 | * after e. Then we can say that V is DU at the beginning of the |
duke@1 | 73 | * catch block iff V is DU everywhere in the try block. Similarly, V |
duke@1 | 74 | * is DU at the beginning of the finally block iff V is DU everywhere |
duke@1 | 75 | * in the try block and in every catch block. Specifically, the |
duke@1 | 76 | * following bullet is added to 16.2.2 |
duke@1 | 77 | * <pre> |
duke@1 | 78 | * V is <em>unassigned everywhere</em> in a block if it is |
duke@1 | 79 | * unassigned before the block and there is no reachable |
duke@1 | 80 | * assignment to V within the block. |
duke@1 | 81 | * </pre> |
duke@1 | 82 | * <p>In 16.2.15, the third bullet (and all of its sub-bullets) for all |
duke@1 | 83 | * try blocks is changed to |
duke@1 | 84 | * <pre> |
duke@1 | 85 | * V is definitely unassigned before a catch block iff V is |
duke@1 | 86 | * definitely unassigned everywhere in the try block. |
duke@1 | 87 | * </pre> |
duke@1 | 88 | * <p>The last bullet (and all of its sub-bullets) for try blocks that |
duke@1 | 89 | * have a finally block is changed to |
duke@1 | 90 | * <pre> |
duke@1 | 91 | * V is definitely unassigned before the finally block iff |
duke@1 | 92 | * V is definitely unassigned everywhere in the try block |
duke@1 | 93 | * and everywhere in each catch block of the try statement. |
duke@1 | 94 | * </pre> |
duke@1 | 95 | * <p>In addition, |
duke@1 | 96 | * <pre> |
duke@1 | 97 | * V is definitely assigned at the end of a constructor iff |
duke@1 | 98 | * V is definitely assigned after the block that is the body |
duke@1 | 99 | * of the constructor and V is definitely assigned at every |
duke@1 | 100 | * return that can return from the constructor. |
duke@1 | 101 | * </pre> |
duke@1 | 102 | * <p>In addition, each continue statement with the loop as its target |
duke@1 | 103 | * is treated as a jump to the end of the loop body, and "intervening" |
duke@1 | 104 | * finally clauses are treated as follows: V is DA "due to the |
duke@1 | 105 | * continue" iff V is DA before the continue statement or V is DA at |
duke@1 | 106 | * the end of any intervening finally block. V is DU "due to the |
duke@1 | 107 | * continue" iff any intervening finally cannot complete normally or V |
duke@1 | 108 | * is DU at the end of every intervening finally block. This "due to |
duke@1 | 109 | * the continue" concept is then used in the spec for the loops. |
duke@1 | 110 | * |
duke@1 | 111 | * <p>Similarly, break statements must consider intervening finally |
duke@1 | 112 | * blocks. For liveness analysis, a break statement for which any |
duke@1 | 113 | * intervening finally cannot complete normally is not considered to |
duke@1 | 114 | * cause the target statement to be able to complete normally. Then |
duke@1 | 115 | * we say V is DA "due to the break" iff V is DA before the break or |
duke@1 | 116 | * V is DA at the end of any intervening finally block. V is DU "due |
duke@1 | 117 | * to the break" iff any intervening finally cannot complete normally |
duke@1 | 118 | * or V is DU at the break and at the end of every intervening |
duke@1 | 119 | * finally block. (I suspect this latter condition can be |
duke@1 | 120 | * simplified.) This "due to the break" is then used in the spec for |
duke@1 | 121 | * all statements that can be "broken". |
duke@1 | 122 | * |
duke@1 | 123 | * <p>The return statement is treated similarly. V is DA "due to a |
duke@1 | 124 | * return statement" iff V is DA before the return statement or V is |
duke@1 | 125 | * DA at the end of any intervening finally block. Note that we |
duke@1 | 126 | * don't have to worry about the return expression because this |
duke@1 | 127 | * concept is only used for construcrors. |
duke@1 | 128 | * |
jjh@972 | 129 | * <p>There is no spec in the JLS for when a variable is definitely |
duke@1 | 130 | * assigned at the end of a constructor, which is needed for final |
duke@1 | 131 | * fields (8.3.1.2). We implement the rule that V is DA at the end |
duke@1 | 132 | * of the constructor iff it is DA and the end of the body of the |
duke@1 | 133 | * constructor and V is DA "due to" every return of the constructor. |
duke@1 | 134 | * |
duke@1 | 135 | * <p>Intervening finally blocks similarly affect exception analysis. An |
duke@1 | 136 | * intervening finally that cannot complete normally allows us to ignore |
duke@1 | 137 | * an otherwise uncaught exception. |
duke@1 | 138 | * |
duke@1 | 139 | * <p>To implement the semantics of intervening finally clauses, all |
duke@1 | 140 | * nonlocal transfers (break, continue, return, throw, method call that |
duke@1 | 141 | * can throw a checked exception, and a constructor invocation that can |
duke@1 | 142 | * thrown a checked exception) are recorded in a queue, and removed |
duke@1 | 143 | * from the queue when we complete processing the target of the |
duke@1 | 144 | * nonlocal transfer. This allows us to modify the queue in accordance |
duke@1 | 145 | * with the above rules when we encounter a finally clause. The only |
duke@1 | 146 | * exception to this [no pun intended] is that checked exceptions that |
duke@1 | 147 | * are known to be caught or declared to be caught in the enclosing |
duke@1 | 148 | * method are not recorded in the queue, but instead are recorded in a |
duke@1 | 149 | * global variable "Set<Type> thrown" that records the type of all |
duke@1 | 150 | * exceptions that can be thrown. |
duke@1 | 151 | * |
duke@1 | 152 | * <p>Other minor issues the treatment of members of other classes |
duke@1 | 153 | * (always considered DA except that within an anonymous class |
duke@1 | 154 | * constructor, where DA status from the enclosing scope is |
duke@1 | 155 | * preserved), treatment of the case expression (V is DA before the |
duke@1 | 156 | * case expression iff V is DA after the switch expression), |
duke@1 | 157 | * treatment of variables declared in a switch block (the implied |
duke@1 | 158 | * DA/DU status after the switch expression is DU and not DA for |
duke@1 | 159 | * variables defined in a switch block), the treatment of boolean ?: |
duke@1 | 160 | * expressions (The JLS rules only handle b and c non-boolean; the |
duke@1 | 161 | * new rule is that if b and c are boolean valued, then V is |
duke@1 | 162 | * (un)assigned after a?b:c when true/false iff V is (un)assigned |
duke@1 | 163 | * after b when true/false and V is (un)assigned after c when |
duke@1 | 164 | * true/false). |
duke@1 | 165 | * |
duke@1 | 166 | * <p>There is the remaining question of what syntactic forms constitute a |
duke@1 | 167 | * reference to a variable. It is conventional to allow this.x on the |
duke@1 | 168 | * left-hand-side to initialize a final instance field named x, yet |
duke@1 | 169 | * this.x isn't considered a "use" when appearing on a right-hand-side |
duke@1 | 170 | * in most implementations. Should parentheses affect what is |
duke@1 | 171 | * considered a variable reference? The simplest rule would be to |
duke@1 | 172 | * allow unqualified forms only, parentheses optional, and phase out |
duke@1 | 173 | * support for assigning to a final field via this.x. |
duke@1 | 174 | * |
jjg@581 | 175 | * <p><b>This is NOT part of any supported API. |
jjg@581 | 176 | * If you write code that depends on this, you do so at your own risk. |
duke@1 | 177 | * This code and its internal interfaces are subject to change or |
duke@1 | 178 | * deletion without notice.</b> |
duke@1 | 179 | */ |
duke@1 | 180 | public class Flow extends TreeScanner { |
duke@1 | 181 | protected static final Context.Key<Flow> flowKey = |
duke@1 | 182 | new Context.Key<Flow>(); |
duke@1 | 183 | |
jjg@113 | 184 | private final Names names; |
duke@1 | 185 | private final Log log; |
duke@1 | 186 | private final Symtab syms; |
duke@1 | 187 | private final Types types; |
duke@1 | 188 | private final Check chk; |
duke@1 | 189 | private TreeMaker make; |
mcimadamore@617 | 190 | private final Resolve rs; |
mcimadamore@617 | 191 | private Env<AttrContext> attrEnv; |
duke@1 | 192 | private Lint lint; |
mcimadamore@935 | 193 | private final boolean allowImprovedRethrowAnalysis; |
mcimadamore@935 | 194 | private final boolean allowImprovedCatchAnalysis; |
duke@1 | 195 | |
duke@1 | 196 | public static Flow instance(Context context) { |
duke@1 | 197 | Flow instance = context.get(flowKey); |
duke@1 | 198 | if (instance == null) |
duke@1 | 199 | instance = new Flow(context); |
duke@1 | 200 | return instance; |
duke@1 | 201 | } |
duke@1 | 202 | |
duke@1 | 203 | protected Flow(Context context) { |
duke@1 | 204 | context.put(flowKey, this); |
jjg@113 | 205 | names = Names.instance(context); |
duke@1 | 206 | log = Log.instance(context); |
duke@1 | 207 | syms = Symtab.instance(context); |
duke@1 | 208 | types = Types.instance(context); |
duke@1 | 209 | chk = Check.instance(context); |
duke@1 | 210 | lint = Lint.instance(context); |
mcimadamore@617 | 211 | rs = Resolve.instance(context); |
mcimadamore@550 | 212 | Source source = Source.instance(context); |
mcimadamore@935 | 213 | allowImprovedRethrowAnalysis = source.allowImprovedRethrowAnalysis(); |
mcimadamore@935 | 214 | allowImprovedCatchAnalysis = source.allowImprovedCatchAnalysis(); |
duke@1 | 215 | } |
duke@1 | 216 | |
duke@1 | 217 | /** A flag that indicates whether the last statement could |
duke@1 | 218 | * complete normally. |
duke@1 | 219 | */ |
duke@1 | 220 | private boolean alive; |
duke@1 | 221 | |
duke@1 | 222 | /** The set of definitely assigned variables. |
duke@1 | 223 | */ |
duke@1 | 224 | Bits inits; |
duke@1 | 225 | |
duke@1 | 226 | /** The set of definitely unassigned variables. |
duke@1 | 227 | */ |
duke@1 | 228 | Bits uninits; |
duke@1 | 229 | |
mcimadamore@735 | 230 | HashMap<Symbol, List<Type>> preciseRethrowTypes; |
mcimadamore@550 | 231 | |
duke@1 | 232 | /** The set of variables that are definitely unassigned everywhere |
duke@1 | 233 | * in current try block. This variable is maintained lazily; it is |
duke@1 | 234 | * updated only when something gets removed from uninits, |
duke@1 | 235 | * typically by being assigned in reachable code. To obtain the |
duke@1 | 236 | * correct set of variables which are definitely unassigned |
duke@1 | 237 | * anywhere in current try block, intersect uninitsTry and |
duke@1 | 238 | * uninits. |
duke@1 | 239 | */ |
duke@1 | 240 | Bits uninitsTry; |
duke@1 | 241 | |
duke@1 | 242 | /** When analyzing a condition, inits and uninits are null. |
duke@1 | 243 | * Instead we have: |
duke@1 | 244 | */ |
duke@1 | 245 | Bits initsWhenTrue; |
duke@1 | 246 | Bits initsWhenFalse; |
duke@1 | 247 | Bits uninitsWhenTrue; |
duke@1 | 248 | Bits uninitsWhenFalse; |
duke@1 | 249 | |
duke@1 | 250 | /** A mapping from addresses to variable symbols. |
duke@1 | 251 | */ |
duke@1 | 252 | VarSymbol[] vars; |
duke@1 | 253 | |
duke@1 | 254 | /** The current class being defined. |
duke@1 | 255 | */ |
duke@1 | 256 | JCClassDecl classDef; |
duke@1 | 257 | |
duke@1 | 258 | /** The first variable sequence number in this class definition. |
duke@1 | 259 | */ |
duke@1 | 260 | int firstadr; |
duke@1 | 261 | |
duke@1 | 262 | /** The next available variable sequence number. |
duke@1 | 263 | */ |
duke@1 | 264 | int nextadr; |
duke@1 | 265 | |
duke@1 | 266 | /** The list of possibly thrown declarable exceptions. |
duke@1 | 267 | */ |
duke@1 | 268 | List<Type> thrown; |
duke@1 | 269 | |
duke@1 | 270 | /** The list of exceptions that are either caught or declared to be |
duke@1 | 271 | * thrown. |
duke@1 | 272 | */ |
duke@1 | 273 | List<Type> caught; |
duke@1 | 274 | |
darcy@609 | 275 | /** The list of unreferenced automatic resources. |
darcy@609 | 276 | */ |
mcimadamore@905 | 277 | Scope unrefdResources; |
darcy@609 | 278 | |
duke@1 | 279 | /** Set when processing a loop body the second time for DU analysis. */ |
duke@1 | 280 | boolean loopPassTwo = false; |
duke@1 | 281 | |
duke@1 | 282 | /*-------------------- Environments ----------------------*/ |
duke@1 | 283 | |
duke@1 | 284 | /** A pending exit. These are the statements return, break, and |
duke@1 | 285 | * continue. In addition, exception-throwing expressions or |
duke@1 | 286 | * statements are put here when not known to be caught. This |
duke@1 | 287 | * will typically result in an error unless it is within a |
duke@1 | 288 | * try-finally whose finally block cannot complete normally. |
duke@1 | 289 | */ |
duke@1 | 290 | static class PendingExit { |
duke@1 | 291 | JCTree tree; |
duke@1 | 292 | Bits inits; |
duke@1 | 293 | Bits uninits; |
duke@1 | 294 | Type thrown; |
duke@1 | 295 | PendingExit(JCTree tree, Bits inits, Bits uninits) { |
duke@1 | 296 | this.tree = tree; |
duke@1 | 297 | this.inits = inits.dup(); |
duke@1 | 298 | this.uninits = uninits.dup(); |
duke@1 | 299 | } |
duke@1 | 300 | PendingExit(JCTree tree, Type thrown) { |
duke@1 | 301 | this.tree = tree; |
duke@1 | 302 | this.thrown = thrown; |
duke@1 | 303 | } |
duke@1 | 304 | } |
duke@1 | 305 | |
duke@1 | 306 | /** The currently pending exits that go from current inner blocks |
duke@1 | 307 | * to an enclosing block, in source order. |
duke@1 | 308 | */ |
duke@1 | 309 | ListBuffer<PendingExit> pendingExits; |
duke@1 | 310 | |
duke@1 | 311 | /*-------------------- Exceptions ----------------------*/ |
duke@1 | 312 | |
duke@1 | 313 | /** Complain that pending exceptions are not caught. |
duke@1 | 314 | */ |
duke@1 | 315 | void errorUncaught() { |
duke@1 | 316 | for (PendingExit exit = pendingExits.next(); |
duke@1 | 317 | exit != null; |
duke@1 | 318 | exit = pendingExits.next()) { |
mcimadamore@878 | 319 | if (classDef != null && |
mcimadamore@878 | 320 | classDef.pos == exit.tree.pos) { |
mcimadamore@878 | 321 | log.error(exit.tree.pos(), |
mcimadamore@878 | 322 | "unreported.exception.default.constructor", |
mcimadamore@878 | 323 | exit.thrown); |
mcimadamore@878 | 324 | } else if (exit.tree.getTag() == JCTree.VARDEF && |
mcimadamore@878 | 325 | ((JCVariableDecl)exit.tree).sym.isResourceVariable()) { |
mcimadamore@878 | 326 | log.error(exit.tree.pos(), |
mcimadamore@878 | 327 | "unreported.exception.implicit.close", |
mcimadamore@878 | 328 | exit.thrown, |
mcimadamore@878 | 329 | ((JCVariableDecl)exit.tree).sym.name); |
mcimadamore@878 | 330 | } else { |
mcimadamore@878 | 331 | log.error(exit.tree.pos(), |
mcimadamore@878 | 332 | "unreported.exception.need.to.catch.or.throw", |
mcimadamore@878 | 333 | exit.thrown); |
mcimadamore@878 | 334 | } |
duke@1 | 335 | } |
duke@1 | 336 | } |
duke@1 | 337 | |
duke@1 | 338 | /** Record that exception is potentially thrown and check that it |
duke@1 | 339 | * is caught. |
duke@1 | 340 | */ |
duke@1 | 341 | void markThrown(JCTree tree, Type exc) { |
duke@1 | 342 | if (!chk.isUnchecked(tree.pos(), exc)) { |
duke@1 | 343 | if (!chk.isHandled(exc, caught)) |
duke@1 | 344 | pendingExits.append(new PendingExit(tree, exc)); |
mcimadamore@735 | 345 | thrown = chk.incl(exc, thrown); |
duke@1 | 346 | } |
duke@1 | 347 | } |
duke@1 | 348 | |
duke@1 | 349 | /*-------------- Processing variables ----------------------*/ |
duke@1 | 350 | |
duke@1 | 351 | /** Do we need to track init/uninit state of this symbol? |
duke@1 | 352 | * I.e. is symbol either a local or a blank final variable? |
duke@1 | 353 | */ |
duke@1 | 354 | boolean trackable(VarSymbol sym) { |
duke@1 | 355 | return |
duke@1 | 356 | (sym.owner.kind == MTH || |
duke@1 | 357 | ((sym.flags() & (FINAL | HASINIT | PARAMETER)) == FINAL && |
duke@1 | 358 | classDef.sym.isEnclosedBy((ClassSymbol)sym.owner))); |
duke@1 | 359 | } |
duke@1 | 360 | |
duke@1 | 361 | /** Initialize new trackable variable by setting its address field |
duke@1 | 362 | * to the next available sequence number and entering it under that |
duke@1 | 363 | * index into the vars array. |
duke@1 | 364 | */ |
duke@1 | 365 | void newVar(VarSymbol sym) { |
duke@1 | 366 | if (nextadr == vars.length) { |
duke@1 | 367 | VarSymbol[] newvars = new VarSymbol[nextadr * 2]; |
duke@1 | 368 | System.arraycopy(vars, 0, newvars, 0, nextadr); |
duke@1 | 369 | vars = newvars; |
duke@1 | 370 | } |
duke@1 | 371 | sym.adr = nextadr; |
duke@1 | 372 | vars[nextadr] = sym; |
duke@1 | 373 | inits.excl(nextadr); |
duke@1 | 374 | uninits.incl(nextadr); |
duke@1 | 375 | nextadr++; |
duke@1 | 376 | } |
duke@1 | 377 | |
duke@1 | 378 | /** Record an initialization of a trackable variable. |
duke@1 | 379 | */ |
duke@1 | 380 | void letInit(DiagnosticPosition pos, VarSymbol sym) { |
duke@1 | 381 | if (sym.adr >= firstadr && trackable(sym)) { |
duke@1 | 382 | if ((sym.flags() & FINAL) != 0) { |
duke@1 | 383 | if ((sym.flags() & PARAMETER) != 0) { |
darcy@969 | 384 | if ((sym.flags() & UNION) != 0) { //multi-catch parameter |
mcimadamore@550 | 385 | log.error(pos, "multicatch.parameter.may.not.be.assigned", |
mcimadamore@550 | 386 | sym); |
mcimadamore@550 | 387 | } |
mcimadamore@550 | 388 | else { |
mcimadamore@550 | 389 | log.error(pos, "final.parameter.may.not.be.assigned", |
duke@1 | 390 | sym); |
mcimadamore@550 | 391 | } |
duke@1 | 392 | } else if (!uninits.isMember(sym.adr)) { |
duke@1 | 393 | log.error(pos, |
duke@1 | 394 | loopPassTwo |
duke@1 | 395 | ? "var.might.be.assigned.in.loop" |
duke@1 | 396 | : "var.might.already.be.assigned", |
duke@1 | 397 | sym); |
duke@1 | 398 | } else if (!inits.isMember(sym.adr)) { |
duke@1 | 399 | // reachable assignment |
duke@1 | 400 | uninits.excl(sym.adr); |
duke@1 | 401 | uninitsTry.excl(sym.adr); |
duke@1 | 402 | } else { |
duke@1 | 403 | //log.rawWarning(pos, "unreachable assignment");//DEBUG |
duke@1 | 404 | uninits.excl(sym.adr); |
duke@1 | 405 | } |
duke@1 | 406 | } |
duke@1 | 407 | inits.incl(sym.adr); |
duke@1 | 408 | } else if ((sym.flags() & FINAL) != 0) { |
duke@1 | 409 | log.error(pos, "var.might.already.be.assigned", sym); |
duke@1 | 410 | } |
duke@1 | 411 | } |
duke@1 | 412 | |
duke@1 | 413 | /** If tree is either a simple name or of the form this.name or |
duke@1 | 414 | * C.this.name, and tree represents a trackable variable, |
duke@1 | 415 | * record an initialization of the variable. |
duke@1 | 416 | */ |
duke@1 | 417 | void letInit(JCTree tree) { |
duke@1 | 418 | tree = TreeInfo.skipParens(tree); |
duke@1 | 419 | if (tree.getTag() == JCTree.IDENT || tree.getTag() == JCTree.SELECT) { |
duke@1 | 420 | Symbol sym = TreeInfo.symbol(tree); |
mcimadamore@676 | 421 | if (sym.kind == VAR) { |
mcimadamore@676 | 422 | letInit(tree.pos(), (VarSymbol)sym); |
mcimadamore@676 | 423 | } |
duke@1 | 424 | } |
duke@1 | 425 | } |
duke@1 | 426 | |
duke@1 | 427 | /** Check that trackable variable is initialized. |
duke@1 | 428 | */ |
duke@1 | 429 | void checkInit(DiagnosticPosition pos, VarSymbol sym) { |
duke@1 | 430 | if ((sym.adr >= firstadr || sym.owner.kind != TYP) && |
duke@1 | 431 | trackable(sym) && |
duke@1 | 432 | !inits.isMember(sym.adr)) { |
duke@1 | 433 | log.error(pos, "var.might.not.have.been.initialized", |
duke@1 | 434 | sym); |
duke@1 | 435 | inits.incl(sym.adr); |
duke@1 | 436 | } |
duke@1 | 437 | } |
duke@1 | 438 | |
duke@1 | 439 | /*-------------------- Handling jumps ----------------------*/ |
duke@1 | 440 | |
duke@1 | 441 | /** Record an outward transfer of control. */ |
duke@1 | 442 | void recordExit(JCTree tree) { |
duke@1 | 443 | pendingExits.append(new PendingExit(tree, inits, uninits)); |
duke@1 | 444 | markDead(); |
duke@1 | 445 | } |
duke@1 | 446 | |
duke@1 | 447 | /** Resolve all breaks of this statement. */ |
duke@1 | 448 | boolean resolveBreaks(JCTree tree, |
duke@1 | 449 | ListBuffer<PendingExit> oldPendingExits) { |
duke@1 | 450 | boolean result = false; |
duke@1 | 451 | List<PendingExit> exits = pendingExits.toList(); |
duke@1 | 452 | pendingExits = oldPendingExits; |
duke@1 | 453 | for (; exits.nonEmpty(); exits = exits.tail) { |
duke@1 | 454 | PendingExit exit = exits.head; |
duke@1 | 455 | if (exit.tree.getTag() == JCTree.BREAK && |
duke@1 | 456 | ((JCBreak) exit.tree).target == tree) { |
duke@1 | 457 | inits.andSet(exit.inits); |
duke@1 | 458 | uninits.andSet(exit.uninits); |
duke@1 | 459 | result = true; |
duke@1 | 460 | } else { |
duke@1 | 461 | pendingExits.append(exit); |
duke@1 | 462 | } |
duke@1 | 463 | } |
duke@1 | 464 | return result; |
duke@1 | 465 | } |
duke@1 | 466 | |
duke@1 | 467 | /** Resolve all continues of this statement. */ |
duke@1 | 468 | boolean resolveContinues(JCTree tree) { |
duke@1 | 469 | boolean result = false; |
duke@1 | 470 | List<PendingExit> exits = pendingExits.toList(); |
duke@1 | 471 | pendingExits = new ListBuffer<PendingExit>(); |
duke@1 | 472 | for (; exits.nonEmpty(); exits = exits.tail) { |
duke@1 | 473 | PendingExit exit = exits.head; |
duke@1 | 474 | if (exit.tree.getTag() == JCTree.CONTINUE && |
duke@1 | 475 | ((JCContinue) exit.tree).target == tree) { |
duke@1 | 476 | inits.andSet(exit.inits); |
duke@1 | 477 | uninits.andSet(exit.uninits); |
duke@1 | 478 | result = true; |
duke@1 | 479 | } else { |
duke@1 | 480 | pendingExits.append(exit); |
duke@1 | 481 | } |
duke@1 | 482 | } |
duke@1 | 483 | return result; |
duke@1 | 484 | } |
duke@1 | 485 | |
duke@1 | 486 | /** Record that statement is unreachable. |
duke@1 | 487 | */ |
duke@1 | 488 | void markDead() { |
duke@1 | 489 | inits.inclRange(firstadr, nextadr); |
duke@1 | 490 | uninits.inclRange(firstadr, nextadr); |
duke@1 | 491 | alive = false; |
duke@1 | 492 | } |
duke@1 | 493 | |
duke@1 | 494 | /** Split (duplicate) inits/uninits into WhenTrue/WhenFalse sets |
duke@1 | 495 | */ |
mcimadamore@676 | 496 | void split(boolean setToNull) { |
duke@1 | 497 | initsWhenFalse = inits.dup(); |
duke@1 | 498 | uninitsWhenFalse = uninits.dup(); |
duke@1 | 499 | initsWhenTrue = inits; |
duke@1 | 500 | uninitsWhenTrue = uninits; |
mcimadamore@676 | 501 | if (setToNull) |
mcimadamore@676 | 502 | inits = uninits = null; |
duke@1 | 503 | } |
duke@1 | 504 | |
duke@1 | 505 | /** Merge (intersect) inits/uninits from WhenTrue/WhenFalse sets. |
duke@1 | 506 | */ |
duke@1 | 507 | void merge() { |
duke@1 | 508 | inits = initsWhenFalse.andSet(initsWhenTrue); |
duke@1 | 509 | uninits = uninitsWhenFalse.andSet(uninitsWhenTrue); |
duke@1 | 510 | } |
duke@1 | 511 | |
duke@1 | 512 | /* ************************************************************************ |
duke@1 | 513 | * Visitor methods for statements and definitions |
duke@1 | 514 | *************************************************************************/ |
duke@1 | 515 | |
duke@1 | 516 | /** Analyze a definition. |
duke@1 | 517 | */ |
duke@1 | 518 | void scanDef(JCTree tree) { |
duke@1 | 519 | scanStat(tree); |
duke@1 | 520 | if (tree != null && tree.getTag() == JCTree.BLOCK && !alive) { |
duke@1 | 521 | log.error(tree.pos(), |
duke@1 | 522 | "initializer.must.be.able.to.complete.normally"); |
duke@1 | 523 | } |
duke@1 | 524 | } |
duke@1 | 525 | |
duke@1 | 526 | /** Analyze a statement. Check that statement is reachable. |
duke@1 | 527 | */ |
duke@1 | 528 | void scanStat(JCTree tree) { |
duke@1 | 529 | if (!alive && tree != null) { |
duke@1 | 530 | log.error(tree.pos(), "unreachable.stmt"); |
duke@1 | 531 | if (tree.getTag() != JCTree.SKIP) alive = true; |
duke@1 | 532 | } |
duke@1 | 533 | scan(tree); |
duke@1 | 534 | } |
duke@1 | 535 | |
duke@1 | 536 | /** Analyze list of statements. |
duke@1 | 537 | */ |
duke@1 | 538 | void scanStats(List<? extends JCStatement> trees) { |
duke@1 | 539 | if (trees != null) |
duke@1 | 540 | for (List<? extends JCStatement> l = trees; l.nonEmpty(); l = l.tail) |
duke@1 | 541 | scanStat(l.head); |
duke@1 | 542 | } |
duke@1 | 543 | |
duke@1 | 544 | /** Analyze an expression. Make sure to set (un)inits rather than |
duke@1 | 545 | * (un)initsWhenTrue(WhenFalse) on exit. |
duke@1 | 546 | */ |
duke@1 | 547 | void scanExpr(JCTree tree) { |
duke@1 | 548 | if (tree != null) { |
duke@1 | 549 | scan(tree); |
duke@1 | 550 | if (inits == null) merge(); |
duke@1 | 551 | } |
duke@1 | 552 | } |
duke@1 | 553 | |
duke@1 | 554 | /** Analyze a list of expressions. |
duke@1 | 555 | */ |
duke@1 | 556 | void scanExprs(List<? extends JCExpression> trees) { |
duke@1 | 557 | if (trees != null) |
duke@1 | 558 | for (List<? extends JCExpression> l = trees; l.nonEmpty(); l = l.tail) |
duke@1 | 559 | scanExpr(l.head); |
duke@1 | 560 | } |
duke@1 | 561 | |
duke@1 | 562 | /** Analyze a condition. Make sure to set (un)initsWhenTrue(WhenFalse) |
duke@1 | 563 | * rather than (un)inits on exit. |
duke@1 | 564 | */ |
duke@1 | 565 | void scanCond(JCTree tree) { |
duke@1 | 566 | if (tree.type.isFalse()) { |
duke@1 | 567 | if (inits == null) merge(); |
duke@1 | 568 | initsWhenTrue = inits.dup(); |
duke@1 | 569 | initsWhenTrue.inclRange(firstadr, nextadr); |
duke@1 | 570 | uninitsWhenTrue = uninits.dup(); |
duke@1 | 571 | uninitsWhenTrue.inclRange(firstadr, nextadr); |
duke@1 | 572 | initsWhenFalse = inits; |
duke@1 | 573 | uninitsWhenFalse = uninits; |
duke@1 | 574 | } else if (tree.type.isTrue()) { |
duke@1 | 575 | if (inits == null) merge(); |
duke@1 | 576 | initsWhenFalse = inits.dup(); |
duke@1 | 577 | initsWhenFalse.inclRange(firstadr, nextadr); |
duke@1 | 578 | uninitsWhenFalse = uninits.dup(); |
duke@1 | 579 | uninitsWhenFalse.inclRange(firstadr, nextadr); |
duke@1 | 580 | initsWhenTrue = inits; |
duke@1 | 581 | uninitsWhenTrue = uninits; |
duke@1 | 582 | } else { |
duke@1 | 583 | scan(tree); |
mcimadamore@676 | 584 | if (inits != null) |
mcimadamore@676 | 585 | split(tree.type != syms.unknownType); |
duke@1 | 586 | } |
mcimadamore@676 | 587 | if (tree.type != syms.unknownType) |
mcimadamore@676 | 588 | inits = uninits = null; |
duke@1 | 589 | } |
duke@1 | 590 | |
duke@1 | 591 | /* ------------ Visitor methods for various sorts of trees -------------*/ |
duke@1 | 592 | |
duke@1 | 593 | public void visitClassDef(JCClassDecl tree) { |
duke@1 | 594 | if (tree.sym == null) return; |
duke@1 | 595 | |
duke@1 | 596 | JCClassDecl classDefPrev = classDef; |
duke@1 | 597 | List<Type> thrownPrev = thrown; |
duke@1 | 598 | List<Type> caughtPrev = caught; |
duke@1 | 599 | boolean alivePrev = alive; |
duke@1 | 600 | int firstadrPrev = firstadr; |
duke@1 | 601 | int nextadrPrev = nextadr; |
duke@1 | 602 | ListBuffer<PendingExit> pendingExitsPrev = pendingExits; |
duke@1 | 603 | Lint lintPrev = lint; |
duke@1 | 604 | |
duke@1 | 605 | pendingExits = new ListBuffer<PendingExit>(); |
duke@1 | 606 | if (tree.name != names.empty) { |
duke@1 | 607 | caught = List.nil(); |
duke@1 | 608 | firstadr = nextadr; |
duke@1 | 609 | } |
duke@1 | 610 | classDef = tree; |
duke@1 | 611 | thrown = List.nil(); |
duke@1 | 612 | lint = lint.augment(tree.sym.attributes_field); |
duke@1 | 613 | |
duke@1 | 614 | try { |
duke@1 | 615 | // define all the static fields |
duke@1 | 616 | for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) { |
duke@1 | 617 | if (l.head.getTag() == JCTree.VARDEF) { |
duke@1 | 618 | JCVariableDecl def = (JCVariableDecl)l.head; |
duke@1 | 619 | if ((def.mods.flags & STATIC) != 0) { |
duke@1 | 620 | VarSymbol sym = def.sym; |
duke@1 | 621 | if (trackable(sym)) |
duke@1 | 622 | newVar(sym); |
duke@1 | 623 | } |
duke@1 | 624 | } |
duke@1 | 625 | } |
duke@1 | 626 | |
duke@1 | 627 | // process all the static initializers |
duke@1 | 628 | for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) { |
duke@1 | 629 | if (l.head.getTag() != JCTree.METHODDEF && |
duke@1 | 630 | (TreeInfo.flags(l.head) & STATIC) != 0) { |
duke@1 | 631 | scanDef(l.head); |
duke@1 | 632 | errorUncaught(); |
duke@1 | 633 | } |
duke@1 | 634 | } |
duke@1 | 635 | |
duke@1 | 636 | // add intersection of all thrown clauses of initial constructors |
duke@1 | 637 | // to set of caught exceptions, unless class is anonymous. |
duke@1 | 638 | if (tree.name != names.empty) { |
duke@1 | 639 | boolean firstConstructor = true; |
duke@1 | 640 | for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) { |
duke@1 | 641 | if (TreeInfo.isInitialConstructor(l.head)) { |
duke@1 | 642 | List<Type> mthrown = |
duke@1 | 643 | ((JCMethodDecl) l.head).sym.type.getThrownTypes(); |
duke@1 | 644 | if (firstConstructor) { |
duke@1 | 645 | caught = mthrown; |
duke@1 | 646 | firstConstructor = false; |
duke@1 | 647 | } else { |
duke@1 | 648 | caught = chk.intersect(mthrown, caught); |
duke@1 | 649 | } |
duke@1 | 650 | } |
duke@1 | 651 | } |
duke@1 | 652 | } |
duke@1 | 653 | |
duke@1 | 654 | // define all the instance fields |
duke@1 | 655 | for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) { |
duke@1 | 656 | if (l.head.getTag() == JCTree.VARDEF) { |
duke@1 | 657 | JCVariableDecl def = (JCVariableDecl)l.head; |
duke@1 | 658 | if ((def.mods.flags & STATIC) == 0) { |
duke@1 | 659 | VarSymbol sym = def.sym; |
duke@1 | 660 | if (trackable(sym)) |
duke@1 | 661 | newVar(sym); |
duke@1 | 662 | } |
duke@1 | 663 | } |
duke@1 | 664 | } |
duke@1 | 665 | |
duke@1 | 666 | // process all the instance initializers |
duke@1 | 667 | for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) { |
duke@1 | 668 | if (l.head.getTag() != JCTree.METHODDEF && |
duke@1 | 669 | (TreeInfo.flags(l.head) & STATIC) == 0) { |
duke@1 | 670 | scanDef(l.head); |
duke@1 | 671 | errorUncaught(); |
duke@1 | 672 | } |
duke@1 | 673 | } |
duke@1 | 674 | |
duke@1 | 675 | // in an anonymous class, add the set of thrown exceptions to |
duke@1 | 676 | // the throws clause of the synthetic constructor and propagate |
duke@1 | 677 | // outwards. |
dlsmith@880 | 678 | // Changing the throws clause on the fly is okay here because |
dlsmith@880 | 679 | // the anonymous constructor can't be invoked anywhere else, |
dlsmith@880 | 680 | // and its type hasn't been cached. |
duke@1 | 681 | if (tree.name == names.empty) { |
duke@1 | 682 | for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) { |
duke@1 | 683 | if (TreeInfo.isInitialConstructor(l.head)) { |
duke@1 | 684 | JCMethodDecl mdef = (JCMethodDecl)l.head; |
duke@1 | 685 | mdef.thrown = make.Types(thrown); |
dlsmith@880 | 686 | mdef.sym.type = types.createMethodTypeWithThrown(mdef.sym.type, thrown); |
duke@1 | 687 | } |
duke@1 | 688 | } |
duke@1 | 689 | thrownPrev = chk.union(thrown, thrownPrev); |
duke@1 | 690 | } |
duke@1 | 691 | |
duke@1 | 692 | // process all the methods |
duke@1 | 693 | for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) { |
duke@1 | 694 | if (l.head.getTag() == JCTree.METHODDEF) { |
duke@1 | 695 | scan(l.head); |
duke@1 | 696 | errorUncaught(); |
duke@1 | 697 | } |
duke@1 | 698 | } |
duke@1 | 699 | |
duke@1 | 700 | thrown = thrownPrev; |
duke@1 | 701 | } finally { |
duke@1 | 702 | pendingExits = pendingExitsPrev; |
duke@1 | 703 | alive = alivePrev; |
duke@1 | 704 | nextadr = nextadrPrev; |
duke@1 | 705 | firstadr = firstadrPrev; |
duke@1 | 706 | caught = caughtPrev; |
duke@1 | 707 | classDef = classDefPrev; |
duke@1 | 708 | lint = lintPrev; |
duke@1 | 709 | } |
duke@1 | 710 | } |
duke@1 | 711 | |
duke@1 | 712 | public void visitMethodDef(JCMethodDecl tree) { |
duke@1 | 713 | if (tree.body == null) return; |
duke@1 | 714 | |
duke@1 | 715 | List<Type> caughtPrev = caught; |
duke@1 | 716 | List<Type> mthrown = tree.sym.type.getThrownTypes(); |
duke@1 | 717 | Bits initsPrev = inits.dup(); |
duke@1 | 718 | Bits uninitsPrev = uninits.dup(); |
duke@1 | 719 | int nextadrPrev = nextadr; |
duke@1 | 720 | int firstadrPrev = firstadr; |
duke@1 | 721 | Lint lintPrev = lint; |
duke@1 | 722 | |
duke@1 | 723 | lint = lint.augment(tree.sym.attributes_field); |
duke@1 | 724 | |
jjg@816 | 725 | Assert.check(pendingExits.isEmpty()); |
duke@1 | 726 | |
duke@1 | 727 | try { |
duke@1 | 728 | boolean isInitialConstructor = |
duke@1 | 729 | TreeInfo.isInitialConstructor(tree); |
duke@1 | 730 | |
duke@1 | 731 | if (!isInitialConstructor) |
duke@1 | 732 | firstadr = nextadr; |
duke@1 | 733 | for (List<JCVariableDecl> l = tree.params; l.nonEmpty(); l = l.tail) { |
duke@1 | 734 | JCVariableDecl def = l.head; |
duke@1 | 735 | scan(def); |
duke@1 | 736 | inits.incl(def.sym.adr); |
duke@1 | 737 | uninits.excl(def.sym.adr); |
duke@1 | 738 | } |
duke@1 | 739 | if (isInitialConstructor) |
duke@1 | 740 | caught = chk.union(caught, mthrown); |
duke@1 | 741 | else if ((tree.sym.flags() & (BLOCK | STATIC)) != BLOCK) |
duke@1 | 742 | caught = mthrown; |
duke@1 | 743 | // else we are in an instance initializer block; |
duke@1 | 744 | // leave caught unchanged. |
duke@1 | 745 | |
duke@1 | 746 | alive = true; |
duke@1 | 747 | scanStat(tree.body); |
duke@1 | 748 | |
duke@1 | 749 | if (alive && tree.sym.type.getReturnType().tag != VOID) |
duke@1 | 750 | log.error(TreeInfo.diagEndPos(tree.body), "missing.ret.stmt"); |
duke@1 | 751 | |
duke@1 | 752 | if (isInitialConstructor) { |
duke@1 | 753 | for (int i = firstadr; i < nextadr; i++) |
duke@1 | 754 | if (vars[i].owner == classDef.sym) |
duke@1 | 755 | checkInit(TreeInfo.diagEndPos(tree.body), vars[i]); |
duke@1 | 756 | } |
duke@1 | 757 | List<PendingExit> exits = pendingExits.toList(); |
duke@1 | 758 | pendingExits = new ListBuffer<PendingExit>(); |
duke@1 | 759 | while (exits.nonEmpty()) { |
duke@1 | 760 | PendingExit exit = exits.head; |
duke@1 | 761 | exits = exits.tail; |
duke@1 | 762 | if (exit.thrown == null) { |
jjg@816 | 763 | Assert.check(exit.tree.getTag() == JCTree.RETURN); |
duke@1 | 764 | if (isInitialConstructor) { |
duke@1 | 765 | inits = exit.inits; |
duke@1 | 766 | for (int i = firstadr; i < nextadr; i++) |
duke@1 | 767 | checkInit(exit.tree.pos(), vars[i]); |
duke@1 | 768 | } |
duke@1 | 769 | } else { |
duke@1 | 770 | // uncaught throws will be reported later |
duke@1 | 771 | pendingExits.append(exit); |
duke@1 | 772 | } |
duke@1 | 773 | } |
duke@1 | 774 | } finally { |
duke@1 | 775 | inits = initsPrev; |
duke@1 | 776 | uninits = uninitsPrev; |
duke@1 | 777 | nextadr = nextadrPrev; |
duke@1 | 778 | firstadr = firstadrPrev; |
duke@1 | 779 | caught = caughtPrev; |
duke@1 | 780 | lint = lintPrev; |
duke@1 | 781 | } |
duke@1 | 782 | } |
duke@1 | 783 | |
duke@1 | 784 | public void visitVarDef(JCVariableDecl tree) { |
duke@1 | 785 | boolean track = trackable(tree.sym); |
duke@1 | 786 | if (track && tree.sym.owner.kind == MTH) newVar(tree.sym); |
duke@1 | 787 | if (tree.init != null) { |
duke@1 | 788 | Lint lintPrev = lint; |
duke@1 | 789 | lint = lint.augment(tree.sym.attributes_field); |
duke@1 | 790 | try{ |
duke@1 | 791 | scanExpr(tree.init); |
duke@1 | 792 | if (track) letInit(tree.pos(), tree.sym); |
duke@1 | 793 | } finally { |
duke@1 | 794 | lint = lintPrev; |
duke@1 | 795 | } |
duke@1 | 796 | } |
duke@1 | 797 | } |
duke@1 | 798 | |
duke@1 | 799 | public void visitBlock(JCBlock tree) { |
duke@1 | 800 | int nextadrPrev = nextadr; |
duke@1 | 801 | scanStats(tree.stats); |
duke@1 | 802 | nextadr = nextadrPrev; |
duke@1 | 803 | } |
duke@1 | 804 | |
duke@1 | 805 | public void visitDoLoop(JCDoWhileLoop tree) { |
duke@1 | 806 | ListBuffer<PendingExit> prevPendingExits = pendingExits; |
duke@1 | 807 | boolean prevLoopPassTwo = loopPassTwo; |
duke@1 | 808 | pendingExits = new ListBuffer<PendingExit>(); |
mcimadamore@906 | 809 | int prevErrors = log.nerrors; |
duke@1 | 810 | do { |
duke@1 | 811 | Bits uninitsEntry = uninits.dup(); |
mcimadamore@906 | 812 | uninitsEntry.excludeFrom(nextadr); |
duke@1 | 813 | scanStat(tree.body); |
duke@1 | 814 | alive |= resolveContinues(tree); |
duke@1 | 815 | scanCond(tree.cond); |
mcimadamore@906 | 816 | if (log.nerrors != prevErrors || |
duke@1 | 817 | loopPassTwo || |
mcimadamore@906 | 818 | uninitsEntry.dup().diffSet(uninitsWhenTrue).nextBit(firstadr)==-1) |
duke@1 | 819 | break; |
duke@1 | 820 | inits = initsWhenTrue; |
duke@1 | 821 | uninits = uninitsEntry.andSet(uninitsWhenTrue); |
duke@1 | 822 | loopPassTwo = true; |
duke@1 | 823 | alive = true; |
duke@1 | 824 | } while (true); |
duke@1 | 825 | loopPassTwo = prevLoopPassTwo; |
duke@1 | 826 | inits = initsWhenFalse; |
duke@1 | 827 | uninits = uninitsWhenFalse; |
duke@1 | 828 | alive = alive && !tree.cond.type.isTrue(); |
duke@1 | 829 | alive |= resolveBreaks(tree, prevPendingExits); |
duke@1 | 830 | } |
duke@1 | 831 | |
duke@1 | 832 | public void visitWhileLoop(JCWhileLoop tree) { |
duke@1 | 833 | ListBuffer<PendingExit> prevPendingExits = pendingExits; |
duke@1 | 834 | boolean prevLoopPassTwo = loopPassTwo; |
duke@1 | 835 | Bits initsCond; |
duke@1 | 836 | Bits uninitsCond; |
duke@1 | 837 | pendingExits = new ListBuffer<PendingExit>(); |
mcimadamore@906 | 838 | int prevErrors = log.nerrors; |
duke@1 | 839 | do { |
duke@1 | 840 | Bits uninitsEntry = uninits.dup(); |
mcimadamore@906 | 841 | uninitsEntry.excludeFrom(nextadr); |
duke@1 | 842 | scanCond(tree.cond); |
duke@1 | 843 | initsCond = initsWhenFalse; |
duke@1 | 844 | uninitsCond = uninitsWhenFalse; |
duke@1 | 845 | inits = initsWhenTrue; |
duke@1 | 846 | uninits = uninitsWhenTrue; |
duke@1 | 847 | alive = !tree.cond.type.isFalse(); |
duke@1 | 848 | scanStat(tree.body); |
duke@1 | 849 | alive |= resolveContinues(tree); |
mcimadamore@906 | 850 | if (log.nerrors != prevErrors || |
duke@1 | 851 | loopPassTwo || |
mcimadamore@906 | 852 | uninitsEntry.dup().diffSet(uninits).nextBit(firstadr) == -1) |
duke@1 | 853 | break; |
duke@1 | 854 | uninits = uninitsEntry.andSet(uninits); |
duke@1 | 855 | loopPassTwo = true; |
duke@1 | 856 | alive = true; |
duke@1 | 857 | } while (true); |
duke@1 | 858 | loopPassTwo = prevLoopPassTwo; |
duke@1 | 859 | inits = initsCond; |
duke@1 | 860 | uninits = uninitsCond; |
duke@1 | 861 | alive = resolveBreaks(tree, prevPendingExits) || |
duke@1 | 862 | !tree.cond.type.isTrue(); |
duke@1 | 863 | } |
duke@1 | 864 | |
duke@1 | 865 | public void visitForLoop(JCForLoop tree) { |
duke@1 | 866 | ListBuffer<PendingExit> prevPendingExits = pendingExits; |
duke@1 | 867 | boolean prevLoopPassTwo = loopPassTwo; |
duke@1 | 868 | int nextadrPrev = nextadr; |
duke@1 | 869 | scanStats(tree.init); |
duke@1 | 870 | Bits initsCond; |
duke@1 | 871 | Bits uninitsCond; |
duke@1 | 872 | pendingExits = new ListBuffer<PendingExit>(); |
mcimadamore@906 | 873 | int prevErrors = log.nerrors; |
duke@1 | 874 | do { |
duke@1 | 875 | Bits uninitsEntry = uninits.dup(); |
mcimadamore@906 | 876 | uninitsEntry.excludeFrom(nextadr); |
duke@1 | 877 | if (tree.cond != null) { |
duke@1 | 878 | scanCond(tree.cond); |
duke@1 | 879 | initsCond = initsWhenFalse; |
duke@1 | 880 | uninitsCond = uninitsWhenFalse; |
duke@1 | 881 | inits = initsWhenTrue; |
duke@1 | 882 | uninits = uninitsWhenTrue; |
duke@1 | 883 | alive = !tree.cond.type.isFalse(); |
duke@1 | 884 | } else { |
duke@1 | 885 | initsCond = inits.dup(); |
duke@1 | 886 | initsCond.inclRange(firstadr, nextadr); |
duke@1 | 887 | uninitsCond = uninits.dup(); |
duke@1 | 888 | uninitsCond.inclRange(firstadr, nextadr); |
duke@1 | 889 | alive = true; |
duke@1 | 890 | } |
duke@1 | 891 | scanStat(tree.body); |
duke@1 | 892 | alive |= resolveContinues(tree); |
duke@1 | 893 | scan(tree.step); |
mcimadamore@906 | 894 | if (log.nerrors != prevErrors || |
duke@1 | 895 | loopPassTwo || |
duke@1 | 896 | uninitsEntry.dup().diffSet(uninits).nextBit(firstadr) == -1) |
duke@1 | 897 | break; |
duke@1 | 898 | uninits = uninitsEntry.andSet(uninits); |
duke@1 | 899 | loopPassTwo = true; |
duke@1 | 900 | alive = true; |
duke@1 | 901 | } while (true); |
duke@1 | 902 | loopPassTwo = prevLoopPassTwo; |
duke@1 | 903 | inits = initsCond; |
duke@1 | 904 | uninits = uninitsCond; |
duke@1 | 905 | alive = resolveBreaks(tree, prevPendingExits) || |
duke@1 | 906 | tree.cond != null && !tree.cond.type.isTrue(); |
duke@1 | 907 | nextadr = nextadrPrev; |
duke@1 | 908 | } |
duke@1 | 909 | |
duke@1 | 910 | public void visitForeachLoop(JCEnhancedForLoop tree) { |
duke@1 | 911 | visitVarDef(tree.var); |
duke@1 | 912 | |
duke@1 | 913 | ListBuffer<PendingExit> prevPendingExits = pendingExits; |
duke@1 | 914 | boolean prevLoopPassTwo = loopPassTwo; |
duke@1 | 915 | int nextadrPrev = nextadr; |
duke@1 | 916 | scan(tree.expr); |
duke@1 | 917 | Bits initsStart = inits.dup(); |
duke@1 | 918 | Bits uninitsStart = uninits.dup(); |
duke@1 | 919 | |
duke@1 | 920 | letInit(tree.pos(), tree.var.sym); |
duke@1 | 921 | pendingExits = new ListBuffer<PendingExit>(); |
mcimadamore@906 | 922 | int prevErrors = log.nerrors; |
duke@1 | 923 | do { |
duke@1 | 924 | Bits uninitsEntry = uninits.dup(); |
mcimadamore@906 | 925 | uninitsEntry.excludeFrom(nextadr); |
duke@1 | 926 | scanStat(tree.body); |
duke@1 | 927 | alive |= resolveContinues(tree); |
mcimadamore@906 | 928 | if (log.nerrors != prevErrors || |
duke@1 | 929 | loopPassTwo || |
mcimadamore@906 | 930 | uninitsEntry.dup().diffSet(uninits).nextBit(firstadr) == -1) |
duke@1 | 931 | break; |
duke@1 | 932 | uninits = uninitsEntry.andSet(uninits); |
duke@1 | 933 | loopPassTwo = true; |
duke@1 | 934 | alive = true; |
duke@1 | 935 | } while (true); |
duke@1 | 936 | loopPassTwo = prevLoopPassTwo; |
duke@1 | 937 | inits = initsStart; |
duke@1 | 938 | uninits = uninitsStart.andSet(uninits); |
duke@1 | 939 | resolveBreaks(tree, prevPendingExits); |
duke@1 | 940 | alive = true; |
duke@1 | 941 | nextadr = nextadrPrev; |
duke@1 | 942 | } |
duke@1 | 943 | |
duke@1 | 944 | public void visitLabelled(JCLabeledStatement tree) { |
duke@1 | 945 | ListBuffer<PendingExit> prevPendingExits = pendingExits; |
duke@1 | 946 | pendingExits = new ListBuffer<PendingExit>(); |
duke@1 | 947 | scanStat(tree.body); |
duke@1 | 948 | alive |= resolveBreaks(tree, prevPendingExits); |
duke@1 | 949 | } |
duke@1 | 950 | |
duke@1 | 951 | public void visitSwitch(JCSwitch tree) { |
duke@1 | 952 | ListBuffer<PendingExit> prevPendingExits = pendingExits; |
duke@1 | 953 | pendingExits = new ListBuffer<PendingExit>(); |
duke@1 | 954 | int nextadrPrev = nextadr; |
duke@1 | 955 | scanExpr(tree.selector); |
duke@1 | 956 | Bits initsSwitch = inits; |
duke@1 | 957 | Bits uninitsSwitch = uninits.dup(); |
duke@1 | 958 | boolean hasDefault = false; |
duke@1 | 959 | for (List<JCCase> l = tree.cases; l.nonEmpty(); l = l.tail) { |
duke@1 | 960 | alive = true; |
duke@1 | 961 | inits = initsSwitch.dup(); |
duke@1 | 962 | uninits = uninits.andSet(uninitsSwitch); |
duke@1 | 963 | JCCase c = l.head; |
duke@1 | 964 | if (c.pat == null) |
duke@1 | 965 | hasDefault = true; |
duke@1 | 966 | else |
duke@1 | 967 | scanExpr(c.pat); |
duke@1 | 968 | scanStats(c.stats); |
duke@1 | 969 | addVars(c.stats, initsSwitch, uninitsSwitch); |
duke@1 | 970 | // Warn about fall-through if lint switch fallthrough enabled. |
duke@1 | 971 | if (!loopPassTwo && |
duke@1 | 972 | alive && |
duke@1 | 973 | lint.isEnabled(Lint.LintCategory.FALLTHROUGH) && |
duke@1 | 974 | c.stats.nonEmpty() && l.tail.nonEmpty()) |
jjg@612 | 975 | log.warning(Lint.LintCategory.FALLTHROUGH, |
jjg@612 | 976 | l.tail.head.pos(), |
duke@1 | 977 | "possible.fall-through.into.case"); |
duke@1 | 978 | } |
duke@1 | 979 | if (!hasDefault) { |
duke@1 | 980 | inits.andSet(initsSwitch); |
duke@1 | 981 | alive = true; |
duke@1 | 982 | } |
duke@1 | 983 | alive |= resolveBreaks(tree, prevPendingExits); |
duke@1 | 984 | nextadr = nextadrPrev; |
duke@1 | 985 | } |
duke@1 | 986 | // where |
duke@1 | 987 | /** Add any variables defined in stats to inits and uninits. */ |
duke@1 | 988 | private static void addVars(List<JCStatement> stats, Bits inits, |
duke@1 | 989 | Bits uninits) { |
duke@1 | 990 | for (;stats.nonEmpty(); stats = stats.tail) { |
duke@1 | 991 | JCTree stat = stats.head; |
duke@1 | 992 | if (stat.getTag() == JCTree.VARDEF) { |
duke@1 | 993 | int adr = ((JCVariableDecl) stat).sym.adr; |
duke@1 | 994 | inits.excl(adr); |
duke@1 | 995 | uninits.incl(adr); |
duke@1 | 996 | } |
duke@1 | 997 | } |
duke@1 | 998 | } |
duke@1 | 999 | |
duke@1 | 1000 | public void visitTry(JCTry tree) { |
duke@1 | 1001 | List<Type> caughtPrev = caught; |
duke@1 | 1002 | List<Type> thrownPrev = thrown; |
duke@1 | 1003 | thrown = List.nil(); |
mcimadamore@550 | 1004 | for (List<JCCatch> l = tree.catchers; l.nonEmpty(); l = l.tail) { |
mcimadamore@550 | 1005 | List<JCExpression> subClauses = TreeInfo.isMultiCatch(l.head) ? |
darcy@969 | 1006 | ((JCTypeUnion)l.head.param.vartype).alternatives : |
mcimadamore@550 | 1007 | List.of(l.head.param.vartype); |
mcimadamore@550 | 1008 | for (JCExpression ct : subClauses) { |
mcimadamore@550 | 1009 | caught = chk.incl(ct.type, caught); |
mcimadamore@550 | 1010 | } |
mcimadamore@550 | 1011 | } |
mcimadamore@905 | 1012 | ListBuffer<JCVariableDecl> resourceVarDecls = ListBuffer.lb(); |
duke@1 | 1013 | Bits uninitsTryPrev = uninitsTry; |
duke@1 | 1014 | ListBuffer<PendingExit> prevPendingExits = pendingExits; |
duke@1 | 1015 | pendingExits = new ListBuffer<PendingExit>(); |
duke@1 | 1016 | Bits initsTry = inits.dup(); |
duke@1 | 1017 | uninitsTry = uninits.dup(); |
darcy@609 | 1018 | for (JCTree resource : tree.resources) { |
darcy@609 | 1019 | if (resource instanceof JCVariableDecl) { |
darcy@609 | 1020 | JCVariableDecl vdecl = (JCVariableDecl) resource; |
darcy@609 | 1021 | visitVarDef(vdecl); |
mcimadamore@905 | 1022 | unrefdResources.enter(vdecl.sym); |
mcimadamore@905 | 1023 | resourceVarDecls.append(vdecl); |
darcy@609 | 1024 | } else if (resource instanceof JCExpression) { |
darcy@609 | 1025 | scanExpr((JCExpression) resource); |
darcy@609 | 1026 | } else { |
darcy@609 | 1027 | throw new AssertionError(tree); // parser error |
darcy@609 | 1028 | } |
darcy@609 | 1029 | } |
darcy@609 | 1030 | for (JCTree resource : tree.resources) { |
darcy@609 | 1031 | List<Type> closeableSupertypes = resource.type.isCompound() ? |
darcy@609 | 1032 | types.interfaces(resource.type).prepend(types.supertype(resource.type)) : |
darcy@609 | 1033 | List.of(resource.type); |
darcy@609 | 1034 | for (Type sup : closeableSupertypes) { |
darcy@609 | 1035 | if (types.asSuper(sup, syms.autoCloseableType.tsym) != null) { |
mcimadamore@676 | 1036 | Symbol closeMethod = rs.resolveQualifiedMethod(tree, |
mcimadamore@617 | 1037 | attrEnv, |
mcimadamore@617 | 1038 | sup, |
mcimadamore@617 | 1039 | names.close, |
mcimadamore@617 | 1040 | List.<Type>nil(), |
mcimadamore@617 | 1041 | List.<Type>nil()); |
mcimadamore@617 | 1042 | if (closeMethod.kind == MTH) { |
mcimadamore@617 | 1043 | for (Type t : ((MethodSymbol)closeMethod).getThrownTypes()) { |
mcimadamore@878 | 1044 | markThrown(resource, t); |
mcimadamore@617 | 1045 | } |
darcy@609 | 1046 | } |
darcy@609 | 1047 | } |
darcy@609 | 1048 | } |
darcy@609 | 1049 | } |
duke@1 | 1050 | scanStat(tree.body); |
mcimadamore@935 | 1051 | List<Type> thrownInTry = allowImprovedCatchAnalysis ? |
mcimadamore@935 | 1052 | chk.union(thrown, List.of(syms.runtimeExceptionType, syms.errorType)) : |
mcimadamore@935 | 1053 | thrown; |
duke@1 | 1054 | thrown = thrownPrev; |
duke@1 | 1055 | caught = caughtPrev; |
duke@1 | 1056 | boolean aliveEnd = alive; |
duke@1 | 1057 | uninitsTry.andSet(uninits); |
duke@1 | 1058 | Bits initsEnd = inits; |
duke@1 | 1059 | Bits uninitsEnd = uninits; |
duke@1 | 1060 | int nextadrCatch = nextadr; |
duke@1 | 1061 | |
mcimadamore@905 | 1062 | if (!resourceVarDecls.isEmpty() && |
mcimadamore@743 | 1063 | lint.isEnabled(Lint.LintCategory.TRY)) { |
mcimadamore@905 | 1064 | for (JCVariableDecl resVar : resourceVarDecls) { |
mcimadamore@905 | 1065 | if (unrefdResources.includes(resVar.sym)) { |
mcimadamore@905 | 1066 | log.warning(Lint.LintCategory.TRY, resVar.pos(), |
mcimadamore@905 | 1067 | "try.resource.not.referenced", resVar.sym); |
mcimadamore@905 | 1068 | unrefdResources.remove(resVar.sym); |
mcimadamore@905 | 1069 | } |
darcy@609 | 1070 | } |
darcy@609 | 1071 | } |
darcy@609 | 1072 | |
duke@1 | 1073 | List<Type> caughtInTry = List.nil(); |
duke@1 | 1074 | for (List<JCCatch> l = tree.catchers; l.nonEmpty(); l = l.tail) { |
duke@1 | 1075 | alive = true; |
duke@1 | 1076 | JCVariableDecl param = l.head.param; |
mcimadamore@550 | 1077 | List<JCExpression> subClauses = TreeInfo.isMultiCatch(l.head) ? |
darcy@969 | 1078 | ((JCTypeUnion)l.head.param.vartype).alternatives : |
mcimadamore@550 | 1079 | List.of(l.head.param.vartype); |
mcimadamore@550 | 1080 | List<Type> ctypes = List.nil(); |
mcimadamore@550 | 1081 | List<Type> rethrownTypes = chk.diff(thrownInTry, caughtInTry); |
mcimadamore@550 | 1082 | for (JCExpression ct : subClauses) { |
mcimadamore@550 | 1083 | Type exc = ct.type; |
mcimadamore@676 | 1084 | if (exc != syms.unknownType) { |
mcimadamore@676 | 1085 | ctypes = ctypes.append(exc); |
mcimadamore@676 | 1086 | if (types.isSameType(exc, syms.objectType)) |
mcimadamore@676 | 1087 | continue; |
mcimadamore@935 | 1088 | checkCaughtType(l.head.pos(), exc, thrownInTry, caughtInTry); |
mcimadamore@676 | 1089 | caughtInTry = chk.incl(exc, caughtInTry); |
mcimadamore@550 | 1090 | } |
duke@1 | 1091 | } |
duke@1 | 1092 | inits = initsTry.dup(); |
duke@1 | 1093 | uninits = uninitsTry.dup(); |
duke@1 | 1094 | scan(param); |
duke@1 | 1095 | inits.incl(param.sym.adr); |
duke@1 | 1096 | uninits.excl(param.sym.adr); |
mcimadamore@735 | 1097 | preciseRethrowTypes.put(param.sym, chk.intersect(ctypes, rethrownTypes)); |
duke@1 | 1098 | scanStat(l.head.body); |
duke@1 | 1099 | initsEnd.andSet(inits); |
duke@1 | 1100 | uninitsEnd.andSet(uninits); |
duke@1 | 1101 | nextadr = nextadrCatch; |
mcimadamore@735 | 1102 | preciseRethrowTypes.remove(param.sym); |
duke@1 | 1103 | aliveEnd |= alive; |
duke@1 | 1104 | } |
duke@1 | 1105 | if (tree.finalizer != null) { |
duke@1 | 1106 | List<Type> savedThrown = thrown; |
duke@1 | 1107 | thrown = List.nil(); |
duke@1 | 1108 | inits = initsTry.dup(); |
duke@1 | 1109 | uninits = uninitsTry.dup(); |
duke@1 | 1110 | ListBuffer<PendingExit> exits = pendingExits; |
duke@1 | 1111 | pendingExits = prevPendingExits; |
duke@1 | 1112 | alive = true; |
duke@1 | 1113 | scanStat(tree.finalizer); |
duke@1 | 1114 | if (!alive) { |
duke@1 | 1115 | // discard exits and exceptions from try and finally |
duke@1 | 1116 | thrown = chk.union(thrown, thrownPrev); |
duke@1 | 1117 | if (!loopPassTwo && |
duke@1 | 1118 | lint.isEnabled(Lint.LintCategory.FINALLY)) { |
jjg@612 | 1119 | log.warning(Lint.LintCategory.FINALLY, |
jjg@612 | 1120 | TreeInfo.diagEndPos(tree.finalizer), |
jjg@612 | 1121 | "finally.cannot.complete"); |
duke@1 | 1122 | } |
duke@1 | 1123 | } else { |
duke@1 | 1124 | thrown = chk.union(thrown, chk.diff(thrownInTry, caughtInTry)); |
duke@1 | 1125 | thrown = chk.union(thrown, savedThrown); |
duke@1 | 1126 | uninits.andSet(uninitsEnd); |
duke@1 | 1127 | // FIX: this doesn't preserve source order of exits in catch |
duke@1 | 1128 | // versus finally! |
duke@1 | 1129 | while (exits.nonEmpty()) { |
duke@1 | 1130 | PendingExit exit = exits.next(); |
duke@1 | 1131 | if (exit.inits != null) { |
duke@1 | 1132 | exit.inits.orSet(inits); |
duke@1 | 1133 | exit.uninits.andSet(uninits); |
duke@1 | 1134 | } |
duke@1 | 1135 | pendingExits.append(exit); |
duke@1 | 1136 | } |
duke@1 | 1137 | inits.orSet(initsEnd); |
duke@1 | 1138 | alive = aliveEnd; |
duke@1 | 1139 | } |
duke@1 | 1140 | } else { |
duke@1 | 1141 | thrown = chk.union(thrown, chk.diff(thrownInTry, caughtInTry)); |
duke@1 | 1142 | inits = initsEnd; |
duke@1 | 1143 | uninits = uninitsEnd; |
duke@1 | 1144 | alive = aliveEnd; |
duke@1 | 1145 | ListBuffer<PendingExit> exits = pendingExits; |
duke@1 | 1146 | pendingExits = prevPendingExits; |
duke@1 | 1147 | while (exits.nonEmpty()) pendingExits.append(exits.next()); |
duke@1 | 1148 | } |
duke@1 | 1149 | uninitsTry.andSet(uninitsTryPrev).andSet(uninits); |
duke@1 | 1150 | } |
duke@1 | 1151 | |
mcimadamore@935 | 1152 | void checkCaughtType(DiagnosticPosition pos, Type exc, List<Type> thrownInTry, List<Type> caughtInTry) { |
mcimadamore@935 | 1153 | if (chk.subset(exc, caughtInTry)) { |
mcimadamore@935 | 1154 | log.error(pos, "except.already.caught", exc); |
mcimadamore@935 | 1155 | } else if (!chk.isUnchecked(pos, exc) && |
mcimadamore@990 | 1156 | !isExceptionOrThrowable(exc) && |
mcimadamore@935 | 1157 | !chk.intersects(exc, thrownInTry)) { |
mcimadamore@935 | 1158 | log.error(pos, "except.never.thrown.in.try", exc); |
mcimadamore@935 | 1159 | } else if (allowImprovedCatchAnalysis) { |
mcimadamore@935 | 1160 | List<Type> catchableThrownTypes = chk.intersect(List.of(exc), thrownInTry); |
mcimadamore@935 | 1161 | // 'catchableThrownTypes' cannnot possibly be empty - if 'exc' was an |
mcimadamore@935 | 1162 | // unchecked exception, the result list would not be empty, as the augmented |
mcimadamore@935 | 1163 | // thrown set includes { RuntimeException, Error }; if 'exc' was a checked |
mcimadamore@935 | 1164 | // exception, that would have been covered in the branch above |
mcimadamore@990 | 1165 | if (chk.diff(catchableThrownTypes, caughtInTry).isEmpty() && |
mcimadamore@990 | 1166 | !isExceptionOrThrowable(exc)) { |
mcimadamore@935 | 1167 | String key = catchableThrownTypes.length() == 1 ? |
mcimadamore@935 | 1168 | "unreachable.catch" : |
mcimadamore@935 | 1169 | "unreachable.catch.1"; |
mcimadamore@935 | 1170 | log.warning(pos, key, catchableThrownTypes); |
mcimadamore@935 | 1171 | } |
mcimadamore@935 | 1172 | } |
mcimadamore@935 | 1173 | } |
mcimadamore@990 | 1174 | //where |
mcimadamore@990 | 1175 | private boolean isExceptionOrThrowable(Type exc) { |
mcimadamore@990 | 1176 | return exc.tsym == syms.throwableType.tsym || |
mcimadamore@990 | 1177 | exc.tsym == syms.exceptionType.tsym; |
mcimadamore@990 | 1178 | } |
mcimadamore@990 | 1179 | |
mcimadamore@935 | 1180 | |
duke@1 | 1181 | public void visitConditional(JCConditional tree) { |
duke@1 | 1182 | scanCond(tree.cond); |
duke@1 | 1183 | Bits initsBeforeElse = initsWhenFalse; |
duke@1 | 1184 | Bits uninitsBeforeElse = uninitsWhenFalse; |
duke@1 | 1185 | inits = initsWhenTrue; |
duke@1 | 1186 | uninits = uninitsWhenTrue; |
duke@1 | 1187 | if (tree.truepart.type.tag == BOOLEAN && |
duke@1 | 1188 | tree.falsepart.type.tag == BOOLEAN) { |
duke@1 | 1189 | // if b and c are boolean valued, then |
duke@1 | 1190 | // v is (un)assigned after a?b:c when true iff |
duke@1 | 1191 | // v is (un)assigned after b when true and |
duke@1 | 1192 | // v is (un)assigned after c when true |
duke@1 | 1193 | scanCond(tree.truepart); |
duke@1 | 1194 | Bits initsAfterThenWhenTrue = initsWhenTrue.dup(); |
duke@1 | 1195 | Bits initsAfterThenWhenFalse = initsWhenFalse.dup(); |
duke@1 | 1196 | Bits uninitsAfterThenWhenTrue = uninitsWhenTrue.dup(); |
duke@1 | 1197 | Bits uninitsAfterThenWhenFalse = uninitsWhenFalse.dup(); |
duke@1 | 1198 | inits = initsBeforeElse; |
duke@1 | 1199 | uninits = uninitsBeforeElse; |
duke@1 | 1200 | scanCond(tree.falsepart); |
duke@1 | 1201 | initsWhenTrue.andSet(initsAfterThenWhenTrue); |
duke@1 | 1202 | initsWhenFalse.andSet(initsAfterThenWhenFalse); |
duke@1 | 1203 | uninitsWhenTrue.andSet(uninitsAfterThenWhenTrue); |
duke@1 | 1204 | uninitsWhenFalse.andSet(uninitsAfterThenWhenFalse); |
duke@1 | 1205 | } else { |
duke@1 | 1206 | scanExpr(tree.truepart); |
duke@1 | 1207 | Bits initsAfterThen = inits.dup(); |
duke@1 | 1208 | Bits uninitsAfterThen = uninits.dup(); |
duke@1 | 1209 | inits = initsBeforeElse; |
duke@1 | 1210 | uninits = uninitsBeforeElse; |
duke@1 | 1211 | scanExpr(tree.falsepart); |
duke@1 | 1212 | inits.andSet(initsAfterThen); |
duke@1 | 1213 | uninits.andSet(uninitsAfterThen); |
duke@1 | 1214 | } |
duke@1 | 1215 | } |
duke@1 | 1216 | |
duke@1 | 1217 | public void visitIf(JCIf tree) { |
duke@1 | 1218 | scanCond(tree.cond); |
duke@1 | 1219 | Bits initsBeforeElse = initsWhenFalse; |
duke@1 | 1220 | Bits uninitsBeforeElse = uninitsWhenFalse; |
duke@1 | 1221 | inits = initsWhenTrue; |
duke@1 | 1222 | uninits = uninitsWhenTrue; |
duke@1 | 1223 | scanStat(tree.thenpart); |
duke@1 | 1224 | if (tree.elsepart != null) { |
duke@1 | 1225 | boolean aliveAfterThen = alive; |
duke@1 | 1226 | alive = true; |
duke@1 | 1227 | Bits initsAfterThen = inits.dup(); |
duke@1 | 1228 | Bits uninitsAfterThen = uninits.dup(); |
duke@1 | 1229 | inits = initsBeforeElse; |
duke@1 | 1230 | uninits = uninitsBeforeElse; |
duke@1 | 1231 | scanStat(tree.elsepart); |
duke@1 | 1232 | inits.andSet(initsAfterThen); |
duke@1 | 1233 | uninits.andSet(uninitsAfterThen); |
duke@1 | 1234 | alive = alive | aliveAfterThen; |
duke@1 | 1235 | } else { |
duke@1 | 1236 | inits.andSet(initsBeforeElse); |
duke@1 | 1237 | uninits.andSet(uninitsBeforeElse); |
duke@1 | 1238 | alive = true; |
duke@1 | 1239 | } |
duke@1 | 1240 | } |
duke@1 | 1241 | |
duke@1 | 1242 | |
duke@1 | 1243 | |
duke@1 | 1244 | public void visitBreak(JCBreak tree) { |
duke@1 | 1245 | recordExit(tree); |
duke@1 | 1246 | } |
duke@1 | 1247 | |
duke@1 | 1248 | public void visitContinue(JCContinue tree) { |
duke@1 | 1249 | recordExit(tree); |
duke@1 | 1250 | } |
duke@1 | 1251 | |
duke@1 | 1252 | public void visitReturn(JCReturn tree) { |
duke@1 | 1253 | scanExpr(tree.expr); |
duke@1 | 1254 | // if not initial constructor, should markDead instead of recordExit |
duke@1 | 1255 | recordExit(tree); |
duke@1 | 1256 | } |
duke@1 | 1257 | |
duke@1 | 1258 | public void visitThrow(JCThrow tree) { |
duke@1 | 1259 | scanExpr(tree.expr); |
mcimadamore@550 | 1260 | Symbol sym = TreeInfo.symbol(tree.expr); |
mcimadamore@550 | 1261 | if (sym != null && |
mcimadamore@550 | 1262 | sym.kind == VAR && |
mcimadamore@735 | 1263 | (sym.flags() & (FINAL | EFFECTIVELY_FINAL)) != 0 && |
mcimadamore@735 | 1264 | preciseRethrowTypes.get(sym) != null && |
mcimadamore@935 | 1265 | allowImprovedRethrowAnalysis) { |
mcimadamore@735 | 1266 | for (Type t : preciseRethrowTypes.get(sym)) { |
mcimadamore@550 | 1267 | markThrown(tree, t); |
mcimadamore@550 | 1268 | } |
mcimadamore@550 | 1269 | } |
mcimadamore@550 | 1270 | else { |
mcimadamore@550 | 1271 | markThrown(tree, tree.expr.type); |
mcimadamore@550 | 1272 | } |
duke@1 | 1273 | markDead(); |
duke@1 | 1274 | } |
duke@1 | 1275 | |
duke@1 | 1276 | public void visitApply(JCMethodInvocation tree) { |
duke@1 | 1277 | scanExpr(tree.meth); |
duke@1 | 1278 | scanExprs(tree.args); |
duke@1 | 1279 | for (List<Type> l = tree.meth.type.getThrownTypes(); l.nonEmpty(); l = l.tail) |
duke@1 | 1280 | markThrown(tree, l.head); |
duke@1 | 1281 | } |
duke@1 | 1282 | |
duke@1 | 1283 | public void visitNewClass(JCNewClass tree) { |
duke@1 | 1284 | scanExpr(tree.encl); |
duke@1 | 1285 | scanExprs(tree.args); |
duke@1 | 1286 | // scan(tree.def); |
mcimadamore@186 | 1287 | for (List<Type> l = tree.constructorType.getThrownTypes(); |
duke@1 | 1288 | l.nonEmpty(); |
mcimadamore@186 | 1289 | l = l.tail) { |
duke@1 | 1290 | markThrown(tree, l.head); |
mcimadamore@186 | 1291 | } |
mcimadamore@186 | 1292 | List<Type> caughtPrev = caught; |
mcimadamore@186 | 1293 | try { |
mcimadamore@186 | 1294 | // If the new class expression defines an anonymous class, |
mcimadamore@186 | 1295 | // analysis of the anonymous constructor may encounter thrown |
mcimadamore@186 | 1296 | // types which are unsubstituted type variables. |
mcimadamore@186 | 1297 | // However, since the constructor's actual thrown types have |
mcimadamore@186 | 1298 | // already been marked as thrown, it is safe to simply include |
mcimadamore@186 | 1299 | // each of the constructor's formal thrown types in the set of |
mcimadamore@186 | 1300 | // 'caught/declared to be thrown' types, for the duration of |
mcimadamore@186 | 1301 | // the class def analysis. |
mcimadamore@186 | 1302 | if (tree.def != null) |
mcimadamore@186 | 1303 | for (List<Type> l = tree.constructor.type.getThrownTypes(); |
mcimadamore@186 | 1304 | l.nonEmpty(); |
mcimadamore@186 | 1305 | l = l.tail) { |
mcimadamore@186 | 1306 | caught = chk.incl(l.head, caught); |
mcimadamore@186 | 1307 | } |
mcimadamore@186 | 1308 | scan(tree.def); |
mcimadamore@186 | 1309 | } |
mcimadamore@186 | 1310 | finally { |
mcimadamore@186 | 1311 | caught = caughtPrev; |
mcimadamore@186 | 1312 | } |
duke@1 | 1313 | } |
duke@1 | 1314 | |
duke@1 | 1315 | public void visitNewArray(JCNewArray tree) { |
duke@1 | 1316 | scanExprs(tree.dims); |
duke@1 | 1317 | scanExprs(tree.elems); |
duke@1 | 1318 | } |
duke@1 | 1319 | |
duke@1 | 1320 | public void visitAssert(JCAssert tree) { |
duke@1 | 1321 | Bits initsExit = inits.dup(); |
duke@1 | 1322 | Bits uninitsExit = uninits.dup(); |
duke@1 | 1323 | scanCond(tree.cond); |
duke@1 | 1324 | uninitsExit.andSet(uninitsWhenTrue); |
duke@1 | 1325 | if (tree.detail != null) { |
duke@1 | 1326 | inits = initsWhenFalse; |
duke@1 | 1327 | uninits = uninitsWhenFalse; |
duke@1 | 1328 | scanExpr(tree.detail); |
duke@1 | 1329 | } |
duke@1 | 1330 | inits = initsExit; |
duke@1 | 1331 | uninits = uninitsExit; |
duke@1 | 1332 | } |
duke@1 | 1333 | |
duke@1 | 1334 | public void visitAssign(JCAssign tree) { |
duke@1 | 1335 | JCTree lhs = TreeInfo.skipParens(tree.lhs); |
duke@1 | 1336 | if (!(lhs instanceof JCIdent)) scanExpr(lhs); |
duke@1 | 1337 | scanExpr(tree.rhs); |
duke@1 | 1338 | letInit(lhs); |
duke@1 | 1339 | } |
duke@1 | 1340 | |
duke@1 | 1341 | public void visitAssignop(JCAssignOp tree) { |
duke@1 | 1342 | scanExpr(tree.lhs); |
duke@1 | 1343 | scanExpr(tree.rhs); |
duke@1 | 1344 | letInit(tree.lhs); |
duke@1 | 1345 | } |
duke@1 | 1346 | |
duke@1 | 1347 | public void visitUnary(JCUnary tree) { |
duke@1 | 1348 | switch (tree.getTag()) { |
duke@1 | 1349 | case JCTree.NOT: |
duke@1 | 1350 | scanCond(tree.arg); |
duke@1 | 1351 | Bits t = initsWhenFalse; |
duke@1 | 1352 | initsWhenFalse = initsWhenTrue; |
duke@1 | 1353 | initsWhenTrue = t; |
duke@1 | 1354 | t = uninitsWhenFalse; |
duke@1 | 1355 | uninitsWhenFalse = uninitsWhenTrue; |
duke@1 | 1356 | uninitsWhenTrue = t; |
duke@1 | 1357 | break; |
duke@1 | 1358 | case JCTree.PREINC: case JCTree.POSTINC: |
duke@1 | 1359 | case JCTree.PREDEC: case JCTree.POSTDEC: |
duke@1 | 1360 | scanExpr(tree.arg); |
duke@1 | 1361 | letInit(tree.arg); |
duke@1 | 1362 | break; |
duke@1 | 1363 | default: |
duke@1 | 1364 | scanExpr(tree.arg); |
duke@1 | 1365 | } |
duke@1 | 1366 | } |
duke@1 | 1367 | |
duke@1 | 1368 | public void visitBinary(JCBinary tree) { |
duke@1 | 1369 | switch (tree.getTag()) { |
duke@1 | 1370 | case JCTree.AND: |
duke@1 | 1371 | scanCond(tree.lhs); |
duke@1 | 1372 | Bits initsWhenFalseLeft = initsWhenFalse; |
duke@1 | 1373 | Bits uninitsWhenFalseLeft = uninitsWhenFalse; |
duke@1 | 1374 | inits = initsWhenTrue; |
duke@1 | 1375 | uninits = uninitsWhenTrue; |
duke@1 | 1376 | scanCond(tree.rhs); |
duke@1 | 1377 | initsWhenFalse.andSet(initsWhenFalseLeft); |
duke@1 | 1378 | uninitsWhenFalse.andSet(uninitsWhenFalseLeft); |
duke@1 | 1379 | break; |
duke@1 | 1380 | case JCTree.OR: |
duke@1 | 1381 | scanCond(tree.lhs); |
duke@1 | 1382 | Bits initsWhenTrueLeft = initsWhenTrue; |
duke@1 | 1383 | Bits uninitsWhenTrueLeft = uninitsWhenTrue; |
duke@1 | 1384 | inits = initsWhenFalse; |
duke@1 | 1385 | uninits = uninitsWhenFalse; |
duke@1 | 1386 | scanCond(tree.rhs); |
duke@1 | 1387 | initsWhenTrue.andSet(initsWhenTrueLeft); |
duke@1 | 1388 | uninitsWhenTrue.andSet(uninitsWhenTrueLeft); |
duke@1 | 1389 | break; |
duke@1 | 1390 | default: |
duke@1 | 1391 | scanExpr(tree.lhs); |
duke@1 | 1392 | scanExpr(tree.rhs); |
duke@1 | 1393 | } |
duke@1 | 1394 | } |
duke@1 | 1395 | |
duke@1 | 1396 | public void visitIdent(JCIdent tree) { |
darcy@609 | 1397 | if (tree.sym.kind == VAR) { |
duke@1 | 1398 | checkInit(tree.pos(), (VarSymbol)tree.sym); |
darcy@609 | 1399 | referenced(tree.sym); |
darcy@609 | 1400 | } |
darcy@609 | 1401 | } |
darcy@609 | 1402 | |
darcy@609 | 1403 | void referenced(Symbol sym) { |
mcimadamore@905 | 1404 | unrefdResources.remove(sym); |
duke@1 | 1405 | } |
duke@1 | 1406 | |
duke@1 | 1407 | public void visitTypeCast(JCTypeCast tree) { |
duke@1 | 1408 | super.visitTypeCast(tree); |
duke@1 | 1409 | if (!tree.type.isErroneous() |
duke@1 | 1410 | && lint.isEnabled(Lint.LintCategory.CAST) |
jjg@308 | 1411 | && types.isSameType(tree.expr.type, tree.clazz.type) |
mcimadamore@742 | 1412 | && !is292targetTypeCast(tree)) { |
jjg@612 | 1413 | log.warning(Lint.LintCategory.CAST, |
jjg@612 | 1414 | tree.pos(), "redundant.cast", tree.expr.type); |
duke@1 | 1415 | } |
duke@1 | 1416 | } |
mcimadamore@742 | 1417 | //where |
mcimadamore@742 | 1418 | private boolean is292targetTypeCast(JCTypeCast tree) { |
mcimadamore@742 | 1419 | boolean is292targetTypeCast = false; |
mcimadamore@820 | 1420 | JCExpression expr = TreeInfo.skipParens(tree.expr); |
mcimadamore@820 | 1421 | if (expr.getTag() == JCTree.APPLY) { |
mcimadamore@820 | 1422 | JCMethodInvocation apply = (JCMethodInvocation)expr; |
mcimadamore@742 | 1423 | Symbol sym = TreeInfo.symbol(apply.meth); |
mcimadamore@742 | 1424 | is292targetTypeCast = sym != null && |
mcimadamore@742 | 1425 | sym.kind == MTH && |
mcimadamore@742 | 1426 | (sym.flags() & POLYMORPHIC_SIGNATURE) != 0; |
mcimadamore@742 | 1427 | } |
mcimadamore@742 | 1428 | return is292targetTypeCast; |
mcimadamore@742 | 1429 | } |
duke@1 | 1430 | |
duke@1 | 1431 | public void visitTopLevel(JCCompilationUnit tree) { |
duke@1 | 1432 | // Do nothing for TopLevel since each class is visited individually |
duke@1 | 1433 | } |
duke@1 | 1434 | |
duke@1 | 1435 | /************************************************************************** |
duke@1 | 1436 | * main method |
duke@1 | 1437 | *************************************************************************/ |
duke@1 | 1438 | |
duke@1 | 1439 | /** Perform definite assignment/unassignment analysis on a tree. |
duke@1 | 1440 | */ |
mcimadamore@617 | 1441 | public void analyzeTree(Env<AttrContext> env, TreeMaker make) { |
duke@1 | 1442 | try { |
mcimadamore@617 | 1443 | attrEnv = env; |
mcimadamore@617 | 1444 | JCTree tree = env.tree; |
duke@1 | 1445 | this.make = make; |
duke@1 | 1446 | inits = new Bits(); |
duke@1 | 1447 | uninits = new Bits(); |
duke@1 | 1448 | uninitsTry = new Bits(); |
duke@1 | 1449 | initsWhenTrue = initsWhenFalse = |
duke@1 | 1450 | uninitsWhenTrue = uninitsWhenFalse = null; |
duke@1 | 1451 | if (vars == null) |
duke@1 | 1452 | vars = new VarSymbol[32]; |
duke@1 | 1453 | else |
duke@1 | 1454 | for (int i=0; i<vars.length; i++) |
duke@1 | 1455 | vars[i] = null; |
duke@1 | 1456 | firstadr = 0; |
duke@1 | 1457 | nextadr = 0; |
duke@1 | 1458 | pendingExits = new ListBuffer<PendingExit>(); |
mcimadamore@735 | 1459 | preciseRethrowTypes = new HashMap<Symbol, List<Type>>(); |
duke@1 | 1460 | alive = true; |
duke@1 | 1461 | this.thrown = this.caught = null; |
duke@1 | 1462 | this.classDef = null; |
mcimadamore@905 | 1463 | unrefdResources = new Scope(env.enclClass.sym); |
duke@1 | 1464 | scan(tree); |
duke@1 | 1465 | } finally { |
duke@1 | 1466 | // note that recursive invocations of this method fail hard |
duke@1 | 1467 | inits = uninits = uninitsTry = null; |
duke@1 | 1468 | initsWhenTrue = initsWhenFalse = |
duke@1 | 1469 | uninitsWhenTrue = uninitsWhenFalse = null; |
duke@1 | 1470 | if (vars != null) for (int i=0; i<vars.length; i++) |
duke@1 | 1471 | vars[i] = null; |
duke@1 | 1472 | firstadr = 0; |
duke@1 | 1473 | nextadr = 0; |
duke@1 | 1474 | pendingExits = null; |
duke@1 | 1475 | this.make = null; |
duke@1 | 1476 | this.thrown = this.caught = null; |
duke@1 | 1477 | this.classDef = null; |
mcimadamore@905 | 1478 | unrefdResources = null; |
duke@1 | 1479 | } |
duke@1 | 1480 | } |
duke@1 | 1481 | } |