Thu, 05 Jan 2017 18:58:06 +0000
8168774: Polymorhic signature method check crashes javac
Summary: Check for polysig method assumes arity is greater than zero
Reviewed-by: vromero
duke@1 | 1 | /* |
jjg@1521 | 2 | * Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights reserved. |
duke@1 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@1 | 4 | * |
duke@1 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@1 | 6 | * under the terms of the GNU General Public License version 2 only, as |
ohair@554 | 7 | * published by the Free Software Foundation. Oracle designates this |
duke@1 | 8 | * particular file as subject to the "Classpath" exception as provided |
ohair@554 | 9 | * by Oracle in the LICENSE file that accompanied this code. |
duke@1 | 10 | * |
duke@1 | 11 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@1 | 12 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@1 | 13 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@1 | 14 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@1 | 15 | * accompanied this code). |
duke@1 | 16 | * |
duke@1 | 17 | * You should have received a copy of the GNU General Public License version |
duke@1 | 18 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@1 | 19 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@1 | 20 | * |
ohair@554 | 21 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
ohair@554 | 22 | * or visit www.oracle.com if you need additional information or have any |
ohair@554 | 23 | * questions. |
duke@1 | 24 | */ |
duke@1 | 25 | |
duke@1 | 26 | package com.sun.tools.javac.code; |
duke@1 | 27 | |
duke@1 | 28 | import java.util.EnumSet; |
duke@1 | 29 | import java.util.Map; |
duke@1 | 30 | import com.sun.tools.javac.code.Symbol.*; |
duke@1 | 31 | import com.sun.tools.javac.util.Context; |
duke@1 | 32 | import com.sun.tools.javac.util.List; |
duke@1 | 33 | import com.sun.tools.javac.util.Options; |
duke@1 | 34 | import com.sun.tools.javac.util.Pair; |
vromero@1442 | 35 | |
duke@1 | 36 | /** |
duke@1 | 37 | * A class for handling -Xlint suboptions and @SuppresssWarnings. |
duke@1 | 38 | * |
jjg@581 | 39 | * <p><b>This is NOT part of any supported API. |
jjg@581 | 40 | * If you write code that depends on this, you do so at your own risk. |
duke@1 | 41 | * This code and its internal interfaces are subject to change or |
duke@1 | 42 | * deletion without notice.</b> |
duke@1 | 43 | */ |
duke@1 | 44 | public class Lint |
duke@1 | 45 | { |
duke@1 | 46 | /** The context key for the root Lint object. */ |
duke@1 | 47 | protected static final Context.Key<Lint> lintKey = new Context.Key<Lint>(); |
duke@1 | 48 | |
duke@1 | 49 | /** Get the root Lint instance. */ |
duke@1 | 50 | public static Lint instance(Context context) { |
duke@1 | 51 | Lint instance = context.get(lintKey); |
duke@1 | 52 | if (instance == null) |
duke@1 | 53 | instance = new Lint(context); |
duke@1 | 54 | return instance; |
duke@1 | 55 | } |
duke@1 | 56 | |
duke@1 | 57 | /** |
duke@1 | 58 | * Returns the result of combining the values in this object with |
duke@1 | 59 | * the given annotation. |
duke@1 | 60 | */ |
duke@1 | 61 | public Lint augment(Attribute.Compound attr) { |
duke@1 | 62 | return augmentor.augment(this, attr); |
duke@1 | 63 | } |
duke@1 | 64 | |
duke@1 | 65 | |
duke@1 | 66 | /** |
duke@1 | 67 | * Returns the result of combining the values in this object with |
jjg@1802 | 68 | * the metadata on the given symbol. |
duke@1 | 69 | */ |
jjg@1802 | 70 | public Lint augment(Symbol sym) { |
jjg@1802 | 71 | Lint l = augmentor.augment(this, sym.getDeclarationAttributes()); |
jjg@1802 | 72 | if (sym.isDeprecated()) { |
duke@1 | 73 | if (l == this) |
duke@1 | 74 | l = new Lint(this); |
duke@1 | 75 | l.values.remove(LintCategory.DEPRECATION); |
duke@1 | 76 | l.suppressedValues.add(LintCategory.DEPRECATION); |
duke@1 | 77 | } |
duke@1 | 78 | return l; |
duke@1 | 79 | } |
duke@1 | 80 | |
duke@1 | 81 | private final AugmentVisitor augmentor; |
duke@1 | 82 | |
duke@1 | 83 | private final EnumSet<LintCategory> values; |
duke@1 | 84 | private final EnumSet<LintCategory> suppressedValues; |
duke@1 | 85 | |
vromero@1442 | 86 | private static final Map<String, LintCategory> map = |
vromero@1442 | 87 | new java.util.concurrent.ConcurrentHashMap<String, LintCategory>(20); |
duke@1 | 88 | |
duke@1 | 89 | protected Lint(Context context) { |
duke@1 | 90 | // initialize values according to the lint options |
duke@1 | 91 | Options options = Options.instance(context); |
duke@1 | 92 | values = EnumSet.noneOf(LintCategory.class); |
duke@1 | 93 | for (Map.Entry<String, LintCategory> e: map.entrySet()) { |
duke@1 | 94 | if (options.lint(e.getKey())) |
duke@1 | 95 | values.add(e.getValue()); |
duke@1 | 96 | } |
duke@1 | 97 | |
duke@1 | 98 | suppressedValues = EnumSet.noneOf(LintCategory.class); |
duke@1 | 99 | |
duke@1 | 100 | context.put(lintKey, this); |
duke@1 | 101 | augmentor = new AugmentVisitor(context); |
duke@1 | 102 | } |
duke@1 | 103 | |
duke@1 | 104 | protected Lint(Lint other) { |
duke@1 | 105 | this.augmentor = other.augmentor; |
duke@1 | 106 | this.values = other.values.clone(); |
duke@1 | 107 | this.suppressedValues = other.suppressedValues.clone(); |
duke@1 | 108 | } |
duke@1 | 109 | |
jjg@612 | 110 | @Override |
duke@1 | 111 | public String toString() { |
duke@1 | 112 | return "Lint:[values" + values + " suppressedValues" + suppressedValues + "]"; |
duke@1 | 113 | } |
duke@1 | 114 | |
duke@1 | 115 | /** |
duke@1 | 116 | * Categories of warnings that can be generated by the compiler. |
duke@1 | 117 | */ |
duke@1 | 118 | public enum LintCategory { |
duke@1 | 119 | /** |
ohrstrom@1384 | 120 | * Warn when code refers to a auxiliary class that is hidden in a source file (ie source file name is |
ohrstrom@1384 | 121 | * different from the class name, and the type is not properly nested) and the referring code |
ohrstrom@1384 | 122 | * is not located in the same source file. |
ohrstrom@1384 | 123 | */ |
ohrstrom@1384 | 124 | AUXILIARYCLASS("auxiliaryclass"), |
ohrstrom@1384 | 125 | |
ohrstrom@1384 | 126 | /** |
duke@1 | 127 | * Warn about use of unnecessary casts. |
duke@1 | 128 | */ |
duke@1 | 129 | CAST("cast"), |
duke@1 | 130 | |
duke@1 | 131 | /** |
jjg@776 | 132 | * Warn about issues related to classfile contents |
jjg@776 | 133 | */ |
jjg@776 | 134 | CLASSFILE("classfile"), |
jjg@776 | 135 | |
jjg@776 | 136 | /** |
duke@1 | 137 | * Warn about use of deprecated items. |
duke@1 | 138 | */ |
duke@1 | 139 | DEPRECATION("deprecation"), |
duke@1 | 140 | |
duke@1 | 141 | /** |
duke@1 | 142 | * Warn about items which are documented with an {@code @deprecated} JavaDoc |
duke@1 | 143 | * comment, but which do not have {@code @Deprecated} annotation. |
duke@1 | 144 | */ |
duke@1 | 145 | DEP_ANN("dep-ann"), |
duke@1 | 146 | |
duke@1 | 147 | /** |
duke@1 | 148 | * Warn about division by constant integer 0. |
duke@1 | 149 | */ |
duke@1 | 150 | DIVZERO("divzero"), |
duke@1 | 151 | |
duke@1 | 152 | /** |
duke@1 | 153 | * Warn about empty statement after if. |
duke@1 | 154 | */ |
duke@1 | 155 | EMPTY("empty"), |
duke@1 | 156 | |
duke@1 | 157 | /** |
duke@1 | 158 | * Warn about falling through from one case of a switch statement to the next. |
duke@1 | 159 | */ |
duke@1 | 160 | FALLTHROUGH("fallthrough"), |
duke@1 | 161 | |
duke@1 | 162 | /** |
duke@1 | 163 | * Warn about finally clauses that do not terminate normally. |
duke@1 | 164 | */ |
duke@1 | 165 | FINALLY("finally"), |
duke@1 | 166 | |
duke@1 | 167 | /** |
jjg@757 | 168 | * Warn about issues relating to use of command line options |
jjg@757 | 169 | */ |
jjg@757 | 170 | OPTIONS("options"), |
jjg@757 | 171 | |
jjg@757 | 172 | /** |
vromero@2000 | 173 | * Warn about issues regarding method overloads. |
vromero@2000 | 174 | */ |
vromero@2000 | 175 | OVERLOADS("overloads"), |
vromero@2000 | 176 | |
vromero@2000 | 177 | /** |
duke@1 | 178 | * Warn about issues regarding method overrides. |
duke@1 | 179 | */ |
duke@1 | 180 | OVERRIDES("overrides"), |
duke@1 | 181 | |
duke@1 | 182 | /** |
duke@1 | 183 | * Warn about invalid path elements on the command line. |
duke@1 | 184 | * Such warnings cannot be suppressed with the SuppressWarnings |
duke@1 | 185 | * annotation. |
duke@1 | 186 | */ |
duke@1 | 187 | PATH("path"), |
duke@1 | 188 | |
duke@1 | 189 | /** |
martin@124 | 190 | * Warn about issues regarding annotation processing. |
martin@124 | 191 | */ |
martin@124 | 192 | PROCESSING("processing"), |
martin@124 | 193 | |
martin@124 | 194 | /** |
jjg@757 | 195 | * Warn about unchecked operations on raw types. |
jjg@757 | 196 | */ |
jjg@757 | 197 | RAW("rawtypes"), |
jjg@757 | 198 | |
jjg@757 | 199 | /** |
duke@1 | 200 | * Warn about Serializable classes that do not provide a serial version ID. |
duke@1 | 201 | */ |
duke@1 | 202 | SERIAL("serial"), |
duke@1 | 203 | |
duke@1 | 204 | /** |
jjg@757 | 205 | * Warn about issues relating to use of statics |
jjg@757 | 206 | */ |
jjg@757 | 207 | STATIC("static"), |
jjg@757 | 208 | |
jjg@757 | 209 | /** |
jjg@757 | 210 | * Warn about proprietary API that may be removed in a future release. |
jjg@757 | 211 | */ |
jjg@757 | 212 | SUNAPI("sunapi", true), |
jjg@757 | 213 | |
jjg@757 | 214 | /** |
jjg@757 | 215 | * Warn about issues relating to use of try blocks (i.e. try-with-resources) |
jjg@757 | 216 | */ |
jjg@757 | 217 | TRY("try"), |
jjg@757 | 218 | |
jjg@757 | 219 | /** |
duke@1 | 220 | * Warn about unchecked operations on raw types. |
duke@1 | 221 | */ |
mcimadamore@122 | 222 | UNCHECKED("unchecked"), |
mcimadamore@122 | 223 | |
mcimadamore@122 | 224 | /** |
mcimadamore@580 | 225 | * Warn about potentially unsafe vararg methods |
mcimadamore@580 | 226 | */ |
jjg@757 | 227 | VARARGS("varargs"); |
duke@1 | 228 | |
duke@1 | 229 | LintCategory(String option) { |
jjg@377 | 230 | this(option, false); |
jjg@377 | 231 | } |
jjg@377 | 232 | |
jjg@377 | 233 | LintCategory(String option, boolean hidden) { |
duke@1 | 234 | this.option = option; |
jjg@377 | 235 | this.hidden = hidden; |
duke@1 | 236 | map.put(option, this); |
duke@1 | 237 | } |
duke@1 | 238 | |
duke@1 | 239 | static LintCategory get(String option) { |
duke@1 | 240 | return map.get(option); |
duke@1 | 241 | } |
duke@1 | 242 | |
jjg@11 | 243 | public final String option; |
jjg@377 | 244 | public final boolean hidden; |
duke@1 | 245 | }; |
duke@1 | 246 | |
duke@1 | 247 | /** |
duke@1 | 248 | * Checks if a warning category is enabled. A warning category may be enabled |
duke@1 | 249 | * on the command line, or by default, and can be temporarily disabled with |
duke@1 | 250 | * the SuppressWarnings annotation. |
duke@1 | 251 | */ |
duke@1 | 252 | public boolean isEnabled(LintCategory lc) { |
duke@1 | 253 | return values.contains(lc); |
duke@1 | 254 | } |
duke@1 | 255 | |
duke@1 | 256 | /** |
duke@1 | 257 | * Checks is a warning category has been specifically suppressed, by means |
duke@1 | 258 | * of the SuppressWarnings annotation, or, in the case of the deprecated |
duke@1 | 259 | * category, whether it has been implicitly suppressed by virtue of the |
duke@1 | 260 | * current entity being itself deprecated. |
duke@1 | 261 | */ |
duke@1 | 262 | public boolean isSuppressed(LintCategory lc) { |
duke@1 | 263 | return suppressedValues.contains(lc); |
duke@1 | 264 | } |
duke@1 | 265 | |
duke@1 | 266 | protected static class AugmentVisitor implements Attribute.Visitor { |
duke@1 | 267 | private final Context context; |
duke@1 | 268 | private Symtab syms; |
duke@1 | 269 | private Lint parent; |
duke@1 | 270 | private Lint lint; |
duke@1 | 271 | |
duke@1 | 272 | AugmentVisitor(Context context) { |
duke@1 | 273 | // to break an ugly sequence of initialization dependencies, |
duke@1 | 274 | // we defer the initialization of syms until it is needed |
duke@1 | 275 | this.context = context; |
duke@1 | 276 | } |
duke@1 | 277 | |
duke@1 | 278 | Lint augment(Lint parent, Attribute.Compound attr) { |
duke@1 | 279 | initSyms(); |
duke@1 | 280 | this.parent = parent; |
duke@1 | 281 | lint = null; |
duke@1 | 282 | attr.accept(this); |
duke@1 | 283 | return (lint == null ? parent : lint); |
duke@1 | 284 | } |
duke@1 | 285 | |
duke@1 | 286 | Lint augment(Lint parent, List<Attribute.Compound> attrs) { |
duke@1 | 287 | initSyms(); |
duke@1 | 288 | this.parent = parent; |
duke@1 | 289 | lint = null; |
duke@1 | 290 | for (Attribute.Compound a: attrs) { |
duke@1 | 291 | a.accept(this); |
duke@1 | 292 | } |
duke@1 | 293 | return (lint == null ? parent : lint); |
duke@1 | 294 | } |
duke@1 | 295 | |
duke@1 | 296 | private void initSyms() { |
duke@1 | 297 | if (syms == null) |
duke@1 | 298 | syms = Symtab.instance(context); |
duke@1 | 299 | } |
duke@1 | 300 | |
duke@1 | 301 | private void suppress(LintCategory lc) { |
duke@1 | 302 | if (lint == null) |
duke@1 | 303 | lint = new Lint(parent); |
duke@1 | 304 | lint.suppressedValues.add(lc); |
duke@1 | 305 | lint.values.remove(lc); |
duke@1 | 306 | } |
duke@1 | 307 | |
duke@1 | 308 | public void visitConstant(Attribute.Constant value) { |
duke@1 | 309 | if (value.type.tsym == syms.stringType.tsym) { |
duke@1 | 310 | LintCategory lc = LintCategory.get((String) (value.value)); |
duke@1 | 311 | if (lc != null) |
duke@1 | 312 | suppress(lc); |
duke@1 | 313 | } |
duke@1 | 314 | } |
duke@1 | 315 | |
duke@1 | 316 | public void visitClass(Attribute.Class clazz) { |
duke@1 | 317 | } |
duke@1 | 318 | |
duke@1 | 319 | // If we find a @SuppressWarnings annotation, then we continue |
duke@1 | 320 | // walking the tree, in order to suppress the individual warnings |
duke@1 | 321 | // specified in the @SuppressWarnings annotation. |
duke@1 | 322 | public void visitCompound(Attribute.Compound compound) { |
duke@1 | 323 | if (compound.type.tsym == syms.suppressWarningsType.tsym) { |
duke@1 | 324 | for (List<Pair<MethodSymbol,Attribute>> v = compound.values; |
duke@1 | 325 | v.nonEmpty(); v = v.tail) { |
duke@1 | 326 | Pair<MethodSymbol,Attribute> value = v.head; |
duke@1 | 327 | if (value.fst.name.toString().equals("value")) |
duke@1 | 328 | value.snd.accept(this); |
duke@1 | 329 | } |
duke@1 | 330 | |
duke@1 | 331 | } |
duke@1 | 332 | } |
duke@1 | 333 | |
duke@1 | 334 | public void visitArray(Attribute.Array array) { |
duke@1 | 335 | for (Attribute value : array.values) |
duke@1 | 336 | value.accept(this); |
duke@1 | 337 | } |
duke@1 | 338 | |
duke@1 | 339 | public void visitEnum(Attribute.Enum e) { |
duke@1 | 340 | } |
duke@1 | 341 | |
duke@1 | 342 | public void visitError(Attribute.Error e) { |
duke@1 | 343 | } |
duke@1 | 344 | }; |
duke@1 | 345 | } |