src/share/classes/com/sun/tools/javac/code/Lint.java

Mon, 02 Sep 2013 22:38:36 +0100

author
vromero
date
Mon, 02 Sep 2013 22:38:36 +0100
changeset 2000
4a6acc42c3a1
parent 1802
8fb68f73d4b1
child 2027
4932bb04c4b8
permissions
-rw-r--r--

8016177: structural most specific and stuckness
Reviewed-by: jjg, vromero
Contributed-by: maurizio.cimadamore@oracle.com

duke@1 1 /*
jjg@1521 2 * Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.code;
duke@1 27
duke@1 28 import java.util.EnumSet;
duke@1 29 import java.util.Map;
duke@1 30 import com.sun.tools.javac.code.Symbol.*;
duke@1 31 import com.sun.tools.javac.util.Context;
duke@1 32 import com.sun.tools.javac.util.List;
duke@1 33 import com.sun.tools.javac.util.Options;
duke@1 34 import com.sun.tools.javac.util.Pair;
vromero@1442 35
duke@1 36 import static com.sun.tools.javac.code.Flags.*;
duke@1 37
duke@1 38
duke@1 39 /**
duke@1 40 * A class for handling -Xlint suboptions and @SuppresssWarnings.
duke@1 41 *
jjg@581 42 * <p><b>This is NOT part of any supported API.
jjg@581 43 * If you write code that depends on this, you do so at your own risk.
duke@1 44 * This code and its internal interfaces are subject to change or
duke@1 45 * deletion without notice.</b>
duke@1 46 */
duke@1 47 public class Lint
duke@1 48 {
duke@1 49 /** The context key for the root Lint object. */
duke@1 50 protected static final Context.Key<Lint> lintKey = new Context.Key<Lint>();
duke@1 51
duke@1 52 /** Get the root Lint instance. */
duke@1 53 public static Lint instance(Context context) {
duke@1 54 Lint instance = context.get(lintKey);
duke@1 55 if (instance == null)
duke@1 56 instance = new Lint(context);
duke@1 57 return instance;
duke@1 58 }
duke@1 59
duke@1 60 /**
duke@1 61 * Returns the result of combining the values in this object with
duke@1 62 * the given annotation.
duke@1 63 */
duke@1 64 public Lint augment(Attribute.Compound attr) {
duke@1 65 return augmentor.augment(this, attr);
duke@1 66 }
duke@1 67
duke@1 68
duke@1 69 /**
duke@1 70 * Returns the result of combining the values in this object with
jjg@1802 71 * the metadata on the given symbol.
duke@1 72 */
jjg@1802 73 public Lint augment(Symbol sym) {
jjg@1802 74 Lint l = augmentor.augment(this, sym.getDeclarationAttributes());
jjg@1802 75 if (sym.isDeprecated()) {
duke@1 76 if (l == this)
duke@1 77 l = new Lint(this);
duke@1 78 l.values.remove(LintCategory.DEPRECATION);
duke@1 79 l.suppressedValues.add(LintCategory.DEPRECATION);
duke@1 80 }
duke@1 81 return l;
duke@1 82 }
duke@1 83
duke@1 84
duke@1 85 private final AugmentVisitor augmentor;
duke@1 86
duke@1 87 private final EnumSet<LintCategory> values;
duke@1 88 private final EnumSet<LintCategory> suppressedValues;
duke@1 89
vromero@1442 90 private static final Map<String, LintCategory> map =
vromero@1442 91 new java.util.concurrent.ConcurrentHashMap<String, LintCategory>(20);
duke@1 92
duke@1 93
duke@1 94 protected Lint(Context context) {
duke@1 95 // initialize values according to the lint options
duke@1 96 Options options = Options.instance(context);
duke@1 97 values = EnumSet.noneOf(LintCategory.class);
duke@1 98 for (Map.Entry<String, LintCategory> e: map.entrySet()) {
duke@1 99 if (options.lint(e.getKey()))
duke@1 100 values.add(e.getValue());
duke@1 101 }
duke@1 102
duke@1 103 suppressedValues = EnumSet.noneOf(LintCategory.class);
duke@1 104
duke@1 105 context.put(lintKey, this);
duke@1 106 augmentor = new AugmentVisitor(context);
duke@1 107 }
duke@1 108
duke@1 109 protected Lint(Lint other) {
duke@1 110 this.augmentor = other.augmentor;
duke@1 111 this.values = other.values.clone();
duke@1 112 this.suppressedValues = other.suppressedValues.clone();
duke@1 113 }
duke@1 114
jjg@612 115 @Override
duke@1 116 public String toString() {
duke@1 117 return "Lint:[values" + values + " suppressedValues" + suppressedValues + "]";
duke@1 118 }
duke@1 119
duke@1 120 /**
duke@1 121 * Categories of warnings that can be generated by the compiler.
duke@1 122 */
duke@1 123 public enum LintCategory {
duke@1 124 /**
ohrstrom@1384 125 * Warn when code refers to a auxiliary class that is hidden in a source file (ie source file name is
ohrstrom@1384 126 * different from the class name, and the type is not properly nested) and the referring code
ohrstrom@1384 127 * is not located in the same source file.
ohrstrom@1384 128 */
ohrstrom@1384 129 AUXILIARYCLASS("auxiliaryclass"),
ohrstrom@1384 130
ohrstrom@1384 131 /**
duke@1 132 * Warn about use of unnecessary casts.
duke@1 133 */
duke@1 134 CAST("cast"),
duke@1 135
duke@1 136 /**
jjg@776 137 * Warn about issues related to classfile contents
jjg@776 138 */
jjg@776 139 CLASSFILE("classfile"),
jjg@776 140
jjg@776 141 /**
duke@1 142 * Warn about use of deprecated items.
duke@1 143 */
duke@1 144 DEPRECATION("deprecation"),
duke@1 145
duke@1 146 /**
duke@1 147 * Warn about items which are documented with an {@code @deprecated} JavaDoc
duke@1 148 * comment, but which do not have {@code @Deprecated} annotation.
duke@1 149 */
duke@1 150 DEP_ANN("dep-ann"),
duke@1 151
duke@1 152 /**
duke@1 153 * Warn about division by constant integer 0.
duke@1 154 */
duke@1 155 DIVZERO("divzero"),
duke@1 156
duke@1 157 /**
duke@1 158 * Warn about empty statement after if.
duke@1 159 */
duke@1 160 EMPTY("empty"),
duke@1 161
duke@1 162 /**
duke@1 163 * Warn about falling through from one case of a switch statement to the next.
duke@1 164 */
duke@1 165 FALLTHROUGH("fallthrough"),
duke@1 166
duke@1 167 /**
duke@1 168 * Warn about finally clauses that do not terminate normally.
duke@1 169 */
duke@1 170 FINALLY("finally"),
duke@1 171
duke@1 172 /**
jjg@757 173 * Warn about issues relating to use of command line options
jjg@757 174 */
jjg@757 175 OPTIONS("options"),
jjg@757 176
jjg@757 177 /**
vromero@2000 178 * Warn about issues regarding method overloads.
vromero@2000 179 */
vromero@2000 180 OVERLOADS("overloads"),
vromero@2000 181
vromero@2000 182 /**
duke@1 183 * Warn about issues regarding method overrides.
duke@1 184 */
duke@1 185 OVERRIDES("overrides"),
duke@1 186
duke@1 187 /**
duke@1 188 * Warn about invalid path elements on the command line.
duke@1 189 * Such warnings cannot be suppressed with the SuppressWarnings
duke@1 190 * annotation.
duke@1 191 */
duke@1 192 PATH("path"),
duke@1 193
duke@1 194 /**
martin@124 195 * Warn about issues regarding annotation processing.
martin@124 196 */
martin@124 197 PROCESSING("processing"),
martin@124 198
martin@124 199 /**
jjg@757 200 * Warn about unchecked operations on raw types.
jjg@757 201 */
jjg@757 202 RAW("rawtypes"),
jjg@757 203
jjg@757 204 /**
duke@1 205 * Warn about Serializable classes that do not provide a serial version ID.
duke@1 206 */
duke@1 207 SERIAL("serial"),
duke@1 208
duke@1 209 /**
jjg@757 210 * Warn about issues relating to use of statics
jjg@757 211 */
jjg@757 212 STATIC("static"),
jjg@757 213
jjg@757 214 /**
jjg@757 215 * Warn about proprietary API that may be removed in a future release.
jjg@757 216 */
jjg@757 217 SUNAPI("sunapi", true),
jjg@757 218
jjg@757 219 /**
jjg@757 220 * Warn about issues relating to use of try blocks (i.e. try-with-resources)
jjg@757 221 */
jjg@757 222 TRY("try"),
jjg@757 223
jjg@757 224 /**
duke@1 225 * Warn about unchecked operations on raw types.
duke@1 226 */
mcimadamore@122 227 UNCHECKED("unchecked"),
mcimadamore@122 228
mcimadamore@122 229 /**
mcimadamore@580 230 * Warn about potentially unsafe vararg methods
mcimadamore@580 231 */
jjg@757 232 VARARGS("varargs");
duke@1 233
duke@1 234 LintCategory(String option) {
jjg@377 235 this(option, false);
jjg@377 236 }
jjg@377 237
jjg@377 238 LintCategory(String option, boolean hidden) {
duke@1 239 this.option = option;
jjg@377 240 this.hidden = hidden;
duke@1 241 map.put(option, this);
duke@1 242 }
duke@1 243
duke@1 244 static LintCategory get(String option) {
duke@1 245 return map.get(option);
duke@1 246 }
duke@1 247
jjg@11 248 public final String option;
jjg@377 249 public final boolean hidden;
duke@1 250 };
duke@1 251
duke@1 252 /**
duke@1 253 * Checks if a warning category is enabled. A warning category may be enabled
duke@1 254 * on the command line, or by default, and can be temporarily disabled with
duke@1 255 * the SuppressWarnings annotation.
duke@1 256 */
duke@1 257 public boolean isEnabled(LintCategory lc) {
duke@1 258 return values.contains(lc);
duke@1 259 }
duke@1 260
duke@1 261 /**
duke@1 262 * Checks is a warning category has been specifically suppressed, by means
duke@1 263 * of the SuppressWarnings annotation, or, in the case of the deprecated
duke@1 264 * category, whether it has been implicitly suppressed by virtue of the
duke@1 265 * current entity being itself deprecated.
duke@1 266 */
duke@1 267 public boolean isSuppressed(LintCategory lc) {
duke@1 268 return suppressedValues.contains(lc);
duke@1 269 }
duke@1 270
duke@1 271 protected static class AugmentVisitor implements Attribute.Visitor {
duke@1 272 private final Context context;
duke@1 273 private Symtab syms;
duke@1 274 private Lint parent;
duke@1 275 private Lint lint;
duke@1 276
duke@1 277 AugmentVisitor(Context context) {
duke@1 278 // to break an ugly sequence of initialization dependencies,
duke@1 279 // we defer the initialization of syms until it is needed
duke@1 280 this.context = context;
duke@1 281 }
duke@1 282
duke@1 283 Lint augment(Lint parent, Attribute.Compound attr) {
duke@1 284 initSyms();
duke@1 285 this.parent = parent;
duke@1 286 lint = null;
duke@1 287 attr.accept(this);
duke@1 288 return (lint == null ? parent : lint);
duke@1 289 }
duke@1 290
duke@1 291 Lint augment(Lint parent, List<Attribute.Compound> attrs) {
duke@1 292 initSyms();
duke@1 293 this.parent = parent;
duke@1 294 lint = null;
duke@1 295 for (Attribute.Compound a: attrs) {
duke@1 296 a.accept(this);
duke@1 297 }
duke@1 298 return (lint == null ? parent : lint);
duke@1 299 }
duke@1 300
duke@1 301 private void initSyms() {
duke@1 302 if (syms == null)
duke@1 303 syms = Symtab.instance(context);
duke@1 304 }
duke@1 305
duke@1 306 private void suppress(LintCategory lc) {
duke@1 307 if (lint == null)
duke@1 308 lint = new Lint(parent);
duke@1 309 lint.suppressedValues.add(lc);
duke@1 310 lint.values.remove(lc);
duke@1 311 }
duke@1 312
duke@1 313 public void visitConstant(Attribute.Constant value) {
duke@1 314 if (value.type.tsym == syms.stringType.tsym) {
duke@1 315 LintCategory lc = LintCategory.get((String) (value.value));
duke@1 316 if (lc != null)
duke@1 317 suppress(lc);
duke@1 318 }
duke@1 319 }
duke@1 320
duke@1 321 public void visitClass(Attribute.Class clazz) {
duke@1 322 }
duke@1 323
duke@1 324 // If we find a @SuppressWarnings annotation, then we continue
duke@1 325 // walking the tree, in order to suppress the individual warnings
duke@1 326 // specified in the @SuppressWarnings annotation.
duke@1 327 public void visitCompound(Attribute.Compound compound) {
duke@1 328 if (compound.type.tsym == syms.suppressWarningsType.tsym) {
duke@1 329 for (List<Pair<MethodSymbol,Attribute>> v = compound.values;
duke@1 330 v.nonEmpty(); v = v.tail) {
duke@1 331 Pair<MethodSymbol,Attribute> value = v.head;
duke@1 332 if (value.fst.name.toString().equals("value"))
duke@1 333 value.snd.accept(this);
duke@1 334 }
duke@1 335
duke@1 336 }
duke@1 337 }
duke@1 338
duke@1 339 public void visitArray(Attribute.Array array) {
duke@1 340 for (Attribute value : array.values)
duke@1 341 value.accept(this);
duke@1 342 }
duke@1 343
duke@1 344 public void visitEnum(Attribute.Enum e) {
duke@1 345 }
duke@1 346
duke@1 347 public void visitError(Attribute.Error e) {
duke@1 348 }
duke@1 349 };
duke@1 350 }

mercurial