src/share/classes/com/sun/tools/javac/code/Lint.java

Thu, 01 Nov 2012 10:48:36 +0100

author
ohrstrom
date
Thu, 01 Nov 2012 10:48:36 +0100
changeset 1384
bf54daa9dcd8
parent 1313
873ddd9f4900
child 1442
fcf89720ae71
permissions
-rw-r--r--

7153951: Add new lint option -Xlint:auxiliaryclass
Reviewed-by: jjg, mcimadamore, forax

duke@1 1 /*
jfranck@1313 2 * Copyright (c) 2005, 2012, Oracle and/or its affiliates. All rights reserved.
duke@1 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@1 4 *
duke@1 5 * This code is free software; you can redistribute it and/or modify it
duke@1 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
duke@1 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
duke@1 10 *
duke@1 11 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@1 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@1 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@1 14 * version 2 for more details (a copy is included in the LICENSE file that
duke@1 15 * accompanied this code).
duke@1 16 *
duke@1 17 * You should have received a copy of the GNU General Public License version
duke@1 18 * 2 along with this work; if not, write to the Free Software Foundation,
duke@1 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@1 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
duke@1 24 */
duke@1 25
duke@1 26 package com.sun.tools.javac.code;
duke@1 27
duke@1 28 import java.util.EnumSet;
duke@1 29 import java.util.HashMap;
duke@1 30 import java.util.Map;
duke@1 31 import com.sun.tools.javac.code.Symbol.*;
duke@1 32 import com.sun.tools.javac.util.Context;
duke@1 33 import com.sun.tools.javac.util.List;
duke@1 34 import com.sun.tools.javac.util.Options;
duke@1 35 import com.sun.tools.javac.util.Pair;
duke@1 36 import static com.sun.tools.javac.code.Flags.*;
duke@1 37
duke@1 38
duke@1 39 /**
duke@1 40 * A class for handling -Xlint suboptions and @SuppresssWarnings.
duke@1 41 *
jjg@581 42 * <p><b>This is NOT part of any supported API.
jjg@581 43 * If you write code that depends on this, you do so at your own risk.
duke@1 44 * This code and its internal interfaces are subject to change or
duke@1 45 * deletion without notice.</b>
duke@1 46 */
duke@1 47 public class Lint
duke@1 48 {
duke@1 49 /** The context key for the root Lint object. */
duke@1 50 protected static final Context.Key<Lint> lintKey = new Context.Key<Lint>();
duke@1 51
duke@1 52 /** Get the root Lint instance. */
duke@1 53 public static Lint instance(Context context) {
duke@1 54 Lint instance = context.get(lintKey);
duke@1 55 if (instance == null)
duke@1 56 instance = new Lint(context);
duke@1 57 return instance;
duke@1 58 }
duke@1 59
duke@1 60 /**
duke@1 61 * Returns the result of combining the values in this object with
duke@1 62 * the given annotation.
duke@1 63 */
duke@1 64 public Lint augment(Attribute.Compound attr) {
duke@1 65 return augmentor.augment(this, attr);
duke@1 66 }
duke@1 67
duke@1 68
duke@1 69 /**
duke@1 70 * Returns the result of combining the values in this object with
duke@1 71 * the given annotations.
duke@1 72 */
jfranck@1313 73 public Lint augment(Annotations annots) {
jfranck@1313 74 return augmentor.augment(this, annots.getAttributes());
duke@1 75 }
duke@1 76
duke@1 77 /**
duke@1 78 * Returns the result of combining the values in this object with
duke@1 79 * the given annotations and flags.
duke@1 80 */
jfranck@1313 81 public Lint augment(Annotations annots, long flags) {
jfranck@1313 82 Lint l = augmentor.augment(this, annots.getAttributes());
duke@1 83 if ((flags & DEPRECATED) != 0) {
duke@1 84 if (l == this)
duke@1 85 l = new Lint(this);
duke@1 86 l.values.remove(LintCategory.DEPRECATION);
duke@1 87 l.suppressedValues.add(LintCategory.DEPRECATION);
duke@1 88 }
duke@1 89 return l;
duke@1 90 }
duke@1 91
duke@1 92
duke@1 93 private final AugmentVisitor augmentor;
duke@1 94
duke@1 95 private final EnumSet<LintCategory> values;
duke@1 96 private final EnumSet<LintCategory> suppressedValues;
duke@1 97
duke@1 98 private static Map<String, LintCategory> map = new HashMap<String,LintCategory>();
duke@1 99
duke@1 100
duke@1 101 protected Lint(Context context) {
duke@1 102 // initialize values according to the lint options
duke@1 103 Options options = Options.instance(context);
duke@1 104 values = EnumSet.noneOf(LintCategory.class);
duke@1 105 for (Map.Entry<String, LintCategory> e: map.entrySet()) {
duke@1 106 if (options.lint(e.getKey()))
duke@1 107 values.add(e.getValue());
duke@1 108 }
duke@1 109
duke@1 110 suppressedValues = EnumSet.noneOf(LintCategory.class);
duke@1 111
duke@1 112 context.put(lintKey, this);
duke@1 113 augmentor = new AugmentVisitor(context);
duke@1 114 }
duke@1 115
duke@1 116 protected Lint(Lint other) {
duke@1 117 this.augmentor = other.augmentor;
duke@1 118 this.values = other.values.clone();
duke@1 119 this.suppressedValues = other.suppressedValues.clone();
duke@1 120 }
duke@1 121
jjg@612 122 @Override
duke@1 123 public String toString() {
duke@1 124 return "Lint:[values" + values + " suppressedValues" + suppressedValues + "]";
duke@1 125 }
duke@1 126
duke@1 127 /**
duke@1 128 * Categories of warnings that can be generated by the compiler.
duke@1 129 */
duke@1 130 public enum LintCategory {
duke@1 131 /**
ohrstrom@1384 132 * Warn when code refers to a auxiliary class that is hidden in a source file (ie source file name is
ohrstrom@1384 133 * different from the class name, and the type is not properly nested) and the referring code
ohrstrom@1384 134 * is not located in the same source file.
ohrstrom@1384 135 */
ohrstrom@1384 136 AUXILIARYCLASS("auxiliaryclass"),
ohrstrom@1384 137
ohrstrom@1384 138 /**
duke@1 139 * Warn about use of unnecessary casts.
duke@1 140 */
duke@1 141 CAST("cast"),
duke@1 142
duke@1 143 /**
jjg@776 144 * Warn about issues related to classfile contents
jjg@776 145 */
jjg@776 146 CLASSFILE("classfile"),
jjg@776 147
jjg@776 148 /**
duke@1 149 * Warn about use of deprecated items.
duke@1 150 */
duke@1 151 DEPRECATION("deprecation"),
duke@1 152
duke@1 153 /**
duke@1 154 * Warn about items which are documented with an {@code @deprecated} JavaDoc
duke@1 155 * comment, but which do not have {@code @Deprecated} annotation.
duke@1 156 */
duke@1 157 DEP_ANN("dep-ann"),
duke@1 158
duke@1 159 /**
duke@1 160 * Warn about division by constant integer 0.
duke@1 161 */
duke@1 162 DIVZERO("divzero"),
duke@1 163
duke@1 164 /**
duke@1 165 * Warn about empty statement after if.
duke@1 166 */
duke@1 167 EMPTY("empty"),
duke@1 168
duke@1 169 /**
duke@1 170 * Warn about falling through from one case of a switch statement to the next.
duke@1 171 */
duke@1 172 FALLTHROUGH("fallthrough"),
duke@1 173
duke@1 174 /**
duke@1 175 * Warn about finally clauses that do not terminate normally.
duke@1 176 */
duke@1 177 FINALLY("finally"),
duke@1 178
duke@1 179 /**
jjg@757 180 * Warn about issues relating to use of command line options
jjg@757 181 */
jjg@757 182 OPTIONS("options"),
jjg@757 183
jjg@757 184 /**
duke@1 185 * Warn about issues regarding method overrides.
duke@1 186 */
duke@1 187 OVERRIDES("overrides"),
duke@1 188
duke@1 189 /**
duke@1 190 * Warn about invalid path elements on the command line.
duke@1 191 * Such warnings cannot be suppressed with the SuppressWarnings
duke@1 192 * annotation.
duke@1 193 */
duke@1 194 PATH("path"),
duke@1 195
duke@1 196 /**
martin@124 197 * Warn about issues regarding annotation processing.
martin@124 198 */
martin@124 199 PROCESSING("processing"),
martin@124 200
martin@124 201 /**
jjg@757 202 * Warn about unchecked operations on raw types.
jjg@757 203 */
jjg@757 204 RAW("rawtypes"),
jjg@757 205
jjg@757 206 /**
duke@1 207 * Warn about Serializable classes that do not provide a serial version ID.
duke@1 208 */
duke@1 209 SERIAL("serial"),
duke@1 210
duke@1 211 /**
jjg@757 212 * Warn about issues relating to use of statics
jjg@757 213 */
jjg@757 214 STATIC("static"),
jjg@757 215
jjg@757 216 /**
jjg@757 217 * Warn about proprietary API that may be removed in a future release.
jjg@757 218 */
jjg@757 219 SUNAPI("sunapi", true),
jjg@757 220
jjg@757 221 /**
jjg@757 222 * Warn about issues relating to use of try blocks (i.e. try-with-resources)
jjg@757 223 */
jjg@757 224 TRY("try"),
jjg@757 225
jjg@757 226 /**
duke@1 227 * Warn about unchecked operations on raw types.
duke@1 228 */
mcimadamore@122 229 UNCHECKED("unchecked"),
mcimadamore@122 230
mcimadamore@122 231 /**
mcimadamore@580 232 * Warn about potentially unsafe vararg methods
mcimadamore@580 233 */
jjg@757 234 VARARGS("varargs");
duke@1 235
duke@1 236 LintCategory(String option) {
jjg@377 237 this(option, false);
jjg@377 238 }
jjg@377 239
jjg@377 240 LintCategory(String option, boolean hidden) {
duke@1 241 this.option = option;
jjg@377 242 this.hidden = hidden;
duke@1 243 map.put(option, this);
duke@1 244 }
duke@1 245
duke@1 246 static LintCategory get(String option) {
duke@1 247 return map.get(option);
duke@1 248 }
duke@1 249
jjg@11 250 public final String option;
jjg@377 251 public final boolean hidden;
duke@1 252 };
duke@1 253
duke@1 254 /**
duke@1 255 * Checks if a warning category is enabled. A warning category may be enabled
duke@1 256 * on the command line, or by default, and can be temporarily disabled with
duke@1 257 * the SuppressWarnings annotation.
duke@1 258 */
duke@1 259 public boolean isEnabled(LintCategory lc) {
duke@1 260 return values.contains(lc);
duke@1 261 }
duke@1 262
duke@1 263 /**
duke@1 264 * Checks is a warning category has been specifically suppressed, by means
duke@1 265 * of the SuppressWarnings annotation, or, in the case of the deprecated
duke@1 266 * category, whether it has been implicitly suppressed by virtue of the
duke@1 267 * current entity being itself deprecated.
duke@1 268 */
duke@1 269 public boolean isSuppressed(LintCategory lc) {
duke@1 270 return suppressedValues.contains(lc);
duke@1 271 }
duke@1 272
duke@1 273 protected static class AugmentVisitor implements Attribute.Visitor {
duke@1 274 private final Context context;
duke@1 275 private Symtab syms;
duke@1 276 private Lint parent;
duke@1 277 private Lint lint;
duke@1 278
duke@1 279 AugmentVisitor(Context context) {
duke@1 280 // to break an ugly sequence of initialization dependencies,
duke@1 281 // we defer the initialization of syms until it is needed
duke@1 282 this.context = context;
duke@1 283 }
duke@1 284
duke@1 285 Lint augment(Lint parent, Attribute.Compound attr) {
duke@1 286 initSyms();
duke@1 287 this.parent = parent;
duke@1 288 lint = null;
duke@1 289 attr.accept(this);
duke@1 290 return (lint == null ? parent : lint);
duke@1 291 }
duke@1 292
duke@1 293 Lint augment(Lint parent, List<Attribute.Compound> attrs) {
duke@1 294 initSyms();
duke@1 295 this.parent = parent;
duke@1 296 lint = null;
duke@1 297 for (Attribute.Compound a: attrs) {
duke@1 298 a.accept(this);
duke@1 299 }
duke@1 300 return (lint == null ? parent : lint);
duke@1 301 }
duke@1 302
duke@1 303 private void initSyms() {
duke@1 304 if (syms == null)
duke@1 305 syms = Symtab.instance(context);
duke@1 306 }
duke@1 307
duke@1 308 private void suppress(LintCategory lc) {
duke@1 309 if (lint == null)
duke@1 310 lint = new Lint(parent);
duke@1 311 lint.suppressedValues.add(lc);
duke@1 312 lint.values.remove(lc);
duke@1 313 }
duke@1 314
duke@1 315 public void visitConstant(Attribute.Constant value) {
duke@1 316 if (value.type.tsym == syms.stringType.tsym) {
duke@1 317 LintCategory lc = LintCategory.get((String) (value.value));
duke@1 318 if (lc != null)
duke@1 319 suppress(lc);
duke@1 320 }
duke@1 321 }
duke@1 322
duke@1 323 public void visitClass(Attribute.Class clazz) {
duke@1 324 }
duke@1 325
duke@1 326 // If we find a @SuppressWarnings annotation, then we continue
duke@1 327 // walking the tree, in order to suppress the individual warnings
duke@1 328 // specified in the @SuppressWarnings annotation.
duke@1 329 public void visitCompound(Attribute.Compound compound) {
duke@1 330 if (compound.type.tsym == syms.suppressWarningsType.tsym) {
duke@1 331 for (List<Pair<MethodSymbol,Attribute>> v = compound.values;
duke@1 332 v.nonEmpty(); v = v.tail) {
duke@1 333 Pair<MethodSymbol,Attribute> value = v.head;
duke@1 334 if (value.fst.name.toString().equals("value"))
duke@1 335 value.snd.accept(this);
duke@1 336 }
duke@1 337
duke@1 338 }
duke@1 339 }
duke@1 340
duke@1 341 public void visitArray(Attribute.Array array) {
duke@1 342 for (Attribute value : array.values)
duke@1 343 value.accept(this);
duke@1 344 }
duke@1 345
duke@1 346 public void visitEnum(Attribute.Enum e) {
duke@1 347 }
duke@1 348
duke@1 349 public void visitError(Attribute.Error e) {
duke@1 350 }
duke@1 351 };
duke@1 352 }

mercurial