Mercurial > jdk8-mips64-public > langtools / file revision
src/share/classes/com/sun/tools/javac/comp/Check.java@ed338593b0b6
src/share/classes/com/sun/tools/javac/comp/Check.java
Tue, 13 Sep 2011 14:14:57 +0100
- author
- mcimadamore
- date
- Tue, 13 Sep 2011 14:14:57 +0100
- changeset 1085
- ed338593b0b6
- parent 1017
- 6762754eb7c0
- child 1103
- 47147081d5b4
- permissions
- -rw-r--r--
7086595: Error message bug: name of initializer is 'null'
Summary: Implementation of MethodSymbol.location() should take into account static/instance initializers
Reviewed-by: jjg
1 /*
2 * Copyright (c) 1999, 2011, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation. Oracle designates this
8 * particular file as subject to the "Classpath" exception as provided
9 * by Oracle in the LICENSE file that accompanied this code.
10 *
11 * This code is distributed in the hope that it will be useful, but WITHOUT
12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
14 * version 2 for more details (a copy is included in the LICENSE file that
15 * accompanied this code).
16 *
17 * You should have received a copy of the GNU General Public License version
18 * 2 along with this work; if not, write to the Free Software Foundation,
19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
20 *
21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
22 * or visit www.oracle.com if you need additional information or have any
23 * questions.
24 */
26 package com.sun.tools.javac.comp;
28 import java.util.*;
29 import java.util.Set;
31 import com.sun.tools.javac.code.*;
32 import com.sun.tools.javac.jvm.*;
33 import com.sun.tools.javac.tree.*;
34 import com.sun.tools.javac.util.*;
35 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
36 import com.sun.tools.javac.util.List;
38 import com.sun.tools.javac.tree.JCTree.*;
39 import com.sun.tools.javac.code.Lint;
40 import com.sun.tools.javac.code.Lint.LintCategory;
41 import com.sun.tools.javac.code.Type.*;
42 import com.sun.tools.javac.code.Symbol.*;
44 import static com.sun.tools.javac.code.Flags.*;
45 import static com.sun.tools.javac.code.Kinds.*;
46 import static com.sun.tools.javac.code.TypeTags.*;
48 import static com.sun.tools.javac.main.OptionName.*;
50 /** Type checking helper class for the attribution phase.
51 *
52 * <p><b>This is NOT part of any supported API.
53 * If you write code that depends on this, you do so at your own risk.
54 * This code and its internal interfaces are subject to change or
55 * deletion without notice.</b>
56 */
57 public class Check {
58 protected static final Context.Key<Check> checkKey =
59 new Context.Key<Check>();
61 private final Names names;
62 private final Log log;
63 private final Symtab syms;
64 private final Enter enter;
65 private final Infer infer;
66 private final Types types;
67 private final JCDiagnostic.Factory diags;
68 private final boolean skipAnnotations;
69 private boolean warnOnSyntheticConflicts;
70 private boolean suppressAbortOnBadClassFile;
71 private boolean enableSunApiLintControl;
72 private final TreeInfo treeinfo;
74 // The set of lint options currently in effect. It is initialized
75 // from the context, and then is set/reset as needed by Attr as it
76 // visits all the various parts of the trees during attribution.
77 private Lint lint;
79 // The method being analyzed in Attr - it is set/reset as needed by
80 // Attr as it visits new method declarations.
81 private MethodSymbol method;
83 public static Check instance(Context context) {
84 Check instance = context.get(checkKey);
85 if (instance == null)
86 instance = new Check(context);
87 return instance;
88 }
90 protected Check(Context context) {
91 context.put(checkKey, this);
93 names = Names.instance(context);
94 log = Log.instance(context);
95 syms = Symtab.instance(context);
96 enter = Enter.instance(context);
97 infer = Infer.instance(context);
98 this.types = Types.instance(context);
99 diags = JCDiagnostic.Factory.instance(context);
100 Options options = Options.instance(context);
101 lint = Lint.instance(context);
102 treeinfo = TreeInfo.instance(context);
104 Source source = Source.instance(context);
105 allowGenerics = source.allowGenerics();
106 allowAnnotations = source.allowAnnotations();
107 allowCovariantReturns = source.allowCovariantReturns();
108 allowSimplifiedVarargs = source.allowSimplifiedVarargs();
109 complexInference = options.isSet(COMPLEXINFERENCE);
110 skipAnnotations = options.isSet("skipAnnotations");
111 warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
112 suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
113 enableSunApiLintControl = options.isSet("enableSunApiLintControl");
115 Target target = Target.instance(context);
116 syntheticNameChar = target.syntheticNameChar();
118 boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
119 boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
120 boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
121 boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
123 deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
124 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
125 uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
126 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
127 sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
128 enforceMandatoryWarnings, "sunapi", null);
130 deferredLintHandler = DeferredLintHandler.immediateHandler;
131 }
133 /** Switch: generics enabled?
134 */
135 boolean allowGenerics;
137 /** Switch: annotations enabled?
138 */
139 boolean allowAnnotations;
141 /** Switch: covariant returns enabled?
142 */
143 boolean allowCovariantReturns;
145 /** Switch: simplified varargs enabled?
146 */
147 boolean allowSimplifiedVarargs;
149 /** Switch: -complexinference option set?
150 */
151 boolean complexInference;
153 /** Character for synthetic names
154 */
155 char syntheticNameChar;
157 /** A table mapping flat names of all compiled classes in this run to their
158 * symbols; maintained from outside.
159 */
160 public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
162 /** A handler for messages about deprecated usage.
163 */
164 private MandatoryWarningHandler deprecationHandler;
166 /** A handler for messages about unchecked or unsafe usage.
167 */
168 private MandatoryWarningHandler uncheckedHandler;
170 /** A handler for messages about using proprietary API.
171 */
172 private MandatoryWarningHandler sunApiHandler;
174 /** A handler for deferred lint warnings.
175 */
176 private DeferredLintHandler deferredLintHandler;
178 /* *************************************************************************
179 * Errors and Warnings
180 **************************************************************************/
182 Lint setLint(Lint newLint) {
183 Lint prev = lint;
184 lint = newLint;
185 return prev;
186 }
188 DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
189 DeferredLintHandler prev = deferredLintHandler;
190 deferredLintHandler = newDeferredLintHandler;
191 return prev;
192 }
194 MethodSymbol setMethod(MethodSymbol newMethod) {
195 MethodSymbol prev = method;
196 method = newMethod;
197 return prev;
198 }
200 /** Warn about deprecated symbol.
201 * @param pos Position to be used for error reporting.
202 * @param sym The deprecated symbol.
203 */
204 void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
205 if (!lint.isSuppressed(LintCategory.DEPRECATION))
206 deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
207 }
209 /** Warn about unchecked operation.
210 * @param pos Position to be used for error reporting.
211 * @param msg A string describing the problem.
212 */
213 public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
214 if (!lint.isSuppressed(LintCategory.UNCHECKED))
215 uncheckedHandler.report(pos, msg, args);
216 }
218 /** Warn about unsafe vararg method decl.
219 * @param pos Position to be used for error reporting.
220 * @param sym The deprecated symbol.
221 */
222 void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
223 if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
224 log.warning(LintCategory.VARARGS, pos, key, args);
225 }
227 /** Warn about using proprietary API.
228 * @param pos Position to be used for error reporting.
229 * @param msg A string describing the problem.
230 */
231 public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
232 if (!lint.isSuppressed(LintCategory.SUNAPI))
233 sunApiHandler.report(pos, msg, args);
234 }
236 public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
237 if (lint.isEnabled(LintCategory.STATIC))
238 log.warning(LintCategory.STATIC, pos, msg, args);
239 }
241 /**
242 * Report any deferred diagnostics.
243 */
244 public void reportDeferredDiagnostics() {
245 deprecationHandler.reportDeferredDiagnostic();
246 uncheckedHandler.reportDeferredDiagnostic();
247 sunApiHandler.reportDeferredDiagnostic();
248 }
251 /** Report a failure to complete a class.
252 * @param pos Position to be used for error reporting.
253 * @param ex The failure to report.
254 */
255 public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
256 log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
257 if (ex instanceof ClassReader.BadClassFile
258 && !suppressAbortOnBadClassFile) throw new Abort();
259 else return syms.errType;
260 }
262 /** Report a type error.
263 * @param pos Position to be used for error reporting.
264 * @param problem A string describing the error.
265 * @param found The type that was found.
266 * @param req The type that was required.
267 */
268 Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
269 log.error(pos, "prob.found.req",
270 problem, found, req);
271 return types.createErrorType(found);
272 }
274 Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
275 log.error(pos, "prob.found.req.1", problem, found, req, explanation);
276 return types.createErrorType(found);
277 }
279 /** Report an error that wrong type tag was found.
280 * @param pos Position to be used for error reporting.
281 * @param required An internationalized string describing the type tag
282 * required.
283 * @param found The type that was found.
284 */
285 Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
286 // this error used to be raised by the parser,
287 // but has been delayed to this point:
288 if (found instanceof Type && ((Type)found).tag == VOID) {
289 log.error(pos, "illegal.start.of.type");
290 return syms.errType;
291 }
292 log.error(pos, "type.found.req", found, required);
293 return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
294 }
296 /** Report an error that symbol cannot be referenced before super
297 * has been called.
298 * @param pos Position to be used for error reporting.
299 * @param sym The referenced symbol.
300 */
301 void earlyRefError(DiagnosticPosition pos, Symbol sym) {
302 log.error(pos, "cant.ref.before.ctor.called", sym);
303 }
305 /** Report duplicate declaration error.
306 */
307 void duplicateError(DiagnosticPosition pos, Symbol sym) {
308 if (!sym.type.isErroneous()) {
309 Symbol location = sym.location();
310 if (location.kind == MTH &&
311 ((MethodSymbol)location).isStaticOrInstanceInit()) {
312 log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
313 kindName(sym.location()), kindName(sym.location().enclClass()),
314 sym.location().enclClass());
315 } else {
316 log.error(pos, "already.defined", kindName(sym), sym,
317 kindName(sym.location()), sym.location());
318 }
319 }
320 }
322 /** Report array/varargs duplicate declaration
323 */
324 void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
325 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
326 log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
327 }
328 }
330 /* ************************************************************************
331 * duplicate declaration checking
332 *************************************************************************/
334 /** Check that variable does not hide variable with same name in
335 * immediately enclosing local scope.
336 * @param pos Position for error reporting.
337 * @param v The symbol.
338 * @param s The scope.
339 */
340 void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
341 if (s.next != null) {
342 for (Scope.Entry e = s.next.lookup(v.name);
343 e.scope != null && e.sym.owner == v.owner;
344 e = e.next()) {
345 if (e.sym.kind == VAR &&
346 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
347 v.name != names.error) {
348 duplicateError(pos, e.sym);
349 return;
350 }
351 }
352 }
353 }
355 /** Check that a class or interface does not hide a class or
356 * interface with same name in immediately enclosing local scope.
357 * @param pos Position for error reporting.
358 * @param c The symbol.
359 * @param s The scope.
360 */
361 void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
362 if (s.next != null) {
363 for (Scope.Entry e = s.next.lookup(c.name);
364 e.scope != null && e.sym.owner == c.owner;
365 e = e.next()) {
366 if (e.sym.kind == TYP && e.sym.type.tag != TYPEVAR &&
367 (e.sym.owner.kind & (VAR | MTH)) != 0 &&
368 c.name != names.error) {
369 duplicateError(pos, e.sym);
370 return;
371 }
372 }
373 }
374 }
376 /** Check that class does not have the same name as one of
377 * its enclosing classes, or as a class defined in its enclosing scope.
378 * return true if class is unique in its enclosing scope.
379 * @param pos Position for error reporting.
380 * @param name The class name.
381 * @param s The enclosing scope.
382 */
383 boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
384 for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
385 if (e.sym.kind == TYP && e.sym.name != names.error) {
386 duplicateError(pos, e.sym);
387 return false;
388 }
389 }
390 for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
391 if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
392 duplicateError(pos, sym);
393 return true;
394 }
395 }
396 return true;
397 }
399 /* *************************************************************************
400 * Class name generation
401 **************************************************************************/
403 /** Return name of local class.
404 * This is of the form <enclClass> $ n <classname>
405 * where
406 * enclClass is the flat name of the enclosing class,
407 * classname is the simple name of the local class
408 */
409 Name localClassName(ClassSymbol c) {
410 for (int i=1; ; i++) {
411 Name flatname = names.
412 fromString("" + c.owner.enclClass().flatname +
413 syntheticNameChar + i +
414 c.name);
415 if (compiled.get(flatname) == null) return flatname;
416 }
417 }
419 /* *************************************************************************
420 * Type Checking
421 **************************************************************************/
423 /** Check that a given type is assignable to a given proto-type.
424 * If it is, return the type, otherwise return errType.
425 * @param pos Position to be used for error reporting.
426 * @param found The type that was found.
427 * @param req The type that was required.
428 */
429 Type checkType(DiagnosticPosition pos, Type found, Type req) {
430 return checkType(pos, found, req, "incompatible.types");
431 }
433 Type checkType(DiagnosticPosition pos, Type found, Type req, String errKey) {
434 if (req.tag == ERROR)
435 return req;
436 if (found.tag == FORALL)
437 return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req));
438 if (req.tag == NONE)
439 return found;
440 if (types.isAssignable(found, req, convertWarner(pos, found, req)))
441 return found;
442 if (found.tag <= DOUBLE && req.tag <= DOUBLE)
443 return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req);
444 if (found.isSuperBound()) {
445 log.error(pos, "assignment.from.super-bound", found);
446 return types.createErrorType(found);
447 }
448 if (req.isExtendsBound()) {
449 log.error(pos, "assignment.to.extends-bound", req);
450 return types.createErrorType(found);
451 }
452 return typeError(pos, diags.fragment(errKey), found, req);
453 }
455 /** Instantiate polymorphic type to some prototype, unless
456 * prototype is `anyPoly' in which case polymorphic type
457 * is returned unchanged.
458 */
459 Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException {
460 if (pt == Infer.anyPoly && complexInference) {
461 return t;
462 } else if (pt == Infer.anyPoly || pt.tag == NONE) {
463 Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
464 return instantiatePoly(pos, t, newpt, warn);
465 } else if (pt.tag == ERROR) {
466 return pt;
467 } else {
468 try {
469 return infer.instantiateExpr(t, pt, warn);
470 } catch (Infer.NoInstanceException ex) {
471 if (ex.isAmbiguous) {
472 JCDiagnostic d = ex.getDiagnostic();
473 log.error(pos,
474 "undetermined.type" + (d!=null ? ".1" : ""),
475 t, d);
476 return types.createErrorType(pt);
477 } else {
478 JCDiagnostic d = ex.getDiagnostic();
479 return typeError(pos,
480 diags.fragment("incompatible.types" + (d!=null ? ".1" : ""), d),
481 t, pt);
482 }
483 } catch (Infer.InvalidInstanceException ex) {
484 JCDiagnostic d = ex.getDiagnostic();
485 log.error(pos, "invalid.inferred.types", t.tvars, d);
486 return types.createErrorType(pt);
487 }
488 }
489 }
491 /** Check that a given type can be cast to a given target type.
492 * Return the result of the cast.
493 * @param pos Position to be used for error reporting.
494 * @param found The type that is being cast.
495 * @param req The target type of the cast.
496 */
497 Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
498 if (found.tag == FORALL) {
499 instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
500 return req;
501 } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
502 return req;
503 } else {
504 return typeError(pos,
505 diags.fragment("inconvertible.types"),
506 found, req);
507 }
508 }
509 //where
510 /** Is type a type variable, or a (possibly multi-dimensional) array of
511 * type variables?
512 */
513 boolean isTypeVar(Type t) {
514 return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
515 }
517 /** Check that a type is within some bounds.
518 *
519 * Used in TypeApply to verify that, e.g., X in V<X> is a valid
520 * type argument.
521 * @param pos Position to be used for error reporting.
522 * @param a The type that should be bounded by bs.
523 * @param bs The bound.
524 */
525 private boolean checkExtends(Type a, TypeVar bs) {
526 if (a.isUnbound()) {
527 return true;
528 } else if (a.tag != WILDCARD) {
529 a = types.upperBound(a);
530 return types.isSubtype(a, bs.bound);
531 } else if (a.isExtendsBound()) {
532 return types.isCastable(bs.getUpperBound(), types.upperBound(a), Warner.noWarnings);
533 } else if (a.isSuperBound()) {
534 return !types.notSoftSubtype(types.lowerBound(a), bs.getUpperBound());
535 }
536 return true;
537 }
539 /** Check that type is different from 'void'.
540 * @param pos Position to be used for error reporting.
541 * @param t The type to be checked.
542 */
543 Type checkNonVoid(DiagnosticPosition pos, Type t) {
544 if (t.tag == VOID) {
545 log.error(pos, "void.not.allowed.here");
546 return types.createErrorType(t);
547 } else {
548 return t;
549 }
550 }
552 /** Check that type is a class or interface type.
553 * @param pos Position to be used for error reporting.
554 * @param t The type to be checked.
555 */
556 Type checkClassType(DiagnosticPosition pos, Type t) {
557 if (t.tag != CLASS && t.tag != ERROR)
558 return typeTagError(pos,
559 diags.fragment("type.req.class"),
560 (t.tag == TYPEVAR)
561 ? diags.fragment("type.parameter", t)
562 : t);
563 else
564 return t;
565 }
567 /** Check that type is a class or interface type.
568 * @param pos Position to be used for error reporting.
569 * @param t The type to be checked.
570 * @param noBounds True if type bounds are illegal here.
571 */
572 Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
573 t = checkClassType(pos, t);
574 if (noBounds && t.isParameterized()) {
575 List<Type> args = t.getTypeArguments();
576 while (args.nonEmpty()) {
577 if (args.head.tag == WILDCARD)
578 return typeTagError(pos,
579 diags.fragment("type.req.exact"),
580 args.head);
581 args = args.tail;
582 }
583 }
584 return t;
585 }
587 /** Check that type is a reifiable class, interface or array type.
588 * @param pos Position to be used for error reporting.
589 * @param t The type to be checked.
590 */
591 Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
592 if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
593 return typeTagError(pos,
594 diags.fragment("type.req.class.array"),
595 t);
596 } else if (!types.isReifiable(t)) {
597 log.error(pos, "illegal.generic.type.for.instof");
598 return types.createErrorType(t);
599 } else {
600 return t;
601 }
602 }
604 /** Check that type is a reference type, i.e. a class, interface or array type
605 * or a type variable.
606 * @param pos Position to be used for error reporting.
607 * @param t The type to be checked.
608 */
609 Type checkRefType(DiagnosticPosition pos, Type t) {
610 switch (t.tag) {
611 case CLASS:
612 case ARRAY:
613 case TYPEVAR:
614 case WILDCARD:
615 case ERROR:
616 return t;
617 default:
618 return typeTagError(pos,
619 diags.fragment("type.req.ref"),
620 t);
621 }
622 }
624 /** Check that each type is a reference type, i.e. a class, interface or array type
625 * or a type variable.
626 * @param trees Original trees, used for error reporting.
627 * @param types The types to be checked.
628 */
629 List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
630 List<JCExpression> tl = trees;
631 for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
632 l.head = checkRefType(tl.head.pos(), l.head);
633 tl = tl.tail;
634 }
635 return types;
636 }
638 /** Check that type is a null or reference type.
639 * @param pos Position to be used for error reporting.
640 * @param t The type to be checked.
641 */
642 Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
643 switch (t.tag) {
644 case CLASS:
645 case ARRAY:
646 case TYPEVAR:
647 case WILDCARD:
648 case BOT:
649 case ERROR:
650 return t;
651 default:
652 return typeTagError(pos,
653 diags.fragment("type.req.ref"),
654 t);
655 }
656 }
658 /** Check that flag set does not contain elements of two conflicting sets. s
659 * Return true if it doesn't.
660 * @param pos Position to be used for error reporting.
661 * @param flags The set of flags to be checked.
662 * @param set1 Conflicting flags set #1.
663 * @param set2 Conflicting flags set #2.
664 */
665 boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
666 if ((flags & set1) != 0 && (flags & set2) != 0) {
667 log.error(pos,
668 "illegal.combination.of.modifiers",
669 asFlagSet(TreeInfo.firstFlag(flags & set1)),
670 asFlagSet(TreeInfo.firstFlag(flags & set2)));
671 return false;
672 } else
673 return true;
674 }
676 /** Check that usage of diamond operator is correct (i.e. diamond should not
677 * be used with non-generic classes or in anonymous class creation expressions)
678 */
679 Type checkDiamond(JCNewClass tree, Type t) {
680 if (!TreeInfo.isDiamond(tree) ||
681 t.isErroneous()) {
682 return checkClassType(tree.clazz.pos(), t, true);
683 } else if (tree.def != null) {
684 log.error(tree.clazz.pos(),
685 "cant.apply.diamond.1",
686 t, diags.fragment("diamond.and.anon.class", t));
687 return types.createErrorType(t);
688 } else if (t.tsym.type.getTypeArguments().isEmpty()) {
689 log.error(tree.clazz.pos(),
690 "cant.apply.diamond.1",
691 t, diags.fragment("diamond.non.generic", t));
692 return types.createErrorType(t);
693 } else if (tree.typeargs != null &&
694 tree.typeargs.nonEmpty()) {
695 log.error(tree.clazz.pos(),
696 "cant.apply.diamond.1",
697 t, diags.fragment("diamond.and.explicit.params", t));
698 return types.createErrorType(t);
699 } else {
700 return t;
701 }
702 }
704 void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
705 MethodSymbol m = tree.sym;
706 if (!allowSimplifiedVarargs) return;
707 boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
708 Type varargElemType = null;
709 if (m.isVarArgs()) {
710 varargElemType = types.elemtype(tree.params.last().type);
711 }
712 if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
713 if (varargElemType != null) {
714 log.error(tree,
715 "varargs.invalid.trustme.anno",
716 syms.trustMeType.tsym,
717 diags.fragment("varargs.trustme.on.virtual.varargs", m));
718 } else {
719 log.error(tree,
720 "varargs.invalid.trustme.anno",
721 syms.trustMeType.tsym,
722 diags.fragment("varargs.trustme.on.non.varargs.meth", m));
723 }
724 } else if (hasTrustMeAnno && varargElemType != null &&
725 types.isReifiable(varargElemType)) {
726 warnUnsafeVararg(tree,
727 "varargs.redundant.trustme.anno",
728 syms.trustMeType.tsym,
729 diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
730 }
731 else if (!hasTrustMeAnno && varargElemType != null &&
732 !types.isReifiable(varargElemType)) {
733 warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
734 }
735 }
736 //where
737 private boolean isTrustMeAllowedOnMethod(Symbol s) {
738 return (s.flags() & VARARGS) != 0 &&
739 (s.isConstructor() ||
740 (s.flags() & (STATIC | FINAL)) != 0);
741 }
743 /**
744 * Check that vararg method call is sound
745 * @param pos Position to be used for error reporting.
746 * @param argtypes Actual arguments supplied to vararg method.
747 */
748 void checkVararg(DiagnosticPosition pos, List<Type> argtypes, Symbol msym) {
749 Type argtype = argtypes.last();
750 if (!types.isReifiable(argtype) &&
751 (!allowSimplifiedVarargs ||
752 msym.attribute(syms.trustMeType.tsym) == null ||
753 !isTrustMeAllowedOnMethod(msym))) {
754 warnUnchecked(pos,
755 "unchecked.generic.array.creation",
756 argtype);
757 }
758 }
760 /**
761 * Check that type 't' is a valid instantiation of a generic class
762 * (see JLS 4.5)
763 *
764 * @param t class type to be checked
765 * @return true if 't' is well-formed
766 */
767 public boolean checkValidGenericType(Type t) {
768 return firstIncompatibleTypeArg(t) == null;
769 }
770 //WHERE
771 private Type firstIncompatibleTypeArg(Type type) {
772 List<Type> formals = type.tsym.type.allparams();
773 List<Type> actuals = type.allparams();
774 List<Type> args = type.getTypeArguments();
775 List<Type> forms = type.tsym.type.getTypeArguments();
776 ListBuffer<Type> tvars_buf = new ListBuffer<Type>();
778 // For matching pairs of actual argument types `a' and
779 // formal type parameters with declared bound `b' ...
780 while (args.nonEmpty() && forms.nonEmpty()) {
781 // exact type arguments needs to know their
782 // bounds (for upper and lower bound
783 // calculations). So we create new TypeVars with
784 // bounds substed with actuals.
785 tvars_buf.append(types.substBound(((TypeVar)forms.head),
786 formals,
787 actuals));
788 args = args.tail;
789 forms = forms.tail;
790 }
792 args = type.getTypeArguments();
793 List<Type> tvars_cap = types.substBounds(formals,
794 formals,
795 types.capture(type).allparams());
796 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
797 // Let the actual arguments know their bound
798 args.head.withTypeVar((TypeVar)tvars_cap.head);
799 args = args.tail;
800 tvars_cap = tvars_cap.tail;
801 }
803 args = type.getTypeArguments();
804 List<Type> tvars = tvars_buf.toList();
806 while (args.nonEmpty() && tvars.nonEmpty()) {
807 Type actual = types.subst(args.head,
808 type.tsym.type.getTypeArguments(),
809 tvars_buf.toList());
810 if (!isTypeArgErroneous(actual) &&
811 !tvars.head.getUpperBound().isErroneous() &&
812 !checkExtends(actual, (TypeVar)tvars.head)) {
813 return args.head;
814 }
815 args = args.tail;
816 tvars = tvars.tail;
817 }
819 args = type.getTypeArguments();
820 tvars = tvars_buf.toList();
822 for (Type arg : types.capture(type).getTypeArguments()) {
823 if (arg.tag == TYPEVAR &&
824 arg.getUpperBound().isErroneous() &&
825 !tvars.head.getUpperBound().isErroneous() &&
826 !isTypeArgErroneous(args.head)) {
827 return args.head;
828 }
829 tvars = tvars.tail;
830 args = args.tail;
831 }
833 return null;
834 }
835 //where
836 boolean isTypeArgErroneous(Type t) {
837 return isTypeArgErroneous.visit(t);
838 }
840 Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
841 public Boolean visitType(Type t, Void s) {
842 return t.isErroneous();
843 }
844 @Override
845 public Boolean visitTypeVar(TypeVar t, Void s) {
846 return visit(t.getUpperBound());
847 }
848 @Override
849 public Boolean visitCapturedType(CapturedType t, Void s) {
850 return visit(t.getUpperBound()) ||
851 visit(t.getLowerBound());
852 }
853 @Override
854 public Boolean visitWildcardType(WildcardType t, Void s) {
855 return visit(t.type);
856 }
857 };
859 /** Check that given modifiers are legal for given symbol and
860 * return modifiers together with any implicit modififiers for that symbol.
861 * Warning: we can't use flags() here since this method
862 * is called during class enter, when flags() would cause a premature
863 * completion.
864 * @param pos Position to be used for error reporting.
865 * @param flags The set of modifiers given in a definition.
866 * @param sym The defined symbol.
867 */
868 long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
869 long mask;
870 long implicit = 0;
871 switch (sym.kind) {
872 case VAR:
873 if (sym.owner.kind != TYP)
874 mask = LocalVarFlags;
875 else if ((sym.owner.flags_field & INTERFACE) != 0)
876 mask = implicit = InterfaceVarFlags;
877 else
878 mask = VarFlags;
879 break;
880 case MTH:
881 if (sym.name == names.init) {
882 if ((sym.owner.flags_field & ENUM) != 0) {
883 // enum constructors cannot be declared public or
884 // protected and must be implicitly or explicitly
885 // private
886 implicit = PRIVATE;
887 mask = PRIVATE;
888 } else
889 mask = ConstructorFlags;
890 } else if ((sym.owner.flags_field & INTERFACE) != 0)
891 mask = implicit = InterfaceMethodFlags;
892 else {
893 mask = MethodFlags;
894 }
895 // Imply STRICTFP if owner has STRICTFP set.
896 if (((flags|implicit) & Flags.ABSTRACT) == 0)
897 implicit |= sym.owner.flags_field & STRICTFP;
898 break;
899 case TYP:
900 if (sym.isLocal()) {
901 mask = LocalClassFlags;
902 if (sym.name.isEmpty()) { // Anonymous class
903 // Anonymous classes in static methods are themselves static;
904 // that's why we admit STATIC here.
905 mask |= STATIC;
906 // JLS: Anonymous classes are final.
907 implicit |= FINAL;
908 }
909 if ((sym.owner.flags_field & STATIC) == 0 &&
910 (flags & ENUM) != 0)
911 log.error(pos, "enums.must.be.static");
912 } else if (sym.owner.kind == TYP) {
913 mask = MemberClassFlags;
914 if (sym.owner.owner.kind == PCK ||
915 (sym.owner.flags_field & STATIC) != 0)
916 mask |= STATIC;
917 else if ((flags & ENUM) != 0)
918 log.error(pos, "enums.must.be.static");
919 // Nested interfaces and enums are always STATIC (Spec ???)
920 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
921 } else {
922 mask = ClassFlags;
923 }
924 // Interfaces are always ABSTRACT
925 if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
927 if ((flags & ENUM) != 0) {
928 // enums can't be declared abstract or final
929 mask &= ~(ABSTRACT | FINAL);
930 implicit |= implicitEnumFinalFlag(tree);
931 }
932 // Imply STRICTFP if owner has STRICTFP set.
933 implicit |= sym.owner.flags_field & STRICTFP;
934 break;
935 default:
936 throw new AssertionError();
937 }
938 long illegal = flags & StandardFlags & ~mask;
939 if (illegal != 0) {
940 if ((illegal & INTERFACE) != 0) {
941 log.error(pos, "intf.not.allowed.here");
942 mask |= INTERFACE;
943 }
944 else {
945 log.error(pos,
946 "mod.not.allowed.here", asFlagSet(illegal));
947 }
948 }
949 else if ((sym.kind == TYP ||
950 // ISSUE: Disallowing abstract&private is no longer appropriate
951 // in the presence of inner classes. Should it be deleted here?
952 checkDisjoint(pos, flags,
953 ABSTRACT,
954 PRIVATE | STATIC))
955 &&
956 checkDisjoint(pos, flags,
957 ABSTRACT | INTERFACE,
958 FINAL | NATIVE | SYNCHRONIZED)
959 &&
960 checkDisjoint(pos, flags,
961 PUBLIC,
962 PRIVATE | PROTECTED)
963 &&
964 checkDisjoint(pos, flags,
965 PRIVATE,
966 PUBLIC | PROTECTED)
967 &&
968 checkDisjoint(pos, flags,
969 FINAL,
970 VOLATILE)
971 &&
972 (sym.kind == TYP ||
973 checkDisjoint(pos, flags,
974 ABSTRACT | NATIVE,
975 STRICTFP))) {
976 // skip
977 }
978 return flags & (mask | ~StandardFlags) | implicit;
979 }
982 /** Determine if this enum should be implicitly final.
983 *
984 * If the enum has no specialized enum contants, it is final.
985 *
986 * If the enum does have specialized enum contants, it is
987 * <i>not</i> final.
988 */
989 private long implicitEnumFinalFlag(JCTree tree) {
990 if (tree.getTag() != JCTree.CLASSDEF) return 0;
991 class SpecialTreeVisitor extends JCTree.Visitor {
992 boolean specialized;
993 SpecialTreeVisitor() {
994 this.specialized = false;
995 };
997 @Override
998 public void visitTree(JCTree tree) { /* no-op */ }
1000 @Override
1001 public void visitVarDef(JCVariableDecl tree) {
1002 if ((tree.mods.flags & ENUM) != 0) {
1003 if (tree.init instanceof JCNewClass &&
1004 ((JCNewClass) tree.init).def != null) {
1005 specialized = true;
1006 }
1007 }
1008 }
1009 }
1011 SpecialTreeVisitor sts = new SpecialTreeVisitor();
1012 JCClassDecl cdef = (JCClassDecl) tree;
1013 for (JCTree defs: cdef.defs) {
1014 defs.accept(sts);
1015 if (sts.specialized) return 0;
1016 }
1017 return FINAL;
1018 }
1020 /* *************************************************************************
1021 * Type Validation
1022 **************************************************************************/
1024 /** Validate a type expression. That is,
1025 * check that all type arguments of a parametric type are within
1026 * their bounds. This must be done in a second phase after type attributon
1027 * since a class might have a subclass as type parameter bound. E.g:
1028 *
1029 * class B<A extends C> { ... }
1030 * class C extends B<C> { ... }
1031 *
1032 * and we can't make sure that the bound is already attributed because
1033 * of possible cycles.
1034 *
1035 * Visitor method: Validate a type expression, if it is not null, catching
1036 * and reporting any completion failures.
1037 */
1038 void validate(JCTree tree, Env<AttrContext> env) {
1039 validate(tree, env, true);
1040 }
1041 void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
1042 new Validator(env).validateTree(tree, checkRaw, true);
1043 }
1045 /** Visitor method: Validate a list of type expressions.
1046 */
1047 void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
1048 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
1049 validate(l.head, env);
1050 }
1052 /** A visitor class for type validation.
1053 */
1054 class Validator extends JCTree.Visitor {
1056 boolean isOuter;
1057 Env<AttrContext> env;
1059 Validator(Env<AttrContext> env) {
1060 this.env = env;
1061 }
1063 @Override
1064 public void visitTypeArray(JCArrayTypeTree tree) {
1065 tree.elemtype.accept(this);
1066 }
1068 @Override
1069 public void visitTypeApply(JCTypeApply tree) {
1070 if (tree.type.tag == CLASS) {
1071 List<JCExpression> args = tree.arguments;
1072 List<Type> forms = tree.type.tsym.type.getTypeArguments();
1074 Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
1075 if (incompatibleArg != null) {
1076 for (JCTree arg : tree.arguments) {
1077 if (arg.type == incompatibleArg) {
1078 log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
1079 }
1080 forms = forms.tail;
1081 }
1082 }
1084 forms = tree.type.tsym.type.getTypeArguments();
1086 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
1088 // For matching pairs of actual argument types `a' and
1089 // formal type parameters with declared bound `b' ...
1090 while (args.nonEmpty() && forms.nonEmpty()) {
1091 validateTree(args.head,
1092 !(isOuter && is_java_lang_Class),
1093 false);
1094 args = args.tail;
1095 forms = forms.tail;
1096 }
1098 // Check that this type is either fully parameterized, or
1099 // not parameterized at all.
1100 if (tree.type.getEnclosingType().isRaw())
1101 log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
1102 if (tree.clazz.getTag() == JCTree.SELECT)
1103 visitSelectInternal((JCFieldAccess)tree.clazz);
1104 }
1105 }
1107 @Override
1108 public void visitTypeParameter(JCTypeParameter tree) {
1109 validateTrees(tree.bounds, true, isOuter);
1110 checkClassBounds(tree.pos(), tree.type);
1111 }
1113 @Override
1114 public void visitWildcard(JCWildcard tree) {
1115 if (tree.inner != null)
1116 validateTree(tree.inner, true, isOuter);
1117 }
1119 @Override
1120 public void visitSelect(JCFieldAccess tree) {
1121 if (tree.type.tag == CLASS) {
1122 visitSelectInternal(tree);
1124 // Check that this type is either fully parameterized, or
1125 // not parameterized at all.
1126 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
1127 log.error(tree.pos(), "improperly.formed.type.param.missing");
1128 }
1129 }
1131 public void visitSelectInternal(JCFieldAccess tree) {
1132 if (tree.type.tsym.isStatic() &&
1133 tree.selected.type.isParameterized()) {
1134 // The enclosing type is not a class, so we are
1135 // looking at a static member type. However, the
1136 // qualifying expression is parameterized.
1137 log.error(tree.pos(), "cant.select.static.class.from.param.type");
1138 } else {
1139 // otherwise validate the rest of the expression
1140 tree.selected.accept(this);
1141 }
1142 }
1144 /** Default visitor method: do nothing.
1145 */
1146 @Override
1147 public void visitTree(JCTree tree) {
1148 }
1150 public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
1151 try {
1152 if (tree != null) {
1153 this.isOuter = isOuter;
1154 tree.accept(this);
1155 if (checkRaw)
1156 checkRaw(tree, env);
1157 }
1158 } catch (CompletionFailure ex) {
1159 completionError(tree.pos(), ex);
1160 }
1161 }
1163 public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
1164 for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
1165 validateTree(l.head, checkRaw, isOuter);
1166 }
1168 void checkRaw(JCTree tree, Env<AttrContext> env) {
1169 if (lint.isEnabled(LintCategory.RAW) &&
1170 tree.type.tag == CLASS &&
1171 !TreeInfo.isDiamond(tree) &&
1172 !env.enclClass.name.isEmpty() && //anonymous or intersection
1173 tree.type.isRaw()) {
1174 log.warning(LintCategory.RAW,
1175 tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
1176 }
1177 }
1178 }
1180 /* *************************************************************************
1181 * Exception checking
1182 **************************************************************************/
1184 /* The following methods treat classes as sets that contain
1185 * the class itself and all their subclasses
1186 */
1188 /** Is given type a subtype of some of the types in given list?
1189 */
1190 boolean subset(Type t, List<Type> ts) {
1191 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
1192 if (types.isSubtype(t, l.head)) return true;
1193 return false;
1194 }
1196 /** Is given type a subtype or supertype of
1197 * some of the types in given list?
1198 */
1199 boolean intersects(Type t, List<Type> ts) {
1200 for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
1201 if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
1202 return false;
1203 }
1205 /** Add type set to given type list, unless it is a subclass of some class
1206 * in the list.
1207 */
1208 List<Type> incl(Type t, List<Type> ts) {
1209 return subset(t, ts) ? ts : excl(t, ts).prepend(t);
1210 }
1212 /** Remove type set from type set list.
1213 */
1214 List<Type> excl(Type t, List<Type> ts) {
1215 if (ts.isEmpty()) {
1216 return ts;
1217 } else {
1218 List<Type> ts1 = excl(t, ts.tail);
1219 if (types.isSubtype(ts.head, t)) return ts1;
1220 else if (ts1 == ts.tail) return ts;
1221 else return ts1.prepend(ts.head);
1222 }
1223 }
1225 /** Form the union of two type set lists.
1226 */
1227 List<Type> union(List<Type> ts1, List<Type> ts2) {
1228 List<Type> ts = ts1;
1229 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
1230 ts = incl(l.head, ts);
1231 return ts;
1232 }
1234 /** Form the difference of two type lists.
1235 */
1236 List<Type> diff(List<Type> ts1, List<Type> ts2) {
1237 List<Type> ts = ts1;
1238 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
1239 ts = excl(l.head, ts);
1240 return ts;
1241 }
1243 /** Form the intersection of two type lists.
1244 */
1245 public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
1246 List<Type> ts = List.nil();
1247 for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
1248 if (subset(l.head, ts2)) ts = incl(l.head, ts);
1249 for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
1250 if (subset(l.head, ts1)) ts = incl(l.head, ts);
1251 return ts;
1252 }
1254 /** Is exc an exception symbol that need not be declared?
1255 */
1256 boolean isUnchecked(ClassSymbol exc) {
1257 return
1258 exc.kind == ERR ||
1259 exc.isSubClass(syms.errorType.tsym, types) ||
1260 exc.isSubClass(syms.runtimeExceptionType.tsym, types);
1261 }
1263 /** Is exc an exception type that need not be declared?
1264 */
1265 boolean isUnchecked(Type exc) {
1266 return
1267 (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
1268 (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
1269 exc.tag == BOT;
1270 }
1272 /** Same, but handling completion failures.
1273 */
1274 boolean isUnchecked(DiagnosticPosition pos, Type exc) {
1275 try {
1276 return isUnchecked(exc);
1277 } catch (CompletionFailure ex) {
1278 completionError(pos, ex);
1279 return true;
1280 }
1281 }
1283 /** Is exc handled by given exception list?
1284 */
1285 boolean isHandled(Type exc, List<Type> handled) {
1286 return isUnchecked(exc) || subset(exc, handled);
1287 }
1289 /** Return all exceptions in thrown list that are not in handled list.
1290 * @param thrown The list of thrown exceptions.
1291 * @param handled The list of handled exceptions.
1292 */
1293 List<Type> unhandled(List<Type> thrown, List<Type> handled) {
1294 List<Type> unhandled = List.nil();
1295 for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
1296 if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
1297 return unhandled;
1298 }
1300 /* *************************************************************************
1301 * Overriding/Implementation checking
1302 **************************************************************************/
1304 /** The level of access protection given by a flag set,
1305 * where PRIVATE is highest and PUBLIC is lowest.
1306 */
1307 static int protection(long flags) {
1308 switch ((short)(flags & AccessFlags)) {
1309 case PRIVATE: return 3;
1310 case PROTECTED: return 1;
1311 default:
1312 case PUBLIC: return 0;
1313 case 0: return 2;
1314 }
1315 }
1317 /** A customized "cannot override" error message.
1318 * @param m The overriding method.
1319 * @param other The overridden method.
1320 * @return An internationalized string.
1321 */
1322 Object cannotOverride(MethodSymbol m, MethodSymbol other) {
1323 String key;
1324 if ((other.owner.flags() & INTERFACE) == 0)
1325 key = "cant.override";
1326 else if ((m.owner.flags() & INTERFACE) == 0)
1327 key = "cant.implement";
1328 else
1329 key = "clashes.with";
1330 return diags.fragment(key, m, m.location(), other, other.location());
1331 }
1333 /** A customized "override" warning message.
1334 * @param m The overriding method.
1335 * @param other The overridden method.
1336 * @return An internationalized string.
1337 */
1338 Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
1339 String key;
1340 if ((other.owner.flags() & INTERFACE) == 0)
1341 key = "unchecked.override";
1342 else if ((m.owner.flags() & INTERFACE) == 0)
1343 key = "unchecked.implement";
1344 else
1345 key = "unchecked.clash.with";
1346 return diags.fragment(key, m, m.location(), other, other.location());
1347 }
1349 /** A customized "override" warning message.
1350 * @param m The overriding method.
1351 * @param other The overridden method.
1352 * @return An internationalized string.
1353 */
1354 Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
1355 String key;
1356 if ((other.owner.flags() & INTERFACE) == 0)
1357 key = "varargs.override";
1358 else if ((m.owner.flags() & INTERFACE) == 0)
1359 key = "varargs.implement";
1360 else
1361 key = "varargs.clash.with";
1362 return diags.fragment(key, m, m.location(), other, other.location());
1363 }
1365 /** Check that this method conforms with overridden method 'other'.
1366 * where `origin' is the class where checking started.
1367 * Complications:
1368 * (1) Do not check overriding of synthetic methods
1369 * (reason: they might be final).
1370 * todo: check whether this is still necessary.
1371 * (2) Admit the case where an interface proxy throws fewer exceptions
1372 * than the method it implements. Augment the proxy methods with the
1373 * undeclared exceptions in this case.
1374 * (3) When generics are enabled, admit the case where an interface proxy
1375 * has a result type
1376 * extended by the result type of the method it implements.
1377 * Change the proxies result type to the smaller type in this case.
1378 *
1379 * @param tree The tree from which positions
1380 * are extracted for errors.
1381 * @param m The overriding method.
1382 * @param other The overridden method.
1383 * @param origin The class of which the overriding method
1384 * is a member.
1385 */
1386 void checkOverride(JCTree tree,
1387 MethodSymbol m,
1388 MethodSymbol other,
1389 ClassSymbol origin) {
1390 // Don't check overriding of synthetic methods or by bridge methods.
1391 if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
1392 return;
1393 }
1395 // Error if static method overrides instance method (JLS 8.4.6.2).
1396 if ((m.flags() & STATIC) != 0 &&
1397 (other.flags() & STATIC) == 0) {
1398 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
1399 cannotOverride(m, other));
1400 return;
1401 }
1403 // Error if instance method overrides static or final
1404 // method (JLS 8.4.6.1).
1405 if ((other.flags() & FINAL) != 0 ||
1406 (m.flags() & STATIC) == 0 &&
1407 (other.flags() & STATIC) != 0) {
1408 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
1409 cannotOverride(m, other),
1410 asFlagSet(other.flags() & (FINAL | STATIC)));
1411 return;
1412 }
1414 if ((m.owner.flags() & ANNOTATION) != 0) {
1415 // handled in validateAnnotationMethod
1416 return;
1417 }
1419 // Error if overriding method has weaker access (JLS 8.4.6.3).
1420 if ((origin.flags() & INTERFACE) == 0 &&
1421 protection(m.flags()) > protection(other.flags())) {
1422 log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
1423 cannotOverride(m, other),
1424 other.flags() == 0 ?
1425 Flag.PACKAGE :
1426 asFlagSet(other.flags() & AccessFlags));
1427 return;
1428 }
1430 Type mt = types.memberType(origin.type, m);
1431 Type ot = types.memberType(origin.type, other);
1432 // Error if overriding result type is different
1433 // (or, in the case of generics mode, not a subtype) of
1434 // overridden result type. We have to rename any type parameters
1435 // before comparing types.
1436 List<Type> mtvars = mt.getTypeArguments();
1437 List<Type> otvars = ot.getTypeArguments();
1438 Type mtres = mt.getReturnType();
1439 Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
1441 overrideWarner.clear();
1442 boolean resultTypesOK =
1443 types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
1444 if (!resultTypesOK) {
1445 if (!allowCovariantReturns &&
1446 m.owner != origin &&
1447 m.owner.isSubClass(other.owner, types)) {
1448 // allow limited interoperability with covariant returns
1449 } else {
1450 log.error(TreeInfo.diagnosticPositionFor(m, tree),
1451 "override.incompatible.ret",
1452 cannotOverride(m, other),
1453 mtres, otres);
1454 return;
1455 }
1456 } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
1457 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
1458 "override.unchecked.ret",
1459 uncheckedOverrides(m, other),
1460 mtres, otres);
1461 }
1463 // Error if overriding method throws an exception not reported
1464 // by overridden method.
1465 List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
1466 List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
1467 List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
1468 if (unhandledErased.nonEmpty()) {
1469 log.error(TreeInfo.diagnosticPositionFor(m, tree),
1470 "override.meth.doesnt.throw",
1471 cannotOverride(m, other),
1472 unhandledUnerased.head);
1473 return;
1474 }
1475 else if (unhandledUnerased.nonEmpty()) {
1476 warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
1477 "override.unchecked.thrown",
1478 cannotOverride(m, other),
1479 unhandledUnerased.head);
1480 return;
1481 }
1483 // Optional warning if varargs don't agree
1484 if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
1485 && lint.isEnabled(LintCategory.OVERRIDES)) {
1486 log.warning(TreeInfo.diagnosticPositionFor(m, tree),
1487 ((m.flags() & Flags.VARARGS) != 0)
1488 ? "override.varargs.missing"
1489 : "override.varargs.extra",
1490 varargsOverrides(m, other));
1491 }
1493 // Warn if instance method overrides bridge method (compiler spec ??)
1494 if ((other.flags() & BRIDGE) != 0) {
1495 log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
1496 uncheckedOverrides(m, other));
1497 }
1499 // Warn if a deprecated method overridden by a non-deprecated one.
1500 if (!isDeprecatedOverrideIgnorable(other, origin)) {
1501 checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
1502 }
1503 }
1504 // where
1505 private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
1506 // If the method, m, is defined in an interface, then ignore the issue if the method
1507 // is only inherited via a supertype and also implemented in the supertype,
1508 // because in that case, we will rediscover the issue when examining the method
1509 // in the supertype.
1510 // If the method, m, is not defined in an interface, then the only time we need to
1511 // address the issue is when the method is the supertype implemementation: any other
1512 // case, we will have dealt with when examining the supertype classes
1513 ClassSymbol mc = m.enclClass();
1514 Type st = types.supertype(origin.type);
1515 if (st.tag != CLASS)
1516 return true;
1517 MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
1519 if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
1520 List<Type> intfs = types.interfaces(origin.type);
1521 return (intfs.contains(mc.type) ? false : (stimpl != null));
1522 }
1523 else
1524 return (stimpl != m);
1525 }
1528 // used to check if there were any unchecked conversions
1529 Warner overrideWarner = new Warner();
1531 /** Check that a class does not inherit two concrete methods
1532 * with the same signature.
1533 * @param pos Position to be used for error reporting.
1534 * @param site The class type to be checked.
1535 */
1536 public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
1537 Type sup = types.supertype(site);
1538 if (sup.tag != CLASS) return;
1540 for (Type t1 = sup;
1541 t1.tsym.type.isParameterized();
1542 t1 = types.supertype(t1)) {
1543 for (Scope.Entry e1 = t1.tsym.members().elems;
1544 e1 != null;
1545 e1 = e1.sibling) {
1546 Symbol s1 = e1.sym;
1547 if (s1.kind != MTH ||
1548 (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
1549 !s1.isInheritedIn(site.tsym, types) ||
1550 ((MethodSymbol)s1).implementation(site.tsym,
1551 types,
1552 true) != s1)
1553 continue;
1554 Type st1 = types.memberType(t1, s1);
1555 int s1ArgsLength = st1.getParameterTypes().length();
1556 if (st1 == s1.type) continue;
1558 for (Type t2 = sup;
1559 t2.tag == CLASS;
1560 t2 = types.supertype(t2)) {
1561 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
1562 e2.scope != null;
1563 e2 = e2.next()) {
1564 Symbol s2 = e2.sym;
1565 if (s2 == s1 ||
1566 s2.kind != MTH ||
1567 (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
1568 s2.type.getParameterTypes().length() != s1ArgsLength ||
1569 !s2.isInheritedIn(site.tsym, types) ||
1570 ((MethodSymbol)s2).implementation(site.tsym,
1571 types,
1572 true) != s2)
1573 continue;
1574 Type st2 = types.memberType(t2, s2);
1575 if (types.overrideEquivalent(st1, st2))
1576 log.error(pos, "concrete.inheritance.conflict",
1577 s1, t1, s2, t2, sup);
1578 }
1579 }
1580 }
1581 }
1582 }
1584 /** Check that classes (or interfaces) do not each define an abstract
1585 * method with same name and arguments but incompatible return types.
1586 * @param pos Position to be used for error reporting.
1587 * @param t1 The first argument type.
1588 * @param t2 The second argument type.
1589 */
1590 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
1591 Type t1,
1592 Type t2) {
1593 return checkCompatibleAbstracts(pos, t1, t2,
1594 types.makeCompoundType(t1, t2));
1595 }
1597 public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
1598 Type t1,
1599 Type t2,
1600 Type site) {
1601 return firstIncompatibility(pos, t1, t2, site) == null;
1602 }
1604 /** Return the first method which is defined with same args
1605 * but different return types in two given interfaces, or null if none
1606 * exists.
1607 * @param t1 The first type.
1608 * @param t2 The second type.
1609 * @param site The most derived type.
1610 * @returns symbol from t2 that conflicts with one in t1.
1611 */
1612 private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
1613 Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
1614 closure(t1, interfaces1);
1615 Map<TypeSymbol,Type> interfaces2;
1616 if (t1 == t2)
1617 interfaces2 = interfaces1;
1618 else
1619 closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
1621 for (Type t3 : interfaces1.values()) {
1622 for (Type t4 : interfaces2.values()) {
1623 Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
1624 if (s != null) return s;
1625 }
1626 }
1627 return null;
1628 }
1630 /** Compute all the supertypes of t, indexed by type symbol. */
1631 private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
1632 if (t.tag != CLASS) return;
1633 if (typeMap.put(t.tsym, t) == null) {
1634 closure(types.supertype(t), typeMap);
1635 for (Type i : types.interfaces(t))
1636 closure(i, typeMap);
1637 }
1638 }
1640 /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
1641 private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
1642 if (t.tag != CLASS) return;
1643 if (typesSkip.get(t.tsym) != null) return;
1644 if (typeMap.put(t.tsym, t) == null) {
1645 closure(types.supertype(t), typesSkip, typeMap);
1646 for (Type i : types.interfaces(t))
1647 closure(i, typesSkip, typeMap);
1648 }
1649 }
1651 /** Return the first method in t2 that conflicts with a method from t1. */
1652 private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
1653 for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
1654 Symbol s1 = e1.sym;
1655 Type st1 = null;
1656 if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
1657 Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
1658 if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
1659 for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
1660 Symbol s2 = e2.sym;
1661 if (s1 == s2) continue;
1662 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
1663 if (st1 == null) st1 = types.memberType(t1, s1);
1664 Type st2 = types.memberType(t2, s2);
1665 if (types.overrideEquivalent(st1, st2)) {
1666 List<Type> tvars1 = st1.getTypeArguments();
1667 List<Type> tvars2 = st2.getTypeArguments();
1668 Type rt1 = st1.getReturnType();
1669 Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
1670 boolean compat =
1671 types.isSameType(rt1, rt2) ||
1672 rt1.tag >= CLASS && rt2.tag >= CLASS &&
1673 (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
1674 types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
1675 checkCommonOverriderIn(s1,s2,site);
1676 if (!compat) {
1677 log.error(pos, "types.incompatible.diff.ret",
1678 t1, t2, s2.name +
1679 "(" + types.memberType(t2, s2).getParameterTypes() + ")");
1680 return s2;
1681 }
1682 } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
1683 !checkCommonOverriderIn(s1, s2, site)) {
1684 log.error(pos,
1685 "name.clash.same.erasure.no.override",
1686 s1, s1.location(),
1687 s2, s2.location());
1688 return s2;
1689 }
1690 }
1691 }
1692 return null;
1693 }
1694 //WHERE
1695 boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
1696 Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
1697 Type st1 = types.memberType(site, s1);
1698 Type st2 = types.memberType(site, s2);
1699 closure(site, supertypes);
1700 for (Type t : supertypes.values()) {
1701 for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
1702 Symbol s3 = e.sym;
1703 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
1704 Type st3 = types.memberType(site,s3);
1705 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
1706 if (s3.owner == site.tsym) {
1707 return true;
1708 }
1709 List<Type> tvars1 = st1.getTypeArguments();
1710 List<Type> tvars2 = st2.getTypeArguments();
1711 List<Type> tvars3 = st3.getTypeArguments();
1712 Type rt1 = st1.getReturnType();
1713 Type rt2 = st2.getReturnType();
1714 Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
1715 Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
1716 boolean compat =
1717 rt13.tag >= CLASS && rt23.tag >= CLASS &&
1718 (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
1719 types.covariantReturnType(rt23, rt2, Warner.noWarnings));
1720 if (compat)
1721 return true;
1722 }
1723 }
1724 }
1725 return false;
1726 }
1728 /** Check that a given method conforms with any method it overrides.
1729 * @param tree The tree from which positions are extracted
1730 * for errors.
1731 * @param m The overriding method.
1732 */
1733 void checkOverride(JCTree tree, MethodSymbol m) {
1734 ClassSymbol origin = (ClassSymbol)m.owner;
1735 if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
1736 if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
1737 log.error(tree.pos(), "enum.no.finalize");
1738 return;
1739 }
1740 for (Type t = origin.type; t.tag == CLASS;
1741 t = types.supertype(t)) {
1742 if (t != origin.type) {
1743 checkOverride(tree, t, origin, m);
1744 }
1745 for (Type t2 : types.interfaces(t)) {
1746 checkOverride(tree, t2, origin, m);
1747 }
1748 }
1749 }
1751 void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
1752 TypeSymbol c = site.tsym;
1753 Scope.Entry e = c.members().lookup(m.name);
1754 while (e.scope != null) {
1755 if (m.overrides(e.sym, origin, types, false)) {
1756 if ((e.sym.flags() & ABSTRACT) == 0) {
1757 checkOverride(tree, m, (MethodSymbol)e.sym, origin);
1758 }
1759 }
1760 e = e.next();
1761 }
1762 }
1764 private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
1765 ClashFilter cf = new ClashFilter(origin.type);
1766 return (cf.accepts(s1) &&
1767 cf.accepts(s2) &&
1768 types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
1769 }
1772 /** Check that all abstract members of given class have definitions.
1773 * @param pos Position to be used for error reporting.
1774 * @param c The class.
1775 */
1776 void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
1777 try {
1778 MethodSymbol undef = firstUndef(c, c);
1779 if (undef != null) {
1780 if ((c.flags() & ENUM) != 0 &&
1781 types.supertype(c.type).tsym == syms.enumSym &&
1782 (c.flags() & FINAL) == 0) {
1783 // add the ABSTRACT flag to an enum
1784 c.flags_field |= ABSTRACT;
1785 } else {
1786 MethodSymbol undef1 =
1787 new MethodSymbol(undef.flags(), undef.name,
1788 types.memberType(c.type, undef), undef.owner);
1789 log.error(pos, "does.not.override.abstract",
1790 c, undef1, undef1.location());
1791 }
1792 }
1793 } catch (CompletionFailure ex) {
1794 completionError(pos, ex);
1795 }
1796 }
1797 //where
1798 /** Return first abstract member of class `c' that is not defined
1799 * in `impl', null if there is none.
1800 */
1801 private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
1802 MethodSymbol undef = null;
1803 // Do not bother to search in classes that are not abstract,
1804 // since they cannot have abstract members.
1805 if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
1806 Scope s = c.members();
1807 for (Scope.Entry e = s.elems;
1808 undef == null && e != null;
1809 e = e.sibling) {
1810 if (e.sym.kind == MTH &&
1811 (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
1812 MethodSymbol absmeth = (MethodSymbol)e.sym;
1813 MethodSymbol implmeth = absmeth.implementation(impl, types, true);
1814 if (implmeth == null || implmeth == absmeth)
1815 undef = absmeth;
1816 }
1817 }
1818 if (undef == null) {
1819 Type st = types.supertype(c.type);
1820 if (st.tag == CLASS)
1821 undef = firstUndef(impl, (ClassSymbol)st.tsym);
1822 }
1823 for (List<Type> l = types.interfaces(c.type);
1824 undef == null && l.nonEmpty();
1825 l = l.tail) {
1826 undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
1827 }
1828 }
1829 return undef;
1830 }
1832 void checkNonCyclicDecl(JCClassDecl tree) {
1833 CycleChecker cc = new CycleChecker();
1834 cc.scan(tree);
1835 if (!cc.errorFound && !cc.partialCheck) {
1836 tree.sym.flags_field |= ACYCLIC;
1837 }
1838 }
1840 class CycleChecker extends TreeScanner {
1842 List<Symbol> seenClasses = List.nil();
1843 boolean errorFound = false;
1844 boolean partialCheck = false;
1846 private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
1847 if (sym != null && sym.kind == TYP) {
1848 Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
1849 if (classEnv != null) {
1850 DiagnosticSource prevSource = log.currentSource();
1851 try {
1852 log.useSource(classEnv.toplevel.sourcefile);
1853 scan(classEnv.tree);
1854 }
1855 finally {
1856 log.useSource(prevSource.getFile());
1857 }
1858 } else if (sym.kind == TYP) {
1859 checkClass(pos, sym, List.<JCTree>nil());
1860 }
1861 } else {
1862 //not completed yet
1863 partialCheck = true;
1864 }
1865 }
1867 @Override
1868 public void visitSelect(JCFieldAccess tree) {
1869 super.visitSelect(tree);
1870 checkSymbol(tree.pos(), tree.sym);
1871 }
1873 @Override
1874 public void visitIdent(JCIdent tree) {
1875 checkSymbol(tree.pos(), tree.sym);
1876 }
1878 @Override
1879 public void visitTypeApply(JCTypeApply tree) {
1880 scan(tree.clazz);
1881 }
1883 @Override
1884 public void visitTypeArray(JCArrayTypeTree tree) {
1885 scan(tree.elemtype);
1886 }
1888 @Override
1889 public void visitClassDef(JCClassDecl tree) {
1890 List<JCTree> supertypes = List.nil();
1891 if (tree.getExtendsClause() != null) {
1892 supertypes = supertypes.prepend(tree.getExtendsClause());
1893 }
1894 if (tree.getImplementsClause() != null) {
1895 for (JCTree intf : tree.getImplementsClause()) {
1896 supertypes = supertypes.prepend(intf);
1897 }
1898 }
1899 checkClass(tree.pos(), tree.sym, supertypes);
1900 }
1902 void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
1903 if ((c.flags_field & ACYCLIC) != 0)
1904 return;
1905 if (seenClasses.contains(c)) {
1906 errorFound = true;
1907 noteCyclic(pos, (ClassSymbol)c);
1908 } else if (!c.type.isErroneous()) {
1909 try {
1910 seenClasses = seenClasses.prepend(c);
1911 if (c.type.tag == CLASS) {
1912 if (supertypes.nonEmpty()) {
1913 scan(supertypes);
1914 }
1915 else {
1916 ClassType ct = (ClassType)c.type;
1917 if (ct.supertype_field == null ||
1918 ct.interfaces_field == null) {
1919 //not completed yet
1920 partialCheck = true;
1921 return;
1922 }
1923 checkSymbol(pos, ct.supertype_field.tsym);
1924 for (Type intf : ct.interfaces_field) {
1925 checkSymbol(pos, intf.tsym);
1926 }
1927 }
1928 if (c.owner.kind == TYP) {
1929 checkSymbol(pos, c.owner);
1930 }
1931 }
1932 } finally {
1933 seenClasses = seenClasses.tail;
1934 }
1935 }
1936 }
1937 }
1939 /** Check for cyclic references. Issue an error if the
1940 * symbol of the type referred to has a LOCKED flag set.
1941 *
1942 * @param pos Position to be used for error reporting.
1943 * @param t The type referred to.
1944 */
1945 void checkNonCyclic(DiagnosticPosition pos, Type t) {
1946 checkNonCyclicInternal(pos, t);
1947 }
1950 void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
1951 checkNonCyclic1(pos, t, List.<TypeVar>nil());
1952 }
1954 private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
1955 final TypeVar tv;
1956 if (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
1957 return;
1958 if (seen.contains(t)) {
1959 tv = (TypeVar)t;
1960 tv.bound = types.createErrorType(t);
1961 log.error(pos, "cyclic.inheritance", t);
1962 } else if (t.tag == TYPEVAR) {
1963 tv = (TypeVar)t;
1964 seen = seen.prepend(tv);
1965 for (Type b : types.getBounds(tv))
1966 checkNonCyclic1(pos, b, seen);
1967 }
1968 }
1970 /** Check for cyclic references. Issue an error if the
1971 * symbol of the type referred to has a LOCKED flag set.
1972 *
1973 * @param pos Position to be used for error reporting.
1974 * @param t The type referred to.
1975 * @returns True if the check completed on all attributed classes
1976 */
1977 private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
1978 boolean complete = true; // was the check complete?
1979 //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
1980 Symbol c = t.tsym;
1981 if ((c.flags_field & ACYCLIC) != 0) return true;
1983 if ((c.flags_field & LOCKED) != 0) {
1984 noteCyclic(pos, (ClassSymbol)c);
1985 } else if (!c.type.isErroneous()) {
1986 try {
1987 c.flags_field |= LOCKED;
1988 if (c.type.tag == CLASS) {
1989 ClassType clazz = (ClassType)c.type;
1990 if (clazz.interfaces_field != null)
1991 for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
1992 complete &= checkNonCyclicInternal(pos, l.head);
1993 if (clazz.supertype_field != null) {
1994 Type st = clazz.supertype_field;
1995 if (st != null && st.tag == CLASS)
1996 complete &= checkNonCyclicInternal(pos, st);
1997 }
1998 if (c.owner.kind == TYP)
1999 complete &= checkNonCyclicInternal(pos, c.owner.type);
2000 }
2001 } finally {
2002 c.flags_field &= ~LOCKED;
2003 }
2004 }
2005 if (complete)
2006 complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
2007 if (complete) c.flags_field |= ACYCLIC;
2008 return complete;
2009 }
2011 /** Note that we found an inheritance cycle. */
2012 private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
2013 log.error(pos, "cyclic.inheritance", c);
2014 for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
2015 l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
2016 Type st = types.supertype(c.type);
2017 if (st.tag == CLASS)
2018 ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
2019 c.type = types.createErrorType(c, c.type);
2020 c.flags_field |= ACYCLIC;
2021 }
2023 /** Check that all methods which implement some
2024 * method conform to the method they implement.
2025 * @param tree The class definition whose members are checked.
2026 */
2027 void checkImplementations(JCClassDecl tree) {
2028 checkImplementations(tree, tree.sym);
2029 }
2030 //where
2031 /** Check that all methods which implement some
2032 * method in `ic' conform to the method they implement.
2033 */
2034 void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
2035 ClassSymbol origin = tree.sym;
2036 for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
2037 ClassSymbol lc = (ClassSymbol)l.head.tsym;
2038 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
2039 for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
2040 if (e.sym.kind == MTH &&
2041 (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
2042 MethodSymbol absmeth = (MethodSymbol)e.sym;
2043 MethodSymbol implmeth = absmeth.implementation(origin, types, false);
2044 if (implmeth != null && implmeth != absmeth &&
2045 (implmeth.owner.flags() & INTERFACE) ==
2046 (origin.flags() & INTERFACE)) {
2047 // don't check if implmeth is in a class, yet
2048 // origin is an interface. This case arises only
2049 // if implmeth is declared in Object. The reason is
2050 // that interfaces really don't inherit from
2051 // Object it's just that the compiler represents
2052 // things that way.
2053 checkOverride(tree, implmeth, absmeth, origin);
2054 }
2055 }
2056 }
2057 }
2058 }
2059 }
2061 /** Check that all abstract methods implemented by a class are
2062 * mutually compatible.
2063 * @param pos Position to be used for error reporting.
2064 * @param c The class whose interfaces are checked.
2065 */
2066 void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
2067 List<Type> supertypes = types.interfaces(c);
2068 Type supertype = types.supertype(c);
2069 if (supertype.tag == CLASS &&
2070 (supertype.tsym.flags() & ABSTRACT) != 0)
2071 supertypes = supertypes.prepend(supertype);
2072 for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
2073 if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
2074 !checkCompatibleAbstracts(pos, l.head, l.head, c))
2075 return;
2076 for (List<Type> m = supertypes; m != l; m = m.tail)
2077 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
2078 return;
2079 }
2080 checkCompatibleConcretes(pos, c);
2081 }
2083 void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
2084 for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
2085 for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
2086 // VM allows methods and variables with differing types
2087 if (sym.kind == e.sym.kind &&
2088 types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
2089 sym != e.sym &&
2090 (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
2091 (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
2092 (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
2093 syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
2094 return;
2095 }
2096 }
2097 }
2098 }
2100 /** Check that all non-override equivalent methods accessible from 'site'
2101 * are mutually compatible (JLS 8.4.8/9.4.1).
2102 *
2103 * @param pos Position to be used for error reporting.
2104 * @param site The class whose methods are checked.
2105 * @param sym The method symbol to be checked.
2106 */
2107 void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
2108 ClashFilter cf = new ClashFilter(site);
2109 //for each method m1 that is a member of 'site'...
2110 for (Symbol s1 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
2111 //...find another method m2 that is overridden (directly or indirectly)
2112 //by method 'sym' in 'site'
2113 for (Symbol s2 : types.membersClosure(site, false).getElementsByName(sym.name, cf)) {
2114 if (s1 == s2 || !sym.overrides(s2, site.tsym, types, false)) continue;
2115 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
2116 //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
2117 if (!types.isSubSignature(sym.type, types.memberType(site, s1), false) &&
2118 types.hasSameArgs(s1.erasure(types), s2.erasure(types))) {
2119 sym.flags_field |= CLASH;
2120 String key = s2 == sym ?
2121 "name.clash.same.erasure.no.override" :
2122 "name.clash.same.erasure.no.override.1";
2123 log.error(pos,
2124 key,
2125 sym, sym.location(),
2126 s1, s1.location(),
2127 s2, s2.location());
2128 return;
2129 }
2130 }
2131 }
2132 }
2136 /** Check that all static methods accessible from 'site' are
2137 * mutually compatible (JLS 8.4.8).
2138 *
2139 * @param pos Position to be used for error reporting.
2140 * @param site The class whose methods are checked.
2141 * @param sym The method symbol to be checked.
2142 */
2143 void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
2144 ClashFilter cf = new ClashFilter(site);
2145 //for each method m1 that is a member of 'site'...
2146 for (Symbol s : types.membersClosure(site, true).getElementsByName(sym.name, cf)) {
2147 //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
2148 //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
2149 if (!types.isSubSignature(sym.type, types.memberType(site, s), false) &&
2150 types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
2151 log.error(pos,
2152 "name.clash.same.erasure.no.hide",
2153 sym, sym.location(),
2154 s, s.location());
2155 return;
2156 }
2157 }
2158 }
2160 //where
2161 private class ClashFilter implements Filter<Symbol> {
2163 Type site;
2165 ClashFilter(Type site) {
2166 this.site = site;
2167 }
2169 boolean shouldSkip(Symbol s) {
2170 return (s.flags() & CLASH) != 0 &&
2171 s.owner == site.tsym;
2172 }
2174 public boolean accepts(Symbol s) {
2175 return s.kind == MTH &&
2176 (s.flags() & SYNTHETIC) == 0 &&
2177 !shouldSkip(s) &&
2178 s.isInheritedIn(site.tsym, types) &&
2179 !s.isConstructor();
2180 }
2181 }
2183 /** Report a conflict between a user symbol and a synthetic symbol.
2184 */
2185 private void syntheticError(DiagnosticPosition pos, Symbol sym) {
2186 if (!sym.type.isErroneous()) {
2187 if (warnOnSyntheticConflicts) {
2188 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
2189 }
2190 else {
2191 log.error(pos, "synthetic.name.conflict", sym, sym.location());
2192 }
2193 }
2194 }
2196 /** Check that class c does not implement directly or indirectly
2197 * the same parameterized interface with two different argument lists.
2198 * @param pos Position to be used for error reporting.
2199 * @param type The type whose interfaces are checked.
2200 */
2201 void checkClassBounds(DiagnosticPosition pos, Type type) {
2202 checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
2203 }
2204 //where
2205 /** Enter all interfaces of type `type' into the hash table `seensofar'
2206 * with their class symbol as key and their type as value. Make
2207 * sure no class is entered with two different types.
2208 */
2209 void checkClassBounds(DiagnosticPosition pos,
2210 Map<TypeSymbol,Type> seensofar,
2211 Type type) {
2212 if (type.isErroneous()) return;
2213 for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
2214 Type it = l.head;
2215 Type oldit = seensofar.put(it.tsym, it);
2216 if (oldit != null) {
2217 List<Type> oldparams = oldit.allparams();
2218 List<Type> newparams = it.allparams();
2219 if (!types.containsTypeEquivalent(oldparams, newparams))
2220 log.error(pos, "cant.inherit.diff.arg",
2221 it.tsym, Type.toString(oldparams),
2222 Type.toString(newparams));
2223 }
2224 checkClassBounds(pos, seensofar, it);
2225 }
2226 Type st = types.supertype(type);
2227 if (st != null) checkClassBounds(pos, seensofar, st);
2228 }
2230 /** Enter interface into into set.
2231 * If it existed already, issue a "repeated interface" error.
2232 */
2233 void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
2234 if (its.contains(it))
2235 log.error(pos, "repeated.interface");
2236 else {
2237 its.add(it);
2238 }
2239 }
2241 /* *************************************************************************
2242 * Check annotations
2243 **************************************************************************/
2245 /**
2246 * Recursively validate annotations values
2247 */
2248 void validateAnnotationTree(JCTree tree) {
2249 class AnnotationValidator extends TreeScanner {
2250 @Override
2251 public void visitAnnotation(JCAnnotation tree) {
2252 if (!tree.type.isErroneous()) {
2253 super.visitAnnotation(tree);
2254 validateAnnotation(tree);
2255 }
2256 }
2257 }
2258 tree.accept(new AnnotationValidator());
2259 }
2261 /** Annotation types are restricted to primitives, String, an
2262 * enum, an annotation, Class, Class<?>, Class<? extends
2263 * Anything>, arrays of the preceding.
2264 */
2265 void validateAnnotationType(JCTree restype) {
2266 // restype may be null if an error occurred, so don't bother validating it
2267 if (restype != null) {
2268 validateAnnotationType(restype.pos(), restype.type);
2269 }
2270 }
2272 void validateAnnotationType(DiagnosticPosition pos, Type type) {
2273 if (type.isPrimitive()) return;
2274 if (types.isSameType(type, syms.stringType)) return;
2275 if ((type.tsym.flags() & Flags.ENUM) != 0) return;
2276 if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
2277 if (types.lowerBound(type).tsym == syms.classType.tsym) return;
2278 if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
2279 validateAnnotationType(pos, types.elemtype(type));
2280 return;
2281 }
2282 log.error(pos, "invalid.annotation.member.type");
2283 }
2285 /**
2286 * "It is also a compile-time error if any method declared in an
2287 * annotation type has a signature that is override-equivalent to
2288 * that of any public or protected method declared in class Object
2289 * or in the interface annotation.Annotation."
2290 *
2291 * @jls 9.6 Annotation Types
2292 */
2293 void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
2294 for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
2295 Scope s = sup.tsym.members();
2296 for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
2297 if (e.sym.kind == MTH &&
2298 (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
2299 types.overrideEquivalent(m.type, e.sym.type))
2300 log.error(pos, "intf.annotation.member.clash", e.sym, sup);
2301 }
2302 }
2303 }
2305 /** Check the annotations of a symbol.
2306 */
2307 public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
2308 if (skipAnnotations) return;
2309 for (JCAnnotation a : annotations)
2310 validateAnnotation(a, s);
2311 }
2313 /** Check an annotation of a symbol.
2314 */
2315 public void validateAnnotation(JCAnnotation a, Symbol s) {
2316 validateAnnotationTree(a);
2318 if (!annotationApplicable(a, s))
2319 log.error(a.pos(), "annotation.type.not.applicable");
2321 if (a.annotationType.type.tsym == syms.overrideType.tsym) {
2322 if (!isOverrider(s))
2323 log.error(a.pos(), "method.does.not.override.superclass");
2324 }
2325 }
2327 /** Is s a method symbol that overrides a method in a superclass? */
2328 boolean isOverrider(Symbol s) {
2329 if (s.kind != MTH || s.isStatic())
2330 return false;
2331 MethodSymbol m = (MethodSymbol)s;
2332 TypeSymbol owner = (TypeSymbol)m.owner;
2333 for (Type sup : types.closure(owner.type)) {
2334 if (sup == owner.type)
2335 continue; // skip "this"
2336 Scope scope = sup.tsym.members();
2337 for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
2338 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
2339 return true;
2340 }
2341 }
2342 return false;
2343 }
2345 /** Is the annotation applicable to the symbol? */
2346 boolean annotationApplicable(JCAnnotation a, Symbol s) {
2347 Attribute.Compound atTarget =
2348 a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
2349 if (atTarget == null) return true;
2350 Attribute atValue = atTarget.member(names.value);
2351 if (!(atValue instanceof Attribute.Array)) return true; // error recovery
2352 Attribute.Array arr = (Attribute.Array) atValue;
2353 for (Attribute app : arr.values) {
2354 if (!(app instanceof Attribute.Enum)) return true; // recovery
2355 Attribute.Enum e = (Attribute.Enum) app;
2356 if (e.value.name == names.TYPE)
2357 { if (s.kind == TYP) return true; }
2358 else if (e.value.name == names.FIELD)
2359 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
2360 else if (e.value.name == names.METHOD)
2361 { if (s.kind == MTH && !s.isConstructor()) return true; }
2362 else if (e.value.name == names.PARAMETER)
2363 { if (s.kind == VAR &&
2364 s.owner.kind == MTH &&
2365 (s.flags() & PARAMETER) != 0)
2366 return true;
2367 }
2368 else if (e.value.name == names.CONSTRUCTOR)
2369 { if (s.kind == MTH && s.isConstructor()) return true; }
2370 else if (e.value.name == names.LOCAL_VARIABLE)
2371 { if (s.kind == VAR && s.owner.kind == MTH &&
2372 (s.flags() & PARAMETER) == 0)
2373 return true;
2374 }
2375 else if (e.value.name == names.ANNOTATION_TYPE)
2376 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
2377 return true;
2378 }
2379 else if (e.value.name == names.PACKAGE)
2380 { if (s.kind == PCK) return true; }
2381 else if (e.value.name == names.TYPE_USE)
2382 { if (s.kind == TYP ||
2383 s.kind == VAR ||
2384 (s.kind == MTH && !s.isConstructor() &&
2385 s.type.getReturnType().tag != VOID))
2386 return true;
2387 }
2388 else
2389 return true; // recovery
2390 }
2391 return false;
2392 }
2394 /** Check an annotation value.
2395 */
2396 public void validateAnnotation(JCAnnotation a) {
2397 // collect an inventory of the members (sorted alphabetically)
2398 Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
2399 public int compare(Symbol t, Symbol t1) {
2400 return t.name.compareTo(t1.name);
2401 }
2402 });
2403 for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
2404 e != null;
2405 e = e.sibling)
2406 if (e.sym.kind == MTH)
2407 members.add((MethodSymbol) e.sym);
2409 // count them off as they're annotated
2410 for (JCTree arg : a.args) {
2411 if (arg.getTag() != JCTree.ASSIGN) continue; // recovery
2412 JCAssign assign = (JCAssign) arg;
2413 Symbol m = TreeInfo.symbol(assign.lhs);
2414 if (m == null || m.type.isErroneous()) continue;
2415 if (!members.remove(m))
2416 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
2417 m.name, a.type);
2418 }
2420 // all the remaining ones better have default values
2421 ListBuffer<Name> missingDefaults = ListBuffer.lb();
2422 for (MethodSymbol m : members) {
2423 if (m.defaultValue == null && !m.type.isErroneous()) {
2424 missingDefaults.append(m.name);
2425 }
2426 }
2427 if (missingDefaults.nonEmpty()) {
2428 String key = (missingDefaults.size() > 1)
2429 ? "annotation.missing.default.value.1"
2430 : "annotation.missing.default.value";
2431 log.error(a.pos(), key, a.type, missingDefaults);
2432 }
2434 // special case: java.lang.annotation.Target must not have
2435 // repeated values in its value member
2436 if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
2437 a.args.tail == null)
2438 return;
2440 if (a.args.head.getTag() != JCTree.ASSIGN) return; // error recovery
2441 JCAssign assign = (JCAssign) a.args.head;
2442 Symbol m = TreeInfo.symbol(assign.lhs);
2443 if (m.name != names.value) return;
2444 JCTree rhs = assign.rhs;
2445 if (rhs.getTag() != JCTree.NEWARRAY) return;
2446 JCNewArray na = (JCNewArray) rhs;
2447 Set<Symbol> targets = new HashSet<Symbol>();
2448 for (JCTree elem : na.elems) {
2449 if (!targets.add(TreeInfo.symbol(elem))) {
2450 log.error(elem.pos(), "repeated.annotation.target");
2451 }
2452 }
2453 }
2455 void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
2456 if (allowAnnotations &&
2457 lint.isEnabled(LintCategory.DEP_ANN) &&
2458 (s.flags() & DEPRECATED) != 0 &&
2459 !syms.deprecatedType.isErroneous() &&
2460 s.attribute(syms.deprecatedType.tsym) == null) {
2461 log.warning(LintCategory.DEP_ANN,
2462 pos, "missing.deprecated.annotation");
2463 }
2464 }
2466 void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
2467 if ((s.flags() & DEPRECATED) != 0 &&
2468 (other.flags() & DEPRECATED) == 0 &&
2469 s.outermostClass() != other.outermostClass()) {
2470 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
2471 @Override
2472 public void report() {
2473 warnDeprecated(pos, s);
2474 }
2475 });
2476 };
2477 }
2479 void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
2480 if ((s.flags() & PROPRIETARY) != 0) {
2481 deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
2482 public void report() {
2483 if (enableSunApiLintControl)
2484 warnSunApi(pos, "sun.proprietary", s);
2485 else
2486 log.strictWarning(pos, "sun.proprietary", s);
2487 }
2488 });
2489 }
2490 }
2492 /* *************************************************************************
2493 * Check for recursive annotation elements.
2494 **************************************************************************/
2496 /** Check for cycles in the graph of annotation elements.
2497 */
2498 void checkNonCyclicElements(JCClassDecl tree) {
2499 if ((tree.sym.flags_field & ANNOTATION) == 0) return;
2500 Assert.check((tree.sym.flags_field & LOCKED) == 0);
2501 try {
2502 tree.sym.flags_field |= LOCKED;
2503 for (JCTree def : tree.defs) {
2504 if (def.getTag() != JCTree.METHODDEF) continue;
2505 JCMethodDecl meth = (JCMethodDecl)def;
2506 checkAnnotationResType(meth.pos(), meth.restype.type);
2507 }
2508 } finally {
2509 tree.sym.flags_field &= ~LOCKED;
2510 tree.sym.flags_field |= ACYCLIC_ANN;
2511 }
2512 }
2514 void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
2515 if ((tsym.flags_field & ACYCLIC_ANN) != 0)
2516 return;
2517 if ((tsym.flags_field & LOCKED) != 0) {
2518 log.error(pos, "cyclic.annotation.element");
2519 return;
2520 }
2521 try {
2522 tsym.flags_field |= LOCKED;
2523 for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
2524 Symbol s = e.sym;
2525 if (s.kind != Kinds.MTH)
2526 continue;
2527 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
2528 }
2529 } finally {
2530 tsym.flags_field &= ~LOCKED;
2531 tsym.flags_field |= ACYCLIC_ANN;
2532 }
2533 }
2535 void checkAnnotationResType(DiagnosticPosition pos, Type type) {
2536 switch (type.tag) {
2537 case TypeTags.CLASS:
2538 if ((type.tsym.flags() & ANNOTATION) != 0)
2539 checkNonCyclicElementsInternal(pos, type.tsym);
2540 break;
2541 case TypeTags.ARRAY:
2542 checkAnnotationResType(pos, types.elemtype(type));
2543 break;
2544 default:
2545 break; // int etc
2546 }
2547 }
2549 /* *************************************************************************
2550 * Check for cycles in the constructor call graph.
2551 **************************************************************************/
2553 /** Check for cycles in the graph of constructors calling other
2554 * constructors.
2555 */
2556 void checkCyclicConstructors(JCClassDecl tree) {
2557 Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
2559 // enter each constructor this-call into the map
2560 for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
2561 JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
2562 if (app == null) continue;
2563 JCMethodDecl meth = (JCMethodDecl) l.head;
2564 if (TreeInfo.name(app.meth) == names._this) {
2565 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
2566 } else {
2567 meth.sym.flags_field |= ACYCLIC;
2568 }
2569 }
2571 // Check for cycles in the map
2572 Symbol[] ctors = new Symbol[0];
2573 ctors = callMap.keySet().toArray(ctors);
2574 for (Symbol caller : ctors) {
2575 checkCyclicConstructor(tree, caller, callMap);
2576 }
2577 }
2579 /** Look in the map to see if the given constructor is part of a
2580 * call cycle.
2581 */
2582 private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
2583 Map<Symbol,Symbol> callMap) {
2584 if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
2585 if ((ctor.flags_field & LOCKED) != 0) {
2586 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
2587 "recursive.ctor.invocation");
2588 } else {
2589 ctor.flags_field |= LOCKED;
2590 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
2591 ctor.flags_field &= ~LOCKED;
2592 }
2593 ctor.flags_field |= ACYCLIC;
2594 }
2595 }
2597 /* *************************************************************************
2598 * Miscellaneous
2599 **************************************************************************/
2601 /**
2602 * Return the opcode of the operator but emit an error if it is an
2603 * error.
2604 * @param pos position for error reporting.
2605 * @param operator an operator
2606 * @param tag a tree tag
2607 * @param left type of left hand side
2608 * @param right type of right hand side
2609 */
2610 int checkOperator(DiagnosticPosition pos,
2611 OperatorSymbol operator,
2612 int tag,
2613 Type left,
2614 Type right) {
2615 if (operator.opcode == ByteCodes.error) {
2616 log.error(pos,
2617 "operator.cant.be.applied.1",
2618 treeinfo.operatorName(tag),
2619 left, right);
2620 }
2621 return operator.opcode;
2622 }
2625 /**
2626 * Check for division by integer constant zero
2627 * @param pos Position for error reporting.
2628 * @param operator The operator for the expression
2629 * @param operand The right hand operand for the expression
2630 */
2631 void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
2632 if (operand.constValue() != null
2633 && lint.isEnabled(LintCategory.DIVZERO)
2634 && operand.tag <= LONG
2635 && ((Number) (operand.constValue())).longValue() == 0) {
2636 int opc = ((OperatorSymbol)operator).opcode;
2637 if (opc == ByteCodes.idiv || opc == ByteCodes.imod
2638 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
2639 log.warning(LintCategory.DIVZERO, pos, "div.zero");
2640 }
2641 }
2642 }
2644 /**
2645 * Check for empty statements after if
2646 */
2647 void checkEmptyIf(JCIf tree) {
2648 if (tree.thenpart.getTag() == JCTree.SKIP && tree.elsepart == null && lint.isEnabled(LintCategory.EMPTY))
2649 log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
2650 }
2652 /** Check that symbol is unique in given scope.
2653 * @param pos Position for error reporting.
2654 * @param sym The symbol.
2655 * @param s The scope.
2656 */
2657 boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
2658 if (sym.type.isErroneous())
2659 return true;
2660 if (sym.owner.name == names.any) return false;
2661 for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
2662 if (sym != e.sym &&
2663 (e.sym.flags() & CLASH) == 0 &&
2664 sym.kind == e.sym.kind &&
2665 sym.name != names.error &&
2666 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
2667 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
2668 varargsDuplicateError(pos, sym, e.sym);
2669 return true;
2670 } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
2671 duplicateErasureError(pos, sym, e.sym);
2672 sym.flags_field |= CLASH;
2673 return true;
2674 } else {
2675 duplicateError(pos, e.sym);
2676 return false;
2677 }
2678 }
2679 }
2680 return true;
2681 }
2683 /** Report duplicate declaration error.
2684 */
2685 void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
2686 if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
2687 log.error(pos, "name.clash.same.erasure", sym1, sym2);
2688 }
2689 }
2691 /** Check that single-type import is not already imported or top-level defined,
2692 * but make an exception for two single-type imports which denote the same type.
2693 * @param pos Position for error reporting.
2694 * @param sym The symbol.
2695 * @param s The scope
2696 */
2697 boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
2698 return checkUniqueImport(pos, sym, s, false);
2699 }
2701 /** Check that static single-type import is not already imported or top-level defined,
2702 * but make an exception for two single-type imports which denote the same type.
2703 * @param pos Position for error reporting.
2704 * @param sym The symbol.
2705 * @param s The scope
2706 * @param staticImport Whether or not this was a static import
2707 */
2708 boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
2709 return checkUniqueImport(pos, sym, s, true);
2710 }
2712 /** Check that single-type import is not already imported or top-level defined,
2713 * but make an exception for two single-type imports which denote the same type.
2714 * @param pos Position for error reporting.
2715 * @param sym The symbol.
2716 * @param s The scope.
2717 * @param staticImport Whether or not this was a static import
2718 */
2719 private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
2720 for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
2721 // is encountered class entered via a class declaration?
2722 boolean isClassDecl = e.scope == s;
2723 if ((isClassDecl || sym != e.sym) &&
2724 sym.kind == e.sym.kind &&
2725 sym.name != names.error) {
2726 if (!e.sym.type.isErroneous()) {
2727 String what = e.sym.toString();
2728 if (!isClassDecl) {
2729 if (staticImport)
2730 log.error(pos, "already.defined.static.single.import", what);
2731 else
2732 log.error(pos, "already.defined.single.import", what);
2733 }
2734 else if (sym != e.sym)
2735 log.error(pos, "already.defined.this.unit", what);
2736 }
2737 return false;
2738 }
2739 }
2740 return true;
2741 }
2743 /** Check that a qualified name is in canonical form (for import decls).
2744 */
2745 public void checkCanonical(JCTree tree) {
2746 if (!isCanonical(tree))
2747 log.error(tree.pos(), "import.requires.canonical",
2748 TreeInfo.symbol(tree));
2749 }
2750 // where
2751 private boolean isCanonical(JCTree tree) {
2752 while (tree.getTag() == JCTree.SELECT) {
2753 JCFieldAccess s = (JCFieldAccess) tree;
2754 if (s.sym.owner != TreeInfo.symbol(s.selected))
2755 return false;
2756 tree = s.selected;
2757 }
2758 return true;
2759 }
2761 private class ConversionWarner extends Warner {
2762 final String uncheckedKey;
2763 final Type found;
2764 final Type expected;
2765 public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
2766 super(pos);
2767 this.uncheckedKey = uncheckedKey;
2768 this.found = found;
2769 this.expected = expected;
2770 }
2772 @Override
2773 public void warn(LintCategory lint) {
2774 boolean warned = this.warned;
2775 super.warn(lint);
2776 if (warned) return; // suppress redundant diagnostics
2777 switch (lint) {
2778 case UNCHECKED:
2779 Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
2780 break;
2781 case VARARGS:
2782 if (method != null &&
2783 method.attribute(syms.trustMeType.tsym) != null &&
2784 isTrustMeAllowedOnMethod(method) &&
2785 !types.isReifiable(method.type.getParameterTypes().last())) {
2786 Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
2787 }
2788 break;
2789 default:
2790 throw new AssertionError("Unexpected lint: " + lint);
2791 }
2792 }
2793 }
2795 public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
2796 return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
2797 }
2799 public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
2800 return new ConversionWarner(pos, "unchecked.assign", found, expected);
2801 }
2802 }
