src/share/classes/com/sun/tools/javac/comp/Check.java

Thu, 19 Aug 2010 11:52:58 +0100

author
mcimadamore
date
Thu, 19 Aug 2010 11:52:58 +0100
changeset 638
d6fe0ea070aa
parent 634
27bae58329d5
child 639
a75770c0d7f6
permissions
-rw-r--r--

6885255: Improve usability of raw warnings
Summary: raw warnings should be disabled in (i) instanceof expressions and (ii) when java.lang.Class is not parameterized
Reviewed-by: jjg

     1 /*
     2  * Copyright (c) 1999, 2009, Oracle and/or its affiliates. All rights reserved.
     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     4  *
     5  * This code is free software; you can redistribute it and/or modify it
     6  * under the terms of the GNU General Public License version 2 only, as
     7  * published by the Free Software Foundation.  Oracle designates this
     8  * particular file as subject to the "Classpath" exception as provided
     9  * by Oracle in the LICENSE file that accompanied this code.
    10  *
    11  * This code is distributed in the hope that it will be useful, but WITHOUT
    12  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    13  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    14  * version 2 for more details (a copy is included in the LICENSE file that
    15  * accompanied this code).
    16  *
    17  * You should have received a copy of the GNU General Public License version
    18  * 2 along with this work; if not, write to the Free Software Foundation,
    19  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    20  *
    21  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    22  * or visit www.oracle.com if you need additional information or have any
    23  * questions.
    24  */
    26 package com.sun.tools.javac.comp;
    28 import com.sun.source.tree.AssignmentTree;
    29 import java.util.*;
    30 import java.util.Set;
    32 import com.sun.tools.javac.code.*;
    33 import com.sun.tools.javac.jvm.*;
    34 import com.sun.tools.javac.tree.*;
    35 import com.sun.tools.javac.util.*;
    36 import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
    37 import com.sun.tools.javac.util.List;
    39 import com.sun.tools.javac.tree.JCTree.*;
    40 import com.sun.tools.javac.code.Lint;
    41 import com.sun.tools.javac.code.Lint.LintCategory;
    42 import com.sun.tools.javac.code.Type.*;
    43 import com.sun.tools.javac.code.Symbol.*;
    45 import static com.sun.tools.javac.code.Flags.*;
    46 import static com.sun.tools.javac.code.Kinds.*;
    47 import static com.sun.tools.javac.code.TypeTags.*;
    49 /** Type checking helper class for the attribution phase.
    50  *
    51  *  <p><b>This is NOT part of any supported API.
    52  *  If you write code that depends on this, you do so at your own risk.
    53  *  This code and its internal interfaces are subject to change or
    54  *  deletion without notice.</b>
    55  */
    56 public class Check {
    57     protected static final Context.Key<Check> checkKey =
    58         new Context.Key<Check>();
    60     private final Names names;
    61     private final Log log;
    62     private final Symtab syms;
    63     private final Infer infer;
    64     private final Types types;
    65     private final JCDiagnostic.Factory diags;
    66     private final boolean skipAnnotations;
    67     private boolean warnOnSyntheticConflicts;
    68     private boolean suppressAbortOnBadClassFile;
    69     private final TreeInfo treeinfo;
    71     // The set of lint options currently in effect. It is initialized
    72     // from the context, and then is set/reset as needed by Attr as it
    73     // visits all the various parts of the trees during attribution.
    74     private Lint lint;
    76     public static Check instance(Context context) {
    77         Check instance = context.get(checkKey);
    78         if (instance == null)
    79             instance = new Check(context);
    80         return instance;
    81     }
    83     protected Check(Context context) {
    84         context.put(checkKey, this);
    86         names = Names.instance(context);
    87         log = Log.instance(context);
    88         syms = Symtab.instance(context);
    89         infer = Infer.instance(context);
    90         this.types = Types.instance(context);
    91         diags = JCDiagnostic.Factory.instance(context);
    92         Options options = Options.instance(context);
    93         lint = Lint.instance(context);
    94         treeinfo = TreeInfo.instance(context);
    96         Source source = Source.instance(context);
    97         allowGenerics = source.allowGenerics();
    98         allowAnnotations = source.allowAnnotations();
    99         allowCovariantReturns = source.allowCovariantReturns();
   100         complexInference = options.get("-complexinference") != null;
   101         skipAnnotations = options.get("skipAnnotations") != null;
   102         warnOnSyntheticConflicts = options.get("warnOnSyntheticConflicts") != null;
   103         suppressAbortOnBadClassFile = options.get("suppressAbortOnBadClassFile") != null;
   105         Target target = Target.instance(context);
   106         syntheticNameChar = target.syntheticNameChar();
   108         boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
   109         boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
   110         boolean verboseVarargs = lint.isEnabled(LintCategory.VARARGS);
   111         boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
   112         boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
   114         deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
   115                 enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
   116         uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
   117                 enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
   118         unsafeVarargsHandler = new MandatoryWarningHandler(log, verboseVarargs,
   119                 enforceMandatoryWarnings, "varargs", LintCategory.VARARGS);
   120         sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
   121                 enforceMandatoryWarnings, "sunapi", null);
   122     }
   124     /** Switch: generics enabled?
   125      */
   126     boolean allowGenerics;
   128     /** Switch: annotations enabled?
   129      */
   130     boolean allowAnnotations;
   132     /** Switch: covariant returns enabled?
   133      */
   134     boolean allowCovariantReturns;
   136     /** Switch: -complexinference option set?
   137      */
   138     boolean complexInference;
   140     /** Character for synthetic names
   141      */
   142     char syntheticNameChar;
   144     /** A table mapping flat names of all compiled classes in this run to their
   145      *  symbols; maintained from outside.
   146      */
   147     public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
   149     /** A handler for messages about deprecated usage.
   150      */
   151     private MandatoryWarningHandler deprecationHandler;
   153     /** A handler for messages about unchecked or unsafe usage.
   154      */
   155     private MandatoryWarningHandler uncheckedHandler;
   157     /** A handler for messages about unchecked or unsafe vararg method decl.
   158      */
   159     private MandatoryWarningHandler unsafeVarargsHandler;
   161     /** A handler for messages about using proprietary API.
   162      */
   163     private MandatoryWarningHandler sunApiHandler;
   165 /* *************************************************************************
   166  * Errors and Warnings
   167  **************************************************************************/
   169     Lint setLint(Lint newLint) {
   170         Lint prev = lint;
   171         lint = newLint;
   172         return prev;
   173     }
   175     /** Warn about deprecated symbol.
   176      *  @param pos        Position to be used for error reporting.
   177      *  @param sym        The deprecated symbol.
   178      */
   179     void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
   180         if (!lint.isSuppressed(LintCategory.DEPRECATION))
   181             deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
   182     }
   184     /** Warn about unchecked operation.
   185      *  @param pos        Position to be used for error reporting.
   186      *  @param msg        A string describing the problem.
   187      */
   188     public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
   189         if (!lint.isSuppressed(LintCategory.UNCHECKED))
   190             uncheckedHandler.report(pos, msg, args);
   191     }
   193     /** Warn about unsafe vararg method decl.
   194      *  @param pos        Position to be used for error reporting.
   195      *  @param sym        The deprecated symbol.
   196      */
   197     void warnUnsafeVararg(DiagnosticPosition pos, Type elemType) {
   198         if (!lint.isSuppressed(LintCategory.VARARGS))
   199             unsafeVarargsHandler.report(pos, "varargs.non.reifiable.type", elemType);
   200     }
   202     /** Warn about using proprietary API.
   203      *  @param pos        Position to be used for error reporting.
   204      *  @param msg        A string describing the problem.
   205      */
   206     public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
   207         if (!lint.isSuppressed(LintCategory.SUNAPI))
   208             sunApiHandler.report(pos, msg, args);
   209     }
   211     public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
   212         if (lint.isEnabled(LintCategory.STATIC))
   213             log.warning(LintCategory.STATIC, pos, msg, args);
   214     }
   216     /**
   217      * Report any deferred diagnostics.
   218      */
   219     public void reportDeferredDiagnostics() {
   220         deprecationHandler.reportDeferredDiagnostic();
   221         uncheckedHandler.reportDeferredDiagnostic();
   222         unsafeVarargsHandler.reportDeferredDiagnostic();
   223         sunApiHandler.reportDeferredDiagnostic();
   224     }
   227     /** Report a failure to complete a class.
   228      *  @param pos        Position to be used for error reporting.
   229      *  @param ex         The failure to report.
   230      */
   231     public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
   232         log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
   233         if (ex instanceof ClassReader.BadClassFile
   234                 && !suppressAbortOnBadClassFile) throw new Abort();
   235         else return syms.errType;
   236     }
   238     /** Report a type error.
   239      *  @param pos        Position to be used for error reporting.
   240      *  @param problem    A string describing the error.
   241      *  @param found      The type that was found.
   242      *  @param req        The type that was required.
   243      */
   244     Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
   245         log.error(pos, "prob.found.req",
   246                   problem, found, req);
   247         return types.createErrorType(found);
   248     }
   250     Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
   251         log.error(pos, "prob.found.req.1", problem, found, req, explanation);
   252         return types.createErrorType(found);
   253     }
   255     /** Report an error that wrong type tag was found.
   256      *  @param pos        Position to be used for error reporting.
   257      *  @param required   An internationalized string describing the type tag
   258      *                    required.
   259      *  @param found      The type that was found.
   260      */
   261     Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
   262         // this error used to be raised by the parser,
   263         // but has been delayed to this point:
   264         if (found instanceof Type && ((Type)found).tag == VOID) {
   265             log.error(pos, "illegal.start.of.type");
   266             return syms.errType;
   267         }
   268         log.error(pos, "type.found.req", found, required);
   269         return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
   270     }
   272     /** Report an error that symbol cannot be referenced before super
   273      *  has been called.
   274      *  @param pos        Position to be used for error reporting.
   275      *  @param sym        The referenced symbol.
   276      */
   277     void earlyRefError(DiagnosticPosition pos, Symbol sym) {
   278         log.error(pos, "cant.ref.before.ctor.called", sym);
   279     }
   281     /** Report duplicate declaration error.
   282      */
   283     void duplicateError(DiagnosticPosition pos, Symbol sym) {
   284         if (!sym.type.isErroneous()) {
   285             log.error(pos, "already.defined", sym, sym.location());
   286         }
   287     }
   289     /** Report array/varargs duplicate declaration
   290      */
   291     void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
   292         if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
   293             log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
   294         }
   295     }
   297 /* ************************************************************************
   298  * duplicate declaration checking
   299  *************************************************************************/
   301     /** Check that variable does not hide variable with same name in
   302      *  immediately enclosing local scope.
   303      *  @param pos           Position for error reporting.
   304      *  @param v             The symbol.
   305      *  @param s             The scope.
   306      */
   307     void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
   308         if (s.next != null) {
   309             for (Scope.Entry e = s.next.lookup(v.name);
   310                  e.scope != null && e.sym.owner == v.owner;
   311                  e = e.next()) {
   312                 if (e.sym.kind == VAR &&
   313                     (e.sym.owner.kind & (VAR | MTH)) != 0 &&
   314                     v.name != names.error) {
   315                     duplicateError(pos, e.sym);
   316                     return;
   317                 }
   318             }
   319         }
   320     }
   322     /** Check that a class or interface does not hide a class or
   323      *  interface with same name in immediately enclosing local scope.
   324      *  @param pos           Position for error reporting.
   325      *  @param c             The symbol.
   326      *  @param s             The scope.
   327      */
   328     void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
   329         if (s.next != null) {
   330             for (Scope.Entry e = s.next.lookup(c.name);
   331                  e.scope != null && e.sym.owner == c.owner;
   332                  e = e.next()) {
   333                 if (e.sym.kind == TYP &&
   334                     (e.sym.owner.kind & (VAR | MTH)) != 0 &&
   335                     c.name != names.error) {
   336                     duplicateError(pos, e.sym);
   337                     return;
   338                 }
   339             }
   340         }
   341     }
   343     /** Check that class does not have the same name as one of
   344      *  its enclosing classes, or as a class defined in its enclosing scope.
   345      *  return true if class is unique in its enclosing scope.
   346      *  @param pos           Position for error reporting.
   347      *  @param name          The class name.
   348      *  @param s             The enclosing scope.
   349      */
   350     boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
   351         for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
   352             if (e.sym.kind == TYP && e.sym.name != names.error) {
   353                 duplicateError(pos, e.sym);
   354                 return false;
   355             }
   356         }
   357         for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
   358             if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
   359                 duplicateError(pos, sym);
   360                 return true;
   361             }
   362         }
   363         return true;
   364     }
   366 /* *************************************************************************
   367  * Class name generation
   368  **************************************************************************/
   370     /** Return name of local class.
   371      *  This is of the form    <enclClass> $ n <classname>
   372      *  where
   373      *    enclClass is the flat name of the enclosing class,
   374      *    classname is the simple name of the local class
   375      */
   376     Name localClassName(ClassSymbol c) {
   377         for (int i=1; ; i++) {
   378             Name flatname = names.
   379                 fromString("" + c.owner.enclClass().flatname +
   380                            syntheticNameChar + i +
   381                            c.name);
   382             if (compiled.get(flatname) == null) return flatname;
   383         }
   384     }
   386 /* *************************************************************************
   387  * Type Checking
   388  **************************************************************************/
   390     /** Check that a given type is assignable to a given proto-type.
   391      *  If it is, return the type, otherwise return errType.
   392      *  @param pos        Position to be used for error reporting.
   393      *  @param found      The type that was found.
   394      *  @param req        The type that was required.
   395      */
   396     Type checkType(DiagnosticPosition pos, Type found, Type req) {
   397         return checkType(pos, found, req, "incompatible.types");
   398     }
   400     Type checkType(DiagnosticPosition pos, Type found, Type req, String errKey) {
   401         if (req.tag == ERROR)
   402             return req;
   403         if (found.tag == FORALL)
   404             return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req));
   405         if (req.tag == NONE)
   406             return found;
   407         if (types.isAssignable(found, req, convertWarner(pos, found, req)))
   408             return found;
   409         if (found.tag <= DOUBLE && req.tag <= DOUBLE)
   410             return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req);
   411         if (found.isSuperBound()) {
   412             log.error(pos, "assignment.from.super-bound", found);
   413             return types.createErrorType(found);
   414         }
   415         if (req.isExtendsBound()) {
   416             log.error(pos, "assignment.to.extends-bound", req);
   417             return types.createErrorType(found);
   418         }
   419         return typeError(pos, diags.fragment(errKey), found, req);
   420     }
   422     /** Instantiate polymorphic type to some prototype, unless
   423      *  prototype is `anyPoly' in which case polymorphic type
   424      *  is returned unchanged.
   425      */
   426     Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException {
   427         if (pt == Infer.anyPoly && complexInference) {
   428             return t;
   429         } else if (pt == Infer.anyPoly || pt.tag == NONE) {
   430             Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
   431             return instantiatePoly(pos, t, newpt, warn);
   432         } else if (pt.tag == ERROR) {
   433             return pt;
   434         } else {
   435             try {
   436                 return infer.instantiateExpr(t, pt, warn);
   437             } catch (Infer.NoInstanceException ex) {
   438                 if (ex.isAmbiguous) {
   439                     JCDiagnostic d = ex.getDiagnostic();
   440                     log.error(pos,
   441                               "undetermined.type" + (d!=null ? ".1" : ""),
   442                               t, d);
   443                     return types.createErrorType(pt);
   444                 } else {
   445                     JCDiagnostic d = ex.getDiagnostic();
   446                     return typeError(pos,
   447                                      diags.fragment("incompatible.types" + (d!=null ? ".1" : ""), d),
   448                                      t, pt);
   449                 }
   450             } catch (Infer.InvalidInstanceException ex) {
   451                 JCDiagnostic d = ex.getDiagnostic();
   452                 log.error(pos, "invalid.inferred.types", t.tvars, d);
   453                 return types.createErrorType(pt);
   454             }
   455         }
   456     }
   458     /** Check that a given type can be cast to a given target type.
   459      *  Return the result of the cast.
   460      *  @param pos        Position to be used for error reporting.
   461      *  @param found      The type that is being cast.
   462      *  @param req        The target type of the cast.
   463      */
   464     Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
   465         if (found.tag == FORALL) {
   466             instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
   467             return req;
   468         } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
   469             return req;
   470         } else {
   471             return typeError(pos,
   472                              diags.fragment("inconvertible.types"),
   473                              found, req);
   474         }
   475     }
   476 //where
   477         /** Is type a type variable, or a (possibly multi-dimensional) array of
   478          *  type variables?
   479          */
   480         boolean isTypeVar(Type t) {
   481             return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
   482         }
   484     /** Check that a type is within some bounds.
   485      *
   486      *  Used in TypeApply to verify that, e.g., X in V<X> is a valid
   487      *  type argument.
   488      *  @param pos           Position to be used for error reporting.
   489      *  @param a             The type that should be bounded by bs.
   490      *  @param bs            The bound.
   491      */
   492     private void checkExtends(DiagnosticPosition pos, Type a, TypeVar bs) {
   493          if (a.isUnbound()) {
   494              return;
   495          } else if (a.tag != WILDCARD) {
   496              a = types.upperBound(a);
   497              for (List<Type> l = types.getBounds(bs); l.nonEmpty(); l = l.tail) {
   498                  if (!types.isSubtype(a, l.head)) {
   499                      log.error(pos, "not.within.bounds", a);
   500                      return;
   501                  }
   502              }
   503          } else if (a.isExtendsBound()) {
   504              if (!types.isCastable(bs.getUpperBound(), types.upperBound(a), Warner.noWarnings))
   505                  log.error(pos, "not.within.bounds", a);
   506          } else if (a.isSuperBound()) {
   507              if (types.notSoftSubtype(types.lowerBound(a), bs.getUpperBound()))
   508                  log.error(pos, "not.within.bounds", a);
   509          }
   510      }
   512     /** Check that a type is within some bounds.
   513      *
   514      *  Used in TypeApply to verify that, e.g., X in V<X> is a valid
   515      *  type argument.
   516      *  @param pos           Position to be used for error reporting.
   517      *  @param a             The type that should be bounded by bs.
   518      *  @param bs            The bound.
   519      */
   520     private void checkCapture(JCTypeApply tree) {
   521         List<JCExpression> args = tree.getTypeArguments();
   522         for (Type arg : types.capture(tree.type).getTypeArguments()) {
   523             if (arg.tag == TYPEVAR && arg.getUpperBound().isErroneous()) {
   524                 log.error(args.head.pos, "not.within.bounds", args.head.type);
   525                 break;
   526             }
   527             args = args.tail;
   528         }
   529      }
   531     /** Check that type is different from 'void'.
   532      *  @param pos           Position to be used for error reporting.
   533      *  @param t             The type to be checked.
   534      */
   535     Type checkNonVoid(DiagnosticPosition pos, Type t) {
   536         if (t.tag == VOID) {
   537             log.error(pos, "void.not.allowed.here");
   538             return types.createErrorType(t);
   539         } else {
   540             return t;
   541         }
   542     }
   544     /** Check that type is a class or interface type.
   545      *  @param pos           Position to be used for error reporting.
   546      *  @param t             The type to be checked.
   547      */
   548     Type checkClassType(DiagnosticPosition pos, Type t) {
   549         if (t.tag != CLASS && t.tag != ERROR)
   550             return typeTagError(pos,
   551                                 diags.fragment("type.req.class"),
   552                                 (t.tag == TYPEVAR)
   553                                 ? diags.fragment("type.parameter", t)
   554                                 : t);
   555         else
   556             return t;
   557     }
   559     /** Check that type is a class or interface type.
   560      *  @param pos           Position to be used for error reporting.
   561      *  @param t             The type to be checked.
   562      *  @param noBounds    True if type bounds are illegal here.
   563      */
   564     Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
   565         t = checkClassType(pos, t);
   566         if (noBounds && t.isParameterized()) {
   567             List<Type> args = t.getTypeArguments();
   568             while (args.nonEmpty()) {
   569                 if (args.head.tag == WILDCARD)
   570                     return typeTagError(pos,
   571                                         diags.fragment("type.req.exact"),
   572                                         args.head);
   573                 args = args.tail;
   574             }
   575         }
   576         return t;
   577     }
   579     /** Check that type is a reifiable class, interface or array type.
   580      *  @param pos           Position to be used for error reporting.
   581      *  @param t             The type to be checked.
   582      */
   583     Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
   584         if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
   585             return typeTagError(pos,
   586                                 diags.fragment("type.req.class.array"),
   587                                 t);
   588         } else if (!types.isReifiable(t)) {
   589             log.error(pos, "illegal.generic.type.for.instof");
   590             return types.createErrorType(t);
   591         } else {
   592             return t;
   593         }
   594     }
   596     /** Check that type is a reference type, i.e. a class, interface or array type
   597      *  or a type variable.
   598      *  @param pos           Position to be used for error reporting.
   599      *  @param t             The type to be checked.
   600      */
   601     Type checkRefType(DiagnosticPosition pos, Type t) {
   602         switch (t.tag) {
   603         case CLASS:
   604         case ARRAY:
   605         case TYPEVAR:
   606         case WILDCARD:
   607         case ERROR:
   608             return t;
   609         default:
   610             return typeTagError(pos,
   611                                 diags.fragment("type.req.ref"),
   612                                 t);
   613         }
   614     }
   616     /** Check that each type is a reference type, i.e. a class, interface or array type
   617      *  or a type variable.
   618      *  @param trees         Original trees, used for error reporting.
   619      *  @param types         The types to be checked.
   620      */
   621     List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
   622         List<JCExpression> tl = trees;
   623         for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
   624             l.head = checkRefType(tl.head.pos(), l.head);
   625             tl = tl.tail;
   626         }
   627         return types;
   628     }
   630     /** Check that type is a null or reference type.
   631      *  @param pos           Position to be used for error reporting.
   632      *  @param t             The type to be checked.
   633      */
   634     Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
   635         switch (t.tag) {
   636         case CLASS:
   637         case ARRAY:
   638         case TYPEVAR:
   639         case WILDCARD:
   640         case BOT:
   641         case ERROR:
   642             return t;
   643         default:
   644             return typeTagError(pos,
   645                                 diags.fragment("type.req.ref"),
   646                                 t);
   647         }
   648     }
   650     /** Check that flag set does not contain elements of two conflicting sets. s
   651      *  Return true if it doesn't.
   652      *  @param pos           Position to be used for error reporting.
   653      *  @param flags         The set of flags to be checked.
   654      *  @param set1          Conflicting flags set #1.
   655      *  @param set2          Conflicting flags set #2.
   656      */
   657     boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
   658         if ((flags & set1) != 0 && (flags & set2) != 0) {
   659             log.error(pos,
   660                       "illegal.combination.of.modifiers",
   661                       asFlagSet(TreeInfo.firstFlag(flags & set1)),
   662                       asFlagSet(TreeInfo.firstFlag(flags & set2)));
   663             return false;
   664         } else
   665             return true;
   666     }
   668     /** Check that the type inferred using the diamond operator does not contain
   669      *  non-denotable types such as captured types or intersection types.
   670      *  @param t the type inferred using the diamond operator
   671      */
   672     List<Type> checkDiamond(ClassType t) {
   673         DiamondTypeChecker dtc = new DiamondTypeChecker();
   674         ListBuffer<Type> buf = ListBuffer.lb();
   675         for (Type arg : t.getTypeArguments()) {
   676             if (!dtc.visit(arg, null)) {
   677                 buf.append(arg);
   678             }
   679         }
   680         return buf.toList();
   681     }
   683     static class DiamondTypeChecker extends Types.SimpleVisitor<Boolean, Void> {
   684         public Boolean visitType(Type t, Void s) {
   685             return true;
   686         }
   687         @Override
   688         public Boolean visitClassType(ClassType t, Void s) {
   689             if (t.isCompound()) {
   690                 return false;
   691             }
   692             for (Type targ : t.getTypeArguments()) {
   693                 if (!visit(targ, s)) {
   694                     return false;
   695                 }
   696             }
   697             return true;
   698         }
   699         @Override
   700         public Boolean visitCapturedType(CapturedType t, Void s) {
   701             return false;
   702         }
   703     }
   705     void checkVarargMethodDecl(JCMethodDecl tree) {
   706         MethodSymbol m = tree.sym;
   707         //check the element type of the vararg
   708         if (m.isVarArgs()) {
   709             Type varargElemType = types.elemtype(tree.params.last().type);
   710             if (!types.isReifiable(varargElemType)) {
   711                 warnUnsafeVararg(tree.params.head.pos(), varargElemType);
   712             }
   713         }
   714     }
   716     /**
   717      * Check that vararg method call is sound
   718      * @param pos Position to be used for error reporting.
   719      * @param argtypes Actual arguments supplied to vararg method.
   720      */
   721     void checkVararg(DiagnosticPosition pos, List<Type> argtypes, Symbol msym, Env<AttrContext> env) {
   722         Env<AttrContext> calleeLintEnv = env;
   723         while (calleeLintEnv.info.lint == null)
   724             calleeLintEnv = calleeLintEnv.next;
   725         Lint calleeLint = calleeLintEnv.info.lint.augment(msym.attributes_field, msym.flags());
   726         Type argtype = argtypes.last();
   727         if (!types.isReifiable(argtype) && !calleeLint.isSuppressed(Lint.LintCategory.VARARGS)) {
   728             warnUnchecked(pos,
   729                               "unchecked.generic.array.creation",
   730                               argtype);
   731         }
   732     }
   734     /** Check that given modifiers are legal for given symbol and
   735      *  return modifiers together with any implicit modififiers for that symbol.
   736      *  Warning: we can't use flags() here since this method
   737      *  is called during class enter, when flags() would cause a premature
   738      *  completion.
   739      *  @param pos           Position to be used for error reporting.
   740      *  @param flags         The set of modifiers given in a definition.
   741      *  @param sym           The defined symbol.
   742      */
   743     long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
   744         long mask;
   745         long implicit = 0;
   746         switch (sym.kind) {
   747         case VAR:
   748             if (sym.owner.kind != TYP)
   749                 mask = LocalVarFlags;
   750             else if ((sym.owner.flags_field & INTERFACE) != 0)
   751                 mask = implicit = InterfaceVarFlags;
   752             else
   753                 mask = VarFlags;
   754             break;
   755         case MTH:
   756             if (sym.name == names.init) {
   757                 if ((sym.owner.flags_field & ENUM) != 0) {
   758                     // enum constructors cannot be declared public or
   759                     // protected and must be implicitly or explicitly
   760                     // private
   761                     implicit = PRIVATE;
   762                     mask = PRIVATE;
   763                 } else
   764                     mask = ConstructorFlags;
   765             }  else if ((sym.owner.flags_field & INTERFACE) != 0)
   766                 mask = implicit = InterfaceMethodFlags;
   767             else {
   768                 mask = MethodFlags;
   769             }
   770             // Imply STRICTFP if owner has STRICTFP set.
   771             if (((flags|implicit) & Flags.ABSTRACT) == 0)
   772               implicit |= sym.owner.flags_field & STRICTFP;
   773             break;
   774         case TYP:
   775             if (sym.isLocal()) {
   776                 mask = LocalClassFlags;
   777                 if (sym.name.isEmpty()) { // Anonymous class
   778                     // Anonymous classes in static methods are themselves static;
   779                     // that's why we admit STATIC here.
   780                     mask |= STATIC;
   781                     // JLS: Anonymous classes are final.
   782                     implicit |= FINAL;
   783                 }
   784                 if ((sym.owner.flags_field & STATIC) == 0 &&
   785                     (flags & ENUM) != 0)
   786                     log.error(pos, "enums.must.be.static");
   787             } else if (sym.owner.kind == TYP) {
   788                 mask = MemberClassFlags;
   789                 if (sym.owner.owner.kind == PCK ||
   790                     (sym.owner.flags_field & STATIC) != 0)
   791                     mask |= STATIC;
   792                 else if ((flags & ENUM) != 0)
   793                     log.error(pos, "enums.must.be.static");
   794                 // Nested interfaces and enums are always STATIC (Spec ???)
   795                 if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
   796             } else {
   797                 mask = ClassFlags;
   798             }
   799             // Interfaces are always ABSTRACT
   800             if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
   802             if ((flags & ENUM) != 0) {
   803                 // enums can't be declared abstract or final
   804                 mask &= ~(ABSTRACT | FINAL);
   805                 implicit |= implicitEnumFinalFlag(tree);
   806             }
   807             // Imply STRICTFP if owner has STRICTFP set.
   808             implicit |= sym.owner.flags_field & STRICTFP;
   809             break;
   810         default:
   811             throw new AssertionError();
   812         }
   813         long illegal = flags & StandardFlags & ~mask;
   814         if (illegal != 0) {
   815             if ((illegal & INTERFACE) != 0) {
   816                 log.error(pos, "intf.not.allowed.here");
   817                 mask |= INTERFACE;
   818             }
   819             else {
   820                 log.error(pos,
   821                           "mod.not.allowed.here", asFlagSet(illegal));
   822             }
   823         }
   824         else if ((sym.kind == TYP ||
   825                   // ISSUE: Disallowing abstract&private is no longer appropriate
   826                   // in the presence of inner classes. Should it be deleted here?
   827                   checkDisjoint(pos, flags,
   828                                 ABSTRACT,
   829                                 PRIVATE | STATIC))
   830                  &&
   831                  checkDisjoint(pos, flags,
   832                                ABSTRACT | INTERFACE,
   833                                FINAL | NATIVE | SYNCHRONIZED)
   834                  &&
   835                  checkDisjoint(pos, flags,
   836                                PUBLIC,
   837                                PRIVATE | PROTECTED)
   838                  &&
   839                  checkDisjoint(pos, flags,
   840                                PRIVATE,
   841                                PUBLIC | PROTECTED)
   842                  &&
   843                  checkDisjoint(pos, flags,
   844                                FINAL,
   845                                VOLATILE)
   846                  &&
   847                  (sym.kind == TYP ||
   848                   checkDisjoint(pos, flags,
   849                                 ABSTRACT | NATIVE,
   850                                 STRICTFP))) {
   851             // skip
   852         }
   853         return flags & (mask | ~StandardFlags) | implicit;
   854     }
   857     /** Determine if this enum should be implicitly final.
   858      *
   859      *  If the enum has no specialized enum contants, it is final.
   860      *
   861      *  If the enum does have specialized enum contants, it is
   862      *  <i>not</i> final.
   863      */
   864     private long implicitEnumFinalFlag(JCTree tree) {
   865         if (tree.getTag() != JCTree.CLASSDEF) return 0;
   866         class SpecialTreeVisitor extends JCTree.Visitor {
   867             boolean specialized;
   868             SpecialTreeVisitor() {
   869                 this.specialized = false;
   870             };
   872             @Override
   873             public void visitTree(JCTree tree) { /* no-op */ }
   875             @Override
   876             public void visitVarDef(JCVariableDecl tree) {
   877                 if ((tree.mods.flags & ENUM) != 0) {
   878                     if (tree.init instanceof JCNewClass &&
   879                         ((JCNewClass) tree.init).def != null) {
   880                         specialized = true;
   881                     }
   882                 }
   883             }
   884         }
   886         SpecialTreeVisitor sts = new SpecialTreeVisitor();
   887         JCClassDecl cdef = (JCClassDecl) tree;
   888         for (JCTree defs: cdef.defs) {
   889             defs.accept(sts);
   890             if (sts.specialized) return 0;
   891         }
   892         return FINAL;
   893     }
   895 /* *************************************************************************
   896  * Type Validation
   897  **************************************************************************/
   899     /** Validate a type expression. That is,
   900      *  check that all type arguments of a parametric type are within
   901      *  their bounds. This must be done in a second phase after type attributon
   902      *  since a class might have a subclass as type parameter bound. E.g:
   903      *
   904      *  class B<A extends C> { ... }
   905      *  class C extends B<C> { ... }
   906      *
   907      *  and we can't make sure that the bound is already attributed because
   908      *  of possible cycles.
   909      *
   910      * Visitor method: Validate a type expression, if it is not null, catching
   911      *  and reporting any completion failures.
   912      */
   913     void validate(JCTree tree, Env<AttrContext> env) {
   914         validate(tree, env, true);
   915     }
   916     void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
   917         new Validator(env).validateTree(tree, checkRaw, true);
   918     }
   920     /** Visitor method: Validate a list of type expressions.
   921      */
   922     void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
   923         for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
   924             validate(l.head, env);
   925     }
   927     /** A visitor class for type validation.
   928      */
   929     class Validator extends JCTree.Visitor {
   931         boolean isOuter;
   932         Env<AttrContext> env;
   934         Validator(Env<AttrContext> env) {
   935             this.env = env;
   936         }
   938         @Override
   939         public void visitTypeArray(JCArrayTypeTree tree) {
   940             tree.elemtype.accept(this);
   941         }
   943         @Override
   944         public void visitTypeApply(JCTypeApply tree) {
   945             if (tree.type.tag == CLASS) {
   946                 List<Type> formals = tree.type.tsym.type.allparams();
   947                 List<Type> actuals = tree.type.allparams();
   948                 List<JCExpression> args = tree.arguments;
   949                 List<Type> forms = tree.type.tsym.type.getTypeArguments();
   950                 ListBuffer<Type> tvars_buf = new ListBuffer<Type>();
   952                 boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
   954                 // For matching pairs of actual argument types `a' and
   955                 // formal type parameters with declared bound `b' ...
   956                 while (args.nonEmpty() && forms.nonEmpty()) {
   957                     validateTree(args.head,
   958                             !(isOuter && is_java_lang_Class),
   959                             false);
   961                     // exact type arguments needs to know their
   962                     // bounds (for upper and lower bound
   963                     // calculations).  So we create new TypeVars with
   964                     // bounds substed with actuals.
   965                     tvars_buf.append(types.substBound(((TypeVar)forms.head),
   966                                                       formals,
   967                                                       actuals));
   969                     args = args.tail;
   970                     forms = forms.tail;
   971                 }
   973                 args = tree.arguments;
   974                 List<Type> tvars_cap = types.substBounds(formals,
   975                                           formals,
   976                                           types.capture(tree.type).allparams());
   977                 while (args.nonEmpty() && tvars_cap.nonEmpty()) {
   978                     // Let the actual arguments know their bound
   979                     args.head.type.withTypeVar((TypeVar)tvars_cap.head);
   980                     args = args.tail;
   981                     tvars_cap = tvars_cap.tail;
   982                 }
   984                 args = tree.arguments;
   985                 List<Type> tvars = tvars_buf.toList();
   987                 while (args.nonEmpty() && tvars.nonEmpty()) {
   988                     Type actual = types.subst(args.head.type,
   989                         tree.type.tsym.type.getTypeArguments(),
   990                         tvars_buf.toList());
   991                     checkExtends(args.head.pos(),
   992                                  actual,
   993                                  (TypeVar)tvars.head);
   994                     args = args.tail;
   995                     tvars = tvars.tail;
   996                 }
   998                 checkCapture(tree);
  1000                 // Check that this type is either fully parameterized, or
  1001                 // not parameterized at all.
  1002                 if (tree.type.getEnclosingType().isRaw())
  1003                     log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
  1004                 if (tree.clazz.getTag() == JCTree.SELECT)
  1005                     visitSelectInternal((JCFieldAccess)tree.clazz);
  1009         @Override
  1010         public void visitTypeParameter(JCTypeParameter tree) {
  1011             validateTrees(tree.bounds, true, isOuter);
  1012             checkClassBounds(tree.pos(), tree.type);
  1015         @Override
  1016         public void visitWildcard(JCWildcard tree) {
  1017             if (tree.inner != null)
  1018                 validateTree(tree.inner, true, isOuter);
  1021         @Override
  1022         public void visitSelect(JCFieldAccess tree) {
  1023             if (tree.type.tag == CLASS) {
  1024                 visitSelectInternal(tree);
  1026                 // Check that this type is either fully parameterized, or
  1027                 // not parameterized at all.
  1028                 if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
  1029                     log.error(tree.pos(), "improperly.formed.type.param.missing");
  1032         public void visitSelectInternal(JCFieldAccess tree) {
  1033             if (tree.type.tsym.isStatic() &&
  1034                 tree.selected.type.isParameterized()) {
  1035                 // The enclosing type is not a class, so we are
  1036                 // looking at a static member type.  However, the
  1037                 // qualifying expression is parameterized.
  1038                 log.error(tree.pos(), "cant.select.static.class.from.param.type");
  1039             } else {
  1040                 // otherwise validate the rest of the expression
  1041                 tree.selected.accept(this);
  1045         @Override
  1046         public void visitAnnotatedType(JCAnnotatedType tree) {
  1047             tree.underlyingType.accept(this);
  1050         /** Default visitor method: do nothing.
  1051          */
  1052         @Override
  1053         public void visitTree(JCTree tree) {
  1056         public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
  1057             try {
  1058                 if (tree != null) {
  1059                     this.isOuter = isOuter;
  1060                     tree.accept(this);
  1061                     if (checkRaw)
  1062                         checkRaw(tree, env);
  1064             } catch (CompletionFailure ex) {
  1065                 completionError(tree.pos(), ex);
  1069         public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
  1070             for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
  1071                 validateTree(l.head, checkRaw, isOuter);
  1074         void checkRaw(JCTree tree, Env<AttrContext> env) {
  1075             if (lint.isEnabled(Lint.LintCategory.RAW) &&
  1076                 tree.type.tag == CLASS &&
  1077                 !TreeInfo.isDiamond(tree) &&
  1078                 !env.enclClass.name.isEmpty() &&  //anonymous or intersection
  1079                 tree.type.isRaw()) {
  1080                 log.warning(Lint.LintCategory.RAW,
  1081                         tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
  1086 /* *************************************************************************
  1087  * Exception checking
  1088  **************************************************************************/
  1090     /* The following methods treat classes as sets that contain
  1091      * the class itself and all their subclasses
  1092      */
  1094     /** Is given type a subtype of some of the types in given list?
  1095      */
  1096     boolean subset(Type t, List<Type> ts) {
  1097         for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
  1098             if (types.isSubtype(t, l.head)) return true;
  1099         return false;
  1102     /** Is given type a subtype or supertype of
  1103      *  some of the types in given list?
  1104      */
  1105     boolean intersects(Type t, List<Type> ts) {
  1106         for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
  1107             if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
  1108         return false;
  1111     /** Add type set to given type list, unless it is a subclass of some class
  1112      *  in the list.
  1113      */
  1114     List<Type> incl(Type t, List<Type> ts) {
  1115         return subset(t, ts) ? ts : excl(t, ts).prepend(t);
  1118     /** Remove type set from type set list.
  1119      */
  1120     List<Type> excl(Type t, List<Type> ts) {
  1121         if (ts.isEmpty()) {
  1122             return ts;
  1123         } else {
  1124             List<Type> ts1 = excl(t, ts.tail);
  1125             if (types.isSubtype(ts.head, t)) return ts1;
  1126             else if (ts1 == ts.tail) return ts;
  1127             else return ts1.prepend(ts.head);
  1131     /** Form the union of two type set lists.
  1132      */
  1133     List<Type> union(List<Type> ts1, List<Type> ts2) {
  1134         List<Type> ts = ts1;
  1135         for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
  1136             ts = incl(l.head, ts);
  1137         return ts;
  1140     /** Form the difference of two type lists.
  1141      */
  1142     List<Type> diff(List<Type> ts1, List<Type> ts2) {
  1143         List<Type> ts = ts1;
  1144         for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
  1145             ts = excl(l.head, ts);
  1146         return ts;
  1149     /** Form the intersection of two type lists.
  1150      */
  1151     public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
  1152         List<Type> ts = List.nil();
  1153         for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
  1154             if (subset(l.head, ts2)) ts = incl(l.head, ts);
  1155         for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
  1156             if (subset(l.head, ts1)) ts = incl(l.head, ts);
  1157         return ts;
  1160     /** Is exc an exception symbol that need not be declared?
  1161      */
  1162     boolean isUnchecked(ClassSymbol exc) {
  1163         return
  1164             exc.kind == ERR ||
  1165             exc.isSubClass(syms.errorType.tsym, types) ||
  1166             exc.isSubClass(syms.runtimeExceptionType.tsym, types);
  1169     /** Is exc an exception type that need not be declared?
  1170      */
  1171     boolean isUnchecked(Type exc) {
  1172         return
  1173             (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
  1174             (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
  1175             exc.tag == BOT;
  1178     /** Same, but handling completion failures.
  1179      */
  1180     boolean isUnchecked(DiagnosticPosition pos, Type exc) {
  1181         try {
  1182             return isUnchecked(exc);
  1183         } catch (CompletionFailure ex) {
  1184             completionError(pos, ex);
  1185             return true;
  1189     /** Is exc handled by given exception list?
  1190      */
  1191     boolean isHandled(Type exc, List<Type> handled) {
  1192         return isUnchecked(exc) || subset(exc, handled);
  1195     /** Return all exceptions in thrown list that are not in handled list.
  1196      *  @param thrown     The list of thrown exceptions.
  1197      *  @param handled    The list of handled exceptions.
  1198      */
  1199     List<Type> unhandled(List<Type> thrown, List<Type> handled) {
  1200         List<Type> unhandled = List.nil();
  1201         for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
  1202             if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
  1203         return unhandled;
  1206 /* *************************************************************************
  1207  * Overriding/Implementation checking
  1208  **************************************************************************/
  1210     /** The level of access protection given by a flag set,
  1211      *  where PRIVATE is highest and PUBLIC is lowest.
  1212      */
  1213     static int protection(long flags) {
  1214         switch ((short)(flags & AccessFlags)) {
  1215         case PRIVATE: return 3;
  1216         case PROTECTED: return 1;
  1217         default:
  1218         case PUBLIC: return 0;
  1219         case 0: return 2;
  1223     /** A customized "cannot override" error message.
  1224      *  @param m      The overriding method.
  1225      *  @param other  The overridden method.
  1226      *  @return       An internationalized string.
  1227      */
  1228     Object cannotOverride(MethodSymbol m, MethodSymbol other) {
  1229         String key;
  1230         if ((other.owner.flags() & INTERFACE) == 0)
  1231             key = "cant.override";
  1232         else if ((m.owner.flags() & INTERFACE) == 0)
  1233             key = "cant.implement";
  1234         else
  1235             key = "clashes.with";
  1236         return diags.fragment(key, m, m.location(), other, other.location());
  1239     /** A customized "override" warning message.
  1240      *  @param m      The overriding method.
  1241      *  @param other  The overridden method.
  1242      *  @return       An internationalized string.
  1243      */
  1244     Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
  1245         String key;
  1246         if ((other.owner.flags() & INTERFACE) == 0)
  1247             key = "unchecked.override";
  1248         else if ((m.owner.flags() & INTERFACE) == 0)
  1249             key = "unchecked.implement";
  1250         else
  1251             key = "unchecked.clash.with";
  1252         return diags.fragment(key, m, m.location(), other, other.location());
  1255     /** A customized "override" warning message.
  1256      *  @param m      The overriding method.
  1257      *  @param other  The overridden method.
  1258      *  @return       An internationalized string.
  1259      */
  1260     Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
  1261         String key;
  1262         if ((other.owner.flags() & INTERFACE) == 0)
  1263             key = "varargs.override";
  1264         else  if ((m.owner.flags() & INTERFACE) == 0)
  1265             key = "varargs.implement";
  1266         else
  1267             key = "varargs.clash.with";
  1268         return diags.fragment(key, m, m.location(), other, other.location());
  1271     /** Check that this method conforms with overridden method 'other'.
  1272      *  where `origin' is the class where checking started.
  1273      *  Complications:
  1274      *  (1) Do not check overriding of synthetic methods
  1275      *      (reason: they might be final).
  1276      *      todo: check whether this is still necessary.
  1277      *  (2) Admit the case where an interface proxy throws fewer exceptions
  1278      *      than the method it implements. Augment the proxy methods with the
  1279      *      undeclared exceptions in this case.
  1280      *  (3) When generics are enabled, admit the case where an interface proxy
  1281      *      has a result type
  1282      *      extended by the result type of the method it implements.
  1283      *      Change the proxies result type to the smaller type in this case.
  1285      *  @param tree         The tree from which positions
  1286      *                      are extracted for errors.
  1287      *  @param m            The overriding method.
  1288      *  @param other        The overridden method.
  1289      *  @param origin       The class of which the overriding method
  1290      *                      is a member.
  1291      */
  1292     void checkOverride(JCTree tree,
  1293                        MethodSymbol m,
  1294                        MethodSymbol other,
  1295                        ClassSymbol origin) {
  1296         // Don't check overriding of synthetic methods or by bridge methods.
  1297         if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
  1298             return;
  1301         // Error if static method overrides instance method (JLS 8.4.6.2).
  1302         if ((m.flags() & STATIC) != 0 &&
  1303                    (other.flags() & STATIC) == 0) {
  1304             log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
  1305                       cannotOverride(m, other));
  1306             return;
  1309         // Error if instance method overrides static or final
  1310         // method (JLS 8.4.6.1).
  1311         if ((other.flags() & FINAL) != 0 ||
  1312                  (m.flags() & STATIC) == 0 &&
  1313                  (other.flags() & STATIC) != 0) {
  1314             log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
  1315                       cannotOverride(m, other),
  1316                       asFlagSet(other.flags() & (FINAL | STATIC)));
  1317             return;
  1320         if ((m.owner.flags() & ANNOTATION) != 0) {
  1321             // handled in validateAnnotationMethod
  1322             return;
  1325         // Error if overriding method has weaker access (JLS 8.4.6.3).
  1326         if ((origin.flags() & INTERFACE) == 0 &&
  1327                  protection(m.flags()) > protection(other.flags())) {
  1328             log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
  1329                       cannotOverride(m, other),
  1330                       other.flags() == 0 ?
  1331                           Flag.PACKAGE :
  1332                           asFlagSet(other.flags() & AccessFlags));
  1333             return;
  1336         Type mt = types.memberType(origin.type, m);
  1337         Type ot = types.memberType(origin.type, other);
  1338         // Error if overriding result type is different
  1339         // (or, in the case of generics mode, not a subtype) of
  1340         // overridden result type. We have to rename any type parameters
  1341         // before comparing types.
  1342         List<Type> mtvars = mt.getTypeArguments();
  1343         List<Type> otvars = ot.getTypeArguments();
  1344         Type mtres = mt.getReturnType();
  1345         Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
  1347         overrideWarner.warned = false;
  1348         boolean resultTypesOK =
  1349             types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
  1350         if (!resultTypesOK) {
  1351             if (!allowCovariantReturns &&
  1352                 m.owner != origin &&
  1353                 m.owner.isSubClass(other.owner, types)) {
  1354                 // allow limited interoperability with covariant returns
  1355             } else {
  1356                 log.error(TreeInfo.diagnosticPositionFor(m, tree),
  1357                           "override.incompatible.ret",
  1358                           cannotOverride(m, other),
  1359                           mtres, otres);
  1360                 return;
  1362         } else if (overrideWarner.warned) {
  1363             warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
  1364                     "override.unchecked.ret",
  1365                     uncheckedOverrides(m, other),
  1366                     mtres, otres);
  1369         // Error if overriding method throws an exception not reported
  1370         // by overridden method.
  1371         List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
  1372         List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
  1373         List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
  1374         if (unhandledErased.nonEmpty()) {
  1375             log.error(TreeInfo.diagnosticPositionFor(m, tree),
  1376                       "override.meth.doesnt.throw",
  1377                       cannotOverride(m, other),
  1378                       unhandledUnerased.head);
  1379             return;
  1381         else if (unhandledUnerased.nonEmpty()) {
  1382             warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
  1383                           "override.unchecked.thrown",
  1384                          cannotOverride(m, other),
  1385                          unhandledUnerased.head);
  1386             return;
  1389         // Optional warning if varargs don't agree
  1390         if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
  1391             && lint.isEnabled(Lint.LintCategory.OVERRIDES)) {
  1392             log.warning(TreeInfo.diagnosticPositionFor(m, tree),
  1393                         ((m.flags() & Flags.VARARGS) != 0)
  1394                         ? "override.varargs.missing"
  1395                         : "override.varargs.extra",
  1396                         varargsOverrides(m, other));
  1399         // Warn if instance method overrides bridge method (compiler spec ??)
  1400         if ((other.flags() & BRIDGE) != 0) {
  1401             log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
  1402                         uncheckedOverrides(m, other));
  1405         // Warn if a deprecated method overridden by a non-deprecated one.
  1406         if ((other.flags() & DEPRECATED) != 0
  1407             && (m.flags() & DEPRECATED) == 0
  1408             && m.outermostClass() != other.outermostClass()
  1409             && !isDeprecatedOverrideIgnorable(other, origin)) {
  1410             warnDeprecated(TreeInfo.diagnosticPositionFor(m, tree), other);
  1413     // where
  1414         private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
  1415             // If the method, m, is defined in an interface, then ignore the issue if the method
  1416             // is only inherited via a supertype and also implemented in the supertype,
  1417             // because in that case, we will rediscover the issue when examining the method
  1418             // in the supertype.
  1419             // If the method, m, is not defined in an interface, then the only time we need to
  1420             // address the issue is when the method is the supertype implemementation: any other
  1421             // case, we will have dealt with when examining the supertype classes
  1422             ClassSymbol mc = m.enclClass();
  1423             Type st = types.supertype(origin.type);
  1424             if (st.tag != CLASS)
  1425                 return true;
  1426             MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
  1428             if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
  1429                 List<Type> intfs = types.interfaces(origin.type);
  1430                 return (intfs.contains(mc.type) ? false : (stimpl != null));
  1432             else
  1433                 return (stimpl != m);
  1437     // used to check if there were any unchecked conversions
  1438     Warner overrideWarner = new Warner();
  1440     /** Check that a class does not inherit two concrete methods
  1441      *  with the same signature.
  1442      *  @param pos          Position to be used for error reporting.
  1443      *  @param site         The class type to be checked.
  1444      */
  1445     public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
  1446         Type sup = types.supertype(site);
  1447         if (sup.tag != CLASS) return;
  1449         for (Type t1 = sup;
  1450              t1.tsym.type.isParameterized();
  1451              t1 = types.supertype(t1)) {
  1452             for (Scope.Entry e1 = t1.tsym.members().elems;
  1453                  e1 != null;
  1454                  e1 = e1.sibling) {
  1455                 Symbol s1 = e1.sym;
  1456                 if (s1.kind != MTH ||
  1457                     (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
  1458                     !s1.isInheritedIn(site.tsym, types) ||
  1459                     ((MethodSymbol)s1).implementation(site.tsym,
  1460                                                       types,
  1461                                                       true) != s1)
  1462                     continue;
  1463                 Type st1 = types.memberType(t1, s1);
  1464                 int s1ArgsLength = st1.getParameterTypes().length();
  1465                 if (st1 == s1.type) continue;
  1467                 for (Type t2 = sup;
  1468                      t2.tag == CLASS;
  1469                      t2 = types.supertype(t2)) {
  1470                     for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
  1471                          e2.scope != null;
  1472                          e2 = e2.next()) {
  1473                         Symbol s2 = e2.sym;
  1474                         if (s2 == s1 ||
  1475                             s2.kind != MTH ||
  1476                             (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
  1477                             s2.type.getParameterTypes().length() != s1ArgsLength ||
  1478                             !s2.isInheritedIn(site.tsym, types) ||
  1479                             ((MethodSymbol)s2).implementation(site.tsym,
  1480                                                               types,
  1481                                                               true) != s2)
  1482                             continue;
  1483                         Type st2 = types.memberType(t2, s2);
  1484                         if (types.overrideEquivalent(st1, st2))
  1485                             log.error(pos, "concrete.inheritance.conflict",
  1486                                       s1, t1, s2, t2, sup);
  1493     /** Check that classes (or interfaces) do not each define an abstract
  1494      *  method with same name and arguments but incompatible return types.
  1495      *  @param pos          Position to be used for error reporting.
  1496      *  @param t1           The first argument type.
  1497      *  @param t2           The second argument type.
  1498      */
  1499     public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
  1500                                             Type t1,
  1501                                             Type t2) {
  1502         return checkCompatibleAbstracts(pos, t1, t2,
  1503                                         types.makeCompoundType(t1, t2));
  1506     public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
  1507                                             Type t1,
  1508                                             Type t2,
  1509                                             Type site) {
  1510         Symbol sym = firstIncompatibility(t1, t2, site);
  1511         if (sym != null) {
  1512             log.error(pos, "types.incompatible.diff.ret",
  1513                       t1, t2, sym.name +
  1514                       "(" + types.memberType(t2, sym).getParameterTypes() + ")");
  1515             return false;
  1517         return true;
  1520     /** Return the first method which is defined with same args
  1521      *  but different return types in two given interfaces, or null if none
  1522      *  exists.
  1523      *  @param t1     The first type.
  1524      *  @param t2     The second type.
  1525      *  @param site   The most derived type.
  1526      *  @returns symbol from t2 that conflicts with one in t1.
  1527      */
  1528     private Symbol firstIncompatibility(Type t1, Type t2, Type site) {
  1529         Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
  1530         closure(t1, interfaces1);
  1531         Map<TypeSymbol,Type> interfaces2;
  1532         if (t1 == t2)
  1533             interfaces2 = interfaces1;
  1534         else
  1535             closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
  1537         for (Type t3 : interfaces1.values()) {
  1538             for (Type t4 : interfaces2.values()) {
  1539                 Symbol s = firstDirectIncompatibility(t3, t4, site);
  1540                 if (s != null) return s;
  1543         return null;
  1546     /** Compute all the supertypes of t, indexed by type symbol. */
  1547     private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
  1548         if (t.tag != CLASS) return;
  1549         if (typeMap.put(t.tsym, t) == null) {
  1550             closure(types.supertype(t), typeMap);
  1551             for (Type i : types.interfaces(t))
  1552                 closure(i, typeMap);
  1556     /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
  1557     private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
  1558         if (t.tag != CLASS) return;
  1559         if (typesSkip.get(t.tsym) != null) return;
  1560         if (typeMap.put(t.tsym, t) == null) {
  1561             closure(types.supertype(t), typesSkip, typeMap);
  1562             for (Type i : types.interfaces(t))
  1563                 closure(i, typesSkip, typeMap);
  1567     /** Return the first method in t2 that conflicts with a method from t1. */
  1568     private Symbol firstDirectIncompatibility(Type t1, Type t2, Type site) {
  1569         for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
  1570             Symbol s1 = e1.sym;
  1571             Type st1 = null;
  1572             if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
  1573             Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
  1574             if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
  1575             for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
  1576                 Symbol s2 = e2.sym;
  1577                 if (s1 == s2) continue;
  1578                 if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
  1579                 if (st1 == null) st1 = types.memberType(t1, s1);
  1580                 Type st2 = types.memberType(t2, s2);
  1581                 if (types.overrideEquivalent(st1, st2)) {
  1582                     List<Type> tvars1 = st1.getTypeArguments();
  1583                     List<Type> tvars2 = st2.getTypeArguments();
  1584                     Type rt1 = st1.getReturnType();
  1585                     Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
  1586                     boolean compat =
  1587                         types.isSameType(rt1, rt2) ||
  1588                         rt1.tag >= CLASS && rt2.tag >= CLASS &&
  1589                         (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
  1590                          types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
  1591                          checkCommonOverriderIn(s1,s2,site);
  1592                     if (!compat) return s2;
  1596         return null;
  1598     //WHERE
  1599     boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
  1600         Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
  1601         Type st1 = types.memberType(site, s1);
  1602         Type st2 = types.memberType(site, s2);
  1603         closure(site, supertypes);
  1604         for (Type t : supertypes.values()) {
  1605             for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
  1606                 Symbol s3 = e.sym;
  1607                 if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
  1608                 Type st3 = types.memberType(site,s3);
  1609                 if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
  1610                     if (s3.owner == site.tsym) {
  1611                         return true;
  1613                     List<Type> tvars1 = st1.getTypeArguments();
  1614                     List<Type> tvars2 = st2.getTypeArguments();
  1615                     List<Type> tvars3 = st3.getTypeArguments();
  1616                     Type rt1 = st1.getReturnType();
  1617                     Type rt2 = st2.getReturnType();
  1618                     Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
  1619                     Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
  1620                     boolean compat =
  1621                         rt13.tag >= CLASS && rt23.tag >= CLASS &&
  1622                         (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
  1623                          types.covariantReturnType(rt23, rt2, Warner.noWarnings));
  1624                     if (compat)
  1625                         return true;
  1629         return false;
  1632     /** Check that a given method conforms with any method it overrides.
  1633      *  @param tree         The tree from which positions are extracted
  1634      *                      for errors.
  1635      *  @param m            The overriding method.
  1636      */
  1637     void checkOverride(JCTree tree, MethodSymbol m) {
  1638         ClassSymbol origin = (ClassSymbol)m.owner;
  1639         if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
  1640             if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
  1641                 log.error(tree.pos(), "enum.no.finalize");
  1642                 return;
  1644         for (Type t = types.supertype(origin.type); t.tag == CLASS;
  1645              t = types.supertype(t)) {
  1646             TypeSymbol c = t.tsym;
  1647             Scope.Entry e = c.members().lookup(m.name);
  1648             while (e.scope != null) {
  1649                 if (m.overrides(e.sym, origin, types, false))
  1650                     checkOverride(tree, m, (MethodSymbol)e.sym, origin);
  1651                 else if (e.sym.kind == MTH &&
  1652                         e.sym.isInheritedIn(origin, types) &&
  1653                         (e.sym.flags() & SYNTHETIC) == 0 &&
  1654                         !m.isConstructor()) {
  1655                     Type er1 = m.erasure(types);
  1656                     Type er2 = e.sym.erasure(types);
  1657                     if (types.isSameTypes(er1.getParameterTypes(),
  1658                             er2.getParameterTypes())) {
  1659                             log.error(TreeInfo.diagnosticPositionFor(m, tree),
  1660                                     "name.clash.same.erasure.no.override",
  1661                                     m, m.location(),
  1662                                     e.sym, e.sym.location());
  1665                 e = e.next();
  1670     /** Check that all abstract members of given class have definitions.
  1671      *  @param pos          Position to be used for error reporting.
  1672      *  @param c            The class.
  1673      */
  1674     void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
  1675         try {
  1676             MethodSymbol undef = firstUndef(c, c);
  1677             if (undef != null) {
  1678                 if ((c.flags() & ENUM) != 0 &&
  1679                     types.supertype(c.type).tsym == syms.enumSym &&
  1680                     (c.flags() & FINAL) == 0) {
  1681                     // add the ABSTRACT flag to an enum
  1682                     c.flags_field |= ABSTRACT;
  1683                 } else {
  1684                     MethodSymbol undef1 =
  1685                         new MethodSymbol(undef.flags(), undef.name,
  1686                                          types.memberType(c.type, undef), undef.owner);
  1687                     log.error(pos, "does.not.override.abstract",
  1688                               c, undef1, undef1.location());
  1691         } catch (CompletionFailure ex) {
  1692             completionError(pos, ex);
  1695 //where
  1696         /** Return first abstract member of class `c' that is not defined
  1697          *  in `impl', null if there is none.
  1698          */
  1699         private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
  1700             MethodSymbol undef = null;
  1701             // Do not bother to search in classes that are not abstract,
  1702             // since they cannot have abstract members.
  1703             if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
  1704                 Scope s = c.members();
  1705                 for (Scope.Entry e = s.elems;
  1706                      undef == null && e != null;
  1707                      e = e.sibling) {
  1708                     if (e.sym.kind == MTH &&
  1709                         (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
  1710                         MethodSymbol absmeth = (MethodSymbol)e.sym;
  1711                         MethodSymbol implmeth = absmeth.implementation(impl, types, true);
  1712                         if (implmeth == null || implmeth == absmeth)
  1713                             undef = absmeth;
  1716                 if (undef == null) {
  1717                     Type st = types.supertype(c.type);
  1718                     if (st.tag == CLASS)
  1719                         undef = firstUndef(impl, (ClassSymbol)st.tsym);
  1721                 for (List<Type> l = types.interfaces(c.type);
  1722                      undef == null && l.nonEmpty();
  1723                      l = l.tail) {
  1724                     undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
  1727             return undef;
  1730     /** Check for cyclic references. Issue an error if the
  1731      *  symbol of the type referred to has a LOCKED flag set.
  1733      *  @param pos      Position to be used for error reporting.
  1734      *  @param t        The type referred to.
  1735      */
  1736     void checkNonCyclic(DiagnosticPosition pos, Type t) {
  1737         checkNonCyclicInternal(pos, t);
  1741     void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
  1742         checkNonCyclic1(pos, t, List.<TypeVar>nil());
  1745     private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
  1746         final TypeVar tv;
  1747         if  (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
  1748             return;
  1749         if (seen.contains(t)) {
  1750             tv = (TypeVar)t;
  1751             tv.bound = types.createErrorType(t);
  1752             log.error(pos, "cyclic.inheritance", t);
  1753         } else if (t.tag == TYPEVAR) {
  1754             tv = (TypeVar)t;
  1755             seen = seen.prepend(tv);
  1756             for (Type b : types.getBounds(tv))
  1757                 checkNonCyclic1(pos, b, seen);
  1761     /** Check for cyclic references. Issue an error if the
  1762      *  symbol of the type referred to has a LOCKED flag set.
  1764      *  @param pos      Position to be used for error reporting.
  1765      *  @param t        The type referred to.
  1766      *  @returns        True if the check completed on all attributed classes
  1767      */
  1768     private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
  1769         boolean complete = true; // was the check complete?
  1770         //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
  1771         Symbol c = t.tsym;
  1772         if ((c.flags_field & ACYCLIC) != 0) return true;
  1774         if ((c.flags_field & LOCKED) != 0) {
  1775             noteCyclic(pos, (ClassSymbol)c);
  1776         } else if (!c.type.isErroneous()) {
  1777             try {
  1778                 c.flags_field |= LOCKED;
  1779                 if (c.type.tag == CLASS) {
  1780                     ClassType clazz = (ClassType)c.type;
  1781                     if (clazz.interfaces_field != null)
  1782                         for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
  1783                             complete &= checkNonCyclicInternal(pos, l.head);
  1784                     if (clazz.supertype_field != null) {
  1785                         Type st = clazz.supertype_field;
  1786                         if (st != null && st.tag == CLASS)
  1787                             complete &= checkNonCyclicInternal(pos, st);
  1789                     if (c.owner.kind == TYP)
  1790                         complete &= checkNonCyclicInternal(pos, c.owner.type);
  1792             } finally {
  1793                 c.flags_field &= ~LOCKED;
  1796         if (complete)
  1797             complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
  1798         if (complete) c.flags_field |= ACYCLIC;
  1799         return complete;
  1802     /** Note that we found an inheritance cycle. */
  1803     private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
  1804         log.error(pos, "cyclic.inheritance", c);
  1805         for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
  1806             l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
  1807         Type st = types.supertype(c.type);
  1808         if (st.tag == CLASS)
  1809             ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
  1810         c.type = types.createErrorType(c, c.type);
  1811         c.flags_field |= ACYCLIC;
  1814     /** Check that all methods which implement some
  1815      *  method conform to the method they implement.
  1816      *  @param tree         The class definition whose members are checked.
  1817      */
  1818     void checkImplementations(JCClassDecl tree) {
  1819         checkImplementations(tree, tree.sym);
  1821 //where
  1822         /** Check that all methods which implement some
  1823          *  method in `ic' conform to the method they implement.
  1824          */
  1825         void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
  1826             ClassSymbol origin = tree.sym;
  1827             for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
  1828                 ClassSymbol lc = (ClassSymbol)l.head.tsym;
  1829                 if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
  1830                     for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
  1831                         if (e.sym.kind == MTH &&
  1832                             (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
  1833                             MethodSymbol absmeth = (MethodSymbol)e.sym;
  1834                             MethodSymbol implmeth = absmeth.implementation(origin, types, false);
  1835                             if (implmeth != null && implmeth != absmeth &&
  1836                                 (implmeth.owner.flags() & INTERFACE) ==
  1837                                 (origin.flags() & INTERFACE)) {
  1838                                 // don't check if implmeth is in a class, yet
  1839                                 // origin is an interface. This case arises only
  1840                                 // if implmeth is declared in Object. The reason is
  1841                                 // that interfaces really don't inherit from
  1842                                 // Object it's just that the compiler represents
  1843                                 // things that way.
  1844                                 checkOverride(tree, implmeth, absmeth, origin);
  1852     /** Check that all abstract methods implemented by a class are
  1853      *  mutually compatible.
  1854      *  @param pos          Position to be used for error reporting.
  1855      *  @param c            The class whose interfaces are checked.
  1856      */
  1857     void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
  1858         List<Type> supertypes = types.interfaces(c);
  1859         Type supertype = types.supertype(c);
  1860         if (supertype.tag == CLASS &&
  1861             (supertype.tsym.flags() & ABSTRACT) != 0)
  1862             supertypes = supertypes.prepend(supertype);
  1863         for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
  1864             if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
  1865                 !checkCompatibleAbstracts(pos, l.head, l.head, c))
  1866                 return;
  1867             for (List<Type> m = supertypes; m != l; m = m.tail)
  1868                 if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
  1869                     return;
  1871         checkCompatibleConcretes(pos, c);
  1874     void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
  1875         for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
  1876             for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
  1877                 // VM allows methods and variables with differing types
  1878                 if (sym.kind == e.sym.kind &&
  1879                     types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
  1880                     sym != e.sym &&
  1881                     (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
  1882                     (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
  1883                     (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
  1884                     syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
  1885                     return;
  1891     /** Report a conflict between a user symbol and a synthetic symbol.
  1892      */
  1893     private void syntheticError(DiagnosticPosition pos, Symbol sym) {
  1894         if (!sym.type.isErroneous()) {
  1895             if (warnOnSyntheticConflicts) {
  1896                 log.warning(pos, "synthetic.name.conflict", sym, sym.location());
  1898             else {
  1899                 log.error(pos, "synthetic.name.conflict", sym, sym.location());
  1904     /** Check that class c does not implement directly or indirectly
  1905      *  the same parameterized interface with two different argument lists.
  1906      *  @param pos          Position to be used for error reporting.
  1907      *  @param type         The type whose interfaces are checked.
  1908      */
  1909     void checkClassBounds(DiagnosticPosition pos, Type type) {
  1910         checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
  1912 //where
  1913         /** Enter all interfaces of type `type' into the hash table `seensofar'
  1914          *  with their class symbol as key and their type as value. Make
  1915          *  sure no class is entered with two different types.
  1916          */
  1917         void checkClassBounds(DiagnosticPosition pos,
  1918                               Map<TypeSymbol,Type> seensofar,
  1919                               Type type) {
  1920             if (type.isErroneous()) return;
  1921             for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
  1922                 Type it = l.head;
  1923                 Type oldit = seensofar.put(it.tsym, it);
  1924                 if (oldit != null) {
  1925                     List<Type> oldparams = oldit.allparams();
  1926                     List<Type> newparams = it.allparams();
  1927                     if (!types.containsTypeEquivalent(oldparams, newparams))
  1928                         log.error(pos, "cant.inherit.diff.arg",
  1929                                   it.tsym, Type.toString(oldparams),
  1930                                   Type.toString(newparams));
  1932                 checkClassBounds(pos, seensofar, it);
  1934             Type st = types.supertype(type);
  1935             if (st != null) checkClassBounds(pos, seensofar, st);
  1938     /** Enter interface into into set.
  1939      *  If it existed already, issue a "repeated interface" error.
  1940      */
  1941     void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
  1942         if (its.contains(it))
  1943             log.error(pos, "repeated.interface");
  1944         else {
  1945             its.add(it);
  1949 /* *************************************************************************
  1950  * Check annotations
  1951  **************************************************************************/
  1953     /**
  1954      * Recursively validate annotations values
  1955      */
  1956     void validateAnnotationTree(JCTree tree) {
  1957         class AnnotationValidator extends TreeScanner {
  1958             @Override
  1959             public void visitAnnotation(JCAnnotation tree) {
  1960                 super.visitAnnotation(tree);
  1961                 validateAnnotation(tree);
  1964         tree.accept(new AnnotationValidator());
  1967     /** Annotation types are restricted to primitives, String, an
  1968      *  enum, an annotation, Class, Class<?>, Class<? extends
  1969      *  Anything>, arrays of the preceding.
  1970      */
  1971     void validateAnnotationType(JCTree restype) {
  1972         // restype may be null if an error occurred, so don't bother validating it
  1973         if (restype != null) {
  1974             validateAnnotationType(restype.pos(), restype.type);
  1978     void validateAnnotationType(DiagnosticPosition pos, Type type) {
  1979         if (type.isPrimitive()) return;
  1980         if (types.isSameType(type, syms.stringType)) return;
  1981         if ((type.tsym.flags() & Flags.ENUM) != 0) return;
  1982         if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
  1983         if (types.lowerBound(type).tsym == syms.classType.tsym) return;
  1984         if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
  1985             validateAnnotationType(pos, types.elemtype(type));
  1986             return;
  1988         log.error(pos, "invalid.annotation.member.type");
  1991     /**
  1992      * "It is also a compile-time error if any method declared in an
  1993      * annotation type has a signature that is override-equivalent to
  1994      * that of any public or protected method declared in class Object
  1995      * or in the interface annotation.Annotation."
  1997      * @jls3 9.6 Annotation Types
  1998      */
  1999     void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
  2000         for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
  2001             Scope s = sup.tsym.members();
  2002             for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
  2003                 if (e.sym.kind == MTH &&
  2004                     (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
  2005                     types.overrideEquivalent(m.type, e.sym.type))
  2006                     log.error(pos, "intf.annotation.member.clash", e.sym, sup);
  2011     /** Check the annotations of a symbol.
  2012      */
  2013     public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
  2014         if (skipAnnotations) return;
  2015         for (JCAnnotation a : annotations)
  2016             validateAnnotation(a, s);
  2019     /** Check the type annotations
  2020      */
  2021     public void validateTypeAnnotations(List<JCTypeAnnotation> annotations, boolean isTypeParameter) {
  2022         if (skipAnnotations) return;
  2023         for (JCTypeAnnotation a : annotations)
  2024             validateTypeAnnotation(a, isTypeParameter);
  2027     /** Check an annotation of a symbol.
  2028      */
  2029     public void validateAnnotation(JCAnnotation a, Symbol s) {
  2030         validateAnnotationTree(a);
  2032         if (!annotationApplicable(a, s))
  2033             log.error(a.pos(), "annotation.type.not.applicable");
  2035         if (a.annotationType.type.tsym == syms.overrideType.tsym) {
  2036             if (!isOverrider(s))
  2037                 log.error(a.pos(), "method.does.not.override.superclass");
  2041     public void validateTypeAnnotation(JCTypeAnnotation a, boolean isTypeParameter) {
  2042         if (a.type == null)
  2043             throw new AssertionError("annotation tree hasn't been attributed yet: " + a);
  2044         validateAnnotationTree(a);
  2046         if (!isTypeAnnotation(a, isTypeParameter))
  2047             log.error(a.pos(), "annotation.type.not.applicable");
  2050     /** Is s a method symbol that overrides a method in a superclass? */
  2051     boolean isOverrider(Symbol s) {
  2052         if (s.kind != MTH || s.isStatic())
  2053             return false;
  2054         MethodSymbol m = (MethodSymbol)s;
  2055         TypeSymbol owner = (TypeSymbol)m.owner;
  2056         for (Type sup : types.closure(owner.type)) {
  2057             if (sup == owner.type)
  2058                 continue; // skip "this"
  2059             Scope scope = sup.tsym.members();
  2060             for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
  2061                 if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
  2062                     return true;
  2065         return false;
  2068     /** Is the annotation applicable to type annotations */
  2069     boolean isTypeAnnotation(JCTypeAnnotation a, boolean isTypeParameter) {
  2070         Attribute.Compound atTarget =
  2071             a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
  2072         if (atTarget == null) return true;
  2073         Attribute atValue = atTarget.member(names.value);
  2074         if (!(atValue instanceof Attribute.Array)) return true; // error recovery
  2075         Attribute.Array arr = (Attribute.Array) atValue;
  2076         for (Attribute app : arr.values) {
  2077             if (!(app instanceof Attribute.Enum)) return true; // recovery
  2078             Attribute.Enum e = (Attribute.Enum) app;
  2079             if (!isTypeParameter && e.value.name == names.TYPE_USE)
  2080                 return true;
  2081             else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER)
  2082                 return true;
  2084         return false;
  2087     /** Is the annotation applicable to the symbol? */
  2088     boolean annotationApplicable(JCAnnotation a, Symbol s) {
  2089         Attribute.Compound atTarget =
  2090             a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
  2091         if (atTarget == null) return true;
  2092         Attribute atValue = atTarget.member(names.value);
  2093         if (!(atValue instanceof Attribute.Array)) return true; // error recovery
  2094         Attribute.Array arr = (Attribute.Array) atValue;
  2095         for (Attribute app : arr.values) {
  2096             if (!(app instanceof Attribute.Enum)) return true; // recovery
  2097             Attribute.Enum e = (Attribute.Enum) app;
  2098             if (e.value.name == names.TYPE)
  2099                 { if (s.kind == TYP) return true; }
  2100             else if (e.value.name == names.FIELD)
  2101                 { if (s.kind == VAR && s.owner.kind != MTH) return true; }
  2102             else if (e.value.name == names.METHOD)
  2103                 { if (s.kind == MTH && !s.isConstructor()) return true; }
  2104             else if (e.value.name == names.PARAMETER)
  2105                 { if (s.kind == VAR &&
  2106                       s.owner.kind == MTH &&
  2107                       (s.flags() & PARAMETER) != 0)
  2108                     return true;
  2110             else if (e.value.name == names.CONSTRUCTOR)
  2111                 { if (s.kind == MTH && s.isConstructor()) return true; }
  2112             else if (e.value.name == names.LOCAL_VARIABLE)
  2113                 { if (s.kind == VAR && s.owner.kind == MTH &&
  2114                       (s.flags() & PARAMETER) == 0)
  2115                     return true;
  2117             else if (e.value.name == names.ANNOTATION_TYPE)
  2118                 { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
  2119                     return true;
  2121             else if (e.value.name == names.PACKAGE)
  2122                 { if (s.kind == PCK) return true; }
  2123             else if (e.value.name == names.TYPE_USE)
  2124                 { if (s.kind == TYP ||
  2125                       s.kind == VAR ||
  2126                       (s.kind == MTH && !s.isConstructor() &&
  2127                        s.type.getReturnType().tag != VOID))
  2128                     return true;
  2130             else
  2131                 return true; // recovery
  2133         return false;
  2136     /** Check an annotation value.
  2137      */
  2138     public void validateAnnotation(JCAnnotation a) {
  2139         if (a.type.isErroneous()) return;
  2141         // collect an inventory of the members (sorted alphabetically)
  2142         Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
  2143             public int compare(Symbol t, Symbol t1) {
  2144                 return t.name.compareTo(t1.name);
  2146         });
  2147         for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
  2148              e != null;
  2149              e = e.sibling)
  2150             if (e.sym.kind == MTH)
  2151                 members.add((MethodSymbol) e.sym);
  2153         // count them off as they're annotated
  2154         for (JCTree arg : a.args) {
  2155             if (arg.getTag() != JCTree.ASSIGN) continue; // recovery
  2156             JCAssign assign = (JCAssign) arg;
  2157             Symbol m = TreeInfo.symbol(assign.lhs);
  2158             if (m == null || m.type.isErroneous()) continue;
  2159             if (!members.remove(m))
  2160                 log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
  2161                           m.name, a.type);
  2164         // all the remaining ones better have default values
  2165         ListBuffer<Name> missingDefaults = ListBuffer.lb();
  2166         for (MethodSymbol m : members) {
  2167             if (m.defaultValue == null && !m.type.isErroneous()) {
  2168                 missingDefaults.append(m.name);
  2171         if (missingDefaults.nonEmpty()) {
  2172             String key = (missingDefaults.size() > 1)
  2173                     ? "annotation.missing.default.value.1"
  2174                     : "annotation.missing.default.value";
  2175             log.error(a.pos(), key, a.type, missingDefaults);
  2178         // special case: java.lang.annotation.Target must not have
  2179         // repeated values in its value member
  2180         if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
  2181             a.args.tail == null)
  2182             return;
  2184         if (a.args.head.getTag() != JCTree.ASSIGN) return; // error recovery
  2185         JCAssign assign = (JCAssign) a.args.head;
  2186         Symbol m = TreeInfo.symbol(assign.lhs);
  2187         if (m.name != names.value) return;
  2188         JCTree rhs = assign.rhs;
  2189         if (rhs.getTag() != JCTree.NEWARRAY) return;
  2190         JCNewArray na = (JCNewArray) rhs;
  2191         Set<Symbol> targets = new HashSet<Symbol>();
  2192         for (JCTree elem : na.elems) {
  2193             if (!targets.add(TreeInfo.symbol(elem))) {
  2194                 log.error(elem.pos(), "repeated.annotation.target");
  2199     void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
  2200         if (allowAnnotations &&
  2201             lint.isEnabled(Lint.LintCategory.DEP_ANN) &&
  2202             (s.flags() & DEPRECATED) != 0 &&
  2203             !syms.deprecatedType.isErroneous() &&
  2204             s.attribute(syms.deprecatedType.tsym) == null) {
  2205             log.warning(Lint.LintCategory.DEP_ANN,
  2206                     pos, "missing.deprecated.annotation");
  2210 /* *************************************************************************
  2211  * Check for recursive annotation elements.
  2212  **************************************************************************/
  2214     /** Check for cycles in the graph of annotation elements.
  2215      */
  2216     void checkNonCyclicElements(JCClassDecl tree) {
  2217         if ((tree.sym.flags_field & ANNOTATION) == 0) return;
  2218         assert (tree.sym.flags_field & LOCKED) == 0;
  2219         try {
  2220             tree.sym.flags_field |= LOCKED;
  2221             for (JCTree def : tree.defs) {
  2222                 if (def.getTag() != JCTree.METHODDEF) continue;
  2223                 JCMethodDecl meth = (JCMethodDecl)def;
  2224                 checkAnnotationResType(meth.pos(), meth.restype.type);
  2226         } finally {
  2227             tree.sym.flags_field &= ~LOCKED;
  2228             tree.sym.flags_field |= ACYCLIC_ANN;
  2232     void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
  2233         if ((tsym.flags_field & ACYCLIC_ANN) != 0)
  2234             return;
  2235         if ((tsym.flags_field & LOCKED) != 0) {
  2236             log.error(pos, "cyclic.annotation.element");
  2237             return;
  2239         try {
  2240             tsym.flags_field |= LOCKED;
  2241             for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
  2242                 Symbol s = e.sym;
  2243                 if (s.kind != Kinds.MTH)
  2244                     continue;
  2245                 checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
  2247         } finally {
  2248             tsym.flags_field &= ~LOCKED;
  2249             tsym.flags_field |= ACYCLIC_ANN;
  2253     void checkAnnotationResType(DiagnosticPosition pos, Type type) {
  2254         switch (type.tag) {
  2255         case TypeTags.CLASS:
  2256             if ((type.tsym.flags() & ANNOTATION) != 0)
  2257                 checkNonCyclicElementsInternal(pos, type.tsym);
  2258             break;
  2259         case TypeTags.ARRAY:
  2260             checkAnnotationResType(pos, types.elemtype(type));
  2261             break;
  2262         default:
  2263             break; // int etc
  2267 /* *************************************************************************
  2268  * Check for cycles in the constructor call graph.
  2269  **************************************************************************/
  2271     /** Check for cycles in the graph of constructors calling other
  2272      *  constructors.
  2273      */
  2274     void checkCyclicConstructors(JCClassDecl tree) {
  2275         Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
  2277         // enter each constructor this-call into the map
  2278         for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
  2279             JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
  2280             if (app == null) continue;
  2281             JCMethodDecl meth = (JCMethodDecl) l.head;
  2282             if (TreeInfo.name(app.meth) == names._this) {
  2283                 callMap.put(meth.sym, TreeInfo.symbol(app.meth));
  2284             } else {
  2285                 meth.sym.flags_field |= ACYCLIC;
  2289         // Check for cycles in the map
  2290         Symbol[] ctors = new Symbol[0];
  2291         ctors = callMap.keySet().toArray(ctors);
  2292         for (Symbol caller : ctors) {
  2293             checkCyclicConstructor(tree, caller, callMap);
  2297     /** Look in the map to see if the given constructor is part of a
  2298      *  call cycle.
  2299      */
  2300     private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
  2301                                         Map<Symbol,Symbol> callMap) {
  2302         if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
  2303             if ((ctor.flags_field & LOCKED) != 0) {
  2304                 log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
  2305                           "recursive.ctor.invocation");
  2306             } else {
  2307                 ctor.flags_field |= LOCKED;
  2308                 checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
  2309                 ctor.flags_field &= ~LOCKED;
  2311             ctor.flags_field |= ACYCLIC;
  2315 /* *************************************************************************
  2316  * Miscellaneous
  2317  **************************************************************************/
  2319     /**
  2320      * Return the opcode of the operator but emit an error if it is an
  2321      * error.
  2322      * @param pos        position for error reporting.
  2323      * @param operator   an operator
  2324      * @param tag        a tree tag
  2325      * @param left       type of left hand side
  2326      * @param right      type of right hand side
  2327      */
  2328     int checkOperator(DiagnosticPosition pos,
  2329                        OperatorSymbol operator,
  2330                        int tag,
  2331                        Type left,
  2332                        Type right) {
  2333         if (operator.opcode == ByteCodes.error) {
  2334             log.error(pos,
  2335                       "operator.cant.be.applied",
  2336                       treeinfo.operatorName(tag),
  2337                       List.of(left, right));
  2339         return operator.opcode;
  2343     /**
  2344      *  Check for division by integer constant zero
  2345      *  @param pos           Position for error reporting.
  2346      *  @param operator      The operator for the expression
  2347      *  @param operand       The right hand operand for the expression
  2348      */
  2349     void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
  2350         if (operand.constValue() != null
  2351             && lint.isEnabled(Lint.LintCategory.DIVZERO)
  2352             && operand.tag <= LONG
  2353             && ((Number) (operand.constValue())).longValue() == 0) {
  2354             int opc = ((OperatorSymbol)operator).opcode;
  2355             if (opc == ByteCodes.idiv || opc == ByteCodes.imod
  2356                 || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
  2357                 log.warning(Lint.LintCategory.DIVZERO, pos, "div.zero");
  2362     /**
  2363      * Check for empty statements after if
  2364      */
  2365     void checkEmptyIf(JCIf tree) {
  2366         if (tree.thenpart.getTag() == JCTree.SKIP && tree.elsepart == null && lint.isEnabled(Lint.LintCategory.EMPTY))
  2367             log.warning(Lint.LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
  2370     /** Check that symbol is unique in given scope.
  2371      *  @param pos           Position for error reporting.
  2372      *  @param sym           The symbol.
  2373      *  @param s             The scope.
  2374      */
  2375     boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
  2376         if (sym.type.isErroneous())
  2377             return true;
  2378         if (sym.owner.name == names.any) return false;
  2379         for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
  2380             if (sym != e.sym &&
  2381                 sym.kind == e.sym.kind &&
  2382                 sym.name != names.error &&
  2383                 (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
  2384                 if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS))
  2385                     varargsDuplicateError(pos, sym, e.sym);
  2386                 else if (sym.kind == MTH && !types.overrideEquivalent(sym.type, e.sym.type))
  2387                     duplicateErasureError(pos, sym, e.sym);
  2388                 else
  2389                     duplicateError(pos, e.sym);
  2390                 return false;
  2393         return true;
  2395     //where
  2396     /** Report duplicate declaration error.
  2397      */
  2398     void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
  2399         if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
  2400             log.error(pos, "name.clash.same.erasure", sym1, sym2);
  2404     /** Check that single-type import is not already imported or top-level defined,
  2405      *  but make an exception for two single-type imports which denote the same type.
  2406      *  @param pos           Position for error reporting.
  2407      *  @param sym           The symbol.
  2408      *  @param s             The scope
  2409      */
  2410     boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
  2411         return checkUniqueImport(pos, sym, s, false);
  2414     /** Check that static single-type import is not already imported or top-level defined,
  2415      *  but make an exception for two single-type imports which denote the same type.
  2416      *  @param pos           Position for error reporting.
  2417      *  @param sym           The symbol.
  2418      *  @param s             The scope
  2419      *  @param staticImport  Whether or not this was a static import
  2420      */
  2421     boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
  2422         return checkUniqueImport(pos, sym, s, true);
  2425     /** Check that single-type import is not already imported or top-level defined,
  2426      *  but make an exception for two single-type imports which denote the same type.
  2427      *  @param pos           Position for error reporting.
  2428      *  @param sym           The symbol.
  2429      *  @param s             The scope.
  2430      *  @param staticImport  Whether or not this was a static import
  2431      */
  2432     private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
  2433         for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
  2434             // is encountered class entered via a class declaration?
  2435             boolean isClassDecl = e.scope == s;
  2436             if ((isClassDecl || sym != e.sym) &&
  2437                 sym.kind == e.sym.kind &&
  2438                 sym.name != names.error) {
  2439                 if (!e.sym.type.isErroneous()) {
  2440                     String what = e.sym.toString();
  2441                     if (!isClassDecl) {
  2442                         if (staticImport)
  2443                             log.error(pos, "already.defined.static.single.import", what);
  2444                         else
  2445                             log.error(pos, "already.defined.single.import", what);
  2447                     else if (sym != e.sym)
  2448                         log.error(pos, "already.defined.this.unit", what);
  2450                 return false;
  2453         return true;
  2456     /** Check that a qualified name is in canonical form (for import decls).
  2457      */
  2458     public void checkCanonical(JCTree tree) {
  2459         if (!isCanonical(tree))
  2460             log.error(tree.pos(), "import.requires.canonical",
  2461                       TreeInfo.symbol(tree));
  2463         // where
  2464         private boolean isCanonical(JCTree tree) {
  2465             while (tree.getTag() == JCTree.SELECT) {
  2466                 JCFieldAccess s = (JCFieldAccess) tree;
  2467                 if (s.sym.owner != TreeInfo.symbol(s.selected))
  2468                     return false;
  2469                 tree = s.selected;
  2471             return true;
  2474     private class ConversionWarner extends Warner {
  2475         final String key;
  2476         final Type found;
  2477         final Type expected;
  2478         public ConversionWarner(DiagnosticPosition pos, String key, Type found, Type expected) {
  2479             super(pos);
  2480             this.key = key;
  2481             this.found = found;
  2482             this.expected = expected;
  2485         @Override
  2486         public void warnUnchecked() {
  2487             boolean warned = this.warned;
  2488             super.warnUnchecked();
  2489             if (warned) return; // suppress redundant diagnostics
  2490             Object problem = diags.fragment(key);
  2491             Check.this.warnUnchecked(pos(), "prob.found.req", problem, found, expected);
  2495     public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
  2496         return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
  2499     public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
  2500         return new ConversionWarner(pos, "unchecked.assign", found, expected);

mercurial