src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java

Mon, 26 Jul 2010 14:25:56 -0700

author
jjg
date
Mon, 26 Jul 2010 14:25:56 -0700
changeset 612
d1bd93028447
parent 581
f2fdd52e4e87
child 689
77cc34d5e548
permissions
-rw-r--r--

6957438: improve code for generating warning messages containing option names
Reviewed-by: mcimadamore

mcimadamore@83 1 /*
ohair@554 2 * Copyright (c) 2005, 2009, Oracle and/or its affiliates. All rights reserved.
mcimadamore@83 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
mcimadamore@83 4 *
mcimadamore@83 5 * This code is free software; you can redistribute it and/or modify it
mcimadamore@83 6 * under the terms of the GNU General Public License version 2 only, as
ohair@554 7 * published by the Free Software Foundation. Oracle designates this
mcimadamore@83 8 * particular file as subject to the "Classpath" exception as provided
ohair@554 9 * by Oracle in the LICENSE file that accompanied this code.
mcimadamore@83 10 *
mcimadamore@83 11 * This code is distributed in the hope that it will be useful, but WITHOUT
mcimadamore@83 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
mcimadamore@83 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
mcimadamore@83 14 * version 2 for more details (a copy is included in the LICENSE file that
mcimadamore@83 15 * accompanied this code).
mcimadamore@83 16 *
mcimadamore@83 17 * You should have received a copy of the GNU General Public License version
mcimadamore@83 18 * 2 along with this work; if not, write to the Free Software Foundation,
mcimadamore@83 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
mcimadamore@83 20 *
ohair@554 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ohair@554 22 * or visit www.oracle.com if you need additional information or have any
ohair@554 23 * questions.
mcimadamore@83 24 */
mcimadamore@83 25
mcimadamore@83 26 package com.sun.tools.javac.util;
mcimadamore@83 27
mcimadamore@221 28 import java.util.Collection;
mcimadamore@221 29 import java.util.EnumSet;
mcimadamore@83 30 import java.util.HashMap;
mcimadamore@83 31 import java.util.Locale;
mcimadamore@83 32 import java.util.Map;
mcimadamore@221 33 import java.util.regex.Matcher;
mcimadamore@83 34 import javax.tools.JavaFileObject;
mcimadamore@83 35
mcimadamore@221 36 import com.sun.tools.javac.util.AbstractDiagnosticFormatter.SimpleConfiguration;
mcimadamore@221 37 import com.sun.tools.javac.util.BasicDiagnosticFormatter.BasicConfiguration;
mcimadamore@221 38
mcimadamore@83 39 import static com.sun.tools.javac.api.DiagnosticFormatter.PositionKind.*;
mcimadamore@221 40 import static com.sun.tools.javac.util.BasicDiagnosticFormatter.BasicConfiguration.*;
mcimadamore@221 41 import static com.sun.tools.javac.util.LayoutCharacters.*;
mcimadamore@83 42
mcimadamore@83 43 /**
mcimadamore@83 44 * A basic formatter for diagnostic messages.
mcimadamore@83 45 * The basic formatter will format a diagnostic according to one of three format patterns, depending on whether
mcimadamore@83 46 * or not the source name and position are set. The formatter supports a printf-like string for patterns
mcimadamore@83 47 * with the following special characters:
mcimadamore@83 48 * <ul>
mcimadamore@83 49 * <li>%b: the base of the source name
mcimadamore@83 50 * <li>%f: the source name (full absolute path)
mcimadamore@83 51 * <li>%l: the line number of the diagnostic, derived from the character offset
mcimadamore@83 52 * <li>%c: the column number of the diagnostic, derived from the character offset
mcimadamore@83 53 * <li>%o: the character offset of the diagnostic if set
mcimadamore@83 54 * <li>%p: the prefix for the diagnostic, derived from the diagnostic type
mcimadamore@83 55 * <li>%t: the prefix as it normally appears in standard diagnostics. In this case, no prefix is
mcimadamore@83 56 * shown if the type is ERROR and if a source name is set
mcimadamore@83 57 * <li>%m: the text or the diagnostic, including any appropriate arguments
mcimadamore@83 58 * <li>%_: space delimiter, useful for formatting purposes
mcimadamore@83 59 * </ul>
jjg@333 60 *
jjg@581 61 * <p><b>This is NOT part of any supported API.
jjg@333 62 * If you write code that depends on this, you do so at your own risk.
jjg@333 63 * This code and its internal interfaces are subject to change or
jjg@333 64 * deletion without notice.</b>
mcimadamore@83 65 */
mcimadamore@83 66 public class BasicDiagnosticFormatter extends AbstractDiagnosticFormatter {
mcimadamore@83 67
mcimadamore@221 68 protected int currentIndentation = 0;
mcimadamore@83 69
mcimadamore@83 70 /**
mcimadamore@83 71 * Create a basic formatter based on the supplied options.
mcimadamore@83 72 *
mcimadamore@83 73 * @param opts list of command-line options
mcimadamore@136 74 * @param msgs JavacMessages object used for i18n
mcimadamore@83 75 */
mcimadamore@221 76 public BasicDiagnosticFormatter(Options options, JavacMessages msgs) {
mcimadamore@221 77 super(msgs, new BasicConfiguration(options));
mcimadamore@83 78 }
mcimadamore@83 79
mcimadamore@83 80 /**
mcimadamore@83 81 * Create a standard basic formatter
mcimadamore@83 82 *
mcimadamore@136 83 * @param msgs JavacMessages object used for i18n
mcimadamore@83 84 */
mcimadamore@136 85 public BasicDiagnosticFormatter(JavacMessages msgs) {
mcimadamore@221 86 super(msgs, new BasicConfiguration());
mcimadamore@83 87 }
mcimadamore@83 88
mcimadamore@238 89 public String formatDiagnostic(JCDiagnostic d, Locale l) {
mcimadamore@136 90 if (l == null)
mcimadamore@136 91 l = messages.getCurrentLocale();
mcimadamore@83 92 String format = selectFormat(d);
mcimadamore@83 93 StringBuilder buf = new StringBuilder();
mcimadamore@83 94 for (int i = 0; i < format.length(); i++) {
mcimadamore@83 95 char c = format.charAt(i);
mcimadamore@83 96 boolean meta = false;
mcimadamore@83 97 if (c == '%' && i < format.length() - 1) {
mcimadamore@83 98 meta = true;
mcimadamore@83 99 c = format.charAt(++i);
mcimadamore@83 100 }
mcimadamore@83 101 buf.append(meta ? formatMeta(c, d, l) : String.valueOf(c));
mcimadamore@83 102 }
mcimadamore@221 103 if (depth == 0)
mcimadamore@221 104 return addSourceLineIfNeeded(d, buf.toString());
mcimadamore@221 105 else
mcimadamore@221 106 return buf.toString();
mcimadamore@221 107 }
mcimadamore@221 108
mcimadamore@221 109 public String formatMessage(JCDiagnostic d, Locale l) {
mcimadamore@221 110 int prevIndentation = currentIndentation;
mcimadamore@221 111 try {
mcimadamore@221 112 StringBuilder buf = new StringBuilder();
mcimadamore@221 113 Collection<String> args = formatArguments(d, l);
mcimadamore@221 114 String msg = localize(l, d.getCode(), args.toArray());
mcimadamore@221 115 String[] lines = msg.split("\n");
mcimadamore@221 116 if (getConfiguration().getVisible().contains(DiagnosticPart.SUMMARY)) {
mcimadamore@221 117 currentIndentation += getConfiguration().getIndentation(DiagnosticPart.SUMMARY);
mcimadamore@221 118 buf.append(indent(lines[0], currentIndentation)); //summary
mcimadamore@221 119 }
mcimadamore@221 120 if (lines.length > 1 && getConfiguration().getVisible().contains(DiagnosticPart.DETAILS)) {
mcimadamore@221 121 currentIndentation += getConfiguration().getIndentation(DiagnosticPart.DETAILS);
mcimadamore@221 122 for (int i = 1;i < lines.length; i++) {
mcimadamore@221 123 buf.append("\n" + indent(lines[i], currentIndentation));
mcimadamore@221 124 }
mcimadamore@221 125 }
mcimadamore@221 126 if (d.isMultiline() && getConfiguration().getVisible().contains(DiagnosticPart.SUBDIAGNOSTICS)) {
mcimadamore@221 127 currentIndentation += getConfiguration().getIndentation(DiagnosticPart.SUBDIAGNOSTICS);
mcimadamore@221 128 for (String sub : formatSubdiagnostics(d, l)) {
mcimadamore@221 129 buf.append("\n" + sub);
mcimadamore@221 130 }
mcimadamore@221 131 }
mcimadamore@221 132 return buf.toString();
mcimadamore@137 133 }
mcimadamore@221 134 finally {
mcimadamore@221 135 currentIndentation = prevIndentation;
mcimadamore@221 136 }
mcimadamore@221 137 }
mcimadamore@221 138
mcimadamore@221 139 protected String addSourceLineIfNeeded(JCDiagnostic d, String msg) {
mcimadamore@221 140 if (!displaySource(d))
mcimadamore@221 141 return msg;
mcimadamore@221 142 else {
mcimadamore@221 143 BasicConfiguration conf = getConfiguration();
mcimadamore@221 144 int indentSource = conf.getIndentation(DiagnosticPart.SOURCE);
mcimadamore@221 145 String sourceLine = "\n" + formatSourceLine(d, indentSource);
mcimadamore@221 146 boolean singleLine = msg.indexOf("\n") == -1;
mcimadamore@221 147 if (singleLine || getConfiguration().getSourcePosition() == SourcePosition.BOTTOM)
mcimadamore@221 148 return msg + sourceLine;
mcimadamore@221 149 else
mcimadamore@221 150 return msg.replaceFirst("\n", Matcher.quoteReplacement(sourceLine) + "\n");
mcimadamore@221 151 }
mcimadamore@83 152 }
mcimadamore@83 153
mcimadamore@83 154 protected String formatMeta(char c, JCDiagnostic d, Locale l) {
mcimadamore@83 155 switch (c) {
mcimadamore@83 156 case 'b':
mcimadamore@100 157 return formatSource(d, false, l);
mcimadamore@83 158 case 'e':
mcimadamore@83 159 return formatPosition(d, END, l);
mcimadamore@83 160 case 'f':
mcimadamore@100 161 return formatSource(d, true, l);
mcimadamore@83 162 case 'l':
mcimadamore@83 163 return formatPosition(d, LINE, l);
mcimadamore@83 164 case 'c':
mcimadamore@83 165 return formatPosition(d, COLUMN, l);
mcimadamore@83 166 case 'o':
mcimadamore@83 167 return formatPosition(d, OFFSET, l);
mcimadamore@83 168 case 'p':
mcimadamore@83 169 return formatKind(d, l);
mcimadamore@83 170 case 's':
mcimadamore@83 171 return formatPosition(d, START, l);
mcimadamore@83 172 case 't': {
mcimadamore@83 173 boolean usePrefix;
mcimadamore@83 174 switch (d.getType()) {
mcimadamore@83 175 case FRAGMENT:
mcimadamore@83 176 usePrefix = false;
mcimadamore@83 177 break;
mcimadamore@83 178 case ERROR:
mcimadamore@83 179 usePrefix = (d.getIntPosition() == Position.NOPOS);
mcimadamore@83 180 break;
mcimadamore@83 181 default:
mcimadamore@83 182 usePrefix = true;
mcimadamore@83 183 }
mcimadamore@83 184 if (usePrefix)
mcimadamore@83 185 return formatKind(d, l);
mcimadamore@83 186 else
mcimadamore@83 187 return "";
mcimadamore@83 188 }
mcimadamore@83 189 case 'm':
mcimadamore@83 190 return formatMessage(d, l);
jjg@612 191 case 'L':
jjg@612 192 return formatLintCategory(d, l);
mcimadamore@83 193 case '_':
mcimadamore@83 194 return " ";
mcimadamore@83 195 case '%':
mcimadamore@83 196 return "%";
mcimadamore@83 197 default:
mcimadamore@83 198 return String.valueOf(c);
mcimadamore@83 199 }
mcimadamore@83 200 }
mcimadamore@83 201
mcimadamore@83 202 private String selectFormat(JCDiagnostic d) {
mcimadamore@83 203 DiagnosticSource source = d.getDiagnosticSource();
mcimadamore@221 204 String format = getConfiguration().getFormat(BasicFormatKind.DEFAULT_NO_POS_FORMAT);
jjg@519 205 if (source != null && source != DiagnosticSource.NO_SOURCE) {
mcimadamore@83 206 if (d.getIntPosition() != Position.NOPOS) {
mcimadamore@221 207 format = getConfiguration().getFormat(BasicFormatKind.DEFAULT_POS_FORMAT);
mcimadamore@83 208 } else if (source.getFile() != null &&
mcimadamore@83 209 source.getFile().getKind() == JavaFileObject.Kind.CLASS) {
mcimadamore@221 210 format = getConfiguration().getFormat(BasicFormatKind.DEFAULT_CLASS_FORMAT);
mcimadamore@83 211 }
mcimadamore@83 212 }
mcimadamore@83 213 return format;
mcimadamore@83 214 }
mcimadamore@83 215
mcimadamore@221 216 @Override
mcimadamore@221 217 public BasicConfiguration getConfiguration() {
mcimadamore@288 218 //the following cast is always safe - see init
mcimadamore@221 219 return (BasicConfiguration)super.getConfiguration();
mcimadamore@221 220 }
mcimadamore@221 221
mcimadamore@221 222 static public class BasicConfiguration extends SimpleConfiguration {
mcimadamore@221 223
mcimadamore@221 224 protected Map<DiagnosticPart, Integer> indentationLevels;
mcimadamore@221 225 protected Map<BasicFormatKind, String> availableFormats;
mcimadamore@221 226 protected SourcePosition sourcePosition;
mcimadamore@221 227
mcimadamore@221 228 @SuppressWarnings("fallthrough")
mcimadamore@221 229 public BasicConfiguration(Options options) {
mcimadamore@221 230 super(options, EnumSet.of(DiagnosticPart.SUMMARY,
mcimadamore@221 231 DiagnosticPart.DETAILS,
mcimadamore@221 232 DiagnosticPart.SUBDIAGNOSTICS,
mcimadamore@221 233 DiagnosticPart.SOURCE));
mcimadamore@221 234 initFormat();
mcimadamore@221 235 initIndentation();
mcimadamore@221 236 String fmt = options.get("diagsFormat");
mcimadamore@221 237 if (fmt != null) {
mcimadamore@221 238 String[] formats = fmt.split("\\|");
mcimadamore@221 239 switch (formats.length) {
mcimadamore@221 240 case 3:
mcimadamore@221 241 setFormat(BasicFormatKind.DEFAULT_CLASS_FORMAT, formats[2]);
mcimadamore@221 242 case 2:
mcimadamore@221 243 setFormat(BasicFormatKind.DEFAULT_NO_POS_FORMAT, formats[1]);
mcimadamore@221 244 default:
mcimadamore@221 245 setFormat(BasicFormatKind.DEFAULT_POS_FORMAT, formats[0]);
mcimadamore@221 246 }
mcimadamore@221 247 }
jjg@612 248 String srcPos = null;
jjg@612 249 if ((((srcPos = options.get("sourcePosition")) != null)) &&
jjg@612 250 srcPos.equals("bottom"))
mcimadamore@221 251 setSourcePosition(SourcePosition.BOTTOM);
mcimadamore@221 252 else
mcimadamore@221 253 setSourcePosition(SourcePosition.AFTER_SUMMARY);
mcimadamore@221 254 String indent = options.get("diagsIndentation");
mcimadamore@221 255 if (indent != null) {
mcimadamore@221 256 String[] levels = indent.split("\\|");
mcimadamore@221 257 try {
mcimadamore@221 258 switch (levels.length) {
mcimadamore@221 259 case 5:
mcimadamore@221 260 setIndentation(DiagnosticPart.JLS,
mcimadamore@221 261 Integer.parseInt(levels[4]));
mcimadamore@221 262 case 4:
mcimadamore@221 263 setIndentation(DiagnosticPart.SUBDIAGNOSTICS,
mcimadamore@221 264 Integer.parseInt(levels[3]));
mcimadamore@221 265 case 3:
mcimadamore@221 266 setIndentation(DiagnosticPart.SOURCE,
mcimadamore@221 267 Integer.parseInt(levels[2]));
mcimadamore@221 268 case 2:
mcimadamore@221 269 setIndentation(DiagnosticPart.DETAILS,
mcimadamore@221 270 Integer.parseInt(levels[1]));
mcimadamore@221 271 default:
mcimadamore@221 272 setIndentation(DiagnosticPart.SUMMARY,
mcimadamore@221 273 Integer.parseInt(levels[0]));
mcimadamore@221 274 }
mcimadamore@221 275 }
mcimadamore@221 276 catch (NumberFormatException ex) {
mcimadamore@221 277 initIndentation();
mcimadamore@221 278 }
mcimadamore@221 279 }
mcimadamore@221 280 }
mcimadamore@221 281
mcimadamore@221 282 public BasicConfiguration() {
mcimadamore@221 283 super(EnumSet.of(DiagnosticPart.SUMMARY,
mcimadamore@221 284 DiagnosticPart.DETAILS,
mcimadamore@221 285 DiagnosticPart.SUBDIAGNOSTICS,
mcimadamore@221 286 DiagnosticPart.SOURCE));
mcimadamore@221 287 initFormat();
mcimadamore@221 288 initIndentation();
mcimadamore@221 289 }
mcimadamore@221 290 //where
mcimadamore@221 291 private void initFormat() {
mcimadamore@221 292 availableFormats = new HashMap<BasicFormatKind, String>();
jjg@612 293 setFormat(BasicFormatKind.DEFAULT_POS_FORMAT, "%f:%l:%_%t%L%m");
jjg@612 294 setFormat(BasicFormatKind.DEFAULT_NO_POS_FORMAT, "%p%L%m");
jjg@612 295 setFormat(BasicFormatKind.DEFAULT_CLASS_FORMAT, "%f:%_%t%L%m");
mcimadamore@221 296 }
mcimadamore@221 297 //where
mcimadamore@221 298 private void initIndentation() {
mcimadamore@221 299 indentationLevels = new HashMap<DiagnosticPart, Integer>();
mcimadamore@221 300 setIndentation(DiagnosticPart.SUMMARY, 0);
mcimadamore@221 301 setIndentation(DiagnosticPart.DETAILS, DetailsInc);
mcimadamore@221 302 setIndentation(DiagnosticPart.SUBDIAGNOSTICS, DiagInc);
mcimadamore@221 303 setIndentation(DiagnosticPart.SOURCE, 0);
mcimadamore@221 304 }
mcimadamore@221 305
mcimadamore@83 306 /**
mcimadamore@221 307 * Get the amount of spaces for a given indentation kind
mcimadamore@221 308 * @param diagPart the diagnostic part for which the indentation is
mcimadamore@221 309 * to be retrieved
mcimadamore@221 310 * @return the amount of spaces used for the specified indentation kind
mcimadamore@221 311 */
mcimadamore@221 312 public int getIndentation(DiagnosticPart diagPart) {
mcimadamore@221 313 return indentationLevels.get(diagPart);
mcimadamore@221 314 }
mcimadamore@221 315
mcimadamore@83 316 /**
mcimadamore@221 317 * Set the indentation level for various element of a given diagnostic -
mcimadamore@221 318 * this might lead to more readable diagnostics
mcimadamore@221 319 *
mcimadamore@221 320 * @param indentationKind kind of indentation to be set
mcimadamore@221 321 * @param nSpaces amount of spaces for the specified diagnostic part
mcimadamore@221 322 */
mcimadamore@221 323 public void setIndentation(DiagnosticPart diagPart, int nSpaces) {
mcimadamore@221 324 indentationLevels.put(diagPart, nSpaces);
mcimadamore@221 325 }
mcimadamore@221 326
mcimadamore@83 327 /**
mcimadamore@221 328 * Set the source line positioning used by this formatter
mcimadamore@221 329 *
mcimadamore@221 330 * @param sourcePos a positioning value for source line
mcimadamore@221 331 */
mcimadamore@221 332 public void setSourcePosition(SourcePosition sourcePos) {
mcimadamore@221 333 sourcePosition = sourcePos;
mcimadamore@221 334 }
mcimadamore@221 335
mcimadamore@221 336 /**
mcimadamore@221 337 * Get the source line positioning used by this formatter
mcimadamore@221 338 *
mcimadamore@221 339 * @return the positioning value used by this formatter
mcimadamore@221 340 */
mcimadamore@221 341 public SourcePosition getSourcePosition() {
mcimadamore@221 342 return sourcePosition;
mcimadamore@221 343 }
mcimadamore@221 344 //where
mcimadamore@221 345 /**
mcimadamore@221 346 * A source positioning value controls the position (within a given
mcimadamore@221 347 * diagnostic message) in which the source line the diagnostic refers to
mcimadamore@221 348 * should be displayed (if applicable)
mcimadamore@221 349 */
mcimadamore@221 350 public enum SourcePosition {
mcimadamore@221 351 /**
mcimadamore@221 352 * Source line is displayed after the diagnostic message
mcimadamore@221 353 */
mcimadamore@221 354 BOTTOM,
mcimadamore@221 355 /**
mcimadamore@221 356 * Source line is displayed after the first line of the diagnostic
mcimadamore@221 357 * message
mcimadamore@221 358 */
mcimadamore@221 359 AFTER_SUMMARY;
mcimadamore@221 360 }
mcimadamore@221 361
mcimadamore@221 362 /**
mcimadamore@221 363 * Set a metachar string for a specific format
mcimadamore@221 364 *
mcimadamore@221 365 * @param kind the format kind to be set
mcimadamore@221 366 * @param s the metachar string specifying the format
mcimadamore@221 367 */
mcimadamore@221 368 public void setFormat(BasicFormatKind kind, String s) {
mcimadamore@221 369 availableFormats.put(kind, s);
mcimadamore@221 370 }
mcimadamore@221 371
mcimadamore@221 372 /**
mcimadamore@221 373 * Get a metachar string for a specific format
mcimadamore@221 374 *
mcimadamore@221 375 * @param sourcePos a positioning value for source line
mcimadamore@221 376 */
mcimadamore@221 377 public String getFormat(BasicFormatKind kind) {
mcimadamore@221 378 return availableFormats.get(kind);
mcimadamore@221 379 }
mcimadamore@221 380 //where
mcimadamore@221 381 /**
mcimadamore@221 382 * This enum contains all the kinds of formatting patterns supported
mcimadamore@221 383 * by a basic diagnostic formatter.
mcimadamore@221 384 */
mcimadamore@221 385 public enum BasicFormatKind {
mcimadamore@221 386 /**
mcimadamore@221 387 * A format string to be used for diagnostics with a given position.
mcimadamore@221 388 */
mcimadamore@221 389 DEFAULT_POS_FORMAT,
mcimadamore@221 390 /**
mcimadamore@221 391 * A format string to be used for diagnostics without a given position.
mcimadamore@221 392 */
mcimadamore@221 393 DEFAULT_NO_POS_FORMAT,
mcimadamore@221 394 /**
mcimadamore@221 395 * A format string to be used for diagnostics regarding classfiles
mcimadamore@221 396 */
mcimadamore@221 397 DEFAULT_CLASS_FORMAT;
mcimadamore@221 398 }
mcimadamore@83 399 }
mcimadamore@83 400 }

mercurial