test/tools/javac/flow/LVTHarness.java

Sat, 14 Sep 2013 19:04:47 +0100

author
vromero
date
Sat, 14 Sep 2013 19:04:47 +0100
changeset 2027
4932bb04c4b8
child 2046
1fe358ea75ff
permissions
-rw-r--r--

7047734: javac, the LVT is not generated correctly in several scenarios
Reviewed-by: jjg, mcimadamore

vromero@2027 1 /*
vromero@2027 2 * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
vromero@2027 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
vromero@2027 4 *
vromero@2027 5 * This code is free software; you can redistribute it and/or modify it
vromero@2027 6 * under the terms of the GNU General Public License version 2 only, as
vromero@2027 7 * published by the Free Software Foundation.
vromero@2027 8 *
vromero@2027 9 * This code is distributed in the hope that it will be useful, but WITHOUT
vromero@2027 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
vromero@2027 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
vromero@2027 12 * version 2 for more details (a copy is included in the LICENSE file that
vromero@2027 13 * accompanied this code).
vromero@2027 14 *
vromero@2027 15 * You should have received a copy of the GNU General Public License version
vromero@2027 16 * 2 along with this work; if not, write to the Free Software Foundation,
vromero@2027 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
vromero@2027 18 *
vromero@2027 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
vromero@2027 20 * or visit www.oracle.com if you need additional information or have any
vromero@2027 21 * questions.
vromero@2027 22 */
vromero@2027 23
vromero@2027 24 /*
vromero@2027 25 * @test
vromero@2027 26 * @bug 7047734
vromero@2027 27 * @summary The LVT is not generated correctly during some try/catch scenarios
vromero@2027 28 * @library /tools/javac/lib
vromero@2027 29 * @build JavacTestingAbstractProcessor LVTHarness
vromero@2027 30 * @run main LVTHarness
vromero@2027 31 */
vromero@2027 32
vromero@2027 33 import java.io.File;
vromero@2027 34 import java.io.IOException;
vromero@2027 35 import java.lang.annotation.Annotation;
vromero@2027 36 import java.util.Set;
vromero@2027 37 import java.util.Arrays;
vromero@2027 38 import java.util.ArrayList;
vromero@2027 39 import java.util.Collections;
vromero@2027 40 import java.util.HashMap;
vromero@2027 41 import java.util.HashSet;
vromero@2027 42 import java.util.List;
vromero@2027 43 import java.util.Map;
vromero@2027 44
vromero@2027 45 import javax.annotation.processing.RoundEnvironment;
vromero@2027 46 import javax.lang.model.element.Element;
vromero@2027 47 import javax.lang.model.element.TypeElement;
vromero@2027 48 import javax.tools.JavaCompiler;
vromero@2027 49 import javax.tools.JavaFileObject;
vromero@2027 50 import javax.tools.StandardJavaFileManager;
vromero@2027 51 import javax.tools.ToolProvider;
vromero@2027 52
vromero@2027 53 import com.sun.source.util.JavacTask;
vromero@2027 54 import com.sun.tools.classfile.Attribute;
vromero@2027 55 import com.sun.tools.classfile.ClassFile;
vromero@2027 56 import com.sun.tools.classfile.ConstantPool;
vromero@2027 57 import com.sun.tools.classfile.ConstantPoolException;
vromero@2027 58 import com.sun.tools.classfile.Code_attribute;
vromero@2027 59 import com.sun.tools.classfile.ConstantPool.InvalidIndex;
vromero@2027 60 import com.sun.tools.classfile.ConstantPool.UnexpectedEntry;
vromero@2027 61 import com.sun.tools.classfile.Descriptor.InvalidDescriptor;
vromero@2027 62 import com.sun.tools.classfile.LocalVariableTable_attribute;
vromero@2027 63 import com.sun.tools.classfile.Method;
vromero@2027 64
vromero@2027 65 import static javax.tools.StandardLocation.*;
vromero@2027 66 import static com.sun.tools.classfile.LocalVariableTable_attribute.Entry;
vromero@2027 67
vromero@2027 68 public class LVTHarness {
vromero@2027 69
vromero@2027 70 static int nerrors = 0;
vromero@2027 71
vromero@2027 72 static final JavaCompiler comp = ToolProvider.getSystemJavaCompiler();
vromero@2027 73 static final StandardJavaFileManager fm = comp.getStandardFileManager(null, null, null);
vromero@2027 74
vromero@2027 75 public static void main(String[] args) throws Exception {
vromero@2027 76 fm.setLocation(SOURCE_PATH,
vromero@2027 77 Arrays.asList(new File(System.getProperty("test.src"), "tests")));
vromero@2027 78 for (JavaFileObject jfo : fm.list(SOURCE_PATH, "",
vromero@2027 79 Collections.singleton(JavaFileObject.Kind.SOURCE), true)) {
vromero@2027 80 new LVTHarness(jfo).check();
vromero@2027 81 }
vromero@2027 82 if (nerrors > 0) {
vromero@2027 83 throw new AssertionError("Errors were found");
vromero@2027 84 }
vromero@2027 85 }
vromero@2027 86
vromero@2027 87
vromero@2027 88 JavaFileObject jfo;
vromero@2027 89 Map<ElementKey, AliveRanges> aliveRangeMap =
vromero@2027 90 new HashMap<ElementKey, AliveRanges>();
vromero@2027 91 Set<String> declaredKeys = new HashSet<>();
vromero@2027 92 List<ElementKey> seenAliveRanges = new ArrayList<>();
vromero@2027 93
vromero@2027 94 protected LVTHarness(JavaFileObject jfo) {
vromero@2027 95 this.jfo = jfo;
vromero@2027 96 }
vromero@2027 97
vromero@2027 98 protected void check() throws Exception {
vromero@2027 99 JavacTask ct = (JavacTask)comp.getTask(null, fm, null, Arrays.asList("-g"),
vromero@2027 100 null, Arrays.asList(jfo));
vromero@2027 101 System.err.println("compiling code " + jfo.toString());
vromero@2027 102 ct.setProcessors(Collections.singleton(new AliveRangeFinder()));
vromero@2027 103 if (!ct.call()) {
vromero@2027 104 throw new AssertionError("Error during compilation");
vromero@2027 105 }
vromero@2027 106
vromero@2027 107 checkClassFile(new File(jfo.getName().replace(".java", ".class")));
vromero@2027 108
vromero@2027 109 //check all candidates have been used up
vromero@2027 110 for (Map.Entry<ElementKey, AliveRanges> entry : aliveRangeMap.entrySet()) {
vromero@2027 111 if (!seenAliveRanges.contains(entry.getKey())) {
vromero@2027 112 error("Redundant @AliveRanges annotation on method " +
vromero@2027 113 entry.getKey().elem);
vromero@2027 114 }
vromero@2027 115 }
vromero@2027 116 }
vromero@2027 117
vromero@2027 118 void checkClassFile(File file)
vromero@2027 119 throws IOException, ConstantPoolException, InvalidDescriptor {
vromero@2027 120 ClassFile classFile = ClassFile.read(file);
vromero@2027 121 ConstantPool constantPool = classFile.constant_pool;
vromero@2027 122
vromero@2027 123 //lets get all the methods in the class file.
vromero@2027 124 for (Method method : classFile.methods) {
vromero@2027 125 for (ElementKey elementKey: aliveRangeMap.keySet()) {
vromero@2027 126 String methodDesc = method.getName(constantPool) +
vromero@2027 127 method.descriptor.getParameterTypes(constantPool);
vromero@2027 128 if (methodDesc.equals(elementKey.elem.toString())) {
vromero@2027 129 checkMethod(constantPool, method, aliveRangeMap.get(elementKey));
vromero@2027 130 seenAliveRanges.add(elementKey);
vromero@2027 131 }
vromero@2027 132 }
vromero@2027 133 }
vromero@2027 134 }
vromero@2027 135
vromero@2027 136 void checkMethod(ConstantPool constantPool, Method method, AliveRanges ranges)
vromero@2027 137 throws InvalidIndex, UnexpectedEntry {
vromero@2027 138 Code_attribute code = (Code_attribute) method.attributes.get(Attribute.Code);
vromero@2027 139 LocalVariableTable_attribute lvt =
vromero@2027 140 (LocalVariableTable_attribute) (code.attributes.get(Attribute.LocalVariableTable));
vromero@2027 141 List<String> infoFromRanges = convertToStringList(ranges);
vromero@2027 142 List<String> infoFromLVT = convertToStringList(constantPool, lvt);
vromero@2027 143
vromero@2027 144 // infoFromRanges most be contained in infoFromLVT
vromero@2027 145 int i = 0;
vromero@2027 146 int j = 0;
vromero@2027 147 while (i < infoFromRanges.size() && j < infoFromLVT.size()) {
vromero@2027 148 int comparison = infoFromRanges.get(i).compareTo(infoFromLVT.get(j));
vromero@2027 149 if (comparison == 0) {
vromero@2027 150 i++; j++;
vromero@2027 151 } else if (comparison > 0) {
vromero@2027 152 j++;
vromero@2027 153 } else {
vromero@2027 154 break;
vromero@2027 155 }
vromero@2027 156 }
vromero@2027 157
vromero@2027 158 if (i < infoFromRanges.size()) {
vromero@2027 159 error(infoFromLVT, infoFromRanges);
vromero@2027 160 }
vromero@2027 161 }
vromero@2027 162
vromero@2027 163 List<String> convertToStringList(AliveRanges ranges) {
vromero@2027 164 List<String> result = new ArrayList<>();
vromero@2027 165 for (Annotation anno : ranges.value()) {
vromero@2027 166 AliveRange range = (AliveRange)anno;
vromero@2027 167 String str = formatLocalVariableData(range.varName(),
vromero@2027 168 range.bytecodeStart(), range.bytecodeLength());
vromero@2027 169 result.add(str);
vromero@2027 170 }
vromero@2027 171 Collections.sort(result);
vromero@2027 172 return result;
vromero@2027 173 }
vromero@2027 174
vromero@2027 175 List<String> convertToStringList(ConstantPool constantPool,
vromero@2027 176 LocalVariableTable_attribute lvt) throws InvalidIndex, UnexpectedEntry {
vromero@2027 177 List<String> result = new ArrayList<>();
vromero@2027 178 for (Entry entry : lvt.local_variable_table) {
vromero@2027 179 String str = formatLocalVariableData(constantPool.getUTF8Value(entry.name_index),
vromero@2027 180 entry.start_pc, entry.length);
vromero@2027 181 result.add(str);
vromero@2027 182 }
vromero@2027 183 Collections.sort(result);
vromero@2027 184 return result;
vromero@2027 185 }
vromero@2027 186
vromero@2027 187 String formatLocalVariableData(String varName, int start, int length) {
vromero@2027 188 StringBuilder sb = new StringBuilder()
vromero@2027 189 .append("var name: ").append(varName)
vromero@2027 190 .append(" start: ").append(start)
vromero@2027 191 .append(" length: ").append(length);
vromero@2027 192 return sb.toString();
vromero@2027 193 }
vromero@2027 194
vromero@2027 195 protected void error(List<String> infoFromLVT, List<String> infoFromRanges) {
vromero@2027 196 nerrors++;
vromero@2027 197 System.err.printf("Error occurred while checking file: %s\n", jfo.getName());
vromero@2027 198 System.err.println("The range info from the annotations is");
vromero@2027 199 printStringListToErrOutput(infoFromRanges);
vromero@2027 200 System.err.println();
vromero@2027 201 System.err.println("And the range info from the class file is");
vromero@2027 202 printStringListToErrOutput(infoFromLVT);
vromero@2027 203 System.err.println();
vromero@2027 204 }
vromero@2027 205
vromero@2027 206 void printStringListToErrOutput(List<String> list) {
vromero@2027 207 for (String s : list) {
vromero@2027 208 System.err.println("\t" + s);
vromero@2027 209 }
vromero@2027 210 }
vromero@2027 211
vromero@2027 212 protected void error(String msg) {
vromero@2027 213 nerrors++;
vromero@2027 214 System.err.printf("Error occurred while checking file: %s\nreason: %s\n",
vromero@2027 215 jfo.getName(), msg);
vromero@2027 216 }
vromero@2027 217
vromero@2027 218 class AliveRangeFinder extends JavacTestingAbstractProcessor {
vromero@2027 219
vromero@2027 220 @Override
vromero@2027 221 public boolean process(Set<? extends TypeElement> annotations,
vromero@2027 222 RoundEnvironment roundEnv) {
vromero@2027 223 if (roundEnv.processingOver())
vromero@2027 224 return true;
vromero@2027 225
vromero@2027 226 TypeElement aliveRangeAnno = elements.getTypeElement("AliveRanges");
vromero@2027 227
vromero@2027 228 if (!annotations.contains(aliveRangeAnno)) {
vromero@2027 229 error("no @AliveRanges annotation found in test class");
vromero@2027 230 }
vromero@2027 231
vromero@2027 232 for (Element elem: roundEnv.getElementsAnnotatedWith(aliveRangeAnno)) {
vromero@2027 233 Annotation annotation = elem.getAnnotation(AliveRanges.class);
vromero@2027 234 aliveRangeMap.put(new ElementKey(elem), (AliveRanges)annotation);
vromero@2027 235 }
vromero@2027 236 return true;
vromero@2027 237 }
vromero@2027 238 }
vromero@2027 239
vromero@2027 240 class ElementKey {
vromero@2027 241
vromero@2027 242 String key;
vromero@2027 243 Element elem;
vromero@2027 244
vromero@2027 245 public ElementKey(Element elem) {
vromero@2027 246 this.elem = elem;
vromero@2027 247 this.key = computeKey(elem);
vromero@2027 248 }
vromero@2027 249
vromero@2027 250 @Override
vromero@2027 251 public boolean equals(Object obj) {
vromero@2027 252 if (obj instanceof ElementKey) {
vromero@2027 253 ElementKey other = (ElementKey)obj;
vromero@2027 254 return other.key.equals(key);
vromero@2027 255 }
vromero@2027 256 return false;
vromero@2027 257 }
vromero@2027 258
vromero@2027 259 @Override
vromero@2027 260 public int hashCode() {
vromero@2027 261 return key.hashCode();
vromero@2027 262 }
vromero@2027 263
vromero@2027 264 String computeKey(Element e) {
vromero@2027 265 StringBuilder buf = new StringBuilder();
vromero@2027 266 while (e != null) {
vromero@2027 267 buf.append(e.toString());
vromero@2027 268 e = e.getEnclosingElement();
vromero@2027 269 }
vromero@2027 270 buf.append(jfo.getName());
vromero@2027 271 return buf.toString();
vromero@2027 272 }
vromero@2027 273
vromero@2027 274 @Override
vromero@2027 275 public String toString() {
vromero@2027 276 return "Key{" + key + "}";
vromero@2027 277 }
vromero@2027 278 }
vromero@2027 279
vromero@2027 280 }

mercurial