src/share/classes/com/sun/tools/doclint/DocLint.java

Wed, 17 Jul 2013 19:16:12 -0700

author
jjg
date
Wed, 17 Jul 2013 19:16:12 -0700
changeset 1913
1476d54fdc61
parent 1895
37031963493e
child 1915
129751018061
permissions
-rw-r--r--

8020664: doclint gives incorrect warnings on normal package statements
Reviewed-by: mcimadamore

jjg@1455 1 /*
jjg@1506 2 * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
jjg@1455 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
jjg@1455 4 *
jjg@1455 5 * This code is free software; you can redistribute it and/or modify it
jjg@1455 6 * under the terms of the GNU General Public License version 2 only, as
jjg@1455 7 * published by the Free Software Foundation. Oracle designates this
jjg@1455 8 * particular file as subject to the "Classpath" exception as provided
jjg@1455 9 * by Oracle in the LICENSE file that accompanied this code.
jjg@1455 10 *
jjg@1455 11 * This code is distributed in the hope that it will be useful, but WITHOUT
jjg@1455 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
jjg@1455 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
jjg@1455 14 * version 2 for more details (a copy is included in the LICENSE file that
jjg@1455 15 * accompanied this code).
jjg@1455 16 *
jjg@1455 17 * You should have received a copy of the GNU General Public License version
jjg@1455 18 * 2 along with this work; if not, write to the Free Software Foundation,
jjg@1455 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
jjg@1455 20 *
jjg@1455 21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
jjg@1455 22 * or visit www.oracle.com if you need additional information or have any
jjg@1455 23 * questions.
jjg@1455 24 */
jjg@1455 25
jjg@1455 26 package com.sun.tools.doclint;
jjg@1455 27
jjg@1455 28 import java.io.File;
jjg@1455 29 import java.io.IOException;
jjg@1455 30 import java.io.PrintWriter;
jjg@1455 31 import java.util.ArrayList;
jjg@1455 32 import java.util.List;
jjg@1455 33
jjg@1455 34 import javax.lang.model.element.Name;
jjg@1913 35 import javax.tools.Diagnostic;
jjg@1913 36 import javax.tools.JavaFileObject;
jjg@1455 37 import javax.tools.StandardLocation;
jjg@1455 38
jjg@1455 39 import com.sun.source.doctree.DocCommentTree;
jjg@1455 40 import com.sun.source.tree.ClassTree;
jjg@1455 41 import com.sun.source.tree.CompilationUnitTree;
jjg@1455 42 import com.sun.source.tree.MethodTree;
jjg@1455 43 import com.sun.source.tree.Tree;
jjg@1455 44 import com.sun.source.tree.VariableTree;
jjg@1455 45 import com.sun.source.util.JavacTask;
jjg@1455 46 import com.sun.source.util.Plugin;
jjg@1455 47 import com.sun.source.util.TaskEvent;
jjg@1455 48 import com.sun.source.util.TaskListener;
jjg@1455 49 import com.sun.source.util.TreePath;
jjg@1455 50 import com.sun.source.util.TreePathScanner;
jjg@1455 51 import com.sun.tools.javac.api.JavacTaskImpl;
jjg@1455 52 import com.sun.tools.javac.api.JavacTool;
jjg@1455 53 import com.sun.tools.javac.file.JavacFileManager;
jjg@1455 54 import com.sun.tools.javac.main.JavaCompiler;
jjg@1455 55 import com.sun.tools.javac.util.Context;
jjg@1455 56
jjg@1455 57 /**
jjg@1455 58 * Multi-function entry point for the doc check utility.
jjg@1455 59 *
jjg@1455 60 * This class can be invoked in the following ways:
jjg@1455 61 * <ul>
jjg@1455 62 * <li>From the command line
jjg@1455 63 * <li>From javac, as a plugin
jjg@1455 64 * <li>Directly, via a simple API
jjg@1455 65 * </ul>
jjg@1455 66 *
jjg@1455 67 * <p><b>This is NOT part of any supported API.
jjg@1455 68 * If you write code that depends on this, you do so at your own
jjg@1455 69 * risk. This code and its internal interfaces are subject to change
jjg@1455 70 * or deletion without notice.</b></p>
jjg@1455 71 */
jjg@1455 72 public class DocLint implements Plugin {
jjg@1455 73
jjg@1455 74 public static final String XMSGS_OPTION = "-Xmsgs";
jjg@1455 75 public static final String XMSGS_CUSTOM_PREFIX = "-Xmsgs:";
jjg@1455 76 private static final String STATS = "-stats";
jjg@1668 77 public static final String XIMPLICIT_HEADERS = "-XimplicitHeaders:";
jjg@1455 78
jjg@1455 79 // <editor-fold defaultstate="collapsed" desc="Command-line entry point">
jjg@1455 80 public static void main(String... args) {
jjg@1796 81 DocLint dl = new DocLint();
jjg@1455 82 try {
jjg@1796 83 dl.run(args);
jjg@1455 84 } catch (BadArgs e) {
jjg@1455 85 System.err.println(e.getMessage());
jjg@1455 86 System.exit(1);
jjg@1455 87 } catch (IOException e) {
jjg@1796 88 System.err.println(dl.localize("dc.main.ioerror", e.getLocalizedMessage()));
jjg@1455 89 System.exit(2);
jjg@1455 90 }
jjg@1455 91 }
jjg@1455 92
jjg@1455 93 // </editor-fold>
jjg@1455 94
jjg@1455 95 // <editor-fold defaultstate="collapsed" desc="Simple API">
jjg@1455 96
jjg@1796 97 public class BadArgs extends Exception {
jjg@1455 98 private static final long serialVersionUID = 0;
jjg@1455 99 BadArgs(String code, Object... args) {
jjg@1796 100 super(localize(code, args));
jjg@1455 101 this.code = code;
jjg@1455 102 this.args = args;
jjg@1455 103 }
jjg@1455 104
jjg@1455 105 final String code;
jjg@1455 106 final Object[] args;
jjg@1455 107 }
jjg@1455 108
jjg@1455 109 /**
jjg@1455 110 * Simple API entry point.
jjg@1455 111 */
jjg@1455 112 public void run(String... args) throws BadArgs, IOException {
jjg@1455 113 PrintWriter out = new PrintWriter(System.out);
jjg@1455 114 try {
jjg@1455 115 run(out, args);
jjg@1455 116 } finally {
jjg@1455 117 out.flush();
jjg@1455 118 }
jjg@1455 119 }
jjg@1455 120
jjg@1455 121 public void run(PrintWriter out, String... args) throws BadArgs, IOException {
jjg@1455 122 env = new Env();
jjg@1455 123 processArgs(args);
jjg@1455 124
jjg@1455 125 if (needHelp)
jjg@1455 126 showHelp(out);
jjg@1455 127
jjg@1455 128 if (javacFiles.isEmpty()) {
jjg@1455 129 if (!needHelp)
jjg@1796 130 out.println(localize("dc.main.no.files.given"));
jjg@1455 131 }
jjg@1455 132
jjg@1455 133 JavacTool tool = JavacTool.create();
jjg@1455 134
jjg@1455 135 JavacFileManager fm = new JavacFileManager(new Context(), false, null);
jjg@1455 136 fm.setSymbolFileEnabled(false);
jjg@1455 137 fm.setLocation(StandardLocation.PLATFORM_CLASS_PATH, javacBootClassPath);
jjg@1455 138 fm.setLocation(StandardLocation.CLASS_PATH, javacClassPath);
jjg@1455 139 fm.setLocation(StandardLocation.SOURCE_PATH, javacSourcePath);
jjg@1455 140
jjg@1455 141 JavacTask task = tool.getTask(out, fm, null, javacOpts, null,
jjg@1455 142 fm.getJavaFileObjectsFromFiles(javacFiles));
jjg@1455 143 Iterable<? extends CompilationUnitTree> units = task.parse();
jjg@1455 144 ((JavacTaskImpl) task).enter();
jjg@1455 145
jjg@1455 146 env.init(task);
jjg@1455 147 checker = new Checker(env);
jjg@1455 148
jjg@1455 149 DeclScanner ds = new DeclScanner() {
jjg@1455 150 @Override
jjg@1455 151 void visitDecl(Tree tree, Name name) {
jjg@1455 152 TreePath p = getCurrentPath();
jjg@1455 153 DocCommentTree dc = env.trees.getDocCommentTree(p);
jjg@1455 154
jjg@1913 155 if (p.getLeaf() == p.getCompilationUnit()) {
jjg@1913 156 JavaFileObject fo = p.getCompilationUnit().getSourceFile();
jjg@1913 157 boolean pkgInfo = fo.isNameCompatible("package-info", JavaFileObject.Kind.SOURCE);
jjg@1913 158 if (!pkgInfo) {
jjg@1913 159 if (dc == null)
jjg@1913 160 return;
jjg@1913 161 env.setCurrent(p, dc);
jjg@1913 162 env.messages.report(Messages.Group.REFERENCE, Diagnostic.Kind.WARNING, p.getLeaf(),
jjg@1913 163 "dc.unexpected.comment");
jjg@1913 164 }
jjg@1913 165 }
jjg@1913 166
jjg@1455 167 checker.scan(dc, p);
jjg@1455 168 }
jjg@1455 169 };
jjg@1455 170
jjg@1455 171 ds.scan(units, null);
jjg@1455 172
jjg@1455 173 reportStats(out);
jjg@1455 174
jjg@1455 175 Context ctx = ((JavacTaskImpl) task).getContext();
jjg@1455 176 JavaCompiler c = JavaCompiler.instance(ctx);
jjg@1455 177 c.printCount("error", c.errorCount());
jjg@1455 178 c.printCount("warn", c.warningCount());
jjg@1455 179 }
jjg@1455 180
jjg@1455 181 void processArgs(String... args) throws BadArgs {
jjg@1913 182 javacOpts = new ArrayList<>();
jjg@1913 183 javacFiles = new ArrayList<>();
jjg@1455 184
jjg@1455 185 if (args.length == 0)
jjg@1455 186 needHelp = true;
jjg@1455 187
jjg@1455 188 for (int i = 0; i < args.length; i++) {
jjg@1455 189 String arg = args[i];
jjg@1455 190 if (arg.matches("-Xmax(errs|warns)") && i + 1 < args.length) {
jjg@1455 191 if (args[++i].matches("[0-9]+")) {
jjg@1455 192 javacOpts.add(arg);
jjg@1455 193 javacOpts.add(args[i]);
jjg@1455 194 } else {
jjg@1455 195 throw new BadArgs("dc.bad.value.for.option", arg, args[i]);
jjg@1455 196 }
jjg@1455 197 } else if (arg.equals(STATS)) {
jjg@1455 198 env.messages.setStatsEnabled(true);
jjg@1506 199 } else if (arg.equals("-bootclasspath") && i + 1 < args.length) {
jjg@1455 200 javacBootClassPath = splitPath(args[++i]);
jjg@1506 201 } else if (arg.equals("-classpath") && i + 1 < args.length) {
jjg@1455 202 javacClassPath = splitPath(args[++i]);
vromero@1885 203 } else if (arg.equals("-cp") && i + 1 < args.length) {
vromero@1885 204 javacClassPath = splitPath(args[++i]);
jjg@1506 205 } else if (arg.equals("-sourcepath") && i + 1 < args.length) {
jjg@1455 206 javacSourcePath = splitPath(args[++i]);
jjg@1455 207 } else if (arg.equals(XMSGS_OPTION)) {
jjg@1455 208 env.messages.setOptions(null);
jjg@1455 209 } else if (arg.startsWith(XMSGS_CUSTOM_PREFIX)) {
jjg@1455 210 env.messages.setOptions(arg.substring(arg.indexOf(":") + 1));
jjg@1455 211 } else if (arg.equals("-h") || arg.equals("-help") || arg.equals("--help")
jjg@1455 212 || arg.equals("-?") || arg.equals("-usage")) {
jjg@1455 213 needHelp = true;
jjg@1455 214 } else if (arg.startsWith("-")) {
jjg@1455 215 throw new BadArgs("dc.bad.option", arg);
jjg@1455 216 } else {
jjg@1455 217 while (i < args.length)
jjg@1455 218 javacFiles.add(new File(args[i++]));
jjg@1455 219 }
jjg@1455 220 }
jjg@1455 221 }
jjg@1455 222
jjg@1455 223 void showHelp(PrintWriter out) {
jjg@1796 224 String msg = localize("dc.main.usage");
jjg@1796 225 for (String line: msg.split("\n"))
jjg@1796 226 out.println(line);
jjg@1455 227 }
jjg@1455 228
jjg@1455 229 List<File> splitPath(String path) {
jjg@1913 230 List<File> files = new ArrayList<>();
jjg@1506 231 for (String f: path.split(File.pathSeparator)) {
jjg@1455 232 if (f.length() > 0)
jjg@1455 233 files.add(new File(f));
jjg@1455 234 }
jjg@1455 235 return files;
jjg@1455 236 }
jjg@1455 237
jjg@1455 238 List<File> javacBootClassPath;
jjg@1455 239 List<File> javacClassPath;
jjg@1455 240 List<File> javacSourcePath;
jjg@1455 241 List<String> javacOpts;
jjg@1455 242 List<File> javacFiles;
jjg@1455 243 boolean needHelp = false;
jjg@1455 244
jjg@1455 245 // </editor-fold>
jjg@1455 246
jjg@1455 247 // <editor-fold defaultstate="collapsed" desc="javac Plugin">
jjg@1455 248
jjg@1455 249 @Override
jjg@1455 250 public String getName() {
jjg@1455 251 return "doclint";
jjg@1455 252 }
jjg@1455 253
jjg@1455 254 @Override
mchung@1458 255 public void init(JavacTask task, String... args) {
jjg@1455 256 init(task, args, true);
jjg@1455 257 }
jjg@1455 258
jjg@1455 259 // </editor-fold>
jjg@1455 260
jjg@1455 261 // <editor-fold defaultstate="collapsed" desc="Embedding API">
jjg@1455 262
jjg@1455 263 public void init(JavacTask task, String[] args, boolean addTaskListener) {
jjg@1455 264 env = new Env();
jjg@1455 265 for (int i = 0; i < args.length; i++) {
jjg@1455 266 String arg = args[i];
jjg@1455 267 if (arg.equals(XMSGS_OPTION)) {
jjg@1455 268 env.messages.setOptions(null);
jjg@1455 269 } else if (arg.startsWith(XMSGS_CUSTOM_PREFIX)) {
jjg@1455 270 env.messages.setOptions(arg.substring(arg.indexOf(":") + 1));
jjg@1668 271 } else if (arg.matches(XIMPLICIT_HEADERS + "[1-6]")) {
jjg@1668 272 char ch = arg.charAt(arg.length() - 1);
jjg@1668 273 env.setImplicitHeaders(Character.digit(ch, 10));
jjg@1455 274 } else
jjg@1455 275 throw new IllegalArgumentException(arg);
jjg@1455 276 }
jjg@1455 277 env.init(task);
jjg@1455 278
jjg@1455 279 checker = new Checker(env);
jjg@1455 280
jjg@1455 281 if (addTaskListener) {
jjg@1455 282 final DeclScanner ds = new DeclScanner() {
jjg@1455 283 @Override
jjg@1455 284 void visitDecl(Tree tree, Name name) {
jjg@1455 285 TreePath p = getCurrentPath();
jjg@1455 286 DocCommentTree dc = env.trees.getDocCommentTree(p);
jjg@1455 287
jjg@1455 288 checker.scan(dc, p);
jjg@1455 289 }
jjg@1455 290 };
jjg@1455 291
jjg@1455 292 TaskListener tl = new TaskListener() {
jjg@1455 293 @Override
jjg@1455 294 public void started(TaskEvent e) {
jjg@1455 295 }
jjg@1455 296
jjg@1455 297 @Override
jjg@1455 298 public void finished(TaskEvent e) {
jjg@1455 299 switch (e.getKind()) {
jjg@1455 300 case ENTER:
jjg@1455 301 ds.scan(e.getCompilationUnit(), null);
jjg@1455 302 }
jjg@1455 303 }
jjg@1455 304 };
jjg@1455 305
jjg@1455 306 task.addTaskListener(tl);
jjg@1455 307 }
jjg@1455 308 }
jjg@1455 309
jjg@1455 310 public void scan(TreePath p) {
jjg@1455 311 DocCommentTree dc = env.trees.getDocCommentTree(p);
jjg@1455 312 checker.scan(dc, p);
jjg@1455 313 }
jjg@1455 314
jjg@1455 315 public void reportStats(PrintWriter out) {
jjg@1455 316 env.messages.reportStats(out);
jjg@1455 317 }
jjg@1455 318
jjg@1455 319 // </editor-fold>
jjg@1455 320
jjg@1455 321 Env env;
jjg@1455 322 Checker checker;
jjg@1455 323
jjg@1455 324 public static boolean isValidOption(String opt) {
jjg@1455 325 if (opt.equals(XMSGS_OPTION))
jjg@1455 326 return true;
jjg@1455 327 if (opt.startsWith(XMSGS_CUSTOM_PREFIX))
jjg@1455 328 return Messages.Options.isValidOptions(opt.substring(XMSGS_CUSTOM_PREFIX.length()));
jjg@1455 329 return false;
jjg@1455 330 }
jjg@1455 331
jjg@1796 332 private String localize(String code, Object... args) {
jjg@1796 333 Messages m = (env != null) ? env.messages : new Messages(null);
jjg@1796 334 return m.localize(code, args);
jjg@1796 335 }
jjg@1796 336
jjg@1455 337 // <editor-fold defaultstate="collapsed" desc="DeclScanner">
jjg@1455 338
jjg@1455 339 static abstract class DeclScanner extends TreePathScanner<Void, Void> {
jjg@1455 340 abstract void visitDecl(Tree tree, Name name);
jjg@1455 341
jjg@1455 342 @Override
jjg@1895 343 public Void visitCompilationUnit(CompilationUnitTree tree, Void ignore) {
jjg@1895 344 if (tree.getPackageName() != null) {
jjg@1895 345 visitDecl(tree, null);
jjg@1895 346 }
jjg@1895 347 return super.visitCompilationUnit(tree, ignore);
jjg@1895 348 }
jjg@1895 349
jjg@1895 350 @Override
jjg@1455 351 public Void visitClass(ClassTree tree, Void ignore) {
jjg@1455 352 visitDecl(tree, tree.getSimpleName());
jjg@1455 353 return super.visitClass(tree, ignore);
jjg@1455 354 }
jjg@1455 355
jjg@1455 356 @Override
jjg@1455 357 public Void visitMethod(MethodTree tree, Void ignore) {
jjg@1455 358 visitDecl(tree, tree.getName());
jjg@1455 359 //return super.visitMethod(tree, ignore);
jjg@1455 360 return null;
jjg@1455 361 }
jjg@1455 362
jjg@1455 363 @Override
jjg@1455 364 public Void visitVariable(VariableTree tree, Void ignore) {
jjg@1455 365 visitDecl(tree, tree.getName());
jjg@1455 366 return super.visitVariable(tree, ignore);
jjg@1455 367 }
jjg@1455 368 }
jjg@1455 369
jjg@1455 370 // </editor-fold>
jjg@1455 371
jjg@1455 372 }

mercurial