Mercurial > jdk8-mips64-public > hotspot / changeset

• changeset
• raw
• bz2
• zip
• gz

changeset

6953483: Typo related to ReduceInitialCardMarks leaves concurrent collectors vulnerable to heap corruption

Wed, 19 May 2010 10:37:05 -0700

author

ysr

date

Wed, 19 May 2010 10:37:05 -0700

changeset 1903

15190cbcabe9

parent 1902

fb1a39993f69

child 1904

1634cec09505

6953483: Typo related to ReduceInitialCardMarks leaves concurrent collectors vulnerable to heap corruption
Summary: Corrected mis-spelling of COMPILER2 in #ifdef, which could cause heap corruption in CMS due to precleaning when +ReduceInitialCardMarks. Thanks to ChenGuang Sun <suncg03@gmail.com> for bringing this typo to our attention.
Reviewed-by: tonyp, jmasa, jcoomes, kvn

     1.1 --- a/src/share/vm/gc_interface/collectedHeap.cpp	Tue May 18 11:02:18 2010 -0700
     1.2 +++ b/src/share/vm/gc_interface/collectedHeap.cpp	Wed May 19 10:37:05 2010 -0700
     1.3 @@ -65,7 +65,7 @@
     1.4  void CollectedHeap::pre_initialize() {
     1.5    // Used for ReduceInitialCardMarks (when COMPILER2 is used);
     1.6    // otherwise remains unused.
     1.7 -#ifdef COMPLER2
     1.8 +#ifdef COMPILER2
     1.9    _defer_initial_card_mark =    ReduceInitialCardMarks && can_elide_tlab_store_barriers()
    1.10                               && (DeferInitialCardMark || card_mark_must_follow_store());
    1.11  #else