Fri, 17 May 2013 17:24:20 +0200
7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: brutisso, tschatzl
sla@5237 | 1 | /* |
sla@5237 | 2 | * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved. |
sla@5237 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
sla@5237 | 4 | * |
sla@5237 | 5 | * This code is free software; you can redistribute it and/or modify it |
sla@5237 | 6 | * under the terms of the GNU General Public License version 2 only, as |
sla@5237 | 7 | * published by the Free Software Foundation. |
sla@5237 | 8 | * |
sla@5237 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
sla@5237 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
sla@5237 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
sla@5237 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
sla@5237 | 13 | * accompanied this code). |
sla@5237 | 14 | * |
sla@5237 | 15 | * You should have received a copy of the GNU General Public License version |
sla@5237 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
sla@5237 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
sla@5237 | 18 | * |
sla@5237 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
sla@5237 | 20 | * or visit www.oracle.com if you need additional information or have any |
sla@5237 | 21 | * questions. |
sla@5237 | 22 | * |
sla@5237 | 23 | */ |
sla@5237 | 24 | |
sla@5237 | 25 | #include "precompiled.hpp" |
sla@5237 | 26 | #include "gc_implementation/shared/gcTimer.hpp" |
brutisso@6904 | 27 | #include "gc_implementation/shared/gcTrace.hpp" |
sla@5237 | 28 | #include "gc_implementation/shared/gcTraceTime.hpp" |
sla@5237 | 29 | #include "runtime/globals.hpp" |
sla@5237 | 30 | #include "runtime/os.hpp" |
sla@5237 | 31 | #include "runtime/safepoint.hpp" |
sla@5237 | 32 | #include "runtime/thread.inline.hpp" |
sla@5237 | 33 | #include "runtime/timer.hpp" |
sla@5237 | 34 | #include "utilities/ostream.hpp" |
mgronlun@6131 | 35 | #include "utilities/ticks.inline.hpp" |
sla@5237 | 36 | |
sla@5237 | 37 | |
brutisso@6904 | 38 | GCTraceTime::GCTraceTime(const char* title, bool doit, bool print_cr, GCTimer* timer, GCId gc_id) : |
mgronlun@6131 | 39 | _title(title), _doit(doit), _print_cr(print_cr), _timer(timer), _start_counter() { |
sla@5237 | 40 | if (_doit || _timer != NULL) { |
mgronlun@6131 | 41 | _start_counter.stamp(); |
sla@5237 | 42 | } |
sla@5237 | 43 | |
sla@5237 | 44 | if (_timer != NULL) { |
sla@5237 | 45 | assert(SafepointSynchronize::is_at_safepoint(), "Tracing currently only supported at safepoints"); |
sla@5237 | 46 | assert(Thread::current()->is_VM_thread(), "Tracing currently only supported from the VM thread"); |
sla@5237 | 47 | |
sla@5237 | 48 | _timer->register_gc_phase_start(title, _start_counter); |
sla@5237 | 49 | } |
sla@5237 | 50 | |
sla@5237 | 51 | if (_doit) { |
aeriksso@7612 | 52 | gclog_or_tty->date_stamp(PrintGCDateStamps); |
aeriksso@7612 | 53 | gclog_or_tty->stamp(PrintGCTimeStamps); |
brutisso@6904 | 54 | if (PrintGCID) { |
brutisso@6904 | 55 | gclog_or_tty->print("#%u: ", gc_id.id()); |
brutisso@6904 | 56 | } |
sla@5237 | 57 | gclog_or_tty->print("[%s", title); |
sla@5237 | 58 | gclog_or_tty->flush(); |
sla@5237 | 59 | } |
sla@5237 | 60 | } |
sla@5237 | 61 | |
sla@5237 | 62 | GCTraceTime::~GCTraceTime() { |
mgronlun@6131 | 63 | Ticks stop_counter; |
sla@5237 | 64 | |
sla@5237 | 65 | if (_doit || _timer != NULL) { |
mgronlun@6131 | 66 | stop_counter.stamp(); |
sla@5237 | 67 | } |
sla@5237 | 68 | |
sla@5237 | 69 | if (_timer != NULL) { |
sla@5237 | 70 | _timer->register_gc_phase_end(stop_counter); |
sla@5237 | 71 | } |
sla@5237 | 72 | |
sla@5237 | 73 | if (_doit) { |
mgronlun@6131 | 74 | const Tickspan duration = stop_counter - _start_counter; |
mgronlun@6131 | 75 | double duration_in_seconds = TicksToTimeHelper::seconds(duration); |
sla@5237 | 76 | if (_print_cr) { |
mgronlun@6131 | 77 | gclog_or_tty->print_cr(", %3.7f secs]", duration_in_seconds); |
sla@5237 | 78 | } else { |
mgronlun@6131 | 79 | gclog_or_tty->print(", %3.7f secs]", duration_in_seconds); |
sla@5237 | 80 | } |
sla@5237 | 81 | gclog_or_tty->flush(); |
sla@5237 | 82 | } |
sla@5237 | 83 | } |