Wed, 17 Jun 2020 11:43:05 +0300
8220293: Deadlock in JFR string pool
Reviewed-by: rehn, egahlin
apetushkov@9858 | 1 | /* |
apetushkov@9928 | 2 | * Copyright (c) 2016, 2019, Oracle and/or its affiliates. All rights reserved. |
apetushkov@9858 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
apetushkov@9858 | 4 | * |
apetushkov@9858 | 5 | * This code is free software; you can redistribute it and/or modify it |
apetushkov@9858 | 6 | * under the terms of the GNU General Public License version 2 only, as |
apetushkov@9858 | 7 | * published by the Free Software Foundation. |
apetushkov@9858 | 8 | * |
apetushkov@9858 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
apetushkov@9858 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
apetushkov@9858 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
apetushkov@9858 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
apetushkov@9858 | 13 | * accompanied this code). |
apetushkov@9858 | 14 | * |
apetushkov@9858 | 15 | * You should have received a copy of the GNU General Public License version |
apetushkov@9858 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
apetushkov@9858 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
apetushkov@9858 | 18 | * |
apetushkov@9858 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
apetushkov@9858 | 20 | * or visit www.oracle.com if you need additional information or have any |
apetushkov@9858 | 21 | * questions. |
apetushkov@9858 | 22 | * |
apetushkov@9858 | 23 | */ |
apetushkov@9858 | 24 | |
apetushkov@9858 | 25 | #include "precompiled.hpp" |
apetushkov@9858 | 26 | #include "jfr/recorder/stringpool/jfrStringPoolBuffer.hpp" |
apetushkov@9858 | 27 | |
apetushkov@9858 | 28 | JfrStringPoolBuffer::JfrStringPoolBuffer() : JfrBuffer(), _string_count_pos(0), _string_count_top(0) {} |
apetushkov@9858 | 29 | |
apetushkov@9858 | 30 | void JfrStringPoolBuffer::reinitialize() { |
apetushkov@9858 | 31 | assert(acquired_by_self() || retired(), "invariant"); |
apetushkov@9858 | 32 | set_string_pos(0); |
apetushkov@9858 | 33 | set_string_top(0); |
apetushkov@9928 | 34 | JfrBuffer::reinitialize(); |
apetushkov@9858 | 35 | } |
apetushkov@9858 | 36 | |
apetushkov@9858 | 37 | uint64_t JfrStringPoolBuffer::string_pos() const { |
apetushkov@9858 | 38 | assert(acquired_by_self() || retired(), "invariant"); |
apetushkov@9858 | 39 | return _string_count_pos; |
apetushkov@9858 | 40 | } |
apetushkov@9858 | 41 | |
apetushkov@9858 | 42 | uint64_t JfrStringPoolBuffer::string_top() const { |
apetushkov@9858 | 43 | assert(acquired_by_self() || retired(), "invariant"); |
apetushkov@9858 | 44 | return _string_count_top; |
apetushkov@9858 | 45 | } |
apetushkov@9858 | 46 | |
apetushkov@9858 | 47 | uint64_t JfrStringPoolBuffer::string_count() const { |
apetushkov@9858 | 48 | assert(acquired_by_self() || retired(), "invariant"); |
apetushkov@9858 | 49 | return string_pos() - string_top(); |
apetushkov@9858 | 50 | } |
apetushkov@9858 | 51 | |
apetushkov@9858 | 52 | void JfrStringPoolBuffer::set_string_pos(uint64_t value) { |
apetushkov@9858 | 53 | assert(acquired_by_self() || retired(), "invariant"); |
apetushkov@9858 | 54 | _string_count_pos = value; |
apetushkov@9858 | 55 | } |
apetushkov@9858 | 56 | |
apetushkov@9858 | 57 | void JfrStringPoolBuffer::increment(uint64_t value) { |
apetushkov@9928 | 58 | assert(acquired_by_self(), "invariant"); |
apetushkov@9858 | 59 | ++_string_count_pos; |
apetushkov@9858 | 60 | } |
apetushkov@9858 | 61 | |
apetushkov@9858 | 62 | void JfrStringPoolBuffer::set_string_top(uint64_t value) { |
apetushkov@9858 | 63 | assert(acquired_by_self() || retired(), "invariant"); |
apetushkov@9858 | 64 | _string_count_top = value; |
apetushkov@9858 | 65 | } |