Mon, 15 Jun 2020 14:08:11 +0300
8245167: Top package in method profiling shows null in JMC
Reviewed-by: neugens
Contributed-by: asemenov@azul.com
apetushkov@9858 | 1 | /* |
apetushkov@9858 | 2 | * Copyright (c) 2017, 2018, Oracle and/or its affiliates. All rights reserved. |
apetushkov@9858 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
apetushkov@9858 | 4 | * |
apetushkov@9858 | 5 | * This code is free software; you can redistribute it and/or modify it |
apetushkov@9858 | 6 | * under the terms of the GNU General Public License version 2 only, as |
apetushkov@9858 | 7 | * published by the Free Software Foundation. |
apetushkov@9858 | 8 | * |
apetushkov@9858 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
apetushkov@9858 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
apetushkov@9858 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
apetushkov@9858 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
apetushkov@9858 | 13 | * accompanied this code). |
apetushkov@9858 | 14 | * |
apetushkov@9858 | 15 | * You should have received a copy of the GNU General Public License version |
apetushkov@9858 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
apetushkov@9858 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
apetushkov@9858 | 18 | * |
apetushkov@9858 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
apetushkov@9858 | 20 | * or visit www.oracle.com if you need additional information or have any |
apetushkov@9858 | 21 | * questions. |
apetushkov@9858 | 22 | * |
apetushkov@9858 | 23 | */ |
apetushkov@9858 | 24 | |
apetushkov@9858 | 25 | #include "precompiled.hpp" |
apetushkov@9858 | 26 | #include "jfr/recorder/checkpoint/types/jfrTypeSetUtils.hpp" |
apetushkov@9858 | 27 | #include "oops/instanceKlass.hpp" |
apetushkov@9858 | 28 | #include "oops/oop.inline.hpp" |
apetushkov@9858 | 29 | #include "oops/symbol.hpp" |
apetushkov@9858 | 30 | |
apetushkov@9926 | 31 | JfrSymbolId::JfrSymbolId() : _symbol_id_counter(0), _sym_table(new SymbolTable(this)), |
apetushkov@9926 | 32 | _cstring_table(new CStringTable(this)), _pkg_table(new CStringTable(this)) { |
apetushkov@9858 | 33 | assert(_sym_table != NULL, "invariant"); |
apetushkov@9858 | 34 | assert(_cstring_table != NULL, "invariant"); |
apetushkov@9926 | 35 | assert(_pkg_table != NULL, "invariant"); |
apetushkov@9858 | 36 | initialize(); |
apetushkov@9858 | 37 | } |
apetushkov@9858 | 38 | |
apetushkov@9858 | 39 | void JfrSymbolId::initialize() { |
apetushkov@9858 | 40 | clear(); |
apetushkov@9858 | 41 | assert(_symbol_id_counter == 0, "invariant"); |
apetushkov@9858 | 42 | } |
apetushkov@9858 | 43 | |
apetushkov@9858 | 44 | void JfrSymbolId::clear() { |
apetushkov@9858 | 45 | assert(_sym_table != NULL, "invariant"); |
apetushkov@9858 | 46 | if (_sym_table->has_entries()) { |
apetushkov@9858 | 47 | _sym_table->clear_entries(); |
apetushkov@9858 | 48 | } |
apetushkov@9858 | 49 | assert(!_sym_table->has_entries(), "invariant"); |
apetushkov@9858 | 50 | |
apetushkov@9858 | 51 | assert(_cstring_table != NULL, "invariant"); |
apetushkov@9858 | 52 | if (_cstring_table->has_entries()) { |
apetushkov@9858 | 53 | _cstring_table->clear_entries(); |
apetushkov@9858 | 54 | } |
apetushkov@9858 | 55 | assert(!_cstring_table->has_entries(), "invariant"); |
apetushkov@9858 | 56 | _symbol_id_counter = 0; |
apetushkov@9926 | 57 | assert(_pkg_table != NULL, "invariant"); |
apetushkov@9926 | 58 | if (_pkg_table->has_entries()) { |
apetushkov@9926 | 59 | _pkg_table->clear_entries(); |
apetushkov@9926 | 60 | } |
apetushkov@9926 | 61 | assert(!_pkg_table->has_entries(), "invariant"); |
apetushkov@9858 | 62 | } |
apetushkov@9858 | 63 | |
apetushkov@9858 | 64 | JfrSymbolId::~JfrSymbolId() { |
apetushkov@9858 | 65 | delete _sym_table; |
apetushkov@9858 | 66 | delete _cstring_table; |
apetushkov@9858 | 67 | } |
apetushkov@9858 | 68 | |
apetushkov@9858 | 69 | traceid JfrSymbolId::mark_anonymous_klass_name(const Klass* k) { |
apetushkov@9858 | 70 | assert(k != NULL, "invariant"); |
apetushkov@9858 | 71 | assert(k->oop_is_instance(), "invariant"); |
apetushkov@9858 | 72 | assert(is_anonymous_klass(k), "invariant"); |
apetushkov@9858 | 73 | |
apetushkov@9858 | 74 | uintptr_t anonymous_symbol_hash_code = 0; |
apetushkov@9858 | 75 | const char* const anonymous_symbol = |
apetushkov@9858 | 76 | create_anonymous_klass_symbol((const InstanceKlass*)k, anonymous_symbol_hash_code); |
apetushkov@9858 | 77 | |
apetushkov@9858 | 78 | if (anonymous_symbol == NULL) { |
apetushkov@9858 | 79 | return 0; |
apetushkov@9858 | 80 | } |
apetushkov@9858 | 81 | |
apetushkov@9858 | 82 | assert(anonymous_symbol_hash_code != 0, "invariant"); |
apetushkov@9858 | 83 | traceid symbol_id = mark(anonymous_symbol, anonymous_symbol_hash_code); |
apetushkov@9858 | 84 | assert(mark(anonymous_symbol, anonymous_symbol_hash_code) == symbol_id, "invariant"); |
apetushkov@9858 | 85 | return symbol_id; |
apetushkov@9858 | 86 | } |
apetushkov@9858 | 87 | |
apetushkov@9858 | 88 | const JfrSymbolId::SymbolEntry* JfrSymbolId::map_symbol(const Symbol* symbol) const { |
apetushkov@9858 | 89 | return _sym_table->lookup_only(symbol, (uintptr_t)const_cast<Symbol*>(symbol)->identity_hash()); |
apetushkov@9858 | 90 | } |
apetushkov@9858 | 91 | |
apetushkov@9858 | 92 | const JfrSymbolId::SymbolEntry* JfrSymbolId::map_symbol(uintptr_t hash) const { |
apetushkov@9858 | 93 | return _sym_table->lookup_only(NULL, hash); |
apetushkov@9858 | 94 | } |
apetushkov@9858 | 95 | |
apetushkov@9858 | 96 | const JfrSymbolId::CStringEntry* JfrSymbolId::map_cstring(uintptr_t hash) const { |
apetushkov@9858 | 97 | return _cstring_table->lookup_only(NULL, hash); |
apetushkov@9858 | 98 | } |
apetushkov@9858 | 99 | |
apetushkov@9858 | 100 | void JfrSymbolId::assign_id(SymbolEntry* entry) { |
apetushkov@9858 | 101 | assert(entry != NULL, "invariant"); |
apetushkov@9858 | 102 | assert(entry->id() == 0, "invariant"); |
apetushkov@9858 | 103 | entry->set_id(++_symbol_id_counter); |
apetushkov@9858 | 104 | } |
apetushkov@9858 | 105 | |
apetushkov@9858 | 106 | bool JfrSymbolId::equals(const Symbol* query, uintptr_t hash, const SymbolEntry* entry) { |
apetushkov@9858 | 107 | // query might be NULL |
apetushkov@9858 | 108 | assert(entry != NULL, "invariant"); |
apetushkov@9858 | 109 | assert(entry->hash() == hash, "invariant"); |
apetushkov@9858 | 110 | return true; |
apetushkov@9858 | 111 | } |
apetushkov@9858 | 112 | |
apetushkov@9858 | 113 | void JfrSymbolId::assign_id(CStringEntry* entry) { |
apetushkov@9858 | 114 | assert(entry != NULL, "invariant"); |
apetushkov@9858 | 115 | assert(entry->id() == 0, "invariant"); |
apetushkov@9858 | 116 | entry->set_id(++_symbol_id_counter); |
apetushkov@9858 | 117 | } |
apetushkov@9858 | 118 | |
apetushkov@9858 | 119 | bool JfrSymbolId::equals(const char* query, uintptr_t hash, const CStringEntry* entry) { |
apetushkov@9858 | 120 | // query might be NULL |
apetushkov@9858 | 121 | assert(entry != NULL, "invariant"); |
apetushkov@9858 | 122 | assert(entry->hash() == hash, "invariant"); |
apetushkov@9858 | 123 | return true; |
apetushkov@9858 | 124 | } |
apetushkov@9858 | 125 | |
apetushkov@9858 | 126 | traceid JfrSymbolId::mark(const Klass* k) { |
apetushkov@9858 | 127 | assert(k != NULL, "invariant"); |
apetushkov@9858 | 128 | traceid symbol_id = 0; |
apetushkov@9858 | 129 | if (is_anonymous_klass(k)) { |
apetushkov@9858 | 130 | symbol_id = mark_anonymous_klass_name(k); |
apetushkov@9858 | 131 | } |
apetushkov@9858 | 132 | if (0 == symbol_id) { |
apetushkov@9858 | 133 | const Symbol* const sym = k->name(); |
apetushkov@9858 | 134 | if (sym != NULL) { |
apetushkov@9858 | 135 | symbol_id = mark(sym); |
apetushkov@9858 | 136 | } |
apetushkov@9858 | 137 | } |
apetushkov@9858 | 138 | assert(symbol_id > 0, "a symbol handler must mark the symbol for writing"); |
apetushkov@9858 | 139 | return symbol_id; |
apetushkov@9858 | 140 | } |
apetushkov@9858 | 141 | |
apetushkov@9858 | 142 | traceid JfrSymbolId::mark(const Symbol* symbol) { |
apetushkov@9858 | 143 | assert(symbol != NULL, "invariant"); |
apetushkov@9858 | 144 | return mark(symbol, (uintptr_t)const_cast<Symbol*>(symbol)->identity_hash()); |
apetushkov@9858 | 145 | } |
apetushkov@9858 | 146 | |
apetushkov@9858 | 147 | traceid JfrSymbolId::mark(const Symbol* data, uintptr_t hash) { |
apetushkov@9858 | 148 | assert(data != NULL, "invariant"); |
apetushkov@9858 | 149 | assert(_sym_table != NULL, "invariant"); |
apetushkov@9858 | 150 | return _sym_table->id(data, hash); |
apetushkov@9858 | 151 | } |
apetushkov@9858 | 152 | |
apetushkov@9858 | 153 | traceid JfrSymbolId::mark(const char* str, uintptr_t hash) { |
apetushkov@9858 | 154 | assert(str != NULL, "invariant"); |
apetushkov@9858 | 155 | return _cstring_table->id(str, hash); |
apetushkov@9858 | 156 | } |
apetushkov@9858 | 157 | |
apetushkov@9926 | 158 | traceid JfrSymbolId::markPackage(const char* name, uintptr_t hash) { |
apetushkov@9926 | 159 | assert(name != NULL, "invariant"); |
apetushkov@9926 | 160 | assert(_pkg_table != NULL, "invariant"); |
apetushkov@9926 | 161 | return _pkg_table->id(name, hash); |
apetushkov@9926 | 162 | } |
apetushkov@9926 | 163 | |
apetushkov@9858 | 164 | bool JfrSymbolId::is_anonymous_klass(const Klass* k) { |
apetushkov@9858 | 165 | assert(k != NULL, "invariant"); |
apetushkov@9858 | 166 | return k->oop_is_instance() && ((const InstanceKlass*)k)->is_anonymous(); |
apetushkov@9858 | 167 | } |
apetushkov@9858 | 168 | |
apetushkov@9858 | 169 | /* |
apetushkov@9858 | 170 | * jsr292 anonymous classes symbol is the external name + |
apetushkov@9858 | 171 | * the identity_hashcode slash appended: |
apetushkov@9858 | 172 | * java.lang.invoke.LambdaForm$BMH/22626602 |
apetushkov@9858 | 173 | * |
apetushkov@9858 | 174 | * caller needs ResourceMark |
apetushkov@9858 | 175 | */ |
apetushkov@9858 | 176 | |
apetushkov@9858 | 177 | uintptr_t JfrSymbolId::anonymous_klass_name_hash_code(const InstanceKlass* ik) { |
apetushkov@9858 | 178 | assert(ik != NULL, "invariant"); |
apetushkov@9858 | 179 | assert(ik->is_anonymous(), "invariant"); |
apetushkov@9858 | 180 | const oop mirror = ik->java_mirror(); |
apetushkov@9858 | 181 | assert(mirror != NULL, "invariant"); |
apetushkov@9858 | 182 | return (uintptr_t)mirror->identity_hash(); |
apetushkov@9858 | 183 | } |
apetushkov@9858 | 184 | |
apetushkov@9858 | 185 | const char* JfrSymbolId::create_anonymous_klass_symbol(const InstanceKlass* ik, uintptr_t& hashcode) { |
apetushkov@9858 | 186 | assert(ik != NULL, "invariant"); |
apetushkov@9858 | 187 | assert(ik->is_anonymous(), "invariant"); |
apetushkov@9858 | 188 | assert(0 == hashcode, "invariant"); |
apetushkov@9858 | 189 | char* anonymous_symbol = NULL; |
apetushkov@9858 | 190 | const oop mirror = ik->java_mirror(); |
apetushkov@9858 | 191 | assert(mirror != NULL, "invariant"); |
apetushkov@9858 | 192 | char hash_buf[40]; |
apetushkov@9858 | 193 | hashcode = anonymous_klass_name_hash_code(ik); |
apetushkov@9858 | 194 | sprintf(hash_buf, "/" UINTX_FORMAT, hashcode); |
apetushkov@9858 | 195 | const size_t hash_len = strlen(hash_buf); |
apetushkov@9858 | 196 | const size_t result_len = ik->name()->utf8_length(); |
apetushkov@9858 | 197 | anonymous_symbol = NEW_RESOURCE_ARRAY(char, result_len + hash_len + 1); |
apetushkov@9858 | 198 | ik->name()->as_klass_external_name(anonymous_symbol, (int)result_len + 1); |
apetushkov@9858 | 199 | assert(strlen(anonymous_symbol) == result_len, "invariant"); |
apetushkov@9858 | 200 | strcpy(anonymous_symbol + result_len, hash_buf); |
apetushkov@9858 | 201 | assert(strlen(anonymous_symbol) == result_len + hash_len, "invariant"); |
apetushkov@9858 | 202 | return anonymous_symbol; |
apetushkov@9858 | 203 | } |
apetushkov@9858 | 204 | |
apetushkov@9858 | 205 | uintptr_t JfrSymbolId::regular_klass_name_hash_code(const Klass* k) { |
apetushkov@9858 | 206 | assert(k != NULL, "invariant"); |
apetushkov@9858 | 207 | const Symbol* const sym = k->name(); |
apetushkov@9858 | 208 | assert(sym != NULL, "invariant"); |
apetushkov@9858 | 209 | return (uintptr_t)const_cast<Symbol*>(sym)->identity_hash(); |
apetushkov@9858 | 210 | } |
apetushkov@9858 | 211 | |
apetushkov@9858 | 212 | JfrArtifactSet::JfrArtifactSet(bool class_unload) : _symbol_id(new JfrSymbolId()), |
apetushkov@9858 | 213 | _klass_list(NULL), |
apetushkov@9858 | 214 | _class_unload(class_unload) { |
apetushkov@9858 | 215 | initialize(class_unload); |
apetushkov@9858 | 216 | assert(_klass_list != NULL, "invariant"); |
apetushkov@9858 | 217 | } |
apetushkov@9858 | 218 | |
apetushkov@9858 | 219 | static const size_t initial_class_list_size = 200; |
apetushkov@9858 | 220 | void JfrArtifactSet::initialize(bool class_unload) { |
apetushkov@9858 | 221 | assert(_symbol_id != NULL, "invariant"); |
apetushkov@9858 | 222 | _symbol_id->initialize(); |
apetushkov@9858 | 223 | assert(!_symbol_id->has_entries(), "invariant"); |
apetushkov@9858 | 224 | _symbol_id->mark(BOOTSTRAP_LOADER_NAME, 0); // pre-load "bootstrap" |
apetushkov@9858 | 225 | _class_unload = class_unload; |
apetushkov@9858 | 226 | // resource allocation |
apetushkov@9858 | 227 | _klass_list = new GrowableArray<const Klass*>(initial_class_list_size, false, mtTracing); |
apetushkov@9858 | 228 | } |
apetushkov@9858 | 229 | |
apetushkov@9858 | 230 | JfrArtifactSet::~JfrArtifactSet() { |
apetushkov@9858 | 231 | clear(); |
apetushkov@9858 | 232 | } |
apetushkov@9858 | 233 | |
apetushkov@9858 | 234 | void JfrArtifactSet::clear() { |
apetushkov@9858 | 235 | _symbol_id->clear(); |
apetushkov@9858 | 236 | // _klass_list will be cleared by a ResourceMark |
apetushkov@9858 | 237 | } |
apetushkov@9858 | 238 | |
apetushkov@9858 | 239 | traceid JfrArtifactSet::mark_anonymous_klass_name(const Klass* klass) { |
apetushkov@9858 | 240 | return _symbol_id->mark_anonymous_klass_name(klass); |
apetushkov@9858 | 241 | } |
apetushkov@9858 | 242 | |
apetushkov@9858 | 243 | traceid JfrArtifactSet::mark(const Symbol* sym, uintptr_t hash) { |
apetushkov@9858 | 244 | return _symbol_id->mark(sym, hash); |
apetushkov@9858 | 245 | } |
apetushkov@9858 | 246 | |
apetushkov@9858 | 247 | traceid JfrArtifactSet::mark(const Klass* klass) { |
apetushkov@9858 | 248 | return _symbol_id->mark(klass); |
apetushkov@9858 | 249 | } |
apetushkov@9858 | 250 | |
apetushkov@9858 | 251 | traceid JfrArtifactSet::mark(const Symbol* symbol) { |
apetushkov@9858 | 252 | return _symbol_id->mark(symbol); |
apetushkov@9858 | 253 | } |
apetushkov@9858 | 254 | |
apetushkov@9858 | 255 | traceid JfrArtifactSet::mark(const char* const str, uintptr_t hash) { |
apetushkov@9858 | 256 | return _symbol_id->mark(str, hash); |
apetushkov@9858 | 257 | } |
apetushkov@9858 | 258 | |
apetushkov@9926 | 259 | traceid JfrArtifactSet::markPackage(const char* const name, uintptr_t hash) { |
apetushkov@9926 | 260 | return _symbol_id->markPackage(name, hash); |
apetushkov@9926 | 261 | } |
apetushkov@9926 | 262 | |
apetushkov@9858 | 263 | const JfrSymbolId::SymbolEntry* JfrArtifactSet::map_symbol(const Symbol* symbol) const { |
apetushkov@9858 | 264 | return _symbol_id->map_symbol(symbol); |
apetushkov@9858 | 265 | } |
apetushkov@9858 | 266 | |
apetushkov@9858 | 267 | const JfrSymbolId::SymbolEntry* JfrArtifactSet::map_symbol(uintptr_t hash) const { |
apetushkov@9858 | 268 | return _symbol_id->map_symbol(hash); |
apetushkov@9858 | 269 | } |
apetushkov@9858 | 270 | |
apetushkov@9858 | 271 | const JfrSymbolId::CStringEntry* JfrArtifactSet::map_cstring(uintptr_t hash) const { |
apetushkov@9858 | 272 | return _symbol_id->map_cstring(hash); |
apetushkov@9858 | 273 | } |
apetushkov@9858 | 274 | |
apetushkov@9858 | 275 | bool JfrArtifactSet::has_klass_entries() const { |
apetushkov@9858 | 276 | return _klass_list->is_nonempty(); |
apetushkov@9858 | 277 | } |
apetushkov@9858 | 278 | |
apetushkov@9858 | 279 | int JfrArtifactSet::entries() const { |
apetushkov@9858 | 280 | return _klass_list->length(); |
apetushkov@9858 | 281 | } |
apetushkov@9858 | 282 | |
apetushkov@9858 | 283 | void JfrArtifactSet::register_klass(const Klass* k) { |
apetushkov@9858 | 284 | assert(k != NULL, "invariant"); |
apetushkov@9858 | 285 | assert(_klass_list != NULL, "invariant"); |
apetushkov@9858 | 286 | assert(_klass_list->find(k) == -1, "invariant"); |
apetushkov@9858 | 287 | _klass_list->append(k); |
apetushkov@9858 | 288 | } |