src/share/vm/utilities/hashtable.cpp

Wed, 04 Jul 2012 15:55:45 -0400

author
coleenp
date
Wed, 04 Jul 2012 15:55:45 -0400
changeset 3904
ace99a6ffc83
parent 3900
d2a62e0f25eb
child 3963
5e2dc722e70d
permissions
-rw-r--r--

7181200: JVM new hashing code breaks SA in product mode
Summary: Made new_hash() overloaded rather than a virtual function so SA code doesn't need to be changed.
Reviewed-by: kvn, acorn, dholmes, fparain

duke@435 1 /*
coleenp@3865 2 * Copyright (c) 2003, 2012, Oracle and/or its affiliates. All rights reserved.
duke@435 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@435 4 *
duke@435 5 * This code is free software; you can redistribute it and/or modify it
duke@435 6 * under the terms of the GNU General Public License version 2 only, as
duke@435 7 * published by the Free Software Foundation.
duke@435 8 *
duke@435 9 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@435 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@435 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@435 12 * version 2 for more details (a copy is included in the LICENSE file that
duke@435 13 * accompanied this code).
duke@435 14 *
duke@435 15 * You should have received a copy of the GNU General Public License version
duke@435 16 * 2 along with this work; if not, write to the Free Software Foundation,
duke@435 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@435 18 *
trims@1907 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
trims@1907 20 * or visit www.oracle.com if you need additional information or have any
trims@1907 21 * questions.
duke@435 22 *
duke@435 23 */
duke@435 24
stefank@2314 25 #include "precompiled.hpp"
coleenp@3904 26 #include "classfile/altHashing.hpp"
coleenp@3904 27 #include "classfile/javaClasses.hpp"
stefank@2314 28 #include "memory/allocation.inline.hpp"
coleenp@3875 29 #include "memory/filemap.hpp"
stefank@2314 30 #include "memory/resourceArea.hpp"
stefank@2314 31 #include "oops/oop.inline.hpp"
stefank@2314 32 #include "runtime/safepoint.hpp"
stefank@2314 33 #include "utilities/dtrace.hpp"
stefank@2314 34 #include "utilities/hashtable.hpp"
stefank@2314 35 #include "utilities/hashtable.inline.hpp"
duke@435 36
coleenp@2497 37
duke@435 38 // This is a generic hashtable, designed to be used for the symbol
duke@435 39 // and string tables.
duke@435 40 //
duke@435 41 // It is implemented as an open hash table with a fixed number of buckets.
duke@435 42 //
duke@435 43 // %note:
duke@435 44 // - HashtableEntrys are allocated in blocks to reduce the space overhead.
duke@435 45
zgu@3900 46 template <MEMFLAGS F> BasicHashtableEntry<F>* BasicHashtable<F>::new_entry(unsigned int hashValue) {
zgu@3900 47 BasicHashtableEntry<F>* entry;
duke@435 48
duke@435 49 if (_free_list) {
duke@435 50 entry = _free_list;
duke@435 51 _free_list = _free_list->next();
duke@435 52 } else {
jrose@867 53 if (_first_free_entry + _entry_size >= _end_block) {
jrose@867 54 int block_size = MIN2(512, MAX2((int)_table_size / 2, (int)_number_of_entries));
duke@435 55 int len = _entry_size * block_size;
jrose@867 56 len = 1 << log2_intptr(len); // round down to power of 2
jrose@867 57 assert(len >= _entry_size, "");
zgu@3900 58 _first_free_entry = NEW_C_HEAP_ARRAY2(char, len, F, CURRENT_PC);
duke@435 59 _end_block = _first_free_entry + len;
duke@435 60 }
zgu@3900 61 entry = (BasicHashtableEntry<F>*)_first_free_entry;
duke@435 62 _first_free_entry += _entry_size;
duke@435 63 }
duke@435 64
jrose@867 65 assert(_entry_size % HeapWordSize == 0, "");
duke@435 66 entry->set_hash(hashValue);
duke@435 67 return entry;
duke@435 68 }
duke@435 69
duke@435 70
zgu@3900 71 template <class T, MEMFLAGS F> HashtableEntry<T, F>* Hashtable<T, F>::new_entry(unsigned int hashValue, T obj) {
zgu@3900 72 HashtableEntry<T, F>* entry;
duke@435 73
zgu@3900 74 entry = (HashtableEntry<T, F>*)BasicHashtable<F>::new_entry(hashValue);
coleenp@2497 75 entry->set_literal(obj);
duke@435 76 return entry;
duke@435 77 }
duke@435 78
coleenp@3865 79 // Check to see if the hashtable is unbalanced. The caller set a flag to
coleenp@3865 80 // rehash at the next safepoint. If this bucket is 60 times greater than the
coleenp@3865 81 // expected average bucket length, it's an unbalanced hashtable.
coleenp@3865 82 // This is somewhat an arbitrary heuristic but if one bucket gets to
coleenp@3865 83 // rehash_count which is currently 100, there's probably something wrong.
coleenp@3865 84
zgu@3900 85 template <MEMFLAGS F> bool BasicHashtable<F>::check_rehash_table(int count) {
coleenp@3865 86 assert(table_size() != 0, "underflow");
coleenp@3865 87 if (count > (((double)number_of_entries()/(double)table_size())*rehash_multiple)) {
coleenp@3865 88 // Set a flag for the next safepoint, which should be at some guaranteed
coleenp@3865 89 // safepoint interval.
coleenp@3865 90 return true;
coleenp@3865 91 }
coleenp@3865 92 return false;
coleenp@3865 93 }
coleenp@3865 94
coleenp@3904 95 template <class T, MEMFLAGS F> jint Hashtable<T, F>::_seed = 0;
coleenp@3904 96
coleenp@3904 97 template <class T, MEMFLAGS F> unsigned int Hashtable<T, F>::new_hash(Symbol* sym) {
coleenp@3904 98 ResourceMark rm;
coleenp@3904 99 // Use alternate hashing algorithm on this symbol.
coleenp@3904 100 return AltHashing::murmur3_32(seed(), (const jbyte*)sym->as_C_string(), sym->utf8_length());
coleenp@3904 101 }
coleenp@3904 102
coleenp@3904 103 template <class T, MEMFLAGS F> unsigned int Hashtable<T, F>::new_hash(oop string) {
coleenp@3904 104 ResourceMark rm;
coleenp@3904 105 int length;
coleenp@3904 106 jchar* chars = java_lang_String::as_unicode_string(string, length);
coleenp@3904 107 // Use alternate hashing algorithm on the string
coleenp@3904 108 return AltHashing::murmur3_32(seed(), chars, length);
coleenp@3904 109 }
coleenp@3904 110
coleenp@3865 111 // Create a new table and using alternate hash code, populate the new table
coleenp@3865 112 // with the existing elements. This can be used to change the hash code
coleenp@3865 113 // and could in the future change the size of the table.
coleenp@3865 114
zgu@3900 115 template <class T, MEMFLAGS F> void Hashtable<T, F>::move_to(Hashtable<T, F>* new_table) {
coleenp@3904 116
coleenp@3904 117 // Initialize the global seed for hashing.
coleenp@3904 118 _seed = AltHashing::compute_seed();
coleenp@3904 119 assert(seed() != 0, "shouldn't be zero");
coleenp@3904 120
coleenp@3904 121 int saved_entry_count = this->number_of_entries();
coleenp@3865 122
coleenp@3865 123 // Iterate through the table and create a new entry for the new table
coleenp@3865 124 for (int i = 0; i < new_table->table_size(); ++i) {
zgu@3900 125 for (HashtableEntry<T, F>* p = bucket(i); p != NULL; ) {
zgu@3900 126 HashtableEntry<T, F>* next = p->next();
coleenp@3865 127 T string = p->literal();
coleenp@3865 128 // Use alternate hashing algorithm on the symbol in the first table
coleenp@3865 129 unsigned int hashValue = new_hash(string);
coleenp@3865 130 // Get a new index relative to the new table (can also change size)
coleenp@3865 131 int index = new_table->hash_to_index(hashValue);
coleenp@3865 132 p->set_hash(hashValue);
coleenp@3875 133 // Keep the shared bit in the Hashtable entry to indicate that this entry
coleenp@3875 134 // can't be deleted. The shared bit is the LSB in the _next field so
coleenp@3875 135 // walking the hashtable past these entries requires
coleenp@3875 136 // BasicHashtableEntry::make_ptr() call.
coleenp@3875 137 bool keep_shared = p->is_shared();
coleenp@3865 138 unlink_entry(p);
coleenp@3865 139 new_table->add_entry(index, p);
coleenp@3875 140 if (keep_shared) {
coleenp@3875 141 p->set_shared();
coleenp@3875 142 }
coleenp@3865 143 p = next;
coleenp@3865 144 }
coleenp@3865 145 }
coleenp@3865 146 // give the new table the free list as well
coleenp@3865 147 new_table->copy_freelist(this);
coleenp@3865 148 assert(new_table->number_of_entries() == saved_entry_count, "lost entry on dictionary copy?");
coleenp@3865 149
coleenp@3865 150 // Destroy memory used by the buckets in the hashtable. The memory
coleenp@3865 151 // for the elements has been used in a new table and is not
coleenp@3865 152 // destroyed. The memory reuse will benefit resizing the SystemDictionary
coleenp@3865 153 // to avoid a memory allocation spike at safepoint.
zgu@3900 154 BasicHashtable<F>::free_buckets();
coleenp@3865 155 }
coleenp@3865 156
zgu@3900 157 template <MEMFLAGS F> void BasicHashtable<F>::free_buckets() {
coleenp@3875 158 if (NULL != _buckets) {
coleenp@3875 159 // Don't delete the buckets in the shared space. They aren't
coleenp@3875 160 // allocated by os::malloc
coleenp@3875 161 if (!UseSharedSpaces ||
coleenp@3875 162 !FileMapInfo::current_info()->is_in_shared_space(_buckets)) {
zgu@3900 163 FREE_C_HEAP_ARRAY(HashtableBucket, _buckets, F);
coleenp@3875 164 }
coleenp@3875 165 _buckets = NULL;
coleenp@3875 166 }
coleenp@3875 167 }
coleenp@3875 168
coleenp@3875 169
duke@435 170 // Reverse the order of elements in the hash buckets.
duke@435 171
zgu@3900 172 template <MEMFLAGS F> void BasicHashtable<F>::reverse() {
duke@435 173
duke@435 174 for (int i = 0; i < _table_size; ++i) {
zgu@3900 175 BasicHashtableEntry<F>* new_list = NULL;
zgu@3900 176 BasicHashtableEntry<F>* p = bucket(i);
duke@435 177 while (p != NULL) {
zgu@3900 178 BasicHashtableEntry<F>* next = p->next();
duke@435 179 p->set_next(new_list);
duke@435 180 new_list = p;
duke@435 181 p = next;
duke@435 182 }
duke@435 183 *bucket_addr(i) = new_list;
duke@435 184 }
duke@435 185 }
duke@435 186
duke@435 187
duke@435 188 // Copy the table to the shared space.
duke@435 189
zgu@3900 190 template <MEMFLAGS F> void BasicHashtable<F>::copy_table(char** top, char* end) {
duke@435 191
duke@435 192 // Dump the hash table entries.
duke@435 193
duke@435 194 intptr_t *plen = (intptr_t*)(*top);
duke@435 195 *top += sizeof(*plen);
duke@435 196
duke@435 197 int i;
duke@435 198 for (i = 0; i < _table_size; ++i) {
zgu@3900 199 for (BasicHashtableEntry<F>** p = _buckets[i].entry_addr();
duke@435 200 *p != NULL;
duke@435 201 p = (*p)->next_addr()) {
duke@435 202 if (*top + entry_size() > end) {
coleenp@2497 203 report_out_of_shared_space(SharedMiscData);
duke@435 204 }
zgu@3900 205 *p = (BasicHashtableEntry<F>*)memcpy(*top, *p, entry_size());
duke@435 206 *top += entry_size();
duke@435 207 }
duke@435 208 }
duke@435 209 *plen = (char*)(*top) - (char*)plen - sizeof(*plen);
duke@435 210
duke@435 211 // Set the shared bit.
duke@435 212
duke@435 213 for (i = 0; i < _table_size; ++i) {
zgu@3900 214 for (BasicHashtableEntry<F>* p = bucket(i); p != NULL; p = p->next()) {
duke@435 215 p->set_shared();
duke@435 216 }
duke@435 217 }
duke@435 218 }
duke@435 219
duke@435 220
duke@435 221
duke@435 222 // Reverse the order of elements in the hash buckets.
duke@435 223
zgu@3900 224 template <class T, MEMFLAGS F> void Hashtable<T, F>::reverse(void* boundary) {
duke@435 225
zgu@3900 226 for (int i = 0; i < this->table_size(); ++i) {
zgu@3900 227 HashtableEntry<T, F>* high_list = NULL;
zgu@3900 228 HashtableEntry<T, F>* low_list = NULL;
zgu@3900 229 HashtableEntry<T, F>* last_low_entry = NULL;
zgu@3900 230 HashtableEntry<T, F>* p = bucket(i);
duke@435 231 while (p != NULL) {
zgu@3900 232 HashtableEntry<T, F>* next = p->next();
duke@435 233 if ((void*)p->literal() >= boundary) {
duke@435 234 p->set_next(high_list);
duke@435 235 high_list = p;
duke@435 236 } else {
duke@435 237 p->set_next(low_list);
duke@435 238 low_list = p;
duke@435 239 if (last_low_entry == NULL) {
duke@435 240 last_low_entry = p;
duke@435 241 }
duke@435 242 }
duke@435 243 p = next;
duke@435 244 }
duke@435 245 if (low_list != NULL) {
duke@435 246 *bucket_addr(i) = low_list;
duke@435 247 last_low_entry->set_next(high_list);
duke@435 248 } else {
duke@435 249 *bucket_addr(i) = high_list;
duke@435 250 }
duke@435 251 }
duke@435 252 }
duke@435 253
duke@435 254
duke@435 255 // Dump the hash table buckets.
duke@435 256
zgu@3900 257 template <MEMFLAGS F> void BasicHashtable<F>::copy_buckets(char** top, char* end) {
zgu@3900 258 intptr_t len = _table_size * sizeof(HashtableBucket<F>);
duke@435 259 *(intptr_t*)(*top) = len;
duke@435 260 *top += sizeof(intptr_t);
duke@435 261
duke@435 262 *(intptr_t*)(*top) = _number_of_entries;
duke@435 263 *top += sizeof(intptr_t);
duke@435 264
duke@435 265 if (*top + len > end) {
coleenp@2497 266 report_out_of_shared_space(SharedMiscData);
duke@435 267 }
zgu@3900 268 _buckets = (HashtableBucket<F>*)memcpy(*top, _buckets, len);
duke@435 269 *top += len;
duke@435 270 }
duke@435 271
duke@435 272
duke@435 273 #ifndef PRODUCT
duke@435 274
zgu@3900 275 template <class T, MEMFLAGS F> void Hashtable<T, F>::print() {
duke@435 276 ResourceMark rm;
duke@435 277
zgu@3900 278 for (int i = 0; i < BasicHashtable<F>::table_size(); i++) {
zgu@3900 279 HashtableEntry<T, F>* entry = bucket(i);
duke@435 280 while(entry != NULL) {
duke@435 281 tty->print("%d : ", i);
duke@435 282 entry->literal()->print();
duke@435 283 tty->cr();
duke@435 284 entry = entry->next();
duke@435 285 }
duke@435 286 }
duke@435 287 }
duke@435 288
duke@435 289
zgu@3900 290 template <MEMFLAGS F> void BasicHashtable<F>::verify() {
duke@435 291 int count = 0;
duke@435 292 for (int i = 0; i < table_size(); i++) {
zgu@3900 293 for (BasicHashtableEntry<F>* p = bucket(i); p != NULL; p = p->next()) {
duke@435 294 ++count;
duke@435 295 }
duke@435 296 }
duke@435 297 assert(count == number_of_entries(), "number of hashtable entries incorrect");
duke@435 298 }
duke@435 299
duke@435 300
duke@435 301 #endif // PRODUCT
duke@435 302
duke@435 303
duke@435 304 #ifdef ASSERT
duke@435 305
zgu@3900 306 template <MEMFLAGS F> void BasicHashtable<F>::verify_lookup_length(double load) {
duke@435 307 if ((double)_lookup_length / (double)_lookup_count > load * 2.0) {
duke@435 308 warning("Performance bug: SystemDictionary lookup_count=%d "
duke@435 309 "lookup_length=%d average=%lf load=%f",
duke@435 310 _lookup_count, _lookup_length,
duke@435 311 (double) _lookup_length / _lookup_count, load);
duke@435 312 }
duke@435 313 }
duke@435 314
duke@435 315 #endif
coleenp@2497 316 // Explicitly instantiate these types
zgu@3900 317 template class Hashtable<constantPoolOop, mtClass>;
zgu@3900 318 template class Hashtable<Symbol*, mtSymbol>;
zgu@3900 319 template class Hashtable<klassOop, mtClass>;
zgu@3900 320 template class Hashtable<oop, mtClass>;
zgu@3900 321 #ifdef SOLARIS
zgu@3900 322 template class Hashtable<oop, mtSymbol>;
zgu@3900 323 #endif
zgu@3900 324 template class Hashtable<oopDesc*, mtSymbol>;
zgu@3900 325 template class Hashtable<Symbol*, mtClass>;
zgu@3900 326 template class HashtableEntry<Symbol*, mtSymbol>;
zgu@3900 327 template class HashtableEntry<Symbol*, mtClass>;
zgu@3900 328 template class HashtableEntry<oop, mtSymbol>;
zgu@3900 329 template class BasicHashtableEntry<mtSymbol>;
zgu@3900 330 template class BasicHashtableEntry<mtCode>;
zgu@3900 331 template class BasicHashtable<mtClass>;
zgu@3900 332 template class BasicHashtable<mtSymbol>;
zgu@3900 333 template class BasicHashtable<mtCode>;
zgu@3900 334 template class BasicHashtable<mtInternal>;

mercurial