Wed, 31 Jul 2019 14:28:51 -0400
8048556: Unnecessary GCLocker-initiated young GCs
Summary: Fixed recognition of unnecessary GCLocker collections.
Reviewed-by: pliden, tschatzl
Contributed-by: johnc@azul.com
duke@435 | 1 | /* |
mlarsson@7686 | 2 | * Copyright (c) 2007, 2015, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
stefank@2314 | 25 | #include "precompiled.hpp" |
stefank@2314 | 26 | #include "gc_implementation/parallelScavenge/parallelScavengeHeap.inline.hpp" |
stefank@2314 | 27 | #include "gc_implementation/parallelScavenge/psMarkSweep.hpp" |
stefank@2314 | 28 | #include "gc_implementation/parallelScavenge/psScavenge.hpp" |
stefank@2314 | 29 | #include "gc_implementation/parallelScavenge/psScavenge.inline.hpp" |
stefank@2314 | 30 | #include "gc_implementation/parallelScavenge/vmPSOperations.hpp" |
stefank@2314 | 31 | #include "memory/gcLocker.inline.hpp" |
stefank@2314 | 32 | #include "utilities/dtrace.hpp" |
duke@435 | 33 | |
duke@435 | 34 | // The following methods are used by the parallel scavenge collector |
mlarsson@7687 | 35 | VM_ParallelGCFailedAllocation::VM_ParallelGCFailedAllocation(size_t word_size, |
mlarsson@7686 | 36 | uint gc_count) : |
mlarsson@7687 | 37 | VM_CollectForAllocation(word_size, gc_count, GCCause::_allocation_failure) { |
mlarsson@7687 | 38 | assert(word_size != 0, "An allocation should always be requested with this operation."); |
duke@435 | 39 | } |
duke@435 | 40 | |
duke@435 | 41 | void VM_ParallelGCFailedAllocation::doit() { |
kamg@2445 | 42 | SvcGCMarker sgcm(SvcGCMarker::MINOR); |
duke@435 | 43 | |
duke@435 | 44 | ParallelScavengeHeap* heap = (ParallelScavengeHeap*)Universe::heap(); |
duke@435 | 45 | assert(heap->kind() == CollectedHeap::ParallelScavengeHeap, "must be a ParallelScavengeHeap"); |
duke@435 | 46 | |
duke@435 | 47 | GCCauseSetter gccs(heap, _gc_cause); |
mlarsson@7687 | 48 | _result = heap->failed_mem_allocate(_word_size); |
duke@435 | 49 | |
duke@435 | 50 | if (_result == NULL && GC_locker::is_active_and_needs_gc()) { |
duke@435 | 51 | set_gc_locked(); |
duke@435 | 52 | } |
duke@435 | 53 | } |
duke@435 | 54 | |
kbarrett@9787 | 55 | static bool is_cause_full(GCCause::Cause cause) { |
kbarrett@9787 | 56 | return (cause != GCCause::_gc_locker) && (cause != GCCause::_wb_young_gc) |
kbarrett@9787 | 57 | DEBUG_ONLY(&& (cause != GCCause::_scavenge_alot)); |
kbarrett@9787 | 58 | } |
kbarrett@9787 | 59 | |
duke@435 | 60 | // Only used for System.gc() calls |
mlarsson@7686 | 61 | VM_ParallelGCSystemGC::VM_ParallelGCSystemGC(uint gc_count, |
mlarsson@7686 | 62 | uint full_gc_count, |
duke@435 | 63 | GCCause::Cause gc_cause) : |
kbarrett@9787 | 64 | VM_GC_Operation(gc_count, gc_cause, full_gc_count, is_cause_full(gc_cause)) |
duke@435 | 65 | { |
duke@435 | 66 | } |
duke@435 | 67 | |
duke@435 | 68 | void VM_ParallelGCSystemGC::doit() { |
kamg@2445 | 69 | SvcGCMarker sgcm(SvcGCMarker::FULL); |
duke@435 | 70 | |
duke@435 | 71 | ParallelScavengeHeap* heap = (ParallelScavengeHeap*)Universe::heap(); |
duke@435 | 72 | assert(heap->kind() == CollectedHeap::ParallelScavengeHeap, |
duke@435 | 73 | "must be a ParallelScavengeHeap"); |
duke@435 | 74 | |
duke@435 | 75 | GCCauseSetter gccs(heap, _gc_cause); |
kbarrett@9787 | 76 | if (!_full) { |
duke@435 | 77 | // If (and only if) the scavenge fails, this will invoke a full gc. |
duke@435 | 78 | heap->invoke_scavenge(); |
duke@435 | 79 | } else { |
coleenp@4037 | 80 | heap->do_full_collection(false); |
duke@435 | 81 | } |
duke@435 | 82 | } |