src/share/vm/opto/ifnode.cpp

Fri, 27 Feb 2009 13:27:09 -0800

author
twisti
date
Fri, 27 Feb 2009 13:27:09 -0800
changeset 1040
98cb887364d3
parent 772
9ee9cf798b59
child 1286
fc4be448891f
permissions
-rw-r--r--

6810672: Comment typos
Summary: I have collected some typos I have found while looking at the code.
Reviewed-by: kvn, never

duke@435 1 /*
xdono@772 2 * Copyright 2000-2008 Sun Microsystems, Inc. All Rights Reserved.
duke@435 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@435 4 *
duke@435 5 * This code is free software; you can redistribute it and/or modify it
duke@435 6 * under the terms of the GNU General Public License version 2 only, as
duke@435 7 * published by the Free Software Foundation.
duke@435 8 *
duke@435 9 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@435 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@435 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@435 12 * version 2 for more details (a copy is included in the LICENSE file that
duke@435 13 * accompanied this code).
duke@435 14 *
duke@435 15 * You should have received a copy of the GNU General Public License version
duke@435 16 * 2 along with this work; if not, write to the Free Software Foundation,
duke@435 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@435 18 *
duke@435 19 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
duke@435 20 * CA 95054 USA or visit www.sun.com if you need additional information or
duke@435 21 * have any questions.
duke@435 22 *
duke@435 23 */
duke@435 24
duke@435 25 // Portions of code courtesy of Clifford Click
duke@435 26
duke@435 27 // Optimization - Graph Style
duke@435 28
duke@435 29 #include "incls/_precompiled.incl"
duke@435 30 #include "incls/_ifnode.cpp.incl"
duke@435 31
duke@435 32
duke@435 33 extern int explicit_null_checks_elided;
duke@435 34
duke@435 35 //=============================================================================
duke@435 36 //------------------------------Value------------------------------------------
duke@435 37 // Return a tuple for whichever arm of the IF is reachable
duke@435 38 const Type *IfNode::Value( PhaseTransform *phase ) const {
duke@435 39 if( !in(0) ) return Type::TOP;
duke@435 40 if( phase->type(in(0)) == Type::TOP )
duke@435 41 return Type::TOP;
duke@435 42 const Type *t = phase->type(in(1));
duke@435 43 if( t == Type::TOP ) // data is undefined
duke@435 44 return TypeTuple::IFNEITHER; // unreachable altogether
duke@435 45 if( t == TypeInt::ZERO ) // zero, or false
duke@435 46 return TypeTuple::IFFALSE; // only false branch is reachable
duke@435 47 if( t == TypeInt::ONE ) // 1, or true
duke@435 48 return TypeTuple::IFTRUE; // only true branch is reachable
duke@435 49 assert( t == TypeInt::BOOL, "expected boolean type" );
duke@435 50
duke@435 51 return TypeTuple::IFBOTH; // No progress
duke@435 52 }
duke@435 53
duke@435 54 const RegMask &IfNode::out_RegMask() const {
duke@435 55 return RegMask::Empty;
duke@435 56 }
duke@435 57
duke@435 58 //------------------------------split_if---------------------------------------
duke@435 59 // Look for places where we merge constants, then test on the merged value.
duke@435 60 // If the IF test will be constant folded on the path with the constant, we
duke@435 61 // win by splitting the IF to before the merge point.
duke@435 62 static Node* split_if(IfNode *iff, PhaseIterGVN *igvn) {
duke@435 63 // I could be a lot more general here, but I'm trying to squeeze this
duke@435 64 // in before the Christmas '98 break so I'm gonna be kinda restrictive
duke@435 65 // on the patterns I accept. CNC
duke@435 66
duke@435 67 // Look for a compare of a constant and a merged value
duke@435 68 Node *i1 = iff->in(1);
duke@435 69 if( !i1->is_Bool() ) return NULL;
duke@435 70 BoolNode *b = i1->as_Bool();
duke@435 71 Node *cmp = b->in(1);
duke@435 72 if( !cmp->is_Cmp() ) return NULL;
duke@435 73 i1 = cmp->in(1);
duke@435 74 if( i1 == NULL || !i1->is_Phi() ) return NULL;
duke@435 75 PhiNode *phi = i1->as_Phi();
duke@435 76 if( phi->is_copy() ) return NULL;
duke@435 77 Node *con2 = cmp->in(2);
duke@435 78 if( !con2->is_Con() ) return NULL;
duke@435 79 // See that the merge point contains some constants
duke@435 80 Node *con1=NULL;
duke@435 81 uint i4;
duke@435 82 for( i4 = 1; i4 < phi->req(); i4++ ) {
duke@435 83 con1 = phi->in(i4);
twisti@1040 84 if( !con1 ) return NULL; // Do not optimize partially collapsed merges
duke@435 85 if( con1->is_Con() ) break; // Found a constant
duke@435 86 // Also allow null-vs-not-null checks
duke@435 87 const TypePtr *tp = igvn->type(con1)->isa_ptr();
duke@435 88 if( tp && tp->_ptr == TypePtr::NotNull )
duke@435 89 break;
duke@435 90 }
duke@435 91 if( i4 >= phi->req() ) return NULL; // Found no constants
duke@435 92
duke@435 93 igvn->C->set_has_split_ifs(true); // Has chance for split-if
duke@435 94
duke@435 95 // Make sure that the compare can be constant folded away
duke@435 96 Node *cmp2 = cmp->clone();
duke@435 97 cmp2->set_req(1,con1);
duke@435 98 cmp2->set_req(2,con2);
duke@435 99 const Type *t = cmp2->Value(igvn);
duke@435 100 // This compare is dead, so whack it!
duke@435 101 igvn->remove_dead_node(cmp2);
duke@435 102 if( !t->singleton() ) return NULL;
duke@435 103
duke@435 104 // No intervening control, like a simple Call
duke@435 105 Node *r = iff->in(0);
duke@435 106 if( !r->is_Region() ) return NULL;
duke@435 107 if( phi->region() != r ) return NULL;
duke@435 108 // No other users of the cmp/bool
duke@435 109 if (b->outcnt() != 1 || cmp->outcnt() != 1) {
duke@435 110 //tty->print_cr("many users of cmp/bool");
duke@435 111 return NULL;
duke@435 112 }
duke@435 113
duke@435 114 // Make sure we can determine where all the uses of merged values go
duke@435 115 for (DUIterator_Fast jmax, j = r->fast_outs(jmax); j < jmax; j++) {
duke@435 116 Node* u = r->fast_out(j);
duke@435 117 if( u == r ) continue;
duke@435 118 if( u == iff ) continue;
duke@435 119 if( u->outcnt() == 0 ) continue; // use is dead & ignorable
duke@435 120 if( !u->is_Phi() ) {
duke@435 121 /*
duke@435 122 if( u->is_Start() ) {
duke@435 123 tty->print_cr("Region has inlined start use");
duke@435 124 } else {
duke@435 125 tty->print_cr("Region has odd use");
duke@435 126 u->dump(2);
duke@435 127 }*/
duke@435 128 return NULL;
duke@435 129 }
duke@435 130 if( u != phi ) {
duke@435 131 // CNC - do not allow any other merged value
duke@435 132 //tty->print_cr("Merging another value");
duke@435 133 //u->dump(2);
duke@435 134 return NULL;
duke@435 135 }
duke@435 136 // Make sure we can account for all Phi uses
duke@435 137 for (DUIterator_Fast kmax, k = u->fast_outs(kmax); k < kmax; k++) {
duke@435 138 Node* v = u->fast_out(k); // User of the phi
duke@435 139 // CNC - Allow only really simple patterns.
duke@435 140 // In particular I disallow AddP of the Phi, a fairly common pattern
duke@435 141 if( v == cmp ) continue; // The compare is OK
duke@435 142 if( (v->is_ConstraintCast()) &&
duke@435 143 v->in(0)->in(0) == iff )
duke@435 144 continue; // CastPP/II of the IfNode is OK
duke@435 145 // Disabled following code because I cannot tell if exactly one
duke@435 146 // path dominates without a real dominator check. CNC 9/9/1999
duke@435 147 //uint vop = v->Opcode();
duke@435 148 //if( vop == Op_Phi ) { // Phi from another merge point might be OK
duke@435 149 // Node *r = v->in(0); // Get controlling point
duke@435 150 // if( !r ) return NULL; // Degraded to a copy
duke@435 151 // // Find exactly one path in (either True or False doms, but not IFF)
duke@435 152 // int cnt = 0;
duke@435 153 // for( uint i = 1; i < r->req(); i++ )
duke@435 154 // if( r->in(i) && r->in(i)->in(0) == iff )
duke@435 155 // cnt++;
duke@435 156 // if( cnt == 1 ) continue; // Exactly one of True or False guards Phi
duke@435 157 //}
duke@435 158 if( !v->is_Call() ) {
duke@435 159 /*
duke@435 160 if( v->Opcode() == Op_AddP ) {
duke@435 161 tty->print_cr("Phi has AddP use");
duke@435 162 } else if( v->Opcode() == Op_CastPP ) {
duke@435 163 tty->print_cr("Phi has CastPP use");
duke@435 164 } else if( v->Opcode() == Op_CastII ) {
duke@435 165 tty->print_cr("Phi has CastII use");
duke@435 166 } else {
duke@435 167 tty->print_cr("Phi has use I cant be bothered with");
duke@435 168 }
duke@435 169 */
duke@435 170 }
duke@435 171 return NULL;
duke@435 172
duke@435 173 /* CNC - Cut out all the fancy acceptance tests
duke@435 174 // Can we clone this use when doing the transformation?
duke@435 175 // If all uses are from Phis at this merge or constants, then YES.
duke@435 176 if( !v->in(0) && v != cmp ) {
duke@435 177 tty->print_cr("Phi has free-floating use");
duke@435 178 v->dump(2);
duke@435 179 return NULL;
duke@435 180 }
duke@435 181 for( uint l = 1; l < v->req(); l++ ) {
duke@435 182 if( (!v->in(l)->is_Phi() || v->in(l)->in(0) != r) &&
duke@435 183 !v->in(l)->is_Con() ) {
duke@435 184 tty->print_cr("Phi has use");
duke@435 185 v->dump(2);
duke@435 186 return NULL;
duke@435 187 } // End of if Phi-use input is neither Phi nor Constant
duke@435 188 } // End of for all inputs to Phi-use
duke@435 189 */
duke@435 190 } // End of for all uses of Phi
duke@435 191 } // End of for all uses of Region
duke@435 192
duke@435 193 // Only do this if the IF node is in a sane state
duke@435 194 if (iff->outcnt() != 2)
duke@435 195 return NULL;
duke@435 196
duke@435 197 // Got a hit! Do the Mondo Hack!
duke@435 198 //
duke@435 199 //ABC a1c def ghi B 1 e h A C a c d f g i
duke@435 200 // R - Phi - Phi - Phi Rc - Phi - Phi - Phi Rx - Phi - Phi - Phi
duke@435 201 // cmp - 2 cmp - 2 cmp - 2
duke@435 202 // bool bool_c bool_x
duke@435 203 // if if_c if_x
duke@435 204 // T F T F T F
duke@435 205 // ..s.. ..t .. ..s.. ..t.. ..s.. ..t..
duke@435 206 //
twisti@1040 207 // Split the paths coming into the merge point into 2 separate groups of
duke@435 208 // merges. On the left will be all the paths feeding constants into the
duke@435 209 // Cmp's Phi. On the right will be the remaining paths. The Cmp's Phi
duke@435 210 // will fold up into a constant; this will let the Cmp fold up as well as
duke@435 211 // all the control flow. Below the original IF we have 2 control
duke@435 212 // dependent regions, 's' and 't'. Now we will merge the two paths
duke@435 213 // just prior to 's' and 't' from the two IFs. At least 1 path (and quite
duke@435 214 // likely 2 or more) will promptly constant fold away.
duke@435 215 PhaseGVN *phase = igvn;
duke@435 216
duke@435 217 // Make a region merging constants and a region merging the rest
duke@435 218 uint req_c = 0;
duke@435 219 for (uint ii = 1; ii < r->req(); ii++) {
duke@435 220 if( phi->in(ii) == con1 ) {
duke@435 221 req_c++;
duke@435 222 }
duke@435 223 }
duke@435 224 Node *region_c = new (igvn->C, req_c + 1) RegionNode(req_c + 1);
duke@435 225 Node *phi_c = con1;
duke@435 226 uint len = r->req();
duke@435 227 Node *region_x = new (igvn->C, len - req_c + 1) RegionNode(len - req_c + 1);
duke@435 228 Node *phi_x = PhiNode::make_blank(region_x, phi);
duke@435 229 for (uint i = 1, i_c = 1, i_x = 1; i < len; i++) {
duke@435 230 if( phi->in(i) == con1 ) {
duke@435 231 region_c->init_req( i_c++, r ->in(i) );
duke@435 232 } else {
duke@435 233 region_x->init_req( i_x, r ->in(i) );
duke@435 234 phi_x ->init_req( i_x++, phi->in(i) );
duke@435 235 }
duke@435 236 }
duke@435 237
duke@435 238 // Register the new RegionNodes but do not transform them. Cannot
twisti@1040 239 // transform until the entire Region/Phi conglomerate has been hacked
duke@435 240 // as a single huge transform.
duke@435 241 igvn->register_new_node_with_optimizer( region_c );
duke@435 242 igvn->register_new_node_with_optimizer( region_x );
duke@435 243 phi_x = phase->transform( phi_x );
duke@435 244 // Prevent the untimely death of phi_x. Currently he has no uses. He is
duke@435 245 // about to get one. If this only use goes away, then phi_x will look dead.
duke@435 246 // However, he will be picking up some more uses down below.
duke@435 247 Node *hook = new (igvn->C, 4) Node(4);
duke@435 248 hook->init_req(0, phi_x);
duke@435 249 hook->init_req(1, phi_c);
duke@435 250
duke@435 251 // Make the compare
duke@435 252 Node *cmp_c = phase->makecon(t);
duke@435 253 Node *cmp_x = cmp->clone();
duke@435 254 cmp_x->set_req(1,phi_x);
duke@435 255 cmp_x->set_req(2,con2);
duke@435 256 cmp_x = phase->transform(cmp_x);
duke@435 257 // Make the bool
duke@435 258 Node *b_c = phase->transform(new (igvn->C, 2) BoolNode(cmp_c,b->_test._test));
duke@435 259 Node *b_x = phase->transform(new (igvn->C, 2) BoolNode(cmp_x,b->_test._test));
duke@435 260 // Make the IfNode
duke@435 261 IfNode *iff_c = new (igvn->C, 2) IfNode(region_c,b_c,iff->_prob,iff->_fcnt);
duke@435 262 igvn->set_type_bottom(iff_c);
duke@435 263 igvn->_worklist.push(iff_c);
duke@435 264 hook->init_req(2, iff_c);
duke@435 265
duke@435 266 IfNode *iff_x = new (igvn->C, 2) IfNode(region_x,b_x,iff->_prob, iff->_fcnt);
duke@435 267 igvn->set_type_bottom(iff_x);
duke@435 268 igvn->_worklist.push(iff_x);
duke@435 269 hook->init_req(3, iff_x);
duke@435 270
duke@435 271 // Make the true/false arms
duke@435 272 Node *iff_c_t = phase->transform(new (igvn->C, 1) IfTrueNode (iff_c));
duke@435 273 Node *iff_c_f = phase->transform(new (igvn->C, 1) IfFalseNode(iff_c));
duke@435 274 Node *iff_x_t = phase->transform(new (igvn->C, 1) IfTrueNode (iff_x));
duke@435 275 Node *iff_x_f = phase->transform(new (igvn->C, 1) IfFalseNode(iff_x));
duke@435 276
duke@435 277 // Merge the TRUE paths
duke@435 278 Node *region_s = new (igvn->C, 3) RegionNode(3);
duke@435 279 igvn->_worklist.push(region_s);
duke@435 280 region_s->init_req(1, iff_c_t);
duke@435 281 region_s->init_req(2, iff_x_t);
duke@435 282 igvn->register_new_node_with_optimizer( region_s );
duke@435 283
duke@435 284 // Merge the FALSE paths
duke@435 285 Node *region_f = new (igvn->C, 3) RegionNode(3);
duke@435 286 igvn->_worklist.push(region_f);
duke@435 287 region_f->init_req(1, iff_c_f);
duke@435 288 region_f->init_req(2, iff_x_f);
duke@435 289 igvn->register_new_node_with_optimizer( region_f );
duke@435 290
duke@435 291 igvn->hash_delete(cmp);// Remove soon-to-be-dead node from hash table.
duke@435 292 cmp->set_req(1,NULL); // Whack the inputs to cmp because it will be dead
duke@435 293 cmp->set_req(2,NULL);
duke@435 294 // Check for all uses of the Phi and give them a new home.
duke@435 295 // The 'cmp' got cloned, but CastPP/IIs need to be moved.
duke@435 296 Node *phi_s = NULL; // do not construct unless needed
duke@435 297 Node *phi_f = NULL; // do not construct unless needed
duke@435 298 for (DUIterator_Last i2min, i2 = phi->last_outs(i2min); i2 >= i2min; --i2) {
duke@435 299 Node* v = phi->last_out(i2);// User of the phi
duke@435 300 igvn->hash_delete(v); // Have to fixup other Phi users
duke@435 301 igvn->_worklist.push(v);
duke@435 302 uint vop = v->Opcode();
duke@435 303 Node *proj = NULL;
duke@435 304 if( vop == Op_Phi ) { // Remote merge point
duke@435 305 Node *r = v->in(0);
duke@435 306 for (uint i3 = 1; i3 < r->req(); i3++)
duke@435 307 if (r->in(i3) && r->in(i3)->in(0) == iff) {
duke@435 308 proj = r->in(i3);
duke@435 309 break;
duke@435 310 }
duke@435 311 } else if( v->is_ConstraintCast() ) {
duke@435 312 proj = v->in(0); // Controlling projection
duke@435 313 } else {
duke@435 314 assert( 0, "do not know how to handle this guy" );
duke@435 315 }
duke@435 316
duke@435 317 Node *proj_path_data, *proj_path_ctrl;
duke@435 318 if( proj->Opcode() == Op_IfTrue ) {
duke@435 319 if( phi_s == NULL ) {
duke@435 320 // Only construct phi_s if needed, otherwise provides
duke@435 321 // interfering use.
duke@435 322 phi_s = PhiNode::make_blank(region_s,phi);
duke@435 323 phi_s->init_req( 1, phi_c );
duke@435 324 phi_s->init_req( 2, phi_x );
duke@435 325 phi_s = phase->transform(phi_s);
duke@435 326 }
duke@435 327 proj_path_data = phi_s;
duke@435 328 proj_path_ctrl = region_s;
duke@435 329 } else {
duke@435 330 if( phi_f == NULL ) {
duke@435 331 // Only construct phi_f if needed, otherwise provides
duke@435 332 // interfering use.
duke@435 333 phi_f = PhiNode::make_blank(region_f,phi);
duke@435 334 phi_f->init_req( 1, phi_c );
duke@435 335 phi_f->init_req( 2, phi_x );
duke@435 336 phi_f = phase->transform(phi_f);
duke@435 337 }
duke@435 338 proj_path_data = phi_f;
duke@435 339 proj_path_ctrl = region_f;
duke@435 340 }
duke@435 341
duke@435 342 // Fixup 'v' for for the split
duke@435 343 if( vop == Op_Phi ) { // Remote merge point
duke@435 344 uint i;
duke@435 345 for( i = 1; i < v->req(); i++ )
duke@435 346 if( v->in(i) == phi )
duke@435 347 break;
duke@435 348 v->set_req(i, proj_path_data );
duke@435 349 } else if( v->is_ConstraintCast() ) {
duke@435 350 v->set_req(0, proj_path_ctrl );
duke@435 351 v->set_req(1, proj_path_data );
duke@435 352 } else
duke@435 353 ShouldNotReachHere();
duke@435 354 }
duke@435 355
duke@435 356 // Now replace the original iff's True/False with region_s/region_t.
duke@435 357 // This makes the original iff go dead.
duke@435 358 for (DUIterator_Last i3min, i3 = iff->last_outs(i3min); i3 >= i3min; --i3) {
duke@435 359 Node* p = iff->last_out(i3);
duke@435 360 assert( p->Opcode() == Op_IfTrue || p->Opcode() == Op_IfFalse, "" );
duke@435 361 Node *u = (p->Opcode() == Op_IfTrue) ? region_s : region_f;
duke@435 362 // Replace p with u
duke@435 363 igvn->add_users_to_worklist(p);
duke@435 364 for (DUIterator_Last lmin, l = p->last_outs(lmin); l >= lmin;) {
duke@435 365 Node* x = p->last_out(l);
duke@435 366 igvn->hash_delete(x);
duke@435 367 uint uses_found = 0;
duke@435 368 for( uint j = 0; j < x->req(); j++ ) {
duke@435 369 if( x->in(j) == p ) {
duke@435 370 x->set_req(j, u);
duke@435 371 uses_found++;
duke@435 372 }
duke@435 373 }
duke@435 374 l -= uses_found; // we deleted 1 or more copies of this edge
duke@435 375 }
duke@435 376 igvn->remove_dead_node(p);
duke@435 377 }
duke@435 378
duke@435 379 // Force the original merge dead
duke@435 380 igvn->hash_delete(r);
duke@435 381 r->set_req_X(0,NULL,igvn);
duke@435 382
duke@435 383 // Now remove the bogus extra edges used to keep things alive
duke@435 384 igvn->remove_dead_node( hook );
duke@435 385
duke@435 386 // Must return either the original node (now dead) or a new node
duke@435 387 // (Do not return a top here, since that would break the uniqueness of top.)
duke@435 388 return new (igvn->C, 1) ConINode(TypeInt::ZERO);
duke@435 389 }
duke@435 390
duke@435 391 //------------------------------is_range_check---------------------------------
duke@435 392 // Return 0 if not a range check. Return 1 if a range check and set index and
duke@435 393 // offset. Return 2 if we had to negate the test. Index is NULL if the check
duke@435 394 // is versus a constant.
duke@435 395 int IfNode::is_range_check(Node* &range, Node* &index, jint &offset) {
duke@435 396 Node* b = in(1);
duke@435 397 if (b == NULL || !b->is_Bool()) return 0;
duke@435 398 BoolNode* bn = b->as_Bool();
duke@435 399 Node* cmp = bn->in(1);
duke@435 400 if (cmp == NULL) return 0;
duke@435 401 if (cmp->Opcode() != Op_CmpU) return 0;
duke@435 402
duke@435 403 Node* l = cmp->in(1);
duke@435 404 Node* r = cmp->in(2);
duke@435 405 int flip_test = 1;
duke@435 406 if (bn->_test._test == BoolTest::le) {
duke@435 407 l = cmp->in(2);
duke@435 408 r = cmp->in(1);
duke@435 409 flip_test = 2;
duke@435 410 } else if (bn->_test._test != BoolTest::lt) {
duke@435 411 return 0;
duke@435 412 }
duke@435 413 if (l->is_top()) return 0; // Top input means dead test
duke@435 414 if (r->Opcode() != Op_LoadRange) return 0;
duke@435 415
duke@435 416 // We have recognized one of these forms:
duke@435 417 // Flip 1: If (Bool[<] CmpU(l, LoadRange)) ...
duke@435 418 // Flip 2: If (Bool[<=] CmpU(LoadRange, l)) ...
duke@435 419
duke@435 420 // Make sure it's a real range check by requiring an uncommon trap
duke@435 421 // along the OOB path. Otherwise, it's possible that the user wrote
duke@435 422 // something which optimized to look like a range check but behaves
duke@435 423 // in some other way.
duke@435 424 Node* iftrap = proj_out(flip_test == 2 ? true : false);
duke@435 425 bool found_trap = false;
duke@435 426 if (iftrap != NULL) {
duke@435 427 Node* u = iftrap->unique_ctrl_out();
duke@435 428 if (u != NULL) {
duke@435 429 // It could be a merge point (Region) for uncommon trap.
duke@435 430 if (u->is_Region()) {
duke@435 431 Node* c = u->unique_ctrl_out();
duke@435 432 if (c != NULL) {
duke@435 433 iftrap = u;
duke@435 434 u = c;
duke@435 435 }
duke@435 436 }
duke@435 437 if (u->in(0) == iftrap && u->is_CallStaticJava()) {
duke@435 438 int req = u->as_CallStaticJava()->uncommon_trap_request();
duke@435 439 if (Deoptimization::trap_request_reason(req) ==
duke@435 440 Deoptimization::Reason_range_check) {
duke@435 441 found_trap = true;
duke@435 442 }
duke@435 443 }
duke@435 444 }
duke@435 445 }
duke@435 446 if (!found_trap) return 0; // sorry, no cigar
duke@435 447
duke@435 448 // Look for index+offset form
duke@435 449 Node* ind = l;
duke@435 450 jint off = 0;
duke@435 451 if (l->is_top()) {
duke@435 452 return 0;
duke@435 453 } else if (l->is_Add()) {
duke@435 454 if ((off = l->in(1)->find_int_con(0)) != 0) {
duke@435 455 ind = l->in(2);
duke@435 456 } else if ((off = l->in(2)->find_int_con(0)) != 0) {
duke@435 457 ind = l->in(1);
duke@435 458 }
duke@435 459 } else if ((off = l->find_int_con(-1)) >= 0) {
duke@435 460 // constant offset with no variable index
duke@435 461 ind = NULL;
duke@435 462 } else {
duke@435 463 // variable index with no constant offset (or dead negative index)
duke@435 464 off = 0;
duke@435 465 }
duke@435 466
duke@435 467 // Return all the values:
duke@435 468 index = ind;
duke@435 469 offset = off;
duke@435 470 range = r;
duke@435 471 return flip_test;
duke@435 472 }
duke@435 473
duke@435 474 //------------------------------adjust_check-----------------------------------
duke@435 475 // Adjust (widen) a prior range check
duke@435 476 static void adjust_check(Node* proj, Node* range, Node* index,
duke@435 477 int flip, jint off_lo, PhaseIterGVN* igvn) {
duke@435 478 PhaseGVN *gvn = igvn;
duke@435 479 // Break apart the old check
duke@435 480 Node *iff = proj->in(0);
duke@435 481 Node *bol = iff->in(1);
duke@435 482 if( bol->is_top() ) return; // In case a partially dead range check appears
duke@435 483 // bail (or bomb[ASSERT/DEBUG]) if NOT projection-->IfNode-->BoolNode
duke@435 484 DEBUG_ONLY( if( !bol->is_Bool() ) { proj->dump(3); fatal("Expect projection-->IfNode-->BoolNode"); } )
duke@435 485 if( !bol->is_Bool() ) return;
duke@435 486
duke@435 487 Node *cmp = bol->in(1);
duke@435 488 // Compute a new check
duke@435 489 Node *new_add = gvn->intcon(off_lo);
duke@435 490 if( index ) {
duke@435 491 new_add = off_lo ? gvn->transform(new (gvn->C, 3) AddINode( index, new_add )) : index;
duke@435 492 }
duke@435 493 Node *new_cmp = (flip == 1)
duke@435 494 ? new (gvn->C, 3) CmpUNode( new_add, range )
duke@435 495 : new (gvn->C, 3) CmpUNode( range, new_add );
duke@435 496 new_cmp = gvn->transform(new_cmp);
duke@435 497 // See if no need to adjust the existing check
duke@435 498 if( new_cmp == cmp ) return;
duke@435 499 // Else, adjust existing check
duke@435 500 Node *new_bol = gvn->transform( new (gvn->C, 2) BoolNode( new_cmp, bol->as_Bool()->_test._test ) );
duke@435 501 igvn->hash_delete( iff );
duke@435 502 iff->set_req_X( 1, new_bol, igvn );
duke@435 503 }
duke@435 504
duke@435 505 //------------------------------up_one_dom-------------------------------------
duke@435 506 // Walk up the dominator tree one step. Return NULL at root or true
duke@435 507 // complex merges. Skips through small diamonds.
duke@435 508 Node* IfNode::up_one_dom(Node *curr, bool linear_only) {
duke@435 509 Node *dom = curr->in(0);
duke@435 510 if( !dom ) // Found a Region degraded to a copy?
duke@435 511 return curr->nonnull_req(); // Skip thru it
duke@435 512
duke@435 513 if( curr != dom ) // Normal walk up one step?
duke@435 514 return dom;
duke@435 515
duke@435 516 // Use linear_only if we are still parsing, since we cannot
duke@435 517 // trust the regions to be fully filled in.
duke@435 518 if (linear_only)
duke@435 519 return NULL;
duke@435 520
duke@435 521 // Else hit a Region. Check for a loop header
duke@435 522 if( dom->is_Loop() )
duke@435 523 return dom->in(1); // Skip up thru loops
duke@435 524
duke@435 525 // Check for small diamonds
duke@435 526 Node *din1, *din2, *din3, *din4;
duke@435 527 if( dom->req() == 3 && // 2-path merge point
duke@435 528 (din1 = dom ->in(1)) && // Left path exists
duke@435 529 (din2 = dom ->in(2)) && // Right path exists
duke@435 530 (din3 = din1->in(0)) && // Left path up one
duke@435 531 (din4 = din2->in(0)) ) { // Right path up one
duke@435 532 if( din3->is_Call() && // Handle a slow-path call on either arm
duke@435 533 (din3 = din3->in(0)) )
duke@435 534 din3 = din3->in(0);
duke@435 535 if( din4->is_Call() && // Handle a slow-path call on either arm
duke@435 536 (din4 = din4->in(0)) )
duke@435 537 din4 = din4->in(0);
duke@435 538 if( din3 == din4 && din3->is_If() )
duke@435 539 return din3; // Skip around diamonds
duke@435 540 }
duke@435 541
duke@435 542 // Give up the search at true merges
duke@435 543 return NULL; // Dead loop? Or hit root?
duke@435 544 }
duke@435 545
never@452 546
never@452 547 //------------------------------filtered_int_type--------------------------------
never@452 548 // Return a possibly more restrictive type for val based on condition control flow for an if
never@452 549 const TypeInt* IfNode::filtered_int_type(PhaseGVN* gvn, Node *val, Node* if_proj) {
never@452 550 assert(if_proj &&
never@452 551 (if_proj->Opcode() == Op_IfTrue || if_proj->Opcode() == Op_IfFalse), "expecting an if projection");
never@452 552 if (if_proj->in(0) && if_proj->in(0)->is_If()) {
never@452 553 IfNode* iff = if_proj->in(0)->as_If();
never@452 554 if (iff->in(1) && iff->in(1)->is_Bool()) {
never@452 555 BoolNode* bol = iff->in(1)->as_Bool();
never@452 556 if (bol->in(1) && bol->in(1)->is_Cmp()) {
never@452 557 const CmpNode* cmp = bol->in(1)->as_Cmp();
never@452 558 if (cmp->in(1) == val) {
never@452 559 const TypeInt* cmp2_t = gvn->type(cmp->in(2))->isa_int();
never@452 560 if (cmp2_t != NULL) {
never@452 561 jint lo = cmp2_t->_lo;
never@452 562 jint hi = cmp2_t->_hi;
never@452 563 BoolTest::mask msk = if_proj->Opcode() == Op_IfTrue ? bol->_test._test : bol->_test.negate();
never@452 564 switch (msk) {
never@452 565 case BoolTest::ne:
never@452 566 // Can't refine type
never@452 567 return NULL;
never@452 568 case BoolTest::eq:
never@452 569 return cmp2_t;
never@452 570 case BoolTest::lt:
never@452 571 lo = TypeInt::INT->_lo;
never@452 572 if (hi - 1 < hi) {
never@452 573 hi = hi - 1;
never@452 574 }
never@452 575 break;
never@452 576 case BoolTest::le:
never@452 577 lo = TypeInt::INT->_lo;
never@452 578 break;
never@452 579 case BoolTest::gt:
never@452 580 if (lo + 1 > lo) {
never@452 581 lo = lo + 1;
never@452 582 }
never@452 583 hi = TypeInt::INT->_hi;
never@452 584 break;
never@452 585 case BoolTest::ge:
never@452 586 // lo unchanged
never@452 587 hi = TypeInt::INT->_hi;
never@452 588 break;
never@452 589 }
never@452 590 const TypeInt* rtn_t = TypeInt::make(lo, hi, cmp2_t->_widen);
never@452 591 return rtn_t;
never@452 592 }
never@452 593 }
never@452 594 }
never@452 595 }
never@452 596 }
never@452 597 return NULL;
never@452 598 }
never@452 599
never@452 600 //------------------------------fold_compares----------------------------
never@452 601 // See if a pair of CmpIs can be converted into a CmpU. In some cases
twisti@1040 602 // the direction of this if is determined by the preceding if so it
never@452 603 // can be eliminate entirely. Given an if testing (CmpI n c) check
never@452 604 // for an immediately control dependent if that is testing (CmpI n c2)
never@452 605 // and has one projection leading to this if and the other projection
never@452 606 // leading to a region that merges one of this ifs control
never@452 607 // projections.
never@452 608 //
never@452 609 // If
never@452 610 // / |
never@452 611 // / |
never@452 612 // / |
never@452 613 // If |
never@452 614 // /\ |
never@452 615 // / \ |
never@452 616 // / \ |
never@452 617 // / Region
never@452 618 //
never@452 619 Node* IfNode::fold_compares(PhaseGVN* phase) {
never@452 620 if (!EliminateAutoBox || Opcode() != Op_If) return NULL;
never@452 621
never@452 622 Node* this_cmp = in(1)->in(1);
never@452 623 if (this_cmp != NULL && this_cmp->Opcode() == Op_CmpI &&
never@452 624 this_cmp->in(2)->is_Con() && this_cmp->in(2) != phase->C->top()) {
never@452 625 Node* ctrl = in(0);
never@452 626 BoolNode* this_bool = in(1)->as_Bool();
never@452 627 Node* n = this_cmp->in(1);
never@452 628 int hi = this_cmp->in(2)->get_int();
never@452 629 if (ctrl != NULL && ctrl->is_Proj() && ctrl->outcnt() == 1 &&
never@452 630 ctrl->in(0)->is_If() &&
never@452 631 ctrl->in(0)->outcnt() == 2 &&
never@452 632 ctrl->in(0)->in(1)->is_Bool() &&
never@452 633 ctrl->in(0)->in(1)->in(1)->Opcode() == Op_CmpI &&
never@452 634 ctrl->in(0)->in(1)->in(1)->in(2)->is_Con() &&
never@452 635 ctrl->in(0)->in(1)->in(1)->in(1) == n) {
never@452 636 IfNode* dom_iff = ctrl->in(0)->as_If();
never@452 637 Node* otherproj = dom_iff->proj_out(!ctrl->as_Proj()->_con);
never@452 638 if (otherproj->outcnt() == 1 && otherproj->unique_out()->is_Region() &&
never@452 639 this_bool->_test._test != BoolTest::ne && this_bool->_test._test != BoolTest::eq) {
never@452 640 // Identify which proj goes to the region and which continues on
never@452 641 RegionNode* region = otherproj->unique_out()->as_Region();
never@452 642 Node* success = NULL;
never@452 643 Node* fail = NULL;
never@452 644 for (int i = 0; i < 2; i++) {
never@452 645 Node* proj = proj_out(i);
never@452 646 if (success == NULL && proj->outcnt() == 1 && proj->unique_out() == region) {
never@452 647 success = proj;
never@452 648 } else if (fail == NULL) {
never@452 649 fail = proj;
never@452 650 } else {
never@452 651 success = fail = NULL;
never@452 652 }
never@452 653 }
never@452 654 if (success != NULL && fail != NULL && !region->has_phi()) {
never@452 655 int lo = dom_iff->in(1)->in(1)->in(2)->get_int();
never@452 656 BoolNode* dom_bool = dom_iff->in(1)->as_Bool();
never@452 657 Node* dom_cmp = dom_bool->in(1);
never@452 658 const TypeInt* failtype = filtered_int_type(phase, n, ctrl);
never@452 659 if (failtype != NULL) {
never@452 660 const TypeInt* type2 = filtered_int_type(phase, n, fail);
never@452 661 if (type2 != NULL) {
never@452 662 failtype = failtype->join(type2)->is_int();
never@452 663 } else {
never@452 664 failtype = NULL;
never@452 665 }
never@452 666 }
never@452 667
never@452 668 if (failtype != NULL &&
never@452 669 dom_bool->_test._test != BoolTest::ne && dom_bool->_test._test != BoolTest::eq) {
never@452 670 int bound = failtype->_hi - failtype->_lo + 1;
never@452 671 if (failtype->_hi != max_jint && failtype->_lo != min_jint && bound > 1) {
never@452 672 // Merge the two compares into a single unsigned compare by building (CmpU (n - lo) hi)
never@452 673 BoolTest::mask cond = fail->as_Proj()->_con ? BoolTest::lt : BoolTest::ge;
never@452 674 Node* adjusted = phase->transform(new (phase->C, 3) SubINode(n, phase->intcon(failtype->_lo)));
never@452 675 Node* newcmp = phase->transform(new (phase->C, 3) CmpUNode(adjusted, phase->intcon(bound)));
never@452 676 Node* newbool = phase->transform(new (phase->C, 2) BoolNode(newcmp, cond));
never@452 677 phase->hash_delete(dom_iff);
never@452 678 dom_iff->set_req(1, phase->intcon(ctrl->as_Proj()->_con));
never@452 679 phase->is_IterGVN()->_worklist.push(dom_iff);
never@452 680 phase->hash_delete(this);
never@452 681 set_req(1, newbool);
never@452 682 return this;
never@452 683 }
never@452 684 if (failtype->_lo > failtype->_hi) {
never@452 685 // previous if determines the result of this if so
never@452 686 // replace Bool with constant
never@452 687 phase->hash_delete(this);
never@452 688 set_req(1, phase->intcon(success->as_Proj()->_con));
never@452 689 return this;
never@452 690 }
never@452 691 }
never@452 692 }
never@452 693 }
never@452 694 }
never@452 695 }
never@452 696 return NULL;
never@452 697 }
never@452 698
duke@435 699 //------------------------------remove_useless_bool----------------------------
duke@435 700 // Check for people making a useless boolean: things like
duke@435 701 // if( (x < y ? true : false) ) { ... }
duke@435 702 // Replace with if( x < y ) { ... }
duke@435 703 static Node *remove_useless_bool(IfNode *iff, PhaseGVN *phase) {
duke@435 704 Node *i1 = iff->in(1);
duke@435 705 if( !i1->is_Bool() ) return NULL;
duke@435 706 BoolNode *bol = i1->as_Bool();
duke@435 707
duke@435 708 Node *cmp = bol->in(1);
duke@435 709 if( cmp->Opcode() != Op_CmpI ) return NULL;
duke@435 710
duke@435 711 // Must be comparing against a bool
duke@435 712 const Type *cmp2_t = phase->type( cmp->in(2) );
duke@435 713 if( cmp2_t != TypeInt::ZERO &&
duke@435 714 cmp2_t != TypeInt::ONE )
duke@435 715 return NULL;
duke@435 716
duke@435 717 // Find a prior merge point merging the boolean
duke@435 718 i1 = cmp->in(1);
duke@435 719 if( !i1->is_Phi() ) return NULL;
duke@435 720 PhiNode *phi = i1->as_Phi();
duke@435 721 if( phase->type( phi ) != TypeInt::BOOL )
duke@435 722 return NULL;
duke@435 723
duke@435 724 // Check for diamond pattern
duke@435 725 int true_path = phi->is_diamond_phi();
duke@435 726 if( true_path == 0 ) return NULL;
duke@435 727
never@685 728 // Make sure that iff and the control of the phi are different. This
never@685 729 // should really only happen for dead control flow since it requires
never@685 730 // an illegal cycle.
never@685 731 if (phi->in(0)->in(1)->in(0) == iff) return NULL;
never@685 732
duke@435 733 // phi->region->if_proj->ifnode->bool->cmp
duke@435 734 BoolNode *bol2 = phi->in(0)->in(1)->in(0)->in(1)->as_Bool();
duke@435 735
duke@435 736 // Now get the 'sense' of the test correct so we can plug in
duke@435 737 // either iff2->in(1) or its complement.
duke@435 738 int flip = 0;
duke@435 739 if( bol->_test._test == BoolTest::ne ) flip = 1-flip;
duke@435 740 else if( bol->_test._test != BoolTest::eq ) return NULL;
duke@435 741 if( cmp2_t == TypeInt::ZERO ) flip = 1-flip;
duke@435 742
duke@435 743 const Type *phi1_t = phase->type( phi->in(1) );
duke@435 744 const Type *phi2_t = phase->type( phi->in(2) );
duke@435 745 // Check for Phi(0,1) and flip
duke@435 746 if( phi1_t == TypeInt::ZERO ) {
duke@435 747 if( phi2_t != TypeInt::ONE ) return NULL;
duke@435 748 flip = 1-flip;
duke@435 749 } else {
duke@435 750 // Check for Phi(1,0)
duke@435 751 if( phi1_t != TypeInt::ONE ) return NULL;
duke@435 752 if( phi2_t != TypeInt::ZERO ) return NULL;
duke@435 753 }
duke@435 754 if( true_path == 2 ) {
duke@435 755 flip = 1-flip;
duke@435 756 }
duke@435 757
duke@435 758 Node* new_bol = (flip ? phase->transform( bol2->negate(phase) ) : bol2);
never@685 759 assert(new_bol != iff->in(1), "must make progress");
duke@435 760 iff->set_req(1, new_bol);
duke@435 761 // Intervening diamond probably goes dead
duke@435 762 phase->C->set_major_progress();
duke@435 763 return iff;
duke@435 764 }
duke@435 765
duke@435 766 static IfNode* idealize_test(PhaseGVN* phase, IfNode* iff);
duke@435 767
duke@435 768 //------------------------------Ideal------------------------------------------
duke@435 769 // Return a node which is more "ideal" than the current node. Strip out
duke@435 770 // control copies
duke@435 771 Node *IfNode::Ideal(PhaseGVN *phase, bool can_reshape) {
duke@435 772 if (remove_dead_region(phase, can_reshape)) return this;
duke@435 773 // No Def-Use info?
duke@435 774 if (!can_reshape) return NULL;
duke@435 775 PhaseIterGVN *igvn = phase->is_IterGVN();
duke@435 776
duke@435 777 // Don't bother trying to transform a dead if
duke@435 778 if (in(0)->is_top()) return NULL;
duke@435 779 // Don't bother trying to transform an if with a dead test
duke@435 780 if (in(1)->is_top()) return NULL;
duke@435 781 // Another variation of a dead test
duke@435 782 if (in(1)->is_Con()) return NULL;
duke@435 783 // Another variation of a dead if
duke@435 784 if (outcnt() < 2) return NULL;
duke@435 785
duke@435 786 // Canonicalize the test.
duke@435 787 Node* idt_if = idealize_test(phase, this);
duke@435 788 if (idt_if != NULL) return idt_if;
duke@435 789
duke@435 790 // Try to split the IF
duke@435 791 Node *s = split_if(this, igvn);
duke@435 792 if (s != NULL) return s;
duke@435 793
duke@435 794 // Check for people making a useless boolean: things like
duke@435 795 // if( (x < y ? true : false) ) { ... }
duke@435 796 // Replace with if( x < y ) { ... }
duke@435 797 Node *bol2 = remove_useless_bool(this, phase);
duke@435 798 if( bol2 ) return bol2;
duke@435 799
duke@435 800 // Setup to scan up the CFG looking for a dominating test
duke@435 801 Node *dom = in(0);
duke@435 802 Node *prev_dom = this;
duke@435 803
duke@435 804 // Check for range-check vs other kinds of tests
duke@435 805 Node *index1, *range1;
duke@435 806 jint offset1;
duke@435 807 int flip1 = is_range_check(range1, index1, offset1);
duke@435 808 if( flip1 ) {
duke@435 809 Node *first_prev_dom = NULL;
duke@435 810
duke@435 811 // Try to remove extra range checks. All 'up_one_dom' gives up at merges
duke@435 812 // so all checks we inspect post-dominate the top-most check we find.
duke@435 813 // If we are going to fail the current check and we reach the top check
twisti@1040 814 // then we are guaranteed to fail, so just start interpreting there.
duke@435 815 // We 'expand' the top 2 range checks to include all post-dominating
duke@435 816 // checks.
duke@435 817
duke@435 818 // The top 2 range checks seen
duke@435 819 Node *prev_chk1 = NULL;
duke@435 820 Node *prev_chk2 = NULL;
duke@435 821 // Low and high offsets seen so far
duke@435 822 jint off_lo = offset1;
duke@435 823 jint off_hi = offset1;
duke@435 824
duke@435 825 // Scan for the top 2 checks and collect range of offsets
duke@435 826 for( int dist = 0; dist < 999; dist++ ) { // Range-Check scan limit
duke@435 827 if( dom->Opcode() == Op_If && // Not same opcode?
duke@435 828 prev_dom->in(0) == dom ) { // One path of test does dominate?
duke@435 829 if( dom == this ) return NULL; // dead loop
duke@435 830 // See if this is a range check
duke@435 831 Node *index2, *range2;
duke@435 832 jint offset2;
duke@435 833 int flip2 = dom->as_If()->is_range_check(range2, index2, offset2);
duke@435 834 // See if this is a _matching_ range check, checking against
duke@435 835 // the same array bounds.
duke@435 836 if( flip2 == flip1 && range2 == range1 && index2 == index1 &&
duke@435 837 dom->outcnt() == 2 ) {
duke@435 838 // Gather expanded bounds
duke@435 839 off_lo = MIN2(off_lo,offset2);
duke@435 840 off_hi = MAX2(off_hi,offset2);
duke@435 841 // Record top 2 range checks
duke@435 842 prev_chk2 = prev_chk1;
duke@435 843 prev_chk1 = prev_dom;
duke@435 844 // If we match the test exactly, then the top test covers
duke@435 845 // both our lower and upper bounds.
duke@435 846 if( dom->in(1) == in(1) )
duke@435 847 prev_chk2 = prev_chk1;
duke@435 848 }
duke@435 849 }
duke@435 850 prev_dom = dom;
duke@435 851 dom = up_one_dom( dom );
duke@435 852 if( !dom ) break;
duke@435 853 }
duke@435 854
duke@435 855
duke@435 856 // Attempt to widen the dominating range check to cover some later
duke@435 857 // ones. Since range checks "fail" by uncommon-trapping to the
duke@435 858 // interpreter, widening a check can make us speculative enter the
duke@435 859 // interpreter. If we see range-check deopt's, do not widen!
duke@435 860 if (!phase->C->allow_range_check_smearing()) return NULL;
duke@435 861
duke@435 862 // Constant indices only need to check the upper bound.
duke@435 863 // Non-constance indices must check both low and high.
duke@435 864 if( index1 ) {
duke@435 865 // Didn't find 2 prior covering checks, so cannot remove anything.
duke@435 866 if( !prev_chk2 ) return NULL;
duke@435 867 // 'Widen' the offsets of the 1st and 2nd covering check
duke@435 868 adjust_check( prev_chk1, range1, index1, flip1, off_lo, igvn );
duke@435 869 // Do not call adjust_check twice on the same projection
duke@435 870 // as the first call may have transformed the BoolNode to a ConI
duke@435 871 if( prev_chk1 != prev_chk2 ) {
duke@435 872 adjust_check( prev_chk2, range1, index1, flip1, off_hi, igvn );
duke@435 873 }
duke@435 874 // Test is now covered by prior checks, dominate it out
duke@435 875 prev_dom = prev_chk2;
duke@435 876 } else {
duke@435 877 // Didn't find prior covering check, so cannot remove anything.
duke@435 878 if( !prev_chk1 ) return NULL;
duke@435 879 // 'Widen' the offset of the 1st and only covering check
duke@435 880 adjust_check( prev_chk1, range1, index1, flip1, off_hi, igvn );
duke@435 881 // Test is now covered by prior checks, dominate it out
duke@435 882 prev_dom = prev_chk1;
duke@435 883 }
duke@435 884
duke@435 885
duke@435 886 } else { // Scan for an equivalent test
duke@435 887
duke@435 888 Node *cmp;
duke@435 889 int dist = 0; // Cutoff limit for search
duke@435 890 int op = Opcode();
duke@435 891 if( op == Op_If &&
duke@435 892 (cmp=in(1)->in(1))->Opcode() == Op_CmpP ) {
duke@435 893 if( cmp->in(2) != NULL && // make sure cmp is not already dead
duke@435 894 cmp->in(2)->bottom_type() == TypePtr::NULL_PTR ) {
duke@435 895 dist = 64; // Limit for null-pointer scans
duke@435 896 } else {
duke@435 897 dist = 4; // Do not bother for random pointer tests
duke@435 898 }
duke@435 899 } else {
duke@435 900 dist = 4; // Limit for random junky scans
duke@435 901 }
duke@435 902
duke@435 903 // Normal equivalent-test check.
duke@435 904 if( !dom ) return NULL; // Dead loop?
duke@435 905
never@452 906 Node* result = fold_compares(phase);
never@452 907 if (result != NULL) {
never@452 908 return result;
never@452 909 }
never@452 910
duke@435 911 // Search up the dominator tree for an If with an identical test
duke@435 912 while( dom->Opcode() != op || // Not same opcode?
duke@435 913 dom->in(1) != in(1) || // Not same input 1?
duke@435 914 (req() == 3 && dom->in(2) != in(2)) || // Not same input 2?
duke@435 915 prev_dom->in(0) != dom ) { // One path of test does not dominate?
duke@435 916 if( dist < 0 ) return NULL;
duke@435 917
duke@435 918 dist--;
duke@435 919 prev_dom = dom;
duke@435 920 dom = up_one_dom( dom );
duke@435 921 if( !dom ) return NULL;
duke@435 922 }
duke@435 923
duke@435 924 // Check that we did not follow a loop back to ourselves
duke@435 925 if( this == dom )
duke@435 926 return NULL;
duke@435 927
duke@435 928 if( dist > 2 ) // Add to count of NULL checks elided
duke@435 929 explicit_null_checks_elided++;
duke@435 930
duke@435 931 } // End of Else scan for an equivalent test
duke@435 932
duke@435 933 // Hit! Remove this IF
duke@435 934 #ifndef PRODUCT
duke@435 935 if( TraceIterativeGVN ) {
duke@435 936 tty->print(" Removing IfNode: "); this->dump();
duke@435 937 }
duke@435 938 if( VerifyOpto && !phase->allow_progress() ) {
duke@435 939 // Found an equivalent dominating test,
duke@435 940 // we can not guarantee reaching a fix-point for these during iterativeGVN
duke@435 941 // since intervening nodes may not change.
duke@435 942 return NULL;
duke@435 943 }
duke@435 944 #endif
duke@435 945
duke@435 946 // Replace dominated IfNode
duke@435 947 dominated_by( prev_dom, igvn );
duke@435 948
duke@435 949 // Must return either the original node (now dead) or a new node
duke@435 950 // (Do not return a top here, since that would break the uniqueness of top.)
duke@435 951 return new (phase->C, 1) ConINode(TypeInt::ZERO);
duke@435 952 }
duke@435 953
duke@435 954 //------------------------------dominated_by-----------------------------------
duke@435 955 void IfNode::dominated_by( Node *prev_dom, PhaseIterGVN *igvn ) {
duke@435 956 igvn->hash_delete(this); // Remove self to prevent spurious V-N
duke@435 957 Node *idom = in(0);
duke@435 958 // Need opcode to decide which way 'this' test goes
duke@435 959 int prev_op = prev_dom->Opcode();
duke@435 960 Node *top = igvn->C->top(); // Shortcut to top
duke@435 961
duke@435 962 // Now walk the current IfNode's projections.
duke@435 963 // Loop ends when 'this' has no more uses.
duke@435 964 for (DUIterator_Last imin, i = last_outs(imin); i >= imin; --i) {
duke@435 965 Node *ifp = last_out(i); // Get IfTrue/IfFalse
duke@435 966 igvn->add_users_to_worklist(ifp);
duke@435 967 // Check which projection it is and set target.
duke@435 968 // Data-target is either the dominating projection of the same type
duke@435 969 // or TOP if the dominating projection is of opposite type.
duke@435 970 // Data-target will be used as the new control edge for the non-CFG
duke@435 971 // nodes like Casts and Loads.
duke@435 972 Node *data_target = (ifp->Opcode() == prev_op ) ? prev_dom : top;
duke@435 973 // Control-target is just the If's immediate dominator or TOP.
duke@435 974 Node *ctrl_target = (ifp->Opcode() == prev_op ) ? idom : top;
duke@435 975
duke@435 976 // For each child of an IfTrue/IfFalse projection, reroute.
duke@435 977 // Loop ends when projection has no more uses.
duke@435 978 for (DUIterator_Last jmin, j = ifp->last_outs(jmin); j >= jmin; --j) {
duke@435 979 Node* s = ifp->last_out(j); // Get child of IfTrue/IfFalse
duke@435 980 igvn->hash_delete(s); // Yank from hash table before edge hacking
duke@435 981 if( !s->depends_only_on_test() ) {
duke@435 982 // Find the control input matching this def-use edge.
duke@435 983 // For Regions it may not be in slot 0.
duke@435 984 uint l;
duke@435 985 for( l = 0; s->in(l) != ifp; l++ ) { }
duke@435 986 s->set_req(l, ctrl_target);
duke@435 987 } else { // Else, for control producers,
duke@435 988 s->set_req(0, data_target); // Move child to data-target
duke@435 989 }
duke@435 990 igvn->_worklist.push(s); // Revisit collapsed Phis
duke@435 991 } // End for each child of a projection
duke@435 992
duke@435 993 igvn->remove_dead_node(ifp);
duke@435 994 } // End for each IfTrue/IfFalse child of If
duke@435 995
duke@435 996 // Kill the IfNode
duke@435 997 igvn->remove_dead_node(this);
duke@435 998 }
duke@435 999
duke@435 1000 //------------------------------Identity---------------------------------------
duke@435 1001 // If the test is constant & we match, then we are the input Control
duke@435 1002 Node *IfTrueNode::Identity( PhaseTransform *phase ) {
duke@435 1003 // Can only optimize if cannot go the other way
duke@435 1004 const TypeTuple *t = phase->type(in(0))->is_tuple();
duke@435 1005 return ( t == TypeTuple::IFNEITHER || t == TypeTuple::IFTRUE )
duke@435 1006 ? in(0)->in(0) // IfNode control
duke@435 1007 : this; // no progress
duke@435 1008 }
duke@435 1009
duke@435 1010 //------------------------------dump_spec--------------------------------------
duke@435 1011 #ifndef PRODUCT
duke@435 1012 void IfNode::dump_spec(outputStream *st) const {
duke@435 1013 st->print("P=%f, C=%f",_prob,_fcnt);
duke@435 1014 }
duke@435 1015 #endif
duke@435 1016
duke@435 1017 //------------------------------idealize_test----------------------------------
duke@435 1018 // Try to canonicalize tests better. Peek at the Cmp/Bool/If sequence and
duke@435 1019 // come up with a canonical sequence. Bools getting 'eq', 'gt' and 'ge' forms
duke@435 1020 // converted to 'ne', 'le' and 'lt' forms. IfTrue/IfFalse get swapped as
duke@435 1021 // needed.
duke@435 1022 static IfNode* idealize_test(PhaseGVN* phase, IfNode* iff) {
duke@435 1023 assert(iff->in(0) != NULL, "If must be live");
duke@435 1024
duke@435 1025 if (iff->outcnt() != 2) return NULL; // Malformed projections.
duke@435 1026 Node* old_if_f = iff->proj_out(false);
duke@435 1027 Node* old_if_t = iff->proj_out(true);
duke@435 1028
duke@435 1029 // CountedLoopEnds want the back-control test to be TRUE, irregardless of
duke@435 1030 // whether they are testing a 'gt' or 'lt' condition. The 'gt' condition
duke@435 1031 // happens in count-down loops
duke@435 1032 if (iff->is_CountedLoopEnd()) return NULL;
duke@435 1033 if (!iff->in(1)->is_Bool()) return NULL; // Happens for partially optimized IF tests
duke@435 1034 BoolNode *b = iff->in(1)->as_Bool();
duke@435 1035 BoolTest bt = b->_test;
duke@435 1036 // Test already in good order?
duke@435 1037 if( bt.is_canonical() )
duke@435 1038 return NULL;
duke@435 1039
duke@435 1040 // Flip test to be canonical. Requires flipping the IfFalse/IfTrue and
duke@435 1041 // cloning the IfNode.
duke@435 1042 Node* new_b = phase->transform( new (phase->C, 2) BoolNode(b->in(1), bt.negate()) );
duke@435 1043 if( !new_b->is_Bool() ) return NULL;
duke@435 1044 b = new_b->as_Bool();
duke@435 1045
duke@435 1046 PhaseIterGVN *igvn = phase->is_IterGVN();
duke@435 1047 assert( igvn, "Test is not canonical in parser?" );
duke@435 1048
duke@435 1049 // The IF node never really changes, but it needs to be cloned
duke@435 1050 iff = new (phase->C, 2) IfNode( iff->in(0), b, 1.0-iff->_prob, iff->_fcnt);
duke@435 1051
duke@435 1052 Node *prior = igvn->hash_find_insert(iff);
duke@435 1053 if( prior ) {
duke@435 1054 igvn->remove_dead_node(iff);
duke@435 1055 iff = (IfNode*)prior;
duke@435 1056 } else {
duke@435 1057 // Cannot call transform on it just yet
duke@435 1058 igvn->set_type_bottom(iff);
duke@435 1059 }
duke@435 1060 igvn->_worklist.push(iff);
duke@435 1061
duke@435 1062 // Now handle projections. Cloning not required.
duke@435 1063 Node* new_if_f = (Node*)(new (phase->C, 1) IfFalseNode( iff ));
duke@435 1064 Node* new_if_t = (Node*)(new (phase->C, 1) IfTrueNode ( iff ));
duke@435 1065
duke@435 1066 igvn->register_new_node_with_optimizer(new_if_f);
duke@435 1067 igvn->register_new_node_with_optimizer(new_if_t);
duke@435 1068 igvn->hash_delete(old_if_f);
duke@435 1069 igvn->hash_delete(old_if_t);
duke@435 1070 // Flip test, so flip trailing control
duke@435 1071 igvn->subsume_node(old_if_f, new_if_t);
duke@435 1072 igvn->subsume_node(old_if_t, new_if_f);
duke@435 1073
duke@435 1074 // Progress
duke@435 1075 return iff;
duke@435 1076 }
duke@435 1077
duke@435 1078 //------------------------------Identity---------------------------------------
duke@435 1079 // If the test is constant & we match, then we are the input Control
duke@435 1080 Node *IfFalseNode::Identity( PhaseTransform *phase ) {
duke@435 1081 // Can only optimize if cannot go the other way
duke@435 1082 const TypeTuple *t = phase->type(in(0))->is_tuple();
duke@435 1083 return ( t == TypeTuple::IFNEITHER || t == TypeTuple::IFFALSE )
duke@435 1084 ? in(0)->in(0) // IfNode control
duke@435 1085 : this; // no progress
duke@435 1086 }

mercurial