Mon, 20 Jul 2009 08:20:00 -0700
6860920: serialize.cpp shouldn't use objArrayOopDesc::base_offset_in_bytes(T_BYTE)
Summary: serialize.cpp currently uses objArrayOopDesc::base_offset_in_bytes(T_BYTE), which seems to be wrong.
Reviewed-by: coleenp, kvn
duke@435 | 1 | /* |
xdono@631 | 2 | * Copyright 1997-2008 Sun Microsystems, Inc. All Rights Reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
duke@435 | 19 | * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, |
duke@435 | 20 | * CA 95054 USA or visit www.sun.com if you need additional information or |
duke@435 | 21 | * have any questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
duke@435 | 25 | // An objArrayOop is an array containing oops. |
duke@435 | 26 | // Evaluating "String arg[10]" will create an objArrayOop. |
duke@435 | 27 | |
duke@435 | 28 | class objArrayOopDesc : public arrayOopDesc { |
coleenp@548 | 29 | friend class objArrayKlass; |
coleenp@548 | 30 | friend class Runtime1; |
coleenp@548 | 31 | friend class psPromotionManager; |
ysr@777 | 32 | friend class CSMarkOopClosure; |
ysr@777 | 33 | friend class G1ParScanPartialArrayClosure; |
coleenp@548 | 34 | |
coleenp@548 | 35 | template <class T> T* obj_at_addr(int index) const { |
coleenp@548 | 36 | assert(is_within_bounds(index), "index out of bounds"); |
coleenp@548 | 37 | return &((T*)base())[index]; |
coleenp@548 | 38 | } |
coleenp@548 | 39 | |
duke@435 | 40 | public: |
twisti@1330 | 41 | // Returns the offset of the first element. |
twisti@1330 | 42 | static int base_offset_in_bytes() { |
twisti@1330 | 43 | return arrayOopDesc::base_offset_in_bytes(T_OBJECT); |
twisti@1330 | 44 | } |
twisti@1330 | 45 | |
coleenp@548 | 46 | // base is the address following the header. |
coleenp@548 | 47 | HeapWord* base() const { return (HeapWord*) arrayOopDesc::base(T_OBJECT); } |
coleenp@548 | 48 | |
duke@435 | 49 | // Accessing |
coleenp@548 | 50 | oop obj_at(int index) const { |
coleenp@548 | 51 | // With UseCompressedOops decode the narrow oop in the objArray to an |
coleenp@548 | 52 | // uncompressed oop. Otherwise this is simply a "*" operator. |
coleenp@548 | 53 | if (UseCompressedOops) { |
coleenp@548 | 54 | return load_decode_heap_oop(obj_at_addr<narrowOop>(index)); |
coleenp@548 | 55 | } else { |
coleenp@548 | 56 | return load_decode_heap_oop(obj_at_addr<oop>(index)); |
coleenp@548 | 57 | } |
coleenp@548 | 58 | } |
duke@435 | 59 | |
coleenp@548 | 60 | void obj_at_put(int index, oop value) { |
coleenp@548 | 61 | if (UseCompressedOops) { |
coleenp@548 | 62 | oop_store(obj_at_addr<narrowOop>(index), value); |
coleenp@548 | 63 | } else { |
coleenp@548 | 64 | oop_store(obj_at_addr<oop>(index), value); |
coleenp@548 | 65 | } |
coleenp@548 | 66 | } |
duke@435 | 67 | // Sizing |
coleenp@548 | 68 | static int header_size() { return arrayOopDesc::header_size(T_OBJECT); } |
coleenp@548 | 69 | int object_size() { return object_size(length()); } |
coleenp@548 | 70 | int array_size() { return array_size(length()); } |
duke@435 | 71 | |
coleenp@548 | 72 | static int object_size(int length) { |
coleenp@548 | 73 | // This returns the object size in HeapWords. |
coleenp@548 | 74 | return align_object_size(header_size() + array_size(length)); |
duke@435 | 75 | } |
coleenp@548 | 76 | |
coleenp@548 | 77 | // Give size of objArrayOop in HeapWords minus the header |
coleenp@548 | 78 | static int array_size(int length) { |
coleenp@548 | 79 | // Without UseCompressedOops, this is simply: |
coleenp@548 | 80 | // oop->length() * HeapWordsPerOop; |
coleenp@548 | 81 | // With narrowOops, HeapWordsPerOop is 1/2 or equal 0 as an integer. |
coleenp@548 | 82 | // The oop elements are aligned up to wordSize |
coleenp@548 | 83 | const int HeapWordsPerOop = heapOopSize/HeapWordSize; |
coleenp@548 | 84 | if (HeapWordsPerOop > 0) { |
coleenp@548 | 85 | return length * HeapWordsPerOop; |
coleenp@548 | 86 | } else { |
coleenp@548 | 87 | const int OopsPerHeapWord = HeapWordSize/heapOopSize; |
coleenp@548 | 88 | int word_len = align_size_up(length, OopsPerHeapWord)/OopsPerHeapWord; |
coleenp@548 | 89 | return word_len; |
coleenp@548 | 90 | } |
coleenp@548 | 91 | } |
coleenp@548 | 92 | |
coleenp@548 | 93 | // special iterators for index ranges, returns size of object |
coleenp@548 | 94 | #define ObjArrayOop_OOP_ITERATE_DECL(OopClosureType, nv_suffix) \ |
coleenp@548 | 95 | int oop_iterate_range(OopClosureType* blk, int start, int end); |
coleenp@548 | 96 | |
coleenp@548 | 97 | ALL_OOP_OOP_ITERATE_CLOSURES_1(ObjArrayOop_OOP_ITERATE_DECL) |
ysr@777 | 98 | ALL_OOP_OOP_ITERATE_CLOSURES_2(ObjArrayOop_OOP_ITERATE_DECL) |
duke@435 | 99 | }; |