Wed, 09 Oct 2019 16:11:58 +0800
8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
apetushkov@9858 | 1 | /* |
ddong@9885 | 2 | * Copyright (c) 2017, 2018, Oracle and/or its affiliates. All rights reserved. |
apetushkov@9858 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
apetushkov@9858 | 4 | * |
apetushkov@9858 | 5 | * This code is free software; you can redistribute it and/or modify it |
apetushkov@9858 | 6 | * under the terms of the GNU General Public License version 2 only, as |
apetushkov@9858 | 7 | * published by the Free Software Foundation. |
apetushkov@9858 | 8 | * |
apetushkov@9858 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
apetushkov@9858 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
apetushkov@9858 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
apetushkov@9858 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
apetushkov@9858 | 13 | * accompanied this code). |
apetushkov@9858 | 14 | * |
apetushkov@9858 | 15 | * You should have received a copy of the GNU General Public License version |
apetushkov@9858 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
apetushkov@9858 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
apetushkov@9858 | 18 | * |
apetushkov@9858 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
apetushkov@9858 | 20 | * or visit www.oracle.com if you need additional information or have any |
apetushkov@9858 | 21 | * questions. |
apetushkov@9858 | 22 | * |
apetushkov@9858 | 23 | */ |
apetushkov@9858 | 24 | #include "precompiled.hpp" |
apetushkov@9858 | 25 | #include "jfr/jfrEvents.hpp" |
apetushkov@9858 | 26 | #include "jfr/leakprofiler/sampling/objectSample.hpp" |
apetushkov@9858 | 27 | #include "jfr/leakprofiler/sampling/objectSampler.hpp" |
apetushkov@9858 | 28 | #include "jfr/leakprofiler/sampling/sampleList.hpp" |
apetushkov@9858 | 29 | #include "jfr/leakprofiler/sampling/samplePriorityQueue.hpp" |
apetushkov@9858 | 30 | #include "jfr/recorder/jfrEventSetting.inline.hpp" |
apetushkov@9858 | 31 | #include "jfr/recorder/checkpoint/jfrCheckpointManager.hpp" |
apetushkov@9858 | 32 | #include "jfr/recorder/stacktrace/jfrStackTraceRepository.hpp" |
apetushkov@9858 | 33 | #include "jfr/support/jfrThreadLocal.hpp" |
apetushkov@9858 | 34 | #include "jfr/utilities/jfrTryLock.hpp" |
apetushkov@9858 | 35 | #include "memory/universe.hpp" |
apetushkov@9858 | 36 | #include "oops/oop.inline.hpp" |
ddong@9885 | 37 | #include "runtime/atomic.hpp" |
ddong@9885 | 38 | #include "runtime/orderAccess.hpp" |
ddong@9885 | 39 | #include "runtime/safepoint.hpp" |
apetushkov@9858 | 40 | #include "runtime/thread.hpp" |
apetushkov@9858 | 41 | |
ddong@9885 | 42 | static ObjectSampler* _instance = NULL; |
ddong@9885 | 43 | |
ddong@9885 | 44 | static ObjectSampler& instance() { |
ddong@9885 | 45 | assert(_instance != NULL, "invariant"); |
ddong@9885 | 46 | return *_instance; |
ddong@9885 | 47 | } |
ddong@9885 | 48 | |
apetushkov@9858 | 49 | ObjectSampler::ObjectSampler(size_t size) : |
apetushkov@9858 | 50 | _priority_queue(new SamplePriorityQueue(size)), |
apetushkov@9858 | 51 | _list(new SampleList(size)), |
apetushkov@9858 | 52 | _last_sweep(JfrTicks::now()), |
apetushkov@9858 | 53 | _total_allocated(0), |
apetushkov@9858 | 54 | _threshold(0), |
apetushkov@9858 | 55 | _size(size), |
apetushkov@9858 | 56 | _dead_samples(false) {} |
apetushkov@9858 | 57 | |
apetushkov@9858 | 58 | ObjectSampler::~ObjectSampler() { |
apetushkov@9858 | 59 | delete _priority_queue; |
apetushkov@9858 | 60 | _priority_queue = NULL; |
apetushkov@9858 | 61 | delete _list; |
apetushkov@9858 | 62 | _list = NULL; |
apetushkov@9858 | 63 | } |
apetushkov@9858 | 64 | |
ddong@9885 | 65 | bool ObjectSampler::create(size_t size) { |
ddong@9885 | 66 | assert(SafepointSynchronize::is_at_safepoint(), "invariant"); |
ddong@9885 | 67 | assert(_instance == NULL, "invariant"); |
ddong@9885 | 68 | _instance = new ObjectSampler(size); |
ddong@9885 | 69 | return _instance != NULL; |
ddong@9885 | 70 | } |
ddong@9885 | 71 | |
ddong@9885 | 72 | bool ObjectSampler::is_created() { |
ddong@9885 | 73 | return _instance != NULL; |
ddong@9885 | 74 | } |
ddong@9885 | 75 | |
ddong@9885 | 76 | ObjectSampler* ObjectSampler::sampler() { |
ddong@9885 | 77 | assert(is_created(), "invariant"); |
ddong@9885 | 78 | return _instance; |
ddong@9885 | 79 | } |
ddong@9885 | 80 | |
ddong@9885 | 81 | void ObjectSampler::destroy() { |
ddong@9885 | 82 | assert(SafepointSynchronize::is_at_safepoint(), "invariant"); |
ddong@9885 | 83 | if (_instance != NULL) { |
ddong@9885 | 84 | ObjectSampler* const sampler = _instance; |
ddong@9885 | 85 | _instance = NULL; |
ddong@9885 | 86 | delete sampler; |
ddong@9885 | 87 | } |
ddong@9885 | 88 | } |
ddong@9885 | 89 | |
ddong@9885 | 90 | static volatile int _lock = 0; |
ddong@9885 | 91 | |
ddong@9885 | 92 | ObjectSampler* ObjectSampler::acquire() { |
ddong@9885 | 93 | assert(is_created(), "invariant"); |
ddong@9885 | 94 | while (Atomic::cmpxchg(1, &_lock, 0) == 1) {} |
ddong@9885 | 95 | return _instance; |
ddong@9885 | 96 | } |
ddong@9885 | 97 | |
ddong@9885 | 98 | void ObjectSampler::release() { |
ddong@9885 | 99 | assert(is_created(), "invariant"); |
ddong@9885 | 100 | OrderAccess::fence(); |
ddong@9885 | 101 | _lock = 0; |
ddong@9885 | 102 | } |
ddong@9885 | 103 | |
ddong@9885 | 104 | static traceid get_thread_id(JavaThread* thread) { |
apetushkov@9858 | 105 | assert(thread != NULL, "invariant"); |
ddong@9885 | 106 | if (thread->threadObj() == NULL) { |
ddong@9885 | 107 | return 0; |
ddong@9885 | 108 | } |
ddong@9885 | 109 | const JfrThreadLocal* const tl = thread->jfr_thread_local(); |
ddong@9885 | 110 | assert(tl != NULL, "invariant"); |
ddong@9885 | 111 | if (!tl->has_thread_checkpoint()) { |
ddong@9885 | 112 | JfrCheckpointManager::create_thread_checkpoint(thread); |
ddong@9885 | 113 | } |
ddong@9885 | 114 | assert(tl->has_thread_checkpoint(), "invariant"); |
ddong@9885 | 115 | return tl->thread_id(); |
ddong@9885 | 116 | } |
ddong@9885 | 117 | |
ddong@9885 | 118 | // Populates the thread local stack frames, but does not add them |
ddong@9885 | 119 | // to the stacktrace repository (...yet, see stacktrace_id() below) |
ddong@9885 | 120 | // |
ddong@9885 | 121 | void ObjectSampler::fill_stacktrace(JfrStackTrace* stacktrace, JavaThread* thread) { |
ddong@9885 | 122 | assert(stacktrace != NULL, "invariant"); |
ddong@9885 | 123 | assert(thread != NULL, "invariant"); |
ddong@9885 | 124 | if (JfrEventSetting::has_stacktrace(EventOldObjectSample::eventId)) { |
ddong@9885 | 125 | JfrStackTraceRepository::fill_stacktrace_for(thread, stacktrace, 0); |
ddong@9885 | 126 | } |
ddong@9885 | 127 | } |
ddong@9885 | 128 | |
ddong@9885 | 129 | // We were successful in acquiring the try lock and have been selected for adding a sample. |
ddong@9885 | 130 | // Go ahead with installing our previously taken stacktrace into the stacktrace repository. |
ddong@9885 | 131 | // |
ddong@9885 | 132 | traceid ObjectSampler::stacktrace_id(const JfrStackTrace* stacktrace, JavaThread* thread) { |
ddong@9885 | 133 | assert(stacktrace != NULL, "invariant"); |
ddong@9885 | 134 | assert(stacktrace->hash() != 0, "invariant"); |
ddong@9885 | 135 | const traceid stacktrace_id = JfrStackTraceRepository::add(stacktrace, thread); |
ddong@9885 | 136 | thread->jfr_thread_local()->set_cached_stack_trace_id(stacktrace_id, stacktrace->hash()); |
ddong@9885 | 137 | return stacktrace_id; |
ddong@9885 | 138 | } |
ddong@9885 | 139 | |
ddong@9885 | 140 | void ObjectSampler::sample(HeapWord* obj, size_t allocated, JavaThread* thread) { |
ddong@9885 | 141 | assert(thread != NULL, "invariant"); |
ddong@9885 | 142 | assert(is_created(), "invariant"); |
ddong@9885 | 143 | |
ddong@9885 | 144 | const traceid thread_id = get_thread_id(thread); |
apetushkov@9858 | 145 | if (thread_id == 0) { |
apetushkov@9858 | 146 | return; |
apetushkov@9858 | 147 | } |
ddong@9885 | 148 | const JfrThreadLocal* const tl = thread->jfr_thread_local(); |
ddong@9885 | 149 | JfrStackTrace stacktrace(tl->stackframes(), tl->stackdepth()); |
ddong@9885 | 150 | fill_stacktrace(&stacktrace, thread); |
apetushkov@9858 | 151 | |
ddong@9885 | 152 | // try enter critical section |
ddong@9885 | 153 | JfrTryLock tryLock(&_lock); |
apetushkov@9858 | 154 | if (!tryLock.has_lock()) { |
apetushkov@9858 | 155 | if (LogJFR && Verbose) tty->print_cr("Skipping old object sample due to lock contention"); |
apetushkov@9858 | 156 | return; |
apetushkov@9858 | 157 | } |
apetushkov@9858 | 158 | |
ddong@9885 | 159 | instance().add(obj, allocated, thread_id, &stacktrace, thread); |
ddong@9885 | 160 | } |
ddong@9885 | 161 | |
ddong@9885 | 162 | void ObjectSampler::add(HeapWord* obj, size_t allocated, traceid thread_id, JfrStackTrace* stacktrace, JavaThread* thread) { |
ddong@9885 | 163 | assert(stacktrace != NULL, "invariant"); |
ddong@9885 | 164 | assert(thread_id != 0, "invariant"); |
ddong@9885 | 165 | assert(thread != NULL, "invariant"); |
ddong@9885 | 166 | assert(thread->jfr_thread_local()->has_thread_checkpoint(), "invariant"); |
ddong@9885 | 167 | |
apetushkov@9858 | 168 | if (_dead_samples) { |
apetushkov@9858 | 169 | scavenge(); |
apetushkov@9858 | 170 | assert(!_dead_samples, "invariant"); |
apetushkov@9858 | 171 | } |
apetushkov@9858 | 172 | |
apetushkov@9858 | 173 | _total_allocated += allocated; |
apetushkov@9858 | 174 | const size_t span = _total_allocated - _priority_queue->total(); |
apetushkov@9858 | 175 | ObjectSample* sample; |
apetushkov@9858 | 176 | if ((size_t)_priority_queue->count() == _size) { |
apetushkov@9858 | 177 | assert(_list->count() == _size, "invariant"); |
apetushkov@9858 | 178 | const ObjectSample* peek = _priority_queue->peek(); |
apetushkov@9858 | 179 | if (peek->span() > span) { |
apetushkov@9858 | 180 | // quick reject, will not fit |
apetushkov@9858 | 181 | return; |
apetushkov@9858 | 182 | } |
apetushkov@9858 | 183 | sample = _list->reuse(_priority_queue->pop()); |
apetushkov@9858 | 184 | } else { |
apetushkov@9858 | 185 | sample = _list->get(); |
apetushkov@9858 | 186 | } |
apetushkov@9858 | 187 | |
apetushkov@9858 | 188 | assert(sample != NULL, "invariant"); |
apetushkov@9858 | 189 | sample->set_thread_id(thread_id); |
apetushkov@9858 | 190 | sample->set_thread_checkpoint(thread->jfr_thread_local()->thread_checkpoint()); |
apetushkov@9858 | 191 | |
ddong@9885 | 192 | const unsigned int stacktrace_hash = stacktrace->hash(); |
ddong@9885 | 193 | if (stacktrace_hash != 0) { |
ddong@9885 | 194 | sample->set_stack_trace_id(stacktrace_id(stacktrace, thread)); |
ddong@9885 | 195 | sample->set_stack_trace_hash(stacktrace_hash); |
apetushkov@9858 | 196 | } |
apetushkov@9858 | 197 | |
apetushkov@9858 | 198 | sample->set_span(allocated); |
apetushkov@9858 | 199 | sample->set_object((oop)obj); |
apetushkov@9858 | 200 | sample->set_allocated(allocated); |
apetushkov@9858 | 201 | sample->set_allocation_time(JfrTicks::now()); |
apetushkov@9858 | 202 | sample->set_heap_used_at_last_gc(Universe::get_heap_used_at_last_gc()); |
apetushkov@9858 | 203 | _priority_queue->push(sample); |
apetushkov@9858 | 204 | } |
apetushkov@9858 | 205 | |
ddong@9885 | 206 | void ObjectSampler::scavenge() { |
ddong@9885 | 207 | ObjectSample* current = _list->last(); |
ddong@9885 | 208 | while (current != NULL) { |
ddong@9885 | 209 | ObjectSample* next = current->next(); |
ddong@9885 | 210 | if (current->is_dead()) { |
ddong@9885 | 211 | remove_dead(current); |
ddong@9885 | 212 | } |
ddong@9885 | 213 | current = next; |
ddong@9885 | 214 | } |
ddong@9885 | 215 | _dead_samples = false; |
ddong@9885 | 216 | } |
ddong@9885 | 217 | |
ddong@9885 | 218 | void ObjectSampler::remove_dead(ObjectSample* sample) { |
ddong@9885 | 219 | assert(sample != NULL, "invariant"); |
ddong@9885 | 220 | assert(sample->is_dead(), "invariant"); |
ddong@9885 | 221 | ObjectSample* const previous = sample->prev(); |
ddong@9885 | 222 | // push span on to previous |
ddong@9885 | 223 | if (previous != NULL) { |
ddong@9885 | 224 | _priority_queue->remove(previous); |
ddong@9885 | 225 | previous->add_span(sample->span()); |
ddong@9885 | 226 | _priority_queue->push(previous); |
ddong@9885 | 227 | } |
ddong@9885 | 228 | _priority_queue->remove(sample); |
ddong@9885 | 229 | _list->release(sample); |
ddong@9885 | 230 | } |
ddong@9885 | 231 | |
ddong@9885 | 232 | void ObjectSampler::oops_do(BoolObjectClosure* is_alive, OopClosure* f) { |
ddong@9885 | 233 | assert(is_created(), "invariant"); |
ddong@9885 | 234 | assert(SafepointSynchronize::is_at_safepoint(), "invariant"); |
ddong@9885 | 235 | ObjectSampler& sampler = instance(); |
ddong@9885 | 236 | ObjectSample* current = sampler._list->last(); |
ddong@9885 | 237 | while (current != NULL) { |
ddong@9885 | 238 | ObjectSample* next = current->next(); |
ddong@9885 | 239 | if (!current->is_dead()) { |
ddong@9885 | 240 | if (is_alive->do_object_b(current->object())) { |
ddong@9885 | 241 | // The weakly referenced object is alive, update pointer |
ddong@9885 | 242 | f->do_oop(const_cast<oop*>(current->object_addr())); |
ddong@9885 | 243 | } else { |
ddong@9885 | 244 | current->set_dead(); |
ddong@9885 | 245 | sampler._dead_samples = true; |
ddong@9885 | 246 | } |
ddong@9885 | 247 | } |
ddong@9885 | 248 | current = next; |
ddong@9885 | 249 | } |
ddong@9885 | 250 | sampler._last_sweep = JfrTicks::now(); |
ddong@9885 | 251 | } |
ddong@9885 | 252 | |
apetushkov@9858 | 253 | const ObjectSample* ObjectSampler::last() const { |
apetushkov@9858 | 254 | return _list->last(); |
apetushkov@9858 | 255 | } |
apetushkov@9858 | 256 | |
egahlin@9867 | 257 | const ObjectSample* ObjectSampler::first() const { |
egahlin@9867 | 258 | return _list->first(); |
egahlin@9867 | 259 | } |
egahlin@9867 | 260 | |
apetushkov@9858 | 261 | const ObjectSample* ObjectSampler::last_resolved() const { |
apetushkov@9858 | 262 | return _list->last_resolved(); |
apetushkov@9858 | 263 | } |
apetushkov@9858 | 264 | |
apetushkov@9858 | 265 | void ObjectSampler::set_last_resolved(const ObjectSample* sample) { |
apetushkov@9858 | 266 | _list->set_last_resolved(sample); |
apetushkov@9858 | 267 | } |
apetushkov@9858 | 268 | |
apetushkov@9858 | 269 | int ObjectSampler::item_count() const { |
apetushkov@9858 | 270 | return _priority_queue->count(); |
apetushkov@9858 | 271 | } |
apetushkov@9858 | 272 | |
apetushkov@9858 | 273 | const ObjectSample* ObjectSampler::item_at(int index) const { |
apetushkov@9858 | 274 | return _priority_queue->item_at(index); |
apetushkov@9858 | 275 | } |
apetushkov@9858 | 276 | |
apetushkov@9858 | 277 | ObjectSample* ObjectSampler::item_at(int index) { |
apetushkov@9858 | 278 | return const_cast<ObjectSample*>( |
apetushkov@9858 | 279 | const_cast<const ObjectSampler*>(this)->item_at(index) |
ddong@9885 | 280 | ); |
apetushkov@9858 | 281 | } |
apetushkov@9858 | 282 | |
apetushkov@9858 | 283 | const JfrTicks& ObjectSampler::last_sweep() const { |
apetushkov@9858 | 284 | return _last_sweep; |
apetushkov@9858 | 285 | } |