Tue, 28 Sep 2010 15:56:15 -0700
6423256: GC stacks should use a better data structure
6942771: SEGV in ParScanThreadState::take_from_overflow_stack
Reviewed-by: apetrusenko, ysr, pbk
duke@435 | 1 | /* |
jcoomes@1993 | 2 | * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
duke@435 | 25 | #include "incls/_precompiled.incl" |
duke@435 | 26 | #include "incls/_psCompactionManager.cpp.incl" |
duke@435 | 27 | |
duke@435 | 28 | PSOldGen* ParCompactionManager::_old_gen = NULL; |
duke@435 | 29 | ParCompactionManager** ParCompactionManager::_manager_array = NULL; |
duke@435 | 30 | OopTaskQueueSet* ParCompactionManager::_stack_array = NULL; |
jcoomes@1746 | 31 | ParCompactionManager::ObjArrayTaskQueueSet* |
jcoomes@1746 | 32 | ParCompactionManager::_objarray_queues = NULL; |
duke@435 | 33 | ObjectStartArray* ParCompactionManager::_start_array = NULL; |
duke@435 | 34 | ParMarkBitMap* ParCompactionManager::_mark_bitmap = NULL; |
jcoomes@1993 | 35 | RegionTaskQueueSet* ParCompactionManager::_region_array = NULL; |
duke@435 | 36 | |
duke@435 | 37 | ParCompactionManager::ParCompactionManager() : |
duke@435 | 38 | _action(CopyAndUpdate) { |
duke@435 | 39 | |
duke@435 | 40 | ParallelScavengeHeap* heap = (ParallelScavengeHeap*)Universe::heap(); |
duke@435 | 41 | assert(heap->kind() == CollectedHeap::ParallelScavengeHeap, "Sanity"); |
duke@435 | 42 | |
duke@435 | 43 | _old_gen = heap->old_gen(); |
duke@435 | 44 | _start_array = old_gen()->start_array(); |
duke@435 | 45 | |
duke@435 | 46 | marking_stack()->initialize(); |
jcoomes@1993 | 47 | _objarray_stack.initialize(); |
jcoomes@810 | 48 | region_stack()->initialize(); |
duke@435 | 49 | } |
duke@435 | 50 | |
duke@435 | 51 | void ParCompactionManager::initialize(ParMarkBitMap* mbm) { |
duke@435 | 52 | assert(PSParallelCompact::gc_task_manager() != NULL, |
duke@435 | 53 | "Needed for initialization"); |
duke@435 | 54 | |
duke@435 | 55 | _mark_bitmap = mbm; |
duke@435 | 56 | |
duke@435 | 57 | uint parallel_gc_threads = PSParallelCompact::gc_task_manager()->workers(); |
duke@435 | 58 | |
duke@435 | 59 | assert(_manager_array == NULL, "Attempt to initialize twice"); |
duke@435 | 60 | _manager_array = NEW_C_HEAP_ARRAY(ParCompactionManager*, parallel_gc_threads+1 ); |
jcoomes@1746 | 61 | guarantee(_manager_array != NULL, "Could not allocate manager_array"); |
duke@435 | 62 | |
duke@435 | 63 | _stack_array = new OopTaskQueueSet(parallel_gc_threads); |
jcoomes@1746 | 64 | guarantee(_stack_array != NULL, "Could not allocate stack_array"); |
jcoomes@1746 | 65 | _objarray_queues = new ObjArrayTaskQueueSet(parallel_gc_threads); |
jcoomes@1746 | 66 | guarantee(_objarray_queues != NULL, "Could not allocate objarray_queues"); |
jcoomes@810 | 67 | _region_array = new RegionTaskQueueSet(parallel_gc_threads); |
jcoomes@1746 | 68 | guarantee(_region_array != NULL, "Could not allocate region_array"); |
duke@435 | 69 | |
duke@435 | 70 | // Create and register the ParCompactionManager(s) for the worker threads. |
duke@435 | 71 | for(uint i=0; i<parallel_gc_threads; i++) { |
duke@435 | 72 | _manager_array[i] = new ParCompactionManager(); |
duke@435 | 73 | guarantee(_manager_array[i] != NULL, "Could not create ParCompactionManager"); |
duke@435 | 74 | stack_array()->register_queue(i, _manager_array[i]->marking_stack()); |
jcoomes@1993 | 75 | _objarray_queues->register_queue(i, &_manager_array[i]->_objarray_stack); |
jcoomes@810 | 76 | region_array()->register_queue(i, _manager_array[i]->region_stack()); |
duke@435 | 77 | } |
duke@435 | 78 | |
duke@435 | 79 | // The VMThread gets its own ParCompactionManager, which is not available |
duke@435 | 80 | // for work stealing. |
duke@435 | 81 | _manager_array[parallel_gc_threads] = new ParCompactionManager(); |
duke@435 | 82 | guarantee(_manager_array[parallel_gc_threads] != NULL, |
duke@435 | 83 | "Could not create ParCompactionManager"); |
duke@435 | 84 | assert(PSParallelCompact::gc_task_manager()->workers() != 0, |
duke@435 | 85 | "Not initialized?"); |
duke@435 | 86 | } |
duke@435 | 87 | |
duke@435 | 88 | bool ParCompactionManager::should_update() { |
duke@435 | 89 | assert(action() != NotValid, "Action is not set"); |
duke@435 | 90 | return (action() == ParCompactionManager::Update) || |
duke@435 | 91 | (action() == ParCompactionManager::CopyAndUpdate) || |
duke@435 | 92 | (action() == ParCompactionManager::UpdateAndCopy); |
duke@435 | 93 | } |
duke@435 | 94 | |
duke@435 | 95 | bool ParCompactionManager::should_copy() { |
duke@435 | 96 | assert(action() != NotValid, "Action is not set"); |
duke@435 | 97 | return (action() == ParCompactionManager::Copy) || |
duke@435 | 98 | (action() == ParCompactionManager::CopyAndUpdate) || |
duke@435 | 99 | (action() == ParCompactionManager::UpdateAndCopy); |
duke@435 | 100 | } |
duke@435 | 101 | |
duke@435 | 102 | bool ParCompactionManager::should_verify_only() { |
duke@435 | 103 | assert(action() != NotValid, "Action is not set"); |
duke@435 | 104 | return action() == ParCompactionManager::VerifyUpdate; |
duke@435 | 105 | } |
duke@435 | 106 | |
duke@435 | 107 | bool ParCompactionManager::should_reset_only() { |
duke@435 | 108 | assert(action() != NotValid, "Action is not set"); |
duke@435 | 109 | return action() == ParCompactionManager::ResetObjects; |
duke@435 | 110 | } |
duke@435 | 111 | |
duke@435 | 112 | ParCompactionManager* |
duke@435 | 113 | ParCompactionManager::gc_thread_compaction_manager(int index) { |
duke@435 | 114 | assert(index >= 0 && index < (int)ParallelGCThreads, "index out of range"); |
duke@435 | 115 | assert(_manager_array != NULL, "Sanity"); |
duke@435 | 116 | return _manager_array[index]; |
duke@435 | 117 | } |
duke@435 | 118 | |
duke@435 | 119 | void ParCompactionManager::reset() { |
jcoomes@2191 | 120 | for(uint i = 0; i < ParallelGCThreads + 1; i++) { |
jcoomes@2191 | 121 | assert(manager_array(i)->revisit_klass_stack()->is_empty(), "sanity"); |
jcoomes@2191 | 122 | assert(manager_array(i)->revisit_mdo_stack()->is_empty(), "sanity"); |
duke@435 | 123 | } |
duke@435 | 124 | } |
duke@435 | 125 | |
jcoomes@1746 | 126 | void ParCompactionManager::follow_marking_stacks() { |
duke@435 | 127 | do { |
jcoomes@1746 | 128 | // Drain the overflow stack first, to allow stealing from the marking stack. |
jcoomes@1750 | 129 | oop obj; |
jcoomes@1993 | 130 | while (marking_stack()->pop_overflow(obj)) { |
jcoomes@1993 | 131 | obj->follow_contents(this); |
jcoomes@1746 | 132 | } |
jcoomes@1746 | 133 | while (marking_stack()->pop_local(obj)) { |
duke@435 | 134 | obj->follow_contents(this); |
duke@435 | 135 | } |
duke@435 | 136 | |
jcoomes@1750 | 137 | // Process ObjArrays one at a time to avoid marking stack bloat. |
jcoomes@1746 | 138 | ObjArrayTask task; |
jcoomes@1993 | 139 | if (_objarray_stack.pop_overflow(task)) { |
jcoomes@1746 | 140 | objArrayKlass* const k = (objArrayKlass*)task.obj()->blueprint(); |
jcoomes@1746 | 141 | k->oop_follow_contents(this, task.obj(), task.index()); |
jcoomes@1993 | 142 | } else if (_objarray_stack.pop_local(task)) { |
jcoomes@1746 | 143 | objArrayKlass* const k = (objArrayKlass*)task.obj()->blueprint(); |
jcoomes@1746 | 144 | k->oop_follow_contents(this, task.obj(), task.index()); |
jcoomes@1746 | 145 | } |
jcoomes@1746 | 146 | } while (!marking_stacks_empty()); |
duke@435 | 147 | |
jcoomes@1746 | 148 | assert(marking_stacks_empty(), "Sanity"); |
duke@435 | 149 | } |
duke@435 | 150 | |
jcoomes@810 | 151 | void ParCompactionManager::drain_region_stacks() { |
duke@435 | 152 | do { |
jcoomes@1993 | 153 | // Drain overflow stack first so other threads can steal. |
jcoomes@1993 | 154 | size_t region_index; |
jcoomes@1993 | 155 | while (region_stack()->pop_overflow(region_index)) { |
jcoomes@810 | 156 | PSParallelCompact::fill_and_update_region(this, region_index); |
duke@435 | 157 | } |
duke@435 | 158 | |
jcoomes@1993 | 159 | while (region_stack()->pop_local(region_index)) { |
jcoomes@810 | 160 | PSParallelCompact::fill_and_update_region(this, region_index); |
duke@435 | 161 | } |
jcoomes@810 | 162 | } while (!region_stack()->is_empty()); |
duke@435 | 163 | } |