src/share/vm/code/vtableStubs.cpp

Fri, 30 Mar 2018 20:09:45 +0000

author
poonam
date
Fri, 30 Mar 2018 20:09:45 +0000
changeset 9185
82f9d3b7e317
parent 6680
78bbf4d43a14
child 9203
53eec13fbaa5
child 9834
bb1da64b0492
permissions
-rw-r--r--

8199406: Performance drop with Java JDK 1.8.0_162-b32
Summary: Improve the nmethod unloading times by optimizing the search for an itable stub in VtableStubs array
Reviewed-by: kvn, coleenp, tschatzl

duke@435 1 /*
poonam@9185 2 * Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved.
duke@435 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@435 4 *
duke@435 5 * This code is free software; you can redistribute it and/or modify it
duke@435 6 * under the terms of the GNU General Public License version 2 only, as
duke@435 7 * published by the Free Software Foundation.
duke@435 8 *
duke@435 9 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@435 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@435 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@435 12 * version 2 for more details (a copy is included in the LICENSE file that
duke@435 13 * accompanied this code).
duke@435 14 *
duke@435 15 * You should have received a copy of the GNU General Public License version
duke@435 16 * 2 along with this work; if not, write to the Free Software Foundation,
duke@435 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@435 18 *
trims@1907 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
trims@1907 20 * or visit www.oracle.com if you need additional information or have any
trims@1907 21 * questions.
duke@435 22 *
duke@435 23 */
duke@435 24
stefank@2314 25 #include "precompiled.hpp"
stefank@2314 26 #include "code/vtableStubs.hpp"
stefank@2314 27 #include "compiler/disassembler.hpp"
stefank@2314 28 #include "memory/allocation.inline.hpp"
stefank@2314 29 #include "memory/resourceArea.hpp"
stefank@2314 30 #include "oops/instanceKlass.hpp"
stefank@2314 31 #include "oops/klassVtable.hpp"
stefank@2314 32 #include "oops/oop.inline.hpp"
stefank@2314 33 #include "prims/forte.hpp"
stefank@2314 34 #include "prims/jvmtiExport.hpp"
stefank@2314 35 #include "runtime/handles.inline.hpp"
stefank@2314 36 #include "runtime/mutexLocker.hpp"
stefank@2314 37 #include "runtime/sharedRuntime.hpp"
stefank@2314 38 #ifdef COMPILER2
stefank@2314 39 #include "opto/matcher.hpp"
stefank@2314 40 #endif
duke@435 41
drchase@6680 42 PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC
drchase@6680 43
duke@435 44 // -----------------------------------------------------------------------------------------
duke@435 45 // Implementation of VtableStub
duke@435 46
duke@435 47 address VtableStub::_chunk = NULL;
duke@435 48 address VtableStub::_chunk_end = NULL;
duke@435 49 VMReg VtableStub::_receiver_location = VMRegImpl::Bad();
duke@435 50
duke@435 51
coleenp@5614 52 void* VtableStub::operator new(size_t size, int code_size) throw() {
duke@435 53 assert(size == sizeof(VtableStub), "mismatched size");
duke@435 54 // compute real VtableStub size (rounded to nearest word)
duke@435 55 const int real_size = round_to(code_size + sizeof(VtableStub), wordSize);
duke@435 56 // malloc them in chunks to minimize header overhead
duke@435 57 const int chunk_factor = 32;
duke@435 58 if (_chunk == NULL || _chunk + real_size > _chunk_end) {
duke@435 59 const int bytes = chunk_factor * real_size + pd_code_alignment();
sspitsyn@6310 60
sspitsyn@6310 61 // There is a dependency on the name of the blob in src/share/vm/prims/jvmtiCodeBlobEvents.cpp
sspitsyn@6310 62 // If changing the name, update the other file accordingly.
poonam@9185 63 VtableBlob* blob = VtableBlob::create("vtable chunks", bytes);
jcoomes@1845 64 if (blob == NULL) {
anoll@5762 65 return NULL;
jcoomes@1845 66 }
twisti@2103 67 _chunk = blob->content_begin();
duke@435 68 _chunk_end = _chunk + bytes;
duke@435 69 Forte::register_stub("vtable stub", _chunk, _chunk_end);
duke@435 70 align_chunk();
duke@435 71 }
duke@435 72 assert(_chunk + real_size <= _chunk_end, "bad allocation");
duke@435 73 void* res = _chunk;
duke@435 74 _chunk += real_size;
duke@435 75 align_chunk();
duke@435 76 return res;
duke@435 77 }
duke@435 78
duke@435 79
bobv@2036 80 void VtableStub::print_on(outputStream* st) const {
bobv@2036 81 st->print("vtable stub (index = %d, receiver_location = %d, code = [" INTPTR_FORMAT ", " INTPTR_FORMAT "[)",
duke@435 82 index(), receiver_location(), code_begin(), code_end());
duke@435 83 }
duke@435 84
duke@435 85
duke@435 86 // -----------------------------------------------------------------------------------------
duke@435 87 // Implementation of VtableStubs
duke@435 88 //
duke@435 89 // For each hash value there's a linked list of vtable stubs (with that
duke@435 90 // hash value). Each list is anchored in a little hash _table, indexed
duke@435 91 // by that hash value.
duke@435 92
duke@435 93 VtableStub* VtableStubs::_table[VtableStubs::N];
duke@435 94 int VtableStubs::_number_of_vtable_stubs = 0;
duke@435 95
duke@435 96
duke@435 97 void VtableStubs::initialize() {
duke@435 98 VtableStub::_receiver_location = SharedRuntime::name_for_receiver();
duke@435 99 {
duke@435 100 MutexLocker ml(VtableStubs_lock);
duke@435 101 assert(_number_of_vtable_stubs == 0, "potential performance bug: VtableStubs initialized more than once");
duke@435 102 assert(is_power_of_2(N), "N must be a power of 2");
duke@435 103 for (int i = 0; i < N; i++) {
duke@435 104 _table[i] = NULL;
duke@435 105 }
duke@435 106 }
duke@435 107 }
duke@435 108
duke@435 109
drchase@5732 110 address VtableStubs::find_stub(bool is_vtable_stub, int vtable_index) {
duke@435 111 assert(vtable_index >= 0, "must be positive");
duke@435 112
duke@435 113 VtableStub* s = ShareVtableStubs ? lookup(is_vtable_stub, vtable_index) : NULL;
duke@435 114 if (s == NULL) {
duke@435 115 if (is_vtable_stub) {
duke@435 116 s = create_vtable_stub(vtable_index);
duke@435 117 } else {
duke@435 118 s = create_itable_stub(vtable_index);
duke@435 119 }
anoll@5762 120
anoll@5762 121 // Creation of vtable or itable can fail if there is not enough free space in the code cache.
anoll@5762 122 if (s == NULL) {
anoll@5762 123 return NULL;
anoll@5762 124 }
anoll@5762 125
duke@435 126 enter(is_vtable_stub, vtable_index, s);
duke@435 127 if (PrintAdapterHandlers) {
duke@435 128 tty->print_cr("Decoding VtableStub %s[%d]@%d",
duke@435 129 is_vtable_stub? "vtbl": "itbl", vtable_index, VtableStub::receiver_location());
duke@435 130 Disassembler::decode(s->code_begin(), s->code_end());
duke@435 131 }
sspitsyn@6310 132 // Notify JVMTI about this stub. The event will be recorded by the enclosing
sspitsyn@6310 133 // JvmtiDynamicCodeEventCollector and posted when this thread has released
sspitsyn@6310 134 // all locks.
sspitsyn@6310 135 if (JvmtiExport::should_post_dynamic_code_generated()) {
sspitsyn@6310 136 JvmtiExport::post_dynamic_code_generated_while_holding_locks(is_vtable_stub? "vtable stub": "itable stub",
sspitsyn@6310 137 s->code_begin(), s->code_end());
sspitsyn@6310 138 }
duke@435 139 }
duke@435 140 return s->entry_point();
duke@435 141 }
duke@435 142
duke@435 143
duke@435 144 inline uint VtableStubs::hash(bool is_vtable_stub, int vtable_index){
duke@435 145 // Assumption: receiver_location < 4 in most cases.
duke@435 146 int hash = ((vtable_index << 2) ^ VtableStub::receiver_location()->value()) + vtable_index;
duke@435 147 return (is_vtable_stub ? ~hash : hash) & mask;
duke@435 148 }
duke@435 149
duke@435 150
duke@435 151 VtableStub* VtableStubs::lookup(bool is_vtable_stub, int vtable_index) {
duke@435 152 MutexLocker ml(VtableStubs_lock);
duke@435 153 unsigned hash = VtableStubs::hash(is_vtable_stub, vtable_index);
duke@435 154 VtableStub* s = _table[hash];
duke@435 155 while( s && !s->matches(is_vtable_stub, vtable_index)) s = s->next();
duke@435 156 return s;
duke@435 157 }
duke@435 158
duke@435 159
duke@435 160 void VtableStubs::enter(bool is_vtable_stub, int vtable_index, VtableStub* s) {
duke@435 161 MutexLocker ml(VtableStubs_lock);
duke@435 162 assert(s->matches(is_vtable_stub, vtable_index), "bad vtable stub");
duke@435 163 unsigned int h = VtableStubs::hash(is_vtable_stub, vtable_index);
duke@435 164 // enter s at the beginning of the corresponding list
duke@435 165 s->set_next(_table[h]);
duke@435 166 _table[h] = s;
duke@435 167 _number_of_vtable_stubs++;
duke@435 168 }
duke@435 169
poonam@9185 170 VtableStub* VtableStubs::entry_point(address pc) {
duke@435 171 MutexLocker ml(VtableStubs_lock);
duke@435 172 VtableStub* stub = (VtableStub*)(pc - VtableStub::entry_offset());
duke@435 173 uint hash = VtableStubs::hash(stub->is_vtable_stub(), stub->index());
duke@435 174 VtableStub* s;
duke@435 175 for (s = _table[hash]; s != NULL && s != stub; s = s->next()) {}
poonam@9185 176 if (s == stub) {
poonam@9185 177 return s;
poonam@9185 178 }
poonam@9185 179 return NULL;
duke@435 180 }
duke@435 181
duke@435 182 bool VtableStubs::contains(address pc) {
duke@435 183 // simple solution for now - we may want to use
duke@435 184 // a faster way if this function is called often
duke@435 185 return stub_containing(pc) != NULL;
duke@435 186 }
duke@435 187
duke@435 188
duke@435 189 VtableStub* VtableStubs::stub_containing(address pc) {
duke@435 190 // Note: No locking needed since any change to the data structure
duke@435 191 // happens with an atomic store into it (we don't care about
duke@435 192 // consistency with the _number_of_vtable_stubs counter).
duke@435 193 for (int i = 0; i < N; i++) {
duke@435 194 for (VtableStub* s = _table[i]; s != NULL; s = s->next()) {
duke@435 195 if (s->contains(pc)) return s;
duke@435 196 }
duke@435 197 }
duke@435 198 return NULL;
duke@435 199 }
duke@435 200
duke@435 201 void vtableStubs_init() {
duke@435 202 VtableStubs::initialize();
duke@435 203 }
duke@435 204
sspitsyn@6310 205 void VtableStubs::vtable_stub_do(void f(VtableStub*)) {
sspitsyn@6310 206 for (int i = 0; i < N; i++) {
sspitsyn@6310 207 for (VtableStub* s = _table[i]; s != NULL; s = s->next()) {
sspitsyn@6310 208 f(s);
sspitsyn@6310 209 }
sspitsyn@6310 210 }
sspitsyn@6310 211 }
sspitsyn@6310 212
duke@435 213
duke@435 214 //-----------------------------------------------------------------------------------------------------
duke@435 215 // Non-product code
duke@435 216 #ifndef PRODUCT
duke@435 217
duke@435 218 extern "C" void bad_compiled_vtable_index(JavaThread* thread, oop receiver, int index) {
duke@435 219 ResourceMark rm;
duke@435 220 HandleMark hm;
coleenp@4037 221 Klass* klass = receiver->klass();
coleenp@4037 222 InstanceKlass* ik = InstanceKlass::cast(klass);
duke@435 223 klassVtable* vt = ik->vtable();
coleenp@4037 224 ik->print();
jcoomes@1845 225 fatal(err_msg("bad compiled vtable dispatch: receiver " INTPTR_FORMAT ", "
jcoomes@1845 226 "index %d (vtable length %d)",
jcoomes@1845 227 (address)receiver, index, vt->length()));
duke@435 228 }
duke@435 229
duke@435 230 #endif // Product

mercurial